[wp-trac] [WordPress Trac] #57354: Backport: outline support for blocks via theme.json

WordPress Trac noreply at wordpress.org
Mon Dec 19 20:26:10 UTC 2022


#57354: Backport: outline support for blocks via theme.json
-------------------------------------------------+-------------------------
 Reporter:  onemaggie                            |       Owner:
                                                 |  hellofromTonya
     Type:  enhancement                          |      Status:  accepted
 Priority:  normal                               |   Milestone:  6.2
Component:  Themes                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests has-        |     Focuses:
  testing-info                                   |
-------------------------------------------------+-------------------------

Comment (by ironprogrammer):

 == Test Report

 Patch tested: https://github.com/WordPress/wordpress-
 develop/pull/3790.diff 👍🏻 LGTM!

 How great to have a backport so early in the cycle! 🙌🏻

 === Environment
 - Hardware: MacBook Pro Apple M1 Pro
 - OS: macOS 12.6.1
 - Browser: Safari 16.1
 - Server: nginx/1.23.2
 - PHP: 7.4.33
 - WordPress: 6.2-alpha-54642-src
 - Theme: twentytwentythree v1.0
 - Active Plugins:
  - gutenberg v14.8.0-rc.1 (tested both on 🟢 and off 🔴)

 === Actual Results
 - ✅ Before patch, outline rules applied to buttons in `theme.json` have
 no effect (expected).
 - ✅ After patch, outline and hover style appear as expected in both
 editor and frontend.

 === Additional Notes
 - TT3 updates applied to `trunk` with attachment:tt3-button-border-
 test.diff.

 === Supplemental Artifacts
 ''Before: Button blocks with "fill" and with "outline" styles -- outline
 in `theme.json` has no effect:''
 [[Image(https://cldup.com/L8mXiQFiJb.png, 300px)]]

 ''After patch: Button outline styles applied in `theme.json` appear as
 expected:''
 [[Image(https://cldup.com/5WwOd3mnG3.gif, 300px)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57354#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list