[wp-trac] [WordPress Trac] #52219: wp-emoji.js should always skip nodes with the `wp-exclude-emoji` CSS class

WordPress Trac noreply at wordpress.org
Fri Dec 16 04:34:39 UTC 2022


#52219: wp-emoji.js should always skip nodes with the `wp-exclude-emoji` CSS class
--------------------------+------------------------------
 Reporter:  GeorgeJipa    |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Emoji         |     Version:  4.2.2
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  javascript
--------------------------+------------------------------
Changes (by dd32):

 * keywords:  has-patch =>


Comment:

 I've run into this again, but this time on the WordPress.org Support
 forums now that [https://make.wordpress.org/support/2022/12/introducing-
 the-block-editor-in-the-support-forums/ we support the Block Editor for
 replies] and the emoji replacer is replacing emojis within the editor
 interface. Ideally.. it wouldn't.. as the emoji's should be replaced upon
 render, not upon save.

 [https://github.com/WordPress/wordpress-develop/pull/3774 PR #3774] is an
 attempt at resolving this, but it has a few shortcomings:
  - In order to make twemoji respect the `.wp-exclude-emoji` class on
 pageload, a patch to Twemoji is required.
  - Performance wise, this requires every emoji's parents to be iterated
 upon

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52219#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list