[wp-trac] [WordPress Trac] #57301: Emoji feature detection is incorrect

[WordPress Trac]

#57301: Emoji feature detection is incorrect
---------------------------+--------------------------------------
 Reporter:  sergiomdgomes  |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Emoji          |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:                 |     Focuses:  javascript, performance
---------------------------+--------------------------------------

Comment (by dmsnell):

 > I really didn't want to have to put in this amount of effort, but let's
 stop being hand-wavy, dig deep, and see what this "compatibility" really
 gets us.

 A shared sentiment! Though I wasn't at all trying to be hand-wavy, which
 is why I looked up specific versions, years they were released, and went
 through the effort the test in old browser versions. To reiterate, I'm not
 trying to make you pick one approach or another; all I wanted to do was
 uncover oddities that jumped out, and to provide a double-check that what
 we're doing is what we think we're doing. I know you're capable, because
 you consistently do great work; on my best days though I personally
 appreciate someone double-checking me and trying to make sure I'm doing
 what I think I am, which is where I'm coming from when sharing on this
 ticket.

 > First of all, your proposed patch produces a syntax error in both
 Firefox < 40 and Edge < 12 as-is.

 For example 😆 And thanks for noticing that - bad habits from working in
 other codebases.

 > As such, my research leads me to conclude that maintaining this level of
 compatibility brings absolutely no benefit in the real world today, that
 it's unlikely to bring any future benefit, and that it's thus merely a
 theoretical concern.

 I have zero problem with making these assessments, which is why I have
 tried to communicate multiple times that if it's not a problem then it's
 okay whatever we do, even suggesting breaking compatibility in order to
 make the input strings clearer //if that's the route we go//.

 > Core does not support those browsers

 This pretty much settles the compatibility question I think, right? Now if
 we don't have to break something, why do it, but if we've already drawn
 the line then I think that's all the justification needed to move on.

 Given that it seems like I might have unintentionally caused grief, which
 was not my intention, I think I'll just step away from this. Happy to
 clarify any of my points if you want, but I think everything I have to
 offer can be found in the thread of comments. Thanks for working on this
 issue!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57301#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform