[wp-trac] [WordPress Trac] #57139: Value type mismatch on is_site_meta_supported function

[WordPress Trac]

#57139: Value type mismatch on is_site_meta_supported function
--------------------------------+------------------------------
 Reporter:  lucascarvalhopl     |       Owner:  (none)
     Type:  defect (bug)        |      Status:  closed
 Priority:  normal              |   Milestone:  Awaiting Review
Component:  Networks and Sites  |     Version:  5.1
 Severity:  minor               |  Resolution:  invalid
 Keywords:  reporter-feedback   |     Focuses:  multisite
--------------------------------+------------------------------
Changes (by lucascarvalhopl):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Thank you for your review @SergeyBiryukov.

 As you've described, this is actually the intended behavior in this
 function, so I'll consider this as invalid.

 However, allow me to kindly disagree with this behavior as it can create
 some issues in some cases like
 [https://wordpress.stackexchange.com/questions/405649/the-wp-blogmeta-
 table-is-not-installed-please-run-the-network-database-upgrade this on
 StackExchange] or [https://wordpress.org/support/topic/not-creating-table-
 wp-blogmeta/ this on WP Support]. While it is actually more efficient and
 possibly safer for a well-designed plugin to do this check, fix the
 problem if it exists and set the option correctly.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57139#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform