[wp-trac] [WordPress Trac] #54504: Update Requests library to version 2.0.0

WordPress Trac noreply at wordpress.org
Fri Dec 9 20:27:59 UTC 2022


#54504: Update Requests library to version 2.0.0
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:
                                                 |  hellofromTonya
     Type:  task (blessed)                       |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  External Libraries                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  php80 php81 has-patch has-unit-      |     Focuses:
  tests early early-like-actually-early          |
-------------------------------------------------+-------------------------

Comment (by antonvlasenko):

 == Test Report

 Patch tested: https://github.com/WordPress/wordpress-develop/pull/3732

 === Environment
 * OS: macOS 12.6
 * Web Server: Apache
 * PHP: 8.1.9
 * WordPress: 6.1.1
 * Browser: Safari 16.1
 * Theme: Twenty Twenty-Two
 * Active Plugins:
   * fake-wordpress-update (see
 https://gist.github.com/hellofromtonya/bb0aa2d4b2311c8b40fa5ae8ada4dc19)

 === Steps to Test
 I've followed the test instructions outlined here:
 https://gist.github.com/hellofromtonya/bb0aa2d4b2311c8b40fa5ae8ada4dc19

 === Actual Results

 - ✅ Upgrade via the admin panel
 Everything works as expected.
 The files have been updated, no errors during the upgrade process.
 No errors on the frontend.
 - ❌ Upgrade via [https://wp-cli.org WP_CLI].
 I'm getting this console error:
 {{{
 PHP Fatal error:  Cannot declare class Requests_Cookie_Jar, because the
 name is already in use in /wp-includes/Requests/Cookie/Jar.php on  line 15
 }}}

 As I've learned during the debugging, this happens because the
 `Requests_Cookie_Jar ` class is declared in the `WP_CLI` script. To be
 more specific, in
 `phar:///path_to_the_wpi_cli_phar/vendor/rmccue/requests/library/Requests/Cookie/Jar.php`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54504#comment:96>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list