[wp-trac] [WordPress Trac] #3534: Hide password in setup-config.php

[WordPress Trac]

#3534: Hide password in setup-config.php
-------------------------------------------------+-------------------------
 Reporter:  xmarcos                              |       Owner:  rob1n
     Type:  enhancement                          |      Status:  reopened
 Priority:  low                                  |   Milestone:  Future
                                                 |  Release
Component:  Upgrade/Install                      |     Version:  2.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  testing-info                                   |  accessibility
-------------------------------------------------+-------------------------

Comment (by bgoewert):

 Completed a test report using @costdev's PR.


 Although, I wanted to also throw in that I agree with what @Clorith
 suggested about a consistent password reveal toggle that aligns with
 #9883. I submitted an additional PR  that combines changes from
 [https://github.com/WordPress/wordpress-develop/pull/2070 PR 2070] &
 [https://github.com/WordPress/wordpress-develop/pull/2071 PR 2071].

 Not sure if self-testing is allowed, but I also completed a test report
 for this as well. If someone else could test to verify that would be cool.

 == Test Report 1
 Using "old" patch.

 Patch tested: [https://github.com/WordPress/wordpress-develop/pull/2071 PR
 2071]

 === Environment
 * OS: Pop_OS! 22.04
 * Localhost: wordpress-develop & Docker Desktop
 * WordPress: trunk
 * Browser: Firefox 107, GNOME Web 43, Chrome 108
 * Theme: N/A
 * Active Plugins: N/A

 === Actual Results

 - ✅ "Password" field shows the "password" placeholder.
 - ✅️ Typing a password into the "Password" field is masked.
 - ✅️ Clicking the "Show" button reveals the un-masked password.
 - ✅️ "Show" button now reads "Hide".
 - ✅️ Clicking the "Hide" button masks the password again.

 === Additional Notes
 - My first test report!
 - This is an old PR. I don't know if this is correct, but before testing I
 locally merged trunk against the PR.

 == Test Report 2
 Using the patch I submitted.

 Patch tested: [https://github.com/WordPress/wordpress-develop/pull/3725 PR
 3725]

 === Environment
 * OS: Pop_OS! 22.04
 * Localhost: wordpress-develop & Docker Desktop
 * WordPress: trunk
 * Browser: Firefox 107, GNOME Web 43, Chrome 108
 * Theme: N/A
 * Active Plugins: N/A

 === Steps to test

 1. (Optional) Enable a password manager browser extension.
 2. (Optional) The password manager icon should not overlap the password
 visibility toggle.
 3. The "Password" field should display the "password" placeholder.
 4. Typing a password into the "Password" field should be masked.
 5. Clicking the password toggle should reveal the password and change the
 icon from [https://developer.wordpress.org/resource/dashicons/#visibility
 "dashicon-visibilty"] to
 [https://developer.wordpress.org/resource/dashicons/#hidden "dashicon-
 hidden"].
 6. Clicking the toggle again should mask the password and change the icon
 back to [https://developer.wordpress.org/resource/dashicons/#visibility
 "dashicon-visibilty"].

 === Actual Results

 - ✅️ Password manager icon does not overlap.
 - ✅️ "Password" field shows a "password" placeholder.
 - ✅️ The password is masked when entered.
 - ✅️ Clicking the toggle un-masks the password and changes the icon.
 - ✅️ Clicking the toggle again masks the password and changes the icon
 back.

 === Supplemental Artifacts
 Image showing that a password manager icon does not overlap the visibility
 toggle and that the password is properly masked.
 [[Image(https://i.imgur.com/I6tZotf.png)]]

 Image showing un-masked password and the different icon.
 [[Image(https://i.imgur.com/WafQiKJ.png)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/3534#comment:49>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform