[wp-trac] [WordPress Trac] #51857: Add rollback for failed plugin/theme updates

[WordPress Trac]

#51857: Add rollback for failed plugin/theme updates
-------------------------------------------------+-------------------------
 Reporter:  pbiron                               |       Owner:  pbiron
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.9
Component:  Upgrade/Install                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  early has-testing-info needs-patch   |     Focuses:
  needs-unit-tests                               |
-------------------------------------------------+-------------------------
Changes (by peterwilsoncc):

 * keywords:  early has-patch has-testing-info => early has-testing-info
     needs-patch needs-unit-tests


Comment:

 I'm seeing some bugs following [51815] on my local development
 environment:

 * Dev environment: [https://github.com/chassis/chassis Chassis]
 * Config file for Chassis at
 https://gist.github.com/peterwilsoncc/53c197cb5ef3e3dd9d649fb1d2069d0f
 * Replaced default `wp` directory with a checkout of the build server
 * Runs in sub-directory mode (ie, site url: wp-build.local/wp, home url:
 wp-build.local, content: wp-build.local/content)
 * Plugins installed pre test: User Switching (latest), Query Monitor
 (latest), Gutenberg (old, 11.1.0)

 When updating plugins that contain sub-directories (such as Gutenberg),
 the top level of the plugin extracts but none of the sub-directories
 contain files. See See [attachment:"Screen Shot 2021-09-23 at 10.55.44
 am.png"].

 I've tested with various workflows to update the plugins, most cause a
 fatal error after the update fails. The results of the various workflows
 are:

 Plugin screen
 * view version details, click install: Fails, stays active and triggers
 critical error
 * update now link: Fails, stays active and triggers critical error
 * checkbox, select update, apply: Fails, stays active and triggers
 critical error

 Update screen:
 * checkbox, click update plugins: fails, stays active and triggers
 critical error
 * view version details, click install: fails, deactivates.

 I've asked some other contributors to test on their local environments but
 the result is consistent for me with multiple plugins that contain a sub-
 directory structure using Chassis.

 There are some plugin tests with hello dolly but it would be good if
 something a little more complex could be tested against. It's probably a
 poor choice to include all of Gutenberg in the tests but something with a
 slightly more complex structure than dolly would be helpful.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51857#comment:128>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform