[wp-trac] [WordPress Trac] #51553: PHP 8.0: code improvements to allow for named parameters in function calls

[WordPress Trac]

#51553: PHP 8.0: code improvements to allow for named parameters in function calls
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:
                                                 |  hellofromTonya
     Type:  task (blessed)                       |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.9
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  php8 has-patch needs-codex early     |     Focuses:  coding-
  needs-dev-note commit                          |  standards
-------------------------------------------------+-------------------------

Comment (by hellofromTonya):

 In [changeset:"51790" 51790]:
 {{{
 #!CommitTicketReference repository="" revision="51790"
 Code Modernization: Fix parameter name mismatches for parent/child classes
 in `WP_Image_Editor::save()`.

 Renames the first parameter in `WP_Image_Editor_GD::save()` to match the
 parent's method signature.
 Why? PHP 8 introduces the ability to pass named arguments to
 function/method calls. This means the child and parent method signatures
 (i.e. parameter names) need to match.

 Adds @since to clearly specify why the change happened.

 Adds parameter descriptions to parent and both child classes.

 Follow-up to [22094], [22619], [30681].

 Props jrf, hellofromTonya, sergeybiryukov, azaozz, desrosj, johnbillion.
 See #51553.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51553#comment:51>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform