[wp-trac] [WordPress Trac] #39827: notice in wp-includes/canonical.php:392

[WordPress Trac]

#39827: notice in wp-includes/canonical.php:392
-------------------------------------------------+-------------------------
 Reporter:  jakubbis                             |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.9
Component:  Canonical                            |     Version:  4.7.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-unit-  |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * status:  closed => reopened
 * resolution:  invalid =>


Comment:

 It looks like there was some confusion during the bug scrub, as someone
 thought the problem is already solved in [source:tags/5.8.1/src/wp-
 includes/canonical.php?marks=83-85#L78 lines 83-85 of canonical.php].

 However, that part was introduced in [9506] and adjusted in [13866]. It
 already existed when this ticket was created. The patch here touches a
 different area of the code, after the `parse_url()` call in
 [source:tags/5.8.1/src/wp-includes/canonical.php?marks=568#L566 line 568]
 further down.

 The ticket still seems valid. Reopening for additional review.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/39827#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform