[wp-trac] [WordPress Trac] #52534: PHP 8: wp_localize_script() throws a warning if third parameter is a string.

WordPress Trac noreply at wordpress.org
Mon Feb 22 16:08:41 UTC 2021


#52534: PHP 8: wp_localize_script() throws a warning if third parameter is a
string.
-------------------------------------------------+-------------------------
 Reporter:  peterwilsoncc                        |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.7
Component:  Script Loader                        |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  php8 has-patch has-unit-tests dev-   |     Focuses:
  reviewed commit                                |
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => reviewing


Comment:

 Replying to [comment:14 jrf]:
 > Just checking: is there any specific keyword I need to add for the
 "second committer sign-off"? I can't seem to find the docs about it.

 `dev-reviewed` is the one, as described in
 [https://make.wordpress.org/core/handbook/contribute/trac/keywords/ Trac
 Workflow Keywords]. Thanks!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52534#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list