[wp-trac] [WordPress Trac] #52566: wp_resource_hints() test failures when removing $pagenow global from get_home_url()

WordPress Trac noreply at wordpress.org
Sat Feb 20 09:54:04 UTC 2021


#52566: wp_resource_hints() test failures when removing $pagenow global from
get_home_url()
----------------------------+-----------------------------
 Reporter:  SergeyBiryukov  |       Owner:  SergeyBiryukov
     Type:  defect (bug)    |      Status:  closed
 Priority:  normal          |   Milestone:  5.8
Component:  General         |     Version:
 Severity:  normal          |  Resolution:  fixed
 Keywords:                  |     Focuses:
----------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"50393" 50393]:
 {{{
 #!CommitTicketReference repository="" revision="50393"
 Script Loader: Explicitly declare the `$pagenow` global in
 `wp_deregister_script()`.

 This avoids an "Undefined index" PHP notice in `wp_resource_hints()` tests
 when running the full test suite.

 Remove the unused global from `get_home_url()`.

 Follow-up to [25443], [38100], [38174], [50156], [50164].

 Props peterwilsoncc.
 Fixes #52566.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52566#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list