[wp-trac] [WordPress Trac] #20683: WP_Dependencies' constructor should accept a string/array value for $deps rather than converting a string to an empty array

WordPress Trac noreply at wordpress.org
Wed Sep 30 20:13:43 UTC 2020


#20683: WP_Dependencies' constructor should accept a string/array value for $deps
rather than converting a string to an empty array
-------------------------------------------------+-------------------------
 Reporter:  vhauri                               |       Owner:
                                                 |  markjaquith
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Script Loader                        |     Version:  2.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch close 2nd-opinion needs-   |     Focuses:
  refresh                                        |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  has-patch dev-feedback => has-patch close 2nd-opinion needs-
     refresh
 * version:   => 2.6
 * milestone:   => Awaiting Review


Comment:

 The latest patch needs a refresh against current `trunk`.

 I'm also considering just closing this out as `wontfix`. `WP_Depenencies`
 was introduced in 2.6, and specifying dependencies in array format when
 using `wp_enqueue_script()`/`wp_enqueue_style()` is now such a common
 practice that I don't know that the benefit of this change still exists.

 Marking `close`/`2nd-opinion` for others to weigh in.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/20683#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list