[wp-trac] [WordPress Trac] #50639: [PHP 8] Add @requires annotations for PHPUnit tests that assert engine-enforced constraints

WordPress Trac noreply at wordpress.org
Wed Sep 30 12:07:28 UTC 2020


#50639: [PHP 8] Add @requires annotations for PHPUnit tests that assert engine-
enforced constraints
------------------------------------------+-----------------------------
 Reporter:  ayeshrajans                   |       Owner:  SergeyBiryukov
     Type:  defect (bug)                  |      Status:  closed
 Priority:  normal                        |   Milestone:  5.6
Component:  Build/Test Tools              |     Version:
 Severity:  normal                        |  Resolution:  fixed
 Keywords:  php8 has-patch needs-refresh  |     Focuses:
------------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 In [changeset:"49072" 49072]:
 {{{
 #!CommitTicketReference repository="" revision="49072"
 Code Modernization: Return `false` from `wpdb::query()` if the query was
 filtered to an empty string using the `query` filter.

 This avoids a fatal error on PHP 8 caused by passing an empty string to
 `mysqli_query()`, and maintains the current behaviour.

 Follow-up to [48980], [48981].

 See #50913, #50639.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50639#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list