[wp-trac] [WordPress Trac] #45880: edit-form-blocks.php shows Warning when $editor_styles include blank element.

[WordPress Trac]

#45880: edit-form-blocks.php shows Warning when $editor_styles include blank
element.
---------------------------+------------------------------
 Reporter:  atachibana     |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Bundled Theme  |     Version:  5.0.2
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+------------------------------
Changes (by noisysocks):

 * component:  Editor => Bundled Theme


Comment:

 Thanks for reporting this @atachibana! I wasn't able to reproduce this by
 setting my language to Japanese, but I agree there's a logic error in the
 code you linked to.

 Instead of checking that the string exists in `edit-form-blocks.php`, I
 think we should instead patch Twenty Seventeen so that it doesn't pass an
 array containing an empty string to `add_editor_style()`.

 [attachment:"45880.diff"] demonstrates what I mean.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45880#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform