[wp-trac] [WordPress Trac] #51254: includes/plugin.php remove_menu_page should check if $menu is array

WordPress Trac noreply at wordpress.org
Sat Sep 5 20:02:03 UTC 2020


#51254: includes/plugin.php remove_menu_page should check if $menu is array
----------------------------+----------------------
 Reporter:  kernelzechs     |       Owner:  (none)
     Type:  defect (bug)    |      Status:  closed
 Priority:  normal          |   Milestone:
Component:  Administration  |     Version:
 Severity:  normal          |  Resolution:  wontfix
 Keywords:                  |     Focuses:
----------------------------+----------------------
Changes (by kernelzechs):

 * status:  reopened => closed
 * resolution:   => wontfix


Comment:

 Reading through more, it seems like the usage of this function outside of
 admin_menu is ill-advised though recommended by some for certain reasons.
 However, I looked into gating this in an elegant way while still retaining
 functionality you all desire, but it would take some rearchitecting. We
 can leave this alone for now, but I recommend looking into something to
 resolve these weird behaviors with hooks in the future.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51254#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list