[wp-trac] [WordPress Trac] #51665: wp_get_image_editor() ->save stopped creating the directory in 5.6-beta2-49360

[WordPress Trac]

#51665: wp_get_image_editor() ->save stopped creating the directory in
5.6-beta2-49360
---------------------------------------------+--------------------------
 Reporter:  eemitch                          |       Owner:  johnbillion
     Type:  defect (bug)                     |      Status:  closed
 Priority:  normal                           |   Milestone:  5.6
Component:  Media                            |     Version:  5.6
 Severity:  normal                           |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests commit  |     Focuses:
---------------------------------------------+--------------------------

Comment (by p00ya):

 FYI I've tested with 5.6-beta4, the gcs-media-plugin and a directory that
 didn't previously exist. Works and thanks for the fix.

 However, the patch in this ticket does not affect the `wp_is_stream`
 branch of the if statement.  While the particular stream wrappers I've
 been testing with don't need parent directories of a new file to be
 created first, other stream wrappers might.  `file_put_contents` won't
 implicitly create directories either.  So we might want to move the
 `wp_mkdir_p` up above the `if()`.  Also note this won't be a regression
 (because no streams would have worked prior to 5.6), so I think it's fine
 to fix in 5.7.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51665#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform