[wp-trac] [WordPress Trac] #51815: Make the URL translatable in wp-admin/includes/class-wp-site-health.php

WordPress Trac noreply at wordpress.org
Wed Nov 18 15:13:40 UTC 2020


#51815: Make the URL translatable in wp-admin/includes/class-wp-site-health.php
-------------------------------------------+-----------------------------
 Reporter:  tai                            |       Owner:  SergeyBiryukov
     Type:  defect (bug)                   |      Status:  reopened
 Priority:  normal                         |   Milestone:  5.6
Component:  Site Health                    |     Version:  trunk
 Severity:  normal                         |  Resolution:
 Keywords:  has-patch commit dev-feedback  |     Focuses:
-------------------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * keywords:  has-patch needs-refresh => has-patch commit dev-feedback
 * status:  closed => reopened
 * version:  5.5 => trunk
 * resolution:  fixed =>


Comment:

 Reopening for backporting to the 5.6 branch after a second committer's
 review.

 All the other DevHub reference links in `wp-admin` are translatable at a
 glance, so this brings some consistency.

 This is a new URL added in [49334], changing the version accordingly.

 Haven't refreshed the tab before committing, and didn't see the suggestion
 about the numbered placeholders :) We do indeed prefer numbered
 placeholders in translatable strings if there is more than one
 placeholder, per #19090 and some other tickets. If the string with
 multiple placeholders is not translatable (as is the case here), I don't
 have strong feelings either way.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51815#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list