[wp-trac] [WordPress Trac] #51580: Application Passwords: Accessibility Improvements

[WordPress Trac]

#51580: Application Passwords: Accessibility Improvements
------------------------------------+--------------------------------------
 Reporter:  georgestephanis         |       Owner:  TimothyBlynJacobs
     Type:  defect (bug)            |      Status:  reopened
 Priority:  normal                  |   Milestone:  5.6
Component:  Login and Registration  |     Version:  trunk
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch               |     Focuses:  accessibility, rest-api
------------------------------------+--------------------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:43 alexstine]:
 > There are 2 more issues.
 >
 > 1. The aria-describedby takes an ID, not an actual description.
 > 2. I have removed the placeholder text and put it in a <p> with
 class="description".
 >
 > I am attaching my patch.

 Thanks for the patch! Some quick notes:

 * Splitting `: not required to update profile` into a new string is not
 friendly for translators, this should be a single string with the full
 sentence for better context.
 * `esc_attr_e()` should be replaced with `_e()`, as the string is no
 longer in an attribute.
 * The same placeholder is also used in `wp-admin/authorize-
 application.php`, so removing it in this one instance would be
 inconsistent. There are also some placeholder in other areas of core, so
 I'm not sure whether that's an issue, as long as the associated field is
 properly described.

 [attachment:"51580.diff"] corrects the `aria-describedby` attribute.

 @TimothyBlynJacobs: Thanks for the review! Do you have an opinion on
 removing the `.screen-reader-text` class here and making this description
 visible for everyone? I think that brings some additional clarity :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51580#comment:47>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform