[wp-trac] [WordPress Trac] #50870: Auto-update counts do not update when bulk deleting

WordPress Trac noreply at wordpress.org
Thu Nov 5 23:55:08 UTC 2020


#50870: Auto-update counts do not update when bulk deleting
-------------------------------------------------+-------------------------
 Reporter:  desrosj                              |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.6
Component:  Plugins                              |     Version:  5.5
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots needs-     |     Focuses:
  testing                                        |  administration
-------------------------------------------------+-------------------------
Changes (by pbiron):

 * keywords:  has-patch has-screenshots => has-patch has-screenshots needs-
     testing


Comment:

 [attachment:"50870.2.diff"] incorporates [attachment:"50870.diff"] and
 extends the solution there so that it works on the multisite themes
 screen.

 Please test this patch **very carefully** because in order to get it to
 work on the themes screen I had to change the data that is passed to the
 JS (via `wp_localize_script()` in
 `WP_MS_Themes_List_Table::prepare_items()`).

 In 5.5, only the counts of themes in each status (e.g., `disabled`,
 'upgrade`, etc) was passed to the JS; whereas
 `WP_Plugins_List_Table::prepare_items()` passes an array of plugins with
 each status.  This patch does the same for themes...and the JS in
 `wp.updates.deleteThemeSuccess()` has been adjusted accordingly.

 The patch also updates the DocBlock at the head of the JS to mention
 `settings.{plugins,themes}['auto-update-{enabled,disabled}']` which was
 never done in 5.5.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50870#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list