[wp-trac] [WordPress Trac] #51961: Twenty Twenty-One: full stop might be in wrong place

[WordPress Trac]

#51961: Twenty Twenty-One: full stop might be in wrong place
---------------------------+----------------------
 Reporter:  wangql         |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  5.6.1
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  ui-copy
---------------------------+----------------------

Comment (by markscottrobson):

 Replying to [comment:7 SergeyBiryukov]:
 > Hi there, welcome back to WordPress Trac! Thanks for the report.
 >
 > Crossposting [comment:4:ticket:51965 my comment] from #51965.
 >
 > As noted above, "Learn more about Dark Mode." is a complete sentence, so
 I think the full stop is in the correct place here.
 >
 > This is consistent with some other strings in core, for example:
 >
 > * [source:branches/5.6/src/wp-admin/update-core.php?marks=1011#L1008
 "Check again" link] on WordPress Updates screen:
 > {{{
 > <a href="' ... '">' . __( 'Check again.' ) . '</a>'
 > }}}
 > * [source:branches/5.6/src/wp-admin/includes/class-wp-plugins-list-
 table.php?marks=414#L400 "Search for plugins" link] on the Plugins screen:
 > {{{
 > <a href=" ... '">' . __( 'Search for plugins in the WordPress Plugin
 Directory.' ) . '</a>'
 > }}}
 >
 > A similar conversation was also
 [https://wordpress.slack.com/archives/C02RQBWTW/p1605230518264800 on Slack
 after 5.6 beta 4]:
 >
 >  yui 04:21
 >  `<a href="%s">Switch to automatic updates for maintenance and security
 releases only.</a>`
 >  is it really meant to have dot before `</a>`?
 >  helen 04:25
 >  It’s the entire line, so yes.
 >
 > That said, this appears to be not a hard and fast rule, there are some
 other arguments and considerations:
 > https://ux.stackexchange.com/questions/17331/should-a-full-sentence-
 html-link-include-the-period-in-the-linked-text
 >
 > Ideally, if any changes should be made, we'd like to be consistent with
 this in core and bundled themes.
 >
 > Marking this with the `ui-copy` focus for a native English speaker to
 chime in :)

 As a native UK English speaker, I would suggest that the text should be
 hyperlinked and not the punctuation. Most style guides would support this.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51961#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform