[wp-trac] [WordPress Trac] #38009: #reply-title.comment-reply-title not updating when replying to an individual

[WordPress Trac]

#38009: #reply-title.comment-reply-title not updating when replying to an
individual
--------------------------+----------------------------
 Reporter:  iguel         |       Owner:  isabel_brison
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  5.5.1
Component:  Comments      |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+----------------------------
Changes (by johannadevos):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I tried testing https://core.trac.wordpress.org/changeset/48876 in the
 5.5.1 RC.
 In `comments.php` in my theme (Twenty Twenty), I replaced:
 `title_reply_before' => '<h2 id="reply-title" class="comment-reply-
 title">',` with:
 `'title_reply_before' => '<h2>',`.

 In other words, I removed the `"reply-title"` id attribute, so that in
 `comment-reply.js` the `commentReplyTitleId` would be undefined.

 To test, I opened the console and replied to a comment on a post. That
 leads to the following error:
 `Uncaught TypeError: Cannot read property 'nodeType' of null` on line 340
 of `comment-reply.js` (concerning `replyHeadingTextNode.nodeType`).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/38009#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform