[wp-trac] [WordPress Trac] #51123: commonL10n removed without backwards compatibility

WordPress Trac noreply at wordpress.org
Tue Aug 25 23:00:14 UTC 2020


#51123: commonL10n removed without backwards compatibility
---------------------------+-----------------------------
 Reporter:  kbjohnson90    |       Owner:  SergeyBiryukov
     Type:  defect (bug)   |      Status:  reviewing
 Priority:  normal         |   Milestone:  5.5.1
Component:  Script Loader  |     Version:  5.5
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  javascript
---------------------------+-----------------------------

Comment (by peterwilsoncc):

 @TimothyBlynJacobs `defineProperty` is unavailable in IE11, whereas
 `__defineGetter__` is.

 Given the latter is deprecated, it might be preferable to use some
 conditional code in a wrapper to prevent errors if any browsers hard
 deprecate the function.

 Reviewing other deprecated JavaScript code, the functionality is generally
 labelled as such in the docblocks but there isn't an equivalent of PHP's
 `_doing_it_wrong()` for JavaScript.

 In my view, adding such a function is best left for another ticket.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51123#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list