[wp-trac] [WordPress Trac] #50961: Fix missing ref array in pre_get_users

WordPress Trac noreply at wordpress.org
Tue Aug 18 12:41:45 UTC 2020


#50961: Fix missing ref array in pre_get_users
--------------------------+------------------------------
 Reporter:  andy          |       Owner:  adamsilverstein
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  5.6
Component:  Users         |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------------------
Changes (by SergeyBiryukov):

 * keywords:  needs-patch good-first-bug => has-patch
 * status:  closed => reopened
 * resolution:  invalid =>


Comment:

 I believe the change should still be made, not for functional difference
 but just for consistency with the other actions:

 * `do_action_ref_array( 'pre_get_comments', array( &$this ) );`
 * `do_action_ref_array( 'pre_get_networks', array( &$this ) );`
 * `do_action_ref_array( 'pre_get_posts', array( &$this ) );`
 * `do_action_ref_array( 'pre_get_sites', array( &$this ) );`
 * `do_action_ref_array( 'pre_user_query', array( &$this ) );`

 [attachment:50961.diff] updates both `pre_get_terms` and `pre_get_users`
 to match.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50961#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list