[wp-trac] [WordPress Trac] #49945: PHP 7.4+ notice in getid3_mp3::MPEGaudioHeaderValid()

[WordPress Trac]

#49945: PHP 7.4+ notice in getid3_mp3::MPEGaudioHeaderValid()
--------------------------------+-----------------------------
 Reporter:  schlessera          |       Owner:  SergeyBiryukov
     Type:  defect (bug)        |      Status:  reopened
 Priority:  normal              |   Milestone:  5.5
Component:  External Libraries  |     Version:
 Severity:  normal              |  Resolution:
 Keywords:                      |     Focuses:
--------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 [47601] caused some failures on Travis:
 {{{
 Deprecated: Function get_magic_quotes_runtime() is deprecated in
 /var/www/build/wp-includes/ID3/getid3.php on line 303
 Deprecated: Function get_magic_quotes_gpc() is deprecated in
 /var/www/build/wp-includes/ID3/getid3.php on line 309
 Deprecated: Function get_magic_quotes_runtime() is deprecated in
 /var/www/build/wp-includes/ID3/getid3.php on line 303
 Deprecated: Function get_magic_quotes_gpc() is deprecated in
 /var/www/build/wp-includes/ID3/getid3.php on line 309
 }}}


 Those lines have a `version_compare(PHP_VERSION, '7.4.0', '<')` check
 above them, but for some reason are still executed in the PHP 7.4 job on
 Travis. It looks like `php --version` on all jobs reports `PHP 7.2.15`.

 Those lines were previously commented out in [46113], but that was
 reverted in [47601] as seemingly not necessary with the
 `version_compare()` check brought from upstream.

 I guess we'll have to comment them out again for the time being, until we
 figure out why `version_compare()` doesn't work.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49945#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform