[wp-trac] [WordPress Trac] #49922: PHP Compatibility fixes for 5.5

[WordPress Trac]

#49922: PHP Compatibility fixes for 5.5
----------------------------+-------------------------------
 Reporter:  desrosj         |       Owner:  desrosj
     Type:  task (blessed)  |      Status:  assigned
 Priority:  normal          |   Milestone:  5.5
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:  coding-standards
----------------------------+-------------------------------

Comment (by desrosj):

 This is the current result of running `composer run compat` locally on
 `trunk`:


 {{{
 PHP CODE SNIFFER REPORT SUMMARY
 ----------------------------------------------------------------------
 FILE                                                  ERRORS  WARNINGS
 ----------------------------------------------------------------------
 src/xmlrpc.php                                        5       0
 src/wp-admin/includes/class-ftp.php                   0       1
 src/wp-admin/includes/schema.php                      0       1
 src/wp-includes/capabilities.php                      1       0
 src/wp-includes/class-phpmailer.php                   5       4
 src/wp-includes/class-pop3.php                        0       2
 src/wp-includes/class-simplepie.php                   0       2
 src/wp-includes/class-snoopy.php                      0       14
 src/wp-includes/cron.php                              0       1
 src/wp-includes/functions.php                         0       1
 src/wp-includes/load.php                              0       1
 src/wp-includes/plugin.php                            0       3
 src/wp-includes/rss.php                               0       2
 src/wp-includes/ID3/getid3.lib.php                    1       0
 src/wp-includes/ID3/getid3.php                        0       4
 src/wp-includes/ID3/module.audio-video.quicktime.php  1       0
 src/wp-includes/IXR/class-IXR-server.php              3       0
 src/wp-includes/pomo/streams.php                      0       1
 src/wp-includes/rest-api/class-wp-rest-server.php     4       0
 src/wp-includes/SimplePie/File.php                    0       1
 src/wp-includes/SimplePie/Item.php                    0       1
 ...-includes/sodium_compat/lib/php72compat_const.php  15      0
 src/wp-includes/sodium_compat/src/Compat.php          3       0
 ----------------------------------------------------------------------
 A TOTAL OF 38 ERRORS AND 39 WARNINGS WERE FOUND IN 23 FILES
 ----------------------------------------------------------------------

 Time: 372ms; Memory: 10MB


 PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
 ----------------------------------------------------------------------
 SOURCE                                                           COUNT
 ----------------------------------------------------------------------
 PHPCompatibility.FunctionUse.RemovedFunctions.eachDeprecated     14
 PHPCompatibility.Variables.RemovedPredefinedGlobalVariables.htt  12
 PHPCompatibility.IniDirectives.RemovedIniDirectives.safe_modeDe  8
 PHPCompatibility.FunctionUse.ArgumentFunctionsReportCurrentValu  5
 PHPCompatibility.IniDirectives.RemovedIniDirectives.mbstring_fu  5
 PHPCompatibility.FunctionUse.RemovedFunctions.set_magic_quotes_  2
 PHPCompatibility.IniDirectives.RemovedIniDirectives.magic_quote  2
 PHPCompatibility.IniDirectives.RemovedIniDirectives.zend_ze1_co  2
 PHPCompatibility.Lists.AssignmentOrder.Affected                  2
 PHPCompatibility.Variables.RemovedPredefinedGlobalVariables.php  2
 PHPCompatibility.Constants.NewConstants.php_int_minFound         1
 PHPCompatibility.Constants.NewConstants.sodium_crypto_kdf_bytes  1
 PHPCompatibility.Constants.NewConstants.sodium_crypto_kdf_bytes  1
 PHPCompatibility.Constants.NewConstants.sodium_crypto_kdf_conte  1
 PHPCompatibility.Constants.NewConstants.sodium_crypto_kdf_keyby  1
 PHPCompatibility.Constants.NewConstants.sodium_crypto_kx_keypai  1
 PHPCompatibility.Constants.NewConstants.sodium_crypto_kx_sessio  1
 PHPCompatibility.Constants.NewConstants.sodium_crypto_pwhash_sc  1
 PHPCompatibility.Constants.NewConstants.sodium_crypto_pwhash_sc  1
 PHPCompatibility.Constants.NewConstants.sodium_crypto_pwhash_sc  1
 PHPCompatibility.Constants.NewConstants.sodium_crypto_pwhash_sc  1
 PHPCompatibility.Constants.NewConstants.sodium_crypto_pwhash_sc  1
 PHPCompatibility.Constants.NewConstants.sodium_crypto_pwhash_sc  1
 PHPCompatibility.Constants.NewConstants.sodium_library_major_ve  1
 PHPCompatibility.Constants.NewConstants.sodium_library_minor_ve  1
 PHPCompatibility.Constants.NewConstants.sodium_library_versionF  1
 PHPCompatibility.FunctionUse.NewFunctions.sodium_crypto_sign_ke  1
 PHPCompatibility.FunctionUse.NewFunctions.sodium_padFound        1
 PHPCompatibility.FunctionUse.NewFunctions.sodium_unpadFound      1
 PHPCompatibility.FunctionUse.RemovedFunctions.dlDeprecated       1
 PHPCompatibility.FunctionUse.RemovedFunctions.get_magic_quotes_  1
 PHPCompatibility.IniDirectives.RemovedIniDirectives.register_gl  1
 PHPCompatibility.ParameterValues.NewIDNVariantDefault.NotSet     1
 ----------------------------------------------------------------------
 A TOTAL OF 77 SNIFF VIOLATIONS WERE FOUND IN 33 SOURCES
 ----------------------------------------------------------------------
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49922#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform