[wp-trac] [WordPress Trac] #47138: Visible labelling only done via placeholder attribute

[WordPress Trac]

#47138: Visible labelling only done via placeholder attribute
-------------------------------------------------+-------------------------
 Reporter:  anevins                              |       Owner:  audrasjb
     Type:  task (blessed)                       |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.3
Component:  Media                                |     Version:
 Severity:  minor                                |  Resolution:
 Keywords:  has-screenshots wpcampus-report      |     Focuses:  ui,
  form-controls has-patch dev-feedback           |  accessibility
-------------------------------------------------+-------------------------

Comment (by afercia):

 Thanks @audrasjb. Quickly reviewed, spotted a few things:
 - There are a couple of JS errors: run `grunt jshint` or `grunt
 jshint:media` to see them (unused l10n variable and a comma to remove).
 - Not sure we should remove the existing strings `searchMediaLabel` and
 `searchMediaPlaceholder`: there's a chance plugins are using them for any
 custom things they add to the media views. I'd rather introduce a new
 string.
 - On smaller viewports and in the media modal (test with the Classic
 Editor) there's not enough room for the visible label (see screenshots
 below). The CSS should be adjusted a bit. Note that the current CSS is a
 bit tricky especially for the modal :(

 Worth noting the media modal responsiveness is far from ideal even on
 current WordPress 5.2 and in all previous versions. At some point on
 smaller viewports some elements get completely hidden (float drop).
 However, this is a pre-existing issue that is out of the scope of this
 ticket.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47138#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform