[wp-trac] [WordPress Trac] #47367: KSES: Update CSS properties considered safe for all users.

WordPress Trac noreply at wordpress.org
Sat Sep 21 03:37:27 UTC 2019


#47367: KSES: Update CSS properties considered safe for all users.
-------------------------------------------------+-------------------------
 Reporter:  peterwilsoncc                        |       Owner:  marybaum
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.3
Component:  Editor                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-refresh 2nd-opinion  |     Focuses:
  needs-unit-tests                               |
-------------------------------------------------+-------------------------

Comment (by peterwilsoncc):

 Flex and columns support are good to go. Grid I am in two minds about.

 Attachment with tests incoming.

 ----

 `grid`, `grid-row`, `grid-column` and `grid-template-*` each accept
 brackets, eg `repeat( 6, 1fr )` which are blocked in KSES. `grid`
 additionally accepts `\` which KSES doesn't like in CSS either.

 This was done in #10336 back in the days of the browser wars, CSS hacks,
 and IE6 support. @azaozz do you remember the nastiness you were trying to
 avoid?

 None of the characters `\()` are required for CSS Grid but rather nice to
 haves. As a result I am not sure if this is good to go with documentation
 informing users that some grid attributes have limited support or whether
 it is better to hold off until the next release:

 * `repeat( 6, 1fr )` can be worked around
 * `minmax( 1fr, 700px )` less so

 As the block editor already uses `grid-template-columns`, I'm leaning
 towards merge and document.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47367#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list