[wp-trac] [WordPress Trac] #34904: The design of the focus outline on buttons/elements could be improved

[WordPress Trac]

#34904: The design of the focus outline on buttons/elements could be improved
-------------------------------------------------+-------------------------
 Reporter:  michaelarestad                       |       Owner:  audrasjb
     Type:  enhancement                          |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.3
Component:  Administration                       |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  color-contrast blessed wpcampus-     |     Focuses:  ui,
  report has-patch has-screenshots needs-dev-    |  accessibility
  note commit                                    |
-------------------------------------------------+-------------------------

Comment (by kjellr):

 Uploaded a fresh version. This one makes sure the alternate color schemes
 follow these new styles, for both the new button styles and the focus
 borders:

 [[Image(https://cldup.com/HRCTIWkq9U.gif)]]

 A note about that: Not all of the alternate button styles pass contrast
 tests. But they didn't before, so I think we're fine? Seems like a
 separate issue, and one that should be considered separately.

 This also fixes an issue where the active toggle button wasn't very
 noticeable. Should be a bit better now:

 [[Image(https://cldup.com/V2FGDIE28i-1200x1200.png)]]

 This patch is getting pretty large, but I ''think'' it covers everything
 it needs to.

 The `buttons.css` file header suggests to edit `editor.css` as well. I see
 that file contains some TinyMCE buttons, but I can't find any of them in
 use, so I'm hesitant to make any changes. I checked the classic editor and
 it seems to be fine as is. If anyone knows where those are, and can fix
 them, that would be excellent. Otherwise, I think this is just ready for
 some solid, thorough testing.

 That's probably my last patch in this thread for the day, so feel free to
 update and build on the patch if anyone finds bugs! Thanks.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/34904#comment:60>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform