[wp-trac] [WordPress Trac] #46152: Add PHPCompatibility checks to test suite

[WordPress Trac]

#46152: Add PHPCompatibility checks to test suite
-------------------------------------+-------------------------------
 Reporter:  desrosj                  |       Owner:  (none)
     Type:  task (blessed)           |      Status:  new
 Priority:  normal                   |   Milestone:  5.3
Component:  Build/Test Tools         |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  coding-standards
-------------------------------------+-------------------------------

Comment (by desrosj):

 @jrf Thanks for all of the detailed feedback!

 [attachment:"46152.3.diff"] is refresh with this round of feedback
 applied. Here are some notes:

 - I changed the commands to contain the `@php` prefix. #47853 was already
 open with this suggestion and the change for other commands landed in
 [46187].
 - `class-snoopy.php`: I have removed the exclusion. I looked back at when
 PHP 7.2 support was tackled, and it
 [https://core.trac.wordpress.org/ticket/40109#comment:24 appears the
 decision was made to skip this file] because the file is deprecated. If
 you feel the level of effort is low for this, I have no strong feelings
 against fixing this. Let's open a new ticket to tackle that.
 - I added a `compat:detailed` script to easily display a full report.
 - I moved the command-line directives into the configuration file. I will
 have a follow up patch shortly for the other commands to commit
 separately.
 - For the double underscore functions, let's open a separate ticket for
 discussion and feedback.

 Moving forward, I think individual tickets for like compatibility updates
 may be best to ensure each gets properly tested.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46152#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform