[wp-trac] [WordPress Trac] #37392: Multisite "Sites" screen: Add links to filter websites by status

[WordPress Trac]

#37392: Multisite "Sites" screen: Add links to filter websites by status
-------------------------------------------------+-------------------------
 Reporter:  thomaswm                             |       Owner:  mnelson4
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.3
Component:  Networks and Sites                   |     Version:  3.0
 Severity:  normal                               |  Resolution:
 Keywords:  needs-unit-tests has-patch needs-    |     Focuses:  multisite
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by pbiron):

 Replying to [comment:43 pbiron]:
 > 2. even with  number 1 fixed, reusing the `WP_Site_Query()` object seems
 to cause problems.  Not sure if it's a bug in `WP_Site_Query::query()` or
 whether it's just not intended to be reused like that.  But
 `WP_Site_Query::$sql_clauses['where']` doesn't get reinitialized between
 repeated calls to `WP_Site_Query::query()`, which results in the query for
 `archive = 1` to actually be `public = 1 AND archived = 1`

 Related: #48078

 I opened another ticket to report the problem with calling
 `WP_Site_Query::query()` in a loop.  Turns out that a couple of the other
 `WP_XXX_Query` classes have the same problem (and a couple don't).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/37392#comment:49>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform