[wp-trac] [WordPress Trac] #42888: Add a "Show" button next to password fields on mobile

[WordPress Trac]

#42888: Add a "Show" button next to password fields on mobile
-------------------------------------+-------------------------------------
 Reporter:  johnbillion              |       Owner:  afercia
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.3
Component:  Login and Registration   |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-           |     Focuses:  accessibility,
  screenshots has-ux-feedback        |  javascript
-------------------------------------+-------------------------------------
Changes (by afercia):

 * keywords:  has-patch has-screenshots has-ux-feedback needs-refresh =>
     has-patch has-screenshots has-ux-feedback


Comment:

 [attachment:"42888.4.diff"] refreshes and slightly improves the patch
 after the several changes in [45673].

 Notes:
 - The patch (as the previous ones) adds the button also on Desktop.
 - When LastPass (password manager) is used, the LastPass icon overlies the
 button: this happens with all the input fields and there's nothing we can
 do about this. I'd tend to think its a LastPass responsibility.

 Some testing would be nice :) Please test:
 - the user new / user edit / user profile pages
 - the login page
 - the install page > step 1
 - the reset password page
 - am I missing something to test?

 Note:
 I think the `.password-input-wrapper` element can be removed from
 anywhere. Seems to me it was only used by `validateForm()` when submitting
 an empty password field. See [34068] / #33406. Basically the form can't be
 submitted with an empty password field any longer so I think the wrapper
 element and the related CSS can be removed.

 @SergeyBiryukov when you have a chance: can you confirm this please? I'd
 greatly appreciate your review.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42888#comment:45>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform