[wp-trac] [WordPress Trac] #25473: wp_text_diff creates wrong number of columns if title arguments are set

[WordPress Trac]

#25473: wp_text_diff creates wrong number of columns if title arguments are set
---------------------------------------+------------------------------
 Reporter:  joedolson                  |       Owner:  adamsilverstein
     Type:  defect (bug)               |      Status:  assigned
 Priority:  normal                     |   Milestone:  5.3
Component:  Revisions                  |     Version:  3.6.1
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:  accessibility
---------------------------------------+------------------------------

Comment (by afercia):

 @adamsilverstein thanks for reviewing. Those "visible labels" aren't just
 text. They are, respectively:
 - $args['title'] -> `<caption>` element
 - title_left and title_right -> `<th>` table headers

 As such they contribute to provide proper semantic information for the
 table. This is a data table and table headers are ''required'' to clarify
 what the data within the columns are. It's not just a visual thing :) and
 I wouldn't recommend to remove them.

 No objections if you think a new design is necessary. However, the new
 design should respect web standards and accessibility constraints in order
 to provide semantic HTML and good level of accessibility (with visible
 table headers).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/25473#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform