[wp-trac] [WordPress Trac] #47681: Critical error handler needs to offer backup troubleshooting instructions in addition to email

[WordPress Trac]

#47681: Critical error handler needs to offer backup troubleshooting instructions
in addition to email
-------------------------------------+-----------------------------
 Reporter:  tobifjellner             |       Owner:  SergeyBiryukov
     Type:  enhancement              |      Status:  closed
 Priority:  normal                   |   Milestone:  5.3
Component:  Site Health              |     Version:  5.2
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:10 garrett-eclipse]:
 > checking the changeset I noticed the external link icon, security
 noopener and accessibility text were all dropped. Was that intentional?

 Thanks for bringing this up, I should have left a comment :)

 In my testing by causing a fatal error in a plugin, neither Dashicons font
 nor `.screen-reader-text` styles were loaded, so `(opens in a new tab)`
 was displayed in plain text after the full stop, which looked weird.

 I'm not sure if `target="_blank"` is really necessary here. We have a
 similar message without `target="_blank"` in [source:tags/5.2/src/wp-
 includes/functions.php?marks=4769,4781#L4759 _doing_it_wrong()], so I
 thought it would make sense to follow the same approach here, since the
 message is generally displayed in a context where Dashicons and `.screen-
 reader-text` styles are not available.

 We could probably add them to `_default_wp_die_handler()` if you think
 it's necessary.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47681#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform