[wp-trac] [WordPress Trac] #45785: Update to Underscore 1.9.1

[WordPress Trac]

#45785: Update to Underscore 1.9.1
-------------------------------------------+-----------------------------
 Reporter:  mukesh27                       |       Owner:  desrosj
     Type:  enhancement                    |      Status:  reopened
 Priority:  normal                         |   Milestone:  Future Release
Component:  External Libraries             |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  has-patch early needs-testing  |     Focuses:
-------------------------------------------+-----------------------------
Changes (by desrosj):

 * keywords:  has-patch early commit => has-patch early needs-testing
 * milestone:  5.3 => Future Release


Comment:

 I looked at this a bit today. The `_.debounce()` function invokes
 `_.delay()` with 4 arguments, but that function appears to only accept 3
 arguments. Removing `this` from this
 [https://github.com/jashkenas/underscore/blob/1.9.1/underscore.js#L902
 line in Underscore] fixes the problem. It's strange that only one are two
 tests are failing (and with inconsistent messages), but all of the front
 end functionality seems to be working as best I can tell.

 Going to move this to Future Release for now since this is not a pressing
 change. If someone a little more familiar with Underscore is able to
 investigate in time for 5.3, we can move it back. But, it's possible that
 an upstream PR may be needed.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45785#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform