[wp-trac] [WordPress Trac] #47872: Try to create image sub-sizes again when uploading fails with a PHP fatal error

[WordPress Trac]

#47872: Try to create image sub-sizes again when uploading fails with a PHP fatal
error
-------------------------------------------------+-------------------------
 Reporter:  azaozz                               |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  high                                 |   Milestone:  5.3
Component:  Upload                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-dev-   |     Focuses:
  note has-screenshots                           |
-------------------------------------------------+-------------------------
Changes (by afercia):

 * keywords:  has-patch needs-testing needs-dev-note => has-patch needs-
     testing needs-dev-note has-screenshots


Comment:

 @azaozz this one was a nice one to test :)

 Tested on Windows, where it's easier to alter the PHP parameters (VVV uses
 Nginx). In my case, for the first test I had to set `max_execution_time`
 to `1` to make it timeout. Also, to upload images larger than 2 MB, set
 both `upload_max_filesize` and `post_max_size` to `20M` (WP takes the
 smaller of these two values).

 Both tests worked for me, see the requests in the screenshots below.
 However, on `media-new.php` I didn't get any error message (see second
 screenshot).

 Quick questions / considerations:
 - Any objections to expand `2500px` to `2500 pixels`? Because of the way
 `px` is announced by screen readers, see for example
 https://core.trac.wordpress.org/ticket/38932#comment:1
 - all the error `<div>`s would need a `role="alert"`: I guess that can be
 added in one of the many pending tickets to improve the media
 accessibility
 - I see many links `href="#"` and `href='#'` that actually behave like
 buttons. They should be buttons. However, I ''think'' most of them are
 used in the old upload modal. Correct?

 (note: [https://gist.github.com/brasofilo/4570587 this plugin can help in
 testing the Old Upload Method])

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47872#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform