[wp-trac] [WordPress Trac] #47965: Missing strict comparison check in REST Autosaves Controller (was: Missing Yoda Conditions check)

WordPress Trac noreply at wordpress.org
Tue Sep 3 13:18:12 UTC 2019


#47965: Missing strict comparison check in REST Autosaves Controller
--------------------------+------------------------------
 Reporter:  dkarfa        |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  REST API      |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  rest-api
--------------------------+------------------------------

Comment (by TimothyBlynJacobs):

 Thanks for the patch @dkarfa!

 I'm a bit worried about the `$post->post_author === $user_id` check. In
 the type doc it is listed as a string and accompanied by "A numeric
 string, for compatibility reasons."

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47965#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list