[wp-trac] [WordPress Trac] #46881: Site Health: improve the header elements horizontal centering

[WordPress Trac]

#46881: Site Health: improve the header elements horizontal centering
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  5.2.2
Component:  Administration                       |     Version:  5.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots site-health has-     |     Focuses:
  design-feedback has-patch                      |
-------------------------------------------------+-------------------------

Comment (by davidbaumwald):

 Replying to [comment:21 afercia]:
 > [attachment:"46881.diff"] uses `inline-grid`. These two tabs are
 hardcoded, there are no filters and no ways to add more tabs, at least for
 now. This means there are only 2 tabs and we can safely use `grid-
 template-columns: 1fr 1fr;`. If new tabs will be added in the future, we'd
 just need to update this value.
 >
 > Some testing would be nice:
 > - try with different text length
 > - hint: using your browser's dev tools, you can also add a
 `contenteditable` attribute to the tabs and then type longer strings
 directly in the tabs
 > - verify the 2 tabs always have the same width regardless of the text
 length
 > - verify the 2 tabs are always centered in the page
 > - test on Windows with IE 11

 Looks good in Chrome on Windows.

 One other thing to keep in mind that #47225 is milestoned for 5.3 and that
 does add actions to prepend/append the Site Health tabs with additional
 content.  This could be used include more tabs, which would cause wrapping
 due to the grid template(see screenshot).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46881#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform