[wp-trac] [WordPress Trac] #46881: Site Health: improve the header elements horizontal centering

WordPress Trac noreply at wordpress.org
Thu May 30 20:19:08 UTC 2019


#46881: Site Health: improve the header elements horizontal centering
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  5.2.2
Component:  Administration                       |     Version:  5.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots site-health has-     |     Focuses:
  design-feedback needs-patch                    |
-------------------------------------------------+-------------------------

Comment (by afercia):

 [attachment:"46881.diff"] uses `inline-grid`. These two tabs are
 hardcoded, there are no filters and no ways to add more tabs, at least for
 now. This means there are only 2 tabs and we can safely use `grid-
 template-columns: 1fr 1fr;`. If new tabs will be added in the future, we'd
 just need to update this value.

 Some testing would be nice:
 - try with different text length
 - hint: using your browser's dev tools, you can also add a
 `contenteditable` attribute to the tabs and then type longer strings
 directly in the tabs
 - verify the 2 tabs always have the same width regardless of the text
 length
 - verify the 2 tabs are always centered in the page
 - test on Windows with IE 11

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46881#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list