[wp-trac] [WordPress Trac] #47411: Build tools, WPCS: disable line ending check

WordPress Trac noreply at wordpress.org
Tue May 28 15:58:38 UTC 2019


#47411: Build tools, WPCS: disable line ending check
------------------------------+-------------------------------
 Reporter:  azaozz            |       Owner:  azaozz
     Type:  defect (bug)      |      Status:  reopened
 Priority:  normal            |   Milestone:  5.3
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  2nd-opinion       |     Focuses:  coding-standards
------------------------------+-------------------------------
Changes (by johnbillion):

 * keywords:  needs-testing commit => 2nd-opinion
 * status:  closed => reopened
 * focuses:   => coding-standards
 * resolution:  fixed =>


Comment:

 Similar to my comment on [comment:7:ticket:46869], globally overriding one
 of core's coding standards in core signifies that something is wrong with
 the rule and needs to be fixed. Overriding it in core means core doesn't
 adhere to core's own coding standards.

 This change prevents "real" line ending issues from being discovered
 during code sniffing.

 * Does this rule need to be fixed upstream in WPCS?
 * Is there a lower level issue with PHPCS?
 * Is this an issue with the local Git/SVN configuration?
 * How does every other project that uses PHPCS handle this problem?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47411#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list