[wp-trac] [WordPress Trac] #47398: Remove wp_favicon_request

[WordPress Trac]

#47398: Remove wp_favicon_request
----------------------------+-----------------------------
 Reporter:  jonoaldersonwp  |       Owner:  SergeyBiryukov
     Type:  enhancement     |      Status:  reviewing
 Priority:  normal          |   Milestone:  5.3
Component:  Bootstrap/Load  |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch seo   |     Focuses:
----------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * milestone:  Awaiting Review => 5.3


Comment:

 I think a request to `favicon.ico` should be handled the same way as we
 handle `robots.txt` with `do_robots()`:
 * If a physical file exists, do nothing, let the server handle the
 request.
 * Otherwise, serve a fallback icon.

 For the latter:
 * If there's a Site Icon set in Customizer, we can use that.
 * Otherwise, there is a precedence of using `wp-admin/images/w-logo-
 blue.png` in [source:tags/5.2.1/src/wp-
 includes/embed.php?marks=1172,1173#L1162 the_embed_site_title()].

 In [attachment:"47398.2.diff"]:
 * Introduce `is_favicon()` conditional tag to complement `is_robots()`.
 * Introduce `do_favicon()` function to complement `do_robots()` and use it
 in template loader.
 * Introduce `do_faviconico` action to complement `do_robotstxt`, for
 plugins to override the default behavior.
 * Mark `wp_favicon_request()` as deprecated.

 Thoughts?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47398#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform