[wp-trac] [WordPress Trac] #24730: Introduce a timezone-retrieval method

WordPress Trac noreply at wordpress.org
Tue May 28 04:46:42 UTC 2019


#24730: Introduce a timezone-retrieval method
--------------------------------------+-----------------------------
 Reporter:  rmccue                    |       Owner:  SergeyBiryukov
     Type:  enhancement               |      Status:  reviewing
 Priority:  normal                    |   Milestone:  5.3
Component:  Date/Time                 |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+-----------------------------

Comment (by Rarst):

 > When it does not find a match, or when using UTC offset values (like
 +07:30), it will be returned as a string

 I forgot again, but I stuffed string case into unit tests before anyway so
 it works... :)

 > Recommend floor() over (int)

 Floor doesn't work in the way we need on negative values.

 Otherwise patch refreshed with your suggestion.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/24730#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list