[wp-trac] [WordPress Trac] #47048: Nav Menus Admin: Missing Deselect All text when toggling Select All

[WordPress Trac]

#47048: Nav Menus Admin: Missing Deselect All text when toggling Select All
-------------------------------------+-------------------------------------
 Reporter:  birgire                  |       Owner:  audrasjb
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  5.3
Component:  Menus                    |     Version:  3.0
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  ui, accessibility,
  patch dev-feedback                 |  administration
-------------------------------------+-------------------------------------

Comment (by afercia):

 I'm not sure dynamically changing the link (sic) text is the best
 approach. Control names shouldn't change depending on the state and
 ideally there should be one control for one, specific, action.

 Screen reader users, users with cognitive impairments, etc. may struggle
 to understand why a "Select All" control they previously encountered then
 disappears.

 I've noticed there are also a few additional issues. Theoretically, the
 menu page should work also when support for JavaScript is off. That's the
 historical reason why some controls are actually links with URL query
 parameters.

 - disable JS in your browser: the Select All link has a `selectall=1`
 param
 - clicking the link reloads the page and all Posts are selected
 - however, the link is still `selectall=1` so there's no way to deselect
 - theoretically it should change to `selectall=0`
 - however, seems these links don't work correctly anyways
 - clicking Select All for categories and tags doesn't select the
 checkboxes
 - haven't tested with CPTs or custom taxonomies...

 Instead of trying to fix all this, I'd suggest something along these
 lines:
 - consider "Select All" an enhancement available only when JavaScript
 support is enabled
 - at this point, "Select All" could be a checkbox, cons:
   - it's consistent with the pattern for the admin tables
   - it gives a visible and semantic feedback about the selection state
 - the "Select All" checkbox should then be hidden when JS is off using the
 CSS class `hide-if-no-js`

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47048#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform