[wp-trac] [WordPress Trac] #47332: Edit link icon missing in TwentyNineteen(1.4) content-page.php

WordPress Trac noreply at wordpress.org
Tue May 21 19:54:59 UTC 2019


#47332: Edit link icon missing in TwentyNineteen(1.4) content-page.php
------------------------------+---------------------
 Reporter:  ounziw            |       Owner:  (none)
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  5.3
Component:  Bundled Theme     |     Version:
 Severity:  minor             |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+---------------------
Changes (by ianbelanger):

 * keywords:  has-patch => has-patch commit


Comment:

 It appears that the edit icon was added to the `post edit-link` to match
 the rest of the items in the `entry-footer`. `author`, `date` and
 `categories` all have icons. See screenshot below.

 IMO we should add the icon to the `page edit-link` as well, just for
 consistency. [attachment:"47332.diff"] looks like a good solution and
 works well for me, going to mark this for `commit`.

 Thanks for reporting @ounziw and thanks for your patch @mukesh27

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47332#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list