[wp-trac] [WordPress Trac] #47301: Core_Upgrader class not extending or working properly

WordPress Trac noreply at wordpress.org
Mon May 20 01:06:07 UTC 2019


#47301: Core_Upgrader class not extending or working properly
-----------------------------------------------+---------------------------
 Reporter:  techeshta                          |       Owner:  (none)
     Type:  defect (bug)                       |      Status:  new
 Priority:  normal                             |   Milestone:  Awaiting
                                               |  Review
Component:  Upgrade/Install                    |     Version:
 Severity:  normal                             |  Resolution:
 Keywords:  has-screenshots reporter-feedback  |     Focuses:
-----------------------------------------------+---------------------------

Comment (by dd32):

 `Core_Upgrader` is a bit special, in that it doesn't actually contain all
 the upgrade logic, and doesn't utilise the `WP_Upgrader` abstractions and
 niceties other than for the initial bootstrap of the UI.

 Just before it starts coping all files over, `Core_Upgrader` ceases to
 send updates to the `Upgrader_Skin` and instead passes them to the
 `update_feedback` filter in
 [https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes
 /update-core.php#L880 update_core()], you'll have to do some juggling with
 filters and `$skin` to get all the messages in the right order in the
 right place.

 Additionally, upgrades through that method will also trigger HTTP
 redirects to the about page amongst others. You may want to look up how
 the background updates work:
 https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-
 wp-automatic-updater.php#L439

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47301#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list