[wp-trac] [WordPress Trac] #47257: Upgrade node-sass to 4.12

[WordPress Trac]

#47257: Upgrade node-sass to 4.12
------------------------------+---------------------
 Reporter:  desrosj           |       Owner:  (none)
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  5.2.1
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+---------------------

Comment (by aduth):

 I think [attachment:47257.2.diff] is the most reasonable patch. Testing
 again (with latest NPM 6.9.0), I both see (a) no local changes after
 running `npm install` and (b) an identical patch when installing from
 [attachment:47257.diff] (i.e. without the `package-lock.json` changes).
 The changes themselves also seem reasonable vs. [attachment:47257.3.diff]
 where we shouldn't want to flip-flop between `optional` and `dev`
 properties of unaffected modules.

 Related discussion in #core-js Slack earlier today, about specific NPM
 version to be using:
 https://wordpress.slack.com/archives/C5UNMSU4R/p1558022288363200

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47257#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform