[wp-trac] [WordPress Trac] #47244: wp_targeted_link_rel filter should not be applied to 'Custom HTML` widget

WordPress Trac noreply at wordpress.org
Wed May 15 21:18:44 UTC 2019


#47244: wp_targeted_link_rel filter should not be applied to 'Custom HTML` widget
--------------------------------------+-----------------------
 Reporter:  fierevere                 |       Owner:  audrasjb
     Type:  defect (bug)              |      Status:  assigned
 Priority:  high                      |   Milestone:  5.2.1
Component:  Widgets                   |     Version:  5.2
 Severity:  major                     |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+-----------------------
Changes (by birgire):

 * keywords:  has-patch needs-unit-tests => has-patch has-unit-tests


Comment:

 If we go for [attachment:"47244.diff"] in 5.2.1, then
 [attachment:"47244-2.diff"] adjusts the existing and relevant unit test.

 It would be great to fix this through {{{wp_targeted_link_rel()}}}, but I
 guess one could create some difficult Javascript examples that would be
 very hard to handle correctly with a regex in
 {{{wp_targeted_link_rel()}}}.

 So reverting seems like a good workaround for now.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47244#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list