[wp-trac] [WordPress Trac] #47169: Use a non-zero exit code when requirements are not met

WordPress Trac noreply at wordpress.org
Tue May 7 16:37:16 UTC 2019


#47169: Use a non-zero exit code when requirements are not met
-----------------------------------+---------------------
 Reporter:  jrf                    |       Owner:  (none)
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  5.2
Component:  Build/Test Tools       |     Version:  3.0
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+---------------------
Changes (by johnjamesjacoby):

 * milestone:  5.2.1 => 5.2


Comment:

 Related:  #46594.

 `47169-alternative-for-wp-5.2.patch​` seems fine enough for now'ish. I
 agree with @spacedmonkey that ultimately using `wp_die()` would be more
 consistent with other similar fatals. See: `wp_maintenance()`, `wp-
 load.php`, etc...

 If there's a reason not to use `wp_die()`, can you detail what that is
 here @jrf?

 > What impact does this have outside of our own build tooling/testing for
 the near term?

 Technically, nothing yet... but only because none of the code loaded by
 the time this part gets executed contains anything that is version
 specific (beyond the lowest required) that would trigger a fatal error.
 When the day comes there is version-incompatible code, this will need to
 be addressed somehow.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47169#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list