[wp-trac] [WordPress Trac] #46901: 5.2 About Page

WordPress Trac noreply at wordpress.org
Wed May 1 06:34:10 UTC 2019


#46901: 5.2 About Page
---------------------------------------+-------------------------
 Reporter:  desrosj                    |       Owner:  karmatosed
     Type:  task (blessed)             |      Status:  assigned
 Priority:  normal                     |   Milestone:  5.2
Component:  Help/About                 |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:
---------------------------------------+-------------------------

Comment (by kjellr):

 Just a minor heads up in case someone ends up having some time for this:
 Ideally, the Health Check and Error Protection `feature-section`s would be
 using our `two-col` class, and the text inside them would be aligned
 vertically using the flexbox styles for columns that are in the
 stylesheet.

 If someone were to take that on, it's worth noting that for now, the
 columns in those sections are not inheriting our columns styles at all.
 This is because these styles because the columns style rule is written to
 specify `[class$="-col"]`. This looks for a class attribute that ends in
 `-col`. That means the  order of the classnames in the HTML attribute
 matters if we want that style to be picked up. The Health Check and Error
 Protection sections have four total classnames, and their current `one-
 col` class is sandwiched in between the others. If we want to have the
 columns style rules kick in, we'd first need to rearrange the class
 declarations so that the `-col` is at the end. 👍

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46901#comment:37>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list