[wp-trac] [WordPress Trac] #46645: Site health: timeout on the "Info" tab

[WordPress Trac]

#46645: Site health: timeout on the "Info" tab
-----------------------------------+------------------------
 Reporter:  azaozz                 |       Owner:  (none)
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  5.2
Component:  Administration         |     Version:  trunk
 Severity:  normal                 |  Resolution:
 Keywords:  site-health has-patch  |     Focuses:  multisite
-----------------------------------+------------------------

Comment (by jeremyfelt):

 Replying to [comment:6 pento]:
 > [attachment:"46645.diff"] switches to using `get_dirsize()`. Performance
 enhancements should probably land in `get_dirsize()` (related: #19879,
 #26135).
 >
 > @jeremyfelt: Any concerns about making `get_dirsize()` and
 `recurse_dirsize()` available on all sites?

 No concerns here. It's been a good while since I looked at those, but I
 don't think it hurts to have them available everywhere.

 I haven't looked closely yet, but logic may need to be changed to account
 for non-uploads directory checking. The `is_main_site()` check in
 `get_dirsize()` assumes you're looking at an uploads directory and
 excludes `/sites` from recursive checks. This *could* be an issue if (in a
 strange world) a plugin or theme slug was "sites". /shrug

 It does seem like we'll get quick feedback from people running into
 #26135, though I think a timeout makes sense as a first step.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46645#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform